ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.209 by root, Mon Apr 21 06:35:26 2008 UTC vs.
Revision 1.337 by root, Thu May 6 21:45:49 2010 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
25	#include <stdio.h>	26	#include <stdio.h>
26	#include <sys/types.h>	27	#include <sys/types.h>
27	#include <sys/uio.h>	28	#include <sys/uio.h>
28	#include <object.h>	29	#include <object.h>
29	#include <funcpoint.h>
30	#include <sproto.h>	30	#include <sproto.h>
31	#include <loader.h>
32		31
33	#include <bitset>	32	#include <bitset>
34		33
35	UUID UUID::cur;	34	UUID UUID::cur;
36	static uint64_t seq_next_save;	35	static uint64_t seq_next_save;
37	static const uint64 UUID_GAP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
38		38
39	objectvec objects;	39	objectvec objects;
40	activevec actives;	40	activevec actives;
		41
		42	freelist_item *object::freelist;
		43	uint32_t object::object_count;
		44	uint32_t object::free_count;
		45	uint32_t object::create_count;
		46	uint32_t object::destroy_count;
		47
		48	//+GPL
41		49
42	short freearr_x[SIZEOFFREE] = {	50	short freearr_x[SIZEOFFREE] = {
43	0,	51	0,
44	0, 1, 1, 1, 0, -1, -1, -1,	52	0, 1, 1, 1, 0, -1, -1, -1,
45	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	53	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
…		…
49	0,	57	0,
50	-1, -1, 0, 1, 1, 1, 0, -1,	58	-1, -1, 0, 1, 1, 1, 0, -1,
51	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	59	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
52	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	60	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
53	};	61	};
54	int maxfree[SIZEOFFREE] = {
55	0,
56	9, 10, 13, 14, 17, 18, 21, 22,
57	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
58	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
59	};
60	int freedir[SIZEOFFREE] = {	62	int freedir[SIZEOFFREE] = {
61	0,	63	0,
62	1, 2, 3, 4, 5, 6, 7, 8,	64	1, 2, 3, 4, 5, 6, 7, 8,
63	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	65	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
64	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	66	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
65	};	67	};
66		68
		69	static int maxfree[SIZEOFFREE] = {
		70	0,
		71	9, 10, 13, 14, 17, 18, 21, 22,
		72	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
		73	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
		74	};
		75
67	static void	76	static void
68	write_uuid (uval64 skip, bool sync)	77	write_uuid (uval64 skip, bool sync)
69	{	78	{
70	CALL_BEGIN (2);	79	CALL_BEGIN (2);
71	CALL_ARG_SV (newSVval64 (skip));	80	CALL_ARG_SV (newSVval64 (skip));
…		…
73	CALL_CALL ("cf::write_uuid", G_DISCARD);	82	CALL_CALL ("cf::write_uuid", G_DISCARD);
74	CALL_END;	83	CALL_END;
75	}	84	}
76		85
77	static void	86	static void
78	read_uuid (void)	87	read_uuid ()
79	{	88	{
80	char filename[MAX_BUF];	89	char filename[MAX_BUF];
81		90
82	sprintf (filename, "%s/uuid", settings.localdir);	91	sprintf (filename, "%s/uuid", settings.localdir);
83		92
…		…
97		106
98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	107	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
99	_exit (1);	108	_exit (1);
100	}	109	}
101		110
102	UUID::BUF buf;	111	char buf [UUID::MAX_LEN];
103	buf[0] = 0;	112	buf[0] = 0;
104	fgets (buf, sizeof (buf), fp);	113	fgets (buf, sizeof (buf), fp);
105		114
106	if (!UUID::cur.parse (buf))	115	if (!UUID::cur.parse (buf))
107	{	116	{
…		…
134		143
135	void	144	void
136	UUID::init ()	145	UUID::init ()
137	{	146	{
138	read_uuid ();	147	read_uuid ();
		148	}
		149
		150	bool
		151	UUID::parse (const char *s)
		152	{
		153	if (*s++ != '<' || *s++ != '1' || *s++ != '.')
		154	return false;
		155
		156	seq = 0;
		157
		158	while (*s != '>')
		159	{
		160	if (*s < '0')
		161	return false;
		162
		163	// this gives nice branchless code with gcc
		164	assert ('0' < 'a' && '0' == 48 && 'a' == 97);
		165	int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
		166
		167	seq = (seq << 4) | digit;
		168
		169	++s;
		170	}
		171
		172	return true;
		173	}
		174
		175	char *
		176	UUID::append (char *buf) const
		177	{
		178	*buf++ = '<';
		179	*buf++ = '1';
		180	*buf++ = '.';
		181
		182	uint64_t seq = this->seq;
		183	const int bits = 64;
		184	char nz = 0;
		185	static const char tohex [] = "0123456789abcdef";
		186
		187	// assert (len >= 3 + bits / 4 + 1 + 1);
		188	for (int i = bits / 4; --i; )
		189	{
		190	uint8_t digit = seq >> (bits - 4);
		191
		192	*buf = tohex [digit];
		193	nz |= digit;
		194	buf += nz ? 1 : 0;
		195	seq <<= 4;
		196	}
		197
		198	// last digit is special - always emit
		199	uint8_t digit = seq >> (bits - 4);
		200	*buf++ = tohex [digit];
		201
		202	*buf++ = '>';
		203
		204	return buf;
		205	}
		206
		207	char *
		208	UUID::c_str () const
		209	{
		210	static char buf [MAX_LEN];
		211	*append (buf) = 0;
		212	return buf;
139	}	213	}
140		214
141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	215	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
142	static bool	216	static bool
143	compare_ob_value_lists_one (const object *wants, const object *has)	217	compare_ob_value_lists_one (const object *wants, const object *has)
144	{	218	{
145	key_value *wants_field;
146
147	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	219	/* n-squared behaviour (see kv_get), but I'm hoping both
148	* objects with lists are rare, and lists stay short. If not, use a	220	* objects with lists are rare, and lists stay short. If not, use a
149	* different structure or at least keep the lists sorted...	221	* different structure or at least keep the lists sorted...
150	*/	222	*/
151		223
152	/* For each field in wants, */	224	/* For each field in wants, */
153	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	225	for (key_value *kv = wants->key_values; kv; kv = kv->next)
154	{	226	if (has->kv_get (kv->key) != kv->value)
155	key_value *has_field;	227	return false;
156
157	/* Look for a field in has with the same key. */
158	has_field = get_ob_key_link (has, wants_field->key);
159
160	if (!has_field)
161	return 0; /* No field with that name. */
162
163	/* Found the matching field. */
164	if (has_field->value != wants_field->value)
165	return 0; /* Values don't match, so this half of the comparison is false. */
166
167	/* If we get here, we found a match. Now for the next field in wants. */
168	}
169		228
170	/* If we get here, every field in wants has a matching field in has. */	229	/* If we get here, every field in wants has a matching field in has. */
171	return 1;	230	return true;
172	}	231	}
173		232
174	/* Returns TRUE if ob1 has the same key_values as ob2. */	233	/* Returns TRUE if ob1 has the same key_values as ob2. */
175	static bool	234	static bool
176	compare_ob_value_lists (const object *ob1, const object *ob2)	235	compare_ob_value_lists (const object *ob1, const object *ob2)
177	{	236	{
178	/* However, there may be fields in has which aren't partnered in wants,	237	/* However, there may be fields in has which aren't partnered in wants,
179	* so we need to run the comparison *twice*. :(	238	* so we need to run the comparison *twice*. :(
180	*/	239	*/
181	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	240	return compare_ob_value_lists_one (ob1, ob2)
		241	&& compare_ob_value_lists_one (ob2, ob1);
182	}	242	}
183		243
184	/* Function examines the 2 objects given to it, and returns true if	244	/* Function examines the 2 objects given to it, and returns true if
185	* they can be merged together.	245	* they can be merged together.
186	*	246	*
…		…
193	* Improvements made with merge: Better checking on potion, and also	253	* Improvements made with merge: Better checking on potion, and also
194	* check weight	254	* check weight
195	*/	255	*/
196	bool object::can_merge_slow (object *ob1, object *ob2)	256	bool object::can_merge_slow (object *ob1, object *ob2)
197	{	257	{
198	/* A couple quicksanity checks */	258	/* A couple quick sanity checks */
199	if (ob1 == ob2	259	if (ob1 == ob2
200	|| ob1->type != ob2->type	260	|| ob1->type != ob2->type
201	|| ob1->speed != ob2->speed
202	|| ob1->value != ob2->value	261	|| ob1->value != ob2->value
203	|| ob1->name != ob2->name)	262	|| ob1->name != ob2->name
		263	|| fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
204	return 0;	264	return 0;
205		265
206	/* Do not merge objects if nrof would overflow. First part checks	266	/* Do not merge objects if nrof would overflow, assume nrof
207	* for unsigned overflow (2c), second part checks whether the result	267	* is always 0 .. 2**31-1 */
208	* would fit into a 32 bit signed int, which is often used to hold	268	if (ob1->nrof > 0x7fffffff - ob2->nrof)
209	* nrof values.
210	*/
211	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
212	return 0;	269	return 0;
213		270
214	/* If the objects have been identified, set the BEEN_APPLIED flag.	271	/* If the objects have been identified, set the BEEN_APPLIED flag.
215	* This is to the comparison of the flags below will be OK. We	272	* This is to the comparison of the flags below will be OK. We
216	* just can't ignore the been applied or identified flags, as they	273	* just can't ignore the been applied or identified flags, as they
217	* are not equal - just if it has been identified, the been_applied	274	* are not equal - just if it has been identified, the been_applied
218	* flags lose any meaning.	275	* flags lose any meaning.
219	*/	276	*/
220	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	277	if (ob1->flag [FLAG_IDENTIFIED])
221	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	278	ob1->set_flag (FLAG_BEEN_APPLIED);
222		279
223	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	280	if (ob2->flag [FLAG_IDENTIFIED])
224	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	281	ob2->set_flag (FLAG_BEEN_APPLIED);
225		282
226	if (ob1->arch->name != ob2->arch->name	283	if (ob1->arch->archname != ob2->arch->archname
227	|| ob1->name != ob2->name	284	|| ob1->name != ob2->name
228	|| ob1->title != ob2->title	285	|| ob1->title != ob2->title
229	|| ob1->msg != ob2->msg	286	|| ob1->msg != ob2->msg
230	|| ob1->weight != ob2->weight	287	|| ob1->weight != ob2->weight
231	|| ob1->attacktype != ob2->attacktype	288	|| ob1->attacktype != ob2->attacktype
232	|| ob1->magic != ob2->magic	289	|| ob1->magic != ob2->magic
233	|| ob1->slaying != ob2->slaying	290	|| ob1->slaying != ob2->slaying
234	|| ob1->skill != ob2->skill	291	|| ob1->skill != ob2->skill
235	|| ob1->value != ob2->value	292	|| ob1->value != ob2->value
236	|| ob1->animation_id != ob2->animation_id	293	|| ob1->animation_id != ob2->animation_id
		294	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
237	|| ob1->client_type != ob2->client_type	295	|| ob1->client_type != ob2->client_type
238	|| ob1->materialname != ob2->materialname	296	|| ob1->material != ob2->material
239	|| ob1->lore != ob2->lore	297	|| ob1->lore != ob2->lore
240	|| ob1->subtype != ob2->subtype	298	|| ob1->subtype != ob2->subtype
241	|| ob1->move_type != ob2->move_type	299	|| ob1->move_type != ob2->move_type
242	|| ob1->move_block != ob2->move_block	300	|| ob1->move_block != ob2->move_block
243	|| ob1->move_allow != ob2->move_allow	301	|| ob1->move_allow != ob2->move_allow
244	|| ob1->move_on != ob2->move_on	302	|| ob1->move_on != ob2->move_on
245	|| ob1->move_off != ob2->move_off	303	|| ob1->move_off != ob2->move_off
246	|| ob1->move_slow != ob2->move_slow	304	|| ob1->move_slow != ob2->move_slow
247	|| ob1->move_slow_penalty != ob2->move_slow_penalty	305	|| fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
248	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))	306	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
249	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	307	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
250	return 0;	308	return 0;
251		309
252	if ((ob1->flag ^ ob2->flag)	310	if ((ob1->flag ^ ob2->flag)
253	.reset (FLAG_INV_LOCKED)	311	.reset (FLAG_INV_LOCKED)
254	.reset (FLAG_CLIENT_SENT)
255	.reset (FLAG_REMOVED)	312	.reset (FLAG_REMOVED)
256	.any ())	313	.any ())
257	return 0;	314	return 0;
258		315
259	/* This is really a spellbook check - we should in general	316	/* This is really a spellbook check - we should in general
…		…
278		335
279	/* Don't merge objects that are applied. With the new 'body' code,	336	/* Don't merge objects that are applied. With the new 'body' code,
280	* it is possible for most any character to have more than one of	337	* it is possible for most any character to have more than one of
281	* some items equipped, and we don't want those to merge.	338	* some items equipped, and we don't want those to merge.
282	*/	339	*/
283	if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED))	340	if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
284	return 0;	341	return 0;
285		342
286	/* Note sure why the following is the case - either the object has to	343	/* Note sure why the following is the case - either the object has to
287	* be animated or have a very low speed. Is this an attempted monster	344	* be animated or have a very low speed. Is this an attempted monster
288	* check?	345	* check?
289	*/	346	*/
290	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())	347	if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
291	return 0;	348	return 0;
292		349
293	switch (ob1->type)	350	switch (ob1->type)
294	{	351	{
295	case SCROLL:	352	case SCROLL:
…		…
331		388
332	/* Everything passes, must be OK. */	389	/* Everything passes, must be OK. */
333	return 1;	390	return 1;
334	}	391	}
335		392
		393	// find player who can see this object
		394	object *
		395	object::visible_to () const
		396	{
		397	if (client_visible () && !flag [FLAG_REMOVED])
		398	{
		399	// see if we are in a container of sorts
		400	if (env)
		401	{
		402	// the player inventory itself is always visible
		403	if (env->is_player ())
		404	return env;
		405
		406	// else a player could have our env open
		407	object *envest = env->outer_env_or_self ();
		408
		409	// the player itself is always on a map, so we will find him here
		410	// even if our inv is in a player.
		411	if (envest->is_on_map ())
		412	if (object *pl = envest->ms ().player ())
		413	if (pl->container_ () == env)
		414	return pl;
		415	}
		416	else
		417	{
		418	// maybe there is a player standing on the same mapspace
		419	// this will catch the case where "this" is a player
		420	if (object *pl = ms ().player ())
		421	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		422	|| pl->container_ () == this)
		423	return pl;
		424	}
		425	}
		426
		427	return 0;
		428	}
		429
336	// adjust weight per container type ("of holding")	430	// adjust weight per container type ("of holding")
337	static sint32	431	static uint32
338	weight_adjust (object *op, sint32 weight)	432	weight_adjust_for (object *op, uint32 weight)
339	{	433	{
340	return op->type == CONTAINER	434	return op->type == CONTAINER
341	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	435	? weight - weight * op->stats.Str / 100
342	: weight;	436	: weight;
343	}	437	}
344		438
345	/*	439	/*
346	* adjust_weight(object, weight) adds the specified weight to an object,	440	* subtracts, then adds, the specified weight to an object,
347	* and also updates how much the environment(s) is/are carrying.	441	* and also updates how much the environment(s) is/are carrying.
348	*/	442	*/
349	static void	443	static void
350	adjust_weight (object *op, sint32 weight)	444	adjust_weight (object *op, sint32 sub, sint32 add)
351	{	445	{
352	while (op)	446	while (op)
353	{	447	{
354	weight = weight_adjust (op, weight);	448	sint32 ocarrying = op->carrying;
355		449
356	op->carrying += weight;	450	op->carrying -= weight_adjust_for (op, sub);
		451	op->carrying += weight_adjust_for (op, add);
		452
		453	if (object *pl = op->visible_to ())
		454	if (pl != op) // player is handled lazily
		455	esrv_update_item (UPD_WEIGHT, pl, op);
		456
		457	sub = ocarrying;
		458	add = op->carrying;
		459
357	op = op->env;	460	op = op->env;
358	}	461	}
359	}	462	}
360		463
361	/*	464	/*
…		…
368	{	471	{
369	sint32 sum = 0;	472	sint32 sum = 0;
370		473
371	for (object *op = inv; op; op = op->below)	474	for (object *op = inv; op; op = op->below)
372	{	475	{
373	if (op->inv)
374	op->update_weight ();	476	op->update_weight ();
375		477
376	sum += op->total_weight ();	478	sum += weight_adjust_for (this, op->total_weight ());
		479	}
		480
		481	if (sum != carrying)
377	}	482	{
		483	if (carrying != sum && carrying)//D
		484	LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
		485	(long long)sum, (long long)carrying, debug_desc ());
378		486
379	carrying = weight_adjust (this, sum);	487	carrying = sum;
		488
		489	if (object *pl = visible_to ())
		490	if (pl != this) // player is handled lazily
		491	esrv_update_item (UPD_WEIGHT, pl, this);
		492	}
380	}	493	}
381		494
382	/*	495	/*
383	* Used by: Server DM commands: dumpbelow, dump. Some error messages.	496	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
384	*/	497	*/
…		…
391	object_freezer freezer;	504	object_freezer freezer;
392	op->write (freezer);	505	op->write (freezer);
393	return freezer.as_string ();	506	return freezer.as_string ();
394	}	507	}
395		508
396	/*	509	char *
397	* get_nearest_part(multi-object, object 2) returns the part of the	510	object::as_string ()
398	* multi-object 1 which is closest to the second object.
399	* If it's not a multi-object, it is returned.
400	*/
401	object *
402	get_nearest_part (object *op, const object *pl)
403	{	511	{
404	object *tmp, *closest;	512	return dump_object (this);
405	int last_dist, i;
406
407	if (!op->more)
408	return op;
409
410	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
411	tmp;
412	tmp = tmp->more)
413	if ((i = distance (tmp, pl)) < last_dist)
414	closest = tmp, last_dist = i;
415
416	return closest;
417	}	513	}
418		514
419	/*	515	/*
420	* Returns the object which has the count-variable equal to the argument.	516	* Returns the object which has the count-variable equal to the argument.
421	* VERRRY slow.	517	* VERRRY slow.
…		…
429		525
430	return 0;	526	return 0;
431	}	527	}
432		528
433	/*	529	/*
		530	* Returns the object which has the uuid equal to the argument.
		531	* MOAR VERRRY slow.
		532	*/
		533
		534	object *
		535	find_object_uuid (UUID i)
		536	{
		537	for_all_objects (op)
		538	if (op->uuid == i)
		539	return op;
		540
		541	return 0;
		542	}
		543
		544	/*
434	* Returns the first object which has a name equal to the argument.	545	* Returns the first object which has a name equal to the argument.
435	* Used only by the patch command, but not all that useful.	546	* Used only by the patch command, but not all that useful.
436	* Enables features like "patch <name-of-other-player> food 999"	547	* Enables features like "patch <name-of-other-player> food 999"
437	*/	548	*/
438	object *	549	object *
439	find_object_name (const char *str)	550	find_object_name (const char *str)
440	{	551	{
441	shstr_cmp str_ (str);	552	shstr_cmp str_ (str);
442	object *op;
443		553
		554	if (str_)
444	for_all_objects (op)	555	for_all_objects (op)
445	if (op->name == str_)	556	if (op->name == str_)
446	break;	557	return op;
447		558
448	return op;	559	return 0;
449	}	560	}
450		561
451	/*	562	/*
452	* Sets the owner and sets the skill and exp pointers to owner's current	563	* Sets the owner and sets the skill and exp pointers to owner's current
453	* skill and experience objects.	564	* skill and experience objects.
…		…
468	}	579	}
469		580
470	this->owner = owner;	581	this->owner = owner;
471	}	582	}
472		583
473	int
474	object::slottype () const
475	{
476	if (type == SKILL)
477	{
478	if (IS_COMBAT_SKILL (subtype)) return slot_combat;
479	if (IS_RANGED_SKILL (subtype)) return slot_ranged;
480	}
481	else
482	{
483	if (slot [body_combat].info) return slot_combat;
484	if (slot [body_range ].info) return slot_ranged;
485	}
486
487	return slot_none;
488	}
489
490	bool
491	object::change_weapon (object *ob)
492	{
493	if (current_weapon == ob)
494	return true;
495
496	if (chosen_skill)
497	chosen_skill->flag [FLAG_APPLIED] = false;
498
499	current_weapon = ob;
500	chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
501
502	if (chosen_skill)
503	chosen_skill->flag [FLAG_APPLIED] = true;
504
505	update_stats ();
506
507	if (ob)
508	{
509	// now check wether any body locations became invalid, in which case
510	// we cannot apply the weapon at the moment.
511	for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
512	if (slot[i].used < 0)
513	{
514	current_weapon = chosen_skill = 0;
515	update_stats ();
516
517	new_draw_info_format (NDI_UNIQUE, 0, this,
518	"You try to balance all your items at once, "
519	"but the %s is just too much for your body. "
520	"[You need to unapply some items first.]", &ob->name);
521	return false;
522	}
523
524	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
525	}
526	else
527	;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
528
529	if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
530	{
531	LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
532	&name, ob->debug_desc ());
533	return false;
534	}
535
536	return true;
537	}
538
539	/* Zero the key_values on op, decrementing the shared-string	584	/* Zero the key_values on op, decrementing the shared-string
540	* refcounts and freeing the links.	585	* refcounts and freeing the links.
541	*/	586	*/
542	static void	587	static void
543	free_key_values (object *op)	588	free_key_values (object *op)
…		…
551	}	596	}
552		597
553	op->key_values = 0;	598	op->key_values = 0;
554	}	599	}
555		600
556	object &	601	/*
557	object::operator =(const object &src)	602	* copy_to first frees everything allocated by the dst object,
		603	* and then copies the contents of itself into the second
		604	* object, allocating what needs to be allocated. Basically, any
		605	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		606	* if the first object is freed, the pointers in the new object
		607	* will point at garbage.
		608	*/
		609	void
		610	object::copy_to (object *dst)
558	{	611	{
559	bool is_freed = flag [FLAG_FREED];	612	dst->remove ();
560	bool is_removed = flag [FLAG_REMOVED];
561
562	*(object_copy *)this = src;	613	*(object_copy *)dst = *this;
563
564	flag [FLAG_FREED] = is_freed;
565	flag [FLAG_REMOVED] = is_removed;	614	dst->flag [FLAG_REMOVED] = true;
566		615
567	/* Copy over key_values, if any. */	616	/* Copy over key_values, if any. */
568	if (src.key_values)	617	if (key_values)
569	{	618	{
570	key_value *tail = 0;	619	key_value *tail = 0;
571	key_values = 0;	620	dst->key_values = 0;
572		621
573	for (key_value *i = src.key_values; i; i = i->next)	622	for (key_value *i = key_values; i; i = i->next)
574	{	623	{
575	key_value *new_link = new key_value;	624	key_value *new_link = new key_value;
576		625
577	new_link->next = 0;	626	new_link->next = 0;
578	new_link->key = i->key;	627	new_link->key = i->key;
579	new_link->value = i->value;	628	new_link->value = i->value;
580		629
581	/* Try and be clever here, too. */	630	/* Try and be clever here, too. */
582	if (!key_values)	631	if (!dst->key_values)
583	{	632	{
584	key_values = new_link;	633	dst->key_values = new_link;
585	tail = new_link;	634	tail = new_link;
586	}	635	}
587	else	636	else
588	{	637	{
589	tail->next = new_link;	638	tail->next = new_link;
590	tail = new_link;	639	tail = new_link;
591	}	640	}
592	}	641	}
593	}	642	}
594	}
595		643
596	/*	644	dst->activate ();
597	* copy_to first frees everything allocated by the dst object,
598	* and then copies the contents of itself into the second
599	* object, allocating what needs to be allocated. Basically, any
600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
601	* if the first object is freed, the pointers in the new object
602	* will point at garbage.
603	*/
604	void
605	object::copy_to (object *dst)
606	{
607	*dst = *this;
608
609	if (speed < 0)
610	dst->speed_left -= rndm ();
611
612	dst->set_speed (dst->speed);
613	}	645	}
614		646
615	void	647	void
616	object::instantiate ()	648	object::instantiate ()
617	{	649	{
618	if (!uuid.seq) // HACK	650	if (!uuid.seq) // HACK
619	uuid = UUID::gen ();	651	uuid = UUID::gen ();
620		652
		653	// TODO: unclean state changes, should nt be done in copy_to AND instantiate
		654	if (flag [FLAG_RANDOM_SPEED] && speed)
		655	speed_left = - speed - rndm (); // TODO animation
		656	else
621	speed_left = -0.1f;	657	speed_left = -1.;
		658
622	/* copy the body_info to the body_used - this is only really	659	/* copy the body_info to the body_used - this is only really
623	* need for monsters, but doesn't hurt to do it for everything.	660	* need for monsters, but doesn't hurt to do it for everything.
624	* by doing so, when a monster is created, it has good starting	661	* by doing so, when a monster is created, it has good starting
625	* values for the body_used info, so when items are created	662	* values for the body_used info, so when items are created
626	* for it, they can be properly equipped.	663	* for it, they can be properly equipped.
…		…
634	object *	671	object *
635	object::clone ()	672	object::clone ()
636	{	673	{
637	object *neu = create ();	674	object *neu = create ();
638	copy_to (neu);	675	copy_to (neu);
		676
		677	// TODO: unclean state changes, should not be done in clone AND instantiate
		678	if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
		679	neu->speed_left = - neu->speed - rndm (); // TODO animation
		680
		681	neu->map = map; // not copied by copy_to
639	return neu;	682	return neu;
640	}	683	}
641		684
642	/*	685	/*
643	* If an object with the IS_TURNABLE() flag needs to be turned due	686	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
645	* be called to update the face variable, _and_ how it looks on the map.	688	* be called to update the face variable, _and_ how it looks on the map.
646	*/	689	*/
647	void	690	void
648	update_turn_face (object *op)	691	update_turn_face (object *op)
649	{	692	{
650	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)	693	if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
651	return;	694	return;
652		695
653	SET_ANIMATION (op, op->direction);	696	SET_ANIMATION (op, op->direction);
654	update_object (op, UP_OBJ_FACE);	697	update_object (op, UP_OBJ_FACE);
655	}	698	}
…		…
660	* This function needs to be called whenever the speed of an object changes.	703	* This function needs to be called whenever the speed of an object changes.
661	*/	704	*/
662	void	705	void
663	object::set_speed (float speed)	706	object::set_speed (float speed)
664	{	707	{
665	if (flag [FLAG_FREED] && speed)
666	{
667	LOG (llevError, "Object %s is freed but has speed.\n", &name);
668	speed = 0;
669	}
670
671	this->speed = speed;	708	this->speed = speed;
672		709
673	if (has_active_speed ())	710	if (has_active_speed ())
674	activate ();	711	activate ();
675	else	712	else
…		…
694	* UP_OBJ_FACE: only the objects face has changed.	731	* UP_OBJ_FACE: only the objects face has changed.
695	*/	732	*/
696	void	733	void
697	update_object (object *op, int action)	734	update_object (object *op, int action)
698	{	735	{
699	if (op == NULL)	736	if (!op)
700	{	737	{
701	/* this should never happen */	738	/* this should never happen */
702	LOG (llevDebug, "update_object() called for NULL object.\n");	739	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
703	return;	740	return;
704	}	741	}
705		742
706	if (op->env)	743	if (!op->is_on_map ())
707	{	744	{
708	/* Animation is currently handled by client, so nothing	745	/* Animation is currently handled by client, so nothing
709	* to do in this case.	746	* to do in this case.
710	*/	747	*/
711	return;	748	return;
712	}	749	}
713
714	/* If the map is saving, don't do anything as everything is
715	* going to get freed anyways.
716	*/
717	if (!op->map || op->map->in_memory == MAP_SAVING)
718	return;
719		750
720	/* make sure the object is within map boundaries */	751	/* make sure the object is within map boundaries */
721	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	752	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
722	{	753	{
723	LOG (llevError, "update_object() called for object out of map!\n");	754	LOG (llevError, "update_object() called for object out of map!\n");
…		…
731		762
732	if (!(m.flags_ & P_UPTODATE))	763	if (!(m.flags_ & P_UPTODATE))
733	/* nop */;	764	/* nop */;
734	else if (action == UP_OBJ_INSERT)	765	else if (action == UP_OBJ_INSERT)
735	{	766	{
		767	#if 0
736	// this is likely overkill, TODO: revisit (schmorp)	768	// this is likely overkill, TODO: revisit (schmorp)
737	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	769	if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
738	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	770	|| (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
739	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	771	|| (op->is_player () && !(m.flags_ & P_PLAYER))
740	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	772	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
741	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	773	|| (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
742	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	774	|| (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
743	|| (m.move_on | op->move_on ) != m.move_on	775	|| (m.move_on | op->move_on ) != m.move_on
744	|| (m.move_off | op->move_off ) != m.move_off	776	|| (m.move_off | op->move_off ) != m.move_off
745	|| (m.move_slow | op->move_slow) != m.move_slow	777	|| (m.move_slow | op->move_slow) != m.move_slow
746	/* This isn't perfect, but I don't expect a lot of objects to	778	/* This isn't perfect, but I don't expect a lot of objects to
747	* to have move_allow right now.	779	* have move_allow right now.
748	*/	780	*/
749	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	781	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
		782	m.invalidate ();
		783	#else
750	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	784	// the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
751	m.flags_ = 0;	785	m.invalidate ();
		786	#endif
752	}	787	}
753	/* if the object is being removed, we can't make intelligent	788	/* if the object is being removed, we can't make intelligent
754	* decisions, because remove_ob can't really pass the object	789	* decisions, because remove_ob can't really pass the object
755	* that is being removed.	790	* that is being removed.
756	*/	791	*/
757	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	792	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
758	m.flags_ = 0;	793	m.invalidate ();
759	else if (action == UP_OBJ_FACE)	794	else if (action == UP_OBJ_FACE)
760	/* Nothing to do for that case */ ;	795	/* Nothing to do for that case */ ;
761	else	796	else
762	LOG (llevError, "update_object called with invalid action: %d\n", action);	797	LOG (llevError, "update_object called with invalid action: %d\n", action);
763		798
…		…
765	update_object (op->more, action);	800	update_object (op->more, action);
766	}	801	}
767		802
768	object::object ()	803	object::object ()
769	{	804	{
770	SET_FLAG (this, FLAG_REMOVED);	805	this->set_flag (FLAG_REMOVED);
771		806
772	expmul = 1.0;	807	//expmul = 1.0; declared const for the time being
773	face = blank_face;	808	face = blank_face;
		809	material = MATERIAL_NULL;
774	}	810	}
775		811
776	object::~object ()	812	object::~object ()
777	{	813	{
778	unlink ();	814	unlink ();
779		815
780	free_key_values (this);	816	free_key_values (this);
781	}	817	}
782
783	static int object_count;
784		818
785	void object::link ()	819	void object::link ()
786	{	820	{
787	assert (!index);//D	821	assert (!index);//D
788	uuid = UUID::gen ();	822	uuid = UUID::gen ();
789	count = ++object_count;
790		823
791	refcnt_inc ();	824	refcnt_inc ();
792	objects.insert (this);	825	objects.insert (this);
		826
		827	++create_count;
		828
793	}	829	}
794		830
795	void object::unlink ()	831	void object::unlink ()
796	{	832	{
797	if (!index)	833	if (!index)
798	return;	834	return;
		835
		836	++destroy_count;
799		837
800	objects.erase (this);	838	objects.erase (this);
801	refcnt_dec ();	839	refcnt_dec ();
802	}	840	}
803		841
…		…
807	/* If already on active list, don't do anything */	845	/* If already on active list, don't do anything */
808	if (active)	846	if (active)
809	return;	847	return;
810		848
811	if (has_active_speed ())	849	if (has_active_speed ())
		850	{
		851	if (flag [FLAG_FREED])
		852	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		853
812	actives.insert (this);	854	actives.insert (this);
		855	}
813	}	856	}
814		857
815	void	858	void
816	object::activate_recursive ()	859	object::activate_recursive ()
817	{	860	{
…		…
866	object::destroy_inv (bool drop_to_ground)	909	object::destroy_inv (bool drop_to_ground)
867	{	910	{
868	// need to check first, because the checks below might segfault	911	// need to check first, because the checks below might segfault
869	// as we might be on an invalid mapspace and crossfire code	912	// as we might be on an invalid mapspace and crossfire code
870	// is too buggy to ensure that the inventory is empty.	913	// is too buggy to ensure that the inventory is empty.
871	// corollary: if you create arrows etc. with stuff in tis inventory,	914	// corollary: if you create arrows etc. with stuff in its inventory,
872	// cf will crash below with off-map x and y	915	// cf will crash below with off-map x and y
873	if (!inv)	916	if (!inv)
874	return;	917	return;
875		918
876	/* Only if the space blocks everything do we not process -	919	/* Only if the space blocks everything do we not process -
…		…
878	* drop on that space.	921	* drop on that space.
879	*/	922	*/
880	if (!drop_to_ground	923	if (!drop_to_ground
881	|| !map	924	|| !map
882	|| map->in_memory != MAP_ACTIVE	925	|| map->in_memory != MAP_ACTIVE
883	|| map->nodrop	926	|| map->no_drop
884	|| ms ().move_block == MOVE_ALL)	927	|| ms ().move_block == MOVE_ALL)
885	{	928	{
886	while (inv)	929	while (inv)
887	{
888	inv->destroy_inv (drop_to_ground);
889	inv->destroy ();	930	inv->destroy ();
890	}
891	}	931	}
892	else	932	else
893	{ /* Put objects in inventory onto this space */	933	{ /* Put objects in inventory onto this space */
894	while (inv)	934	while (inv)
895	{	935	{
…		…
906	map->insert (op, x, y);	946	map->insert (op, x, y);
907	}	947	}
908	}	948	}
909	}	949	}
910		950
		951	/*
		952	* Remove and free all objects in the inventory of the given object.
		953	* Unlike destroy_inv, this assumes the *this is destroyed as well
		954	* well, so we can (and have to!) take shortcuts.
		955	*/
		956	void
		957	object::destroy_inv_fast ()
		958	{
		959	while (object *op = inv)
		960	{
		961	// remove from object the fast way
		962	op->flag [FLAG_REMOVED] = true;
		963	op->env = 0;
		964	if ((inv = inv->below))
		965	inv->above = 0;
		966
		967	// then destroy
		968	op->destroy ();
		969	}
		970	}
		971
		972	void
		973	object::freelist_free (int count)
		974	{
		975	while (count-- && freelist)
		976	{
		977	freelist_item *next = freelist->next;
		978	// count is being "destroyed"
		979
		980	sfree ((char *)freelist, sizeof (object));
		981
		982	freelist = next;
		983	--free_count;
		984	}
		985	}
		986
		987	object *
911	object *object::create ()	988	object::create ()
912	{	989	{
913	object *op = new object;	990	object *op;
		991
		992	if (freelist)
		993	{
		994	freelist_item li = *freelist;
		995	memset (freelist, 0, sizeof (object));
		996
		997	op = new (freelist) object;
		998	op->count = li.count;
		999
		1000	freelist = li.next;
		1001	--free_count;
		1002	}
		1003	else
		1004	{
		1005	void *ni = salloc0<char> (sizeof (object));
		1006
		1007	op = new(ni) object;
		1008
		1009	op->count = ++object_count;
		1010	}
		1011
914	op->link ();	1012	op->link ();
		1013
915	return op;	1014	return op;
916	}	1015	}
917		1016
918	void	1017	void
		1018	object::do_delete ()
		1019	{
		1020	uint32_t count = this->count;
		1021
		1022	this->~object ();
		1023
		1024	freelist_item *li = (freelist_item *)this;
		1025	li->next = freelist;
		1026	li->count = count;
		1027
		1028	freelist = li;
		1029	++free_count;
		1030	}
		1031
		1032	static struct freed_map : maptile
		1033	{
		1034	freed_map ()
		1035	: maptile (3, 3)
		1036	{
		1037	path = "<freed objects map>";
		1038	name = "/internal/freed_objects_map";
		1039	no_drop = 1;
		1040	no_reset = 1;
		1041
		1042	in_memory = MAP_ACTIVE;
		1043	}
		1044
		1045	~freed_map ()
		1046	{
		1047	destroy ();
		1048	}
		1049	} freed_map; // freed objects are moved here to avoid crashes
		1050
		1051	void
919	object::do_destroy ()	1052	object::do_destroy ()
920	{	1053	{
921	attachable::do_destroy ();
922
923	if (flag [FLAG_IS_LINKED])	1054	if (flag [FLAG_IS_LINKED])
924	remove_button_link (this);	1055	remove_link ();
925		1056
926	if (flag [FLAG_FRIENDLY])	1057	if (flag [FLAG_FRIENDLY])
927	remove_friendly_object (this);	1058	remove_friendly_object (this);
928		1059
929	if (!flag [FLAG_REMOVED])
930	remove ();	1060	remove ();
931		1061
932	destroy_inv (true);	1062	attachable::do_destroy ();
933		1063
934	deactivate ();	1064	deactivate ();
935	unlink ();	1065	unlink ();
936		1066
937	flag [FLAG_FREED] = 1;	1067	flag [FLAG_FREED] = 1;
938		1068
939	// hack to ensure that freed objects still have a valid map	1069	// hack to ensure that freed objects still have a valid map
940	{
941	static maptile *freed_map; // freed objects are moved here to avoid crashes
942
943	if (!freed_map)
944	{
945	freed_map = new maptile;
946
947	freed_map->path = "<freed objects map>";
948	freed_map->name = "/internal/freed_objects_map";
949	freed_map->width = 3;
950	freed_map->height = 3;
951	freed_map->nodrop = 1;
952
953	freed_map->alloc ();
954	freed_map->in_memory = MAP_ACTIVE;
955	}
956
957	map = freed_map;	1070	map = &freed_map;
958	x = 1;	1071	x = 1;
959	y = 1;	1072	y = 1;
960	}
961		1073
962	if (more)	1074	if (more)
963	{	1075	{
964	more->destroy ();	1076	more->destroy ();
965	more = 0;	1077	more = 0;
…		…
973	attacked_by = 0;	1085	attacked_by = 0;
974	current_weapon = 0;	1086	current_weapon = 0;
975	}	1087	}
976		1088
977	void	1089	void
978	object::destroy (bool destroy_inventory)	1090	object::destroy ()
979	{	1091	{
980	if (destroyed ())	1092	if (destroyed ())
981	return;	1093	return;
982		1094
983	if (destroy_inventory)	1095	if (!is_head () && !head->destroyed ())
		1096	{
		1097	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1098	head->destroy ();
		1099	return;
		1100	}
		1101
984	destroy_inv (false);	1102	destroy_inv_fast ();
985		1103
986	if (is_head ())	1104	if (is_head ())
987	if (sound_destroy)	1105	if (sound_destroy)
988	play_sound (sound_destroy);	1106	play_sound (sound_destroy);
989	else if (flag [FLAG_MONSTER])	1107	else if (flag [FLAG_MONSTER])
…		…
1000	* the previous environment.	1118	* the previous environment.
1001	*/	1119	*/
1002	void	1120	void
1003	object::do_remove ()	1121	object::do_remove ()
1004	{	1122	{
1005	object *tmp, *last = 0;	1123	if (flag [FLAG_REMOVED])
1006	object *otmp;
1007
1008	if (QUERY_FLAG (this, FLAG_REMOVED))
1009	return;	1124	return;
1010		1125
1011	SET_FLAG (this, FLAG_REMOVED);
1012	INVOKE_OBJECT (REMOVE, this);	1126	INVOKE_OBJECT (REMOVE, this);
		1127
		1128	flag [FLAG_REMOVED] = true;
1013		1129
1014	if (more)	1130	if (more)
1015	more->remove ();	1131	more->remove ();
1016		1132
1017	/*	1133	/*
1018	* In this case, the object to be removed is in someones	1134	* In this case, the object to be removed is in someones
1019	* inventory.	1135	* inventory.
1020	*/	1136	*/
1021	if (env)	1137	if (env)
1022	{	1138	{
		1139	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1140	if (object *pl = visible_to ())
		1141	esrv_del_item (pl->contr, count);
		1142	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1143
1023	adjust_weight (env, -total_weight ());	1144	adjust_weight (env, total_weight (), 0);
1024		1145
1025	*(above ? &above->below : &env->inv) = below;	1146	object *pl = in_player ();
1026
1027	if (below)
1028	below->above = above;
1029		1147
1030	/* we set up values so that it could be inserted into	1148	/* we set up values so that it could be inserted into
1031	* the map, but we don't actually do that - it is up	1149	* the map, but we don't actually do that - it is up
1032	* to the caller to decide what we want to do.	1150	* to the caller to decide what we want to do.
1033	*/	1151	*/
1034	map = env->map;	1152	map = env->map;
1035	x = env->x;	1153	x = env->x;
1036	y = env->y;	1154	y = env->y;
		1155
		1156	// make sure cmov optimisation is applicable
		1157	*(above ? &above->below : &env->inv) = below;
		1158	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1159
1037	above = 0;	1160	above = 0;
1038	below = 0;	1161	below = 0;
1039	env = 0;	1162	env = 0;
1040		1163
1041	/* NO_FIX_PLAYER is set when a great many changes are being	1164	if (pl && pl->is_player ())
1042	* made to players inventory. If set, avoiding the call
1043	* to save cpu time.
1044	*/	1165	{
1045	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1166	if (expect_false (pl->contr->combat_ob == this))
1046	otmp->update_stats ();	1167	{
		1168	pl->apply (pl->contr->combat_ob, AP_UNAPPLY);
		1169	pl->contr->combat_ob = 0;
		1170	if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
		1171	}
		1172
		1173	if (expect_false (pl->contr->ranged_ob == this))
		1174	{
		1175	pl->apply (pl->contr->ranged_ob, AP_UNAPPLY);
		1176	pl->contr->ranged_ob = 0;
		1177	if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
		1178	}
		1179
		1180	pl->contr->queue_stats_update ();
		1181
		1182	if (expect_false (glow_radius) && pl->is_on_map ())
		1183	update_all_los (pl->map, pl->x, pl->y);
		1184	}
1047	}	1185	}
1048	else if (map)	1186	else if (map)
1049	{	1187	{
1050	if (type == PLAYER)
1051	{
1052	// leaving a spot always closes any open container on the ground
1053	if (container && !container->env)
1054	// this causes spurious floorbox updates, but it ensures
1055	// that the CLOSE event is being sent.
1056	close_container ();
1057
1058	--map->players;
1059	map->touch ();
1060	}
1061
1062	map->dirty = true;	1188	map->dirty = true;
1063	mapspace &ms = this->ms ();	1189	mapspace &ms = this->ms ();
1064		1190
		1191	if (object *pl = ms.player ())
		1192	{
		1193	if (is_player ())
		1194	{
		1195	if (!flag [FLAG_WIZPASS])
		1196	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1197
		1198	// leaving a spot always closes any open container on the ground
		1199	if (container && !container->env)
		1200	// this causes spurious floorbox updates, but it ensures
		1201	// that the CLOSE event is being sent.
		1202	close_container ();
		1203
		1204	--map->players;
		1205	map->touch ();
		1206	}
		1207	else if (pl->container_ () == this)
		1208	{
		1209	// removing a container should close it
		1210	close_container ();
		1211	}
		1212	else
		1213	esrv_del_item (pl->contr, count);
		1214	}
		1215
1065	/* link the object above us */	1216	/* link the object above us */
1066	if (above)	1217	// re-link, make sure compiler can easily use cmove
1067	above->below = below;	1218	*(above ? &above->below : &ms.top) = below;
1068	else	1219	*(below ? &below->above : &ms.bot) = above;
1069	ms.top = below; /* we were top, set new top */
1070
1071	/* Relink the object below us, if there is one */
1072	if (below)
1073	below->above = above;
1074	else
1075	{
1076	/* Nothing below, which means we need to relink map object for this space
1077	* use translated coordinates in case some oddness with map tiling is
1078	* evident
1079	*/
1080	if (GET_MAP_OB (map, x, y) != this)
1081	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1082
1083	ms.bot = above; /* goes on above it. */
1084	}
1085		1220
1086	above = 0;	1221	above = 0;
1087	below = 0;	1222	below = 0;
1088		1223
		1224	ms.invalidate ();
		1225
1089	if (map->in_memory == MAP_SAVING)	1226	if (map->in_memory == MAP_SAVING)
1090	return;	1227	return;
1091		1228
1092	int check_walk_off = !flag [FLAG_NO_APPLY];	1229	int check_walk_off = !flag [FLAG_NO_APPLY];
1093		1230
1094	if (object *pl = ms.player ())	1231	if (object *pl = ms.player ())
1095	{	1232	{
1096	if (pl->container == this)	1233	if (pl->container_ () == this)
1097	/* If a container that the player is currently using somehow gets	1234	/* If a container that the player is currently using somehow gets
1098	* removed (most likely destroyed), update the player view	1235	* removed (most likely destroyed), update the player view
1099	* appropriately.	1236	* appropriately.
1100	*/	1237	*/
1101	pl->close_container ();	1238	pl->close_container ();
1102		1239
		1240	//TODO: the floorbox prev/next might need updating
		1241	//esrv_del_item (pl->contr, count);
		1242	//TODO: update floorbox to preserve ordering
		1243	if (pl->contr->ns)
1103	pl->contr->ns->floorbox_update ();	1244	pl->contr->ns->floorbox_update ();
1104	}	1245	}
1105		1246
		1247	if (check_walk_off)
1106	for (tmp = ms.bot; tmp; tmp = tmp->above)	1248	for (object *above, *tmp = ms.bot; tmp; tmp = above)
1107	{	1249	{
		1250	above = tmp->above;
		1251
1108	/* No point updating the players look faces if he is the object	1252	/* No point updating the players look faces if he is the object
1109	* being removed.	1253	* being removed.
1110	*/	1254	*/
1111		1255
1112	/* See if object moving off should effect something */	1256	/* See if object moving off should effect something */
1113	if (check_walk_off
1114	&& ((move_type & tmp->move_off)	1257	if ((move_type & tmp->move_off)
1115	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1258	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1116	{
1117	move_apply (tmp, this, 0);	1259	move_apply (tmp, this, 0);
1118
1119	if (destroyed ())
1120	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1121	}	1260	}
1122		1261
1123	last = tmp;	1262	if (affects_los ())
1124	}
1125
1126	/* last == NULL if there are no objects on this space */
1127	//TODO: this makes little sense, why only update the topmost object?
1128	if (!last)
1129	map->at (x, y).flags_ = 0;
1130	else
1131	update_object (last, UP_OBJ_REMOVE);
1132
1133	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1134	update_all_los (map, x, y);	1263	update_all_los (map, x, y);
1135	}	1264	}
1136	}	1265	}
1137		1266
1138	/*	1267	/*
…		…
1152	if (!top)	1281	if (!top)
1153	for (top = op; top && top->above; top = top->above)	1282	for (top = op; top && top->above; top = top->above)
1154	;	1283	;
1155		1284
1156	for (; top; top = top->below)	1285	for (; top; top = top->below)
1157	{
1158	if (top == op)
1159	continue;
1160
1161	if (object::can_merge (op, top))	1286	if (object::can_merge (op, top))
1162	{	1287	{
1163	top->nrof += op->nrof;	1288	top->nrof += op->nrof;
1164		1289
1165	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1290	if (object *pl = top->visible_to ())
1166	op->weight = 0; /* Don't want any adjustements now */	1291	esrv_update_item (UPD_NROF, pl, top);
		1292
		1293	op->weight = 0; // cancel the addition above
		1294	op->carrying = 0; // must be 0 already
		1295
1167	op->destroy ();	1296	op->destroy ();
		1297
1168	return top;	1298	return top;
1169	}	1299	}
1170	}
1171		1300
1172	return 0;	1301	return 0;
1173	}	1302	}
1174		1303
1175	void	1304	void
…		…
1180		1309
1181	object *prev = this;	1310	object *prev = this;
1182		1311
1183	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)	1312	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1184	{	1313	{
1185	object *op = arch_to_object (at);	1314	object *op = at->instance ();
1186		1315
1187	op->name = name;	1316	op->name = name;
1188	op->name_pl = name_pl;	1317	op->name_pl = name_pl;
1189	op->title = title;	1318	op->title = title;
1190		1319
…		…
1200	* job preparing multi-part monsters.	1329	* job preparing multi-part monsters.
1201	*/	1330	*/
1202	object *	1331	object *
1203	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1332	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1204	{	1333	{
		1334	op->remove ();
		1335
1205	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1336	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1206	{	1337	{
1207	tmp->x = x + tmp->arch->x;	1338	tmp->x = x + tmp->arch->x;
1208	tmp->y = y + tmp->arch->y;	1339	tmp->y = y + tmp->arch->y;
1209	}	1340	}
…		…
1226	* Passing 0 for flag gives proper default values, so flag really only needs	1357	* Passing 0 for flag gives proper default values, so flag really only needs
1227	* to be set if special handling is needed.	1358	* to be set if special handling is needed.
1228	*	1359	*
1229	* Return value:	1360	* Return value:
1230	* new object if 'op' was merged with other object	1361	* new object if 'op' was merged with other object
1231	* NULL if 'op' was destroyed	1362	* NULL if there was an error (destroyed, blocked etc.)
1232	* just 'op' otherwise	1363	* just 'op' otherwise
1233	*/	1364	*/
1234	object *	1365	object *
1235	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1366	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1236	{	1367	{
1237	assert (!op->flag [FLAG_FREED]);
1238
1239	object *top, *floor = NULL;
1240
1241	op->remove ();	1368	op->remove ();
		1369
		1370	if (m == &freed_map)//D TODO: remove soon
		1371	{//D
		1372	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1373	}//D
1242		1374
1243	/* Ideally, the caller figures this out. However, it complicates a lot	1375	/* Ideally, the caller figures this out. However, it complicates a lot
1244	* of areas of callers (eg, anything that uses find_free_spot would now	1376	* of areas of callers (eg, anything that uses find_free_spot would now
1245	* need extra work	1377	* need extra work
1246	*/	1378	*/
		1379	maptile *newmap = m;
1247	if (!xy_normalise (m, op->x, op->y))	1380	if (!xy_normalise (newmap, op->x, op->y))
1248	{	1381	{
1249	op->destroy ();	1382	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1250	return 0;	1383	return 0;
1251	}	1384	}
1252		1385
1253	if (object *more = op->more)	1386	if (object *more = op->more)
1254	if (!insert_ob_in_map (more, m, originator, flag))	1387	if (!insert_ob_in_map (more, m, originator, flag))
1255	return 0;	1388	return 0;
1256		1389
1257	CLEAR_FLAG (op, FLAG_REMOVED);	1390	op->flag [FLAG_REMOVED] = false;
1258		1391	op->env = 0;
1259	op->map = m;	1392	op->map = newmap;
		1393
1260	mapspace &ms = op->ms ();	1394	mapspace &ms = op->ms ();
1261		1395
1262	/* this has to be done after we translate the coordinates.	1396	/* this has to be done after we translate the coordinates.
1263	*/	1397	*/
1264	if (op->nrof && !(flag & INS_NO_MERGE))	1398	if (op->nrof && !(flag & INS_NO_MERGE))
1265	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1399	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1266	if (object::can_merge (op, tmp))	1400	if (object::can_merge (op, tmp))
1267	{	1401	{
		1402	// TODO: we actually want to update tmp, not op,
		1403	// but some caller surely breaks when we return tmp
		1404	// from here :/
1268	op->nrof += tmp->nrof;	1405	op->nrof += tmp->nrof;
1269	tmp->destroy (1);	1406	tmp->destroy ();
1270	}	1407	}
1271		1408
1272	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1409	op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1273	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1410	op->clr_flag (FLAG_INV_LOCKED);
1274		1411
1275	if (!QUERY_FLAG (op, FLAG_ALIVE))	1412	if (!op->flag [FLAG_ALIVE])
1276	CLEAR_FLAG (op, FLAG_NO_STEAL);	1413	op->clr_flag (FLAG_NO_STEAL);
1277		1414
1278	if (flag & INS_BELOW_ORIGINATOR)	1415	if (flag & INS_BELOW_ORIGINATOR)
1279	{	1416	{
1280	if (originator->map != op->map || originator->x != op->x || originator->y != op->y)	1417	if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1281	{	1418	{
1282	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1419	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1283	abort ();	1420	abort ();
1284	}	1421	}
1285		1422
		1423	if (!originator->is_on_map ())
		1424	{
		1425	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1426	op->debug_desc (), originator->debug_desc ());
		1427	abort ();
		1428	}
		1429
1286	op->above = originator;	1430	op->above = originator;
1287	op->below = originator->below;	1431	op->below = originator->below;
1288
1289	if (op->below)
1290	op->below->above = op;
1291	else
1292	ms.bot = op;
1293
1294	/* since *below* originator, no need to update top */
1295	originator->below = op;	1432	originator->below = op;
		1433
		1434	*(op->below ? &op->below->above : &ms.bot) = op;
1296	}	1435	}
1297	else	1436	else
1298	{	1437	{
1299	top = ms.bot;	1438	object *floor = 0;
		1439	object *top = ms.top;
1300		1440
1301	/* If there are other objects, then */	1441	/* If there are other objects, then */
1302	if (top)	1442	if (top)
1303	{	1443	{
1304	object *last = 0;
1305
1306	/*	1444	/*
1307	* If there are multiple objects on this space, we do some trickier handling.	1445	* If there are multiple objects on this space, we do some trickier handling.
1308	* We've already dealt with merging if appropriate.	1446	* We've already dealt with merging if appropriate.
1309	* Generally, we want to put the new object on top. But if	1447	* Generally, we want to put the new object on top. But if
1310	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1448	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1313	* once we get to them. This reduces the need to traverse over all of	1451	* once we get to them. This reduces the need to traverse over all of
1314	* them when adding another one - this saves quite a bit of cpu time	1452	* them when adding another one - this saves quite a bit of cpu time
1315	* when lots of spells are cast in one area. Currently, it is presumed	1453	* when lots of spells are cast in one area. Currently, it is presumed
1316	* that flying non pickable objects are spell objects.	1454	* that flying non pickable objects are spell objects.
1317	*/	1455	*/
1318	for (top = ms.bot; top; top = top->above)	1456	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1319	{	1457	{
1320	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1458	if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1321	floor = top;	1459	floor = tmp;
1322		1460
1323	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1461	if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1324	{	1462	{
1325	/* We insert above top, so we want this object below this */	1463	/* We insert above top, so we want this object below this */
1326	top = top->below;	1464	top = tmp->below;
1327	break;	1465	break;
1328	}	1466	}
1329		1467
1330	last = top;	1468	top = tmp;
1331	}	1469	}
1332
1333	/* Don't want top to be NULL, so set it to the last valid object */
1334	top = last;
1335		1470
1336	/* We let update_position deal with figuring out what the space	1471	/* We let update_position deal with figuring out what the space
1337	* looks like instead of lots of conditions here.	1472	* looks like instead of lots of conditions here.
1338	* makes things faster, and effectively the same result.	1473	* makes things faster, and effectively the same result.
1339	*/	1474	*/
…		…
1346	*/	1481	*/
1347	if (!(flag & INS_ON_TOP)	1482	if (!(flag & INS_ON_TOP)
1348	&& ms.flags () & P_BLOCKSVIEW	1483	&& ms.flags () & P_BLOCKSVIEW
1349	&& (op->face && !faces [op->face].visibility))	1484	&& (op->face && !faces [op->face].visibility))
1350	{	1485	{
		1486	object *last;
		1487
1351	for (last = top; last != floor; last = last->below)	1488	for (last = top; last != floor; last = last->below)
1352	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1489	if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1353	break;	1490	break;
1354		1491
1355	/* Check to see if we found the object that blocks view,	1492	/* Check to see if we found the object that blocks view,
1356	* and make sure we have a below pointer for it so that	1493	* and make sure we have a below pointer for it so that
1357	* we can get inserted below this one, which requires we	1494	* we can get inserted below this one, which requires we
…		…
1363	} /* If objects on this space */	1500	} /* If objects on this space */
1364		1501
1365	if (flag & INS_ABOVE_FLOOR_ONLY)	1502	if (flag & INS_ABOVE_FLOOR_ONLY)
1366	top = floor;	1503	top = floor;
1367		1504
1368	/* Top is the object that our object (op) is going to get inserted above.	1505	// insert object above top, or bottom-most if top = 0
1369	*/
1370
1371	/* First object on this space */
1372	if (!top)	1506	if (!top)
1373	{	1507	{
		1508	op->below = 0;
1374	op->above = ms.bot;	1509	op->above = ms.bot;
1375
1376	if (op->above)
1377	op->above->below = op;
1378
1379	op->below = 0;
1380	ms.bot = op;	1510	ms.bot = op;
		1511
		1512	*(op->above ? &op->above->below : &ms.top) = op;
1381	}	1513	}
1382	else	1514	else
1383	{ /* get inserted into the stack above top */	1515	{
1384	op->above = top->above;	1516	op->above = top->above;
1385
1386	if (op->above)
1387	op->above->below = op;	1517	top->above = op;
1388		1518
1389	op->below = top;	1519	op->below = top;
1390	top->above = op;	1520	*(op->above ? &op->above->below : &ms.top) = op;
1391	}	1521	}
		1522	}
1392		1523
1393	if (!op->above)	1524	if (op->is_player ())
1394	ms.top = op;
1395	} /* else not INS_BELOW_ORIGINATOR */
1396
1397	if (op->type == PLAYER)
1398	{	1525	{
1399	op->contr->do_los = 1;	1526	op->contr->do_los = 1;
1400	++op->map->players;	1527	++op->map->players;
1401	op->map->touch ();	1528	op->map->touch ();
1402	}	1529	}
1403		1530
1404	op->map->dirty = true;	1531	op->map->dirty = true;
1405		1532
1406	if (object *pl = ms.player ())	1533	if (object *pl = ms.player ())
		1534	//TODO: the floorbox prev/next might need updating
		1535	//esrv_send_item (pl, op);
		1536	//TODO: update floorbox to preserve ordering
		1537	if (pl->contr->ns)
1407	pl->contr->ns->floorbox_update ();	1538	pl->contr->ns->floorbox_update ();
1408		1539
1409	/* If this object glows, it may affect lighting conditions that are	1540	/* If this object glows, it may affect lighting conditions that are
1410	* visible to others on this map. But update_all_los is really	1541	* visible to others on this map. But update_all_los is really
1411	* an inefficient way to do this, as it means los for all players	1542	* an inefficient way to do this, as it means los for all players
1412	* on the map will get recalculated. The players could very well	1543	* on the map will get recalculated. The players could very well
1413	* be far away from this change and not affected in any way -	1544	* be far away from this change and not affected in any way -
1414	* this should get redone to only look for players within range,	1545	* this should get redone to only look for players within range,
1415	* or just updating the P_UPTODATE for spaces within this area	1546	* or just updating the P_UPTODATE for spaces within this area
1416	* of effect may be sufficient.	1547	* of effect may be sufficient.
1417	*/	1548	*/
1418	if (op->map->darkness && (op->glow_radius != 0))	1549	if (op->affects_los ())
		1550	{
		1551	op->ms ().invalidate ();
1419	update_all_los (op->map, op->x, op->y);	1552	update_all_los (op->map, op->x, op->y);
		1553	}
1420		1554
1421	/* updates flags (blocked, alive, no magic, etc) for this map space */	1555	/* updates flags (blocked, alive, no magic, etc) for this map space */
1422	update_object (op, UP_OBJ_INSERT);	1556	update_object (op, UP_OBJ_INSERT);
1423		1557
1424	INVOKE_OBJECT (INSERT, op);	1558	INVOKE_OBJECT (INSERT, op);
…		…
1431	* blocked() and wall() work properly), and these flags are updated by	1565	* blocked() and wall() work properly), and these flags are updated by
1432	* update_object().	1566	* update_object().
1433	*/	1567	*/
1434		1568
1435	/* if this is not the head or flag has been passed, don't check walk on status */	1569	/* if this is not the head or flag has been passed, don't check walk on status */
1436	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1570	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1437	{	1571	{
1438	if (check_move_on (op, originator))	1572	if (check_move_on (op, originator, flag))
1439	return 0;	1573	return 0;
1440		1574
1441	/* If we are a multi part object, lets work our way through the check	1575	/* If we are a multi part object, let's work our way through the check
1442	* walk on's.	1576	* walk on's.
1443	*/	1577	*/
1444	for (object *tmp = op->more; tmp; tmp = tmp->more)	1578	for (object *tmp = op->more; tmp; tmp = tmp->more)
1445	if (check_move_on (tmp, originator))	1579	if (check_move_on (tmp, originator, flag))
1446	return 0;	1580	return 0;
1447	}	1581	}
1448		1582
1449	return op;	1583	return op;
1450	}	1584	}
…		…
1452	/* this function inserts an object in the map, but if it	1586	/* this function inserts an object in the map, but if it
1453	* finds an object of its own type, it'll remove that one first.	1587	* finds an object of its own type, it'll remove that one first.
1454	* op is the object to insert it under: supplies x and the map.	1588	* op is the object to insert it under: supplies x and the map.
1455	*/	1589	*/
1456	void	1590	void
1457	replace_insert_ob_in_map (const char *arch_string, object *op)	1591	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1458	{	1592	{
1459	/* first search for itself and remove any old instances */	1593	/* first search for itself and remove any old instances */
1460		1594
1461	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1595	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1462	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1596	if (tmp->arch->archname == archname) /* same archetype */
1463	tmp->destroy (1);	1597	tmp->destroy ();
1464		1598
1465	object *tmp = arch_to_object (archetype::find (arch_string));	1599	object *tmp = archetype::find (archname)->instance ();
1466		1600
1467	tmp->x = op->x;	1601	tmp->x = op->x;
1468	tmp->y = op->y;	1602	tmp->y = op->y;
1469		1603
1470	insert_ob_in_map (tmp, op->map, op, 0);	1604	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1477	return where->env->insert (this);	1611	return where->env->insert (this);
1478	else	1612	else
1479	return where->map->insert (this, where->x, where->y, originator, flags);	1613	return where->map->insert (this, where->x, where->y, originator, flags);
1480	}	1614	}
1481		1615
1482	// find player who can see this object	1616	// check whether we can put this into the map, respect max_volume, max_items
1483	static object *	1617	bool
1484	visible_to (object *op)	1618	object::can_drop_at (maptile *m, int x, int y, object *originator)
1485	{	1619	{
1486	if (!op->flag [FLAG_REMOVED])	1620	mapspace &ms = m->at (x, y);
1487	{
1488	// see if we are in a container of sorts
1489	if (object *env = op->env)
1490	{
1491	// the player inventory itself is always visible
1492	if (env->type == PLAYER)
1493	return env;
1494		1621
1495	// else a player could have our env open	1622	int items = ms.items ();
1496	env = env->outer_env ();
1497		1623
1498	// the player itself is always on a map, so we will find him here	1624	if (!items // testing !items ensures we can drop at least one item
1499	// even if our inv is in a player.	1625	|| (items < m->max_items
1500	if (env->is_on_map ())	1626	&& ms.volume () < m->max_volume))
1501	if (object *pl = env->ms ().player ())	1627	return true;
1502	if (pl->container == op->env)
1503	return pl;
1504	}
1505	else
1506	{
1507	// maybe there is a player standing on the same mapspace
1508	if (object *pl = env->ms ().player ())
1509	return pl;
1510	}
1511	}
1512		1628
		1629	if (originator && originator->is_player ())
		1630	originator->contr->failmsgf (
		1631	"No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
		1632	query_name ()
		1633	);
		1634
1513	return 0;	1635	return false;
1514	}	1636	}
1515		1637
1516	/*	1638	/*
1517	* decrease(object, number) decreases a specified number from	1639	* decrease(object, number) decreases a specified number from
1518	* the amount of an object. If the amount reaches 0, the object	1640	* the amount of an object. If the amount reaches 0, the object
…		…
1521	* Return value: 'op' if something is left, NULL if the amount reached 0	1643	* Return value: 'op' if something is left, NULL if the amount reached 0
1522	*/	1644	*/
1523	bool	1645	bool
1524	object::decrease (sint32 nr)	1646	object::decrease (sint32 nr)
1525	{	1647	{
		1648	if (!nr)
		1649	return true;
		1650
1526	nr = min (nr, nrof);	1651	nr = min (nr, nrof);
1527		1652
1528	if (!nr)	1653	if (nrof > nr)
1529	return 1;	1654	{
		1655	sint64 oweight = total_weight ();
1530		1656
1531	nrof -= nr;	1657	nrof -= nr;
1532		1658
1533	object *visible = visible_to (this);	1659	if (object *pl = visible_to ())
		1660	esrv_update_item (UPD_NROF, pl, this);
1534		1661
1535	if (nrof)	1662	adjust_weight (env, oweight, total_weight ());
1536	{
1537	adjust_weight (env, -weight * nr); // carrying == 0
1538		1663
1539	if (visible)
1540	esrv_send_item (visible, this);
1541
1542	return 1;	1664	return true;
1543	}	1665	}
1544	else	1666	else
1545	{	1667	{
1546	if (visible)
1547	esrv_del_item (visible->contr, count);
1548
1549	this->destroy (1);	1668	destroy ();
1550	return 0;	1669	return false;
1551	}	1670	}
1552	}	1671	}
1553		1672
1554	/*	1673	/*
1555	* get_split_ob(ob,nr) splits up ob into two parts. The part which	1674	* split(ob,nr) splits up ob into two parts. The part which
1556	* is returned contains nr objects, and the remaining parts contains	1675	* is returned contains nr objects, and the remaining parts contains
1557	* the rest (or is removed and freed if that number is 0).	1676	* the rest (or is removed and returned if that number is 0).
1558	* On failure, NULL is returned, and the reason put into the	1677	* On failure, NULL is returned.
1559	* global static errmsg array.
1560	*/	1678	*/
1561	object *	1679	object *
1562	object::split (sint32 nr)	1680	object::split (sint32 nr)
1563	{	1681	{
		1682	int have = number_of ();
		1683
1564	if (nrof < nr)	1684	if (have < nr)
1565	return 0;	1685	return 0;
1566	else if (nrof == nr)	1686	else if (have == nr)
1567	{	1687	{
1568	remove ();	1688	remove ();
1569	return this;	1689	return this;
1570	}	1690	}
1571	else	1691	else
1572	{	1692	{
1573	decrease (nr);	1693	decrease (nr);
1574		1694
1575	object *op = object_create_clone (this);	1695	object *op = deep_clone ();
1576	op->nrof = nr;	1696	op->nrof = nr;
1577	return op;	1697	return op;
1578	}	1698	}
1579	}
1580
1581	//TODO: remove, but semantics differs from split_nr
1582	object *
1583	get_split_ob (object *orig_ob, uint32 nr)
1584	{
1585	if (orig_ob->nrof < nr)
1586	{
1587	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1588	return 0;
1589	}
1590
1591	return orig_ob->split (nr);
1592	}	1699	}
1593		1700
1594	object *	1701	object *
1595	insert_ob_in_ob (object *op, object *where)	1702	insert_ob_in_ob (object *op, object *where)
1596	{	1703	{
…		…
1635	if (op->nrof)	1742	if (op->nrof)
1636	for (object *tmp = inv; tmp; tmp = tmp->below)	1743	for (object *tmp = inv; tmp; tmp = tmp->below)
1637	if (object::can_merge (tmp, op))	1744	if (object::can_merge (tmp, op))
1638	{	1745	{
1639	/* return the original object and remove inserted object	1746	/* return the original object and remove inserted object
1640	(client needs the original object) */	1747	(client prefers the original object) */
		1748
		1749	// carring must be 0 for mergable objects
		1750	sint64 oweight = tmp->weight * tmp->nrof;
		1751
1641	tmp->nrof += op->nrof;	1752	tmp->nrof += op->nrof;
		1753
		1754	if (object *pl = tmp->visible_to ())
		1755	esrv_update_item (UPD_NROF, pl, tmp);
		1756
		1757	adjust_weight (this, oweight, tmp->weight * tmp->nrof);
		1758
1642	op->destroy (1);	1759	op->destroy ();
1643	op = tmp;	1760	op = tmp;
1644	goto inserted;	1761	goto inserted;
1645	}	1762	}
1646		1763
1647	op->owner = 0; // it's his/hers now. period.	1764	op->owner = 0; // it's his/hers now. period.
…		…
1658		1775
1659	inv = op;	1776	inv = op;
1660		1777
1661	op->flag [FLAG_REMOVED] = 0;	1778	op->flag [FLAG_REMOVED] = 0;
1662		1779
		1780	if (object *pl = op->visible_to ())
		1781	esrv_send_item (pl, op);
		1782
1663	adjust_weight (this, op->total_weight ());	1783	adjust_weight (this, 0, op->total_weight ());
1664		1784
1665	inserted:	1785	inserted:
1666	/* reset the light list and los of the players on the map */	1786	/* reset the light list and los of the players on the map */
1667	if (op->glow_radius && map && map->darkness)	1787	if (op->glow_radius && is_on_map ())
		1788	{
		1789	update_stats ();
1668	update_all_los (map, x, y);	1790	update_all_los (map, x, y);
1669		1791	}
1670	if (object *otmp = in_player ())	1792	else if (is_player ())
1671	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1793	// if this is a player's inventory, update stats
1672	otmp->update_stats ();	1794	contr->queue_stats_update ();
1673		1795
1674	INVOKE_OBJECT (INSERT, this);	1796	INVOKE_OBJECT (INSERT, this);
1675		1797
1676	return op;	1798	return op;
1677	}	1799	}
…		…
1695	* MSW 2001-07-08: Check all objects on space, not just those below	1817	* MSW 2001-07-08: Check all objects on space, not just those below
1696	* object being inserted. insert_ob_in_map may not put new objects	1818	* object being inserted. insert_ob_in_map may not put new objects
1697	* on top.	1819	* on top.
1698	*/	1820	*/
1699	int	1821	int
1700	check_move_on (object *op, object *originator)	1822	check_move_on (object *op, object *originator, int flags)
1701	{	1823	{
		1824	if (op->flag [FLAG_NO_APPLY])
		1825	return 0;
		1826
1702	object *tmp;	1827	object *tmp;
1703	maptile *m = op->map;	1828	maptile *m = op->map;
1704	int x = op->x, y = op->y;	1829	int x = op->x, y = op->y;
1705		1830
1706	MoveType move_on, move_slow, move_block;	1831	mapspace &ms = m->at (x, y);
1707		1832
1708	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1833	ms.update ();
1709	return 0;
1710		1834
1711	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1835	MoveType move_on = ms.move_on;
1712	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1836	MoveType move_slow = ms.move_slow;
1713	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1837	MoveType move_block = ms.move_block;
1714		1838
1715	/* if nothing on this space will slow op down or be applied,	1839	/* if nothing on this space will slow op down or be applied,
1716	* no need to do checking below. have to make sure move_type	1840	* no need to do checking below. have to make sure move_type
1717	* is set, as lots of objects don't have it set - we treat that	1841	* is set, as lots of objects don't have it set - we treat that
1718	* as walking.	1842	* as walking.
…		…
1729	return 0;	1853	return 0;
1730		1854
1731	/* The objects have to be checked from top to bottom.	1855	/* The objects have to be checked from top to bottom.
1732	* Hence, we first go to the top:	1856	* Hence, we first go to the top:
1733	*/	1857	*/
1734		1858	for (object *next, *tmp = ms.top; tmp; tmp = next)
1735	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1736	{
1737	/* Trim the search when we find the first other spell effect
1738	* this helps performance so that if a space has 50 spell objects,
1739	* we don't need to check all of them.
1740	*/
1741	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1742	break;
1743	}	1859	{
		1860	next = tmp->below;
1744		1861
1745	for (; tmp; tmp = tmp->below)
1746	{
1747	if (tmp == op)	1862	if (tmp == op)
1748	continue; /* Can't apply yourself */	1863	continue; /* Can't apply yourself */
1749		1864
1750	/* Check to see if one of the movement types should be slowed down.	1865	/* Check to see if one of the movement types should be slowed down.
1751	* Second check makes sure that the movement types not being slowed	1866	* Second check makes sure that the movement types not being slowed
1752	* (~slow_move) is not blocked on this space - just because the	1867	* (~slow_move) is not blocked on this space - just because the
1753	* space doesn't slow down swimming (for example), if you can't actually	1868	* space doesn't slow down swimming (for example), if you can't actually
1754	* swim on that space, can't use it to avoid the penalty.	1869	* swim on that space, can't use it to avoid the penalty.
1755	*/	1870	*/
1756	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1871	if (!op->flag [FLAG_WIZPASS])
1757	{	1872	{
1758	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1873	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1759	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1874	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1760	{	1875	{
1761
1762	float
1763	diff = tmp->move_slow_penalty * fabs (op->speed);	1876	float diff = tmp->move_slow_penalty * fabs (op->speed);
1764		1877
1765	if (op->type == PLAYER)	1878	if (op->is_player ())
1766	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1879	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1767	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1880	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1768	diff /= 4.0;	1881	diff /= 4.0;
1769		1882
1770	op->speed_left -= diff;	1883	op->speed_left -= diff;
1771	}	1884	}
1772	}	1885	}
1773		1886
1774	/* Basically same logic as above, except now for actual apply. */	1887	/* Basically same logic as above, except now for actual apply. */
1775	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||	1888	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1776	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))	1889	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1777	{	1890	{
		1891	if ((flags & INS_NO_AUTO_EXIT)
		1892	&& (tmp->type == EXIT || tmp->type == TELEPORTER
		1893	|| tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
		1894	continue;
		1895
1778	move_apply (tmp, op, originator);	1896	move_apply (tmp, op, originator);
1779		1897
1780	if (op->destroyed ())	1898	if (op->destroyed ())
1781	return 1;	1899	return 1;
1782		1900
…		…
1805	LOG (llevError, "Present_arch called outside map.\n");	1923	LOG (llevError, "Present_arch called outside map.\n");
1806	return NULL;	1924	return NULL;
1807	}	1925	}
1808		1926
1809	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1927	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1810	if (tmp->arch == at)	1928	if (tmp->arch->archname == at->archname)
1811	return tmp;	1929	return tmp;
1812		1930
1813	return NULL;	1931	return NULL;
1814	}	1932	}
1815		1933
…		…
1879	* The first matching object is returned, or NULL if none.	1997	* The first matching object is returned, or NULL if none.
1880	*/	1998	*/
1881	object *	1999	object *
1882	present_arch_in_ob (const archetype *at, const object *op)	2000	present_arch_in_ob (const archetype *at, const object *op)
1883	{	2001	{
1884	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	2002	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1885	if (tmp->arch == at)	2003	if (tmp->arch->archname == at->archname)
1886	return tmp;	2004	return tmp;
1887		2005
1888	return NULL;	2006	return NULL;
1889	}	2007	}
1890		2008
…		…
1894	void	2012	void
1895	flag_inv (object *op, int flag)	2013	flag_inv (object *op, int flag)
1896	{	2014	{
1897	for (object *tmp = op->inv; tmp; tmp = tmp->below)	2015	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1898	{	2016	{
1899	SET_FLAG (tmp, flag);	2017	tmp->set_flag (flag);
1900	flag_inv (tmp, flag);	2018	flag_inv (tmp, flag);
1901	}	2019	}
1902	}	2020	}
1903		2021
1904	/*	2022	/*
…		…
1907	void	2025	void
1908	unflag_inv (object *op, int flag)	2026	unflag_inv (object *op, int flag)
1909	{	2027	{
1910	for (object *tmp = op->inv; tmp; tmp = tmp->below)	2028	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1911	{	2029	{
1912	CLEAR_FLAG (tmp, flag);	2030	tmp->clr_flag (flag);
1913	unflag_inv (tmp, flag);	2031	unflag_inv (tmp, flag);
1914	}	2032	}
1915	}	2033	}
1916		2034
1917	/*	2035	/*
…		…
1978	* head of the object should correspond for the entire object.	2096	* head of the object should correspond for the entire object.
1979	*/	2097	*/
1980	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	2098	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1981	continue;	2099	continue;
1982		2100
1983	if (ob->blocked (m, pos.x, pos.y))	2101	if (ob->blocked (pos.m, pos.x, pos.y))
1984	continue;	2102	continue;
1985		2103
1986	altern [index++] = i;	2104	altern [index++] = i;
1987	}	2105	}
1988		2106
…		…
2056	* there is capable of.	2174	* there is capable of.
2057	*/	2175	*/
2058	int	2176	int
2059	find_dir (maptile *m, int x, int y, object *exclude)	2177	find_dir (maptile *m, int x, int y, object *exclude)
2060	{	2178	{
2061	int i, max = SIZEOFFREE, mflags;	2179	int max = SIZEOFFREE, mflags;
2062
2063	sint16 nx, ny;
2064	object *tmp;
2065	maptile *mp;
2066
2067	MoveType blocked, move_type;	2180	MoveType move_type;
2068		2181
2069	if (exclude && exclude->head_ () != exclude)	2182	if (exclude && exclude->head_ () != exclude)
2070	{	2183	{
2071	exclude = exclude->head;	2184	exclude = exclude->head;
2072	move_type = exclude->move_type;	2185	move_type = exclude->move_type;
…		…
2075	{	2188	{
2076	/* If we don't have anything, presume it can use all movement types. */	2189	/* If we don't have anything, presume it can use all movement types. */
2077	move_type = MOVE_ALL;	2190	move_type = MOVE_ALL;
2078	}	2191	}
2079		2192
2080	for (i = 1; i < max; i++)	2193	for (int i = 1; i < max; i++)
2081	{	2194	{
2082	mp = m;	2195	mapxy pos (m, x, y);
2083	nx = x + freearr_x[i];	2196	pos.move (i);
2084	ny = y + freearr_y[i];
2085		2197
2086	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2198	if (!pos.normalise ())
2087
2088	if (mflags & P_OUT_OF_MAP)
2089	max = maxfree[i];	2199	max = maxfree[i];
2090	else	2200	else
2091	{	2201	{
2092	mapspace &ms = mp->at (nx, ny);	2202	mapspace &ms = *pos;
2093		2203
2094	blocked = ms.move_block;
2095
2096	if ((move_type & blocked) == move_type)	2204	if ((move_type & ms.move_block) == move_type)
2097	max = maxfree[i];	2205	max = maxfree [i];
2098	else if (mflags & P_IS_ALIVE)	2206	else if (ms.flags () & P_IS_ALIVE)
2099	{	2207	{
2100	for (tmp = ms.bot; tmp; tmp = tmp->above)	2208	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2101	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2209	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2102	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2210	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2103	break;
2104
2105	if (tmp)
2106	return freedir[i];	2211	return freedir [i];
2107	}	2212	}
2108	}	2213	}
2109	}	2214	}
2110		2215
2111	return 0;	2216	return 0;
…		…
2120	{	2225	{
2121	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);	2226	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2122	}	2227	}
2123		2228
2124	/*	2229	/*
2125	* find_dir_2(delta-x,delta-y) will return a direction in which	2230	* find_dir_2(delta-x,delta-y) will return a direction value
2126	* an object which has subtracted the x and y coordinates of another	2231	* for running into direct [dx, dy].
2127	* object, needs to travel toward it.	2232	* (the opposite of crossfire's find_dir_2!)
2128	*/	2233	*/
2129	int	2234	int
2130	find_dir_2 (int x, int y)	2235	find_dir_2 (int x, int y)
2131	{	2236	{
		2237	#if 1 // new algorithm
		2238	// this works by putting x, y into 16 sectors, which
		2239	// are not equal sized, but are a better approximation
		2240	// then the old algorithm, and then using a mapping
		2241	// table to map it into a direction value.
		2242	// basically, it maps these comparisons to each bit
		2243	// bit #3: x < 0
		2244	// bit #2: y < 0
		2245	// bit #1: x > y
		2246	// bit #0: x > 2y
		2247
		2248	static const uint8 dir[16] = {
		2249	4, 5, 4, 3,
		2250	2, 1, 2, 3,
		2251	6, 5, 6, 7,
		2252	8, 1, 8, 7,
		2253	};
		2254	int sector = 0;
		2255
		2256	// this is a bit ugly, but more likely to result in branchless code
		2257	sector |= x < 0 ? 8 : 0;
		2258	x = x < 0 ? -x : x; // abs
		2259
		2260	sector |= y < 0 ? 4 : 0;
		2261	y = y < 0 ? -y : y; // abs
		2262
		2263	if (x > y)
		2264	{
		2265	sector |= 2;
		2266
		2267	if (x > y * 2)
		2268	sector |= 1;
		2269	}
		2270	else
		2271	{
		2272	if (y > x * 2)
		2273	sector |= 1;
		2274	else if (!y)
		2275	return 0; // x == 0 here
		2276	}
		2277
		2278	return dir [sector];
		2279	#else // old algorithm
2132	int q;	2280	int q;
2133		2281
2134	if (y)	2282	if (y)
2135	q = x * 100 / y;	2283	q = 128 * x / y;
2136	else if (x)	2284	else if (x)
2137	q = -300 * x;	2285	q = -512 * x; // to make it > 309
2138	else	2286	else
2139	return 0;	2287	return 0;
2140		2288
2141	if (y > 0)	2289	if (y > 0)
2142	{	2290	{
2143	if (q < -242)	2291	if (q < -309) return 7;
		2292	if (q < -52) return 6;
		2293	if (q < 52) return 5;
		2294	if (q < 309) return 4;
		2295
2144	return 3;	2296	return 3;
2145	if (q < -41)	2297	}
2146	return 2;	2298	else
2147	if (q < 41)	2299	{
2148	return 1;	2300	if (q < -309) return 3;
2149	if (q < 242)	2301	if (q < -52) return 2;
2150	return 8;	2302	if (q < 52) return 1;
		2303	if (q < 309) return 8;
		2304
2151	return 7;	2305	return 7;
2152	}	2306	}
2153		2307	#endif
2154	if (q < -242)
2155	return 7;
2156	if (q < -41)
2157	return 6;
2158	if (q < 41)
2159	return 5;
2160	if (q < 242)
2161	return 4;
2162
2163	return 3;
2164	}	2308	}
2165		2309
2166	/*	2310	/*
2167	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is	2311	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2168	* between two directions (which are expected to be absolute (see absdir())	2312	* between two directions (which are expected to be absolute (see absdir())
2169	*/	2313	*/
2170	int	2314	int
2171	dirdiff (int dir1, int dir2)	2315	dirdiff (int dir1, int dir2)
2172	{	2316	{
2173	int d;
2174
2175	d = abs (dir1 - dir2);	2317	int d = abs (dir1 - dir2);
2176	if (d > 4)
2177	d = 8 - d;
2178		2318
2179	return d;	2319	return d > 4 ? 8 - d : d;
2180	}	2320	}
2181		2321
2182	/* peterm:	2322	/* peterm:
2183	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.	2323	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2184	* Basically, this is a table of directions, and what directions	2324	* Basically, this is a table of directions, and what directions
…		…
2186	* This basically means that if direction is 15, then it could either go	2326	* This basically means that if direction is 15, then it could either go
2187	* direction 4, 14, or 16 to get back to where we are.	2327	* direction 4, 14, or 16 to get back to where we are.
2188	* Moved from spell_util.c to object.c with the other related direction	2328	* Moved from spell_util.c to object.c with the other related direction
2189	* functions.	2329	* functions.
2190	*/	2330	*/
2191	int reduction_dir[SIZEOFFREE][3] = {	2331	static const int reduction_dir[SIZEOFFREE][3] = {
2192	{0, 0, 0}, /* 0 */	2332	{0, 0, 0}, /* 0 */
2193	{0, 0, 0}, /* 1 */	2333	{0, 0, 0}, /* 1 */
2194	{0, 0, 0}, /* 2 */	2334	{0, 0, 0}, /* 2 */
2195	{0, 0, 0}, /* 3 */	2335	{0, 0, 0}, /* 3 */
2196	{0, 0, 0}, /* 4 */	2336	{0, 0, 0}, /* 4 */
…		…
2290	* Add a check so we can't pick up invisible objects (0.93.8)	2430	* Add a check so we can't pick up invisible objects (0.93.8)
2291	*/	2431	*/
2292	int	2432	int
2293	can_pick (const object *who, const object *item)	2433	can_pick (const object *who, const object *item)
2294	{	2434	{
2295	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2435	return /*who->flag [FLAG_WIZ]|| */
2296	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2436	(item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2297	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2437	!item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2298	}	2438	}
2299		2439
2300	/*	2440	/*
2301	* create clone from object to another	2441	* create clone from object to another
2302	*/	2442	*/
2303	object *	2443	object *
2304	object_create_clone (object *asrc)	2444	object::deep_clone ()
2305	{	2445	{
2306	object *dst = 0, *tmp, *src, *prev, *item;	2446	assert (("deep_clone called on non-head object", is_head ()));
2307		2447
2308	if (!asrc)	2448	object *dst = clone ();
2309	return 0;
2310		2449
2311	src = asrc->head_ ();	2450	object *prev = dst;
2312
2313	prev = 0;
2314	for (object *part = src; part; part = part->more)	2451	for (object *part = this->more; part; part = part->more)
2315	{	2452	{
2316	tmp = part->clone ();	2453	object *tmp = part->clone ();
2317	tmp->x -= src->x;
2318	tmp->y -= src->y;
2319
2320	if (!part->head)
2321	{
2322	dst = tmp;
2323	tmp->head = 0;
2324	}
2325	else
2326	tmp->head = dst;	2454	tmp->head = dst;
2327
2328	tmp->more = 0;
2329
2330	if (prev)
2331	prev->more = tmp;	2455	prev->more = tmp;
2332
2333	prev = tmp;	2456	prev = tmp;
2334	}	2457	}
2335		2458
2336	for (item = src->inv; item; item = item->below)	2459	for (object *item = inv; item; item = item->below)
2337	insert_ob_in_ob (object_create_clone (item), dst);	2460	insert_ob_in_ob (item->deep_clone (), dst);
2338		2461
2339	return dst;	2462	return dst;
2340	}	2463	}
2341		2464
2342	/* This returns the first object in who's inventory that	2465	/* This returns the first object in who's inventory that
…		…
2351	return tmp;	2474	return tmp;
2352		2475
2353	return 0;	2476	return 0;
2354	}	2477	}
2355		2478
2356	/* If ob has a field named key, return the link from the list,	2479	shstr_tmp
2357	* otherwise return NULL.	2480	object::kv_get (shstr_tmp key) const
2358	*
2359	* key must be a passed in shared string - otherwise, this won't
2360	* do the desired thing.
2361	*/
2362	key_value *
2363	get_ob_key_link (const object *ob, const char *key)
2364	{	2481	{
2365	for (key_value *link = ob->key_values; link; link = link->next)	2482	for (key_value *kv = key_values; kv; kv = kv->next)
2366	if (link->key == key)	2483	if (kv->key == key)
2367	return link;
2368
2369	return 0;
2370	}
2371
2372	/*
2373	* Returns the value of op has an extra_field for key, or NULL.
2374	*
2375	* The argument doesn't need to be a shared string.
2376	*
2377	* The returned string is shared.
2378	*/
2379	const char *
2380	get_ob_key_value (const object *op, const char *const key)
2381	{
2382	key_value *link;
2383	shstr_cmp canonical_key (key);
2384
2385	if (!canonical_key)
2386	{
2387	/* 1. There being a field named key on any object
2388	* implies there'd be a shared string to find.
2389	* 2. Since there isn't, no object has this field.
2390	* 3. Therefore, *this* object doesn't have this field.
2391	*/
2392	return 0;
2393	}
2394
2395	/* This is copied from get_ob_key_link() above -
2396	* only 4 lines, and saves the function call overhead.
2397	*/
2398	for (link = op->key_values; link; link = link->next)
2399	if (link->key == canonical_key)
2400	return link->value;	2484	return kv->value;
2401		2485
2402	return 0;	2486	return shstr ();
2403	}	2487	}
2404		2488
2405	/*	2489	void
2406	* Updates the canonical_key in op to value.	2490	object::kv_set (shstr_tmp key, shstr_tmp value)
2407	*
2408	* canonical_key is a shared string (value doesn't have to be).
2409	*
2410	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2411	* keys.
2412	*
2413	* Returns TRUE on success.
2414	*/
2415	int
2416	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2417	{	2491	{
2418	key_value *field = NULL, *last = NULL;	2492	for (key_value *kv = key_values; kv; kv = kv->next)
2419		2493	if (kv->key == key)
2420	for (field = op->key_values; field != NULL; field = field->next)
2421	{
2422	if (field->key != canonical_key)
2423	{	2494	{
2424	last = field;	2495	kv->value = value;
2425	continue;	2496	return;
2426	}	2497	}
2427		2498
2428	if (value)	2499	key_value *kv = new key_value;
2429	field->value = value;	2500
2430	else	2501	kv->next = key_values;
		2502	kv->key = key;
		2503	kv->value = value;
		2504
		2505	key_values = kv;
		2506	}
		2507
		2508	void
		2509	object::kv_del (shstr_tmp key)
		2510	{
		2511	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2512	if ((*kvp)->key == key)
2431	{	2513	{
2432	/* Basically, if the archetype has this key set,	2514	key_value *kv = *kvp;
2433	* we need to store the null value so when we save	2515	*kvp = (*kvp)->next;
2434	* it, we save the empty value so that when we load,	2516	delete kv;
2435	* we get this value back again.	2517	return;
2436	*/
2437	if (get_ob_key_link (op->arch, canonical_key))
2438	field->value = 0;
2439	else
2440	{
2441	if (last)
2442	last->next = field->next;
2443	else
2444	op->key_values = field->next;
2445
2446	delete field;
2447	}
2448	}	2518	}
2449	return TRUE;
2450	}
2451	/* IF we get here, key doesn't exist */
2452
2453	/* No field, we'll have to add it. */
2454
2455	if (!add_key)
2456	return FALSE;
2457
2458	/* There isn't any good reason to store a null
2459	* value in the key/value list. If the archetype has
2460	* this key, then we should also have it, so shouldn't
2461	* be here. If user wants to store empty strings,
2462	* should pass in ""
2463	*/
2464	if (value == NULL)
2465	return TRUE;
2466
2467	field = new key_value;
2468
2469	field->key = canonical_key;
2470	field->value = value;
2471	/* Usual prepend-addition. */
2472	field->next = op->key_values;
2473	op->key_values = field;
2474
2475	return TRUE;
2476	}
2477
2478	/*
2479	* Updates the key in op to value.
2480	*
2481	* If add_key is FALSE, this will only update existing keys,
2482	* and not add new ones.
2483	* In general, should be little reason FALSE is ever passed in for add_key
2484	*
2485	* Returns TRUE on success.
2486	*/
2487	int
2488	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2489	{
2490	shstr key_ (key);
2491
2492	return set_ob_key_value_s (op, key_, value, add_key);
2493	}	2519	}
2494		2520
2495	object::depth_iterator::depth_iterator (object *container)	2521	object::depth_iterator::depth_iterator (object *container)
2496	: iterator_base (container)	2522	: iterator_base (container)
2497	{	2523	{
…		…
2547	{	2573	{
2548	char flagdesc[512];	2574	char flagdesc[512];
2549	char info2[256 * 4];	2575	char info2[256 * 4];
2550	char *p = info;	2576	char *p = info;
2551		2577
2552	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2578	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2553	count,	2579	count,
2554	uuid.c_str (),	2580	uuid.c_str (),
2555	&name,	2581	&name,
2556	title ? "\",title:\"" : "",	2582	title ? ",title:\"" : "",
2557	title ? (const char *)title : "",	2583	title ? (const char *)title : "",
		2584	title ? "\"" : "",
2558	flag_desc (flagdesc, 512), type);	2585	flag_desc (flagdesc, 512), type);
2559		2586
2560	if (!this->flag[FLAG_REMOVED] && env)	2587	if (!flag[FLAG_REMOVED] && env)
2561	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2588	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2562		2589
2563	if (map)	2590	if (map)
2564	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2591	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2565		2592
…		…
2580	{	2607	{
2581	return map ? map->region (x, y)	2608	return map ? map->region (x, y)
2582	: region::default_region ();	2609	: region::default_region ();
2583	}	2610	}
2584		2611
2585	const materialtype_t *
2586	object::dominant_material () const
2587	{
2588	if (materialtype_t *mt = name_to_material (materialname))
2589	return mt;
2590
2591	return name_to_material (shstr_unknown);
2592	}
2593
2594	void	2612	void
2595	object::open_container (object *new_container)	2613	object::open_container (object *new_container)
2596	{	2614	{
2597	if (container == new_container)	2615	if (container == new_container)
2598	return;	2616	return;
2599		2617
2600	if (object *old_container = container)	2618	object *old_container = container;
		2619
		2620	if (old_container)
2601	{	2621	{
2602	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2622	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2603	return;	2623	return;
2604		2624
2605	#if 0	2625	#if 0
…		…
2607	if (object *closer = old_container->inv)	2627	if (object *closer = old_container->inv)
2608	if (closer->type == CLOSE_CON)	2628	if (closer->type == CLOSE_CON)
2609	closer->destroy ();	2629	closer->destroy ();
2610	#endif	2630	#endif
2611		2631
		2632	// make sure the container is available
		2633	esrv_send_item (this, old_container);
		2634
2612	old_container->flag [FLAG_APPLIED] = 0;	2635	old_container->flag [FLAG_APPLIED] = false;
2613	container = 0;	2636	container = 0;
2614		2637
		2638	// client needs item update to make it work, client bug requires this to be separate
2615	esrv_update_item (UPD_FLAGS, this, old_container);	2639	esrv_update_item (UPD_FLAGS, this, old_container);
		2640
2616	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2641	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2617	play_sound (sound_find ("chest_close"));	2642	play_sound (sound_find ("chest_close"));
2618	}	2643	}
2619		2644
2620	if (new_container)	2645	if (new_container)
2621	{	2646	{
…		…
2625	// TODO: this does not seem to serve any purpose anymore?	2650	// TODO: this does not seem to serve any purpose anymore?
2626	#if 0	2651	#if 0
2627	// insert the "Close Container" object.	2652	// insert the "Close Container" object.
2628	if (archetype *closer = new_container->other_arch)	2653	if (archetype *closer = new_container->other_arch)
2629	{	2654	{
2630	object *closer = arch_to_object (new_container->other_arch);	2655	object *closer = new_container->other_arch->instance ();
2631	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2656	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2632	new_container->insert (closer);	2657	new_container->insert (closer);
2633	}	2658	}
2634	#endif	2659	#endif
2635		2660
2636	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2661	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2637		2662
		2663	// make sure the container is available, client bug requires this to be separate
		2664	esrv_send_item (this, new_container);
		2665
2638	new_container->flag [FLAG_APPLIED] = 1;	2666	new_container->flag [FLAG_APPLIED] = true;
2639	container = new_container;	2667	container = new_container;
2640		2668
		2669	// client needs flag change
2641	esrv_update_item (UPD_FLAGS, this, new_container);	2670	esrv_update_item (UPD_FLAGS, this, new_container);
2642	esrv_send_inventory (this, new_container);	2671	esrv_send_inventory (this, new_container);
2643	play_sound (sound_find ("chest_open"));	2672	play_sound (sound_find ("chest_open"));
2644	}	2673	}
		2674	// else if (!old_container->env && contr && contr->ns)
		2675	// contr->ns->floorbox_reset ();
2645	}	2676	}
2646		2677
2647	object *	2678	object *
2648	object::force_find (const shstr name)	2679	object::force_find (shstr_tmp name)
2649	{	2680	{
2650	/* cycle through his inventory to look for the MARK we want to	2681	/* cycle through his inventory to look for the MARK we want to
2651	* place	2682	* place
2652	*/	2683	*/
2653	for (object *tmp = inv; tmp; tmp = tmp->below)	2684	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2655	return splay (tmp);	2686	return splay (tmp);
2656		2687
2657	return 0;	2688	return 0;
2658	}	2689	}
2659		2690
		2691	//-GPL
		2692
2660	void	2693	void
		2694	object::force_set_timer (int duration)
		2695	{
		2696	this->duration = 1;
		2697	this->speed_left = -1.f;
		2698
		2699	this->set_speed (duration ? 1.f / duration : 0.f);
		2700	}
		2701
		2702	object *
2661	object::force_add (const shstr name, int duration)	2703	object::force_add (shstr_tmp name, int duration)
2662	{	2704	{
2663	if (object *force = force_find (name))	2705	if (object *force = force_find (name))
2664	force->destroy ();	2706	force->destroy ();
2665		2707
2666	object *force = get_archetype (FORCE_NAME);	2708	object *force = get_archetype (FORCE_NAME);
2667		2709
2668	force->slaying = name;	2710	force->slaying = name;
2669	force->stats.food = 1;	2711	force->force_set_timer (duration);
2670	force->speed_left = -1.f;
2671
2672	force->set_speed (duration ? 1.f / duration : 0.f);
2673	force->flag [FLAG_IS_USED_UP] = true;
2674	force->flag [FLAG_APPLIED] = true;	2712	force->flag [FLAG_APPLIED] = true;
2675		2713
2676	insert (force);	2714	return insert (force);
2677	}	2715	}
2678		2716
2679	void	2717	void
2680	object::play_sound (faceidx sound)	2718	object::play_sound (faceidx sound) const
2681	{	2719	{
2682	if (!sound)	2720	if (!sound)
2683	return;	2721	return;
2684		2722
2685	if (flag [FLAG_REMOVED])	2723	if (is_on_map ())
		2724	map->play_sound (sound, x, y);
		2725	else if (object *pl = in_player ())
		2726	pl->contr->play_sound (sound);
		2727	}
		2728
		2729	void
		2730	object::say_msg (const char *msg) const
		2731	{
		2732	if (is_on_map ())
		2733	map->say_msg (msg, x, y);
		2734	else if (object *pl = in_player ())
		2735	pl->contr->play_sound (sound);
		2736	}
		2737
		2738	void
		2739	object::make_noise ()
		2740	{
		2741	// we do not model noise in the map, so instead put
		2742	// a temporary light into the noise source
		2743	// could use the map instead, but that's less reliable for our
		2744	// goal, which is to make invisibility a bit harder to exploit
		2745
		2746	// currently only works sensibly for players
		2747	if (!is_player ())
2686	return;	2748	return;
2687		2749
2688	if (env)	2750	// find old force, or create new one
2689	{	2751	object *force = force_find (shstr_noise_force);
2690	if (object *pl = in_player ())	2752
2691	pl->contr->play_sound (sound);	2753	if (force)
2692	}	2754	force->speed_left = -1.f; // patch old speed up
2693	else	2755	else
2694	map->play_sound (sound, x, y);	2756	{
2695	}	2757	force = archetype::get (shstr_noise_force);
2696		2758
		2759	force->slaying = shstr_noise_force;
		2760	force->stats.food = 1;
		2761	force->speed_left = -1.f;
		2762
		2763	force->set_speed (1.f / 4.f);
		2764	force->flag [FLAG_IS_USED_UP] = true;
		2765	force->flag [FLAG_APPLIED] = true;
		2766
		2767	insert (force);
		2768	}
		2769	}
		2770
		2771	void object::change_move_type (MoveType mt)
		2772	{
		2773	if (move_type == mt)
		2774	return;
		2775
		2776	if (is_on_map ())
		2777	{
		2778	// we are on the map, so handle move_on/off effects
		2779	remove ();
		2780	move_type = mt;
		2781	map->insert (this, x, y, this);
		2782	}
		2783	else
		2784	move_type = mt;
		2785	}
		2786
		2787	/* object should be a player.
		2788	* we return the object the player has marked with the 'mark' command
		2789	* below. If no match is found (or object has changed), we return
		2790	* NULL. We leave it up to the calling function to print messages if
		2791	* nothing is found.
		2792	*/
		2793	object *
		2794	object::mark () const
		2795	{
		2796	if (contr && contr->mark && contr->mark->env == this)
		2797	return contr->mark;
		2798	else
		2799	return 0;
		2800	}
		2801

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines