ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.215 by root, Tue Apr 22 07:28:05 2008 UTC vs.
Revision 1.231 by root, Sun May 4 11:12:40 2008 UTC

… …
139 139
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 141static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
143{ 143{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
149 */ 147 */
150 148
151 /* For each field in wants, */ 149 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 151 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 152 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 153
169 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 155 return true;
171} 156}
172 157
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 159static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 161{
177 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
179 */ 164 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
181} 167}
182 168
183/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 170 * they can be merged together.
185 * 171 *
… …
334 320
335// find player who can see this object 321// find player who can see this object
336object * 322object *
337object::visible_to () const 323object::visible_to () const
338{ 324{
339 if (!flag [FLAG_REMOVED]) 325 if (client_visible () && !flag [FLAG_REMOVED])
340 { 326 {
341 // see if we are in a container of sorts 327 // see if we are in a container of sorts
342 if (env) 328 if (env)
343 { 329 {
344 // the player inventory itself is always visible 330 // the player inventory itself is always visible
… …
358 else 344 else
359 { 345 {
360 // maybe there is a player standing on the same mapspace 346 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 347 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 348 if (object *pl = ms ().player ())
349 if (!pl->container || this == pl->container)
363 return pl; 350 return pl;
364 } 351 }
365 } 352 }
366 353
367 return 0; 354 return 0;
368} 355}
… …
602 } 589 }
603 590
604 op->key_values = 0; 591 op->key_values = 0;
605} 592}
606 593
607object & 594/*
608object::operator =(const object &src) 595 * copy_to first frees everything allocated by the dst object,
596 * and then copies the contents of itself into the second
597 * object, allocating what needs to be allocated. Basically, any
598 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
599 * if the first object is freed, the pointers in the new object
600 * will point at garbage.
601 */
602void
603object::copy_to (object *dst)
609{ 604{
610 bool is_freed = flag [FLAG_FREED]; 605 dst->remove ();
611 bool is_removed = flag [FLAG_REMOVED];
612
613 *(object_copy *)this = src; 606 *(object_copy *)dst = *this;
614
615 flag [FLAG_FREED] = is_freed;
616 flag [FLAG_REMOVED] = is_removed; 607 dst->flag [FLAG_REMOVED] = true;
617 608
618 /* Copy over key_values, if any. */ 609 /* Copy over key_values, if any. */
619 if (src.key_values) 610 if (key_values)
620 { 611 {
621 key_value *tail = 0; 612 key_value *tail = 0;
622 key_values = 0; 613 dst->key_values = 0;
623 614
624 for (key_value *i = src.key_values; i; i = i->next) 615 for (key_value *i = key_values; i; i = i->next)
625 { 616 {
626 key_value *new_link = new key_value; 617 key_value *new_link = new key_value;
627 618
628 new_link->next = 0; 619 new_link->next = 0;
629 new_link->key = i->key; 620 new_link->key = i->key;
630 new_link->value = i->value; 621 new_link->value = i->value;
631 622
632 /* Try and be clever here, too. */ 623 /* Try and be clever here, too. */
633 if (!key_values) 624 if (!dst->key_values)
634 { 625 {
635 key_values = new_link; 626 dst->key_values = new_link;
636 tail = new_link; 627 tail = new_link;
637 } 628 }
638 else 629 else
639 { 630 {
640 tail->next = new_link; 631 tail->next = new_link;
641 tail = new_link; 632 tail = new_link;
642 } 633 }
643 } 634 }
644 } 635 }
645}
646
647/*
648 * copy_to first frees everything allocated by the dst object,
649 * and then copies the contents of itself into the second
650 * object, allocating what needs to be allocated. Basically, any
651 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
652 * if the first object is freed, the pointers in the new object
653 * will point at garbage.
654 */
655void
656object::copy_to (object *dst)
657{
658 *dst = *this;
659 636
660 if (speed < 0) 637 if (speed < 0)
661 dst->speed_left -= rndm (); 638 dst->speed_left -= rndm ();
662 639
663 dst->set_speed (dst->speed); 640 dst->set_speed (dst->speed);
… …
685object * 662object *
686object::clone () 663object::clone ()
687{ 664{
688 object *neu = create (); 665 object *neu = create ();
689 copy_to (neu); 666 copy_to (neu);
667 neu->map = map; // not copied by copy_to
690 return neu; 668 return neu;
691} 669}
692 670
693/* 671/*
694 * If an object with the IS_TURNABLE() flag needs to be turned due 672 * If an object with the IS_TURNABLE() flag needs to be turned due
… …
745 * UP_OBJ_FACE: only the objects face has changed. 723 * UP_OBJ_FACE: only the objects face has changed.
746 */ 724 */
747void 725void
748update_object (object *op, int action) 726update_object (object *op, int action)
749{ 727{
750 if (op == NULL) 728 if (!op)
751 { 729 {
752 /* this should never happen */ 730 /* this should never happen */
753 LOG (llevDebug, "update_object() called for NULL object.\n"); 731 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754 return; 732 return;
755 } 733 }
756 734
757 if (op->env) 735 if (!op->is_on_map ())
758 { 736 {
759 /* Animation is currently handled by client, so nothing 737 /* Animation is currently handled by client, so nothing
760 * to do in this case. 738 * to do in this case.
761 */ 739 */
762 return; 740 return;
763 } 741 }
764
765 /* If the map is saving, don't do anything as everything is
766 * going to get freed anyways.
767 */
768 if (!op->map || op->map->in_memory == MAP_SAVING)
769 return;
770 742
771 /* make sure the object is within map boundaries */ 743 /* make sure the object is within map boundaries */
772 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 744 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773 { 745 {
774 LOG (llevError, "update_object() called for object out of map!\n"); 746 LOG (llevError, "update_object() called for object out of map!\n");
… …
917object::destroy_inv (bool drop_to_ground) 889object::destroy_inv (bool drop_to_ground)
918{ 890{
919 // need to check first, because the checks below might segfault 891 // need to check first, because the checks below might segfault
920 // as we might be on an invalid mapspace and crossfire code 892 // as we might be on an invalid mapspace and crossfire code
921 // is too buggy to ensure that the inventory is empty. 893 // is too buggy to ensure that the inventory is empty.
922 // corollary: if you create arrows etc. with stuff in tis inventory, 894 // corollary: if you create arrows etc. with stuff in its inventory,
923 // cf will crash below with off-map x and y 895 // cf will crash below with off-map x and y
924 if (!inv) 896 if (!inv)
925 return; 897 return;
926 898
927 /* Only if the space blocks everything do we not process - 899 /* Only if the space blocks everything do we not process -
… …
934 || map->nodrop 906 || map->nodrop
935 || ms ().move_block == MOVE_ALL) 907 || ms ().move_block == MOVE_ALL)
936 { 908 {
937 while (inv) 909 while (inv)
938 { 910 {
939 inv->destroy_inv (drop_to_ground); 911 inv->destroy_inv (false);
940 inv->destroy (); 912 inv->destroy ();
941 } 913 }
942 } 914 }
943 else 915 else
944 { /* Put objects in inventory onto this space */ 916 { /* Put objects in inventory onto this space */
… …
950 || op->flag [FLAG_NO_DROP] 922 || op->flag [FLAG_NO_DROP]
951 || op->type == RUNE 923 || op->type == RUNE
952 || op->type == TRAP 924 || op->type == TRAP
953 || op->flag [FLAG_IS_A_TEMPLATE] 925 || op->flag [FLAG_IS_A_TEMPLATE]
954 || op->flag [FLAG_DESTROY_ON_DEATH]) 926 || op->flag [FLAG_DESTROY_ON_DEATH])
955 op->destroy (); 927 op->destroy (true);
956 else 928 else
957 map->insert (op, x, y); 929 map->insert (op, x, y);
958 } 930 }
959 } 931 }
960} 932}
… …
964 object *op = new object; 936 object *op = new object;
965 op->link (); 937 op->link ();
966 return op; 938 return op;
967} 939}
968 940
941static struct freed_map : maptile
942{
943 freed_map ()
944 {
945 path = "<freed objects map>";
946 name = "/internal/freed_objects_map";
947 width = 3;
948 height = 3;
949 nodrop = 1;
950
951 alloc ();
952 in_memory = MAP_ACTIVE;
953 }
954
955 ~freed_map ()
956 {
957 destroy ();
958 }
959} freed_map; // freed objects are moved here to avoid crashes
960
969void 961void
970object::do_destroy () 962object::do_destroy ()
971{ 963{
972 if (flag [FLAG_IS_LINKED]) 964 if (flag [FLAG_IS_LINKED])
973 remove_button_link (this); 965 remove_button_link (this);
… …
977 969
978 remove (); 970 remove ();
979 971
980 attachable::do_destroy (); 972 attachable::do_destroy ();
981 973
982 destroy_inv (true);
983
984 deactivate (); 974 deactivate ();
985 unlink (); 975 unlink ();
986 976
987 flag [FLAG_FREED] = 1; 977 flag [FLAG_FREED] = 1;
988 978
989 // hack to ensure that freed objects still have a valid map 979 // hack to ensure that freed objects still have a valid map
990 {
991 static maptile *freed_map; // freed objects are moved here to avoid crashes
992
993 if (!freed_map)
994 {
995 freed_map = new maptile;
996
997 freed_map->path = "<freed objects map>";
998 freed_map->name = "/internal/freed_objects_map";
999 freed_map->width = 3;
1000 freed_map->height = 3;
1001 freed_map->nodrop = 1;
1002
1003 freed_map->alloc ();
1004 freed_map->in_memory = MAP_ACTIVE;
1005 }
1006
1007 map = freed_map; 980 map = &freed_map;
1008 x = 1; 981 x = 1;
1009 y = 1; 982 y = 1;
1010 }
1011 983
1012 if (more) 984 if (more)
1013 { 985 {
1014 more->destroy (); 986 more->destroy ();
1015 more = 0; 987 more = 0;
… …
1028object::destroy (bool destroy_inventory) 1000object::destroy (bool destroy_inventory)
1029{ 1001{
1030 if (destroyed ()) 1002 if (destroyed ())
1031 return; 1003 return;
1032 1004
1005 if (!is_head () && !head->destroyed ())
1006 {
1007 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1008 head->destroy (destroy_inventory);
1009 return;
1010 }
1011
1033 if (destroy_inventory) 1012 destroy_inv (!destroy_inventory);
1034 destroy_inv (false);
1035 1013
1036 if (is_head ()) 1014 if (is_head ())
1037 if (sound_destroy) 1015 if (sound_destroy)
1038 play_sound (sound_destroy); 1016 play_sound (sound_destroy);
1039 else if (flag [FLAG_MONSTER]) 1017 else if (flag [FLAG_MONSTER])
… …
1058 if (flag [FLAG_REMOVED]) 1036 if (flag [FLAG_REMOVED])
1059 return; 1037 return;
1060 1038
1061 INVOKE_OBJECT (REMOVE, this); 1039 INVOKE_OBJECT (REMOVE, this);
1062 1040
1063 if (object *pl = visible_to ())
1064 esrv_del_item (pl->contr, count);
1065
1066 flag [FLAG_REMOVED] = true; 1041 flag [FLAG_REMOVED] = true;
1067 1042
1068 if (more) 1043 if (more)
1069 more->remove (); 1044 more->remove ();
1070 1045
… …
1072 * In this case, the object to be removed is in someones 1047 * In this case, the object to be removed is in someones
1073 * inventory. 1048 * inventory.
1074 */ 1049 */
1075 if (env) 1050 if (env)
1076 { 1051 {
1052 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1053 if (object *pl = visible_to ())
1054 esrv_del_item (pl->contr, count);
1055 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1056
1077 adjust_weight (env, -total_weight ()); 1057 adjust_weight (env, -total_weight ());
1078 1058
1079 *(above ? &above->below : &env->inv) = below; 1059 *(above ? &above->below : &env->inv) = below;
1080 1060
1081 if (below) 1061 if (below)
… …
1099 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1079 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1100 otmp->update_stats (); 1080 otmp->update_stats ();
1101 } 1081 }
1102 else if (map) 1082 else if (map)
1103 { 1083 {
1104 if (type == PLAYER)
1105 {
1106 // leaving a spot always closes any open container on the ground
1107 if (container && !container->env)
1108 // this causes spurious floorbox updates, but it ensures
1109 // that the CLOSE event is being sent.
1110 close_container ();
1111
1112 --map->players;
1113 map->touch ();
1114 }
1115
1116 map->dirty = true; 1084 map->dirty = true;
1117 mapspace &ms = this->ms (); 1085 mapspace &ms = this->ms ();
1086
1087 if (object *pl = ms.player ())
1088 {
1089 if (type == PLAYER) // this == pl(!)
1090 {
1091 // leaving a spot always closes any open container on the ground
1092 if (container && !container->env)
1093 // this causes spurious floorbox updates, but it ensures
1094 // that the CLOSE event is being sent.
1095 close_container ();
1096
1097 --map->players;
1098 map->touch ();
1099 }
1100 else if (pl->container == this)
1101 {
1102 // removing a container should close it
1103 close_container ();
1104 }
1105
1106 esrv_del_item (pl->contr, count);
1107 }
1118 1108
1119 /* link the object above us */ 1109 /* link the object above us */
1120 if (above) 1110 if (above)
1121 above->below = below; 1111 above->below = below;
1122 else 1112 else
… …
1152 * removed (most likely destroyed), update the player view 1142 * removed (most likely destroyed), update the player view
1153 * appropriately. 1143 * appropriately.
1154 */ 1144 */
1155 pl->close_container (); 1145 pl->close_container ();
1156 1146
1147 //TODO: the floorbox prev/next might need updating
1148 //esrv_del_item (pl->contr, count);
1149 //TODO: update floorbox to preserve ordering
1150 if (pl->contr->ns)
1157 pl->contr->ns->floorbox_update (); 1151 pl->contr->ns->floorbox_update ();
1158 } 1152 }
1159 1153
1160 for (tmp = ms.bot; tmp; tmp = tmp->above) 1154 for (tmp = ms.bot; tmp; tmp = tmp->above)
1161 { 1155 {
1162 /* No point updating the players look faces if he is the object 1156 /* No point updating the players look faces if he is the object
… …
1288object * 1282object *
1289insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1283insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1290{ 1284{
1291 assert (!op->flag [FLAG_FREED]); 1285 assert (!op->flag [FLAG_FREED]);
1292 1286
1293 object *top, *floor = NULL;
1294
1295 op->remove (); 1287 op->remove ();
1296 1288
1297 /* Ideally, the caller figures this out. However, it complicates a lot 1289 /* Ideally, the caller figures this out. However, it complicates a lot
1298 * of areas of callers (eg, anything that uses find_free_spot would now 1290 * of areas of callers (eg, anything that uses find_free_spot would now
1299 * need extra work 1291 * need extra work
1300 */ 1292 */
1301 if (!xy_normalise (m, op->x, op->y)) 1293 if (!xy_normalise (m, op->x, op->y))
1302 { 1294 {
1303 op->destroy (); 1295 op->destroy (1);
1304 return 0; 1296 return 0;
1305 } 1297 }
1306 1298
1307 if (object *more = op->more) 1299 if (object *more = op->more)
1308 if (!insert_ob_in_map (more, m, originator, flag)) 1300 if (!insert_ob_in_map (more, m, originator, flag))
… …
1317 */ 1309 */
1318 if (op->nrof && !(flag & INS_NO_MERGE)) 1310 if (op->nrof && !(flag & INS_NO_MERGE))
1319 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1311 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1320 if (object::can_merge (op, tmp)) 1312 if (object::can_merge (op, tmp))
1321 { 1313 {
1314 // TODO: we atcually want to update tmp, not op,
1315 // but some caller surely breaks when we return tmp
1316 // from here :/
1322 op->nrof += tmp->nrof; 1317 op->nrof += tmp->nrof;
1323 tmp->destroy (1); 1318 tmp->destroy (1);
1324 } 1319 }
1325 1320
1326 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1321 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
… …
1348 /* since *below* originator, no need to update top */ 1343 /* since *below* originator, no need to update top */
1349 originator->below = op; 1344 originator->below = op;
1350 } 1345 }
1351 else 1346 else
1352 { 1347 {
1348 object *top, *floor = NULL;
1349
1353 top = ms.bot; 1350 top = ms.bot;
1354 1351
1355 /* If there are other objects, then */ 1352 /* If there are other objects, then */
1356 if (top) 1353 if (top)
1357 { 1354 {
… …
1456 } 1453 }
1457 1454
1458 op->map->dirty = true; 1455 op->map->dirty = true;
1459 1456
1460 if (object *pl = ms.player ()) 1457 if (object *pl = ms.player ())
1458 //TODO: the floorbox prev/next might need updating
1459 //esrv_send_item (pl, op);
1460 //TODO: update floorbox to preserve ordering
1461 if (pl->contr->ns)
1461 pl->contr->ns->floorbox_update (); 1462 pl->contr->ns->floorbox_update ();
1462 1463
1463 /* If this object glows, it may affect lighting conditions that are 1464 /* If this object glows, it may affect lighting conditions that are
1464 * visible to others on this map. But update_all_los is really 1465 * visible to others on this map. But update_all_los is really
1465 * an inefficient way to do this, as it means los for all players 1466 * an inefficient way to do this, as it means los for all players
1466 * on the map will get recalculated. The players could very well 1467 * on the map will get recalculated. The players could very well
… …
1586 } 1587 }
1587 else 1588 else
1588 { 1589 {
1589 decrease (nr); 1590 decrease (nr);
1590 1591
1591 object *op = object_create_clone (this); 1592 object *op = deep_clone ();
1592 op->nrof = nr; 1593 op->nrof = nr;
1593 return op; 1594 return op;
1594 } 1595 }
1595} 1596}
1596 1597
… …
1817 LOG (llevError, "Present_arch called outside map.\n"); 1818 LOG (llevError, "Present_arch called outside map.\n");
1818 return NULL; 1819 return NULL;
1819 } 1820 }
1820 1821
1821 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1822 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1822 if (tmp->arch == at) 1823 if (tmp->arch->archname == at->archname)
1823 return tmp; 1824 return tmp;
1824 1825
1825 return NULL; 1826 return NULL;
1826} 1827}
1827 1828
… …
1891 * The first matching object is returned, or NULL if none. 1892 * The first matching object is returned, or NULL if none.
1892 */ 1893 */
1893object * 1894object *
1894present_arch_in_ob (const archetype *at, const object *op) 1895present_arch_in_ob (const archetype *at, const object *op)
1895{ 1896{
1896 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1897 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1897 if (tmp->arch == at) 1898 if (tmp->arch->archname == at->archname)
1898 return tmp; 1899 return tmp;
1899 1900
1900 return NULL; 1901 return NULL;
1901} 1902}
1902 1903
… …
2311 2312
2312/* 2313/*
2313 * create clone from object to another 2314 * create clone from object to another
2314 */ 2315 */
2315object * 2316object *
2316object_create_clone (object *asrc) 2317object::deep_clone ()
2317{ 2318{
2318 object *dst = 0, *tmp, *src, *prev, *item; 2319 assert (("deep_clone called on non-head object", is_head ()));
2319 2320
2320 if (!asrc) 2321 object *dst = clone ();
2321 return 0;
2322 2322
2323 src = asrc->head_ (); 2323 object *prev = dst;
2324
2325 prev = 0;
2326 for (object *part = src; part; part = part->more) 2324 for (object *part = this->more; part; part = part->more)
2327 { 2325 {
2328 tmp = part->clone (); 2326 object *tmp = part->clone ();
2329 tmp->x -= src->x;
2330 tmp->y -= src->y;
2331
2332 if (!part->head)
2333 {
2334 dst = tmp;
2335 tmp->head = 0;
2336 }
2337 else
2338 tmp->head = dst; 2327 tmp->head = dst;
2339
2340 tmp->more = 0;
2341
2342 if (prev)
2343 prev->more = tmp; 2328 prev->more = tmp;
2344
2345 prev = tmp; 2329 prev = tmp;
2346 } 2330 }
2347 2331
2348 for (item = src->inv; item; item = item->below) 2332 for (object *item = inv; item; item = item->below)
2349 insert_ob_in_ob (object_create_clone (item), dst); 2333 insert_ob_in_ob (item->deep_clone (), dst);
2350 2334
2351 return dst; 2335 return dst;
2352} 2336}
2353 2337
2354/* This returns the first object in who's inventory that 2338/* This returns the first object in who's inventory that
… …
2363 return tmp; 2347 return tmp;
2364 2348
2365 return 0; 2349 return 0;
2366} 2350}
2367 2351
2368/* If ob has a field named key, return the link from the list, 2352const shstr &
2369 * otherwise return NULL. 2353object::kv_get (const shstr &key) const
2370 *
2371 * key must be a passed in shared string - otherwise, this won't
2372 * do the desired thing.
2373 */
2374key_value *
2375get_ob_key_link (const object *ob, const char *key)
2376{ 2354{
2377 for (key_value *link = ob->key_values; link; link = link->next) 2355 for (key_value *kv = key_values; kv; kv = kv->next)
2378 if (link->key == key) 2356 if (kv->key == key)
2379 return link;
2380
2381 return 0;
2382}
2383
2384/*
2385 * Returns the value of op has an extra_field for key, or NULL.
2386 *
2387 * The argument doesn't need to be a shared string.
2388 *
2389 * The returned string is shared.
2390 */
2391const char *
2392get_ob_key_value (const object *op, const char *const key)
2393{
2394 key_value *link;
2395 shstr_cmp canonical_key (key);
2396
2397 if (!canonical_key)
2398 {
2399 /* 1. There being a field named key on any object
2400 * implies there'd be a shared string to find.
2401 * 2. Since there isn't, no object has this field.
2402 * 3. Therefore, *this* object doesn't have this field.
2403 */
2404 return 0;
2405 }
2406
2407 /* This is copied from get_ob_key_link() above -
2408 * only 4 lines, and saves the function call overhead.
2409 */
2410 for (link = op->key_values; link; link = link->next)
2411 if (link->key == canonical_key)
2412 return link->value; 2357 return kv->value;
2413 2358
2414 return 0; 2359 return shstr_null;
2415} 2360}
2416 2361
2417/* 2362void
2418 * Updates the canonical_key in op to value. 2363object::kv_set (const shstr &key, const shstr &value)
2419 *
2420 * canonical_key is a shared string (value doesn't have to be).
2421 *
2422 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2423 * keys.
2424 *
2425 * Returns TRUE on success.
2426 */
2427int
2428set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2429{ 2364{
2430 key_value *field = NULL, *last = NULL; 2365 for (key_value *kv = key_values; kv; kv = kv->next)
2431 2366 if (kv->key == key)
2432 for (field = op->key_values; field != NULL; field = field->next)
2433 {
2434 if (field->key != canonical_key)
2435 { 2367 {
2436 last = field; 2368 kv->value = value;
2437 continue; 2369 return;
2438 } 2370 }
2439 2371
2440 if (value) 2372 key_value *kv = new key_value;
2441 field->value = value; 2373
2442 else 2374 kv->next = key_values;
2375 kv->key = key;
2376 kv->value = value;
2377
2378 key_values = kv;
2379}
2380
2381void
2382object::kv_del (const shstr &key)
2383{
2384 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2385 if ((*kvp)->key == key)
2443 { 2386 {
2444 /* Basically, if the archetype has this key set, 2387 key_value *kv = *kvp;
2445 * we need to store the null value so when we save 2388 *kvp = (*kvp)->next;
2446 * it, we save the empty value so that when we load, 2389 delete kv;
2447 * we get this value back again. 2390 return;
2448 */
2449 if (get_ob_key_link (op->arch, canonical_key))
2450 field->value = 0;
2451 else
2452 {
2453 if (last)
2454 last->next = field->next;
2455 else
2456 op->key_values = field->next;
2457
2458 delete field;
2459 }
2460 } 2391 }
2461 return TRUE;
2462 }
2463 /* IF we get here, key doesn't exist */
2464
2465 /* No field, we'll have to add it. */
2466
2467 if (!add_key)
2468 return FALSE;
2469
2470 /* There isn't any good reason to store a null
2471 * value in the key/value list. If the archetype has
2472 * this key, then we should also have it, so shouldn't
2473 * be here. If user wants to store empty strings,
2474 * should pass in ""
2475 */
2476 if (value == NULL)
2477 return TRUE;
2478
2479 field = new key_value;
2480
2481 field->key = canonical_key;
2482 field->value = value;
2483 /* Usual prepend-addition. */
2484 field->next = op->key_values;
2485 op->key_values = field;
2486
2487 return TRUE;
2488}
2489
2490/*
2491 * Updates the key in op to value.
2492 *
2493 * If add_key is FALSE, this will only update existing keys,
2494 * and not add new ones.
2495 * In general, should be little reason FALSE is ever passed in for add_key
2496 *
2497 * Returns TRUE on success.
2498 */
2499int
2500set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2501{
2502 shstr key_ (key);
2503
2504 return set_ob_key_value_s (op, key_, value, add_key);
2505} 2392}
2506 2393
2507object::depth_iterator::depth_iterator (object *container) 2394object::depth_iterator::depth_iterator (object *container)
2508: iterator_base (container) 2395: iterator_base (container)
2509{ 2396{
… …
2567 &name, 2454 &name,
2568 title ? "\",title:\"" : "", 2455 title ? "\",title:\"" : "",
2569 title ? (const char *)title : "", 2456 title ? (const char *)title : "",
2570 flag_desc (flagdesc, 512), type); 2457 flag_desc (flagdesc, 512), type);
2571 2458
2572 if (!this->flag[FLAG_REMOVED] && env) 2459 if (!flag[FLAG_REMOVED] && env)
2573 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2460 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2574 2461
2575 if (map) 2462 if (map)
2576 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2463 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2577 2464
… …
2607object::open_container (object *new_container) 2494object::open_container (object *new_container)
2608{ 2495{
2609 if (container == new_container) 2496 if (container == new_container)
2610 return; 2497 return;
2611 2498
2612 if (object *old_container = container) 2499 object *old_container = container;
2500
2501 if (old_container)
2613 { 2502 {
2614 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2503 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2615 return; 2504 return;
2616 2505
2617#if 0 2506#if 0
… …
2619 if (object *closer = old_container->inv) 2508 if (object *closer = old_container->inv)
2620 if (closer->type == CLOSE_CON) 2509 if (closer->type == CLOSE_CON)
2621 closer->destroy (); 2510 closer->destroy ();
2622#endif 2511#endif
2623 2512
2513 // make sure the container is available
2514 esrv_send_item (this, old_container);
2515
2624 old_container->flag [FLAG_APPLIED] = 0; 2516 old_container->flag [FLAG_APPLIED] = false;
2625 container = 0; 2517 container = 0;
2626 2518
2519 // client needs item update to make it work, client bug requires this to be separate
2627 esrv_update_item (UPD_FLAGS, this, old_container); 2520 esrv_update_item (UPD_FLAGS, this, old_container);
2521
2628 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2522 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2629 play_sound (sound_find ("chest_close")); 2523 play_sound (sound_find ("chest_close"));
2630 } 2524 }
2631 2525
2632 if (new_container) 2526 if (new_container)
… …
2645 } 2539 }
2646#endif 2540#endif
2647 2541
2648 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2542 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2649 2543
2544 // make sure the container is available, client bug requires this to be separate
2545 esrv_send_item (this, new_container);
2546
2650 new_container->flag [FLAG_APPLIED] = 1; 2547 new_container->flag [FLAG_APPLIED] = true;
2651 container = new_container; 2548 container = new_container;
2652 2549
2550 // client needs flag change
2653 esrv_update_item (UPD_FLAGS, this, new_container); 2551 esrv_update_item (UPD_FLAGS, this, new_container);
2654 esrv_send_inventory (this, new_container); 2552 esrv_send_inventory (this, new_container);
2655 play_sound (sound_find ("chest_open")); 2553 play_sound (sound_find ("chest_open"));
2656 } 2554 }
2555// else if (!old_container->env && contr && contr->ns)
2556// contr->ns->floorbox_reset ();
2657} 2557}
2658 2558
2659object * 2559object *
2660object::force_find (const shstr name) 2560object::force_find (const shstr name)
2661{ 2561{

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines