ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.216 by root, Tue Apr 22 23:50:23 2008 UTC vs.
Revision 1.317 by root, Fri Apr 2 03:41:24 2010 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
25	#include <stdio.h>	26	#include <stdio.h>
26	#include <sys/types.h>	27	#include <sys/types.h>
27	#include <sys/uio.h>	28	#include <sys/uio.h>
28	#include <object.h>	29	#include <object.h>
29	#include <sproto.h>	30	#include <sproto.h>
30	#include <loader.h>
31		31
32	#include <bitset>	32	#include <bitset>
33		33
34	UUID UUID::cur;	34	UUID UUID::cur;
35	static uint64_t seq_next_save;	35	static uint64_t seq_next_save;
36	static const uint64 UUID_GAP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
37		38
38	objectvec objects;	39	objectvec objects;
39	activevec actives;	40	activevec actives;
		41
		42	//+GPL
40		43
41	short freearr_x[SIZEOFFREE] = {	44	short freearr_x[SIZEOFFREE] = {
42	0,	45	0,
43	0, 1, 1, 1, 0, -1, -1, -1,	46	0, 1, 1, 1, 0, -1, -1, -1,
44	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	47	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
…		…
48	0,	51	0,
49	-1, -1, 0, 1, 1, 1, 0, -1,	52	-1, -1, 0, 1, 1, 1, 0, -1,
50	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	53	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	54	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52	};	55	};
53	int maxfree[SIZEOFFREE] = {
54	0,
55	9, 10, 13, 14, 17, 18, 21, 22,
56	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58	};
59	int freedir[SIZEOFFREE] = {	56	int freedir[SIZEOFFREE] = {
60	0,	57	0,
61	1, 2, 3, 4, 5, 6, 7, 8,	58	1, 2, 3, 4, 5, 6, 7, 8,
62	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	59	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	60	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64	};	61	};
65		62
		63	static int maxfree[SIZEOFFREE] = {
		64	0,
		65	9, 10, 13, 14, 17, 18, 21, 22,
		66	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
		67	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
		68	};
		69
66	static void	70	static void
67	write_uuid (uval64 skip, bool sync)	71	write_uuid (uval64 skip, bool sync)
68	{	72	{
69	CALL_BEGIN (2);	73	CALL_BEGIN (2);
70	CALL_ARG_SV (newSVval64 (skip));	74	CALL_ARG_SV (newSVval64 (skip));
…		…
72	CALL_CALL ("cf::write_uuid", G_DISCARD);	76	CALL_CALL ("cf::write_uuid", G_DISCARD);
73	CALL_END;	77	CALL_END;
74	}	78	}
75		79
76	static void	80	static void
77	read_uuid (void)	81	read_uuid ()
78	{	82	{
79	char filename[MAX_BUF];	83	char filename[MAX_BUF];
80		84
81	sprintf (filename, "%s/uuid", settings.localdir);	85	sprintf (filename, "%s/uuid", settings.localdir);
82		86
…		…
96		100
97	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	101	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98	_exit (1);	102	_exit (1);
99	}	103	}
100		104
101	UUID::BUF buf;	105	char buf [UUID::MAX_LEN];
102	buf[0] = 0;	106	buf[0] = 0;
103	fgets (buf, sizeof (buf), fp);	107	fgets (buf, sizeof (buf), fp);
104		108
105	if (!UUID::cur.parse (buf))	109	if (!UUID::cur.parse (buf))
106	{	110	{
…		…
133		137
134	void	138	void
135	UUID::init ()	139	UUID::init ()
136	{	140	{
137	read_uuid ();	141	read_uuid ();
		142	}
		143
		144	bool
		145	UUID::parse (const char *s)
		146	{
		147	if (*s++ != '<' || *s++ != '1' || *s++ != '.')
		148	return false;
		149
		150	seq = 0;
		151
		152	while (*s != '>')
		153	{
		154	if (*s < '0')
		155	return false;
		156
		157	// this gives nice branchless code with gcc
		158	assert ('0' < 'a' && '0' == 48 && 'a' == 97);
		159	int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
		160
		161	seq = (seq << 4) | digit;
		162
		163	++s;
		164	}
		165
		166	return true;
		167	}
		168
		169	char *
		170	UUID::append (char *buf) const
		171	{
		172	*buf++ = '<';
		173	*buf++ = '1';
		174	*buf++ = '.';
		175
		176	uint64_t seq = this->seq;
		177	const int bits = 64;
		178	char nz = 0;
		179	static const char tohex [] = "0123456789abcdef";
		180
		181	// assert (len >= 3 + bits / 4 + 1 + 1);
		182	for (int i = bits / 4; --i; )
		183	{
		184	uint8_t digit = seq >> (bits - 4);
		185
		186	*buf = tohex [digit];
		187	nz |= digit;
		188	buf += nz ? 1 : 0;
		189	seq <<= 4;
		190	}
		191
		192	// last digit is special - always emit
		193	uint8_t digit = seq >> (bits - 4);
		194	*buf++ = tohex [digit];
		195
		196	*buf++ = '>';
		197
		198	return buf;
		199	}
		200
		201	char *
		202	UUID::c_str () const
		203	{
		204	static char buf [MAX_LEN];
		205	*append (buf) = 0;
		206	return buf;
138	}	207	}
139		208
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	209	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	210	static bool
142	compare_ob_value_lists_one (const object *wants, const object *has)	211	compare_ob_value_lists_one (const object *wants, const object *has)
143	{	212	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	213	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	214	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	215	* different structure or at least keep the lists sorted...
149	*/	216	*/
150		217
151	/* For each field in wants, */	218	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	219	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	220	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	221	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		222
169	/* If we get here, every field in wants has a matching field in has. */	223	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	224	return true;
171	}	225	}
172		226
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	227	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	228	static bool
175	compare_ob_value_lists (const object *ob1, const object *ob2)	229	compare_ob_value_lists (const object *ob1, const object *ob2)
176	{	230	{
177	/* However, there may be fields in has which aren't partnered in wants,	231	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison *twice*. :(	232	* so we need to run the comparison *twice*. :(
179	*/	233	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	234	return compare_ob_value_lists_one (ob1, ob2)
		235	&& compare_ob_value_lists_one (ob2, ob1);
181	}	236	}
182		237
183	/* Function examines the 2 objects given to it, and returns true if	238	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	239	* they can be merged together.
185	*	240	*
…		…
192	* Improvements made with merge: Better checking on potion, and also	247	* Improvements made with merge: Better checking on potion, and also
193	* check weight	248	* check weight
194	*/	249	*/
195	bool object::can_merge_slow (object *ob1, object *ob2)	250	bool object::can_merge_slow (object *ob1, object *ob2)
196	{	251	{
197	/* A couple quicksanity checks */	252	/* A couple quick sanity checks */
198	if (ob1 == ob2	253	if (ob1 == ob2
199	|| ob1->type != ob2->type	254	|| ob1->type != ob2->type
200	|| ob1->speed != ob2->speed
201	|| ob1->value != ob2->value	255	|| ob1->value != ob2->value
202	|| ob1->name != ob2->name)	256	|| ob1->name != ob2->name
		257	|| fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
203	return 0;	258	return 0;
204		259
205	/* Do not merge objects if nrof would overflow. First part checks	260	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	261	* is always 0 .. 2**31-1 */
207	* would fit into a 32 bit signed int, which is often used to hold	262	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	263	return 0;
212		264
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	265	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	266	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	267	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	272	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		273
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	274	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	275	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		276
225	if (ob1->arch->name != ob2->arch->name	277	if (ob1->arch->archname != ob2->arch->archname
226	|| ob1->name != ob2->name	278	|| ob1->name != ob2->name
227	|| ob1->title != ob2->title	279	|| ob1->title != ob2->title
228	|| ob1->msg != ob2->msg	280	|| ob1->msg != ob2->msg
229	|| ob1->weight != ob2->weight	281	|| ob1->weight != ob2->weight
230	|| ob1->attacktype != ob2->attacktype	282	|| ob1->attacktype != ob2->attacktype
231	|| ob1->magic != ob2->magic	283	|| ob1->magic != ob2->magic
232	|| ob1->slaying != ob2->slaying	284	|| ob1->slaying != ob2->slaying
233	|| ob1->skill != ob2->skill	285	|| ob1->skill != ob2->skill
234	|| ob1->value != ob2->value	286	|| ob1->value != ob2->value
235	|| ob1->animation_id != ob2->animation_id	287	|| ob1->animation_id != ob2->animation_id
		288	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
236	|| ob1->client_type != ob2->client_type	289	|| ob1->client_type != ob2->client_type
237	|| ob1->materialname != ob2->materialname	290	|| ob1->material != ob2->material
238	|| ob1->lore != ob2->lore	291	|| ob1->lore != ob2->lore
239	|| ob1->subtype != ob2->subtype	292	|| ob1->subtype != ob2->subtype
240	|| ob1->move_type != ob2->move_type	293	|| ob1->move_type != ob2->move_type
241	|| ob1->move_block != ob2->move_block	294	|| ob1->move_block != ob2->move_block
242	|| ob1->move_allow != ob2->move_allow	295	|| ob1->move_allow != ob2->move_allow
243	|| ob1->move_on != ob2->move_on	296	|| ob1->move_on != ob2->move_on
244	|| ob1->move_off != ob2->move_off	297	|| ob1->move_off != ob2->move_off
245	|| ob1->move_slow != ob2->move_slow	298	|| ob1->move_slow != ob2->move_slow
246	|| ob1->move_slow_penalty != ob2->move_slow_penalty	299	|| fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))	300	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	301	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	302	return 0;
250		303
251	if ((ob1->flag ^ ob2->flag)	304	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	305	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	306	.reset (FLAG_REMOVED)
255	.any ())	307	.any ())
256	return 0;	308	return 0;
257		309
258	/* This is really a spellbook check - we should in general	310	/* This is really a spellbook check - we should in general
…		…
334		386
335	// find player who can see this object	387	// find player who can see this object
336	object *	388	object *
337	object::visible_to () const	389	object::visible_to () const
338	{	390	{
339	if (!flag [FLAG_REMOVED])	391	if (client_visible () && !flag [FLAG_REMOVED])
340	{	392	{
341	// see if we are in a container of sorts	393	// see if we are in a container of sorts
342	if (env)	394	if (env)
343	{	395	{
344	// the player inventory itself is always visible	396	// the player inventory itself is always visible
345	if (env->type == PLAYER)	397	if (env->is_player ())
346	return env;	398	return env;
347		399
348	// else a player could have our env open	400	// else a player could have our env open
349	object *envest = env->outer_env ();	401	object *envest = env->outer_env_or_self ();
350		402
351	// the player itself is always on a map, so we will find him here	403	// the player itself is always on a map, so we will find him here
352	// even if our inv is in a player.	404	// even if our inv is in a player.
353	if (envest->is_on_map ())	405	if (envest->is_on_map ())
354	if (object *pl = envest->ms ().player ())	406	if (object *pl = envest->ms ().player ())
355	if (pl->container == env)	407	if (pl->container_ () == env)
356	return pl;	408	return pl;
357	}	409	}
358	else	410	else
359	{	411	{
360	// maybe there is a player standing on the same mapspace	412	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	413	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	414	if (object *pl = ms ().player ())
		415	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		416	|| pl->container_ () == this)
363	return pl;	417	return pl;
364	}	418	}
365	}	419	}
366		420
367	return 0;	421	return 0;
368	}	422	}
369		423
370	// adjust weight per container type ("of holding")	424	// adjust weight per container type ("of holding")
371	static sint32	425	static sint32
372	weight_adjust (object *op, sint32 weight)	426	weight_adjust_for (object *op, sint32 weight)
373	{	427	{
374	return op->type == CONTAINER	428	return op->type == CONTAINER
375	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	429	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
376	: weight;	430	: weight;
377	}	431	}
…		…
383	static void	437	static void
384	adjust_weight (object *op, sint32 weight)	438	adjust_weight (object *op, sint32 weight)
385	{	439	{
386	while (op)	440	while (op)
387	{	441	{
		442	// adjust by actual difference to account for rounding errors
		443	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
388	weight = weight_adjust (op, weight);	444	weight = weight_adjust_for (op, op->carrying)
		445	- weight_adjust_for (op, op->carrying - weight);
389		446
390	if (!weight)	447	if (!weight)
391	return;	448	return;
392		449
393	op->carrying += weight;	450	op->carrying += weight;
…		…
416	op->update_weight ();	473	op->update_weight ();
417		474
418	sum += op->total_weight ();	475	sum += op->total_weight ();
419	}	476	}
420		477
421	sum = weight_adjust (this, sum);	478	sum = weight_adjust_for (this, sum);
422		479
423	if (sum != carrying)	480	if (sum != carrying)
424	{	481	{
425	carrying = sum;	482	carrying = sum;
426		483
…		…
442	object_freezer freezer;	499	object_freezer freezer;
443	op->write (freezer);	500	op->write (freezer);
444	return freezer.as_string ();	501	return freezer.as_string ();
445	}	502	}
446		503
447	/*	504	char *
448	* get_nearest_part(multi-object, object 2) returns the part of the	505	object::as_string ()
449	* multi-object 1 which is closest to the second object.
450	* If it's not a multi-object, it is returned.
451	*/
452	object *
453	get_nearest_part (object *op, const object *pl)
454	{	506	{
455	object *tmp, *closest;	507	return dump_object (this);
456	int last_dist, i;
457
458	if (!op->more)
459	return op;
460
461	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
462	tmp;
463	tmp = tmp->more)
464	if ((i = distance (tmp, pl)) < last_dist)
465	closest = tmp, last_dist = i;
466
467	return closest;
468	}	508	}
469		509
470	/*	510	/*
471	* Returns the object which has the count-variable equal to the argument.	511	* Returns the object which has the count-variable equal to the argument.
472	* VERRRY slow.	512	* VERRRY slow.
…		…
480		520
481	return 0;	521	return 0;
482	}	522	}
483		523
484	/*	524	/*
		525	* Returns the object which has the uuid equal to the argument.
		526	* MOAR VERRRY slow.
		527	*/
		528
		529	object *
		530	find_object_uuid (UUID i)
		531	{
		532	for_all_objects (op)
		533	if (op->uuid == i)
		534	return op;
		535
		536	return 0;
		537	}
		538
		539	/*
485	* Returns the first object which has a name equal to the argument.	540	* Returns the first object which has a name equal to the argument.
486	* Used only by the patch command, but not all that useful.	541	* Used only by the patch command, but not all that useful.
487	* Enables features like "patch <name-of-other-player> food 999"	542	* Enables features like "patch <name-of-other-player> food 999"
488	*/	543	*/
489	object *	544	object *
490	find_object_name (const char *str)	545	find_object_name (const char *str)
491	{	546	{
492	shstr_cmp str_ (str);	547	shstr_cmp str_ (str);
493	object *op;
494		548
		549	if (str_)
495	for_all_objects (op)	550	for_all_objects (op)
496	if (op->name == str_)	551	if (op->name == str_)
497	break;	552	return op;
498		553
499	return op;	554	return 0;
500	}	555	}
501		556
502	/*	557	/*
503	* Sets the owner and sets the skill and exp pointers to owner's current	558	* Sets the owner and sets the skill and exp pointers to owner's current
504	* skill and experience objects.	559	* skill and experience objects.
…		…
542	object::change_weapon (object *ob)	597	object::change_weapon (object *ob)
543	{	598	{
544	if (current_weapon == ob)	599	if (current_weapon == ob)
545	return true;	600	return true;
546		601
547	if (chosen_skill)	602	if (current_weapon && current_weapon->flag [FLAG_APPLIED])
548	chosen_skill->flag [FLAG_APPLIED] = false;
549
550	current_weapon = ob;
551	chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
552
553	if (chosen_skill)
554	chosen_skill->flag [FLAG_APPLIED] = true;
555
556	update_stats ();
557
558	if (ob)
559	{
560	// now check wether any body locations became invalid, in which case
561	// we cannot apply the weapon at the moment.
562	for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
563	if (slot[i].used < 0)
564	{
565	current_weapon = chosen_skill = 0;
566	update_stats ();
567
568	new_draw_info_format (NDI_UNIQUE, 0, this,
569	"You try to balance all your items at once, "
570	"but the %s is just too much for your body. "
571	"[You need to unapply some items first.]", &ob->name);
572	return false;
573	}
574
575	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
576	}	603	{
577	else	604	manual_apply (this, current_weapon, AP_UNAPPLY);
578	;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
579		605
580	if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)	606	if (current_weapon && !current_weapon->flag [FLAG_APPLIED])//D
581	{	607	LOG (llevError, "FATAL: did not clear current_weapon (%s)\n", current_weapon->debug_desc ());
582	LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",	608
583	&name, ob->debug_desc ());	609	if (current_weapon && current_weapon->flag [FLAG_APPLIED])
584	return false;	610	return false;
		611	}
		612
		613	current_weapon = 0;
		614
		615	if (ob && !ob->flag [FLAG_APPLIED])
		616	{
		617	manual_apply (this, ob, AP_APPLY);
		618
		619	if (ob->flag [FLAG_APPLIED])
		620	current_weapon = ob;
		621	else
		622	return false;
585	}	623	}
586		624
587	return true;	625	return true;
588	}	626	}
589		627
…		…
602	}	640	}
603		641
604	op->key_values = 0;	642	op->key_values = 0;
605	}	643	}
606		644
607	object &	645	/*
608	object::operator =(const object &src)	646	* copy_to first frees everything allocated by the dst object,
		647	* and then copies the contents of itself into the second
		648	* object, allocating what needs to be allocated. Basically, any
		649	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		650	* if the first object is freed, the pointers in the new object
		651	* will point at garbage.
		652	*/
		653	void
		654	object::copy_to (object *dst)
609	{	655	{
610	bool is_freed = flag [FLAG_FREED];	656	dst->remove ();
611	bool is_removed = flag [FLAG_REMOVED];
612
613	*(object_copy *)this = src;	657	*(object_copy *)dst = *this;
614
615	flag [FLAG_FREED] = is_freed;
616	flag [FLAG_REMOVED] = is_removed;	658	dst->flag [FLAG_REMOVED] = true;
617		659
618	/* Copy over key_values, if any. */	660	/* Copy over key_values, if any. */
619	if (src.key_values)	661	if (key_values)
620	{	662	{
621	key_value *tail = 0;	663	key_value *tail = 0;
622	key_values = 0;	664	dst->key_values = 0;
623		665
624	for (key_value *i = src.key_values; i; i = i->next)	666	for (key_value *i = key_values; i; i = i->next)
625	{	667	{
626	key_value *new_link = new key_value;	668	key_value *new_link = new key_value;
627		669
628	new_link->next = 0;	670	new_link->next = 0;
629	new_link->key = i->key;	671	new_link->key = i->key;
630	new_link->value = i->value;	672	new_link->value = i->value;
631		673
632	/* Try and be clever here, too. */	674	/* Try and be clever here, too. */
633	if (!key_values)	675	if (!dst->key_values)
634	{	676	{
635	key_values = new_link;	677	dst->key_values = new_link;
636	tail = new_link;	678	tail = new_link;
637	}	679	}
638	else	680	else
639	{	681	{
640	tail->next = new_link;	682	tail->next = new_link;
641	tail = new_link;	683	tail = new_link;
642	}	684	}
643	}	685	}
644	}	686	}
645	}
646		687
647	/*	688	dst->activate ();
648	* copy_to first frees everything allocated by the dst object,
649	* and then copies the contents of itself into the second
650	* object, allocating what needs to be allocated. Basically, any
651	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
652	* if the first object is freed, the pointers in the new object
653	* will point at garbage.
654	*/
655	void
656	object::copy_to (object *dst)
657	{
658	*dst = *this;
659
660	if (speed < 0)
661	dst->speed_left -= rndm ();
662
663	dst->set_speed (dst->speed);
664	}	689	}
665		690
666	void	691	void
667	object::instantiate ()	692	object::instantiate ()
668	{	693	{
669	if (!uuid.seq) // HACK	694	if (!uuid.seq) // HACK
670	uuid = UUID::gen ();	695	uuid = UUID::gen ();
671		696
		697	// TODO: unclean state changes, should nt be done in copy_to AND instantiate
		698	if (flag [FLAG_RANDOM_SPEED] && speed)
		699	speed_left = - speed - rndm (); // TODO animation
		700	else
672	speed_left = -0.1f;	701	speed_left = -1.;
		702
673	/* copy the body_info to the body_used - this is only really	703	/* copy the body_info to the body_used - this is only really
674	* need for monsters, but doesn't hurt to do it for everything.	704	* need for monsters, but doesn't hurt to do it for everything.
675	* by doing so, when a monster is created, it has good starting	705	* by doing so, when a monster is created, it has good starting
676	* values for the body_used info, so when items are created	706	* values for the body_used info, so when items are created
677	* for it, they can be properly equipped.	707	* for it, they can be properly equipped.
…		…
685	object *	715	object *
686	object::clone ()	716	object::clone ()
687	{	717	{
688	object *neu = create ();	718	object *neu = create ();
689	copy_to (neu);	719	copy_to (neu);
		720
		721	// TODO: unclean state changes, should not be done in clone AND instantiate
		722	if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
		723	neu->speed_left = - neu->speed - rndm (); // TODO animation
		724
		725	neu->map = map; // not copied by copy_to
690	return neu;	726	return neu;
691	}	727	}
692		728
693	/*	729	/*
694	* If an object with the IS_TURNABLE() flag needs to be turned due	730	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
711	* This function needs to be called whenever the speed of an object changes.	747	* This function needs to be called whenever the speed of an object changes.
712	*/	748	*/
713	void	749	void
714	object::set_speed (float speed)	750	object::set_speed (float speed)
715	{	751	{
716	if (flag [FLAG_FREED] && speed)
717	{
718	LOG (llevError, "Object %s is freed but has speed.\n", &name);
719	speed = 0;
720	}
721
722	this->speed = speed;	752	this->speed = speed;
723		753
724	if (has_active_speed ())	754	if (has_active_speed ())
725	activate ();	755	activate ();
726	else	756	else
…		…
745	* UP_OBJ_FACE: only the objects face has changed.	775	* UP_OBJ_FACE: only the objects face has changed.
746	*/	776	*/
747	void	777	void
748	update_object (object *op, int action)	778	update_object (object *op, int action)
749	{	779	{
750	if (op == NULL)	780	if (!op)
751	{	781	{
752	/* this should never happen */	782	/* this should never happen */
753	LOG (llevDebug, "update_object() called for NULL object.\n");	783	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754	return;	784	return;
755	}	785	}
756		786
757	if (op->env)	787	if (!op->is_on_map ())
758	{	788	{
759	/* Animation is currently handled by client, so nothing	789	/* Animation is currently handled by client, so nothing
760	* to do in this case.	790	* to do in this case.
761	*/	791	*/
762	return;	792	return;
763	}	793	}
764
765	/* If the map is saving, don't do anything as everything is
766	* going to get freed anyways.
767	*/
768	if (!op->map || op->map->in_memory == MAP_SAVING)
769	return;
770		794
771	/* make sure the object is within map boundaries */	795	/* make sure the object is within map boundaries */
772	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	796	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773	{	797	{
774	LOG (llevError, "update_object() called for object out of map!\n");	798	LOG (llevError, "update_object() called for object out of map!\n");
…		…
782		806
783	if (!(m.flags_ & P_UPTODATE))	807	if (!(m.flags_ & P_UPTODATE))
784	/* nop */;	808	/* nop */;
785	else if (action == UP_OBJ_INSERT)	809	else if (action == UP_OBJ_INSERT)
786	{	810	{
		811	#if 0
787	// this is likely overkill, TODO: revisit (schmorp)	812	// this is likely overkill, TODO: revisit (schmorp)
788	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	813	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
789	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	814	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
790	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	815	|| (op->is_player () && !(m.flags_ & P_PLAYER))
791	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	816	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
792	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	817	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
793	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	818	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
794	|| (m.move_on | op->move_on ) != m.move_on	819	|| (m.move_on | op->move_on ) != m.move_on
795	|| (m.move_off | op->move_off ) != m.move_off	820	|| (m.move_off | op->move_off ) != m.move_off
796	|| (m.move_slow | op->move_slow) != m.move_slow	821	|| (m.move_slow | op->move_slow) != m.move_slow
797	/* This isn't perfect, but I don't expect a lot of objects to	822	/* This isn't perfect, but I don't expect a lot of objects to
798	* to have move_allow right now.	823	* have move_allow right now.
799	*/	824	*/
800	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	825	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
		826	m.invalidate ();
		827	#else
801	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	828	// the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
802	m.flags_ = 0;	829	m.invalidate ();
		830	#endif
803	}	831	}
804	/* if the object is being removed, we can't make intelligent	832	/* if the object is being removed, we can't make intelligent
805	* decisions, because remove_ob can't really pass the object	833	* decisions, because remove_ob can't really pass the object
806	* that is being removed.	834	* that is being removed.
807	*/	835	*/
808	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	836	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
809	m.flags_ = 0;	837	m.invalidate ();
810	else if (action == UP_OBJ_FACE)	838	else if (action == UP_OBJ_FACE)
811	/* Nothing to do for that case */ ;	839	/* Nothing to do for that case */ ;
812	else	840	else
813	LOG (llevError, "update_object called with invalid action: %d\n", action);	841	LOG (llevError, "update_object called with invalid action: %d\n", action);
814		842
…		…
818		846
819	object::object ()	847	object::object ()
820	{	848	{
821	SET_FLAG (this, FLAG_REMOVED);	849	SET_FLAG (this, FLAG_REMOVED);
822		850
823	expmul = 1.0;	851	//expmul = 1.0; declared const for the time being
824	face = blank_face;	852	face = blank_face;
		853	material = MATERIAL_NULL;
825	}	854	}
826		855
827	object::~object ()	856	object::~object ()
828	{	857	{
829	unlink ();	858	unlink ();
…		…
858	/* If already on active list, don't do anything */	887	/* If already on active list, don't do anything */
859	if (active)	888	if (active)
860	return;	889	return;
861		890
862	if (has_active_speed ())	891	if (has_active_speed ())
		892	{
		893	if (flag [FLAG_FREED])
		894	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		895
863	actives.insert (this);	896	actives.insert (this);
		897	}
864	}	898	}
865		899
866	void	900	void
867	object::activate_recursive ()	901	object::activate_recursive ()
868	{	902	{
…		…
917	object::destroy_inv (bool drop_to_ground)	951	object::destroy_inv (bool drop_to_ground)
918	{	952	{
919	// need to check first, because the checks below might segfault	953	// need to check first, because the checks below might segfault
920	// as we might be on an invalid mapspace and crossfire code	954	// as we might be on an invalid mapspace and crossfire code
921	// is too buggy to ensure that the inventory is empty.	955	// is too buggy to ensure that the inventory is empty.
922	// corollary: if you create arrows etc. with stuff in tis inventory,	956	// corollary: if you create arrows etc. with stuff in its inventory,
923	// cf will crash below with off-map x and y	957	// cf will crash below with off-map x and y
924	if (!inv)	958	if (!inv)
925	return;	959	return;
926		960
927	/* Only if the space blocks everything do we not process -	961	/* Only if the space blocks everything do we not process -
…		…
929	* drop on that space.	963	* drop on that space.
930	*/	964	*/
931	if (!drop_to_ground	965	if (!drop_to_ground
932	|| !map	966	|| !map
933	|| map->in_memory != MAP_ACTIVE	967	|| map->in_memory != MAP_ACTIVE
934	|| map->nodrop	968	|| map->no_drop
935	|| ms ().move_block == MOVE_ALL)	969	|| ms ().move_block == MOVE_ALL)
936	{	970	{
937	while (inv)	971	while (inv)
938	{
939	inv->destroy_inv (drop_to_ground);
940	inv->destroy ();	972	inv->destroy ();
941	}
942	}	973	}
943	else	974	else
944	{ /* Put objects in inventory onto this space */	975	{ /* Put objects in inventory onto this space */
945	while (inv)	976	while (inv)
946	{	977	{
…		…
964	object *op = new object;	995	object *op = new object;
965	op->link ();	996	op->link ();
966	return op;	997	return op;
967	}	998	}
968		999
		1000	static struct freed_map : maptile
		1001	{
		1002	freed_map ()
		1003	{
		1004	path = "<freed objects map>";
		1005	name = "/internal/freed_objects_map";
		1006	width = 3;
		1007	height = 3;
		1008	no_drop = 1;
		1009	no_reset = 1;
		1010
		1011	alloc ();
		1012	in_memory = MAP_ACTIVE;
		1013	}
		1014
		1015	~freed_map ()
		1016	{
		1017	destroy ();
		1018	}
		1019	} freed_map; // freed objects are moved here to avoid crashes
		1020
969	void	1021	void
970	object::do_destroy ()	1022	object::do_destroy ()
971	{	1023	{
972	if (flag [FLAG_IS_LINKED])	1024	if (flag [FLAG_IS_LINKED])
973	remove_button_link (this);	1025	remove_link ();
974		1026
975	if (flag [FLAG_FRIENDLY])	1027	if (flag [FLAG_FRIENDLY])
976	remove_friendly_object (this);	1028	remove_friendly_object (this);
977		1029
978	remove ();	1030	remove ();
979		1031
980	attachable::do_destroy ();	1032	attachable::do_destroy ();
981		1033
982	destroy_inv (true);
983
984	deactivate ();	1034	deactivate ();
985	unlink ();	1035	unlink ();
986		1036
987	flag [FLAG_FREED] = 1;	1037	flag [FLAG_FREED] = 1;
988		1038
989	// hack to ensure that freed objects still have a valid map	1039	// hack to ensure that freed objects still have a valid map
990	{
991	static maptile *freed_map; // freed objects are moved here to avoid crashes
992
993	if (!freed_map)
994	{
995	freed_map = new maptile;
996
997	freed_map->path = "<freed objects map>";
998	freed_map->name = "/internal/freed_objects_map";
999	freed_map->width = 3;
1000	freed_map->height = 3;
1001	freed_map->nodrop = 1;
1002
1003	freed_map->alloc ();
1004	freed_map->in_memory = MAP_ACTIVE;
1005	}
1006
1007	map = freed_map;	1040	map = &freed_map;
1008	x = 1;	1041	x = 1;
1009	y = 1;	1042	y = 1;
1010	}
1011		1043
1012	if (more)	1044	if (more)
1013	{	1045	{
1014	more->destroy ();	1046	more->destroy ();
1015	more = 0;	1047	more = 0;
…		…
1023	attacked_by = 0;	1055	attacked_by = 0;
1024	current_weapon = 0;	1056	current_weapon = 0;
1025	}	1057	}
1026		1058
1027	void	1059	void
1028	object::destroy (bool destroy_inventory)	1060	object::destroy ()
1029	{	1061	{
1030	if (destroyed ())	1062	if (destroyed ())
1031	return;	1063	return;
1032		1064
1033	if (destroy_inventory)	1065	if (!is_head () && !head->destroyed ())
		1066	{
		1067	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1068	head->destroy ();
		1069	return;
		1070	}
		1071
1034	destroy_inv (false);	1072	destroy_inv (false);
1035		1073
1036	if (is_head ())	1074	if (is_head ())
1037	if (sound_destroy)	1075	if (sound_destroy)
1038	play_sound (sound_destroy);	1076	play_sound (sound_destroy);
1039	else if (flag [FLAG_MONSTER])	1077	else if (flag [FLAG_MONSTER])
…		…
1050	* the previous environment.	1088	* the previous environment.
1051	*/	1089	*/
1052	void	1090	void
1053	object::do_remove ()	1091	object::do_remove ()
1054	{	1092	{
1055	object *tmp, *last = 0;
1056	object *otmp;
1057
1058	if (flag [FLAG_REMOVED])	1093	if (flag [FLAG_REMOVED])
1059	return;	1094	return;
1060		1095
1061	INVOKE_OBJECT (REMOVE, this);	1096	INVOKE_OBJECT (REMOVE, this);
1062
1063	if (object *pl = visible_to ())
1064	esrv_del_item (pl->contr, count);
1065		1097
1066	flag [FLAG_REMOVED] = true;	1098	flag [FLAG_REMOVED] = true;
1067		1099
1068	if (more)	1100	if (more)
1069	more->remove ();	1101	more->remove ();
…		…
1072	* In this case, the object to be removed is in someones	1104	* In this case, the object to be removed is in someones
1073	* inventory.	1105	* inventory.
1074	*/	1106	*/
1075	if (env)	1107	if (env)
1076	{	1108	{
		1109	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1110	if (object *pl = visible_to ())
		1111	esrv_del_item (pl->contr, count);
		1112	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1113
1077	adjust_weight (env, -total_weight ());	1114	adjust_weight (env, -total_weight ());
1078		1115
1079	*(above ? &above->below : &env->inv) = below;	1116	object *pl = in_player ();
1080
1081	if (below)
1082	below->above = above;
1083		1117
1084	/* we set up values so that it could be inserted into	1118	/* we set up values so that it could be inserted into
1085	* the map, but we don't actually do that - it is up	1119	* the map, but we don't actually do that - it is up
1086	* to the caller to decide what we want to do.	1120	* to the caller to decide what we want to do.
1087	*/	1121	*/
1088	map = env->map;	1122	map = env->map;
1089	x = env->x;	1123	x = env->x;
1090	y = env->y;	1124	y = env->y;
		1125
		1126	// make sure cmov optimisation is applicable
		1127	*(above ? &above->below : &env->inv) = below;
		1128	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1129
1091	above = 0;	1130	above = 0;
1092	below = 0;	1131	below = 0;
1093	env = 0;	1132	env = 0;
1094		1133
1095	/* NO_FIX_PLAYER is set when a great many changes are being	1134	if (pl && pl->is_player ())
1096	* made to players inventory. If set, avoiding the call
1097	* to save cpu time.
1098	*/	1135	{
1099	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1136	if (expect_false (pl->contr->combat_ob == this))
1100	otmp->update_stats ();	1137	{
		1138	pl->apply (pl->contr->combat_ob, AP_UNAPPLY);
		1139	pl->contr->combat_ob = 0;
		1140	if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
		1141	}
		1142
		1143	if (expect_false (pl->contr->ranged_ob == this))
		1144	{
		1145	pl->apply (pl->contr->ranged_ob, AP_UNAPPLY);
		1146	pl->contr->ranged_ob = 0;
		1147	if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
		1148	}
		1149
		1150	pl->contr->queue_stats_update ();
		1151
		1152	if (expect_false (glow_radius) && pl->is_on_map ())
		1153	update_all_los (pl->map, pl->x, pl->y);
		1154	}
1101	}	1155	}
1102	else if (map)	1156	else if (map)
1103	{	1157	{
1104	if (type == PLAYER)
1105	{
1106	// leaving a spot always closes any open container on the ground
1107	if (container && !container->env)
1108	// this causes spurious floorbox updates, but it ensures
1109	// that the CLOSE event is being sent.
1110	close_container ();
1111
1112	--map->players;
1113	map->touch ();
1114	}
1115
1116	map->dirty = true;	1158	map->dirty = true;
1117	mapspace &ms = this->ms ();	1159	mapspace &ms = this->ms ();
1118		1160
		1161	if (object *pl = ms.player ())
		1162	{
		1163	if (is_player ())
		1164	{
		1165	if (!flag [FLAG_WIZPASS])
		1166	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1167
		1168	// leaving a spot always closes any open container on the ground
		1169	if (container && !container->env)
		1170	// this causes spurious floorbox updates, but it ensures
		1171	// that the CLOSE event is being sent.
		1172	close_container ();
		1173
		1174	--map->players;
		1175	map->touch ();
		1176	}
		1177	else if (pl->container_ () == this)
		1178	{
		1179	// removing a container should close it
		1180	close_container ();
		1181	}
		1182
		1183	esrv_del_item (pl->contr, count);
		1184	}
		1185
1119	/* link the object above us */	1186	/* link the object above us */
1120	if (above)	1187	// re-link, make sure compiler can easily use cmove
1121	above->below = below;	1188	*(above ? &above->below : &ms.top) = below;
1122	else	1189	*(below ? &below->above : &ms.bot) = above;
1123	ms.top = below; /* we were top, set new top */
1124
1125	/* Relink the object below us, if there is one */
1126	if (below)
1127	below->above = above;
1128	else
1129	{
1130	/* Nothing below, which means we need to relink map object for this space
1131	* use translated coordinates in case some oddness with map tiling is
1132	* evident
1133	*/
1134	if (GET_MAP_OB (map, x, y) != this)
1135	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1136
1137	ms.bot = above; /* goes on above it. */
1138	}
1139		1190
1140	above = 0;	1191	above = 0;
1141	below = 0;	1192	below = 0;
1142		1193
		1194	ms.invalidate ();
		1195
1143	if (map->in_memory == MAP_SAVING)	1196	if (map->in_memory == MAP_SAVING)
1144	return;	1197	return;
1145		1198
1146	int check_walk_off = !flag [FLAG_NO_APPLY];	1199	int check_walk_off = !flag [FLAG_NO_APPLY];
1147		1200
1148	if (object *pl = ms.player ())	1201	if (object *pl = ms.player ())
1149	{	1202	{
1150	if (pl->container == this)	1203	if (pl->container_ () == this)
1151	/* If a container that the player is currently using somehow gets	1204	/* If a container that the player is currently using somehow gets
1152	* removed (most likely destroyed), update the player view	1205	* removed (most likely destroyed), update the player view
1153	* appropriately.	1206	* appropriately.
1154	*/	1207	*/
1155	pl->close_container ();	1208	pl->close_container ();
1156		1209
		1210	//TODO: the floorbox prev/next might need updating
		1211	//esrv_del_item (pl->contr, count);
		1212	//TODO: update floorbox to preserve ordering
		1213	if (pl->contr->ns)
1157	pl->contr->ns->floorbox_update ();	1214	pl->contr->ns->floorbox_update ();
1158	}	1215	}
1159		1216
		1217	if (check_walk_off)
1160	for (tmp = ms.bot; tmp; tmp = tmp->above)	1218	for (object *above, *tmp = ms.bot; tmp; tmp = above)
1161	{	1219	{
		1220	above = tmp->above;
		1221
1162	/* No point updating the players look faces if he is the object	1222	/* No point updating the players look faces if he is the object
1163	* being removed.	1223	* being removed.
1164	*/	1224	*/
1165		1225
1166	/* See if object moving off should effect something */	1226	/* See if object moving off should effect something */
1167	if (check_walk_off
1168	&& ((move_type & tmp->move_off)	1227	if ((move_type & tmp->move_off)
1169	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1228	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1170	{
1171	move_apply (tmp, this, 0);	1229	move_apply (tmp, this, 0);
1172
1173	if (destroyed ())
1174	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1175	}	1230	}
1176		1231
1177	last = tmp;	1232	if (affects_los ())
1178	}
1179
1180	/* last == NULL if there are no objects on this space */
1181	//TODO: this makes little sense, why only update the topmost object?
1182	if (!last)
1183	map->at (x, y).flags_ = 0;
1184	else
1185	update_object (last, UP_OBJ_REMOVE);
1186
1187	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1188	update_all_los (map, x, y);	1233	update_all_los (map, x, y);
1189	}	1234	}
1190	}	1235	}
1191		1236
1192	/*	1237	/*
…		…
1216	esrv_update_item (UPD_NROF, pl, top);	1261	esrv_update_item (UPD_NROF, pl, top);
1217		1262
1218	op->weight = 0; // cancel the addition above	1263	op->weight = 0; // cancel the addition above
1219	op->carrying = 0; // must be 0 already	1264	op->carrying = 0; // must be 0 already
1220		1265
1221	op->destroy (1);	1266	op->destroy ();
1222		1267
1223	return top;	1268	return top;
1224	}	1269	}
1225		1270
1226	return 0;	1271	return 0;
…		…
1234		1279
1235	object *prev = this;	1280	object *prev = this;
1236		1281
1237	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)	1282	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1238	{	1283	{
1239	object *op = arch_to_object (at);	1284	object *op = at->instance ();
1240		1285
1241	op->name = name;	1286	op->name = name;
1242	op->name_pl = name_pl;	1287	op->name_pl = name_pl;
1243	op->title = title;	1288	op->title = title;
1244		1289
…		…
1254	* job preparing multi-part monsters.	1299	* job preparing multi-part monsters.
1255	*/	1300	*/
1256	object *	1301	object *
1257	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1302	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1258	{	1303	{
		1304	op->remove ();
		1305
1259	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1306	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1260	{	1307	{
1261	tmp->x = x + tmp->arch->x;	1308	tmp->x = x + tmp->arch->x;
1262	tmp->y = y + tmp->arch->y;	1309	tmp->y = y + tmp->arch->y;
1263	}	1310	}
…		…
1280	* Passing 0 for flag gives proper default values, so flag really only needs	1327	* Passing 0 for flag gives proper default values, so flag really only needs
1281	* to be set if special handling is needed.	1328	* to be set if special handling is needed.
1282	*	1329	*
1283	* Return value:	1330	* Return value:
1284	* new object if 'op' was merged with other object	1331	* new object if 'op' was merged with other object
1285	* NULL if 'op' was destroyed	1332	* NULL if there was an error (destroyed, blocked etc.)
1286	* just 'op' otherwise	1333	* just 'op' otherwise
1287	*/	1334	*/
1288	object *	1335	object *
1289	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1336	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1290	{	1337	{
1291	assert (!op->flag [FLAG_FREED]);
1292
1293	object *top, *floor = NULL;
1294
1295	op->remove ();	1338	op->remove ();
		1339
		1340	if (m == &freed_map)//D TODO: remove soon
		1341	{//D
		1342	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1343	}//D
1296		1344
1297	/* Ideally, the caller figures this out. However, it complicates a lot	1345	/* Ideally, the caller figures this out. However, it complicates a lot
1298	* of areas of callers (eg, anything that uses find_free_spot would now	1346	* of areas of callers (eg, anything that uses find_free_spot would now
1299	* need extra work	1347	* need extra work
1300	*/	1348	*/
		1349	maptile *newmap = m;
1301	if (!xy_normalise (m, op->x, op->y))	1350	if (!xy_normalise (newmap, op->x, op->y))
1302	{	1351	{
1303	op->destroy ();	1352	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1304	return 0;	1353	return 0;
1305	}	1354	}
1306		1355
1307	if (object *more = op->more)	1356	if (object *more = op->more)
1308	if (!insert_ob_in_map (more, m, originator, flag))	1357	if (!insert_ob_in_map (more, m, originator, flag))
1309	return 0;	1358	return 0;
1310		1359
1311	CLEAR_FLAG (op, FLAG_REMOVED);	1360	op->flag [FLAG_REMOVED] = false;
1312		1361	op->env = 0;
1313	op->map = m;	1362	op->map = newmap;
		1363
1314	mapspace &ms = op->ms ();	1364	mapspace &ms = op->ms ();
1315		1365
1316	/* this has to be done after we translate the coordinates.	1366	/* this has to be done after we translate the coordinates.
1317	*/	1367	*/
1318	if (op->nrof && !(flag & INS_NO_MERGE))	1368	if (op->nrof && !(flag & INS_NO_MERGE))
1319	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1369	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1320	if (object::can_merge (op, tmp))	1370	if (object::can_merge (op, tmp))
1321	{	1371	{
		1372	// TODO: we actually want to update tmp, not op,
		1373	// but some caller surely breaks when we return tmp
		1374	// from here :/
1322	op->nrof += tmp->nrof;	1375	op->nrof += tmp->nrof;
1323	tmp->destroy (1);	1376	tmp->destroy ();
1324	}	1377	}
1325		1378
1326	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1379	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1327	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1380	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1328		1381
…		…
1335	{	1388	{
1336	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1389	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1337	abort ();	1390	abort ();
1338	}	1391	}
1339		1392
		1393	if (!originator->is_on_map ())
		1394	{
		1395	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1396	op->debug_desc (), originator->debug_desc ());
		1397	abort ();
		1398	}
		1399
1340	op->above = originator;	1400	op->above = originator;
1341	op->below = originator->below;	1401	op->below = originator->below;
1342
1343	if (op->below)
1344	op->below->above = op;
1345	else
1346	ms.bot = op;
1347
1348	/* since *below* originator, no need to update top */
1349	originator->below = op;	1402	originator->below = op;
		1403
		1404	*(op->below ? &op->below->above : &ms.bot) = op;
1350	}	1405	}
1351	else	1406	else
1352	{	1407	{
1353	top = ms.bot;	1408	object *floor = 0;
		1409	object *top = ms.top;
1354		1410
1355	/* If there are other objects, then */	1411	/* If there are other objects, then */
1356	if (top)	1412	if (top)
1357	{	1413	{
1358	object *last = 0;
1359
1360	/*	1414	/*
1361	* If there are multiple objects on this space, we do some trickier handling.	1415	* If there are multiple objects on this space, we do some trickier handling.
1362	* We've already dealt with merging if appropriate.	1416	* We've already dealt with merging if appropriate.
1363	* Generally, we want to put the new object on top. But if	1417	* Generally, we want to put the new object on top. But if
1364	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1418	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1367	* once we get to them. This reduces the need to traverse over all of	1421	* once we get to them. This reduces the need to traverse over all of
1368	* them when adding another one - this saves quite a bit of cpu time	1422	* them when adding another one - this saves quite a bit of cpu time
1369	* when lots of spells are cast in one area. Currently, it is presumed	1423	* when lots of spells are cast in one area. Currently, it is presumed
1370	* that flying non pickable objects are spell objects.	1424	* that flying non pickable objects are spell objects.
1371	*/	1425	*/
1372	for (top = ms.bot; top; top = top->above)	1426	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1373	{	1427	{
1374	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1428	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1375	floor = top;	1429	floor = tmp;
1376		1430
1377	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1431	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1378	{	1432	{
1379	/* We insert above top, so we want this object below this */	1433	/* We insert above top, so we want this object below this */
1380	top = top->below;	1434	top = tmp->below;
1381	break;	1435	break;
1382	}	1436	}
1383		1437
1384	last = top;	1438	top = tmp;
1385	}	1439	}
1386
1387	/* Don't want top to be NULL, so set it to the last valid object */
1388	top = last;
1389		1440
1390	/* We let update_position deal with figuring out what the space	1441	/* We let update_position deal with figuring out what the space
1391	* looks like instead of lots of conditions here.	1442	* looks like instead of lots of conditions here.
1392	* makes things faster, and effectively the same result.	1443	* makes things faster, and effectively the same result.
1393	*/	1444	*/
…		…
1400	*/	1451	*/
1401	if (!(flag & INS_ON_TOP)	1452	if (!(flag & INS_ON_TOP)
1402	&& ms.flags () & P_BLOCKSVIEW	1453	&& ms.flags () & P_BLOCKSVIEW
1403	&& (op->face && !faces [op->face].visibility))	1454	&& (op->face && !faces [op->face].visibility))
1404	{	1455	{
		1456	object *last;
		1457
1405	for (last = top; last != floor; last = last->below)	1458	for (last = top; last != floor; last = last->below)
1406	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1459	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1407	break;	1460	break;
1408		1461
1409	/* Check to see if we found the object that blocks view,	1462	/* Check to see if we found the object that blocks view,
…		…
1417	} /* If objects on this space */	1470	} /* If objects on this space */
1418		1471
1419	if (flag & INS_ABOVE_FLOOR_ONLY)	1472	if (flag & INS_ABOVE_FLOOR_ONLY)
1420	top = floor;	1473	top = floor;
1421		1474
1422	/* Top is the object that our object (op) is going to get inserted above.	1475	// insert object above top, or bottom-most if top = 0
1423	*/
1424
1425	/* First object on this space */
1426	if (!top)	1476	if (!top)
1427	{	1477	{
		1478	op->below = 0;
1428	op->above = ms.bot;	1479	op->above = ms.bot;
1429
1430	if (op->above)
1431	op->above->below = op;
1432
1433	op->below = 0;
1434	ms.bot = op;	1480	ms.bot = op;
		1481
		1482	*(op->above ? &op->above->below : &ms.top) = op;
1435	}	1483	}
1436	else	1484	else
1437	{ /* get inserted into the stack above top */	1485	{
1438	op->above = top->above;	1486	op->above = top->above;
1439
1440	if (op->above)
1441	op->above->below = op;	1487	top->above = op;
1442		1488
1443	op->below = top;	1489	op->below = top;
1444	top->above = op;	1490	*(op->above ? &op->above->below : &ms.top) = op;
1445	}	1491	}
		1492	}
1446		1493
1447	if (!op->above)	1494	if (op->is_player ())
1448	ms.top = op;
1449	} /* else not INS_BELOW_ORIGINATOR */
1450
1451	if (op->type == PLAYER)
1452	{	1495	{
1453	op->contr->do_los = 1;	1496	op->contr->do_los = 1;
1454	++op->map->players;	1497	++op->map->players;
1455	op->map->touch ();	1498	op->map->touch ();
1456	}	1499	}
1457		1500
1458	op->map->dirty = true;	1501	op->map->dirty = true;
1459		1502
1460	if (object *pl = ms.player ())	1503	if (object *pl = ms.player ())
		1504	//TODO: the floorbox prev/next might need updating
		1505	//esrv_send_item (pl, op);
		1506	//TODO: update floorbox to preserve ordering
		1507	if (pl->contr->ns)
1461	pl->contr->ns->floorbox_update ();	1508	pl->contr->ns->floorbox_update ();
1462		1509
1463	/* If this object glows, it may affect lighting conditions that are	1510	/* If this object glows, it may affect lighting conditions that are
1464	* visible to others on this map. But update_all_los is really	1511	* visible to others on this map. But update_all_los is really
1465	* an inefficient way to do this, as it means los for all players	1512	* an inefficient way to do this, as it means los for all players
1466	* on the map will get recalculated. The players could very well	1513	* on the map will get recalculated. The players could very well
1467	* be far away from this change and not affected in any way -	1514	* be far away from this change and not affected in any way -
1468	* this should get redone to only look for players within range,	1515	* this should get redone to only look for players within range,
1469	* or just updating the P_UPTODATE for spaces within this area	1516	* or just updating the P_UPTODATE for spaces within this area
1470	* of effect may be sufficient.	1517	* of effect may be sufficient.
1471	*/	1518	*/
1472	if (op->map->darkness && (op->glow_radius != 0))	1519	if (op->affects_los ())
		1520	{
		1521	op->ms ().invalidate ();
1473	update_all_los (op->map, op->x, op->y);	1522	update_all_los (op->map, op->x, op->y);
		1523	}
1474		1524
1475	/* updates flags (blocked, alive, no magic, etc) for this map space */	1525	/* updates flags (blocked, alive, no magic, etc) for this map space */
1476	update_object (op, UP_OBJ_INSERT);	1526	update_object (op, UP_OBJ_INSERT);
1477		1527
1478	INVOKE_OBJECT (INSERT, op);	1528	INVOKE_OBJECT (INSERT, op);
…		…
1485	* blocked() and wall() work properly), and these flags are updated by	1535	* blocked() and wall() work properly), and these flags are updated by
1486	* update_object().	1536	* update_object().
1487	*/	1537	*/
1488		1538
1489	/* if this is not the head or flag has been passed, don't check walk on status */	1539	/* if this is not the head or flag has been passed, don't check walk on status */
1490	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1540	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1491	{	1541	{
1492	if (check_move_on (op, originator))	1542	if (check_move_on (op, originator))
1493	return 0;	1543	return 0;
1494		1544
1495	/* If we are a multi part object, lets work our way through the check	1545	/* If we are a multi part object, lets work our way through the check
…		…
1506	/* this function inserts an object in the map, but if it	1556	/* this function inserts an object in the map, but if it
1507	* finds an object of its own type, it'll remove that one first.	1557	* finds an object of its own type, it'll remove that one first.
1508	* op is the object to insert it under: supplies x and the map.	1558	* op is the object to insert it under: supplies x and the map.
1509	*/	1559	*/
1510	void	1560	void
1511	replace_insert_ob_in_map (const char *arch_string, object *op)	1561	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1512	{	1562	{
1513	/* first search for itself and remove any old instances */	1563	/* first search for itself and remove any old instances */
1514		1564
1515	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1565	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1516	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1566	if (tmp->arch->archname == archname) /* same archetype */
1517	tmp->destroy (1);	1567	tmp->destroy ();
1518		1568
1519	object *tmp = arch_to_object (archetype::find (arch_string));	1569	object *tmp = archetype::find (archname)->instance ();
1520		1570
1521	tmp->x = op->x;	1571	tmp->x = op->x;
1522	tmp->y = op->y;	1572	tmp->y = op->y;
1523		1573
1524	insert_ob_in_map (tmp, op->map, op, 0);	1574	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1529	{	1579	{
1530	if (where->env)	1580	if (where->env)
1531	return where->env->insert (this);	1581	return where->env->insert (this);
1532	else	1582	else
1533	return where->map->insert (this, where->x, where->y, originator, flags);	1583	return where->map->insert (this, where->x, where->y, originator, flags);
		1584	}
		1585
		1586	// check whether we can put this into the map, respect max_volume, max_items
		1587	bool
		1588	object::can_drop_at (maptile *m, int x, int y, object *originator)
		1589	{
		1590	mapspace &ms = m->at (x, y);
		1591
		1592	int items = ms.items ();
		1593
		1594	if (!items // testing !items ensures we can drop at least one item
		1595	|| (items < m->max_items
		1596	&& ms.volume () < m->max_volume))
		1597	return true;
		1598
		1599	if (originator && originator->is_player ())
		1600	originator->contr->failmsg (format (
		1601	"No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
		1602	query_name ()
		1603	));
		1604
		1605	return false;
1534	}	1606	}
1535		1607
1536	/*	1608	/*
1537	* decrease(object, number) decreases a specified number from	1609	* decrease(object, number) decreases a specified number from
1538	* the amount of an object. If the amount reaches 0, the object	1610	* the amount of an object. If the amount reaches 0, the object
…		…
1546	if (!nr)	1618	if (!nr)
1547	return true;	1619	return true;
1548		1620
1549	nr = min (nr, nrof);	1621	nr = min (nr, nrof);
1550		1622
		1623	if (nrof > nr)
		1624	{
1551	nrof -= nr;	1625	nrof -= nr;
1552
1553	if (nrof)
1554	{
1555	adjust_weight (env, -weight * nr); // carrying == 0	1626	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1556		1627
1557	if (object *pl = visible_to ())	1628	if (object *pl = visible_to ())
1558	esrv_update_item (UPD_NROF, pl, this);	1629	esrv_update_item (UPD_NROF, pl, this);
1559		1630
1560	return true;	1631	return true;
1561	}	1632	}
1562	else	1633	else
1563	{	1634	{
1564	destroy (1);	1635	destroy ();
1565	return false;	1636	return false;
1566	}	1637	}
1567	}	1638	}
1568		1639
1569	/*	1640	/*
…		…
1586	}	1657	}
1587	else	1658	else
1588	{	1659	{
1589	decrease (nr);	1660	decrease (nr);
1590		1661
1591	object *op = object_create_clone (this);	1662	object *op = deep_clone ();
1592	op->nrof = nr;	1663	op->nrof = nr;
1593	return op;	1664	return op;
1594	}	1665	}
1595	}	1666	}
1596		1667
…		…
1646	if (object *pl = tmp->visible_to ())	1717	if (object *pl = tmp->visible_to ())
1647	esrv_update_item (UPD_NROF, pl, tmp);	1718	esrv_update_item (UPD_NROF, pl, tmp);
1648		1719
1649	adjust_weight (this, op->total_weight ());	1720	adjust_weight (this, op->total_weight ());
1650		1721
1651	op->destroy (1);	1722	op->destroy ();
1652	op = tmp;	1723	op = tmp;
1653	goto inserted;	1724	goto inserted;
1654	}	1725	}
1655		1726
1656	op->owner = 0; // it's his/hers now. period.	1727	op->owner = 0; // it's his/hers now. period.
…		…
1674		1745
1675	adjust_weight (this, op->total_weight ());	1746	adjust_weight (this, op->total_weight ());
1676		1747
1677	inserted:	1748	inserted:
1678	/* reset the light list and los of the players on the map */	1749	/* reset the light list and los of the players on the map */
1679	if (op->glow_radius && map && map->darkness)	1750	if (op->glow_radius && is_on_map ())
		1751	{
		1752	update_stats ();
1680	update_all_los (map, x, y);	1753	update_all_los (map, x, y);
1681		1754	}
		1755	else if (is_player ())
1682	// if this is a player's inventory, update stats	1756	// if this is a player's inventory, update stats
1683	if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])	1757	contr->queue_stats_update ();
1684	update_stats ();
1685		1758
1686	INVOKE_OBJECT (INSERT, this);	1759	INVOKE_OBJECT (INSERT, this);
1687		1760
1688	return op;	1761	return op;
1689	}	1762	}
…		…
1709	* on top.	1782	* on top.
1710	*/	1783	*/
1711	int	1784	int
1712	check_move_on (object *op, object *originator)	1785	check_move_on (object *op, object *originator)
1713	{	1786	{
		1787	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1788	return 0;
		1789
1714	object *tmp;	1790	object *tmp;
1715	maptile *m = op->map;	1791	maptile *m = op->map;
1716	int x = op->x, y = op->y;	1792	int x = op->x, y = op->y;
1717		1793
1718	MoveType move_on, move_slow, move_block;	1794	mapspace &ms = m->at (x, y);
1719		1795
1720	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1796	ms.update ();
1721	return 0;
1722		1797
1723	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1798	MoveType move_on = ms.move_on;
1724	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1799	MoveType move_slow = ms.move_slow;
1725	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1800	MoveType move_block = ms.move_block;
1726		1801
1727	/* if nothing on this space will slow op down or be applied,	1802	/* if nothing on this space will slow op down or be applied,
1728	* no need to do checking below. have to make sure move_type	1803	* no need to do checking below. have to make sure move_type
1729	* is set, as lots of objects don't have it set - we treat that	1804	* is set, as lots of objects don't have it set - we treat that
1730	* as walking.	1805	* as walking.
…		…
1741	return 0;	1816	return 0;
1742		1817
1743	/* The objects have to be checked from top to bottom.	1818	/* The objects have to be checked from top to bottom.
1744	* Hence, we first go to the top:	1819	* Hence, we first go to the top:
1745	*/	1820	*/
1746		1821	for (object *next, *tmp = ms.top; tmp; tmp = next)
1747	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1748	{
1749	/* Trim the search when we find the first other spell effect
1750	* this helps performance so that if a space has 50 spell objects,
1751	* we don't need to check all of them.
1752	*/
1753	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1754	break;
1755	}	1822	{
		1823	next = tmp->below;
1756		1824
1757	for (; tmp; tmp = tmp->below)
1758	{
1759	if (tmp == op)	1825	if (tmp == op)
1760	continue; /* Can't apply yourself */	1826	continue; /* Can't apply yourself */
1761		1827
1762	/* Check to see if one of the movement types should be slowed down.	1828	/* Check to see if one of the movement types should be slowed down.
1763	* Second check makes sure that the movement types not being slowed	1829	* Second check makes sure that the movement types not being slowed
…		…
1768	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1834	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1769	{	1835	{
1770	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1836	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1771	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1837	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1772	{	1838	{
1773
1774	float
1775	diff = tmp->move_slow_penalty * fabs (op->speed);	1839	float diff = tmp->move_slow_penalty * fabs (op->speed);
1776		1840
1777	if (op->type == PLAYER)	1841	if (op->is_player ())
1778	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1842	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1779	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1843	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1780	diff /= 4.0;	1844	diff /= 4.0;
1781		1845
1782	op->speed_left -= diff;	1846	op->speed_left -= diff;
1783	}	1847	}
1784	}	1848	}
…		…
1817	LOG (llevError, "Present_arch called outside map.\n");	1881	LOG (llevError, "Present_arch called outside map.\n");
1818	return NULL;	1882	return NULL;
1819	}	1883	}
1820		1884
1821	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1885	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1822	if (tmp->arch == at)	1886	if (tmp->arch->archname == at->archname)
1823	return tmp;	1887	return tmp;
1824		1888
1825	return NULL;	1889	return NULL;
1826	}	1890	}
1827		1891
…		…
1891	* The first matching object is returned, or NULL if none.	1955	* The first matching object is returned, or NULL if none.
1892	*/	1956	*/
1893	object *	1957	object *
1894	present_arch_in_ob (const archetype *at, const object *op)	1958	present_arch_in_ob (const archetype *at, const object *op)
1895	{	1959	{
1896	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1960	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1897	if (tmp->arch == at)	1961	if (tmp->arch->archname == at->archname)
1898	return tmp;	1962	return tmp;
1899		1963
1900	return NULL;	1964	return NULL;
1901	}	1965	}
1902		1966
…		…
1990	* head of the object should correspond for the entire object.	2054	* head of the object should correspond for the entire object.
1991	*/	2055	*/
1992	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	2056	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1993	continue;	2057	continue;
1994		2058
1995	if (ob->blocked (m, pos.x, pos.y))	2059	if (ob->blocked (pos.m, pos.x, pos.y))
1996	continue;	2060	continue;
1997		2061
1998	altern [index++] = i;	2062	altern [index++] = i;
1999	}	2063	}
2000		2064
…		…
2068	* there is capable of.	2132	* there is capable of.
2069	*/	2133	*/
2070	int	2134	int
2071	find_dir (maptile *m, int x, int y, object *exclude)	2135	find_dir (maptile *m, int x, int y, object *exclude)
2072	{	2136	{
2073	int i, max = SIZEOFFREE, mflags;	2137	int max = SIZEOFFREE, mflags;
2074
2075	sint16 nx, ny;
2076	object *tmp;
2077	maptile *mp;
2078
2079	MoveType blocked, move_type;	2138	MoveType move_type;
2080		2139
2081	if (exclude && exclude->head_ () != exclude)	2140	if (exclude && exclude->head_ () != exclude)
2082	{	2141	{
2083	exclude = exclude->head;	2142	exclude = exclude->head;
2084	move_type = exclude->move_type;	2143	move_type = exclude->move_type;
…		…
2087	{	2146	{
2088	/* If we don't have anything, presume it can use all movement types. */	2147	/* If we don't have anything, presume it can use all movement types. */
2089	move_type = MOVE_ALL;	2148	move_type = MOVE_ALL;
2090	}	2149	}
2091		2150
2092	for (i = 1; i < max; i++)	2151	for (int i = 1; i < max; i++)
2093	{	2152	{
2094	mp = m;	2153	mapxy pos (m, x, y);
2095	nx = x + freearr_x[i];	2154	pos.move (i);
2096	ny = y + freearr_y[i];
2097		2155
2098	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2156	if (!pos.normalise ())
2099
2100	if (mflags & P_OUT_OF_MAP)
2101	max = maxfree[i];	2157	max = maxfree[i];
2102	else	2158	else
2103	{	2159	{
2104	mapspace &ms = mp->at (nx, ny);	2160	mapspace &ms = *pos;
2105		2161
2106	blocked = ms.move_block;
2107
2108	if ((move_type & blocked) == move_type)	2162	if ((move_type & ms.move_block) == move_type)
2109	max = maxfree[i];	2163	max = maxfree [i];
2110	else if (mflags & P_IS_ALIVE)	2164	else if (ms.flags () & P_IS_ALIVE)
2111	{	2165	{
2112	for (tmp = ms.bot; tmp; tmp = tmp->above)	2166	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2113	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2167	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2114	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2168	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2115	break;
2116
2117	if (tmp)
2118	return freedir[i];	2169	return freedir [i];
2119	}	2170	}
2120	}	2171	}
2121	}	2172	}
2122		2173
2123	return 0;	2174	return 0;
…		…
2198	* This basically means that if direction is 15, then it could either go	2249	* This basically means that if direction is 15, then it could either go
2199	* direction 4, 14, or 16 to get back to where we are.	2250	* direction 4, 14, or 16 to get back to where we are.
2200	* Moved from spell_util.c to object.c with the other related direction	2251	* Moved from spell_util.c to object.c with the other related direction
2201	* functions.	2252	* functions.
2202	*/	2253	*/
2203	int reduction_dir[SIZEOFFREE][3] = {	2254	static const int reduction_dir[SIZEOFFREE][3] = {
2204	{0, 0, 0}, /* 0 */	2255	{0, 0, 0}, /* 0 */
2205	{0, 0, 0}, /* 1 */	2256	{0, 0, 0}, /* 1 */
2206	{0, 0, 0}, /* 2 */	2257	{0, 0, 0}, /* 2 */
2207	{0, 0, 0}, /* 3 */	2258	{0, 0, 0}, /* 3 */
2208	{0, 0, 0}, /* 4 */	2259	{0, 0, 0}, /* 4 */
…		…
2304	int	2355	int
2305	can_pick (const object *who, const object *item)	2356	can_pick (const object *who, const object *item)
2306	{	2357	{
2307	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2358	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2308	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2359	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2309	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2360	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2310	}	2361	}
2311		2362
2312	/*	2363	/*
2313	* create clone from object to another	2364	* create clone from object to another
2314	*/	2365	*/
2315	object *	2366	object *
2316	object_create_clone (object *asrc)	2367	object::deep_clone ()
2317	{	2368	{
2318	object *dst = 0, *tmp, *src, *prev, *item;	2369	assert (("deep_clone called on non-head object", is_head ()));
2319		2370
2320	if (!asrc)	2371	object *dst = clone ();
2321	return 0;
2322		2372
2323	src = asrc->head_ ();	2373	object *prev = dst;
2324
2325	prev = 0;
2326	for (object *part = src; part; part = part->more)	2374	for (object *part = this->more; part; part = part->more)
2327	{	2375	{
2328	tmp = part->clone ();	2376	object *tmp = part->clone ();
2329	tmp->x -= src->x;
2330	tmp->y -= src->y;
2331
2332	if (!part->head)
2333	{
2334	dst = tmp;
2335	tmp->head = 0;
2336	}
2337	else
2338	tmp->head = dst;	2377	tmp->head = dst;
2339
2340	tmp->more = 0;
2341
2342	if (prev)
2343	prev->more = tmp;	2378	prev->more = tmp;
2344
2345	prev = tmp;	2379	prev = tmp;
2346	}	2380	}
2347		2381
2348	for (item = src->inv; item; item = item->below)	2382	for (object *item = inv; item; item = item->below)
2349	insert_ob_in_ob (object_create_clone (item), dst);	2383	insert_ob_in_ob (item->deep_clone (), dst);
2350		2384
2351	return dst;	2385	return dst;
2352	}	2386	}
2353		2387
2354	/* This returns the first object in who's inventory that	2388	/* This returns the first object in who's inventory that
…		…
2363	return tmp;	2397	return tmp;
2364		2398
2365	return 0;	2399	return 0;
2366	}	2400	}
2367		2401
2368	/* If ob has a field named key, return the link from the list,	2402	shstr_tmp
2369	* otherwise return NULL.	2403	object::kv_get (shstr_tmp key) const
2370	*
2371	* key must be a passed in shared string - otherwise, this won't
2372	* do the desired thing.
2373	*/
2374	key_value *
2375	get_ob_key_link (const object *ob, const char *key)
2376	{	2404	{
2377	for (key_value *link = ob->key_values; link; link = link->next)	2405	for (key_value *kv = key_values; kv; kv = kv->next)
2378	if (link->key == key)	2406	if (kv->key == key)
2379	return link;
2380
2381	return 0;
2382	}
2383
2384	/*
2385	* Returns the value of op has an extra_field for key, or NULL.
2386	*
2387	* The argument doesn't need to be a shared string.
2388	*
2389	* The returned string is shared.
2390	*/
2391	const char *
2392	get_ob_key_value (const object *op, const char *const key)
2393	{
2394	key_value *link;
2395	shstr_cmp canonical_key (key);
2396
2397	if (!canonical_key)
2398	{
2399	/* 1. There being a field named key on any object
2400	* implies there'd be a shared string to find.
2401	* 2. Since there isn't, no object has this field.
2402	* 3. Therefore, *this* object doesn't have this field.
2403	*/
2404	return 0;
2405	}
2406
2407	/* This is copied from get_ob_key_link() above -
2408	* only 4 lines, and saves the function call overhead.
2409	*/
2410	for (link = op->key_values; link; link = link->next)
2411	if (link->key == canonical_key)
2412	return link->value;	2407	return kv->value;
2413		2408
2414	return 0;	2409	return shstr ();
2415	}	2410	}
2416		2411
2417	/*	2412	void
2418	* Updates the canonical_key in op to value.	2413	object::kv_set (shstr_tmp key, shstr_tmp value)
2419	*
2420	* canonical_key is a shared string (value doesn't have to be).
2421	*
2422	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2423	* keys.
2424	*
2425	* Returns TRUE on success.
2426	*/
2427	int
2428	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2429	{	2414	{
2430	key_value *field = NULL, *last = NULL;	2415	for (key_value *kv = key_values; kv; kv = kv->next)
2431		2416	if (kv->key == key)
2432	for (field = op->key_values; field != NULL; field = field->next)
2433	{
2434	if (field->key != canonical_key)
2435	{	2417	{
2436	last = field;	2418	kv->value = value;
2437	continue;	2419	return;
2438	}	2420	}
2439		2421
2440	if (value)	2422	key_value *kv = new key_value;
2441	field->value = value;	2423
2442	else	2424	kv->next = key_values;
		2425	kv->key = key;
		2426	kv->value = value;
		2427
		2428	key_values = kv;
		2429	}
		2430
		2431	void
		2432	object::kv_del (shstr_tmp key)
		2433	{
		2434	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2435	if ((*kvp)->key == key)
2443	{	2436	{
2444	/* Basically, if the archetype has this key set,	2437	key_value *kv = *kvp;
2445	* we need to store the null value so when we save	2438	*kvp = (*kvp)->next;
2446	* it, we save the empty value so that when we load,	2439	delete kv;
2447	* we get this value back again.	2440	return;
2448	*/
2449	if (get_ob_key_link (op->arch, canonical_key))
2450	field->value = 0;
2451	else
2452	{
2453	if (last)
2454	last->next = field->next;
2455	else
2456	op->key_values = field->next;
2457
2458	delete field;
2459	}
2460	}	2441	}
2461	return TRUE;
2462	}
2463	/* IF we get here, key doesn't exist */
2464
2465	/* No field, we'll have to add it. */
2466
2467	if (!add_key)
2468	return FALSE;
2469
2470	/* There isn't any good reason to store a null
2471	* value in the key/value list. If the archetype has
2472	* this key, then we should also have it, so shouldn't
2473	* be here. If user wants to store empty strings,
2474	* should pass in ""
2475	*/
2476	if (value == NULL)
2477	return TRUE;
2478
2479	field = new key_value;
2480
2481	field->key = canonical_key;
2482	field->value = value;
2483	/* Usual prepend-addition. */
2484	field->next = op->key_values;
2485	op->key_values = field;
2486
2487	return TRUE;
2488	}
2489
2490	/*
2491	* Updates the key in op to value.
2492	*
2493	* If add_key is FALSE, this will only update existing keys,
2494	* and not add new ones.
2495	* In general, should be little reason FALSE is ever passed in for add_key
2496	*
2497	* Returns TRUE on success.
2498	*/
2499	int
2500	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2501	{
2502	shstr key_ (key);
2503
2504	return set_ob_key_value_s (op, key_, value, add_key);
2505	}	2442	}
2506		2443
2507	object::depth_iterator::depth_iterator (object *container)	2444	object::depth_iterator::depth_iterator (object *container)
2508	: iterator_base (container)	2445	: iterator_base (container)
2509	{	2446	{
…		…
2559	{	2496	{
2560	char flagdesc[512];	2497	char flagdesc[512];
2561	char info2[256 * 4];	2498	char info2[256 * 4];
2562	char *p = info;	2499	char *p = info;
2563		2500
2564	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2501	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2565	count,	2502	count,
2566	uuid.c_str (),	2503	uuid.c_str (),
2567	&name,	2504	&name,
2568	title ? "\",title:\"" : "",	2505	title ? ",title:\"" : "",
2569	title ? (const char *)title : "",	2506	title ? (const char *)title : "",
		2507	title ? "\"" : "",
2570	flag_desc (flagdesc, 512), type);	2508	flag_desc (flagdesc, 512), type);
2571		2509
2572	if (!this->flag[FLAG_REMOVED] && env)	2510	if (!flag[FLAG_REMOVED] && env)
2573	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2511	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2574		2512
2575	if (map)	2513	if (map)
2576	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2514	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2577		2515
…		…
2592	{	2530	{
2593	return map ? map->region (x, y)	2531	return map ? map->region (x, y)
2594	: region::default_region ();	2532	: region::default_region ();
2595	}	2533	}
2596		2534
2597	const materialtype_t *
2598	object::dominant_material () const
2599	{
2600	if (materialtype_t *mt = name_to_material (materialname))
2601	return mt;
2602
2603	return name_to_material (shstr_unknown);
2604	}
2605
2606	void	2535	void
2607	object::open_container (object *new_container)	2536	object::open_container (object *new_container)
2608	{	2537	{
2609	if (container == new_container)	2538	if (container == new_container)
2610	return;	2539	return;
2611		2540
2612	if (object *old_container = container)	2541	object *old_container = container;
		2542
		2543	if (old_container)
2613	{	2544	{
2614	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2545	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2615	return;	2546	return;
2616		2547
2617	#if 0	2548	#if 0
…		…
2619	if (object *closer = old_container->inv)	2550	if (object *closer = old_container->inv)
2620	if (closer->type == CLOSE_CON)	2551	if (closer->type == CLOSE_CON)
2621	closer->destroy ();	2552	closer->destroy ();
2622	#endif	2553	#endif
2623		2554
		2555	// make sure the container is available
		2556	esrv_send_item (this, old_container);
		2557
2624	old_container->flag [FLAG_APPLIED] = false;	2558	old_container->flag [FLAG_APPLIED] = false;
2625	container = 0;	2559	container = 0;
2626		2560
		2561	// client needs item update to make it work, client bug requires this to be separate
2627	esrv_update_item (UPD_FLAGS, this, old_container);	2562	esrv_update_item (UPD_FLAGS, this, old_container);
		2563
2628	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2564	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2629	play_sound (sound_find ("chest_close"));	2565	play_sound (sound_find ("chest_close"));
2630	}	2566	}
2631		2567
2632	if (new_container)	2568	if (new_container)
2633	{	2569	{
…		…
2637	// TODO: this does not seem to serve any purpose anymore?	2573	// TODO: this does not seem to serve any purpose anymore?
2638	#if 0	2574	#if 0
2639	// insert the "Close Container" object.	2575	// insert the "Close Container" object.
2640	if (archetype *closer = new_container->other_arch)	2576	if (archetype *closer = new_container->other_arch)
2641	{	2577	{
2642	object *closer = arch_to_object (new_container->other_arch);	2578	object *closer = new_container->other_arch->instance ();
2643	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2579	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2644	new_container->insert (closer);	2580	new_container->insert (closer);
2645	}	2581	}
2646	#endif	2582	#endif
2647		2583
2648	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2584	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
		2585
		2586	// make sure the container is available, client bug requires this to be separate
		2587	esrv_send_item (this, new_container);
2649		2588
2650	new_container->flag [FLAG_APPLIED] = true;	2589	new_container->flag [FLAG_APPLIED] = true;
2651	container = new_container;	2590	container = new_container;
2652		2591
		2592	// client needs flag change
2653	esrv_update_item (UPD_FLAGS, this, new_container);	2593	esrv_update_item (UPD_FLAGS, this, new_container);
2654	esrv_send_inventory (this, new_container);	2594	esrv_send_inventory (this, new_container);
2655	play_sound (sound_find ("chest_open"));	2595	play_sound (sound_find ("chest_open"));
2656	}	2596	}
		2597	// else if (!old_container->env && contr && contr->ns)
		2598	// contr->ns->floorbox_reset ();
2657	}	2599	}
2658		2600
2659	object *	2601	object *
2660	object::force_find (const shstr name)	2602	object::force_find (shstr_tmp name)
2661	{	2603	{
2662	/* cycle through his inventory to look for the MARK we want to	2604	/* cycle through his inventory to look for the MARK we want to
2663	* place	2605	* place
2664	*/	2606	*/
2665	for (object *tmp = inv; tmp; tmp = tmp->below)	2607	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2667	return splay (tmp);	2609	return splay (tmp);
2668		2610
2669	return 0;	2611	return 0;
2670	}	2612	}
2671		2613
		2614	//-GPL
		2615
2672	void	2616	void
		2617	object::force_set_timer (int duration)
		2618	{
		2619	this->duration = 1;
		2620	this->speed_left = -1.f;
		2621
		2622	this->set_speed (duration ? 1.f / duration : 0.f);
		2623	}
		2624
		2625	object *
2673	object::force_add (const shstr name, int duration)	2626	object::force_add (shstr_tmp name, int duration)
2674	{	2627	{
2675	if (object *force = force_find (name))	2628	if (object *force = force_find (name))
2676	force->destroy ();	2629	force->destroy ();
2677		2630
2678	object *force = get_archetype (FORCE_NAME);	2631	object *force = get_archetype (FORCE_NAME);
2679		2632
2680	force->slaying = name;	2633	force->slaying = name;
2681	force->stats.food = 1;	2634	force->force_set_timer (duration);
2682	force->speed_left = -1.f;
2683
2684	force->set_speed (duration ? 1.f / duration : 0.f);
2685	force->flag [FLAG_IS_USED_UP] = true;
2686	force->flag [FLAG_APPLIED] = true;	2635	force->flag [FLAG_APPLIED] = true;
2687		2636
2688	insert (force);	2637	return insert (force);
2689	}	2638	}
2690		2639
2691	void	2640	void
2692	object::play_sound (faceidx sound)	2641	object::play_sound (faceidx sound) const
2693	{	2642	{
2694	if (!sound)	2643	if (!sound)
2695	return;	2644	return;
2696		2645
2697	if (flag [FLAG_REMOVED])	2646	if (is_on_map ())
		2647	map->play_sound (sound, x, y);
		2648	else if (object *pl = in_player ())
		2649	pl->contr->play_sound (sound);
		2650	}
		2651
		2652	void
		2653	object::say_msg (const char *msg) const
		2654	{
		2655	if (is_on_map ())
		2656	map->say_msg (msg, x, y);
		2657	else if (object *pl = in_player ())
		2658	pl->contr->play_sound (sound);
		2659	}
		2660
		2661	void
		2662	object::make_noise ()
		2663	{
		2664	// we do not model noise in the map, so instead put
		2665	// a temporary light into the noise source
		2666	// could use the map instead, but that's less reliable for our
		2667	// goal, which is to make invisibility a bit harder to exploit
		2668
		2669	// currently only works sensibly for players
		2670	if (!is_player ())
2698	return;	2671	return;
2699		2672
2700	if (env)	2673	// find old force, or create new one
2701	{	2674	object *force = force_find (shstr_noise_force);
2702	if (object *pl = in_player ())	2675
2703	pl->contr->play_sound (sound);	2676	if (force)
2704	}	2677	force->speed_left = -1.f; // patch old speed up
2705	else	2678	else
2706	map->play_sound (sound, x, y);	2679	{
2707	}	2680	force = archetype::get (shstr_noise_force);
2708		2681
		2682	force->slaying = shstr_noise_force;
		2683	force->stats.food = 1;
		2684	force->speed_left = -1.f;
		2685
		2686	force->set_speed (1.f / 4.f);
		2687	force->flag [FLAG_IS_USED_UP] = true;
		2688	force->flag [FLAG_APPLIED] = true;
		2689
		2690	insert (force);
		2691	}
		2692	}
		2693
		2694	void object::change_move_type (MoveType mt)
		2695	{
		2696	if (move_type == mt)
		2697	return;
		2698
		2699	if (is_on_map ())
		2700	{
		2701	// we are on the map, so handle move_on/off effects
		2702	remove ();
		2703	move_type = mt;
		2704	map->insert (this, x, y, this);
		2705	}
		2706	else
		2707	move_type = mt;
		2708	}
		2709

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines