ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.219 by root, Wed Apr 23 21:09:10 2008 UTC vs.
Revision 1.298 by root, Sun Nov 8 00:01:33 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 52 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 56};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
60 0, 58 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
62};
63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64}; 69};
65 70
66static void 71static void
67write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
68{ 73{
139 144
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 145/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 146static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 147compare_ob_value_lists_one (const object *wants, const object *has)
143{ 148{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 149 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 150 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 151 * different structure or at least keep the lists sorted...
149 */ 152 */
150 153
151 /* For each field in wants, */ 154 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 155 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 156 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 157 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 158
169 /* If we get here, every field in wants has a matching field in has. */ 159 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 160 return true;
171} 161}
172 162
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 163/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 164static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 165compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 166{
177 /* However, there may be fields in has which aren't partnered in wants, 167 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 168 * so we need to run the comparison *twice*. :(
179 */ 169 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 170 return compare_ob_value_lists_one (ob1, ob2)
171 && compare_ob_value_lists_one (ob2, ob1);
181} 172}
182 173
183/* Function examines the 2 objects given to it, and returns true if 174/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 175 * they can be merged together.
185 * 176 *
195bool object::can_merge_slow (object *ob1, object *ob2) 186bool object::can_merge_slow (object *ob1, object *ob2)
196{ 187{
197 /* A couple quicksanity checks */ 188 /* A couple quicksanity checks */
198 if (ob1 == ob2 189 if (ob1 == ob2
199 || ob1->type != ob2->type 190 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed 191 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED
201 || ob1->value != ob2->value 192 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 193 || ob1->name != ob2->name)
203 return 0; 194 return 0;
204 195
205 /* Do not merge objects if nrof would overflow. First part checks 196 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 197 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 198 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 199 return 0;
212 200
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 201 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 202 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 203 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 209
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 210 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 211 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 212
225 if (ob1->arch->name != ob2->arch->name 213 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 214 || ob1->name != ob2->name
227 || ob1->title != ob2->title 215 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 216 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 217 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 218 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 219 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 220 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 221 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 222 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 223 || ob1->animation_id != ob2->animation_id
224 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 225 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 226 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 227 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 228 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 229 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 230 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 231 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 232 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 233 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 234 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 235 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 236 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 238 return 0;
250 239
251 if ((ob1->flag ^ ob2->flag) 240 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 241 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 242 .reset (FLAG_REMOVED)
255 .any ()) 243 .any ())
256 return 0; 244 return 0;
257 245
258 /* This is really a spellbook check - we should in general 246 /* This is really a spellbook check - we should in general
334 322
335// find player who can see this object 323// find player who can see this object
336object * 324object *
337object::visible_to () const 325object::visible_to () const
338{ 326{
339 if (!flag [FLAG_REMOVED]) 327 if (client_visible () && !flag [FLAG_REMOVED])
340 { 328 {
341 // see if we are in a container of sorts 329 // see if we are in a container of sorts
342 if (env) 330 if (env)
343 { 331 {
344 // the player inventory itself is always visible 332 // the player inventory itself is always visible
345 if (env->type == PLAYER) 333 if (env->is_player ())
346 return env; 334 return env;
347 335
348 // else a player could have our env open 336 // else a player could have our env open
349 object *envest = env->outer_env (); 337 object *envest = env->outer_env_or_self ();
350 338
351 // the player itself is always on a map, so we will find him here 339 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 340 // even if our inv is in a player.
353 if (envest->is_on_map ()) 341 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 342 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 343 if (pl->container_ () == env)
356 return pl; 344 return pl;
357 } 345 }
358 else 346 else
359 { 347 {
360 // maybe there is a player standing on the same mapspace 348 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 349 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 350 if (object *pl = ms ().player ())
351 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
352 || pl->container_ () == this)
363 return pl; 353 return pl;
364 } 354 }
365 } 355 }
366 356
367 return 0; 357 return 0;
368} 358}
369 359
370// adjust weight per container type ("of holding") 360// adjust weight per container type ("of holding")
371static sint32 361static sint32
372weight_adjust (object *op, sint32 weight) 362weight_adjust_for (object *op, sint32 weight)
373{ 363{
374 return op->type == CONTAINER 364 return op->type == CONTAINER
375 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 365 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
376 : weight; 366 : weight;
377} 367}
383static void 373static void
384adjust_weight (object *op, sint32 weight) 374adjust_weight (object *op, sint32 weight)
385{ 375{
386 while (op) 376 while (op)
387 { 377 {
378 // adjust by actual difference to account for rounding errors
379 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
388 weight = weight_adjust (op, weight); 380 weight = weight_adjust_for (op, op->carrying)
381 - weight_adjust_for (op, op->carrying - weight);
389 382
390 if (!weight) 383 if (!weight)
391 return; 384 return;
392 385
393 op->carrying += weight; 386 op->carrying += weight;
416 op->update_weight (); 409 op->update_weight ();
417 410
418 sum += op->total_weight (); 411 sum += op->total_weight ();
419 } 412 }
420 413
421 sum = weight_adjust (this, sum); 414 sum = weight_adjust_for (this, sum);
422 415
423 if (sum != carrying) 416 if (sum != carrying)
424 { 417 {
425 carrying = sum; 418 carrying = sum;
426 419
442 object_freezer freezer; 435 object_freezer freezer;
443 op->write (freezer); 436 op->write (freezer);
444 return freezer.as_string (); 437 return freezer.as_string ();
445} 438}
446 439
447/* 440char *
448 * get_nearest_part(multi-object, object 2) returns the part of the 441object::as_string ()
449 * multi-object 1 which is closest to the second object.
450 * If it's not a multi-object, it is returned.
451 */
452object *
453get_nearest_part (object *op, const object *pl)
454{ 442{
455 object *tmp, *closest; 443 return dump_object (this);
456 int last_dist, i;
457
458 if (!op->more)
459 return op;
460
461 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
462 tmp;
463 tmp = tmp->more)
464 if ((i = distance (tmp, pl)) < last_dist)
465 closest = tmp, last_dist = i;
466
467 return closest;
468} 444}
469 445
470/* 446/*
471 * Returns the object which has the count-variable equal to the argument. 447 * Returns the object which has the count-variable equal to the argument.
472 * VERRRY slow. 448 * VERRRY slow.
488 */ 464 */
489object * 465object *
490find_object_name (const char *str) 466find_object_name (const char *str)
491{ 467{
492 shstr_cmp str_ (str); 468 shstr_cmp str_ (str);
493 object *op;
494 469
470 if (str_)
495 for_all_objects (op) 471 for_all_objects (op)
496 if (op->name == str_) 472 if (op->name == str_)
497 break; 473 return op;
498 474
499 return op; 475 return 0;
500} 476}
501 477
502/* 478/*
503 * Sets the owner and sets the skill and exp pointers to owner's current 479 * Sets the owner and sets the skill and exp pointers to owner's current
504 * skill and experience objects. 480 * skill and experience objects.
566 update_stats (); 542 update_stats ();
567 543
568 new_draw_info_format (NDI_UNIQUE, 0, this, 544 new_draw_info_format (NDI_UNIQUE, 0, this,
569 "You try to balance all your items at once, " 545 "You try to balance all your items at once, "
570 "but the %s is just too much for your body. " 546 "but the %s is just too much for your body. "
571 "[You need to unapply some items first.]", &ob->name); 547 "[You need to unapply some items first - use the 'body' command to see "
548 "how many items you cna wera on a specific body part.]", &ob->name);
572 return false; 549 return false;
573 } 550 }
574 551
575 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 552 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
576 } 553 }
602 } 579 }
603 580
604 op->key_values = 0; 581 op->key_values = 0;
605} 582}
606 583
607object & 584/*
608object::operator =(const object &src) 585 * copy_to first frees everything allocated by the dst object,
586 * and then copies the contents of itself into the second
587 * object, allocating what needs to be allocated. Basically, any
588 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
589 * if the first object is freed, the pointers in the new object
590 * will point at garbage.
591 */
592void
593object::copy_to (object *dst)
609{ 594{
610 bool is_freed = flag [FLAG_FREED]; 595 dst->remove ();
611 bool is_removed = flag [FLAG_REMOVED];
612
613 *(object_copy *)this = src; 596 *(object_copy *)dst = *this;
614
615 flag [FLAG_FREED] = is_freed;
616 flag [FLAG_REMOVED] = is_removed; 597 dst->flag [FLAG_REMOVED] = true;
617 598
618 /* Copy over key_values, if any. */ 599 /* Copy over key_values, if any. */
619 if (src.key_values) 600 if (key_values)
620 { 601 {
621 key_value *tail = 0; 602 key_value *tail = 0;
622 key_values = 0; 603 dst->key_values = 0;
623 604
624 for (key_value *i = src.key_values; i; i = i->next) 605 for (key_value *i = key_values; i; i = i->next)
625 { 606 {
626 key_value *new_link = new key_value; 607 key_value *new_link = new key_value;
627 608
628 new_link->next = 0; 609 new_link->next = 0;
629 new_link->key = i->key; 610 new_link->key = i->key;
630 new_link->value = i->value; 611 new_link->value = i->value;
631 612
632 /* Try and be clever here, too. */ 613 /* Try and be clever here, too. */
633 if (!key_values) 614 if (!dst->key_values)
634 { 615 {
635 key_values = new_link; 616 dst->key_values = new_link;
636 tail = new_link; 617 tail = new_link;
637 } 618 }
638 else 619 else
639 { 620 {
640 tail->next = new_link; 621 tail->next = new_link;
641 tail = new_link; 622 tail = new_link;
642 } 623 }
643 } 624 }
644 } 625 }
645}
646
647/*
648 * copy_to first frees everything allocated by the dst object,
649 * and then copies the contents of itself into the second
650 * object, allocating what needs to be allocated. Basically, any
651 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
652 * if the first object is freed, the pointers in the new object
653 * will point at garbage.
654 */
655void
656object::copy_to (object *dst)
657{
658 *dst = *this;
659 626
660 if (speed < 0) 627 if (speed < 0)
661 dst->speed_left -= rndm (); 628 dst->speed_left -= rndm ();
662 629
663 dst->set_speed (dst->speed); 630 dst->activate ();
664} 631}
665 632
666void 633void
667object::instantiate () 634object::instantiate ()
668{ 635{
685object * 652object *
686object::clone () 653object::clone ()
687{ 654{
688 object *neu = create (); 655 object *neu = create ();
689 copy_to (neu); 656 copy_to (neu);
657 neu->map = map; // not copied by copy_to
690 return neu; 658 return neu;
691} 659}
692 660
693/* 661/*
694 * If an object with the IS_TURNABLE() flag needs to be turned due 662 * If an object with the IS_TURNABLE() flag needs to be turned due
711 * This function needs to be called whenever the speed of an object changes. 679 * This function needs to be called whenever the speed of an object changes.
712 */ 680 */
713void 681void
714object::set_speed (float speed) 682object::set_speed (float speed)
715{ 683{
716 if (flag [FLAG_FREED] && speed)
717 {
718 LOG (llevError, "Object %s is freed but has speed.\n", &name);
719 speed = 0;
720 }
721
722 this->speed = speed; 684 this->speed = speed;
723 685
724 if (has_active_speed ()) 686 if (has_active_speed ())
725 activate (); 687 activate ();
726 else 688 else
745 * UP_OBJ_FACE: only the objects face has changed. 707 * UP_OBJ_FACE: only the objects face has changed.
746 */ 708 */
747void 709void
748update_object (object *op, int action) 710update_object (object *op, int action)
749{ 711{
750 if (op == NULL) 712 if (!op)
751 { 713 {
752 /* this should never happen */ 714 /* this should never happen */
753 LOG (llevDebug, "update_object() called for NULL object.\n"); 715 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754 return; 716 return;
755 } 717 }
756 718
757 if (op->env) 719 if (!op->is_on_map ())
758 { 720 {
759 /* Animation is currently handled by client, so nothing 721 /* Animation is currently handled by client, so nothing
760 * to do in this case. 722 * to do in this case.
761 */ 723 */
762 return; 724 return;
763 } 725 }
764
765 /* If the map is saving, don't do anything as everything is
766 * going to get freed anyways.
767 */
768 if (!op->map || op->map->in_memory == MAP_SAVING)
769 return;
770 726
771 /* make sure the object is within map boundaries */ 727 /* make sure the object is within map boundaries */
772 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 728 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773 { 729 {
774 LOG (llevError, "update_object() called for object out of map!\n"); 730 LOG (llevError, "update_object() called for object out of map!\n");
782 738
783 if (!(m.flags_ & P_UPTODATE)) 739 if (!(m.flags_ & P_UPTODATE))
784 /* nop */; 740 /* nop */;
785 else if (action == UP_OBJ_INSERT) 741 else if (action == UP_OBJ_INSERT)
786 { 742 {
743#if 0
787 // this is likely overkill, TODO: revisit (schmorp) 744 // this is likely overkill, TODO: revisit (schmorp)
788 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 745 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
789 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 746 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
790 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 747 || (op->is_player () && !(m.flags_ & P_PLAYER))
791 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 748 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
792 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 749 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
793 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 750 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
794 || (m.move_on | op->move_on ) != m.move_on 751 || (m.move_on | op->move_on ) != m.move_on
795 || (m.move_off | op->move_off ) != m.move_off 752 || (m.move_off | op->move_off ) != m.move_off
796 || (m.move_slow | op->move_slow) != m.move_slow 753 || (m.move_slow | op->move_slow) != m.move_slow
797 /* This isn't perfect, but I don't expect a lot of objects to 754 /* This isn't perfect, but I don't expect a lot of objects to
798 * to have move_allow right now. 755 * have move_allow right now.
799 */ 756 */
800 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 757 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
758 m.invalidate ();
759#else
801 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 760 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
802 m.flags_ = 0; 761 m.invalidate ();
762#endif
803 } 763 }
804 /* if the object is being removed, we can't make intelligent 764 /* if the object is being removed, we can't make intelligent
805 * decisions, because remove_ob can't really pass the object 765 * decisions, because remove_ob can't really pass the object
806 * that is being removed. 766 * that is being removed.
807 */ 767 */
808 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 768 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
809 m.flags_ = 0; 769 m.invalidate ();
810 else if (action == UP_OBJ_FACE) 770 else if (action == UP_OBJ_FACE)
811 /* Nothing to do for that case */ ; 771 /* Nothing to do for that case */ ;
812 else 772 else
813 LOG (llevError, "update_object called with invalid action: %d\n", action); 773 LOG (llevError, "update_object called with invalid action: %d\n", action);
814 774
818 778
819object::object () 779object::object ()
820{ 780{
821 SET_FLAG (this, FLAG_REMOVED); 781 SET_FLAG (this, FLAG_REMOVED);
822 782
823 expmul = 1.0; 783 //expmul = 1.0; declared const for the time being
824 face = blank_face; 784 face = blank_face;
825} 785}
826 786
827object::~object () 787object::~object ()
828{ 788{
858 /* If already on active list, don't do anything */ 818 /* If already on active list, don't do anything */
859 if (active) 819 if (active)
860 return; 820 return;
861 821
862 if (has_active_speed ()) 822 if (has_active_speed ())
823 {
824 if (flag [FLAG_FREED])
825 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
826
863 actives.insert (this); 827 actives.insert (this);
828 }
864} 829}
865 830
866void 831void
867object::activate_recursive () 832object::activate_recursive ()
868{ 833{
929 * drop on that space. 894 * drop on that space.
930 */ 895 */
931 if (!drop_to_ground 896 if (!drop_to_ground
932 || !map 897 || !map
933 || map->in_memory != MAP_ACTIVE 898 || map->in_memory != MAP_ACTIVE
934 || map->nodrop 899 || map->no_drop
935 || ms ().move_block == MOVE_ALL) 900 || ms ().move_block == MOVE_ALL)
936 { 901 {
937 while (inv) 902 while (inv)
938 {
939 inv->destroy_inv (false);
940 inv->destroy (); 903 inv->destroy ();
941 }
942 } 904 }
943 else 905 else
944 { /* Put objects in inventory onto this space */ 906 { /* Put objects in inventory onto this space */
945 while (inv) 907 while (inv)
946 { 908 {
950 || op->flag [FLAG_NO_DROP] 912 || op->flag [FLAG_NO_DROP]
951 || op->type == RUNE 913 || op->type == RUNE
952 || op->type == TRAP 914 || op->type == TRAP
953 || op->flag [FLAG_IS_A_TEMPLATE] 915 || op->flag [FLAG_IS_A_TEMPLATE]
954 || op->flag [FLAG_DESTROY_ON_DEATH]) 916 || op->flag [FLAG_DESTROY_ON_DEATH])
955 op->destroy (true); 917 op->destroy ();
956 else 918 else
957 map->insert (op, x, y); 919 map->insert (op, x, y);
958 } 920 }
959 } 921 }
960} 922}
964 object *op = new object; 926 object *op = new object;
965 op->link (); 927 op->link ();
966 return op; 928 return op;
967} 929}
968 930
931static struct freed_map : maptile
932{
933 freed_map ()
934 {
935 path = "<freed objects map>";
936 name = "/internal/freed_objects_map";
937 width = 3;
938 height = 3;
939 no_drop = 1;
940 no_reset = 1;
941
942 alloc ();
943 in_memory = MAP_ACTIVE;
944 }
945
946 ~freed_map ()
947 {
948 destroy ();
949 }
950} freed_map; // freed objects are moved here to avoid crashes
951
969void 952void
970object::do_destroy () 953object::do_destroy ()
971{ 954{
972 if (flag [FLAG_IS_LINKED]) 955 if (flag [FLAG_IS_LINKED])
973 remove_button_link (this); 956 remove_link ();
974 957
975 if (flag [FLAG_FRIENDLY]) 958 if (flag [FLAG_FRIENDLY])
976 remove_friendly_object (this); 959 remove_friendly_object (this);
977 960
978 remove (); 961 remove ();
983 unlink (); 966 unlink ();
984 967
985 flag [FLAG_FREED] = 1; 968 flag [FLAG_FREED] = 1;
986 969
987 // hack to ensure that freed objects still have a valid map 970 // hack to ensure that freed objects still have a valid map
988 {
989 static maptile *freed_map; // freed objects are moved here to avoid crashes
990
991 if (!freed_map)
992 {
993 freed_map = new maptile;
994
995 freed_map->path = "<freed objects map>";
996 freed_map->name = "/internal/freed_objects_map";
997 freed_map->width = 3;
998 freed_map->height = 3;
999 freed_map->nodrop = 1;
1000
1001 freed_map->alloc ();
1002 freed_map->in_memory = MAP_ACTIVE;
1003 }
1004
1005 map = freed_map; 971 map = &freed_map;
1006 x = 1; 972 x = 1;
1007 y = 1; 973 y = 1;
1008 }
1009 974
1010 if (more) 975 if (more)
1011 { 976 {
1012 more->destroy (); 977 more->destroy ();
1013 more = 0; 978 more = 0;
1021 attacked_by = 0; 986 attacked_by = 0;
1022 current_weapon = 0; 987 current_weapon = 0;
1023} 988}
1024 989
1025void 990void
1026object::destroy (bool destroy_inventory) 991object::destroy ()
1027{ 992{
1028 if (destroyed ()) 993 if (destroyed ())
1029 return; 994 return;
1030 995
1031 if (!is_head () && !head->destroyed ()) 996 if (!is_head () && !head->destroyed ())
1032 { 997 {
1033 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 998 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1034 head->destroy (destroy_inventory); 999 head->destroy ();
1000 return;
1035 } 1001 }
1036 1002
1037 destroy_inv (!destroy_inventory); 1003 destroy_inv (false);
1038 1004
1039 if (is_head ()) 1005 if (is_head ())
1040 if (sound_destroy) 1006 if (sound_destroy)
1041 play_sound (sound_destroy); 1007 play_sound (sound_destroy);
1042 else if (flag [FLAG_MONSTER]) 1008 else if (flag [FLAG_MONSTER])
1053 * the previous environment. 1019 * the previous environment.
1054 */ 1020 */
1055void 1021void
1056object::do_remove () 1022object::do_remove ()
1057{ 1023{
1058 object *tmp, *last = 0;
1059 object *otmp;
1060
1061 if (flag [FLAG_REMOVED]) 1024 if (flag [FLAG_REMOVED])
1062 return; 1025 return;
1063 1026
1064 INVOKE_OBJECT (REMOVE, this); 1027 INVOKE_OBJECT (REMOVE, this);
1065
1066 if (object *pl = visible_to ())
1067 esrv_del_item (pl->contr, count);
1068 1028
1069 flag [FLAG_REMOVED] = true; 1029 flag [FLAG_REMOVED] = true;
1070 1030
1071 if (more) 1031 if (more)
1072 more->remove (); 1032 more->remove ();
1075 * In this case, the object to be removed is in someones 1035 * In this case, the object to be removed is in someones
1076 * inventory. 1036 * inventory.
1077 */ 1037 */
1078 if (env) 1038 if (env)
1079 { 1039 {
1040 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1041 if (object *pl = visible_to ())
1042 esrv_del_item (pl->contr, count);
1043 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1044
1080 adjust_weight (env, -total_weight ()); 1045 adjust_weight (env, -total_weight ());
1081 1046
1082 *(above ? &above->below : &env->inv) = below; 1047 object *pl = in_player ();
1083
1084 if (below)
1085 below->above = above;
1086 1048
1087 /* we set up values so that it could be inserted into 1049 /* we set up values so that it could be inserted into
1088 * the map, but we don't actually do that - it is up 1050 * the map, but we don't actually do that - it is up
1089 * to the caller to decide what we want to do. 1051 * to the caller to decide what we want to do.
1090 */ 1052 */
1091 map = env->map; 1053 map = env->map;
1092 x = env->x; 1054 x = env->x;
1093 y = env->y; 1055 y = env->y;
1056
1057 // make sure cmov optimisation is applicable
1058 *(above ? &above->below : &env->inv) = below;
1059 *(below ? &below->above : &above ) = above; // &above is just a dummy
1060
1094 above = 0; 1061 above = 0;
1095 below = 0; 1062 below = 0;
1096 env = 0; 1063 env = 0;
1097 1064
1098 /* NO_FIX_PLAYER is set when a great many changes are being 1065 /* NO_FIX_PLAYER is set when a great many changes are being
1099 * made to players inventory. If set, avoiding the call 1066 * made to players inventory. If set, avoiding the call
1100 * to save cpu time. 1067 * to save cpu time.
1101 */ 1068 */
1102 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1069 if (pl)
1070 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1071 {
1103 otmp->update_stats (); 1072 pl->update_stats ();
1073
1074 if (glow_radius && pl->is_on_map ())
1075 update_all_los (pl->map, pl->x, pl->y);
1076 }
1104 } 1077 }
1105 else if (map) 1078 else if (map)
1106 { 1079 {
1107 if (type == PLAYER)
1108 {
1109 // leaving a spot always closes any open container on the ground
1110 if (container && !container->env)
1111 // this causes spurious floorbox updates, but it ensures
1112 // that the CLOSE event is being sent.
1113 close_container ();
1114
1115 --map->players;
1116 map->touch ();
1117 }
1118
1119 map->dirty = true; 1080 map->dirty = true;
1120 mapspace &ms = this->ms (); 1081 mapspace &ms = this->ms ();
1121 1082
1083 if (object *pl = ms.player ())
1084 {
1085 if (is_player ())
1086 {
1087 if (!flag [FLAG_WIZPASS])
1088 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1089
1090 // leaving a spot always closes any open container on the ground
1091 if (container && !container->env)
1092 // this causes spurious floorbox updates, but it ensures
1093 // that the CLOSE event is being sent.
1094 close_container ();
1095
1096 --map->players;
1097 map->touch ();
1098 }
1099 else if (pl->container_ () == this)
1100 {
1101 // removing a container should close it
1102 close_container ();
1103 }
1104
1105 esrv_del_item (pl->contr, count);
1106 }
1107
1122 /* link the object above us */ 1108 /* link the object above us */
1123 if (above) 1109 // re-link, make sure compiler can easily use cmove
1124 above->below = below; 1110 *(above ? &above->below : &ms.top) = below;
1125 else 1111 *(below ? &below->above : &ms.bot) = above;
1126 ms.top = below; /* we were top, set new top */
1127
1128 /* Relink the object below us, if there is one */
1129 if (below)
1130 below->above = above;
1131 else
1132 {
1133 /* Nothing below, which means we need to relink map object for this space
1134 * use translated coordinates in case some oddness with map tiling is
1135 * evident
1136 */
1137 if (GET_MAP_OB (map, x, y) != this)
1138 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1139
1140 ms.bot = above; /* goes on above it. */
1141 }
1142 1112
1143 above = 0; 1113 above = 0;
1144 below = 0; 1114 below = 0;
1145 1115
1116 ms.invalidate ();
1117
1146 if (map->in_memory == MAP_SAVING) 1118 if (map->in_memory == MAP_SAVING)
1147 return; 1119 return;
1148 1120
1149 int check_walk_off = !flag [FLAG_NO_APPLY]; 1121 int check_walk_off = !flag [FLAG_NO_APPLY];
1150 1122
1151 if (object *pl = ms.player ()) 1123 if (object *pl = ms.player ())
1152 { 1124 {
1153 if (pl->container == this) 1125 if (pl->container_ () == this)
1154 /* If a container that the player is currently using somehow gets 1126 /* If a container that the player is currently using somehow gets
1155 * removed (most likely destroyed), update the player view 1127 * removed (most likely destroyed), update the player view
1156 * appropriately. 1128 * appropriately.
1157 */ 1129 */
1158 pl->close_container (); 1130 pl->close_container ();
1159 1131
1160 //TODO: the floorbox prev/next might need updating 1132 //TODO: the floorbox prev/next might need updating
1161 esrv_del_item (pl->contr, count); 1133 //esrv_del_item (pl->contr, count);
1134 //TODO: update floorbox to preserve ordering
1135 if (pl->contr->ns)
1136 pl->contr->ns->floorbox_update ();
1162 } 1137 }
1163 1138
1139 if (check_walk_off)
1164 for (tmp = ms.bot; tmp; tmp = tmp->above) 1140 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1165 { 1141 {
1142 above = tmp->above;
1143
1166 /* No point updating the players look faces if he is the object 1144 /* No point updating the players look faces if he is the object
1167 * being removed. 1145 * being removed.
1168 */ 1146 */
1169 1147
1170 /* See if object moving off should effect something */ 1148 /* See if object moving off should effect something */
1171 if (check_walk_off
1172 && ((move_type & tmp->move_off) 1149 if ((move_type & tmp->move_off)
1173 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1150 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1174 {
1175 move_apply (tmp, this, 0); 1151 move_apply (tmp, this, 0);
1176
1177 if (destroyed ())
1178 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1179 } 1152 }
1180 1153
1181 last = tmp; 1154 if (affects_los ())
1182 }
1183
1184 /* last == NULL if there are no objects on this space */
1185 //TODO: this makes little sense, why only update the topmost object?
1186 if (!last)
1187 map->at (x, y).flags_ = 0;
1188 else
1189 update_object (last, UP_OBJ_REMOVE);
1190
1191 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1192 update_all_los (map, x, y); 1155 update_all_los (map, x, y);
1193 } 1156 }
1194} 1157}
1195 1158
1196/* 1159/*
1220 esrv_update_item (UPD_NROF, pl, top); 1183 esrv_update_item (UPD_NROF, pl, top);
1221 1184
1222 op->weight = 0; // cancel the addition above 1185 op->weight = 0; // cancel the addition above
1223 op->carrying = 0; // must be 0 already 1186 op->carrying = 0; // must be 0 already
1224 1187
1225 op->destroy (1); 1188 op->destroy ();
1226 1189
1227 return top; 1190 return top;
1228 } 1191 }
1229 1192
1230 return 0; 1193 return 0;
1258 * job preparing multi-part monsters. 1221 * job preparing multi-part monsters.
1259 */ 1222 */
1260object * 1223object *
1261insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1224insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1262{ 1225{
1226 op->remove ();
1227
1263 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1228 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1264 { 1229 {
1265 tmp->x = x + tmp->arch->x; 1230 tmp->x = x + tmp->arch->x;
1266 tmp->y = y + tmp->arch->y; 1231 tmp->y = y + tmp->arch->y;
1267 } 1232 }
1290 * just 'op' otherwise 1255 * just 'op' otherwise
1291 */ 1256 */
1292object * 1257object *
1293insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1258insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1294{ 1259{
1295 assert (!op->flag [FLAG_FREED]);
1296
1297 op->remove (); 1260 op->remove ();
1261
1262 if (m == &freed_map)//D TODO: remove soon
1263 {//D
1264 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1265 }//D
1298 1266
1299 /* Ideally, the caller figures this out. However, it complicates a lot 1267 /* Ideally, the caller figures this out. However, it complicates a lot
1300 * of areas of callers (eg, anything that uses find_free_spot would now 1268 * of areas of callers (eg, anything that uses find_free_spot would now
1301 * need extra work 1269 * need extra work
1302 */ 1270 */
1271 maptile *newmap = m;
1303 if (!xy_normalise (m, op->x, op->y)) 1272 if (!xy_normalise (newmap, op->x, op->y))
1304 { 1273 {
1305 op->destroy (1); 1274 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1306 return 0; 1275 return 0;
1307 } 1276 }
1308 1277
1309 if (object *more = op->more) 1278 if (object *more = op->more)
1310 if (!insert_ob_in_map (more, m, originator, flag)) 1279 if (!insert_ob_in_map (more, m, originator, flag))
1311 return 0; 1280 return 0;
1312 1281
1313 CLEAR_FLAG (op, FLAG_REMOVED); 1282 op->flag [FLAG_REMOVED] = false;
1314 1283 op->env = 0;
1315 op->map = m; 1284 op->map = newmap;
1285
1316 mapspace &ms = op->ms (); 1286 mapspace &ms = op->ms ();
1317 1287
1318 /* this has to be done after we translate the coordinates. 1288 /* this has to be done after we translate the coordinates.
1319 */ 1289 */
1320 if (op->nrof && !(flag & INS_NO_MERGE)) 1290 if (op->nrof && !(flag & INS_NO_MERGE))
1321 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1291 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322 if (object::can_merge (op, tmp)) 1292 if (object::can_merge (op, tmp))
1323 { 1293 {
1324 // TODO: we atcually want to update tmp, not op, 1294 // TODO: we actually want to update tmp, not op,
1325 // but some caller surely breaks when we return tmp 1295 // but some caller surely breaks when we return tmp
1326 // from here :/ 1296 // from here :/
1327 op->nrof += tmp->nrof; 1297 op->nrof += tmp->nrof;
1328 tmp->destroy (1); 1298 tmp->destroy ();
1329 } 1299 }
1330 1300
1331 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1301 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1332 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1302 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1333 1303
1340 { 1310 {
1341 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1311 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1342 abort (); 1312 abort ();
1343 } 1313 }
1344 1314
1315 if (!originator->is_on_map ())
1316 {
1317 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1318 op->debug_desc (), originator->debug_desc ());
1319 abort ();
1320 }
1321
1345 op->above = originator; 1322 op->above = originator;
1346 op->below = originator->below; 1323 op->below = originator->below;
1347
1348 if (op->below)
1349 op->below->above = op;
1350 else
1351 ms.bot = op;
1352
1353 /* since *below* originator, no need to update top */
1354 originator->below = op; 1324 originator->below = op;
1325
1326 *(op->below ? &op->below->above : &ms.bot) = op;
1355 } 1327 }
1356 else 1328 else
1357 { 1329 {
1358 object *top, *floor = NULL; 1330 object *floor = 0;
1359 1331 object *top = ms.top;
1360 top = ms.bot;
1361 1332
1362 /* If there are other objects, then */ 1333 /* If there are other objects, then */
1363 if (top) 1334 if (top)
1364 { 1335 {
1365 object *last = 0;
1366
1367 /* 1336 /*
1368 * If there are multiple objects on this space, we do some trickier handling. 1337 * If there are multiple objects on this space, we do some trickier handling.
1369 * We've already dealt with merging if appropriate. 1338 * We've already dealt with merging if appropriate.
1370 * Generally, we want to put the new object on top. But if 1339 * Generally, we want to put the new object on top. But if
1371 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1340 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1374 * once we get to them. This reduces the need to traverse over all of 1343 * once we get to them. This reduces the need to traverse over all of
1375 * them when adding another one - this saves quite a bit of cpu time 1344 * them when adding another one - this saves quite a bit of cpu time
1376 * when lots of spells are cast in one area. Currently, it is presumed 1345 * when lots of spells are cast in one area. Currently, it is presumed
1377 * that flying non pickable objects are spell objects. 1346 * that flying non pickable objects are spell objects.
1378 */ 1347 */
1379 for (top = ms.bot; top; top = top->above) 1348 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1380 { 1349 {
1381 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1350 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1382 floor = top; 1351 floor = tmp;
1383 1352
1384 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1353 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1385 { 1354 {
1386 /* We insert above top, so we want this object below this */ 1355 /* We insert above top, so we want this object below this */
1387 top = top->below; 1356 top = tmp->below;
1388 break; 1357 break;
1389 } 1358 }
1390 1359
1391 last = top; 1360 top = tmp;
1392 } 1361 }
1393
1394 /* Don't want top to be NULL, so set it to the last valid object */
1395 top = last;
1396 1362
1397 /* We let update_position deal with figuring out what the space 1363 /* We let update_position deal with figuring out what the space
1398 * looks like instead of lots of conditions here. 1364 * looks like instead of lots of conditions here.
1399 * makes things faster, and effectively the same result. 1365 * makes things faster, and effectively the same result.
1400 */ 1366 */
1407 */ 1373 */
1408 if (!(flag & INS_ON_TOP) 1374 if (!(flag & INS_ON_TOP)
1409 && ms.flags () & P_BLOCKSVIEW 1375 && ms.flags () & P_BLOCKSVIEW
1410 && (op->face && !faces [op->face].visibility)) 1376 && (op->face && !faces [op->face].visibility))
1411 { 1377 {
1378 object *last;
1379
1412 for (last = top; last != floor; last = last->below) 1380 for (last = top; last != floor; last = last->below)
1413 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1381 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1414 break; 1382 break;
1415 1383
1416 /* Check to see if we found the object that blocks view, 1384 /* Check to see if we found the object that blocks view,
1424 } /* If objects on this space */ 1392 } /* If objects on this space */
1425 1393
1426 if (flag & INS_ABOVE_FLOOR_ONLY) 1394 if (flag & INS_ABOVE_FLOOR_ONLY)
1427 top = floor; 1395 top = floor;
1428 1396
1429 /* Top is the object that our object (op) is going to get inserted above. 1397 // insert object above top, or bottom-most if top = 0
1430 */
1431
1432 /* First object on this space */
1433 if (!top) 1398 if (!top)
1434 { 1399 {
1400 op->below = 0;
1435 op->above = ms.bot; 1401 op->above = ms.bot;
1436
1437 if (op->above)
1438 op->above->below = op;
1439
1440 op->below = 0;
1441 ms.bot = op; 1402 ms.bot = op;
1403
1404 *(op->above ? &op->above->below : &ms.top) = op;
1442 } 1405 }
1443 else 1406 else
1444 { /* get inserted into the stack above top */ 1407 {
1445 op->above = top->above; 1408 op->above = top->above;
1446
1447 if (op->above)
1448 op->above->below = op; 1409 top->above = op;
1449 1410
1450 op->below = top; 1411 op->below = top;
1451 top->above = op; 1412 *(op->above ? &op->above->below : &ms.top) = op;
1452 } 1413 }
1414 }
1453 1415
1454 if (!op->above) 1416 if (op->is_player ())
1455 ms.top = op;
1456 } /* else not INS_BELOW_ORIGINATOR */
1457
1458 if (op->type == PLAYER)
1459 { 1417 {
1460 op->contr->do_los = 1; 1418 op->contr->do_los = 1;
1461 ++op->map->players; 1419 ++op->map->players;
1462 op->map->touch (); 1420 op->map->touch ();
1463 } 1421 }
1464 1422
1465 op->map->dirty = true; 1423 op->map->dirty = true;
1466 1424
1467 if (object *pl = ms.player ()) 1425 if (object *pl = ms.player ())
1468 //TODO: the floorbox prev/next might need updating 1426 //TODO: the floorbox prev/next might need updating
1469 esrv_send_item (pl, op); 1427 //esrv_send_item (pl, op);
1428 //TODO: update floorbox to preserve ordering
1429 if (pl->contr->ns)
1430 pl->contr->ns->floorbox_update ();
1470 1431
1471 /* If this object glows, it may affect lighting conditions that are 1432 /* If this object glows, it may affect lighting conditions that are
1472 * visible to others on this map. But update_all_los is really 1433 * visible to others on this map. But update_all_los is really
1473 * an inefficient way to do this, as it means los for all players 1434 * an inefficient way to do this, as it means los for all players
1474 * on the map will get recalculated. The players could very well 1435 * on the map will get recalculated. The players could very well
1475 * be far away from this change and not affected in any way - 1436 * be far away from this change and not affected in any way -
1476 * this should get redone to only look for players within range, 1437 * this should get redone to only look for players within range,
1477 * or just updating the P_UPTODATE for spaces within this area 1438 * or just updating the P_UPTODATE for spaces within this area
1478 * of effect may be sufficient. 1439 * of effect may be sufficient.
1479 */ 1440 */
1480 if (op->map->darkness && (op->glow_radius != 0)) 1441 if (op->affects_los ())
1442 {
1443 op->ms ().invalidate ();
1481 update_all_los (op->map, op->x, op->y); 1444 update_all_los (op->map, op->x, op->y);
1445 }
1482 1446
1483 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1447 /* updates flags (blocked, alive, no magic, etc) for this map space */
1484 update_object (op, UP_OBJ_INSERT); 1448 update_object (op, UP_OBJ_INSERT);
1485 1449
1486 INVOKE_OBJECT (INSERT, op); 1450 INVOKE_OBJECT (INSERT, op);
1493 * blocked() and wall() work properly), and these flags are updated by 1457 * blocked() and wall() work properly), and these flags are updated by
1494 * update_object(). 1458 * update_object().
1495 */ 1459 */
1496 1460
1497 /* if this is not the head or flag has been passed, don't check walk on status */ 1461 /* if this is not the head or flag has been passed, don't check walk on status */
1498 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1462 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1499 { 1463 {
1500 if (check_move_on (op, originator)) 1464 if (check_move_on (op, originator))
1501 return 0; 1465 return 0;
1502 1466
1503 /* If we are a multi part object, lets work our way through the check 1467 /* If we are a multi part object, lets work our way through the check
1514/* this function inserts an object in the map, but if it 1478/* this function inserts an object in the map, but if it
1515 * finds an object of its own type, it'll remove that one first. 1479 * finds an object of its own type, it'll remove that one first.
1516 * op is the object to insert it under: supplies x and the map. 1480 * op is the object to insert it under: supplies x and the map.
1517 */ 1481 */
1518void 1482void
1519replace_insert_ob_in_map (const char *arch_string, object *op) 1483replace_insert_ob_in_map (shstr_tmp archname, object *op)
1520{ 1484{
1521 /* first search for itself and remove any old instances */ 1485 /* first search for itself and remove any old instances */
1522 1486
1523 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1487 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1524 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1488 if (tmp->arch->archname == archname) /* same archetype */
1525 tmp->destroy (1); 1489 tmp->destroy ();
1526 1490
1527 object *tmp = arch_to_object (archetype::find (arch_string)); 1491 object *tmp = arch_to_object (archetype::find (archname));
1528 1492
1529 tmp->x = op->x; 1493 tmp->x = op->x;
1530 tmp->y = op->y; 1494 tmp->y = op->y;
1531 1495
1532 insert_ob_in_map (tmp, op->map, op, 0); 1496 insert_ob_in_map (tmp, op->map, op, 0);
1554 if (!nr) 1518 if (!nr)
1555 return true; 1519 return true;
1556 1520
1557 nr = min (nr, nrof); 1521 nr = min (nr, nrof);
1558 1522
1523 if (nrof > nr)
1524 {
1559 nrof -= nr; 1525 nrof -= nr;
1560
1561 if (nrof)
1562 {
1563 adjust_weight (env, -weight * nr); // carrying == 0 1526 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1564 1527
1565 if (object *pl = visible_to ()) 1528 if (object *pl = visible_to ())
1566 esrv_update_item (UPD_NROF, pl, this); 1529 esrv_update_item (UPD_NROF, pl, this);
1567 1530
1568 return true; 1531 return true;
1569 } 1532 }
1570 else 1533 else
1571 { 1534 {
1572 destroy (1); 1535 destroy ();
1573 return false; 1536 return false;
1574 } 1537 }
1575} 1538}
1576 1539
1577/* 1540/*
1594 } 1557 }
1595 else 1558 else
1596 { 1559 {
1597 decrease (nr); 1560 decrease (nr);
1598 1561
1599 object *op = object_create_clone (this); 1562 object *op = deep_clone ();
1600 op->nrof = nr; 1563 op->nrof = nr;
1601 return op; 1564 return op;
1602 } 1565 }
1603} 1566}
1604 1567
1654 if (object *pl = tmp->visible_to ()) 1617 if (object *pl = tmp->visible_to ())
1655 esrv_update_item (UPD_NROF, pl, tmp); 1618 esrv_update_item (UPD_NROF, pl, tmp);
1656 1619
1657 adjust_weight (this, op->total_weight ()); 1620 adjust_weight (this, op->total_weight ());
1658 1621
1659 op->destroy (1); 1622 op->destroy ();
1660 op = tmp; 1623 op = tmp;
1661 goto inserted; 1624 goto inserted;
1662 } 1625 }
1663 1626
1664 op->owner = 0; // it's his/hers now. period. 1627 op->owner = 0; // it's his/hers now. period.
1682 1645
1683 adjust_weight (this, op->total_weight ()); 1646 adjust_weight (this, op->total_weight ());
1684 1647
1685inserted: 1648inserted:
1686 /* reset the light list and los of the players on the map */ 1649 /* reset the light list and los of the players on the map */
1687 if (op->glow_radius && map && map->darkness) 1650 if (op->glow_radius && is_on_map ())
1651 {
1652 update_stats ();
1688 update_all_los (map, x, y); 1653 update_all_los (map, x, y);
1689 1654 }
1655 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1690 // if this is a player's inventory, update stats 1656 // if this is a player's inventory, update stats
1691 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1692 update_stats (); 1657 update_stats ();
1693 1658
1694 INVOKE_OBJECT (INSERT, this); 1659 INVOKE_OBJECT (INSERT, this);
1695 1660
1696 return op; 1661 return op;
1717 * on top. 1682 * on top.
1718 */ 1683 */
1719int 1684int
1720check_move_on (object *op, object *originator) 1685check_move_on (object *op, object *originator)
1721{ 1686{
1687 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1688 return 0;
1689
1722 object *tmp; 1690 object *tmp;
1723 maptile *m = op->map; 1691 maptile *m = op->map;
1724 int x = op->x, y = op->y; 1692 int x = op->x, y = op->y;
1725 1693
1726 MoveType move_on, move_slow, move_block; 1694 mapspace &ms = m->at (x, y);
1727 1695
1728 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1696 ms.update ();
1729 return 0;
1730 1697
1731 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1698 MoveType move_on = ms.move_on;
1732 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1699 MoveType move_slow = ms.move_slow;
1733 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1700 MoveType move_block = ms.move_block;
1734 1701
1735 /* if nothing on this space will slow op down or be applied, 1702 /* if nothing on this space will slow op down or be applied,
1736 * no need to do checking below. have to make sure move_type 1703 * no need to do checking below. have to make sure move_type
1737 * is set, as lots of objects don't have it set - we treat that 1704 * is set, as lots of objects don't have it set - we treat that
1738 * as walking. 1705 * as walking.
1749 return 0; 1716 return 0;
1750 1717
1751 /* The objects have to be checked from top to bottom. 1718 /* The objects have to be checked from top to bottom.
1752 * Hence, we first go to the top: 1719 * Hence, we first go to the top:
1753 */ 1720 */
1754 1721 for (object *next, *tmp = ms.top; tmp; tmp = next)
1755 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1756 {
1757 /* Trim the search when we find the first other spell effect
1758 * this helps performance so that if a space has 50 spell objects,
1759 * we don't need to check all of them.
1760 */
1761 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1762 break;
1763 } 1722 {
1723 next = tmp->below;
1764 1724
1765 for (; tmp; tmp = tmp->below)
1766 {
1767 if (tmp == op) 1725 if (tmp == op)
1768 continue; /* Can't apply yourself */ 1726 continue; /* Can't apply yourself */
1769 1727
1770 /* Check to see if one of the movement types should be slowed down. 1728 /* Check to see if one of the movement types should be slowed down.
1771 * Second check makes sure that the movement types not being slowed 1729 * Second check makes sure that the movement types not being slowed
1776 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1734 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1777 { 1735 {
1778 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1736 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1779 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1737 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1780 { 1738 {
1781
1782 float
1783 diff = tmp->move_slow_penalty * fabs (op->speed); 1739 float diff = tmp->move_slow_penalty * fabs (op->speed);
1784 1740
1785 if (op->type == PLAYER) 1741 if (op->is_player ())
1786 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1742 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1787 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1743 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1788 diff /= 4.0; 1744 diff /= 4.0;
1789 1745
1790 op->speed_left -= diff; 1746 op->speed_left -= diff;
1791 } 1747 }
1792 } 1748 }
1825 LOG (llevError, "Present_arch called outside map.\n"); 1781 LOG (llevError, "Present_arch called outside map.\n");
1826 return NULL; 1782 return NULL;
1827 } 1783 }
1828 1784
1829 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1785 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1830 if (tmp->arch == at) 1786 if (tmp->arch->archname == at->archname)
1831 return tmp; 1787 return tmp;
1832 1788
1833 return NULL; 1789 return NULL;
1834} 1790}
1835 1791
1899 * The first matching object is returned, or NULL if none. 1855 * The first matching object is returned, or NULL if none.
1900 */ 1856 */
1901object * 1857object *
1902present_arch_in_ob (const archetype *at, const object *op) 1858present_arch_in_ob (const archetype *at, const object *op)
1903{ 1859{
1904 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1905 if (tmp->arch == at) 1861 if (tmp->arch->archname == at->archname)
1906 return tmp; 1862 return tmp;
1907 1863
1908 return NULL; 1864 return NULL;
1909} 1865}
1910 1866
1998 * head of the object should correspond for the entire object. 1954 * head of the object should correspond for the entire object.
1999 */ 1955 */
2000 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1956 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2001 continue; 1957 continue;
2002 1958
2003 if (ob->blocked (m, pos.x, pos.y)) 1959 if (ob->blocked (pos.m, pos.x, pos.y))
2004 continue; 1960 continue;
2005 1961
2006 altern [index++] = i; 1962 altern [index++] = i;
2007 } 1963 }
2008 1964
2076 * there is capable of. 2032 * there is capable of.
2077 */ 2033 */
2078int 2034int
2079find_dir (maptile *m, int x, int y, object *exclude) 2035find_dir (maptile *m, int x, int y, object *exclude)
2080{ 2036{
2081 int i, max = SIZEOFFREE, mflags; 2037 int max = SIZEOFFREE, mflags;
2082
2083 sint16 nx, ny;
2084 object *tmp;
2085 maptile *mp;
2086
2087 MoveType blocked, move_type; 2038 MoveType move_type;
2088 2039
2089 if (exclude && exclude->head_ () != exclude) 2040 if (exclude && exclude->head_ () != exclude)
2090 { 2041 {
2091 exclude = exclude->head; 2042 exclude = exclude->head;
2092 move_type = exclude->move_type; 2043 move_type = exclude->move_type;
2095 { 2046 {
2096 /* If we don't have anything, presume it can use all movement types. */ 2047 /* If we don't have anything, presume it can use all movement types. */
2097 move_type = MOVE_ALL; 2048 move_type = MOVE_ALL;
2098 } 2049 }
2099 2050
2100 for (i = 1; i < max; i++) 2051 for (int i = 1; i < max; i++)
2101 { 2052 {
2102 mp = m; 2053 mapxy pos (m, x, y);
2103 nx = x + freearr_x[i]; 2054 pos.move (i);
2104 ny = y + freearr_y[i];
2105 2055
2106 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2056 if (!pos.normalise ())
2107
2108 if (mflags & P_OUT_OF_MAP)
2109 max = maxfree[i]; 2057 max = maxfree[i];
2110 else 2058 else
2111 { 2059 {
2112 mapspace &ms = mp->at (nx, ny); 2060 mapspace &ms = *pos;
2113 2061
2114 blocked = ms.move_block;
2115
2116 if ((move_type & blocked) == move_type) 2062 if ((move_type & ms.move_block) == move_type)
2117 max = maxfree[i]; 2063 max = maxfree [i];
2118 else if (mflags & P_IS_ALIVE) 2064 else if (ms.flags () & P_IS_ALIVE)
2119 { 2065 {
2120 for (tmp = ms.bot; tmp; tmp = tmp->above) 2066 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2121 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2067 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2122 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2068 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2123 break;
2124
2125 if (tmp)
2126 return freedir[i]; 2069 return freedir [i];
2127 } 2070 }
2128 } 2071 }
2129 } 2072 }
2130 2073
2131 return 0; 2074 return 0;
2206 * This basically means that if direction is 15, then it could either go 2149 * This basically means that if direction is 15, then it could either go
2207 * direction 4, 14, or 16 to get back to where we are. 2150 * direction 4, 14, or 16 to get back to where we are.
2208 * Moved from spell_util.c to object.c with the other related direction 2151 * Moved from spell_util.c to object.c with the other related direction
2209 * functions. 2152 * functions.
2210 */ 2153 */
2211int reduction_dir[SIZEOFFREE][3] = { 2154static const int reduction_dir[SIZEOFFREE][3] = {
2212 {0, 0, 0}, /* 0 */ 2155 {0, 0, 0}, /* 0 */
2213 {0, 0, 0}, /* 1 */ 2156 {0, 0, 0}, /* 1 */
2214 {0, 0, 0}, /* 2 */ 2157 {0, 0, 0}, /* 2 */
2215 {0, 0, 0}, /* 3 */ 2158 {0, 0, 0}, /* 3 */
2216 {0, 0, 0}, /* 4 */ 2159 {0, 0, 0}, /* 4 */
2312int 2255int
2313can_pick (const object *who, const object *item) 2256can_pick (const object *who, const object *item)
2314{ 2257{
2315 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2258 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2316 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2259 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2317 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2260 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2318} 2261}
2319 2262
2320/* 2263/*
2321 * create clone from object to another 2264 * create clone from object to another
2322 */ 2265 */
2323object * 2266object *
2324object_create_clone (object *asrc) 2267object::deep_clone ()
2325{ 2268{
2326 object *dst = 0, *tmp, *src, *prev, *item; 2269 assert (("deep_clone called on non-head object", is_head ()));
2327 2270
2328 if (!asrc) 2271 object *dst = clone ();
2329 return 0;
2330 2272
2331 src = asrc->head_ (); 2273 object *prev = dst;
2332
2333 prev = 0;
2334 for (object *part = src; part; part = part->more) 2274 for (object *part = this->more; part; part = part->more)
2335 { 2275 {
2336 tmp = part->clone (); 2276 object *tmp = part->clone ();
2337 tmp->x -= src->x;
2338 tmp->y -= src->y;
2339
2340 if (!part->head)
2341 {
2342 dst = tmp;
2343 tmp->head = 0;
2344 }
2345 else
2346 tmp->head = dst; 2277 tmp->head = dst;
2347
2348 tmp->more = 0;
2349
2350 if (prev)
2351 prev->more = tmp; 2278 prev->more = tmp;
2352
2353 prev = tmp; 2279 prev = tmp;
2354 } 2280 }
2355 2281
2356 for (item = src->inv; item; item = item->below) 2282 for (object *item = inv; item; item = item->below)
2357 insert_ob_in_ob (object_create_clone (item), dst); 2283 insert_ob_in_ob (item->deep_clone (), dst);
2358 2284
2359 return dst; 2285 return dst;
2360} 2286}
2361 2287
2362/* This returns the first object in who's inventory that 2288/* This returns the first object in who's inventory that
2371 return tmp; 2297 return tmp;
2372 2298
2373 return 0; 2299 return 0;
2374} 2300}
2375 2301
2376/* If ob has a field named key, return the link from the list, 2302shstr_tmp
2377 * otherwise return NULL. 2303object::kv_get (shstr_tmp key) const
2378 *
2379 * key must be a passed in shared string - otherwise, this won't
2380 * do the desired thing.
2381 */
2382key_value *
2383get_ob_key_link (const object *ob, const char *key)
2384{ 2304{
2385 for (key_value *link = ob->key_values; link; link = link->next) 2305 for (key_value *kv = key_values; kv; kv = kv->next)
2386 if (link->key == key) 2306 if (kv->key == key)
2387 return link;
2388
2389 return 0;
2390}
2391
2392/*
2393 * Returns the value of op has an extra_field for key, or NULL.
2394 *
2395 * The argument doesn't need to be a shared string.
2396 *
2397 * The returned string is shared.
2398 */
2399const char *
2400get_ob_key_value (const object *op, const char *const key)
2401{
2402 key_value *link;
2403 shstr_cmp canonical_key (key);
2404
2405 if (!canonical_key)
2406 {
2407 /* 1. There being a field named key on any object
2408 * implies there'd be a shared string to find.
2409 * 2. Since there isn't, no object has this field.
2410 * 3. Therefore, *this* object doesn't have this field.
2411 */
2412 return 0;
2413 }
2414
2415 /* This is copied from get_ob_key_link() above -
2416 * only 4 lines, and saves the function call overhead.
2417 */
2418 for (link = op->key_values; link; link = link->next)
2419 if (link->key == canonical_key)
2420 return link->value; 2307 return kv->value;
2421 2308
2422 return 0; 2309 return shstr ();
2423} 2310}
2424 2311
2425/* 2312void
2426 * Updates the canonical_key in op to value. 2313object::kv_set (shstr_tmp key, shstr_tmp value)
2427 *
2428 * canonical_key is a shared string (value doesn't have to be).
2429 *
2430 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2431 * keys.
2432 *
2433 * Returns TRUE on success.
2434 */
2435int
2436set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2437{ 2314{
2438 key_value *field = NULL, *last = NULL; 2315 for (key_value *kv = key_values; kv; kv = kv->next)
2439 2316 if (kv->key == key)
2440 for (field = op->key_values; field != NULL; field = field->next)
2441 {
2442 if (field->key != canonical_key)
2443 { 2317 {
2444 last = field; 2318 kv->value = value;
2445 continue; 2319 return;
2446 } 2320 }
2447 2321
2448 if (value) 2322 key_value *kv = new key_value;
2449 field->value = value; 2323
2450 else 2324 kv->next = key_values;
2325 kv->key = key;
2326 kv->value = value;
2327
2328 key_values = kv;
2329}
2330
2331void
2332object::kv_del (shstr_tmp key)
2333{
2334 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2335 if ((*kvp)->key == key)
2451 { 2336 {
2452 /* Basically, if the archetype has this key set, 2337 key_value *kv = *kvp;
2453 * we need to store the null value so when we save 2338 *kvp = (*kvp)->next;
2454 * it, we save the empty value so that when we load, 2339 delete kv;
2455 * we get this value back again. 2340 return;
2456 */
2457 if (get_ob_key_link (op->arch, canonical_key))
2458 field->value = 0;
2459 else
2460 {
2461 if (last)
2462 last->next = field->next;
2463 else
2464 op->key_values = field->next;
2465
2466 delete field;
2467 }
2468 } 2341 }
2469 return TRUE;
2470 }
2471 /* IF we get here, key doesn't exist */
2472
2473 /* No field, we'll have to add it. */
2474
2475 if (!add_key)
2476 return FALSE;
2477
2478 /* There isn't any good reason to store a null
2479 * value in the key/value list. If the archetype has
2480 * this key, then we should also have it, so shouldn't
2481 * be here. If user wants to store empty strings,
2482 * should pass in ""
2483 */
2484 if (value == NULL)
2485 return TRUE;
2486
2487 field = new key_value;
2488
2489 field->key = canonical_key;
2490 field->value = value;
2491 /* Usual prepend-addition. */
2492 field->next = op->key_values;
2493 op->key_values = field;
2494
2495 return TRUE;
2496}
2497
2498/*
2499 * Updates the key in op to value.
2500 *
2501 * If add_key is FALSE, this will only update existing keys,
2502 * and not add new ones.
2503 * In general, should be little reason FALSE is ever passed in for add_key
2504 *
2505 * Returns TRUE on success.
2506 */
2507int
2508set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2509{
2510 shstr key_ (key);
2511
2512 return set_ob_key_value_s (op, key_, value, add_key);
2513} 2342}
2514 2343
2515object::depth_iterator::depth_iterator (object *container) 2344object::depth_iterator::depth_iterator (object *container)
2516: iterator_base (container) 2345: iterator_base (container)
2517{ 2346{
2567{ 2396{
2568 char flagdesc[512]; 2397 char flagdesc[512];
2569 char info2[256 * 4]; 2398 char info2[256 * 4];
2570 char *p = info; 2399 char *p = info;
2571 2400
2572 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2401 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2573 count, 2402 count,
2574 uuid.c_str (), 2403 uuid.c_str (),
2575 &name, 2404 &name,
2576 title ? "\",title:\"" : "", 2405 title ? ",title:\"" : "",
2577 title ? (const char *)title : "", 2406 title ? (const char *)title : "",
2407 title ? "\"" : "",
2578 flag_desc (flagdesc, 512), type); 2408 flag_desc (flagdesc, 512), type);
2579 2409
2580 if (!flag[FLAG_REMOVED] && env) 2410 if (!flag[FLAG_REMOVED] && env)
2581 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2411 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2582 2412
2615object::open_container (object *new_container) 2445object::open_container (object *new_container)
2616{ 2446{
2617 if (container == new_container) 2447 if (container == new_container)
2618 return; 2448 return;
2619 2449
2620 if (object *old_container = container) 2450 object *old_container = container;
2451
2452 if (old_container)
2621 { 2453 {
2622 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2454 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2623 return; 2455 return;
2624 2456
2625#if 0 2457#if 0
2627 if (object *closer = old_container->inv) 2459 if (object *closer = old_container->inv)
2628 if (closer->type == CLOSE_CON) 2460 if (closer->type == CLOSE_CON)
2629 closer->destroy (); 2461 closer->destroy ();
2630#endif 2462#endif
2631 2463
2464 // make sure the container is available
2465 esrv_send_item (this, old_container);
2466
2632 old_container->flag [FLAG_APPLIED] = false; 2467 old_container->flag [FLAG_APPLIED] = false;
2633 container = 0; 2468 container = 0;
2634 2469
2470 // client needs item update to make it work, client bug requires this to be separate
2635 esrv_update_item (UPD_FLAGS, this, old_container); 2471 esrv_update_item (UPD_FLAGS, this, old_container);
2472
2636 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2473 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2637 play_sound (sound_find ("chest_close")); 2474 play_sound (sound_find ("chest_close"));
2638 } 2475 }
2639 2476
2640 if (new_container) 2477 if (new_container)
2641 { 2478 {
2651 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2488 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2652 new_container->insert (closer); 2489 new_container->insert (closer);
2653 } 2490 }
2654#endif 2491#endif
2655 2492
2656 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2493 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2494
2495 // make sure the container is available, client bug requires this to be separate
2496 esrv_send_item (this, new_container);
2657 2497
2658 new_container->flag [FLAG_APPLIED] = true; 2498 new_container->flag [FLAG_APPLIED] = true;
2659 container = new_container; 2499 container = new_container;
2660 2500
2501 // client needs flag change
2661 esrv_update_item (UPD_FLAGS, this, new_container); 2502 esrv_update_item (UPD_FLAGS, this, new_container);
2662 esrv_send_inventory (this, new_container); 2503 esrv_send_inventory (this, new_container);
2663 play_sound (sound_find ("chest_open")); 2504 play_sound (sound_find ("chest_open"));
2664 } 2505 }
2506// else if (!old_container->env && contr && contr->ns)
2507// contr->ns->floorbox_reset ();
2665} 2508}
2666 2509
2667object * 2510object *
2668object::force_find (const shstr name) 2511object::force_find (shstr_tmp name)
2669{ 2512{
2670 /* cycle through his inventory to look for the MARK we want to 2513 /* cycle through his inventory to look for the MARK we want to
2671 * place 2514 * place
2672 */ 2515 */
2673 for (object *tmp = inv; tmp; tmp = tmp->below) 2516 for (object *tmp = inv; tmp; tmp = tmp->below)
2675 return splay (tmp); 2518 return splay (tmp);
2676 2519
2677 return 0; 2520 return 0;
2678} 2521}
2679 2522
2523//-GPL
2524
2680void 2525void
2526object::force_set_timer (int duration)
2527{
2528 this->duration = 1;
2529 this->speed_left = -1.f;
2530
2531 this->set_speed (duration ? 1.f / duration : 0.f);
2532}
2533
2534object *
2681object::force_add (const shstr name, int duration) 2535object::force_add (shstr_tmp name, int duration)
2682{ 2536{
2683 if (object *force = force_find (name)) 2537 if (object *force = force_find (name))
2684 force->destroy (); 2538 force->destroy ();
2685 2539
2686 object *force = get_archetype (FORCE_NAME); 2540 object *force = get_archetype (FORCE_NAME);
2687 2541
2688 force->slaying = name; 2542 force->slaying = name;
2689 force->stats.food = 1; 2543 force->force_set_timer (duration);
2690 force->speed_left = -1.f;
2691
2692 force->set_speed (duration ? 1.f / duration : 0.f);
2693 force->flag [FLAG_IS_USED_UP] = true;
2694 force->flag [FLAG_APPLIED] = true; 2544 force->flag [FLAG_APPLIED] = true;
2695 2545
2696 insert (force); 2546 return insert (force);
2697} 2547}
2698 2548
2699void 2549void
2700object::play_sound (faceidx sound) 2550object::play_sound (faceidx sound) const
2701{ 2551{
2702 if (!sound) 2552 if (!sound)
2703 return; 2553 return;
2704 2554
2705 if (flag [FLAG_REMOVED]) 2555 if (is_on_map ())
2556 map->play_sound (sound, x, y);
2557 else if (object *pl = in_player ())
2558 pl->contr->play_sound (sound);
2559}
2560
2561void
2562object::say_msg (const char *msg) const
2563{
2564 if (is_on_map ())
2565 map->say_msg (msg, x, y);
2566 else if (object *pl = in_player ())
2567 pl->contr->play_sound (sound);
2568}
2569
2570void
2571object::make_noise ()
2572{
2573 // we do not model noise in the map, so instead put
2574 // a temporary light into the noise source
2575 // could use the map instead, but that's less reliable for our
2576 // goal, which is to make invisibility a bit harder to exploit
2577
2578 // currently only works sensibly for players
2579 if (!is_player ())
2706 return; 2580 return;
2707 2581
2708 if (env) 2582 // find old force, or create new one
2709 { 2583 object *force = force_find (shstr_noise_force);
2710 if (object *pl = in_player ()) 2584
2711 pl->contr->play_sound (sound); 2585 if (force)
2712 } 2586 force->speed_left = -1.f; // patch old speed up
2713 else 2587 else
2714 map->play_sound (sound, x, y); 2588 {
2715} 2589 force = archetype::get (shstr_noise_force);
2716 2590
2591 force->slaying = shstr_noise_force;
2592 force->stats.food = 1;
2593 force->speed_left = -1.f;
2594
2595 force->set_speed (1.f / 4.f);
2596 force->flag [FLAG_IS_USED_UP] = true;
2597 force->flag [FLAG_APPLIED] = true;
2598
2599 insert (force);
2600 }
2601}
2602

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines