[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.254 by root, Sun Aug 31 01:17:11 2008 UTC

…		…
139		139
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	141	static bool
142	compare_ob_value_lists_one (const object wants, const object has)	142	compare_ob_value_lists_one (const object wants, const object has)
143	{	143	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	144	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	145	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	146	* different structure or at least keep the lists sorted...
149	*/	147	*/
150		148
151	/* For each field in wants, */	149	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	150	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	151	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	152	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		153
169	/* If we get here, every field in wants has a matching field in has. */	154	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	155	return true;
171	}	156	}
172		157
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	158	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	159	static bool
175	compare_ob_value_lists (const object ob1, const object ob2)	160	compare_ob_value_lists (const object ob1, const object ob2)
176	{	161	{
177	/* However, there may be fields in has which aren't partnered in wants,	162	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison twice. :(	163	* so we need to run the comparison twice. :(
179	*/	164	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	165	return compare_ob_value_lists_one (ob1, ob2)
		166	&& compare_ob_value_lists_one (ob2, ob1);
181	}	167	}
182		168
183	/* Function examines the 2 objects given to it, and returns true if	169	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	170	* they can be merged together.
185	*	171	*
…		…
200	\|\| ob1->speed != ob2->speed	186	\|\| ob1->speed != ob2->speed
201	\|\| ob1->value != ob2->value	187	\|\| ob1->value != ob2->value
202	\|\| ob1->name != ob2->name)	188	\|\| ob1->name != ob2->name)
203	return 0;	189	return 0;
204		190
205	/* Do not merge objects if nrof would overflow. First part checks	191	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	192	* is always 0 .. 2*31-1 /
207	* would fit into a 32 bit signed int, which is often used to hold	193	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof \|\| ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	194	return 0;
212		195
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	196	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	197	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	198	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	203	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		204
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	205	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	206	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		207
225	if (ob1->arch->name != ob2->arch->name	208	if (ob1->arch->archname != ob2->arch->archname
226	\|\| ob1->name != ob2->name	209	\|\| ob1->name != ob2->name
227	\|\| ob1->title != ob2->title	210	\|\| ob1->title != ob2->title
228	\|\| ob1->msg != ob2->msg	211	\|\| ob1->msg != ob2->msg
229	\|\| ob1->weight != ob2->weight	212	\|\| ob1->weight != ob2->weight
230	\|\| ob1->attacktype != ob2->attacktype	213	\|\| ob1->attacktype != ob2->attacktype
231	\|\| ob1->magic != ob2->magic	214	\|\| ob1->magic != ob2->magic
232	\|\| ob1->slaying != ob2->slaying	215	\|\| ob1->slaying != ob2->slaying
233	\|\| ob1->skill != ob2->skill	216	\|\| ob1->skill != ob2->skill
234	\|\| ob1->value != ob2->value	217	\|\| ob1->value != ob2->value
235	\|\| ob1->animation_id != ob2->animation_id	218	\|\| ob1->animation_id != ob2->animation_id
		219	\|\| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	\|\| ob1->client_type != ob2->client_type	220	\|\| ob1->client_type != ob2->client_type
237	\|\| ob1->materialname != ob2->materialname	221	\|\| ob1->materialname != ob2->materialname
238	\|\| ob1->lore != ob2->lore	222	\|\| ob1->lore != ob2->lore
239	\|\| ob1->subtype != ob2->subtype	223	\|\| ob1->subtype != ob2->subtype
240	\|\| ob1->move_type != ob2->move_type	224	\|\| ob1->move_type != ob2->move_type
…		…
358	else	342	else
359	{	343	{
360	// maybe there is a player standing on the same mapspace	344	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	345	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363	if (!pl->container \|\| this == pl->container)	348	\|\| this == pl->container)
364	return pl;	349	return pl;
365	}	350	}
366	}	351	}
367		352
368	return 0;	353	return 0;
369	}	354	}
370		355
371	// adjust weight per container type ("of holding")	356	// adjust weight per container type ("of holding")
372	static sint32	357	static sint32
373	weight_adjust (object *op, sint32 weight)	358	weight_adjust_for (object *op, sint32 weight)
374	{	359	{
375	return op->type == CONTAINER	360	return op->type == CONTAINER
376	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377	: weight;	362	: weight;
378	}	363	}
…		…
384	static void	369	static void
385	adjust_weight (object *op, sint32 weight)	370	adjust_weight (object *op, sint32 weight)
386	{	371	{
387	while (op)	372	while (op)
388	{	373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389	weight = weight_adjust (op, weight);	376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
390		378
391	if (!weight)	379	if (!weight)
392	return;	380	return;
393		381
394	op->carrying += weight;	382	op->carrying += weight;
…		…
417	op->update_weight ();	405	op->update_weight ();
418		406
419	sum += op->total_weight ();	407	sum += op->total_weight ();
420	}	408	}
421		409
422	sum = weight_adjust (this, sum);	410	sum = weight_adjust_for (this, sum);
423		411
424	if (sum != carrying)	412	if (sum != carrying)
425	{	413	{
426	carrying = sum;	414	carrying = sum;
427		415
…		…
489	*/	477	*/
490	object *	478	object *
491	find_object_name (const char *str)	479	find_object_name (const char *str)
492	{	480	{
493	shstr_cmp str_ (str);	481	shstr_cmp str_ (str);
494	object *op;
495		482
		483	if (str_)
496	for_all_objects (op)	484	for_all_objects (op)
497	if (op->name == str_)	485	if (op->name == str_)
498	break;	486	return op;
499		487
500	return op;	488	return 0;
501	}	489	}
502		490
503	/*	491	/*
504	* Sets the owner and sets the skill and exp pointers to owner's current	492	* Sets the owner and sets the skill and exp pointers to owner's current
505	* skill and experience objects.	493	* skill and experience objects.
…		…
603	}	591	}
604		592
605	op->key_values = 0;	593	op->key_values = 0;
606	}	594	}
607		595
608	object &	596	/*
609	object::operator =(const object &src)	597	* copy_to first frees everything allocated by the dst object,
		598	* and then copies the contents of itself into the second
		599	* object, allocating what needs to be allocated. Basically, any
		600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		601	* if the first object is freed, the pointers in the new object
		602	* will point at garbage.
		603	*/
		604	void
		605	object::copy_to (object *dst)
610	{	606	{
611	bool is_freed = flag [FLAG_FREED];	607	dst->remove ();
612	bool is_removed = flag [FLAG_REMOVED];
613
614	(object_copy )this = src;	608	(object_copy )dst = *this;
615
616	flag [FLAG_FREED] = is_freed;
617	flag [FLAG_REMOVED] = is_removed;	609	dst->flag [FLAG_REMOVED] = true;
618		610
619	/* Copy over key_values, if any. */	611	/* Copy over key_values, if any. */
620	if (src.key_values)	612	if (key_values)
621	{	613	{
622	key_value *tail = 0;	614	key_value *tail = 0;
623	key_values = 0;	615	dst->key_values = 0;
624		616
625	for (key_value *i = src.key_values; i; i = i->next)	617	for (key_value *i = key_values; i; i = i->next)
626	{	618	{
627	key_value *new_link = new key_value;	619	key_value *new_link = new key_value;
628		620
629	new_link->next = 0;	621	new_link->next = 0;
630	new_link->key = i->key;	622	new_link->key = i->key;
631	new_link->value = i->value;	623	new_link->value = i->value;
632		624
633	/* Try and be clever here, too. */	625	/* Try and be clever here, too. */
634	if (!key_values)	626	if (!dst->key_values)
635	{	627	{
636	key_values = new_link;	628	dst->key_values = new_link;
637	tail = new_link;	629	tail = new_link;
638	}	630	}
639	else	631	else
640	{	632	{
641	tail->next = new_link;	633	tail->next = new_link;
642	tail = new_link;	634	tail = new_link;
643	}	635	}
644	}	636	}
645	}	637	}
646	}
647
648	/*
649	* copy_to first frees everything allocated by the dst object,
650	* and then copies the contents of itself into the second
651	* object, allocating what needs to be allocated. Basically, any
652	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
653	* if the first object is freed, the pointers in the new object
654	* will point at garbage.
655	*/
656	void
657	object::copy_to (object *dst)
658	{
659	dst = this;
660		638
661	if (speed < 0)	639	if (speed < 0)
662	dst->speed_left -= rndm ();	640	dst->speed_left -= rndm ();
663		641
664	dst->set_speed (dst->speed);	642	dst->set_speed (dst->speed);
…		…
686	object *	664	object *
687	object::clone ()	665	object::clone ()
688	{	666	{
689	object *neu = create ();	667	object *neu = create ();
690	copy_to (neu);	668	copy_to (neu);
		669	neu->map = map; // not copied by copy_to
691	return neu;	670	return neu;
692	}	671	}
693		672
694	/*	673	/*
695	* If an object with the IS_TURNABLE() flag needs to be turned due	674	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
746	* UP_OBJ_FACE: only the objects face has changed.	725	* UP_OBJ_FACE: only the objects face has changed.
747	*/	726	*/
748	void	727	void
749	update_object (object *op, int action)	728	update_object (object *op, int action)
750	{	729	{
751	if (op == NULL)	730	if (!op)
752	{	731	{
753	/* this should never happen */	732	/* this should never happen */
754	LOG (llevDebug, "update_object() called for NULL object.\n");	733	LOG (llevError \| logBacktrace, "update_object() called for NULL object.\n");
755	return;	734	return;
756	}	735	}
757		736
758	if (op->env)	737	if (!op->is_on_map ())
759	{	738	{
760	/* Animation is currently handled by client, so nothing	739	/* Animation is currently handled by client, so nothing
761	* to do in this case.	740	* to do in this case.
762	*/	741	*/
763	return;	742	return;
764	}	743	}
765
766	/* If the map is saving, don't do anything as everything is
767	* going to get freed anyways.
768	*/
769	if (!op->map \|\| op->map->in_memory == MAP_SAVING)
770	return;
771		744
772	/* make sure the object is within map boundaries */	745	/* make sure the object is within map boundaries */
773	if (op->x < 0 \|\| op->x >= op->map->width \|\| op->y < 0 \|\| op->y >= op->map->height)	746	if (op->x < 0 \|\| op->x >= op->map->width \|\| op->y < 0 \|\| op->y >= op->map->height)
774	{	747	{
775	LOG (llevError, "update_object() called for object out of map!\n");	748	LOG (llevError, "update_object() called for object out of map!\n");
…		…
794	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	767	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
795	\|\| (m.move_on \| op->move_on ) != m.move_on	768	\|\| (m.move_on \| op->move_on ) != m.move_on
796	\|\| (m.move_off \| op->move_off ) != m.move_off	769	\|\| (m.move_off \| op->move_off ) != m.move_off
797	\|\| (m.move_slow \| op->move_slow) != m.move_slow	770	\|\| (m.move_slow \| op->move_slow) != m.move_slow
798	/* This isn't perfect, but I don't expect a lot of objects to	771	/* This isn't perfect, but I don't expect a lot of objects to
799	* to have move_allow right now.	772	* have move_allow right now.
800	*/	773	*/
801	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block	774	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block
802	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	775	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
803	m.flags_ = 0;	776	m.flags_ = 0;
804	}	777	}
…		…
930	* drop on that space.	903	* drop on that space.
931	*/	904	*/
932	if (!drop_to_ground	905	if (!drop_to_ground
933	\|\| !map	906	\|\| !map
934	\|\| map->in_memory != MAP_ACTIVE	907	\|\| map->in_memory != MAP_ACTIVE
935	\|\| map->nodrop	908	\|\| map->no_drop
936	\|\| ms ().move_block == MOVE_ALL)	909	\|\| ms ().move_block == MOVE_ALL)
937	{	910	{
938	while (inv)	911	while (inv)
939	{
940	inv->destroy_inv (false);
941	inv->destroy ();	912	inv->destroy (true);
942	}
943	}	913	}
944	else	914	else
945	{ /* Put objects in inventory onto this space */	915	{ /* Put objects in inventory onto this space */
946	while (inv)	916	while (inv)
947	{	917	{
…		…
965	object *op = new object;	935	object *op = new object;
966	op->link ();	936	op->link ();
967	return op;	937	return op;
968	}	938	}
969		939
		940	static struct freed_map : maptile
		941	{
		942	freed_map ()
		943	{
		944	path = "<freed objects map>";
		945	name = "/internal/freed_objects_map";
		946	width = 3;
		947	height = 3;
		948	no_drop = 1;
		949	no_reset = 1;
		950
		951	alloc ();
		952	in_memory = MAP_ACTIVE;
		953	}
		954
		955	~freed_map ()
		956	{
		957	destroy ();
		958	}
		959	} freed_map; // freed objects are moved here to avoid crashes
		960
970	void	961	void
971	object::do_destroy ()	962	object::do_destroy ()
972	{	963	{
973	if (flag [FLAG_IS_LINKED])	964	if (flag [FLAG_IS_LINKED])
974	remove_button_link (this);	965	remove_button_link (this);
…		…
984	unlink ();	975	unlink ();
985		976
986	flag [FLAG_FREED] = 1;	977	flag [FLAG_FREED] = 1;
987		978
988	// hack to ensure that freed objects still have a valid map	979	// hack to ensure that freed objects still have a valid map
989	{
990	static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992	if (!freed_map)
993	{
994	freed_map = new maptile;
995
996	freed_map->path = "<freed objects map>";
997	freed_map->name = "/internal/freed_objects_map";
998	freed_map->width = 3;
999	freed_map->height = 3;
1000	freed_map->nodrop = 1;
1001
1002	freed_map->alloc ();
1003	freed_map->in_memory = MAP_ACTIVE;
1004	}
1005
1006	map = freed_map;	980	map = &freed_map;
1007	x = 1;	981	x = 1;
1008	y = 1;	982	y = 1;
1009	}
1010		983
1011	if (more)	984	if (more)
1012	{	985	{
1013	more->destroy ();	986	more->destroy ();
1014	more = 0;	987	more = 0;
…		…
1031		1004
1032	if (!is_head () && !head->destroyed ())	1005	if (!is_head () && !head->destroyed ())
1033	{	1006	{
1034	LOG (llevError \| logBacktrace, "tried to destroy the tail of an object");	1007	LOG (llevError \| logBacktrace, "tried to destroy the tail of an object");
1035	head->destroy (destroy_inventory);	1008	head->destroy (destroy_inventory);
		1009	return;
1036	}	1010	}
1037		1011
1038	destroy_inv (!destroy_inventory);	1012	destroy_inv (!destroy_inventory);
1039		1013
1040	if (is_head ())	1014	if (is_head ())
…		…
1079	if (object *pl = visible_to ())	1053	if (object *pl = visible_to ())
1080	esrv_del_item (pl->contr, count);	1054	esrv_del_item (pl->contr, count);
1081	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed	1055	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1082		1056
1083	adjust_weight (env, -total_weight ());	1057	adjust_weight (env, -total_weight ());
1084
1085	*(above ? &above->below : &env->inv) = below;
1086
1087	if (below)
1088	below->above = above;
1089		1058
1090	/* we set up values so that it could be inserted into	1059	/* we set up values so that it could be inserted into
1091	* the map, but we don't actually do that - it is up	1060	* the map, but we don't actually do that - it is up
1092	* to the caller to decide what we want to do.	1061	* to the caller to decide what we want to do.
1093	*/	1062	*/
1094	map = env->map;	1063	map = env->map;
1095	x = env->x;	1064	x = env->x;
1096	y = env->y;	1065	y = env->y;
		1066
		1067	// make sure cmov optimisation is applicable
		1068	*(above ? &above->below : &env->inv) = below;
		1069	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1070
1097	above = 0;	1071	above = 0;
1098	below = 0;	1072	below = 0;
1099	env = 0;	1073	env = 0;
1100		1074
1101	/* NO_FIX_PLAYER is set when a great many changes are being	1075	/* NO_FIX_PLAYER is set when a great many changes are being
…		…
1131		1105
1132	esrv_del_item (pl->contr, count);	1106	esrv_del_item (pl->contr, count);
1133	}	1107	}
1134		1108
1135	/* link the object above us */	1109	/* link the object above us */
1136	if (above)	1110	// re-link, make sure compiler can easily use cmove
1137	above->below = below;	1111	*(above ? &above->below : &ms.top) = below;
1138	else	1112	*(below ? &below->above : &ms.bot) = above;
1139	ms.top = below; /* we were top, set new top */
1140
1141	/* Relink the object below us, if there is one */
1142	if (below)
1143	below->above = above;
1144	else
1145	{
1146	/* Nothing below, which means we need to relink map object for this space
1147	* use translated coordinates in case some oddness with map tiling is
1148	* evident
1149	*/
1150	if (GET_MAP_OB (map, x, y) != this)
1151	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1152
1153	ms.bot = above; /* goes on above it. */
1154	}
1155		1113
1156	above = 0;	1114	above = 0;
1157	below = 0;	1115	below = 0;
		1116
		1117	ms.flags_ = 0;
1158		1118
1159	if (map->in_memory == MAP_SAVING)	1119	if (map->in_memory == MAP_SAVING)
1160	return;	1120	return;
1161		1121
1162	int check_walk_off = !flag [FLAG_NO_APPLY];	1122	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1169	* appropriately.	1129	* appropriately.
1170	*/	1130	*/
1171	pl->close_container ();	1131	pl->close_container ();
1172		1132
1173	//TODO: the floorbox prev/next might need updating	1133	//TODO: the floorbox prev/next might need updating
1174	esrv_del_item (pl->contr, count);	1134	//esrv_del_item (pl->contr, count);
		1135	//TODO: update floorbox to preserve ordering
		1136	if (pl->contr->ns)
		1137	pl->contr->ns->floorbox_update ();
1175	}	1138	}
1176		1139
1177	for (tmp = ms.bot; tmp; tmp = tmp->above)	1140	for (tmp = ms.bot; tmp; tmp = tmp->above)
1178	{	1141	{
1179	/* No point updating the players look faces if he is the object	1142	/* No point updating the players look faces if he is the object
…		…
1192	}	1155	}
1193		1156
1194	last = tmp;	1157	last = tmp;
1195	}	1158	}
1196		1159
1197	/* last == NULL if there are no objects on this space */
1198	//TODO: this makes little sense, why only update the topmost object?
1199	if (!last)
1200	map->at (x, y).flags_ = 0;
1201	else
1202	update_object (last, UP_OBJ_REMOVE);
1203
1204	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)	1160	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)
1205	update_all_los (map, x, y);	1161	update_all_los (map, x, y);
1206	}	1162	}
1207	}	1163	}
1208		1164
…		…
1271	* job preparing multi-part monsters.	1227	* job preparing multi-part monsters.
1272	*/	1228	*/
1273	object *	1229	object *
1274	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)	1230	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)
1275	{	1231	{
		1232	op->remove ();
		1233
1276	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1234	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1277	{	1235	{
1278	tmp->x = x + tmp->arch->x;	1236	tmp->x = x + tmp->arch->x;
1279	tmp->y = y + tmp->arch->y;	1237	tmp->y = y + tmp->arch->y;
1280	}	1238	}
…		…
1303	* just 'op' otherwise	1261	* just 'op' otherwise
1304	*/	1262	*/
1305	object *	1263	object *
1306	insert_ob_in_map (object op, maptile m, object *originator, int flag)	1264	insert_ob_in_map (object op, maptile m, object *originator, int flag)
1307	{	1265	{
1308	assert (!op->flag [FLAG_FREED]);	1266	if (op->is_on_map ())
		1267	{
		1268	LOG (llevError, "insert_ob_in_map called for object already on map");
		1269	abort ();
		1270	}
1309		1271
		1272	if (op->env)
		1273	{
		1274	LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1310	op->remove ();	1275	op->remove ();
		1276	}
		1277
		1278	if (op->face && !face_info (op->face))//D TODO: remove soon
		1279	{//D
		1280	LOG (llevError \| logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
		1281	op->face = 1;//D
		1282	}//D
1311		1283
1312	/* Ideally, the caller figures this out. However, it complicates a lot	1284	/* Ideally, the caller figures this out. However, it complicates a lot
1313	* of areas of callers (eg, anything that uses find_free_spot would now	1285	* of areas of callers (eg, anything that uses find_free_spot would now
1314	* need extra work	1286	* need extra work
1315	*/	1287	*/
1316	if (!xy_normalise (m, op->x, op->y))	1288	if (!xy_normalise (m, op->x, op->y))
1317	{	1289	{
1318	op->destroy (1);	1290	op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1319	return 0;	1291	return 0;
1320	}	1292	}
1321		1293
1322	if (object *more = op->more)	1294	if (object *more = op->more)
1323	if (!insert_ob_in_map (more, m, originator, flag))	1295	if (!insert_ob_in_map (more, m, originator, flag))
…		…
1332	*/	1304	*/
1333	if (op->nrof && !(flag & INS_NO_MERGE))	1305	if (op->nrof && !(flag & INS_NO_MERGE))
1334	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1306	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335	if (object::can_merge (op, tmp))	1307	if (object::can_merge (op, tmp))
1336	{	1308	{
1337	// TODO: we atcually want to update tmp, not op,	1309	// TODO: we actually want to update tmp, not op,
1338	// but some caller surely breaks when we return tmp	1310	// but some caller surely breaks when we return tmp
1339	// from here :/	1311	// from here :/
1340	op->nrof += tmp->nrof;	1312	op->nrof += tmp->nrof;
1341	tmp->destroy (1);	1313	tmp->destroy (1);
1342	}	1314	}
…		…
1353	{	1325	{
1354	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1326	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1355	abort ();	1327	abort ();
1356	}	1328	}
1357		1329
		1330	if (!originator->is_on_map ())
		1331	LOG (llevDebug \| logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1332	op->debug_desc (), originator->debug_desc ());
		1333
1358	op->above = originator;	1334	op->above = originator;
1359	op->below = originator->below;	1335	op->below = originator->below;
1360
1361	if (op->below)
1362	op->below->above = op;
1363	else
1364	ms.bot = op;
1365
1366	/* since below originator, no need to update top */
1367	originator->below = op;	1336	originator->below = op;
		1337
		1338	*(op->below ? &op->below->above : &ms.bot) = op;
1368	}	1339	}
1369	else	1340	else
1370	{	1341	{
1371	object top, floor = NULL;	1342	object *floor = 0;
1372		1343	object *top = ms.top;
1373	top = ms.bot;
1374		1344
1375	/* If there are other objects, then */	1345	/* If there are other objects, then */
1376	if (top)	1346	if (top)
1377	{	1347	{
1378	object *last = 0;
1379
1380	/*	1348	/*
1381	* If there are multiple objects on this space, we do some trickier handling.	1349	* If there are multiple objects on this space, we do some trickier handling.
1382	* We've already dealt with merging if appropriate.	1350	* We've already dealt with merging if appropriate.
1383	* Generally, we want to put the new object on top. But if	1351	* Generally, we want to put the new object on top. But if
1384	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1352	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1387	* once we get to them. This reduces the need to traverse over all of	1355	* once we get to them. This reduces the need to traverse over all of
1388	* them when adding another one - this saves quite a bit of cpu time	1356	* them when adding another one - this saves quite a bit of cpu time
1389	* when lots of spells are cast in one area. Currently, it is presumed	1357	* when lots of spells are cast in one area. Currently, it is presumed
1390	* that flying non pickable objects are spell objects.	1358	* that flying non pickable objects are spell objects.
1391	*/	1359	*/
1392	for (top = ms.bot; top; top = top->above)	1360	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1393	{	1361	{
1394	if (QUERY_FLAG (top, FLAG_IS_FLOOR) \|\| QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1362	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) \|\| QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1395	floor = top;	1363	floor = tmp;
1396		1364
1397	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1365	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1398	{	1366	{
1399	/* We insert above top, so we want this object below this */	1367	/* We insert above top, so we want this object below this */
1400	top = top->below;	1368	top = tmp->below;
1401	break;	1369	break;
1402	}	1370	}
1403		1371
1404	last = top;	1372	top = tmp;
1405	}	1373	}
1406
1407	/* Don't want top to be NULL, so set it to the last valid object */
1408	top = last;
1409		1374
1410	/* We let update_position deal with figuring out what the space	1375	/* We let update_position deal with figuring out what the space
1411	* looks like instead of lots of conditions here.	1376	* looks like instead of lots of conditions here.
1412	* makes things faster, and effectively the same result.	1377	* makes things faster, and effectively the same result.
1413	*/	1378	*/
…		…
1420	*/	1385	*/
1421	if (!(flag & INS_ON_TOP)	1386	if (!(flag & INS_ON_TOP)
1422	&& ms.flags () & P_BLOCKSVIEW	1387	&& ms.flags () & P_BLOCKSVIEW
1423	&& (op->face && !faces [op->face].visibility))	1388	&& (op->face && !faces [op->face].visibility))
1424	{	1389	{
		1390	object *last;
		1391
1425	for (last = top; last != floor; last = last->below)	1392	for (last = top; last != floor; last = last->below)
1426	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1393	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1427	break;	1394	break;
1428		1395
1429	/* Check to see if we found the object that blocks view,	1396	/* Check to see if we found the object that blocks view,
…		…
1437	} /* If objects on this space */	1404	} /* If objects on this space */
1438		1405
1439	if (flag & INS_ABOVE_FLOOR_ONLY)	1406	if (flag & INS_ABOVE_FLOOR_ONLY)
1440	top = floor;	1407	top = floor;
1441		1408
1442	/* Top is the object that our object (op) is going to get inserted above.	1409	// insert object above top, or bottom-most if top = 0
1443	*/
1444
1445	/* First object on this space */
1446	if (!top)	1410	if (!top)
1447	{	1411	{
		1412	op->below = 0;
1448	op->above = ms.bot;	1413	op->above = ms.bot;
1449
1450	if (op->above)
1451	op->above->below = op;
1452
1453	op->below = 0;
1454	ms.bot = op;	1414	ms.bot = op;
		1415
		1416	*(op->above ? &op->above->below : &ms.top) = op;
1455	}	1417	}
1456	else	1418	else
1457	{ /* get inserted into the stack above top */	1419	{
1458	op->above = top->above;	1420	op->above = top->above;
1459
1460	if (op->above)
1461	op->above->below = op;	1421	top->above = op;
1462		1422
1463	op->below = top;	1423	op->below = top;
1464	top->above = op;	1424	*(op->above ? &op->above->below : &ms.top) = op;
1465	}	1425	}
1466		1426	}
1467	if (!op->above)
1468	ms.top = op;
1469	} /* else not INS_BELOW_ORIGINATOR */
1470		1427
1471	if (op->type == PLAYER)	1428	if (op->type == PLAYER)
1472	{	1429	{
1473	op->contr->do_los = 1;	1430	op->contr->do_los = 1;
1474	++op->map->players;	1431	++op->map->players;
…		…
1477		1434
1478	op->map->dirty = true;	1435	op->map->dirty = true;
1479		1436
1480	if (object *pl = ms.player ())	1437	if (object *pl = ms.player ())
1481	//TODO: the floorbox prev/next might need updating	1438	//TODO: the floorbox prev/next might need updating
1482	esrv_send_item (pl, op);	1439	//esrv_send_item (pl, op);
		1440	//TODO: update floorbox to preserve ordering
		1441	if (pl->contr->ns)
		1442	pl->contr->ns->floorbox_update ();
1483		1443
1484	/* If this object glows, it may affect lighting conditions that are	1444	/* If this object glows, it may affect lighting conditions that are
1485	* visible to others on this map. But update_all_los is really	1445	* visible to others on this map. But update_all_los is really
1486	* an inefficient way to do this, as it means los for all players	1446	* an inefficient way to do this, as it means los for all players
1487	* on the map will get recalculated. The players could very well	1447	* on the map will get recalculated. The players could very well
…		…
1567	if (!nr)	1527	if (!nr)
1568	return true;	1528	return true;
1569		1529
1570	nr = min (nr, nrof);	1530	nr = min (nr, nrof);
1571		1531
		1532	if (nrof > nr)
		1533	{
1572	nrof -= nr;	1534	nrof -= nr;
1573
1574	if (nrof)
1575	{
1576	adjust_weight (env, -weight * nr); // carrying == 0	1535	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1577		1536
1578	if (object *pl = visible_to ())	1537	if (object *pl = visible_to ())
1579	esrv_update_item (UPD_NROF, pl, this);	1538	esrv_update_item (UPD_NROF, pl, this);
1580		1539
1581	return true;	1540	return true;
1582	}	1541	}
1583	else	1542	else
1584	{	1543	{
1585	destroy (1);	1544	destroy ();
1586	return false;	1545	return false;
1587	}	1546	}
1588	}	1547	}
1589		1548
1590	/*	1549	/*
…		…
1607	}	1566	}
1608	else	1567	else
1609	{	1568	{
1610	decrease (nr);	1569	decrease (nr);
1611		1570
1612	object *op = object_create_clone (this);	1571	object *op = deep_clone ();
1613	op->nrof = nr;	1572	op->nrof = nr;
1614	return op;	1573	return op;
1615	}	1574	}
1616	}	1575	}
1617		1576
…		…
1838	LOG (llevError, "Present_arch called outside map.\n");	1797	LOG (llevError, "Present_arch called outside map.\n");
1839	return NULL;	1798	return NULL;
1840	}	1799	}
1841		1800
1842	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1801	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1843	if (tmp->arch == at)	1802	if (tmp->arch->archname == at->archname)
1844	return tmp;	1803	return tmp;
1845		1804
1846	return NULL;	1805	return NULL;
1847	}	1806	}
1848		1807
…		…
1912	* The first matching object is returned, or NULL if none.	1871	* The first matching object is returned, or NULL if none.
1913	*/	1872	*/
1914	object *	1873	object *
1915	present_arch_in_ob (const archetype at, const object op)	1874	present_arch_in_ob (const archetype at, const object op)
1916	{	1875	{
1917	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1876	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1918	if (tmp->arch == at)	1877	if (tmp->arch->archname == at->archname)
1919	return tmp;	1878	return tmp;
1920		1879
1921	return NULL;	1880	return NULL;
1922	}	1881	}
1923		1882
…		…
2332		2291
2333	/*	2292	/*
2334	* create clone from object to another	2293	* create clone from object to another
2335	*/	2294	*/
2336	object *	2295	object *
2337	object_create_clone (object *asrc)	2296	object::deep_clone ()
2338	{	2297	{
2339	object dst = 0, tmp, src, prev, *item;	2298	assert (("deep_clone called on non-head object", is_head ()));
2340		2299
2341	if (!asrc)	2300	object *dst = clone ();
2342	return 0;
2343		2301
2344	src = asrc->head_ ();	2302	object *prev = dst;
2345
2346	prev = 0;
2347	for (object *part = src; part; part = part->more)	2303	for (object *part = this->more; part; part = part->more)
2348	{	2304	{
2349	tmp = part->clone ();	2305	object *tmp = part->clone ();
2350	tmp->x -= src->x;
2351	tmp->y -= src->y;
2352
2353	if (!part->head)
2354	{
2355	dst = tmp;
2356	tmp->head = 0;
2357	}
2358	else
2359	tmp->head = dst;	2306	tmp->head = dst;
2360
2361	tmp->more = 0;
2362
2363	if (prev)
2364	prev->more = tmp;	2307	prev->more = tmp;
2365
2366	prev = tmp;	2308	prev = tmp;
2367	}	2309	}
2368		2310
2369	for (item = src->inv; item; item = item->below)	2311	for (object *item = inv; item; item = item->below)
2370	insert_ob_in_ob (object_create_clone (item), dst);	2312	insert_ob_in_ob (item->deep_clone (), dst);
2371		2313
2372	return dst;	2314	return dst;
2373	}	2315	}
2374		2316
2375	/* This returns the first object in who's inventory that	2317	/* This returns the first object in who's inventory that
…		…
2384	return tmp;	2326	return tmp;
2385		2327
2386	return 0;	2328	return 0;
2387	}	2329	}
2388		2330
2389	/* If ob has a field named key, return the link from the list,	2331	const shstr &
2390	* otherwise return NULL.	2332	object::kv_get (const shstr &key) const
2391	*
2392	* key must be a passed in shared string - otherwise, this won't
2393	* do the desired thing.
2394	*/
2395	key_value *
2396	get_ob_key_link (const object ob, const char key)
2397	{	2333	{
2398	for (key_value *link = ob->key_values; link; link = link->next)	2334	for (key_value *kv = key_values; kv; kv = kv->next)
2399	if (link->key == key)	2335	if (kv->key == key)
2400	return link;
2401
2402	return 0;
2403	}
2404
2405	/*
2406	* Returns the value of op has an extra_field for key, or NULL.
2407	*
2408	* The argument doesn't need to be a shared string.
2409	*
2410	* The returned string is shared.
2411	*/
2412	const char *
2413	get_ob_key_value (const object op, const char const key)
2414	{
2415	key_value *link;
2416	shstr_cmp canonical_key (key);
2417
2418	if (!canonical_key)
2419	{
2420	/* 1. There being a field named key on any object
2421	* implies there'd be a shared string to find.
2422	* 2. Since there isn't, no object has this field.
2423	* 3. Therefore, this object doesn't have this field.
2424	*/
2425	return 0;
2426	}
2427
2428	/* This is copied from get_ob_key_link() above -
2429	* only 4 lines, and saves the function call overhead.
2430	*/
2431	for (link = op->key_values; link; link = link->next)
2432	if (link->key == canonical_key)
2433	return link->value;	2336	return kv->value;
2434		2337
2435	return 0;	2338	return shstr_null;
2436	}	2339	}
2437		2340
2438	/*	2341	void
2439	* Updates the canonical_key in op to value.	2342	object::kv_set (const shstr &key, const shstr &value)
2440	*
2441	* canonical_key is a shared string (value doesn't have to be).
2442	*
2443	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2444	* keys.
2445	*
2446	* Returns TRUE on success.
2447	*/
2448	int
2449	set_ob_key_value_s (object op, const shstr & canonical_key, const char value, int add_key)
2450	{	2343	{
2451	key_value field = NULL, last = NULL;	2344	for (key_value *kv = key_values; kv; kv = kv->next)
2452		2345	if (kv->key == key)
2453	for (field = op->key_values; field != NULL; field = field->next)
2454	{
2455	if (field->key != canonical_key)
2456	{	2346	{
2457	last = field;	2347	kv->value = value;
2458	continue;	2348	return;
2459	}	2349	}
2460		2350
2461	if (value)	2351	key_value *kv = new key_value;
2462	field->value = value;	2352
2463	else	2353	kv->next = key_values;
		2354	kv->key = key;
		2355	kv->value = value;
		2356
		2357	key_values = kv;
		2358	}
		2359
		2360	void
		2361	object::kv_del (const shstr &key)
		2362	{
		2363	for (key_value *kvp = &key_values; kvp; kvp = &(*kvp)->next)
		2364	if ((*kvp)->key == key)
2464	{	2365	{
2465	/* Basically, if the archetype has this key set,	2366	key_value kv = kvp;
2466	* we need to store the null value so when we save	2367	kvp = (kvp)->next;
2467	* it, we save the empty value so that when we load,	2368	delete kv;
2468	* we get this value back again.	2369	return;
2469	*/
2470	if (get_ob_key_link (op->arch, canonical_key))
2471	field->value = 0;
2472	else
2473	{
2474	if (last)
2475	last->next = field->next;
2476	else
2477	op->key_values = field->next;
2478
2479	delete field;
2480	}
2481	}	2370	}
2482	return TRUE;
2483	}
2484	/* IF we get here, key doesn't exist */
2485
2486	/* No field, we'll have to add it. */
2487
2488	if (!add_key)
2489	return FALSE;
2490
2491	/* There isn't any good reason to store a null
2492	* value in the key/value list. If the archetype has
2493	* this key, then we should also have it, so shouldn't
2494	* be here. If user wants to store empty strings,
2495	* should pass in ""
2496	*/
2497	if (value == NULL)
2498	return TRUE;
2499
2500	field = new key_value;
2501
2502	field->key = canonical_key;
2503	field->value = value;
2504	/* Usual prepend-addition. */
2505	field->next = op->key_values;
2506	op->key_values = field;
2507
2508	return TRUE;
2509	}
2510
2511	/*
2512	* Updates the key in op to value.
2513	*
2514	* If add_key is FALSE, this will only update existing keys,
2515	* and not add new ones.
2516	* In general, should be little reason FALSE is ever passed in for add_key
2517	*
2518	* Returns TRUE on success.
2519	*/
2520	int
2521	set_ob_key_value (object op, const char key, const char *value, int add_key)
2522	{
2523	shstr key_ (key);
2524
2525	return set_ob_key_value_s (op, key_, value, add_key);
2526	}	2371	}
2527		2372
2528	object::depth_iterator::depth_iterator (object *container)	2373	object::depth_iterator::depth_iterator (object *container)
2529	: iterator_base (container)	2374	: iterator_base (container)
2530	{	2375	{
…		…
2580	{	2425	{
2581	char flagdesc[512];	2426	char flagdesc[512];
2582	char info2[256 * 4];	2427	char info2[256 * 4];
2583	char *p = info;	2428	char *p = info;
2584		2429
2585	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2430	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2586	count,	2431	count,
2587	uuid.c_str (),	2432	uuid.c_str (),
2588	&name,	2433	&name,
2589	title ? "\",title:\"" : "",	2434	title ? ",title:\"" : "",
2590	title ? (const char *)title : "",	2435	title ? (const char *)title : "",
		2436	title ? "\"" : "",
2591	flag_desc (flagdesc, 512), type);	2437	flag_desc (flagdesc, 512), type);
2592		2438
2593	if (!flag[FLAG_REMOVED] && env)	2439	if (!flag[FLAG_REMOVED] && env)
2594	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2440	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2595		2441

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs. Revision 1.254 by root, Sun Aug 31 01:17:11 2008 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.254 by root, Sun Aug 31 01:17:11 2008 UTC