ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.298 by root, Sun Nov 8 00:01:33 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 52 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 56};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
60 0, 58 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
62};
63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64}; 69};
65 70
66static void 71static void
67write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
68{ 73{
139 144
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 145/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 146static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 147compare_ob_value_lists_one (const object *wants, const object *has)
143{ 148{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 149 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 150 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 151 * different structure or at least keep the lists sorted...
149 */ 152 */
150 153
151 /* For each field in wants, */ 154 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 155 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 156 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 157 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 158
169 /* If we get here, every field in wants has a matching field in has. */ 159 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 160 return true;
171} 161}
172 162
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 163/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 164static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 165compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 166{
177 /* However, there may be fields in has which aren't partnered in wants, 167 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 168 * so we need to run the comparison *twice*. :(
179 */ 169 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 170 return compare_ob_value_lists_one (ob1, ob2)
171 && compare_ob_value_lists_one (ob2, ob1);
181} 172}
182 173
183/* Function examines the 2 objects given to it, and returns true if 174/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 175 * they can be merged together.
185 * 176 *
195bool object::can_merge_slow (object *ob1, object *ob2) 186bool object::can_merge_slow (object *ob1, object *ob2)
196{ 187{
197 /* A couple quicksanity checks */ 188 /* A couple quicksanity checks */
198 if (ob1 == ob2 189 if (ob1 == ob2
199 || ob1->type != ob2->type 190 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed 191 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED
201 || ob1->value != ob2->value 192 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 193 || ob1->name != ob2->name)
203 return 0; 194 return 0;
204 195
205 /* Do not merge objects if nrof would overflow. First part checks 196 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 197 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 198 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 199 return 0;
212 200
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 201 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 202 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 203 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 209
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 210 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 211 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 212
225 if (ob1->arch->name != ob2->arch->name 213 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 214 || ob1->name != ob2->name
227 || ob1->title != ob2->title 215 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 216 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 217 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 218 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 219 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 220 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 221 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 222 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 223 || ob1->animation_id != ob2->animation_id
224 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 225 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 226 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 227 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 228 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 229 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 230 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 231 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 232 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 233 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 234 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 235 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 236 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 238 return 0;
250 239
251 if ((ob1->flag ^ ob2->flag) 240 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 241 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 242 .reset (FLAG_REMOVED)
255 .any ()) 243 .any ())
256 return 0; 244 return 0;
257 245
258 /* This is really a spellbook check - we should in general 246 /* This is really a spellbook check - we should in general
340 { 328 {
341 // see if we are in a container of sorts 329 // see if we are in a container of sorts
342 if (env) 330 if (env)
343 { 331 {
344 // the player inventory itself is always visible 332 // the player inventory itself is always visible
345 if (env->type == PLAYER) 333 if (env->is_player ())
346 return env; 334 return env;
347 335
348 // else a player could have our env open 336 // else a player could have our env open
349 object *envest = env->outer_env (); 337 object *envest = env->outer_env_or_self ();
350 338
351 // the player itself is always on a map, so we will find him here 339 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 340 // even if our inv is in a player.
353 if (envest->is_on_map ()) 341 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 342 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 343 if (pl->container_ () == env)
356 return pl; 344 return pl;
357 } 345 }
358 else 346 else
359 { 347 {
360 // maybe there is a player standing on the same mapspace 348 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 349 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 350 if (object *pl = ms ().player ())
363 if (!pl->container || this == pl->container) 351 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
352 || pl->container_ () == this)
364 return pl; 353 return pl;
365 } 354 }
366 } 355 }
367 356
368 return 0; 357 return 0;
369} 358}
370 359
371// adjust weight per container type ("of holding") 360// adjust weight per container type ("of holding")
372static sint32 361static sint32
373weight_adjust (object *op, sint32 weight) 362weight_adjust_for (object *op, sint32 weight)
374{ 363{
375 return op->type == CONTAINER 364 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 365 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 366 : weight;
378} 367}
384static void 373static void
385adjust_weight (object *op, sint32 weight) 374adjust_weight (object *op, sint32 weight)
386{ 375{
387 while (op) 376 while (op)
388 { 377 {
378 // adjust by actual difference to account for rounding errors
379 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 380 weight = weight_adjust_for (op, op->carrying)
381 - weight_adjust_for (op, op->carrying - weight);
390 382
391 if (!weight) 383 if (!weight)
392 return; 384 return;
393 385
394 op->carrying += weight; 386 op->carrying += weight;
417 op->update_weight (); 409 op->update_weight ();
418 410
419 sum += op->total_weight (); 411 sum += op->total_weight ();
420 } 412 }
421 413
422 sum = weight_adjust (this, sum); 414 sum = weight_adjust_for (this, sum);
423 415
424 if (sum != carrying) 416 if (sum != carrying)
425 { 417 {
426 carrying = sum; 418 carrying = sum;
427 419
443 object_freezer freezer; 435 object_freezer freezer;
444 op->write (freezer); 436 op->write (freezer);
445 return freezer.as_string (); 437 return freezer.as_string ();
446} 438}
447 439
448/* 440char *
449 * get_nearest_part(multi-object, object 2) returns the part of the 441object::as_string ()
450 * multi-object 1 which is closest to the second object.
451 * If it's not a multi-object, it is returned.
452 */
453object *
454get_nearest_part (object *op, const object *pl)
455{ 442{
456 object *tmp, *closest; 443 return dump_object (this);
457 int last_dist, i;
458
459 if (!op->more)
460 return op;
461
462 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
463 tmp;
464 tmp = tmp->more)
465 if ((i = distance (tmp, pl)) < last_dist)
466 closest = tmp, last_dist = i;
467
468 return closest;
469} 444}
470 445
471/* 446/*
472 * Returns the object which has the count-variable equal to the argument. 447 * Returns the object which has the count-variable equal to the argument.
473 * VERRRY slow. 448 * VERRRY slow.
489 */ 464 */
490object * 465object *
491find_object_name (const char *str) 466find_object_name (const char *str)
492{ 467{
493 shstr_cmp str_ (str); 468 shstr_cmp str_ (str);
494 object *op;
495 469
470 if (str_)
496 for_all_objects (op) 471 for_all_objects (op)
497 if (op->name == str_) 472 if (op->name == str_)
498 break; 473 return op;
499 474
500 return op; 475 return 0;
501} 476}
502 477
503/* 478/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 479 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 480 * skill and experience objects.
567 update_stats (); 542 update_stats ();
568 543
569 new_draw_info_format (NDI_UNIQUE, 0, this, 544 new_draw_info_format (NDI_UNIQUE, 0, this,
570 "You try to balance all your items at once, " 545 "You try to balance all your items at once, "
571 "but the %s is just too much for your body. " 546 "but the %s is just too much for your body. "
572 "[You need to unapply some items first.]", &ob->name); 547 "[You need to unapply some items first - use the 'body' command to see "
548 "how many items you cna wera on a specific body part.]", &ob->name);
573 return false; 549 return false;
574 } 550 }
575 551
576 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 552 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577 } 553 }
603 } 579 }
604 580
605 op->key_values = 0; 581 op->key_values = 0;
606} 582}
607 583
608object & 584/*
609object::operator =(const object &src) 585 * copy_to first frees everything allocated by the dst object,
586 * and then copies the contents of itself into the second
587 * object, allocating what needs to be allocated. Basically, any
588 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
589 * if the first object is freed, the pointers in the new object
590 * will point at garbage.
591 */
592void
593object::copy_to (object *dst)
610{ 594{
611 bool is_freed = flag [FLAG_FREED]; 595 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 596 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 597 dst->flag [FLAG_REMOVED] = true;
618 598
619 /* Copy over key_values, if any. */ 599 /* Copy over key_values, if any. */
620 if (src.key_values) 600 if (key_values)
621 { 601 {
622 key_value *tail = 0; 602 key_value *tail = 0;
623 key_values = 0; 603 dst->key_values = 0;
624 604
625 for (key_value *i = src.key_values; i; i = i->next) 605 for (key_value *i = key_values; i; i = i->next)
626 { 606 {
627 key_value *new_link = new key_value; 607 key_value *new_link = new key_value;
628 608
629 new_link->next = 0; 609 new_link->next = 0;
630 new_link->key = i->key; 610 new_link->key = i->key;
631 new_link->value = i->value; 611 new_link->value = i->value;
632 612
633 /* Try and be clever here, too. */ 613 /* Try and be clever here, too. */
634 if (!key_values) 614 if (!dst->key_values)
635 { 615 {
636 key_values = new_link; 616 dst->key_values = new_link;
637 tail = new_link; 617 tail = new_link;
638 } 618 }
639 else 619 else
640 { 620 {
641 tail->next = new_link; 621 tail->next = new_link;
642 tail = new_link; 622 tail = new_link;
643 } 623 }
644 } 624 }
645 } 625 }
646}
647
648/*
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660 626
661 if (speed < 0) 627 if (speed < 0)
662 dst->speed_left -= rndm (); 628 dst->speed_left -= rndm ();
663 629
664 dst->set_speed (dst->speed); 630 dst->activate ();
665} 631}
666 632
667void 633void
668object::instantiate () 634object::instantiate ()
669{ 635{
686object * 652object *
687object::clone () 653object::clone ()
688{ 654{
689 object *neu = create (); 655 object *neu = create ();
690 copy_to (neu); 656 copy_to (neu);
657 neu->map = map; // not copied by copy_to
691 return neu; 658 return neu;
692} 659}
693 660
694/* 661/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 662 * If an object with the IS_TURNABLE() flag needs to be turned due
712 * This function needs to be called whenever the speed of an object changes. 679 * This function needs to be called whenever the speed of an object changes.
713 */ 680 */
714void 681void
715object::set_speed (float speed) 682object::set_speed (float speed)
716{ 683{
717 if (flag [FLAG_FREED] && speed)
718 {
719 LOG (llevError, "Object %s is freed but has speed.\n", &name);
720 speed = 0;
721 }
722
723 this->speed = speed; 684 this->speed = speed;
724 685
725 if (has_active_speed ()) 686 if (has_active_speed ())
726 activate (); 687 activate ();
727 else 688 else
746 * UP_OBJ_FACE: only the objects face has changed. 707 * UP_OBJ_FACE: only the objects face has changed.
747 */ 708 */
748void 709void
749update_object (object *op, int action) 710update_object (object *op, int action)
750{ 711{
751 if (op == NULL) 712 if (!op)
752 { 713 {
753 /* this should never happen */ 714 /* this should never happen */
754 LOG (llevDebug, "update_object() called for NULL object.\n"); 715 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
755 return; 716 return;
756 } 717 }
757 718
758 if (op->env) 719 if (!op->is_on_map ())
759 { 720 {
760 /* Animation is currently handled by client, so nothing 721 /* Animation is currently handled by client, so nothing
761 * to do in this case. 722 * to do in this case.
762 */ 723 */
763 return; 724 return;
764 } 725 }
765
766 /* If the map is saving, don't do anything as everything is
767 * going to get freed anyways.
768 */
769 if (!op->map || op->map->in_memory == MAP_SAVING)
770 return;
771 726
772 /* make sure the object is within map boundaries */ 727 /* make sure the object is within map boundaries */
773 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 728 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
774 { 729 {
775 LOG (llevError, "update_object() called for object out of map!\n"); 730 LOG (llevError, "update_object() called for object out of map!\n");
783 738
784 if (!(m.flags_ & P_UPTODATE)) 739 if (!(m.flags_ & P_UPTODATE))
785 /* nop */; 740 /* nop */;
786 else if (action == UP_OBJ_INSERT) 741 else if (action == UP_OBJ_INSERT)
787 { 742 {
743#if 0
788 // this is likely overkill, TODO: revisit (schmorp) 744 // this is likely overkill, TODO: revisit (schmorp)
789 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 745 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
790 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 746 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
791 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 747 || (op->is_player () && !(m.flags_ & P_PLAYER))
792 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 748 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
793 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 749 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
794 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 750 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
795 || (m.move_on | op->move_on ) != m.move_on 751 || (m.move_on | op->move_on ) != m.move_on
796 || (m.move_off | op->move_off ) != m.move_off 752 || (m.move_off | op->move_off ) != m.move_off
797 || (m.move_slow | op->move_slow) != m.move_slow 753 || (m.move_slow | op->move_slow) != m.move_slow
798 /* This isn't perfect, but I don't expect a lot of objects to 754 /* This isn't perfect, but I don't expect a lot of objects to
799 * to have move_allow right now. 755 * have move_allow right now.
800 */ 756 */
801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 757 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
758 m.invalidate ();
759#else
802 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 760 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
803 m.flags_ = 0; 761 m.invalidate ();
762#endif
804 } 763 }
805 /* if the object is being removed, we can't make intelligent 764 /* if the object is being removed, we can't make intelligent
806 * decisions, because remove_ob can't really pass the object 765 * decisions, because remove_ob can't really pass the object
807 * that is being removed. 766 * that is being removed.
808 */ 767 */
809 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 768 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
810 m.flags_ = 0; 769 m.invalidate ();
811 else if (action == UP_OBJ_FACE) 770 else if (action == UP_OBJ_FACE)
812 /* Nothing to do for that case */ ; 771 /* Nothing to do for that case */ ;
813 else 772 else
814 LOG (llevError, "update_object called with invalid action: %d\n", action); 773 LOG (llevError, "update_object called with invalid action: %d\n", action);
815 774
819 778
820object::object () 779object::object ()
821{ 780{
822 SET_FLAG (this, FLAG_REMOVED); 781 SET_FLAG (this, FLAG_REMOVED);
823 782
824 expmul = 1.0; 783 //expmul = 1.0; declared const for the time being
825 face = blank_face; 784 face = blank_face;
826} 785}
827 786
828object::~object () 787object::~object ()
829{ 788{
859 /* If already on active list, don't do anything */ 818 /* If already on active list, don't do anything */
860 if (active) 819 if (active)
861 return; 820 return;
862 821
863 if (has_active_speed ()) 822 if (has_active_speed ())
823 {
824 if (flag [FLAG_FREED])
825 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
826
864 actives.insert (this); 827 actives.insert (this);
828 }
865} 829}
866 830
867void 831void
868object::activate_recursive () 832object::activate_recursive ()
869{ 833{
930 * drop on that space. 894 * drop on that space.
931 */ 895 */
932 if (!drop_to_ground 896 if (!drop_to_ground
933 || !map 897 || !map
934 || map->in_memory != MAP_ACTIVE 898 || map->in_memory != MAP_ACTIVE
935 || map->nodrop 899 || map->no_drop
936 || ms ().move_block == MOVE_ALL) 900 || ms ().move_block == MOVE_ALL)
937 { 901 {
938 while (inv) 902 while (inv)
939 {
940 inv->destroy_inv (false);
941 inv->destroy (); 903 inv->destroy ();
942 }
943 } 904 }
944 else 905 else
945 { /* Put objects in inventory onto this space */ 906 { /* Put objects in inventory onto this space */
946 while (inv) 907 while (inv)
947 { 908 {
951 || op->flag [FLAG_NO_DROP] 912 || op->flag [FLAG_NO_DROP]
952 || op->type == RUNE 913 || op->type == RUNE
953 || op->type == TRAP 914 || op->type == TRAP
954 || op->flag [FLAG_IS_A_TEMPLATE] 915 || op->flag [FLAG_IS_A_TEMPLATE]
955 || op->flag [FLAG_DESTROY_ON_DEATH]) 916 || op->flag [FLAG_DESTROY_ON_DEATH])
956 op->destroy (true); 917 op->destroy ();
957 else 918 else
958 map->insert (op, x, y); 919 map->insert (op, x, y);
959 } 920 }
960 } 921 }
961} 922}
965 object *op = new object; 926 object *op = new object;
966 op->link (); 927 op->link ();
967 return op; 928 return op;
968} 929}
969 930
931static struct freed_map : maptile
932{
933 freed_map ()
934 {
935 path = "<freed objects map>";
936 name = "/internal/freed_objects_map";
937 width = 3;
938 height = 3;
939 no_drop = 1;
940 no_reset = 1;
941
942 alloc ();
943 in_memory = MAP_ACTIVE;
944 }
945
946 ~freed_map ()
947 {
948 destroy ();
949 }
950} freed_map; // freed objects are moved here to avoid crashes
951
970void 952void
971object::do_destroy () 953object::do_destroy ()
972{ 954{
973 if (flag [FLAG_IS_LINKED]) 955 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 956 remove_link ();
975 957
976 if (flag [FLAG_FRIENDLY]) 958 if (flag [FLAG_FRIENDLY])
977 remove_friendly_object (this); 959 remove_friendly_object (this);
978 960
979 remove (); 961 remove ();
984 unlink (); 966 unlink ();
985 967
986 flag [FLAG_FREED] = 1; 968 flag [FLAG_FREED] = 1;
987 969
988 // hack to ensure that freed objects still have a valid map 970 // hack to ensure that freed objects still have a valid map
989 {
990 static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992 if (!freed_map)
993 {
994 freed_map = new maptile;
995
996 freed_map->path = "<freed objects map>";
997 freed_map->name = "/internal/freed_objects_map";
998 freed_map->width = 3;
999 freed_map->height = 3;
1000 freed_map->nodrop = 1;
1001
1002 freed_map->alloc ();
1003 freed_map->in_memory = MAP_ACTIVE;
1004 }
1005
1006 map = freed_map; 971 map = &freed_map;
1007 x = 1; 972 x = 1;
1008 y = 1; 973 y = 1;
1009 }
1010 974
1011 if (more) 975 if (more)
1012 { 976 {
1013 more->destroy (); 977 more->destroy ();
1014 more = 0; 978 more = 0;
1022 attacked_by = 0; 986 attacked_by = 0;
1023 current_weapon = 0; 987 current_weapon = 0;
1024} 988}
1025 989
1026void 990void
1027object::destroy (bool destroy_inventory) 991object::destroy ()
1028{ 992{
1029 if (destroyed ()) 993 if (destroyed ())
1030 return; 994 return;
1031 995
1032 if (!is_head () && !head->destroyed ()) 996 if (!is_head () && !head->destroyed ())
1033 { 997 {
1034 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 998 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1035 head->destroy (destroy_inventory); 999 head->destroy ();
1000 return;
1036 } 1001 }
1037 1002
1038 destroy_inv (!destroy_inventory); 1003 destroy_inv (false);
1039 1004
1040 if (is_head ()) 1005 if (is_head ())
1041 if (sound_destroy) 1006 if (sound_destroy)
1042 play_sound (sound_destroy); 1007 play_sound (sound_destroy);
1043 else if (flag [FLAG_MONSTER]) 1008 else if (flag [FLAG_MONSTER])
1054 * the previous environment. 1019 * the previous environment.
1055 */ 1020 */
1056void 1021void
1057object::do_remove () 1022object::do_remove ()
1058{ 1023{
1059 object *tmp, *last = 0;
1060 object *otmp;
1061
1062 if (flag [FLAG_REMOVED]) 1024 if (flag [FLAG_REMOVED])
1063 return; 1025 return;
1064 1026
1065 INVOKE_OBJECT (REMOVE, this); 1027 INVOKE_OBJECT (REMOVE, this);
1066 1028
1080 esrv_del_item (pl->contr, count); 1042 esrv_del_item (pl->contr, count);
1081 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1043 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1082 1044
1083 adjust_weight (env, -total_weight ()); 1045 adjust_weight (env, -total_weight ());
1084 1046
1085 *(above ? &above->below : &env->inv) = below; 1047 object *pl = in_player ();
1086
1087 if (below)
1088 below->above = above;
1089 1048
1090 /* we set up values so that it could be inserted into 1049 /* we set up values so that it could be inserted into
1091 * the map, but we don't actually do that - it is up 1050 * the map, but we don't actually do that - it is up
1092 * to the caller to decide what we want to do. 1051 * to the caller to decide what we want to do.
1093 */ 1052 */
1094 map = env->map; 1053 map = env->map;
1095 x = env->x; 1054 x = env->x;
1096 y = env->y; 1055 y = env->y;
1056
1057 // make sure cmov optimisation is applicable
1058 *(above ? &above->below : &env->inv) = below;
1059 *(below ? &below->above : &above ) = above; // &above is just a dummy
1060
1097 above = 0; 1061 above = 0;
1098 below = 0; 1062 below = 0;
1099 env = 0; 1063 env = 0;
1100 1064
1101 /* NO_FIX_PLAYER is set when a great many changes are being 1065 /* NO_FIX_PLAYER is set when a great many changes are being
1102 * made to players inventory. If set, avoiding the call 1066 * made to players inventory. If set, avoiding the call
1103 * to save cpu time. 1067 * to save cpu time.
1104 */ 1068 */
1105 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1069 if (pl)
1070 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1071 {
1106 otmp->update_stats (); 1072 pl->update_stats ();
1073
1074 if (glow_radius && pl->is_on_map ())
1075 update_all_los (pl->map, pl->x, pl->y);
1076 }
1107 } 1077 }
1108 else if (map) 1078 else if (map)
1109 { 1079 {
1110 map->dirty = true; 1080 map->dirty = true;
1111 mapspace &ms = this->ms (); 1081 mapspace &ms = this->ms ();
1112 1082
1113 if (object *pl = ms.player ()) 1083 if (object *pl = ms.player ())
1114 { 1084 {
1115 if (type == PLAYER) // this == pl(!) 1085 if (is_player ())
1116 { 1086 {
1087 if (!flag [FLAG_WIZPASS])
1088 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1089
1117 // leaving a spot always closes any open container on the ground 1090 // leaving a spot always closes any open container on the ground
1118 if (container && !container->env) 1091 if (container && !container->env)
1119 // this causes spurious floorbox updates, but it ensures 1092 // this causes spurious floorbox updates, but it ensures
1120 // that the CLOSE event is being sent. 1093 // that the CLOSE event is being sent.
1121 close_container (); 1094 close_container ();
1122 1095
1123 --map->players; 1096 --map->players;
1124 map->touch (); 1097 map->touch ();
1125 } 1098 }
1126 else if (pl->container == this) 1099 else if (pl->container_ () == this)
1127 { 1100 {
1128 // removing a container should close it 1101 // removing a container should close it
1129 close_container (); 1102 close_container ();
1130 } 1103 }
1131 1104
1132 esrv_del_item (pl->contr, count); 1105 esrv_del_item (pl->contr, count);
1133 } 1106 }
1134 1107
1135 /* link the object above us */ 1108 /* link the object above us */
1136 if (above) 1109 // re-link, make sure compiler can easily use cmove
1137 above->below = below; 1110 *(above ? &above->below : &ms.top) = below;
1138 else 1111 *(below ? &below->above : &ms.bot) = above;
1139 ms.top = below; /* we were top, set new top */
1140
1141 /* Relink the object below us, if there is one */
1142 if (below)
1143 below->above = above;
1144 else
1145 {
1146 /* Nothing below, which means we need to relink map object for this space
1147 * use translated coordinates in case some oddness with map tiling is
1148 * evident
1149 */
1150 if (GET_MAP_OB (map, x, y) != this)
1151 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1152
1153 ms.bot = above; /* goes on above it. */
1154 }
1155 1112
1156 above = 0; 1113 above = 0;
1157 below = 0; 1114 below = 0;
1158 1115
1116 ms.invalidate ();
1117
1159 if (map->in_memory == MAP_SAVING) 1118 if (map->in_memory == MAP_SAVING)
1160 return; 1119 return;
1161 1120
1162 int check_walk_off = !flag [FLAG_NO_APPLY]; 1121 int check_walk_off = !flag [FLAG_NO_APPLY];
1163 1122
1164 if (object *pl = ms.player ()) 1123 if (object *pl = ms.player ())
1165 { 1124 {
1166 if (pl->container == this) 1125 if (pl->container_ () == this)
1167 /* If a container that the player is currently using somehow gets 1126 /* If a container that the player is currently using somehow gets
1168 * removed (most likely destroyed), update the player view 1127 * removed (most likely destroyed), update the player view
1169 * appropriately. 1128 * appropriately.
1170 */ 1129 */
1171 pl->close_container (); 1130 pl->close_container ();
1172 1131
1173 //TODO: the floorbox prev/next might need updating 1132 //TODO: the floorbox prev/next might need updating
1174 esrv_del_item (pl->contr, count); 1133 //esrv_del_item (pl->contr, count);
1134 //TODO: update floorbox to preserve ordering
1135 if (pl->contr->ns)
1136 pl->contr->ns->floorbox_update ();
1175 } 1137 }
1176 1138
1139 if (check_walk_off)
1177 for (tmp = ms.bot; tmp; tmp = tmp->above) 1140 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1178 { 1141 {
1142 above = tmp->above;
1143
1179 /* No point updating the players look faces if he is the object 1144 /* No point updating the players look faces if he is the object
1180 * being removed. 1145 * being removed.
1181 */ 1146 */
1182 1147
1183 /* See if object moving off should effect something */ 1148 /* See if object moving off should effect something */
1184 if (check_walk_off
1185 && ((move_type & tmp->move_off) 1149 if ((move_type & tmp->move_off)
1186 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1150 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1187 {
1188 move_apply (tmp, this, 0); 1151 move_apply (tmp, this, 0);
1189
1190 if (destroyed ())
1191 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1192 } 1152 }
1193 1153
1194 last = tmp; 1154 if (affects_los ())
1195 }
1196
1197 /* last == NULL if there are no objects on this space */
1198 //TODO: this makes little sense, why only update the topmost object?
1199 if (!last)
1200 map->at (x, y).flags_ = 0;
1201 else
1202 update_object (last, UP_OBJ_REMOVE);
1203
1204 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1205 update_all_los (map, x, y); 1155 update_all_los (map, x, y);
1206 } 1156 }
1207} 1157}
1208 1158
1209/* 1159/*
1233 esrv_update_item (UPD_NROF, pl, top); 1183 esrv_update_item (UPD_NROF, pl, top);
1234 1184
1235 op->weight = 0; // cancel the addition above 1185 op->weight = 0; // cancel the addition above
1236 op->carrying = 0; // must be 0 already 1186 op->carrying = 0; // must be 0 already
1237 1187
1238 op->destroy (1); 1188 op->destroy ();
1239 1189
1240 return top; 1190 return top;
1241 } 1191 }
1242 1192
1243 return 0; 1193 return 0;
1271 * job preparing multi-part monsters. 1221 * job preparing multi-part monsters.
1272 */ 1222 */
1273object * 1223object *
1274insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1224insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1275{ 1225{
1226 op->remove ();
1227
1276 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1228 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1277 { 1229 {
1278 tmp->x = x + tmp->arch->x; 1230 tmp->x = x + tmp->arch->x;
1279 tmp->y = y + tmp->arch->y; 1231 tmp->y = y + tmp->arch->y;
1280 } 1232 }
1303 * just 'op' otherwise 1255 * just 'op' otherwise
1304 */ 1256 */
1305object * 1257object *
1306insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1258insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1307{ 1259{
1308 assert (!op->flag [FLAG_FREED]);
1309
1310 op->remove (); 1260 op->remove ();
1261
1262 if (m == &freed_map)//D TODO: remove soon
1263 {//D
1264 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1265 }//D
1311 1266
1312 /* Ideally, the caller figures this out. However, it complicates a lot 1267 /* Ideally, the caller figures this out. However, it complicates a lot
1313 * of areas of callers (eg, anything that uses find_free_spot would now 1268 * of areas of callers (eg, anything that uses find_free_spot would now
1314 * need extra work 1269 * need extra work
1315 */ 1270 */
1271 maptile *newmap = m;
1316 if (!xy_normalise (m, op->x, op->y)) 1272 if (!xy_normalise (newmap, op->x, op->y))
1317 { 1273 {
1318 op->destroy (1); 1274 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1319 return 0; 1275 return 0;
1320 } 1276 }
1321 1277
1322 if (object *more = op->more) 1278 if (object *more = op->more)
1323 if (!insert_ob_in_map (more, m, originator, flag)) 1279 if (!insert_ob_in_map (more, m, originator, flag))
1324 return 0; 1280 return 0;
1325 1281
1326 CLEAR_FLAG (op, FLAG_REMOVED); 1282 op->flag [FLAG_REMOVED] = false;
1327 1283 op->env = 0;
1328 op->map = m; 1284 op->map = newmap;
1285
1329 mapspace &ms = op->ms (); 1286 mapspace &ms = op->ms ();
1330 1287
1331 /* this has to be done after we translate the coordinates. 1288 /* this has to be done after we translate the coordinates.
1332 */ 1289 */
1333 if (op->nrof && !(flag & INS_NO_MERGE)) 1290 if (op->nrof && !(flag & INS_NO_MERGE))
1334 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1291 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335 if (object::can_merge (op, tmp)) 1292 if (object::can_merge (op, tmp))
1336 { 1293 {
1337 // TODO: we atcually want to update tmp, not op, 1294 // TODO: we actually want to update tmp, not op,
1338 // but some caller surely breaks when we return tmp 1295 // but some caller surely breaks when we return tmp
1339 // from here :/ 1296 // from here :/
1340 op->nrof += tmp->nrof; 1297 op->nrof += tmp->nrof;
1341 tmp->destroy (1); 1298 tmp->destroy ();
1342 } 1299 }
1343 1300
1344 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1301 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1345 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1302 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1346 1303
1353 { 1310 {
1354 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1311 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1355 abort (); 1312 abort ();
1356 } 1313 }
1357 1314
1315 if (!originator->is_on_map ())
1316 {
1317 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1318 op->debug_desc (), originator->debug_desc ());
1319 abort ();
1320 }
1321
1358 op->above = originator; 1322 op->above = originator;
1359 op->below = originator->below; 1323 op->below = originator->below;
1360
1361 if (op->below)
1362 op->below->above = op;
1363 else
1364 ms.bot = op;
1365
1366 /* since *below* originator, no need to update top */
1367 originator->below = op; 1324 originator->below = op;
1325
1326 *(op->below ? &op->below->above : &ms.bot) = op;
1368 } 1327 }
1369 else 1328 else
1370 { 1329 {
1371 object *top, *floor = NULL; 1330 object *floor = 0;
1372 1331 object *top = ms.top;
1373 top = ms.bot;
1374 1332
1375 /* If there are other objects, then */ 1333 /* If there are other objects, then */
1376 if (top) 1334 if (top)
1377 { 1335 {
1378 object *last = 0;
1379
1380 /* 1336 /*
1381 * If there are multiple objects on this space, we do some trickier handling. 1337 * If there are multiple objects on this space, we do some trickier handling.
1382 * We've already dealt with merging if appropriate. 1338 * We've already dealt with merging if appropriate.
1383 * Generally, we want to put the new object on top. But if 1339 * Generally, we want to put the new object on top. But if
1384 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1340 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1387 * once we get to them. This reduces the need to traverse over all of 1343 * once we get to them. This reduces the need to traverse over all of
1388 * them when adding another one - this saves quite a bit of cpu time 1344 * them when adding another one - this saves quite a bit of cpu time
1389 * when lots of spells are cast in one area. Currently, it is presumed 1345 * when lots of spells are cast in one area. Currently, it is presumed
1390 * that flying non pickable objects are spell objects. 1346 * that flying non pickable objects are spell objects.
1391 */ 1347 */
1392 for (top = ms.bot; top; top = top->above) 1348 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1393 { 1349 {
1394 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1350 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1395 floor = top; 1351 floor = tmp;
1396 1352
1397 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1353 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1398 { 1354 {
1399 /* We insert above top, so we want this object below this */ 1355 /* We insert above top, so we want this object below this */
1400 top = top->below; 1356 top = tmp->below;
1401 break; 1357 break;
1402 } 1358 }
1403 1359
1404 last = top; 1360 top = tmp;
1405 } 1361 }
1406
1407 /* Don't want top to be NULL, so set it to the last valid object */
1408 top = last;
1409 1362
1410 /* We let update_position deal with figuring out what the space 1363 /* We let update_position deal with figuring out what the space
1411 * looks like instead of lots of conditions here. 1364 * looks like instead of lots of conditions here.
1412 * makes things faster, and effectively the same result. 1365 * makes things faster, and effectively the same result.
1413 */ 1366 */
1420 */ 1373 */
1421 if (!(flag & INS_ON_TOP) 1374 if (!(flag & INS_ON_TOP)
1422 && ms.flags () & P_BLOCKSVIEW 1375 && ms.flags () & P_BLOCKSVIEW
1423 && (op->face && !faces [op->face].visibility)) 1376 && (op->face && !faces [op->face].visibility))
1424 { 1377 {
1378 object *last;
1379
1425 for (last = top; last != floor; last = last->below) 1380 for (last = top; last != floor; last = last->below)
1426 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1381 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1427 break; 1382 break;
1428 1383
1429 /* Check to see if we found the object that blocks view, 1384 /* Check to see if we found the object that blocks view,
1437 } /* If objects on this space */ 1392 } /* If objects on this space */
1438 1393
1439 if (flag & INS_ABOVE_FLOOR_ONLY) 1394 if (flag & INS_ABOVE_FLOOR_ONLY)
1440 top = floor; 1395 top = floor;
1441 1396
1442 /* Top is the object that our object (op) is going to get inserted above. 1397 // insert object above top, or bottom-most if top = 0
1443 */
1444
1445 /* First object on this space */
1446 if (!top) 1398 if (!top)
1447 { 1399 {
1400 op->below = 0;
1448 op->above = ms.bot; 1401 op->above = ms.bot;
1449
1450 if (op->above)
1451 op->above->below = op;
1452
1453 op->below = 0;
1454 ms.bot = op; 1402 ms.bot = op;
1403
1404 *(op->above ? &op->above->below : &ms.top) = op;
1455 } 1405 }
1456 else 1406 else
1457 { /* get inserted into the stack above top */ 1407 {
1458 op->above = top->above; 1408 op->above = top->above;
1459
1460 if (op->above)
1461 op->above->below = op; 1409 top->above = op;
1462 1410
1463 op->below = top; 1411 op->below = top;
1464 top->above = op; 1412 *(op->above ? &op->above->below : &ms.top) = op;
1465 } 1413 }
1414 }
1466 1415
1467 if (!op->above) 1416 if (op->is_player ())
1468 ms.top = op;
1469 } /* else not INS_BELOW_ORIGINATOR */
1470
1471 if (op->type == PLAYER)
1472 { 1417 {
1473 op->contr->do_los = 1; 1418 op->contr->do_los = 1;
1474 ++op->map->players; 1419 ++op->map->players;
1475 op->map->touch (); 1420 op->map->touch ();
1476 } 1421 }
1477 1422
1478 op->map->dirty = true; 1423 op->map->dirty = true;
1479 1424
1480 if (object *pl = ms.player ()) 1425 if (object *pl = ms.player ())
1481 //TODO: the floorbox prev/next might need updating 1426 //TODO: the floorbox prev/next might need updating
1482 esrv_send_item (pl, op); 1427 //esrv_send_item (pl, op);
1428 //TODO: update floorbox to preserve ordering
1429 if (pl->contr->ns)
1430 pl->contr->ns->floorbox_update ();
1483 1431
1484 /* If this object glows, it may affect lighting conditions that are 1432 /* If this object glows, it may affect lighting conditions that are
1485 * visible to others on this map. But update_all_los is really 1433 * visible to others on this map. But update_all_los is really
1486 * an inefficient way to do this, as it means los for all players 1434 * an inefficient way to do this, as it means los for all players
1487 * on the map will get recalculated. The players could very well 1435 * on the map will get recalculated. The players could very well
1488 * be far away from this change and not affected in any way - 1436 * be far away from this change and not affected in any way -
1489 * this should get redone to only look for players within range, 1437 * this should get redone to only look for players within range,
1490 * or just updating the P_UPTODATE for spaces within this area 1438 * or just updating the P_UPTODATE for spaces within this area
1491 * of effect may be sufficient. 1439 * of effect may be sufficient.
1492 */ 1440 */
1493 if (op->map->darkness && (op->glow_radius != 0)) 1441 if (op->affects_los ())
1442 {
1443 op->ms ().invalidate ();
1494 update_all_los (op->map, op->x, op->y); 1444 update_all_los (op->map, op->x, op->y);
1445 }
1495 1446
1496 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1447 /* updates flags (blocked, alive, no magic, etc) for this map space */
1497 update_object (op, UP_OBJ_INSERT); 1448 update_object (op, UP_OBJ_INSERT);
1498 1449
1499 INVOKE_OBJECT (INSERT, op); 1450 INVOKE_OBJECT (INSERT, op);
1506 * blocked() and wall() work properly), and these flags are updated by 1457 * blocked() and wall() work properly), and these flags are updated by
1507 * update_object(). 1458 * update_object().
1508 */ 1459 */
1509 1460
1510 /* if this is not the head or flag has been passed, don't check walk on status */ 1461 /* if this is not the head or flag has been passed, don't check walk on status */
1511 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1462 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1512 { 1463 {
1513 if (check_move_on (op, originator)) 1464 if (check_move_on (op, originator))
1514 return 0; 1465 return 0;
1515 1466
1516 /* If we are a multi part object, lets work our way through the check 1467 /* If we are a multi part object, lets work our way through the check
1527/* this function inserts an object in the map, but if it 1478/* this function inserts an object in the map, but if it
1528 * finds an object of its own type, it'll remove that one first. 1479 * finds an object of its own type, it'll remove that one first.
1529 * op is the object to insert it under: supplies x and the map. 1480 * op is the object to insert it under: supplies x and the map.
1530 */ 1481 */
1531void 1482void
1532replace_insert_ob_in_map (const char *arch_string, object *op) 1483replace_insert_ob_in_map (shstr_tmp archname, object *op)
1533{ 1484{
1534 /* first search for itself and remove any old instances */ 1485 /* first search for itself and remove any old instances */
1535 1486
1536 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1487 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1537 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1488 if (tmp->arch->archname == archname) /* same archetype */
1538 tmp->destroy (1); 1489 tmp->destroy ();
1539 1490
1540 object *tmp = arch_to_object (archetype::find (arch_string)); 1491 object *tmp = arch_to_object (archetype::find (archname));
1541 1492
1542 tmp->x = op->x; 1493 tmp->x = op->x;
1543 tmp->y = op->y; 1494 tmp->y = op->y;
1544 1495
1545 insert_ob_in_map (tmp, op->map, op, 0); 1496 insert_ob_in_map (tmp, op->map, op, 0);
1567 if (!nr) 1518 if (!nr)
1568 return true; 1519 return true;
1569 1520
1570 nr = min (nr, nrof); 1521 nr = min (nr, nrof);
1571 1522
1523 if (nrof > nr)
1524 {
1572 nrof -= nr; 1525 nrof -= nr;
1573
1574 if (nrof)
1575 {
1576 adjust_weight (env, -weight * nr); // carrying == 0 1526 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1577 1527
1578 if (object *pl = visible_to ()) 1528 if (object *pl = visible_to ())
1579 esrv_update_item (UPD_NROF, pl, this); 1529 esrv_update_item (UPD_NROF, pl, this);
1580 1530
1581 return true; 1531 return true;
1582 } 1532 }
1583 else 1533 else
1584 { 1534 {
1585 destroy (1); 1535 destroy ();
1586 return false; 1536 return false;
1587 } 1537 }
1588} 1538}
1589 1539
1590/* 1540/*
1607 } 1557 }
1608 else 1558 else
1609 { 1559 {
1610 decrease (nr); 1560 decrease (nr);
1611 1561
1612 object *op = object_create_clone (this); 1562 object *op = deep_clone ();
1613 op->nrof = nr; 1563 op->nrof = nr;
1614 return op; 1564 return op;
1615 } 1565 }
1616} 1566}
1617 1567
1667 if (object *pl = tmp->visible_to ()) 1617 if (object *pl = tmp->visible_to ())
1668 esrv_update_item (UPD_NROF, pl, tmp); 1618 esrv_update_item (UPD_NROF, pl, tmp);
1669 1619
1670 adjust_weight (this, op->total_weight ()); 1620 adjust_weight (this, op->total_weight ());
1671 1621
1672 op->destroy (1); 1622 op->destroy ();
1673 op = tmp; 1623 op = tmp;
1674 goto inserted; 1624 goto inserted;
1675 } 1625 }
1676 1626
1677 op->owner = 0; // it's his/hers now. period. 1627 op->owner = 0; // it's his/hers now. period.
1695 1645
1696 adjust_weight (this, op->total_weight ()); 1646 adjust_weight (this, op->total_weight ());
1697 1647
1698inserted: 1648inserted:
1699 /* reset the light list and los of the players on the map */ 1649 /* reset the light list and los of the players on the map */
1700 if (op->glow_radius && map && map->darkness) 1650 if (op->glow_radius && is_on_map ())
1651 {
1652 update_stats ();
1701 update_all_los (map, x, y); 1653 update_all_los (map, x, y);
1702 1654 }
1655 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1703 // if this is a player's inventory, update stats 1656 // if this is a player's inventory, update stats
1704 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1705 update_stats (); 1657 update_stats ();
1706 1658
1707 INVOKE_OBJECT (INSERT, this); 1659 INVOKE_OBJECT (INSERT, this);
1708 1660
1709 return op; 1661 return op;
1730 * on top. 1682 * on top.
1731 */ 1683 */
1732int 1684int
1733check_move_on (object *op, object *originator) 1685check_move_on (object *op, object *originator)
1734{ 1686{
1687 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1688 return 0;
1689
1735 object *tmp; 1690 object *tmp;
1736 maptile *m = op->map; 1691 maptile *m = op->map;
1737 int x = op->x, y = op->y; 1692 int x = op->x, y = op->y;
1738 1693
1739 MoveType move_on, move_slow, move_block; 1694 mapspace &ms = m->at (x, y);
1740 1695
1741 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1696 ms.update ();
1742 return 0;
1743 1697
1744 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1698 MoveType move_on = ms.move_on;
1745 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1699 MoveType move_slow = ms.move_slow;
1746 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1700 MoveType move_block = ms.move_block;
1747 1701
1748 /* if nothing on this space will slow op down or be applied, 1702 /* if nothing on this space will slow op down or be applied,
1749 * no need to do checking below. have to make sure move_type 1703 * no need to do checking below. have to make sure move_type
1750 * is set, as lots of objects don't have it set - we treat that 1704 * is set, as lots of objects don't have it set - we treat that
1751 * as walking. 1705 * as walking.
1762 return 0; 1716 return 0;
1763 1717
1764 /* The objects have to be checked from top to bottom. 1718 /* The objects have to be checked from top to bottom.
1765 * Hence, we first go to the top: 1719 * Hence, we first go to the top:
1766 */ 1720 */
1767 1721 for (object *next, *tmp = ms.top; tmp; tmp = next)
1768 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1769 {
1770 /* Trim the search when we find the first other spell effect
1771 * this helps performance so that if a space has 50 spell objects,
1772 * we don't need to check all of them.
1773 */
1774 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1775 break;
1776 } 1722 {
1723 next = tmp->below;
1777 1724
1778 for (; tmp; tmp = tmp->below)
1779 {
1780 if (tmp == op) 1725 if (tmp == op)
1781 continue; /* Can't apply yourself */ 1726 continue; /* Can't apply yourself */
1782 1727
1783 /* Check to see if one of the movement types should be slowed down. 1728 /* Check to see if one of the movement types should be slowed down.
1784 * Second check makes sure that the movement types not being slowed 1729 * Second check makes sure that the movement types not being slowed
1789 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1734 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1790 { 1735 {
1791 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1736 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1792 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1737 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1793 { 1738 {
1794
1795 float
1796 diff = tmp->move_slow_penalty * fabs (op->speed); 1739 float diff = tmp->move_slow_penalty * fabs (op->speed);
1797 1740
1798 if (op->type == PLAYER) 1741 if (op->is_player ())
1799 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1742 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1800 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1743 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1801 diff /= 4.0; 1744 diff /= 4.0;
1802 1745
1803 op->speed_left -= diff; 1746 op->speed_left -= diff;
1804 } 1747 }
1805 } 1748 }
1838 LOG (llevError, "Present_arch called outside map.\n"); 1781 LOG (llevError, "Present_arch called outside map.\n");
1839 return NULL; 1782 return NULL;
1840 } 1783 }
1841 1784
1842 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1785 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1843 if (tmp->arch == at) 1786 if (tmp->arch->archname == at->archname)
1844 return tmp; 1787 return tmp;
1845 1788
1846 return NULL; 1789 return NULL;
1847} 1790}
1848 1791
1912 * The first matching object is returned, or NULL if none. 1855 * The first matching object is returned, or NULL if none.
1913 */ 1856 */
1914object * 1857object *
1915present_arch_in_ob (const archetype *at, const object *op) 1858present_arch_in_ob (const archetype *at, const object *op)
1916{ 1859{
1917 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1918 if (tmp->arch == at) 1861 if (tmp->arch->archname == at->archname)
1919 return tmp; 1862 return tmp;
1920 1863
1921 return NULL; 1864 return NULL;
1922} 1865}
1923 1866
2011 * head of the object should correspond for the entire object. 1954 * head of the object should correspond for the entire object.
2012 */ 1955 */
2013 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1956 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2014 continue; 1957 continue;
2015 1958
2016 if (ob->blocked (m, pos.x, pos.y)) 1959 if (ob->blocked (pos.m, pos.x, pos.y))
2017 continue; 1960 continue;
2018 1961
2019 altern [index++] = i; 1962 altern [index++] = i;
2020 } 1963 }
2021 1964
2089 * there is capable of. 2032 * there is capable of.
2090 */ 2033 */
2091int 2034int
2092find_dir (maptile *m, int x, int y, object *exclude) 2035find_dir (maptile *m, int x, int y, object *exclude)
2093{ 2036{
2094 int i, max = SIZEOFFREE, mflags; 2037 int max = SIZEOFFREE, mflags;
2095
2096 sint16 nx, ny;
2097 object *tmp;
2098 maptile *mp;
2099
2100 MoveType blocked, move_type; 2038 MoveType move_type;
2101 2039
2102 if (exclude && exclude->head_ () != exclude) 2040 if (exclude && exclude->head_ () != exclude)
2103 { 2041 {
2104 exclude = exclude->head; 2042 exclude = exclude->head;
2105 move_type = exclude->move_type; 2043 move_type = exclude->move_type;
2108 { 2046 {
2109 /* If we don't have anything, presume it can use all movement types. */ 2047 /* If we don't have anything, presume it can use all movement types. */
2110 move_type = MOVE_ALL; 2048 move_type = MOVE_ALL;
2111 } 2049 }
2112 2050
2113 for (i = 1; i < max; i++) 2051 for (int i = 1; i < max; i++)
2114 { 2052 {
2115 mp = m; 2053 mapxy pos (m, x, y);
2116 nx = x + freearr_x[i]; 2054 pos.move (i);
2117 ny = y + freearr_y[i];
2118 2055
2119 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2056 if (!pos.normalise ())
2120
2121 if (mflags & P_OUT_OF_MAP)
2122 max = maxfree[i]; 2057 max = maxfree[i];
2123 else 2058 else
2124 { 2059 {
2125 mapspace &ms = mp->at (nx, ny); 2060 mapspace &ms = *pos;
2126 2061
2127 blocked = ms.move_block;
2128
2129 if ((move_type & blocked) == move_type) 2062 if ((move_type & ms.move_block) == move_type)
2130 max = maxfree[i]; 2063 max = maxfree [i];
2131 else if (mflags & P_IS_ALIVE) 2064 else if (ms.flags () & P_IS_ALIVE)
2132 { 2065 {
2133 for (tmp = ms.bot; tmp; tmp = tmp->above) 2066 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2134 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2067 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2135 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2068 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2136 break;
2137
2138 if (tmp)
2139 return freedir[i]; 2069 return freedir [i];
2140 } 2070 }
2141 } 2071 }
2142 } 2072 }
2143 2073
2144 return 0; 2074 return 0;
2219 * This basically means that if direction is 15, then it could either go 2149 * This basically means that if direction is 15, then it could either go
2220 * direction 4, 14, or 16 to get back to where we are. 2150 * direction 4, 14, or 16 to get back to where we are.
2221 * Moved from spell_util.c to object.c with the other related direction 2151 * Moved from spell_util.c to object.c with the other related direction
2222 * functions. 2152 * functions.
2223 */ 2153 */
2224int reduction_dir[SIZEOFFREE][3] = { 2154static const int reduction_dir[SIZEOFFREE][3] = {
2225 {0, 0, 0}, /* 0 */ 2155 {0, 0, 0}, /* 0 */
2226 {0, 0, 0}, /* 1 */ 2156 {0, 0, 0}, /* 1 */
2227 {0, 0, 0}, /* 2 */ 2157 {0, 0, 0}, /* 2 */
2228 {0, 0, 0}, /* 3 */ 2158 {0, 0, 0}, /* 3 */
2229 {0, 0, 0}, /* 4 */ 2159 {0, 0, 0}, /* 4 */
2325int 2255int
2326can_pick (const object *who, const object *item) 2256can_pick (const object *who, const object *item)
2327{ 2257{
2328 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2258 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2329 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2259 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2330 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2260 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2331} 2261}
2332 2262
2333/* 2263/*
2334 * create clone from object to another 2264 * create clone from object to another
2335 */ 2265 */
2336object * 2266object *
2337object_create_clone (object *asrc) 2267object::deep_clone ()
2338{ 2268{
2339 object *dst = 0, *tmp, *src, *prev, *item; 2269 assert (("deep_clone called on non-head object", is_head ()));
2340 2270
2341 if (!asrc) 2271 object *dst = clone ();
2342 return 0;
2343 2272
2344 src = asrc->head_ (); 2273 object *prev = dst;
2345
2346 prev = 0;
2347 for (object *part = src; part; part = part->more) 2274 for (object *part = this->more; part; part = part->more)
2348 { 2275 {
2349 tmp = part->clone (); 2276 object *tmp = part->clone ();
2350 tmp->x -= src->x;
2351 tmp->y -= src->y;
2352
2353 if (!part->head)
2354 {
2355 dst = tmp;
2356 tmp->head = 0;
2357 }
2358 else
2359 tmp->head = dst; 2277 tmp->head = dst;
2360
2361 tmp->more = 0;
2362
2363 if (prev)
2364 prev->more = tmp; 2278 prev->more = tmp;
2365
2366 prev = tmp; 2279 prev = tmp;
2367 } 2280 }
2368 2281
2369 for (item = src->inv; item; item = item->below) 2282 for (object *item = inv; item; item = item->below)
2370 insert_ob_in_ob (object_create_clone (item), dst); 2283 insert_ob_in_ob (item->deep_clone (), dst);
2371 2284
2372 return dst; 2285 return dst;
2373} 2286}
2374 2287
2375/* This returns the first object in who's inventory that 2288/* This returns the first object in who's inventory that
2384 return tmp; 2297 return tmp;
2385 2298
2386 return 0; 2299 return 0;
2387} 2300}
2388 2301
2389/* If ob has a field named key, return the link from the list, 2302shstr_tmp
2390 * otherwise return NULL. 2303object::kv_get (shstr_tmp key) const
2391 *
2392 * key must be a passed in shared string - otherwise, this won't
2393 * do the desired thing.
2394 */
2395key_value *
2396get_ob_key_link (const object *ob, const char *key)
2397{ 2304{
2398 for (key_value *link = ob->key_values; link; link = link->next) 2305 for (key_value *kv = key_values; kv; kv = kv->next)
2399 if (link->key == key) 2306 if (kv->key == key)
2400 return link;
2401
2402 return 0;
2403}
2404
2405/*
2406 * Returns the value of op has an extra_field for key, or NULL.
2407 *
2408 * The argument doesn't need to be a shared string.
2409 *
2410 * The returned string is shared.
2411 */
2412const char *
2413get_ob_key_value (const object *op, const char *const key)
2414{
2415 key_value *link;
2416 shstr_cmp canonical_key (key);
2417
2418 if (!canonical_key)
2419 {
2420 /* 1. There being a field named key on any object
2421 * implies there'd be a shared string to find.
2422 * 2. Since there isn't, no object has this field.
2423 * 3. Therefore, *this* object doesn't have this field.
2424 */
2425 return 0;
2426 }
2427
2428 /* This is copied from get_ob_key_link() above -
2429 * only 4 lines, and saves the function call overhead.
2430 */
2431 for (link = op->key_values; link; link = link->next)
2432 if (link->key == canonical_key)
2433 return link->value; 2307 return kv->value;
2434 2308
2435 return 0; 2309 return shstr ();
2436} 2310}
2437 2311
2438/* 2312void
2439 * Updates the canonical_key in op to value. 2313object::kv_set (shstr_tmp key, shstr_tmp value)
2440 *
2441 * canonical_key is a shared string (value doesn't have to be).
2442 *
2443 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2444 * keys.
2445 *
2446 * Returns TRUE on success.
2447 */
2448int
2449set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2450{ 2314{
2451 key_value *field = NULL, *last = NULL; 2315 for (key_value *kv = key_values; kv; kv = kv->next)
2452 2316 if (kv->key == key)
2453 for (field = op->key_values; field != NULL; field = field->next)
2454 {
2455 if (field->key != canonical_key)
2456 { 2317 {
2457 last = field; 2318 kv->value = value;
2458 continue; 2319 return;
2459 } 2320 }
2460 2321
2461 if (value) 2322 key_value *kv = new key_value;
2462 field->value = value; 2323
2463 else 2324 kv->next = key_values;
2325 kv->key = key;
2326 kv->value = value;
2327
2328 key_values = kv;
2329}
2330
2331void
2332object::kv_del (shstr_tmp key)
2333{
2334 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2335 if ((*kvp)->key == key)
2464 { 2336 {
2465 /* Basically, if the archetype has this key set, 2337 key_value *kv = *kvp;
2466 * we need to store the null value so when we save 2338 *kvp = (*kvp)->next;
2467 * it, we save the empty value so that when we load, 2339 delete kv;
2468 * we get this value back again. 2340 return;
2469 */
2470 if (get_ob_key_link (op->arch, canonical_key))
2471 field->value = 0;
2472 else
2473 {
2474 if (last)
2475 last->next = field->next;
2476 else
2477 op->key_values = field->next;
2478
2479 delete field;
2480 }
2481 } 2341 }
2482 return TRUE;
2483 }
2484 /* IF we get here, key doesn't exist */
2485
2486 /* No field, we'll have to add it. */
2487
2488 if (!add_key)
2489 return FALSE;
2490
2491 /* There isn't any good reason to store a null
2492 * value in the key/value list. If the archetype has
2493 * this key, then we should also have it, so shouldn't
2494 * be here. If user wants to store empty strings,
2495 * should pass in ""
2496 */
2497 if (value == NULL)
2498 return TRUE;
2499
2500 field = new key_value;
2501
2502 field->key = canonical_key;
2503 field->value = value;
2504 /* Usual prepend-addition. */
2505 field->next = op->key_values;
2506 op->key_values = field;
2507
2508 return TRUE;
2509}
2510
2511/*
2512 * Updates the key in op to value.
2513 *
2514 * If add_key is FALSE, this will only update existing keys,
2515 * and not add new ones.
2516 * In general, should be little reason FALSE is ever passed in for add_key
2517 *
2518 * Returns TRUE on success.
2519 */
2520int
2521set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2522{
2523 shstr key_ (key);
2524
2525 return set_ob_key_value_s (op, key_, value, add_key);
2526} 2342}
2527 2343
2528object::depth_iterator::depth_iterator (object *container) 2344object::depth_iterator::depth_iterator (object *container)
2529: iterator_base (container) 2345: iterator_base (container)
2530{ 2346{
2580{ 2396{
2581 char flagdesc[512]; 2397 char flagdesc[512];
2582 char info2[256 * 4]; 2398 char info2[256 * 4];
2583 char *p = info; 2399 char *p = info;
2584 2400
2585 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2401 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2586 count, 2402 count,
2587 uuid.c_str (), 2403 uuid.c_str (),
2588 &name, 2404 &name,
2589 title ? "\",title:\"" : "", 2405 title ? ",title:\"" : "",
2590 title ? (const char *)title : "", 2406 title ? (const char *)title : "",
2407 title ? "\"" : "",
2591 flag_desc (flagdesc, 512), type); 2408 flag_desc (flagdesc, 512), type);
2592 2409
2593 if (!flag[FLAG_REMOVED] && env) 2410 if (!flag[FLAG_REMOVED] && env)
2594 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2411 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2595 2412
2651 container = 0; 2468 container = 0;
2652 2469
2653 // client needs item update to make it work, client bug requires this to be separate 2470 // client needs item update to make it work, client bug requires this to be separate
2654 esrv_update_item (UPD_FLAGS, this, old_container); 2471 esrv_update_item (UPD_FLAGS, this, old_container);
2655 2472
2656 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2473 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2657 play_sound (sound_find ("chest_close")); 2474 play_sound (sound_find ("chest_close"));
2658 } 2475 }
2659 2476
2660 if (new_container) 2477 if (new_container)
2661 { 2478 {
2671 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2488 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2672 new_container->insert (closer); 2489 new_container->insert (closer);
2673 } 2490 }
2674#endif 2491#endif
2675 2492
2676 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2493 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2677 2494
2678 // make sure the container is available, client bug requires this to be separate 2495 // make sure the container is available, client bug requires this to be separate
2679 esrv_send_item (this, new_container); 2496 esrv_send_item (this, new_container);
2680 2497
2681 new_container->flag [FLAG_APPLIED] = true; 2498 new_container->flag [FLAG_APPLIED] = true;
2689// else if (!old_container->env && contr && contr->ns) 2506// else if (!old_container->env && contr && contr->ns)
2690// contr->ns->floorbox_reset (); 2507// contr->ns->floorbox_reset ();
2691} 2508}
2692 2509
2693object * 2510object *
2694object::force_find (const shstr name) 2511object::force_find (shstr_tmp name)
2695{ 2512{
2696 /* cycle through his inventory to look for the MARK we want to 2513 /* cycle through his inventory to look for the MARK we want to
2697 * place 2514 * place
2698 */ 2515 */
2699 for (object *tmp = inv; tmp; tmp = tmp->below) 2516 for (object *tmp = inv; tmp; tmp = tmp->below)
2701 return splay (tmp); 2518 return splay (tmp);
2702 2519
2703 return 0; 2520 return 0;
2704} 2521}
2705 2522
2523//-GPL
2524
2706void 2525void
2526object::force_set_timer (int duration)
2527{
2528 this->duration = 1;
2529 this->speed_left = -1.f;
2530
2531 this->set_speed (duration ? 1.f / duration : 0.f);
2532}
2533
2534object *
2707object::force_add (const shstr name, int duration) 2535object::force_add (shstr_tmp name, int duration)
2708{ 2536{
2709 if (object *force = force_find (name)) 2537 if (object *force = force_find (name))
2710 force->destroy (); 2538 force->destroy ();
2711 2539
2712 object *force = get_archetype (FORCE_NAME); 2540 object *force = get_archetype (FORCE_NAME);
2713 2541
2714 force->slaying = name; 2542 force->slaying = name;
2715 force->stats.food = 1; 2543 force->force_set_timer (duration);
2716 force->speed_left = -1.f;
2717
2718 force->set_speed (duration ? 1.f / duration : 0.f);
2719 force->flag [FLAG_IS_USED_UP] = true;
2720 force->flag [FLAG_APPLIED] = true; 2544 force->flag [FLAG_APPLIED] = true;
2721 2545
2722 insert (force); 2546 return insert (force);
2723} 2547}
2724 2548
2725void 2549void
2726object::play_sound (faceidx sound) 2550object::play_sound (faceidx sound) const
2727{ 2551{
2728 if (!sound) 2552 if (!sound)
2729 return; 2553 return;
2730 2554
2731 if (flag [FLAG_REMOVED]) 2555 if (is_on_map ())
2556 map->play_sound (sound, x, y);
2557 else if (object *pl = in_player ())
2558 pl->contr->play_sound (sound);
2559}
2560
2561void
2562object::say_msg (const char *msg) const
2563{
2564 if (is_on_map ())
2565 map->say_msg (msg, x, y);
2566 else if (object *pl = in_player ())
2567 pl->contr->play_sound (sound);
2568}
2569
2570void
2571object::make_noise ()
2572{
2573 // we do not model noise in the map, so instead put
2574 // a temporary light into the noise source
2575 // could use the map instead, but that's less reliable for our
2576 // goal, which is to make invisibility a bit harder to exploit
2577
2578 // currently only works sensibly for players
2579 if (!is_player ())
2732 return; 2580 return;
2733 2581
2734 if (env) 2582 // find old force, or create new one
2735 { 2583 object *force = force_find (shstr_noise_force);
2736 if (object *pl = in_player ()) 2584
2737 pl->contr->play_sound (sound); 2585 if (force)
2738 } 2586 force->speed_left = -1.f; // patch old speed up
2739 else 2587 else
2740 map->play_sound (sound, x, y); 2588 {
2741} 2589 force = archetype::get (shstr_noise_force);
2742 2590
2591 force->slaying = shstr_noise_force;
2592 force->stats.food = 1;
2593 force->speed_left = -1.f;
2594
2595 force->set_speed (1.f / 4.f);
2596 force->flag [FLAG_IS_USED_UP] = true;
2597 force->flag [FLAG_APPLIED] = true;
2598
2599 insert (force);
2600 }
2601}
2602

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines