ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.342 by sf-kernelpanic, Sun Apr 10 20:30:53 2011 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
40 49
41short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
42 0, 51 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 57 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 61};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
60 0, 63 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 67};
65 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
76const char *wall_suffix[16] = {
77 "0",
78 "1_3",
79 "1_4",
80 "2_1_2",
81 "1_2",
82 "2_2_4",
83 "2_2_1",
84 "3_1",
85 "1_1",
86 "2_2_3",
87 "2_2_2",
88 "3_3",
89 "2_1_1",
90 "3_4",
91 "3_2",
92 "4"
93};
94
66static void 95static void
67write_uuid (uval64 skip, bool sync) 96write_uuid (uval64 skip, bool sync)
68{ 97{
69 CALL_BEGIN (2); 98 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 99 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 101 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 102 CALL_END;
74} 103}
75 104
76static void 105static void
77read_uuid (void) 106read_uuid ()
78{ 107{
79 char filename[MAX_BUF]; 108 char filename[MAX_BUF];
80 109
81 sprintf (filename, "%s/uuid", settings.localdir); 110 sprintf (filename, "%s/uuid", settings.localdir);
82 111
96 125
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 126 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 127 _exit (1);
99 } 128 }
100 129
101 UUID::BUF buf; 130 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 131 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 132 fgets (buf, sizeof (buf), fp);
104 133
105 if (!UUID::cur.parse (buf)) 134 if (!UUID::cur.parse (buf))
106 { 135 {
133 162
134void 163void
135UUID::init () 164UUID::init ()
136{ 165{
137 read_uuid (); 166 read_uuid ();
167}
168
169bool
170UUID::parse (const char *s)
171{
172 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
173 return false;
174
175 seq = 0;
176
177 while (*s != '>')
178 {
179 if (*s < '0')
180 return false;
181
182 // this gives nice branchless code with gcc
183 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
184 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
185
186 seq = (seq << 4) | digit;
187
188 ++s;
189 }
190
191 return true;
192}
193
194char *
195UUID::append (char *buf) const
196{
197 *buf++ = '<';
198 *buf++ = '1';
199 *buf++ = '.';
200
201 uint64_t seq = this->seq;
202 const int bits = 64;
203 char nz = 0;
204 static const char tohex [] = "0123456789abcdef";
205
206 // assert (len >= 3 + bits / 4 + 1 + 1);
207 for (int i = bits / 4; --i; )
208 {
209 uint8_t digit = seq >> (bits - 4);
210
211 *buf = tohex [digit];
212 nz |= digit;
213 buf += nz ? 1 : 0;
214 seq <<= 4;
215 }
216
217 // last digit is special - always emit
218 uint8_t digit = seq >> (bits - 4);
219 *buf++ = tohex [digit];
220
221 *buf++ = '>';
222
223 return buf;
224}
225
226char *
227UUID::c_str () const
228{
229 static char buf [MAX_LEN];
230 *append (buf) = 0;
231 return buf;
138} 232}
139 233
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 234/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 235static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 236compare_ob_value_lists_one (const object *wants, const object *has)
143{ 237{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 238 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 239 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 240 * different structure or at least keep the lists sorted...
149 */ 241 */
150 242
151 /* For each field in wants, */ 243 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 244 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 245 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 246 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 247
169 /* If we get here, every field in wants has a matching field in has. */ 248 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 249 return true;
171} 250}
172 251
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 252/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 253static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 254compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 255{
177 /* However, there may be fields in has which aren't partnered in wants, 256 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 257 * so we need to run the comparison *twice*. :(
179 */ 258 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 259 return compare_ob_value_lists_one (ob1, ob2)
260 && compare_ob_value_lists_one (ob2, ob1);
181} 261}
182 262
183/* Function examines the 2 objects given to it, and returns true if 263/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 264 * they can be merged together.
185 * 265 *
192 * Improvements made with merge: Better checking on potion, and also 272 * Improvements made with merge: Better checking on potion, and also
193 * check weight 273 * check weight
194 */ 274 */
195bool object::can_merge_slow (object *ob1, object *ob2) 275bool object::can_merge_slow (object *ob1, object *ob2)
196{ 276{
197 /* A couple quicksanity checks */ 277 /* A couple quick sanity checks */
198 if (ob1 == ob2 278 if (ob1 == ob2
199 || ob1->type != ob2->type 279 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 280 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 281 || ob1->name != ob2->name
282 || ob1->custom_name != ob2->custom_name
283 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
203 return 0; 284 return 0;
204 285
205 /* Do not merge objects if nrof would overflow. First part checks 286 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 287 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 288 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 289 return 0;
212 290
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 291 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 292 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 293 * just can't ignore the been applied or identified flags, as they
216 * are not equal - just if it has been identified, the been_applied 294 * are not equal - just if it has been identified, the been_applied
217 * flags lose any meaning. 295 * flags lose any meaning.
218 */ 296 */
219 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 297 if (ob1->flag [FLAG_IDENTIFIED])
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 298 ob1->set_flag (FLAG_BEEN_APPLIED);
221 299
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 300 if (ob2->flag [FLAG_IDENTIFIED])
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 301 ob2->set_flag (FLAG_BEEN_APPLIED);
224 302
225 if (ob1->arch->name != ob2->arch->name 303 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 304 || ob1->name != ob2->name
227 || ob1->title != ob2->title 305 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 306 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 307 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 308 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 309 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 310 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 311 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 312 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 313 || ob1->animation_id != ob2->animation_id
314 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
236 || ob1->client_type != ob2->client_type 315 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 316 || ob1->material != ob2->material
238 || ob1->lore != ob2->lore 317 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 318 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 319 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 320 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 321 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 322 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 323 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 324 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 325 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 326 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 327 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 328 return 0;
250 329
251 if ((ob1->flag ^ ob2->flag) 330 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 331 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 332 .reset (FLAG_REMOVED)
255 .any ()) 333 .any ())
256 return 0; 334 return 0;
257 335
258 /* This is really a spellbook check - we should in general 336 /* This is really a spellbook check - we should in general
277 355
278 /* Don't merge objects that are applied. With the new 'body' code, 356 /* Don't merge objects that are applied. With the new 'body' code,
279 * it is possible for most any character to have more than one of 357 * it is possible for most any character to have more than one of
280 * some items equipped, and we don't want those to merge. 358 * some items equipped, and we don't want those to merge.
281 */ 359 */
282 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 360 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
283 return 0; 361 return 0;
284 362
285 /* Note sure why the following is the case - either the object has to 363 /* Note sure why the following is the case - either the object has to
286 * be animated or have a very low speed. Is this an attempted monster 364 * be animated or have a very low speed. Is this an attempted monster
287 * check? 365 * check?
288 */ 366 */
289 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 367 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
290 return 0; 368 return 0;
291 369
292 switch (ob1->type) 370 switch (ob1->type)
293 { 371 {
294 case SCROLL: 372 case SCROLL:
340 { 418 {
341 // see if we are in a container of sorts 419 // see if we are in a container of sorts
342 if (env) 420 if (env)
343 { 421 {
344 // the player inventory itself is always visible 422 // the player inventory itself is always visible
345 if (env->type == PLAYER) 423 if (env->is_player ())
346 return env; 424 return env;
347 425
348 // else a player could have our env open 426 // else a player could have our env open
349 object *envest = env->outer_env (); 427 object *envest = env->outer_env_or_self ();
350 428
351 // the player itself is always on a map, so we will find him here 429 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 430 // even if our inv is in a player.
353 if (envest->is_on_map ()) 431 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 432 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 433 if (pl->container_ () == env)
356 return pl; 434 return pl;
357 } 435 }
358 else 436 else
359 { 437 {
360 // maybe there is a player standing on the same mapspace 438 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 439 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 440 if (object *pl = ms ().player ())
363 if (!pl->container || this == pl->container) 441 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
442 || pl->container_ () == this)
364 return pl; 443 return pl;
365 } 444 }
366 } 445 }
367 446
368 return 0; 447 return 0;
369} 448}
370 449
371// adjust weight per container type ("of holding") 450// adjust weight per container type ("of holding")
372static sint32 451static uint32
373weight_adjust (object *op, sint32 weight) 452weight_adjust_for (object *op, uint32 weight)
374{ 453{
375 return op->type == CONTAINER 454 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 455 ? weight - weight * op->stats.Str / 100
377 : weight; 456 : weight;
378} 457}
379 458
380/* 459/*
381 * adjust_weight(object, weight) adds the specified weight to an object, 460 * subtracts, then adds, the specified weight to an object,
382 * and also updates how much the environment(s) is/are carrying. 461 * and also updates how much the environment(s) is/are carrying.
383 */ 462 */
384static void 463static void
385adjust_weight (object *op, sint32 weight) 464adjust_weight (object *op, sint32 sub, sint32 add)
386{ 465{
387 while (op) 466 while (op)
388 { 467 {
389 weight = weight_adjust (op, weight); 468 sint32 ocarrying = op->carrying;
390 469
391 if (!weight) 470 op->carrying -= weight_adjust_for (op, sub);
392 return; 471 op->carrying += weight_adjust_for (op, add);
393
394 op->carrying += weight;
395 472
396 if (object *pl = op->visible_to ()) 473 if (object *pl = op->visible_to ())
397 if (pl != op) // player is handled lazily 474 if (pl != op) // player is handled lazily
398 esrv_update_item (UPD_WEIGHT, pl, op); 475 esrv_update_item (UPD_WEIGHT, pl, op);
399 476
477 sub = ocarrying;
478 add = op->carrying;
479
400 op = op->env; 480 op = op->env;
401 } 481 }
402} 482}
403 483
404/* 484/*
411{ 491{
412 sint32 sum = 0; 492 sint32 sum = 0;
413 493
414 for (object *op = inv; op; op = op->below) 494 for (object *op = inv; op; op = op->below)
415 { 495 {
416 if (op->inv)
417 op->update_weight (); 496 op->update_weight ();
418 497
419 sum += op->total_weight (); 498 sum += weight_adjust_for (this, op->total_weight ());
420 } 499 }
421
422 sum = weight_adjust (this, sum);
423 500
424 if (sum != carrying) 501 if (sum != carrying)
425 { 502 {
503 if (carrying != sum && carrying)//D
504 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
505 (long long)sum, (long long)carrying, debug_desc ());
506
426 carrying = sum; 507 carrying = sum;
427 508
428 if (object *pl = visible_to ()) 509 if (object *pl = visible_to ())
429 if (pl != this) // player is handled lazily 510 if (pl != this) // player is handled lazily
430 esrv_update_item (UPD_WEIGHT, pl, this); 511 esrv_update_item (UPD_WEIGHT, pl, this);
443 object_freezer freezer; 524 object_freezer freezer;
444 op->write (freezer); 525 op->write (freezer);
445 return freezer.as_string (); 526 return freezer.as_string ();
446} 527}
447 528
448/* 529char *
449 * get_nearest_part(multi-object, object 2) returns the part of the 530object::as_string ()
450 * multi-object 1 which is closest to the second object.
451 * If it's not a multi-object, it is returned.
452 */
453object *
454get_nearest_part (object *op, const object *pl)
455{ 531{
456 object *tmp, *closest; 532 return dump_object (this);
457 int last_dist, i;
458
459 if (!op->more)
460 return op;
461
462 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
463 tmp;
464 tmp = tmp->more)
465 if ((i = distance (tmp, pl)) < last_dist)
466 closest = tmp, last_dist = i;
467
468 return closest;
469} 533}
470 534
471/* 535/*
472 * Returns the object which has the count-variable equal to the argument. 536 * Returns the object which has the count-variable equal to the argument.
473 * VERRRY slow. 537 * VERRRY slow.
481 545
482 return 0; 546 return 0;
483} 547}
484 548
485/* 549/*
550 * Returns the object which has the uuid equal to the argument.
551 * MOAR VERRRY slow.
552 */
553
554object *
555find_object_uuid (UUID i)
556{
557 for_all_objects (op)
558 if (op->uuid == i)
559 return op;
560
561 return 0;
562}
563
564/*
486 * Returns the first object which has a name equal to the argument. 565 * Returns the first object which has a name equal to the argument.
487 * Used only by the patch command, but not all that useful. 566 * Used only by the patch command, but not all that useful.
488 * Enables features like "patch <name-of-other-player> food 999" 567 * Enables features like "patch <name-of-other-player> food 999"
489 */ 568 */
490object * 569object *
491find_object_name (const char *str) 570find_object_name (const char *str)
492{ 571{
493 shstr_cmp str_ (str); 572 shstr_cmp str_ (str);
494 object *op;
495 573
574 if (str_)
496 for_all_objects (op) 575 for_all_objects (op)
497 if (op->name == str_) 576 if (op->name == str_)
498 break; 577 return op;
499 578
500 return op; 579 return 0;
501} 580}
502 581
503/* 582/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 583 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 584 * skill and experience objects.
520 } 599 }
521 600
522 this->owner = owner; 601 this->owner = owner;
523} 602}
524 603
525int
526object::slottype () const
527{
528 if (type == SKILL)
529 {
530 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
531 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
532 }
533 else
534 {
535 if (slot [body_combat].info) return slot_combat;
536 if (slot [body_range ].info) return slot_ranged;
537 }
538
539 return slot_none;
540}
541
542bool
543object::change_weapon (object *ob)
544{
545 if (current_weapon == ob)
546 return true;
547
548 if (chosen_skill)
549 chosen_skill->flag [FLAG_APPLIED] = false;
550
551 current_weapon = ob;
552 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
553
554 if (chosen_skill)
555 chosen_skill->flag [FLAG_APPLIED] = true;
556
557 update_stats ();
558
559 if (ob)
560 {
561 // now check wether any body locations became invalid, in which case
562 // we cannot apply the weapon at the moment.
563 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
564 if (slot[i].used < 0)
565 {
566 current_weapon = chosen_skill = 0;
567 update_stats ();
568
569 new_draw_info_format (NDI_UNIQUE, 0, this,
570 "You try to balance all your items at once, "
571 "but the %s is just too much for your body. "
572 "[You need to unapply some items first.]", &ob->name);
573 return false;
574 }
575
576 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577 }
578 else
579 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
580
581 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
582 {
583 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
584 &name, ob->debug_desc ());
585 return false;
586 }
587
588 return true;
589}
590
591/* Zero the key_values on op, decrementing the shared-string 604/* Zero the key_values on op, decrementing the shared-string
592 * refcounts and freeing the links. 605 * refcounts and freeing the links.
593 */ 606 */
594static void 607static void
595free_key_values (object *op) 608free_key_values (object *op)
603 } 616 }
604 617
605 op->key_values = 0; 618 op->key_values = 0;
606} 619}
607 620
608object & 621/*
609object::operator =(const object &src) 622 * copy_to first frees everything allocated by the dst object,
623 * and then copies the contents of itself into the second
624 * object, allocating what needs to be allocated. Basically, any
625 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
626 * if the first object is freed, the pointers in the new object
627 * will point at garbage.
628 */
629void
630object::copy_to (object *dst)
610{ 631{
611 bool is_freed = flag [FLAG_FREED]; 632 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 633 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 634 dst->flag [FLAG_REMOVED] = true;
618 635
619 /* Copy over key_values, if any. */ 636 /* Copy over key_values, if any. */
620 if (src.key_values) 637 if (key_values)
621 { 638 {
622 key_value *tail = 0; 639 key_value *tail = 0;
623 key_values = 0; 640 dst->key_values = 0;
624 641
625 for (key_value *i = src.key_values; i; i = i->next) 642 for (key_value *i = key_values; i; i = i->next)
626 { 643 {
627 key_value *new_link = new key_value; 644 key_value *new_link = new key_value;
628 645
629 new_link->next = 0; 646 new_link->next = 0;
630 new_link->key = i->key; 647 new_link->key = i->key;
631 new_link->value = i->value; 648 new_link->value = i->value;
632 649
633 /* Try and be clever here, too. */ 650 /* Try and be clever here, too. */
634 if (!key_values) 651 if (!dst->key_values)
635 { 652 {
636 key_values = new_link; 653 dst->key_values = new_link;
637 tail = new_link; 654 tail = new_link;
638 } 655 }
639 else 656 else
640 { 657 {
641 tail->next = new_link; 658 tail->next = new_link;
642 tail = new_link; 659 tail = new_link;
643 } 660 }
644 } 661 }
645 } 662 }
646}
647 663
648/* 664 dst->activate ();
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660
661 if (speed < 0)
662 dst->speed_left -= rndm ();
663
664 dst->set_speed (dst->speed);
665} 665}
666 666
667void 667void
668object::instantiate () 668object::instantiate ()
669{ 669{
670 if (!uuid.seq) // HACK 670 if (!uuid.seq) // HACK
671 uuid = UUID::gen (); 671 uuid = UUID::gen ();
672 672
673 // TODO: unclean state changes, should not be done in copy_to AND instantiate
674 if (flag [FLAG_RANDOM_SPEED] && speed)
675 speed_left = - speed - rndm (); // TODO animation
676 else
673 speed_left = -0.1f; 677 speed_left = -1.;
678
674 /* copy the body_info to the body_used - this is only really 679 /* copy the body_info to the body_used - this is only really
675 * need for monsters, but doesn't hurt to do it for everything. 680 * need for monsters, but doesn't hurt to do it for everything.
676 * by doing so, when a monster is created, it has good starting 681 * by doing so, when a monster is created, it has good starting
677 * values for the body_used info, so when items are created 682 * values for the body_used info, so when items are created
678 * for it, they can be properly equipped. 683 * for it, they can be properly equipped.
686object * 691object *
687object::clone () 692object::clone ()
688{ 693{
689 object *neu = create (); 694 object *neu = create ();
690 copy_to (neu); 695 copy_to (neu);
696
697 // TODO: unclean state changes, should not be done in clone AND instantiate
698 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
699 neu->speed_left = - neu->speed - rndm (); // TODO animation
700
701 neu->map = map; // not copied by copy_to
691 return neu; 702 return neu;
692} 703}
693 704
694/* 705/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 706 * If an object with the IS_TURNABLE() flag needs to be turned due
697 * be called to update the face variable, _and_ how it looks on the map. 708 * be called to update the face variable, _and_ how it looks on the map.
698 */ 709 */
699void 710void
700update_turn_face (object *op) 711update_turn_face (object *op)
701{ 712{
702 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 713 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
703 return; 714 return;
704 715
705 SET_ANIMATION (op, op->direction); 716 SET_ANIMATION (op, op->direction);
706 update_object (op, UP_OBJ_FACE); 717 update_object (op, UP_OBJ_FACE);
707} 718}
712 * This function needs to be called whenever the speed of an object changes. 723 * This function needs to be called whenever the speed of an object changes.
713 */ 724 */
714void 725void
715object::set_speed (float speed) 726object::set_speed (float speed)
716{ 727{
717 if (flag [FLAG_FREED] && speed)
718 {
719 LOG (llevError, "Object %s is freed but has speed.\n", &name);
720 speed = 0;
721 }
722
723 this->speed = speed; 728 this->speed = speed;
724 729
725 if (has_active_speed ()) 730 if (has_active_speed ())
726 activate (); 731 activate ();
727 else 732 else
746 * UP_OBJ_FACE: only the objects face has changed. 751 * UP_OBJ_FACE: only the objects face has changed.
747 */ 752 */
748void 753void
749update_object (object *op, int action) 754update_object (object *op, int action)
750{ 755{
751 if (op == NULL) 756 if (!op)
752 { 757 {
753 /* this should never happen */ 758 /* this should never happen */
754 LOG (llevDebug, "update_object() called for NULL object.\n"); 759 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
755 return; 760 return;
756 } 761 }
757 762
758 if (op->env) 763 if (!op->is_on_map ())
759 { 764 {
760 /* Animation is currently handled by client, so nothing 765 /* Animation is currently handled by client, so nothing
761 * to do in this case. 766 * to do in this case.
762 */ 767 */
763 return; 768 return;
764 } 769 }
765
766 /* If the map is saving, don't do anything as everything is
767 * going to get freed anyways.
768 */
769 if (!op->map || op->map->in_memory == MAP_SAVING)
770 return;
771 770
772 /* make sure the object is within map boundaries */ 771 /* make sure the object is within map boundaries */
773 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 772 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
774 { 773 {
775 LOG (llevError, "update_object() called for object out of map!\n"); 774 LOG (llevError, "update_object() called for object out of map!\n");
783 782
784 if (!(m.flags_ & P_UPTODATE)) 783 if (!(m.flags_ & P_UPTODATE))
785 /* nop */; 784 /* nop */;
786 else if (action == UP_OBJ_INSERT) 785 else if (action == UP_OBJ_INSERT)
787 { 786 {
787#if 0
788 // this is likely overkill, TODO: revisit (schmorp) 788 // this is likely overkill, TODO: revisit (schmorp)
789 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 789 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
790 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 790 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
791 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 791 || (op->is_player () && !(m.flags_ & P_PLAYER))
792 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 792 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
793 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 793 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
794 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 794 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
795 || (m.move_on | op->move_on ) != m.move_on 795 || (m.move_on | op->move_on ) != m.move_on
796 || (m.move_off | op->move_off ) != m.move_off 796 || (m.move_off | op->move_off ) != m.move_off
797 || (m.move_slow | op->move_slow) != m.move_slow 797 || (m.move_slow | op->move_slow) != m.move_slow
798 /* This isn't perfect, but I don't expect a lot of objects to 798 /* This isn't perfect, but I don't expect a lot of objects to
799 * to have move_allow right now. 799 * have move_allow right now.
800 */ 800 */
801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
802 m.invalidate ();
803#else
802 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 804 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
803 m.flags_ = 0; 805 m.invalidate ();
806#endif
804 } 807 }
805 /* if the object is being removed, we can't make intelligent 808 /* if the object is being removed, we can't make intelligent
806 * decisions, because remove_ob can't really pass the object 809 * decisions, because remove_ob can't really pass the object
807 * that is being removed. 810 * that is being removed.
808 */ 811 */
809 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 812 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
810 m.flags_ = 0; 813 m.invalidate ();
811 else if (action == UP_OBJ_FACE) 814 else if (action == UP_OBJ_FACE)
812 /* Nothing to do for that case */ ; 815 /* Nothing to do for that case */ ;
813 else 816 else
814 LOG (llevError, "update_object called with invalid action: %d\n", action); 817 LOG (llevError, "update_object called with invalid action: %d\n", action);
815 818
817 update_object (op->more, action); 820 update_object (op->more, action);
818} 821}
819 822
820object::object () 823object::object ()
821{ 824{
822 SET_FLAG (this, FLAG_REMOVED); 825 this->set_flag (FLAG_REMOVED);
823 826
824 expmul = 1.0; 827 //expmul = 1.0; declared const for the time being
825 face = blank_face; 828 face = blank_face;
829 material = MATERIAL_NULL;
826} 830}
827 831
828object::~object () 832object::~object ()
829{ 833{
830 unlink (); 834 unlink ();
831 835
832 free_key_values (this); 836 free_key_values (this);
833} 837}
834
835static int object_count;
836 838
837void object::link () 839void object::link ()
838{ 840{
839 assert (!index);//D 841 assert (!index);//D
840 uuid = UUID::gen (); 842 uuid = UUID::gen ();
841 count = ++object_count;
842 843
843 refcnt_inc (); 844 refcnt_inc ();
844 objects.insert (this); 845 objects.insert (this);
846
847 ++create_count;
848
845} 849}
846 850
847void object::unlink () 851void object::unlink ()
848{ 852{
849 if (!index) 853 if (!index)
850 return; 854 return;
855
856 ++destroy_count;
851 857
852 objects.erase (this); 858 objects.erase (this);
853 refcnt_dec (); 859 refcnt_dec ();
854} 860}
855 861
859 /* If already on active list, don't do anything */ 865 /* If already on active list, don't do anything */
860 if (active) 866 if (active)
861 return; 867 return;
862 868
863 if (has_active_speed ()) 869 if (has_active_speed ())
870 {
871 if (flag [FLAG_FREED])
872 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
873
864 actives.insert (this); 874 actives.insert (this);
875 }
865} 876}
866 877
867void 878void
868object::activate_recursive () 879object::activate_recursive ()
869{ 880{
930 * drop on that space. 941 * drop on that space.
931 */ 942 */
932 if (!drop_to_ground 943 if (!drop_to_ground
933 || !map 944 || !map
934 || map->in_memory != MAP_ACTIVE 945 || map->in_memory != MAP_ACTIVE
935 || map->nodrop 946 || map->no_drop
936 || ms ().move_block == MOVE_ALL) 947 || ms ().move_block == MOVE_ALL)
937 { 948 {
938 while (inv) 949 while (inv)
939 {
940 inv->destroy_inv (false);
941 inv->destroy (); 950 inv->destroy ();
942 }
943 } 951 }
944 else 952 else
945 { /* Put objects in inventory onto this space */ 953 { /* Put objects in inventory onto this space */
946 while (inv) 954 while (inv)
947 { 955 {
951 || op->flag [FLAG_NO_DROP] 959 || op->flag [FLAG_NO_DROP]
952 || op->type == RUNE 960 || op->type == RUNE
953 || op->type == TRAP 961 || op->type == TRAP
954 || op->flag [FLAG_IS_A_TEMPLATE] 962 || op->flag [FLAG_IS_A_TEMPLATE]
955 || op->flag [FLAG_DESTROY_ON_DEATH]) 963 || op->flag [FLAG_DESTROY_ON_DEATH])
956 op->destroy (true); 964 op->destroy ();
957 else 965 else
958 map->insert (op, x, y); 966 map->insert (op, x, y);
959 } 967 }
960 } 968 }
961} 969}
962 970
971/*
972 * Remove and free all objects in the inventory of the given object.
973 * Unlike destroy_inv, this assumes the *this is destroyed as well
974 * well, so we can (and have to!) take shortcuts.
975 */
976void
977object::destroy_inv_fast ()
978{
979 while (object *op = inv)
980 {
981 // remove from object the fast way
982 op->flag [FLAG_REMOVED] = true;
983 op->env = 0;
984 if ((inv = inv->below))
985 inv->above = 0;
986
987 // then destroy
988 op->destroy ();
989 }
990}
991
992void
993object::freelist_free (int count)
994{
995 while (count-- && freelist)
996 {
997 freelist_item *next = freelist->next;
998 // count is being "destroyed"
999
1000 sfree ((char *)freelist, sizeof (object));
1001
1002 freelist = next;
1003 --free_count;
1004 }
1005}
1006
1007object *
963object *object::create () 1008object::create ()
964{ 1009{
965 object *op = new object; 1010 object *op;
1011
1012 if (freelist)
1013 {
1014 freelist_item li = *freelist;
1015 memset (freelist, 0, sizeof (object));
1016
1017 op = new (freelist) object;
1018 op->count = li.count;
1019
1020 freelist = li.next;
1021 --free_count;
1022 }
1023 else
1024 {
1025 void *ni = salloc0<char> (sizeof (object));
1026
1027 op = new(ni) object;
1028
1029 op->count = ++object_count;
1030 }
1031
966 op->link (); 1032 op->link ();
1033
967 return op; 1034 return op;
968} 1035}
969 1036
970void 1037void
1038object::do_delete ()
1039{
1040 uint32_t count = this->count;
1041
1042 this->~object ();
1043
1044 freelist_item *li = (freelist_item *)this;
1045 li->next = freelist;
1046 li->count = count;
1047
1048 freelist = li;
1049 ++free_count;
1050}
1051
1052static struct freed_map : maptile
1053{
1054 freed_map ()
1055 : maptile (3, 3)
1056 {
1057 path = "<freed objects map>";
1058 name = "/internal/freed_objects_map";
1059 no_drop = 1;
1060 no_reset = 1;
1061
1062 in_memory = MAP_ACTIVE;
1063 }
1064
1065 ~freed_map ()
1066 {
1067 destroy ();
1068 }
1069} freed_map; // freed objects are moved here to avoid crashes
1070
1071void
971object::do_destroy () 1072object::do_destroy ()
972{ 1073{
973 if (flag [FLAG_IS_LINKED]) 1074 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 1075 remove_link ();
975 1076
976 if (flag [FLAG_FRIENDLY]) 1077 if (flag [FLAG_FRIENDLY])
977 remove_friendly_object (this); 1078 remove_friendly_object (this);
978 1079
979 remove (); 1080 remove ();
984 unlink (); 1085 unlink ();
985 1086
986 flag [FLAG_FREED] = 1; 1087 flag [FLAG_FREED] = 1;
987 1088
988 // hack to ensure that freed objects still have a valid map 1089 // hack to ensure that freed objects still have a valid map
989 {
990 static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992 if (!freed_map)
993 {
994 freed_map = new maptile;
995
996 freed_map->path = "<freed objects map>";
997 freed_map->name = "/internal/freed_objects_map";
998 freed_map->width = 3;
999 freed_map->height = 3;
1000 freed_map->nodrop = 1;
1001
1002 freed_map->alloc ();
1003 freed_map->in_memory = MAP_ACTIVE;
1004 }
1005
1006 map = freed_map; 1090 map = &freed_map;
1007 x = 1; 1091 x = 1;
1008 y = 1; 1092 y = 1;
1009 }
1010 1093
1011 if (more) 1094 if (more)
1012 { 1095 {
1013 more->destroy (); 1096 more->destroy ();
1014 more = 0; 1097 more = 0;
1022 attacked_by = 0; 1105 attacked_by = 0;
1023 current_weapon = 0; 1106 current_weapon = 0;
1024} 1107}
1025 1108
1026void 1109void
1027object::destroy (bool destroy_inventory) 1110object::destroy ()
1028{ 1111{
1029 if (destroyed ()) 1112 if (destroyed ())
1030 return; 1113 return;
1031 1114
1032 if (!is_head () && !head->destroyed ()) 1115 if (!is_head () && !head->destroyed ())
1033 { 1116 {
1034 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1117 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1035 head->destroy (destroy_inventory); 1118 head->destroy ();
1119 return;
1036 } 1120 }
1037 1121
1038 destroy_inv (!destroy_inventory); 1122 destroy_inv_fast ();
1039 1123
1040 if (is_head ()) 1124 if (is_head ())
1041 if (sound_destroy) 1125 if (sound_destroy)
1042 play_sound (sound_destroy); 1126 play_sound (sound_destroy);
1043 else if (flag [FLAG_MONSTER]) 1127 else if (flag [FLAG_MONSTER])
1054 * the previous environment. 1138 * the previous environment.
1055 */ 1139 */
1056void 1140void
1057object::do_remove () 1141object::do_remove ()
1058{ 1142{
1059 object *tmp, *last = 0;
1060 object *otmp;
1061
1062 if (flag [FLAG_REMOVED]) 1143 if (flag [FLAG_REMOVED])
1063 return; 1144 return;
1064 1145
1065 INVOKE_OBJECT (REMOVE, this); 1146 INVOKE_OBJECT (REMOVE, this);
1066 1147
1078 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed 1159 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1079 if (object *pl = visible_to ()) 1160 if (object *pl = visible_to ())
1080 esrv_del_item (pl->contr, count); 1161 esrv_del_item (pl->contr, count);
1081 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1162 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1082 1163
1083 adjust_weight (env, -total_weight ()); 1164 adjust_weight (env, total_weight (), 0);
1084 1165
1085 *(above ? &above->below : &env->inv) = below; 1166 object *pl = in_player ();
1086
1087 if (below)
1088 below->above = above;
1089 1167
1090 /* we set up values so that it could be inserted into 1168 /* we set up values so that it could be inserted into
1091 * the map, but we don't actually do that - it is up 1169 * the map, but we don't actually do that - it is up
1092 * to the caller to decide what we want to do. 1170 * to the caller to decide what we want to do.
1093 */ 1171 */
1094 map = env->map; 1172 map = env->map;
1095 x = env->x; 1173 x = env->x;
1096 y = env->y; 1174 y = env->y;
1175
1176 // make sure cmov optimisation is applicable
1177 *(above ? &above->below : &env->inv) = below;
1178 *(below ? &below->above : &above ) = above; // &above is just a dummy
1179
1097 above = 0; 1180 above = 0;
1098 below = 0; 1181 below = 0;
1099 env = 0; 1182 env = 0;
1100 1183
1101 /* NO_FIX_PLAYER is set when a great many changes are being 1184 if (pl && pl->is_player ())
1102 * made to players inventory. If set, avoiding the call
1103 * to save cpu time.
1104 */ 1185 {
1105 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1186 if (expect_false (pl->contr->combat_ob == this))
1106 otmp->update_stats (); 1187 {
1188 pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1189 pl->contr->combat_ob = 0;
1190 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1191 }
1192
1193 if (expect_false (pl->contr->ranged_ob == this))
1194 {
1195 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1196 pl->contr->ranged_ob = 0;
1197 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1198 }
1199
1200 pl->contr->queue_stats_update ();
1201
1202 if (expect_false (glow_radius) && pl->is_on_map ())
1203 update_all_los (pl->map, pl->x, pl->y);
1204 }
1107 } 1205 }
1108 else if (map) 1206 else if (map)
1109 { 1207 {
1110 map->dirty = true; 1208 map->dirty = true;
1111 mapspace &ms = this->ms (); 1209 mapspace &ms = this->ms ();
1112 1210
1113 if (object *pl = ms.player ()) 1211 if (object *pl = ms.player ())
1114 { 1212 {
1115 if (type == PLAYER) // this == pl(!) 1213 if (is_player ())
1116 { 1214 {
1215 if (!flag [FLAG_WIZPASS])
1216 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1217
1117 // leaving a spot always closes any open container on the ground 1218 // leaving a spot always closes any open container on the ground
1118 if (container && !container->env) 1219 if (container && !container->env)
1119 // this causes spurious floorbox updates, but it ensures 1220 // this causes spurious floorbox updates, but it ensures
1120 // that the CLOSE event is being sent. 1221 // that the CLOSE event is being sent.
1121 close_container (); 1222 close_container ();
1122 1223
1123 --map->players; 1224 --map->players;
1124 map->touch (); 1225 map->touch ();
1125 } 1226 }
1126 else if (pl->container == this) 1227 else if (pl->container_ () == this)
1127 { 1228 {
1128 // removing a container should close it 1229 // removing a container should close it
1129 close_container (); 1230 close_container ();
1130 } 1231 }
1131 1232 else
1132 esrv_del_item (pl->contr, count); 1233 esrv_del_item (pl->contr, count);
1133 } 1234 }
1134 1235
1135 /* link the object above us */ 1236 /* link the object above us */
1136 if (above) 1237 // re-link, make sure compiler can easily use cmove
1137 above->below = below; 1238 *(above ? &above->below : &ms.top) = below;
1138 else 1239 *(below ? &below->above : &ms.bot) = above;
1139 ms.top = below; /* we were top, set new top */
1140
1141 /* Relink the object below us, if there is one */
1142 if (below)
1143 below->above = above;
1144 else
1145 {
1146 /* Nothing below, which means we need to relink map object for this space
1147 * use translated coordinates in case some oddness with map tiling is
1148 * evident
1149 */
1150 if (GET_MAP_OB (map, x, y) != this)
1151 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1152
1153 ms.bot = above; /* goes on above it. */
1154 }
1155 1240
1156 above = 0; 1241 above = 0;
1157 below = 0; 1242 below = 0;
1158 1243
1244 ms.invalidate ();
1245
1159 if (map->in_memory == MAP_SAVING) 1246 if (map->in_memory == MAP_SAVING)
1160 return; 1247 return;
1161 1248
1162 int check_walk_off = !flag [FLAG_NO_APPLY]; 1249 int check_walk_off = !flag [FLAG_NO_APPLY];
1163 1250
1164 if (object *pl = ms.player ()) 1251 if (object *pl = ms.player ())
1165 { 1252 {
1166 if (pl->container == this) 1253 if (pl->container_ () == this)
1167 /* If a container that the player is currently using somehow gets 1254 /* If a container that the player is currently using somehow gets
1168 * removed (most likely destroyed), update the player view 1255 * removed (most likely destroyed), update the player view
1169 * appropriately. 1256 * appropriately.
1170 */ 1257 */
1171 pl->close_container (); 1258 pl->close_container ();
1172 1259
1173 //TODO: the floorbox prev/next might need updating 1260 //TODO: the floorbox prev/next might need updating
1174 esrv_del_item (pl->contr, count); 1261 //esrv_del_item (pl->contr, count);
1262 //TODO: update floorbox to preserve ordering
1263 if (pl->contr->ns)
1264 pl->contr->ns->floorbox_update ();
1175 } 1265 }
1176 1266
1267 if (check_walk_off)
1177 for (tmp = ms.bot; tmp; tmp = tmp->above) 1268 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1178 { 1269 {
1270 above = tmp->above;
1271
1179 /* No point updating the players look faces if he is the object 1272 /* No point updating the players look faces if he is the object
1180 * being removed. 1273 * being removed.
1181 */ 1274 */
1182 1275
1183 /* See if object moving off should effect something */ 1276 /* See if object moving off should effect something */
1184 if (check_walk_off
1185 && ((move_type & tmp->move_off) 1277 if ((move_type & tmp->move_off)
1186 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1278 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1187 {
1188 move_apply (tmp, this, 0); 1279 move_apply (tmp, this, 0);
1189
1190 if (destroyed ())
1191 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1192 } 1280 }
1193 1281
1194 last = tmp; 1282 if (affects_los ())
1195 }
1196
1197 /* last == NULL if there are no objects on this space */
1198 //TODO: this makes little sense, why only update the topmost object?
1199 if (!last)
1200 map->at (x, y).flags_ = 0;
1201 else
1202 update_object (last, UP_OBJ_REMOVE);
1203
1204 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1205 update_all_los (map, x, y); 1283 update_all_los (map, x, y);
1206 } 1284 }
1207} 1285}
1208 1286
1209/* 1287/*
1233 esrv_update_item (UPD_NROF, pl, top); 1311 esrv_update_item (UPD_NROF, pl, top);
1234 1312
1235 op->weight = 0; // cancel the addition above 1313 op->weight = 0; // cancel the addition above
1236 op->carrying = 0; // must be 0 already 1314 op->carrying = 0; // must be 0 already
1237 1315
1238 op->destroy (1); 1316 op->destroy ();
1239 1317
1240 return top; 1318 return top;
1241 } 1319 }
1242 1320
1243 return 0; 1321 return 0;
1251 1329
1252 object *prev = this; 1330 object *prev = this;
1253 1331
1254 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1332 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1255 { 1333 {
1256 object *op = arch_to_object (at); 1334 object *op = at->instance ();
1257 1335
1258 op->name = name; 1336 op->name = name;
1259 op->name_pl = name_pl; 1337 op->name_pl = name_pl;
1260 op->title = title; 1338 op->title = title;
1261 1339
1271 * job preparing multi-part monsters. 1349 * job preparing multi-part monsters.
1272 */ 1350 */
1273object * 1351object *
1274insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1352insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1275{ 1353{
1354 op->remove ();
1355
1276 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1356 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1277 { 1357 {
1278 tmp->x = x + tmp->arch->x; 1358 tmp->x = x + tmp->arch->x;
1279 tmp->y = y + tmp->arch->y; 1359 tmp->y = y + tmp->arch->y;
1280 } 1360 }
1297 * Passing 0 for flag gives proper default values, so flag really only needs 1377 * Passing 0 for flag gives proper default values, so flag really only needs
1298 * to be set if special handling is needed. 1378 * to be set if special handling is needed.
1299 * 1379 *
1300 * Return value: 1380 * Return value:
1301 * new object if 'op' was merged with other object 1381 * new object if 'op' was merged with other object
1302 * NULL if 'op' was destroyed 1382 * NULL if there was an error (destroyed, blocked etc.)
1303 * just 'op' otherwise 1383 * just 'op' otherwise
1304 */ 1384 */
1305object * 1385object *
1306insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1386insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1307{ 1387{
1308 assert (!op->flag [FLAG_FREED]);
1309
1310 op->remove (); 1388 op->remove ();
1389
1390 if (m == &freed_map)//D TODO: remove soon
1391 {//D
1392 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1393 }//D
1311 1394
1312 /* Ideally, the caller figures this out. However, it complicates a lot 1395 /* Ideally, the caller figures this out. However, it complicates a lot
1313 * of areas of callers (eg, anything that uses find_free_spot would now 1396 * of areas of callers (eg, anything that uses find_free_spot would now
1314 * need extra work 1397 * need extra work
1315 */ 1398 */
1399 maptile *newmap = m;
1316 if (!xy_normalise (m, op->x, op->y)) 1400 if (!xy_normalise (newmap, op->x, op->y))
1317 { 1401 {
1318 op->destroy (1); 1402 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1319 return 0; 1403 return 0;
1320 } 1404 }
1321 1405
1322 if (object *more = op->more) 1406 if (object *more = op->more)
1323 if (!insert_ob_in_map (more, m, originator, flag)) 1407 if (!insert_ob_in_map (more, m, originator, flag))
1324 return 0; 1408 return 0;
1325 1409
1326 CLEAR_FLAG (op, FLAG_REMOVED); 1410 op->flag [FLAG_REMOVED] = false;
1327 1411 op->env = 0;
1328 op->map = m; 1412 op->map = newmap;
1413
1329 mapspace &ms = op->ms (); 1414 mapspace &ms = op->ms ();
1330 1415
1331 /* this has to be done after we translate the coordinates. 1416 /* this has to be done after we translate the coordinates.
1332 */ 1417 */
1333 if (op->nrof && !(flag & INS_NO_MERGE)) 1418 if (op->nrof && !(flag & INS_NO_MERGE))
1334 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1419 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335 if (object::can_merge (op, tmp)) 1420 if (object::can_merge (op, tmp))
1336 { 1421 {
1337 // TODO: we atcually want to update tmp, not op, 1422 // TODO: we actually want to update tmp, not op,
1338 // but some caller surely breaks when we return tmp 1423 // but some caller surely breaks when we return tmp
1339 // from here :/ 1424 // from here :/
1340 op->nrof += tmp->nrof; 1425 op->nrof += tmp->nrof;
1341 tmp->destroy (1); 1426 tmp->destroy ();
1342 } 1427 }
1343 1428
1344 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1429 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1345 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1430 op->clr_flag (FLAG_INV_LOCKED);
1346 1431
1347 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1432 if (!op->flag [FLAG_ALIVE])
1348 CLEAR_FLAG (op, FLAG_NO_STEAL); 1433 op->clr_flag (FLAG_NO_STEAL);
1349 1434
1350 if (flag & INS_BELOW_ORIGINATOR) 1435 if (flag & INS_BELOW_ORIGINATOR)
1351 { 1436 {
1352 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1437 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1353 { 1438 {
1354 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1439 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1355 abort (); 1440 abort ();
1356 } 1441 }
1357 1442
1443 if (!originator->is_on_map ())
1444 {
1445 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1446 op->debug_desc (), originator->debug_desc ());
1447 abort ();
1448 }
1449
1358 op->above = originator; 1450 op->above = originator;
1359 op->below = originator->below; 1451 op->below = originator->below;
1360
1361 if (op->below)
1362 op->below->above = op;
1363 else
1364 ms.bot = op;
1365
1366 /* since *below* originator, no need to update top */
1367 originator->below = op; 1452 originator->below = op;
1453
1454 *(op->below ? &op->below->above : &ms.bot) = op;
1368 } 1455 }
1369 else 1456 else
1370 { 1457 {
1371 object *top, *floor = NULL; 1458 object *floor = 0;
1372 1459 object *top = ms.top;
1373 top = ms.bot;
1374 1460
1375 /* If there are other objects, then */ 1461 /* If there are other objects, then */
1376 if (top) 1462 if (top)
1377 { 1463 {
1378 object *last = 0;
1379
1380 /* 1464 /*
1381 * If there are multiple objects on this space, we do some trickier handling. 1465 * If there are multiple objects on this space, we do some trickier handling.
1382 * We've already dealt with merging if appropriate. 1466 * We've already dealt with merging if appropriate.
1383 * Generally, we want to put the new object on top. But if 1467 * Generally, we want to put the new object on top. But if
1384 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1468 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1387 * once we get to them. This reduces the need to traverse over all of 1471 * once we get to them. This reduces the need to traverse over all of
1388 * them when adding another one - this saves quite a bit of cpu time 1472 * them when adding another one - this saves quite a bit of cpu time
1389 * when lots of spells are cast in one area. Currently, it is presumed 1473 * when lots of spells are cast in one area. Currently, it is presumed
1390 * that flying non pickable objects are spell objects. 1474 * that flying non pickable objects are spell objects.
1391 */ 1475 */
1392 for (top = ms.bot; top; top = top->above) 1476 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1393 { 1477 {
1394 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1478 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1395 floor = top; 1479 floor = tmp;
1396 1480
1397 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1481 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1398 { 1482 {
1399 /* We insert above top, so we want this object below this */ 1483 /* We insert above top, so we want this object below this */
1400 top = top->below; 1484 top = tmp->below;
1401 break; 1485 break;
1402 } 1486 }
1403 1487
1404 last = top; 1488 top = tmp;
1405 } 1489 }
1406
1407 /* Don't want top to be NULL, so set it to the last valid object */
1408 top = last;
1409 1490
1410 /* We let update_position deal with figuring out what the space 1491 /* We let update_position deal with figuring out what the space
1411 * looks like instead of lots of conditions here. 1492 * looks like instead of lots of conditions here.
1412 * makes things faster, and effectively the same result. 1493 * makes things faster, and effectively the same result.
1413 */ 1494 */
1420 */ 1501 */
1421 if (!(flag & INS_ON_TOP) 1502 if (!(flag & INS_ON_TOP)
1422 && ms.flags () & P_BLOCKSVIEW 1503 && ms.flags () & P_BLOCKSVIEW
1423 && (op->face && !faces [op->face].visibility)) 1504 && (op->face && !faces [op->face].visibility))
1424 { 1505 {
1506 object *last;
1507
1425 for (last = top; last != floor; last = last->below) 1508 for (last = top; last != floor; last = last->below)
1426 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1509 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1427 break; 1510 break;
1428 1511
1429 /* Check to see if we found the object that blocks view, 1512 /* Check to see if we found the object that blocks view,
1430 * and make sure we have a below pointer for it so that 1513 * and make sure we have a below pointer for it so that
1431 * we can get inserted below this one, which requires we 1514 * we can get inserted below this one, which requires we
1437 } /* If objects on this space */ 1520 } /* If objects on this space */
1438 1521
1439 if (flag & INS_ABOVE_FLOOR_ONLY) 1522 if (flag & INS_ABOVE_FLOOR_ONLY)
1440 top = floor; 1523 top = floor;
1441 1524
1442 /* Top is the object that our object (op) is going to get inserted above. 1525 // insert object above top, or bottom-most if top = 0
1443 */
1444
1445 /* First object on this space */
1446 if (!top) 1526 if (!top)
1447 { 1527 {
1528 op->below = 0;
1448 op->above = ms.bot; 1529 op->above = ms.bot;
1449
1450 if (op->above)
1451 op->above->below = op;
1452
1453 op->below = 0;
1454 ms.bot = op; 1530 ms.bot = op;
1531
1532 *(op->above ? &op->above->below : &ms.top) = op;
1455 } 1533 }
1456 else 1534 else
1457 { /* get inserted into the stack above top */ 1535 {
1458 op->above = top->above; 1536 op->above = top->above;
1459
1460 if (op->above)
1461 op->above->below = op; 1537 top->above = op;
1462 1538
1463 op->below = top; 1539 op->below = top;
1464 top->above = op; 1540 *(op->above ? &op->above->below : &ms.top) = op;
1465 } 1541 }
1542 }
1466 1543
1467 if (!op->above) 1544 if (op->is_player ())
1468 ms.top = op;
1469 } /* else not INS_BELOW_ORIGINATOR */
1470
1471 if (op->type == PLAYER)
1472 { 1545 {
1473 op->contr->do_los = 1; 1546 op->contr->do_los = 1;
1474 ++op->map->players; 1547 ++op->map->players;
1475 op->map->touch (); 1548 op->map->touch ();
1476 } 1549 }
1477 1550
1478 op->map->dirty = true; 1551 op->map->dirty = true;
1479 1552
1480 if (object *pl = ms.player ()) 1553 if (object *pl = ms.player ())
1481 //TODO: the floorbox prev/next might need updating 1554 //TODO: the floorbox prev/next might need updating
1482 esrv_send_item (pl, op); 1555 //esrv_send_item (pl, op);
1556 //TODO: update floorbox to preserve ordering
1557 if (pl->contr->ns)
1558 pl->contr->ns->floorbox_update ();
1483 1559
1484 /* If this object glows, it may affect lighting conditions that are 1560 /* If this object glows, it may affect lighting conditions that are
1485 * visible to others on this map. But update_all_los is really 1561 * visible to others on this map. But update_all_los is really
1486 * an inefficient way to do this, as it means los for all players 1562 * an inefficient way to do this, as it means los for all players
1487 * on the map will get recalculated. The players could very well 1563 * on the map will get recalculated. The players could very well
1488 * be far away from this change and not affected in any way - 1564 * be far away from this change and not affected in any way -
1489 * this should get redone to only look for players within range, 1565 * this should get redone to only look for players within range,
1490 * or just updating the P_UPTODATE for spaces within this area 1566 * or just updating the P_UPTODATE for spaces within this area
1491 * of effect may be sufficient. 1567 * of effect may be sufficient.
1492 */ 1568 */
1493 if (op->map->darkness && (op->glow_radius != 0)) 1569 if (op->affects_los ())
1570 {
1571 op->ms ().invalidate ();
1494 update_all_los (op->map, op->x, op->y); 1572 update_all_los (op->map, op->x, op->y);
1573 }
1495 1574
1496 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1575 /* updates flags (blocked, alive, no magic, etc) for this map space */
1497 update_object (op, UP_OBJ_INSERT); 1576 update_object (op, UP_OBJ_INSERT);
1498 1577
1499 INVOKE_OBJECT (INSERT, op); 1578 INVOKE_OBJECT (INSERT, op);
1506 * blocked() and wall() work properly), and these flags are updated by 1585 * blocked() and wall() work properly), and these flags are updated by
1507 * update_object(). 1586 * update_object().
1508 */ 1587 */
1509 1588
1510 /* if this is not the head or flag has been passed, don't check walk on status */ 1589 /* if this is not the head or flag has been passed, don't check walk on status */
1511 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1590 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1512 { 1591 {
1513 if (check_move_on (op, originator)) 1592 if (check_move_on (op, originator, flag))
1514 return 0; 1593 return 0;
1515 1594
1516 /* If we are a multi part object, lets work our way through the check 1595 /* If we are a multi part object, let's work our way through the check
1517 * walk on's. 1596 * walk on's.
1518 */ 1597 */
1519 for (object *tmp = op->more; tmp; tmp = tmp->more) 1598 for (object *tmp = op->more; tmp; tmp = tmp->more)
1520 if (check_move_on (tmp, originator)) 1599 if (check_move_on (tmp, originator, flag))
1521 return 0; 1600 return 0;
1522 } 1601 }
1523 1602
1524 return op; 1603 return op;
1525} 1604}
1527/* this function inserts an object in the map, but if it 1606/* this function inserts an object in the map, but if it
1528 * finds an object of its own type, it'll remove that one first. 1607 * finds an object of its own type, it'll remove that one first.
1529 * op is the object to insert it under: supplies x and the map. 1608 * op is the object to insert it under: supplies x and the map.
1530 */ 1609 */
1531void 1610void
1532replace_insert_ob_in_map (const char *arch_string, object *op) 1611replace_insert_ob_in_map (shstr_tmp archname, object *op)
1533{ 1612{
1534 /* first search for itself and remove any old instances */ 1613 /* first search for itself and remove any old instances */
1535 1614
1536 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1615 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1537 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1616 if (tmp->arch->archname == archname) /* same archetype */
1538 tmp->destroy (1); 1617 tmp->destroy ();
1539 1618
1540 object *tmp = arch_to_object (archetype::find (arch_string)); 1619 object *tmp = archetype::find (archname)->instance ();
1541 1620
1542 tmp->x = op->x; 1621 tmp->x = op->x;
1543 tmp->y = op->y; 1622 tmp->y = op->y;
1544 1623
1545 insert_ob_in_map (tmp, op->map, op, 0); 1624 insert_ob_in_map (tmp, op->map, op, 0);
1550{ 1629{
1551 if (where->env) 1630 if (where->env)
1552 return where->env->insert (this); 1631 return where->env->insert (this);
1553 else 1632 else
1554 return where->map->insert (this, where->x, where->y, originator, flags); 1633 return where->map->insert (this, where->x, where->y, originator, flags);
1634}
1635
1636// check whether we can put this into the map, respect max_volume, max_items
1637bool
1638object::can_drop_at (maptile *m, int x, int y, object *originator)
1639{
1640 mapspace &ms = m->at (x, y);
1641
1642 int items = ms.items ();
1643
1644 if (!items // testing !items ensures we can drop at least one item
1645 || (items < m->max_items
1646 && ms.volume () < m->max_volume))
1647 return true;
1648
1649 if (originator && originator->is_player ())
1650 originator->contr->failmsgf (
1651 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1652 query_name ()
1653 );
1654
1655 return false;
1555} 1656}
1556 1657
1557/* 1658/*
1558 * decrease(object, number) decreases a specified number from 1659 * decrease(object, number) decreases a specified number from
1559 * the amount of an object. If the amount reaches 0, the object 1660 * the amount of an object. If the amount reaches 0, the object
1567 if (!nr) 1668 if (!nr)
1568 return true; 1669 return true;
1569 1670
1570 nr = min (nr, nrof); 1671 nr = min (nr, nrof);
1571 1672
1673 if (nrof > nr)
1674 {
1675 sint64 oweight = total_weight ();
1676
1572 nrof -= nr; 1677 nrof -= nr;
1573
1574 if (nrof)
1575 {
1576 adjust_weight (env, -weight * nr); // carrying == 0
1577 1678
1578 if (object *pl = visible_to ()) 1679 if (object *pl = visible_to ())
1579 esrv_update_item (UPD_NROF, pl, this); 1680 esrv_update_item (UPD_NROF, pl, this);
1580 1681
1682 adjust_weight (env, oweight, total_weight ());
1683
1581 return true; 1684 return true;
1582 } 1685 }
1583 else 1686 else
1584 { 1687 {
1585 destroy (1); 1688 destroy ();
1586 return false; 1689 return false;
1587 } 1690 }
1588} 1691}
1589 1692
1590/* 1693/*
1607 } 1710 }
1608 else 1711 else
1609 { 1712 {
1610 decrease (nr); 1713 decrease (nr);
1611 1714
1612 object *op = object_create_clone (this); 1715 object *op = deep_clone ();
1613 op->nrof = nr; 1716 op->nrof = nr;
1614 return op; 1717 return op;
1615 } 1718 }
1616} 1719}
1617 1720
1659 if (op->nrof) 1762 if (op->nrof)
1660 for (object *tmp = inv; tmp; tmp = tmp->below) 1763 for (object *tmp = inv; tmp; tmp = tmp->below)
1661 if (object::can_merge (tmp, op)) 1764 if (object::can_merge (tmp, op))
1662 { 1765 {
1663 /* return the original object and remove inserted object 1766 /* return the original object and remove inserted object
1664 (client needs the original object) */ 1767 (client prefers the original object) */
1768
1769 // carring must be 0 for mergable objects
1770 sint64 oweight = tmp->weight * tmp->nrof;
1771
1665 tmp->nrof += op->nrof; 1772 tmp->nrof += op->nrof;
1666 1773
1667 if (object *pl = tmp->visible_to ()) 1774 if (object *pl = tmp->visible_to ())
1668 esrv_update_item (UPD_NROF, pl, tmp); 1775 esrv_update_item (UPD_NROF, pl, tmp);
1669 1776
1670 adjust_weight (this, op->total_weight ()); 1777 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1671 1778
1672 op->destroy (1); 1779 op->destroy ();
1673 op = tmp; 1780 op = tmp;
1674 goto inserted; 1781 goto inserted;
1675 } 1782 }
1676 1783
1677 op->owner = 0; // it's his/hers now. period. 1784 op->owner = 0; // it's his/hers now. period.
1691 op->flag [FLAG_REMOVED] = 0; 1798 op->flag [FLAG_REMOVED] = 0;
1692 1799
1693 if (object *pl = op->visible_to ()) 1800 if (object *pl = op->visible_to ())
1694 esrv_send_item (pl, op); 1801 esrv_send_item (pl, op);
1695 1802
1696 adjust_weight (this, op->total_weight ()); 1803 adjust_weight (this, 0, op->total_weight ());
1697 1804
1698inserted: 1805inserted:
1699 /* reset the light list and los of the players on the map */ 1806 /* reset the light list and los of the players on the map */
1700 if (op->glow_radius && map && map->darkness) 1807 if (op->glow_radius && is_on_map ())
1808 {
1809 update_stats ();
1701 update_all_los (map, x, y); 1810 update_all_los (map, x, y);
1702 1811 }
1812 else if (is_player ())
1703 // if this is a player's inventory, update stats 1813 // if this is a player's inventory, update stats
1704 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1814 contr->queue_stats_update ();
1705 update_stats ();
1706 1815
1707 INVOKE_OBJECT (INSERT, this); 1816 INVOKE_OBJECT (INSERT, this);
1708 1817
1709 return op; 1818 return op;
1710} 1819}
1728 * MSW 2001-07-08: Check all objects on space, not just those below 1837 * MSW 2001-07-08: Check all objects on space, not just those below
1729 * object being inserted. insert_ob_in_map may not put new objects 1838 * object being inserted. insert_ob_in_map may not put new objects
1730 * on top. 1839 * on top.
1731 */ 1840 */
1732int 1841int
1733check_move_on (object *op, object *originator) 1842check_move_on (object *op, object *originator, int flags)
1734{ 1843{
1844 if (op->flag [FLAG_NO_APPLY])
1845 return 0;
1846
1735 object *tmp; 1847 object *tmp;
1736 maptile *m = op->map; 1848 maptile *m = op->map;
1737 int x = op->x, y = op->y; 1849 int x = op->x, y = op->y;
1738 1850
1739 MoveType move_on, move_slow, move_block; 1851 mapspace &ms = m->at (x, y);
1740 1852
1741 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1853 ms.update ();
1742 return 0;
1743 1854
1744 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1855 MoveType move_on = ms.move_on;
1745 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1856 MoveType move_slow = ms.move_slow;
1746 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1857 MoveType move_block = ms.move_block;
1747 1858
1748 /* if nothing on this space will slow op down or be applied, 1859 /* if nothing on this space will slow op down or be applied,
1749 * no need to do checking below. have to make sure move_type 1860 * no need to do checking below. have to make sure move_type
1750 * is set, as lots of objects don't have it set - we treat that 1861 * is set, as lots of objects don't have it set - we treat that
1751 * as walking. 1862 * as walking.
1762 return 0; 1873 return 0;
1763 1874
1764 /* The objects have to be checked from top to bottom. 1875 /* The objects have to be checked from top to bottom.
1765 * Hence, we first go to the top: 1876 * Hence, we first go to the top:
1766 */ 1877 */
1767 1878 for (object *next, *tmp = ms.top; tmp; tmp = next)
1768 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1769 {
1770 /* Trim the search when we find the first other spell effect
1771 * this helps performance so that if a space has 50 spell objects,
1772 * we don't need to check all of them.
1773 */
1774 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1775 break;
1776 } 1879 {
1880 next = tmp->below;
1777 1881
1778 for (; tmp; tmp = tmp->below)
1779 {
1780 if (tmp == op) 1882 if (tmp == op)
1781 continue; /* Can't apply yourself */ 1883 continue; /* Can't apply yourself */
1782 1884
1783 /* Check to see if one of the movement types should be slowed down. 1885 /* Check to see if one of the movement types should be slowed down.
1784 * Second check makes sure that the movement types not being slowed 1886 * Second check makes sure that the movement types not being slowed
1785 * (~slow_move) is not blocked on this space - just because the 1887 * (~slow_move) is not blocked on this space - just because the
1786 * space doesn't slow down swimming (for example), if you can't actually 1888 * space doesn't slow down swimming (for example), if you can't actually
1787 * swim on that space, can't use it to avoid the penalty. 1889 * swim on that space, can't use it to avoid the penalty.
1788 */ 1890 */
1789 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1891 if (!op->flag [FLAG_WIZPASS])
1790 { 1892 {
1791 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1893 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1792 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1894 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1793 { 1895 {
1794
1795 float
1796 diff = tmp->move_slow_penalty * fabs (op->speed); 1896 float diff = tmp->move_slow_penalty * fabs (op->speed);
1797 1897
1798 if (op->type == PLAYER) 1898 if (op->is_player ())
1799 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1899 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1800 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1900 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1801 diff /= 4.0; 1901 diff /= 4.0;
1802 1902
1803 op->speed_left -= diff; 1903 op->speed_left -= diff;
1804 } 1904 }
1805 } 1905 }
1806 1906
1807 /* Basically same logic as above, except now for actual apply. */ 1907 /* Basically same logic as above, except now for actual apply. */
1808 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1908 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1809 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1909 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1810 { 1910 {
1911 if ((flags & INS_NO_AUTO_EXIT)
1912 && (tmp->type == EXIT || tmp->type == TELEPORTER
1913 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1914 continue;
1915
1811 move_apply (tmp, op, originator); 1916 move_apply (tmp, op, originator);
1812 1917
1813 if (op->destroyed ()) 1918 if (op->destroyed ())
1814 return 1; 1919 return 1;
1815 1920
1838 LOG (llevError, "Present_arch called outside map.\n"); 1943 LOG (llevError, "Present_arch called outside map.\n");
1839 return NULL; 1944 return NULL;
1840 } 1945 }
1841 1946
1842 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1947 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1843 if (tmp->arch == at) 1948 if (tmp->arch->archname == at->archname)
1844 return tmp; 1949 return tmp;
1845 1950
1846 return NULL; 1951 return NULL;
1847} 1952}
1848 1953
1912 * The first matching object is returned, or NULL if none. 2017 * The first matching object is returned, or NULL if none.
1913 */ 2018 */
1914object * 2019object *
1915present_arch_in_ob (const archetype *at, const object *op) 2020present_arch_in_ob (const archetype *at, const object *op)
1916{ 2021{
1917 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 2022 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1918 if (tmp->arch == at) 2023 if (tmp->arch->archname == at->archname)
1919 return tmp; 2024 return tmp;
1920 2025
1921 return NULL; 2026 return NULL;
1922} 2027}
1923 2028
1927void 2032void
1928flag_inv (object *op, int flag) 2033flag_inv (object *op, int flag)
1929{ 2034{
1930 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2035 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1931 { 2036 {
1932 SET_FLAG (tmp, flag); 2037 tmp->set_flag (flag);
1933 flag_inv (tmp, flag); 2038 flag_inv (tmp, flag);
1934 } 2039 }
1935} 2040}
1936 2041
1937/* 2042/*
1940void 2045void
1941unflag_inv (object *op, int flag) 2046unflag_inv (object *op, int flag)
1942{ 2047{
1943 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2048 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1944 { 2049 {
1945 CLEAR_FLAG (tmp, flag); 2050 tmp->clr_flag (flag);
1946 unflag_inv (tmp, flag); 2051 unflag_inv (tmp, flag);
1947 } 2052 }
1948} 2053}
1949 2054
1950/* 2055/*
2011 * head of the object should correspond for the entire object. 2116 * head of the object should correspond for the entire object.
2012 */ 2117 */
2013 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2118 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2014 continue; 2119 continue;
2015 2120
2016 if (ob->blocked (m, pos.x, pos.y)) 2121 if (ob->blocked (pos.m, pos.x, pos.y))
2017 continue; 2122 continue;
2018 2123
2019 altern [index++] = i; 2124 altern [index++] = i;
2020 } 2125 }
2021 2126
2089 * there is capable of. 2194 * there is capable of.
2090 */ 2195 */
2091int 2196int
2092find_dir (maptile *m, int x, int y, object *exclude) 2197find_dir (maptile *m, int x, int y, object *exclude)
2093{ 2198{
2094 int i, max = SIZEOFFREE, mflags; 2199 int max = SIZEOFFREE, mflags;
2095
2096 sint16 nx, ny;
2097 object *tmp;
2098 maptile *mp;
2099
2100 MoveType blocked, move_type; 2200 MoveType move_type;
2101 2201
2102 if (exclude && exclude->head_ () != exclude) 2202 if (exclude && exclude->head_ () != exclude)
2103 { 2203 {
2104 exclude = exclude->head; 2204 exclude = exclude->head;
2105 move_type = exclude->move_type; 2205 move_type = exclude->move_type;
2108 { 2208 {
2109 /* If we don't have anything, presume it can use all movement types. */ 2209 /* If we don't have anything, presume it can use all movement types. */
2110 move_type = MOVE_ALL; 2210 move_type = MOVE_ALL;
2111 } 2211 }
2112 2212
2113 for (i = 1; i < max; i++) 2213 for (int i = 1; i < max; i++)
2114 { 2214 {
2115 mp = m; 2215 mapxy pos (m, x, y);
2116 nx = x + freearr_x[i]; 2216 pos.move (i);
2117 ny = y + freearr_y[i];
2118 2217
2119 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2218 if (!pos.normalise ())
2120
2121 if (mflags & P_OUT_OF_MAP)
2122 max = maxfree[i]; 2219 max = maxfree[i];
2123 else 2220 else
2124 { 2221 {
2125 mapspace &ms = mp->at (nx, ny); 2222 mapspace &ms = *pos;
2126 2223
2127 blocked = ms.move_block;
2128
2129 if ((move_type & blocked) == move_type) 2224 if ((move_type & ms.move_block) == move_type)
2130 max = maxfree[i]; 2225 max = maxfree [i];
2131 else if (mflags & P_IS_ALIVE) 2226 else if (ms.flags () & P_IS_ALIVE)
2132 { 2227 {
2133 for (tmp = ms.bot; tmp; tmp = tmp->above) 2228 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2134 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2229 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2135 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2230 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2136 break;
2137
2138 if (tmp)
2139 return freedir[i]; 2231 return freedir [i];
2140 } 2232 }
2141 } 2233 }
2142 } 2234 }
2143 2235
2144 return 0; 2236 return 0;
2153{ 2245{
2154 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2246 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2155} 2247}
2156 2248
2157/* 2249/*
2158 * find_dir_2(delta-x,delta-y) will return a direction in which 2250 * find_dir_2(delta-x,delta-y) will return a direction value
2159 * an object which has subtracted the x and y coordinates of another 2251 * for running into direct [dx, dy].
2160 * object, needs to travel toward it. 2252 * (the opposite of crossfire's find_dir_2!)
2161 */ 2253 */
2162int 2254int
2163find_dir_2 (int x, int y) 2255find_dir_2 (int x, int y)
2164{ 2256{
2257#if 1 // new algorithm
2258 // this works by putting x, y into 16 sectors, which
2259 // are not equal sized, but are a better approximation
2260 // then the old algorithm, and then using a mapping
2261 // table to map it into a direction value.
2262 // basically, it maps these comparisons to each bit
2263 // bit #3: x < 0
2264 // bit #2: y < 0
2265 // bit #1: x > y
2266 // bit #0: x > 2y
2267
2268 static const uint8 dir[16] = {
2269 4, 5, 4, 3,
2270 2, 1, 2, 3,
2271 6, 5, 6, 7,
2272 8, 1, 8, 7,
2273 };
2274 int sector = 0;
2275
2276 // this is a bit ugly, but more likely to result in branchless code
2277 sector |= x < 0 ? 8 : 0;
2278 x = x < 0 ? -x : x; // abs
2279
2280 sector |= y < 0 ? 4 : 0;
2281 y = y < 0 ? -y : y; // abs
2282
2283 if (x > y)
2284 {
2285 sector |= 2;
2286
2287 if (x > y * 2)
2288 sector |= 1;
2289 }
2290 else
2291 {
2292 if (y > x * 2)
2293 sector |= 1;
2294 else if (!y)
2295 return 0; // x == 0 here
2296 }
2297
2298 return dir [sector];
2299#else // old algorithm
2165 int q; 2300 int q;
2166 2301
2167 if (y) 2302 if (y)
2168 q = x * 100 / y; 2303 q = 128 * x / y;
2169 else if (x) 2304 else if (x)
2170 q = -300 * x; 2305 q = -512 * x; // to make it > 309
2171 else 2306 else
2172 return 0; 2307 return 0;
2173 2308
2174 if (y > 0) 2309 if (y > 0)
2175 { 2310 {
2176 if (q < -242) 2311 if (q < -309) return 7;
2312 if (q < -52) return 6;
2313 if (q < 52) return 5;
2314 if (q < 309) return 4;
2315
2177 return 3; 2316 return 3;
2178 if (q < -41) 2317 }
2179 return 2; 2318 else
2180 if (q < 41) 2319 {
2181 return 1; 2320 if (q < -309) return 3;
2182 if (q < 242) 2321 if (q < -52) return 2;
2183 return 8; 2322 if (q < 52) return 1;
2323 if (q < 309) return 8;
2324
2184 return 7; 2325 return 7;
2185 } 2326 }
2186 2327#endif
2187 if (q < -242)
2188 return 7;
2189 if (q < -41)
2190 return 6;
2191 if (q < 41)
2192 return 5;
2193 if (q < 242)
2194 return 4;
2195
2196 return 3;
2197} 2328}
2198 2329
2199/* 2330/*
2200 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2331 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2201 * between two directions (which are expected to be absolute (see absdir()) 2332 * between two directions (which are expected to be absolute (see absdir())
2202 */ 2333 */
2203int 2334int
2204dirdiff (int dir1, int dir2) 2335dirdiff (int dir1, int dir2)
2205{ 2336{
2206 int d;
2207
2208 d = abs (dir1 - dir2); 2337 int d = abs (dir1 - dir2);
2209 if (d > 4)
2210 d = 8 - d;
2211 2338
2212 return d; 2339 return d > 4 ? 8 - d : d;
2213} 2340}
2214 2341
2215/* peterm: 2342/* peterm:
2216 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2343 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2217 * Basically, this is a table of directions, and what directions 2344 * Basically, this is a table of directions, and what directions
2219 * This basically means that if direction is 15, then it could either go 2346 * This basically means that if direction is 15, then it could either go
2220 * direction 4, 14, or 16 to get back to where we are. 2347 * direction 4, 14, or 16 to get back to where we are.
2221 * Moved from spell_util.c to object.c with the other related direction 2348 * Moved from spell_util.c to object.c with the other related direction
2222 * functions. 2349 * functions.
2223 */ 2350 */
2224int reduction_dir[SIZEOFFREE][3] = { 2351static const int reduction_dir[SIZEOFFREE][3] = {
2225 {0, 0, 0}, /* 0 */ 2352 {0, 0, 0}, /* 0 */
2226 {0, 0, 0}, /* 1 */ 2353 {0, 0, 0}, /* 1 */
2227 {0, 0, 0}, /* 2 */ 2354 {0, 0, 0}, /* 2 */
2228 {0, 0, 0}, /* 3 */ 2355 {0, 0, 0}, /* 3 */
2229 {0, 0, 0}, /* 4 */ 2356 {0, 0, 0}, /* 4 */
2323 * Add a check so we can't pick up invisible objects (0.93.8) 2450 * Add a check so we can't pick up invisible objects (0.93.8)
2324 */ 2451 */
2325int 2452int
2326can_pick (const object *who, const object *item) 2453can_pick (const object *who, const object *item)
2327{ 2454{
2328 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2455 return /*who->flag [FLAG_WIZ]|| */
2329 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2456 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2330 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2457 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2331} 2458}
2332 2459
2333/* 2460/*
2334 * create clone from object to another 2461 * create clone from object to another
2335 */ 2462 */
2336object * 2463object *
2337object_create_clone (object *asrc) 2464object::deep_clone ()
2338{ 2465{
2339 object *dst = 0, *tmp, *src, *prev, *item; 2466 assert (("deep_clone called on non-head object", is_head ()));
2340 2467
2341 if (!asrc) 2468 object *dst = clone ();
2342 return 0;
2343 2469
2344 src = asrc->head_ (); 2470 object *prev = dst;
2345
2346 prev = 0;
2347 for (object *part = src; part; part = part->more) 2471 for (object *part = this->more; part; part = part->more)
2348 { 2472 {
2349 tmp = part->clone (); 2473 object *tmp = part->clone ();
2350 tmp->x -= src->x;
2351 tmp->y -= src->y;
2352
2353 if (!part->head)
2354 {
2355 dst = tmp;
2356 tmp->head = 0;
2357 }
2358 else
2359 tmp->head = dst; 2474 tmp->head = dst;
2360
2361 tmp->more = 0;
2362
2363 if (prev)
2364 prev->more = tmp; 2475 prev->more = tmp;
2365
2366 prev = tmp; 2476 prev = tmp;
2367 } 2477 }
2368 2478
2369 for (item = src->inv; item; item = item->below) 2479 for (object *item = inv; item; item = item->below)
2370 insert_ob_in_ob (object_create_clone (item), dst); 2480 insert_ob_in_ob (item->deep_clone (), dst);
2371 2481
2372 return dst; 2482 return dst;
2373} 2483}
2374 2484
2375/* This returns the first object in who's inventory that 2485/* This returns the first object in who's inventory that
2384 return tmp; 2494 return tmp;
2385 2495
2386 return 0; 2496 return 0;
2387} 2497}
2388 2498
2389/* If ob has a field named key, return the link from the list, 2499shstr_tmp
2390 * otherwise return NULL. 2500object::kv_get (shstr_tmp key) const
2391 *
2392 * key must be a passed in shared string - otherwise, this won't
2393 * do the desired thing.
2394 */
2395key_value *
2396get_ob_key_link (const object *ob, const char *key)
2397{ 2501{
2398 for (key_value *link = ob->key_values; link; link = link->next) 2502 for (key_value *kv = key_values; kv; kv = kv->next)
2399 if (link->key == key) 2503 if (kv->key == key)
2400 return link;
2401
2402 return 0;
2403}
2404
2405/*
2406 * Returns the value of op has an extra_field for key, or NULL.
2407 *
2408 * The argument doesn't need to be a shared string.
2409 *
2410 * The returned string is shared.
2411 */
2412const char *
2413get_ob_key_value (const object *op, const char *const key)
2414{
2415 key_value *link;
2416 shstr_cmp canonical_key (key);
2417
2418 if (!canonical_key)
2419 {
2420 /* 1. There being a field named key on any object
2421 * implies there'd be a shared string to find.
2422 * 2. Since there isn't, no object has this field.
2423 * 3. Therefore, *this* object doesn't have this field.
2424 */
2425 return 0;
2426 }
2427
2428 /* This is copied from get_ob_key_link() above -
2429 * only 4 lines, and saves the function call overhead.
2430 */
2431 for (link = op->key_values; link; link = link->next)
2432 if (link->key == canonical_key)
2433 return link->value; 2504 return kv->value;
2434 2505
2435 return 0; 2506 return shstr ();
2436} 2507}
2437 2508
2438/* 2509void
2439 * Updates the canonical_key in op to value. 2510object::kv_set (shstr_tmp key, shstr_tmp value)
2440 *
2441 * canonical_key is a shared string (value doesn't have to be).
2442 *
2443 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2444 * keys.
2445 *
2446 * Returns TRUE on success.
2447 */
2448int
2449set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2450{ 2511{
2451 key_value *field = NULL, *last = NULL; 2512 for (key_value *kv = key_values; kv; kv = kv->next)
2452 2513 if (kv->key == key)
2453 for (field = op->key_values; field != NULL; field = field->next)
2454 {
2455 if (field->key != canonical_key)
2456 { 2514 {
2457 last = field; 2515 kv->value = value;
2458 continue; 2516 return;
2459 } 2517 }
2460 2518
2461 if (value) 2519 key_value *kv = new key_value;
2462 field->value = value; 2520
2463 else 2521 kv->next = key_values;
2522 kv->key = key;
2523 kv->value = value;
2524
2525 key_values = kv;
2526}
2527
2528void
2529object::kv_del (shstr_tmp key)
2530{
2531 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2532 if ((*kvp)->key == key)
2464 { 2533 {
2465 /* Basically, if the archetype has this key set, 2534 key_value *kv = *kvp;
2466 * we need to store the null value so when we save 2535 *kvp = (*kvp)->next;
2467 * it, we save the empty value so that when we load, 2536 delete kv;
2468 * we get this value back again. 2537 return;
2469 */
2470 if (get_ob_key_link (op->arch, canonical_key))
2471 field->value = 0;
2472 else
2473 {
2474 if (last)
2475 last->next = field->next;
2476 else
2477 op->key_values = field->next;
2478
2479 delete field;
2480 }
2481 } 2538 }
2482 return TRUE;
2483 }
2484 /* IF we get here, key doesn't exist */
2485
2486 /* No field, we'll have to add it. */
2487
2488 if (!add_key)
2489 return FALSE;
2490
2491 /* There isn't any good reason to store a null
2492 * value in the key/value list. If the archetype has
2493 * this key, then we should also have it, so shouldn't
2494 * be here. If user wants to store empty strings,
2495 * should pass in ""
2496 */
2497 if (value == NULL)
2498 return TRUE;
2499
2500 field = new key_value;
2501
2502 field->key = canonical_key;
2503 field->value = value;
2504 /* Usual prepend-addition. */
2505 field->next = op->key_values;
2506 op->key_values = field;
2507
2508 return TRUE;
2509}
2510
2511/*
2512 * Updates the key in op to value.
2513 *
2514 * If add_key is FALSE, this will only update existing keys,
2515 * and not add new ones.
2516 * In general, should be little reason FALSE is ever passed in for add_key
2517 *
2518 * Returns TRUE on success.
2519 */
2520int
2521set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2522{
2523 shstr key_ (key);
2524
2525 return set_ob_key_value_s (op, key_, value, add_key);
2526} 2539}
2527 2540
2528object::depth_iterator::depth_iterator (object *container) 2541object::depth_iterator::depth_iterator (object *container)
2529: iterator_base (container) 2542: iterator_base (container)
2530{ 2543{
2580{ 2593{
2581 char flagdesc[512]; 2594 char flagdesc[512];
2582 char info2[256 * 4]; 2595 char info2[256 * 4];
2583 char *p = info; 2596 char *p = info;
2584 2597
2585 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2598 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2586 count, 2599 count,
2587 uuid.c_str (), 2600 uuid.c_str (),
2588 &name, 2601 &name,
2589 title ? "\",title:\"" : "", 2602 title ? ",title:\"" : "",
2590 title ? (const char *)title : "", 2603 title ? (const char *)title : "",
2604 title ? "\"" : "",
2591 flag_desc (flagdesc, 512), type); 2605 flag_desc (flagdesc, 512), type);
2592 2606
2593 if (!flag[FLAG_REMOVED] && env) 2607 if (!flag[FLAG_REMOVED] && env)
2594 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2608 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2595 2609
2611struct region * 2625struct region *
2612object::region () const 2626object::region () const
2613{ 2627{
2614 return map ? map->region (x, y) 2628 return map ? map->region (x, y)
2615 : region::default_region (); 2629 : region::default_region ();
2616}
2617
2618const materialtype_t *
2619object::dominant_material () const
2620{
2621 if (materialtype_t *mt = name_to_material (materialname))
2622 return mt;
2623
2624 return name_to_material (shstr_unknown);
2625} 2630}
2626 2631
2627void 2632void
2628object::open_container (object *new_container) 2633object::open_container (object *new_container)
2629{ 2634{
2651 container = 0; 2656 container = 0;
2652 2657
2653 // client needs item update to make it work, client bug requires this to be separate 2658 // client needs item update to make it work, client bug requires this to be separate
2654 esrv_update_item (UPD_FLAGS, this, old_container); 2659 esrv_update_item (UPD_FLAGS, this, old_container);
2655 2660
2656 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2661 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2657 play_sound (sound_find ("chest_close")); 2662 play_sound (sound_find ("chest_close"));
2658 } 2663 }
2659 2664
2660 if (new_container) 2665 if (new_container)
2661 { 2666 {
2665 // TODO: this does not seem to serve any purpose anymore? 2670 // TODO: this does not seem to serve any purpose anymore?
2666#if 0 2671#if 0
2667 // insert the "Close Container" object. 2672 // insert the "Close Container" object.
2668 if (archetype *closer = new_container->other_arch) 2673 if (archetype *closer = new_container->other_arch)
2669 { 2674 {
2670 object *closer = arch_to_object (new_container->other_arch); 2675 object *closer = new_container->other_arch->instance ();
2671 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2676 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2672 new_container->insert (closer); 2677 new_container->insert (closer);
2673 } 2678 }
2674#endif 2679#endif
2675 2680
2676 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2681 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2677 2682
2678 // make sure the container is available, client bug requires this to be separate 2683 // make sure the container is available, client bug requires this to be separate
2679 esrv_send_item (this, new_container); 2684 esrv_send_item (this, new_container);
2680 2685
2681 new_container->flag [FLAG_APPLIED] = true; 2686 new_container->flag [FLAG_APPLIED] = true;
2689// else if (!old_container->env && contr && contr->ns) 2694// else if (!old_container->env && contr && contr->ns)
2690// contr->ns->floorbox_reset (); 2695// contr->ns->floorbox_reset ();
2691} 2696}
2692 2697
2693object * 2698object *
2694object::force_find (const shstr name) 2699object::force_find (shstr_tmp name)
2695{ 2700{
2696 /* cycle through his inventory to look for the MARK we want to 2701 /* cycle through his inventory to look for the MARK we want to
2697 * place 2702 * place
2698 */ 2703 */
2699 for (object *tmp = inv; tmp; tmp = tmp->below) 2704 for (object *tmp = inv; tmp; tmp = tmp->below)
2701 return splay (tmp); 2706 return splay (tmp);
2702 2707
2703 return 0; 2708 return 0;
2704} 2709}
2705 2710
2711//-GPL
2712
2706void 2713void
2714object::force_set_timer (int duration)
2715{
2716 this->duration = 1;
2717 this->speed_left = -1.f;
2718
2719 this->set_speed (duration ? 1.f / duration : 0.f);
2720}
2721
2722object *
2707object::force_add (const shstr name, int duration) 2723object::force_add (shstr_tmp name, int duration)
2708{ 2724{
2709 if (object *force = force_find (name)) 2725 if (object *force = force_find (name))
2710 force->destroy (); 2726 force->destroy ();
2711 2727
2712 object *force = get_archetype (FORCE_NAME); 2728 object *force = get_archetype (FORCE_NAME);
2713 2729
2714 force->slaying = name; 2730 force->slaying = name;
2715 force->stats.food = 1; 2731 force->force_set_timer (duration);
2716 force->speed_left = -1.f;
2717
2718 force->set_speed (duration ? 1.f / duration : 0.f);
2719 force->flag [FLAG_IS_USED_UP] = true;
2720 force->flag [FLAG_APPLIED] = true; 2732 force->flag [FLAG_APPLIED] = true;
2721 2733
2722 insert (force); 2734 return insert (force);
2723} 2735}
2724 2736
2725void 2737void
2726object::play_sound (faceidx sound) 2738object::play_sound (faceidx sound) const
2727{ 2739{
2728 if (!sound) 2740 if (!sound)
2729 return; 2741 return;
2730 2742
2731 if (flag [FLAG_REMOVED]) 2743 if (is_on_map ())
2744 map->play_sound (sound, x, y);
2745 else if (object *pl = in_player ())
2746 pl->contr->play_sound (sound);
2747}
2748
2749void
2750object::say_msg (const char *msg) const
2751{
2752 if (is_on_map ())
2753 map->say_msg (msg, x, y);
2754 else if (object *pl = in_player ())
2755 pl->contr->play_sound (sound);
2756}
2757
2758void
2759object::make_noise ()
2760{
2761 // we do not model noise in the map, so instead put
2762 // a temporary light into the noise source
2763 // could use the map instead, but that's less reliable for our
2764 // goal, which is to make invisibility a bit harder to exploit
2765
2766 // currently only works sensibly for players
2767 if (!is_player ())
2732 return; 2768 return;
2733 2769
2734 if (env) 2770 // find old force, or create new one
2735 { 2771 object *force = force_find (shstr_noise_force);
2736 if (object *pl = in_player ()) 2772
2737 pl->contr->play_sound (sound); 2773 if (force)
2738 } 2774 force->speed_left = -1.f; // patch old speed up
2739 else 2775 else
2740 map->play_sound (sound, x, y); 2776 {
2741} 2777 force = archetype::get (shstr_noise_force);
2742 2778
2779 force->slaying = shstr_noise_force;
2780 force->stats.food = 1;
2781 force->speed_left = -1.f;
2782
2783 force->set_speed (1.f / 4.f);
2784 force->flag [FLAG_IS_USED_UP] = true;
2785 force->flag [FLAG_APPLIED] = true;
2786
2787 insert (force);
2788 }
2789}
2790
2791void object::change_move_type (MoveType mt)
2792{
2793 if (move_type == mt)
2794 return;
2795
2796 if (is_on_map ())
2797 {
2798 // we are on the map, so handle move_on/off effects
2799 remove ();
2800 move_type = mt;
2801 map->insert (this, x, y, this);
2802 }
2803 else
2804 move_type = mt;
2805}
2806
2807/* object should be a player.
2808 * we return the object the player has marked with the 'mark' command
2809 * below. If no match is found (or object has changed), we return
2810 * NULL. We leave it up to the calling function to print messages if
2811 * nothing is found.
2812 */
2813object *
2814object::mark () const
2815{
2816 if (contr && contr->mark && contr->mark->env == this)
2817 return contr->mark;
2818 else
2819 return 0;
2820}
2821
2822// put marked object first in the inventory
2823// this is used by identify-like spells so players can influence
2824// the order a bit.
2825void
2826object::splay_marked ()
2827{
2828 if (object *marked = mark ())
2829 splay (marked);
2830}
2831

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines