ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.222 by root, Wed Apr 30 05:06:36 2008 UTC vs.
Revision 1.247 by root, Mon Jul 14 18:36:43 2008 UTC

139 139
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 141static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
143{ 143{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
149 */ 147 */
150 148
151 /* For each field in wants, */ 149 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 151 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 152 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 153
169 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 155 return true;
171} 156}
172 157
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 159static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 161{
177 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
179 */ 164 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
181} 167}
182 168
183/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 170 * they can be merged together.
185 * 171 *
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 207
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 209 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 210
225 if (ob1->arch->name != ob2->arch->name 211 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 212 || ob1->name != ob2->name
227 || ob1->title != ob2->title 213 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 214 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 215 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 216 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 217 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 218 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 219 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 220 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 221 || ob1->animation_id != ob2->animation_id
222 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 223 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 224 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 225 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 226 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 227 || ob1->move_type != ob2->move_type
368 return 0; 355 return 0;
369} 356}
370 357
371// adjust weight per container type ("of holding") 358// adjust weight per container type ("of holding")
372static sint32 359static sint32
373weight_adjust (object *op, sint32 weight) 360weight_adjust_for (object *op, sint32 weight)
374{ 361{
375 return op->type == CONTAINER 362 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 363 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 364 : weight;
378} 365}
384static void 371static void
385adjust_weight (object *op, sint32 weight) 372adjust_weight (object *op, sint32 weight)
386{ 373{
387 while (op) 374 while (op)
388 { 375 {
376 // adjust by actual difference to account for rounding errors
377 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 378 weight = weight_adjust_for (op, op->carrying)
379 - weight_adjust_for (op, op->carrying - weight);
390 380
391 if (!weight) 381 if (!weight)
392 return; 382 return;
393 383
394 op->carrying += weight; 384 op->carrying += weight;
417 op->update_weight (); 407 op->update_weight ();
418 408
419 sum += op->total_weight (); 409 sum += op->total_weight ();
420 } 410 }
421 411
422 sum = weight_adjust (this, sum); 412 sum = weight_adjust_for (this, sum);
423 413
424 if (sum != carrying) 414 if (sum != carrying)
425 { 415 {
426 carrying = sum; 416 carrying = sum;
427 417
489 */ 479 */
490object * 480object *
491find_object_name (const char *str) 481find_object_name (const char *str)
492{ 482{
493 shstr_cmp str_ (str); 483 shstr_cmp str_ (str);
494 object *op;
495 484
485 if (str_)
496 for_all_objects (op) 486 for_all_objects (op)
497 if (op->name == str_) 487 if (op->name == str_)
498 break; 488 return op;
499 489
500 return op; 490 return 0;
501} 491}
502 492
503/* 493/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 494 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 495 * skill and experience objects.
603 } 593 }
604 594
605 op->key_values = 0; 595 op->key_values = 0;
606} 596}
607 597
608object & 598/*
609object::operator =(const object &src) 599 * copy_to first frees everything allocated by the dst object,
600 * and then copies the contents of itself into the second
601 * object, allocating what needs to be allocated. Basically, any
602 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
603 * if the first object is freed, the pointers in the new object
604 * will point at garbage.
605 */
606void
607object::copy_to (object *dst)
610{ 608{
611 bool is_freed = flag [FLAG_FREED]; 609 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 610 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 611 dst->flag [FLAG_REMOVED] = true;
618 612
619 /* Copy over key_values, if any. */ 613 /* Copy over key_values, if any. */
620 if (src.key_values) 614 if (key_values)
621 { 615 {
622 key_value *tail = 0; 616 key_value *tail = 0;
623 key_values = 0; 617 dst->key_values = 0;
624 618
625 for (key_value *i = src.key_values; i; i = i->next) 619 for (key_value *i = key_values; i; i = i->next)
626 { 620 {
627 key_value *new_link = new key_value; 621 key_value *new_link = new key_value;
628 622
629 new_link->next = 0; 623 new_link->next = 0;
630 new_link->key = i->key; 624 new_link->key = i->key;
631 new_link->value = i->value; 625 new_link->value = i->value;
632 626
633 /* Try and be clever here, too. */ 627 /* Try and be clever here, too. */
634 if (!key_values) 628 if (!dst->key_values)
635 { 629 {
636 key_values = new_link; 630 dst->key_values = new_link;
637 tail = new_link; 631 tail = new_link;
638 } 632 }
639 else 633 else
640 { 634 {
641 tail->next = new_link; 635 tail->next = new_link;
642 tail = new_link; 636 tail = new_link;
643 } 637 }
644 } 638 }
645 } 639 }
646}
647
648/*
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660 640
661 if (speed < 0) 641 if (speed < 0)
662 dst->speed_left -= rndm (); 642 dst->speed_left -= rndm ();
663 643
664 dst->set_speed (dst->speed); 644 dst->set_speed (dst->speed);
686object * 666object *
687object::clone () 667object::clone ()
688{ 668{
689 object *neu = create (); 669 object *neu = create ();
690 copy_to (neu); 670 copy_to (neu);
671 neu->map = map; // not copied by copy_to
691 return neu; 672 return neu;
692} 673}
693 674
694/* 675/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 676 * If an object with the IS_TURNABLE() flag needs to be turned due
924 * drop on that space. 905 * drop on that space.
925 */ 906 */
926 if (!drop_to_ground 907 if (!drop_to_ground
927 || !map 908 || !map
928 || map->in_memory != MAP_ACTIVE 909 || map->in_memory != MAP_ACTIVE
929 || map->nodrop 910 || map->no_drop
930 || ms ().move_block == MOVE_ALL) 911 || ms ().move_block == MOVE_ALL)
931 { 912 {
932 while (inv) 913 while (inv)
933 { 914 {
934 inv->destroy_inv (false); 915 inv->destroy_inv (false);
959 object *op = new object; 940 object *op = new object;
960 op->link (); 941 op->link ();
961 return op; 942 return op;
962} 943}
963 944
945static struct freed_map : maptile
946{
947 freed_map ()
948 {
949 path = "<freed objects map>";
950 name = "/internal/freed_objects_map";
951 width = 3;
952 height = 3;
953 no_drop = 1;
954 no_reset = 1;
955
956 alloc ();
957 in_memory = MAP_ACTIVE;
958 }
959
960 ~freed_map ()
961 {
962 destroy ();
963 }
964} freed_map; // freed objects are moved here to avoid crashes
965
964void 966void
965object::do_destroy () 967object::do_destroy ()
966{ 968{
967 if (flag [FLAG_IS_LINKED]) 969 if (flag [FLAG_IS_LINKED])
968 remove_button_link (this); 970 remove_button_link (this);
978 unlink (); 980 unlink ();
979 981
980 flag [FLAG_FREED] = 1; 982 flag [FLAG_FREED] = 1;
981 983
982 // hack to ensure that freed objects still have a valid map 984 // hack to ensure that freed objects still have a valid map
983 {
984 static maptile *freed_map; // freed objects are moved here to avoid crashes
985
986 if (!freed_map)
987 {
988 freed_map = new maptile;
989
990 freed_map->path = "<freed objects map>";
991 freed_map->name = "/internal/freed_objects_map";
992 freed_map->width = 3;
993 freed_map->height = 3;
994 freed_map->nodrop = 1;
995
996 freed_map->alloc ();
997 freed_map->in_memory = MAP_ACTIVE;
998 }
999
1000 map = freed_map; 985 map = &freed_map;
1001 x = 1; 986 x = 1;
1002 y = 1; 987 y = 1;
1003 }
1004 988
1005 if (more) 989 if (more)
1006 { 990 {
1007 more->destroy (); 991 more->destroy ();
1008 more = 0; 992 more = 0;
1025 1009
1026 if (!is_head () && !head->destroyed ()) 1010 if (!is_head () && !head->destroyed ())
1027 { 1011 {
1028 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1012 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1029 head->destroy (destroy_inventory); 1013 head->destroy (destroy_inventory);
1014 return;
1030 } 1015 }
1031 1016
1032 destroy_inv (!destroy_inventory); 1017 destroy_inv (!destroy_inventory);
1033 1018
1034 if (is_head ()) 1019 if (is_head ())
1073 if (object *pl = visible_to ()) 1058 if (object *pl = visible_to ())
1074 esrv_del_item (pl->contr, count); 1059 esrv_del_item (pl->contr, count);
1075 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1060 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1076 1061
1077 adjust_weight (env, -total_weight ()); 1062 adjust_weight (env, -total_weight ());
1078
1079 *(above ? &above->below : &env->inv) = below;
1080
1081 if (below)
1082 below->above = above;
1083 1063
1084 /* we set up values so that it could be inserted into 1064 /* we set up values so that it could be inserted into
1085 * the map, but we don't actually do that - it is up 1065 * the map, but we don't actually do that - it is up
1086 * to the caller to decide what we want to do. 1066 * to the caller to decide what we want to do.
1087 */ 1067 */
1088 map = env->map; 1068 map = env->map;
1089 x = env->x; 1069 x = env->x;
1090 y = env->y; 1070 y = env->y;
1071
1072 // make sure cmov optimisation is applicable
1073 *(above ? &above->below : &env->inv) = below;
1074 *(below ? &below->above : &above ) = above; // &above is just a dummy
1075
1091 above = 0; 1076 above = 0;
1092 below = 0; 1077 below = 0;
1093 env = 0; 1078 env = 0;
1094 1079
1095 /* NO_FIX_PLAYER is set when a great many changes are being 1080 /* NO_FIX_PLAYER is set when a great many changes are being
1125 1110
1126 esrv_del_item (pl->contr, count); 1111 esrv_del_item (pl->contr, count);
1127 } 1112 }
1128 1113
1129 /* link the object above us */ 1114 /* link the object above us */
1130 if (above) 1115 // re-link, make sure compiler can easily use cmove
1131 above->below = below; 1116 *(above ? &above->below : &ms.top) = below;
1132 else 1117 *(below ? &below->above : &ms.bot) = above;
1133 ms.top = below; /* we were top, set new top */
1134
1135 /* Relink the object below us, if there is one */
1136 if (below)
1137 below->above = above;
1138 else
1139 {
1140 /* Nothing below, which means we need to relink map object for this space
1141 * use translated coordinates in case some oddness with map tiling is
1142 * evident
1143 */
1144 if (GET_MAP_OB (map, x, y) != this)
1145 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1146
1147 ms.bot = above; /* goes on above it. */
1148 }
1149 1118
1150 above = 0; 1119 above = 0;
1151 below = 0; 1120 below = 0;
1152 1121
1153 if (map->in_memory == MAP_SAVING) 1122 if (map->in_memory == MAP_SAVING)
1163 * appropriately. 1132 * appropriately.
1164 */ 1133 */
1165 pl->close_container (); 1134 pl->close_container ();
1166 1135
1167 //TODO: the floorbox prev/next might need updating 1136 //TODO: the floorbox prev/next might need updating
1168 esrv_del_item (pl->contr, count); 1137 //esrv_del_item (pl->contr, count);
1138 //TODO: update floorbox to preserve ordering
1139 if (pl->contr->ns)
1140 pl->contr->ns->floorbox_update ();
1169 } 1141 }
1170 1142
1171 for (tmp = ms.bot; tmp; tmp = tmp->above) 1143 for (tmp = ms.bot; tmp; tmp = tmp->above)
1172 { 1144 {
1173 /* No point updating the players look faces if he is the object 1145 /* No point updating the players look faces if he is the object
1265 * job preparing multi-part monsters. 1237 * job preparing multi-part monsters.
1266 */ 1238 */
1267object * 1239object *
1268insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1240insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1269{ 1241{
1242 op->remove ();
1243
1270 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1244 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1271 { 1245 {
1272 tmp->x = x + tmp->arch->x; 1246 tmp->x = x + tmp->arch->x;
1273 tmp->y = y + tmp->arch->y; 1247 tmp->y = y + tmp->arch->y;
1274 } 1248 }
1297 * just 'op' otherwise 1271 * just 'op' otherwise
1298 */ 1272 */
1299object * 1273object *
1300insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1274insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1301{ 1275{
1302 assert (!op->flag [FLAG_FREED]); 1276 if (op->is_on_map ())
1277 {
1278 LOG (llevError, "insert_ob_in_map called for object already on map");
1279 abort ();
1280 }
1303 1281
1282 if (op->env)
1283 {
1284 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1304 op->remove (); 1285 op->remove ();
1286 }
1287
1288 if (op->face && !face_info (op->face))//D TODO: remove soon
1289 {//D
1290 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
1291 op->face = 1;//D
1292 }//D
1305 1293
1306 /* Ideally, the caller figures this out. However, it complicates a lot 1294 /* Ideally, the caller figures this out. However, it complicates a lot
1307 * of areas of callers (eg, anything that uses find_free_spot would now 1295 * of areas of callers (eg, anything that uses find_free_spot would now
1308 * need extra work 1296 * need extra work
1309 */ 1297 */
1310 if (!xy_normalise (m, op->x, op->y)) 1298 if (!xy_normalise (m, op->x, op->y))
1311 { 1299 {
1312 op->destroy (1); 1300 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1313 return 0; 1301 return 0;
1314 } 1302 }
1315 1303
1316 if (object *more = op->more) 1304 if (object *more = op->more)
1317 if (!insert_ob_in_map (more, m, originator, flag)) 1305 if (!insert_ob_in_map (more, m, originator, flag))
1326 */ 1314 */
1327 if (op->nrof && !(flag & INS_NO_MERGE)) 1315 if (op->nrof && !(flag & INS_NO_MERGE))
1328 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1316 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1329 if (object::can_merge (op, tmp)) 1317 if (object::can_merge (op, tmp))
1330 { 1318 {
1331 // TODO: we atcually want to update tmp, not op, 1319 // TODO: we actually want to update tmp, not op,
1332 // but some caller surely breaks when we return tmp 1320 // but some caller surely breaks when we return tmp
1333 // from here :/ 1321 // from here :/
1334 op->nrof += tmp->nrof; 1322 op->nrof += tmp->nrof;
1335 tmp->destroy (1); 1323 tmp->destroy (1);
1336 } 1324 }
1347 { 1335 {
1348 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1336 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1349 abort (); 1337 abort ();
1350 } 1338 }
1351 1339
1340 if (!originator->is_on_map ())
1341 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1342 op->debug_desc (), originator->debug_desc ());
1343
1352 op->above = originator; 1344 op->above = originator;
1353 op->below = originator->below; 1345 op->below = originator->below;
1354
1355 if (op->below)
1356 op->below->above = op;
1357 else
1358 ms.bot = op;
1359
1360 /* since *below* originator, no need to update top */
1361 originator->below = op; 1346 originator->below = op;
1347
1348 *(op->below ? &op->below->above : &ms.bot) = op;
1362 } 1349 }
1363 else 1350 else
1364 { 1351 {
1365 object *top, *floor = NULL; 1352 object *floor = 0;
1366 1353 object *top = ms.top;
1367 top = ms.bot;
1368 1354
1369 /* If there are other objects, then */ 1355 /* If there are other objects, then */
1370 if (top) 1356 if (top)
1371 { 1357 {
1372 object *last = 0;
1373
1374 /* 1358 /*
1375 * If there are multiple objects on this space, we do some trickier handling. 1359 * If there are multiple objects on this space, we do some trickier handling.
1376 * We've already dealt with merging if appropriate. 1360 * We've already dealt with merging if appropriate.
1377 * Generally, we want to put the new object on top. But if 1361 * Generally, we want to put the new object on top. But if
1378 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1362 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1381 * once we get to them. This reduces the need to traverse over all of 1365 * once we get to them. This reduces the need to traverse over all of
1382 * them when adding another one - this saves quite a bit of cpu time 1366 * them when adding another one - this saves quite a bit of cpu time
1383 * when lots of spells are cast in one area. Currently, it is presumed 1367 * when lots of spells are cast in one area. Currently, it is presumed
1384 * that flying non pickable objects are spell objects. 1368 * that flying non pickable objects are spell objects.
1385 */ 1369 */
1386 for (top = ms.bot; top; top = top->above) 1370 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1387 { 1371 {
1388 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1372 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1389 floor = top; 1373 floor = tmp;
1390 1374
1391 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1375 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1392 { 1376 {
1393 /* We insert above top, so we want this object below this */ 1377 /* We insert above top, so we want this object below this */
1394 top = top->below; 1378 top = tmp->below;
1395 break; 1379 break;
1396 } 1380 }
1397 1381
1398 last = top; 1382 top = tmp;
1399 } 1383 }
1400
1401 /* Don't want top to be NULL, so set it to the last valid object */
1402 top = last;
1403 1384
1404 /* We let update_position deal with figuring out what the space 1385 /* We let update_position deal with figuring out what the space
1405 * looks like instead of lots of conditions here. 1386 * looks like instead of lots of conditions here.
1406 * makes things faster, and effectively the same result. 1387 * makes things faster, and effectively the same result.
1407 */ 1388 */
1414 */ 1395 */
1415 if (!(flag & INS_ON_TOP) 1396 if (!(flag & INS_ON_TOP)
1416 && ms.flags () & P_BLOCKSVIEW 1397 && ms.flags () & P_BLOCKSVIEW
1417 && (op->face && !faces [op->face].visibility)) 1398 && (op->face && !faces [op->face].visibility))
1418 { 1399 {
1400 object *last;
1401
1419 for (last = top; last != floor; last = last->below) 1402 for (last = top; last != floor; last = last->below)
1420 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1421 break; 1404 break;
1422 1405
1423 /* Check to see if we found the object that blocks view, 1406 /* Check to see if we found the object that blocks view,
1431 } /* If objects on this space */ 1414 } /* If objects on this space */
1432 1415
1433 if (flag & INS_ABOVE_FLOOR_ONLY) 1416 if (flag & INS_ABOVE_FLOOR_ONLY)
1434 top = floor; 1417 top = floor;
1435 1418
1436 /* Top is the object that our object (op) is going to get inserted above. 1419 // insert object above top, or bottom-most if top = 0
1437 */
1438
1439 /* First object on this space */
1440 if (!top) 1420 if (!top)
1441 { 1421 {
1422 op->below = 0;
1442 op->above = ms.bot; 1423 op->above = ms.bot;
1443
1444 if (op->above)
1445 op->above->below = op;
1446
1447 op->below = 0;
1448 ms.bot = op; 1424 ms.bot = op;
1425
1426 *(op->above ? &op->above->below : &ms.top) = op;
1449 } 1427 }
1450 else 1428 else
1451 { /* get inserted into the stack above top */ 1429 {
1452 op->above = top->above; 1430 op->above = top->above;
1453
1454 if (op->above)
1455 op->above->below = op; 1431 top->above = op;
1456 1432
1457 op->below = top; 1433 op->below = top;
1458 top->above = op; 1434 *(op->above ? &op->above->below : &ms.top) = op;
1459 } 1435 }
1460 1436 }
1461 if (!op->above)
1462 ms.top = op;
1463 } /* else not INS_BELOW_ORIGINATOR */
1464 1437
1465 if (op->type == PLAYER) 1438 if (op->type == PLAYER)
1466 { 1439 {
1467 op->contr->do_los = 1; 1440 op->contr->do_los = 1;
1468 ++op->map->players; 1441 ++op->map->players;
1471 1444
1472 op->map->dirty = true; 1445 op->map->dirty = true;
1473 1446
1474 if (object *pl = ms.player ()) 1447 if (object *pl = ms.player ())
1475 //TODO: the floorbox prev/next might need updating 1448 //TODO: the floorbox prev/next might need updating
1476 esrv_send_item (pl, op); 1449 //esrv_send_item (pl, op);
1450 //TODO: update floorbox to preserve ordering
1451 if (pl->contr->ns)
1452 pl->contr->ns->floorbox_update ();
1477 1453
1478 /* If this object glows, it may affect lighting conditions that are 1454 /* If this object glows, it may affect lighting conditions that are
1479 * visible to others on this map. But update_all_los is really 1455 * visible to others on this map. But update_all_los is really
1480 * an inefficient way to do this, as it means los for all players 1456 * an inefficient way to do this, as it means los for all players
1481 * on the map will get recalculated. The players could very well 1457 * on the map will get recalculated. The players could very well
1565 1541
1566 nrof -= nr; 1542 nrof -= nr;
1567 1543
1568 if (nrof) 1544 if (nrof)
1569 { 1545 {
1570 adjust_weight (env, -weight * nr); // carrying == 0 1546 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1571 1547
1572 if (object *pl = visible_to ()) 1548 if (object *pl = visible_to ())
1573 esrv_update_item (UPD_NROF, pl, this); 1549 esrv_update_item (UPD_NROF, pl, this);
1574 1550
1575 return true; 1551 return true;
1601 } 1577 }
1602 else 1578 else
1603 { 1579 {
1604 decrease (nr); 1580 decrease (nr);
1605 1581
1606 object *op = object_create_clone (this); 1582 object *op = deep_clone ();
1607 op->nrof = nr; 1583 op->nrof = nr;
1608 return op; 1584 return op;
1609 } 1585 }
1610} 1586}
1611 1587
1832 LOG (llevError, "Present_arch called outside map.\n"); 1808 LOG (llevError, "Present_arch called outside map.\n");
1833 return NULL; 1809 return NULL;
1834 } 1810 }
1835 1811
1836 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1812 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1837 if (tmp->arch == at) 1813 if (tmp->arch->archname == at->archname)
1838 return tmp; 1814 return tmp;
1839 1815
1840 return NULL; 1816 return NULL;
1841} 1817}
1842 1818
1906 * The first matching object is returned, or NULL if none. 1882 * The first matching object is returned, or NULL if none.
1907 */ 1883 */
1908object * 1884object *
1909present_arch_in_ob (const archetype *at, const object *op) 1885present_arch_in_ob (const archetype *at, const object *op)
1910{ 1886{
1911 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1887 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1912 if (tmp->arch == at) 1888 if (tmp->arch->archname == at->archname)
1913 return tmp; 1889 return tmp;
1914 1890
1915 return NULL; 1891 return NULL;
1916} 1892}
1917 1893
2326 2302
2327/* 2303/*
2328 * create clone from object to another 2304 * create clone from object to another
2329 */ 2305 */
2330object * 2306object *
2331object_create_clone (object *asrc) 2307object::deep_clone ()
2332{ 2308{
2333 object *dst = 0, *tmp, *src, *prev, *item; 2309 assert (("deep_clone called on non-head object", is_head ()));
2334 2310
2335 if (!asrc) 2311 object *dst = clone ();
2336 return 0;
2337 2312
2338 src = asrc->head_ (); 2313 object *prev = dst;
2339
2340 prev = 0;
2341 for (object *part = src; part; part = part->more) 2314 for (object *part = this->more; part; part = part->more)
2342 { 2315 {
2343 tmp = part->clone (); 2316 object *tmp = part->clone ();
2344 tmp->x -= src->x;
2345 tmp->y -= src->y;
2346
2347 if (!part->head)
2348 {
2349 dst = tmp;
2350 tmp->head = 0;
2351 }
2352 else
2353 tmp->head = dst; 2317 tmp->head = dst;
2354
2355 tmp->more = 0;
2356
2357 if (prev)
2358 prev->more = tmp; 2318 prev->more = tmp;
2359
2360 prev = tmp; 2319 prev = tmp;
2361 } 2320 }
2362 2321
2363 for (item = src->inv; item; item = item->below) 2322 for (object *item = inv; item; item = item->below)
2364 insert_ob_in_ob (object_create_clone (item), dst); 2323 insert_ob_in_ob (item->deep_clone (), dst);
2365 2324
2366 return dst; 2325 return dst;
2367} 2326}
2368 2327
2369/* This returns the first object in who's inventory that 2328/* This returns the first object in who's inventory that
2378 return tmp; 2337 return tmp;
2379 2338
2380 return 0; 2339 return 0;
2381} 2340}
2382 2341
2383/* If ob has a field named key, return the link from the list, 2342const shstr &
2384 * otherwise return NULL. 2343object::kv_get (const shstr &key) const
2385 *
2386 * key must be a passed in shared string - otherwise, this won't
2387 * do the desired thing.
2388 */
2389key_value *
2390get_ob_key_link (const object *ob, const char *key)
2391{ 2344{
2392 for (key_value *link = ob->key_values; link; link = link->next) 2345 for (key_value *kv = key_values; kv; kv = kv->next)
2393 if (link->key == key) 2346 if (kv->key == key)
2394 return link;
2395
2396 return 0;
2397}
2398
2399/*
2400 * Returns the value of op has an extra_field for key, or NULL.
2401 *
2402 * The argument doesn't need to be a shared string.
2403 *
2404 * The returned string is shared.
2405 */
2406const char *
2407get_ob_key_value (const object *op, const char *const key)
2408{
2409 key_value *link;
2410 shstr_cmp canonical_key (key);
2411
2412 if (!canonical_key)
2413 {
2414 /* 1. There being a field named key on any object
2415 * implies there'd be a shared string to find.
2416 * 2. Since there isn't, no object has this field.
2417 * 3. Therefore, *this* object doesn't have this field.
2418 */
2419 return 0;
2420 }
2421
2422 /* This is copied from get_ob_key_link() above -
2423 * only 4 lines, and saves the function call overhead.
2424 */
2425 for (link = op->key_values; link; link = link->next)
2426 if (link->key == canonical_key)
2427 return link->value; 2347 return kv->value;
2428 2348
2429 return 0; 2349 return shstr_null;
2430} 2350}
2431 2351
2432/* 2352void
2433 * Updates the canonical_key in op to value. 2353object::kv_set (const shstr &key, const shstr &value)
2434 *
2435 * canonical_key is a shared string (value doesn't have to be).
2436 *
2437 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2438 * keys.
2439 *
2440 * Returns TRUE on success.
2441 */
2442int
2443set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2444{ 2354{
2445 key_value *field = NULL, *last = NULL; 2355 for (key_value *kv = key_values; kv; kv = kv->next)
2446 2356 if (kv->key == key)
2447 for (field = op->key_values; field != NULL; field = field->next)
2448 {
2449 if (field->key != canonical_key)
2450 { 2357 {
2451 last = field; 2358 kv->value = value;
2452 continue; 2359 return;
2453 } 2360 }
2454 2361
2455 if (value) 2362 key_value *kv = new key_value;
2456 field->value = value; 2363
2457 else 2364 kv->next = key_values;
2365 kv->key = key;
2366 kv->value = value;
2367
2368 key_values = kv;
2369}
2370
2371void
2372object::kv_del (const shstr &key)
2373{
2374 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2375 if ((*kvp)->key == key)
2458 { 2376 {
2459 /* Basically, if the archetype has this key set, 2377 key_value *kv = *kvp;
2460 * we need to store the null value so when we save 2378 *kvp = (*kvp)->next;
2461 * it, we save the empty value so that when we load, 2379 delete kv;
2462 * we get this value back again. 2380 return;
2463 */
2464 if (get_ob_key_link (op->arch, canonical_key))
2465 field->value = 0;
2466 else
2467 {
2468 if (last)
2469 last->next = field->next;
2470 else
2471 op->key_values = field->next;
2472
2473 delete field;
2474 }
2475 } 2381 }
2476 return TRUE;
2477 }
2478 /* IF we get here, key doesn't exist */
2479
2480 /* No field, we'll have to add it. */
2481
2482 if (!add_key)
2483 return FALSE;
2484
2485 /* There isn't any good reason to store a null
2486 * value in the key/value list. If the archetype has
2487 * this key, then we should also have it, so shouldn't
2488 * be here. If user wants to store empty strings,
2489 * should pass in ""
2490 */
2491 if (value == NULL)
2492 return TRUE;
2493
2494 field = new key_value;
2495
2496 field->key = canonical_key;
2497 field->value = value;
2498 /* Usual prepend-addition. */
2499 field->next = op->key_values;
2500 op->key_values = field;
2501
2502 return TRUE;
2503}
2504
2505/*
2506 * Updates the key in op to value.
2507 *
2508 * If add_key is FALSE, this will only update existing keys,
2509 * and not add new ones.
2510 * In general, should be little reason FALSE is ever passed in for add_key
2511 *
2512 * Returns TRUE on success.
2513 */
2514int
2515set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2516{
2517 shstr key_ (key);
2518
2519 return set_ob_key_value_s (op, key_, value, add_key);
2520} 2382}
2521 2383
2522object::depth_iterator::depth_iterator (object *container) 2384object::depth_iterator::depth_iterator (object *container)
2523: iterator_base (container) 2385: iterator_base (container)
2524{ 2386{
2574{ 2436{
2575 char flagdesc[512]; 2437 char flagdesc[512];
2576 char info2[256 * 4]; 2438 char info2[256 * 4];
2577 char *p = info; 2439 char *p = info;
2578 2440
2579 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2441 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2580 count, 2442 count,
2581 uuid.c_str (), 2443 uuid.c_str (),
2582 &name, 2444 &name,
2583 title ? "\",title:\"" : "", 2445 title ? ",title:\"" : "",
2584 title ? (const char *)title : "", 2446 title ? (const char *)title : "",
2447 title ? "\"" : "",
2585 flag_desc (flagdesc, 512), type); 2448 flag_desc (flagdesc, 512), type);
2586 2449
2587 if (!flag[FLAG_REMOVED] && env) 2450 if (!flag[FLAG_REMOVED] && env)
2588 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2451 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2589 2452

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines