ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.225 by root, Fri May 2 20:28:44 2008 UTC vs.
Revision 1.297 by root, Sat Nov 7 18:30:05 2009 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
…		…
32	#include <bitset>	33	#include <bitset>
33		34
34	UUID UUID::cur;	35	UUID UUID::cur;
35	static uint64_t seq_next_save;	36	static uint64_t seq_next_save;
36	static const uint64 UUID_GAP = 1<<19;	37	static const uint64 UUID_GAP = 1<<19;
		38	uint32_t mapspace::smellcount = 10000;
37		39
38	objectvec objects;	40	objectvec objects;
39	activevec actives;	41	activevec actives;
		42
		43	//+GPL
40		44
41	short freearr_x[SIZEOFFREE] = {	45	short freearr_x[SIZEOFFREE] = {
42	0,	46	0,
43	0, 1, 1, 1, 0, -1, -1, -1,	47	0, 1, 1, 1, 0, -1, -1, -1,
44	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	48	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
…		…
48	0,	52	0,
49	-1, -1, 0, 1, 1, 1, 0, -1,	53	-1, -1, 0, 1, 1, 1, 0, -1,
50	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	54	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	55	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52	};	56	};
53	int maxfree[SIZEOFFREE] = {
54	0,
55	9, 10, 13, 14, 17, 18, 21, 22,
56	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58	};
59	int freedir[SIZEOFFREE] = {	57	int freedir[SIZEOFFREE] = {
60	0,	58	0,
61	1, 2, 3, 4, 5, 6, 7, 8,	59	1, 2, 3, 4, 5, 6, 7, 8,
62	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	60	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	61	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
		62	};
		63
		64	static int maxfree[SIZEOFFREE] = {
		65	0,
		66	9, 10, 13, 14, 17, 18, 21, 22,
		67	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
		68	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64	};	69	};
65		70
66	static void	71	static void
67	write_uuid (uval64 skip, bool sync)	72	write_uuid (uval64 skip, bool sync)
68	{	73	{
…		…
139		144
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	145	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	146	static bool
142	compare_ob_value_lists_one (const object *wants, const object *has)	147	compare_ob_value_lists_one (const object *wants, const object *has)
143	{	148	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	149	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	150	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	151	* different structure or at least keep the lists sorted...
149	*/	152	*/
150		153
151	/* For each field in wants, */	154	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	155	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	156	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	157	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		158
169	/* If we get here, every field in wants has a matching field in has. */	159	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	160	return true;
171	}	161	}
172		162
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	163	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	164	static bool
175	compare_ob_value_lists (const object *ob1, const object *ob2)	165	compare_ob_value_lists (const object *ob1, const object *ob2)
176	{	166	{
177	/* However, there may be fields in has which aren't partnered in wants,	167	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison *twice*. :(	168	* so we need to run the comparison *twice*. :(
179	*/	169	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	170	return compare_ob_value_lists_one (ob1, ob2)
		171	&& compare_ob_value_lists_one (ob2, ob1);
181	}	172	}
182		173
183	/* Function examines the 2 objects given to it, and returns true if	174	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	175	* they can be merged together.
185	*	176	*
…		…
195	bool object::can_merge_slow (object *ob1, object *ob2)	186	bool object::can_merge_slow (object *ob1, object *ob2)
196	{	187	{
197	/* A couple quicksanity checks */	188	/* A couple quicksanity checks */
198	if (ob1 == ob2	189	if (ob1 == ob2
199	|| ob1->type != ob2->type	190	|| ob1->type != ob2->type
200	|| ob1->speed != ob2->speed	191	|| fabs (ob1->speed - ob2->speed) < MIN_ACTIVE_SPEED
201	|| ob1->value != ob2->value	192	|| ob1->value != ob2->value
202	|| ob1->name != ob2->name)	193	|| ob1->name != ob2->name)
203	return 0;	194	return 0;
204		195
205	/* Do not merge objects if nrof would overflow. First part checks	196	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	197	* is always 0 .. 2**31-1 */
207	* would fit into a 32 bit signed int, which is often used to hold	198	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	199	return 0;
212		200
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	201	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	202	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	203	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	208	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		209
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	210	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	211	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		212
225	if (ob1->arch->name != ob2->arch->name	213	if (ob1->arch->archname != ob2->arch->archname
226	|| ob1->name != ob2->name	214	|| ob1->name != ob2->name
227	|| ob1->title != ob2->title	215	|| ob1->title != ob2->title
228	|| ob1->msg != ob2->msg	216	|| ob1->msg != ob2->msg
229	|| ob1->weight != ob2->weight	217	|| ob1->weight != ob2->weight
230	|| ob1->attacktype != ob2->attacktype	218	|| ob1->attacktype != ob2->attacktype
231	|| ob1->magic != ob2->magic	219	|| ob1->magic != ob2->magic
232	|| ob1->slaying != ob2->slaying	220	|| ob1->slaying != ob2->slaying
233	|| ob1->skill != ob2->skill	221	|| ob1->skill != ob2->skill
234	|| ob1->value != ob2->value	222	|| ob1->value != ob2->value
235	|| ob1->animation_id != ob2->animation_id	223	|| ob1->animation_id != ob2->animation_id
		224	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	|| ob1->client_type != ob2->client_type	225	|| ob1->client_type != ob2->client_type
237	|| ob1->materialname != ob2->materialname	226	|| ob1->materialname != ob2->materialname
238	|| ob1->lore != ob2->lore	227	|| ob1->lore != ob2->lore
239	|| ob1->subtype != ob2->subtype	228	|| ob1->subtype != ob2->subtype
240	|| ob1->move_type != ob2->move_type	229	|| ob1->move_type != ob2->move_type
241	|| ob1->move_block != ob2->move_block	230	|| ob1->move_block != ob2->move_block
242	|| ob1->move_allow != ob2->move_allow	231	|| ob1->move_allow != ob2->move_allow
243	|| ob1->move_on != ob2->move_on	232	|| ob1->move_on != ob2->move_on
244	|| ob1->move_off != ob2->move_off	233	|| ob1->move_off != ob2->move_off
245	|| ob1->move_slow != ob2->move_slow	234	|| ob1->move_slow != ob2->move_slow
246	|| ob1->move_slow_penalty != ob2->move_slow_penalty	235	|| fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) < (1.f / 1024.f)
247	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))	236	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	237	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	238	return 0;
250		239
251	if ((ob1->flag ^ ob2->flag)	240	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	241	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	242	.reset (FLAG_REMOVED)
255	.any ())	243	.any ())
256	return 0;	244	return 0;
257		245
258	/* This is really a spellbook check - we should in general	246	/* This is really a spellbook check - we should in general
…		…
340	{	328	{
341	// see if we are in a container of sorts	329	// see if we are in a container of sorts
342	if (env)	330	if (env)
343	{	331	{
344	// the player inventory itself is always visible	332	// the player inventory itself is always visible
345	if (env->type == PLAYER)	333	if (env->is_player ())
346	return env;	334	return env;
347		335
348	// else a player could have our env open	336	// else a player could have our env open
349	object *envest = env->outer_env ();	337	object *envest = env->outer_env_or_self ();
350		338
351	// the player itself is always on a map, so we will find him here	339	// the player itself is always on a map, so we will find him here
352	// even if our inv is in a player.	340	// even if our inv is in a player.
353	if (envest->is_on_map ())	341	if (envest->is_on_map ())
354	if (object *pl = envest->ms ().player ())	342	if (object *pl = envest->ms ().player ())
355	if (pl->container == env)	343	if (pl->container_ () == env)
356	return pl;	344	return pl;
357	}	345	}
358	else	346	else
359	{	347	{
360	// maybe there is a player standing on the same mapspace	348	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	349	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	350	if (object *pl = ms ().player ())
363	if (!pl->container || this == pl->container)	351	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		352	|| pl->container_ () == this)
364	return pl;	353	return pl;
365	}	354	}
366	}	355	}
367		356
368	return 0;	357	return 0;
369	}	358	}
370		359
371	// adjust weight per container type ("of holding")	360	// adjust weight per container type ("of holding")
372	static sint32	361	static sint32
373	weight_adjust (object *op, sint32 weight)	362	weight_adjust_for (object *op, sint32 weight)
374	{	363	{
375	return op->type == CONTAINER	364	return op->type == CONTAINER
376	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	365	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377	: weight;	366	: weight;
378	}	367	}
…		…
384	static void	373	static void
385	adjust_weight (object *op, sint32 weight)	374	adjust_weight (object *op, sint32 weight)
386	{	375	{
387	while (op)	376	while (op)
388	{	377	{
		378	// adjust by actual difference to account for rounding errors
		379	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389	weight = weight_adjust (op, weight);	380	weight = weight_adjust_for (op, op->carrying)
		381	- weight_adjust_for (op, op->carrying - weight);
390		382
391	if (!weight)	383	if (!weight)
392	return;	384	return;
393		385
394	op->carrying += weight;	386	op->carrying += weight;
…		…
417	op->update_weight ();	409	op->update_weight ();
418		410
419	sum += op->total_weight ();	411	sum += op->total_weight ();
420	}	412	}
421		413
422	sum = weight_adjust (this, sum);	414	sum = weight_adjust_for (this, sum);
423		415
424	if (sum != carrying)	416	if (sum != carrying)
425	{	417	{
426	carrying = sum;	418	carrying = sum;
427		419
…		…
443	object_freezer freezer;	435	object_freezer freezer;
444	op->write (freezer);	436	op->write (freezer);
445	return freezer.as_string ();	437	return freezer.as_string ();
446	}	438	}
447		439
448	/*	440	char *
449	* get_nearest_part(multi-object, object 2) returns the part of the	441	object::as_string ()
450	* multi-object 1 which is closest to the second object.
451	* If it's not a multi-object, it is returned.
452	*/
453	object *
454	get_nearest_part (object *op, const object *pl)
455	{	442	{
456	object *tmp, *closest;	443	return dump_object (this);
457	int last_dist, i;
458
459	if (!op->more)
460	return op;
461
462	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
463	tmp;
464	tmp = tmp->more)
465	if ((i = distance (tmp, pl)) < last_dist)
466	closest = tmp, last_dist = i;
467
468	return closest;
469	}	444	}
470		445
471	/*	446	/*
472	* Returns the object which has the count-variable equal to the argument.	447	* Returns the object which has the count-variable equal to the argument.
473	* VERRRY slow.	448	* VERRRY slow.
…		…
489	*/	464	*/
490	object *	465	object *
491	find_object_name (const char *str)	466	find_object_name (const char *str)
492	{	467	{
493	shstr_cmp str_ (str);	468	shstr_cmp str_ (str);
494	object *op;
495		469
		470	if (str_)
496	for_all_objects (op)	471	for_all_objects (op)
497	if (op->name == str_)	472	if (op->name == str_)
498	break;	473	return op;
499		474
500	return op;	475	return 0;
501	}	476	}
502		477
503	/*	478	/*
504	* Sets the owner and sets the skill and exp pointers to owner's current	479	* Sets the owner and sets the skill and exp pointers to owner's current
505	* skill and experience objects.	480	* skill and experience objects.
…		…
567	update_stats ();	542	update_stats ();
568		543
569	new_draw_info_format (NDI_UNIQUE, 0, this,	544	new_draw_info_format (NDI_UNIQUE, 0, this,
570	"You try to balance all your items at once, "	545	"You try to balance all your items at once, "
571	"but the %s is just too much for your body. "	546	"but the %s is just too much for your body. "
572	"[You need to unapply some items first.]", &ob->name);	547	"[You need to unapply some items first - use the 'body' command to see "
		548	"how many items you cna wera on a specific body part.]", &ob->name);
573	return false;	549	return false;
574	}	550	}
575		551
576	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);	552	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577	}	553	}
…		…
603	}	579	}
604		580
605	op->key_values = 0;	581	op->key_values = 0;
606	}	582	}
607		583
608	object &	584	/*
609	object::operator =(const object &src)	585	* copy_to first frees everything allocated by the dst object,
		586	* and then copies the contents of itself into the second
		587	* object, allocating what needs to be allocated. Basically, any
		588	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		589	* if the first object is freed, the pointers in the new object
		590	* will point at garbage.
		591	*/
		592	void
		593	object::copy_to (object *dst)
610	{	594	{
611	remove ();	595	dst->remove ();
612
613	*(object_copy *)this = src;	596	*(object_copy *)dst = *this;
614
615	flag [FLAG_REMOVED] = true;	597	dst->flag [FLAG_REMOVED] = true;
616		598
617	/* Copy over key_values, if any. */	599	/* Copy over key_values, if any. */
618	if (src.key_values)	600	if (key_values)
619	{	601	{
620	key_value *tail = 0;	602	key_value *tail = 0;
621	key_values = 0;	603	dst->key_values = 0;
622		604
623	for (key_value *i = src.key_values; i; i = i->next)	605	for (key_value *i = key_values; i; i = i->next)
624	{	606	{
625	key_value *new_link = new key_value;	607	key_value *new_link = new key_value;
626		608
627	new_link->next = 0;	609	new_link->next = 0;
628	new_link->key = i->key;	610	new_link->key = i->key;
629	new_link->value = i->value;	611	new_link->value = i->value;
630		612
631	/* Try and be clever here, too. */	613	/* Try and be clever here, too. */
632	if (!key_values)	614	if (!dst->key_values)
633	{	615	{
634	key_values = new_link;	616	dst->key_values = new_link;
635	tail = new_link;	617	tail = new_link;
636	}	618	}
637	else	619	else
638	{	620	{
639	tail->next = new_link;	621	tail->next = new_link;
640	tail = new_link;	622	tail = new_link;
641	}	623	}
642	}	624	}
643	}	625	}
644	}
645
646	/*
647	* copy_to first frees everything allocated by the dst object,
648	* and then copies the contents of itself into the second
649	* object, allocating what needs to be allocated. Basically, any
650	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
651	* if the first object is freed, the pointers in the new object
652	* will point at garbage.
653	*/
654	void
655	object::copy_to (object *dst)
656	{
657	*dst = *this;
658		626
659	if (speed < 0)	627	if (speed < 0)
660	dst->speed_left -= rndm ();	628	dst->speed_left -= rndm ();
661		629
662	dst->set_speed (dst->speed);	630	dst->activate ();
663	}	631	}
664		632
665	void	633	void
666	object::instantiate ()	634	object::instantiate ()
667	{	635	{
…		…
711	* This function needs to be called whenever the speed of an object changes.	679	* This function needs to be called whenever the speed of an object changes.
712	*/	680	*/
713	void	681	void
714	object::set_speed (float speed)	682	object::set_speed (float speed)
715	{	683	{
716	if (flag [FLAG_FREED] && speed)
717	{
718	LOG (llevError, "Object %s is freed but has speed.\n", &name);
719	speed = 0;
720	}
721
722	this->speed = speed;	684	this->speed = speed;
723		685
724	if (has_active_speed ())	686	if (has_active_speed ())
725	activate ();	687	activate ();
726	else	688	else
…		…
776		738
777	if (!(m.flags_ & P_UPTODATE))	739	if (!(m.flags_ & P_UPTODATE))
778	/* nop */;	740	/* nop */;
779	else if (action == UP_OBJ_INSERT)	741	else if (action == UP_OBJ_INSERT)
780	{	742	{
		743	#if 0
781	// this is likely overkill, TODO: revisit (schmorp)	744	// this is likely overkill, TODO: revisit (schmorp)
782	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	745	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
783	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	746	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
784	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	747	|| (op->is_player () && !(m.flags_ & P_PLAYER))
785	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	748	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
786	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	749	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
787	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	750	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
788	|| (m.move_on | op->move_on ) != m.move_on	751	|| (m.move_on | op->move_on ) != m.move_on
789	|| (m.move_off | op->move_off ) != m.move_off	752	|| (m.move_off | op->move_off ) != m.move_off
790	|| (m.move_slow | op->move_slow) != m.move_slow	753	|| (m.move_slow | op->move_slow) != m.move_slow
791	/* This isn't perfect, but I don't expect a lot of objects to	754	/* This isn't perfect, but I don't expect a lot of objects to
792	* to have move_allow right now.	755	* have move_allow right now.
793	*/	756	*/
794	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	757	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
		758	m.invalidate ();
		759	#else
795	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	760	// the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
796	m.flags_ = 0;	761	m.invalidate ();
		762	#endif
797	}	763	}
798	/* if the object is being removed, we can't make intelligent	764	/* if the object is being removed, we can't make intelligent
799	* decisions, because remove_ob can't really pass the object	765	* decisions, because remove_ob can't really pass the object
800	* that is being removed.	766	* that is being removed.
801	*/	767	*/
802	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	768	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
803	m.flags_ = 0;	769	m.invalidate ();
804	else if (action == UP_OBJ_FACE)	770	else if (action == UP_OBJ_FACE)
805	/* Nothing to do for that case */ ;	771	/* Nothing to do for that case */ ;
806	else	772	else
807	LOG (llevError, "update_object called with invalid action: %d\n", action);	773	LOG (llevError, "update_object called with invalid action: %d\n", action);
808		774
…		…
812		778
813	object::object ()	779	object::object ()
814	{	780	{
815	SET_FLAG (this, FLAG_REMOVED);	781	SET_FLAG (this, FLAG_REMOVED);
816		782
817	expmul = 1.0;	783	//expmul = 1.0; declared const for the time being
818	face = blank_face;	784	face = blank_face;
819	}	785	}
820		786
821	object::~object ()	787	object::~object ()
822	{	788	{
…		…
852	/* If already on active list, don't do anything */	818	/* If already on active list, don't do anything */
853	if (active)	819	if (active)
854	return;	820	return;
855		821
856	if (has_active_speed ())	822	if (has_active_speed ())
		823	{
		824	if (flag [FLAG_FREED])
		825	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		826
857	actives.insert (this);	827	actives.insert (this);
		828	}
858	}	829	}
859		830
860	void	831	void
861	object::activate_recursive ()	832	object::activate_recursive ()
862	{	833	{
…		…
923	* drop on that space.	894	* drop on that space.
924	*/	895	*/
925	if (!drop_to_ground	896	if (!drop_to_ground
926	|| !map	897	|| !map
927	|| map->in_memory != MAP_ACTIVE	898	|| map->in_memory != MAP_ACTIVE
928	|| map->nodrop	899	|| map->no_drop
929	|| ms ().move_block == MOVE_ALL)	900	|| ms ().move_block == MOVE_ALL)
930	{	901	{
931	while (inv)	902	while (inv)
932	{
933	inv->destroy_inv (false);
934	inv->destroy ();	903	inv->destroy ();
935	}
936	}	904	}
937	else	905	else
938	{ /* Put objects in inventory onto this space */	906	{ /* Put objects in inventory onto this space */
939	while (inv)	907	while (inv)
940	{	908	{
…		…
944	|| op->flag [FLAG_NO_DROP]	912	|| op->flag [FLAG_NO_DROP]
945	|| op->type == RUNE	913	|| op->type == RUNE
946	|| op->type == TRAP	914	|| op->type == TRAP
947	|| op->flag [FLAG_IS_A_TEMPLATE]	915	|| op->flag [FLAG_IS_A_TEMPLATE]
948	|| op->flag [FLAG_DESTROY_ON_DEATH])	916	|| op->flag [FLAG_DESTROY_ON_DEATH])
949	op->destroy (true);	917	op->destroy ();
950	else	918	else
951	map->insert (op, x, y);	919	map->insert (op, x, y);
952	}	920	}
953	}	921	}
954	}	922	}
…		…
962		930
963	static struct freed_map : maptile	931	static struct freed_map : maptile
964	{	932	{
965	freed_map ()	933	freed_map ()
966	{	934	{
967	path = "<freed objects map>";	935	path = "<freed objects map>";
968	name = "/internal/freed_objects_map";	936	name = "/internal/freed_objects_map";
969	width = 3;	937	width = 3;
970	height = 3;	938	height = 3;
971	nodrop = 1;	939	no_drop = 1;
		940	no_reset = 1;
972		941
973	alloc ();	942	alloc ();
974	in_memory = MAP_ACTIVE;	943	in_memory = MAP_ACTIVE;
975	}	944	}
		945
		946	~freed_map ()
		947	{
		948	destroy ();
		949	}
976	} freed_map; // freed objects are moved here to avoid crashes	950	} freed_map; // freed objects are moved here to avoid crashes
977		951
978	void	952	void
979	object::do_destroy ()	953	object::do_destroy ()
980	{	954	{
981	if (flag [FLAG_IS_LINKED])	955	if (flag [FLAG_IS_LINKED])
982	remove_button_link (this);	956	remove_link ();
983		957
984	if (flag [FLAG_FRIENDLY])	958	if (flag [FLAG_FRIENDLY])
985	remove_friendly_object (this);	959	remove_friendly_object (this);
986		960
987	remove ();	961	remove ();
…		…
1012	attacked_by = 0;	986	attacked_by = 0;
1013	current_weapon = 0;	987	current_weapon = 0;
1014	}	988	}
1015		989
1016	void	990	void
1017	object::destroy (bool destroy_inventory)	991	object::destroy ()
1018	{	992	{
1019	if (destroyed ())	993	if (destroyed ())
1020	return;	994	return;
1021		995
1022	if (!is_head () && !head->destroyed ())	996	if (!is_head () && !head->destroyed ())
1023	{	997	{
1024	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");	998	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1025	head->destroy (destroy_inventory);	999	head->destroy ();
1026	return;	1000	return;
1027	}	1001	}
1028		1002
1029	destroy_inv (!destroy_inventory);	1003	destroy_inv (false);
1030		1004
1031	if (is_head ())	1005	if (is_head ())
1032	if (sound_destroy)	1006	if (sound_destroy)
1033	play_sound (sound_destroy);	1007	play_sound (sound_destroy);
1034	else if (flag [FLAG_MONSTER])	1008	else if (flag [FLAG_MONSTER])
…		…
1045	* the previous environment.	1019	* the previous environment.
1046	*/	1020	*/
1047	void	1021	void
1048	object::do_remove ()	1022	object::do_remove ()
1049	{	1023	{
1050	object *tmp, *last = 0;
1051	object *otmp;
1052
1053	if (flag [FLAG_REMOVED])	1024	if (flag [FLAG_REMOVED])
1054	return;	1025	return;
1055		1026
1056	INVOKE_OBJECT (REMOVE, this);	1027	INVOKE_OBJECT (REMOVE, this);
1057		1028
…		…
1071	esrv_del_item (pl->contr, count);	1042	esrv_del_item (pl->contr, count);
1072	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed	1043	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1073		1044
1074	adjust_weight (env, -total_weight ());	1045	adjust_weight (env, -total_weight ());
1075		1046
1076	*(above ? &above->below : &env->inv) = below;	1047	object *pl = in_player ();
1077
1078	if (below)
1079	below->above = above;
1080		1048
1081	/* we set up values so that it could be inserted into	1049	/* we set up values so that it could be inserted into
1082	* the map, but we don't actually do that - it is up	1050	* the map, but we don't actually do that - it is up
1083	* to the caller to decide what we want to do.	1051	* to the caller to decide what we want to do.
1084	*/	1052	*/
1085	map = env->map;	1053	map = env->map;
1086	x = env->x;	1054	x = env->x;
1087	y = env->y;	1055	y = env->y;
		1056
		1057	// make sure cmov optimisation is applicable
		1058	*(above ? &above->below : &env->inv) = below;
		1059	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1060
1088	above = 0;	1061	above = 0;
1089	below = 0;	1062	below = 0;
1090	env = 0;	1063	env = 0;
1091		1064
1092	/* NO_FIX_PLAYER is set when a great many changes are being	1065	/* NO_FIX_PLAYER is set when a great many changes are being
1093	* made to players inventory. If set, avoiding the call	1066	* made to players inventory. If set, avoiding the call
1094	* to save cpu time.	1067	* to save cpu time.
1095	*/	1068	*/
1096	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1069	if (pl)
		1070	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1071	{
1097	otmp->update_stats ();	1072	pl->update_stats ();
		1073
		1074	if (glow_radius && pl->is_on_map ())
		1075	update_all_los (pl->map, pl->x, pl->y);
		1076	}
1098	}	1077	}
1099	else if (map)	1078	else if (map)
1100	{	1079	{
1101	map->dirty = true;	1080	map->dirty = true;
1102	mapspace &ms = this->ms ();	1081	mapspace &ms = this->ms ();
1103		1082
1104	if (object *pl = ms.player ())	1083	if (object *pl = ms.player ())
1105	{	1084	{
1106	if (type == PLAYER) // this == pl(!)	1085	if (is_player ())
1107	{	1086	{
		1087	if (!flag [FLAG_WIZPASS])
		1088	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1089
1108	// leaving a spot always closes any open container on the ground	1090	// leaving a spot always closes any open container on the ground
1109	if (container && !container->env)	1091	if (container && !container->env)
1110	// this causes spurious floorbox updates, but it ensures	1092	// this causes spurious floorbox updates, but it ensures
1111	// that the CLOSE event is being sent.	1093	// that the CLOSE event is being sent.
1112	close_container ();	1094	close_container ();
1113		1095
1114	--map->players;	1096	--map->players;
1115	map->touch ();	1097	map->touch ();
1116	}	1098	}
1117	else if (pl->container == this)	1099	else if (pl->container_ () == this)
1118	{	1100	{
1119	// removing a container should close it	1101	// removing a container should close it
1120	close_container ();	1102	close_container ();
1121	}	1103	}
1122		1104
1123	esrv_del_item (pl->contr, count);	1105	esrv_del_item (pl->contr, count);
1124	}	1106	}
1125		1107
1126	/* link the object above us */	1108	/* link the object above us */
1127	if (above)	1109	// re-link, make sure compiler can easily use cmove
1128	above->below = below;	1110	*(above ? &above->below : &ms.top) = below;
1129	else	1111	*(below ? &below->above : &ms.bot) = above;
1130	ms.top = below; /* we were top, set new top */
1131
1132	/* Relink the object below us, if there is one */
1133	if (below)
1134	below->above = above;
1135	else
1136	{
1137	/* Nothing below, which means we need to relink map object for this space
1138	* use translated coordinates in case some oddness with map tiling is
1139	* evident
1140	*/
1141	if (GET_MAP_OB (map, x, y) != this)
1142	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1143
1144	ms.bot = above; /* goes on above it. */
1145	}
1146		1112
1147	above = 0;	1113	above = 0;
1148	below = 0;	1114	below = 0;
1149		1115
		1116	ms.invalidate ();
		1117
1150	if (map->in_memory == MAP_SAVING)	1118	if (map->in_memory == MAP_SAVING)
1151	return;	1119	return;
1152		1120
1153	int check_walk_off = !flag [FLAG_NO_APPLY];	1121	int check_walk_off = !flag [FLAG_NO_APPLY];
1154		1122
1155	if (object *pl = ms.player ())	1123	if (object *pl = ms.player ())
1156	{	1124	{
1157	if (pl->container == this)	1125	if (pl->container_ () == this)
1158	/* If a container that the player is currently using somehow gets	1126	/* If a container that the player is currently using somehow gets
1159	* removed (most likely destroyed), update the player view	1127	* removed (most likely destroyed), update the player view
1160	* appropriately.	1128	* appropriately.
1161	*/	1129	*/
1162	pl->close_container ();	1130	pl->close_container ();
1163		1131
1164	//TODO: the floorbox prev/next might need updating	1132	//TODO: the floorbox prev/next might need updating
1165	esrv_del_item (pl->contr, count);	1133	//esrv_del_item (pl->contr, count);
		1134	//TODO: update floorbox to preserve ordering
		1135	if (pl->contr->ns)
		1136	pl->contr->ns->floorbox_update ();
1166	}	1137	}
1167		1138
		1139	if (check_walk_off)
1168	for (tmp = ms.bot; tmp; tmp = tmp->above)	1140	for (object *above, *tmp = ms.bot; tmp; tmp = above)
1169	{	1141	{
		1142	above = tmp->above;
		1143
1170	/* No point updating the players look faces if he is the object	1144	/* No point updating the players look faces if he is the object
1171	* being removed.	1145	* being removed.
1172	*/	1146	*/
1173		1147
1174	/* See if object moving off should effect something */	1148	/* See if object moving off should effect something */
1175	if (check_walk_off
1176	&& ((move_type & tmp->move_off)	1149	if ((move_type & tmp->move_off)
1177	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1150	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1178	{
1179	move_apply (tmp, this, 0);	1151	move_apply (tmp, this, 0);
1180
1181	if (destroyed ())
1182	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1183	}	1152	}
1184		1153
1185	last = tmp;	1154	if (affects_los ())
1186	}
1187
1188	/* last == NULL if there are no objects on this space */
1189	//TODO: this makes little sense, why only update the topmost object?
1190	if (!last)
1191	map->at (x, y).flags_ = 0;
1192	else
1193	update_object (last, UP_OBJ_REMOVE);
1194
1195	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1196	update_all_los (map, x, y);	1155	update_all_los (map, x, y);
1197	}	1156	}
1198	}	1157	}
1199		1158
1200	/*	1159	/*
…		…
1224	esrv_update_item (UPD_NROF, pl, top);	1183	esrv_update_item (UPD_NROF, pl, top);
1225		1184
1226	op->weight = 0; // cancel the addition above	1185	op->weight = 0; // cancel the addition above
1227	op->carrying = 0; // must be 0 already	1186	op->carrying = 0; // must be 0 already
1228		1187
1229	op->destroy (1);	1188	op->destroy ();
1230		1189
1231	return top;	1190	return top;
1232	}	1191	}
1233		1192
1234	return 0;	1193	return 0;
…		…
1262	* job preparing multi-part monsters.	1221	* job preparing multi-part monsters.
1263	*/	1222	*/
1264	object *	1223	object *
1265	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1224	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1266	{	1225	{
		1226	op->remove ();
		1227
1267	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1228	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1268	{	1229	{
1269	tmp->x = x + tmp->arch->x;	1230	tmp->x = x + tmp->arch->x;
1270	tmp->y = y + tmp->arch->y;	1231	tmp->y = y + tmp->arch->y;
1271	}	1232	}
…		…
1294	* just 'op' otherwise	1255	* just 'op' otherwise
1295	*/	1256	*/
1296	object *	1257	object *
1297	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1258	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1298	{	1259	{
1299	assert (!op->flag [FLAG_FREED]);
1300
1301	op->remove ();	1260	op->remove ();
		1261
		1262	if (m == &freed_map)//D TODO: remove soon
		1263	{//D
		1264	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1265	}//D
1302		1266
1303	/* Ideally, the caller figures this out. However, it complicates a lot	1267	/* Ideally, the caller figures this out. However, it complicates a lot
1304	* of areas of callers (eg, anything that uses find_free_spot would now	1268	* of areas of callers (eg, anything that uses find_free_spot would now
1305	* need extra work	1269	* need extra work
1306	*/	1270	*/
		1271	maptile *newmap = m;
1307	if (!xy_normalise (m, op->x, op->y))	1272	if (!xy_normalise (newmap, op->x, op->y))
1308	{	1273	{
1309	op->destroy (1);	1274	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1310	return 0;	1275	return 0;
1311	}	1276	}
1312		1277
1313	if (object *more = op->more)	1278	if (object *more = op->more)
1314	if (!insert_ob_in_map (more, m, originator, flag))	1279	if (!insert_ob_in_map (more, m, originator, flag))
1315	return 0;	1280	return 0;
1316		1281
1317	CLEAR_FLAG (op, FLAG_REMOVED);	1282	op->flag [FLAG_REMOVED] = false;
1318		1283	op->env = 0;
1319	op->map = m;	1284	op->map = newmap;
		1285
1320	mapspace &ms = op->ms ();	1286	mapspace &ms = op->ms ();
1321		1287
1322	/* this has to be done after we translate the coordinates.	1288	/* this has to be done after we translate the coordinates.
1323	*/	1289	*/
1324	if (op->nrof && !(flag & INS_NO_MERGE))	1290	if (op->nrof && !(flag & INS_NO_MERGE))
1325	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1291	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1326	if (object::can_merge (op, tmp))	1292	if (object::can_merge (op, tmp))
1327	{	1293	{
1328	// TODO: we atcually want to update tmp, not op,	1294	// TODO: we actually want to update tmp, not op,
1329	// but some caller surely breaks when we return tmp	1295	// but some caller surely breaks when we return tmp
1330	// from here :/	1296	// from here :/
1331	op->nrof += tmp->nrof;	1297	op->nrof += tmp->nrof;
1332	tmp->destroy (1);	1298	tmp->destroy ();
1333	}	1299	}
1334		1300
1335	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1301	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1336	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1302	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1337		1303
…		…
1344	{	1310	{
1345	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1311	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1346	abort ();	1312	abort ();
1347	}	1313	}
1348		1314
		1315	if (!originator->is_on_map ())
		1316	{
		1317	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1318	op->debug_desc (), originator->debug_desc ());
		1319	abort ();
		1320	}
		1321
1349	op->above = originator;	1322	op->above = originator;
1350	op->below = originator->below;	1323	op->below = originator->below;
1351
1352	if (op->below)
1353	op->below->above = op;
1354	else
1355	ms.bot = op;
1356
1357	/* since *below* originator, no need to update top */
1358	originator->below = op;	1324	originator->below = op;
		1325
		1326	*(op->below ? &op->below->above : &ms.bot) = op;
1359	}	1327	}
1360	else	1328	else
1361	{	1329	{
1362	object *top, *floor = NULL;	1330	object *floor = 0;
1363		1331	object *top = ms.top;
1364	top = ms.bot;
1365		1332
1366	/* If there are other objects, then */	1333	/* If there are other objects, then */
1367	if (top)	1334	if (top)
1368	{	1335	{
1369	object *last = 0;
1370
1371	/*	1336	/*
1372	* If there are multiple objects on this space, we do some trickier handling.	1337	* If there are multiple objects on this space, we do some trickier handling.
1373	* We've already dealt with merging if appropriate.	1338	* We've already dealt with merging if appropriate.
1374	* Generally, we want to put the new object on top. But if	1339	* Generally, we want to put the new object on top. But if
1375	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1340	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1378	* once we get to them. This reduces the need to traverse over all of	1343	* once we get to them. This reduces the need to traverse over all of
1379	* them when adding another one - this saves quite a bit of cpu time	1344	* them when adding another one - this saves quite a bit of cpu time
1380	* when lots of spells are cast in one area. Currently, it is presumed	1345	* when lots of spells are cast in one area. Currently, it is presumed
1381	* that flying non pickable objects are spell objects.	1346	* that flying non pickable objects are spell objects.
1382	*/	1347	*/
1383	for (top = ms.bot; top; top = top->above)	1348	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1384	{	1349	{
1385	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1350	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1386	floor = top;	1351	floor = tmp;
1387		1352
1388	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1353	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1389	{	1354	{
1390	/* We insert above top, so we want this object below this */	1355	/* We insert above top, so we want this object below this */
1391	top = top->below;	1356	top = tmp->below;
1392	break;	1357	break;
1393	}	1358	}
1394		1359
1395	last = top;	1360	top = tmp;
1396	}	1361	}
1397
1398	/* Don't want top to be NULL, so set it to the last valid object */
1399	top = last;
1400		1362
1401	/* We let update_position deal with figuring out what the space	1363	/* We let update_position deal with figuring out what the space
1402	* looks like instead of lots of conditions here.	1364	* looks like instead of lots of conditions here.
1403	* makes things faster, and effectively the same result.	1365	* makes things faster, and effectively the same result.
1404	*/	1366	*/
…		…
1411	*/	1373	*/
1412	if (!(flag & INS_ON_TOP)	1374	if (!(flag & INS_ON_TOP)
1413	&& ms.flags () & P_BLOCKSVIEW	1375	&& ms.flags () & P_BLOCKSVIEW
1414	&& (op->face && !faces [op->face].visibility))	1376	&& (op->face && !faces [op->face].visibility))
1415	{	1377	{
		1378	object *last;
		1379
1416	for (last = top; last != floor; last = last->below)	1380	for (last = top; last != floor; last = last->below)
1417	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1381	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1418	break;	1382	break;
1419		1383
1420	/* Check to see if we found the object that blocks view,	1384	/* Check to see if we found the object that blocks view,
…		…
1428	} /* If objects on this space */	1392	} /* If objects on this space */
1429		1393
1430	if (flag & INS_ABOVE_FLOOR_ONLY)	1394	if (flag & INS_ABOVE_FLOOR_ONLY)
1431	top = floor;	1395	top = floor;
1432		1396
1433	/* Top is the object that our object (op) is going to get inserted above.	1397	// insert object above top, or bottom-most if top = 0
1434	*/
1435
1436	/* First object on this space */
1437	if (!top)	1398	if (!top)
1438	{	1399	{
		1400	op->below = 0;
1439	op->above = ms.bot;	1401	op->above = ms.bot;
1440
1441	if (op->above)
1442	op->above->below = op;
1443
1444	op->below = 0;
1445	ms.bot = op;	1402	ms.bot = op;
		1403
		1404	*(op->above ? &op->above->below : &ms.top) = op;
1446	}	1405	}
1447	else	1406	else
1448	{ /* get inserted into the stack above top */	1407	{
1449	op->above = top->above;	1408	op->above = top->above;
1450
1451	if (op->above)
1452	op->above->below = op;	1409	top->above = op;
1453		1410
1454	op->below = top;	1411	op->below = top;
1455	top->above = op;	1412	*(op->above ? &op->above->below : &ms.top) = op;
1456	}	1413	}
		1414	}
1457		1415
1458	if (!op->above)	1416	if (op->is_player ())
1459	ms.top = op;
1460	} /* else not INS_BELOW_ORIGINATOR */
1461
1462	if (op->type == PLAYER)
1463	{	1417	{
1464	op->contr->do_los = 1;	1418	op->contr->do_los = 1;
1465	++op->map->players;	1419	++op->map->players;
1466	op->map->touch ();	1420	op->map->touch ();
1467	}	1421	}
1468		1422
1469	op->map->dirty = true;	1423	op->map->dirty = true;
1470		1424
1471	if (object *pl = ms.player ())	1425	if (object *pl = ms.player ())
1472	//TODO: the floorbox prev/next might need updating	1426	//TODO: the floorbox prev/next might need updating
1473	esrv_send_item (pl, op);	1427	//esrv_send_item (pl, op);
		1428	//TODO: update floorbox to preserve ordering
		1429	if (pl->contr->ns)
		1430	pl->contr->ns->floorbox_update ();
1474		1431
1475	/* If this object glows, it may affect lighting conditions that are	1432	/* If this object glows, it may affect lighting conditions that are
1476	* visible to others on this map. But update_all_los is really	1433	* visible to others on this map. But update_all_los is really
1477	* an inefficient way to do this, as it means los for all players	1434	* an inefficient way to do this, as it means los for all players
1478	* on the map will get recalculated. The players could very well	1435	* on the map will get recalculated. The players could very well
1479	* be far away from this change and not affected in any way -	1436	* be far away from this change and not affected in any way -
1480	* this should get redone to only look for players within range,	1437	* this should get redone to only look for players within range,
1481	* or just updating the P_UPTODATE for spaces within this area	1438	* or just updating the P_UPTODATE for spaces within this area
1482	* of effect may be sufficient.	1439	* of effect may be sufficient.
1483	*/	1440	*/
1484	if (op->map->darkness && (op->glow_radius != 0))	1441	if (op->affects_los ())
		1442	{
		1443	op->ms ().invalidate ();
1485	update_all_los (op->map, op->x, op->y);	1444	update_all_los (op->map, op->x, op->y);
		1445	}
1486		1446
1487	/* updates flags (blocked, alive, no magic, etc) for this map space */	1447	/* updates flags (blocked, alive, no magic, etc) for this map space */
1488	update_object (op, UP_OBJ_INSERT);	1448	update_object (op, UP_OBJ_INSERT);
1489		1449
1490	INVOKE_OBJECT (INSERT, op);	1450	INVOKE_OBJECT (INSERT, op);
…		…
1497	* blocked() and wall() work properly), and these flags are updated by	1457	* blocked() and wall() work properly), and these flags are updated by
1498	* update_object().	1458	* update_object().
1499	*/	1459	*/
1500		1460
1501	/* if this is not the head or flag has been passed, don't check walk on status */	1461	/* if this is not the head or flag has been passed, don't check walk on status */
1502	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1462	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1503	{	1463	{
1504	if (check_move_on (op, originator))	1464	if (check_move_on (op, originator))
1505	return 0;	1465	return 0;
1506		1466
1507	/* If we are a multi part object, lets work our way through the check	1467	/* If we are a multi part object, lets work our way through the check
…		…
1518	/* this function inserts an object in the map, but if it	1478	/* this function inserts an object in the map, but if it
1519	* finds an object of its own type, it'll remove that one first.	1479	* finds an object of its own type, it'll remove that one first.
1520	* op is the object to insert it under: supplies x and the map.	1480	* op is the object to insert it under: supplies x and the map.
1521	*/	1481	*/
1522	void	1482	void
1523	replace_insert_ob_in_map (const char *arch_string, object *op)	1483	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1524	{	1484	{
1525	/* first search for itself and remove any old instances */	1485	/* first search for itself and remove any old instances */
1526		1486
1527	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1487	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1528	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1488	if (tmp->arch->archname == archname) /* same archetype */
1529	tmp->destroy (1);	1489	tmp->destroy ();
1530		1490
1531	object *tmp = arch_to_object (archetype::find (arch_string));	1491	object *tmp = arch_to_object (archetype::find (archname));
1532		1492
1533	tmp->x = op->x;	1493	tmp->x = op->x;
1534	tmp->y = op->y;	1494	tmp->y = op->y;
1535		1495
1536	insert_ob_in_map (tmp, op->map, op, 0);	1496	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1558	if (!nr)	1518	if (!nr)
1559	return true;	1519	return true;
1560		1520
1561	nr = min (nr, nrof);	1521	nr = min (nr, nrof);
1562		1522
		1523	if (nrof > nr)
		1524	{
1563	nrof -= nr;	1525	nrof -= nr;
1564
1565	if (nrof)
1566	{
1567	adjust_weight (env, -weight * nr); // carrying == 0	1526	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1568		1527
1569	if (object *pl = visible_to ())	1528	if (object *pl = visible_to ())
1570	esrv_update_item (UPD_NROF, pl, this);	1529	esrv_update_item (UPD_NROF, pl, this);
1571		1530
1572	return true;	1531	return true;
1573	}	1532	}
1574	else	1533	else
1575	{	1534	{
1576	destroy (1);	1535	destroy ();
1577	return false;	1536	return false;
1578	}	1537	}
1579	}	1538	}
1580		1539
1581	/*	1540	/*
…		…
1598	}	1557	}
1599	else	1558	else
1600	{	1559	{
1601	decrease (nr);	1560	decrease (nr);
1602		1561
1603	object *op = object_create_clone (this);	1562	object *op = deep_clone ();
1604	op->nrof = nr;	1563	op->nrof = nr;
1605	return op;	1564	return op;
1606	}	1565	}
1607	}	1566	}
1608		1567
…		…
1658	if (object *pl = tmp->visible_to ())	1617	if (object *pl = tmp->visible_to ())
1659	esrv_update_item (UPD_NROF, pl, tmp);	1618	esrv_update_item (UPD_NROF, pl, tmp);
1660		1619
1661	adjust_weight (this, op->total_weight ());	1620	adjust_weight (this, op->total_weight ());
1662		1621
1663	op->destroy (1);	1622	op->destroy ();
1664	op = tmp;	1623	op = tmp;
1665	goto inserted;	1624	goto inserted;
1666	}	1625	}
1667		1626
1668	op->owner = 0; // it's his/hers now. period.	1627	op->owner = 0; // it's his/hers now. period.
…		…
1686		1645
1687	adjust_weight (this, op->total_weight ());	1646	adjust_weight (this, op->total_weight ());
1688		1647
1689	inserted:	1648	inserted:
1690	/* reset the light list and los of the players on the map */	1649	/* reset the light list and los of the players on the map */
1691	if (op->glow_radius && map && map->darkness)	1650	if (op->glow_radius && is_on_map ())
		1651	{
		1652	update_stats ();
1692	update_all_los (map, x, y);	1653	update_all_los (map, x, y);
1693		1654	}
		1655	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1694	// if this is a player's inventory, update stats	1656	// if this is a player's inventory, update stats
1695	if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1696	update_stats ();	1657	update_stats ();
1697		1658
1698	INVOKE_OBJECT (INSERT, this);	1659	INVOKE_OBJECT (INSERT, this);
1699		1660
1700	return op;	1661	return op;
…		…
1721	* on top.	1682	* on top.
1722	*/	1683	*/
1723	int	1684	int
1724	check_move_on (object *op, object *originator)	1685	check_move_on (object *op, object *originator)
1725	{	1686	{
		1687	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1688	return 0;
		1689
1726	object *tmp;	1690	object *tmp;
1727	maptile *m = op->map;	1691	maptile *m = op->map;
1728	int x = op->x, y = op->y;	1692	int x = op->x, y = op->y;
1729		1693
1730	MoveType move_on, move_slow, move_block;	1694	mapspace &ms = m->at (x, y);
1731		1695
1732	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1696	ms.update ();
1733	return 0;
1734		1697
1735	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1698	MoveType move_on = ms.move_on;
1736	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1699	MoveType move_slow = ms.move_slow;
1737	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1700	MoveType move_block = ms.move_block;
1738		1701
1739	/* if nothing on this space will slow op down or be applied,	1702	/* if nothing on this space will slow op down or be applied,
1740	* no need to do checking below. have to make sure move_type	1703	* no need to do checking below. have to make sure move_type
1741	* is set, as lots of objects don't have it set - we treat that	1704	* is set, as lots of objects don't have it set - we treat that
1742	* as walking.	1705	* as walking.
…		…
1753	return 0;	1716	return 0;
1754		1717
1755	/* The objects have to be checked from top to bottom.	1718	/* The objects have to be checked from top to bottom.
1756	* Hence, we first go to the top:	1719	* Hence, we first go to the top:
1757	*/	1720	*/
1758		1721	for (object *next, *tmp = ms.top; tmp; tmp = next)
1759	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1760	{
1761	/* Trim the search when we find the first other spell effect
1762	* this helps performance so that if a space has 50 spell objects,
1763	* we don't need to check all of them.
1764	*/
1765	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1766	break;
1767	}	1722	{
		1723	next = tmp->below;
1768		1724
1769	for (; tmp; tmp = tmp->below)
1770	{
1771	if (tmp == op)	1725	if (tmp == op)
1772	continue; /* Can't apply yourself */	1726	continue; /* Can't apply yourself */
1773		1727
1774	/* Check to see if one of the movement types should be slowed down.	1728	/* Check to see if one of the movement types should be slowed down.
1775	* Second check makes sure that the movement types not being slowed	1729	* Second check makes sure that the movement types not being slowed
…		…
1780	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1734	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1781	{	1735	{
1782	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1736	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1783	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1737	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1784	{	1738	{
1785
1786	float
1787	diff = tmp->move_slow_penalty * fabs (op->speed);	1739	float diff = tmp->move_slow_penalty * fabs (op->speed);
1788		1740
1789	if (op->type == PLAYER)	1741	if (op->is_player ())
1790	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1742	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1791	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1743	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1792	diff /= 4.0;	1744	diff /= 4.0;
1793		1745
1794	op->speed_left -= diff;	1746	op->speed_left -= diff;
1795	}	1747	}
1796	}	1748	}
…		…
1829	LOG (llevError, "Present_arch called outside map.\n");	1781	LOG (llevError, "Present_arch called outside map.\n");
1830	return NULL;	1782	return NULL;
1831	}	1783	}
1832		1784
1833	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1785	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1834	if (tmp->arch == at)	1786	if (tmp->arch->archname == at->archname)
1835	return tmp;	1787	return tmp;
1836		1788
1837	return NULL;	1789	return NULL;
1838	}	1790	}
1839		1791
…		…
1903	* The first matching object is returned, or NULL if none.	1855	* The first matching object is returned, or NULL if none.
1904	*/	1856	*/
1905	object *	1857	object *
1906	present_arch_in_ob (const archetype *at, const object *op)	1858	present_arch_in_ob (const archetype *at, const object *op)
1907	{	1859	{
1908	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1860	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1909	if (tmp->arch == at)	1861	if (tmp->arch->archname == at->archname)
1910	return tmp;	1862	return tmp;
1911		1863
1912	return NULL;	1864	return NULL;
1913	}	1865	}
1914		1866
…		…
2002	* head of the object should correspond for the entire object.	1954	* head of the object should correspond for the entire object.
2003	*/	1955	*/
2004	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1956	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2005	continue;	1957	continue;
2006		1958
2007	if (ob->blocked (m, pos.x, pos.y))	1959	if (ob->blocked (pos.m, pos.x, pos.y))
2008	continue;	1960	continue;
2009		1961
2010	altern [index++] = i;	1962	altern [index++] = i;
2011	}	1963	}
2012		1964
…		…
2080	* there is capable of.	2032	* there is capable of.
2081	*/	2033	*/
2082	int	2034	int
2083	find_dir (maptile *m, int x, int y, object *exclude)	2035	find_dir (maptile *m, int x, int y, object *exclude)
2084	{	2036	{
2085	int i, max = SIZEOFFREE, mflags;	2037	int max = SIZEOFFREE, mflags;
2086
2087	sint16 nx, ny;
2088	object *tmp;
2089	maptile *mp;
2090
2091	MoveType blocked, move_type;	2038	MoveType move_type;
2092		2039
2093	if (exclude && exclude->head_ () != exclude)	2040	if (exclude && exclude->head_ () != exclude)
2094	{	2041	{
2095	exclude = exclude->head;	2042	exclude = exclude->head;
2096	move_type = exclude->move_type;	2043	move_type = exclude->move_type;
…		…
2099	{	2046	{
2100	/* If we don't have anything, presume it can use all movement types. */	2047	/* If we don't have anything, presume it can use all movement types. */
2101	move_type = MOVE_ALL;	2048	move_type = MOVE_ALL;
2102	}	2049	}
2103		2050
2104	for (i = 1; i < max; i++)	2051	for (int i = 1; i < max; i++)
2105	{	2052	{
2106	mp = m;	2053	mapxy pos (m, x, y);
2107	nx = x + freearr_x[i];	2054	pos.move (i);
2108	ny = y + freearr_y[i];
2109		2055
2110	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2056	if (!pos.normalise ())
2111
2112	if (mflags & P_OUT_OF_MAP)
2113	max = maxfree[i];	2057	max = maxfree[i];
2114	else	2058	else
2115	{	2059	{
2116	mapspace &ms = mp->at (nx, ny);	2060	mapspace &ms = *pos;
2117		2061
2118	blocked = ms.move_block;
2119
2120	if ((move_type & blocked) == move_type)	2062	if ((move_type & ms.move_block) == move_type)
2121	max = maxfree[i];	2063	max = maxfree [i];
2122	else if (mflags & P_IS_ALIVE)	2064	else if (ms.flags () & P_IS_ALIVE)
2123	{	2065	{
2124	for (tmp = ms.bot; tmp; tmp = tmp->above)	2066	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2125	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2067	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2126	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2068	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2127	break;
2128
2129	if (tmp)
2130	return freedir[i];	2069	return freedir [i];
2131	}	2070	}
2132	}	2071	}
2133	}	2072	}
2134		2073
2135	return 0;	2074	return 0;
…		…
2210	* This basically means that if direction is 15, then it could either go	2149	* This basically means that if direction is 15, then it could either go
2211	* direction 4, 14, or 16 to get back to where we are.	2150	* direction 4, 14, or 16 to get back to where we are.
2212	* Moved from spell_util.c to object.c with the other related direction	2151	* Moved from spell_util.c to object.c with the other related direction
2213	* functions.	2152	* functions.
2214	*/	2153	*/
2215	int reduction_dir[SIZEOFFREE][3] = {	2154	static const int reduction_dir[SIZEOFFREE][3] = {
2216	{0, 0, 0}, /* 0 */	2155	{0, 0, 0}, /* 0 */
2217	{0, 0, 0}, /* 1 */	2156	{0, 0, 0}, /* 1 */
2218	{0, 0, 0}, /* 2 */	2157	{0, 0, 0}, /* 2 */
2219	{0, 0, 0}, /* 3 */	2158	{0, 0, 0}, /* 3 */
2220	{0, 0, 0}, /* 4 */	2159	{0, 0, 0}, /* 4 */
…		…
2316	int	2255	int
2317	can_pick (const object *who, const object *item)	2256	can_pick (const object *who, const object *item)
2318	{	2257	{
2319	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2258	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2320	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2259	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2321	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2260	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2322	}	2261	}
2323		2262
2324	/*	2263	/*
2325	* create clone from object to another	2264	* create clone from object to another
2326	*/	2265	*/
2327	object *	2266	object *
2328	object_create_clone (object *asrc)	2267	object::deep_clone ()
2329	{	2268	{
		2269	assert (("deep_clone called on non-head object", is_head ()));
		2270
2330	object *dst = 0;	2271	object *dst = clone ();
2331		2272
2332	if (!asrc)
2333	return 0;
2334
2335	object *src = asrc->head_ ();
2336
2337	object *prev = 0;	2273	object *prev = dst;
2338	for (object *part = src; part; part = part->more)	2274	for (object *part = this->more; part; part = part->more)
2339	{	2275	{
2340	object *tmp = part->clone ();	2276	object *tmp = part->clone ();
2341
2342	tmp->x -= src->x;
2343	tmp->y -= src->y;
2344
2345	if (!part->head)
2346	{
2347	dst = tmp;
2348	tmp->head = 0;
2349	}
2350	else
2351	tmp->head = dst;	2277	tmp->head = dst;
2352
2353	tmp->more = 0;
2354
2355	if (prev)
2356	prev->more = tmp;	2278	prev->more = tmp;
2357
2358	prev = tmp;	2279	prev = tmp;
2359	}	2280	}
2360		2281
2361	for (object *item = src->inv; item; item = item->below)	2282	for (object *item = inv; item; item = item->below)
2362	insert_ob_in_ob (object_create_clone (item), dst);	2283	insert_ob_in_ob (item->deep_clone (), dst);
2363		2284
2364	return dst;	2285	return dst;
2365	}	2286	}
2366		2287
2367	/* This returns the first object in who's inventory that	2288	/* This returns the first object in who's inventory that
…		…
2376	return tmp;	2297	return tmp;
2377		2298
2378	return 0;	2299	return 0;
2379	}	2300	}
2380		2301
2381	/* If ob has a field named key, return the link from the list,	2302	shstr_tmp
2382	* otherwise return NULL.	2303	object::kv_get (shstr_tmp key) const
2383	*
2384	* key must be a passed in shared string - otherwise, this won't
2385	* do the desired thing.
2386	*/
2387	key_value *
2388	get_ob_key_link (const object *ob, const char *key)
2389	{	2304	{
2390	for (key_value *link = ob->key_values; link; link = link->next)	2305	for (key_value *kv = key_values; kv; kv = kv->next)
2391	if (link->key == key)	2306	if (kv->key == key)
2392	return link;
2393
2394	return 0;
2395	}
2396
2397	/*
2398	* Returns the value of op has an extra_field for key, or NULL.
2399	*
2400	* The argument doesn't need to be a shared string.
2401	*
2402	* The returned string is shared.
2403	*/
2404	const char *
2405	get_ob_key_value (const object *op, const char *const key)
2406	{
2407	key_value *link;
2408	shstr_cmp canonical_key (key);
2409
2410	if (!canonical_key)
2411	{
2412	/* 1. There being a field named key on any object
2413	* implies there'd be a shared string to find.
2414	* 2. Since there isn't, no object has this field.
2415	* 3. Therefore, *this* object doesn't have this field.
2416	*/
2417	return 0;
2418	}
2419
2420	/* This is copied from get_ob_key_link() above -
2421	* only 4 lines, and saves the function call overhead.
2422	*/
2423	for (link = op->key_values; link; link = link->next)
2424	if (link->key == canonical_key)
2425	return link->value;	2307	return kv->value;
2426		2308
2427	return 0;	2309	return shstr ();
2428	}	2310	}
2429		2311
2430	/*	2312	void
2431	* Updates the canonical_key in op to value.	2313	object::kv_set (shstr_tmp key, shstr_tmp value)
2432	*
2433	* canonical_key is a shared string (value doesn't have to be).
2434	*
2435	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2436	* keys.
2437	*
2438	* Returns TRUE on success.
2439	*/
2440	int
2441	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2442	{	2314	{
2443	key_value *field = NULL, *last = NULL;	2315	for (key_value *kv = key_values; kv; kv = kv->next)
2444		2316	if (kv->key == key)
2445	for (field = op->key_values; field != NULL; field = field->next)
2446	{
2447	if (field->key != canonical_key)
2448	{	2317	{
2449	last = field;	2318	kv->value = value;
2450	continue;	2319	return;
2451	}	2320	}
2452		2321
2453	if (value)	2322	key_value *kv = new key_value;
2454	field->value = value;	2323
2455	else	2324	kv->next = key_values;
		2325	kv->key = key;
		2326	kv->value = value;
		2327
		2328	key_values = kv;
		2329	}
		2330
		2331	void
		2332	object::kv_del (shstr_tmp key)
		2333	{
		2334	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2335	if ((*kvp)->key == key)
2456	{	2336	{
2457	/* Basically, if the archetype has this key set,	2337	key_value *kv = *kvp;
2458	* we need to store the null value so when we save	2338	*kvp = (*kvp)->next;
2459	* it, we save the empty value so that when we load,	2339	delete kv;
2460	* we get this value back again.	2340	return;
2461	*/
2462	if (get_ob_key_link (op->arch, canonical_key))
2463	field->value = 0;
2464	else
2465	{
2466	if (last)
2467	last->next = field->next;
2468	else
2469	op->key_values = field->next;
2470
2471	delete field;
2472	}
2473	}	2341	}
2474	return TRUE;
2475	}
2476	/* IF we get here, key doesn't exist */
2477
2478	/* No field, we'll have to add it. */
2479
2480	if (!add_key)
2481	return FALSE;
2482
2483	/* There isn't any good reason to store a null
2484	* value in the key/value list. If the archetype has
2485	* this key, then we should also have it, so shouldn't
2486	* be here. If user wants to store empty strings,
2487	* should pass in ""
2488	*/
2489	if (value == NULL)
2490	return TRUE;
2491
2492	field = new key_value;
2493
2494	field->key = canonical_key;
2495	field->value = value;
2496	/* Usual prepend-addition. */
2497	field->next = op->key_values;
2498	op->key_values = field;
2499
2500	return TRUE;
2501	}
2502
2503	/*
2504	* Updates the key in op to value.
2505	*
2506	* If add_key is FALSE, this will only update existing keys,
2507	* and not add new ones.
2508	* In general, should be little reason FALSE is ever passed in for add_key
2509	*
2510	* Returns TRUE on success.
2511	*/
2512	int
2513	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2514	{
2515	shstr key_ (key);
2516
2517	return set_ob_key_value_s (op, key_, value, add_key);
2518	}	2342	}
2519		2343
2520	object::depth_iterator::depth_iterator (object *container)	2344	object::depth_iterator::depth_iterator (object *container)
2521	: iterator_base (container)	2345	: iterator_base (container)
2522	{	2346	{
…		…
2572	{	2396	{
2573	char flagdesc[512];	2397	char flagdesc[512];
2574	char info2[256 * 4];	2398	char info2[256 * 4];
2575	char *p = info;	2399	char *p = info;
2576		2400
2577	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2401	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2578	count,	2402	count,
2579	uuid.c_str (),	2403	uuid.c_str (),
2580	&name,	2404	&name,
2581	title ? "\",title:\"" : "",	2405	title ? ",title:\"" : "",
2582	title ? (const char *)title : "",	2406	title ? (const char *)title : "",
		2407	title ? "\"" : "",
2583	flag_desc (flagdesc, 512), type);	2408	flag_desc (flagdesc, 512), type);
2584		2409
2585	if (!flag[FLAG_REMOVED] && env)	2410	if (!flag[FLAG_REMOVED] && env)
2586	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2411	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2587		2412
…		…
2643	container = 0;	2468	container = 0;
2644		2469
2645	// client needs item update to make it work, client bug requires this to be separate	2470	// client needs item update to make it work, client bug requires this to be separate
2646	esrv_update_item (UPD_FLAGS, this, old_container);	2471	esrv_update_item (UPD_FLAGS, this, old_container);
2647		2472
2648	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2473	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2649	play_sound (sound_find ("chest_close"));	2474	play_sound (sound_find ("chest_close"));
2650	}	2475	}
2651		2476
2652	if (new_container)	2477	if (new_container)
2653	{	2478	{
…		…
2663	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2488	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2664	new_container->insert (closer);	2489	new_container->insert (closer);
2665	}	2490	}
2666	#endif	2491	#endif
2667		2492
2668	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2493	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2669		2494
2670	// make sure the container is available, client bug requires this to be separate	2495	// make sure the container is available, client bug requires this to be separate
2671	esrv_send_item (this, new_container);	2496	esrv_send_item (this, new_container);
2672		2497
2673	new_container->flag [FLAG_APPLIED] = true;	2498	new_container->flag [FLAG_APPLIED] = true;
…		…
2681	// else if (!old_container->env && contr && contr->ns)	2506	// else if (!old_container->env && contr && contr->ns)
2682	// contr->ns->floorbox_reset ();	2507	// contr->ns->floorbox_reset ();
2683	}	2508	}
2684		2509
2685	object *	2510	object *
2686	object::force_find (const shstr name)	2511	object::force_find (shstr_tmp name)
2687	{	2512	{
2688	/* cycle through his inventory to look for the MARK we want to	2513	/* cycle through his inventory to look for the MARK we want to
2689	* place	2514	* place
2690	*/	2515	*/
2691	for (object *tmp = inv; tmp; tmp = tmp->below)	2516	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2693	return splay (tmp);	2518	return splay (tmp);
2694		2519
2695	return 0;	2520	return 0;
2696	}	2521	}
2697		2522
		2523	//-GPL
		2524
2698	void	2525	void
		2526	object::force_set_timer (int duration)
		2527	{
		2528	this->duration = 1;
		2529	this->speed_left = -1.f;
		2530
		2531	this->set_speed (duration ? 1.f / duration : 0.f);
		2532	}
		2533
		2534	object *
2699	object::force_add (const shstr name, int duration)	2535	object::force_add (shstr_tmp name, int duration)
2700	{	2536	{
2701	if (object *force = force_find (name))	2537	if (object *force = force_find (name))
2702	force->destroy ();	2538	force->destroy ();
2703		2539
2704	object *force = get_archetype (FORCE_NAME);	2540	object *force = get_archetype (FORCE_NAME);
2705		2541
2706	force->slaying = name;	2542	force->slaying = name;
2707	force->stats.food = 1;	2543	force->force_set_timer (duration);
2708	force->speed_left = -1.f;
2709
2710	force->set_speed (duration ? 1.f / duration : 0.f);
2711	force->flag [FLAG_IS_USED_UP] = true;
2712	force->flag [FLAG_APPLIED] = true;	2544	force->flag [FLAG_APPLIED] = true;
2713		2545
2714	insert (force);	2546	return insert (force);
2715	}	2547	}
2716		2548
2717	void	2549	void
2718	object::play_sound (faceidx sound)	2550	object::play_sound (faceidx sound) const
2719	{	2551	{
2720	if (!sound)	2552	if (!sound)
2721	return;	2553	return;
2722		2554
2723	if (flag [FLAG_REMOVED])	2555	if (is_on_map ())
		2556	map->play_sound (sound, x, y);
		2557	else if (object *pl = in_player ())
		2558	pl->contr->play_sound (sound);
		2559	}
		2560
		2561	void
		2562	object::say_msg (const char *msg) const
		2563	{
		2564	if (is_on_map ())
		2565	map->say_msg (msg, x, y);
		2566	else if (object *pl = in_player ())
		2567	pl->contr->play_sound (sound);
		2568	}
		2569
		2570	void
		2571	object::make_noise ()
		2572	{
		2573	// we do not model noise in the map, so instead put
		2574	// a temporary light into the noise source
		2575	// could use the map instead, but that's less reliable for our
		2576	// goal, which is to make invisibility a bit harder to exploit
		2577
		2578	// currently only works sensibly for players
		2579	if (!is_player ())
2724	return;	2580	return;
2725		2581
2726	if (env)	2582	// find old force, or create new one
2727	{	2583	object *force = force_find (shstr_noise_force);
2728	if (object *pl = in_player ())	2584
2729	pl->contr->play_sound (sound);	2585	if (force)
2730	}	2586	force->speed_left = -1.f; // patch old speed up
2731	else	2587	else
2732	map->play_sound (sound, x, y);	2588	{
2733	}	2589	force = archetype::get (shstr_noise_force);
2734		2590
		2591	force->slaying = shstr_noise_force;
		2592	force->stats.food = 1;
		2593	force->speed_left = -1.f;
		2594
		2595	force->set_speed (1.f / 4.f);
		2596	force->flag [FLAG_IS_USED_UP] = true;
		2597	force->flag [FLAG_APPLIED] = true;
		2598
		2599	insert (force);
		2600	}
		2601	}
		2602

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines