[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.227 by root, Sat May 3 09:04:17 2008 UTC vs.
Revision 1.238 by root, Wed May 7 11:02:50 2008 UTC

…		…
139		139
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	141	static bool
142	compare_ob_value_lists_one (const object wants, const object has)	142	compare_ob_value_lists_one (const object wants, const object has)
143	{	143	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	144	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	145	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	146	* different structure or at least keep the lists sorted...
149	*/	147	*/
150		148
151	/* For each field in wants, */	149	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	150	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	151	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	152	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		153
169	/* If we get here, every field in wants has a matching field in has. */	154	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	155	return true;
171	}	156	}
172		157
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	158	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	159	static bool
175	compare_ob_value_lists (const object ob1, const object ob2)	160	compare_ob_value_lists (const object ob1, const object ob2)
176	{	161	{
177	/* However, there may be fields in has which aren't partnered in wants,	162	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison twice. :(	163	* so we need to run the comparison twice. :(
179	*/	164	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	165	return compare_ob_value_lists_one (ob1, ob2)
		166	&& compare_ob_value_lists_one (ob2, ob1);
181	}	167	}
182		168
183	/* Function examines the 2 objects given to it, and returns true if	169	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	170	* they can be merged together.
185	*	171	*
…		…
368	return 0;	354	return 0;
369	}	355	}
370		356
371	// adjust weight per container type ("of holding")	357	// adjust weight per container type ("of holding")
372	static sint32	358	static sint32
373	weight_adjust (object *op, sint32 weight)	359	weight_adjust_for (object *op, sint32 weight)
374	{	360	{
375	return op->type == CONTAINER	361	return op->type == CONTAINER
376	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	362	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377	: weight;	363	: weight;
378	}	364	}
…		…
384	static void	370	static void
385	adjust_weight (object *op, sint32 weight)	371	adjust_weight (object *op, sint32 weight)
386	{	372	{
387	while (op)	373	while (op)
388	{	374	{
		375	// adjust by actual difference to account for rounding errors
		376	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389	weight = weight_adjust (op, weight);	377	weight = weight_adjust_for (op, op->carrying)
		378	- weight_adjust_for (op, op->carrying - weight);
390		379
391	if (!weight)	380	if (!weight)
392	return;	381	return;
393		382
394	op->carrying += weight;	383	op->carrying += weight;
…		…
417	op->update_weight ();	406	op->update_weight ();
418		407
419	sum += op->total_weight ();	408	sum += op->total_weight ();
420	}	409	}
421		410
422	sum = weight_adjust (this, sum);	411	sum = weight_adjust_for (this, sum);
423		412
424	if (sum != carrying)	413	if (sum != carrying)
425	{	414	{
426	carrying = sum;	415	carrying = sum;
427		416
…		…
915	* drop on that space.	904	* drop on that space.
916	*/	905	*/
917	if (!drop_to_ground	906	if (!drop_to_ground
918	\|\| !map	907	\|\| !map
919	\|\| map->in_memory != MAP_ACTIVE	908	\|\| map->in_memory != MAP_ACTIVE
920	\|\| map->nodrop	909	\|\| map->no_drop
921	\|\| ms ().move_block == MOVE_ALL)	910	\|\| ms ().move_block == MOVE_ALL)
922	{	911	{
923	while (inv)	912	while (inv)
924	{	913	{
925	inv->destroy_inv (false);	914	inv->destroy_inv (false);
…		…
954		943
955	static struct freed_map : maptile	944	static struct freed_map : maptile
956	{	945	{
957	freed_map ()	946	freed_map ()
958	{	947	{
959	path = "<freed objects map>";	948	path = "<freed objects map>";
960	name = "/internal/freed_objects_map";	949	name = "/internal/freed_objects_map";
961	width = 3;	950	width = 3;
962	height = 3;	951	height = 3;
963	nodrop = 1;	952	no_drop = 1;
		953	no_reset = 1;
964		954
965	alloc ();	955	alloc ();
966	in_memory = MAP_ACTIVE;	956	in_memory = MAP_ACTIVE;
		957	}
		958
		959	~freed_map ()
		960	{
		961	destroy ();
967	}	962	}
968	} freed_map; // freed objects are moved here to avoid crashes	963	} freed_map; // freed objects are moved here to avoid crashes
969		964
970	void	965	void
971	object::do_destroy ()	966	object::do_destroy ()
…		…
1062	if (object *pl = visible_to ())	1057	if (object *pl = visible_to ())
1063	esrv_del_item (pl->contr, count);	1058	esrv_del_item (pl->contr, count);
1064	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed	1059	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1065		1060
1066	adjust_weight (env, -total_weight ());	1061	adjust_weight (env, -total_weight ());
1067
1068	*(above ? &above->below : &env->inv) = below;
1069
1070	if (below)
1071	below->above = above;
1072		1062
1073	/* we set up values so that it could be inserted into	1063	/* we set up values so that it could be inserted into
1074	* the map, but we don't actually do that - it is up	1064	* the map, but we don't actually do that - it is up
1075	* to the caller to decide what we want to do.	1065	* to the caller to decide what we want to do.
1076	*/	1066	*/
1077	map = env->map;	1067	map = env->map;
1078	x = env->x;	1068	x = env->x;
1079	y = env->y;	1069	y = env->y;
		1070
		1071	// make sure cmov optimisation is applicable
		1072	*(above ? &above->below : &env->inv) = below;
		1073	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1074
1080	above = 0;	1075	above = 0;
1081	below = 0;	1076	below = 0;
1082	env = 0;	1077	env = 0;
1083		1078
1084	/* NO_FIX_PLAYER is set when a great many changes are being	1079	/* NO_FIX_PLAYER is set when a great many changes are being
…		…
1114		1109
1115	esrv_del_item (pl->contr, count);	1110	esrv_del_item (pl->contr, count);
1116	}	1111	}
1117		1112
1118	/* link the object above us */	1113	/* link the object above us */
1119	if (above)	1114	// re-link, make sure compiler can easily use cmove
1120	above->below = below;	1115	*(above ? &above->below : &ms.top) = below;
1121	else	1116	*(below ? &below->above : &ms.bot) = above;
1122	ms.top = below; /* we were top, set new top */
1123
1124	/* Relink the object below us, if there is one */
1125	if (below)
1126	below->above = above;
1127	else
1128	{
1129	/* Nothing below, which means we need to relink map object for this space
1130	* use translated coordinates in case some oddness with map tiling is
1131	* evident
1132	*/
1133	if (GET_MAP_OB (map, x, y) != this)
1134	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1135
1136	ms.bot = above; /* goes on above it. */
1137	}
1138		1117
1139	above = 0;	1118	above = 0;
1140	below = 0;	1119	below = 0;
1141		1120
1142	if (map->in_memory == MAP_SAVING)	1121	if (map->in_memory == MAP_SAVING)
…		…
1289	* just 'op' otherwise	1268	* just 'op' otherwise
1290	*/	1269	*/
1291	object *	1270	object *
1292	insert_ob_in_map (object op, maptile m, object *originator, int flag)	1271	insert_ob_in_map (object op, maptile m, object *originator, int flag)
1293	{	1272	{
1294	assert (!op->flag [FLAG_FREED]);
1295
1296	op->remove ();	1273	op->remove ();
1297		1274
1298	/* Ideally, the caller figures this out. However, it complicates a lot	1275	/* Ideally, the caller figures this out. However, it complicates a lot
1299	* of areas of callers (eg, anything that uses find_free_spot would now	1276	* of areas of callers (eg, anything that uses find_free_spot would now
1300	* need extra work	1277	* need extra work
1301	*/	1278	*/
1302	if (!xy_normalise (m, op->x, op->y))	1279	if (!xy_normalise (m, op->x, op->y))
1303	{	1280	{
1304	op->destroy (1);	1281	op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1305	return 0;	1282	return 0;
1306	}	1283	}
1307		1284
1308	if (object *more = op->more)	1285	if (object *more = op->more)
1309	if (!insert_ob_in_map (more, m, originator, flag))	1286	if (!insert_ob_in_map (more, m, originator, flag))
…		…
1318	*/	1295	*/
1319	if (op->nrof && !(flag & INS_NO_MERGE))	1296	if (op->nrof && !(flag & INS_NO_MERGE))
1320	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1297	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1321	if (object::can_merge (op, tmp))	1298	if (object::can_merge (op, tmp))
1322	{	1299	{
1323	// TODO: we atcually want to update tmp, not op,	1300	// TODO: we actually want to update tmp, not op,
1324	// but some caller surely breaks when we return tmp	1301	// but some caller surely breaks when we return tmp
1325	// from here :/	1302	// from here :/
1326	op->nrof += tmp->nrof;	1303	op->nrof += tmp->nrof;
1327	tmp->destroy (1);	1304	tmp->destroy (1);
1328	}	1305	}
…		…
1333	if (!QUERY_FLAG (op, FLAG_ALIVE))	1310	if (!QUERY_FLAG (op, FLAG_ALIVE))
1334	CLEAR_FLAG (op, FLAG_NO_STEAL);	1311	CLEAR_FLAG (op, FLAG_NO_STEAL);
1335		1312
1336	if (flag & INS_BELOW_ORIGINATOR)	1313	if (flag & INS_BELOW_ORIGINATOR)
1337	{	1314	{
1338	if (originator->map != op->map \|\| originator->x != op->x \|\| originator->y != op->y)	1315	if (originator->map != op->map \|\| originator->x != op->x \|\| originator->y != op->y \|\| !originator->is_on_map ())
1339	{	1316	{
1340	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1317	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1341	abort ();	1318	abort ();
1342	}	1319	}
1343		1320
1344	op->above = originator;	1321	op->above = originator;
1345	op->below = originator->below;	1322	op->below = originator->below;
1346
1347	if (op->below)
1348	op->below->above = op;
1349	else
1350	ms.bot = op;
1351
1352	/* since below originator, no need to update top */
1353	originator->below = op;	1323	originator->below = op;
		1324
		1325	*(op->below ? &op->below->above : &ms.bot) = op;
1354	}	1326	}
1355	else	1327	else
1356	{	1328	{
1357	object top, floor = NULL;	1329	object *floor = 0;
1358		1330	object *top = ms.top;
1359	top = ms.bot;
1360		1331
1361	/* If there are other objects, then */	1332	/* If there are other objects, then */
1362	if (top)	1333	if (top)
1363	{	1334	{
1364	object *last = 0;
1365
1366	/*	1335	/*
1367	* If there are multiple objects on this space, we do some trickier handling.	1336	* If there are multiple objects on this space, we do some trickier handling.
1368	* We've already dealt with merging if appropriate.	1337	* We've already dealt with merging if appropriate.
1369	* Generally, we want to put the new object on top. But if	1338	* Generally, we want to put the new object on top. But if
1370	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1339	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1373	* once we get to them. This reduces the need to traverse over all of	1342	* once we get to them. This reduces the need to traverse over all of
1374	* them when adding another one - this saves quite a bit of cpu time	1343	* them when adding another one - this saves quite a bit of cpu time
1375	* when lots of spells are cast in one area. Currently, it is presumed	1344	* when lots of spells are cast in one area. Currently, it is presumed
1376	* that flying non pickable objects are spell objects.	1345	* that flying non pickable objects are spell objects.
1377	*/	1346	*/
1378	for (top = ms.bot; top; top = top->above)	1347	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1379	{	1348	{
1380	if (QUERY_FLAG (top, FLAG_IS_FLOOR) \|\| QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1349	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) \|\| QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1381	floor = top;	1350	floor = tmp;
1382		1351
1383	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1352	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1384	{	1353	{
1385	/* We insert above top, so we want this object below this */	1354	/* We insert above top, so we want this object below this */
1386	top = top->below;	1355	top = tmp->below;
1387	break;	1356	break;
1388	}	1357	}
1389		1358
1390	last = top;	1359	top = tmp;
1391	}	1360	}
1392
1393	/* Don't want top to be NULL, so set it to the last valid object */
1394	top = last;
1395		1361
1396	/* We let update_position deal with figuring out what the space	1362	/* We let update_position deal with figuring out what the space
1397	* looks like instead of lots of conditions here.	1363	* looks like instead of lots of conditions here.
1398	* makes things faster, and effectively the same result.	1364	* makes things faster, and effectively the same result.
1399	*/	1365	*/
…		…
1406	*/	1372	*/
1407	if (!(flag & INS_ON_TOP)	1373	if (!(flag & INS_ON_TOP)
1408	&& ms.flags () & P_BLOCKSVIEW	1374	&& ms.flags () & P_BLOCKSVIEW
1409	&& (op->face && !faces [op->face].visibility))	1375	&& (op->face && !faces [op->face].visibility))
1410	{	1376	{
		1377	object *last;
		1378
1411	for (last = top; last != floor; last = last->below)	1379	for (last = top; last != floor; last = last->below)
1412	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1380	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1413	break;	1381	break;
1414		1382
1415	/* Check to see if we found the object that blocks view,	1383	/* Check to see if we found the object that blocks view,
…		…
1426	top = floor;	1394	top = floor;
1427		1395
1428	/* Top is the object that our object (op) is going to get inserted above.	1396	/* Top is the object that our object (op) is going to get inserted above.
1429	*/	1397	*/
1430		1398
1431	/* First object on this space */	1399	/* no top found, insert on top */
1432	if (!top)	1400	if (!top)
1433	{	1401	{
1434	op->above = ms.bot;
1435
1436	if (op->above)
1437	op->above->below = op;
1438
1439	op->below = 0;	1402	op->above = 0;
		1403	op->below = ms.top;
1440	ms.bot = op;	1404	ms.top = op;
		1405
		1406	*(op->below ? &op->below->above : &ms.bot) = op;
1441	}	1407	}
1442	else	1408	else
1443	{ /* get inserted into the stack above top */	1409	{ /* get inserted into the stack above top */
1444	op->above = top->above;	1410	op->above = top->above;
1445
1446	if (op->above)
1447	op->above->below = op;	1411	top->above = op;
1448		1412
1449	op->below = top;	1413	op->below = top;
1450	top->above = op;	1414	*(op->above ? &op->above->below : &ms.top) = op;
1451	}	1415	}
1452
1453	if (!op->above)
1454	ms.top = op;
1455	} /* else not INS_BELOW_ORIGINATOR */	1416	} /* else not INS_BELOW_ORIGINATOR */
1456		1417
1457	if (op->type == PLAYER)	1418	if (op->type == PLAYER)
1458	{	1419	{
1459	op->contr->do_los = 1;	1420	op->contr->do_los = 1;
…		…
1596	}	1557	}
1597	else	1558	else
1598	{	1559	{
1599	decrease (nr);	1560	decrease (nr);
1600		1561
1601	object *op = object_create_clone (this);	1562	object *op = deep_clone ();
1602	op->nrof = nr;	1563	op->nrof = nr;
1603	return op;	1564	return op;
1604	}	1565	}
1605	}	1566	}
1606		1567
…		…
1827	LOG (llevError, "Present_arch called outside map.\n");	1788	LOG (llevError, "Present_arch called outside map.\n");
1828	return NULL;	1789	return NULL;
1829	}	1790	}
1830		1791
1831	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1792	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1832	if (tmp->arch == at)	1793	if (tmp->arch->archname == at->archname)
1833	return tmp;	1794	return tmp;
1834		1795
1835	return NULL;	1796	return NULL;
1836	}	1797	}
1837		1798
…		…
1901	* The first matching object is returned, or NULL if none.	1862	* The first matching object is returned, or NULL if none.
1902	*/	1863	*/
1903	object *	1864	object *
1904	present_arch_in_ob (const archetype at, const object op)	1865	present_arch_in_ob (const archetype at, const object op)
1905	{	1866	{
1906	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1867	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1907	if (tmp->arch == at)	1868	if (tmp->arch->archname == at->archname)
1908	return tmp;	1869	return tmp;
1909		1870
1910	return NULL;	1871	return NULL;
1911	}	1872	}
1912		1873
…		…
2321		2282
2322	/*	2283	/*
2323	* create clone from object to another	2284	* create clone from object to another
2324	*/	2285	*/
2325	object *	2286	object *
2326	object_create_clone (object *asrc)	2287	object::deep_clone ()
2327	{	2288	{
		2289	assert (("deep_clone called on non-head object", is_head ()));
		2290
2328	object *dst = 0;	2291	object *dst = clone ();
2329		2292
2330	if (!asrc)
2331	return 0;
2332
2333	object *src = asrc->head_ ();
2334
2335	object *prev = 0;	2293	object *prev = dst;
2336	for (object *part = src; part; part = part->more)	2294	for (object *part = this->more; part; part = part->more)
2337	{	2295	{
2338	object *tmp = part->clone ();	2296	object *tmp = part->clone ();
2339
2340	tmp->x -= src->x;
2341	tmp->y -= src->y;
2342
2343	if (!part->head)
2344	{
2345	dst = tmp;
2346	tmp->head = 0;
2347	}
2348	else
2349	tmp->head = dst;	2297	tmp->head = dst;
2350
2351	tmp->more = 0;
2352
2353	if (prev)
2354	prev->more = tmp;	2298	prev->more = tmp;
2355
2356	prev = tmp;	2299	prev = tmp;
2357	}	2300	}
2358		2301
2359	for (object *item = src->inv; item; item = item->below)	2302	for (object *item = inv; item; item = item->below)
2360	insert_ob_in_ob (object_create_clone (item), dst);	2303	insert_ob_in_ob (item->deep_clone (), dst);
2361		2304
2362	return dst;	2305	return dst;
2363	}	2306	}
2364		2307
2365	/* This returns the first object in who's inventory that	2308	/* This returns the first object in who's inventory that
…		…
2374	return tmp;	2317	return tmp;
2375		2318
2376	return 0;	2319	return 0;
2377	}	2320	}
2378		2321
2379	/* If ob has a field named key, return the link from the list,	2322	const shstr &
2380	* otherwise return NULL.	2323	object::kv_get (const shstr &key) const
2381	*
2382	* key must be a passed in shared string - otherwise, this won't
2383	* do the desired thing.
2384	*/
2385	key_value *
2386	get_ob_key_link (const object ob, const char key)
2387	{	2324	{
2388	for (key_value *link = ob->key_values; link; link = link->next)	2325	for (key_value *kv = key_values; kv; kv = kv->next)
2389	if (link->key == key)	2326	if (kv->key == key)
2390	return link;
2391
2392	return 0;
2393	}
2394
2395	/*
2396	* Returns the value of op has an extra_field for key, or NULL.
2397	*
2398	* The argument doesn't need to be a shared string.
2399	*
2400	* The returned string is shared.
2401	*/
2402	const char *
2403	get_ob_key_value (const object op, const char const key)
2404	{
2405	key_value *link;
2406	shstr_cmp canonical_key (key);
2407
2408	if (!canonical_key)
2409	{
2410	/* 1. There being a field named key on any object
2411	* implies there'd be a shared string to find.
2412	* 2. Since there isn't, no object has this field.
2413	* 3. Therefore, this object doesn't have this field.
2414	*/
2415	return 0;
2416	}
2417
2418	/* This is copied from get_ob_key_link() above -
2419	* only 4 lines, and saves the function call overhead.
2420	*/
2421	for (link = op->key_values; link; link = link->next)
2422	if (link->key == canonical_key)
2423	return link->value;	2327	return kv->value;
2424		2328
2425	return 0;	2329	return shstr_null;
2426	}	2330	}
2427		2331
2428	/*	2332	void
2429	* Updates the canonical_key in op to value.	2333	object::kv_set (const shstr &key, const shstr &value)
2430	*
2431	* canonical_key is a shared string (value doesn't have to be).
2432	*
2433	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2434	* keys.
2435	*
2436	* Returns TRUE on success.
2437	*/
2438	int
2439	set_ob_key_value_s (object op, const shstr & canonical_key, const char value, int add_key)
2440	{	2334	{
2441	key_value field = NULL, last = NULL;	2335	for (key_value *kv = key_values; kv; kv = kv->next)
2442		2336	if (kv->key == key)
2443	for (field = op->key_values; field != NULL; field = field->next)
2444	{
2445	if (field->key != canonical_key)
2446	{	2337	{
2447	last = field;	2338	kv->value = value;
2448	continue;	2339	return;
2449	}	2340	}
2450		2341
2451	if (value)	2342	key_value *kv = new key_value;
2452	field->value = value;	2343
2453	else	2344	kv->next = key_values;
		2345	kv->key = key;
		2346	kv->value = value;
		2347
		2348	key_values = kv;
		2349	}
		2350
		2351	void
		2352	object::kv_del (const shstr &key)
		2353	{
		2354	for (key_value *kvp = &key_values; kvp; kvp = &(*kvp)->next)
		2355	if ((*kvp)->key == key)
2454	{	2356	{
2455	/* Basically, if the archetype has this key set,	2357	key_value kv = kvp;
2456	* we need to store the null value so when we save	2358	kvp = (kvp)->next;
2457	* it, we save the empty value so that when we load,	2359	delete kv;
2458	* we get this value back again.	2360	return;
2459	*/
2460	if (get_ob_key_link (op->arch, canonical_key))
2461	field->value = 0;
2462	else
2463	{
2464	if (last)
2465	last->next = field->next;
2466	else
2467	op->key_values = field->next;
2468
2469	delete field;
2470	}
2471	}	2361	}
2472	return TRUE;
2473	}
2474	/* IF we get here, key doesn't exist */
2475
2476	/* No field, we'll have to add it. */
2477
2478	if (!add_key)
2479	return FALSE;
2480
2481	/* There isn't any good reason to store a null
2482	* value in the key/value list. If the archetype has
2483	* this key, then we should also have it, so shouldn't
2484	* be here. If user wants to store empty strings,
2485	* should pass in ""
2486	*/
2487	if (value == NULL)
2488	return TRUE;
2489
2490	field = new key_value;
2491
2492	field->key = canonical_key;
2493	field->value = value;
2494	/* Usual prepend-addition. */
2495	field->next = op->key_values;
2496	op->key_values = field;
2497
2498	return TRUE;
2499	}
2500
2501	/*
2502	* Updates the key in op to value.
2503	*
2504	* If add_key is FALSE, this will only update existing keys,
2505	* and not add new ones.
2506	* In general, should be little reason FALSE is ever passed in for add_key
2507	*
2508	* Returns TRUE on success.
2509	*/
2510	int
2511	set_ob_key_value (object op, const char key, const char *value, int add_key)
2512	{
2513	shstr key_ (key);
2514
2515	return set_ob_key_value_s (op, key_, value, add_key);
2516	}	2362	}
2517		2363
2518	object::depth_iterator::depth_iterator (object *container)	2364	object::depth_iterator::depth_iterator (object *container)
2519	: iterator_base (container)	2365	: iterator_base (container)
2520	{	2366	{

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.227 by root, Sat May 3 09:04:17 2008 UTC vs. Revision 1.238 by root, Wed May 7 11:02:50 2008 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.227 by root, Sat May 3 09:04:17 2008 UTC vs.
Revision 1.238 by root, Wed May 7 11:02:50 2008 UTC