ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.227 by root, Sat May 3 09:04:17 2008 UTC vs.
Revision 1.311 by root, Sat Jan 16 13:41:37 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42//+GPL
40 43
41short freearr_x[SIZEOFFREE] = { 44short freearr_x[SIZEOFFREE] = {
42 0, 45 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 46 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 47 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 51 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 52 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 53 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 54 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 55};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 56int freedir[SIZEOFFREE] = {
60 0, 57 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 58 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 59 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 60 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 61};
65 62
63static int maxfree[SIZEOFFREE] = {
64 0,
65 9, 10, 13, 14, 17, 18, 21, 22,
66 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
67 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
68};
69
66static void 70static void
67write_uuid (uval64 skip, bool sync) 71write_uuid (uval64 skip, bool sync)
68{ 72{
69 CALL_BEGIN (2); 73 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 74 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 76 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 77 CALL_END;
74} 78}
75 79
76static void 80static void
77read_uuid (void) 81read_uuid ()
78{ 82{
79 char filename[MAX_BUF]; 83 char filename[MAX_BUF];
80 84
81 sprintf (filename, "%s/uuid", settings.localdir); 85 sprintf (filename, "%s/uuid", settings.localdir);
82 86
96 100
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 101 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 102 _exit (1);
99 } 103 }
100 104
101 UUID::BUF buf; 105 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 106 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 107 fgets (buf, sizeof (buf), fp);
104 108
105 if (!UUID::cur.parse (buf)) 109 if (!UUID::cur.parse (buf))
106 { 110 {
133 137
134void 138void
135UUID::init () 139UUID::init ()
136{ 140{
137 read_uuid (); 141 read_uuid ();
142}
143
144bool
145UUID::parse (const char *s)
146{
147 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
148 return false;
149
150 seq = 0;
151
152 while (*s != '>')
153 {
154 if (*s < '0')
155 return false;
156
157 // this gives nice branchless code with gcc
158 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
159 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
160
161 seq = (seq << 4) | digit;
162
163 ++s;
164 }
165
166 return true;
167}
168
169char *
170UUID::append (char *buf) const
171{
172 *buf++ = '<';
173 *buf++ = '1';
174 *buf++ = '.';
175
176 uint64_t seq = this->seq;
177 const int bits = 64;
178 char nz = 0;
179 static const char tohex [] = "0123456789abcdef";
180
181 // assert (len >= 3 + bits / 4 + 1 + 1);
182 for (int i = bits / 4; --i; )
183 {
184 uint8_t digit = seq >> (bits - 4);
185
186 *buf = tohex [digit];
187 nz |= digit;
188 buf += nz ? 1 : 0;
189 seq <<= 4;
190 }
191
192 // last digit is special - always emit
193 uint8_t digit = seq >> (bits - 4);
194 *buf++ = tohex [digit];
195
196 *buf++ = '>';
197
198 return buf;
199}
200
201char *
202UUID::c_str () const
203{
204 static char buf [MAX_LEN];
205 *append (buf) = 0;
206 return buf;
138} 207}
139 208
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 209/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 210static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 211compare_ob_value_lists_one (const object *wants, const object *has)
143{ 212{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 213 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 214 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 215 * different structure or at least keep the lists sorted...
149 */ 216 */
150 217
151 /* For each field in wants, */ 218 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 219 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 220 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 221 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 222
169 /* If we get here, every field in wants has a matching field in has. */ 223 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 224 return true;
171} 225}
172 226
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 227/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 228static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 229compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 230{
177 /* However, there may be fields in has which aren't partnered in wants, 231 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 232 * so we need to run the comparison *twice*. :(
179 */ 233 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 234 return compare_ob_value_lists_one (ob1, ob2)
235 && compare_ob_value_lists_one (ob2, ob1);
181} 236}
182 237
183/* Function examines the 2 objects given to it, and returns true if 238/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 239 * they can be merged together.
185 * 240 *
192 * Improvements made with merge: Better checking on potion, and also 247 * Improvements made with merge: Better checking on potion, and also
193 * check weight 248 * check weight
194 */ 249 */
195bool object::can_merge_slow (object *ob1, object *ob2) 250bool object::can_merge_slow (object *ob1, object *ob2)
196{ 251{
197 /* A couple quicksanity checks */ 252 /* A couple quick sanity checks */
198 if (ob1 == ob2 253 if (ob1 == ob2
199 || ob1->type != ob2->type 254 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 255 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 256 || ob1->name != ob2->name
257 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
203 return 0; 258 return 0;
204 259
205 /* Do not merge objects if nrof would overflow. First part checks 260 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 261 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 262 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 263 return 0;
212 264
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 265 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 266 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 267 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 272 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 273
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 274 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 275 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 276
225 if (ob1->arch->name != ob2->arch->name 277 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 278 || ob1->name != ob2->name
227 || ob1->title != ob2->title 279 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 280 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 281 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 282 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 283 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 284 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 285 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 286 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 287 || ob1->animation_id != ob2->animation_id
288 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
236 || ob1->client_type != ob2->client_type 289 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 290 || ob1->material != ob2->material
238 || ob1->lore != ob2->lore 291 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 292 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 293 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 294 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 295 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 296 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 297 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 298 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 299 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 300 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 301 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 302 return 0;
250 303
251 if ((ob1->flag ^ ob2->flag) 304 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 305 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 306 .reset (FLAG_REMOVED)
255 .any ()) 307 .any ())
256 return 0; 308 return 0;
257 309
258 /* This is really a spellbook check - we should in general 310 /* This is really a spellbook check - we should in general
340 { 392 {
341 // see if we are in a container of sorts 393 // see if we are in a container of sorts
342 if (env) 394 if (env)
343 { 395 {
344 // the player inventory itself is always visible 396 // the player inventory itself is always visible
345 if (env->type == PLAYER) 397 if (env->is_player ())
346 return env; 398 return env;
347 399
348 // else a player could have our env open 400 // else a player could have our env open
349 object *envest = env->outer_env (); 401 object *envest = env->outer_env_or_self ();
350 402
351 // the player itself is always on a map, so we will find him here 403 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 404 // even if our inv is in a player.
353 if (envest->is_on_map ()) 405 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 406 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 407 if (pl->container_ () == env)
356 return pl; 408 return pl;
357 } 409 }
358 else 410 else
359 { 411 {
360 // maybe there is a player standing on the same mapspace 412 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 413 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 414 if (object *pl = ms ().player ())
363 if (!pl->container || this == pl->container) 415 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
416 || pl->container_ () == this)
364 return pl; 417 return pl;
365 } 418 }
366 } 419 }
367 420
368 return 0; 421 return 0;
369} 422}
370 423
371// adjust weight per container type ("of holding") 424// adjust weight per container type ("of holding")
372static sint32 425static sint32
373weight_adjust (object *op, sint32 weight) 426weight_adjust_for (object *op, sint32 weight)
374{ 427{
375 return op->type == CONTAINER 428 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 429 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 430 : weight;
378} 431}
384static void 437static void
385adjust_weight (object *op, sint32 weight) 438adjust_weight (object *op, sint32 weight)
386{ 439{
387 while (op) 440 while (op)
388 { 441 {
442 // adjust by actual difference to account for rounding errors
443 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 444 weight = weight_adjust_for (op, op->carrying)
445 - weight_adjust_for (op, op->carrying - weight);
390 446
391 if (!weight) 447 if (!weight)
392 return; 448 return;
393 449
394 op->carrying += weight; 450 op->carrying += weight;
417 op->update_weight (); 473 op->update_weight ();
418 474
419 sum += op->total_weight (); 475 sum += op->total_weight ();
420 } 476 }
421 477
422 sum = weight_adjust (this, sum); 478 sum = weight_adjust_for (this, sum);
423 479
424 if (sum != carrying) 480 if (sum != carrying)
425 { 481 {
426 carrying = sum; 482 carrying = sum;
427 483
443 object_freezer freezer; 499 object_freezer freezer;
444 op->write (freezer); 500 op->write (freezer);
445 return freezer.as_string (); 501 return freezer.as_string ();
446} 502}
447 503
448/* 504char *
449 * get_nearest_part(multi-object, object 2) returns the part of the 505object::as_string ()
450 * multi-object 1 which is closest to the second object.
451 * If it's not a multi-object, it is returned.
452 */
453object *
454get_nearest_part (object *op, const object *pl)
455{ 506{
456 object *tmp, *closest; 507 return dump_object (this);
457 int last_dist, i;
458
459 if (!op->more)
460 return op;
461
462 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
463 tmp;
464 tmp = tmp->more)
465 if ((i = distance (tmp, pl)) < last_dist)
466 closest = tmp, last_dist = i;
467
468 return closest;
469} 508}
470 509
471/* 510/*
472 * Returns the object which has the count-variable equal to the argument. 511 * Returns the object which has the count-variable equal to the argument.
473 * VERRRY slow. 512 * VERRRY slow.
489 */ 528 */
490object * 529object *
491find_object_name (const char *str) 530find_object_name (const char *str)
492{ 531{
493 shstr_cmp str_ (str); 532 shstr_cmp str_ (str);
494 object *op;
495 533
534 if (str_)
496 for_all_objects (op) 535 for_all_objects (op)
497 if (op->name == str_) 536 if (op->name == str_)
498 break; 537 return op;
499 538
500 return op; 539 return 0;
501} 540}
502 541
503/* 542/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 543 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 544 * skill and experience objects.
567 update_stats (); 606 update_stats ();
568 607
569 new_draw_info_format (NDI_UNIQUE, 0, this, 608 new_draw_info_format (NDI_UNIQUE, 0, this,
570 "You try to balance all your items at once, " 609 "You try to balance all your items at once, "
571 "but the %s is just too much for your body. " 610 "but the %s is just too much for your body. "
572 "[You need to unapply some items first.]", &ob->name); 611 "[You need to unapply some items first - use the 'body' command to see "
612 "how many items you cna wera on a specific body part.]", &ob->name);
573 return false; 613 return false;
574 } 614 }
575 615
576 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 616 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577 } 617 }
646 tail = new_link; 686 tail = new_link;
647 } 687 }
648 } 688 }
649 } 689 }
650 690
651 if (speed < 0) 691 dst->activate ();
652 dst->speed_left -= rndm ();
653
654 dst->set_speed (dst->speed);
655} 692}
656 693
657void 694void
658object::instantiate () 695object::instantiate ()
659{ 696{
660 if (!uuid.seq) // HACK 697 if (!uuid.seq) // HACK
661 uuid = UUID::gen (); 698 uuid = UUID::gen ();
662 699
700 // TODO: unclean state changes, should nt be done in copy_to AND instantiate
701 if (flag [FLAG_RANDOM_SPEED] && speed)
702 speed_left = - speed - rndm (); // TODO animation
703 else
663 speed_left = -0.1f; 704 speed_left = -1.;
705
664 /* copy the body_info to the body_used - this is only really 706 /* copy the body_info to the body_used - this is only really
665 * need for monsters, but doesn't hurt to do it for everything. 707 * need for monsters, but doesn't hurt to do it for everything.
666 * by doing so, when a monster is created, it has good starting 708 * by doing so, when a monster is created, it has good starting
667 * values for the body_used info, so when items are created 709 * values for the body_used info, so when items are created
668 * for it, they can be properly equipped. 710 * for it, they can be properly equipped.
676object * 718object *
677object::clone () 719object::clone ()
678{ 720{
679 object *neu = create (); 721 object *neu = create ();
680 copy_to (neu); 722 copy_to (neu);
723
724 // TODO: unclean state changes, should not be done in clone AND instantiate
725 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
726 neu->speed_left = - neu->speed - rndm (); // TODO animation
727
681 neu->map = map; // not copied by copy_to 728 neu->map = map; // not copied by copy_to
682 return neu; 729 return neu;
683} 730}
684 731
685/* 732/*
703 * This function needs to be called whenever the speed of an object changes. 750 * This function needs to be called whenever the speed of an object changes.
704 */ 751 */
705void 752void
706object::set_speed (float speed) 753object::set_speed (float speed)
707{ 754{
708 if (flag [FLAG_FREED] && speed)
709 {
710 LOG (llevError, "Object %s is freed but has speed.\n", &name);
711 speed = 0;
712 }
713
714 this->speed = speed; 755 this->speed = speed;
715 756
716 if (has_active_speed ()) 757 if (has_active_speed ())
717 activate (); 758 activate ();
718 else 759 else
768 809
769 if (!(m.flags_ & P_UPTODATE)) 810 if (!(m.flags_ & P_UPTODATE))
770 /* nop */; 811 /* nop */;
771 else if (action == UP_OBJ_INSERT) 812 else if (action == UP_OBJ_INSERT)
772 { 813 {
814#if 0
773 // this is likely overkill, TODO: revisit (schmorp) 815 // this is likely overkill, TODO: revisit (schmorp)
774 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 816 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
775 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 817 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
776 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 818 || (op->is_player () && !(m.flags_ & P_PLAYER))
777 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 819 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
778 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 820 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
779 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 821 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
780 || (m.move_on | op->move_on ) != m.move_on 822 || (m.move_on | op->move_on ) != m.move_on
781 || (m.move_off | op->move_off ) != m.move_off 823 || (m.move_off | op->move_off ) != m.move_off
782 || (m.move_slow | op->move_slow) != m.move_slow 824 || (m.move_slow | op->move_slow) != m.move_slow
783 /* This isn't perfect, but I don't expect a lot of objects to 825 /* This isn't perfect, but I don't expect a lot of objects to
784 * to have move_allow right now. 826 * have move_allow right now.
785 */ 827 */
786 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 828 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
829 m.invalidate ();
830#else
787 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 831 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
788 m.flags_ = 0; 832 m.invalidate ();
833#endif
789 } 834 }
790 /* if the object is being removed, we can't make intelligent 835 /* if the object is being removed, we can't make intelligent
791 * decisions, because remove_ob can't really pass the object 836 * decisions, because remove_ob can't really pass the object
792 * that is being removed. 837 * that is being removed.
793 */ 838 */
794 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 839 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
795 m.flags_ = 0; 840 m.invalidate ();
796 else if (action == UP_OBJ_FACE) 841 else if (action == UP_OBJ_FACE)
797 /* Nothing to do for that case */ ; 842 /* Nothing to do for that case */ ;
798 else 843 else
799 LOG (llevError, "update_object called with invalid action: %d\n", action); 844 LOG (llevError, "update_object called with invalid action: %d\n", action);
800 845
804 849
805object::object () 850object::object ()
806{ 851{
807 SET_FLAG (this, FLAG_REMOVED); 852 SET_FLAG (this, FLAG_REMOVED);
808 853
809 expmul = 1.0; 854 //expmul = 1.0; declared const for the time being
810 face = blank_face; 855 face = blank_face;
856 material = MATERIAL_NULL;
811} 857}
812 858
813object::~object () 859object::~object ()
814{ 860{
815 unlink (); 861 unlink ();
844 /* If already on active list, don't do anything */ 890 /* If already on active list, don't do anything */
845 if (active) 891 if (active)
846 return; 892 return;
847 893
848 if (has_active_speed ()) 894 if (has_active_speed ())
895 {
896 if (flag [FLAG_FREED])
897 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
898
849 actives.insert (this); 899 actives.insert (this);
900 }
850} 901}
851 902
852void 903void
853object::activate_recursive () 904object::activate_recursive ()
854{ 905{
915 * drop on that space. 966 * drop on that space.
916 */ 967 */
917 if (!drop_to_ground 968 if (!drop_to_ground
918 || !map 969 || !map
919 || map->in_memory != MAP_ACTIVE 970 || map->in_memory != MAP_ACTIVE
920 || map->nodrop 971 || map->no_drop
921 || ms ().move_block == MOVE_ALL) 972 || ms ().move_block == MOVE_ALL)
922 { 973 {
923 while (inv) 974 while (inv)
924 {
925 inv->destroy_inv (false);
926 inv->destroy (); 975 inv->destroy ();
927 }
928 } 976 }
929 else 977 else
930 { /* Put objects in inventory onto this space */ 978 { /* Put objects in inventory onto this space */
931 while (inv) 979 while (inv)
932 { 980 {
936 || op->flag [FLAG_NO_DROP] 984 || op->flag [FLAG_NO_DROP]
937 || op->type == RUNE 985 || op->type == RUNE
938 || op->type == TRAP 986 || op->type == TRAP
939 || op->flag [FLAG_IS_A_TEMPLATE] 987 || op->flag [FLAG_IS_A_TEMPLATE]
940 || op->flag [FLAG_DESTROY_ON_DEATH]) 988 || op->flag [FLAG_DESTROY_ON_DEATH])
941 op->destroy (true); 989 op->destroy ();
942 else 990 else
943 map->insert (op, x, y); 991 map->insert (op, x, y);
944 } 992 }
945 } 993 }
946} 994}
954 1002
955static struct freed_map : maptile 1003static struct freed_map : maptile
956{ 1004{
957 freed_map () 1005 freed_map ()
958 { 1006 {
959 path = "<freed objects map>"; 1007 path = "<freed objects map>";
960 name = "/internal/freed_objects_map"; 1008 name = "/internal/freed_objects_map";
961 width = 3; 1009 width = 3;
962 height = 3; 1010 height = 3;
963 nodrop = 1; 1011 no_drop = 1;
1012 no_reset = 1;
964 1013
965 alloc (); 1014 alloc ();
966 in_memory = MAP_ACTIVE; 1015 in_memory = MAP_ACTIVE;
967 } 1016 }
1017
1018 ~freed_map ()
1019 {
1020 destroy ();
1021 }
968} freed_map; // freed objects are moved here to avoid crashes 1022} freed_map; // freed objects are moved here to avoid crashes
969 1023
970void 1024void
971object::do_destroy () 1025object::do_destroy ()
972{ 1026{
973 if (flag [FLAG_IS_LINKED]) 1027 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 1028 remove_link ();
975 1029
976 if (flag [FLAG_FRIENDLY]) 1030 if (flag [FLAG_FRIENDLY])
977 remove_friendly_object (this); 1031 remove_friendly_object (this);
978 1032
979 remove (); 1033 remove ();
1004 attacked_by = 0; 1058 attacked_by = 0;
1005 current_weapon = 0; 1059 current_weapon = 0;
1006} 1060}
1007 1061
1008void 1062void
1009object::destroy (bool destroy_inventory) 1063object::destroy ()
1010{ 1064{
1011 if (destroyed ()) 1065 if (destroyed ())
1012 return; 1066 return;
1013 1067
1014 if (!is_head () && !head->destroyed ()) 1068 if (!is_head () && !head->destroyed ())
1015 { 1069 {
1016 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1070 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1017 head->destroy (destroy_inventory); 1071 head->destroy ();
1018 return; 1072 return;
1019 } 1073 }
1020 1074
1021 destroy_inv (!destroy_inventory); 1075 destroy_inv (false);
1022 1076
1023 if (is_head ()) 1077 if (is_head ())
1024 if (sound_destroy) 1078 if (sound_destroy)
1025 play_sound (sound_destroy); 1079 play_sound (sound_destroy);
1026 else if (flag [FLAG_MONSTER]) 1080 else if (flag [FLAG_MONSTER])
1037 * the previous environment. 1091 * the previous environment.
1038 */ 1092 */
1039void 1093void
1040object::do_remove () 1094object::do_remove ()
1041{ 1095{
1042 object *tmp, *last = 0;
1043 object *otmp;
1044
1045 if (flag [FLAG_REMOVED]) 1096 if (flag [FLAG_REMOVED])
1046 return; 1097 return;
1047 1098
1048 INVOKE_OBJECT (REMOVE, this); 1099 INVOKE_OBJECT (REMOVE, this);
1049 1100
1063 esrv_del_item (pl->contr, count); 1114 esrv_del_item (pl->contr, count);
1064 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1115 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1065 1116
1066 adjust_weight (env, -total_weight ()); 1117 adjust_weight (env, -total_weight ());
1067 1118
1068 *(above ? &above->below : &env->inv) = below; 1119 object *pl = in_player ();
1069
1070 if (below)
1071 below->above = above;
1072 1120
1073 /* we set up values so that it could be inserted into 1121 /* we set up values so that it could be inserted into
1074 * the map, but we don't actually do that - it is up 1122 * the map, but we don't actually do that - it is up
1075 * to the caller to decide what we want to do. 1123 * to the caller to decide what we want to do.
1076 */ 1124 */
1077 map = env->map; 1125 map = env->map;
1078 x = env->x; 1126 x = env->x;
1079 y = env->y; 1127 y = env->y;
1128
1129 // make sure cmov optimisation is applicable
1130 *(above ? &above->below : &env->inv) = below;
1131 *(below ? &below->above : &above ) = above; // &above is just a dummy
1132
1080 above = 0; 1133 above = 0;
1081 below = 0; 1134 below = 0;
1082 env = 0; 1135 env = 0;
1083 1136
1084 /* NO_FIX_PLAYER is set when a great many changes are being 1137 if (pl && pl->is_player ())
1085 * made to players inventory. If set, avoiding the call
1086 * to save cpu time.
1087 */ 1138 {
1088 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1139 pl->contr->queue_stats_update ();
1089 otmp->update_stats (); 1140
1141 if (glow_radius && pl->is_on_map ())
1142 update_all_los (pl->map, pl->x, pl->y);
1143 }
1090 } 1144 }
1091 else if (map) 1145 else if (map)
1092 { 1146 {
1093 map->dirty = true; 1147 map->dirty = true;
1094 mapspace &ms = this->ms (); 1148 mapspace &ms = this->ms ();
1095 1149
1096 if (object *pl = ms.player ()) 1150 if (object *pl = ms.player ())
1097 { 1151 {
1098 if (type == PLAYER) // this == pl(!) 1152 if (is_player ())
1099 { 1153 {
1154 if (!flag [FLAG_WIZPASS])
1155 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1156
1100 // leaving a spot always closes any open container on the ground 1157 // leaving a spot always closes any open container on the ground
1101 if (container && !container->env) 1158 if (container && !container->env)
1102 // this causes spurious floorbox updates, but it ensures 1159 // this causes spurious floorbox updates, but it ensures
1103 // that the CLOSE event is being sent. 1160 // that the CLOSE event is being sent.
1104 close_container (); 1161 close_container ();
1105 1162
1106 --map->players; 1163 --map->players;
1107 map->touch (); 1164 map->touch ();
1108 } 1165 }
1109 else if (pl->container == this) 1166 else if (pl->container_ () == this)
1110 { 1167 {
1111 // removing a container should close it 1168 // removing a container should close it
1112 close_container (); 1169 close_container ();
1113 } 1170 }
1114 1171
1115 esrv_del_item (pl->contr, count); 1172 esrv_del_item (pl->contr, count);
1116 } 1173 }
1117 1174
1118 /* link the object above us */ 1175 /* link the object above us */
1119 if (above) 1176 // re-link, make sure compiler can easily use cmove
1120 above->below = below; 1177 *(above ? &above->below : &ms.top) = below;
1121 else 1178 *(below ? &below->above : &ms.bot) = above;
1122 ms.top = below; /* we were top, set new top */
1123
1124 /* Relink the object below us, if there is one */
1125 if (below)
1126 below->above = above;
1127 else
1128 {
1129 /* Nothing below, which means we need to relink map object for this space
1130 * use translated coordinates in case some oddness with map tiling is
1131 * evident
1132 */
1133 if (GET_MAP_OB (map, x, y) != this)
1134 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1135
1136 ms.bot = above; /* goes on above it. */
1137 }
1138 1179
1139 above = 0; 1180 above = 0;
1140 below = 0; 1181 below = 0;
1141 1182
1183 ms.invalidate ();
1184
1142 if (map->in_memory == MAP_SAVING) 1185 if (map->in_memory == MAP_SAVING)
1143 return; 1186 return;
1144 1187
1145 int check_walk_off = !flag [FLAG_NO_APPLY]; 1188 int check_walk_off = !flag [FLAG_NO_APPLY];
1146 1189
1147 if (object *pl = ms.player ()) 1190 if (object *pl = ms.player ())
1148 { 1191 {
1149 if (pl->container == this) 1192 if (pl->container_ () == this)
1150 /* If a container that the player is currently using somehow gets 1193 /* If a container that the player is currently using somehow gets
1151 * removed (most likely destroyed), update the player view 1194 * removed (most likely destroyed), update the player view
1152 * appropriately. 1195 * appropriately.
1153 */ 1196 */
1154 pl->close_container (); 1197 pl->close_container ();
1158 //TODO: update floorbox to preserve ordering 1201 //TODO: update floorbox to preserve ordering
1159 if (pl->contr->ns) 1202 if (pl->contr->ns)
1160 pl->contr->ns->floorbox_update (); 1203 pl->contr->ns->floorbox_update ();
1161 } 1204 }
1162 1205
1206 if (check_walk_off)
1163 for (tmp = ms.bot; tmp; tmp = tmp->above) 1207 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1164 { 1208 {
1209 above = tmp->above;
1210
1165 /* No point updating the players look faces if he is the object 1211 /* No point updating the players look faces if he is the object
1166 * being removed. 1212 * being removed.
1167 */ 1213 */
1168 1214
1169 /* See if object moving off should effect something */ 1215 /* See if object moving off should effect something */
1170 if (check_walk_off
1171 && ((move_type & tmp->move_off) 1216 if ((move_type & tmp->move_off)
1172 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1217 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1173 {
1174 move_apply (tmp, this, 0); 1218 move_apply (tmp, this, 0);
1175
1176 if (destroyed ())
1177 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1178 } 1219 }
1179 1220
1180 last = tmp; 1221 if (affects_los ())
1181 }
1182
1183 /* last == NULL if there are no objects on this space */
1184 //TODO: this makes little sense, why only update the topmost object?
1185 if (!last)
1186 map->at (x, y).flags_ = 0;
1187 else
1188 update_object (last, UP_OBJ_REMOVE);
1189
1190 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1191 update_all_los (map, x, y); 1222 update_all_los (map, x, y);
1192 } 1223 }
1193} 1224}
1194 1225
1195/* 1226/*
1219 esrv_update_item (UPD_NROF, pl, top); 1250 esrv_update_item (UPD_NROF, pl, top);
1220 1251
1221 op->weight = 0; // cancel the addition above 1252 op->weight = 0; // cancel the addition above
1222 op->carrying = 0; // must be 0 already 1253 op->carrying = 0; // must be 0 already
1223 1254
1224 op->destroy (1); 1255 op->destroy ();
1225 1256
1226 return top; 1257 return top;
1227 } 1258 }
1228 1259
1229 return 0; 1260 return 0;
1237 1268
1238 object *prev = this; 1269 object *prev = this;
1239 1270
1240 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1271 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1241 { 1272 {
1242 object *op = arch_to_object (at); 1273 object *op = at->instance ();
1243 1274
1244 op->name = name; 1275 op->name = name;
1245 op->name_pl = name_pl; 1276 op->name_pl = name_pl;
1246 op->title = title; 1277 op->title = title;
1247 1278
1257 * job preparing multi-part monsters. 1288 * job preparing multi-part monsters.
1258 */ 1289 */
1259object * 1290object *
1260insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1291insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1261{ 1292{
1293 op->remove ();
1294
1262 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1295 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1263 { 1296 {
1264 tmp->x = x + tmp->arch->x; 1297 tmp->x = x + tmp->arch->x;
1265 tmp->y = y + tmp->arch->y; 1298 tmp->y = y + tmp->arch->y;
1266 } 1299 }
1289 * just 'op' otherwise 1322 * just 'op' otherwise
1290 */ 1323 */
1291object * 1324object *
1292insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1325insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1293{ 1326{
1294 assert (!op->flag [FLAG_FREED]);
1295
1296 op->remove (); 1327 op->remove ();
1328
1329 if (m == &freed_map)//D TODO: remove soon
1330 {//D
1331 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1332 }//D
1297 1333
1298 /* Ideally, the caller figures this out. However, it complicates a lot 1334 /* Ideally, the caller figures this out. However, it complicates a lot
1299 * of areas of callers (eg, anything that uses find_free_spot would now 1335 * of areas of callers (eg, anything that uses find_free_spot would now
1300 * need extra work 1336 * need extra work
1301 */ 1337 */
1338 maptile *newmap = m;
1302 if (!xy_normalise (m, op->x, op->y)) 1339 if (!xy_normalise (newmap, op->x, op->y))
1303 { 1340 {
1304 op->destroy (1); 1341 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1305 return 0; 1342 return 0;
1306 } 1343 }
1307 1344
1308 if (object *more = op->more) 1345 if (object *more = op->more)
1309 if (!insert_ob_in_map (more, m, originator, flag)) 1346 if (!insert_ob_in_map (more, m, originator, flag))
1310 return 0; 1347 return 0;
1311 1348
1312 CLEAR_FLAG (op, FLAG_REMOVED); 1349 op->flag [FLAG_REMOVED] = false;
1313 1350 op->env = 0;
1314 op->map = m; 1351 op->map = newmap;
1352
1315 mapspace &ms = op->ms (); 1353 mapspace &ms = op->ms ();
1316 1354
1317 /* this has to be done after we translate the coordinates. 1355 /* this has to be done after we translate the coordinates.
1318 */ 1356 */
1319 if (op->nrof && !(flag & INS_NO_MERGE)) 1357 if (op->nrof && !(flag & INS_NO_MERGE))
1320 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1358 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1321 if (object::can_merge (op, tmp)) 1359 if (object::can_merge (op, tmp))
1322 { 1360 {
1323 // TODO: we atcually want to update tmp, not op, 1361 // TODO: we actually want to update tmp, not op,
1324 // but some caller surely breaks when we return tmp 1362 // but some caller surely breaks when we return tmp
1325 // from here :/ 1363 // from here :/
1326 op->nrof += tmp->nrof; 1364 op->nrof += tmp->nrof;
1327 tmp->destroy (1); 1365 tmp->destroy ();
1328 } 1366 }
1329 1367
1330 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1368 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1331 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1369 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1332 1370
1339 { 1377 {
1340 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1378 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1341 abort (); 1379 abort ();
1342 } 1380 }
1343 1381
1382 if (!originator->is_on_map ())
1383 {
1384 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1385 op->debug_desc (), originator->debug_desc ());
1386 abort ();
1387 }
1388
1344 op->above = originator; 1389 op->above = originator;
1345 op->below = originator->below; 1390 op->below = originator->below;
1346
1347 if (op->below)
1348 op->below->above = op;
1349 else
1350 ms.bot = op;
1351
1352 /* since *below* originator, no need to update top */
1353 originator->below = op; 1391 originator->below = op;
1392
1393 *(op->below ? &op->below->above : &ms.bot) = op;
1354 } 1394 }
1355 else 1395 else
1356 { 1396 {
1357 object *top, *floor = NULL; 1397 object *floor = 0;
1358 1398 object *top = ms.top;
1359 top = ms.bot;
1360 1399
1361 /* If there are other objects, then */ 1400 /* If there are other objects, then */
1362 if (top) 1401 if (top)
1363 { 1402 {
1364 object *last = 0;
1365
1366 /* 1403 /*
1367 * If there are multiple objects on this space, we do some trickier handling. 1404 * If there are multiple objects on this space, we do some trickier handling.
1368 * We've already dealt with merging if appropriate. 1405 * We've already dealt with merging if appropriate.
1369 * Generally, we want to put the new object on top. But if 1406 * Generally, we want to put the new object on top. But if
1370 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1407 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1373 * once we get to them. This reduces the need to traverse over all of 1410 * once we get to them. This reduces the need to traverse over all of
1374 * them when adding another one - this saves quite a bit of cpu time 1411 * them when adding another one - this saves quite a bit of cpu time
1375 * when lots of spells are cast in one area. Currently, it is presumed 1412 * when lots of spells are cast in one area. Currently, it is presumed
1376 * that flying non pickable objects are spell objects. 1413 * that flying non pickable objects are spell objects.
1377 */ 1414 */
1378 for (top = ms.bot; top; top = top->above) 1415 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1379 { 1416 {
1380 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1417 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1381 floor = top; 1418 floor = tmp;
1382 1419
1383 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1420 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1384 { 1421 {
1385 /* We insert above top, so we want this object below this */ 1422 /* We insert above top, so we want this object below this */
1386 top = top->below; 1423 top = tmp->below;
1387 break; 1424 break;
1388 } 1425 }
1389 1426
1390 last = top; 1427 top = tmp;
1391 } 1428 }
1392
1393 /* Don't want top to be NULL, so set it to the last valid object */
1394 top = last;
1395 1429
1396 /* We let update_position deal with figuring out what the space 1430 /* We let update_position deal with figuring out what the space
1397 * looks like instead of lots of conditions here. 1431 * looks like instead of lots of conditions here.
1398 * makes things faster, and effectively the same result. 1432 * makes things faster, and effectively the same result.
1399 */ 1433 */
1406 */ 1440 */
1407 if (!(flag & INS_ON_TOP) 1441 if (!(flag & INS_ON_TOP)
1408 && ms.flags () & P_BLOCKSVIEW 1442 && ms.flags () & P_BLOCKSVIEW
1409 && (op->face && !faces [op->face].visibility)) 1443 && (op->face && !faces [op->face].visibility))
1410 { 1444 {
1445 object *last;
1446
1411 for (last = top; last != floor; last = last->below) 1447 for (last = top; last != floor; last = last->below)
1412 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1448 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1413 break; 1449 break;
1414 1450
1415 /* Check to see if we found the object that blocks view, 1451 /* Check to see if we found the object that blocks view,
1423 } /* If objects on this space */ 1459 } /* If objects on this space */
1424 1460
1425 if (flag & INS_ABOVE_FLOOR_ONLY) 1461 if (flag & INS_ABOVE_FLOOR_ONLY)
1426 top = floor; 1462 top = floor;
1427 1463
1428 /* Top is the object that our object (op) is going to get inserted above. 1464 // insert object above top, or bottom-most if top = 0
1429 */
1430
1431 /* First object on this space */
1432 if (!top) 1465 if (!top)
1433 { 1466 {
1467 op->below = 0;
1434 op->above = ms.bot; 1468 op->above = ms.bot;
1435
1436 if (op->above)
1437 op->above->below = op;
1438
1439 op->below = 0;
1440 ms.bot = op; 1469 ms.bot = op;
1470
1471 *(op->above ? &op->above->below : &ms.top) = op;
1441 } 1472 }
1442 else 1473 else
1443 { /* get inserted into the stack above top */ 1474 {
1444 op->above = top->above; 1475 op->above = top->above;
1445
1446 if (op->above)
1447 op->above->below = op; 1476 top->above = op;
1448 1477
1449 op->below = top; 1478 op->below = top;
1450 top->above = op; 1479 *(op->above ? &op->above->below : &ms.top) = op;
1451 } 1480 }
1481 }
1452 1482
1453 if (!op->above) 1483 if (op->is_player ())
1454 ms.top = op;
1455 } /* else not INS_BELOW_ORIGINATOR */
1456
1457 if (op->type == PLAYER)
1458 { 1484 {
1459 op->contr->do_los = 1; 1485 op->contr->do_los = 1;
1460 ++op->map->players; 1486 ++op->map->players;
1461 op->map->touch (); 1487 op->map->touch ();
1462 } 1488 }
1477 * be far away from this change and not affected in any way - 1503 * be far away from this change and not affected in any way -
1478 * this should get redone to only look for players within range, 1504 * this should get redone to only look for players within range,
1479 * or just updating the P_UPTODATE for spaces within this area 1505 * or just updating the P_UPTODATE for spaces within this area
1480 * of effect may be sufficient. 1506 * of effect may be sufficient.
1481 */ 1507 */
1482 if (op->map->darkness && (op->glow_radius != 0)) 1508 if (op->affects_los ())
1509 {
1510 op->ms ().invalidate ();
1483 update_all_los (op->map, op->x, op->y); 1511 update_all_los (op->map, op->x, op->y);
1512 }
1484 1513
1485 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1514 /* updates flags (blocked, alive, no magic, etc) for this map space */
1486 update_object (op, UP_OBJ_INSERT); 1515 update_object (op, UP_OBJ_INSERT);
1487 1516
1488 INVOKE_OBJECT (INSERT, op); 1517 INVOKE_OBJECT (INSERT, op);
1495 * blocked() and wall() work properly), and these flags are updated by 1524 * blocked() and wall() work properly), and these flags are updated by
1496 * update_object(). 1525 * update_object().
1497 */ 1526 */
1498 1527
1499 /* if this is not the head or flag has been passed, don't check walk on status */ 1528 /* if this is not the head or flag has been passed, don't check walk on status */
1500 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1529 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1501 { 1530 {
1502 if (check_move_on (op, originator)) 1531 if (check_move_on (op, originator))
1503 return 0; 1532 return 0;
1504 1533
1505 /* If we are a multi part object, lets work our way through the check 1534 /* If we are a multi part object, lets work our way through the check
1516/* this function inserts an object in the map, but if it 1545/* this function inserts an object in the map, but if it
1517 * finds an object of its own type, it'll remove that one first. 1546 * finds an object of its own type, it'll remove that one first.
1518 * op is the object to insert it under: supplies x and the map. 1547 * op is the object to insert it under: supplies x and the map.
1519 */ 1548 */
1520void 1549void
1521replace_insert_ob_in_map (const char *arch_string, object *op) 1550replace_insert_ob_in_map (shstr_tmp archname, object *op)
1522{ 1551{
1523 /* first search for itself and remove any old instances */ 1552 /* first search for itself and remove any old instances */
1524 1553
1525 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1554 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1526 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1555 if (tmp->arch->archname == archname) /* same archetype */
1527 tmp->destroy (1); 1556 tmp->destroy ();
1528 1557
1529 object *tmp = arch_to_object (archetype::find (arch_string)); 1558 object *tmp = archetype::find (archname)->instance ();
1530 1559
1531 tmp->x = op->x; 1560 tmp->x = op->x;
1532 tmp->y = op->y; 1561 tmp->y = op->y;
1533 1562
1534 insert_ob_in_map (tmp, op->map, op, 0); 1563 insert_ob_in_map (tmp, op->map, op, 0);
1539{ 1568{
1540 if (where->env) 1569 if (where->env)
1541 return where->env->insert (this); 1570 return where->env->insert (this);
1542 else 1571 else
1543 return where->map->insert (this, where->x, where->y, originator, flags); 1572 return where->map->insert (this, where->x, where->y, originator, flags);
1573}
1574
1575// check whether we can put this into the map, respect max_volume, max_items
1576bool
1577object::can_drop_at (maptile *m, int x, int y, object *originator)
1578{
1579 mapspace &ms = m->at (x, y);
1580
1581 int items = ms.items ();
1582
1583 if (!items // testing !items ensures we can drop at least one item
1584 || (items < m->max_items
1585 && ms.volume () < m->max_volume))
1586 return true;
1587
1588 if (originator && originator->is_player ())
1589 originator->contr->failmsg (format (
1590 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1591 query_name ()
1592 ));
1593
1594 return false;
1544} 1595}
1545 1596
1546/* 1597/*
1547 * decrease(object, number) decreases a specified number from 1598 * decrease(object, number) decreases a specified number from
1548 * the amount of an object. If the amount reaches 0, the object 1599 * the amount of an object. If the amount reaches 0, the object
1556 if (!nr) 1607 if (!nr)
1557 return true; 1608 return true;
1558 1609
1559 nr = min (nr, nrof); 1610 nr = min (nr, nrof);
1560 1611
1612 if (nrof > nr)
1613 {
1561 nrof -= nr; 1614 nrof -= nr;
1562
1563 if (nrof)
1564 {
1565 adjust_weight (env, -weight * nr); // carrying == 0 1615 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1566 1616
1567 if (object *pl = visible_to ()) 1617 if (object *pl = visible_to ())
1568 esrv_update_item (UPD_NROF, pl, this); 1618 esrv_update_item (UPD_NROF, pl, this);
1569 1619
1570 return true; 1620 return true;
1571 } 1621 }
1572 else 1622 else
1573 { 1623 {
1574 destroy (1); 1624 destroy ();
1575 return false; 1625 return false;
1576 } 1626 }
1577} 1627}
1578 1628
1579/* 1629/*
1596 } 1646 }
1597 else 1647 else
1598 { 1648 {
1599 decrease (nr); 1649 decrease (nr);
1600 1650
1601 object *op = object_create_clone (this); 1651 object *op = deep_clone ();
1602 op->nrof = nr; 1652 op->nrof = nr;
1603 return op; 1653 return op;
1604 } 1654 }
1605} 1655}
1606 1656
1656 if (object *pl = tmp->visible_to ()) 1706 if (object *pl = tmp->visible_to ())
1657 esrv_update_item (UPD_NROF, pl, tmp); 1707 esrv_update_item (UPD_NROF, pl, tmp);
1658 1708
1659 adjust_weight (this, op->total_weight ()); 1709 adjust_weight (this, op->total_weight ());
1660 1710
1661 op->destroy (1); 1711 op->destroy ();
1662 op = tmp; 1712 op = tmp;
1663 goto inserted; 1713 goto inserted;
1664 } 1714 }
1665 1715
1666 op->owner = 0; // it's his/hers now. period. 1716 op->owner = 0; // it's his/hers now. period.
1684 1734
1685 adjust_weight (this, op->total_weight ()); 1735 adjust_weight (this, op->total_weight ());
1686 1736
1687inserted: 1737inserted:
1688 /* reset the light list and los of the players on the map */ 1738 /* reset the light list and los of the players on the map */
1689 if (op->glow_radius && map && map->darkness) 1739 if (op->glow_radius && is_on_map ())
1740 {
1741 update_stats ();
1690 update_all_los (map, x, y); 1742 update_all_los (map, x, y);
1691 1743 }
1744 else if (is_player ())
1692 // if this is a player's inventory, update stats 1745 // if this is a player's inventory, update stats
1693 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1746 contr->queue_stats_update ();
1694 update_stats ();
1695 1747
1696 INVOKE_OBJECT (INSERT, this); 1748 INVOKE_OBJECT (INSERT, this);
1697 1749
1698 return op; 1750 return op;
1699} 1751}
1719 * on top. 1771 * on top.
1720 */ 1772 */
1721int 1773int
1722check_move_on (object *op, object *originator) 1774check_move_on (object *op, object *originator)
1723{ 1775{
1776 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1777 return 0;
1778
1724 object *tmp; 1779 object *tmp;
1725 maptile *m = op->map; 1780 maptile *m = op->map;
1726 int x = op->x, y = op->y; 1781 int x = op->x, y = op->y;
1727 1782
1728 MoveType move_on, move_slow, move_block; 1783 mapspace &ms = m->at (x, y);
1729 1784
1730 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1785 ms.update ();
1731 return 0;
1732 1786
1733 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1787 MoveType move_on = ms.move_on;
1734 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1788 MoveType move_slow = ms.move_slow;
1735 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1789 MoveType move_block = ms.move_block;
1736 1790
1737 /* if nothing on this space will slow op down or be applied, 1791 /* if nothing on this space will slow op down or be applied,
1738 * no need to do checking below. have to make sure move_type 1792 * no need to do checking below. have to make sure move_type
1739 * is set, as lots of objects don't have it set - we treat that 1793 * is set, as lots of objects don't have it set - we treat that
1740 * as walking. 1794 * as walking.
1751 return 0; 1805 return 0;
1752 1806
1753 /* The objects have to be checked from top to bottom. 1807 /* The objects have to be checked from top to bottom.
1754 * Hence, we first go to the top: 1808 * Hence, we first go to the top:
1755 */ 1809 */
1756 1810 for (object *next, *tmp = ms.top; tmp; tmp = next)
1757 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1758 {
1759 /* Trim the search when we find the first other spell effect
1760 * this helps performance so that if a space has 50 spell objects,
1761 * we don't need to check all of them.
1762 */
1763 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1764 break;
1765 } 1811 {
1812 next = tmp->below;
1766 1813
1767 for (; tmp; tmp = tmp->below)
1768 {
1769 if (tmp == op) 1814 if (tmp == op)
1770 continue; /* Can't apply yourself */ 1815 continue; /* Can't apply yourself */
1771 1816
1772 /* Check to see if one of the movement types should be slowed down. 1817 /* Check to see if one of the movement types should be slowed down.
1773 * Second check makes sure that the movement types not being slowed 1818 * Second check makes sure that the movement types not being slowed
1778 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1823 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1779 { 1824 {
1780 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1825 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1781 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1826 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1782 { 1827 {
1783
1784 float
1785 diff = tmp->move_slow_penalty * fabs (op->speed); 1828 float diff = tmp->move_slow_penalty * fabs (op->speed);
1786 1829
1787 if (op->type == PLAYER) 1830 if (op->is_player ())
1788 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1831 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1789 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1832 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1790 diff /= 4.0; 1833 diff /= 4.0;
1791 1834
1792 op->speed_left -= diff; 1835 op->speed_left -= diff;
1793 } 1836 }
1794 } 1837 }
1827 LOG (llevError, "Present_arch called outside map.\n"); 1870 LOG (llevError, "Present_arch called outside map.\n");
1828 return NULL; 1871 return NULL;
1829 } 1872 }
1830 1873
1831 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1874 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1832 if (tmp->arch == at) 1875 if (tmp->arch->archname == at->archname)
1833 return tmp; 1876 return tmp;
1834 1877
1835 return NULL; 1878 return NULL;
1836} 1879}
1837 1880
1901 * The first matching object is returned, or NULL if none. 1944 * The first matching object is returned, or NULL if none.
1902 */ 1945 */
1903object * 1946object *
1904present_arch_in_ob (const archetype *at, const object *op) 1947present_arch_in_ob (const archetype *at, const object *op)
1905{ 1948{
1906 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1949 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1907 if (tmp->arch == at) 1950 if (tmp->arch->archname == at->archname)
1908 return tmp; 1951 return tmp;
1909 1952
1910 return NULL; 1953 return NULL;
1911} 1954}
1912 1955
2000 * head of the object should correspond for the entire object. 2043 * head of the object should correspond for the entire object.
2001 */ 2044 */
2002 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2045 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2003 continue; 2046 continue;
2004 2047
2005 if (ob->blocked (m, pos.x, pos.y)) 2048 if (ob->blocked (pos.m, pos.x, pos.y))
2006 continue; 2049 continue;
2007 2050
2008 altern [index++] = i; 2051 altern [index++] = i;
2009 } 2052 }
2010 2053
2078 * there is capable of. 2121 * there is capable of.
2079 */ 2122 */
2080int 2123int
2081find_dir (maptile *m, int x, int y, object *exclude) 2124find_dir (maptile *m, int x, int y, object *exclude)
2082{ 2125{
2083 int i, max = SIZEOFFREE, mflags; 2126 int max = SIZEOFFREE, mflags;
2084
2085 sint16 nx, ny;
2086 object *tmp;
2087 maptile *mp;
2088
2089 MoveType blocked, move_type; 2127 MoveType move_type;
2090 2128
2091 if (exclude && exclude->head_ () != exclude) 2129 if (exclude && exclude->head_ () != exclude)
2092 { 2130 {
2093 exclude = exclude->head; 2131 exclude = exclude->head;
2094 move_type = exclude->move_type; 2132 move_type = exclude->move_type;
2097 { 2135 {
2098 /* If we don't have anything, presume it can use all movement types. */ 2136 /* If we don't have anything, presume it can use all movement types. */
2099 move_type = MOVE_ALL; 2137 move_type = MOVE_ALL;
2100 } 2138 }
2101 2139
2102 for (i = 1; i < max; i++) 2140 for (int i = 1; i < max; i++)
2103 { 2141 {
2104 mp = m; 2142 mapxy pos (m, x, y);
2105 nx = x + freearr_x[i]; 2143 pos.move (i);
2106 ny = y + freearr_y[i];
2107 2144
2108 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2145 if (!pos.normalise ())
2109
2110 if (mflags & P_OUT_OF_MAP)
2111 max = maxfree[i]; 2146 max = maxfree[i];
2112 else 2147 else
2113 { 2148 {
2114 mapspace &ms = mp->at (nx, ny); 2149 mapspace &ms = *pos;
2115 2150
2116 blocked = ms.move_block;
2117
2118 if ((move_type & blocked) == move_type) 2151 if ((move_type & ms.move_block) == move_type)
2119 max = maxfree[i]; 2152 max = maxfree [i];
2120 else if (mflags & P_IS_ALIVE) 2153 else if (ms.flags () & P_IS_ALIVE)
2121 { 2154 {
2122 for (tmp = ms.bot; tmp; tmp = tmp->above) 2155 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2123 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2156 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2124 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2157 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2125 break;
2126
2127 if (tmp)
2128 return freedir[i]; 2158 return freedir [i];
2129 } 2159 }
2130 } 2160 }
2131 } 2161 }
2132 2162
2133 return 0; 2163 return 0;
2208 * This basically means that if direction is 15, then it could either go 2238 * This basically means that if direction is 15, then it could either go
2209 * direction 4, 14, or 16 to get back to where we are. 2239 * direction 4, 14, or 16 to get back to where we are.
2210 * Moved from spell_util.c to object.c with the other related direction 2240 * Moved from spell_util.c to object.c with the other related direction
2211 * functions. 2241 * functions.
2212 */ 2242 */
2213int reduction_dir[SIZEOFFREE][3] = { 2243static const int reduction_dir[SIZEOFFREE][3] = {
2214 {0, 0, 0}, /* 0 */ 2244 {0, 0, 0}, /* 0 */
2215 {0, 0, 0}, /* 1 */ 2245 {0, 0, 0}, /* 1 */
2216 {0, 0, 0}, /* 2 */ 2246 {0, 0, 0}, /* 2 */
2217 {0, 0, 0}, /* 3 */ 2247 {0, 0, 0}, /* 3 */
2218 {0, 0, 0}, /* 4 */ 2248 {0, 0, 0}, /* 4 */
2314int 2344int
2315can_pick (const object *who, const object *item) 2345can_pick (const object *who, const object *item)
2316{ 2346{
2317 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2347 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2318 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2348 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2319 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2349 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2320} 2350}
2321 2351
2322/* 2352/*
2323 * create clone from object to another 2353 * create clone from object to another
2324 */ 2354 */
2325object * 2355object *
2326object_create_clone (object *asrc) 2356object::deep_clone ()
2327{ 2357{
2358 assert (("deep_clone called on non-head object", is_head ()));
2359
2328 object *dst = 0; 2360 object *dst = clone ();
2329 2361
2330 if (!asrc)
2331 return 0;
2332
2333 object *src = asrc->head_ ();
2334
2335 object *prev = 0; 2362 object *prev = dst;
2336 for (object *part = src; part; part = part->more) 2363 for (object *part = this->more; part; part = part->more)
2337 { 2364 {
2338 object *tmp = part->clone (); 2365 object *tmp = part->clone ();
2339
2340 tmp->x -= src->x;
2341 tmp->y -= src->y;
2342
2343 if (!part->head)
2344 {
2345 dst = tmp;
2346 tmp->head = 0;
2347 }
2348 else
2349 tmp->head = dst; 2366 tmp->head = dst;
2350
2351 tmp->more = 0;
2352
2353 if (prev)
2354 prev->more = tmp; 2367 prev->more = tmp;
2355
2356 prev = tmp; 2368 prev = tmp;
2357 } 2369 }
2358 2370
2359 for (object *item = src->inv; item; item = item->below) 2371 for (object *item = inv; item; item = item->below)
2360 insert_ob_in_ob (object_create_clone (item), dst); 2372 insert_ob_in_ob (item->deep_clone (), dst);
2361 2373
2362 return dst; 2374 return dst;
2363} 2375}
2364 2376
2365/* This returns the first object in who's inventory that 2377/* This returns the first object in who's inventory that
2374 return tmp; 2386 return tmp;
2375 2387
2376 return 0; 2388 return 0;
2377} 2389}
2378 2390
2379/* If ob has a field named key, return the link from the list, 2391shstr_tmp
2380 * otherwise return NULL. 2392object::kv_get (shstr_tmp key) const
2381 *
2382 * key must be a passed in shared string - otherwise, this won't
2383 * do the desired thing.
2384 */
2385key_value *
2386get_ob_key_link (const object *ob, const char *key)
2387{ 2393{
2388 for (key_value *link = ob->key_values; link; link = link->next) 2394 for (key_value *kv = key_values; kv; kv = kv->next)
2389 if (link->key == key) 2395 if (kv->key == key)
2390 return link;
2391
2392 return 0;
2393}
2394
2395/*
2396 * Returns the value of op has an extra_field for key, or NULL.
2397 *
2398 * The argument doesn't need to be a shared string.
2399 *
2400 * The returned string is shared.
2401 */
2402const char *
2403get_ob_key_value (const object *op, const char *const key)
2404{
2405 key_value *link;
2406 shstr_cmp canonical_key (key);
2407
2408 if (!canonical_key)
2409 {
2410 /* 1. There being a field named key on any object
2411 * implies there'd be a shared string to find.
2412 * 2. Since there isn't, no object has this field.
2413 * 3. Therefore, *this* object doesn't have this field.
2414 */
2415 return 0;
2416 }
2417
2418 /* This is copied from get_ob_key_link() above -
2419 * only 4 lines, and saves the function call overhead.
2420 */
2421 for (link = op->key_values; link; link = link->next)
2422 if (link->key == canonical_key)
2423 return link->value; 2396 return kv->value;
2424 2397
2425 return 0; 2398 return shstr ();
2426} 2399}
2427 2400
2428/* 2401void
2429 * Updates the canonical_key in op to value. 2402object::kv_set (shstr_tmp key, shstr_tmp value)
2430 *
2431 * canonical_key is a shared string (value doesn't have to be).
2432 *
2433 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2434 * keys.
2435 *
2436 * Returns TRUE on success.
2437 */
2438int
2439set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2440{ 2403{
2441 key_value *field = NULL, *last = NULL; 2404 for (key_value *kv = key_values; kv; kv = kv->next)
2442 2405 if (kv->key == key)
2443 for (field = op->key_values; field != NULL; field = field->next)
2444 {
2445 if (field->key != canonical_key)
2446 { 2406 {
2447 last = field; 2407 kv->value = value;
2448 continue; 2408 return;
2449 } 2409 }
2450 2410
2451 if (value) 2411 key_value *kv = new key_value;
2452 field->value = value; 2412
2453 else 2413 kv->next = key_values;
2414 kv->key = key;
2415 kv->value = value;
2416
2417 key_values = kv;
2418}
2419
2420void
2421object::kv_del (shstr_tmp key)
2422{
2423 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2424 if ((*kvp)->key == key)
2454 { 2425 {
2455 /* Basically, if the archetype has this key set, 2426 key_value *kv = *kvp;
2456 * we need to store the null value so when we save 2427 *kvp = (*kvp)->next;
2457 * it, we save the empty value so that when we load, 2428 delete kv;
2458 * we get this value back again. 2429 return;
2459 */
2460 if (get_ob_key_link (op->arch, canonical_key))
2461 field->value = 0;
2462 else
2463 {
2464 if (last)
2465 last->next = field->next;
2466 else
2467 op->key_values = field->next;
2468
2469 delete field;
2470 }
2471 } 2430 }
2472 return TRUE;
2473 }
2474 /* IF we get here, key doesn't exist */
2475
2476 /* No field, we'll have to add it. */
2477
2478 if (!add_key)
2479 return FALSE;
2480
2481 /* There isn't any good reason to store a null
2482 * value in the key/value list. If the archetype has
2483 * this key, then we should also have it, so shouldn't
2484 * be here. If user wants to store empty strings,
2485 * should pass in ""
2486 */
2487 if (value == NULL)
2488 return TRUE;
2489
2490 field = new key_value;
2491
2492 field->key = canonical_key;
2493 field->value = value;
2494 /* Usual prepend-addition. */
2495 field->next = op->key_values;
2496 op->key_values = field;
2497
2498 return TRUE;
2499}
2500
2501/*
2502 * Updates the key in op to value.
2503 *
2504 * If add_key is FALSE, this will only update existing keys,
2505 * and not add new ones.
2506 * In general, should be little reason FALSE is ever passed in for add_key
2507 *
2508 * Returns TRUE on success.
2509 */
2510int
2511set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2512{
2513 shstr key_ (key);
2514
2515 return set_ob_key_value_s (op, key_, value, add_key);
2516} 2431}
2517 2432
2518object::depth_iterator::depth_iterator (object *container) 2433object::depth_iterator::depth_iterator (object *container)
2519: iterator_base (container) 2434: iterator_base (container)
2520{ 2435{
2570{ 2485{
2571 char flagdesc[512]; 2486 char flagdesc[512];
2572 char info2[256 * 4]; 2487 char info2[256 * 4];
2573 char *p = info; 2488 char *p = info;
2574 2489
2575 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2490 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2576 count, 2491 count,
2577 uuid.c_str (), 2492 uuid.c_str (),
2578 &name, 2493 &name,
2579 title ? "\",title:\"" : "", 2494 title ? ",title:\"" : "",
2580 title ? (const char *)title : "", 2495 title ? (const char *)title : "",
2496 title ? "\"" : "",
2581 flag_desc (flagdesc, 512), type); 2497 flag_desc (flagdesc, 512), type);
2582 2498
2583 if (!flag[FLAG_REMOVED] && env) 2499 if (!flag[FLAG_REMOVED] && env)
2584 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2500 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2585 2501
2601struct region * 2517struct region *
2602object::region () const 2518object::region () const
2603{ 2519{
2604 return map ? map->region (x, y) 2520 return map ? map->region (x, y)
2605 : region::default_region (); 2521 : region::default_region ();
2606}
2607
2608const materialtype_t *
2609object::dominant_material () const
2610{
2611 if (materialtype_t *mt = name_to_material (materialname))
2612 return mt;
2613
2614 return name_to_material (shstr_unknown);
2615} 2522}
2616 2523
2617void 2524void
2618object::open_container (object *new_container) 2525object::open_container (object *new_container)
2619{ 2526{
2641 container = 0; 2548 container = 0;
2642 2549
2643 // client needs item update to make it work, client bug requires this to be separate 2550 // client needs item update to make it work, client bug requires this to be separate
2644 esrv_update_item (UPD_FLAGS, this, old_container); 2551 esrv_update_item (UPD_FLAGS, this, old_container);
2645 2552
2646 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2553 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2647 play_sound (sound_find ("chest_close")); 2554 play_sound (sound_find ("chest_close"));
2648 } 2555 }
2649 2556
2650 if (new_container) 2557 if (new_container)
2651 { 2558 {
2655 // TODO: this does not seem to serve any purpose anymore? 2562 // TODO: this does not seem to serve any purpose anymore?
2656#if 0 2563#if 0
2657 // insert the "Close Container" object. 2564 // insert the "Close Container" object.
2658 if (archetype *closer = new_container->other_arch) 2565 if (archetype *closer = new_container->other_arch)
2659 { 2566 {
2660 object *closer = arch_to_object (new_container->other_arch); 2567 object *closer = new_container->other_arch->instance ();
2661 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2568 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2662 new_container->insert (closer); 2569 new_container->insert (closer);
2663 } 2570 }
2664#endif 2571#endif
2665 2572
2666 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2573 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2667 2574
2668 // make sure the container is available, client bug requires this to be separate 2575 // make sure the container is available, client bug requires this to be separate
2669 esrv_send_item (this, new_container); 2576 esrv_send_item (this, new_container);
2670 2577
2671 new_container->flag [FLAG_APPLIED] = true; 2578 new_container->flag [FLAG_APPLIED] = true;
2679// else if (!old_container->env && contr && contr->ns) 2586// else if (!old_container->env && contr && contr->ns)
2680// contr->ns->floorbox_reset (); 2587// contr->ns->floorbox_reset ();
2681} 2588}
2682 2589
2683object * 2590object *
2684object::force_find (const shstr name) 2591object::force_find (shstr_tmp name)
2685{ 2592{
2686 /* cycle through his inventory to look for the MARK we want to 2593 /* cycle through his inventory to look for the MARK we want to
2687 * place 2594 * place
2688 */ 2595 */
2689 for (object *tmp = inv; tmp; tmp = tmp->below) 2596 for (object *tmp = inv; tmp; tmp = tmp->below)
2691 return splay (tmp); 2598 return splay (tmp);
2692 2599
2693 return 0; 2600 return 0;
2694} 2601}
2695 2602
2603//-GPL
2604
2696void 2605void
2606object::force_set_timer (int duration)
2607{
2608 this->duration = 1;
2609 this->speed_left = -1.f;
2610
2611 this->set_speed (duration ? 1.f / duration : 0.f);
2612}
2613
2614object *
2697object::force_add (const shstr name, int duration) 2615object::force_add (shstr_tmp name, int duration)
2698{ 2616{
2699 if (object *force = force_find (name)) 2617 if (object *force = force_find (name))
2700 force->destroy (); 2618 force->destroy ();
2701 2619
2702 object *force = get_archetype (FORCE_NAME); 2620 object *force = get_archetype (FORCE_NAME);
2703 2621
2704 force->slaying = name; 2622 force->slaying = name;
2705 force->stats.food = 1; 2623 force->force_set_timer (duration);
2706 force->speed_left = -1.f;
2707
2708 force->set_speed (duration ? 1.f / duration : 0.f);
2709 force->flag [FLAG_IS_USED_UP] = true;
2710 force->flag [FLAG_APPLIED] = true; 2624 force->flag [FLAG_APPLIED] = true;
2711 2625
2712 insert (force); 2626 return insert (force);
2713} 2627}
2714 2628
2715void 2629void
2716object::play_sound (faceidx sound) 2630object::play_sound (faceidx sound) const
2717{ 2631{
2718 if (!sound) 2632 if (!sound)
2719 return; 2633 return;
2720 2634
2721 if (flag [FLAG_REMOVED]) 2635 if (is_on_map ())
2636 map->play_sound (sound, x, y);
2637 else if (object *pl = in_player ())
2638 pl->contr->play_sound (sound);
2639}
2640
2641void
2642object::say_msg (const char *msg) const
2643{
2644 if (is_on_map ())
2645 map->say_msg (msg, x, y);
2646 else if (object *pl = in_player ())
2647 pl->contr->play_sound (sound);
2648}
2649
2650void
2651object::make_noise ()
2652{
2653 // we do not model noise in the map, so instead put
2654 // a temporary light into the noise source
2655 // could use the map instead, but that's less reliable for our
2656 // goal, which is to make invisibility a bit harder to exploit
2657
2658 // currently only works sensibly for players
2659 if (!is_player ())
2722 return; 2660 return;
2723 2661
2724 if (env) 2662 // find old force, or create new one
2725 { 2663 object *force = force_find (shstr_noise_force);
2726 if (object *pl = in_player ()) 2664
2727 pl->contr->play_sound (sound); 2665 if (force)
2728 } 2666 force->speed_left = -1.f; // patch old speed up
2729 else 2667 else
2730 map->play_sound (sound, x, y); 2668 {
2731} 2669 force = archetype::get (shstr_noise_force);
2732 2670
2671 force->slaying = shstr_noise_force;
2672 force->stats.food = 1;
2673 force->speed_left = -1.f;
2674
2675 force->set_speed (1.f / 4.f);
2676 force->flag [FLAG_IS_USED_UP] = true;
2677 force->flag [FLAG_APPLIED] = true;
2678
2679 insert (force);
2680 }
2681}
2682

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines