ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.244 by root, Sun May 18 17:52:53 2008 UTC vs.
Revision 1.344 by root, Sun May 1 13:18:23 2011 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009,2010,2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
25	#include <stdio.h>	26	#include <stdio.h>
26	#include <sys/types.h>	27	#include <sys/types.h>
27	#include <sys/uio.h>	28	#include <sys/uio.h>
28	#include <object.h>	29	#include <object.h>
29	#include <sproto.h>	30	#include <sproto.h>
30	#include <loader.h>
31		31
32	#include <bitset>	32	#include <bitset>
33		33
34	UUID UUID::cur;	34	UUID UUID::cur;
35	static uint64_t seq_next_save;	35	static uint64_t seq_next_save;
36	static const uint64 UUID_GAP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
37		38
38	objectvec objects;	39	objectvec objects;
39	activevec actives;	40	activevec actives;
		41
		42	freelist_item *object::freelist;
		43	uint32_t object::object_count;
		44	uint32_t object::free_count;
		45	uint32_t object::create_count;
		46	uint32_t object::destroy_count;
		47
		48	//+GPL
40		49
41	short freearr_x[SIZEOFFREE] = {	50	short freearr_x[SIZEOFFREE] = {
42	0,	51	0,
43	0, 1, 1, 1, 0, -1, -1, -1,	52	0, 1, 1, 1, 0, -1, -1, -1,
44	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	53	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
…		…
48	0,	57	0,
49	-1, -1, 0, 1, 1, 1, 0, -1,	58	-1, -1, 0, 1, 1, 1, 0, -1,
50	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	59	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	60	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52	};	61	};
53	int maxfree[SIZEOFFREE] = {
54	0,
55	9, 10, 13, 14, 17, 18, 21, 22,
56	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58	};
59	int freedir[SIZEOFFREE] = {	62	int freedir[SIZEOFFREE] = {
60	0,	63	0,
61	1, 2, 3, 4, 5, 6, 7, 8,	64	1, 2, 3, 4, 5, 6, 7, 8,
62	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	65	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	66	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64	};	67	};
65		68
		69	static int maxfree[SIZEOFFREE] = {
		70	0,
		71	9, 10, 13, 14, 17, 18, 21, 22,
		72	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
		73	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
		74	};
		75
		76	const char *wall_suffix[16] = {
		77	"0",
		78	"1_3",
		79	"1_4",
		80	"2_1_2",
		81	"1_2",
		82	"2_2_4",
		83	"2_2_1",
		84	"3_1",
		85	"1_1",
		86	"2_2_3",
		87	"2_2_2",
		88	"3_3",
		89	"2_1_1",
		90	"3_4",
		91	"3_2",
		92	"4"
		93	};
		94
66	static void	95	static void
67	write_uuid (uval64 skip, bool sync)	96	write_uuid (uval64 skip, bool sync)
68	{	97	{
69	CALL_BEGIN (2);	98	CALL_BEGIN (2);
70	CALL_ARG_SV (newSVval64 (skip));	99	CALL_ARG_SV (newSVval64 (skip));
…		…
72	CALL_CALL ("cf::write_uuid", G_DISCARD);	101	CALL_CALL ("cf::write_uuid", G_DISCARD);
73	CALL_END;	102	CALL_END;
74	}	103	}
75		104
76	static void	105	static void
77	read_uuid (void)	106	read_uuid ()
78	{	107	{
79	char filename[MAX_BUF];	108	char filename[MAX_BUF];
80		109
81	sprintf (filename, "%s/uuid", settings.localdir);	110	sprintf (filename, "%s/uuid", settings.localdir);
82		111
…		…
96		125
97	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	126	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98	_exit (1);	127	_exit (1);
99	}	128	}
100		129
101	UUID::BUF buf;	130	char buf [UUID::MAX_LEN];
102	buf[0] = 0;	131	buf[0] = 0;
103	fgets (buf, sizeof (buf), fp);	132	fgets (buf, sizeof (buf), fp);
104		133
105	if (!UUID::cur.parse (buf))	134	if (!UUID::cur.parse (buf))
106	{	135	{
…		…
133		162
134	void	163	void
135	UUID::init ()	164	UUID::init ()
136	{	165	{
137	read_uuid ();	166	read_uuid ();
		167	}
		168
		169	bool
		170	UUID::parse (const char *s)
		171	{
		172	if (*s++ != '<' || *s++ != '1' || *s++ != '.')
		173	return false;
		174
		175	seq = 0;
		176
		177	while (*s != '>')
		178	{
		179	if (*s < '0')
		180	return false;
		181
		182	// this gives nice branchless code with gcc
		183	assert ('0' < 'a' && '0' == 48 && 'a' == 97);
		184	int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
		185
		186	seq = (seq << 4) | digit;
		187
		188	++s;
		189	}
		190
		191	return true;
		192	}
		193
		194	char *
		195	UUID::append (char *buf) const
		196	{
		197	*buf++ = '<';
		198	*buf++ = '1';
		199	*buf++ = '.';
		200
		201	uint64_t seq = this->seq;
		202	const int bits = 64;
		203	char nz = 0;
		204	static const char tohex [] = "0123456789abcdef";
		205
		206	// assert (len >= 3 + bits / 4 + 1 + 1);
		207	for (int i = bits / 4; --i; )
		208	{
		209	uint8_t digit = seq >> (bits - 4);
		210
		211	*buf = tohex [digit];
		212	nz |= digit;
		213	buf += nz ? 1 : 0;
		214	seq <<= 4;
		215	}
		216
		217	// last digit is special - always emit
		218	uint8_t digit = seq >> (bits - 4);
		219	*buf++ = tohex [digit];
		220
		221	*buf++ = '>';
		222
		223	return buf;
		224	}
		225
		226	char *
		227	UUID::c_str () const
		228	{
		229	static char buf [MAX_LEN];
		230	*append (buf) = 0;
		231	return buf;
138	}	232	}
139		233
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	234	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	235	static bool
142	compare_ob_value_lists_one (const object *wants, const object *has)	236	compare_ob_value_lists_one (const object *wants, const object *has)
143	{	237	{
144	/* n-squared behaviour (see kv_get), but I'm hoping both	238	/* n-squared behaviour (see kv.get), but I'm hoping both
145	* objects with lists are rare, and lists stay short. If not, use a	239	* objects with lists are rare, and lists stay short. If not, use a
146	* different structure or at least keep the lists sorted...	240	* different structure or at least keep the lists sorted...
147	*/	241	*/
148		242
149	/* For each field in wants, */	243	/* For each field in wants, */
150	for (key_value *kv = wants->key_values; kv; kv = kv->next)	244	for (key_value *kv = wants->kv.first; kv; kv = kv->next)
151	if (has->kv_get (kv->key) != kv->value)	245	if (has->kv.get (kv->key) != kv->value)
152	return false;	246	return false;
153		247
154	/* If we get here, every field in wants has a matching field in has. */	248	/* If we get here, every field in wants has a matching field in has. */
155	return true;	249	return true;
156	}	250	}
…		…
178	* Improvements made with merge: Better checking on potion, and also	272	* Improvements made with merge: Better checking on potion, and also
179	* check weight	273	* check weight
180	*/	274	*/
181	bool object::can_merge_slow (object *ob1, object *ob2)	275	bool object::can_merge_slow (object *ob1, object *ob2)
182	{	276	{
183	/* A couple quicksanity checks */	277	/* A couple quick sanity checks */
184	if (ob1 == ob2	278	if (ob1 == ob2
185	|| ob1->type != ob2->type	279	|| ob1->type != ob2->type
186	|| ob1->speed != ob2->speed
187	|| ob1->value != ob2->value	280	|| ob1->value != ob2->value
188	|| ob1->name != ob2->name)	281	|| ob1->name != ob2->name
		282	|| ob1->custom_name != ob2->custom_name
		283	|| fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
189	return 0;	284	return 0;
190		285
191	// some objects are unmergable
192	if (!ob1->nrof || !ob2->nrof)
193	return 0;
194
195	/* Do not merge objects if nrof would overflow. First part checks	286	/* Do not merge objects if nrof would overflow, assume nrof
196	* for unsigned overflow (2c), second part checks whether the result	287	* is always 0 .. 2**31-1 */
197	* would fit into a 32 bit signed int, which is often used to hold	288	if (ob1->nrof > 0x7fffffff - ob2->nrof)
198	* nrof values.
199	*/
200	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
201	return 0;	289	return 0;
202		290
203	/* If the objects have been identified, set the BEEN_APPLIED flag.	291	/* If the objects have been identified, set the BEEN_APPLIED flag.
204	* This is to the comparison of the flags below will be OK. We	292	* This is to the comparison of the flags below will be OK. We
205	* just can't ignore the been applied or identified flags, as they	293	* just can't ignore the been applied or identified flags, as they
206	* are not equal - just if it has been identified, the been_applied	294	* are not equal - just if it has been identified, the been_applied
207	* flags lose any meaning.	295	* flags lose any meaning.
208	*/	296	*/
209	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	297	if (ob1->flag [FLAG_IDENTIFIED])
210	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	298	ob1->set_flag (FLAG_BEEN_APPLIED);
211		299
212	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	300	if (ob2->flag [FLAG_IDENTIFIED])
213	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	301	ob2->set_flag (FLAG_BEEN_APPLIED);
214		302
215	if (ob1->arch->archname != ob2->arch->archname	303	if (ob1->arch->archname != ob2->arch->archname
216	|| ob1->name != ob2->name	304	|| ob1->name != ob2->name
217	|| ob1->title != ob2->title	305	|| ob1->title != ob2->title
218	|| ob1->msg != ob2->msg	306	|| ob1->msg != ob2->msg
…		…
221	|| ob1->magic != ob2->magic	309	|| ob1->magic != ob2->magic
222	|| ob1->slaying != ob2->slaying	310	|| ob1->slaying != ob2->slaying
223	|| ob1->skill != ob2->skill	311	|| ob1->skill != ob2->skill
224	|| ob1->value != ob2->value	312	|| ob1->value != ob2->value
225	|| ob1->animation_id != ob2->animation_id	313	|| ob1->animation_id != ob2->animation_id
226	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other	314	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
227	|| ob1->client_type != ob2->client_type	315	|| ob1->client_type != ob2->client_type
228	|| ob1->materialname != ob2->materialname	316	|| ob1->material != ob2->material
229	|| ob1->lore != ob2->lore	317	|| ob1->lore != ob2->lore
230	|| ob1->subtype != ob2->subtype	318	|| ob1->subtype != ob2->subtype
231	|| ob1->move_type != ob2->move_type	319	|| ob1->move_type != ob2->move_type
232	|| ob1->move_block != ob2->move_block	320	|| ob1->move_block != ob2->move_block
233	|| ob1->move_allow != ob2->move_allow	321	|| ob1->move_allow != ob2->move_allow
234	|| ob1->move_on != ob2->move_on	322	|| ob1->move_on != ob2->move_on
235	|| ob1->move_off != ob2->move_off	323	|| ob1->move_off != ob2->move_off
236	|| ob1->move_slow != ob2->move_slow	324	|| ob1->move_slow != ob2->move_slow
237	|| ob1->move_slow_penalty != ob2->move_slow_penalty	325	|| fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
238	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))	326	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	327	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
240	return 0;	328	return 0;
241		329
242	if ((ob1->flag ^ ob2->flag)	330	if ((ob1->flag ^ ob2->flag)
243	.reset (FLAG_INV_LOCKED)	331	.reset (FLAG_INV_LOCKED)
244	.reset (FLAG_CLIENT_SENT)
245	.reset (FLAG_REMOVED)	332	.reset (FLAG_REMOVED)
246	.any ())	333	.any ())
247	return 0;	334	return 0;
248		335
249	/* This is really a spellbook check - we should in general	336	/* This is really a spellbook check - we should in general
…		…
268		355
269	/* Don't merge objects that are applied. With the new 'body' code,	356	/* Don't merge objects that are applied. With the new 'body' code,
270	* it is possible for most any character to have more than one of	357	* it is possible for most any character to have more than one of
271	* some items equipped, and we don't want those to merge.	358	* some items equipped, and we don't want those to merge.
272	*/	359	*/
273	if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED))	360	if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
274	return 0;	361	return 0;
275		362
276	/* Note sure why the following is the case - either the object has to	363	/* Note sure why the following is the case - either the object has to
277	* be animated or have a very low speed. Is this an attempted monster	364	* be animated or have a very low speed. Is this an attempted monster
278	* check?	365	* check?
279	*/	366	*/
280	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())	367	if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
281	return 0;	368	return 0;
282		369
283	switch (ob1->type)	370	switch (ob1->type)
284	{	371	{
285	case SCROLL:	372	case SCROLL:
286	if (ob1->level != ob2->level)	373	if (ob1->level != ob2->level)
287	return 0;	374	return 0;
288	break;	375	break;
289	}	376	}
290		377
291	if (ob1->key_values || ob2->key_values)	378	if (!ob1->kv.empty () || !ob2->kv.empty ())
292	{	379	{
293	/* At least one of these has key_values. */	380	/* At least one of these has key_values. */
294	if ((!ob1->key_values) != (!ob2->key_values))	381	if (ob1->kv.empty () != ob2->kv.empty ())
295	return 0; /* One has fields, but the other one doesn't. */	382	return 0; /* One has fields, but the other one doesn't. */
296		383
297	if (!compare_ob_value_lists (ob1, ob2))	384	if (!compare_ob_value_lists (ob1, ob2))
298	return 0;	385	return 0;
299	}	386	}
…		…
331	{	418	{
332	// see if we are in a container of sorts	419	// see if we are in a container of sorts
333	if (env)	420	if (env)
334	{	421	{
335	// the player inventory itself is always visible	422	// the player inventory itself is always visible
336	if (env->type == PLAYER)	423	if (env->is_player ())
337	return env;	424	return env;
338		425
339	// else a player could have our env open	426	// else a player could have our env open
340	object *envest = env->outer_env ();	427	object *envest = env->outer_env_or_self ();
341		428
342	// the player itself is always on a map, so we will find him here	429	// the player itself is always on a map, so we will find him here
343	// even if our inv is in a player.	430	// even if our inv is in a player.
344	if (envest->is_on_map ())	431	if (envest->is_on_map ())
345	if (object *pl = envest->ms ().player ())	432	if (object *pl = envest->ms ().player ())
346	if (pl->container == env)	433	if (pl->container_ () == env)
347	return pl;	434	return pl;
348	}	435	}
349	else	436	else
350	{	437	{
351	// maybe there is a player standing on the same mapspace	438	// maybe there is a player standing on the same mapspace
352	// this will catch the case where "this" is a player	439	// this will catch the case where "this" is a player
353	if (object *pl = ms ().player ())	440	if (object *pl = ms ().player ())
354	if (!pl->container || this == pl->container)	441	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		442	|| pl->container_ () == this)
355	return pl;	443	return pl;
356	}	444	}
357	}	445	}
358		446
359	return 0;	447	return 0;
360	}	448	}
361		449
362	// adjust weight per container type ("of holding")	450	// adjust weight per container type ("of holding")
363	static sint32	451	static uint32
364	weight_adjust_for (object *op, sint32 weight)	452	weight_adjust_for (object *op, uint32 weight)
365	{	453	{
366	return op->type == CONTAINER	454	return op->type == CONTAINER
367	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	455	? weight - weight * op->stats.Str / 100
368	: weight;	456	: weight;
369	}	457	}
370		458
371	/*	459	/*
372	* adjust_weight(object, weight) adds the specified weight to an object,	460	* subtracts, then adds, the specified weight to an object,
373	* and also updates how much the environment(s) is/are carrying.	461	* and also updates how much the environment(s) is/are carrying.
374	*/	462	*/
375	static void	463	static void
376	adjust_weight (object *op, sint32 weight)	464	adjust_weight (object *op, sint32 sub, sint32 add)
377	{	465	{
378	while (op)	466	while (op)
379	{	467	{
380	// adjust by actual difference to account for rounding errors	468	sint32 ocarrying = op->carrying;
381	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
382	weight = weight_adjust_for (op, op->carrying)
383	- weight_adjust_for (op, op->carrying - weight);
384		469
385	if (!weight)	470	op->carrying -= weight_adjust_for (op, sub);
386	return;	471	op->carrying += weight_adjust_for (op, add);
387
388	op->carrying += weight;
389		472
390	if (object *pl = op->visible_to ())	473	if (object *pl = op->visible_to ())
391	if (pl != op) // player is handled lazily	474	if (pl != op) // player is handled lazily
392	esrv_update_item (UPD_WEIGHT, pl, op);	475	esrv_update_item (UPD_WEIGHT, pl, op);
393		476
		477	sub = ocarrying;
		478	add = op->carrying;
		479
394	op = op->env;	480	op = op->env;
395	}	481	}
396	}	482	}
397		483
398	/*	484	/*
…		…
405	{	491	{
406	sint32 sum = 0;	492	sint32 sum = 0;
407		493
408	for (object *op = inv; op; op = op->below)	494	for (object *op = inv; op; op = op->below)
409	{	495	{
410	if (op->inv)
411	op->update_weight ();	496	op->update_weight ();
412		497
413	sum += op->total_weight ();	498	sum += weight_adjust_for (this, op->total_weight ());
414	}	499	}
415
416	sum = weight_adjust_for (this, sum);
417		500
418	if (sum != carrying)	501	if (sum != carrying)
419	{	502	{
		503	if (carrying != sum && carrying)//D
		504	LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
		505	(long long)sum, (long long)carrying, debug_desc ());
		506
420	carrying = sum;	507	carrying = sum;
421		508
422	if (object *pl = visible_to ())	509	if (object *pl = visible_to ())
423	if (pl != this) // player is handled lazily	510	if (pl != this) // player is handled lazily
424	esrv_update_item (UPD_WEIGHT, pl, this);	511	esrv_update_item (UPD_WEIGHT, pl, this);
…		…
437	object_freezer freezer;	524	object_freezer freezer;
438	op->write (freezer);	525	op->write (freezer);
439	return freezer.as_string ();	526	return freezer.as_string ();
440	}	527	}
441		528
442	/*	529	char *
443	* get_nearest_part(multi-object, object 2) returns the part of the	530	object::as_string ()
444	* multi-object 1 which is closest to the second object.
445	* If it's not a multi-object, it is returned.
446	*/
447	object *
448	get_nearest_part (object *op, const object *pl)
449	{	531	{
450	object *tmp, *closest;	532	return dump_object (this);
451	int last_dist, i;
452
453	if (!op->more)
454	return op;
455
456	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
457	tmp;
458	tmp = tmp->more)
459	if ((i = distance (tmp, pl)) < last_dist)
460	closest = tmp, last_dist = i;
461
462	return closest;
463	}	533	}
464		534
465	/*	535	/*
466	* Returns the object which has the count-variable equal to the argument.	536	* Returns the object which has the count-variable equal to the argument.
467	* VERRRY slow.	537	* VERRRY slow.
…		…
469	object *	539	object *
470	find_object (tag_t i)	540	find_object (tag_t i)
471	{	541	{
472	for_all_objects (op)	542	for_all_objects (op)
473	if (op->count == i)	543	if (op->count == i)
		544	return op;
		545
		546	return 0;
		547	}
		548
		549	/*
		550	* Returns the object which has the uuid equal to the argument.
		551	* MOAR VERRRY slow.
		552	*/
		553
		554	object *
		555	find_object_uuid (UUID i)
		556	{
		557	for_all_objects (op)
		558	if (op->uuid == i)
474	return op;	559	return op;
475		560
476	return 0;	561	return 0;
477	}	562	}
478		563
…		…
512	LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());	597	LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
513	return;	598	return;
514	}	599	}
515		600
516	this->owner = owner;	601	this->owner = owner;
517	}
518
519	int
520	object::slottype () const
521	{
522	if (type == SKILL)
523	{
524	if (IS_COMBAT_SKILL (subtype)) return slot_combat;
525	if (IS_RANGED_SKILL (subtype)) return slot_ranged;
526	}
527	else
528	{
529	if (slot [body_combat].info) return slot_combat;
530	if (slot [body_range ].info) return slot_ranged;
531	}
532
533	return slot_none;
534	}
535
536	bool
537	object::change_weapon (object *ob)
538	{
539	if (current_weapon == ob)
540	return true;
541
542	if (chosen_skill)
543	chosen_skill->flag [FLAG_APPLIED] = false;
544
545	current_weapon = ob;
546	chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
547
548	if (chosen_skill)
549	chosen_skill->flag [FLAG_APPLIED] = true;
550
551	update_stats ();
552
553	if (ob)
554	{
555	// now check wether any body locations became invalid, in which case
556	// we cannot apply the weapon at the moment.
557	for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
558	if (slot[i].used < 0)
559	{
560	current_weapon = chosen_skill = 0;
561	update_stats ();
562
563	new_draw_info_format (NDI_UNIQUE, 0, this,
564	"You try to balance all your items at once, "
565	"but the %s is just too much for your body. "
566	"[You need to unapply some items first.]", &ob->name);
567	return false;
568	}
569
570	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
571	}
572	else
573	;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
574
575	if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
576	{
577	LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
578	&name, ob->debug_desc ());
579	return false;
580	}
581
582	return true;
583	}
584
585	/* Zero the key_values on op, decrementing the shared-string
586	* refcounts and freeing the links.
587	*/
588	static void
589	free_key_values (object *op)
590	{
591	for (key_value *i = op->key_values; i; )
592	{
593	key_value *next = i->next;
594	delete i;
595
596	i = next;
597	}
598
599	op->key_values = 0;
600	}	602	}
601		603
602	/*	604	/*
603	* copy_to first frees everything allocated by the dst object,	605	* copy_to first frees everything allocated by the dst object,
604	* and then copies the contents of itself into the second	606	* and then copies the contents of itself into the second
…		…
610	void	612	void
611	object::copy_to (object *dst)	613	object::copy_to (object *dst)
612	{	614	{
613	dst->remove ();	615	dst->remove ();
614	*(object_copy *)dst = *this;	616	*(object_copy *)dst = *this;
		617
		618	// maybe move to object_copy?
		619	dst->kv = kv;
		620
615	dst->flag [FLAG_REMOVED] = true;	621	dst->flag [FLAG_REMOVED] = true;
616		622	dst->activate ();
617	/* Copy over key_values, if any. */
618	if (key_values)
619	{
620	key_value *tail = 0;
621	dst->key_values = 0;
622
623	for (key_value *i = key_values; i; i = i->next)
624	{
625	key_value *new_link = new key_value;
626
627	new_link->next = 0;
628	new_link->key = i->key;
629	new_link->value = i->value;
630
631	/* Try and be clever here, too. */
632	if (!dst->key_values)
633	{
634	dst->key_values = new_link;
635	tail = new_link;
636	}
637	else
638	{
639	tail->next = new_link;
640	tail = new_link;
641	}
642	}
643	}
644
645	if (speed < 0)
646	dst->speed_left -= rndm ();
647
648	dst->set_speed (dst->speed);
649	}	623	}
650		624
651	void	625	void
652	object::instantiate ()	626	object::instantiate ()
653	{	627	{
654	if (!uuid.seq) // HACK	628	if (!uuid.seq) // HACK
655	uuid = UUID::gen ();	629	uuid = UUID::gen ();
656		630
		631	// TODO: unclean state changes, should not be done in copy_to AND instantiate
		632	if (flag [FLAG_RANDOM_SPEED] && speed)
		633	speed_left = - speed - rndm (); // TODO animation
		634	else
657	speed_left = -0.1f;	635	speed_left = -1.;
		636
658	/* copy the body_info to the body_used - this is only really	637	/* copy the body_info to the body_used - this is only really
659	* need for monsters, but doesn't hurt to do it for everything.	638	* need for monsters, but doesn't hurt to do it for everything.
660	* by doing so, when a monster is created, it has good starting	639	* by doing so, when a monster is created, it has good starting
661	* values for the body_used info, so when items are created	640	* values for the body_used info, so when items are created
662	* for it, they can be properly equipped.	641	* for it, they can be properly equipped.
…		…
670	object *	649	object *
671	object::clone ()	650	object::clone ()
672	{	651	{
673	object *neu = create ();	652	object *neu = create ();
674	copy_to (neu);	653	copy_to (neu);
		654
		655	// TODO: unclean state changes, should not be done in clone AND instantiate
		656	if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
		657	neu->speed_left = - neu->speed - rndm (); // TODO animation
		658
675	neu->map = map; // not copied by copy_to	659	neu->map = map; // not copied by copy_to
676	return neu;	660	return neu;
677	}	661	}
678		662
679	/*	663	/*
…		…
682	* be called to update the face variable, _and_ how it looks on the map.	666	* be called to update the face variable, _and_ how it looks on the map.
683	*/	667	*/
684	void	668	void
685	update_turn_face (object *op)	669	update_turn_face (object *op)
686	{	670	{
687	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)	671	if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
688	return;	672	return;
689		673
690	SET_ANIMATION (op, op->direction);	674	SET_ANIMATION (op, op->direction);
691	update_object (op, UP_OBJ_FACE);	675	update_object (op, UP_OBJ_FACE);
692	}	676	}
…		…
697	* This function needs to be called whenever the speed of an object changes.	681	* This function needs to be called whenever the speed of an object changes.
698	*/	682	*/
699	void	683	void
700	object::set_speed (float speed)	684	object::set_speed (float speed)
701	{	685	{
702	if (flag [FLAG_FREED] && speed)
703	{
704	LOG (llevError, "Object %s is freed but has speed.\n", &name);
705	speed = 0;
706	}
707
708	this->speed = speed;	686	this->speed = speed;
709		687
710	if (has_active_speed ())	688	if (has_active_speed ())
711	activate ();	689	activate ();
712	else	690	else
…		…
762		740
763	if (!(m.flags_ & P_UPTODATE))	741	if (!(m.flags_ & P_UPTODATE))
764	/* nop */;	742	/* nop */;
765	else if (action == UP_OBJ_INSERT)	743	else if (action == UP_OBJ_INSERT)
766	{	744	{
		745	#if 0
767	// this is likely overkill, TODO: revisit (schmorp)	746	// this is likely overkill, TODO: revisit (schmorp)
768	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	747	if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
769	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	748	|| (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
770	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	749	|| (op->is_player () && !(m.flags_ & P_PLAYER))
771	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	750	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
772	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	751	|| (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
773	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	752	|| (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
774	|| (m.move_on | op->move_on ) != m.move_on	753	|| (m.move_on | op->move_on ) != m.move_on
775	|| (m.move_off | op->move_off ) != m.move_off	754	|| (m.move_off | op->move_off ) != m.move_off
776	|| (m.move_slow | op->move_slow) != m.move_slow	755	|| (m.move_slow | op->move_slow) != m.move_slow
777	/* This isn't perfect, but I don't expect a lot of objects to	756	/* This isn't perfect, but I don't expect a lot of objects to
778	* to have move_allow right now.	757	* have move_allow right now.
779	*/	758	*/
780	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	759	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
		760	m.invalidate ();
		761	#else
781	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	762	// the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
782	m.flags_ = 0;	763	m.invalidate ();
		764	#endif
783	}	765	}
784	/* if the object is being removed, we can't make intelligent	766	/* if the object is being removed, we can't make intelligent
785	* decisions, because remove_ob can't really pass the object	767	* decisions, because remove_ob can't really pass the object
786	* that is being removed.	768	* that is being removed.
787	*/	769	*/
788	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	770	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
789	m.flags_ = 0;	771	m.invalidate ();
790	else if (action == UP_OBJ_FACE)	772	else if (action == UP_OBJ_FACE)
791	/* Nothing to do for that case */ ;	773	/* Nothing to do for that case */ ;
792	else	774	else
793	LOG (llevError, "update_object called with invalid action: %d\n", action);	775	LOG (llevError, "update_object called with invalid action: %d\n", action);
794		776
…		…
796	update_object (op->more, action);	778	update_object (op->more, action);
797	}	779	}
798		780
799	object::object ()	781	object::object ()
800	{	782	{
801	SET_FLAG (this, FLAG_REMOVED);	783	this->set_flag (FLAG_REMOVED);
802		784
803	expmul = 1.0;	785	//expmul = 1.0; declared const for the time being
804	face = blank_face;	786	face = blank_face;
		787	material = MATERIAL_NULL;
805	}	788	}
806		789
807	object::~object ()	790	object::~object ()
808	{	791	{
809	unlink ();	792	unlink ();
810		793
811	free_key_values (this);	794	kv.clear ();
812	}	795	}
813
814	static int object_count;
815		796
816	void object::link ()	797	void object::link ()
817	{	798	{
818	assert (!index);//D	799	assert (!index);//D
819	uuid = UUID::gen ();	800	uuid = UUID::gen ();
820	count = ++object_count;
821		801
822	refcnt_inc ();	802	refcnt_inc ();
823	objects.insert (this);	803	objects.insert (this);
		804
		805	++create_count;
		806
824	}	807	}
825		808
826	void object::unlink ()	809	void object::unlink ()
827	{	810	{
828	if (!index)	811	if (!index)
829	return;	812	return;
		813
		814	++destroy_count;
830		815
831	objects.erase (this);	816	objects.erase (this);
832	refcnt_dec ();	817	refcnt_dec ();
833	}	818	}
834		819
…		…
838	/* If already on active list, don't do anything */	823	/* If already on active list, don't do anything */
839	if (active)	824	if (active)
840	return;	825	return;
841		826
842	if (has_active_speed ())	827	if (has_active_speed ())
		828	{
		829	if (flag [FLAG_FREED])
		830	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		831
843	actives.insert (this);	832	actives.insert (this);
		833	}
844	}	834	}
845		835
846	void	836	void
847	object::activate_recursive ()	837	object::activate_recursive ()
848	{	838	{
…		…
913	|| map->in_memory != MAP_ACTIVE	903	|| map->in_memory != MAP_ACTIVE
914	|| map->no_drop	904	|| map->no_drop
915	|| ms ().move_block == MOVE_ALL)	905	|| ms ().move_block == MOVE_ALL)
916	{	906	{
917	while (inv)	907	while (inv)
918	{
919	inv->destroy_inv (false);
920	inv->destroy ();	908	inv->destroy ();
921	}
922	}	909	}
923	else	910	else
924	{ /* Put objects in inventory onto this space */	911	{ /* Put objects in inventory onto this space */
925	while (inv)	912	while (inv)
926	{	913	{
…		…
930	|| op->flag [FLAG_NO_DROP]	917	|| op->flag [FLAG_NO_DROP]
931	|| op->type == RUNE	918	|| op->type == RUNE
932	|| op->type == TRAP	919	|| op->type == TRAP
933	|| op->flag [FLAG_IS_A_TEMPLATE]	920	|| op->flag [FLAG_IS_A_TEMPLATE]
934	|| op->flag [FLAG_DESTROY_ON_DEATH])	921	|| op->flag [FLAG_DESTROY_ON_DEATH])
935	op->destroy (true);	922	op->destroy ();
936	else	923	else
937	map->insert (op, x, y);	924	map->insert (op, x, y);
938	}	925	}
939	}	926	}
940	}	927	}
941		928
		929	/*
		930	* Remove and free all objects in the inventory of the given object.
		931	* Unlike destroy_inv, this assumes the *this is destroyed as well
		932	* well, so we can (and have to!) take shortcuts.
		933	*/
		934	void
		935	object::destroy_inv_fast ()
		936	{
		937	while (object *op = inv)
		938	{
		939	// remove from object the fast way
		940	op->flag [FLAG_REMOVED] = true;
		941	op->env = 0;
		942	if ((inv = inv->below))
		943	inv->above = 0;
		944
		945	// then destroy
		946	op->destroy ();
		947	}
		948	}
		949
		950	void
		951	object::freelist_free (int count)
		952	{
		953	while (count-- && freelist)
		954	{
		955	freelist_item *next = freelist->next;
		956	// count is being "destroyed"
		957
		958	sfree ((char *)freelist, sizeof (object));
		959
		960	freelist = next;
		961	--free_count;
		962	}
		963	}
		964
		965	object *
942	object *object::create ()	966	object::create ()
943	{	967	{
944	object *op = new object;	968	object *op;
		969
		970	if (freelist)
		971	{
		972	freelist_item li = *freelist;
		973	memset (freelist, 0, sizeof (object));
		974
		975	op = new (freelist) object;
		976	op->count = li.count;
		977
		978	freelist = li.next;
		979	--free_count;
		980	}
		981	else
		982	{
		983	void *ni = salloc0<char> (sizeof (object));
		984
		985	op = new(ni) object;
		986
		987	op->count = ++object_count;
		988	}
		989
945	op->link ();	990	op->link ();
		991
946	return op;	992	return op;
947	}	993	}
948		994
		995	void
		996	object::do_delete ()
		997	{
		998	uint32_t count = this->count;
		999
		1000	this->~object ();
		1001
		1002	freelist_item *li = (freelist_item *)this;
		1003	li->next = freelist;
		1004	li->count = count;
		1005
		1006	freelist = li;
		1007	++free_count;
		1008	}
		1009
949	static struct freed_map : maptile	1010	static struct freed_map : maptile
950	{	1011	{
951	freed_map ()	1012	freed_map ()
		1013	: maptile (3, 3)
952	{	1014	{
953	path = "<freed objects map>";	1015	path = "<freed objects map>";
954	name = "/internal/freed_objects_map";	1016	name = "/internal/freed_objects_map";
955	width = 3;
956	height = 3;
957	no_drop = 1;	1017	no_drop = 1;
958	no_reset = 1;	1018	no_reset = 1;
959		1019
960	alloc ();
961	in_memory = MAP_ACTIVE;	1020	in_memory = MAP_ACTIVE;
962	}	1021	}
963		1022
964	~freed_map ()	1023	~freed_map ()
965	{	1024	{
…		…
969		1028
970	void	1029	void
971	object::do_destroy ()	1030	object::do_destroy ()
972	{	1031	{
973	if (flag [FLAG_IS_LINKED])	1032	if (flag [FLAG_IS_LINKED])
974	remove_button_link (this);	1033	remove_link ();
975		1034
976	if (flag [FLAG_FRIENDLY])	1035	if (flag [FLAG_FRIENDLY])
977	remove_friendly_object (this);	1036	remove_friendly_object (this);
978		1037
979	remove ();	1038	remove ();
…		…
1004	attacked_by = 0;	1063	attacked_by = 0;
1005	current_weapon = 0;	1064	current_weapon = 0;
1006	}	1065	}
1007		1066
1008	void	1067	void
1009	object::destroy (bool destroy_inventory)	1068	object::destroy ()
1010	{	1069	{
1011	if (destroyed ())	1070	if (destroyed ())
1012	return;	1071	return;
1013		1072
1014	if (!is_head () && !head->destroyed ())	1073	if (!is_head () && !head->destroyed ())
1015	{	1074	{
1016	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");	1075	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1017	head->destroy (destroy_inventory);	1076	head->destroy ();
1018	return;	1077	return;
1019	}	1078	}
1020		1079
1021	destroy_inv (!destroy_inventory);	1080	destroy_inv_fast ();
1022		1081
1023	if (is_head ())	1082	if (is_head ())
1024	if (sound_destroy)	1083	if (sound_destroy)
1025	play_sound (sound_destroy);	1084	play_sound (sound_destroy);
1026	else if (flag [FLAG_MONSTER])	1085	else if (flag [FLAG_MONSTER])
…		…
1037	* the previous environment.	1096	* the previous environment.
1038	*/	1097	*/
1039	void	1098	void
1040	object::do_remove ()	1099	object::do_remove ()
1041	{	1100	{
1042	object *tmp, *last = 0;
1043	object *otmp;
1044
1045	if (flag [FLAG_REMOVED])	1101	if (flag [FLAG_REMOVED])
1046	return;	1102	return;
1047		1103
1048	INVOKE_OBJECT (REMOVE, this);	1104	INVOKE_OBJECT (REMOVE, this);
1049		1105
…		…
1061	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed	1117	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1062	if (object *pl = visible_to ())	1118	if (object *pl = visible_to ())
1063	esrv_del_item (pl->contr, count);	1119	esrv_del_item (pl->contr, count);
1064	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed	1120	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1065		1121
1066	adjust_weight (env, -total_weight ());	1122	adjust_weight (env, total_weight (), 0);
		1123
		1124	object *pl = in_player ();
1067		1125
1068	/* we set up values so that it could be inserted into	1126	/* we set up values so that it could be inserted into
1069	* the map, but we don't actually do that - it is up	1127	* the map, but we don't actually do that - it is up
1070	* to the caller to decide what we want to do.	1128	* to the caller to decide what we want to do.
1071	*/	1129	*/
…		…
1079		1137
1080	above = 0;	1138	above = 0;
1081	below = 0;	1139	below = 0;
1082	env = 0;	1140	env = 0;
1083		1141
1084	/* NO_FIX_PLAYER is set when a great many changes are being	1142	if (pl && pl->is_player ())
1085	* made to players inventory. If set, avoiding the call
1086	* to save cpu time.
1087	*/	1143	{
1088	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1144	if (expect_false (pl->contr->combat_ob == this))
1089	otmp->update_stats ();	1145	{
		1146	pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
		1147	pl->contr->combat_ob = 0;
		1148	if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
		1149	}
		1150
		1151	if (expect_false (pl->contr->ranged_ob == this))
		1152	{
		1153	pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
		1154	pl->contr->ranged_ob = 0;
		1155	if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
		1156	}
		1157
		1158	pl->contr->queue_stats_update ();
		1159
		1160	if (expect_false (glow_radius) && pl->is_on_map ())
		1161	update_all_los (pl->map, pl->x, pl->y);
		1162	}
1090	}	1163	}
1091	else if (map)	1164	else if (map)
1092	{	1165	{
1093	map->dirty = true;	1166	map->dirty = true;
1094	mapspace &ms = this->ms ();	1167	mapspace &ms = this->ms ();
1095		1168
1096	if (object *pl = ms.player ())	1169	if (object *pl = ms.player ())
1097	{	1170	{
1098	if (type == PLAYER) // this == pl(!)	1171	if (is_player ())
1099	{	1172	{
		1173	if (!flag [FLAG_WIZPASS])
		1174	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1175
1100	// leaving a spot always closes any open container on the ground	1176	// leaving a spot always closes any open container on the ground
1101	if (container && !container->env)	1177	if (container && !container->env)
1102	// this causes spurious floorbox updates, but it ensures	1178	// this causes spurious floorbox updates, but it ensures
1103	// that the CLOSE event is being sent.	1179	// that the CLOSE event is being sent.
1104	close_container ();	1180	close_container ();
1105		1181
1106	--map->players;	1182	--map->players;
1107	map->touch ();	1183	map->touch ();
1108	}	1184	}
1109	else if (pl->container == this)	1185	else if (pl->container_ () == this)
1110	{	1186	{
1111	// removing a container should close it	1187	// removing a container should close it
1112	close_container ();	1188	close_container ();
1113	}	1189	}
1114		1190	else
1115	esrv_del_item (pl->contr, count);	1191	esrv_del_item (pl->contr, count);
1116	}	1192	}
1117		1193
1118	/* link the object above us */	1194	/* link the object above us */
1119	// re-link, make sure compiler can easily use cmove	1195	// re-link, make sure compiler can easily use cmove
1120	*(above ? &above->below : &ms.top) = below;	1196	*(above ? &above->below : &ms.top) = below;
1121	*(below ? &below->above : &ms.bot) = above;	1197	*(below ? &below->above : &ms.bot) = above;
1122		1198
1123	above = 0;	1199	above = 0;
1124	below = 0;	1200	below = 0;
1125		1201
		1202	ms.invalidate ();
		1203
1126	if (map->in_memory == MAP_SAVING)	1204	if (map->in_memory == MAP_SAVING)
1127	return;	1205	return;
1128		1206
1129	int check_walk_off = !flag [FLAG_NO_APPLY];	1207	int check_walk_off = !flag [FLAG_NO_APPLY];
1130		1208
1131	if (object *pl = ms.player ())	1209	if (object *pl = ms.player ())
1132	{	1210	{
1133	if (pl->container == this)	1211	if (pl->container_ () == this)
1134	/* If a container that the player is currently using somehow gets	1212	/* If a container that the player is currently using somehow gets
1135	* removed (most likely destroyed), update the player view	1213	* removed (most likely destroyed), update the player view
1136	* appropriately.	1214	* appropriately.
1137	*/	1215	*/
1138	pl->close_container ();	1216	pl->close_container ();
…		…
1142	//TODO: update floorbox to preserve ordering	1220	//TODO: update floorbox to preserve ordering
1143	if (pl->contr->ns)	1221	if (pl->contr->ns)
1144	pl->contr->ns->floorbox_update ();	1222	pl->contr->ns->floorbox_update ();
1145	}	1223	}
1146		1224
		1225	if (check_walk_off)
1147	for (tmp = ms.bot; tmp; tmp = tmp->above)	1226	for (object *above, *tmp = ms.bot; tmp; tmp = above)
1148	{	1227	{
		1228	above = tmp->above;
		1229
1149	/* No point updating the players look faces if he is the object	1230	/* No point updating the players look faces if he is the object
1150	* being removed.	1231	* being removed.
1151	*/	1232	*/
1152		1233
1153	/* See if object moving off should effect something */	1234	/* See if object moving off should effect something */
1154	if (check_walk_off
1155	&& ((move_type & tmp->move_off)	1235	if ((move_type & tmp->move_off)
1156	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1236	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1157	{
1158	move_apply (tmp, this, 0);	1237	move_apply (tmp, this, 0);
1159
1160	if (destroyed ())
1161	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1162	}	1238	}
1163		1239
1164	last = tmp;	1240	if (affects_los ())
1165	}
1166
1167	/* last == NULL if there are no objects on this space */
1168	//TODO: this makes little sense, why only update the topmost object?
1169	if (!last)
1170	map->at (x, y).flags_ = 0;
1171	else
1172	update_object (last, UP_OBJ_REMOVE);
1173
1174	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1175	update_all_los (map, x, y);	1241	update_all_los (map, x, y);
1176	}	1242	}
1177	}	1243	}
1178		1244
1179	/*	1245	/*
…		…
1203	esrv_update_item (UPD_NROF, pl, top);	1269	esrv_update_item (UPD_NROF, pl, top);
1204		1270
1205	op->weight = 0; // cancel the addition above	1271	op->weight = 0; // cancel the addition above
1206	op->carrying = 0; // must be 0 already	1272	op->carrying = 0; // must be 0 already
1207		1273
1208	op->destroy (1);	1274	op->destroy ();
1209		1275
1210	return top;	1276	return top;
1211	}	1277	}
1212		1278
1213	return 0;	1279	return 0;
…		…
1221		1287
1222	object *prev = this;	1288	object *prev = this;
1223		1289
1224	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)	1290	for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1225	{	1291	{
1226	object *op = arch_to_object (at);	1292	object *op = at->instance ();
1227		1293
1228	op->name = name;	1294	op->name = name;
1229	op->name_pl = name_pl;	1295	op->name_pl = name_pl;
1230	op->title = title;	1296	op->title = title;
1231		1297
…		…
1269	* Passing 0 for flag gives proper default values, so flag really only needs	1335	* Passing 0 for flag gives proper default values, so flag really only needs
1270	* to be set if special handling is needed.	1336	* to be set if special handling is needed.
1271	*	1337	*
1272	* Return value:	1338	* Return value:
1273	* new object if 'op' was merged with other object	1339	* new object if 'op' was merged with other object
1274	* NULL if 'op' was destroyed	1340	* NULL if there was an error (destroyed, blocked etc.)
1275	* just 'op' otherwise	1341	* just 'op' otherwise
1276	*/	1342	*/
1277	object *	1343	object *
1278	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1344	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1279	{	1345	{
1280	if (op->is_on_map ())
1281	{
1282	LOG (llevError, "insert_ob_in_map called for object already on map");
1283	abort ();
1284	}
1285
1286	if (op->env)
1287	{
1288	LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1289	op->remove ();	1346	op->remove ();
		1347
		1348	if (m == &freed_map)//D TODO: remove soon
		1349	{//D
		1350	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1290	}	1351	}//D
1291		1352
1292	/* Ideally, the caller figures this out. However, it complicates a lot	1353	/* Ideally, the caller figures this out. However, it complicates a lot
1293	* of areas of callers (eg, anything that uses find_free_spot would now	1354	* of areas of callers (eg, anything that uses find_free_spot would now
1294	* need extra work	1355	* need extra work
1295	*/	1356	*/
		1357	maptile *newmap = m;
1296	if (!xy_normalise (m, op->x, op->y))	1358	if (!xy_normalise (newmap, op->x, op->y))
1297	{	1359	{
1298	op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found	1360	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1299	return 0;	1361	return 0;
1300	}	1362	}
1301		1363
1302	if (object *more = op->more)	1364	if (object *more = op->more)
1303	if (!insert_ob_in_map (more, m, originator, flag))	1365	if (!insert_ob_in_map (more, m, originator, flag))
1304	return 0;	1366	return 0;
1305		1367
1306	CLEAR_FLAG (op, FLAG_REMOVED);	1368	op->flag [FLAG_REMOVED] = false;
1307		1369	op->env = 0;
1308	op->map = m;	1370	op->map = newmap;
		1371
1309	mapspace &ms = op->ms ();	1372	mapspace &ms = op->ms ();
1310		1373
1311	/* this has to be done after we translate the coordinates.	1374	/* this has to be done after we translate the coordinates.
1312	*/	1375	*/
1313	if (op->nrof && !(flag & INS_NO_MERGE))	1376	if (op->nrof && !(flag & INS_NO_MERGE))
…		…
1316	{	1379	{
1317	// TODO: we actually want to update tmp, not op,	1380	// TODO: we actually want to update tmp, not op,
1318	// but some caller surely breaks when we return tmp	1381	// but some caller surely breaks when we return tmp
1319	// from here :/	1382	// from here :/
1320	op->nrof += tmp->nrof;	1383	op->nrof += tmp->nrof;
1321	tmp->destroy (1);	1384	tmp->destroy ();
1322	}	1385	}
1323		1386
1324	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1387	op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1325	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1388	op->clr_flag (FLAG_INV_LOCKED);
1326		1389
1327	if (!QUERY_FLAG (op, FLAG_ALIVE))	1390	if (!op->flag [FLAG_ALIVE])
1328	CLEAR_FLAG (op, FLAG_NO_STEAL);	1391	op->clr_flag (FLAG_NO_STEAL);
1329		1392
1330	if (flag & INS_BELOW_ORIGINATOR)	1393	if (flag & INS_BELOW_ORIGINATOR)
1331	{	1394	{
1332	if (originator->map != op->map || originator->x != op->x || originator->y != op->y)	1395	if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1333	{	1396	{
1334	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1397	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1335	abort ();	1398	abort ();
1336	}	1399	}
1337		1400
1338	if (!originator->is_on_map ())	1401	if (!originator->is_on_map ())
		1402	{
1339	LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",	1403	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1340	op->debug_desc (), originator->debug_desc ());	1404	op->debug_desc (), originator->debug_desc ());
		1405	abort ();
		1406	}
1341		1407
1342	op->above = originator;	1408	op->above = originator;
1343	op->below = originator->below;	1409	op->below = originator->below;
1344	originator->below = op;	1410	originator->below = op;
1345		1411
…		…
1365	* when lots of spells are cast in one area. Currently, it is presumed	1431	* when lots of spells are cast in one area. Currently, it is presumed
1366	* that flying non pickable objects are spell objects.	1432	* that flying non pickable objects are spell objects.
1367	*/	1433	*/
1368	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1434	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1369	{	1435	{
1370	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))	1436	if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1371	floor = tmp;	1437	floor = tmp;
1372		1438
1373	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))	1439	if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1374	{	1440	{
1375	/* We insert above top, so we want this object below this */	1441	/* We insert above top, so we want this object below this */
1376	top = tmp->below;	1442	top = tmp->below;
1377	break;	1443	break;
1378	}	1444	}
…		…
1396	&& (op->face && !faces [op->face].visibility))	1462	&& (op->face && !faces [op->face].visibility))
1397	{	1463	{
1398	object *last;	1464	object *last;
1399		1465
1400	for (last = top; last != floor; last = last->below)	1466	for (last = top; last != floor; last = last->below)
1401	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1467	if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1402	break;	1468	break;
1403		1469
1404	/* Check to see if we found the object that blocks view,	1470	/* Check to see if we found the object that blocks view,
1405	* and make sure we have a below pointer for it so that	1471	* and make sure we have a below pointer for it so that
1406	* we can get inserted below this one, which requires we	1472	* we can get inserted below this one, which requires we
…		…
1431	op->below = top;	1497	op->below = top;
1432	*(op->above ? &op->above->below : &ms.top) = op;	1498	*(op->above ? &op->above->below : &ms.top) = op;
1433	}	1499	}
1434	}	1500	}
1435		1501
1436	if (op->type == PLAYER)	1502	if (op->is_player ())
1437	{	1503	{
1438	op->contr->do_los = 1;	1504	op->contr->do_los = 1;
1439	++op->map->players;	1505	++op->map->players;
1440	op->map->touch ();	1506	op->map->touch ();
1441	}	1507	}
…		…
1456	* be far away from this change and not affected in any way -	1522	* be far away from this change and not affected in any way -
1457	* this should get redone to only look for players within range,	1523	* this should get redone to only look for players within range,
1458	* or just updating the P_UPTODATE for spaces within this area	1524	* or just updating the P_UPTODATE for spaces within this area
1459	* of effect may be sufficient.	1525	* of effect may be sufficient.
1460	*/	1526	*/
1461	if (op->map->darkness && (op->glow_radius != 0))	1527	if (op->affects_los ())
		1528	{
		1529	op->ms ().invalidate ();
1462	update_all_los (op->map, op->x, op->y);	1530	update_all_los (op->map, op->x, op->y);
		1531	}
1463		1532
1464	/* updates flags (blocked, alive, no magic, etc) for this map space */	1533	/* updates flags (blocked, alive, no magic, etc) for this map space */
1465	update_object (op, UP_OBJ_INSERT);	1534	update_object (op, UP_OBJ_INSERT);
1466		1535
1467	INVOKE_OBJECT (INSERT, op);	1536	INVOKE_OBJECT (INSERT, op);
…		…
1474	* blocked() and wall() work properly), and these flags are updated by	1543	* blocked() and wall() work properly), and these flags are updated by
1475	* update_object().	1544	* update_object().
1476	*/	1545	*/
1477		1546
1478	/* if this is not the head or flag has been passed, don't check walk on status */	1547	/* if this is not the head or flag has been passed, don't check walk on status */
1479	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1548	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1480	{	1549	{
1481	if (check_move_on (op, originator))	1550	if (check_move_on (op, originator, flag))
1482	return 0;	1551	return 0;
1483		1552
1484	/* If we are a multi part object, lets work our way through the check	1553	/* If we are a multi part object, let's work our way through the check
1485	* walk on's.	1554	* walk on's.
1486	*/	1555	*/
1487	for (object *tmp = op->more; tmp; tmp = tmp->more)	1556	for (object *tmp = op->more; tmp; tmp = tmp->more)
1488	if (check_move_on (tmp, originator))	1557	if (check_move_on (tmp, originator, flag))
1489	return 0;	1558	return 0;
1490	}	1559	}
1491		1560
1492	return op;	1561	return op;
1493	}	1562	}
…		…
1495	/* this function inserts an object in the map, but if it	1564	/* this function inserts an object in the map, but if it
1496	* finds an object of its own type, it'll remove that one first.	1565	* finds an object of its own type, it'll remove that one first.
1497	* op is the object to insert it under: supplies x and the map.	1566	* op is the object to insert it under: supplies x and the map.
1498	*/	1567	*/
1499	void	1568	void
1500	replace_insert_ob_in_map (const char *arch_string, object *op)	1569	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1501	{	1570	{
1502	/* first search for itself and remove any old instances */	1571	/* first search for itself and remove any old instances */
1503		1572
1504	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1573	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1505	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1574	if (tmp->arch->archname == archname) /* same archetype */
1506	tmp->destroy (1);	1575	tmp->destroy ();
1507		1576
1508	object *tmp = arch_to_object (archetype::find (arch_string));	1577	object *tmp = archetype::find (archname)->instance ();
1509		1578
1510	tmp->x = op->x;	1579	tmp->x = op->x;
1511	tmp->y = op->y;	1580	tmp->y = op->y;
1512		1581
1513	insert_ob_in_map (tmp, op->map, op, 0);	1582	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1518	{	1587	{
1519	if (where->env)	1588	if (where->env)
1520	return where->env->insert (this);	1589	return where->env->insert (this);
1521	else	1590	else
1522	return where->map->insert (this, where->x, where->y, originator, flags);	1591	return where->map->insert (this, where->x, where->y, originator, flags);
		1592	}
		1593
		1594	// check whether we can put this into the map, respect max_volume, max_items
		1595	bool
		1596	object::can_drop_at (maptile *m, int x, int y, object *originator)
		1597	{
		1598	mapspace &ms = m->at (x, y);
		1599
		1600	int items = ms.items ();
		1601
		1602	if (!items // testing !items ensures we can drop at least one item
		1603	|| (items < m->max_items
		1604	&& ms.volume () < m->max_volume))
		1605	return true;
		1606
		1607	if (originator && originator->is_player ())
		1608	originator->contr->failmsgf (
		1609	"No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
		1610	query_name ()
		1611	);
		1612
		1613	return false;
1523	}	1614	}
1524		1615
1525	/*	1616	/*
1526	* decrease(object, number) decreases a specified number from	1617	* decrease(object, number) decreases a specified number from
1527	* the amount of an object. If the amount reaches 0, the object	1618	* the amount of an object. If the amount reaches 0, the object
…		…
1535	if (!nr)	1626	if (!nr)
1536	return true;	1627	return true;
1537		1628
1538	nr = min (nr, nrof);	1629	nr = min (nr, nrof);
1539		1630
		1631	if (nrof > nr)
		1632	{
		1633	sint64 oweight = total_weight ();
		1634
1540	nrof -= nr;	1635	nrof -= nr;
1541
1542	if (nrof)
1543	{
1544	adjust_weight (env, -weight * nr); // carrying == 0
1545		1636
1546	if (object *pl = visible_to ())	1637	if (object *pl = visible_to ())
1547	esrv_update_item (UPD_NROF, pl, this);	1638	esrv_update_item (UPD_NROF, pl, this);
1548		1639
		1640	adjust_weight (env, oweight, total_weight ());
		1641
1549	return true;	1642	return true;
1550	}	1643	}
1551	else	1644	else
1552	{	1645	{
1553	destroy (1);	1646	destroy ();
1554	return false;	1647	return false;
1555	}	1648	}
1556	}	1649	}
1557		1650
1558	/*	1651	/*
…		…
1627	if (op->nrof)	1720	if (op->nrof)
1628	for (object *tmp = inv; tmp; tmp = tmp->below)	1721	for (object *tmp = inv; tmp; tmp = tmp->below)
1629	if (object::can_merge (tmp, op))	1722	if (object::can_merge (tmp, op))
1630	{	1723	{
1631	/* return the original object and remove inserted object	1724	/* return the original object and remove inserted object
1632	(client needs the original object) */	1725	(client prefers the original object) */
		1726
		1727	// carring must be 0 for mergable objects
		1728	sint64 oweight = tmp->weight * tmp->nrof;
		1729
1633	tmp->nrof += op->nrof;	1730	tmp->nrof += op->nrof;
1634		1731
1635	if (object *pl = tmp->visible_to ())	1732	if (object *pl = tmp->visible_to ())
1636	esrv_update_item (UPD_NROF, pl, tmp);	1733	esrv_update_item (UPD_NROF, pl, tmp);
1637		1734
1638	adjust_weight (this, op->total_weight ());	1735	adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1639		1736
1640	op->destroy (1);	1737	op->destroy ();
1641	op = tmp;	1738	op = tmp;
1642	goto inserted;	1739	goto inserted;
1643	}	1740	}
1644		1741
1645	op->owner = 0; // it's his/hers now. period.	1742	op->owner = 0; // it's his/hers now. period.
…		…
1659	op->flag [FLAG_REMOVED] = 0;	1756	op->flag [FLAG_REMOVED] = 0;
1660		1757
1661	if (object *pl = op->visible_to ())	1758	if (object *pl = op->visible_to ())
1662	esrv_send_item (pl, op);	1759	esrv_send_item (pl, op);
1663		1760
1664	adjust_weight (this, op->total_weight ());	1761	adjust_weight (this, 0, op->total_weight ());
1665		1762
1666	inserted:	1763	inserted:
1667	/* reset the light list and los of the players on the map */	1764	/* reset the light list and los of the players on the map */
1668	if (op->glow_radius && map && map->darkness)	1765	if (op->glow_radius && is_on_map ())
		1766	{
		1767	update_stats ();
1669	update_all_los (map, x, y);	1768	update_all_los (map, x, y);
1670		1769	}
		1770	else if (is_player ())
1671	// if this is a player's inventory, update stats	1771	// if this is a player's inventory, update stats
1672	if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])	1772	contr->queue_stats_update ();
1673	update_stats ();
1674		1773
1675	INVOKE_OBJECT (INSERT, this);	1774	INVOKE_OBJECT (INSERT, this);
1676		1775
1677	return op;	1776	return op;
1678	}	1777	}
…		…
1696	* MSW 2001-07-08: Check all objects on space, not just those below	1795	* MSW 2001-07-08: Check all objects on space, not just those below
1697	* object being inserted. insert_ob_in_map may not put new objects	1796	* object being inserted. insert_ob_in_map may not put new objects
1698	* on top.	1797	* on top.
1699	*/	1798	*/
1700	int	1799	int
1701	check_move_on (object *op, object *originator)	1800	check_move_on (object *op, object *originator, int flags)
1702	{	1801	{
		1802	if (op->flag [FLAG_NO_APPLY])
		1803	return 0;
		1804
1703	object *tmp;	1805	object *tmp;
1704	maptile *m = op->map;	1806	maptile *m = op->map;
1705	int x = op->x, y = op->y;	1807	int x = op->x, y = op->y;
1706		1808
1707	MoveType move_on, move_slow, move_block;	1809	mapspace &ms = m->at (x, y);
1708		1810
1709	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1811	ms.update ();
1710	return 0;
1711		1812
1712	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1813	MoveType move_on = ms.move_on;
1713	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1814	MoveType move_slow = ms.move_slow;
1714	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1815	MoveType move_block = ms.move_block;
1715		1816
1716	/* if nothing on this space will slow op down or be applied,	1817	/* if nothing on this space will slow op down or be applied,
1717	* no need to do checking below. have to make sure move_type	1818	* no need to do checking below. have to make sure move_type
1718	* is set, as lots of objects don't have it set - we treat that	1819	* is set, as lots of objects don't have it set - we treat that
1719	* as walking.	1820	* as walking.
…		…
1730	return 0;	1831	return 0;
1731		1832
1732	/* The objects have to be checked from top to bottom.	1833	/* The objects have to be checked from top to bottom.
1733	* Hence, we first go to the top:	1834	* Hence, we first go to the top:
1734	*/	1835	*/
1735		1836	for (object *next, *tmp = ms.top; tmp; tmp = next)
1736	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1737	{
1738	/* Trim the search when we find the first other spell effect
1739	* this helps performance so that if a space has 50 spell objects,
1740	* we don't need to check all of them.
1741	*/
1742	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1743	break;
1744	}	1837	{
		1838	next = tmp->below;
1745		1839
1746	for (; tmp; tmp = tmp->below)
1747	{
1748	if (tmp == op)	1840	if (tmp == op)
1749	continue; /* Can't apply yourself */	1841	continue; /* Can't apply yourself */
1750		1842
1751	/* Check to see if one of the movement types should be slowed down.	1843	/* Check to see if one of the movement types should be slowed down.
1752	* Second check makes sure that the movement types not being slowed	1844	* Second check makes sure that the movement types not being slowed
1753	* (~slow_move) is not blocked on this space - just because the	1845	* (~slow_move) is not blocked on this space - just because the
1754	* space doesn't slow down swimming (for example), if you can't actually	1846	* space doesn't slow down swimming (for example), if you can't actually
1755	* swim on that space, can't use it to avoid the penalty.	1847	* swim on that space, can't use it to avoid the penalty.
1756	*/	1848	*/
1757	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1849	if (!op->flag [FLAG_WIZPASS])
1758	{	1850	{
1759	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1851	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1760	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1852	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1761	{	1853	{
1762
1763	float
1764	diff = tmp->move_slow_penalty * fabs (op->speed);	1854	float diff = tmp->move_slow_penalty * fabs (op->speed);
1765		1855
1766	if (op->type == PLAYER)	1856	if (op->is_player ())
1767	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1857	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1768	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1858	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1769	diff /= 4.0;	1859	diff /= 4.0;
1770		1860
1771	op->speed_left -= diff;	1861	op->speed_left -= diff;
1772	}	1862	}
1773	}	1863	}
1774		1864
1775	/* Basically same logic as above, except now for actual apply. */	1865	/* Basically same logic as above, except now for actual apply. */
1776	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||	1866	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1777	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))	1867	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1778	{	1868	{
		1869	if ((flags & INS_NO_AUTO_EXIT)
		1870	&& (tmp->type == EXIT || tmp->type == TELEPORTER
		1871	|| tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
		1872	continue;
		1873
1779	move_apply (tmp, op, originator);	1874	move_apply (tmp, op, originator);
1780		1875
1781	if (op->destroyed ())	1876	if (op->destroyed ())
1782	return 1;	1877	return 1;
1783		1878
…		…
1895	void	1990	void
1896	flag_inv (object *op, int flag)	1991	flag_inv (object *op, int flag)
1897	{	1992	{
1898	for (object *tmp = op->inv; tmp; tmp = tmp->below)	1993	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1899	{	1994	{
1900	SET_FLAG (tmp, flag);	1995	tmp->set_flag (flag);
1901	flag_inv (tmp, flag);	1996	flag_inv (tmp, flag);
1902	}	1997	}
1903	}	1998	}
1904		1999
1905	/*	2000	/*
…		…
1908	void	2003	void
1909	unflag_inv (object *op, int flag)	2004	unflag_inv (object *op, int flag)
1910	{	2005	{
1911	for (object *tmp = op->inv; tmp; tmp = tmp->below)	2006	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1912	{	2007	{
1913	CLEAR_FLAG (tmp, flag);	2008	tmp->clr_flag (flag);
1914	unflag_inv (tmp, flag);	2009	unflag_inv (tmp, flag);
1915	}	2010	}
1916	}	2011	}
1917		2012
1918	/*	2013	/*
…		…
1979	* head of the object should correspond for the entire object.	2074	* head of the object should correspond for the entire object.
1980	*/	2075	*/
1981	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	2076	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1982	continue;	2077	continue;
1983		2078
1984	if (ob->blocked (m, pos.x, pos.y))	2079	if (ob->blocked (pos.m, pos.x, pos.y))
1985	continue;	2080	continue;
1986		2081
1987	altern [index++] = i;	2082	altern [index++] = i;
1988	}	2083	}
1989		2084
…		…
2057	* there is capable of.	2152	* there is capable of.
2058	*/	2153	*/
2059	int	2154	int
2060	find_dir (maptile *m, int x, int y, object *exclude)	2155	find_dir (maptile *m, int x, int y, object *exclude)
2061	{	2156	{
2062	int i, max = SIZEOFFREE, mflags;	2157	int max = SIZEOFFREE, mflags;
2063
2064	sint16 nx, ny;
2065	object *tmp;
2066	maptile *mp;
2067
2068	MoveType blocked, move_type;	2158	MoveType move_type;
2069		2159
2070	if (exclude && exclude->head_ () != exclude)	2160	if (exclude && exclude->head_ () != exclude)
2071	{	2161	{
2072	exclude = exclude->head;	2162	exclude = exclude->head;
2073	move_type = exclude->move_type;	2163	move_type = exclude->move_type;
…		…
2076	{	2166	{
2077	/* If we don't have anything, presume it can use all movement types. */	2167	/* If we don't have anything, presume it can use all movement types. */
2078	move_type = MOVE_ALL;	2168	move_type = MOVE_ALL;
2079	}	2169	}
2080		2170
2081	for (i = 1; i < max; i++)	2171	for (int i = 1; i < max; i++)
2082	{	2172	{
2083	mp = m;	2173	mapxy pos (m, x, y);
2084	nx = x + freearr_x[i];	2174	pos.move (i);
2085	ny = y + freearr_y[i];
2086		2175
2087	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2176	if (!pos.normalise ())
2088
2089	if (mflags & P_OUT_OF_MAP)
2090	max = maxfree[i];	2177	max = maxfree[i];
2091	else	2178	else
2092	{	2179	{
2093	mapspace &ms = mp->at (nx, ny);	2180	mapspace &ms = *pos;
2094		2181
2095	blocked = ms.move_block;
2096
2097	if ((move_type & blocked) == move_type)	2182	if ((move_type & ms.move_block) == move_type)
2098	max = maxfree[i];	2183	max = maxfree [i];
2099	else if (mflags & P_IS_ALIVE)	2184	else if (ms.flags () & P_IS_ALIVE)
2100	{	2185	{
2101	for (tmp = ms.bot; tmp; tmp = tmp->above)	2186	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2102	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2187	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2103	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2188	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2104	break;
2105
2106	if (tmp)
2107	return freedir[i];	2189	return freedir [i];
2108	}	2190	}
2109	}	2191	}
2110	}	2192	}
2111		2193
2112	return 0;	2194	return 0;
…		…
2121	{	2203	{
2122	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);	2204	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2123	}	2205	}
2124		2206
2125	/*	2207	/*
2126	* find_dir_2(delta-x,delta-y) will return a direction in which	2208	* find_dir_2(delta-x,delta-y) will return a direction value
2127	* an object which has subtracted the x and y coordinates of another	2209	* for running into direct [dx, dy].
2128	* object, needs to travel toward it.	2210	* (the opposite of crossfire's find_dir_2!)
2129	*/	2211	*/
2130	int	2212	int
2131	find_dir_2 (int x, int y)	2213	find_dir_2 (int x, int y)
2132	{	2214	{
		2215	#if 1 // new algorithm
		2216	// this works by putting x, y into 16 sectors, which
		2217	// are not equal sized, but are a better approximation
		2218	// then the old algorithm, and then using a mapping
		2219	// table to map it into a direction value.
		2220	// basically, it maps these comparisons to each bit
		2221	// bit #3: x < 0
		2222	// bit #2: y < 0
		2223	// bit #1: x > y
		2224	// bit #0: x > 2y
		2225
		2226	static const uint8 dir[16] = {
		2227	4, 5, 4, 3,
		2228	2, 1, 2, 3,
		2229	6, 5, 6, 7,
		2230	8, 1, 8, 7,
		2231	};
		2232	int sector = 0;
		2233
		2234	// this is a bit ugly, but more likely to result in branchless code
		2235	sector |= x < 0 ? 8 : 0;
		2236	x = x < 0 ? -x : x; // abs
		2237
		2238	sector |= y < 0 ? 4 : 0;
		2239	y = y < 0 ? -y : y; // abs
		2240
		2241	if (x > y)
		2242	{
		2243	sector |= 2;
		2244
		2245	if (x > y * 2)
		2246	sector |= 1;
		2247	}
		2248	else
		2249	{
		2250	if (y > x * 2)
		2251	sector |= 1;
		2252	else if (!y)
		2253	return 0; // x == 0 here
		2254	}
		2255
		2256	return dir [sector];
		2257	#else // old algorithm
2133	int q;	2258	int q;
2134		2259
2135	if (y)	2260	if (y)
2136	q = x * 100 / y;	2261	q = 128 * x / y;
2137	else if (x)	2262	else if (x)
2138	q = -300 * x;	2263	q = -512 * x; // to make it > 309
2139	else	2264	else
2140	return 0;	2265	return 0;
2141		2266
2142	if (y > 0)	2267	if (y > 0)
2143	{	2268	{
2144	if (q < -242)	2269	if (q < -309) return 7;
		2270	if (q < -52) return 6;
		2271	if (q < 52) return 5;
		2272	if (q < 309) return 4;
		2273
2145	return 3;	2274	return 3;
2146	if (q < -41)	2275	}
2147	return 2;	2276	else
2148	if (q < 41)	2277	{
2149	return 1;	2278	if (q < -309) return 3;
2150	if (q < 242)	2279	if (q < -52) return 2;
2151	return 8;	2280	if (q < 52) return 1;
		2281	if (q < 309) return 8;
		2282
2152	return 7;	2283	return 7;
2153	}	2284	}
2154		2285	#endif
2155	if (q < -242)
2156	return 7;
2157	if (q < -41)
2158	return 6;
2159	if (q < 41)
2160	return 5;
2161	if (q < 242)
2162	return 4;
2163
2164	return 3;
2165	}	2286	}
2166		2287
2167	/*	2288	/*
2168	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is	2289	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2169	* between two directions (which are expected to be absolute (see absdir())	2290	* between two directions (which are expected to be absolute (see absdir())
2170	*/	2291	*/
2171	int	2292	int
2172	dirdiff (int dir1, int dir2)	2293	dirdiff (int dir1, int dir2)
2173	{	2294	{
2174	int d;
2175
2176	d = abs (dir1 - dir2);	2295	int d = abs (dir1 - dir2);
2177	if (d > 4)
2178	d = 8 - d;
2179		2296
2180	return d;	2297	return d > 4 ? 8 - d : d;
2181	}	2298	}
2182		2299
2183	/* peterm:	2300	/* peterm:
2184	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.	2301	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2185	* Basically, this is a table of directions, and what directions	2302	* Basically, this is a table of directions, and what directions
…		…
2187	* This basically means that if direction is 15, then it could either go	2304	* This basically means that if direction is 15, then it could either go
2188	* direction 4, 14, or 16 to get back to where we are.	2305	* direction 4, 14, or 16 to get back to where we are.
2189	* Moved from spell_util.c to object.c with the other related direction	2306	* Moved from spell_util.c to object.c with the other related direction
2190	* functions.	2307	* functions.
2191	*/	2308	*/
2192	int reduction_dir[SIZEOFFREE][3] = {	2309	static const int reduction_dir[SIZEOFFREE][3] = {
2193	{0, 0, 0}, /* 0 */	2310	{0, 0, 0}, /* 0 */
2194	{0, 0, 0}, /* 1 */	2311	{0, 0, 0}, /* 1 */
2195	{0, 0, 0}, /* 2 */	2312	{0, 0, 0}, /* 2 */
2196	{0, 0, 0}, /* 3 */	2313	{0, 0, 0}, /* 3 */
2197	{0, 0, 0}, /* 4 */	2314	{0, 0, 0}, /* 4 */
…		…
2291	* Add a check so we can't pick up invisible objects (0.93.8)	2408	* Add a check so we can't pick up invisible objects (0.93.8)
2292	*/	2409	*/
2293	int	2410	int
2294	can_pick (const object *who, const object *item)	2411	can_pick (const object *who, const object *item)
2295	{	2412	{
2296	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2413	return /*who->flag [FLAG_WIZ]|| */
2297	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2414	(item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2298	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2415	!item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2299	}	2416	}
2300		2417
2301	/*	2418	/*
2302	* create clone from object to another	2419	* create clone from object to another
2303	*/	2420	*/
…		…
2335	return tmp;	2452	return tmp;
2336		2453
2337	return 0;	2454	return 0;
2338	}	2455	}
2339		2456
2340	const shstr &	2457	/* Zero the key_values on op, decrementing the shared-string
2341	object::kv_get (const shstr &key) const	2458	* refcounts and freeing the links.
		2459	*/
		2460	void
		2461	key_values::clear ()
2342	{	2462	{
		2463	for (key_value *kvp = first; kvp; )
		2464	{
		2465	key_value *next = kvp->next;
		2466	delete kvp;
		2467	kvp = next;
		2468	}
		2469
		2470	first = 0;
		2471	}
		2472
		2473	shstr_tmp
		2474	key_values::get (shstr_tmp key) const
		2475	{
2343	for (key_value *kv = key_values; kv; kv = kv->next)	2476	for (key_value *kv = first; kv; kv = kv->next)
2344	if (kv->key == key)	2477	if (kv->key == key)
2345	return kv->value;	2478	return kv->value;
2346		2479
2347	return shstr_null;	2480	return shstr ();
2348	}	2481	}
2349		2482
2350	void	2483	void
2351	object::kv_set (const shstr &key, const shstr &value)	2484	key_values::add (shstr_tmp key, shstr_tmp value)
2352	{	2485	{
		2486	key_value *kv = new key_value;
		2487
		2488	kv->next = first;
		2489	kv->key = key;
		2490	kv->value = value;
		2491
		2492	first = kv;
		2493	}
		2494
		2495	void
		2496	key_values::set (shstr_tmp key, shstr_tmp value)
		2497	{
2353	for (key_value *kv = key_values; kv; kv = kv->next)	2498	for (key_value *kv = first; kv; kv = kv->next)
2354	if (kv->key == key)	2499	if (kv->key == key)
2355	{	2500	{
2356	kv->value = value;	2501	kv->value = value;
2357	return;	2502	return;
2358	}	2503	}
2359		2504
2360	key_value *kv = new key_value;	2505	add (key, value);
2361
2362	kv->next = key_values;
2363	kv->key = key;
2364	kv->value = value;
2365
2366	key_values = kv;
2367	}	2506	}
2368		2507
2369	void	2508	void
2370	object::kv_del (const shstr &key)	2509	key_values::del (shstr_tmp key)
2371	{	2510	{
2372	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)	2511	for (key_value **kvp = &first; *kvp; kvp = &(*kvp)->next)
2373	if ((*kvp)->key == key)	2512	if ((*kvp)->key == key)
2374	{	2513	{
2375	key_value *kv = *kvp;	2514	key_value *kv = *kvp;
2376	*kvp = (*kvp)->next;	2515	*kvp = (*kvp)->next;
2377	delete kv;	2516	delete kv;
2378	return;	2517	return;
2379	}	2518	}
		2519	}
		2520
		2521	void
		2522	key_values::reverse ()
		2523	{
		2524	key_value *prev = 0;
		2525	key_value *head = first;
		2526
		2527	while (head)
		2528	{
		2529	key_value *node = head;
		2530	head = head->next;
		2531	node->next = prev;
		2532	prev = node;
		2533	}
		2534
		2535	first = prev;
		2536	}
		2537
		2538	key_values &
		2539	key_values::operator =(const key_values &kv)
		2540	{
		2541	clear ();
		2542
		2543	for (key_value *kvp = kv.first; kvp; kvp = kvp->next)
		2544	add (kvp->key, kvp->value);
		2545
		2546	reverse ();
2380	}	2547	}
2381		2548
2382	object::depth_iterator::depth_iterator (object *container)	2549	object::depth_iterator::depth_iterator (object *container)
2383	: iterator_base (container)	2550	: iterator_base (container)
2384	{	2551	{
…		…
2468	{	2635	{
2469	return map ? map->region (x, y)	2636	return map ? map->region (x, y)
2470	: region::default_region ();	2637	: region::default_region ();
2471	}	2638	}
2472		2639
2473	const materialtype_t *
2474	object::dominant_material () const
2475	{
2476	if (materialtype_t *mt = name_to_material (materialname))
2477	return mt;
2478
2479	return name_to_material (shstr_unknown);
2480	}
2481
2482	void	2640	void
2483	object::open_container (object *new_container)	2641	object::open_container (object *new_container)
2484	{	2642	{
2485	if (container == new_container)	2643	if (container == new_container)
2486	return;	2644	return;
…		…
2506	container = 0;	2664	container = 0;
2507		2665
2508	// client needs item update to make it work, client bug requires this to be separate	2666	// client needs item update to make it work, client bug requires this to be separate
2509	esrv_update_item (UPD_FLAGS, this, old_container);	2667	esrv_update_item (UPD_FLAGS, this, old_container);
2510		2668
2511	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2669	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2512	play_sound (sound_find ("chest_close"));	2670	play_sound (sound_find ("chest_close"));
2513	}	2671	}
2514		2672
2515	if (new_container)	2673	if (new_container)
2516	{	2674	{
…		…
2520	// TODO: this does not seem to serve any purpose anymore?	2678	// TODO: this does not seem to serve any purpose anymore?
2521	#if 0	2679	#if 0
2522	// insert the "Close Container" object.	2680	// insert the "Close Container" object.
2523	if (archetype *closer = new_container->other_arch)	2681	if (archetype *closer = new_container->other_arch)
2524	{	2682	{
2525	object *closer = arch_to_object (new_container->other_arch);	2683	object *closer = new_container->other_arch->instance ();
2526	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2684	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2527	new_container->insert (closer);	2685	new_container->insert (closer);
2528	}	2686	}
2529	#endif	2687	#endif
2530		2688
2531	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2689	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2532		2690
2533	// make sure the container is available, client bug requires this to be separate	2691	// make sure the container is available, client bug requires this to be separate
2534	esrv_send_item (this, new_container);	2692	esrv_send_item (this, new_container);
2535		2693
2536	new_container->flag [FLAG_APPLIED] = true;	2694	new_container->flag [FLAG_APPLIED] = true;
…		…
2544	// else if (!old_container->env && contr && contr->ns)	2702	// else if (!old_container->env && contr && contr->ns)
2545	// contr->ns->floorbox_reset ();	2703	// contr->ns->floorbox_reset ();
2546	}	2704	}
2547		2705
2548	object *	2706	object *
2549	object::force_find (const shstr name)	2707	object::force_find (shstr_tmp name)
2550	{	2708	{
2551	/* cycle through his inventory to look for the MARK we want to	2709	/* cycle through his inventory to look for the MARK we want to
2552	* place	2710	* place
2553	*/	2711	*/
2554	for (object *tmp = inv; tmp; tmp = tmp->below)	2712	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2556	return splay (tmp);	2714	return splay (tmp);
2557		2715
2558	return 0;	2716	return 0;
2559	}	2717	}
2560		2718
		2719	//-GPL
		2720
2561	void	2721	void
		2722	object::force_set_timer (int duration)
		2723	{
		2724	this->duration = 1;
		2725	this->speed_left = -1.f;
		2726
		2727	this->set_speed (duration ? 1.f / duration : 0.f);
		2728	}
		2729
		2730	object *
2562	object::force_add (const shstr name, int duration)	2731	object::force_add (shstr_tmp name, int duration)
2563	{	2732	{
2564	if (object *force = force_find (name))	2733	if (object *force = force_find (name))
2565	force->destroy ();	2734	force->destroy ();
2566		2735
2567	object *force = get_archetype (FORCE_NAME);	2736	object *force = get_archetype (FORCE_NAME);
2568		2737
2569	force->slaying = name;	2738	force->slaying = name;
2570	force->stats.food = 1;	2739	force->force_set_timer (duration);
2571	force->speed_left = -1.f;
2572
2573	force->set_speed (duration ? 1.f / duration : 0.f);
2574	force->flag [FLAG_IS_USED_UP] = true;
2575	force->flag [FLAG_APPLIED] = true;	2740	force->flag [FLAG_APPLIED] = true;
2576		2741
2577	insert (force);	2742	return insert (force);
2578	}	2743	}
2579		2744
2580	void	2745	void
2581	object::play_sound (faceidx sound)	2746	object::play_sound (faceidx sound) const
2582	{	2747	{
2583	if (!sound)	2748	if (!sound)
2584	return;	2749	return;
2585		2750
2586	if (flag [FLAG_REMOVED])	2751	if (is_on_map ())
		2752	map->play_sound (sound, x, y);
		2753	else if (object *pl = in_player ())
		2754	pl->contr->play_sound (sound);
		2755	}
		2756
		2757	void
		2758	object::say_msg (const char *msg) const
		2759	{
		2760	if (is_on_map ())
		2761	map->say_msg (msg, x, y);
		2762	else if (object *pl = in_player ())
		2763	pl->contr->play_sound (sound);
		2764	}
		2765
		2766	void
		2767	object::make_noise ()
		2768	{
		2769	// we do not model noise in the map, so instead put
		2770	// a temporary light into the noise source
		2771	// could use the map instead, but that's less reliable for our
		2772	// goal, which is to make invisibility a bit harder to exploit
		2773
		2774	// currently only works sensibly for players
		2775	if (!is_player ())
2587	return;	2776	return;
2588		2777
2589	if (env)	2778	// find old force, or create new one
2590	{	2779	object *force = force_find (shstr_noise_force);
2591	if (object *pl = in_player ())	2780
2592	pl->contr->play_sound (sound);	2781	if (force)
2593	}	2782	force->speed_left = -1.f; // patch old speed up
2594	else	2783	else
2595	map->play_sound (sound, x, y);	2784	{
2596	}	2785	force = archetype::get (shstr_noise_force);
2597		2786
		2787	force->slaying = shstr_noise_force;
		2788	force->stats.food = 1;
		2789	force->speed_left = -1.f;
		2790
		2791	force->set_speed (1.f / 4.f);
		2792	force->flag [FLAG_IS_USED_UP] = true;
		2793	force->flag [FLAG_APPLIED] = true;
		2794
		2795	insert (force);
		2796	}
		2797	}
		2798
		2799	void object::change_move_type (MoveType mt)
		2800	{
		2801	if (move_type == mt)
		2802	return;
		2803
		2804	if (is_on_map ())
		2805	{
		2806	// we are on the map, so handle move_on/off effects
		2807	remove ();
		2808	move_type = mt;
		2809	map->insert (this, x, y, this);
		2810	}
		2811	else
		2812	move_type = mt;
		2813	}
		2814
		2815	/* object should be a player.
		2816	* we return the object the player has marked with the 'mark' command
		2817	* below. If no match is found (or object has changed), we return
		2818	* NULL. We leave it up to the calling function to print messages if
		2819	* nothing is found.
		2820	*/
		2821	object *
		2822	object::mark () const
		2823	{
		2824	if (contr && contr->mark && contr->mark->env == this)
		2825	return contr->mark;
		2826	else
		2827	return 0;
		2828	}
		2829
		2830	// put marked object first in the inventory
		2831	// this is used by identify-like spells so players can influence
		2832	// the order a bit.
		2833	void
		2834	object::splay_marked ()
		2835	{
		2836	if (object *marked = mark ())
		2837	splay (marked);
		2838	}
		2839

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines