ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.203 by root, Fri Apr 11 13:59:05 2008 UTC vs.
Revision 1.245 by root, Sun May 18 19:53:07 2008 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save;
39static const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
40 37
41objectvec objects; 38objectvec objects;
42activevec actives; 39activevec actives;
43 40
44short freearr_x[SIZEOFFREE] = { 41short freearr_x[SIZEOFFREE] = {
81{ 78{
82 char filename[MAX_BUF]; 79 char filename[MAX_BUF];
83 80
84 sprintf (filename, "%s/uuid", settings.localdir); 81 sprintf (filename, "%s/uuid", settings.localdir);
85 82
83 seq_next_save = 0;
84
86 FILE *fp; 85 FILE *fp;
87 86
88 if (!(fp = fopen (filename, "r"))) 87 if (!(fp = fopen (filename, "r")))
89 { 88 {
90 if (errno == ENOENT) 89 if (errno == ENOENT)
91 { 90 {
92 LOG (llevInfo, "RESET uid to 1\n"); 91 LOG (llevInfo, "RESET uid to 1\n");
93 UUID::cur.seq = 0; 92 UUID::cur.seq = 0;
94 write_uuid (UUID_SKIP, true); 93 write_uuid (UUID_GAP, true);
95 return; 94 return;
96 } 95 }
97 96
98 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
99 _exit (1); 98 _exit (1);
109 _exit (1); 108 _exit (1);
110 } 109 }
111 110
112 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ()); 111 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
113 112
114 write_uuid (UUID_SKIP, true); 113 write_uuid (UUID_GAP, true);
115 fclose (fp); 114 fclose (fp);
116} 115}
117 116
118UUID 117UUID
119UUID::gen () 118UUID::gen ()
120{ 119{
121 UUID uid; 120 UUID uid;
122 121
123 uid.seq = ++cur.seq; 122 uid.seq = ++cur.seq;
124 123
125 if (expect_false (!(cur.seq & (UUID_SKIP - 1)))) 124 if (expect_false (cur.seq >= seq_next_save))
125 {
126 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
126 write_uuid (UUID_SKIP, false); 127 write_uuid (UUID_GAP, false);
128 }
129
127 130
128 return uid; 131 return uid;
129} 132}
130 133
131void 134void
133{ 136{
134 read_uuid (); 137 read_uuid ();
135} 138}
136 139
137/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
138static int 141static bool
139compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
140{ 143{
141 key_value *wants_field;
142
143 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
144 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
145 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
146 */ 147 */
147 148
148 /* For each field in wants, */ 149 /* For each field in wants, */
149 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
150 { 151 if (has->kv_get (kv->key) != kv->value)
151 key_value *has_field; 152 return false;
152
153 /* Look for a field in has with the same key. */
154 has_field = get_ob_key_link (has, wants_field->key);
155
156 if (has_field == NULL)
157 {
158 /* No field with that name. */
159 return FALSE;
160 }
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 {
165 /* Values don't match, so this half of the comparison is false. */
166 return FALSE;
167 }
168
169 /* If we get here, we found a match. Now for the next field in wants. */
170 }
171 153
172 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
173 return TRUE; 155 return true;
174} 156}
175 157
176/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
177static int 159static bool
178compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
179{ 161{
180 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
181 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
182 */ 164 */
183 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
184} 167}
185 168
186/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
187 * they can be merged together. 170 * they can be merged together.
188 * 171 *
203 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
204 || ob1->value != ob2->value 187 || ob1->value != ob2->value
205 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
206 return 0; 189 return 0;
207 190
208 //TODO: this ain't working well, use nicer and correct overflow check 191 // some objects are unmergable
209 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 if (!ob1->nrof || !ob2->nrof)
210 * value could not be stored in a sint32 (which unfortunately sometimes is 193 return 0;
211 * used to store nrof). 194
195 /* Do not merge objects if nrof would overflow. First part checks
196 * for unsigned overflow (2c), second part checks whether the result
197 * would fit into a 32 bit signed int, which is often used to hold
198 * nrof values.
212 */ 199 */
213 if (ob1->nrof + ob2->nrof >= 1UL << 31) 200 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
214 return 0; 201 return 0;
215 202
216 /* If the objects have been identified, set the BEEN_APPLIED flag. 203 /* If the objects have been identified, set the BEEN_APPLIED flag.
217 * This is to the comparison of the flags below will be OK. We 204 * This is to the comparison of the flags below will be OK. We
218 * just can't ignore the been applied or identified flags, as they 205 * just can't ignore the been applied or identified flags, as they
219 * are not equal - just if it has been identified, the been_applied 206 * are not equal - just if it has been identified, the been_applied
220 * flags lose any meaning. 207 * flags lose any meaning.
221 */ 208 */
222 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 209 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
223 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 210 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
224 211
225 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 212 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
226 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 213 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
227 214
228 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 215 if (ob1->arch->archname != ob2->arch->archname
229 || ob1->arch != ob2->arch
230 || ob1->name != ob2->name 216 || ob1->name != ob2->name
231 || ob1->title != ob2->title 217 || ob1->title != ob2->title
232 || ob1->msg != ob2->msg 218 || ob1->msg != ob2->msg
233 || ob1->weight != ob2->weight 219 || ob1->weight != ob2->weight
234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
236 || ob1->attacktype != ob2->attacktype 220 || ob1->attacktype != ob2->attacktype
237 || ob1->magic != ob2->magic 221 || ob1->magic != ob2->magic
238 || ob1->slaying != ob2->slaying 222 || ob1->slaying != ob2->slaying
239 || ob1->skill != ob2->skill 223 || ob1->skill != ob2->skill
240 || ob1->value != ob2->value 224 || ob1->value != ob2->value
241 || ob1->animation_id != ob2->animation_id 225 || ob1->animation_id != ob2->animation_id
226 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
242 || ob1->client_type != ob2->client_type 227 || ob1->client_type != ob2->client_type
243 || ob1->materialname != ob2->materialname 228 || ob1->materialname != ob2->materialname
244 || ob1->lore != ob2->lore 229 || ob1->lore != ob2->lore
245 || ob1->subtype != ob2->subtype 230 || ob1->subtype != ob2->subtype
246 || ob1->move_type != ob2->move_type 231 || ob1->move_type != ob2->move_type
247 || ob1->move_block != ob2->move_block 232 || ob1->move_block != ob2->move_block
248 || ob1->move_allow != ob2->move_allow 233 || ob1->move_allow != ob2->move_allow
249 || ob1->move_on != ob2->move_on 234 || ob1->move_on != ob2->move_on
250 || ob1->move_off != ob2->move_off 235 || ob1->move_off != ob2->move_off
251 || ob1->move_slow != ob2->move_slow 236 || ob1->move_slow != ob2->move_slow
252 || ob1->move_slow_penalty != ob2->move_slow_penalty) 237 || ob1->move_slow_penalty != ob2->move_slow_penalty
238 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
253 return 0; 240 return 0;
254 241
242 if ((ob1->flag ^ ob2->flag)
243 .reset (FLAG_INV_LOCKED)
244 .reset (FLAG_CLIENT_SENT)
245 .reset (FLAG_REMOVED)
246 .any ())
247 return 0;
248
255 /* This is really a spellbook check - really, we should 249 /* This is really a spellbook check - we should in general
256 * check all objects in the inventory. 250 * not merge objects with real inventories, as splitting them
251 * is hard.
257 */ 252 */
258 if (ob1->inv || ob2->inv) 253 if (ob1->inv || ob2->inv)
259 { 254 {
260 if (!(ob1->inv && ob2->inv)) 255 if (!(ob1->inv && ob2->inv))
261 return 0; /* inventories differ in length */ 256 return 0; /* inventories differ in length */
262 257
263 if (ob1->inv->below || ob2->inv->below) 258 if (ob1->inv->below || ob2->inv->below)
264 return 0; /* more than one object in inv */ 259 return 0; /* more than one object in inv */
265 260
266 if (!object::can_merge (ob1->inv, ob2->inv)) 261 if (!object::can_merge (ob1->inv, ob2->inv))
267 return 0; /* inventory objexts differ */ 262 return 0; /* inventory objects differ */
268 263
269 /* inventory ok - still need to check rest of this object to see 264 /* inventory ok - still need to check rest of this object to see
270 * if it is valid. 265 * if it is valid.
271 */ 266 */
272 } 267 }
291 if (ob1->level != ob2->level) 286 if (ob1->level != ob2->level)
292 return 0; 287 return 0;
293 break; 288 break;
294 } 289 }
295 290
296 if (ob1->key_values != NULL || ob2->key_values != NULL) 291 if (ob1->key_values || ob2->key_values)
297 { 292 {
298 /* At least one of these has key_values. */ 293 /* At least one of these has key_values. */
299 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 294 if ((!ob1->key_values) != (!ob2->key_values))
300 /* One has fields, but the other one doesn't. */ 295 return 0; /* One has fields, but the other one doesn't. */
301 return 0; 296
302 else if (!compare_ob_value_lists (ob1, ob2)) 297 if (!compare_ob_value_lists (ob1, ob2))
303 return 0; 298 return 0;
304 } 299 }
305 300
306 if (ob1->self || ob2->self) 301 if (ob1->self || ob2->self)
307 { 302 {
313 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 308 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
314 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 309 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
315 310
316 if (k1 != k2) 311 if (k1 != k2)
317 return 0; 312 return 0;
313
318 else if (k1 == 0) 314 if (k1 == 0)
319 return 1; 315 return 1;
316
320 else if (!cfperl_can_merge (ob1, ob2)) 317 if (!cfperl_can_merge (ob1, ob2))
321 return 0; 318 return 0;
322 } 319 }
323 } 320 }
324 321
325 /* Everything passes, must be OK. */ 322 /* Everything passes, must be OK. */
326 return 1; 323 return 1;
327} 324}
328 325
326// find player who can see this object
327object *
328object::visible_to () const
329{
330 if (client_visible () && !flag [FLAG_REMOVED])
331 {
332 // see if we are in a container of sorts
333 if (env)
334 {
335 // the player inventory itself is always visible
336 if (env->type == PLAYER)
337 return env;
338
339 // else a player could have our env open
340 object *envest = env->outer_env ();
341
342 // the player itself is always on a map, so we will find him here
343 // even if our inv is in a player.
344 if (envest->is_on_map ())
345 if (object *pl = envest->ms ().player ())
346 if (pl->container == env)
347 return pl;
348 }
349 else
350 {
351 // maybe there is a player standing on the same mapspace
352 // this will catch the case where "this" is a player
353 if (object *pl = ms ().player ())
354 if (!pl->container || this == pl->container)
355 return pl;
356 }
357 }
358
359 return 0;
360}
361
362// adjust weight per container type ("of holding")
363static sint32
364weight_adjust_for (object *op, sint32 weight)
365{
366 return op->type == CONTAINER
367 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
368 : weight;
369}
370
329/* 371/*
372 * adjust_weight(object, weight) adds the specified weight to an object,
373 * and also updates how much the environment(s) is/are carrying.
374 */
375static void
376adjust_weight (object *op, sint32 weight)
377{
378 while (op)
379 {
380 // adjust by actual difference to account for rounding errors
381 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
382 weight = weight_adjust_for (op, op->carrying)
383 - weight_adjust_for (op, op->carrying - weight);
384
385 if (!weight)
386 return;
387
388 op->carrying += weight;
389
390 if (object *pl = op->visible_to ())
391 if (pl != op) // player is handled lazily
392 esrv_update_item (UPD_WEIGHT, pl, op);
393
394 op = op->env;
395 }
396}
397
398/*
330 * sum_weight() is a recursive function which calculates the weight 399 * this is a recursive function which calculates the weight
331 * an object is carrying. It goes through in figures out how much 400 * an object is carrying. It goes through op and figures out how much
332 * containers are carrying, and sums it up. 401 * containers are carrying, and sums it up.
333 */ 402 */
334long 403void
335sum_weight (object *op) 404object::update_weight ()
336{ 405{
337 long sum; 406 sint32 sum = 0;
338 object *inv;
339 407
340 for (sum = 0, inv = op->inv; inv; inv = inv->below) 408 for (object *op = inv; op; op = op->below)
341 { 409 {
342 if (inv->inv) 410 if (op->inv)
343 sum_weight (inv); 411 op->update_weight ();
344 412
345 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 413 sum += op->total_weight ();
414 }
415
416 sum = weight_adjust_for (this, sum);
417
418 if (sum != carrying)
346 } 419 {
347
348 if (op->type == CONTAINER && op->stats.Str)
349 sum = (sum * (100 - op->stats.Str)) / 100;
350
351 if (op->carrying != sum)
352 op->carrying = sum; 420 carrying = sum;
353 421
354 return sum; 422 if (object *pl = visible_to ())
423 if (pl != this) // player is handled lazily
424 esrv_update_item (UPD_WEIGHT, pl, this);
425 }
355} 426}
356 427
357/** 428/*
358 * Return the outermost environment object for a given object. 429 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
359 */
360
361object *
362object_get_env_recursive (object *op)
363{
364 while (op->env != NULL)
365 op = op->env;
366 return op;
367}
368
369/*
370 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
371 * Some error messages.
372 * The result of the dump is stored in the static global errmsg array.
373 */ 430 */
374char * 431char *
375dump_object (object *op) 432dump_object (object *op)
376{ 433{
377 if (!op) 434 if (!op)
391get_nearest_part (object *op, const object *pl) 448get_nearest_part (object *op, const object *pl)
392{ 449{
393 object *tmp, *closest; 450 object *tmp, *closest;
394 int last_dist, i; 451 int last_dist, i;
395 452
396 if (op->more == NULL) 453 if (!op->more)
397 return op; 454 return op;
455
398 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 456 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
457 tmp;
458 tmp = tmp->more)
399 if ((i = distance (tmp, pl)) < last_dist) 459 if ((i = distance (tmp, pl)) < last_dist)
400 closest = tmp, last_dist = i; 460 closest = tmp, last_dist = i;
461
401 return closest; 462 return closest;
402} 463}
403 464
404/* 465/*
405 * Returns the object which has the count-variable equal to the argument. 466 * Returns the object which has the count-variable equal to the argument.
467 * VERRRY slow.
406 */ 468 */
407object * 469object *
408find_object (tag_t i) 470find_object (tag_t i)
409{ 471{
410 for_all_objects (op) 472 for_all_objects (op)
421 */ 483 */
422object * 484object *
423find_object_name (const char *str) 485find_object_name (const char *str)
424{ 486{
425 shstr_cmp str_ (str); 487 shstr_cmp str_ (str);
426 object *op;
427 488
489 if (str_)
428 for_all_objects (op) 490 for_all_objects (op)
429 if (op->name == str_) 491 if (op->name == str_)
430 break; 492 return op;
431 493
432 return op; 494 return 0;
433} 495}
434 496
435/* 497/*
436 * Sets the owner and sets the skill and exp pointers to owner's current 498 * Sets the owner and sets the skill and exp pointers to owner's current
437 * skill and experience objects. 499 * skill and experience objects.
535 } 597 }
536 598
537 op->key_values = 0; 599 op->key_values = 0;
538} 600}
539 601
540object & 602/*
541object::operator =(const object &src) 603 * copy_to first frees everything allocated by the dst object,
604 * and then copies the contents of itself into the second
605 * object, allocating what needs to be allocated. Basically, any
606 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
607 * if the first object is freed, the pointers in the new object
608 * will point at garbage.
609 */
610void
611object::copy_to (object *dst)
542{ 612{
543 bool is_freed = flag [FLAG_FREED]; 613 dst->remove ();
544 bool is_removed = flag [FLAG_REMOVED];
545
546 *(object_copy *)this = src; 614 *(object_copy *)dst = *this;
547
548 flag [FLAG_FREED] = is_freed;
549 flag [FLAG_REMOVED] = is_removed; 615 dst->flag [FLAG_REMOVED] = true;
550 616
551 /* Copy over key_values, if any. */ 617 /* Copy over key_values, if any. */
552 if (src.key_values) 618 if (key_values)
553 { 619 {
554 key_value *tail = 0; 620 key_value *tail = 0;
555 key_values = 0; 621 dst->key_values = 0;
556 622
557 for (key_value *i = src.key_values; i; i = i->next) 623 for (key_value *i = key_values; i; i = i->next)
558 { 624 {
559 key_value *new_link = new key_value; 625 key_value *new_link = new key_value;
560 626
561 new_link->next = 0; 627 new_link->next = 0;
562 new_link->key = i->key; 628 new_link->key = i->key;
563 new_link->value = i->value; 629 new_link->value = i->value;
564 630
565 /* Try and be clever here, too. */ 631 /* Try and be clever here, too. */
566 if (!key_values) 632 if (!dst->key_values)
567 { 633 {
568 key_values = new_link; 634 dst->key_values = new_link;
569 tail = new_link; 635 tail = new_link;
570 } 636 }
571 else 637 else
572 { 638 {
573 tail->next = new_link; 639 tail->next = new_link;
574 tail = new_link; 640 tail = new_link;
575 } 641 }
576 } 642 }
577 } 643 }
578}
579
580/*
581 * copy_to first frees everything allocated by the dst object,
582 * and then copies the contents of itself into the second
583 * object, allocating what needs to be allocated. Basically, any
584 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
585 * if the first object is freed, the pointers in the new object
586 * will point at garbage.
587 */
588void
589object::copy_to (object *dst)
590{
591 *dst = *this;
592 644
593 if (speed < 0) 645 if (speed < 0)
594 dst->speed_left -= rndm (); 646 dst->speed_left -= rndm ();
595 647
596 dst->set_speed (dst->speed); 648 dst->set_speed (dst->speed);
618object * 670object *
619object::clone () 671object::clone ()
620{ 672{
621 object *neu = create (); 673 object *neu = create ();
622 copy_to (neu); 674 copy_to (neu);
675 neu->map = map; // not copied by copy_to
623 return neu; 676 return neu;
624} 677}
625 678
626/* 679/*
627 * If an object with the IS_TURNABLE() flag needs to be turned due 680 * If an object with the IS_TURNABLE() flag needs to be turned due
678 * UP_OBJ_FACE: only the objects face has changed. 731 * UP_OBJ_FACE: only the objects face has changed.
679 */ 732 */
680void 733void
681update_object (object *op, int action) 734update_object (object *op, int action)
682{ 735{
683 if (op == NULL) 736 if (!op)
684 { 737 {
685 /* this should never happen */ 738 /* this should never happen */
686 LOG (llevDebug, "update_object() called for NULL object.\n"); 739 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
687 return; 740 return;
688 } 741 }
689 742
690 if (op->env) 743 if (!op->is_on_map ())
691 { 744 {
692 /* Animation is currently handled by client, so nothing 745 /* Animation is currently handled by client, so nothing
693 * to do in this case. 746 * to do in this case.
694 */ 747 */
695 return; 748 return;
696 } 749 }
697
698 /* If the map is saving, don't do anything as everything is
699 * going to get freed anyways.
700 */
701 if (!op->map || op->map->in_memory == MAP_SAVING)
702 return;
703 750
704 /* make sure the object is within map boundaries */ 751 /* make sure the object is within map boundaries */
705 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 752 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
706 { 753 {
707 LOG (llevError, "update_object() called for object out of map!\n"); 754 LOG (llevError, "update_object() called for object out of map!\n");
850object::destroy_inv (bool drop_to_ground) 897object::destroy_inv (bool drop_to_ground)
851{ 898{
852 // need to check first, because the checks below might segfault 899 // need to check first, because the checks below might segfault
853 // as we might be on an invalid mapspace and crossfire code 900 // as we might be on an invalid mapspace and crossfire code
854 // is too buggy to ensure that the inventory is empty. 901 // is too buggy to ensure that the inventory is empty.
855 // corollary: if you create arrows etc. with stuff in tis inventory, 902 // corollary: if you create arrows etc. with stuff in its inventory,
856 // cf will crash below with off-map x and y 903 // cf will crash below with off-map x and y
857 if (!inv) 904 if (!inv)
858 return; 905 return;
859 906
860 /* Only if the space blocks everything do we not process - 907 /* Only if the space blocks everything do we not process -
861 * if some form of movement is allowed, let objects 908 * if some form of movement is allowed, let objects
862 * drop on that space. 909 * drop on that space.
863 */ 910 */
864 if (!drop_to_ground 911 if (!drop_to_ground
865 || !map 912 || !map
866 || map->in_memory != MAP_IN_MEMORY 913 || map->in_memory != MAP_ACTIVE
867 || map->nodrop 914 || map->no_drop
868 || ms ().move_block == MOVE_ALL) 915 || ms ().move_block == MOVE_ALL)
869 { 916 {
870 while (inv) 917 while (inv)
871 { 918 {
872 inv->destroy_inv (drop_to_ground); 919 inv->destroy_inv (false);
873 inv->destroy (); 920 inv->destroy ();
874 } 921 }
875 } 922 }
876 else 923 else
877 { /* Put objects in inventory onto this space */ 924 { /* Put objects in inventory onto this space */
883 || op->flag [FLAG_NO_DROP] 930 || op->flag [FLAG_NO_DROP]
884 || op->type == RUNE 931 || op->type == RUNE
885 || op->type == TRAP 932 || op->type == TRAP
886 || op->flag [FLAG_IS_A_TEMPLATE] 933 || op->flag [FLAG_IS_A_TEMPLATE]
887 || op->flag [FLAG_DESTROY_ON_DEATH]) 934 || op->flag [FLAG_DESTROY_ON_DEATH])
888 op->destroy (); 935 op->destroy (true);
889 else 936 else
890 map->insert (op, x, y); 937 map->insert (op, x, y);
891 } 938 }
892 } 939 }
893} 940}
897 object *op = new object; 944 object *op = new object;
898 op->link (); 945 op->link ();
899 return op; 946 return op;
900} 947}
901 948
949static struct freed_map : maptile
950{
951 freed_map ()
952 {
953 path = "<freed objects map>";
954 name = "/internal/freed_objects_map";
955 width = 3;
956 height = 3;
957 no_drop = 1;
958 no_reset = 1;
959
960 alloc ();
961 in_memory = MAP_ACTIVE;
962 }
963
964 ~freed_map ()
965 {
966 destroy ();
967 }
968} freed_map; // freed objects are moved here to avoid crashes
969
902void 970void
903object::do_destroy () 971object::do_destroy ()
904{ 972{
905 attachable::do_destroy ();
906
907 if (flag [FLAG_IS_LINKED]) 973 if (flag [FLAG_IS_LINKED])
908 remove_button_link (this); 974 remove_button_link (this);
909 975
910 if (flag [FLAG_FRIENDLY]) 976 if (flag [FLAG_FRIENDLY])
911 remove_friendly_object (this); 977 remove_friendly_object (this);
912 978
913 if (!flag [FLAG_REMOVED])
914 remove (); 979 remove ();
915 980
916 destroy_inv (true); 981 attachable::do_destroy ();
917 982
918 deactivate (); 983 deactivate ();
919 unlink (); 984 unlink ();
920 985
921 flag [FLAG_FREED] = 1; 986 flag [FLAG_FREED] = 1;
922 987
923 // hack to ensure that freed objects still have a valid map 988 // hack to ensure that freed objects still have a valid map
924 {
925 static maptile *freed_map; // freed objects are moved here to avoid crashes
926
927 if (!freed_map)
928 {
929 freed_map = new maptile;
930
931 freed_map->path = "<freed objects map>";
932 freed_map->name = "/internal/freed_objects_map";
933 freed_map->width = 3;
934 freed_map->height = 3;
935 freed_map->nodrop = 1;
936
937 freed_map->alloc ();
938 freed_map->in_memory = MAP_IN_MEMORY;
939 }
940
941 map = freed_map; 989 map = &freed_map;
942 x = 1; 990 x = 1;
943 y = 1; 991 y = 1;
944 }
945 992
946 if (more) 993 if (more)
947 { 994 {
948 more->destroy (); 995 more->destroy ();
949 more = 0; 996 more = 0;
962object::destroy (bool destroy_inventory) 1009object::destroy (bool destroy_inventory)
963{ 1010{
964 if (destroyed ()) 1011 if (destroyed ())
965 return; 1012 return;
966 1013
1014 if (!is_head () && !head->destroyed ())
1015 {
1016 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1017 head->destroy (destroy_inventory);
1018 return;
1019 }
1020
967 if (destroy_inventory) 1021 destroy_inv (!destroy_inventory);
968 destroy_inv (false);
969 1022
970 if (is_head ()) 1023 if (is_head ())
971 if (sound_destroy) 1024 if (sound_destroy)
972 play_sound (sound_destroy); 1025 play_sound (sound_destroy);
973 else if (flag [FLAG_MONSTER]) 1026 else if (flag [FLAG_MONSTER])
974 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1027 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
975 1028
976 attachable::destroy (); 1029 attachable::destroy ();
977}
978
979/*
980 * sub_weight() recursively (outwards) subtracts a number from the
981 * weight of an object (and what is carried by it's environment(s)).
982 */
983void
984sub_weight (object *op, signed long weight)
985{
986 while (op != NULL)
987 {
988 if (op->type == CONTAINER)
989 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
990
991 op->carrying -= weight;
992 op = op->env;
993 }
994} 1030}
995 1031
996/* op->remove (): 1032/* op->remove ():
997 * This function removes the object op from the linked list of objects 1033 * This function removes the object op from the linked list of objects
998 * which it is currently tied to. When this function is done, the 1034 * which it is currently tied to. When this function is done, the
1004object::do_remove () 1040object::do_remove ()
1005{ 1041{
1006 object *tmp, *last = 0; 1042 object *tmp, *last = 0;
1007 object *otmp; 1043 object *otmp;
1008 1044
1009 if (QUERY_FLAG (this, FLAG_REMOVED)) 1045 if (flag [FLAG_REMOVED])
1010 return; 1046 return;
1011 1047
1012 SET_FLAG (this, FLAG_REMOVED);
1013 INVOKE_OBJECT (REMOVE, this); 1048 INVOKE_OBJECT (REMOVE, this);
1049
1050 flag [FLAG_REMOVED] = true;
1014 1051
1015 if (more) 1052 if (more)
1016 more->remove (); 1053 more->remove ();
1017 1054
1018 /* 1055 /*
1019 * In this case, the object to be removed is in someones 1056 * In this case, the object to be removed is in someones
1020 * inventory. 1057 * inventory.
1021 */ 1058 */
1022 if (env) 1059 if (env)
1023 { 1060 {
1024 if (nrof) 1061 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1025 sub_weight (env, weight * nrof); 1062 if (object *pl = visible_to ())
1026 else 1063 esrv_del_item (pl->contr, count);
1027 sub_weight (env, weight + carrying); 1064 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1065
1066 adjust_weight (env, -total_weight ());
1067
1068 /* we set up values so that it could be inserted into
1069 * the map, but we don't actually do that - it is up
1070 * to the caller to decide what we want to do.
1071 */
1072 map = env->map;
1073 x = env->x;
1074 y = env->y;
1075
1076 // make sure cmov optimisation is applicable
1077 *(above ? &above->below : &env->inv) = below;
1078 *(below ? &below->above : &above ) = above; // &above is just a dummy
1079
1080 above = 0;
1081 below = 0;
1082 env = 0;
1028 1083
1029 /* NO_FIX_PLAYER is set when a great many changes are being 1084 /* NO_FIX_PLAYER is set when a great many changes are being
1030 * made to players inventory. If set, avoiding the call 1085 * made to players inventory. If set, avoiding the call
1031 * to save cpu time. 1086 * to save cpu time.
1032 */ 1087 */
1033 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1088 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1034 otmp->update_stats (); 1089 otmp->update_stats ();
1035
1036 if (above)
1037 above->below = below;
1038 else
1039 env->inv = below;
1040
1041 if (below)
1042 below->above = above;
1043
1044 /* we set up values so that it could be inserted into
1045 * the map, but we don't actually do that - it is up
1046 * to the caller to decide what we want to do.
1047 */
1048 x = env->x, y = env->y;
1049 map = env->map;
1050 above = 0, below = 0;
1051 env = 0;
1052 } 1090 }
1053 else if (map) 1091 else if (map)
1054 { 1092 {
1055 if (type == PLAYER)
1056 {
1057 // leaving a spot always closes any open container on the ground
1058 if (container && !container->env)
1059 // this causes spurious floorbox updates, but it ensures
1060 // that the CLOSE event is being sent.
1061 close_container ();
1062
1063 --map->players;
1064 map->touch ();
1065 }
1066
1067 map->dirty = true; 1093 map->dirty = true;
1068 mapspace &ms = this->ms (); 1094 mapspace &ms = this->ms ();
1069 1095
1096 if (object *pl = ms.player ())
1097 {
1098 if (type == PLAYER) // this == pl(!)
1099 {
1100 // leaving a spot always closes any open container on the ground
1101 if (container && !container->env)
1102 // this causes spurious floorbox updates, but it ensures
1103 // that the CLOSE event is being sent.
1104 close_container ();
1105
1106 --map->players;
1107 map->touch ();
1108 }
1109 else if (pl->container == this)
1110 {
1111 // removing a container should close it
1112 close_container ();
1113 }
1114
1115 esrv_del_item (pl->contr, count);
1116 }
1117
1070 /* link the object above us */ 1118 /* link the object above us */
1071 if (above) 1119 // re-link, make sure compiler can easily use cmove
1072 above->below = below; 1120 *(above ? &above->below : &ms.top) = below;
1073 else 1121 *(below ? &below->above : &ms.bot) = above;
1074 ms.top = below; /* we were top, set new top */
1075
1076 /* Relink the object below us, if there is one */
1077 if (below)
1078 below->above = above;
1079 else
1080 {
1081 /* Nothing below, which means we need to relink map object for this space
1082 * use translated coordinates in case some oddness with map tiling is
1083 * evident
1084 */
1085 if (GET_MAP_OB (map, x, y) != this)
1086 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1087
1088 ms.bot = above; /* goes on above it. */
1089 }
1090 1122
1091 above = 0; 1123 above = 0;
1092 below = 0; 1124 below = 0;
1093 1125
1094 if (map->in_memory == MAP_SAVING) 1126 if (map->in_memory == MAP_SAVING)
1103 * removed (most likely destroyed), update the player view 1135 * removed (most likely destroyed), update the player view
1104 * appropriately. 1136 * appropriately.
1105 */ 1137 */
1106 pl->close_container (); 1138 pl->close_container ();
1107 1139
1140 //TODO: the floorbox prev/next might need updating
1141 //esrv_del_item (pl->contr, count);
1142 //TODO: update floorbox to preserve ordering
1143 if (pl->contr->ns)
1108 pl->contr->ns->floorbox_update (); 1144 pl->contr->ns->floorbox_update ();
1109 } 1145 }
1110 1146
1111 for (tmp = ms.bot; tmp; tmp = tmp->above) 1147 for (tmp = ms.bot; tmp; tmp = tmp->above)
1112 { 1148 {
1113 /* No point updating the players look faces if he is the object 1149 /* No point updating the players look faces if he is the object
1157 if (!top) 1193 if (!top)
1158 for (top = op; top && top->above; top = top->above) 1194 for (top = op; top && top->above; top = top->above)
1159 ; 1195 ;
1160 1196
1161 for (; top; top = top->below) 1197 for (; top; top = top->below)
1162 {
1163 if (top == op)
1164 continue;
1165
1166 if (object::can_merge (op, top)) 1198 if (object::can_merge (op, top))
1167 { 1199 {
1168 top->nrof += op->nrof; 1200 top->nrof += op->nrof;
1169 1201
1170/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1202 if (object *pl = top->visible_to ())
1171 op->weight = 0; /* Don't want any adjustements now */ 1203 esrv_update_item (UPD_NROF, pl, top);
1204
1205 op->weight = 0; // cancel the addition above
1206 op->carrying = 0; // must be 0 already
1207
1172 op->destroy (); 1208 op->destroy (1);
1209
1173 return top; 1210 return top;
1174 } 1211 }
1175 }
1176 1212
1177 return 0; 1213 return 0;
1178} 1214}
1179 1215
1180void 1216void
1205 * job preparing multi-part monsters. 1241 * job preparing multi-part monsters.
1206 */ 1242 */
1207object * 1243object *
1208insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1244insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1209{ 1245{
1246 op->remove ();
1247
1210 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1248 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1211 { 1249 {
1212 tmp->x = x + tmp->arch->x; 1250 tmp->x = x + tmp->arch->x;
1213 tmp->y = y + tmp->arch->y; 1251 tmp->y = y + tmp->arch->y;
1214 } 1252 }
1237 * just 'op' otherwise 1275 * just 'op' otherwise
1238 */ 1276 */
1239object * 1277object *
1240insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1278insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1241{ 1279{
1242 assert (!op->flag [FLAG_FREED]); 1280 if (op->is_on_map ())
1281 {
1282 LOG (llevError, "insert_ob_in_map called for object already on map");
1283 abort ();
1284 }
1243 1285
1244 object *top, *floor = NULL; 1286 if (op->env)
1245 1287 {
1288 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1246 op->remove (); 1289 op->remove ();
1290 }
1291
1292 if (op->face && !face_info (op->face))//D TODO: remove soon
1293 {//D
1294 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
1295 op->face = 1;//D
1296 }//D
1247 1297
1248 /* Ideally, the caller figures this out. However, it complicates a lot 1298 /* Ideally, the caller figures this out. However, it complicates a lot
1249 * of areas of callers (eg, anything that uses find_free_spot would now 1299 * of areas of callers (eg, anything that uses find_free_spot would now
1250 * need extra work 1300 * need extra work
1251 */ 1301 */
1252 if (!xy_normalise (m, op->x, op->y)) 1302 if (!xy_normalise (m, op->x, op->y))
1253 { 1303 {
1254 op->destroy (); 1304 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1255 return 0; 1305 return 0;
1256 } 1306 }
1257 1307
1258 if (object *more = op->more) 1308 if (object *more = op->more)
1259 if (!insert_ob_in_map (more, m, originator, flag)) 1309 if (!insert_ob_in_map (more, m, originator, flag))
1268 */ 1318 */
1269 if (op->nrof && !(flag & INS_NO_MERGE)) 1319 if (op->nrof && !(flag & INS_NO_MERGE))
1270 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1320 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1271 if (object::can_merge (op, tmp)) 1321 if (object::can_merge (op, tmp))
1272 { 1322 {
1323 // TODO: we actually want to update tmp, not op,
1324 // but some caller surely breaks when we return tmp
1325 // from here :/
1273 op->nrof += tmp->nrof; 1326 op->nrof += tmp->nrof;
1274 tmp->destroy (); 1327 tmp->destroy (1);
1275 } 1328 }
1276 1329
1277 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1330 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1278 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1331 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1279 1332
1286 { 1339 {
1287 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1340 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1288 abort (); 1341 abort ();
1289 } 1342 }
1290 1343
1344 if (!originator->is_on_map ())
1345 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1346 op->debug_desc (), originator->debug_desc ());
1347
1291 op->above = originator; 1348 op->above = originator;
1292 op->below = originator->below; 1349 op->below = originator->below;
1293
1294 if (op->below)
1295 op->below->above = op;
1296 else
1297 ms.bot = op;
1298
1299 /* since *below* originator, no need to update top */
1300 originator->below = op; 1350 originator->below = op;
1351
1352 *(op->below ? &op->below->above : &ms.bot) = op;
1301 } 1353 }
1302 else 1354 else
1303 { 1355 {
1304 top = ms.bot; 1356 object *floor = 0;
1357 object *top = ms.top;
1305 1358
1306 /* If there are other objects, then */ 1359 /* If there are other objects, then */
1307 if (top) 1360 if (top)
1308 { 1361 {
1309 object *last = 0;
1310
1311 /* 1362 /*
1312 * If there are multiple objects on this space, we do some trickier handling. 1363 * If there are multiple objects on this space, we do some trickier handling.
1313 * We've already dealt with merging if appropriate. 1364 * We've already dealt with merging if appropriate.
1314 * Generally, we want to put the new object on top. But if 1365 * Generally, we want to put the new object on top. But if
1315 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1366 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1318 * once we get to them. This reduces the need to traverse over all of 1369 * once we get to them. This reduces the need to traverse over all of
1319 * them when adding another one - this saves quite a bit of cpu time 1370 * them when adding another one - this saves quite a bit of cpu time
1320 * when lots of spells are cast in one area. Currently, it is presumed 1371 * when lots of spells are cast in one area. Currently, it is presumed
1321 * that flying non pickable objects are spell objects. 1372 * that flying non pickable objects are spell objects.
1322 */ 1373 */
1323 for (top = ms.bot; top; top = top->above) 1374 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1324 { 1375 {
1325 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1376 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1326 floor = top; 1377 floor = tmp;
1327 1378
1328 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1379 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1329 { 1380 {
1330 /* We insert above top, so we want this object below this */ 1381 /* We insert above top, so we want this object below this */
1331 top = top->below; 1382 top = tmp->below;
1332 break; 1383 break;
1333 } 1384 }
1334 1385
1335 last = top; 1386 top = tmp;
1336 } 1387 }
1337
1338 /* Don't want top to be NULL, so set it to the last valid object */
1339 top = last;
1340 1388
1341 /* We let update_position deal with figuring out what the space 1389 /* We let update_position deal with figuring out what the space
1342 * looks like instead of lots of conditions here. 1390 * looks like instead of lots of conditions here.
1343 * makes things faster, and effectively the same result. 1391 * makes things faster, and effectively the same result.
1344 */ 1392 */
1351 */ 1399 */
1352 if (!(flag & INS_ON_TOP) 1400 if (!(flag & INS_ON_TOP)
1353 && ms.flags () & P_BLOCKSVIEW 1401 && ms.flags () & P_BLOCKSVIEW
1354 && (op->face && !faces [op->face].visibility)) 1402 && (op->face && !faces [op->face].visibility))
1355 { 1403 {
1404 object *last;
1405
1356 for (last = top; last != floor; last = last->below) 1406 for (last = top; last != floor; last = last->below)
1357 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1407 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1358 break; 1408 break;
1359 1409
1360 /* Check to see if we found the object that blocks view, 1410 /* Check to see if we found the object that blocks view,
1368 } /* If objects on this space */ 1418 } /* If objects on this space */
1369 1419
1370 if (flag & INS_ABOVE_FLOOR_ONLY) 1420 if (flag & INS_ABOVE_FLOOR_ONLY)
1371 top = floor; 1421 top = floor;
1372 1422
1373 /* Top is the object that our object (op) is going to get inserted above. 1423 // insert object above top, or bottom-most if top = 0
1374 */
1375
1376 /* First object on this space */
1377 if (!top) 1424 if (!top)
1378 { 1425 {
1426 op->below = 0;
1379 op->above = ms.bot; 1427 op->above = ms.bot;
1380
1381 if (op->above)
1382 op->above->below = op;
1383
1384 op->below = 0;
1385 ms.bot = op; 1428 ms.bot = op;
1429
1430 *(op->above ? &op->above->below : &ms.top) = op;
1386 } 1431 }
1387 else 1432 else
1388 { /* get inserted into the stack above top */ 1433 {
1389 op->above = top->above; 1434 op->above = top->above;
1390
1391 if (op->above)
1392 op->above->below = op; 1435 top->above = op;
1393 1436
1394 op->below = top; 1437 op->below = top;
1395 top->above = op; 1438 *(op->above ? &op->above->below : &ms.top) = op;
1396 } 1439 }
1397 1440 }
1398 if (!op->above)
1399 ms.top = op;
1400 } /* else not INS_BELOW_ORIGINATOR */
1401 1441
1402 if (op->type == PLAYER) 1442 if (op->type == PLAYER)
1403 { 1443 {
1404 op->contr->do_los = 1; 1444 op->contr->do_los = 1;
1405 ++op->map->players; 1445 ++op->map->players;
1407 } 1447 }
1408 1448
1409 op->map->dirty = true; 1449 op->map->dirty = true;
1410 1450
1411 if (object *pl = ms.player ()) 1451 if (object *pl = ms.player ())
1452 //TODO: the floorbox prev/next might need updating
1453 //esrv_send_item (pl, op);
1454 //TODO: update floorbox to preserve ordering
1455 if (pl->contr->ns)
1412 pl->contr->ns->floorbox_update (); 1456 pl->contr->ns->floorbox_update ();
1413 1457
1414 /* If this object glows, it may affect lighting conditions that are 1458 /* If this object glows, it may affect lighting conditions that are
1415 * visible to others on this map. But update_all_los is really 1459 * visible to others on this map. But update_all_los is really
1416 * an inefficient way to do this, as it means los for all players 1460 * an inefficient way to do this, as it means los for all players
1417 * on the map will get recalculated. The players could very well 1461 * on the map will get recalculated. The players could very well
1459 * op is the object to insert it under: supplies x and the map. 1503 * op is the object to insert it under: supplies x and the map.
1460 */ 1504 */
1461void 1505void
1462replace_insert_ob_in_map (const char *arch_string, object *op) 1506replace_insert_ob_in_map (const char *arch_string, object *op)
1463{ 1507{
1464 object *tmp, *tmp1;
1465
1466 /* first search for itself and remove any old instances */ 1508 /* first search for itself and remove any old instances */
1467 1509
1468 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1510 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1469 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1511 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1470 tmp->destroy (); 1512 tmp->destroy (1);
1471 1513
1472 tmp1 = arch_to_object (archetype::find (arch_string)); 1514 object *tmp = arch_to_object (archetype::find (arch_string));
1473 1515
1474 tmp1->x = op->x; 1516 tmp->x = op->x;
1475 tmp1->y = op->y; 1517 tmp->y = op->y;
1518
1476 insert_ob_in_map (tmp1, op->map, op, 0); 1519 insert_ob_in_map (tmp, op->map, op, 0);
1477} 1520}
1478 1521
1479object * 1522object *
1480object::insert_at (object *where, object *originator, int flags) 1523object::insert_at (object *where, object *originator, int flags)
1481{ 1524{
1525 if (where->env)
1526 return where->env->insert (this);
1527 else
1482 return where->map->insert (this, where->x, where->y, originator, flags); 1528 return where->map->insert (this, where->x, where->y, originator, flags);
1483} 1529}
1484 1530
1485/* 1531/*
1486 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1487 * is returned contains nr objects, and the remaining parts contains
1488 * the rest (or is removed and freed if that number is 0).
1489 * On failure, NULL is returned, and the reason put into the
1490 * global static errmsg array.
1491 */
1492object *
1493get_split_ob (object *orig_ob, uint32 nr)
1494{
1495 object *newob;
1496 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1497
1498 if (orig_ob->nrof < nr)
1499 {
1500 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1501 return NULL;
1502 }
1503
1504 newob = object_create_clone (orig_ob);
1505
1506 if ((orig_ob->nrof -= nr) < 1)
1507 orig_ob->destroy (1);
1508 else if (!is_removed)
1509 {
1510 if (orig_ob->env != NULL)
1511 sub_weight (orig_ob->env, orig_ob->weight * nr);
1512 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1513 {
1514 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1515 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1516 return NULL;
1517 }
1518 }
1519
1520 newob->nrof = nr;
1521
1522 return newob;
1523}
1524
1525/*
1526 * decrease_ob_nr(object, number) decreases a specified number from 1532 * decrease(object, number) decreases a specified number from
1527 * the amount of an object. If the amount reaches 0, the object 1533 * the amount of an object. If the amount reaches 0, the object
1528 * is subsequently removed and freed. 1534 * is subsequently removed and freed.
1529 * 1535 *
1530 * Return value: 'op' if something is left, NULL if the amount reached 0 1536 * Return value: 'op' if something is left, NULL if the amount reached 0
1531 */ 1537 */
1538bool
1539object::decrease (sint32 nr)
1540{
1541 if (!nr)
1542 return true;
1543
1544 nr = min (nr, nrof);
1545
1546 nrof -= nr;
1547
1548 if (nrof)
1549 {
1550 adjust_weight (env, -weight * nr); // carrying == 0
1551
1552 if (object *pl = visible_to ())
1553 esrv_update_item (UPD_NROF, pl, this);
1554
1555 return true;
1556 }
1557 else
1558 {
1559 destroy (1);
1560 return false;
1561 }
1562}
1563
1564/*
1565 * split(ob,nr) splits up ob into two parts. The part which
1566 * is returned contains nr objects, and the remaining parts contains
1567 * the rest (or is removed and returned if that number is 0).
1568 * On failure, NULL is returned.
1569 */
1532object * 1570object *
1533decrease_ob_nr (object *op, uint32 i) 1571object::split (sint32 nr)
1534{ 1572{
1535 object *tmp; 1573 int have = number_of ();
1536 1574
1537 if (i == 0) /* objects with op->nrof require this check */ 1575 if (have < nr)
1538 return op; 1576 return 0;
1539 1577 else if (have == nr)
1540 if (i > op->nrof)
1541 i = op->nrof;
1542
1543 if (QUERY_FLAG (op, FLAG_REMOVED))
1544 op->nrof -= i;
1545 else if (op->env)
1546 { 1578 {
1547 /* is this object in the players inventory, or sub container
1548 * therein?
1549 */
1550 tmp = op->in_player ();
1551 /* nope. Is this a container the player has opened?
1552 * If so, set tmp to that player.
1553 * IMO, searching through all the players will mostly
1554 * likely be quicker than following op->env to the map,
1555 * and then searching the map for a player.
1556 */
1557 if (!tmp)
1558 for_all_players (pl)
1559 if (pl->ob->container == op->env)
1560 {
1561 tmp = pl->ob;
1562 break;
1563 }
1564
1565 if (i < op->nrof)
1566 {
1567 sub_weight (op->env, op->weight * i);
1568 op->nrof -= i;
1569 if (tmp)
1570 esrv_send_item (tmp, op);
1571 }
1572 else
1573 {
1574 op->remove (); 1579 remove ();
1575 op->nrof = 0; 1580 return this;
1576 if (tmp)
1577 esrv_del_item (tmp->contr, op->count);
1578 }
1579 } 1581 }
1580 else 1582 else
1581 { 1583 {
1582 object *above = op->above; 1584 decrease (nr);
1583 1585
1584 if (i < op->nrof) 1586 object *op = deep_clone ();
1585 op->nrof -= i; 1587 op->nrof = nr;
1586 else
1587 {
1588 op->remove ();
1589 op->nrof = 0;
1590 }
1591
1592 /* Since we just removed op, op->above is null */
1593 for (tmp = above; tmp; tmp = tmp->above)
1594 if (tmp->type == PLAYER)
1595 {
1596 if (op->nrof)
1597 esrv_send_item (tmp, op);
1598 else
1599 esrv_del_item (tmp->contr, op->count);
1600 }
1601 }
1602
1603 if (op->nrof)
1604 return op; 1588 return op;
1605 else
1606 {
1607 op->destroy ();
1608 return 0;
1609 }
1610}
1611
1612/*
1613 * add_weight(object, weight) adds the specified weight to an object,
1614 * and also updates how much the environment(s) is/are carrying.
1615 */
1616void
1617add_weight (object *op, signed long weight)
1618{
1619 while (op != NULL)
1620 {
1621 if (op->type == CONTAINER)
1622 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1623
1624 op->carrying += weight;
1625 op = op->env;
1626 } 1589 }
1627} 1590}
1628 1591
1629object * 1592object *
1630insert_ob_in_ob (object *op, object *where) 1593insert_ob_in_ob (object *op, object *where)
1655 * be != op, if items are merged. -Tero 1618 * be != op, if items are merged. -Tero
1656 */ 1619 */
1657object * 1620object *
1658object::insert (object *op) 1621object::insert (object *op)
1659{ 1622{
1660 if (!QUERY_FLAG (op, FLAG_REMOVED))
1661 op->remove ();
1662
1663 if (op->more) 1623 if (op->more)
1664 { 1624 {
1665 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1625 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1666 return op; 1626 return op;
1667 } 1627 }
1668 1628
1669 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1629 op->remove ();
1670 CLEAR_FLAG (op, FLAG_REMOVED); 1630
1631 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1671 1632
1672 if (op->nrof) 1633 if (op->nrof)
1673 {
1674 for (object *tmp = inv; tmp; tmp = tmp->below) 1634 for (object *tmp = inv; tmp; tmp = tmp->below)
1675 if (object::can_merge (tmp, op)) 1635 if (object::can_merge (tmp, op))
1676 { 1636 {
1677 /* return the original object and remove inserted object 1637 /* return the original object and remove inserted object
1678 (client needs the original object) */ 1638 (client needs the original object) */
1679 tmp->nrof += op->nrof; 1639 tmp->nrof += op->nrof;
1680 /* Weight handling gets pretty funky. Since we are adding to 1640
1681 * tmp->nrof, we need to increase the weight. 1641 if (object *pl = tmp->visible_to ())
1682 */ 1642 esrv_update_item (UPD_NROF, pl, tmp);
1643
1683 add_weight (this, op->weight * op->nrof); 1644 adjust_weight (this, op->total_weight ());
1684 SET_FLAG (op, FLAG_REMOVED); 1645
1685 op->destroy (); /* free the inserted object */ 1646 op->destroy (1);
1686 op = tmp; 1647 op = tmp;
1687 op->remove (); /* and fix old object's links */ 1648 goto inserted;
1688 CLEAR_FLAG (op, FLAG_REMOVED);
1689 break;
1690 } 1649 }
1691 1650
1692 /* I assume combined objects have no inventory
1693 * We add the weight - this object could have just been removed
1694 * (if it was possible to merge). calling remove_ob will subtract
1695 * the weight, so we need to add it in again, since we actually do
1696 * the linking below
1697 */
1698 add_weight (this, op->weight * op->nrof);
1699 }
1700 else
1701 add_weight (this, (op->weight + op->carrying));
1702
1703 if (object *otmp = this->in_player ())
1704 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1705 otmp->update_stats ();
1706
1707 op->owner = 0; // its his/hers now. period. 1651 op->owner = 0; // it's his/hers now. period.
1708 op->map = 0; 1652 op->map = 0;
1653 op->x = 0;
1654 op->y = 0;
1655
1656 op->above = 0;
1657 op->below = inv;
1709 op->env = this; 1658 op->env = this;
1710 op->above = 0;
1711 op->below = 0;
1712 op->x = op->y = 0;
1713 1659
1660 if (inv)
1661 inv->above = op;
1662
1663 inv = op;
1664
1665 op->flag [FLAG_REMOVED] = 0;
1666
1667 if (object *pl = op->visible_to ())
1668 esrv_send_item (pl, op);
1669
1670 adjust_weight (this, op->total_weight ());
1671
1672inserted:
1714 /* reset the light list and los of the players on the map */ 1673 /* reset the light list and los of the players on the map */
1715 if (op->glow_radius && map) 1674 if (op->glow_radius && map && map->darkness)
1716 {
1717#ifdef DEBUG_LIGHTS
1718 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1719#endif /* DEBUG_LIGHTS */
1720 if (map->darkness)
1721 update_all_los (map, x, y); 1675 update_all_los (map, x, y);
1722 }
1723 1676
1724 /* Client has no idea of ordering so lets not bother ordering it here. 1677 // if this is a player's inventory, update stats
1725 * It sure simplifies this function... 1678 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1726 */ 1679 update_stats ();
1727 if (!inv)
1728 inv = op;
1729 else
1730 {
1731 op->below = inv;
1732 op->below->above = op;
1733 inv = op;
1734 }
1735 1680
1736 INVOKE_OBJECT (INSERT, this); 1681 INVOKE_OBJECT (INSERT, this);
1737 1682
1738 return op; 1683 return op;
1739} 1684}
1867 LOG (llevError, "Present_arch called outside map.\n"); 1812 LOG (llevError, "Present_arch called outside map.\n");
1868 return NULL; 1813 return NULL;
1869 } 1814 }
1870 1815
1871 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1816 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1872 if (tmp->arch == at) 1817 if (tmp->arch->archname == at->archname)
1873 return tmp; 1818 return tmp;
1874 1819
1875 return NULL; 1820 return NULL;
1876} 1821}
1877 1822
1941 * The first matching object is returned, or NULL if none. 1886 * The first matching object is returned, or NULL if none.
1942 */ 1887 */
1943object * 1888object *
1944present_arch_in_ob (const archetype *at, const object *op) 1889present_arch_in_ob (const archetype *at, const object *op)
1945{ 1890{
1946 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1947 if (tmp->arch == at) 1892 if (tmp->arch->archname == at->archname)
1948 return tmp; 1893 return tmp;
1949 1894
1950 return NULL; 1895 return NULL;
1951} 1896}
1952 1897
2361 2306
2362/* 2307/*
2363 * create clone from object to another 2308 * create clone from object to another
2364 */ 2309 */
2365object * 2310object *
2366object_create_clone (object *asrc) 2311object::deep_clone ()
2367{ 2312{
2368 object *dst = 0, *tmp, *src, *prev, *item; 2313 assert (("deep_clone called on non-head object", is_head ()));
2369 2314
2370 if (!asrc) 2315 object *dst = clone ();
2371 return 0;
2372 2316
2373 src = asrc->head_ (); 2317 object *prev = dst;
2374
2375 prev = 0;
2376 for (object *part = src; part; part = part->more) 2318 for (object *part = this->more; part; part = part->more)
2377 { 2319 {
2378 tmp = part->clone (); 2320 object *tmp = part->clone ();
2379 tmp->x -= src->x;
2380 tmp->y -= src->y;
2381
2382 if (!part->head)
2383 {
2384 dst = tmp;
2385 tmp->head = 0;
2386 }
2387 else
2388 tmp->head = dst; 2321 tmp->head = dst;
2389
2390 tmp->more = 0;
2391
2392 if (prev)
2393 prev->more = tmp; 2322 prev->more = tmp;
2394
2395 prev = tmp; 2323 prev = tmp;
2396 } 2324 }
2397 2325
2398 for (item = src->inv; item; item = item->below) 2326 for (object *item = inv; item; item = item->below)
2399 insert_ob_in_ob (object_create_clone (item), dst); 2327 insert_ob_in_ob (item->deep_clone (), dst);
2400 2328
2401 return dst; 2329 return dst;
2402} 2330}
2403 2331
2404/* This returns the first object in who's inventory that 2332/* This returns the first object in who's inventory that
2413 return tmp; 2341 return tmp;
2414 2342
2415 return 0; 2343 return 0;
2416} 2344}
2417 2345
2418/* If ob has a field named key, return the link from the list, 2346const shstr &
2419 * otherwise return NULL. 2347object::kv_get (const shstr &key) const
2420 *
2421 * key must be a passed in shared string - otherwise, this won't
2422 * do the desired thing.
2423 */
2424key_value *
2425get_ob_key_link (const object *ob, const char *key)
2426{ 2348{
2427 for (key_value *link = ob->key_values; link; link = link->next) 2349 for (key_value *kv = key_values; kv; kv = kv->next)
2428 if (link->key == key) 2350 if (kv->key == key)
2429 return link;
2430
2431 return 0;
2432}
2433
2434/*
2435 * Returns the value of op has an extra_field for key, or NULL.
2436 *
2437 * The argument doesn't need to be a shared string.
2438 *
2439 * The returned string is shared.
2440 */
2441const char *
2442get_ob_key_value (const object *op, const char *const key)
2443{
2444 key_value *link;
2445 shstr_cmp canonical_key (key);
2446
2447 if (!canonical_key)
2448 {
2449 /* 1. There being a field named key on any object
2450 * implies there'd be a shared string to find.
2451 * 2. Since there isn't, no object has this field.
2452 * 3. Therefore, *this* object doesn't have this field.
2453 */
2454 return 0;
2455 }
2456
2457 /* This is copied from get_ob_key_link() above -
2458 * only 4 lines, and saves the function call overhead.
2459 */
2460 for (link = op->key_values; link; link = link->next)
2461 if (link->key == canonical_key)
2462 return link->value; 2351 return kv->value;
2463 2352
2464 return 0; 2353 return shstr_null;
2465} 2354}
2466 2355
2467/* 2356void
2468 * Updates the canonical_key in op to value. 2357object::kv_set (const shstr &key, const shstr &value)
2469 *
2470 * canonical_key is a shared string (value doesn't have to be).
2471 *
2472 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2473 * keys.
2474 *
2475 * Returns TRUE on success.
2476 */
2477int
2478set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2479{ 2358{
2480 key_value *field = NULL, *last = NULL; 2359 for (key_value *kv = key_values; kv; kv = kv->next)
2481 2360 if (kv->key == key)
2482 for (field = op->key_values; field != NULL; field = field->next)
2483 {
2484 if (field->key != canonical_key)
2485 { 2361 {
2486 last = field; 2362 kv->value = value;
2487 continue; 2363 return;
2488 } 2364 }
2489 2365
2490 if (value) 2366 key_value *kv = new key_value;
2491 field->value = value; 2367
2492 else 2368 kv->next = key_values;
2369 kv->key = key;
2370 kv->value = value;
2371
2372 key_values = kv;
2373}
2374
2375void
2376object::kv_del (const shstr &key)
2377{
2378 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2379 if ((*kvp)->key == key)
2493 { 2380 {
2494 /* Basically, if the archetype has this key set, 2381 key_value *kv = *kvp;
2495 * we need to store the null value so when we save 2382 *kvp = (*kvp)->next;
2496 * it, we save the empty value so that when we load, 2383 delete kv;
2497 * we get this value back again. 2384 return;
2498 */
2499 if (get_ob_key_link (op->arch, canonical_key))
2500 field->value = 0;
2501 else
2502 {
2503 if (last)
2504 last->next = field->next;
2505 else
2506 op->key_values = field->next;
2507
2508 delete field;
2509 }
2510 } 2385 }
2511 return TRUE;
2512 }
2513 /* IF we get here, key doesn't exist */
2514
2515 /* No field, we'll have to add it. */
2516
2517 if (!add_key)
2518 return FALSE;
2519
2520 /* There isn't any good reason to store a null
2521 * value in the key/value list. If the archetype has
2522 * this key, then we should also have it, so shouldn't
2523 * be here. If user wants to store empty strings,
2524 * should pass in ""
2525 */
2526 if (value == NULL)
2527 return TRUE;
2528
2529 field = new key_value;
2530
2531 field->key = canonical_key;
2532 field->value = value;
2533 /* Usual prepend-addition. */
2534 field->next = op->key_values;
2535 op->key_values = field;
2536
2537 return TRUE;
2538}
2539
2540/*
2541 * Updates the key in op to value.
2542 *
2543 * If add_key is FALSE, this will only update existing keys,
2544 * and not add new ones.
2545 * In general, should be little reason FALSE is ever passed in for add_key
2546 *
2547 * Returns TRUE on success.
2548 */
2549int
2550set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2551{
2552 shstr key_ (key);
2553
2554 return set_ob_key_value_s (op, key_, value, add_key);
2555} 2386}
2556 2387
2557object::depth_iterator::depth_iterator (object *container) 2388object::depth_iterator::depth_iterator (object *container)
2558: iterator_base (container) 2389: iterator_base (container)
2559{ 2390{
2609{ 2440{
2610 char flagdesc[512]; 2441 char flagdesc[512];
2611 char info2[256 * 4]; 2442 char info2[256 * 4];
2612 char *p = info; 2443 char *p = info;
2613 2444
2614 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2445 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2615 count, 2446 count,
2616 uuid.c_str (), 2447 uuid.c_str (),
2617 &name, 2448 &name,
2618 title ? "\",title:\"" : "", 2449 title ? ",title:\"" : "",
2619 title ? (const char *)title : "", 2450 title ? (const char *)title : "",
2451 title ? "\"" : "",
2620 flag_desc (flagdesc, 512), type); 2452 flag_desc (flagdesc, 512), type);
2621 2453
2622 if (!this->flag[FLAG_REMOVED] && env) 2454 if (!flag[FLAG_REMOVED] && env)
2623 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2455 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2624 2456
2625 if (map) 2457 if (map)
2626 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2458 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2627 2459
2657object::open_container (object *new_container) 2489object::open_container (object *new_container)
2658{ 2490{
2659 if (container == new_container) 2491 if (container == new_container)
2660 return; 2492 return;
2661 2493
2662 if (object *old_container = container) 2494 object *old_container = container;
2495
2496 if (old_container)
2663 { 2497 {
2664 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2498 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2665 return; 2499 return;
2666 2500
2667#if 0 2501#if 0
2669 if (object *closer = old_container->inv) 2503 if (object *closer = old_container->inv)
2670 if (closer->type == CLOSE_CON) 2504 if (closer->type == CLOSE_CON)
2671 closer->destroy (); 2505 closer->destroy ();
2672#endif 2506#endif
2673 2507
2508 // make sure the container is available
2509 esrv_send_item (this, old_container);
2510
2674 old_container->flag [FLAG_APPLIED] = 0; 2511 old_container->flag [FLAG_APPLIED] = false;
2675 container = 0; 2512 container = 0;
2676 2513
2514 // client needs item update to make it work, client bug requires this to be separate
2677 esrv_update_item (UPD_FLAGS, this, old_container); 2515 esrv_update_item (UPD_FLAGS, this, old_container);
2516
2678 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2517 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2679 play_sound (sound_find ("chest_close")); 2518 play_sound (sound_find ("chest_close"));
2680 } 2519 }
2681 2520
2682 if (new_container) 2521 if (new_container)
2695 } 2534 }
2696#endif 2535#endif
2697 2536
2698 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2537 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2699 2538
2539 // make sure the container is available, client bug requires this to be separate
2540 esrv_send_item (this, new_container);
2541
2700 new_container->flag [FLAG_APPLIED] = 1; 2542 new_container->flag [FLAG_APPLIED] = true;
2701 container = new_container; 2543 container = new_container;
2702 2544
2545 // client needs flag change
2703 esrv_update_item (UPD_FLAGS, this, new_container); 2546 esrv_update_item (UPD_FLAGS, this, new_container);
2704 esrv_send_inventory (this, new_container); 2547 esrv_send_inventory (this, new_container);
2705 play_sound (sound_find ("chest_open")); 2548 play_sound (sound_find ("chest_open"));
2706 } 2549 }
2550// else if (!old_container->env && contr && contr->ns)
2551// contr->ns->floorbox_reset ();
2707} 2552}
2708 2553
2709object * 2554object *
2710object::force_find (const shstr name) 2555object::force_find (const shstr name)
2711{ 2556{
2737 2582
2738 insert (force); 2583 insert (force);
2739} 2584}
2740 2585
2741void 2586void
2742object::play_sound (faceidx sound) const 2587object::play_sound (faceidx sound)
2743{ 2588{
2744 if (!sound) 2589 if (!sound)
2745 return; 2590 return;
2746 2591
2747 if (flag [FLAG_REMOVED]) 2592 if (flag [FLAG_REMOVED])

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines