ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.202 by root, Thu Apr 10 15:35:15 2008 UTC vs.
Revision 1.247 by root, Mon Jul 14 18:36:43 2008 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save;
39static const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
40 37
41objectvec objects; 38objectvec objects;
42activevec actives; 39activevec actives;
43 40
44short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 41short freearr_x[SIZEOFFREE] = {
42 0,
43 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
45 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 45 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
46}; 46};
47short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 47short freearr_y[SIZEOFFREE] = {
48 0,
49 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
48 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
49}; 52};
50int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
51 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
52}; 58};
53int freedir[SIZEOFFREE] = { 59int freedir[SIZEOFFREE] = {
54 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 0,
61 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
55 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
56}; 64};
57 65
58static void 66static void
59write_uuid (void) 67write_uuid (uval64 skip, bool sync)
60{ 68{
61 char filename1[MAX_BUF], filename2[MAX_BUF]; 69 CALL_BEGIN (2);
62 70 CALL_ARG_SV (newSVval64 (skip));
63 sprintf (filename1, "%s/uuid", settings.localdir); 71 CALL_ARG_SV (boolSV (sync));
64 sprintf (filename2, "%s/uuid~", settings.localdir); 72 CALL_CALL ("cf::write_uuid", G_DISCARD);
65 73 CALL_END;
66 FILE *fp;
67
68 if (!(fp = fopen (filename2, "w")))
69 {
70 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
71 return;
72 }
73
74 fprintf (fp, "<1,%llx>\n", (unsigned long long)UUID::cur.seq + UUID_SKIP * 2);
75 fclose (fp);
76 rename (filename2, filename1);
77} 74}
78 75
79static void 76static void
80read_uuid (void) 77read_uuid (void)
81{ 78{
82 char filename[MAX_BUF]; 79 char filename[MAX_BUF];
83 80
84 sprintf (filename, "%s/uuid", settings.localdir); 81 sprintf (filename, "%s/uuid", settings.localdir);
82
83 seq_next_save = 0;
85 84
86 FILE *fp; 85 FILE *fp;
87 86
88 if (!(fp = fopen (filename, "r"))) 87 if (!(fp = fopen (filename, "r")))
89 { 88 {
90 if (errno == ENOENT) 89 if (errno == ENOENT)
91 { 90 {
92 LOG (llevInfo, "RESET uid to 1\n"); 91 LOG (llevInfo, "RESET uid to 1\n");
93 UUID::cur.seq = 0; 92 UUID::cur.seq = 0;
94 write_uuid (); 93 write_uuid (UUID_GAP, true);
95 return; 94 return;
96 } 95 }
97 96
98 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
99 _exit (1); 98 _exit (1);
100 } 99 }
101 100
102 int version; 101 UUID::BUF buf;
103 unsigned long long uid; 102 buf[0] = 0;
104 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 103 fgets (buf, sizeof (buf), fp);
104
105 if (!UUID::cur.parse (buf))
105 { 106 {
106 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 107 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
107 _exit (1); 108 _exit (1);
108 } 109 }
109 110
110 UUID::cur.seq = uid; 111 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
111 write_uuid (); 112
112 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 113 write_uuid (UUID_GAP, true);
113 fclose (fp); 114 fclose (fp);
114} 115}
115 116
116UUID 117UUID
117UUID::gen () 118UUID::gen ()
118{ 119{
119 UUID uid; 120 UUID uid;
120 121
121 uid.seq = ++cur.seq; 122 uid.seq = ++cur.seq;
122 123
123 if (!(cur.seq & (UUID_SKIP - 1))) 124 if (expect_false (cur.seq >= seq_next_save))
124 write_uuid (); 125 {
126 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
127 write_uuid (UUID_GAP, false);
128 }
129
125 130
126 return uid; 131 return uid;
127} 132}
128 133
129void 134void
131{ 136{
132 read_uuid (); 137 read_uuid ();
133} 138}
134 139
135/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
136static int 141static bool
137compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
138{ 143{
139 key_value *wants_field;
140
141 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
142 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
143 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
144 */ 147 */
145 148
146 /* For each field in wants, */ 149 /* For each field in wants, */
147 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
148 { 151 if (has->kv_get (kv->key) != kv->value)
149 key_value *has_field; 152 return false;
150
151 /* Look for a field in has with the same key. */
152 has_field = get_ob_key_link (has, wants_field->key);
153
154 if (has_field == NULL)
155 {
156 /* No field with that name. */
157 return FALSE;
158 }
159
160 /* Found the matching field. */
161 if (has_field->value != wants_field->value)
162 {
163 /* Values don't match, so this half of the comparison is false. */
164 return FALSE;
165 }
166
167 /* If we get here, we found a match. Now for the next field in wants. */
168 }
169 153
170 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
171 return TRUE; 155 return true;
172} 156}
173 157
174/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
175static int 159static bool
176compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
177{ 161{
178 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
179 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
180 */ 164 */
181 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
182} 167}
183 168
184/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
185 * they can be merged together. 170 * they can be merged together.
186 * 171 *
201 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value 187 || ob1->value != ob2->value
203 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
204 return 0; 189 return 0;
205 190
206 //TODO: this ain't working well, use nicer and correct overflow check 191 /* Do not merge objects if nrof would overflow. First part checks
207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 * for unsigned overflow (2c), second part checks whether the result
208 * value could not be stored in a sint32 (which unfortunately sometimes is 193 * would fit into a 32 bit signed int, which is often used to hold
209 * used to store nrof). 194 * nrof values.
210 */ 195 */
211 if (ob1->nrof + ob2->nrof >= 1UL << 31) 196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
212 return 0; 197 return 0;
213 198
214 /* If the objects have been identified, set the BEEN_APPLIED flag. 199 /* If the objects have been identified, set the BEEN_APPLIED flag.
215 * This is to the comparison of the flags below will be OK. We 200 * This is to the comparison of the flags below will be OK. We
216 * just can't ignore the been applied or identified flags, as they 201 * just can't ignore the been applied or identified flags, as they
217 * are not equal - just if it has been identified, the been_applied 202 * are not equal - just if it has been identified, the been_applied
218 * flags lose any meaning. 203 * flags lose any meaning.
219 */ 204 */
220 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
221 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222 207
223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 209 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225 210
226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 211 if (ob1->arch->archname != ob2->arch->archname
227 || ob1->arch != ob2->arch
228 || ob1->name != ob2->name 212 || ob1->name != ob2->name
229 || ob1->title != ob2->title 213 || ob1->title != ob2->title
230 || ob1->msg != ob2->msg 214 || ob1->msg != ob2->msg
231 || ob1->weight != ob2->weight 215 || ob1->weight != ob2->weight
232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
234 || ob1->attacktype != ob2->attacktype 216 || ob1->attacktype != ob2->attacktype
235 || ob1->magic != ob2->magic 217 || ob1->magic != ob2->magic
236 || ob1->slaying != ob2->slaying 218 || ob1->slaying != ob2->slaying
237 || ob1->skill != ob2->skill 219 || ob1->skill != ob2->skill
238 || ob1->value != ob2->value 220 || ob1->value != ob2->value
239 || ob1->animation_id != ob2->animation_id 221 || ob1->animation_id != ob2->animation_id
222 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
240 || ob1->client_type != ob2->client_type 223 || ob1->client_type != ob2->client_type
241 || ob1->materialname != ob2->materialname 224 || ob1->materialname != ob2->materialname
242 || ob1->lore != ob2->lore 225 || ob1->lore != ob2->lore
243 || ob1->subtype != ob2->subtype 226 || ob1->subtype != ob2->subtype
244 || ob1->move_type != ob2->move_type 227 || ob1->move_type != ob2->move_type
245 || ob1->move_block != ob2->move_block 228 || ob1->move_block != ob2->move_block
246 || ob1->move_allow != ob2->move_allow 229 || ob1->move_allow != ob2->move_allow
247 || ob1->move_on != ob2->move_on 230 || ob1->move_on != ob2->move_on
248 || ob1->move_off != ob2->move_off 231 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow 232 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty) 233 || ob1->move_slow_penalty != ob2->move_slow_penalty
234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
251 return 0; 236 return 0;
252 237
238 if ((ob1->flag ^ ob2->flag)
239 .reset (FLAG_INV_LOCKED)
240 .reset (FLAG_CLIENT_SENT)
241 .reset (FLAG_REMOVED)
242 .any ())
243 return 0;
244
253 /* This is really a spellbook check - really, we should 245 /* This is really a spellbook check - we should in general
254 * check all objects in the inventory. 246 * not merge objects with real inventories, as splitting them
247 * is hard.
255 */ 248 */
256 if (ob1->inv || ob2->inv) 249 if (ob1->inv || ob2->inv)
257 { 250 {
258 if (!(ob1->inv && ob2->inv)) 251 if (!(ob1->inv && ob2->inv))
259 return 0; /* inventories differ in length */ 252 return 0; /* inventories differ in length */
260 253
261 if (ob1->inv->below || ob2->inv->below) 254 if (ob1->inv->below || ob2->inv->below)
262 return 0; /* more than one object in inv */ 255 return 0; /* more than one object in inv */
263 256
264 if (!object::can_merge (ob1->inv, ob2->inv)) 257 if (!object::can_merge (ob1->inv, ob2->inv))
265 return 0; /* inventory objexts differ */ 258 return 0; /* inventory objects differ */
266 259
267 /* inventory ok - still need to check rest of this object to see 260 /* inventory ok - still need to check rest of this object to see
268 * if it is valid. 261 * if it is valid.
269 */ 262 */
270 } 263 }
289 if (ob1->level != ob2->level) 282 if (ob1->level != ob2->level)
290 return 0; 283 return 0;
291 break; 284 break;
292 } 285 }
293 286
294 if (ob1->key_values != NULL || ob2->key_values != NULL) 287 if (ob1->key_values || ob2->key_values)
295 { 288 {
296 /* At least one of these has key_values. */ 289 /* At least one of these has key_values. */
297 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 290 if ((!ob1->key_values) != (!ob2->key_values))
298 /* One has fields, but the other one doesn't. */ 291 return 0; /* One has fields, but the other one doesn't. */
299 return 0; 292
300 else if (!compare_ob_value_lists (ob1, ob2)) 293 if (!compare_ob_value_lists (ob1, ob2))
301 return 0; 294 return 0;
302 } 295 }
303 296
304 if (ob1->self || ob2->self) 297 if (ob1->self || ob2->self)
305 { 298 {
311 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 304 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
312 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 305 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
313 306
314 if (k1 != k2) 307 if (k1 != k2)
315 return 0; 308 return 0;
309
316 else if (k1 == 0) 310 if (k1 == 0)
317 return 1; 311 return 1;
312
318 else if (!cfperl_can_merge (ob1, ob2)) 313 if (!cfperl_can_merge (ob1, ob2))
319 return 0; 314 return 0;
320 } 315 }
321 } 316 }
322 317
323 /* Everything passes, must be OK. */ 318 /* Everything passes, must be OK. */
324 return 1; 319 return 1;
325} 320}
326 321
322// find player who can see this object
323object *
324object::visible_to () const
325{
326 if (client_visible () && !flag [FLAG_REMOVED])
327 {
328 // see if we are in a container of sorts
329 if (env)
330 {
331 // the player inventory itself is always visible
332 if (env->type == PLAYER)
333 return env;
334
335 // else a player could have our env open
336 object *envest = env->outer_env ();
337
338 // the player itself is always on a map, so we will find him here
339 // even if our inv is in a player.
340 if (envest->is_on_map ())
341 if (object *pl = envest->ms ().player ())
342 if (pl->container == env)
343 return pl;
344 }
345 else
346 {
347 // maybe there is a player standing on the same mapspace
348 // this will catch the case where "this" is a player
349 if (object *pl = ms ().player ())
350 if (!pl->container || this == pl->container)
351 return pl;
352 }
353 }
354
355 return 0;
356}
357
358// adjust weight per container type ("of holding")
359static sint32
360weight_adjust_for (object *op, sint32 weight)
361{
362 return op->type == CONTAINER
363 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
364 : weight;
365}
366
327/* 367/*
368 * adjust_weight(object, weight) adds the specified weight to an object,
369 * and also updates how much the environment(s) is/are carrying.
370 */
371static void
372adjust_weight (object *op, sint32 weight)
373{
374 while (op)
375 {
376 // adjust by actual difference to account for rounding errors
377 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
378 weight = weight_adjust_for (op, op->carrying)
379 - weight_adjust_for (op, op->carrying - weight);
380
381 if (!weight)
382 return;
383
384 op->carrying += weight;
385
386 if (object *pl = op->visible_to ())
387 if (pl != op) // player is handled lazily
388 esrv_update_item (UPD_WEIGHT, pl, op);
389
390 op = op->env;
391 }
392}
393
394/*
328 * sum_weight() is a recursive function which calculates the weight 395 * this is a recursive function which calculates the weight
329 * an object is carrying. It goes through in figures out how much 396 * an object is carrying. It goes through op and figures out how much
330 * containers are carrying, and sums it up. 397 * containers are carrying, and sums it up.
331 */ 398 */
332long 399void
333sum_weight (object *op) 400object::update_weight ()
334{ 401{
335 long sum; 402 sint32 sum = 0;
336 object *inv;
337 403
338 for (sum = 0, inv = op->inv; inv; inv = inv->below) 404 for (object *op = inv; op; op = op->below)
339 { 405 {
340 if (inv->inv) 406 if (op->inv)
341 sum_weight (inv); 407 op->update_weight ();
342 408
343 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 409 sum += op->total_weight ();
410 }
411
412 sum = weight_adjust_for (this, sum);
413
414 if (sum != carrying)
344 } 415 {
345
346 if (op->type == CONTAINER && op->stats.Str)
347 sum = (sum * (100 - op->stats.Str)) / 100;
348
349 if (op->carrying != sum)
350 op->carrying = sum; 416 carrying = sum;
351 417
352 return sum; 418 if (object *pl = visible_to ())
419 if (pl != this) // player is handled lazily
420 esrv_update_item (UPD_WEIGHT, pl, this);
421 }
353} 422}
354 423
355/** 424/*
356 * Return the outermost environment object for a given object. 425 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
357 */
358
359object *
360object_get_env_recursive (object *op)
361{
362 while (op->env != NULL)
363 op = op->env;
364 return op;
365}
366
367/*
368 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
369 * Some error messages.
370 * The result of the dump is stored in the static global errmsg array.
371 */ 426 */
372char * 427char *
373dump_object (object *op) 428dump_object (object *op)
374{ 429{
375 if (!op) 430 if (!op)
389get_nearest_part (object *op, const object *pl) 444get_nearest_part (object *op, const object *pl)
390{ 445{
391 object *tmp, *closest; 446 object *tmp, *closest;
392 int last_dist, i; 447 int last_dist, i;
393 448
394 if (op->more == NULL) 449 if (!op->more)
395 return op; 450 return op;
451
396 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 452 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
453 tmp;
454 tmp = tmp->more)
397 if ((i = distance (tmp, pl)) < last_dist) 455 if ((i = distance (tmp, pl)) < last_dist)
398 closest = tmp, last_dist = i; 456 closest = tmp, last_dist = i;
457
399 return closest; 458 return closest;
400} 459}
401 460
402/* 461/*
403 * Returns the object which has the count-variable equal to the argument. 462 * Returns the object which has the count-variable equal to the argument.
463 * VERRRY slow.
404 */ 464 */
405object * 465object *
406find_object (tag_t i) 466find_object (tag_t i)
407{ 467{
408 for_all_objects (op) 468 for_all_objects (op)
419 */ 479 */
420object * 480object *
421find_object_name (const char *str) 481find_object_name (const char *str)
422{ 482{
423 shstr_cmp str_ (str); 483 shstr_cmp str_ (str);
424 object *op;
425 484
485 if (str_)
426 for_all_objects (op) 486 for_all_objects (op)
427 if (op->name == str_) 487 if (op->name == str_)
428 break; 488 return op;
429 489
430 return op; 490 return 0;
431} 491}
432 492
433/* 493/*
434 * Sets the owner and sets the skill and exp pointers to owner's current 494 * Sets the owner and sets the skill and exp pointers to owner's current
435 * skill and experience objects. 495 * skill and experience objects.
533 } 593 }
534 594
535 op->key_values = 0; 595 op->key_values = 0;
536} 596}
537 597
538object & 598/*
539object::operator =(const object &src) 599 * copy_to first frees everything allocated by the dst object,
600 * and then copies the contents of itself into the second
601 * object, allocating what needs to be allocated. Basically, any
602 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
603 * if the first object is freed, the pointers in the new object
604 * will point at garbage.
605 */
606void
607object::copy_to (object *dst)
540{ 608{
541 bool is_freed = flag [FLAG_FREED]; 609 dst->remove ();
542 bool is_removed = flag [FLAG_REMOVED];
543
544 *(object_copy *)this = src; 610 *(object_copy *)dst = *this;
545
546 flag [FLAG_FREED] = is_freed;
547 flag [FLAG_REMOVED] = is_removed; 611 dst->flag [FLAG_REMOVED] = true;
548 612
549 /* Copy over key_values, if any. */ 613 /* Copy over key_values, if any. */
550 if (src.key_values) 614 if (key_values)
551 { 615 {
552 key_value *tail = 0; 616 key_value *tail = 0;
553 key_values = 0; 617 dst->key_values = 0;
554 618
555 for (key_value *i = src.key_values; i; i = i->next) 619 for (key_value *i = key_values; i; i = i->next)
556 { 620 {
557 key_value *new_link = new key_value; 621 key_value *new_link = new key_value;
558 622
559 new_link->next = 0; 623 new_link->next = 0;
560 new_link->key = i->key; 624 new_link->key = i->key;
561 new_link->value = i->value; 625 new_link->value = i->value;
562 626
563 /* Try and be clever here, too. */ 627 /* Try and be clever here, too. */
564 if (!key_values) 628 if (!dst->key_values)
565 { 629 {
566 key_values = new_link; 630 dst->key_values = new_link;
567 tail = new_link; 631 tail = new_link;
568 } 632 }
569 else 633 else
570 { 634 {
571 tail->next = new_link; 635 tail->next = new_link;
572 tail = new_link; 636 tail = new_link;
573 } 637 }
574 } 638 }
575 } 639 }
576}
577
578/*
579 * copy_to first frees everything allocated by the dst object,
580 * and then copies the contents of itself into the second
581 * object, allocating what needs to be allocated. Basically, any
582 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
583 * if the first object is freed, the pointers in the new object
584 * will point at garbage.
585 */
586void
587object::copy_to (object *dst)
588{
589 *dst = *this;
590 640
591 if (speed < 0) 641 if (speed < 0)
592 dst->speed_left -= rndm (); 642 dst->speed_left -= rndm ();
593 643
594 dst->set_speed (dst->speed); 644 dst->set_speed (dst->speed);
616object * 666object *
617object::clone () 667object::clone ()
618{ 668{
619 object *neu = create (); 669 object *neu = create ();
620 copy_to (neu); 670 copy_to (neu);
671 neu->map = map; // not copied by copy_to
621 return neu; 672 return neu;
622} 673}
623 674
624/* 675/*
625 * If an object with the IS_TURNABLE() flag needs to be turned due 676 * If an object with the IS_TURNABLE() flag needs to be turned due
676 * UP_OBJ_FACE: only the objects face has changed. 727 * UP_OBJ_FACE: only the objects face has changed.
677 */ 728 */
678void 729void
679update_object (object *op, int action) 730update_object (object *op, int action)
680{ 731{
681 if (op == NULL) 732 if (!op)
682 { 733 {
683 /* this should never happen */ 734 /* this should never happen */
684 LOG (llevDebug, "update_object() called for NULL object.\n"); 735 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
685 return; 736 return;
686 } 737 }
687 738
688 if (op->env) 739 if (!op->is_on_map ())
689 { 740 {
690 /* Animation is currently handled by client, so nothing 741 /* Animation is currently handled by client, so nothing
691 * to do in this case. 742 * to do in this case.
692 */ 743 */
693 return; 744 return;
694 } 745 }
695
696 /* If the map is saving, don't do anything as everything is
697 * going to get freed anyways.
698 */
699 if (!op->map || op->map->in_memory == MAP_SAVING)
700 return;
701 746
702 /* make sure the object is within map boundaries */ 747 /* make sure the object is within map boundaries */
703 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 748 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
704 { 749 {
705 LOG (llevError, "update_object() called for object out of map!\n"); 750 LOG (llevError, "update_object() called for object out of map!\n");
848object::destroy_inv (bool drop_to_ground) 893object::destroy_inv (bool drop_to_ground)
849{ 894{
850 // need to check first, because the checks below might segfault 895 // need to check first, because the checks below might segfault
851 // as we might be on an invalid mapspace and crossfire code 896 // as we might be on an invalid mapspace and crossfire code
852 // is too buggy to ensure that the inventory is empty. 897 // is too buggy to ensure that the inventory is empty.
853 // corollary: if you create arrows etc. with stuff in tis inventory, 898 // corollary: if you create arrows etc. with stuff in its inventory,
854 // cf will crash below with off-map x and y 899 // cf will crash below with off-map x and y
855 if (!inv) 900 if (!inv)
856 return; 901 return;
857 902
858 /* Only if the space blocks everything do we not process - 903 /* Only if the space blocks everything do we not process -
859 * if some form of movement is allowed, let objects 904 * if some form of movement is allowed, let objects
860 * drop on that space. 905 * drop on that space.
861 */ 906 */
862 if (!drop_to_ground 907 if (!drop_to_ground
863 || !map 908 || !map
864 || map->in_memory != MAP_IN_MEMORY 909 || map->in_memory != MAP_ACTIVE
865 || map->nodrop 910 || map->no_drop
866 || ms ().move_block == MOVE_ALL) 911 || ms ().move_block == MOVE_ALL)
867 { 912 {
868 while (inv) 913 while (inv)
869 { 914 {
870 inv->destroy_inv (drop_to_ground); 915 inv->destroy_inv (false);
871 inv->destroy (); 916 inv->destroy ();
872 } 917 }
873 } 918 }
874 else 919 else
875 { /* Put objects in inventory onto this space */ 920 { /* Put objects in inventory onto this space */
881 || op->flag [FLAG_NO_DROP] 926 || op->flag [FLAG_NO_DROP]
882 || op->type == RUNE 927 || op->type == RUNE
883 || op->type == TRAP 928 || op->type == TRAP
884 || op->flag [FLAG_IS_A_TEMPLATE] 929 || op->flag [FLAG_IS_A_TEMPLATE]
885 || op->flag [FLAG_DESTROY_ON_DEATH]) 930 || op->flag [FLAG_DESTROY_ON_DEATH])
886 op->destroy (); 931 op->destroy (true);
887 else 932 else
888 map->insert (op, x, y); 933 map->insert (op, x, y);
889 } 934 }
890 } 935 }
891} 936}
895 object *op = new object; 940 object *op = new object;
896 op->link (); 941 op->link ();
897 return op; 942 return op;
898} 943}
899 944
945static struct freed_map : maptile
946{
947 freed_map ()
948 {
949 path = "<freed objects map>";
950 name = "/internal/freed_objects_map";
951 width = 3;
952 height = 3;
953 no_drop = 1;
954 no_reset = 1;
955
956 alloc ();
957 in_memory = MAP_ACTIVE;
958 }
959
960 ~freed_map ()
961 {
962 destroy ();
963 }
964} freed_map; // freed objects are moved here to avoid crashes
965
900void 966void
901object::do_destroy () 967object::do_destroy ()
902{ 968{
903 attachable::do_destroy ();
904
905 if (flag [FLAG_IS_LINKED]) 969 if (flag [FLAG_IS_LINKED])
906 remove_button_link (this); 970 remove_button_link (this);
907 971
908 if (flag [FLAG_FRIENDLY]) 972 if (flag [FLAG_FRIENDLY])
909 remove_friendly_object (this); 973 remove_friendly_object (this);
910 974
911 if (!flag [FLAG_REMOVED])
912 remove (); 975 remove ();
913 976
914 destroy_inv (true); 977 attachable::do_destroy ();
915 978
916 deactivate (); 979 deactivate ();
917 unlink (); 980 unlink ();
918 981
919 flag [FLAG_FREED] = 1; 982 flag [FLAG_FREED] = 1;
920 983
921 // hack to ensure that freed objects still have a valid map 984 // hack to ensure that freed objects still have a valid map
922 {
923 static maptile *freed_map; // freed objects are moved here to avoid crashes
924
925 if (!freed_map)
926 {
927 freed_map = new maptile;
928
929 freed_map->path = "<freed objects map>";
930 freed_map->name = "/internal/freed_objects_map";
931 freed_map->width = 3;
932 freed_map->height = 3;
933 freed_map->nodrop = 1;
934
935 freed_map->alloc ();
936 freed_map->in_memory = MAP_IN_MEMORY;
937 }
938
939 map = freed_map; 985 map = &freed_map;
940 x = 1; 986 x = 1;
941 y = 1; 987 y = 1;
942 }
943 988
944 if (more) 989 if (more)
945 { 990 {
946 more->destroy (); 991 more->destroy ();
947 more = 0; 992 more = 0;
960object::destroy (bool destroy_inventory) 1005object::destroy (bool destroy_inventory)
961{ 1006{
962 if (destroyed ()) 1007 if (destroyed ())
963 return; 1008 return;
964 1009
1010 if (!is_head () && !head->destroyed ())
1011 {
1012 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1013 head->destroy (destroy_inventory);
1014 return;
1015 }
1016
965 if (destroy_inventory) 1017 destroy_inv (!destroy_inventory);
966 destroy_inv (false);
967 1018
968 if (is_head ()) 1019 if (is_head ())
969 if (sound_destroy) 1020 if (sound_destroy)
970 play_sound (sound_destroy); 1021 play_sound (sound_destroy);
971 else if (flag [FLAG_MONSTER]) 1022 else if (flag [FLAG_MONSTER])
972 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1023 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
973 1024
974 attachable::destroy (); 1025 attachable::destroy ();
975}
976
977/*
978 * sub_weight() recursively (outwards) subtracts a number from the
979 * weight of an object (and what is carried by it's environment(s)).
980 */
981void
982sub_weight (object *op, signed long weight)
983{
984 while (op != NULL)
985 {
986 if (op->type == CONTAINER)
987 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
988
989 op->carrying -= weight;
990 op = op->env;
991 }
992} 1026}
993 1027
994/* op->remove (): 1028/* op->remove ():
995 * This function removes the object op from the linked list of objects 1029 * This function removes the object op from the linked list of objects
996 * which it is currently tied to. When this function is done, the 1030 * which it is currently tied to. When this function is done, the
1002object::do_remove () 1036object::do_remove ()
1003{ 1037{
1004 object *tmp, *last = 0; 1038 object *tmp, *last = 0;
1005 object *otmp; 1039 object *otmp;
1006 1040
1007 if (QUERY_FLAG (this, FLAG_REMOVED)) 1041 if (flag [FLAG_REMOVED])
1008 return; 1042 return;
1009 1043
1010 SET_FLAG (this, FLAG_REMOVED);
1011 INVOKE_OBJECT (REMOVE, this); 1044 INVOKE_OBJECT (REMOVE, this);
1045
1046 flag [FLAG_REMOVED] = true;
1012 1047
1013 if (more) 1048 if (more)
1014 more->remove (); 1049 more->remove ();
1015 1050
1016 /* 1051 /*
1017 * In this case, the object to be removed is in someones 1052 * In this case, the object to be removed is in someones
1018 * inventory. 1053 * inventory.
1019 */ 1054 */
1020 if (env) 1055 if (env)
1021 { 1056 {
1022 if (nrof) 1057 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1023 sub_weight (env, weight * nrof); 1058 if (object *pl = visible_to ())
1024 else 1059 esrv_del_item (pl->contr, count);
1025 sub_weight (env, weight + carrying); 1060 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1061
1062 adjust_weight (env, -total_weight ());
1063
1064 /* we set up values so that it could be inserted into
1065 * the map, but we don't actually do that - it is up
1066 * to the caller to decide what we want to do.
1067 */
1068 map = env->map;
1069 x = env->x;
1070 y = env->y;
1071
1072 // make sure cmov optimisation is applicable
1073 *(above ? &above->below : &env->inv) = below;
1074 *(below ? &below->above : &above ) = above; // &above is just a dummy
1075
1076 above = 0;
1077 below = 0;
1078 env = 0;
1026 1079
1027 /* NO_FIX_PLAYER is set when a great many changes are being 1080 /* NO_FIX_PLAYER is set when a great many changes are being
1028 * made to players inventory. If set, avoiding the call 1081 * made to players inventory. If set, avoiding the call
1029 * to save cpu time. 1082 * to save cpu time.
1030 */ 1083 */
1031 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1084 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1032 otmp->update_stats (); 1085 otmp->update_stats ();
1033
1034 if (above)
1035 above->below = below;
1036 else
1037 env->inv = below;
1038
1039 if (below)
1040 below->above = above;
1041
1042 /* we set up values so that it could be inserted into
1043 * the map, but we don't actually do that - it is up
1044 * to the caller to decide what we want to do.
1045 */
1046 x = env->x, y = env->y;
1047 map = env->map;
1048 above = 0, below = 0;
1049 env = 0;
1050 } 1086 }
1051 else if (map) 1087 else if (map)
1052 { 1088 {
1053 if (type == PLAYER)
1054 {
1055 // leaving a spot always closes any open container on the ground
1056 if (container && !container->env)
1057 // this causes spurious floorbox updates, but it ensures
1058 // that the CLOSE event is being sent.
1059 close_container ();
1060
1061 --map->players;
1062 map->touch ();
1063 }
1064
1065 map->dirty = true; 1089 map->dirty = true;
1066 mapspace &ms = this->ms (); 1090 mapspace &ms = this->ms ();
1067 1091
1092 if (object *pl = ms.player ())
1093 {
1094 if (type == PLAYER) // this == pl(!)
1095 {
1096 // leaving a spot always closes any open container on the ground
1097 if (container && !container->env)
1098 // this causes spurious floorbox updates, but it ensures
1099 // that the CLOSE event is being sent.
1100 close_container ();
1101
1102 --map->players;
1103 map->touch ();
1104 }
1105 else if (pl->container == this)
1106 {
1107 // removing a container should close it
1108 close_container ();
1109 }
1110
1111 esrv_del_item (pl->contr, count);
1112 }
1113
1068 /* link the object above us */ 1114 /* link the object above us */
1069 if (above) 1115 // re-link, make sure compiler can easily use cmove
1070 above->below = below; 1116 *(above ? &above->below : &ms.top) = below;
1071 else 1117 *(below ? &below->above : &ms.bot) = above;
1072 ms.top = below; /* we were top, set new top */
1073
1074 /* Relink the object below us, if there is one */
1075 if (below)
1076 below->above = above;
1077 else
1078 {
1079 /* Nothing below, which means we need to relink map object for this space
1080 * use translated coordinates in case some oddness with map tiling is
1081 * evident
1082 */
1083 if (GET_MAP_OB (map, x, y) != this)
1084 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1085
1086 ms.bot = above; /* goes on above it. */
1087 }
1088 1118
1089 above = 0; 1119 above = 0;
1090 below = 0; 1120 below = 0;
1091 1121
1092 if (map->in_memory == MAP_SAVING) 1122 if (map->in_memory == MAP_SAVING)
1101 * removed (most likely destroyed), update the player view 1131 * removed (most likely destroyed), update the player view
1102 * appropriately. 1132 * appropriately.
1103 */ 1133 */
1104 pl->close_container (); 1134 pl->close_container ();
1105 1135
1136 //TODO: the floorbox prev/next might need updating
1137 //esrv_del_item (pl->contr, count);
1138 //TODO: update floorbox to preserve ordering
1139 if (pl->contr->ns)
1106 pl->contr->ns->floorbox_update (); 1140 pl->contr->ns->floorbox_update ();
1107 } 1141 }
1108 1142
1109 for (tmp = ms.bot; tmp; tmp = tmp->above) 1143 for (tmp = ms.bot; tmp; tmp = tmp->above)
1110 { 1144 {
1111 /* No point updating the players look faces if he is the object 1145 /* No point updating the players look faces if he is the object
1155 if (!top) 1189 if (!top)
1156 for (top = op; top && top->above; top = top->above) 1190 for (top = op; top && top->above; top = top->above)
1157 ; 1191 ;
1158 1192
1159 for (; top; top = top->below) 1193 for (; top; top = top->below)
1160 {
1161 if (top == op)
1162 continue;
1163
1164 if (object::can_merge (op, top)) 1194 if (object::can_merge (op, top))
1165 { 1195 {
1166 top->nrof += op->nrof; 1196 top->nrof += op->nrof;
1167 1197
1168/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1198 if (object *pl = top->visible_to ())
1169 op->weight = 0; /* Don't want any adjustements now */ 1199 esrv_update_item (UPD_NROF, pl, top);
1200
1201 op->weight = 0; // cancel the addition above
1202 op->carrying = 0; // must be 0 already
1203
1170 op->destroy (); 1204 op->destroy (1);
1205
1171 return top; 1206 return top;
1172 } 1207 }
1173 }
1174 1208
1175 return 0; 1209 return 0;
1176} 1210}
1177 1211
1178void 1212void
1203 * job preparing multi-part monsters. 1237 * job preparing multi-part monsters.
1204 */ 1238 */
1205object * 1239object *
1206insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1240insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1207{ 1241{
1242 op->remove ();
1243
1208 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1244 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1209 { 1245 {
1210 tmp->x = x + tmp->arch->x; 1246 tmp->x = x + tmp->arch->x;
1211 tmp->y = y + tmp->arch->y; 1247 tmp->y = y + tmp->arch->y;
1212 } 1248 }
1235 * just 'op' otherwise 1271 * just 'op' otherwise
1236 */ 1272 */
1237object * 1273object *
1238insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1274insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1239{ 1275{
1240 assert (!op->flag [FLAG_FREED]); 1276 if (op->is_on_map ())
1277 {
1278 LOG (llevError, "insert_ob_in_map called for object already on map");
1279 abort ();
1280 }
1241 1281
1242 object *top, *floor = NULL; 1282 if (op->env)
1243 1283 {
1284 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1244 op->remove (); 1285 op->remove ();
1286 }
1287
1288 if (op->face && !face_info (op->face))//D TODO: remove soon
1289 {//D
1290 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
1291 op->face = 1;//D
1292 }//D
1245 1293
1246 /* Ideally, the caller figures this out. However, it complicates a lot 1294 /* Ideally, the caller figures this out. However, it complicates a lot
1247 * of areas of callers (eg, anything that uses find_free_spot would now 1295 * of areas of callers (eg, anything that uses find_free_spot would now
1248 * need extra work 1296 * need extra work
1249 */ 1297 */
1250 if (!xy_normalise (m, op->x, op->y)) 1298 if (!xy_normalise (m, op->x, op->y))
1251 { 1299 {
1252 op->destroy (); 1300 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1253 return 0; 1301 return 0;
1254 } 1302 }
1255 1303
1256 if (object *more = op->more) 1304 if (object *more = op->more)
1257 if (!insert_ob_in_map (more, m, originator, flag)) 1305 if (!insert_ob_in_map (more, m, originator, flag))
1266 */ 1314 */
1267 if (op->nrof && !(flag & INS_NO_MERGE)) 1315 if (op->nrof && !(flag & INS_NO_MERGE))
1268 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1316 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1269 if (object::can_merge (op, tmp)) 1317 if (object::can_merge (op, tmp))
1270 { 1318 {
1319 // TODO: we actually want to update tmp, not op,
1320 // but some caller surely breaks when we return tmp
1321 // from here :/
1271 op->nrof += tmp->nrof; 1322 op->nrof += tmp->nrof;
1272 tmp->destroy (); 1323 tmp->destroy (1);
1273 } 1324 }
1274 1325
1275 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1326 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1276 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1327 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1277 1328
1284 { 1335 {
1285 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1336 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1286 abort (); 1337 abort ();
1287 } 1338 }
1288 1339
1340 if (!originator->is_on_map ())
1341 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1342 op->debug_desc (), originator->debug_desc ());
1343
1289 op->above = originator; 1344 op->above = originator;
1290 op->below = originator->below; 1345 op->below = originator->below;
1291
1292 if (op->below)
1293 op->below->above = op;
1294 else
1295 ms.bot = op;
1296
1297 /* since *below* originator, no need to update top */
1298 originator->below = op; 1346 originator->below = op;
1347
1348 *(op->below ? &op->below->above : &ms.bot) = op;
1299 } 1349 }
1300 else 1350 else
1301 { 1351 {
1302 top = ms.bot; 1352 object *floor = 0;
1353 object *top = ms.top;
1303 1354
1304 /* If there are other objects, then */ 1355 /* If there are other objects, then */
1305 if (top) 1356 if (top)
1306 { 1357 {
1307 object *last = 0;
1308
1309 /* 1358 /*
1310 * If there are multiple objects on this space, we do some trickier handling. 1359 * If there are multiple objects on this space, we do some trickier handling.
1311 * We've already dealt with merging if appropriate. 1360 * We've already dealt with merging if appropriate.
1312 * Generally, we want to put the new object on top. But if 1361 * Generally, we want to put the new object on top. But if
1313 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1362 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1316 * once we get to them. This reduces the need to traverse over all of 1365 * once we get to them. This reduces the need to traverse over all of
1317 * them when adding another one - this saves quite a bit of cpu time 1366 * them when adding another one - this saves quite a bit of cpu time
1318 * when lots of spells are cast in one area. Currently, it is presumed 1367 * when lots of spells are cast in one area. Currently, it is presumed
1319 * that flying non pickable objects are spell objects. 1368 * that flying non pickable objects are spell objects.
1320 */ 1369 */
1321 for (top = ms.bot; top; top = top->above) 1370 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322 { 1371 {
1323 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1372 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1324 floor = top; 1373 floor = tmp;
1325 1374
1326 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1375 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1327 { 1376 {
1328 /* We insert above top, so we want this object below this */ 1377 /* We insert above top, so we want this object below this */
1329 top = top->below; 1378 top = tmp->below;
1330 break; 1379 break;
1331 } 1380 }
1332 1381
1333 last = top; 1382 top = tmp;
1334 } 1383 }
1335
1336 /* Don't want top to be NULL, so set it to the last valid object */
1337 top = last;
1338 1384
1339 /* We let update_position deal with figuring out what the space 1385 /* We let update_position deal with figuring out what the space
1340 * looks like instead of lots of conditions here. 1386 * looks like instead of lots of conditions here.
1341 * makes things faster, and effectively the same result. 1387 * makes things faster, and effectively the same result.
1342 */ 1388 */
1349 */ 1395 */
1350 if (!(flag & INS_ON_TOP) 1396 if (!(flag & INS_ON_TOP)
1351 && ms.flags () & P_BLOCKSVIEW 1397 && ms.flags () & P_BLOCKSVIEW
1352 && (op->face && !faces [op->face].visibility)) 1398 && (op->face && !faces [op->face].visibility))
1353 { 1399 {
1400 object *last;
1401
1354 for (last = top; last != floor; last = last->below) 1402 for (last = top; last != floor; last = last->below)
1355 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1356 break; 1404 break;
1357 1405
1358 /* Check to see if we found the object that blocks view, 1406 /* Check to see if we found the object that blocks view,
1366 } /* If objects on this space */ 1414 } /* If objects on this space */
1367 1415
1368 if (flag & INS_ABOVE_FLOOR_ONLY) 1416 if (flag & INS_ABOVE_FLOOR_ONLY)
1369 top = floor; 1417 top = floor;
1370 1418
1371 /* Top is the object that our object (op) is going to get inserted above. 1419 // insert object above top, or bottom-most if top = 0
1372 */
1373
1374 /* First object on this space */
1375 if (!top) 1420 if (!top)
1376 { 1421 {
1422 op->below = 0;
1377 op->above = ms.bot; 1423 op->above = ms.bot;
1378
1379 if (op->above)
1380 op->above->below = op;
1381
1382 op->below = 0;
1383 ms.bot = op; 1424 ms.bot = op;
1425
1426 *(op->above ? &op->above->below : &ms.top) = op;
1384 } 1427 }
1385 else 1428 else
1386 { /* get inserted into the stack above top */ 1429 {
1387 op->above = top->above; 1430 op->above = top->above;
1388
1389 if (op->above)
1390 op->above->below = op; 1431 top->above = op;
1391 1432
1392 op->below = top; 1433 op->below = top;
1393 top->above = op; 1434 *(op->above ? &op->above->below : &ms.top) = op;
1394 } 1435 }
1395 1436 }
1396 if (!op->above)
1397 ms.top = op;
1398 } /* else not INS_BELOW_ORIGINATOR */
1399 1437
1400 if (op->type == PLAYER) 1438 if (op->type == PLAYER)
1401 { 1439 {
1402 op->contr->do_los = 1; 1440 op->contr->do_los = 1;
1403 ++op->map->players; 1441 ++op->map->players;
1405 } 1443 }
1406 1444
1407 op->map->dirty = true; 1445 op->map->dirty = true;
1408 1446
1409 if (object *pl = ms.player ()) 1447 if (object *pl = ms.player ())
1448 //TODO: the floorbox prev/next might need updating
1449 //esrv_send_item (pl, op);
1450 //TODO: update floorbox to preserve ordering
1451 if (pl->contr->ns)
1410 pl->contr->ns->floorbox_update (); 1452 pl->contr->ns->floorbox_update ();
1411 1453
1412 /* If this object glows, it may affect lighting conditions that are 1454 /* If this object glows, it may affect lighting conditions that are
1413 * visible to others on this map. But update_all_los is really 1455 * visible to others on this map. But update_all_los is really
1414 * an inefficient way to do this, as it means los for all players 1456 * an inefficient way to do this, as it means los for all players
1415 * on the map will get recalculated. The players could very well 1457 * on the map will get recalculated. The players could very well
1457 * op is the object to insert it under: supplies x and the map. 1499 * op is the object to insert it under: supplies x and the map.
1458 */ 1500 */
1459void 1501void
1460replace_insert_ob_in_map (const char *arch_string, object *op) 1502replace_insert_ob_in_map (const char *arch_string, object *op)
1461{ 1503{
1462 object *tmp, *tmp1;
1463
1464 /* first search for itself and remove any old instances */ 1504 /* first search for itself and remove any old instances */
1465 1505
1466 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1506 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1467 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1507 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1468 tmp->destroy (); 1508 tmp->destroy (1);
1469 1509
1470 tmp1 = arch_to_object (archetype::find (arch_string)); 1510 object *tmp = arch_to_object (archetype::find (arch_string));
1471 1511
1472 tmp1->x = op->x; 1512 tmp->x = op->x;
1473 tmp1->y = op->y; 1513 tmp->y = op->y;
1514
1474 insert_ob_in_map (tmp1, op->map, op, 0); 1515 insert_ob_in_map (tmp, op->map, op, 0);
1475} 1516}
1476 1517
1477object * 1518object *
1478object::insert_at (object *where, object *originator, int flags) 1519object::insert_at (object *where, object *originator, int flags)
1479{ 1520{
1521 if (where->env)
1522 return where->env->insert (this);
1523 else
1480 return where->map->insert (this, where->x, where->y, originator, flags); 1524 return where->map->insert (this, where->x, where->y, originator, flags);
1481} 1525}
1482 1526
1483/* 1527/*
1484 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1485 * is returned contains nr objects, and the remaining parts contains
1486 * the rest (or is removed and freed if that number is 0).
1487 * On failure, NULL is returned, and the reason put into the
1488 * global static errmsg array.
1489 */
1490object *
1491get_split_ob (object *orig_ob, uint32 nr)
1492{
1493 object *newob;
1494 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1495
1496 if (orig_ob->nrof < nr)
1497 {
1498 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1499 return NULL;
1500 }
1501
1502 newob = object_create_clone (orig_ob);
1503
1504 if ((orig_ob->nrof -= nr) < 1)
1505 orig_ob->destroy (1);
1506 else if (!is_removed)
1507 {
1508 if (orig_ob->env != NULL)
1509 sub_weight (orig_ob->env, orig_ob->weight * nr);
1510 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1511 {
1512 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1513 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1514 return NULL;
1515 }
1516 }
1517
1518 newob->nrof = nr;
1519
1520 return newob;
1521}
1522
1523/*
1524 * decrease_ob_nr(object, number) decreases a specified number from 1528 * decrease(object, number) decreases a specified number from
1525 * the amount of an object. If the amount reaches 0, the object 1529 * the amount of an object. If the amount reaches 0, the object
1526 * is subsequently removed and freed. 1530 * is subsequently removed and freed.
1527 * 1531 *
1528 * Return value: 'op' if something is left, NULL if the amount reached 0 1532 * Return value: 'op' if something is left, NULL if the amount reached 0
1529 */ 1533 */
1534bool
1535object::decrease (sint32 nr)
1536{
1537 if (!nr)
1538 return true;
1539
1540 nr = min (nr, nrof);
1541
1542 nrof -= nr;
1543
1544 if (nrof)
1545 {
1546 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1547
1548 if (object *pl = visible_to ())
1549 esrv_update_item (UPD_NROF, pl, this);
1550
1551 return true;
1552 }
1553 else
1554 {
1555 destroy (1);
1556 return false;
1557 }
1558}
1559
1560/*
1561 * split(ob,nr) splits up ob into two parts. The part which
1562 * is returned contains nr objects, and the remaining parts contains
1563 * the rest (or is removed and returned if that number is 0).
1564 * On failure, NULL is returned.
1565 */
1530object * 1566object *
1531decrease_ob_nr (object *op, uint32 i) 1567object::split (sint32 nr)
1532{ 1568{
1533 object *tmp; 1569 int have = number_of ();
1534 1570
1535 if (i == 0) /* objects with op->nrof require this check */ 1571 if (have < nr)
1536 return op; 1572 return 0;
1537 1573 else if (have == nr)
1538 if (i > op->nrof)
1539 i = op->nrof;
1540
1541 if (QUERY_FLAG (op, FLAG_REMOVED))
1542 op->nrof -= i;
1543 else if (op->env)
1544 { 1574 {
1545 /* is this object in the players inventory, or sub container
1546 * therein?
1547 */
1548 tmp = op->in_player ();
1549 /* nope. Is this a container the player has opened?
1550 * If so, set tmp to that player.
1551 * IMO, searching through all the players will mostly
1552 * likely be quicker than following op->env to the map,
1553 * and then searching the map for a player.
1554 */
1555 if (!tmp)
1556 for_all_players (pl)
1557 if (pl->ob->container == op->env)
1558 {
1559 tmp = pl->ob;
1560 break;
1561 }
1562
1563 if (i < op->nrof)
1564 {
1565 sub_weight (op->env, op->weight * i);
1566 op->nrof -= i;
1567 if (tmp)
1568 esrv_send_item (tmp, op);
1569 }
1570 else
1571 {
1572 op->remove (); 1575 remove ();
1573 op->nrof = 0; 1576 return this;
1574 if (tmp)
1575 esrv_del_item (tmp->contr, op->count);
1576 }
1577 } 1577 }
1578 else 1578 else
1579 { 1579 {
1580 object *above = op->above; 1580 decrease (nr);
1581 1581
1582 if (i < op->nrof) 1582 object *op = deep_clone ();
1583 op->nrof -= i; 1583 op->nrof = nr;
1584 else
1585 {
1586 op->remove ();
1587 op->nrof = 0;
1588 }
1589
1590 /* Since we just removed op, op->above is null */
1591 for (tmp = above; tmp; tmp = tmp->above)
1592 if (tmp->type == PLAYER)
1593 {
1594 if (op->nrof)
1595 esrv_send_item (tmp, op);
1596 else
1597 esrv_del_item (tmp->contr, op->count);
1598 }
1599 }
1600
1601 if (op->nrof)
1602 return op; 1584 return op;
1603 else
1604 {
1605 op->destroy ();
1606 return 0;
1607 }
1608}
1609
1610/*
1611 * add_weight(object, weight) adds the specified weight to an object,
1612 * and also updates how much the environment(s) is/are carrying.
1613 */
1614void
1615add_weight (object *op, signed long weight)
1616{
1617 while (op != NULL)
1618 {
1619 if (op->type == CONTAINER)
1620 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1621
1622 op->carrying += weight;
1623 op = op->env;
1624 } 1585 }
1625} 1586}
1626 1587
1627object * 1588object *
1628insert_ob_in_ob (object *op, object *where) 1589insert_ob_in_ob (object *op, object *where)
1653 * be != op, if items are merged. -Tero 1614 * be != op, if items are merged. -Tero
1654 */ 1615 */
1655object * 1616object *
1656object::insert (object *op) 1617object::insert (object *op)
1657{ 1618{
1658 if (!QUERY_FLAG (op, FLAG_REMOVED))
1659 op->remove ();
1660
1661 if (op->more) 1619 if (op->more)
1662 { 1620 {
1663 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1621 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1664 return op; 1622 return op;
1665 } 1623 }
1666 1624
1667 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1625 op->remove ();
1668 CLEAR_FLAG (op, FLAG_REMOVED); 1626
1627 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1669 1628
1670 if (op->nrof) 1629 if (op->nrof)
1671 {
1672 for (object *tmp = inv; tmp; tmp = tmp->below) 1630 for (object *tmp = inv; tmp; tmp = tmp->below)
1673 if (object::can_merge (tmp, op)) 1631 if (object::can_merge (tmp, op))
1674 { 1632 {
1675 /* return the original object and remove inserted object 1633 /* return the original object and remove inserted object
1676 (client needs the original object) */ 1634 (client needs the original object) */
1677 tmp->nrof += op->nrof; 1635 tmp->nrof += op->nrof;
1678 /* Weight handling gets pretty funky. Since we are adding to 1636
1679 * tmp->nrof, we need to increase the weight. 1637 if (object *pl = tmp->visible_to ())
1680 */ 1638 esrv_update_item (UPD_NROF, pl, tmp);
1639
1681 add_weight (this, op->weight * op->nrof); 1640 adjust_weight (this, op->total_weight ());
1682 SET_FLAG (op, FLAG_REMOVED); 1641
1683 op->destroy (); /* free the inserted object */ 1642 op->destroy (1);
1684 op = tmp; 1643 op = tmp;
1685 op->remove (); /* and fix old object's links */ 1644 goto inserted;
1686 CLEAR_FLAG (op, FLAG_REMOVED);
1687 break;
1688 } 1645 }
1689 1646
1690 /* I assume combined objects have no inventory
1691 * We add the weight - this object could have just been removed
1692 * (if it was possible to merge). calling remove_ob will subtract
1693 * the weight, so we need to add it in again, since we actually do
1694 * the linking below
1695 */
1696 add_weight (this, op->weight * op->nrof);
1697 }
1698 else
1699 add_weight (this, (op->weight + op->carrying));
1700
1701 if (object *otmp = this->in_player ())
1702 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1703 otmp->update_stats ();
1704
1705 op->owner = 0; // its his/hers now. period. 1647 op->owner = 0; // it's his/hers now. period.
1706 op->map = 0; 1648 op->map = 0;
1649 op->x = 0;
1650 op->y = 0;
1651
1652 op->above = 0;
1653 op->below = inv;
1707 op->env = this; 1654 op->env = this;
1708 op->above = 0;
1709 op->below = 0;
1710 op->x = op->y = 0;
1711 1655
1656 if (inv)
1657 inv->above = op;
1658
1659 inv = op;
1660
1661 op->flag [FLAG_REMOVED] = 0;
1662
1663 if (object *pl = op->visible_to ())
1664 esrv_send_item (pl, op);
1665
1666 adjust_weight (this, op->total_weight ());
1667
1668inserted:
1712 /* reset the light list and los of the players on the map */ 1669 /* reset the light list and los of the players on the map */
1713 if (op->glow_radius && map) 1670 if (op->glow_radius && map && map->darkness)
1714 {
1715#ifdef DEBUG_LIGHTS
1716 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1717#endif /* DEBUG_LIGHTS */
1718 if (map->darkness)
1719 update_all_los (map, x, y); 1671 update_all_los (map, x, y);
1720 }
1721 1672
1722 /* Client has no idea of ordering so lets not bother ordering it here. 1673 // if this is a player's inventory, update stats
1723 * It sure simplifies this function... 1674 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1724 */ 1675 update_stats ();
1725 if (!inv)
1726 inv = op;
1727 else
1728 {
1729 op->below = inv;
1730 op->below->above = op;
1731 inv = op;
1732 }
1733 1676
1734 INVOKE_OBJECT (INSERT, this); 1677 INVOKE_OBJECT (INSERT, this);
1735 1678
1736 return op; 1679 return op;
1737} 1680}
1865 LOG (llevError, "Present_arch called outside map.\n"); 1808 LOG (llevError, "Present_arch called outside map.\n");
1866 return NULL; 1809 return NULL;
1867 } 1810 }
1868 1811
1869 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1812 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1870 if (tmp->arch == at) 1813 if (tmp->arch->archname == at->archname)
1871 return tmp; 1814 return tmp;
1872 1815
1873 return NULL; 1816 return NULL;
1874} 1817}
1875 1818
1939 * The first matching object is returned, or NULL if none. 1882 * The first matching object is returned, or NULL if none.
1940 */ 1883 */
1941object * 1884object *
1942present_arch_in_ob (const archetype *at, const object *op) 1885present_arch_in_ob (const archetype *at, const object *op)
1943{ 1886{
1944 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1887 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1945 if (tmp->arch == at) 1888 if (tmp->arch->archname == at->archname)
1946 return tmp; 1889 return tmp;
1947 1890
1948 return NULL; 1891 return NULL;
1949} 1892}
1950 1893
2359 2302
2360/* 2303/*
2361 * create clone from object to another 2304 * create clone from object to another
2362 */ 2305 */
2363object * 2306object *
2364object_create_clone (object *asrc) 2307object::deep_clone ()
2365{ 2308{
2366 object *dst = 0, *tmp, *src, *prev, *item; 2309 assert (("deep_clone called on non-head object", is_head ()));
2367 2310
2368 if (!asrc) 2311 object *dst = clone ();
2369 return 0;
2370 2312
2371 src = asrc->head_ (); 2313 object *prev = dst;
2372
2373 prev = 0;
2374 for (object *part = src; part; part = part->more) 2314 for (object *part = this->more; part; part = part->more)
2375 { 2315 {
2376 tmp = part->clone (); 2316 object *tmp = part->clone ();
2377 tmp->x -= src->x;
2378 tmp->y -= src->y;
2379
2380 if (!part->head)
2381 {
2382 dst = tmp;
2383 tmp->head = 0;
2384 }
2385 else
2386 tmp->head = dst; 2317 tmp->head = dst;
2387
2388 tmp->more = 0;
2389
2390 if (prev)
2391 prev->more = tmp; 2318 prev->more = tmp;
2392
2393 prev = tmp; 2319 prev = tmp;
2394 } 2320 }
2395 2321
2396 for (item = src->inv; item; item = item->below) 2322 for (object *item = inv; item; item = item->below)
2397 insert_ob_in_ob (object_create_clone (item), dst); 2323 insert_ob_in_ob (item->deep_clone (), dst);
2398 2324
2399 return dst; 2325 return dst;
2400} 2326}
2401 2327
2402/* This returns the first object in who's inventory that 2328/* This returns the first object in who's inventory that
2411 return tmp; 2337 return tmp;
2412 2338
2413 return 0; 2339 return 0;
2414} 2340}
2415 2341
2416/* If ob has a field named key, return the link from the list, 2342const shstr &
2417 * otherwise return NULL. 2343object::kv_get (const shstr &key) const
2418 *
2419 * key must be a passed in shared string - otherwise, this won't
2420 * do the desired thing.
2421 */
2422key_value *
2423get_ob_key_link (const object *ob, const char *key)
2424{ 2344{
2425 for (key_value *link = ob->key_values; link; link = link->next) 2345 for (key_value *kv = key_values; kv; kv = kv->next)
2426 if (link->key == key) 2346 if (kv->key == key)
2427 return link;
2428
2429 return 0;
2430}
2431
2432/*
2433 * Returns the value of op has an extra_field for key, or NULL.
2434 *
2435 * The argument doesn't need to be a shared string.
2436 *
2437 * The returned string is shared.
2438 */
2439const char *
2440get_ob_key_value (const object *op, const char *const key)
2441{
2442 key_value *link;
2443 shstr_cmp canonical_key (key);
2444
2445 if (!canonical_key)
2446 {
2447 /* 1. There being a field named key on any object
2448 * implies there'd be a shared string to find.
2449 * 2. Since there isn't, no object has this field.
2450 * 3. Therefore, *this* object doesn't have this field.
2451 */
2452 return 0;
2453 }
2454
2455 /* This is copied from get_ob_key_link() above -
2456 * only 4 lines, and saves the function call overhead.
2457 */
2458 for (link = op->key_values; link; link = link->next)
2459 if (link->key == canonical_key)
2460 return link->value; 2347 return kv->value;
2461 2348
2462 return 0; 2349 return shstr_null;
2463} 2350}
2464 2351
2465/* 2352void
2466 * Updates the canonical_key in op to value. 2353object::kv_set (const shstr &key, const shstr &value)
2467 *
2468 * canonical_key is a shared string (value doesn't have to be).
2469 *
2470 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2471 * keys.
2472 *
2473 * Returns TRUE on success.
2474 */
2475int
2476set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2477{ 2354{
2478 key_value *field = NULL, *last = NULL; 2355 for (key_value *kv = key_values; kv; kv = kv->next)
2479 2356 if (kv->key == key)
2480 for (field = op->key_values; field != NULL; field = field->next)
2481 {
2482 if (field->key != canonical_key)
2483 { 2357 {
2484 last = field; 2358 kv->value = value;
2485 continue; 2359 return;
2486 } 2360 }
2487 2361
2488 if (value) 2362 key_value *kv = new key_value;
2489 field->value = value; 2363
2490 else 2364 kv->next = key_values;
2365 kv->key = key;
2366 kv->value = value;
2367
2368 key_values = kv;
2369}
2370
2371void
2372object::kv_del (const shstr &key)
2373{
2374 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2375 if ((*kvp)->key == key)
2491 { 2376 {
2492 /* Basically, if the archetype has this key set, 2377 key_value *kv = *kvp;
2493 * we need to store the null value so when we save 2378 *kvp = (*kvp)->next;
2494 * it, we save the empty value so that when we load, 2379 delete kv;
2495 * we get this value back again. 2380 return;
2496 */
2497 if (get_ob_key_link (op->arch, canonical_key))
2498 field->value = 0;
2499 else
2500 {
2501 if (last)
2502 last->next = field->next;
2503 else
2504 op->key_values = field->next;
2505
2506 delete field;
2507 }
2508 } 2381 }
2509 return TRUE;
2510 }
2511 /* IF we get here, key doesn't exist */
2512
2513 /* No field, we'll have to add it. */
2514
2515 if (!add_key)
2516 return FALSE;
2517
2518 /* There isn't any good reason to store a null
2519 * value in the key/value list. If the archetype has
2520 * this key, then we should also have it, so shouldn't
2521 * be here. If user wants to store empty strings,
2522 * should pass in ""
2523 */
2524 if (value == NULL)
2525 return TRUE;
2526
2527 field = new key_value;
2528
2529 field->key = canonical_key;
2530 field->value = value;
2531 /* Usual prepend-addition. */
2532 field->next = op->key_values;
2533 op->key_values = field;
2534
2535 return TRUE;
2536}
2537
2538/*
2539 * Updates the key in op to value.
2540 *
2541 * If add_key is FALSE, this will only update existing keys,
2542 * and not add new ones.
2543 * In general, should be little reason FALSE is ever passed in for add_key
2544 *
2545 * Returns TRUE on success.
2546 */
2547int
2548set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2549{
2550 shstr key_ (key);
2551
2552 return set_ob_key_value_s (op, key_, value, add_key);
2553} 2382}
2554 2383
2555object::depth_iterator::depth_iterator (object *container) 2384object::depth_iterator::depth_iterator (object *container)
2556: iterator_base (container) 2385: iterator_base (container)
2557{ 2386{
2607{ 2436{
2608 char flagdesc[512]; 2437 char flagdesc[512];
2609 char info2[256 * 4]; 2438 char info2[256 * 4];
2610 char *p = info; 2439 char *p = info;
2611 2440
2612 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2441 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2613 count, uuid.seq, 2442 count,
2443 uuid.c_str (),
2614 &name, 2444 &name,
2615 title ? "\",title:\"" : "", 2445 title ? ",title:\"" : "",
2616 title ? (const char *)title : "", 2446 title ? (const char *)title : "",
2447 title ? "\"" : "",
2617 flag_desc (flagdesc, 512), type); 2448 flag_desc (flagdesc, 512), type);
2618 2449
2619 if (!this->flag[FLAG_REMOVED] && env) 2450 if (!flag[FLAG_REMOVED] && env)
2620 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2451 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2621 2452
2622 if (map) 2453 if (map)
2623 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2454 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2624 2455
2654object::open_container (object *new_container) 2485object::open_container (object *new_container)
2655{ 2486{
2656 if (container == new_container) 2487 if (container == new_container)
2657 return; 2488 return;
2658 2489
2659 if (object *old_container = container) 2490 object *old_container = container;
2491
2492 if (old_container)
2660 { 2493 {
2661 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2494 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2662 return; 2495 return;
2663 2496
2664#if 0 2497#if 0
2666 if (object *closer = old_container->inv) 2499 if (object *closer = old_container->inv)
2667 if (closer->type == CLOSE_CON) 2500 if (closer->type == CLOSE_CON)
2668 closer->destroy (); 2501 closer->destroy ();
2669#endif 2502#endif
2670 2503
2504 // make sure the container is available
2505 esrv_send_item (this, old_container);
2506
2671 old_container->flag [FLAG_APPLIED] = 0; 2507 old_container->flag [FLAG_APPLIED] = false;
2672 container = 0; 2508 container = 0;
2673 2509
2510 // client needs item update to make it work, client bug requires this to be separate
2674 esrv_update_item (UPD_FLAGS, this, old_container); 2511 esrv_update_item (UPD_FLAGS, this, old_container);
2512
2675 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2513 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2676 play_sound (sound_find ("chest_close")); 2514 play_sound (sound_find ("chest_close"));
2677 } 2515 }
2678 2516
2679 if (new_container) 2517 if (new_container)
2692 } 2530 }
2693#endif 2531#endif
2694 2532
2695 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2533 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2696 2534
2535 // make sure the container is available, client bug requires this to be separate
2536 esrv_send_item (this, new_container);
2537
2697 new_container->flag [FLAG_APPLIED] = 1; 2538 new_container->flag [FLAG_APPLIED] = true;
2698 container = new_container; 2539 container = new_container;
2699 2540
2541 // client needs flag change
2700 esrv_update_item (UPD_FLAGS, this, new_container); 2542 esrv_update_item (UPD_FLAGS, this, new_container);
2701 esrv_send_inventory (this, new_container); 2543 esrv_send_inventory (this, new_container);
2702 play_sound (sound_find ("chest_open")); 2544 play_sound (sound_find ("chest_open"));
2703 } 2545 }
2546// else if (!old_container->env && contr && contr->ns)
2547// contr->ns->floorbox_reset ();
2704} 2548}
2705 2549
2706object * 2550object *
2707object::force_find (const shstr name) 2551object::force_find (const shstr name)
2708{ 2552{
2734 2578
2735 insert (force); 2579 insert (force);
2736} 2580}
2737 2581
2738void 2582void
2739object::play_sound (faceidx sound) const 2583object::play_sound (faceidx sound)
2740{ 2584{
2741 if (!sound) 2585 if (!sound)
2742 return; 2586 return;
2743 2587
2744 if (flag [FLAG_REMOVED]) 2588 if (flag [FLAG_REMOVED])

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines