| … | |
… | |
| 186 | || ob1->speed != ob2->speed |
186 | || ob1->speed != ob2->speed |
| 187 | || ob1->value != ob2->value |
187 | || ob1->value != ob2->value |
| 188 | || ob1->name != ob2->name) |
188 | || ob1->name != ob2->name) |
| 189 | return 0; |
189 | return 0; |
| 190 | |
190 | |
| 191 | // some objects are unmergable |
|
|
| 192 | if (!ob1->nrof || !ob2->nrof) |
|
|
| 193 | return 0; |
|
|
| 194 | |
|
|
| 195 | /* Do not merge objects if nrof would overflow. First part checks |
191 | /* Do not merge objects if nrof would overflow, assume nrof |
| 196 | * for unsigned overflow (2c), second part checks whether the result |
192 | * is always 0 .. 2**31-1 */ |
| 197 | * would fit into a 32 bit signed int, which is often used to hold |
193 | if (ob1->nrof > 0x7fffffff - ob2->nrof) |
| 198 | * nrof values. |
|
|
| 199 | */ |
|
|
| 200 | if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31)) |
|
|
| 201 | return 0; |
194 | return 0; |
| 202 | |
195 | |
| 203 | /* If the objects have been identified, set the BEEN_APPLIED flag. |
196 | /* If the objects have been identified, set the BEEN_APPLIED flag. |
| 204 | * This is to the comparison of the flags below will be OK. We |
197 | * This is to the comparison of the flags below will be OK. We |
| 205 | * just can't ignore the been applied or identified flags, as they |
198 | * just can't ignore the been applied or identified flags, as they |
| … | |
… | |
| 239 | || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) |
232 | || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) |
| 240 | return 0; |
233 | return 0; |
| 241 | |
234 | |
| 242 | if ((ob1->flag ^ ob2->flag) |
235 | if ((ob1->flag ^ ob2->flag) |
| 243 | .reset (FLAG_INV_LOCKED) |
236 | .reset (FLAG_INV_LOCKED) |
| 244 | .reset (FLAG_CLIENT_SENT) |
|
|
| 245 | .reset (FLAG_REMOVED) |
237 | .reset (FLAG_REMOVED) |
| 246 | .any ()) |
238 | .any ()) |
| 247 | return 0; |
239 | return 0; |
| 248 | |
240 | |
| 249 | /* This is really a spellbook check - we should in general |
241 | /* This is really a spellbook check - we should in general |
| … | |
… | |
| 349 | else |
341 | else |
| 350 | { |
342 | { |
| 351 | // maybe there is a player standing on the same mapspace |
343 | // maybe there is a player standing on the same mapspace |
| 352 | // this will catch the case where "this" is a player |
344 | // this will catch the case where "this" is a player |
| 353 | if (object *pl = ms ().player ()) |
345 | if (object *pl = ms ().player ()) |
|
|
346 | if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look) |
| 354 | if (!pl->container || this == pl->container) |
347 | || this == pl->container) |
| 355 | return pl; |
348 | return pl; |
| 356 | } |
349 | } |
| 357 | } |
350 | } |
| 358 | |
351 | |
| 359 | return 0; |
352 | return 0; |
| … | |
… | |
| 773 | || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) |
766 | || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) |
| 774 | || (m.move_on | op->move_on ) != m.move_on |
767 | || (m.move_on | op->move_on ) != m.move_on |
| 775 | || (m.move_off | op->move_off ) != m.move_off |
768 | || (m.move_off | op->move_off ) != m.move_off |
| 776 | || (m.move_slow | op->move_slow) != m.move_slow |
769 | || (m.move_slow | op->move_slow) != m.move_slow |
| 777 | /* This isn't perfect, but I don't expect a lot of objects to |
770 | /* This isn't perfect, but I don't expect a lot of objects to |
| 778 | * to have move_allow right now. |
771 | * have move_allow right now. |
| 779 | */ |
772 | */ |
| 780 | || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block |
773 | || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block |
| 781 | || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) |
774 | || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) |
| 782 | m.flags_ = 0; |
775 | m.flags_ = 0; |
| 783 | } |
776 | } |
| … | |
… | |
| 913 | || map->in_memory != MAP_ACTIVE |
906 | || map->in_memory != MAP_ACTIVE |
| 914 | || map->no_drop |
907 | || map->no_drop |
| 915 | || ms ().move_block == MOVE_ALL) |
908 | || ms ().move_block == MOVE_ALL) |
| 916 | { |
909 | { |
| 917 | while (inv) |
910 | while (inv) |
| 918 | { |
|
|
| 919 | inv->destroy_inv (false); |
|
|
| 920 | inv->destroy (); |
911 | inv->destroy (true); |
| 921 | } |
|
|
| 922 | } |
912 | } |
| 923 | else |
913 | else |
| 924 | { /* Put objects in inventory onto this space */ |
914 | { /* Put objects in inventory onto this space */ |
| 925 | while (inv) |
915 | while (inv) |
| 926 | { |
916 | { |
| … | |
… | |
| 1121 | *(below ? &below->above : &ms.bot) = above; |
1111 | *(below ? &below->above : &ms.bot) = above; |
| 1122 | |
1112 | |
| 1123 | above = 0; |
1113 | above = 0; |
| 1124 | below = 0; |
1114 | below = 0; |
| 1125 | |
1115 | |
|
|
1116 | ms.flags_ = 0; |
|
|
1117 | |
| 1126 | if (map->in_memory == MAP_SAVING) |
1118 | if (map->in_memory == MAP_SAVING) |
| 1127 | return; |
1119 | return; |
| 1128 | |
1120 | |
| 1129 | int check_walk_off = !flag [FLAG_NO_APPLY]; |
1121 | int check_walk_off = !flag [FLAG_NO_APPLY]; |
| 1130 | |
1122 | |
| … | |
… | |
| 1161 | LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); |
1153 | LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); |
| 1162 | } |
1154 | } |
| 1163 | |
1155 | |
| 1164 | last = tmp; |
1156 | last = tmp; |
| 1165 | } |
1157 | } |
| 1166 | |
|
|
| 1167 | /* last == NULL if there are no objects on this space */ |
|
|
| 1168 | //TODO: this makes little sense, why only update the topmost object? |
|
|
| 1169 | if (!last) |
|
|
| 1170 | map->at (x, y).flags_ = 0; |
|
|
| 1171 | else |
|
|
| 1172 | update_object (last, UP_OBJ_REMOVE); |
|
|
| 1173 | |
1158 | |
| 1174 | if (flag [FLAG_BLOCKSVIEW] || glow_radius) |
1159 | if (flag [FLAG_BLOCKSVIEW] || glow_radius) |
| 1175 | update_all_los (map, x, y); |
1160 | update_all_los (map, x, y); |
| 1176 | } |
1161 | } |
| 1177 | } |
1162 | } |
| … | |
… | |
| 1541 | if (!nr) |
1526 | if (!nr) |
| 1542 | return true; |
1527 | return true; |
| 1543 | |
1528 | |
| 1544 | nr = min (nr, nrof); |
1529 | nr = min (nr, nrof); |
| 1545 | |
1530 | |
|
|
1531 | if (nrof > nr) |
|
|
1532 | { |
| 1546 | nrof -= nr; |
1533 | nrof -= nr; |
| 1547 | |
|
|
| 1548 | if (nrof) |
|
|
| 1549 | { |
|
|
| 1550 | adjust_weight (env, -weight * nr); // carrying == 0 |
1534 | adjust_weight (env, -weight * max (1, nr)); // carrying == 0 |
| 1551 | |
1535 | |
| 1552 | if (object *pl = visible_to ()) |
1536 | if (object *pl = visible_to ()) |
| 1553 | esrv_update_item (UPD_NROF, pl, this); |
1537 | esrv_update_item (UPD_NROF, pl, this); |
| 1554 | |
1538 | |
| 1555 | return true; |
1539 | return true; |
| 1556 | } |
1540 | } |
| 1557 | else |
1541 | else |
| 1558 | { |
1542 | { |
| 1559 | destroy (1); |
1543 | destroy (); |
| 1560 | return false; |
1544 | return false; |
| 1561 | } |
1545 | } |
| 1562 | } |
1546 | } |
| 1563 | |
1547 | |
| 1564 | /* |
1548 | /* |
