ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.255 by root, Sun Aug 31 02:01:41 2008 UTC vs.
Revision 1.296 by root, Fri Nov 6 13:31:47 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 52 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 56};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
60 0, 58 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
62};
63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64}; 69};
65 70
66static void 71static void
67write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
68{ 73{
323 { 328 {
324 // see if we are in a container of sorts 329 // see if we are in a container of sorts
325 if (env) 330 if (env)
326 { 331 {
327 // the player inventory itself is always visible 332 // the player inventory itself is always visible
328 if (env->type == PLAYER) 333 if (env->is_player ())
329 return env; 334 return env;
330 335
331 // else a player could have our env open 336 // else a player could have our env open
332 object *envest = env->outer_env (); 337 object *envest = env->outer_env_or_self ();
333 338
334 // the player itself is always on a map, so we will find him here 339 // the player itself is always on a map, so we will find him here
335 // even if our inv is in a player. 340 // even if our inv is in a player.
336 if (envest->is_on_map ()) 341 if (envest->is_on_map ())
337 if (object *pl = envest->ms ().player ()) 342 if (object *pl = envest->ms ().player ())
338 if (pl->container == env) 343 if (pl->container_ () == env)
339 return pl; 344 return pl;
340 } 345 }
341 else 346 else
342 { 347 {
343 // maybe there is a player standing on the same mapspace 348 // maybe there is a player standing on the same mapspace
344 // this will catch the case where "this" is a player 349 // this will catch the case where "this" is a player
345 if (object *pl = ms ().player ()) 350 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look) 351 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
347 || this == pl->container) 352 || pl->container_ () == this)
348 return pl; 353 return pl;
349 } 354 }
350 } 355 }
351 356
352 return 0; 357 return 0;
430 object_freezer freezer; 435 object_freezer freezer;
431 op->write (freezer); 436 op->write (freezer);
432 return freezer.as_string (); 437 return freezer.as_string ();
433} 438}
434 439
435/* 440char *
436 * get_nearest_part(multi-object, object 2) returns the part of the 441object::as_string ()
437 * multi-object 1 which is closest to the second object.
438 * If it's not a multi-object, it is returned.
439 */
440object *
441get_nearest_part (object *op, const object *pl)
442{ 442{
443 object *tmp, *closest; 443 return dump_object (this);
444 int last_dist, i;
445
446 if (!op->more)
447 return op;
448
449 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
450 tmp;
451 tmp = tmp->more)
452 if ((i = distance (tmp, pl)) < last_dist)
453 closest = tmp, last_dist = i;
454
455 return closest;
456} 444}
457 445
458/* 446/*
459 * Returns the object which has the count-variable equal to the argument. 447 * Returns the object which has the count-variable equal to the argument.
460 * VERRRY slow. 448 * VERRRY slow.
554 update_stats (); 542 update_stats ();
555 543
556 new_draw_info_format (NDI_UNIQUE, 0, this, 544 new_draw_info_format (NDI_UNIQUE, 0, this,
557 "You try to balance all your items at once, " 545 "You try to balance all your items at once, "
558 "but the %s is just too much for your body. " 546 "but the %s is just too much for your body. "
559 "[You need to unapply some items first.]", &ob->name); 547 "[You need to unapply some items first - use the 'body' command to see "
548 "how many items you cna wera on a specific body part.]", &ob->name);
560 return false; 549 return false;
561 } 550 }
562 551
563 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 552 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
564 } 553 }
636 } 625 }
637 626
638 if (speed < 0) 627 if (speed < 0)
639 dst->speed_left -= rndm (); 628 dst->speed_left -= rndm ();
640 629
641 dst->set_speed (dst->speed); 630 dst->activate ();
642} 631}
643 632
644void 633void
645object::instantiate () 634object::instantiate ()
646{ 635{
758 else if (action == UP_OBJ_INSERT) 747 else if (action == UP_OBJ_INSERT)
759 { 748 {
760 // this is likely overkill, TODO: revisit (schmorp) 749 // this is likely overkill, TODO: revisit (schmorp)
761 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 750 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
762 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 751 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
763 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 752 || (op->is_player () && !(m.flags_ & P_PLAYER))
764 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 753 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
765 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 754 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 755 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
767 || (m.move_on | op->move_on ) != m.move_on 756 || (m.move_on | op->move_on ) != m.move_on
768 || (m.move_off | op->move_off ) != m.move_off 757 || (m.move_off | op->move_off ) != m.move_off
770 /* This isn't perfect, but I don't expect a lot of objects to 759 /* This isn't perfect, but I don't expect a lot of objects to
771 * have move_allow right now. 760 * have move_allow right now.
772 */ 761 */
773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 762 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 763 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
775 m.flags_ = 0; 764 m.invalidate ();
776 } 765 }
777 /* if the object is being removed, we can't make intelligent 766 /* if the object is being removed, we can't make intelligent
778 * decisions, because remove_ob can't really pass the object 767 * decisions, because remove_ob can't really pass the object
779 * that is being removed. 768 * that is being removed.
780 */ 769 */
781 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 770 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
782 m.flags_ = 0; 771 m.invalidate ();
783 else if (action == UP_OBJ_FACE) 772 else if (action == UP_OBJ_FACE)
784 /* Nothing to do for that case */ ; 773 /* Nothing to do for that case */ ;
785 else 774 else
786 LOG (llevError, "update_object called with invalid action: %d\n", action); 775 LOG (llevError, "update_object called with invalid action: %d\n", action);
787 776
791 780
792object::object () 781object::object ()
793{ 782{
794 SET_FLAG (this, FLAG_REMOVED); 783 SET_FLAG (this, FLAG_REMOVED);
795 784
796 expmul = 1.0; 785 //expmul = 1.0; declared const for the time being
797 face = blank_face; 786 face = blank_face;
798} 787}
799 788
800object::~object () 789object::~object ()
801{ 790{
831 /* If already on active list, don't do anything */ 820 /* If already on active list, don't do anything */
832 if (active) 821 if (active)
833 return; 822 return;
834 823
835 if (has_active_speed ()) 824 if (has_active_speed ())
825 {
826 if (flag [FLAG_FREED])
827 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
828
836 actives.insert (this); 829 actives.insert (this);
830 }
837} 831}
838 832
839void 833void
840object::activate_recursive () 834object::activate_recursive ()
841{ 835{
906 || map->in_memory != MAP_ACTIVE 900 || map->in_memory != MAP_ACTIVE
907 || map->no_drop 901 || map->no_drop
908 || ms ().move_block == MOVE_ALL) 902 || ms ().move_block == MOVE_ALL)
909 { 903 {
910 while (inv) 904 while (inv)
911 inv->destroy (true); 905 inv->destroy ();
912 } 906 }
913 else 907 else
914 { /* Put objects in inventory onto this space */ 908 { /* Put objects in inventory onto this space */
915 while (inv) 909 while (inv)
916 { 910 {
920 || op->flag [FLAG_NO_DROP] 914 || op->flag [FLAG_NO_DROP]
921 || op->type == RUNE 915 || op->type == RUNE
922 || op->type == TRAP 916 || op->type == TRAP
923 || op->flag [FLAG_IS_A_TEMPLATE] 917 || op->flag [FLAG_IS_A_TEMPLATE]
924 || op->flag [FLAG_DESTROY_ON_DEATH]) 918 || op->flag [FLAG_DESTROY_ON_DEATH])
925 op->destroy (true); 919 op->destroy ();
926 else 920 else
927 map->insert (op, x, y); 921 map->insert (op, x, y);
928 } 922 }
929 } 923 }
930} 924}
959 953
960void 954void
961object::do_destroy () 955object::do_destroy ()
962{ 956{
963 if (flag [FLAG_IS_LINKED]) 957 if (flag [FLAG_IS_LINKED])
964 remove_button_link (this); 958 remove_link ();
965 959
966 if (flag [FLAG_FRIENDLY]) 960 if (flag [FLAG_FRIENDLY])
967 remove_friendly_object (this); 961 remove_friendly_object (this);
968 962
969 remove (); 963 remove ();
994 attacked_by = 0; 988 attacked_by = 0;
995 current_weapon = 0; 989 current_weapon = 0;
996} 990}
997 991
998void 992void
999object::destroy (bool destroy_inventory) 993object::destroy ()
1000{ 994{
1001 if (destroyed ()) 995 if (destroyed ())
1002 return; 996 return;
1003 997
1004 if (!is_head () && !head->destroyed ()) 998 if (!is_head () && !head->destroyed ())
1005 { 999 {
1006 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1000 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1007 head->destroy (destroy_inventory); 1001 head->destroy ();
1008 return; 1002 return;
1009 } 1003 }
1010 1004
1011 destroy_inv (!destroy_inventory); 1005 destroy_inv (false);
1012 1006
1013 if (is_head ()) 1007 if (is_head ())
1014 if (sound_destroy) 1008 if (sound_destroy)
1015 play_sound (sound_destroy); 1009 play_sound (sound_destroy);
1016 else if (flag [FLAG_MONSTER]) 1010 else if (flag [FLAG_MONSTER])
1027 * the previous environment. 1021 * the previous environment.
1028 */ 1022 */
1029void 1023void
1030object::do_remove () 1024object::do_remove ()
1031{ 1025{
1032 object *tmp, *last = 0;
1033 object *otmp;
1034
1035 if (flag [FLAG_REMOVED]) 1026 if (flag [FLAG_REMOVED])
1036 return; 1027 return;
1037 1028
1038 INVOKE_OBJECT (REMOVE, this); 1029 INVOKE_OBJECT (REMOVE, this);
1039 1030
1052 if (object *pl = visible_to ()) 1043 if (object *pl = visible_to ())
1053 esrv_del_item (pl->contr, count); 1044 esrv_del_item (pl->contr, count);
1054 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1045 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1055 1046
1056 adjust_weight (env, -total_weight ()); 1047 adjust_weight (env, -total_weight ());
1048
1049 object *pl = in_player ();
1057 1050
1058 /* we set up values so that it could be inserted into 1051 /* we set up values so that it could be inserted into
1059 * the map, but we don't actually do that - it is up 1052 * the map, but we don't actually do that - it is up
1060 * to the caller to decide what we want to do. 1053 * to the caller to decide what we want to do.
1061 */ 1054 */
1073 1066
1074 /* NO_FIX_PLAYER is set when a great many changes are being 1067 /* NO_FIX_PLAYER is set when a great many changes are being
1075 * made to players inventory. If set, avoiding the call 1068 * made to players inventory. If set, avoiding the call
1076 * to save cpu time. 1069 * to save cpu time.
1077 */ 1070 */
1078 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1071 if (pl)
1072 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1073 {
1079 otmp->update_stats (); 1074 pl->update_stats ();
1075
1076 if (glow_radius && pl->is_on_map ())
1077 update_all_los (pl->map, pl->x, pl->y);
1078 }
1080 } 1079 }
1081 else if (map) 1080 else if (map)
1082 { 1081 {
1083 map->dirty = true; 1082 map->dirty = true;
1084 mapspace &ms = this->ms (); 1083 mapspace &ms = this->ms ();
1085 1084
1086 if (object *pl = ms.player ()) 1085 if (object *pl = ms.player ())
1087 { 1086 {
1088 if (type == PLAYER) // this == pl(!) 1087 if (is_player ())
1089 { 1088 {
1089 if (!flag [FLAG_WIZPASS])
1090 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1091
1090 // leaving a spot always closes any open container on the ground 1092 // leaving a spot always closes any open container on the ground
1091 if (container && !container->env) 1093 if (container && !container->env)
1092 // this causes spurious floorbox updates, but it ensures 1094 // this causes spurious floorbox updates, but it ensures
1093 // that the CLOSE event is being sent. 1095 // that the CLOSE event is being sent.
1094 close_container (); 1096 close_container ();
1095 1097
1096 --map->players; 1098 --map->players;
1097 map->touch (); 1099 map->touch ();
1098 } 1100 }
1099 else if (pl->container == this) 1101 else if (pl->container_ () == this)
1100 { 1102 {
1101 // removing a container should close it 1103 // removing a container should close it
1102 close_container (); 1104 close_container ();
1103 } 1105 }
1104 1106
1111 *(below ? &below->above : &ms.bot) = above; 1113 *(below ? &below->above : &ms.bot) = above;
1112 1114
1113 above = 0; 1115 above = 0;
1114 below = 0; 1116 below = 0;
1115 1117
1116 ms.flags_ = 0; 1118 ms.invalidate ();
1117 1119
1118 if (map->in_memory == MAP_SAVING) 1120 if (map->in_memory == MAP_SAVING)
1119 return; 1121 return;
1120 1122
1121 int check_walk_off = !flag [FLAG_NO_APPLY]; 1123 int check_walk_off = !flag [FLAG_NO_APPLY];
1122 1124
1123 if (object *pl = ms.player ()) 1125 if (object *pl = ms.player ())
1124 { 1126 {
1125 if (pl->container == this) 1127 if (pl->container_ () == this)
1126 /* If a container that the player is currently using somehow gets 1128 /* If a container that the player is currently using somehow gets
1127 * removed (most likely destroyed), update the player view 1129 * removed (most likely destroyed), update the player view
1128 * appropriately. 1130 * appropriately.
1129 */ 1131 */
1130 pl->close_container (); 1132 pl->close_container ();
1134 //TODO: update floorbox to preserve ordering 1136 //TODO: update floorbox to preserve ordering
1135 if (pl->contr->ns) 1137 if (pl->contr->ns)
1136 pl->contr->ns->floorbox_update (); 1138 pl->contr->ns->floorbox_update ();
1137 } 1139 }
1138 1140
1141 if (check_walk_off)
1139 for (tmp = ms.bot; tmp; tmp = tmp->above) 1142 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1140 { 1143 {
1144 above = tmp->above;
1145
1141 /* No point updating the players look faces if he is the object 1146 /* No point updating the players look faces if he is the object
1142 * being removed. 1147 * being removed.
1143 */ 1148 */
1144 1149
1145 /* See if object moving off should effect something */ 1150 /* See if object moving off should effect something */
1146 if (check_walk_off
1147 && ((move_type & tmp->move_off) 1151 if ((move_type & tmp->move_off)
1148 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1152 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1149 {
1150 move_apply (tmp, this, 0); 1153 move_apply (tmp, this, 0);
1151
1152 if (destroyed ())
1153 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1154 } 1154 }
1155 1155
1156 last = tmp; 1156 if (affects_los ())
1157 }
1158
1159 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1160 update_all_los (map, x, y); 1157 update_all_los (map, x, y);
1161 } 1158 }
1162} 1159}
1163 1160
1164/* 1161/*
1188 esrv_update_item (UPD_NROF, pl, top); 1185 esrv_update_item (UPD_NROF, pl, top);
1189 1186
1190 op->weight = 0; // cancel the addition above 1187 op->weight = 0; // cancel the addition above
1191 op->carrying = 0; // must be 0 already 1188 op->carrying = 0; // must be 0 already
1192 1189
1193 op->destroy (1); 1190 op->destroy ();
1194 1191
1195 return top; 1192 return top;
1196 } 1193 }
1197 1194
1198 return 0; 1195 return 0;
1260 * just 'op' otherwise 1257 * just 'op' otherwise
1261 */ 1258 */
1262object * 1259object *
1263insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1260insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1264{ 1261{
1265 if (op->is_on_map ())
1266 {
1267 LOG (llevError, "insert_ob_in_map called for object already on map");
1268 abort ();
1269 }
1270
1271 if (op->env)
1272 {
1273 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1274 op->remove (); 1262 op->remove ();
1275 }
1276 1263
1277 if (op->face && !face_info (op->face))//D TODO: remove soon 1264 if (m == &freed_map)//D TODO: remove soon
1278 {//D 1265 {//D
1279 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D 1266 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1280 op->face = 1;//D
1281 }//D 1267 }//D
1282 1268
1283 /* Ideally, the caller figures this out. However, it complicates a lot 1269 /* Ideally, the caller figures this out. However, it complicates a lot
1284 * of areas of callers (eg, anything that uses find_free_spot would now 1270 * of areas of callers (eg, anything that uses find_free_spot would now
1285 * need extra work 1271 * need extra work
1286 */ 1272 */
1273 maptile *newmap = m;
1287 if (!xy_normalise (m, op->x, op->y)) 1274 if (!xy_normalise (newmap, op->x, op->y))
1288 { 1275 {
1289 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found 1276 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1290 return 0; 1277 return 0;
1291 } 1278 }
1292 1279
1293 if (object *more = op->more) 1280 if (object *more = op->more)
1294 if (!insert_ob_in_map (more, m, originator, flag)) 1281 if (!insert_ob_in_map (more, m, originator, flag))
1295 return 0; 1282 return 0;
1296 1283
1297 CLEAR_FLAG (op, FLAG_REMOVED); 1284 op->flag [FLAG_REMOVED] = false;
1298 1285 op->env = 0;
1299 op->map = m; 1286 op->map = newmap;
1287
1300 mapspace &ms = op->ms (); 1288 mapspace &ms = op->ms ();
1301 1289
1302 /* this has to be done after we translate the coordinates. 1290 /* this has to be done after we translate the coordinates.
1303 */ 1291 */
1304 if (op->nrof && !(flag & INS_NO_MERGE)) 1292 if (op->nrof && !(flag & INS_NO_MERGE))
1307 { 1295 {
1308 // TODO: we actually want to update tmp, not op, 1296 // TODO: we actually want to update tmp, not op,
1309 // but some caller surely breaks when we return tmp 1297 // but some caller surely breaks when we return tmp
1310 // from here :/ 1298 // from here :/
1311 op->nrof += tmp->nrof; 1299 op->nrof += tmp->nrof;
1312 tmp->destroy (1); 1300 tmp->destroy ();
1313 } 1301 }
1314 1302
1315 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1303 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1316 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1304 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1317 1305
1325 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1313 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1326 abort (); 1314 abort ();
1327 } 1315 }
1328 1316
1329 if (!originator->is_on_map ()) 1317 if (!originator->is_on_map ())
1318 {
1330 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map", 1319 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1331 op->debug_desc (), originator->debug_desc ()); 1320 op->debug_desc (), originator->debug_desc ());
1321 abort ();
1322 }
1332 1323
1333 op->above = originator; 1324 op->above = originator;
1334 op->below = originator->below; 1325 op->below = originator->below;
1335 originator->below = op; 1326 originator->below = op;
1336 1327
1422 op->below = top; 1413 op->below = top;
1423 *(op->above ? &op->above->below : &ms.top) = op; 1414 *(op->above ? &op->above->below : &ms.top) = op;
1424 } 1415 }
1425 } 1416 }
1426 1417
1427 if (op->type == PLAYER) 1418 if (op->is_player ())
1428 { 1419 {
1429 op->contr->do_los = 1; 1420 op->contr->do_los = 1;
1430 ++op->map->players; 1421 ++op->map->players;
1431 op->map->touch (); 1422 op->map->touch ();
1432 } 1423 }
1447 * be far away from this change and not affected in any way - 1438 * be far away from this change and not affected in any way -
1448 * this should get redone to only look for players within range, 1439 * this should get redone to only look for players within range,
1449 * or just updating the P_UPTODATE for spaces within this area 1440 * or just updating the P_UPTODATE for spaces within this area
1450 * of effect may be sufficient. 1441 * of effect may be sufficient.
1451 */ 1442 */
1452 if (op->map->darkness && (op->glow_radius != 0)) 1443 if (op->affects_los ())
1444 {
1445 op->ms ().invalidate ();
1453 update_all_los (op->map, op->x, op->y); 1446 update_all_los (op->map, op->x, op->y);
1447 }
1454 1448
1455 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1449 /* updates flags (blocked, alive, no magic, etc) for this map space */
1456 update_object (op, UP_OBJ_INSERT); 1450 update_object (op, UP_OBJ_INSERT);
1457 1451
1458 INVOKE_OBJECT (INSERT, op); 1452 INVOKE_OBJECT (INSERT, op);
1465 * blocked() and wall() work properly), and these flags are updated by 1459 * blocked() and wall() work properly), and these flags are updated by
1466 * update_object(). 1460 * update_object().
1467 */ 1461 */
1468 1462
1469 /* if this is not the head or flag has been passed, don't check walk on status */ 1463 /* if this is not the head or flag has been passed, don't check walk on status */
1470 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1464 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1471 { 1465 {
1472 if (check_move_on (op, originator)) 1466 if (check_move_on (op, originator))
1473 return 0; 1467 return 0;
1474 1468
1475 /* If we are a multi part object, lets work our way through the check 1469 /* If we are a multi part object, lets work our way through the check
1486/* this function inserts an object in the map, but if it 1480/* this function inserts an object in the map, but if it
1487 * finds an object of its own type, it'll remove that one first. 1481 * finds an object of its own type, it'll remove that one first.
1488 * op is the object to insert it under: supplies x and the map. 1482 * op is the object to insert it under: supplies x and the map.
1489 */ 1483 */
1490void 1484void
1491replace_insert_ob_in_map (const char *arch_string, object *op) 1485replace_insert_ob_in_map (shstr_tmp archname, object *op)
1492{ 1486{
1493 /* first search for itself and remove any old instances */ 1487 /* first search for itself and remove any old instances */
1494 1488
1495 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1489 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1496 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1490 if (tmp->arch->archname == archname) /* same archetype */
1497 tmp->destroy (1); 1491 tmp->destroy ();
1498 1492
1499 object *tmp = arch_to_object (archetype::find (arch_string)); 1493 object *tmp = arch_to_object (archetype::find (archname));
1500 1494
1501 tmp->x = op->x; 1495 tmp->x = op->x;
1502 tmp->y = op->y; 1496 tmp->y = op->y;
1503 1497
1504 insert_ob_in_map (tmp, op->map, op, 0); 1498 insert_ob_in_map (tmp, op->map, op, 0);
1625 if (object *pl = tmp->visible_to ()) 1619 if (object *pl = tmp->visible_to ())
1626 esrv_update_item (UPD_NROF, pl, tmp); 1620 esrv_update_item (UPD_NROF, pl, tmp);
1627 1621
1628 adjust_weight (this, op->total_weight ()); 1622 adjust_weight (this, op->total_weight ());
1629 1623
1630 op->destroy (1); 1624 op->destroy ();
1631 op = tmp; 1625 op = tmp;
1632 goto inserted; 1626 goto inserted;
1633 } 1627 }
1634 1628
1635 op->owner = 0; // it's his/hers now. period. 1629 op->owner = 0; // it's his/hers now. period.
1653 1647
1654 adjust_weight (this, op->total_weight ()); 1648 adjust_weight (this, op->total_weight ());
1655 1649
1656inserted: 1650inserted:
1657 /* reset the light list and los of the players on the map */ 1651 /* reset the light list and los of the players on the map */
1658 if (op->glow_radius && map && map->darkness) 1652 if (op->glow_radius && is_on_map ())
1653 {
1654 update_stats ();
1659 update_all_los (map, x, y); 1655 update_all_los (map, x, y);
1660 1656 }
1657 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1661 // if this is a player's inventory, update stats 1658 // if this is a player's inventory, update stats
1662 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1663 update_stats (); 1659 update_stats ();
1664 1660
1665 INVOKE_OBJECT (INSERT, this); 1661 INVOKE_OBJECT (INSERT, this);
1666 1662
1667 return op; 1663 return op;
1688 * on top. 1684 * on top.
1689 */ 1685 */
1690int 1686int
1691check_move_on (object *op, object *originator) 1687check_move_on (object *op, object *originator)
1692{ 1688{
1689 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1690 return 0;
1691
1693 object *tmp; 1692 object *tmp;
1694 maptile *m = op->map; 1693 maptile *m = op->map;
1695 int x = op->x, y = op->y; 1694 int x = op->x, y = op->y;
1696 1695
1697 MoveType move_on, move_slow, move_block; 1696 mapspace &ms = m->at (x, y);
1698 1697
1699 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1698 ms.update ();
1700 return 0;
1701 1699
1702 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1700 MoveType move_on = ms.move_on;
1703 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1701 MoveType move_slow = ms.move_slow;
1704 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1702 MoveType move_block = ms.move_block;
1705 1703
1706 /* if nothing on this space will slow op down or be applied, 1704 /* if nothing on this space will slow op down or be applied,
1707 * no need to do checking below. have to make sure move_type 1705 * no need to do checking below. have to make sure move_type
1708 * is set, as lots of objects don't have it set - we treat that 1706 * is set, as lots of objects don't have it set - we treat that
1709 * as walking. 1707 * as walking.
1720 return 0; 1718 return 0;
1721 1719
1722 /* The objects have to be checked from top to bottom. 1720 /* The objects have to be checked from top to bottom.
1723 * Hence, we first go to the top: 1721 * Hence, we first go to the top:
1724 */ 1722 */
1725 1723 for (object *next, *tmp = ms.top; tmp; tmp = next)
1726 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1727 {
1728 /* Trim the search when we find the first other spell effect
1729 * this helps performance so that if a space has 50 spell objects,
1730 * we don't need to check all of them.
1731 */
1732 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1733 break;
1734 } 1724 {
1725 next = tmp->below;
1735 1726
1736 for (; tmp; tmp = tmp->below)
1737 {
1738 if (tmp == op) 1727 if (tmp == op)
1739 continue; /* Can't apply yourself */ 1728 continue; /* Can't apply yourself */
1740 1729
1741 /* Check to see if one of the movement types should be slowed down. 1730 /* Check to see if one of the movement types should be slowed down.
1742 * Second check makes sure that the movement types not being slowed 1731 * Second check makes sure that the movement types not being slowed
1747 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1736 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1748 { 1737 {
1749 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1738 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1750 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1739 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1751 { 1740 {
1752
1753 float
1754 diff = tmp->move_slow_penalty * fabs (op->speed); 1741 float diff = tmp->move_slow_penalty * fabs (op->speed);
1755 1742
1756 if (op->type == PLAYER) 1743 if (op->is_player ())
1757 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1744 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1758 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1745 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1759 diff /= 4.0; 1746 diff /= 4.0;
1760 1747
1761 op->speed_left -= diff; 1748 op->speed_left -= diff;
1762 } 1749 }
1763 } 1750 }
1969 * head of the object should correspond for the entire object. 1956 * head of the object should correspond for the entire object.
1970 */ 1957 */
1971 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1958 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1972 continue; 1959 continue;
1973 1960
1974 if (ob->blocked (m, pos.x, pos.y)) 1961 if (ob->blocked (pos.m, pos.x, pos.y))
1975 continue; 1962 continue;
1976 1963
1977 altern [index++] = i; 1964 altern [index++] = i;
1978 } 1965 }
1979 1966
2047 * there is capable of. 2034 * there is capable of.
2048 */ 2035 */
2049int 2036int
2050find_dir (maptile *m, int x, int y, object *exclude) 2037find_dir (maptile *m, int x, int y, object *exclude)
2051{ 2038{
2052 int i, max = SIZEOFFREE, mflags; 2039 int max = SIZEOFFREE, mflags;
2053
2054 sint16 nx, ny;
2055 object *tmp;
2056 maptile *mp;
2057
2058 MoveType blocked, move_type; 2040 MoveType move_type;
2059 2041
2060 if (exclude && exclude->head_ () != exclude) 2042 if (exclude && exclude->head_ () != exclude)
2061 { 2043 {
2062 exclude = exclude->head; 2044 exclude = exclude->head;
2063 move_type = exclude->move_type; 2045 move_type = exclude->move_type;
2066 { 2048 {
2067 /* If we don't have anything, presume it can use all movement types. */ 2049 /* If we don't have anything, presume it can use all movement types. */
2068 move_type = MOVE_ALL; 2050 move_type = MOVE_ALL;
2069 } 2051 }
2070 2052
2071 for (i = 1; i < max; i++) 2053 for (int i = 1; i < max; i++)
2072 { 2054 {
2073 mp = m; 2055 mapxy pos (m, x, y);
2074 nx = x + freearr_x[i]; 2056 pos.move (i);
2075 ny = y + freearr_y[i];
2076 2057
2077 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2058 if (!pos.normalise ())
2078
2079 if (mflags & P_OUT_OF_MAP)
2080 max = maxfree[i]; 2059 max = maxfree[i];
2081 else 2060 else
2082 { 2061 {
2083 mapspace &ms = mp->at (nx, ny); 2062 mapspace &ms = *pos;
2084 2063
2085 blocked = ms.move_block;
2086
2087 if ((move_type & blocked) == move_type) 2064 if ((move_type & ms.move_block) == move_type)
2088 max = maxfree[i]; 2065 max = maxfree [i];
2089 else if (mflags & P_IS_ALIVE) 2066 else if (ms.flags () & P_IS_ALIVE)
2090 { 2067 {
2091 for (tmp = ms.bot; tmp; tmp = tmp->above) 2068 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2092 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2069 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2093 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2070 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2094 break;
2095
2096 if (tmp)
2097 return freedir[i]; 2071 return freedir [i];
2098 } 2072 }
2099 } 2073 }
2100 } 2074 }
2101 2075
2102 return 0; 2076 return 0;
2177 * This basically means that if direction is 15, then it could either go 2151 * This basically means that if direction is 15, then it could either go
2178 * direction 4, 14, or 16 to get back to where we are. 2152 * direction 4, 14, or 16 to get back to where we are.
2179 * Moved from spell_util.c to object.c with the other related direction 2153 * Moved from spell_util.c to object.c with the other related direction
2180 * functions. 2154 * functions.
2181 */ 2155 */
2182int reduction_dir[SIZEOFFREE][3] = { 2156static const int reduction_dir[SIZEOFFREE][3] = {
2183 {0, 0, 0}, /* 0 */ 2157 {0, 0, 0}, /* 0 */
2184 {0, 0, 0}, /* 1 */ 2158 {0, 0, 0}, /* 1 */
2185 {0, 0, 0}, /* 2 */ 2159 {0, 0, 0}, /* 2 */
2186 {0, 0, 0}, /* 3 */ 2160 {0, 0, 0}, /* 3 */
2187 {0, 0, 0}, /* 4 */ 2161 {0, 0, 0}, /* 4 */
2283int 2257int
2284can_pick (const object *who, const object *item) 2258can_pick (const object *who, const object *item)
2285{ 2259{
2286 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2260 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2287 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2261 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2288 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2262 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2289} 2263}
2290 2264
2291/* 2265/*
2292 * create clone from object to another 2266 * create clone from object to another
2293 */ 2267 */
2325 return tmp; 2299 return tmp;
2326 2300
2327 return 0; 2301 return 0;
2328} 2302}
2329 2303
2330const shstr & 2304shstr_tmp
2331object::kv_get (const shstr &key) const 2305object::kv_get (shstr_tmp key) const
2332{ 2306{
2333 for (key_value *kv = key_values; kv; kv = kv->next) 2307 for (key_value *kv = key_values; kv; kv = kv->next)
2334 if (kv->key == key) 2308 if (kv->key == key)
2335 return kv->value; 2309 return kv->value;
2336 2310
2337 return shstr_null; 2311 return shstr ();
2338} 2312}
2339 2313
2340void 2314void
2341object::kv_set (const shstr &key, const shstr &value) 2315object::kv_set (shstr_tmp key, shstr_tmp value)
2342{ 2316{
2343 for (key_value *kv = key_values; kv; kv = kv->next) 2317 for (key_value *kv = key_values; kv; kv = kv->next)
2344 if (kv->key == key) 2318 if (kv->key == key)
2345 { 2319 {
2346 kv->value = value; 2320 kv->value = value;
2355 2329
2356 key_values = kv; 2330 key_values = kv;
2357} 2331}
2358 2332
2359void 2333void
2360object::kv_del (const shstr &key) 2334object::kv_del (shstr_tmp key)
2361{ 2335{
2362 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2336 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2363 if ((*kvp)->key == key) 2337 if ((*kvp)->key == key)
2364 { 2338 {
2365 key_value *kv = *kvp; 2339 key_value *kv = *kvp;
2496 container = 0; 2470 container = 0;
2497 2471
2498 // client needs item update to make it work, client bug requires this to be separate 2472 // client needs item update to make it work, client bug requires this to be separate
2499 esrv_update_item (UPD_FLAGS, this, old_container); 2473 esrv_update_item (UPD_FLAGS, this, old_container);
2500 2474
2501 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2475 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2502 play_sound (sound_find ("chest_close")); 2476 play_sound (sound_find ("chest_close"));
2503 } 2477 }
2504 2478
2505 if (new_container) 2479 if (new_container)
2506 { 2480 {
2516 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2490 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2517 new_container->insert (closer); 2491 new_container->insert (closer);
2518 } 2492 }
2519#endif 2493#endif
2520 2494
2521 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2495 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2522 2496
2523 // make sure the container is available, client bug requires this to be separate 2497 // make sure the container is available, client bug requires this to be separate
2524 esrv_send_item (this, new_container); 2498 esrv_send_item (this, new_container);
2525 2499
2526 new_container->flag [FLAG_APPLIED] = true; 2500 new_container->flag [FLAG_APPLIED] = true;
2534// else if (!old_container->env && contr && contr->ns) 2508// else if (!old_container->env && contr && contr->ns)
2535// contr->ns->floorbox_reset (); 2509// contr->ns->floorbox_reset ();
2536} 2510}
2537 2511
2538object * 2512object *
2539object::force_find (const shstr name) 2513object::force_find (shstr_tmp name)
2540{ 2514{
2541 /* cycle through his inventory to look for the MARK we want to 2515 /* cycle through his inventory to look for the MARK we want to
2542 * place 2516 * place
2543 */ 2517 */
2544 for (object *tmp = inv; tmp; tmp = tmp->below) 2518 for (object *tmp = inv; tmp; tmp = tmp->below)
2546 return splay (tmp); 2520 return splay (tmp);
2547 2521
2548 return 0; 2522 return 0;
2549} 2523}
2550 2524
2525//-GPL
2526
2551void 2527void
2528object::force_set_timer (int duration)
2529{
2530 this->duration = 1;
2531 this->speed_left = -1.f;
2532
2533 this->set_speed (duration ? 1.f / duration : 0.f);
2534}
2535
2536object *
2552object::force_add (const shstr name, int duration) 2537object::force_add (shstr_tmp name, int duration)
2553{ 2538{
2554 if (object *force = force_find (name)) 2539 if (object *force = force_find (name))
2555 force->destroy (); 2540 force->destroy ();
2556 2541
2557 object *force = get_archetype (FORCE_NAME); 2542 object *force = get_archetype (FORCE_NAME);
2558 2543
2559 force->slaying = name; 2544 force->slaying = name;
2560 force->stats.food = 1; 2545 force->force_set_timer (duration);
2561 force->speed_left = -1.f;
2562
2563 force->set_speed (duration ? 1.f / duration : 0.f);
2564 force->flag [FLAG_IS_USED_UP] = true;
2565 force->flag [FLAG_APPLIED] = true; 2546 force->flag [FLAG_APPLIED] = true;
2566 2547
2567 insert (force); 2548 return insert (force);
2568} 2549}
2569 2550
2570void 2551void
2571object::play_sound (faceidx sound) 2552object::play_sound (faceidx sound) const
2572{ 2553{
2573 if (!sound) 2554 if (!sound)
2574 return; 2555 return;
2575 2556
2576 if (flag [FLAG_REMOVED]) 2557 if (is_on_map ())
2558 map->play_sound (sound, x, y);
2559 else if (object *pl = in_player ())
2560 pl->contr->play_sound (sound);
2561}
2562
2563void
2564object::say_msg (const char *msg) const
2565{
2566 if (is_on_map ())
2567 map->say_msg (msg, x, y);
2568 else if (object *pl = in_player ())
2569 pl->contr->play_sound (sound);
2570}
2571
2572void
2573object::make_noise ()
2574{
2575 // we do not model noise in the map, so instead put
2576 // a temporary light into the noise source
2577 // could use the map instead, but that's less reliable for our
2578 // goal, which is to make invisibility a bit harder to exploit
2579
2580 // currently only works sensibly for players
2581 if (!is_player ())
2577 return; 2582 return;
2578 2583
2579 if (env) 2584 // find old force, or create new one
2580 { 2585 object *force = force_find (shstr_noise_force);
2581 if (object *pl = in_player ()) 2586
2582 pl->contr->play_sound (sound); 2587 if (force)
2583 } 2588 force->speed_left = -1.f; // patch old speed up
2584 else 2589 else
2585 map->play_sound (sound, x, y); 2590 {
2586} 2591 force = archetype::get (shstr_noise_force);
2587 2592
2593 force->slaying = shstr_noise_force;
2594 force->stats.food = 1;
2595 force->speed_left = -1.f;
2596
2597 force->set_speed (1.f / 4.f);
2598 force->flag [FLAG_IS_USED_UP] = true;
2599 force->flag [FLAG_APPLIED] = true;
2600
2601 insert (force);
2602 }
2603}
2604

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines