[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.215 by root, Tue Apr 22 07:28:05 2008 UTC vs.
Revision 1.256 by root, Sun Aug 31 05:47:14 2008 UTC

…		…
139		139
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	141	static bool
142	compare_ob_value_lists_one (const object wants, const object has)	142	compare_ob_value_lists_one (const object wants, const object has)
143	{	143	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	144	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	145	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	146	* different structure or at least keep the lists sorted...
149	*/	147	*/
150		148
151	/* For each field in wants, */	149	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	150	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	151	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	152	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		153
169	/* If we get here, every field in wants has a matching field in has. */	154	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	155	return true;
171	}	156	}
172		157
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	158	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	159	static bool
175	compare_ob_value_lists (const object ob1, const object ob2)	160	compare_ob_value_lists (const object ob1, const object ob2)
176	{	161	{
177	/* However, there may be fields in has which aren't partnered in wants,	162	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison twice. :(	163	* so we need to run the comparison twice. :(
179	*/	164	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	165	return compare_ob_value_lists_one (ob1, ob2)
		166	&& compare_ob_value_lists_one (ob2, ob1);
181	}	167	}
182		168
183	/* Function examines the 2 objects given to it, and returns true if	169	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	170	* they can be merged together.
185	*	171	*
…		…
200	\|\| ob1->speed != ob2->speed	186	\|\| ob1->speed != ob2->speed
201	\|\| ob1->value != ob2->value	187	\|\| ob1->value != ob2->value
202	\|\| ob1->name != ob2->name)	188	\|\| ob1->name != ob2->name)
203	return 0;	189	return 0;
204		190
205	/* Do not merge objects if nrof would overflow. First part checks	191	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	192	* is always 0 .. 2*31-1 /
207	* would fit into a 32 bit signed int, which is often used to hold	193	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof \|\| ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	194	return 0;
212		195
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	196	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	197	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	198	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	203	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		204
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	205	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	206	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		207
225	if (ob1->arch->name != ob2->arch->name	208	if (ob1->arch->archname != ob2->arch->archname
226	\|\| ob1->name != ob2->name	209	\|\| ob1->name != ob2->name
227	\|\| ob1->title != ob2->title	210	\|\| ob1->title != ob2->title
228	\|\| ob1->msg != ob2->msg	211	\|\| ob1->msg != ob2->msg
229	\|\| ob1->weight != ob2->weight	212	\|\| ob1->weight != ob2->weight
230	\|\| ob1->attacktype != ob2->attacktype	213	\|\| ob1->attacktype != ob2->attacktype
231	\|\| ob1->magic != ob2->magic	214	\|\| ob1->magic != ob2->magic
232	\|\| ob1->slaying != ob2->slaying	215	\|\| ob1->slaying != ob2->slaying
233	\|\| ob1->skill != ob2->skill	216	\|\| ob1->skill != ob2->skill
234	\|\| ob1->value != ob2->value	217	\|\| ob1->value != ob2->value
235	\|\| ob1->animation_id != ob2->animation_id	218	\|\| ob1->animation_id != ob2->animation_id
		219	\|\| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	\|\| ob1->client_type != ob2->client_type	220	\|\| ob1->client_type != ob2->client_type
237	\|\| ob1->materialname != ob2->materialname	221	\|\| ob1->materialname != ob2->materialname
238	\|\| ob1->lore != ob2->lore	222	\|\| ob1->lore != ob2->lore
239	\|\| ob1->subtype != ob2->subtype	223	\|\| ob1->subtype != ob2->subtype
240	\|\| ob1->move_type != ob2->move_type	224	\|\| ob1->move_type != ob2->move_type
…		…
248	\|\| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	232	\|\| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	233	return 0;
250		234
251	if ((ob1->flag ^ ob2->flag)	235	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	236	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	237	.reset (FLAG_REMOVED)
255	.any ())	238	.any ())
256	return 0;	239	return 0;
257		240
258	/* This is really a spellbook check - we should in general	241	/* This is really a spellbook check - we should in general
…		…
334		317
335	// find player who can see this object	318	// find player who can see this object
336	object *	319	object *
337	object::visible_to () const	320	object::visible_to () const
338	{	321	{
339	if (!flag [FLAG_REMOVED])	322	if (client_visible () && !flag [FLAG_REMOVED])
340	{	323	{
341	// see if we are in a container of sorts	324	// see if we are in a container of sorts
342	if (env)	325	if (env)
343	{	326	{
344	// the player inventory itself is always visible	327	// the player inventory itself is always visible
…		…
358	else	341	else
359	{	342	{
360	// maybe there is a player standing on the same mapspace	343	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	344	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	345	if (object *pl = ms ().player ())
		346	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		347	\|\| this == pl->container)
363	return pl;	348	return pl;
364	}	349	}
365	}	350	}
366		351
367	return 0;	352	return 0;
368	}	353	}
369		354
370	// adjust weight per container type ("of holding")	355	// adjust weight per container type ("of holding")
371	static sint32	356	static sint32
372	weight_adjust (object *op, sint32 weight)	357	weight_adjust_for (object *op, sint32 weight)
373	{	358	{
374	return op->type == CONTAINER	359	return op->type == CONTAINER
375	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	360	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
376	: weight;	361	: weight;
377	}	362	}
…		…
383	static void	368	static void
384	adjust_weight (object *op, sint32 weight)	369	adjust_weight (object *op, sint32 weight)
385	{	370	{
386	while (op)	371	while (op)
387	{	372	{
		373	// adjust by actual difference to account for rounding errors
		374	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
388	weight = weight_adjust (op, weight);	375	weight = weight_adjust_for (op, op->carrying)
		376	- weight_adjust_for (op, op->carrying - weight);
389		377
390	if (!weight)	378	if (!weight)
391	return;	379	return;
392		380
393	op->carrying += weight;	381	op->carrying += weight;
…		…
416	op->update_weight ();	404	op->update_weight ();
417		405
418	sum += op->total_weight ();	406	sum += op->total_weight ();
419	}	407	}
420		408
421	sum = weight_adjust (this, sum);	409	sum = weight_adjust_for (this, sum);
422		410
423	if (sum != carrying)	411	if (sum != carrying)
424	{	412	{
425	carrying = sum;	413	carrying = sum;
426		414
…		…
488	*/	476	*/
489	object *	477	object *
490	find_object_name (const char *str)	478	find_object_name (const char *str)
491	{	479	{
492	shstr_cmp str_ (str);	480	shstr_cmp str_ (str);
493	object *op;
494		481
		482	if (str_)
495	for_all_objects (op)	483	for_all_objects (op)
496	if (op->name == str_)	484	if (op->name == str_)
497	break;	485	return op;
498		486
499	return op;	487	return 0;
500	}	488	}
501		489
502	/*	490	/*
503	* Sets the owner and sets the skill and exp pointers to owner's current	491	* Sets the owner and sets the skill and exp pointers to owner's current
504	* skill and experience objects.	492	* skill and experience objects.
…		…
602	}	590	}
603		591
604	op->key_values = 0;	592	op->key_values = 0;
605	}	593	}
606		594
607	object &	595	/*
608	object::operator =(const object &src)	596	* copy_to first frees everything allocated by the dst object,
		597	* and then copies the contents of itself into the second
		598	* object, allocating what needs to be allocated. Basically, any
		599	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		600	* if the first object is freed, the pointers in the new object
		601	* will point at garbage.
		602	*/
		603	void
		604	object::copy_to (object *dst)
609	{	605	{
610	bool is_freed = flag [FLAG_FREED];	606	dst->remove ();
611	bool is_removed = flag [FLAG_REMOVED];
612
613	(object_copy )this = src;	607	(object_copy )dst = *this;
614
615	flag [FLAG_FREED] = is_freed;
616	flag [FLAG_REMOVED] = is_removed;	608	dst->flag [FLAG_REMOVED] = true;
617		609
618	/* Copy over key_values, if any. */	610	/* Copy over key_values, if any. */
619	if (src.key_values)	611	if (key_values)
620	{	612	{
621	key_value *tail = 0;	613	key_value *tail = 0;
622	key_values = 0;	614	dst->key_values = 0;
623		615
624	for (key_value *i = src.key_values; i; i = i->next)	616	for (key_value *i = key_values; i; i = i->next)
625	{	617	{
626	key_value *new_link = new key_value;	618	key_value *new_link = new key_value;
627		619
628	new_link->next = 0;	620	new_link->next = 0;
629	new_link->key = i->key;	621	new_link->key = i->key;
630	new_link->value = i->value;	622	new_link->value = i->value;
631		623
632	/* Try and be clever here, too. */	624	/* Try and be clever here, too. */
633	if (!key_values)	625	if (!dst->key_values)
634	{	626	{
635	key_values = new_link;	627	dst->key_values = new_link;
636	tail = new_link;	628	tail = new_link;
637	}	629	}
638	else	630	else
639	{	631	{
640	tail->next = new_link;	632	tail->next = new_link;
641	tail = new_link;	633	tail = new_link;
642	}	634	}
643	}	635	}
644	}	636	}
645	}
646
647	/*
648	* copy_to first frees everything allocated by the dst object,
649	* and then copies the contents of itself into the second
650	* object, allocating what needs to be allocated. Basically, any
651	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
652	* if the first object is freed, the pointers in the new object
653	* will point at garbage.
654	*/
655	void
656	object::copy_to (object *dst)
657	{
658	dst = this;
659		637
660	if (speed < 0)	638	if (speed < 0)
661	dst->speed_left -= rndm ();	639	dst->speed_left -= rndm ();
662		640
663	dst->set_speed (dst->speed);	641	dst->activate ();
664	}	642	}
665		643
666	void	644	void
667	object::instantiate ()	645	object::instantiate ()
668	{	646	{
…		…
685	object *	663	object *
686	object::clone ()	664	object::clone ()
687	{	665	{
688	object *neu = create ();	666	object *neu = create ();
689	copy_to (neu);	667	copy_to (neu);
		668	neu->map = map; // not copied by copy_to
690	return neu;	669	return neu;
691	}	670	}
692		671
693	/*	672	/*
694	* If an object with the IS_TURNABLE() flag needs to be turned due	673	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
745	* UP_OBJ_FACE: only the objects face has changed.	724	* UP_OBJ_FACE: only the objects face has changed.
746	*/	725	*/
747	void	726	void
748	update_object (object *op, int action)	727	update_object (object *op, int action)
749	{	728	{
750	if (op == NULL)	729	if (!op)
751	{	730	{
752	/* this should never happen */	731	/* this should never happen */
753	LOG (llevDebug, "update_object() called for NULL object.\n");	732	LOG (llevError \| logBacktrace, "update_object() called for NULL object.\n");
754	return;	733	return;
755	}	734	}
756		735
757	if (op->env)	736	if (!op->is_on_map ())
758	{	737	{
759	/* Animation is currently handled by client, so nothing	738	/* Animation is currently handled by client, so nothing
760	* to do in this case.	739	* to do in this case.
761	*/	740	*/
762	return;	741	return;
763	}	742	}
764
765	/* If the map is saving, don't do anything as everything is
766	* going to get freed anyways.
767	*/
768	if (!op->map \|\| op->map->in_memory == MAP_SAVING)
769	return;
770		743
771	/* make sure the object is within map boundaries */	744	/* make sure the object is within map boundaries */
772	if (op->x < 0 \|\| op->x >= op->map->width \|\| op->y < 0 \|\| op->y >= op->map->height)	745	if (op->x < 0 \|\| op->x >= op->map->width \|\| op->y < 0 \|\| op->y >= op->map->height)
773	{	746	{
774	LOG (llevError, "update_object() called for object out of map!\n");	747	LOG (llevError, "update_object() called for object out of map!\n");
…		…
793	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	766	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
794	\|\| (m.move_on \| op->move_on ) != m.move_on	767	\|\| (m.move_on \| op->move_on ) != m.move_on
795	\|\| (m.move_off \| op->move_off ) != m.move_off	768	\|\| (m.move_off \| op->move_off ) != m.move_off
796	\|\| (m.move_slow \| op->move_slow) != m.move_slow	769	\|\| (m.move_slow \| op->move_slow) != m.move_slow
797	/* This isn't perfect, but I don't expect a lot of objects to	770	/* This isn't perfect, but I don't expect a lot of objects to
798	* to have move_allow right now.	771	* have move_allow right now.
799	*/	772	*/
800	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block	773	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block
801	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	774	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
802	m.flags_ = 0;	775	m.flags_ = 0;
803	}	776	}
…		…
857	{	830	{
858	/* If already on active list, don't do anything */	831	/* If already on active list, don't do anything */
859	if (active)	832	if (active)
860	return;	833	return;
861		834
		835	if (has_active_speed () && flag [FLAG_FREED ]) LOG (llevError \| logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		836
862	if (has_active_speed ())	837	if (has_active_speed ())
863	actives.insert (this);	838	actives.insert (this);
864	}	839	}
865		840
866	void	841	void
…		…
917	object::destroy_inv (bool drop_to_ground)	892	object::destroy_inv (bool drop_to_ground)
918	{	893	{
919	// need to check first, because the checks below might segfault	894	// need to check first, because the checks below might segfault
920	// as we might be on an invalid mapspace and crossfire code	895	// as we might be on an invalid mapspace and crossfire code
921	// is too buggy to ensure that the inventory is empty.	896	// is too buggy to ensure that the inventory is empty.
922	// corollary: if you create arrows etc. with stuff in tis inventory,	897	// corollary: if you create arrows etc. with stuff in its inventory,
923	// cf will crash below with off-map x and y	898	// cf will crash below with off-map x and y
924	if (!inv)	899	if (!inv)
925	return;	900	return;
926		901
927	/* Only if the space blocks everything do we not process -	902	/* Only if the space blocks everything do we not process -
…		…
929	* drop on that space.	904	* drop on that space.
930	*/	905	*/
931	if (!drop_to_ground	906	if (!drop_to_ground
932	\|\| !map	907	\|\| !map
933	\|\| map->in_memory != MAP_ACTIVE	908	\|\| map->in_memory != MAP_ACTIVE
934	\|\| map->nodrop	909	\|\| map->no_drop
935	\|\| ms ().move_block == MOVE_ALL)	910	\|\| ms ().move_block == MOVE_ALL)
936	{	911	{
937	while (inv)	912	while (inv)
938	{
939	inv->destroy_inv (drop_to_ground);
940	inv->destroy ();	913	inv->destroy (true);
941	}
942	}	914	}
943	else	915	else
944	{ /* Put objects in inventory onto this space */	916	{ /* Put objects in inventory onto this space */
945	while (inv)	917	while (inv)
946	{	918	{
…		…
950	\|\| op->flag [FLAG_NO_DROP]	922	\|\| op->flag [FLAG_NO_DROP]
951	\|\| op->type == RUNE	923	\|\| op->type == RUNE
952	\|\| op->type == TRAP	924	\|\| op->type == TRAP
953	\|\| op->flag [FLAG_IS_A_TEMPLATE]	925	\|\| op->flag [FLAG_IS_A_TEMPLATE]
954	\|\| op->flag [FLAG_DESTROY_ON_DEATH])	926	\|\| op->flag [FLAG_DESTROY_ON_DEATH])
955	op->destroy ();	927	op->destroy (true);
956	else	928	else
957	map->insert (op, x, y);	929	map->insert (op, x, y);
958	}	930	}
959	}	931	}
960	}	932	}
…		…
964	object *op = new object;	936	object *op = new object;
965	op->link ();	937	op->link ();
966	return op;	938	return op;
967	}	939	}
968		940
		941	static struct freed_map : maptile
		942	{
		943	freed_map ()
		944	{
		945	path = "<freed objects map>";
		946	name = "/internal/freed_objects_map";
		947	width = 3;
		948	height = 3;
		949	no_drop = 1;
		950	no_reset = 1;
		951
		952	alloc ();
		953	in_memory = MAP_ACTIVE;
		954	}
		955
		956	~freed_map ()
		957	{
		958	destroy ();
		959	}
		960	} freed_map; // freed objects are moved here to avoid crashes
		961
969	void	962	void
970	object::do_destroy ()	963	object::do_destroy ()
971	{	964	{
972	if (flag [FLAG_IS_LINKED])	965	if (flag [FLAG_IS_LINKED])
973	remove_button_link (this);	966	remove_button_link (this);
…		…
977		970
978	remove ();	971	remove ();
979		972
980	attachable::do_destroy ();	973	attachable::do_destroy ();
981		974
982	destroy_inv (true);
983
984	deactivate ();	975	deactivate ();
985	unlink ();	976	unlink ();
986		977
987	flag [FLAG_FREED] = 1;	978	flag [FLAG_FREED] = 1;
988		979
989	// hack to ensure that freed objects still have a valid map	980	// hack to ensure that freed objects still have a valid map
990	{
991	static maptile *freed_map; // freed objects are moved here to avoid crashes
992
993	if (!freed_map)
994	{
995	freed_map = new maptile;
996
997	freed_map->path = "<freed objects map>";
998	freed_map->name = "/internal/freed_objects_map";
999	freed_map->width = 3;
1000	freed_map->height = 3;
1001	freed_map->nodrop = 1;
1002
1003	freed_map->alloc ();
1004	freed_map->in_memory = MAP_ACTIVE;
1005	}
1006
1007	map = freed_map;	981	map = &freed_map;
1008	x = 1;	982	x = 1;
1009	y = 1;	983	y = 1;
1010	}
1011		984
1012	if (more)	985	if (more)
1013	{	986	{
1014	more->destroy ();	987	more->destroy ();
1015	more = 0;	988	more = 0;
…		…
1028	object::destroy (bool destroy_inventory)	1001	object::destroy (bool destroy_inventory)
1029	{	1002	{
1030	if (destroyed ())	1003	if (destroyed ())
1031	return;	1004	return;
1032		1005
		1006	if (!is_head () && !head->destroyed ())
		1007	{
		1008	LOG (llevError \| logBacktrace, "tried to destroy the tail of an object");
		1009	head->destroy (destroy_inventory);
		1010	return;
		1011	}
		1012
1033	if (destroy_inventory)	1013	destroy_inv (!destroy_inventory);
1034	destroy_inv (false);
1035		1014
1036	if (is_head ())	1015	if (is_head ())
1037	if (sound_destroy)	1016	if (sound_destroy)
1038	play_sound (sound_destroy);	1017	play_sound (sound_destroy);
1039	else if (flag [FLAG_MONSTER])	1018	else if (flag [FLAG_MONSTER])
…		…
1058	if (flag [FLAG_REMOVED])	1037	if (flag [FLAG_REMOVED])
1059	return;	1038	return;
1060		1039
1061	INVOKE_OBJECT (REMOVE, this);	1040	INVOKE_OBJECT (REMOVE, this);
1062		1041
1063	if (object *pl = visible_to ())
1064	esrv_del_item (pl->contr, count);
1065
1066	flag [FLAG_REMOVED] = true;	1042	flag [FLAG_REMOVED] = true;
1067		1043
1068	if (more)	1044	if (more)
1069	more->remove ();	1045	more->remove ();
1070		1046
…		…
1072	* In this case, the object to be removed is in someones	1048	* In this case, the object to be removed is in someones
1073	* inventory.	1049	* inventory.
1074	*/	1050	*/
1075	if (env)	1051	if (env)
1076	{	1052	{
		1053	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1054	if (object *pl = visible_to ())
		1055	esrv_del_item (pl->contr, count);
		1056	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1057
1077	adjust_weight (env, -total_weight ());	1058	adjust_weight (env, -total_weight ());
1078
1079	*(above ? &above->below : &env->inv) = below;
1080
1081	if (below)
1082	below->above = above;
1083		1059
1084	/* we set up values so that it could be inserted into	1060	/* we set up values so that it could be inserted into
1085	* the map, but we don't actually do that - it is up	1061	* the map, but we don't actually do that - it is up
1086	* to the caller to decide what we want to do.	1062	* to the caller to decide what we want to do.
1087	*/	1063	*/
1088	map = env->map;	1064	map = env->map;
1089	x = env->x;	1065	x = env->x;
1090	y = env->y;	1066	y = env->y;
		1067
		1068	// make sure cmov optimisation is applicable
		1069	*(above ? &above->below : &env->inv) = below;
		1070	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1071
1091	above = 0;	1072	above = 0;
1092	below = 0;	1073	below = 0;
1093	env = 0;	1074	env = 0;
1094		1075
1095	/* NO_FIX_PLAYER is set when a great many changes are being	1076	/* NO_FIX_PLAYER is set when a great many changes are being
…		…
1099	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1080	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1100	otmp->update_stats ();	1081	otmp->update_stats ();
1101	}	1082	}
1102	else if (map)	1083	else if (map)
1103	{	1084	{
1104	if (type == PLAYER)
1105	{
1106	// leaving a spot always closes any open container on the ground
1107	if (container && !container->env)
1108	// this causes spurious floorbox updates, but it ensures
1109	// that the CLOSE event is being sent.
1110	close_container ();
1111
1112	--map->players;
1113	map->touch ();
1114	}
1115
1116	map->dirty = true;	1085	map->dirty = true;
1117	mapspace &ms = this->ms ();	1086	mapspace &ms = this->ms ();
1118		1087
		1088	if (object *pl = ms.player ())
		1089	{
		1090	if (type == PLAYER) // this == pl(!)
		1091	{
		1092	// leaving a spot always closes any open container on the ground
		1093	if (container && !container->env)
		1094	// this causes spurious floorbox updates, but it ensures
		1095	// that the CLOSE event is being sent.
		1096	close_container ();
		1097
		1098	--map->players;
		1099	map->touch ();
		1100	}
		1101	else if (pl->container == this)
		1102	{
		1103	// removing a container should close it
		1104	close_container ();
		1105	}
		1106
		1107	esrv_del_item (pl->contr, count);
		1108	}
		1109
1119	/* link the object above us */	1110	/* link the object above us */
1120	if (above)	1111	// re-link, make sure compiler can easily use cmove
1121	above->below = below;	1112	*(above ? &above->below : &ms.top) = below;
1122	else	1113	*(below ? &below->above : &ms.bot) = above;
1123	ms.top = below; /* we were top, set new top */
1124
1125	/* Relink the object below us, if there is one */
1126	if (below)
1127	below->above = above;
1128	else
1129	{
1130	/* Nothing below, which means we need to relink map object for this space
1131	* use translated coordinates in case some oddness with map tiling is
1132	* evident
1133	*/
1134	if (GET_MAP_OB (map, x, y) != this)
1135	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1136
1137	ms.bot = above; /* goes on above it. */
1138	}
1139		1114
1140	above = 0;	1115	above = 0;
1141	below = 0;	1116	below = 0;
		1117
		1118	ms.flags_ = 0;
1142		1119
1143	if (map->in_memory == MAP_SAVING)	1120	if (map->in_memory == MAP_SAVING)
1144	return;	1121	return;
1145		1122
1146	int check_walk_off = !flag [FLAG_NO_APPLY];	1123	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1152	* removed (most likely destroyed), update the player view	1129	* removed (most likely destroyed), update the player view
1153	* appropriately.	1130	* appropriately.
1154	*/	1131	*/
1155	pl->close_container ();	1132	pl->close_container ();
1156		1133
		1134	//TODO: the floorbox prev/next might need updating
		1135	//esrv_del_item (pl->contr, count);
		1136	//TODO: update floorbox to preserve ordering
		1137	if (pl->contr->ns)
1157	pl->contr->ns->floorbox_update ();	1138	pl->contr->ns->floorbox_update ();
1158	}	1139	}
1159		1140
1160	for (tmp = ms.bot; tmp; tmp = tmp->above)	1141	for (tmp = ms.bot; tmp; tmp = tmp->above)
1161	{	1142	{
1162	/* No point updating the players look faces if he is the object	1143	/* No point updating the players look faces if he is the object
…		…
1175	}	1156	}
1176		1157
1177	last = tmp;	1158	last = tmp;
1178	}	1159	}
1179		1160
1180	/* last == NULL if there are no objects on this space */
1181	//TODO: this makes little sense, why only update the topmost object?
1182	if (!last)
1183	map->at (x, y).flags_ = 0;
1184	else
1185	update_object (last, UP_OBJ_REMOVE);
1186
1187	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)	1161	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)
1188	update_all_los (map, x, y);	1162	update_all_los (map, x, y);
1189	}	1163	}
1190	}	1164	}
1191		1165
…		…
1254	* job preparing multi-part monsters.	1228	* job preparing multi-part monsters.
1255	*/	1229	*/
1256	object *	1230	object *
1257	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)	1231	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)
1258	{	1232	{
		1233	op->remove ();
		1234
1259	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1235	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1260	{	1236	{
1261	tmp->x = x + tmp->arch->x;	1237	tmp->x = x + tmp->arch->x;
1262	tmp->y = y + tmp->arch->y;	1238	tmp->y = y + tmp->arch->y;
1263	}	1239	}
…		…
1286	* just 'op' otherwise	1262	* just 'op' otherwise
1287	*/	1263	*/
1288	object *	1264	object *
1289	insert_ob_in_map (object op, maptile m, object *originator, int flag)	1265	insert_ob_in_map (object op, maptile m, object *originator, int flag)
1290	{	1266	{
1291	assert (!op->flag [FLAG_FREED]);	1267	if (op->is_on_map ())
		1268	{
		1269	LOG (llevError, "insert_ob_in_map called for object already on map");
		1270	abort ();
		1271	}
1292		1272
1293	object top, floor = NULL;	1273	if (op->env)
1294		1274	{
		1275	LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1295	op->remove ();	1276	op->remove ();
		1277	}
		1278
		1279	if (op->face && !face_info (op->face))//D TODO: remove soon
		1280	{//D
		1281	LOG (llevError \| logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
		1282	op->face = 1;//D
		1283	}//D
1296		1284
1297	/* Ideally, the caller figures this out. However, it complicates a lot	1285	/* Ideally, the caller figures this out. However, it complicates a lot
1298	* of areas of callers (eg, anything that uses find_free_spot would now	1286	* of areas of callers (eg, anything that uses find_free_spot would now
1299	* need extra work	1287	* need extra work
1300	*/	1288	*/
1301	if (!xy_normalise (m, op->x, op->y))	1289	if (!xy_normalise (m, op->x, op->y))
1302	{	1290	{
1303	op->destroy ();	1291	op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1304	return 0;	1292	return 0;
1305	}	1293	}
1306		1294
1307	if (object *more = op->more)	1295	if (object *more = op->more)
1308	if (!insert_ob_in_map (more, m, originator, flag))	1296	if (!insert_ob_in_map (more, m, originator, flag))
…		…
1317	*/	1305	*/
1318	if (op->nrof && !(flag & INS_NO_MERGE))	1306	if (op->nrof && !(flag & INS_NO_MERGE))
1319	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1307	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1320	if (object::can_merge (op, tmp))	1308	if (object::can_merge (op, tmp))
1321	{	1309	{
		1310	// TODO: we actually want to update tmp, not op,
		1311	// but some caller surely breaks when we return tmp
		1312	// from here :/
1322	op->nrof += tmp->nrof;	1313	op->nrof += tmp->nrof;
1323	tmp->destroy (1);	1314	tmp->destroy (1);
1324	}	1315	}
1325		1316
1326	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1317	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
…		…
1335	{	1326	{
1336	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1327	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1337	abort ();	1328	abort ();
1338	}	1329	}
1339		1330
		1331	if (!originator->is_on_map ())
		1332	LOG (llevDebug \| logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1333	op->debug_desc (), originator->debug_desc ());
		1334
1340	op->above = originator;	1335	op->above = originator;
1341	op->below = originator->below;	1336	op->below = originator->below;
1342
1343	if (op->below)
1344	op->below->above = op;
1345	else
1346	ms.bot = op;
1347
1348	/* since below originator, no need to update top */
1349	originator->below = op;	1337	originator->below = op;
		1338
		1339	*(op->below ? &op->below->above : &ms.bot) = op;
1350	}	1340	}
1351	else	1341	else
1352	{	1342	{
1353	top = ms.bot;	1343	object *floor = 0;
		1344	object *top = ms.top;
1354		1345
1355	/* If there are other objects, then */	1346	/* If there are other objects, then */
1356	if (top)	1347	if (top)
1357	{	1348	{
1358	object *last = 0;
1359
1360	/*	1349	/*
1361	* If there are multiple objects on this space, we do some trickier handling.	1350	* If there are multiple objects on this space, we do some trickier handling.
1362	* We've already dealt with merging if appropriate.	1351	* We've already dealt with merging if appropriate.
1363	* Generally, we want to put the new object on top. But if	1352	* Generally, we want to put the new object on top. But if
1364	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1353	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1367	* once we get to them. This reduces the need to traverse over all of	1356	* once we get to them. This reduces the need to traverse over all of
1368	* them when adding another one - this saves quite a bit of cpu time	1357	* them when adding another one - this saves quite a bit of cpu time
1369	* when lots of spells are cast in one area. Currently, it is presumed	1358	* when lots of spells are cast in one area. Currently, it is presumed
1370	* that flying non pickable objects are spell objects.	1359	* that flying non pickable objects are spell objects.
1371	*/	1360	*/
1372	for (top = ms.bot; top; top = top->above)	1361	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1373	{	1362	{
1374	if (QUERY_FLAG (top, FLAG_IS_FLOOR) \|\| QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1363	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) \|\| QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1375	floor = top;	1364	floor = tmp;
1376		1365
1377	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1366	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1378	{	1367	{
1379	/* We insert above top, so we want this object below this */	1368	/* We insert above top, so we want this object below this */
1380	top = top->below;	1369	top = tmp->below;
1381	break;	1370	break;
1382	}	1371	}
1383		1372
1384	last = top;	1373	top = tmp;
1385	}	1374	}
1386
1387	/* Don't want top to be NULL, so set it to the last valid object */
1388	top = last;
1389		1375
1390	/* We let update_position deal with figuring out what the space	1376	/* We let update_position deal with figuring out what the space
1391	* looks like instead of lots of conditions here.	1377	* looks like instead of lots of conditions here.
1392	* makes things faster, and effectively the same result.	1378	* makes things faster, and effectively the same result.
1393	*/	1379	*/
…		…
1400	*/	1386	*/
1401	if (!(flag & INS_ON_TOP)	1387	if (!(flag & INS_ON_TOP)
1402	&& ms.flags () & P_BLOCKSVIEW	1388	&& ms.flags () & P_BLOCKSVIEW
1403	&& (op->face && !faces [op->face].visibility))	1389	&& (op->face && !faces [op->face].visibility))
1404	{	1390	{
		1391	object *last;
		1392
1405	for (last = top; last != floor; last = last->below)	1393	for (last = top; last != floor; last = last->below)
1406	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1394	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1407	break;	1395	break;
1408		1396
1409	/* Check to see if we found the object that blocks view,	1397	/* Check to see if we found the object that blocks view,
…		…
1417	} /* If objects on this space */	1405	} /* If objects on this space */
1418		1406
1419	if (flag & INS_ABOVE_FLOOR_ONLY)	1407	if (flag & INS_ABOVE_FLOOR_ONLY)
1420	top = floor;	1408	top = floor;
1421		1409
1422	/* Top is the object that our object (op) is going to get inserted above.	1410	// insert object above top, or bottom-most if top = 0
1423	*/
1424
1425	/* First object on this space */
1426	if (!top)	1411	if (!top)
1427	{	1412	{
		1413	op->below = 0;
1428	op->above = ms.bot;	1414	op->above = ms.bot;
1429
1430	if (op->above)
1431	op->above->below = op;
1432
1433	op->below = 0;
1434	ms.bot = op;	1415	ms.bot = op;
		1416
		1417	*(op->above ? &op->above->below : &ms.top) = op;
1435	}	1418	}
1436	else	1419	else
1437	{ /* get inserted into the stack above top */	1420	{
1438	op->above = top->above;	1421	op->above = top->above;
1439
1440	if (op->above)
1441	op->above->below = op;	1422	top->above = op;
1442		1423
1443	op->below = top;	1424	op->below = top;
1444	top->above = op;	1425	*(op->above ? &op->above->below : &ms.top) = op;
1445	}	1426	}
1446		1427	}
1447	if (!op->above)
1448	ms.top = op;
1449	} /* else not INS_BELOW_ORIGINATOR */
1450		1428
1451	if (op->type == PLAYER)	1429	if (op->type == PLAYER)
1452	{	1430	{
1453	op->contr->do_los = 1;	1431	op->contr->do_los = 1;
1454	++op->map->players;	1432	++op->map->players;
…		…
1456	}	1434	}
1457		1435
1458	op->map->dirty = true;	1436	op->map->dirty = true;
1459		1437
1460	if (object *pl = ms.player ())	1438	if (object *pl = ms.player ())
		1439	//TODO: the floorbox prev/next might need updating
		1440	//esrv_send_item (pl, op);
		1441	//TODO: update floorbox to preserve ordering
		1442	if (pl->contr->ns)
1461	pl->contr->ns->floorbox_update ();	1443	pl->contr->ns->floorbox_update ();
1462		1444
1463	/* If this object glows, it may affect lighting conditions that are	1445	/* If this object glows, it may affect lighting conditions that are
1464	* visible to others on this map. But update_all_los is really	1446	* visible to others on this map. But update_all_los is really
1465	* an inefficient way to do this, as it means los for all players	1447	* an inefficient way to do this, as it means los for all players
1466	* on the map will get recalculated. The players could very well	1448	* on the map will get recalculated. The players could very well
…		…
1546	if (!nr)	1528	if (!nr)
1547	return true;	1529	return true;
1548		1530
1549	nr = min (nr, nrof);	1531	nr = min (nr, nrof);
1550		1532
		1533	if (nrof > nr)
		1534	{
1551	nrof -= nr;	1535	nrof -= nr;
1552
1553	if (nrof)
1554	{
1555	adjust_weight (env, -weight * nr); // carrying == 0	1536	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1556		1537
1557	if (object *pl = visible_to ())	1538	if (object *pl = visible_to ())
1558	esrv_update_item (UPD_NROF, pl, this);	1539	esrv_update_item (UPD_NROF, pl, this);
1559		1540
1560	return true;	1541	return true;
1561	}	1542	}
1562	else	1543	else
1563	{	1544	{
1564	destroy (1);	1545	destroy ();
1565	return false;	1546	return false;
1566	}	1547	}
1567	}	1548	}
1568		1549
1569	/*	1550	/*
…		…
1586	}	1567	}
1587	else	1568	else
1588	{	1569	{
1589	decrease (nr);	1570	decrease (nr);
1590		1571
1591	object *op = object_create_clone (this);	1572	object *op = deep_clone ();
1592	op->nrof = nr;	1573	op->nrof = nr;
1593	return op;	1574	return op;
1594	}	1575	}
1595	}	1576	}
1596		1577
…		…
1817	LOG (llevError, "Present_arch called outside map.\n");	1798	LOG (llevError, "Present_arch called outside map.\n");
1818	return NULL;	1799	return NULL;
1819	}	1800	}
1820		1801
1821	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1802	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1822	if (tmp->arch == at)	1803	if (tmp->arch->archname == at->archname)
1823	return tmp;	1804	return tmp;
1824		1805
1825	return NULL;	1806	return NULL;
1826	}	1807	}
1827		1808
…		…
1891	* The first matching object is returned, or NULL if none.	1872	* The first matching object is returned, or NULL if none.
1892	*/	1873	*/
1893	object *	1874	object *
1894	present_arch_in_ob (const archetype at, const object op)	1875	present_arch_in_ob (const archetype at, const object op)
1895	{	1876	{
1896	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1877	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1897	if (tmp->arch == at)	1878	if (tmp->arch->archname == at->archname)
1898	return tmp;	1879	return tmp;
1899		1880
1900	return NULL;	1881	return NULL;
1901	}	1882	}
1902		1883
…		…
2311		2292
2312	/*	2293	/*
2313	* create clone from object to another	2294	* create clone from object to another
2314	*/	2295	*/
2315	object *	2296	object *
2316	object_create_clone (object *asrc)	2297	object::deep_clone ()
2317	{	2298	{
2318	object dst = 0, tmp, src, prev, *item;	2299	assert (("deep_clone called on non-head object", is_head ()));
2319		2300
2320	if (!asrc)	2301	object *dst = clone ();
2321	return 0;
2322		2302
2323	src = asrc->head_ ();	2303	object *prev = dst;
2324
2325	prev = 0;
2326	for (object *part = src; part; part = part->more)	2304	for (object *part = this->more; part; part = part->more)
2327	{	2305	{
2328	tmp = part->clone ();	2306	object *tmp = part->clone ();
2329	tmp->x -= src->x;
2330	tmp->y -= src->y;
2331
2332	if (!part->head)
2333	{
2334	dst = tmp;
2335	tmp->head = 0;
2336	}
2337	else
2338	tmp->head = dst;	2307	tmp->head = dst;
2339
2340	tmp->more = 0;
2341
2342	if (prev)
2343	prev->more = tmp;	2308	prev->more = tmp;
2344
2345	prev = tmp;	2309	prev = tmp;
2346	}	2310	}
2347		2311
2348	for (item = src->inv; item; item = item->below)	2312	for (object *item = inv; item; item = item->below)
2349	insert_ob_in_ob (object_create_clone (item), dst);	2313	insert_ob_in_ob (item->deep_clone (), dst);
2350		2314
2351	return dst;	2315	return dst;
2352	}	2316	}
2353		2317
2354	/* This returns the first object in who's inventory that	2318	/* This returns the first object in who's inventory that
…		…
2363	return tmp;	2327	return tmp;
2364		2328
2365	return 0;	2329	return 0;
2366	}	2330	}
2367		2331
2368	/* If ob has a field named key, return the link from the list,	2332	const shstr &
2369	* otherwise return NULL.	2333	object::kv_get (const shstr &key) const
2370	*
2371	* key must be a passed in shared string - otherwise, this won't
2372	* do the desired thing.
2373	*/
2374	key_value *
2375	get_ob_key_link (const object ob, const char key)
2376	{	2334	{
2377	for (key_value *link = ob->key_values; link; link = link->next)	2335	for (key_value *kv = key_values; kv; kv = kv->next)
2378	if (link->key == key)	2336	if (kv->key == key)
2379	return link;
2380
2381	return 0;
2382	}
2383
2384	/*
2385	* Returns the value of op has an extra_field for key, or NULL.
2386	*
2387	* The argument doesn't need to be a shared string.
2388	*
2389	* The returned string is shared.
2390	*/
2391	const char *
2392	get_ob_key_value (const object op, const char const key)
2393	{
2394	key_value *link;
2395	shstr_cmp canonical_key (key);
2396
2397	if (!canonical_key)
2398	{
2399	/* 1. There being a field named key on any object
2400	* implies there'd be a shared string to find.
2401	* 2. Since there isn't, no object has this field.
2402	* 3. Therefore, this object doesn't have this field.
2403	*/
2404	return 0;
2405	}
2406
2407	/* This is copied from get_ob_key_link() above -
2408	* only 4 lines, and saves the function call overhead.
2409	*/
2410	for (link = op->key_values; link; link = link->next)
2411	if (link->key == canonical_key)
2412	return link->value;	2337	return kv->value;
2413		2338
2414	return 0;	2339	return shstr_null;
2415	}	2340	}
2416		2341
2417	/*	2342	void
2418	* Updates the canonical_key in op to value.	2343	object::kv_set (const shstr &key, const shstr &value)
2419	*
2420	* canonical_key is a shared string (value doesn't have to be).
2421	*
2422	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2423	* keys.
2424	*
2425	* Returns TRUE on success.
2426	*/
2427	int
2428	set_ob_key_value_s (object op, const shstr & canonical_key, const char value, int add_key)
2429	{	2344	{
2430	key_value field = NULL, last = NULL;	2345	for (key_value *kv = key_values; kv; kv = kv->next)
2431		2346	if (kv->key == key)
2432	for (field = op->key_values; field != NULL; field = field->next)
2433	{
2434	if (field->key != canonical_key)
2435	{	2347	{
2436	last = field;	2348	kv->value = value;
2437	continue;	2349	return;
2438	}	2350	}
2439		2351
2440	if (value)	2352	key_value *kv = new key_value;
2441	field->value = value;	2353
2442	else	2354	kv->next = key_values;
		2355	kv->key = key;
		2356	kv->value = value;
		2357
		2358	key_values = kv;
		2359	}
		2360
		2361	void
		2362	object::kv_del (const shstr &key)
		2363	{
		2364	for (key_value *kvp = &key_values; kvp; kvp = &(*kvp)->next)
		2365	if ((*kvp)->key == key)
2443	{	2366	{
2444	/* Basically, if the archetype has this key set,	2367	key_value kv = kvp;
2445	* we need to store the null value so when we save	2368	kvp = (kvp)->next;
2446	* it, we save the empty value so that when we load,	2369	delete kv;
2447	* we get this value back again.	2370	return;
2448	*/
2449	if (get_ob_key_link (op->arch, canonical_key))
2450	field->value = 0;
2451	else
2452	{
2453	if (last)
2454	last->next = field->next;
2455	else
2456	op->key_values = field->next;
2457
2458	delete field;
2459	}
2460	}	2371	}
2461	return TRUE;
2462	}
2463	/* IF we get here, key doesn't exist */
2464
2465	/* No field, we'll have to add it. */
2466
2467	if (!add_key)
2468	return FALSE;
2469
2470	/* There isn't any good reason to store a null
2471	* value in the key/value list. If the archetype has
2472	* this key, then we should also have it, so shouldn't
2473	* be here. If user wants to store empty strings,
2474	* should pass in ""
2475	*/
2476	if (value == NULL)
2477	return TRUE;
2478
2479	field = new key_value;
2480
2481	field->key = canonical_key;
2482	field->value = value;
2483	/* Usual prepend-addition. */
2484	field->next = op->key_values;
2485	op->key_values = field;
2486
2487	return TRUE;
2488	}
2489
2490	/*
2491	* Updates the key in op to value.
2492	*
2493	* If add_key is FALSE, this will only update existing keys,
2494	* and not add new ones.
2495	* In general, should be little reason FALSE is ever passed in for add_key
2496	*
2497	* Returns TRUE on success.
2498	*/
2499	int
2500	set_ob_key_value (object op, const char key, const char *value, int add_key)
2501	{
2502	shstr key_ (key);
2503
2504	return set_ob_key_value_s (op, key_, value, add_key);
2505	}	2372	}
2506		2373
2507	object::depth_iterator::depth_iterator (object *container)	2374	object::depth_iterator::depth_iterator (object *container)
2508	: iterator_base (container)	2375	: iterator_base (container)
2509	{	2376	{
…		…
2559	{	2426	{
2560	char flagdesc[512];	2427	char flagdesc[512];
2561	char info2[256 * 4];	2428	char info2[256 * 4];
2562	char *p = info;	2429	char *p = info;
2563		2430
2564	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2431	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2565	count,	2432	count,
2566	uuid.c_str (),	2433	uuid.c_str (),
2567	&name,	2434	&name,
2568	title ? "\",title:\"" : "",	2435	title ? ",title:\"" : "",
2569	title ? (const char *)title : "",	2436	title ? (const char *)title : "",
		2437	title ? "\"" : "",
2570	flag_desc (flagdesc, 512), type);	2438	flag_desc (flagdesc, 512), type);
2571		2439
2572	if (!this->flag[FLAG_REMOVED] && env)	2440	if (!flag[FLAG_REMOVED] && env)
2573	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2441	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2574		2442
2575	if (map)	2443	if (map)
2576	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2444	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2577		2445
…		…
2607	object::open_container (object *new_container)	2475	object::open_container (object *new_container)
2608	{	2476	{
2609	if (container == new_container)	2477	if (container == new_container)
2610	return;	2478	return;
2611		2479
2612	if (object *old_container = container)	2480	object *old_container = container;
		2481
		2482	if (old_container)
2613	{	2483	{
2614	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2484	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2615	return;	2485	return;
2616		2486
2617	#if 0	2487	#if 0
…		…
2619	if (object *closer = old_container->inv)	2489	if (object *closer = old_container->inv)
2620	if (closer->type == CLOSE_CON)	2490	if (closer->type == CLOSE_CON)
2621	closer->destroy ();	2491	closer->destroy ();
2622	#endif	2492	#endif
2623		2493
		2494	// make sure the container is available
		2495	esrv_send_item (this, old_container);
		2496
2624	old_container->flag [FLAG_APPLIED] = 0;	2497	old_container->flag [FLAG_APPLIED] = false;
2625	container = 0;	2498	container = 0;
2626		2499
		2500	// client needs item update to make it work, client bug requires this to be separate
2627	esrv_update_item (UPD_FLAGS, this, old_container);	2501	esrv_update_item (UPD_FLAGS, this, old_container);
		2502
2628	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2503	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2629	play_sound (sound_find ("chest_close"));	2504	play_sound (sound_find ("chest_close"));
2630	}	2505	}
2631		2506
2632	if (new_container)	2507	if (new_container)
…		…
2645	}	2520	}
2646	#endif	2521	#endif
2647		2522
2648	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2523	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2649		2524
		2525	// make sure the container is available, client bug requires this to be separate
		2526	esrv_send_item (this, new_container);
		2527
2650	new_container->flag [FLAG_APPLIED] = 1;	2528	new_container->flag [FLAG_APPLIED] = true;
2651	container = new_container;	2529	container = new_container;
2652		2530
		2531	// client needs flag change
2653	esrv_update_item (UPD_FLAGS, this, new_container);	2532	esrv_update_item (UPD_FLAGS, this, new_container);
2654	esrv_send_inventory (this, new_container);	2533	esrv_send_inventory (this, new_container);
2655	play_sound (sound_find ("chest_open"));	2534	play_sound (sound_find ("chest_open"));
2656	}	2535	}
		2536	// else if (!old_container->env && contr && contr->ns)
		2537	// contr->ns->floorbox_reset ();
2657	}	2538	}
2658		2539
2659	object *	2540	object *
2660	object::force_find (const shstr name)	2541	object::force_find (const shstr name)
2661	{	2542	{

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.215 by root, Tue Apr 22 07:28:05 2008 UTC vs. Revision 1.256 by root, Sun Aug 31 05:47:14 2008 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.215 by root, Tue Apr 22 07:28:05 2008 UTC vs.
Revision 1.256 by root, Sun Aug 31 05:47:14 2008 UTC