ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.224 by root, Fri May 2 20:16:24 2008 UTC vs.
Revision 1.258 by root, Mon Sep 29 09:04:50 2008 UTC

139 139
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 141static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
143{ 143{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
149 */ 147 */
150 148
151 /* For each field in wants, */ 149 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 151 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 152 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 153
169 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 155 return true;
171} 156}
172 157
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 159static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 161{
177 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
179 */ 164 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
181} 167}
182 168
183/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 170 * they can be merged together.
185 * 171 *
200 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 187 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
203 return 0; 189 return 0;
204 190
205 /* Do not merge objects if nrof would overflow. First part checks 191 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 192 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 193 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 194 return 0;
212 195
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 196 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 197 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 198 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 203 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 204
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 207
225 if (ob1->arch->name != ob2->arch->name 208 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 209 || ob1->name != ob2->name
227 || ob1->title != ob2->title 210 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 211 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 212 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 213 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 214 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 215 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 216 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 217 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 218 || ob1->animation_id != ob2->animation_id
219 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 220 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 221 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 222 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 223 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 224 || ob1->move_type != ob2->move_type
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 233 return 0;
250 234
251 if ((ob1->flag ^ ob2->flag) 235 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 236 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 237 .reset (FLAG_REMOVED)
255 .any ()) 238 .any ())
256 return 0; 239 return 0;
257 240
258 /* This is really a spellbook check - we should in general 241 /* This is really a spellbook check - we should in general
358 else 341 else
359 { 342 {
360 // maybe there is a player standing on the same mapspace 343 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 344 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 345 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363 if (!pl->container || this == pl->container) 347 || this == pl->container)
364 return pl; 348 return pl;
365 } 349 }
366 } 350 }
367 351
368 return 0; 352 return 0;
369} 353}
370 354
371// adjust weight per container type ("of holding") 355// adjust weight per container type ("of holding")
372static sint32 356static sint32
373weight_adjust (object *op, sint32 weight) 357weight_adjust_for (object *op, sint32 weight)
374{ 358{
375 return op->type == CONTAINER 359 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 360 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 361 : weight;
378} 362}
384static void 368static void
385adjust_weight (object *op, sint32 weight) 369adjust_weight (object *op, sint32 weight)
386{ 370{
387 while (op) 371 while (op)
388 { 372 {
373 // adjust by actual difference to account for rounding errors
374 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 375 weight = weight_adjust_for (op, op->carrying)
376 - weight_adjust_for (op, op->carrying - weight);
390 377
391 if (!weight) 378 if (!weight)
392 return; 379 return;
393 380
394 op->carrying += weight; 381 op->carrying += weight;
417 op->update_weight (); 404 op->update_weight ();
418 405
419 sum += op->total_weight (); 406 sum += op->total_weight ();
420 } 407 }
421 408
422 sum = weight_adjust (this, sum); 409 sum = weight_adjust_for (this, sum);
423 410
424 if (sum != carrying) 411 if (sum != carrying)
425 { 412 {
426 carrying = sum; 413 carrying = sum;
427 414
489 */ 476 */
490object * 477object *
491find_object_name (const char *str) 478find_object_name (const char *str)
492{ 479{
493 shstr_cmp str_ (str); 480 shstr_cmp str_ (str);
494 object *op;
495 481
482 if (str_)
496 for_all_objects (op) 483 for_all_objects (op)
497 if (op->name == str_) 484 if (op->name == str_)
498 break; 485 return op;
499 486
500 return op; 487 return 0;
501} 488}
502 489
503/* 490/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 491 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 492 * skill and experience objects.
603 } 590 }
604 591
605 op->key_values = 0; 592 op->key_values = 0;
606} 593}
607 594
608object & 595/*
609object::operator =(const object &src) 596 * copy_to first frees everything allocated by the dst object,
597 * and then copies the contents of itself into the second
598 * object, allocating what needs to be allocated. Basically, any
599 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
600 * if the first object is freed, the pointers in the new object
601 * will point at garbage.
602 */
603void
604object::copy_to (object *dst)
610{ 605{
611 remove (); 606 dst->remove ();
612
613 *(object_copy *)this = src; 607 *(object_copy *)dst = *this;
614
615 flag [FLAG_REMOVED] = true; 608 dst->flag [FLAG_REMOVED] = true;
616 609
617 /* Copy over key_values, if any. */ 610 /* Copy over key_values, if any. */
618 if (src.key_values) 611 if (key_values)
619 { 612 {
620 key_value *tail = 0; 613 key_value *tail = 0;
621 key_values = 0; 614 dst->key_values = 0;
622 615
623 for (key_value *i = src.key_values; i; i = i->next) 616 for (key_value *i = key_values; i; i = i->next)
624 { 617 {
625 key_value *new_link = new key_value; 618 key_value *new_link = new key_value;
626 619
627 new_link->next = 0; 620 new_link->next = 0;
628 new_link->key = i->key; 621 new_link->key = i->key;
629 new_link->value = i->value; 622 new_link->value = i->value;
630 623
631 /* Try and be clever here, too. */ 624 /* Try and be clever here, too. */
632 if (!key_values) 625 if (!dst->key_values)
633 { 626 {
634 key_values = new_link; 627 dst->key_values = new_link;
635 tail = new_link; 628 tail = new_link;
636 } 629 }
637 else 630 else
638 { 631 {
639 tail->next = new_link; 632 tail->next = new_link;
640 tail = new_link; 633 tail = new_link;
641 } 634 }
642 } 635 }
643 } 636 }
644}
645
646/*
647 * copy_to first frees everything allocated by the dst object,
648 * and then copies the contents of itself into the second
649 * object, allocating what needs to be allocated. Basically, any
650 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
651 * if the first object is freed, the pointers in the new object
652 * will point at garbage.
653 */
654void
655object::copy_to (object *dst)
656{
657 *dst = *this;
658 637
659 if (speed < 0) 638 if (speed < 0)
660 dst->speed_left -= rndm (); 639 dst->speed_left -= rndm ();
661 640
662 dst->set_speed (dst->speed); 641 dst->activate ();
663} 642}
664 643
665void 644void
666object::instantiate () 645object::instantiate ()
667{ 646{
684object * 663object *
685object::clone () 664object::clone ()
686{ 665{
687 object *neu = create (); 666 object *neu = create ();
688 copy_to (neu); 667 copy_to (neu);
668 neu->map = map; // not copied by copy_to
689 return neu; 669 return neu;
690} 670}
691 671
692/* 672/*
693 * If an object with the IS_TURNABLE() flag needs to be turned due 673 * If an object with the IS_TURNABLE() flag needs to be turned due
786 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
787 || (m.move_on | op->move_on ) != m.move_on 767 || (m.move_on | op->move_on ) != m.move_on
788 || (m.move_off | op->move_off ) != m.move_off 768 || (m.move_off | op->move_off ) != m.move_off
789 || (m.move_slow | op->move_slow) != m.move_slow 769 || (m.move_slow | op->move_slow) != m.move_slow
790 /* This isn't perfect, but I don't expect a lot of objects to 770 /* This isn't perfect, but I don't expect a lot of objects to
791 * to have move_allow right now. 771 * have move_allow right now.
792 */ 772 */
793 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
794 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
795 m.flags_ = 0; 775 m.flags_ = 0;
796 } 776 }
850{ 830{
851 /* If already on active list, don't do anything */ 831 /* If already on active list, don't do anything */
852 if (active) 832 if (active)
853 return; 833 return;
854 834
835 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
836 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
837
855 if (has_active_speed ()) 838 if (has_active_speed ())
856 actives.insert (this); 839 actives.insert (this);
857} 840}
858 841
859void 842void
922 * drop on that space. 905 * drop on that space.
923 */ 906 */
924 if (!drop_to_ground 907 if (!drop_to_ground
925 || !map 908 || !map
926 || map->in_memory != MAP_ACTIVE 909 || map->in_memory != MAP_ACTIVE
927 || map->nodrop 910 || map->no_drop
928 || ms ().move_block == MOVE_ALL) 911 || ms ().move_block == MOVE_ALL)
929 { 912 {
930 while (inv) 913 while (inv)
931 {
932 inv->destroy_inv (false);
933 inv->destroy (); 914 inv->destroy (true);
934 }
935 } 915 }
936 else 916 else
937 { /* Put objects in inventory onto this space */ 917 { /* Put objects in inventory onto this space */
938 while (inv) 918 while (inv)
939 { 919 {
961 941
962static struct freed_map : maptile 942static struct freed_map : maptile
963{ 943{
964 freed_map () 944 freed_map ()
965 { 945 {
966 path = "<freed objects map>"; 946 path = "<freed objects map>";
967 name = "/internal/freed_objects_map"; 947 name = "/internal/freed_objects_map";
968 width = 3; 948 width = 3;
969 height = 3; 949 height = 3;
970 nodrop = 1; 950 no_drop = 1;
951 no_reset = 1;
971 952
972 alloc (); 953 alloc ();
973 in_memory = MAP_ACTIVE; 954 in_memory = MAP_ACTIVE;
955 }
956
957 ~freed_map ()
958 {
959 destroy ();
974 } 960 }
975} freed_map; // freed objects are moved here to avoid crashes 961} freed_map; // freed objects are moved here to avoid crashes
976 962
977void 963void
978object::do_destroy () 964object::do_destroy ()
997 x = 1; 983 x = 1;
998 y = 1; 984 y = 1;
999 985
1000 if (more) 986 if (more)
1001 { 987 {
1002 more->destroy (); 988 more->destroy (true);
1003 more = 0; 989 more = 0;
1004 } 990 }
1005 991
1006 head = 0; 992 head = 0;
1007 993
1069 if (object *pl = visible_to ()) 1055 if (object *pl = visible_to ())
1070 esrv_del_item (pl->contr, count); 1056 esrv_del_item (pl->contr, count);
1071 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1057 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1072 1058
1073 adjust_weight (env, -total_weight ()); 1059 adjust_weight (env, -total_weight ());
1074
1075 *(above ? &above->below : &env->inv) = below;
1076
1077 if (below)
1078 below->above = above;
1079 1060
1080 /* we set up values so that it could be inserted into 1061 /* we set up values so that it could be inserted into
1081 * the map, but we don't actually do that - it is up 1062 * the map, but we don't actually do that - it is up
1082 * to the caller to decide what we want to do. 1063 * to the caller to decide what we want to do.
1083 */ 1064 */
1084 map = env->map; 1065 map = env->map;
1085 x = env->x; 1066 x = env->x;
1086 y = env->y; 1067 y = env->y;
1068
1069 // make sure cmov optimisation is applicable
1070 *(above ? &above->below : &env->inv) = below;
1071 *(below ? &below->above : &above ) = above; // &above is just a dummy
1072
1087 above = 0; 1073 above = 0;
1088 below = 0; 1074 below = 0;
1089 env = 0; 1075 env = 0;
1090 1076
1091 /* NO_FIX_PLAYER is set when a great many changes are being 1077 /* NO_FIX_PLAYER is set when a great many changes are being
1121 1107
1122 esrv_del_item (pl->contr, count); 1108 esrv_del_item (pl->contr, count);
1123 } 1109 }
1124 1110
1125 /* link the object above us */ 1111 /* link the object above us */
1126 if (above) 1112 // re-link, make sure compiler can easily use cmove
1127 above->below = below; 1113 *(above ? &above->below : &ms.top) = below;
1128 else 1114 *(below ? &below->above : &ms.bot) = above;
1129 ms.top = below; /* we were top, set new top */
1130
1131 /* Relink the object below us, if there is one */
1132 if (below)
1133 below->above = above;
1134 else
1135 {
1136 /* Nothing below, which means we need to relink map object for this space
1137 * use translated coordinates in case some oddness with map tiling is
1138 * evident
1139 */
1140 if (GET_MAP_OB (map, x, y) != this)
1141 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1142
1143 ms.bot = above; /* goes on above it. */
1144 }
1145 1115
1146 above = 0; 1116 above = 0;
1147 below = 0; 1117 below = 0;
1118
1119 ms.flags_ = 0;
1148 1120
1149 if (map->in_memory == MAP_SAVING) 1121 if (map->in_memory == MAP_SAVING)
1150 return; 1122 return;
1151 1123
1152 int check_walk_off = !flag [FLAG_NO_APPLY]; 1124 int check_walk_off = !flag [FLAG_NO_APPLY];
1159 * appropriately. 1131 * appropriately.
1160 */ 1132 */
1161 pl->close_container (); 1133 pl->close_container ();
1162 1134
1163 //TODO: the floorbox prev/next might need updating 1135 //TODO: the floorbox prev/next might need updating
1164 esrv_del_item (pl->contr, count); 1136 //esrv_del_item (pl->contr, count);
1137 //TODO: update floorbox to preserve ordering
1138 if (pl->contr->ns)
1139 pl->contr->ns->floorbox_update ();
1165 } 1140 }
1166 1141
1167 for (tmp = ms.bot; tmp; tmp = tmp->above) 1142 for (tmp = ms.bot; tmp; tmp = tmp->above)
1168 { 1143 {
1169 /* No point updating the players look faces if he is the object 1144 /* No point updating the players look faces if he is the object
1182 } 1157 }
1183 1158
1184 last = tmp; 1159 last = tmp;
1185 } 1160 }
1186 1161
1187 /* last == NULL if there are no objects on this space */
1188 //TODO: this makes little sense, why only update the topmost object?
1189 if (!last)
1190 map->at (x, y).flags_ = 0;
1191 else
1192 update_object (last, UP_OBJ_REMOVE);
1193
1194 if (flag [FLAG_BLOCKSVIEW] || glow_radius) 1162 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1195 update_all_los (map, x, y); 1163 update_all_los (map, x, y);
1196 } 1164 }
1197} 1165}
1198 1166
1223 esrv_update_item (UPD_NROF, pl, top); 1191 esrv_update_item (UPD_NROF, pl, top);
1224 1192
1225 op->weight = 0; // cancel the addition above 1193 op->weight = 0; // cancel the addition above
1226 op->carrying = 0; // must be 0 already 1194 op->carrying = 0; // must be 0 already
1227 1195
1228 op->destroy (1); 1196 op->destroy (true);
1229 1197
1230 return top; 1198 return top;
1231 } 1199 }
1232 1200
1233 return 0; 1201 return 0;
1261 * job preparing multi-part monsters. 1229 * job preparing multi-part monsters.
1262 */ 1230 */
1263object * 1231object *
1264insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1232insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1265{ 1233{
1234 op->remove ();
1235
1266 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1236 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1267 { 1237 {
1268 tmp->x = x + tmp->arch->x; 1238 tmp->x = x + tmp->arch->x;
1269 tmp->y = y + tmp->arch->y; 1239 tmp->y = y + tmp->arch->y;
1270 } 1240 }
1293 * just 'op' otherwise 1263 * just 'op' otherwise
1294 */ 1264 */
1295object * 1265object *
1296insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1266insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1297{ 1267{
1298 assert (!op->flag [FLAG_FREED]); 1268 if (op->is_on_map ())
1269 {
1270 LOG (llevError, "insert_ob_in_map called for object already on map");
1271 abort ();
1272 }
1299 1273
1274 if (op->env)
1275 {
1276 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1300 op->remove (); 1277 op->remove ();
1278 }
1279
1280 if (m == &freed_map)//D TODO: remove soon
1281 {//D
1282 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1283 }//D
1301 1284
1302 /* Ideally, the caller figures this out. However, it complicates a lot 1285 /* Ideally, the caller figures this out. However, it complicates a lot
1303 * of areas of callers (eg, anything that uses find_free_spot would now 1286 * of areas of callers (eg, anything that uses find_free_spot would now
1304 * need extra work 1287 * need extra work
1305 */ 1288 */
1306 if (!xy_normalise (m, op->x, op->y)) 1289 if (!xy_normalise (m, op->x, op->y))
1307 { 1290 {
1308 op->destroy (1); 1291 op->head_ ()->destroy (true);// remove head_ once all tail object destroyers found
1309 return 0; 1292 return 0;
1310 } 1293 }
1311 1294
1312 if (object *more = op->more) 1295 if (object *more = op->more)
1313 if (!insert_ob_in_map (more, m, originator, flag)) 1296 if (!insert_ob_in_map (more, m, originator, flag))
1322 */ 1305 */
1323 if (op->nrof && !(flag & INS_NO_MERGE)) 1306 if (op->nrof && !(flag & INS_NO_MERGE))
1324 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1307 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1325 if (object::can_merge (op, tmp)) 1308 if (object::can_merge (op, tmp))
1326 { 1309 {
1327 // TODO: we atcually want to update tmp, not op, 1310 // TODO: we actually want to update tmp, not op,
1328 // but some caller surely breaks when we return tmp 1311 // but some caller surely breaks when we return tmp
1329 // from here :/ 1312 // from here :/
1330 op->nrof += tmp->nrof; 1313 op->nrof += tmp->nrof;
1331 tmp->destroy (1); 1314 tmp->destroy (true);
1332 } 1315 }
1333 1316
1334 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1317 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1335 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1318 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1336 1319
1343 { 1326 {
1344 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1327 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1345 abort (); 1328 abort ();
1346 } 1329 }
1347 1330
1331 if (!originator->is_on_map ())
1332 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1333 op->debug_desc (), originator->debug_desc ());
1334
1348 op->above = originator; 1335 op->above = originator;
1349 op->below = originator->below; 1336 op->below = originator->below;
1350
1351 if (op->below)
1352 op->below->above = op;
1353 else
1354 ms.bot = op;
1355
1356 /* since *below* originator, no need to update top */
1357 originator->below = op; 1337 originator->below = op;
1338
1339 *(op->below ? &op->below->above : &ms.bot) = op;
1358 } 1340 }
1359 else 1341 else
1360 { 1342 {
1361 object *top, *floor = NULL; 1343 object *floor = 0;
1362 1344 object *top = ms.top;
1363 top = ms.bot;
1364 1345
1365 /* If there are other objects, then */ 1346 /* If there are other objects, then */
1366 if (top) 1347 if (top)
1367 { 1348 {
1368 object *last = 0;
1369
1370 /* 1349 /*
1371 * If there are multiple objects on this space, we do some trickier handling. 1350 * If there are multiple objects on this space, we do some trickier handling.
1372 * We've already dealt with merging if appropriate. 1351 * We've already dealt with merging if appropriate.
1373 * Generally, we want to put the new object on top. But if 1352 * Generally, we want to put the new object on top. But if
1374 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1353 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1377 * once we get to them. This reduces the need to traverse over all of 1356 * once we get to them. This reduces the need to traverse over all of
1378 * them when adding another one - this saves quite a bit of cpu time 1357 * them when adding another one - this saves quite a bit of cpu time
1379 * when lots of spells are cast in one area. Currently, it is presumed 1358 * when lots of spells are cast in one area. Currently, it is presumed
1380 * that flying non pickable objects are spell objects. 1359 * that flying non pickable objects are spell objects.
1381 */ 1360 */
1382 for (top = ms.bot; top; top = top->above) 1361 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1383 { 1362 {
1384 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1363 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1385 floor = top; 1364 floor = tmp;
1386 1365
1387 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1366 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1388 { 1367 {
1389 /* We insert above top, so we want this object below this */ 1368 /* We insert above top, so we want this object below this */
1390 top = top->below; 1369 top = tmp->below;
1391 break; 1370 break;
1392 } 1371 }
1393 1372
1394 last = top; 1373 top = tmp;
1395 } 1374 }
1396
1397 /* Don't want top to be NULL, so set it to the last valid object */
1398 top = last;
1399 1375
1400 /* We let update_position deal with figuring out what the space 1376 /* We let update_position deal with figuring out what the space
1401 * looks like instead of lots of conditions here. 1377 * looks like instead of lots of conditions here.
1402 * makes things faster, and effectively the same result. 1378 * makes things faster, and effectively the same result.
1403 */ 1379 */
1410 */ 1386 */
1411 if (!(flag & INS_ON_TOP) 1387 if (!(flag & INS_ON_TOP)
1412 && ms.flags () & P_BLOCKSVIEW 1388 && ms.flags () & P_BLOCKSVIEW
1413 && (op->face && !faces [op->face].visibility)) 1389 && (op->face && !faces [op->face].visibility))
1414 { 1390 {
1391 object *last;
1392
1415 for (last = top; last != floor; last = last->below) 1393 for (last = top; last != floor; last = last->below)
1416 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1394 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1417 break; 1395 break;
1418 1396
1419 /* Check to see if we found the object that blocks view, 1397 /* Check to see if we found the object that blocks view,
1427 } /* If objects on this space */ 1405 } /* If objects on this space */
1428 1406
1429 if (flag & INS_ABOVE_FLOOR_ONLY) 1407 if (flag & INS_ABOVE_FLOOR_ONLY)
1430 top = floor; 1408 top = floor;
1431 1409
1432 /* Top is the object that our object (op) is going to get inserted above. 1410 // insert object above top, or bottom-most if top = 0
1433 */
1434
1435 /* First object on this space */
1436 if (!top) 1411 if (!top)
1437 { 1412 {
1413 op->below = 0;
1438 op->above = ms.bot; 1414 op->above = ms.bot;
1439
1440 if (op->above)
1441 op->above->below = op;
1442
1443 op->below = 0;
1444 ms.bot = op; 1415 ms.bot = op;
1416
1417 *(op->above ? &op->above->below : &ms.top) = op;
1445 } 1418 }
1446 else 1419 else
1447 { /* get inserted into the stack above top */ 1420 {
1448 op->above = top->above; 1421 op->above = top->above;
1449
1450 if (op->above)
1451 op->above->below = op; 1422 top->above = op;
1452 1423
1453 op->below = top; 1424 op->below = top;
1454 top->above = op; 1425 *(op->above ? &op->above->below : &ms.top) = op;
1455 } 1426 }
1456 1427 }
1457 if (!op->above)
1458 ms.top = op;
1459 } /* else not INS_BELOW_ORIGINATOR */
1460 1428
1461 if (op->type == PLAYER) 1429 if (op->type == PLAYER)
1462 { 1430 {
1463 op->contr->do_los = 1; 1431 op->contr->do_los = 1;
1464 ++op->map->players; 1432 ++op->map->players;
1467 1435
1468 op->map->dirty = true; 1436 op->map->dirty = true;
1469 1437
1470 if (object *pl = ms.player ()) 1438 if (object *pl = ms.player ())
1471 //TODO: the floorbox prev/next might need updating 1439 //TODO: the floorbox prev/next might need updating
1472 esrv_send_item (pl, op); 1440 //esrv_send_item (pl, op);
1441 //TODO: update floorbox to preserve ordering
1442 if (pl->contr->ns)
1443 pl->contr->ns->floorbox_update ();
1473 1444
1474 /* If this object glows, it may affect lighting conditions that are 1445 /* If this object glows, it may affect lighting conditions that are
1475 * visible to others on this map. But update_all_los is really 1446 * visible to others on this map. But update_all_los is really
1476 * an inefficient way to do this, as it means los for all players 1447 * an inefficient way to do this, as it means los for all players
1477 * on the map will get recalculated. The players could very well 1448 * on the map will get recalculated. The players could very well
1523{ 1494{
1524 /* first search for itself and remove any old instances */ 1495 /* first search for itself and remove any old instances */
1525 1496
1526 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1497 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1527 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1498 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1528 tmp->destroy (1); 1499 tmp->destroy (true);
1529 1500
1530 object *tmp = arch_to_object (archetype::find (arch_string)); 1501 object *tmp = arch_to_object (archetype::find (arch_string));
1531 1502
1532 tmp->x = op->x; 1503 tmp->x = op->x;
1533 tmp->y = op->y; 1504 tmp->y = op->y;
1557 if (!nr) 1528 if (!nr)
1558 return true; 1529 return true;
1559 1530
1560 nr = min (nr, nrof); 1531 nr = min (nr, nrof);
1561 1532
1533 if (nrof > nr)
1534 {
1562 nrof -= nr; 1535 nrof -= nr;
1563
1564 if (nrof)
1565 {
1566 adjust_weight (env, -weight * nr); // carrying == 0 1536 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1567 1537
1568 if (object *pl = visible_to ()) 1538 if (object *pl = visible_to ())
1569 esrv_update_item (UPD_NROF, pl, this); 1539 esrv_update_item (UPD_NROF, pl, this);
1570 1540
1571 return true; 1541 return true;
1572 } 1542 }
1573 else 1543 else
1574 { 1544 {
1575 destroy (1); 1545 destroy ();
1576 return false; 1546 return false;
1577 } 1547 }
1578} 1548}
1579 1549
1580/* 1550/*
1597 } 1567 }
1598 else 1568 else
1599 { 1569 {
1600 decrease (nr); 1570 decrease (nr);
1601 1571
1602 object *op = object_create_clone (this); 1572 object *op = deep_clone ();
1603 op->nrof = nr; 1573 op->nrof = nr;
1604 return op; 1574 return op;
1605 } 1575 }
1606} 1576}
1607 1577
1657 if (object *pl = tmp->visible_to ()) 1627 if (object *pl = tmp->visible_to ())
1658 esrv_update_item (UPD_NROF, pl, tmp); 1628 esrv_update_item (UPD_NROF, pl, tmp);
1659 1629
1660 adjust_weight (this, op->total_weight ()); 1630 adjust_weight (this, op->total_weight ());
1661 1631
1662 op->destroy (1); 1632 op->destroy (true);
1663 op = tmp; 1633 op = tmp;
1664 goto inserted; 1634 goto inserted;
1665 } 1635 }
1666 1636
1667 op->owner = 0; // it's his/hers now. period. 1637 op->owner = 0; // it's his/hers now. period.
1828 LOG (llevError, "Present_arch called outside map.\n"); 1798 LOG (llevError, "Present_arch called outside map.\n");
1829 return NULL; 1799 return NULL;
1830 } 1800 }
1831 1801
1832 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1802 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1833 if (tmp->arch == at) 1803 if (tmp->arch->archname == at->archname)
1834 return tmp; 1804 return tmp;
1835 1805
1836 return NULL; 1806 return NULL;
1837} 1807}
1838 1808
1902 * The first matching object is returned, or NULL if none. 1872 * The first matching object is returned, or NULL if none.
1903 */ 1873 */
1904object * 1874object *
1905present_arch_in_ob (const archetype *at, const object *op) 1875present_arch_in_ob (const archetype *at, const object *op)
1906{ 1876{
1907 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1877 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1908 if (tmp->arch == at) 1878 if (tmp->arch->archname == at->archname)
1909 return tmp; 1879 return tmp;
1910 1880
1911 return NULL; 1881 return NULL;
1912} 1882}
1913 1883
2322 2292
2323/* 2293/*
2324 * create clone from object to another 2294 * create clone from object to another
2325 */ 2295 */
2326object * 2296object *
2327object_create_clone (object *asrc) 2297object::deep_clone ()
2328{ 2298{
2299 assert (("deep_clone called on non-head object", is_head ()));
2300
2329 object *dst = 0; 2301 object *dst = clone ();
2330 2302
2331 if (!asrc)
2332 return 0;
2333
2334 object *src = asrc->head_ ();
2335
2336 object *prev = 0; 2303 object *prev = dst;
2337 for (object *part = src; part; part = part->more) 2304 for (object *part = this->more; part; part = part->more)
2338 { 2305 {
2339 object *tmp = part->clone (); 2306 object *tmp = part->clone ();
2340
2341 tmp->x -= src->x;
2342 tmp->y -= src->y;
2343
2344 if (!part->head)
2345 {
2346 dst = tmp;
2347 tmp->head = 0;
2348 }
2349 else
2350 tmp->head = dst; 2307 tmp->head = dst;
2351
2352 tmp->more = 0;
2353
2354 if (prev)
2355 prev->more = tmp; 2308 prev->more = tmp;
2356
2357 prev = tmp; 2309 prev = tmp;
2358 } 2310 }
2359 2311
2360 for (object *item = src->inv; item; item = item->below) 2312 for (object *item = inv; item; item = item->below)
2361 insert_ob_in_ob (object_create_clone (item), dst); 2313 insert_ob_in_ob (item->deep_clone (), dst);
2362 2314
2363 return dst; 2315 return dst;
2364} 2316}
2365 2317
2366/* This returns the first object in who's inventory that 2318/* This returns the first object in who's inventory that
2375 return tmp; 2327 return tmp;
2376 2328
2377 return 0; 2329 return 0;
2378} 2330}
2379 2331
2380/* If ob has a field named key, return the link from the list, 2332const shstr &
2381 * otherwise return NULL. 2333object::kv_get (const shstr &key) const
2382 *
2383 * key must be a passed in shared string - otherwise, this won't
2384 * do the desired thing.
2385 */
2386key_value *
2387get_ob_key_link (const object *ob, const char *key)
2388{ 2334{
2389 for (key_value *link = ob->key_values; link; link = link->next) 2335 for (key_value *kv = key_values; kv; kv = kv->next)
2390 if (link->key == key) 2336 if (kv->key == key)
2391 return link;
2392
2393 return 0;
2394}
2395
2396/*
2397 * Returns the value of op has an extra_field for key, or NULL.
2398 *
2399 * The argument doesn't need to be a shared string.
2400 *
2401 * The returned string is shared.
2402 */
2403const char *
2404get_ob_key_value (const object *op, const char *const key)
2405{
2406 key_value *link;
2407 shstr_cmp canonical_key (key);
2408
2409 if (!canonical_key)
2410 {
2411 /* 1. There being a field named key on any object
2412 * implies there'd be a shared string to find.
2413 * 2. Since there isn't, no object has this field.
2414 * 3. Therefore, *this* object doesn't have this field.
2415 */
2416 return 0;
2417 }
2418
2419 /* This is copied from get_ob_key_link() above -
2420 * only 4 lines, and saves the function call overhead.
2421 */
2422 for (link = op->key_values; link; link = link->next)
2423 if (link->key == canonical_key)
2424 return link->value; 2337 return kv->value;
2425 2338
2426 return 0; 2339 return shstr_null;
2427} 2340}
2428 2341
2429/* 2342void
2430 * Updates the canonical_key in op to value. 2343object::kv_set (const shstr &key, const shstr &value)
2431 *
2432 * canonical_key is a shared string (value doesn't have to be).
2433 *
2434 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2435 * keys.
2436 *
2437 * Returns TRUE on success.
2438 */
2439int
2440set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2441{ 2344{
2442 key_value *field = NULL, *last = NULL; 2345 for (key_value *kv = key_values; kv; kv = kv->next)
2443 2346 if (kv->key == key)
2444 for (field = op->key_values; field != NULL; field = field->next)
2445 {
2446 if (field->key != canonical_key)
2447 { 2347 {
2448 last = field; 2348 kv->value = value;
2449 continue; 2349 return;
2450 } 2350 }
2451 2351
2452 if (value) 2352 key_value *kv = new key_value;
2453 field->value = value; 2353
2454 else 2354 kv->next = key_values;
2355 kv->key = key;
2356 kv->value = value;
2357
2358 key_values = kv;
2359}
2360
2361void
2362object::kv_del (const shstr &key)
2363{
2364 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2365 if ((*kvp)->key == key)
2455 { 2366 {
2456 /* Basically, if the archetype has this key set, 2367 key_value *kv = *kvp;
2457 * we need to store the null value so when we save 2368 *kvp = (*kvp)->next;
2458 * it, we save the empty value so that when we load, 2369 delete kv;
2459 * we get this value back again. 2370 return;
2460 */
2461 if (get_ob_key_link (op->arch, canonical_key))
2462 field->value = 0;
2463 else
2464 {
2465 if (last)
2466 last->next = field->next;
2467 else
2468 op->key_values = field->next;
2469
2470 delete field;
2471 }
2472 } 2371 }
2473 return TRUE;
2474 }
2475 /* IF we get here, key doesn't exist */
2476
2477 /* No field, we'll have to add it. */
2478
2479 if (!add_key)
2480 return FALSE;
2481
2482 /* There isn't any good reason to store a null
2483 * value in the key/value list. If the archetype has
2484 * this key, then we should also have it, so shouldn't
2485 * be here. If user wants to store empty strings,
2486 * should pass in ""
2487 */
2488 if (value == NULL)
2489 return TRUE;
2490
2491 field = new key_value;
2492
2493 field->key = canonical_key;
2494 field->value = value;
2495 /* Usual prepend-addition. */
2496 field->next = op->key_values;
2497 op->key_values = field;
2498
2499 return TRUE;
2500}
2501
2502/*
2503 * Updates the key in op to value.
2504 *
2505 * If add_key is FALSE, this will only update existing keys,
2506 * and not add new ones.
2507 * In general, should be little reason FALSE is ever passed in for add_key
2508 *
2509 * Returns TRUE on success.
2510 */
2511int
2512set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2513{
2514 shstr key_ (key);
2515
2516 return set_ob_key_value_s (op, key_, value, add_key);
2517} 2372}
2518 2373
2519object::depth_iterator::depth_iterator (object *container) 2374object::depth_iterator::depth_iterator (object *container)
2520: iterator_base (container) 2375: iterator_base (container)
2521{ 2376{
2571{ 2426{
2572 char flagdesc[512]; 2427 char flagdesc[512];
2573 char info2[256 * 4]; 2428 char info2[256 * 4];
2574 char *p = info; 2429 char *p = info;
2575 2430
2576 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2431 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2577 count, 2432 count,
2578 uuid.c_str (), 2433 uuid.c_str (),
2579 &name, 2434 &name,
2580 title ? "\",title:\"" : "", 2435 title ? ",title:\"" : "",
2581 title ? (const char *)title : "", 2436 title ? (const char *)title : "",
2437 title ? "\"" : "",
2582 flag_desc (flagdesc, 512), type); 2438 flag_desc (flagdesc, 512), type);
2583 2439
2584 if (!flag[FLAG_REMOVED] && env) 2440 if (!flag[FLAG_REMOVED] && env)
2585 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2441 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2586 2442
2630 2486
2631#if 0 2487#if 0
2632 // remove the "Close old_container" object. 2488 // remove the "Close old_container" object.
2633 if (object *closer = old_container->inv) 2489 if (object *closer = old_container->inv)
2634 if (closer->type == CLOSE_CON) 2490 if (closer->type == CLOSE_CON)
2635 closer->destroy (); 2491 closer->destroy (true);
2636#endif 2492#endif
2637 2493
2638 // make sure the container is available 2494 // make sure the container is available
2639 esrv_send_item (this, old_container); 2495 esrv_send_item (this, old_container);
2640 2496
2696 2552
2697void 2553void
2698object::force_add (const shstr name, int duration) 2554object::force_add (const shstr name, int duration)
2699{ 2555{
2700 if (object *force = force_find (name)) 2556 if (object *force = force_find (name))
2701 force->destroy (); 2557 force->destroy (true);
2702 2558
2703 object *force = get_archetype (FORCE_NAME); 2559 object *force = get_archetype (FORCE_NAME);
2704 2560
2705 force->slaying = name; 2561 force->slaying = name;
2706 force->stats.food = 1; 2562 force->stats.food = 1;

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines