ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.258 by root, Mon Sep 29 09:04:50 2008 UTC vs.
Revision 1.354 by root, Mon Oct 29 23:55:52 2012 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
40 49
41short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
42 0, 51 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 57 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 61};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
60 0, 63 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 67};
65 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
76const char *wall_suffix[16] = {
77 "0",
78 "1_3",
79 "1_4",
80 "2_1_2",
81 "1_2",
82 "2_2_4",
83 "2_2_1",
84 "3_1",
85 "1_1",
86 "2_2_3",
87 "2_2_2",
88 "3_3",
89 "2_1_1",
90 "3_4",
91 "3_2",
92 "4"
93};
94
66static void 95static void
67write_uuid (uval64 skip, bool sync) 96write_uuid (uval64 skip, bool sync)
68{ 97{
69 CALL_BEGIN (2); 98 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 99 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 101 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 102 CALL_END;
74} 103}
75 104
76static void 105static void
77read_uuid (void) 106read_uuid ()
78{ 107{
79 char filename[MAX_BUF]; 108 char filename[MAX_BUF];
80 109
81 sprintf (filename, "%s/uuid", settings.localdir); 110 sprintf (filename, "%s/uuid", settings.localdir);
82 111
96 125
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 126 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 127 _exit (1);
99 } 128 }
100 129
101 UUID::BUF buf; 130 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 131 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 132 fgets (buf, sizeof (buf), fp);
104 133
105 if (!UUID::cur.parse (buf)) 134 if (!UUID::cur.parse (buf))
106 { 135 {
133 162
134void 163void
135UUID::init () 164UUID::init ()
136{ 165{
137 read_uuid (); 166 read_uuid ();
167}
168
169bool
170UUID::parse (const char *s)
171{
172 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
173 return false;
174
175 seq = 0;
176
177 while (*s != '>')
178 {
179 if (*s < '0')
180 return false;
181
182 // this gives nice branchless code with gcc
183 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
184 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
185
186 seq = (seq << 4) | digit;
187
188 ++s;
189 }
190
191 return true;
192}
193
194char *
195UUID::append (char *buf) const
196{
197 *buf++ = '<';
198 *buf++ = '1';
199 *buf++ = '.';
200
201 uint64_t seq = this->seq;
202 const int bits = 64;
203 char nz = 0;
204 static const char tohex [] = "0123456789abcdef";
205
206 // assert (len >= 3 + bits / 4 + 1 + 1);
207 for (int i = bits / 4; --i; )
208 {
209 uint8_t digit = seq >> (bits - 4);
210
211 *buf = tohex [digit];
212 nz |= digit;
213 buf += nz ? 1 : 0;
214 seq <<= 4;
215 }
216
217 // last digit is special - always emit
218 uint8_t digit = seq >> (bits - 4);
219 *buf++ = tohex [digit];
220
221 *buf++ = '>';
222
223 return buf;
224}
225
226char *
227UUID::c_str () const
228{
229 static char buf [MAX_LEN];
230 *append (buf) = 0;
231 return buf;
138} 232}
139 233
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 234/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 235static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 236compare_ob_value_lists_one (const object *wants, const object *has)
143{ 237{
144 /* n-squared behaviour (see kv_get), but I'm hoping both 238 /* n-squared behaviour (see kv.get), but I'm hoping both
145 * objects with lists are rare, and lists stay short. If not, use a 239 * objects with lists are rare, and lists stay short. If not, use a
146 * different structure or at least keep the lists sorted... 240 * different structure or at least keep the lists sorted...
147 */ 241 */
148 242
149 /* For each field in wants, */ 243 /* For each field in wants, */
150 for (key_value *kv = wants->key_values; kv; kv = kv->next) 244 for (key_value *kv = wants->kv.first; kv; kv = kv->next)
151 if (has->kv_get (kv->key) != kv->value) 245 if (has->kv.get (kv->key) != kv->value)
152 return false; 246 return false;
153 247
154 /* If we get here, every field in wants has a matching field in has. */ 248 /* If we get here, every field in wants has a matching field in has. */
155 return true; 249 return true;
156} 250}
178 * Improvements made with merge: Better checking on potion, and also 272 * Improvements made with merge: Better checking on potion, and also
179 * check weight 273 * check weight
180 */ 274 */
181bool object::can_merge_slow (object *ob1, object *ob2) 275bool object::can_merge_slow (object *ob1, object *ob2)
182{ 276{
183 /* A couple quicksanity checks */ 277 /* A couple quick sanity checks */
184 if (ob1 == ob2 278 if (ob1 == ob2
185 || ob1->type != ob2->type 279 || ob1->type != ob2->type
186 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 280 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 281 || ob1->name != ob2->name
282 || ob1->custom_name != ob2->custom_name
283 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
189 return 0; 284 return 0;
190 285
191 /* Do not merge objects if nrof would overflow, assume nrof 286 /* Do not merge objects if nrof would overflow, assume nrof
192 * is always 0 .. 2**31-1 */ 287 * is always 0 .. 2**31-1 */
193 if (ob1->nrof > 0x7fffffff - ob2->nrof) 288 if (ob1->nrof > 0x7fffffff - ob2->nrof)
197 * This is to the comparison of the flags below will be OK. We 292 * This is to the comparison of the flags below will be OK. We
198 * just can't ignore the been applied or identified flags, as they 293 * just can't ignore the been applied or identified flags, as they
199 * are not equal - just if it has been identified, the been_applied 294 * are not equal - just if it has been identified, the been_applied
200 * flags lose any meaning. 295 * flags lose any meaning.
201 */ 296 */
202 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 297 if (ob1->flag [FLAG_IDENTIFIED])
203 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 298 ob1->set_flag (FLAG_BEEN_APPLIED);
204 299
205 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 300 if (ob2->flag [FLAG_IDENTIFIED])
206 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 301 ob2->set_flag (FLAG_BEEN_APPLIED);
207 302
208 if (ob1->arch->archname != ob2->arch->archname 303 if (ob1->arch->archname != ob2->arch->archname
209 || ob1->name != ob2->name 304 || ob1->name != ob2->name
210 || ob1->title != ob2->title 305 || ob1->title != ob2->title
211 || ob1->msg != ob2->msg 306 || ob1->msg != ob2->msg
214 || ob1->magic != ob2->magic 309 || ob1->magic != ob2->magic
215 || ob1->slaying != ob2->slaying 310 || ob1->slaying != ob2->slaying
216 || ob1->skill != ob2->skill 311 || ob1->skill != ob2->skill
217 || ob1->value != ob2->value 312 || ob1->value != ob2->value
218 || ob1->animation_id != ob2->animation_id 313 || ob1->animation_id != ob2->animation_id
219 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other 314 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
220 || ob1->client_type != ob2->client_type 315 || ob1->client_type != ob2->client_type
221 || ob1->materialname != ob2->materialname 316 || ob1->material != ob2->material
222 || ob1->lore != ob2->lore 317 || ob1->lore != ob2->lore
223 || ob1->subtype != ob2->subtype 318 || ob1->subtype != ob2->subtype
224 || ob1->move_type != ob2->move_type 319 || ob1->move_type != ob2->move_type
225 || ob1->move_block != ob2->move_block 320 || ob1->move_block != ob2->move_block
226 || ob1->move_allow != ob2->move_allow 321 || ob1->move_allow != ob2->move_allow
227 || ob1->move_on != ob2->move_on 322 || ob1->move_on != ob2->move_on
228 || ob1->move_off != ob2->move_off 323 || ob1->move_off != ob2->move_off
229 || ob1->move_slow != ob2->move_slow 324 || ob1->move_slow != ob2->move_slow
230 || ob1->move_slow_penalty != ob2->move_slow_penalty 325 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 326 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 327 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
233 return 0; 328 return 0;
234 329
235 if ((ob1->flag ^ ob2->flag) 330 if ((ob1->flag ^ ob2->flag)
260 355
261 /* Don't merge objects that are applied. With the new 'body' code, 356 /* Don't merge objects that are applied. With the new 'body' code,
262 * it is possible for most any character to have more than one of 357 * it is possible for most any character to have more than one of
263 * some items equipped, and we don't want those to merge. 358 * some items equipped, and we don't want those to merge.
264 */ 359 */
265 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 360 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
266 return 0; 361 return 0;
267 362
268 /* Note sure why the following is the case - either the object has to 363 /* Note sure why the following is the case - either the object has to
269 * be animated or have a very low speed. Is this an attempted monster 364 * be animated or have a very low speed. Is this an attempted monster
270 * check? 365 * check?
271 */ 366 */
272 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 367 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
273 return 0; 368 return 0;
274 369
275 switch (ob1->type) 370 switch (ob1->type)
276 { 371 {
277 case SCROLL: 372 case SCROLL:
278 if (ob1->level != ob2->level) 373 if (ob1->level != ob2->level)
279 return 0; 374 return 0;
280 break; 375 break;
281 } 376 }
282 377
283 if (ob1->key_values || ob2->key_values) 378 if (!ob1->kv.empty () || !ob2->kv.empty ())
284 { 379 {
285 /* At least one of these has key_values. */ 380 /* At least one of these has key_values. */
286 if ((!ob1->key_values) != (!ob2->key_values)) 381 if (ob1->kv.empty () != ob2->kv.empty ())
287 return 0; /* One has fields, but the other one doesn't. */ 382 return 0; /* One has fields, but the other one doesn't. */
288 383
289 if (!compare_ob_value_lists (ob1, ob2)) 384 if (!compare_ob_value_lists (ob1, ob2))
290 return 0; 385 return 0;
291 } 386 }
323 { 418 {
324 // see if we are in a container of sorts 419 // see if we are in a container of sorts
325 if (env) 420 if (env)
326 { 421 {
327 // the player inventory itself is always visible 422 // the player inventory itself is always visible
328 if (env->type == PLAYER) 423 if (env->is_player ())
329 return env; 424 return env;
330 425
331 // else a player could have our env open 426 // else a player could have our env open
332 object *envest = env->outer_env (); 427 object *envest = env->outer_env_or_self ();
333 428
334 // the player itself is always on a map, so we will find him here 429 // the player itself is always on a map, so we will find him here
335 // even if our inv is in a player. 430 // even if our inv is in a player.
336 if (envest->is_on_map ()) 431 if (envest->is_on_map ())
337 if (object *pl = envest->ms ().player ()) 432 if (object *pl = envest->ms ().player ())
338 if (pl->container == env) 433 if (pl->container_ () == env)
339 return pl; 434 return pl;
340 } 435 }
341 else 436 else
342 { 437 {
343 // maybe there is a player standing on the same mapspace 438 // maybe there is a player standing on the same mapspace
344 // this will catch the case where "this" is a player 439 // this will catch the case where "this" is a player
345 if (object *pl = ms ().player ()) 440 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look) 441 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
347 || this == pl->container) 442 || pl->container_ () == this)
348 return pl; 443 return pl;
349 } 444 }
350 } 445 }
351 446
352 return 0; 447 return 0;
353} 448}
354 449
355// adjust weight per container type ("of holding") 450// adjust weight per container type ("of holding")
356static sint32 451static uint32
357weight_adjust_for (object *op, sint32 weight) 452weight_adjust_for (object *op, uint32 weight)
358{ 453{
359 return op->type == CONTAINER 454 return op->type == CONTAINER
360 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 455 ? weight - weight * op->stats.Str / 100
361 : weight; 456 : weight;
362} 457}
363 458
364/* 459/*
365 * adjust_weight(object, weight) adds the specified weight to an object, 460 * subtracts, then adds, the specified weight to an object,
366 * and also updates how much the environment(s) is/are carrying. 461 * and also updates how much the environment(s) is/are carrying.
367 */ 462 */
368static void 463static void
369adjust_weight (object *op, sint32 weight) 464adjust_weight (object *op, sint32 sub, sint32 add)
370{ 465{
371 while (op) 466 while (op)
372 { 467 {
373 // adjust by actual difference to account for rounding errors 468 sint32 ocarrying = op->carrying;
374 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
375 weight = weight_adjust_for (op, op->carrying)
376 - weight_adjust_for (op, op->carrying - weight);
377 469
378 if (!weight) 470 op->carrying -= weight_adjust_for (op, sub);
379 return; 471 op->carrying += weight_adjust_for (op, add);
380
381 op->carrying += weight;
382 472
383 if (object *pl = op->visible_to ()) 473 if (object *pl = op->visible_to ())
384 if (pl != op) // player is handled lazily 474 if (pl != op) // player is handled lazily
385 esrv_update_item (UPD_WEIGHT, pl, op); 475 esrv_update_item (UPD_WEIGHT, pl, op);
386 476
477 sub = ocarrying;
478 add = op->carrying;
479
387 op = op->env; 480 op = op->env;
388 } 481 }
389} 482}
390 483
391/* 484/*
398{ 491{
399 sint32 sum = 0; 492 sint32 sum = 0;
400 493
401 for (object *op = inv; op; op = op->below) 494 for (object *op = inv; op; op = op->below)
402 { 495 {
403 if (op->inv)
404 op->update_weight (); 496 op->update_weight ();
405 497
406 sum += op->total_weight (); 498 sum += weight_adjust_for (this, op->total_weight ());
407 } 499 }
408
409 sum = weight_adjust_for (this, sum);
410 500
411 if (sum != carrying) 501 if (sum != carrying)
412 { 502 {
503 if (carrying != sum && carrying)//D
504 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
505 (long long)sum, (long long)carrying, debug_desc ());
506
413 carrying = sum; 507 carrying = sum;
414 508
415 if (object *pl = visible_to ()) 509 if (object *pl = visible_to ())
416 if (pl != this) // player is handled lazily 510 if (pl != this) // player is handled lazily
417 esrv_update_item (UPD_WEIGHT, pl, this); 511 esrv_update_item (UPD_WEIGHT, pl, this);
430 object_freezer freezer; 524 object_freezer freezer;
431 op->write (freezer); 525 op->write (freezer);
432 return freezer.as_string (); 526 return freezer.as_string ();
433} 527}
434 528
435/* 529char *
436 * get_nearest_part(multi-object, object 2) returns the part of the 530object::as_string ()
437 * multi-object 1 which is closest to the second object.
438 * If it's not a multi-object, it is returned.
439 */
440object *
441get_nearest_part (object *op, const object *pl)
442{ 531{
443 object *tmp, *closest; 532 return dump_object (this);
444 int last_dist, i;
445
446 if (!op->more)
447 return op;
448
449 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
450 tmp;
451 tmp = tmp->more)
452 if ((i = distance (tmp, pl)) < last_dist)
453 closest = tmp, last_dist = i;
454
455 return closest;
456} 533}
457 534
458/* 535/*
459 * Returns the object which has the count-variable equal to the argument. 536 * Returns the object which has the count-variable equal to the argument.
460 * VERRRY slow. 537 * VERRRY slow.
462object * 539object *
463find_object (tag_t i) 540find_object (tag_t i)
464{ 541{
465 for_all_objects (op) 542 for_all_objects (op)
466 if (op->count == i) 543 if (op->count == i)
544 return op;
545
546 return 0;
547}
548
549/*
550 * Returns the object which has the uuid equal to the argument.
551 * MOAR VERRRY slow.
552 */
553
554object *
555find_object_uuid (UUID i)
556{
557 for_all_objects (op)
558 if (op->uuid == i)
467 return op; 559 return op;
468 560
469 return 0; 561 return 0;
470} 562}
471 563
505 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ()); 597 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
506 return; 598 return;
507 } 599 }
508 600
509 this->owner = owner; 601 this->owner = owner;
510}
511
512int
513object::slottype () const
514{
515 if (type == SKILL)
516 {
517 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
518 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
519 }
520 else
521 {
522 if (slot [body_combat].info) return slot_combat;
523 if (slot [body_range ].info) return slot_ranged;
524 }
525
526 return slot_none;
527}
528
529bool
530object::change_weapon (object *ob)
531{
532 if (current_weapon == ob)
533 return true;
534
535 if (chosen_skill)
536 chosen_skill->flag [FLAG_APPLIED] = false;
537
538 current_weapon = ob;
539 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
540
541 if (chosen_skill)
542 chosen_skill->flag [FLAG_APPLIED] = true;
543
544 update_stats ();
545
546 if (ob)
547 {
548 // now check wether any body locations became invalid, in which case
549 // we cannot apply the weapon at the moment.
550 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
551 if (slot[i].used < 0)
552 {
553 current_weapon = chosen_skill = 0;
554 update_stats ();
555
556 new_draw_info_format (NDI_UNIQUE, 0, this,
557 "You try to balance all your items at once, "
558 "but the %s is just too much for your body. "
559 "[You need to unapply some items first.]", &ob->name);
560 return false;
561 }
562
563 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
564 }
565 else
566 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
567
568 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
569 {
570 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
571 &name, ob->debug_desc ());
572 return false;
573 }
574
575 return true;
576}
577
578/* Zero the key_values on op, decrementing the shared-string
579 * refcounts and freeing the links.
580 */
581static void
582free_key_values (object *op)
583{
584 for (key_value *i = op->key_values; i; )
585 {
586 key_value *next = i->next;
587 delete i;
588
589 i = next;
590 }
591
592 op->key_values = 0;
593} 602}
594 603
595/* 604/*
596 * copy_to first frees everything allocated by the dst object, 605 * copy_to first frees everything allocated by the dst object,
597 * and then copies the contents of itself into the second 606 * and then copies the contents of itself into the second
603void 612void
604object::copy_to (object *dst) 613object::copy_to (object *dst)
605{ 614{
606 dst->remove (); 615 dst->remove ();
607 *(object_copy *)dst = *this; 616 *(object_copy *)dst = *this;
617
618 // maybe move to object_copy?
619 dst->kv = kv;
620
608 dst->flag [FLAG_REMOVED] = true; 621 dst->flag [FLAG_REMOVED] = true;
609
610 /* Copy over key_values, if any. */
611 if (key_values)
612 {
613 key_value *tail = 0;
614 dst->key_values = 0;
615
616 for (key_value *i = key_values; i; i = i->next)
617 {
618 key_value *new_link = new key_value;
619
620 new_link->next = 0;
621 new_link->key = i->key;
622 new_link->value = i->value;
623
624 /* Try and be clever here, too. */
625 if (!dst->key_values)
626 {
627 dst->key_values = new_link;
628 tail = new_link;
629 }
630 else
631 {
632 tail->next = new_link;
633 tail = new_link;
634 }
635 }
636 }
637
638 if (speed < 0)
639 dst->speed_left -= rndm ();
640
641 dst->activate (); 622 dst->activate ();
642} 623}
643 624
644void 625void
645object::instantiate () 626object::instantiate ()
646{ 627{
647 if (!uuid.seq) // HACK 628 if (!uuid.seq) // HACK
648 uuid = UUID::gen (); 629 uuid = UUID::gen ();
649 630
631 // TODO: unclean state changes, should not be done in copy_to AND instantiate
632 if (flag [FLAG_RANDOM_SPEED] && speed)
633 speed_left = - speed - rndm (); // TODO animation
634 else
650 speed_left = -0.1f; 635 speed_left = -1.;
636
651 /* copy the body_info to the body_used - this is only really 637 /* copy the body_info to the body_used - this is only really
652 * need for monsters, but doesn't hurt to do it for everything. 638 * need for monsters, but doesn't hurt to do it for everything.
653 * by doing so, when a monster is created, it has good starting 639 * by doing so, when a monster is created, it has good starting
654 * values for the body_used info, so when items are created 640 * values for the body_used info, so when items are created
655 * for it, they can be properly equipped. 641 * for it, they can be properly equipped.
663object * 649object *
664object::clone () 650object::clone ()
665{ 651{
666 object *neu = create (); 652 object *neu = create ();
667 copy_to (neu); 653 copy_to (neu);
654
655 // TODO: unclean state changes, should not be done in clone AND instantiate
656 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
657 neu->speed_left = - neu->speed - rndm (); // TODO animation
658
668 neu->map = map; // not copied by copy_to 659 neu->map = map; // not copied by copy_to
669 return neu; 660 return neu;
670} 661}
671 662
672/* 663/*
675 * be called to update the face variable, _and_ how it looks on the map. 666 * be called to update the face variable, _and_ how it looks on the map.
676 */ 667 */
677void 668void
678update_turn_face (object *op) 669update_turn_face (object *op)
679{ 670{
680 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 671 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
681 return; 672 return;
682 673
683 SET_ANIMATION (op, op->direction); 674 SET_ANIMATION (op, op->direction);
684 update_object (op, UP_OBJ_FACE); 675 update_object (op, UP_OBJ_FACE);
685} 676}
690 * This function needs to be called whenever the speed of an object changes. 681 * This function needs to be called whenever the speed of an object changes.
691 */ 682 */
692void 683void
693object::set_speed (float speed) 684object::set_speed (float speed)
694{ 685{
695 if (flag [FLAG_FREED] && speed)
696 {
697 LOG (llevError, "Object %s is freed but has speed.\n", &name);
698 speed = 0;
699 }
700
701 this->speed = speed; 686 this->speed = speed;
702 687
703 if (has_active_speed ()) 688 if (has_active_speed ())
704 activate (); 689 activate ();
705 else 690 else
752 } 737 }
753 738
754 mapspace &m = op->ms (); 739 mapspace &m = op->ms ();
755 740
756 if (!(m.flags_ & P_UPTODATE)) 741 if (!(m.flags_ & P_UPTODATE))
757 /* nop */; 742 m.update_up (); // nothing to do except copy up
758 else if (action == UP_OBJ_INSERT) 743 else if (action == UP_OBJ_INSERT)
759 { 744 {
745#if 0
760 // this is likely overkill, TODO: revisit (schmorp) 746 // this is likely overkill, TODO: revisit (schmorp)
761 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 747 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
762 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 748 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
763 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 749 || (op->is_player () && !(m.flags_ & P_PLAYER))
764 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 750 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
765 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 751 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 752 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
767 || (m.move_on | op->move_on ) != m.move_on 753 || (m.move_on | op->move_on ) != m.move_on
768 || (m.move_off | op->move_off ) != m.move_off 754 || (m.move_off | op->move_off ) != m.move_off
769 || (m.move_slow | op->move_slow) != m.move_slow 755 || (m.move_slow | op->move_slow) != m.move_slow
770 /* This isn't perfect, but I don't expect a lot of objects to 756 /* This isn't perfect, but I don't expect a lot of objects to
771 * have move_allow right now. 757 * have move_allow right now.
772 */ 758 */
773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 759 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
760 m.invalidate ();
761#else
774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 762 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
775 m.flags_ = 0; 763 m.invalidate ();
764#endif
776 } 765 }
777 /* if the object is being removed, we can't make intelligent 766 /* if the object is being removed, we can't make intelligent
778 * decisions, because remove_ob can't really pass the object 767 * decisions, because remove_ob can't really pass the object
779 * that is being removed. 768 * that is being removed.
780 */ 769 */
781 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 770 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
782 m.flags_ = 0; 771 m.invalidate ();
783 else if (action == UP_OBJ_FACE) 772 else if (action == UP_OBJ_FACE)
784 /* Nothing to do for that case */ ; 773 m.update_up (); // nothing to do for that case, except copy up
785 else 774 else
786 LOG (llevError, "update_object called with invalid action: %d\n", action); 775 LOG (llevError, "update_object called with invalid action: %d\n", action);
787 776
788 if (op->more) 777 if (op->more)
789 update_object (op->more, action); 778 update_object (op->more, action);
790} 779}
791 780
792object::object () 781object::object ()
793{ 782{
794 SET_FLAG (this, FLAG_REMOVED); 783 this->set_flag (FLAG_REMOVED);
795 784
796 expmul = 1.0; 785 //expmul = 1.0; declared const for the time being
797 face = blank_face; 786 face = blank_face;
787 material = MATERIAL_NULL;
798} 788}
799 789
800object::~object () 790object::~object ()
801{ 791{
802 unlink (); 792 unlink ();
803 793
804 free_key_values (this); 794 kv.clear ();
805} 795}
806
807static int object_count;
808 796
809void object::link () 797void object::link ()
810{ 798{
811 assert (!index);//D 799 assert (!index);//D
812 uuid = UUID::gen (); 800 uuid = UUID::gen ();
813 count = ++object_count;
814 801
815 refcnt_inc (); 802 refcnt_inc ();
816 objects.insert (this); 803 objects.insert (this);
804
805 ++create_count;
806
817} 807}
818 808
819void object::unlink () 809void object::unlink ()
820{ 810{
821 if (!index) 811 if (!index)
822 return; 812 return;
813
814 ++destroy_count;
823 815
824 objects.erase (this); 816 objects.erase (this);
825 refcnt_dec (); 817 refcnt_dec ();
826} 818}
827 819
830{ 822{
831 /* If already on active list, don't do anything */ 823 /* If already on active list, don't do anything */
832 if (active) 824 if (active)
833 return; 825 return;
834 826
835 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
836 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
837
838 if (has_active_speed ()) 827 if (has_active_speed ())
828 {
829 if (flag [FLAG_FREED])
830 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
831
839 actives.insert (this); 832 actives.insert (this);
833 }
840} 834}
841 835
842void 836void
843object::activate_recursive () 837object::activate_recursive ()
844{ 838{
904 * if some form of movement is allowed, let objects 898 * if some form of movement is allowed, let objects
905 * drop on that space. 899 * drop on that space.
906 */ 900 */
907 if (!drop_to_ground 901 if (!drop_to_ground
908 || !map 902 || !map
909 || map->in_memory != MAP_ACTIVE 903 || !map->linkable ()
910 || map->no_drop 904 || map->no_drop
911 || ms ().move_block == MOVE_ALL) 905 || ms ().move_block == MOVE_ALL)
912 { 906 {
913 while (inv) 907 while (inv)
914 inv->destroy (true); 908 inv->destroy ();
915 } 909 }
916 else 910 else
917 { /* Put objects in inventory onto this space */ 911 { /* Put objects in inventory onto this space */
918 while (inv) 912 while (inv)
919 { 913 {
923 || op->flag [FLAG_NO_DROP] 917 || op->flag [FLAG_NO_DROP]
924 || op->type == RUNE 918 || op->type == RUNE
925 || op->type == TRAP 919 || op->type == TRAP
926 || op->flag [FLAG_IS_A_TEMPLATE] 920 || op->flag [FLAG_IS_A_TEMPLATE]
927 || op->flag [FLAG_DESTROY_ON_DEATH]) 921 || op->flag [FLAG_DESTROY_ON_DEATH])
928 op->destroy (true); 922 op->destroy ();
929 else 923 else
930 map->insert (op, x, y); 924 map->insert (op, x, y);
931 } 925 }
932 } 926 }
933} 927}
934 928
929/*
930 * Remove and free all objects in the inventory of the given object.
931 * Unlike destroy_inv, this assumes the *this is destroyed as well
932 * well, so we can (and have to!) take shortcuts.
933 */
934void
935object::destroy_inv_fast ()
936{
937 while (object *op = inv)
938 {
939 // remove from object the fast way
940 op->flag [FLAG_REMOVED] = true;
941 op->env = 0;
942 if ((inv = inv->below))
943 inv->above = 0;
944
945 // then destroy
946 op->destroy ();
947 }
948}
949
950void
951object::freelist_free (int count)
952{
953 while (count-- && freelist)
954 {
955 freelist_item *next = freelist->next;
956 // count is being "destroyed"
957
958 sfree ((char *)freelist, sizeof (object));
959
960 freelist = next;
961 --free_count;
962 }
963}
964
965object *
935object *object::create () 966object::create ()
936{ 967{
937 object *op = new object; 968 object *op;
969
970 if (freelist)
971 {
972 freelist_item li = *freelist;
973 memset (freelist, 0, sizeof (object));
974
975 op = new (freelist) object;
976 op->count = li.count;
977
978 freelist = li.next;
979 --free_count;
980 }
981 else
982 {
983 void *ni = salloc0<char> (sizeof (object));
984
985 op = new(ni) object;
986
987 op->count = ++object_count;
988 }
989
938 op->link (); 990 op->link ();
991
939 return op; 992 return op;
940} 993}
941 994
942static struct freed_map : maptile 995void
996object::do_delete ()
943{ 997{
944 freed_map () 998 uint32_t count = this->count;
945 {
946 path = "<freed objects map>";
947 name = "/internal/freed_objects_map";
948 width = 3;
949 height = 3;
950 no_drop = 1;
951 no_reset = 1;
952 999
953 alloc (); 1000 this->~object ();
954 in_memory = MAP_ACTIVE;
955 }
956 1001
957 ~freed_map () 1002 freelist_item *li = (freelist_item *)this;
958 { 1003 li->next = freelist;
959 destroy (); 1004 li->count = count;
960 } 1005
961} freed_map; // freed objects are moved here to avoid crashes 1006 freelist = li;
1007 ++free_count;
1008}
962 1009
963void 1010void
964object::do_destroy () 1011object::do_destroy ()
965{ 1012{
966 if (flag [FLAG_IS_LINKED]) 1013 if (flag [FLAG_IS_LINKED])
967 remove_button_link (this); 1014 remove_link ();
968 1015
969 if (flag [FLAG_FRIENDLY]) 1016 if (flag [FLAG_FRIENDLY])
970 remove_friendly_object (this); 1017 remove_friendly_object (this);
971 1018
972 remove (); 1019 remove ();
983 x = 1; 1030 x = 1;
984 y = 1; 1031 y = 1;
985 1032
986 if (more) 1033 if (more)
987 { 1034 {
988 more->destroy (true); 1035 more->destroy ();
989 more = 0; 1036 more = 0;
990 } 1037 }
991 1038
992 head = 0; 1039 head = 0;
993 1040
997 attacked_by = 0; 1044 attacked_by = 0;
998 current_weapon = 0; 1045 current_weapon = 0;
999} 1046}
1000 1047
1001void 1048void
1002object::destroy (bool destroy_inventory) 1049object::destroy ()
1003{ 1050{
1004 if (destroyed ()) 1051 if (destroyed ())
1005 return; 1052 return;
1006 1053
1007 if (!is_head () && !head->destroyed ()) 1054 if (!is_head () && !head->destroyed ())
1008 { 1055 {
1009 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1056 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1010 head->destroy (destroy_inventory); 1057 head->destroy ();
1011 return; 1058 return;
1012 } 1059 }
1013 1060
1014 destroy_inv (!destroy_inventory); 1061 destroy_inv_fast ();
1015 1062
1016 if (is_head ()) 1063 if (is_head ())
1017 if (sound_destroy) 1064 if (sound_destroy)
1018 play_sound (sound_destroy); 1065 play_sound (sound_destroy);
1019 else if (flag [FLAG_MONSTER]) 1066 else if (flag [FLAG_MONSTER])
1030 * the previous environment. 1077 * the previous environment.
1031 */ 1078 */
1032void 1079void
1033object::do_remove () 1080object::do_remove ()
1034{ 1081{
1035 object *tmp, *last = 0;
1036 object *otmp;
1037
1038 if (flag [FLAG_REMOVED]) 1082 if (flag [FLAG_REMOVED])
1039 return; 1083 return;
1040 1084
1041 INVOKE_OBJECT (REMOVE, this); 1085 INVOKE_OBJECT (REMOVE, this);
1042 1086
1054 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed 1098 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1055 if (object *pl = visible_to ()) 1099 if (object *pl = visible_to ())
1056 esrv_del_item (pl->contr, count); 1100 esrv_del_item (pl->contr, count);
1057 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1101 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1058 1102
1059 adjust_weight (env, -total_weight ()); 1103 adjust_weight (env, total_weight (), 0);
1104
1105 object *pl = in_player ();
1060 1106
1061 /* we set up values so that it could be inserted into 1107 /* we set up values so that it could be inserted into
1062 * the map, but we don't actually do that - it is up 1108 * the map, but we don't actually do that - it is up
1063 * to the caller to decide what we want to do. 1109 * to the caller to decide what we want to do.
1064 */ 1110 */
1072 1118
1073 above = 0; 1119 above = 0;
1074 below = 0; 1120 below = 0;
1075 env = 0; 1121 env = 0;
1076 1122
1077 /* NO_FIX_PLAYER is set when a great many changes are being 1123 if (pl && pl->is_player ())
1078 * made to players inventory. If set, avoiding the call
1079 * to save cpu time.
1080 */ 1124 {
1081 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1125 if (expect_false (pl->contr->combat_ob == this))
1082 otmp->update_stats (); 1126 {
1127 pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1128 pl->contr->combat_ob = 0;
1129 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1130 }
1131
1132 if (expect_false (pl->contr->ranged_ob == this))
1133 {
1134 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1135 pl->contr->ranged_ob = 0;
1136 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1137 }
1138
1139 pl->contr->queue_stats_update ();
1140
1141 if (expect_false (glow_radius) && pl->is_on_map ())
1142 update_all_los (pl->map, pl->x, pl->y);
1143 }
1083 } 1144 }
1084 else if (map) 1145 else if (map)
1085 { 1146 {
1086 map->dirty = true; 1147 map->dirty = true;
1087 mapspace &ms = this->ms (); 1148 mapspace &ms = this->ms ();
1088 1149
1089 if (object *pl = ms.player ()) 1150 if (object *pl = ms.player ())
1090 { 1151 {
1091 if (type == PLAYER) // this == pl(!) 1152 if (is_player ())
1092 { 1153 {
1154 if (!flag [FLAG_WIZPASS])
1155 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1156
1093 // leaving a spot always closes any open container on the ground 1157 // leaving a spot always closes any open container on the ground
1094 if (container && !container->env) 1158 if (container && !container->env)
1095 // this causes spurious floorbox updates, but it ensures 1159 // this causes spurious floorbox updates, but it ensures
1096 // that the CLOSE event is being sent. 1160 // that the CLOSE event is being sent.
1097 close_container (); 1161 close_container ();
1098 1162
1099 --map->players; 1163 --map->players;
1100 map->touch (); 1164 map->touch ();
1101 } 1165 }
1102 else if (pl->container == this) 1166 else if (pl->container_ () == this)
1103 { 1167 {
1104 // removing a container should close it 1168 // removing a container should close it
1105 close_container (); 1169 close_container ();
1106 } 1170 }
1107 1171 else
1108 esrv_del_item (pl->contr, count); 1172 esrv_del_item (pl->contr, count);
1109 } 1173 }
1110 1174
1111 /* link the object above us */ 1175 /* link the object above us */
1112 // re-link, make sure compiler can easily use cmove 1176 // re-link, make sure compiler can easily use cmove
1113 *(above ? &above->below : &ms.top) = below; 1177 *(above ? &above->below : &ms.top) = below;
1114 *(below ? &below->above : &ms.bot) = above; 1178 *(below ? &below->above : &ms.bot) = above;
1115 1179
1116 above = 0; 1180 above = 0;
1117 below = 0; 1181 below = 0;
1118 1182
1119 ms.flags_ = 0; 1183 ms.invalidate ();
1120
1121 if (map->in_memory == MAP_SAVING)
1122 return;
1123 1184
1124 int check_walk_off = !flag [FLAG_NO_APPLY]; 1185 int check_walk_off = !flag [FLAG_NO_APPLY];
1125 1186
1126 if (object *pl = ms.player ()) 1187 if (object *pl = ms.player ())
1127 { 1188 {
1128 if (pl->container == this) 1189 if (pl->container_ () == this)
1129 /* If a container that the player is currently using somehow gets 1190 /* If a container that the player is currently using somehow gets
1130 * removed (most likely destroyed), update the player view 1191 * removed (most likely destroyed), update the player view
1131 * appropriately. 1192 * appropriately.
1132 */ 1193 */
1133 pl->close_container (); 1194 pl->close_container ();
1137 //TODO: update floorbox to preserve ordering 1198 //TODO: update floorbox to preserve ordering
1138 if (pl->contr->ns) 1199 if (pl->contr->ns)
1139 pl->contr->ns->floorbox_update (); 1200 pl->contr->ns->floorbox_update ();
1140 } 1201 }
1141 1202
1203 if (check_walk_off)
1142 for (tmp = ms.bot; tmp; tmp = tmp->above) 1204 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1143 { 1205 {
1206 above = tmp->above;
1207
1144 /* No point updating the players look faces if he is the object 1208 /* No point updating the players look faces if he is the object
1145 * being removed. 1209 * being removed.
1146 */ 1210 */
1147 1211
1148 /* See if object moving off should effect something */ 1212 /* See if object moving off should effect something */
1149 if (check_walk_off
1150 && ((move_type & tmp->move_off) 1213 if ((move_type & tmp->move_off)
1151 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1214 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1152 {
1153 move_apply (tmp, this, 0); 1215 move_apply (tmp, this, 0);
1154
1155 if (destroyed ())
1156 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1157 } 1216 }
1158 1217
1159 last = tmp; 1218 if (affects_los ())
1160 }
1161
1162 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1163 update_all_los (map, x, y); 1219 update_all_los (map, x, y);
1164 } 1220 }
1165} 1221}
1166 1222
1167/* 1223/*
1191 esrv_update_item (UPD_NROF, pl, top); 1247 esrv_update_item (UPD_NROF, pl, top);
1192 1248
1193 op->weight = 0; // cancel the addition above 1249 op->weight = 0; // cancel the addition above
1194 op->carrying = 0; // must be 0 already 1250 op->carrying = 0; // must be 0 already
1195 1251
1196 op->destroy (true); 1252 op->destroy ();
1197 1253
1198 return top; 1254 return top;
1199 } 1255 }
1200 1256
1201 return 0; 1257 return 0;
1209 1265
1210 object *prev = this; 1266 object *prev = this;
1211 1267
1212 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1268 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1213 { 1269 {
1214 object *op = arch_to_object (at); 1270 object *op = at->instance ();
1215 1271
1216 op->name = name; 1272 op->name = name;
1217 op->name_pl = name_pl; 1273 op->name_pl = name_pl;
1218 op->title = title; 1274 op->title = title;
1219 1275
1257 * Passing 0 for flag gives proper default values, so flag really only needs 1313 * Passing 0 for flag gives proper default values, so flag really only needs
1258 * to be set if special handling is needed. 1314 * to be set if special handling is needed.
1259 * 1315 *
1260 * Return value: 1316 * Return value:
1261 * new object if 'op' was merged with other object 1317 * new object if 'op' was merged with other object
1262 * NULL if 'op' was destroyed 1318 * NULL if there was an error (destroyed, blocked etc.)
1263 * just 'op' otherwise 1319 * just 'op' otherwise
1264 */ 1320 */
1265object * 1321object *
1266insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1322insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1267{ 1323{
1268 if (op->is_on_map ())
1269 {
1270 LOG (llevError, "insert_ob_in_map called for object already on map");
1271 abort ();
1272 }
1273
1274 if (op->env)
1275 {
1276 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1277 op->remove (); 1324 op->remove ();
1278 }
1279 1325
1280 if (m == &freed_map)//D TODO: remove soon 1326 if (m == &freed_map)//D TODO: remove soon
1281 {//D 1327 {//D
1282 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D 1328 LOG (llevError | logBacktrace, "tries to insert object on freed objects map: %s", op->debug_desc ());//D
1283 }//D 1329 }//D
1284 1330
1285 /* Ideally, the caller figures this out. However, it complicates a lot 1331 /* Ideally, the caller figures this out. However, it complicates a lot
1286 * of areas of callers (eg, anything that uses find_free_spot would now 1332 * of areas of callers (eg, anything that uses find_free_spot would now
1287 * need extra work 1333 * need extra work
1288 */ 1334 */
1335 maptile *newmap = m;
1289 if (!xy_normalise (m, op->x, op->y)) 1336 if (!xy_normalise (newmap, op->x, op->y))
1290 { 1337 {
1291 op->head_ ()->destroy (true);// remove head_ once all tail object destroyers found 1338 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1292 return 0; 1339 return 0;
1293 } 1340 }
1294 1341
1295 if (object *more = op->more) 1342 if (object *more = op->more)
1296 if (!insert_ob_in_map (more, m, originator, flag)) 1343 if (!insert_ob_in_map (more, m, originator, flag))
1297 return 0; 1344 return 0;
1298 1345
1299 CLEAR_FLAG (op, FLAG_REMOVED); 1346 op->flag [FLAG_REMOVED] = false;
1300 1347 op->env = 0;
1301 op->map = m; 1348 op->map = newmap;
1349
1302 mapspace &ms = op->ms (); 1350 mapspace &ms = op->ms ();
1303 1351
1304 /* this has to be done after we translate the coordinates. 1352 /* this has to be done after we translate the coordinates.
1305 */ 1353 */
1306 if (op->nrof && !(flag & INS_NO_MERGE)) 1354 if (op->nrof && !(flag & INS_NO_MERGE))
1309 { 1357 {
1310 // TODO: we actually want to update tmp, not op, 1358 // TODO: we actually want to update tmp, not op,
1311 // but some caller surely breaks when we return tmp 1359 // but some caller surely breaks when we return tmp
1312 // from here :/ 1360 // from here :/
1313 op->nrof += tmp->nrof; 1361 op->nrof += tmp->nrof;
1314 tmp->destroy (true); 1362 tmp->destroy ();
1315 } 1363 }
1316 1364
1317 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1365 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1318 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1366 op->clr_flag (FLAG_INV_LOCKED);
1319 1367
1320 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1368 if (!op->flag [FLAG_ALIVE])
1321 CLEAR_FLAG (op, FLAG_NO_STEAL); 1369 op->clr_flag (FLAG_NO_STEAL);
1322 1370
1323 if (flag & INS_BELOW_ORIGINATOR) 1371 if (flag & INS_BELOW_ORIGINATOR)
1324 { 1372 {
1325 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1373 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1326 { 1374 {
1327 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1375 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1328 abort (); 1376 abort ();
1329 } 1377 }
1330 1378
1331 if (!originator->is_on_map ()) 1379 if (!originator->is_on_map ())
1380 {
1332 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map", 1381 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1333 op->debug_desc (), originator->debug_desc ()); 1382 op->debug_desc (), originator->debug_desc ());
1383 abort ();
1384 }
1334 1385
1335 op->above = originator; 1386 op->above = originator;
1336 op->below = originator->below; 1387 op->below = originator->below;
1337 originator->below = op; 1388 originator->below = op;
1338 1389
1358 * when lots of spells are cast in one area. Currently, it is presumed 1409 * when lots of spells are cast in one area. Currently, it is presumed
1359 * that flying non pickable objects are spell objects. 1410 * that flying non pickable objects are spell objects.
1360 */ 1411 */
1361 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1412 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1362 { 1413 {
1363 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR)) 1414 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1364 floor = tmp; 1415 floor = tmp;
1365 1416
1366 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 1417 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1367 { 1418 {
1368 /* We insert above top, so we want this object below this */ 1419 /* We insert above top, so we want this object below this */
1369 top = tmp->below; 1420 top = tmp->below;
1370 break; 1421 break;
1371 } 1422 }
1389 && (op->face && !faces [op->face].visibility)) 1440 && (op->face && !faces [op->face].visibility))
1390 { 1441 {
1391 object *last; 1442 object *last;
1392 1443
1393 for (last = top; last != floor; last = last->below) 1444 for (last = top; last != floor; last = last->below)
1394 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1445 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1395 break; 1446 break;
1396 1447
1397 /* Check to see if we found the object that blocks view, 1448 /* Check to see if we found the object that blocks view,
1398 * and make sure we have a below pointer for it so that 1449 * and make sure we have a below pointer for it so that
1399 * we can get inserted below this one, which requires we 1450 * we can get inserted below this one, which requires we
1424 op->below = top; 1475 op->below = top;
1425 *(op->above ? &op->above->below : &ms.top) = op; 1476 *(op->above ? &op->above->below : &ms.top) = op;
1426 } 1477 }
1427 } 1478 }
1428 1479
1429 if (op->type == PLAYER) 1480 if (op->is_player ())
1430 { 1481 {
1431 op->contr->do_los = 1; 1482 op->contr->do_los = 1;
1432 ++op->map->players; 1483 ++op->map->players;
1433 op->map->touch (); 1484 op->map->touch ();
1434 } 1485 }
1449 * be far away from this change and not affected in any way - 1500 * be far away from this change and not affected in any way -
1450 * this should get redone to only look for players within range, 1501 * this should get redone to only look for players within range,
1451 * or just updating the P_UPTODATE for spaces within this area 1502 * or just updating the P_UPTODATE for spaces within this area
1452 * of effect may be sufficient. 1503 * of effect may be sufficient.
1453 */ 1504 */
1454 if (op->map->darkness && (op->glow_radius != 0)) 1505 if (op->affects_los ())
1506 {
1507 op->ms ().invalidate ();
1455 update_all_los (op->map, op->x, op->y); 1508 update_all_los (op->map, op->x, op->y);
1509 }
1456 1510
1457 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1511 /* updates flags (blocked, alive, no magic, etc) for this map space */
1458 update_object (op, UP_OBJ_INSERT); 1512 update_object (op, UP_OBJ_INSERT);
1459 1513
1460 INVOKE_OBJECT (INSERT, op); 1514 INVOKE_OBJECT (INSERT, op);
1467 * blocked() and wall() work properly), and these flags are updated by 1521 * blocked() and wall() work properly), and these flags are updated by
1468 * update_object(). 1522 * update_object().
1469 */ 1523 */
1470 1524
1471 /* if this is not the head or flag has been passed, don't check walk on status */ 1525 /* if this is not the head or flag has been passed, don't check walk on status */
1472 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1526 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1473 { 1527 {
1474 if (check_move_on (op, originator)) 1528 if (check_move_on (op, originator, flag))
1475 return 0; 1529 return 0;
1476 1530
1477 /* If we are a multi part object, lets work our way through the check 1531 /* If we are a multi part object, let's work our way through the check
1478 * walk on's. 1532 * walk on's.
1479 */ 1533 */
1480 for (object *tmp = op->more; tmp; tmp = tmp->more) 1534 for (object *tmp = op->more; tmp; tmp = tmp->more)
1481 if (check_move_on (tmp, originator)) 1535 if (check_move_on (tmp, originator, flag))
1482 return 0; 1536 return 0;
1483 } 1537 }
1484 1538
1485 return op; 1539 return op;
1486} 1540}
1488/* this function inserts an object in the map, but if it 1542/* this function inserts an object in the map, but if it
1489 * finds an object of its own type, it'll remove that one first. 1543 * finds an object of its own type, it'll remove that one first.
1490 * op is the object to insert it under: supplies x and the map. 1544 * op is the object to insert it under: supplies x and the map.
1491 */ 1545 */
1492void 1546void
1493replace_insert_ob_in_map (const char *arch_string, object *op) 1547replace_insert_ob_in_map (shstr_tmp archname, object *op)
1494{ 1548{
1495 /* first search for itself and remove any old instances */ 1549 /* first search for itself and remove any old instances */
1496 1550
1497 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1551 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1498 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1552 if (tmp->arch->archname == archname) /* same archetype */
1499 tmp->destroy (true); 1553 tmp->destroy ();
1500 1554
1501 object *tmp = arch_to_object (archetype::find (arch_string)); 1555 object *tmp = archetype::find (archname)->instance ();
1502 1556
1503 tmp->x = op->x; 1557 tmp->x = op->x;
1504 tmp->y = op->y; 1558 tmp->y = op->y;
1505 1559
1506 insert_ob_in_map (tmp, op->map, op, 0); 1560 insert_ob_in_map (tmp, op->map, op, 0);
1511{ 1565{
1512 if (where->env) 1566 if (where->env)
1513 return where->env->insert (this); 1567 return where->env->insert (this);
1514 else 1568 else
1515 return where->map->insert (this, where->x, where->y, originator, flags); 1569 return where->map->insert (this, where->x, where->y, originator, flags);
1570}
1571
1572// check whether we can put this into the map, respect max_volume, max_items
1573bool
1574object::can_drop_at (maptile *m, int x, int y, object *originator)
1575{
1576 mapspace &ms = m->at (x, y);
1577
1578 int items = ms.items ();
1579
1580 if (!items // testing !items ensures we can drop at least one item
1581 || (items < m->max_items
1582 && ms.volume () < m->max_volume))
1583 return true;
1584
1585 if (originator && originator->is_player ())
1586 originator->contr->failmsgf (
1587 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1588 query_name ()
1589 );
1590
1591 return false;
1516} 1592}
1517 1593
1518/* 1594/*
1519 * decrease(object, number) decreases a specified number from 1595 * decrease(object, number) decreases a specified number from
1520 * the amount of an object. If the amount reaches 0, the object 1596 * the amount of an object. If the amount reaches 0, the object
1530 1606
1531 nr = min (nr, nrof); 1607 nr = min (nr, nrof);
1532 1608
1533 if (nrof > nr) 1609 if (nrof > nr)
1534 { 1610 {
1611 sint64 oweight = total_weight ();
1612
1535 nrof -= nr; 1613 nrof -= nr;
1536 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1537 1614
1538 if (object *pl = visible_to ()) 1615 if (object *pl = visible_to ())
1539 esrv_update_item (UPD_NROF, pl, this); 1616 esrv_update_item (UPD_NROF, pl, this);
1617
1618 adjust_weight (env, oweight, total_weight ());
1540 1619
1541 return true; 1620 return true;
1542 } 1621 }
1543 else 1622 else
1544 { 1623 {
1619 if (op->nrof) 1698 if (op->nrof)
1620 for (object *tmp = inv; tmp; tmp = tmp->below) 1699 for (object *tmp = inv; tmp; tmp = tmp->below)
1621 if (object::can_merge (tmp, op)) 1700 if (object::can_merge (tmp, op))
1622 { 1701 {
1623 /* return the original object and remove inserted object 1702 /* return the original object and remove inserted object
1624 (client needs the original object) */ 1703 (client prefers the original object) */
1704
1705 // carring must be 0 for mergable objects
1706 sint64 oweight = tmp->weight * tmp->nrof;
1707
1625 tmp->nrof += op->nrof; 1708 tmp->nrof += op->nrof;
1626 1709
1627 if (object *pl = tmp->visible_to ()) 1710 if (object *pl = tmp->visible_to ())
1628 esrv_update_item (UPD_NROF, pl, tmp); 1711 esrv_update_item (UPD_NROF, pl, tmp);
1629 1712
1630 adjust_weight (this, op->total_weight ()); 1713 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1631 1714
1632 op->destroy (true); 1715 op->destroy ();
1633 op = tmp; 1716 op = tmp;
1634 goto inserted; 1717 goto inserted;
1635 } 1718 }
1636 1719
1637 op->owner = 0; // it's his/hers now. period. 1720 op->owner = 0; // it's his/hers now. period.
1651 op->flag [FLAG_REMOVED] = 0; 1734 op->flag [FLAG_REMOVED] = 0;
1652 1735
1653 if (object *pl = op->visible_to ()) 1736 if (object *pl = op->visible_to ())
1654 esrv_send_item (pl, op); 1737 esrv_send_item (pl, op);
1655 1738
1656 adjust_weight (this, op->total_weight ()); 1739 adjust_weight (this, 0, op->total_weight ());
1657 1740
1658inserted: 1741inserted:
1659 /* reset the light list and los of the players on the map */ 1742 /* reset the light list and los of the players on the map */
1660 if (op->glow_radius && map && map->darkness) 1743 if (op->glow_radius && is_on_map ())
1744 {
1745 update_stats ();
1661 update_all_los (map, x, y); 1746 update_all_los (map, x, y);
1662 1747 }
1748 else if (is_player ())
1663 // if this is a player's inventory, update stats 1749 // if this is a player's inventory, update stats
1664 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1750 contr->queue_stats_update ();
1665 update_stats ();
1666 1751
1667 INVOKE_OBJECT (INSERT, this); 1752 INVOKE_OBJECT (INSERT, this);
1668 1753
1669 return op; 1754 return op;
1670} 1755}
1688 * MSW 2001-07-08: Check all objects on space, not just those below 1773 * MSW 2001-07-08: Check all objects on space, not just those below
1689 * object being inserted. insert_ob_in_map may not put new objects 1774 * object being inserted. insert_ob_in_map may not put new objects
1690 * on top. 1775 * on top.
1691 */ 1776 */
1692int 1777int
1693check_move_on (object *op, object *originator) 1778check_move_on (object *op, object *originator, int flags)
1694{ 1779{
1780 if (op->flag [FLAG_NO_APPLY])
1781 return 0;
1782
1695 object *tmp; 1783 object *tmp;
1696 maptile *m = op->map; 1784 maptile *m = op->map;
1697 int x = op->x, y = op->y; 1785 int x = op->x, y = op->y;
1698 1786
1699 MoveType move_on, move_slow, move_block; 1787 mapspace &ms = m->at (x, y);
1700 1788
1701 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1789 ms.update ();
1702 return 0;
1703 1790
1704 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1791 MoveType move_on = ms.move_on;
1705 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1792 MoveType move_slow = ms.move_slow;
1706 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1793 MoveType move_block = ms.move_block;
1707 1794
1708 /* if nothing on this space will slow op down or be applied, 1795 /* if nothing on this space will slow op down or be applied,
1709 * no need to do checking below. have to make sure move_type 1796 * no need to do checking below. have to make sure move_type
1710 * is set, as lots of objects don't have it set - we treat that 1797 * is set, as lots of objects don't have it set - we treat that
1711 * as walking. 1798 * as walking.
1722 return 0; 1809 return 0;
1723 1810
1724 /* The objects have to be checked from top to bottom. 1811 /* The objects have to be checked from top to bottom.
1725 * Hence, we first go to the top: 1812 * Hence, we first go to the top:
1726 */ 1813 */
1727 1814 for (object *next, *tmp = ms.top; tmp; tmp = next)
1728 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1729 {
1730 /* Trim the search when we find the first other spell effect
1731 * this helps performance so that if a space has 50 spell objects,
1732 * we don't need to check all of them.
1733 */
1734 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1735 break;
1736 } 1815 {
1816 next = tmp->below;
1737 1817
1738 for (; tmp; tmp = tmp->below)
1739 {
1740 if (tmp == op) 1818 if (tmp == op)
1741 continue; /* Can't apply yourself */ 1819 continue; /* Can't apply yourself */
1742 1820
1743 /* Check to see if one of the movement types should be slowed down. 1821 /* Check to see if one of the movement types should be slowed down.
1744 * Second check makes sure that the movement types not being slowed 1822 * Second check makes sure that the movement types not being slowed
1745 * (~slow_move) is not blocked on this space - just because the 1823 * (~slow_move) is not blocked on this space - just because the
1746 * space doesn't slow down swimming (for example), if you can't actually 1824 * space doesn't slow down swimming (for example), if you can't actually
1747 * swim on that space, can't use it to avoid the penalty. 1825 * swim on that space, can't use it to avoid the penalty.
1748 */ 1826 */
1749 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1827 if (!op->flag [FLAG_WIZPASS])
1750 { 1828 {
1751 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1829 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1752 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1830 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1753 { 1831 {
1754
1755 float
1756 diff = tmp->move_slow_penalty * fabs (op->speed); 1832 float diff = tmp->move_slow_penalty * fabs (op->speed);
1757 1833
1758 if (op->type == PLAYER) 1834 if (op->is_player ())
1759 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1835 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1760 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1836 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1761 diff /= 4.0; 1837 diff /= 4.0;
1762 1838
1763 op->speed_left -= diff; 1839 op->speed_left -= diff;
1764 } 1840 }
1765 } 1841 }
1766 1842
1767 /* Basically same logic as above, except now for actual apply. */ 1843 /* Basically same logic as above, except now for actual apply. */
1768 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1844 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1769 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1845 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1770 { 1846 {
1847 if ((flags & INS_NO_AUTO_EXIT)
1848 && (tmp->type == EXIT || tmp->type == TELEPORTER
1849 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1850 continue;
1851
1771 move_apply (tmp, op, originator); 1852 move_apply (tmp, op, originator);
1772 1853
1773 if (op->destroyed ()) 1854 if (op->destroyed ())
1774 return 1; 1855 return 1;
1775 1856
1887void 1968void
1888flag_inv (object *op, int flag) 1969flag_inv (object *op, int flag)
1889{ 1970{
1890 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1971 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1891 { 1972 {
1892 SET_FLAG (tmp, flag); 1973 tmp->set_flag (flag);
1893 flag_inv (tmp, flag); 1974 flag_inv (tmp, flag);
1894 } 1975 }
1895} 1976}
1896 1977
1897/* 1978/*
1900void 1981void
1901unflag_inv (object *op, int flag) 1982unflag_inv (object *op, int flag)
1902{ 1983{
1903 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1984 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1904 { 1985 {
1905 CLEAR_FLAG (tmp, flag); 1986 tmp->clr_flag (flag);
1906 unflag_inv (tmp, flag); 1987 unflag_inv (tmp, flag);
1907 } 1988 }
1908} 1989}
1909 1990
1910/* 1991/*
1927 */ 2008 */
1928int 2009int
1929find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2010find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
1930{ 2011{
1931 int altern[SIZEOFFREE]; 2012 int altern[SIZEOFFREE];
1932 int index = 0, flag; 2013 int index = 0;
1933 2014
1934 for (int i = start; i < stop; i++) 2015 for (int i = start; i < stop; i++)
1935 { 2016 {
1936 mapxy pos (m, x, y); pos.move (i); 2017 mapxy pos (m, x, y); pos.move (i);
1937 2018
1971 * head of the object should correspond for the entire object. 2052 * head of the object should correspond for the entire object.
1972 */ 2053 */
1973 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2054 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1974 continue; 2055 continue;
1975 2056
1976 if (ob->blocked (m, pos.x, pos.y)) 2057 if (ob->blocked (pos.m, pos.x, pos.y))
1977 continue; 2058 continue;
1978 2059
1979 altern [index++] = i; 2060 altern [index++] = i;
1980 } 2061 }
1981 2062
2049 * there is capable of. 2130 * there is capable of.
2050 */ 2131 */
2051int 2132int
2052find_dir (maptile *m, int x, int y, object *exclude) 2133find_dir (maptile *m, int x, int y, object *exclude)
2053{ 2134{
2054 int i, max = SIZEOFFREE, mflags; 2135 int max = SIZEOFFREE;
2055
2056 sint16 nx, ny;
2057 object *tmp;
2058 maptile *mp;
2059
2060 MoveType blocked, move_type; 2136 MoveType move_type;
2061 2137
2062 if (exclude && exclude->head_ () != exclude) 2138 if (exclude && exclude->head_ () != exclude)
2063 { 2139 {
2064 exclude = exclude->head; 2140 exclude = exclude->head;
2065 move_type = exclude->move_type; 2141 move_type = exclude->move_type;
2068 { 2144 {
2069 /* If we don't have anything, presume it can use all movement types. */ 2145 /* If we don't have anything, presume it can use all movement types. */
2070 move_type = MOVE_ALL; 2146 move_type = MOVE_ALL;
2071 } 2147 }
2072 2148
2073 for (i = 1; i < max; i++) 2149 for (int i = 1; i < max; i++)
2074 { 2150 {
2075 mp = m; 2151 mapxy pos (m, x, y);
2076 nx = x + freearr_x[i]; 2152 pos.move (i);
2077 ny = y + freearr_y[i];
2078 2153
2079 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2154 if (!pos.normalise ())
2080
2081 if (mflags & P_OUT_OF_MAP)
2082 max = maxfree[i]; 2155 max = maxfree[i];
2083 else 2156 else
2084 { 2157 {
2085 mapspace &ms = mp->at (nx, ny); 2158 mapspace &ms = *pos;
2086 2159
2087 blocked = ms.move_block;
2088
2089 if ((move_type & blocked) == move_type) 2160 if ((move_type & ms.move_block) == move_type)
2090 max = maxfree[i]; 2161 max = maxfree [i];
2091 else if (mflags & P_IS_ALIVE) 2162 else if (ms.flags () & P_IS_ALIVE)
2092 { 2163 {
2093 for (tmp = ms.bot; tmp; tmp = tmp->above) 2164 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2094 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2165 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2095 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2166 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2096 break;
2097
2098 if (tmp)
2099 return freedir[i]; 2167 return freedir [i];
2100 } 2168 }
2101 } 2169 }
2102 } 2170 }
2103 2171
2104 return 0; 2172 return 0;
2113{ 2181{
2114 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2182 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2115} 2183}
2116 2184
2117/* 2185/*
2118 * find_dir_2(delta-x,delta-y) will return a direction in which 2186 * find_dir_2(delta-x,delta-y) will return a direction value
2119 * an object which has subtracted the x and y coordinates of another 2187 * for running into direct [dx, dy].
2120 * object, needs to travel toward it. 2188 * (the opposite of crossfire's find_dir_2!)
2121 */ 2189 */
2122int 2190int
2123find_dir_2 (int x, int y) 2191find_dir_2 (int x, int y)
2124{ 2192{
2193#if 1 // new algorithm
2194 // this works by putting x, y into 16 sectors, which
2195 // are not equal sized, but are a better approximation
2196 // then the old algorithm, and then using a mapping
2197 // table to map it into a direction value.
2198 // basically, it maps these comparisons to each bit
2199 // bit #3: x < 0
2200 // bit #2: y < 0
2201 // bit #1: x > y
2202 // bit #0: x > 2y
2203
2204 static const uint8 dir[16] = {
2205 4, 5, 4, 3,
2206 2, 1, 2, 3,
2207 6, 5, 6, 7,
2208 8, 1, 8, 7,
2209 };
2210 int sector = 0;
2211
2212 // this is a bit ugly, but more likely to result in branchless code
2213 sector |= x < 0 ? 8 : 0;
2214 x = x < 0 ? -x : x; // abs
2215
2216 sector |= y < 0 ? 4 : 0;
2217 y = y < 0 ? -y : y; // abs
2218
2219 if (x > y)
2220 {
2221 sector |= 2;
2222
2223 if (x > y * 2)
2224 sector |= 1;
2225 }
2226 else
2227 {
2228 if (y > x * 2)
2229 sector |= 1;
2230 else if (!y)
2231 return 0; // x == 0 here
2232 }
2233
2234 return dir [sector];
2235#else // old algorithm
2125 int q; 2236 int q;
2126 2237
2127 if (y) 2238 if (y)
2128 q = x * 100 / y; 2239 q = 128 * x / y;
2129 else if (x) 2240 else if (x)
2130 q = -300 * x; 2241 q = -512 * x; // to make it > 309
2131 else 2242 else
2132 return 0; 2243 return 0;
2133 2244
2134 if (y > 0) 2245 if (y > 0)
2135 { 2246 {
2136 if (q < -242) 2247 if (q < -309) return 7;
2248 if (q < -52) return 6;
2249 if (q < 52) return 5;
2250 if (q < 309) return 4;
2251
2137 return 3; 2252 return 3;
2138 if (q < -41) 2253 }
2139 return 2; 2254 else
2140 if (q < 41) 2255 {
2141 return 1; 2256 if (q < -309) return 3;
2142 if (q < 242) 2257 if (q < -52) return 2;
2143 return 8; 2258 if (q < 52) return 1;
2259 if (q < 309) return 8;
2260
2144 return 7; 2261 return 7;
2145 } 2262 }
2146 2263#endif
2147 if (q < -242)
2148 return 7;
2149 if (q < -41)
2150 return 6;
2151 if (q < 41)
2152 return 5;
2153 if (q < 242)
2154 return 4;
2155
2156 return 3;
2157} 2264}
2158 2265
2159/* 2266/*
2160 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2267 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2161 * between two directions (which are expected to be absolute (see absdir()) 2268 * between two directions (which are expected to be absolute (see absdir())
2162 */ 2269 */
2163int 2270int
2164dirdiff (int dir1, int dir2) 2271dirdiff (int dir1, int dir2)
2165{ 2272{
2166 int d;
2167
2168 d = abs (dir1 - dir2); 2273 int d = abs (dir1 - dir2);
2169 if (d > 4)
2170 d = 8 - d;
2171 2274
2172 return d; 2275 return d > 4 ? 8 - d : d;
2173} 2276}
2174 2277
2175/* peterm: 2278/* peterm:
2176 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2279 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2177 * Basically, this is a table of directions, and what directions 2280 * Basically, this is a table of directions, and what directions
2179 * This basically means that if direction is 15, then it could either go 2282 * This basically means that if direction is 15, then it could either go
2180 * direction 4, 14, or 16 to get back to where we are. 2283 * direction 4, 14, or 16 to get back to where we are.
2181 * Moved from spell_util.c to object.c with the other related direction 2284 * Moved from spell_util.c to object.c with the other related direction
2182 * functions. 2285 * functions.
2183 */ 2286 */
2184int reduction_dir[SIZEOFFREE][3] = { 2287static const int reduction_dir[SIZEOFFREE][3] = {
2185 {0, 0, 0}, /* 0 */ 2288 {0, 0, 0}, /* 0 */
2186 {0, 0, 0}, /* 1 */ 2289 {0, 0, 0}, /* 1 */
2187 {0, 0, 0}, /* 2 */ 2290 {0, 0, 0}, /* 2 */
2188 {0, 0, 0}, /* 3 */ 2291 {0, 0, 0}, /* 3 */
2189 {0, 0, 0}, /* 4 */ 2292 {0, 0, 0}, /* 4 */
2283 * Add a check so we can't pick up invisible objects (0.93.8) 2386 * Add a check so we can't pick up invisible objects (0.93.8)
2284 */ 2387 */
2285int 2388int
2286can_pick (const object *who, const object *item) 2389can_pick (const object *who, const object *item)
2287{ 2390{
2288 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2391 return /*who->flag [FLAG_WIZ]|| */
2289 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2392 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2290 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2393 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2291} 2394}
2395
2396//-GPL
2292 2397
2293/* 2398/*
2294 * create clone from object to another 2399 * create clone from object to another
2295 */ 2400 */
2296object * 2401object *
2327 return tmp; 2432 return tmp;
2328 2433
2329 return 0; 2434 return 0;
2330} 2435}
2331 2436
2332const shstr & 2437/* Zero the key_values on op, decrementing the shared-string
2333object::kv_get (const shstr &key) const 2438 * refcounts and freeing the links.
2439 */
2440void
2441key_values::clear ()
2334{ 2442{
2443 for (key_value *kvp = first; kvp; )
2444 {
2445 key_value *next = kvp->next;
2446 delete kvp;
2447 kvp = next;
2448 }
2449
2450 first = 0;
2451}
2452
2453shstr_tmp
2454key_values::get (shstr_tmp key) const
2455{
2335 for (key_value *kv = key_values; kv; kv = kv->next) 2456 for (key_value *kv = first; kv; kv = kv->next)
2336 if (kv->key == key) 2457 if (kv->key == key)
2337 return kv->value; 2458 return kv->value;
2338 2459
2339 return shstr_null; 2460 return shstr ();
2340} 2461}
2341 2462
2342void 2463void
2343object::kv_set (const shstr &key, const shstr &value) 2464key_values::add (shstr_tmp key, shstr_tmp value)
2344{ 2465{
2466 key_value *kv = new key_value;
2467
2468 kv->next = first;
2469 kv->key = key;
2470 kv->value = value;
2471
2472 first = kv;
2473}
2474
2475void
2476key_values::set (shstr_tmp key, shstr_tmp value)
2477{
2345 for (key_value *kv = key_values; kv; kv = kv->next) 2478 for (key_value *kv = first; kv; kv = kv->next)
2346 if (kv->key == key) 2479 if (kv->key == key)
2347 { 2480 {
2348 kv->value = value; 2481 kv->value = value;
2349 return; 2482 return;
2350 } 2483 }
2351 2484
2352 key_value *kv = new key_value; 2485 add (key, value);
2353
2354 kv->next = key_values;
2355 kv->key = key;
2356 kv->value = value;
2357
2358 key_values = kv;
2359} 2486}
2360 2487
2361void 2488void
2362object::kv_del (const shstr &key) 2489key_values::del (shstr_tmp key)
2363{ 2490{
2364 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2491 for (key_value **kvp = &first; *kvp; kvp = &(*kvp)->next)
2365 if ((*kvp)->key == key) 2492 if ((*kvp)->key == key)
2366 { 2493 {
2367 key_value *kv = *kvp; 2494 key_value *kv = *kvp;
2368 *kvp = (*kvp)->next; 2495 *kvp = (*kvp)->next;
2369 delete kv; 2496 delete kv;
2370 return; 2497 return;
2371 } 2498 }
2499}
2500
2501void
2502key_values::reverse ()
2503{
2504 key_value *prev = 0;
2505 key_value *head = first;
2506
2507 while (head)
2508 {
2509 key_value *node = head;
2510 head = head->next;
2511 node->next = prev;
2512 prev = node;
2513 }
2514
2515 first = prev;
2516}
2517
2518key_values &
2519key_values::operator =(const key_values &kv)
2520{
2521 clear ();
2522
2523 for (key_value *kvp = kv.first; kvp; kvp = kvp->next)
2524 add (kvp->key, kvp->value);
2525
2526 reverse ();
2372} 2527}
2373 2528
2374object::depth_iterator::depth_iterator (object *container) 2529object::depth_iterator::depth_iterator (object *container)
2375: iterator_base (container) 2530: iterator_base (container)
2376{ 2531{
2460{ 2615{
2461 return map ? map->region (x, y) 2616 return map ? map->region (x, y)
2462 : region::default_region (); 2617 : region::default_region ();
2463} 2618}
2464 2619
2465const materialtype_t * 2620//+GPL
2466object::dominant_material () const
2467{
2468 if (materialtype_t *mt = name_to_material (materialname))
2469 return mt;
2470
2471 return name_to_material (shstr_unknown);
2472}
2473 2621
2474void 2622void
2475object::open_container (object *new_container) 2623object::open_container (object *new_container)
2476{ 2624{
2477 if (container == new_container) 2625 if (container == new_container)
2486 2634
2487#if 0 2635#if 0
2488 // remove the "Close old_container" object. 2636 // remove the "Close old_container" object.
2489 if (object *closer = old_container->inv) 2637 if (object *closer = old_container->inv)
2490 if (closer->type == CLOSE_CON) 2638 if (closer->type == CLOSE_CON)
2491 closer->destroy (true); 2639 closer->destroy ();
2492#endif 2640#endif
2493 2641
2494 // make sure the container is available 2642 // make sure the container is available
2495 esrv_send_item (this, old_container); 2643 esrv_send_item (this, old_container);
2496 2644
2498 container = 0; 2646 container = 0;
2499 2647
2500 // client needs item update to make it work, client bug requires this to be separate 2648 // client needs item update to make it work, client bug requires this to be separate
2501 esrv_update_item (UPD_FLAGS, this, old_container); 2649 esrv_update_item (UPD_FLAGS, this, old_container);
2502 2650
2503 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2651 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2504 play_sound (sound_find ("chest_close")); 2652 play_sound (sound_find ("chest_close"));
2505 } 2653 }
2506 2654
2507 if (new_container) 2655 if (new_container)
2508 { 2656 {
2512 // TODO: this does not seem to serve any purpose anymore? 2660 // TODO: this does not seem to serve any purpose anymore?
2513#if 0 2661#if 0
2514 // insert the "Close Container" object. 2662 // insert the "Close Container" object.
2515 if (archetype *closer = new_container->other_arch) 2663 if (archetype *closer = new_container->other_arch)
2516 { 2664 {
2517 object *closer = arch_to_object (new_container->other_arch); 2665 object *closer = new_container->other_arch->instance ();
2518 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2666 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2519 new_container->insert (closer); 2667 new_container->insert (closer);
2520 } 2668 }
2521#endif 2669#endif
2522 2670
2523 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2671 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2524 2672
2525 // make sure the container is available, client bug requires this to be separate 2673 // make sure the container is available, client bug requires this to be separate
2526 esrv_send_item (this, new_container); 2674 esrv_send_item (this, new_container);
2527 2675
2528 new_container->flag [FLAG_APPLIED] = true; 2676 new_container->flag [FLAG_APPLIED] = true;
2535 } 2683 }
2536// else if (!old_container->env && contr && contr->ns) 2684// else if (!old_container->env && contr && contr->ns)
2537// contr->ns->floorbox_reset (); 2685// contr->ns->floorbox_reset ();
2538} 2686}
2539 2687
2688//-GPL
2689
2690// prefetch some flat area around the player
2691static void
2692prefetch_surrounding_area (object *op, maptile *map, int range)
2693{
2694 for (maprect *rect = map->split_to_tiles (mapwalk_buf,
2695 op->x - range , op->y - range ,
2696 op->x + range + 1, op->y + range + 1);
2697 rect->m;
2698 ++rect)
2699 {
2700 rect->m->touch ();
2701 rect->m->activate ();
2702 }
2703}
2704
2705// prefetch a generous area around the player, also up and down
2706void
2707object::prefetch_surrounding_maps ()
2708{
2709 prefetch_surrounding_area (this, map, 40);
2710
2711 if (maptile *m = map->tile_available (TILE_DOWN))
2712 prefetch_surrounding_area (this, m, 20);
2713
2714 if (maptile *m = map->tile_available (TILE_UP))
2715 prefetch_surrounding_area (this, m, 20);
2716}
2717
2718//+GPL
2719
2540object * 2720object *
2541object::force_find (const shstr name) 2721object::force_find (shstr_tmp name)
2542{ 2722{
2543 /* cycle through his inventory to look for the MARK we want to 2723 /* cycle through his inventory to look for the MARK we want to
2544 * place 2724 * place
2545 */ 2725 */
2546 for (object *tmp = inv; tmp; tmp = tmp->below) 2726 for (object *tmp = inv; tmp; tmp = tmp->below)
2549 2729
2550 return 0; 2730 return 0;
2551} 2731}
2552 2732
2553void 2733void
2734object::force_set_timer (int duration)
2735{
2736 this->duration = 1;
2737 this->speed_left = -1.f;
2738
2739 this->set_speed (duration ? 1.f / duration : 0.f);
2740}
2741
2742object *
2554object::force_add (const shstr name, int duration) 2743object::force_add (shstr_tmp name, int duration)
2555{ 2744{
2556 if (object *force = force_find (name)) 2745 if (object *force = force_find (name))
2557 force->destroy (true); 2746 force->destroy ();
2558 2747
2559 object *force = get_archetype (FORCE_NAME); 2748 object *force = archetype::get (FORCE_NAME);
2560 2749
2561 force->slaying = name; 2750 force->slaying = name;
2562 force->stats.food = 1; 2751 force->force_set_timer (duration);
2563 force->speed_left = -1.f;
2564
2565 force->set_speed (duration ? 1.f / duration : 0.f);
2566 force->flag [FLAG_IS_USED_UP] = true;
2567 force->flag [FLAG_APPLIED] = true; 2752 force->flag [FLAG_APPLIED] = true;
2568 2753
2569 insert (force); 2754 return insert (force);
2570} 2755}
2571 2756
2572void 2757void
2573object::play_sound (faceidx sound) 2758object::play_sound (faceidx sound) const
2574{ 2759{
2575 if (!sound) 2760 if (!sound)
2576 return; 2761 return;
2577 2762
2578 if (flag [FLAG_REMOVED]) 2763 if (is_on_map ())
2764 map->play_sound (sound, x, y);
2765 else if (object *pl = in_player ())
2766 pl->contr->play_sound (sound);
2767}
2768
2769void
2770object::say_msg (const char *msg) const
2771{
2772 if (is_on_map ())
2773 map->say_msg (msg, x, y);
2774 else if (object *pl = in_player ())
2775 pl->contr->play_sound (sound);
2776}
2777
2778void
2779object::make_noise ()
2780{
2781 // we do not model noise in the map, so instead put
2782 // a temporary light into the noise source
2783 // could use the map instead, but that's less reliable for our
2784 // goal, which is to make invisibility a bit harder to exploit
2785
2786 // currently only works sensibly for players
2787 if (!is_player ())
2579 return; 2788 return;
2580 2789
2581 if (env) 2790 // find old force, or create new one
2582 { 2791 object *force = force_find (shstr_noise_force);
2583 if (object *pl = in_player ()) 2792
2584 pl->contr->play_sound (sound); 2793 if (force)
2585 } 2794 force->speed_left = -1.f; // patch old speed up
2586 else 2795 else
2587 map->play_sound (sound, x, y); 2796 {
2588} 2797 force = archetype::get (shstr_noise_force);
2589 2798
2799 force->slaying = shstr_noise_force;
2800 force->stats.food = 1;
2801 force->speed_left = -1.f;
2802
2803 force->set_speed (1.f / 4.f);
2804 force->flag [FLAG_IS_USED_UP] = true;
2805 force->flag [FLAG_APPLIED] = true;
2806
2807 insert (force);
2808 }
2809}
2810
2811void object::change_move_type (MoveType mt)
2812{
2813 if (move_type == mt)
2814 return;
2815
2816 if (is_on_map ())
2817 {
2818 // we are on the map, so handle move_on/off effects
2819 remove ();
2820 move_type = mt;
2821 map->insert (this, x, y, this);
2822 }
2823 else
2824 move_type = mt;
2825}
2826
2827/* object should be a player.
2828 * we return the object the player has marked with the 'mark' command
2829 * below. If no match is found (or object has changed), we return
2830 * NULL. We leave it up to the calling function to print messages if
2831 * nothing is found.
2832 */
2833object *
2834object::mark () const
2835{
2836 if (contr && contr->mark && contr->mark->env == this)
2837 return contr->mark;
2838 else
2839 return 0;
2840}
2841
2842// put marked object first in the inventory
2843// this is used by identify-like spells so players can influence
2844// the order a bit.
2845void
2846object::splay_marked ()
2847{
2848 if (object *marked = mark ())
2849 splay (marked);
2850}
2851

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines