[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.222 by root, Wed Apr 30 05:06:36 2008 UTC vs.
Revision 1.261 by root, Wed Oct 1 16:04:16 2008 UTC

…		…
139		139
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	141	static bool
142	compare_ob_value_lists_one (const object wants, const object has)	142	compare_ob_value_lists_one (const object wants, const object has)
143	{	143	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	144	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	145	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	146	* different structure or at least keep the lists sorted...
149	*/	147	*/
150		148
151	/* For each field in wants, */	149	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	150	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	151	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	152	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		153
169	/* If we get here, every field in wants has a matching field in has. */	154	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	155	return true;
171	}	156	}
172		157
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	158	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	159	static bool
175	compare_ob_value_lists (const object ob1, const object ob2)	160	compare_ob_value_lists (const object ob1, const object ob2)
176	{	161	{
177	/* However, there may be fields in has which aren't partnered in wants,	162	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison twice. :(	163	* so we need to run the comparison twice. :(
179	*/	164	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	165	return compare_ob_value_lists_one (ob1, ob2)
		166	&& compare_ob_value_lists_one (ob2, ob1);
181	}	167	}
182		168
183	/* Function examines the 2 objects given to it, and returns true if	169	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	170	* they can be merged together.
185	*	171	*
…		…
200	\|\| ob1->speed != ob2->speed	186	\|\| ob1->speed != ob2->speed
201	\|\| ob1->value != ob2->value	187	\|\| ob1->value != ob2->value
202	\|\| ob1->name != ob2->name)	188	\|\| ob1->name != ob2->name)
203	return 0;	189	return 0;
204		190
205	/* Do not merge objects if nrof would overflow. First part checks	191	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	192	* is always 0 .. 2*31-1 /
207	* would fit into a 32 bit signed int, which is often used to hold	193	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof \|\| ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	194	return 0;
212		195
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	196	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	197	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	198	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	203	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		204
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	205	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	206	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		207
225	if (ob1->arch->name != ob2->arch->name	208	if (ob1->arch->archname != ob2->arch->archname
226	\|\| ob1->name != ob2->name	209	\|\| ob1->name != ob2->name
227	\|\| ob1->title != ob2->title	210	\|\| ob1->title != ob2->title
228	\|\| ob1->msg != ob2->msg	211	\|\| ob1->msg != ob2->msg
229	\|\| ob1->weight != ob2->weight	212	\|\| ob1->weight != ob2->weight
230	\|\| ob1->attacktype != ob2->attacktype	213	\|\| ob1->attacktype != ob2->attacktype
231	\|\| ob1->magic != ob2->magic	214	\|\| ob1->magic != ob2->magic
232	\|\| ob1->slaying != ob2->slaying	215	\|\| ob1->slaying != ob2->slaying
233	\|\| ob1->skill != ob2->skill	216	\|\| ob1->skill != ob2->skill
234	\|\| ob1->value != ob2->value	217	\|\| ob1->value != ob2->value
235	\|\| ob1->animation_id != ob2->animation_id	218	\|\| ob1->animation_id != ob2->animation_id
		219	\|\| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	\|\| ob1->client_type != ob2->client_type	220	\|\| ob1->client_type != ob2->client_type
237	\|\| ob1->materialname != ob2->materialname	221	\|\| ob1->materialname != ob2->materialname
238	\|\| ob1->lore != ob2->lore	222	\|\| ob1->lore != ob2->lore
239	\|\| ob1->subtype != ob2->subtype	223	\|\| ob1->subtype != ob2->subtype
240	\|\| ob1->move_type != ob2->move_type	224	\|\| ob1->move_type != ob2->move_type
…		…
248	\|\| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	232	\|\| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	233	return 0;
250		234
251	if ((ob1->flag ^ ob2->flag)	235	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	236	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	237	.reset (FLAG_REMOVED)
255	.any ())	238	.any ())
256	return 0;	239	return 0;
257		240
258	/* This is really a spellbook check - we should in general	241	/* This is really a spellbook check - we should in general
…		…
358	else	341	else
359	{	342	{
360	// maybe there is a player standing on the same mapspace	343	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	344	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	345	if (object *pl = ms ().player ())
		346	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363	if (!pl->container \|\| this == pl->container)	347	\|\| this == pl->container)
364	return pl;	348	return pl;
365	}	349	}
366	}	350	}
367		351
368	return 0;	352	return 0;
369	}	353	}
370		354
371	// adjust weight per container type ("of holding")	355	// adjust weight per container type ("of holding")
372	static sint32	356	static sint32
373	weight_adjust (object *op, sint32 weight)	357	weight_adjust_for (object *op, sint32 weight)
374	{	358	{
375	return op->type == CONTAINER	359	return op->type == CONTAINER
376	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	360	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377	: weight;	361	: weight;
378	}	362	}
…		…
384	static void	368	static void
385	adjust_weight (object *op, sint32 weight)	369	adjust_weight (object *op, sint32 weight)
386	{	370	{
387	while (op)	371	while (op)
388	{	372	{
		373	// adjust by actual difference to account for rounding errors
		374	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389	weight = weight_adjust (op, weight);	375	weight = weight_adjust_for (op, op->carrying)
		376	- weight_adjust_for (op, op->carrying - weight);
390		377
391	if (!weight)	378	if (!weight)
392	return;	379	return;
393		380
394	op->carrying += weight;	381	op->carrying += weight;
…		…
417	op->update_weight ();	404	op->update_weight ();
418		405
419	sum += op->total_weight ();	406	sum += op->total_weight ();
420	}	407	}
421		408
422	sum = weight_adjust (this, sum);	409	sum = weight_adjust_for (this, sum);
423		410
424	if (sum != carrying)	411	if (sum != carrying)
425	{	412	{
426	carrying = sum;	413	carrying = sum;
427		414
…		…
489	*/	476	*/
490	object *	477	object *
491	find_object_name (const char *str)	478	find_object_name (const char *str)
492	{	479	{
493	shstr_cmp str_ (str);	480	shstr_cmp str_ (str);
494	object *op;
495		481
		482	if (str_)
496	for_all_objects (op)	483	for_all_objects (op)
497	if (op->name == str_)	484	if (op->name == str_)
498	break;	485	return op;
499		486
500	return op;	487	return 0;
501	}	488	}
502		489
503	/*	490	/*
504	* Sets the owner and sets the skill and exp pointers to owner's current	491	* Sets the owner and sets the skill and exp pointers to owner's current
505	* skill and experience objects.	492	* skill and experience objects.
…		…
603	}	590	}
604		591
605	op->key_values = 0;	592	op->key_values = 0;
606	}	593	}
607		594
608	object &	595	/*
609	object::operator =(const object &src)	596	* copy_to first frees everything allocated by the dst object,
		597	* and then copies the contents of itself into the second
		598	* object, allocating what needs to be allocated. Basically, any
		599	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		600	* if the first object is freed, the pointers in the new object
		601	* will point at garbage.
		602	*/
		603	void
		604	object::copy_to (object *dst)
610	{	605	{
611	bool is_freed = flag [FLAG_FREED];	606	dst->remove ();
612	bool is_removed = flag [FLAG_REMOVED];
613
614	(object_copy )this = src;	607	(object_copy )dst = *this;
615
616	flag [FLAG_FREED] = is_freed;
617	flag [FLAG_REMOVED] = is_removed;	608	dst->flag [FLAG_REMOVED] = true;
618		609
619	/* Copy over key_values, if any. */	610	/* Copy over key_values, if any. */
620	if (src.key_values)	611	if (key_values)
621	{	612	{
622	key_value *tail = 0;	613	key_value *tail = 0;
623	key_values = 0;	614	dst->key_values = 0;
624		615
625	for (key_value *i = src.key_values; i; i = i->next)	616	for (key_value *i = key_values; i; i = i->next)
626	{	617	{
627	key_value *new_link = new key_value;	618	key_value *new_link = new key_value;
628		619
629	new_link->next = 0;	620	new_link->next = 0;
630	new_link->key = i->key;	621	new_link->key = i->key;
631	new_link->value = i->value;	622	new_link->value = i->value;
632		623
633	/* Try and be clever here, too. */	624	/* Try and be clever here, too. */
634	if (!key_values)	625	if (!dst->key_values)
635	{	626	{
636	key_values = new_link;	627	dst->key_values = new_link;
637	tail = new_link;	628	tail = new_link;
638	}	629	}
639	else	630	else
640	{	631	{
641	tail->next = new_link;	632	tail->next = new_link;
642	tail = new_link;	633	tail = new_link;
643	}	634	}
644	}	635	}
645	}	636	}
646	}
647
648	/*
649	* copy_to first frees everything allocated by the dst object,
650	* and then copies the contents of itself into the second
651	* object, allocating what needs to be allocated. Basically, any
652	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
653	* if the first object is freed, the pointers in the new object
654	* will point at garbage.
655	*/
656	void
657	object::copy_to (object *dst)
658	{
659	dst = this;
660		637
661	if (speed < 0)	638	if (speed < 0)
662	dst->speed_left -= rndm ();	639	dst->speed_left -= rndm ();
663		640
664	dst->set_speed (dst->speed);	641	dst->activate ();
665	}	642	}
666		643
667	void	644	void
668	object::instantiate ()	645	object::instantiate ()
669	{	646	{
…		…
686	object *	663	object *
687	object::clone ()	664	object::clone ()
688	{	665	{
689	object *neu = create ();	666	object *neu = create ();
690	copy_to (neu);	667	copy_to (neu);
		668	neu->map = map; // not copied by copy_to
691	return neu;	669	return neu;
692	}	670	}
693		671
694	/*	672	/*
695	* If an object with the IS_TURNABLE() flag needs to be turned due	673	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
788	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	766	\|\| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
789	\|\| (m.move_on \| op->move_on ) != m.move_on	767	\|\| (m.move_on \| op->move_on ) != m.move_on
790	\|\| (m.move_off \| op->move_off ) != m.move_off	768	\|\| (m.move_off \| op->move_off ) != m.move_off
791	\|\| (m.move_slow \| op->move_slow) != m.move_slow	769	\|\| (m.move_slow \| op->move_slow) != m.move_slow
792	/* This isn't perfect, but I don't expect a lot of objects to	770	/* This isn't perfect, but I don't expect a lot of objects to
793	* to have move_allow right now.	771	* have move_allow right now.
794	*/	772	*/
795	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block	773	\|\| ((m.move_block \| op->move_block) & ~op->move_allow) != m.move_block
796	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	774	\|\| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
797	m.flags_ = 0;	775	m.flags_ = 0;
798	}	776	}
…		…
852	{	830	{
853	/* If already on active list, don't do anything */	831	/* If already on active list, don't do anything */
854	if (active)	832	if (active)
855	return;	833	return;
856		834
		835	if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError \| logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		836	if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError \| logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
		837
857	if (has_active_speed ())	838	if (has_active_speed ())
858	actives.insert (this);	839	actives.insert (this);
859	}	840	}
860		841
861	void	842	void
…		…
924	* drop on that space.	905	* drop on that space.
925	*/	906	*/
926	if (!drop_to_ground	907	if (!drop_to_ground
927	\|\| !map	908	\|\| !map
928	\|\| map->in_memory != MAP_ACTIVE	909	\|\| map->in_memory != MAP_ACTIVE
929	\|\| map->nodrop	910	\|\| map->no_drop
930	\|\| ms ().move_block == MOVE_ALL)	911	\|\| ms ().move_block == MOVE_ALL)
931	{	912	{
932	while (inv)	913	while (inv)
933	{
934	inv->destroy_inv (false);
935	inv->destroy ();	914	inv->destroy ();
936	}
937	}	915	}
938	else	916	else
939	{ /* Put objects in inventory onto this space */	917	{ /* Put objects in inventory onto this space */
940	while (inv)	918	while (inv)
941	{	919	{
…		…
945	\|\| op->flag [FLAG_NO_DROP]	923	\|\| op->flag [FLAG_NO_DROP]
946	\|\| op->type == RUNE	924	\|\| op->type == RUNE
947	\|\| op->type == TRAP	925	\|\| op->type == TRAP
948	\|\| op->flag [FLAG_IS_A_TEMPLATE]	926	\|\| op->flag [FLAG_IS_A_TEMPLATE]
949	\|\| op->flag [FLAG_DESTROY_ON_DEATH])	927	\|\| op->flag [FLAG_DESTROY_ON_DEATH])
950	op->destroy (true);	928	op->destroy ();
951	else	929	else
952	map->insert (op, x, y);	930	map->insert (op, x, y);
953	}	931	}
954	}	932	}
955	}	933	}
…		…
959	object *op = new object;	937	object *op = new object;
960	op->link ();	938	op->link ();
961	return op;	939	return op;
962	}	940	}
963		941
		942	static struct freed_map : maptile
		943	{
		944	freed_map ()
		945	{
		946	path = "<freed objects map>";
		947	name = "/internal/freed_objects_map";
		948	width = 3;
		949	height = 3;
		950	no_drop = 1;
		951	no_reset = 1;
		952
		953	alloc ();
		954	in_memory = MAP_ACTIVE;
		955	}
		956
		957	~freed_map ()
		958	{
		959	destroy ();
		960	}
		961	} freed_map; // freed objects are moved here to avoid crashes
		962
964	void	963	void
965	object::do_destroy ()	964	object::do_destroy ()
966	{	965	{
967	if (flag [FLAG_IS_LINKED])	966	if (flag [FLAG_IS_LINKED])
968	remove_button_link (this);	967	remove_button_link (this);
…		…
978	unlink ();	977	unlink ();
979		978
980	flag [FLAG_FREED] = 1;	979	flag [FLAG_FREED] = 1;
981		980
982	// hack to ensure that freed objects still have a valid map	981	// hack to ensure that freed objects still have a valid map
983	{
984	static maptile *freed_map; // freed objects are moved here to avoid crashes
985
986	if (!freed_map)
987	{
988	freed_map = new maptile;
989
990	freed_map->path = "<freed objects map>";
991	freed_map->name = "/internal/freed_objects_map";
992	freed_map->width = 3;
993	freed_map->height = 3;
994	freed_map->nodrop = 1;
995
996	freed_map->alloc ();
997	freed_map->in_memory = MAP_ACTIVE;
998	}
999
1000	map = freed_map;	982	map = &freed_map;
1001	x = 1;	983	x = 1;
1002	y = 1;	984	y = 1;
1003	}
1004		985
1005	if (more)	986	if (more)
1006	{	987	{
1007	more->destroy ();	988	more->destroy ();
1008	more = 0;	989	more = 0;
…		…
1016	attacked_by = 0;	997	attacked_by = 0;
1017	current_weapon = 0;	998	current_weapon = 0;
1018	}	999	}
1019		1000
1020	void	1001	void
1021	object::destroy (bool destroy_inventory)	1002	object::destroy ()
1022	{	1003	{
1023	if (destroyed ())	1004	if (destroyed ())
1024	return;	1005	return;
1025		1006
1026	if (!is_head () && !head->destroyed ())	1007	if (!is_head () && !head->destroyed ())
1027	{	1008	{
1028	LOG (llevError \| logBacktrace, "tried to destroy the tail of an object");	1009	LOG (llevError \| logBacktrace, "tried to destroy the tail of an object");
1029	head->destroy (destroy_inventory);	1010	head->destroy ();
		1011	return;
1030	}	1012	}
1031		1013
1032	destroy_inv (!destroy_inventory);	1014	destroy_inv (false);
1033		1015
1034	if (is_head ())	1016	if (is_head ())
1035	if (sound_destroy)	1017	if (sound_destroy)
1036	play_sound (sound_destroy);	1018	play_sound (sound_destroy);
1037	else if (flag [FLAG_MONSTER])	1019	else if (flag [FLAG_MONSTER])
…		…
1073	if (object *pl = visible_to ())	1055	if (object *pl = visible_to ())
1074	esrv_del_item (pl->contr, count);	1056	esrv_del_item (pl->contr, count);
1075	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed	1057	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1076		1058
1077	adjust_weight (env, -total_weight ());	1059	adjust_weight (env, -total_weight ());
1078
1079	*(above ? &above->below : &env->inv) = below;
1080
1081	if (below)
1082	below->above = above;
1083		1060
1084	/* we set up values so that it could be inserted into	1061	/* we set up values so that it could be inserted into
1085	* the map, but we don't actually do that - it is up	1062	* the map, but we don't actually do that - it is up
1086	* to the caller to decide what we want to do.	1063	* to the caller to decide what we want to do.
1087	*/	1064	*/
1088	map = env->map;	1065	map = env->map;
1089	x = env->x;	1066	x = env->x;
1090	y = env->y;	1067	y = env->y;
		1068
		1069	// make sure cmov optimisation is applicable
		1070	*(above ? &above->below : &env->inv) = below;
		1071	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1072
1091	above = 0;	1073	above = 0;
1092	below = 0;	1074	below = 0;
1093	env = 0;	1075	env = 0;
1094		1076
1095	/* NO_FIX_PLAYER is set when a great many changes are being	1077	/* NO_FIX_PLAYER is set when a great many changes are being
…		…
1125		1107
1126	esrv_del_item (pl->contr, count);	1108	esrv_del_item (pl->contr, count);
1127	}	1109	}
1128		1110
1129	/* link the object above us */	1111	/* link the object above us */
1130	if (above)	1112	// re-link, make sure compiler can easily use cmove
1131	above->below = below;	1113	*(above ? &above->below : &ms.top) = below;
1132	else	1114	*(below ? &below->above : &ms.bot) = above;
1133	ms.top = below; /* we were top, set new top */
1134
1135	/* Relink the object below us, if there is one */
1136	if (below)
1137	below->above = above;
1138	else
1139	{
1140	/* Nothing below, which means we need to relink map object for this space
1141	* use translated coordinates in case some oddness with map tiling is
1142	* evident
1143	*/
1144	if (GET_MAP_OB (map, x, y) != this)
1145	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1146
1147	ms.bot = above; /* goes on above it. */
1148	}
1149		1115
1150	above = 0;	1116	above = 0;
1151	below = 0;	1117	below = 0;
		1118
		1119	ms.flags_ = 0;
1152		1120
1153	if (map->in_memory == MAP_SAVING)	1121	if (map->in_memory == MAP_SAVING)
1154	return;	1122	return;
1155		1123
1156	int check_walk_off = !flag [FLAG_NO_APPLY];	1124	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1163	* appropriately.	1131	* appropriately.
1164	*/	1132	*/
1165	pl->close_container ();	1133	pl->close_container ();
1166		1134
1167	//TODO: the floorbox prev/next might need updating	1135	//TODO: the floorbox prev/next might need updating
1168	esrv_del_item (pl->contr, count);	1136	//esrv_del_item (pl->contr, count);
		1137	//TODO: update floorbox to preserve ordering
		1138	if (pl->contr->ns)
		1139	pl->contr->ns->floorbox_update ();
1169	}	1140	}
1170		1141
1171	for (tmp = ms.bot; tmp; tmp = tmp->above)	1142	for (tmp = ms.bot; tmp; tmp = tmp->above)
1172	{	1143	{
1173	/* No point updating the players look faces if he is the object	1144	/* No point updating the players look faces if he is the object
…		…
1186	}	1157	}
1187		1158
1188	last = tmp;	1159	last = tmp;
1189	}	1160	}
1190		1161
1191	/* last == NULL if there are no objects on this space */
1192	//TODO: this makes little sense, why only update the topmost object?
1193	if (!last)
1194	map->at (x, y).flags_ = 0;
1195	else
1196	update_object (last, UP_OBJ_REMOVE);
1197
1198	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)	1162	if (flag [FLAG_BLOCKSVIEW] \|\| glow_radius)
1199	update_all_los (map, x, y);	1163	update_all_los (map, x, y);
1200	}	1164	}
1201	}	1165	}
1202		1166
…		…
1227	esrv_update_item (UPD_NROF, pl, top);	1191	esrv_update_item (UPD_NROF, pl, top);
1228		1192
1229	op->weight = 0; // cancel the addition above	1193	op->weight = 0; // cancel the addition above
1230	op->carrying = 0; // must be 0 already	1194	op->carrying = 0; // must be 0 already
1231		1195
1232	op->destroy (1);	1196	op->destroy ();
1233		1197
1234	return top;	1198	return top;
1235	}	1199	}
1236		1200
1237	return 0;	1201	return 0;
…		…
1265	* job preparing multi-part monsters.	1229	* job preparing multi-part monsters.
1266	*/	1230	*/
1267	object *	1231	object *
1268	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)	1232	insert_ob_in_map_at (object op, maptile m, object *originator, int flag, int x, int y)
1269	{	1233	{
		1234	op->remove ();
		1235
1270	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1236	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1271	{	1237	{
1272	tmp->x = x + tmp->arch->x;	1238	tmp->x = x + tmp->arch->x;
1273	tmp->y = y + tmp->arch->y;	1239	tmp->y = y + tmp->arch->y;
1274	}	1240	}
…		…
1297	* just 'op' otherwise	1263	* just 'op' otherwise
1298	*/	1264	*/
1299	object *	1265	object *
1300	insert_ob_in_map (object op, maptile m, object *originator, int flag)	1266	insert_ob_in_map (object op, maptile m, object *originator, int flag)
1301	{	1267	{
1302	assert (!op->flag [FLAG_FREED]);
1303
1304	op->remove ();	1268	op->remove ();
		1269
		1270	if (m == &freed_map)//D TODO: remove soon
		1271	{//D
		1272	LOG (llevError \| logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1273	}//D
1305		1274
1306	/* Ideally, the caller figures this out. However, it complicates a lot	1275	/* Ideally, the caller figures this out. However, it complicates a lot
1307	* of areas of callers (eg, anything that uses find_free_spot would now	1276	* of areas of callers (eg, anything that uses find_free_spot would now
1308	* need extra work	1277	* need extra work
1309	*/	1278	*/
1310	if (!xy_normalise (m, op->x, op->y))	1279	if (!xy_normalise (m, op->x, op->y))
1311	{	1280	{
1312	op->destroy (1);	1281	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1313	return 0;	1282	return 0;
1314	}	1283	}
1315		1284
1316	if (object *more = op->more)	1285	if (object *more = op->more)
1317	if (!insert_ob_in_map (more, m, originator, flag))	1286	if (!insert_ob_in_map (more, m, originator, flag))
…		…
1326	*/	1295	*/
1327	if (op->nrof && !(flag & INS_NO_MERGE))	1296	if (op->nrof && !(flag & INS_NO_MERGE))
1328	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1297	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1329	if (object::can_merge (op, tmp))	1298	if (object::can_merge (op, tmp))
1330	{	1299	{
1331	// TODO: we atcually want to update tmp, not op,	1300	// TODO: we actually want to update tmp, not op,
1332	// but some caller surely breaks when we return tmp	1301	// but some caller surely breaks when we return tmp
1333	// from here :/	1302	// from here :/
1334	op->nrof += tmp->nrof;	1303	op->nrof += tmp->nrof;
1335	tmp->destroy (1);	1304	tmp->destroy ();
1336	}	1305	}
1337		1306
1338	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1307	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1339	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1308	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1340		1309
…		…
1347	{	1316	{
1348	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1317	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1349	abort ();	1318	abort ();
1350	}	1319	}
1351		1320
		1321	if (!originator->is_on_map ())
		1322	LOG (llevDebug \| logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1323	op->debug_desc (), originator->debug_desc ());
		1324
1352	op->above = originator;	1325	op->above = originator;
1353	op->below = originator->below;	1326	op->below = originator->below;
1354
1355	if (op->below)
1356	op->below->above = op;
1357	else
1358	ms.bot = op;
1359
1360	/* since below originator, no need to update top */
1361	originator->below = op;	1327	originator->below = op;
		1328
		1329	*(op->below ? &op->below->above : &ms.bot) = op;
1362	}	1330	}
1363	else	1331	else
1364	{	1332	{
1365	object top, floor = NULL;	1333	object *floor = 0;
1366		1334	object *top = ms.top;
1367	top = ms.bot;
1368		1335
1369	/* If there are other objects, then */	1336	/* If there are other objects, then */
1370	if (top)	1337	if (top)
1371	{	1338	{
1372	object *last = 0;
1373
1374	/*	1339	/*
1375	* If there are multiple objects on this space, we do some trickier handling.	1340	* If there are multiple objects on this space, we do some trickier handling.
1376	* We've already dealt with merging if appropriate.	1341	* We've already dealt with merging if appropriate.
1377	* Generally, we want to put the new object on top. But if	1342	* Generally, we want to put the new object on top. But if
1378	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1343	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1381	* once we get to them. This reduces the need to traverse over all of	1346	* once we get to them. This reduces the need to traverse over all of
1382	* them when adding another one - this saves quite a bit of cpu time	1347	* them when adding another one - this saves quite a bit of cpu time
1383	* when lots of spells are cast in one area. Currently, it is presumed	1348	* when lots of spells are cast in one area. Currently, it is presumed
1384	* that flying non pickable objects are spell objects.	1349	* that flying non pickable objects are spell objects.
1385	*/	1350	*/
1386	for (top = ms.bot; top; top = top->above)	1351	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1387	{	1352	{
1388	if (QUERY_FLAG (top, FLAG_IS_FLOOR) \|\| QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1353	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) \|\| QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1389	floor = top;	1354	floor = tmp;
1390		1355
1391	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1356	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW \| MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1392	{	1357	{
1393	/* We insert above top, so we want this object below this */	1358	/* We insert above top, so we want this object below this */
1394	top = top->below;	1359	top = tmp->below;
1395	break;	1360	break;
1396	}	1361	}
1397		1362
1398	last = top;	1363	top = tmp;
1399	}	1364	}
1400
1401	/* Don't want top to be NULL, so set it to the last valid object */
1402	top = last;
1403		1365
1404	/* We let update_position deal with figuring out what the space	1366	/* We let update_position deal with figuring out what the space
1405	* looks like instead of lots of conditions here.	1367	* looks like instead of lots of conditions here.
1406	* makes things faster, and effectively the same result.	1368	* makes things faster, and effectively the same result.
1407	*/	1369	*/
…		…
1414	*/	1376	*/
1415	if (!(flag & INS_ON_TOP)	1377	if (!(flag & INS_ON_TOP)
1416	&& ms.flags () & P_BLOCKSVIEW	1378	&& ms.flags () & P_BLOCKSVIEW
1417	&& (op->face && !faces [op->face].visibility))	1379	&& (op->face && !faces [op->face].visibility))
1418	{	1380	{
		1381	object *last;
		1382
1419	for (last = top; last != floor; last = last->below)	1383	for (last = top; last != floor; last = last->below)
1420	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1384	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1421	break;	1385	break;
1422		1386
1423	/* Check to see if we found the object that blocks view,	1387	/* Check to see if we found the object that blocks view,
…		…
1431	} /* If objects on this space */	1395	} /* If objects on this space */
1432		1396
1433	if (flag & INS_ABOVE_FLOOR_ONLY)	1397	if (flag & INS_ABOVE_FLOOR_ONLY)
1434	top = floor;	1398	top = floor;
1435		1399
1436	/* Top is the object that our object (op) is going to get inserted above.	1400	// insert object above top, or bottom-most if top = 0
1437	*/
1438
1439	/* First object on this space */
1440	if (!top)	1401	if (!top)
1441	{	1402	{
		1403	op->below = 0;
1442	op->above = ms.bot;	1404	op->above = ms.bot;
1443
1444	if (op->above)
1445	op->above->below = op;
1446
1447	op->below = 0;
1448	ms.bot = op;	1405	ms.bot = op;
		1406
		1407	*(op->above ? &op->above->below : &ms.top) = op;
1449	}	1408	}
1450	else	1409	else
1451	{ /* get inserted into the stack above top */	1410	{
1452	op->above = top->above;	1411	op->above = top->above;
1453
1454	if (op->above)
1455	op->above->below = op;	1412	top->above = op;
1456		1413
1457	op->below = top;	1414	op->below = top;
1458	top->above = op;	1415	*(op->above ? &op->above->below : &ms.top) = op;
1459	}	1416	}
1460		1417	}
1461	if (!op->above)
1462	ms.top = op;
1463	} /* else not INS_BELOW_ORIGINATOR */
1464		1418
1465	if (op->type == PLAYER)	1419	if (op->type == PLAYER)
1466	{	1420	{
1467	op->contr->do_los = 1;	1421	op->contr->do_los = 1;
1468	++op->map->players;	1422	++op->map->players;
…		…
1471		1425
1472	op->map->dirty = true;	1426	op->map->dirty = true;
1473		1427
1474	if (object *pl = ms.player ())	1428	if (object *pl = ms.player ())
1475	//TODO: the floorbox prev/next might need updating	1429	//TODO: the floorbox prev/next might need updating
1476	esrv_send_item (pl, op);	1430	//esrv_send_item (pl, op);
		1431	//TODO: update floorbox to preserve ordering
		1432	if (pl->contr->ns)
		1433	pl->contr->ns->floorbox_update ();
1477		1434
1478	/* If this object glows, it may affect lighting conditions that are	1435	/* If this object glows, it may affect lighting conditions that are
1479	* visible to others on this map. But update_all_los is really	1436	* visible to others on this map. But update_all_los is really
1480	* an inefficient way to do this, as it means los for all players	1437	* an inefficient way to do this, as it means los for all players
1481	* on the map will get recalculated. The players could very well	1438	* on the map will get recalculated. The players could very well
…		…
1527	{	1484	{
1528	/* first search for itself and remove any old instances */	1485	/* first search for itself and remove any old instances */
1529		1486
1530	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1487	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1531	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1488	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1532	tmp->destroy (1);	1489	tmp->destroy ();
1533		1490
1534	object *tmp = arch_to_object (archetype::find (arch_string));	1491	object *tmp = arch_to_object (archetype::find (arch_string));
1535		1492
1536	tmp->x = op->x;	1493	tmp->x = op->x;
1537	tmp->y = op->y;	1494	tmp->y = op->y;
…		…
1561	if (!nr)	1518	if (!nr)
1562	return true;	1519	return true;
1563		1520
1564	nr = min (nr, nrof);	1521	nr = min (nr, nrof);
1565		1522
		1523	if (nrof > nr)
		1524	{
1566	nrof -= nr;	1525	nrof -= nr;
1567
1568	if (nrof)
1569	{
1570	adjust_weight (env, -weight * nr); // carrying == 0	1526	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1571		1527
1572	if (object *pl = visible_to ())	1528	if (object *pl = visible_to ())
1573	esrv_update_item (UPD_NROF, pl, this);	1529	esrv_update_item (UPD_NROF, pl, this);
1574		1530
1575	return true;	1531	return true;
1576	}	1532	}
1577	else	1533	else
1578	{	1534	{
1579	destroy (1);	1535	destroy ();
1580	return false;	1536	return false;
1581	}	1537	}
1582	}	1538	}
1583		1539
1584	/*	1540	/*
…		…
1601	}	1557	}
1602	else	1558	else
1603	{	1559	{
1604	decrease (nr);	1560	decrease (nr);
1605		1561
1606	object *op = object_create_clone (this);	1562	object *op = deep_clone ();
1607	op->nrof = nr;	1563	op->nrof = nr;
1608	return op;	1564	return op;
1609	}	1565	}
1610	}	1566	}
1611		1567
…		…
1661	if (object *pl = tmp->visible_to ())	1617	if (object *pl = tmp->visible_to ())
1662	esrv_update_item (UPD_NROF, pl, tmp);	1618	esrv_update_item (UPD_NROF, pl, tmp);
1663		1619
1664	adjust_weight (this, op->total_weight ());	1620	adjust_weight (this, op->total_weight ());
1665		1621
1666	op->destroy (1);	1622	op->destroy ();
1667	op = tmp;	1623	op = tmp;
1668	goto inserted;	1624	goto inserted;
1669	}	1625	}
1670		1626
1671	op->owner = 0; // it's his/hers now. period.	1627	op->owner = 0; // it's his/hers now. period.
…		…
1832	LOG (llevError, "Present_arch called outside map.\n");	1788	LOG (llevError, "Present_arch called outside map.\n");
1833	return NULL;	1789	return NULL;
1834	}	1790	}
1835		1791
1836	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1792	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1837	if (tmp->arch == at)	1793	if (tmp->arch->archname == at->archname)
1838	return tmp;	1794	return tmp;
1839		1795
1840	return NULL;	1796	return NULL;
1841	}	1797	}
1842		1798
…		…
1906	* The first matching object is returned, or NULL if none.	1862	* The first matching object is returned, or NULL if none.
1907	*/	1863	*/
1908	object *	1864	object *
1909	present_arch_in_ob (const archetype at, const object op)	1865	present_arch_in_ob (const archetype at, const object op)
1910	{	1866	{
1911	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1867	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1912	if (tmp->arch == at)	1868	if (tmp->arch->archname == at->archname)
1913	return tmp;	1869	return tmp;
1914		1870
1915	return NULL;	1871	return NULL;
1916	}	1872	}
1917		1873
…		…
2326		2282
2327	/*	2283	/*
2328	* create clone from object to another	2284	* create clone from object to another
2329	*/	2285	*/
2330	object *	2286	object *
2331	object_create_clone (object *asrc)	2287	object::deep_clone ()
2332	{	2288	{
2333	object dst = 0, tmp, src, prev, *item;	2289	assert (("deep_clone called on non-head object", is_head ()));
2334		2290
2335	if (!asrc)	2291	object *dst = clone ();
2336	return 0;
2337		2292
2338	src = asrc->head_ ();	2293	object *prev = dst;
2339
2340	prev = 0;
2341	for (object *part = src; part; part = part->more)	2294	for (object *part = this->more; part; part = part->more)
2342	{	2295	{
2343	tmp = part->clone ();	2296	object *tmp = part->clone ();
2344	tmp->x -= src->x;
2345	tmp->y -= src->y;
2346
2347	if (!part->head)
2348	{
2349	dst = tmp;
2350	tmp->head = 0;
2351	}
2352	else
2353	tmp->head = dst;	2297	tmp->head = dst;
2354
2355	tmp->more = 0;
2356
2357	if (prev)
2358	prev->more = tmp;	2298	prev->more = tmp;
2359
2360	prev = tmp;	2299	prev = tmp;
2361	}	2300	}
2362		2301
2363	for (item = src->inv; item; item = item->below)	2302	for (object *item = inv; item; item = item->below)
2364	insert_ob_in_ob (object_create_clone (item), dst);	2303	insert_ob_in_ob (item->deep_clone (), dst);
2365		2304
2366	return dst;	2305	return dst;
2367	}	2306	}
2368		2307
2369	/* This returns the first object in who's inventory that	2308	/* This returns the first object in who's inventory that
…		…
2378	return tmp;	2317	return tmp;
2379		2318
2380	return 0;	2319	return 0;
2381	}	2320	}
2382		2321
2383	/* If ob has a field named key, return the link from the list,	2322	const shstr &
2384	* otherwise return NULL.	2323	object::kv_get (const shstr &key) const
2385	*
2386	* key must be a passed in shared string - otherwise, this won't
2387	* do the desired thing.
2388	*/
2389	key_value *
2390	get_ob_key_link (const object ob, const char key)
2391	{	2324	{
2392	for (key_value *link = ob->key_values; link; link = link->next)	2325	for (key_value *kv = key_values; kv; kv = kv->next)
2393	if (link->key == key)	2326	if (kv->key == key)
2394	return link;
2395
2396	return 0;
2397	}
2398
2399	/*
2400	* Returns the value of op has an extra_field for key, or NULL.
2401	*
2402	* The argument doesn't need to be a shared string.
2403	*
2404	* The returned string is shared.
2405	*/
2406	const char *
2407	get_ob_key_value (const object op, const char const key)
2408	{
2409	key_value *link;
2410	shstr_cmp canonical_key (key);
2411
2412	if (!canonical_key)
2413	{
2414	/* 1. There being a field named key on any object
2415	* implies there'd be a shared string to find.
2416	* 2. Since there isn't, no object has this field.
2417	* 3. Therefore, this object doesn't have this field.
2418	*/
2419	return 0;
2420	}
2421
2422	/* This is copied from get_ob_key_link() above -
2423	* only 4 lines, and saves the function call overhead.
2424	*/
2425	for (link = op->key_values; link; link = link->next)
2426	if (link->key == canonical_key)
2427	return link->value;	2327	return kv->value;
2428		2328
2429	return 0;	2329	return shstr_null;
2430	}	2330	}
2431		2331
2432	/*	2332	void
2433	* Updates the canonical_key in op to value.	2333	object::kv_set (const shstr &key, const shstr &value)
2434	*
2435	* canonical_key is a shared string (value doesn't have to be).
2436	*
2437	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2438	* keys.
2439	*
2440	* Returns TRUE on success.
2441	*/
2442	int
2443	set_ob_key_value_s (object op, const shstr & canonical_key, const char value, int add_key)
2444	{	2334	{
2445	key_value field = NULL, last = NULL;	2335	for (key_value *kv = key_values; kv; kv = kv->next)
2446		2336	if (kv->key == key)
2447	for (field = op->key_values; field != NULL; field = field->next)
2448	{
2449	if (field->key != canonical_key)
2450	{	2337	{
2451	last = field;	2338	kv->value = value;
2452	continue;	2339	return;
2453	}	2340	}
2454		2341
2455	if (value)	2342	key_value *kv = new key_value;
2456	field->value = value;	2343
2457	else	2344	kv->next = key_values;
		2345	kv->key = key;
		2346	kv->value = value;
		2347
		2348	key_values = kv;
		2349	}
		2350
		2351	void
		2352	object::kv_del (const shstr &key)
		2353	{
		2354	for (key_value *kvp = &key_values; kvp; kvp = &(*kvp)->next)
		2355	if ((*kvp)->key == key)
2458	{	2356	{
2459	/* Basically, if the archetype has this key set,	2357	key_value kv = kvp;
2460	* we need to store the null value so when we save	2358	kvp = (kvp)->next;
2461	* it, we save the empty value so that when we load,	2359	delete kv;
2462	* we get this value back again.	2360	return;
2463	*/
2464	if (get_ob_key_link (op->arch, canonical_key))
2465	field->value = 0;
2466	else
2467	{
2468	if (last)
2469	last->next = field->next;
2470	else
2471	op->key_values = field->next;
2472
2473	delete field;
2474	}
2475	}	2361	}
2476	return TRUE;
2477	}
2478	/* IF we get here, key doesn't exist */
2479
2480	/* No field, we'll have to add it. */
2481
2482	if (!add_key)
2483	return FALSE;
2484
2485	/* There isn't any good reason to store a null
2486	* value in the key/value list. If the archetype has
2487	* this key, then we should also have it, so shouldn't
2488	* be here. If user wants to store empty strings,
2489	* should pass in ""
2490	*/
2491	if (value == NULL)
2492	return TRUE;
2493
2494	field = new key_value;
2495
2496	field->key = canonical_key;
2497	field->value = value;
2498	/* Usual prepend-addition. */
2499	field->next = op->key_values;
2500	op->key_values = field;
2501
2502	return TRUE;
2503	}
2504
2505	/*
2506	* Updates the key in op to value.
2507	*
2508	* If add_key is FALSE, this will only update existing keys,
2509	* and not add new ones.
2510	* In general, should be little reason FALSE is ever passed in for add_key
2511	*
2512	* Returns TRUE on success.
2513	*/
2514	int
2515	set_ob_key_value (object op, const char key, const char *value, int add_key)
2516	{
2517	shstr key_ (key);
2518
2519	return set_ob_key_value_s (op, key_, value, add_key);
2520	}	2362	}
2521		2363
2522	object::depth_iterator::depth_iterator (object *container)	2364	object::depth_iterator::depth_iterator (object *container)
2523	: iterator_base (container)	2365	: iterator_base (container)
2524	{	2366	{
…		…
2574	{	2416	{
2575	char flagdesc[512];	2417	char flagdesc[512];
2576	char info2[256 * 4];	2418	char info2[256 * 4];
2577	char *p = info;	2419	char *p = info;
2578		2420
2579	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2421	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2580	count,	2422	count,
2581	uuid.c_str (),	2423	uuid.c_str (),
2582	&name,	2424	&name,
2583	title ? "\",title:\"" : "",	2425	title ? ",title:\"" : "",
2584	title ? (const char *)title : "",	2426	title ? (const char *)title : "",
		2427	title ? "\"" : "",
2585	flag_desc (flagdesc, 512), type);	2428	flag_desc (flagdesc, 512), type);
2586		2429
2587	if (!flag[FLAG_REMOVED] && env)	2430	if (!flag[FLAG_REMOVED] && env)
2588	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2431	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2589		2432

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.222 by root, Wed Apr 30 05:06:36 2008 UTC vs. Revision 1.261 by root, Wed Oct 1 16:04:16 2008 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.222 by root, Wed Apr 30 05:06:36 2008 UTC vs.
Revision 1.261 by root, Wed Oct 1 16:04:16 2008 UTC