ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.162 by root, Sat Jun 16 00:12:20 2007 UTC vs.
Revision 1.274 by root, Sun Dec 28 03:58:36 2008 UTC

1	/*	1	/*
2	* This file is part of Crossfire TRT, the Multiplayer Online Role Playing Game.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team	4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Crossfire TRT is free software; you can redistribute it and/or modify it	8	* Deliantra is free software: you can redistribute it and/or modify
9	* under the terms of the GNU General Public License as published by the Free	9	* it under the terms of the GNU General Public License as published by
10	* Software Foundation; either version 2 of the License, or (at your option)	10	* the Free Software Foundation, either version 3 of the License, or
11	* any later version.	11	* (at your option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful, but	13	* This program is distributed in the hope that it will be useful,
14	* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License along	18	* You should have received a copy of the GNU General Public License
19	* with Crossfire TRT; if not, write to the Free Software Foundation, Inc. 51	19	* along with this program. If not, see <http://www.gnu.org/licenses/>.
20	* Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
21	*	20	*
22	* The authors can be reached via e-mail to <crossfire@schmorp.de>	21	* The authors can be reached via e-mail to <support@deliantra.net>
23	*/	22	*/
24		23
25	/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26	sub/add_weight will transcend the environment updating the carrying
27	variable. */
28	#include <global.h>	24	#include <global.h>
29	#include <stdio.h>	25	#include <stdio.h>
30	#include <sys/types.h>	26	#include <sys/types.h>
31	#include <sys/uio.h>	27	#include <sys/uio.h>
32	#include <object.h>	28	#include <object.h>
33	#include <funcpoint.h>
34	#include <sproto.h>	29	#include <sproto.h>
35	#include <loader.h>	30	#include <loader.h>
36		31
37	#include <bitset>	32	#include <bitset>
38		33
39	int nrofallocobjects = 0;	34	UUID UUID::cur;
40	static UUID uuid;	35	static uint64_t seq_next_save;
41	const uint64 UUID_SKIP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
42		38
43	objectvec objects;	39	objectvec objects;
44	activevec actives;	40	activevec actives;
45		41
46	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	42	short freearr_x[SIZEOFFREE] = {
		43	0,
		44	0, 1, 1, 1, 0, -1, -1, -1,
		45	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
47	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1	46	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
48	};	47	};
49	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	48	short freearr_y[SIZEOFFREE] = {
		49	0,
		50	-1, -1, 0, 1, 1, 1, 0, -1,
		51	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
50	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	52	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
51	};	53	};
52	int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45,	54	int maxfree[SIZEOFFREE] = {
		55	0,
		56	9, 10, 13, 14, 17, 18, 21, 22,
		57	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
53	48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49	58	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
54	};	59	};
55	int freedir[SIZEOFFREE] = {	60	int freedir[SIZEOFFREE] = {
56	0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	61	0,
		62	1, 2, 3, 4, 5, 6, 7, 8,
		63	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
57	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	64	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
58	};	65	};
59		66
60	static void	67	static void
61	write_uuid (void)	68	write_uuid (uval64 skip, bool sync)
62	{	69	{
63	char filename1[MAX_BUF], filename2[MAX_BUF];	70	CALL_BEGIN (2);
64		71	CALL_ARG_SV (newSVval64 (skip));
65	sprintf (filename1, "%s/uuid", settings.localdir);	72	CALL_ARG_SV (boolSV (sync));
66	sprintf (filename2, "%s/uuid~", settings.localdir);	73	CALL_CALL ("cf::write_uuid", G_DISCARD);
67		74	CALL_END;
68	FILE *fp;
69
70	if (!(fp = fopen (filename2, "w")))
71	{
72	LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
73	return;
74	}
75
76	fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
77	fclose (fp);
78	rename (filename2, filename1);
79	}	75	}
80		76
81	static void	77	static void
82	read_uuid (void)	78	read_uuid (void)
83	{	79	{
84	char filename[MAX_BUF];	80	char filename[MAX_BUF];
85		81
86	sprintf (filename, "%s/uuid", settings.localdir);	82	sprintf (filename, "%s/uuid", settings.localdir);
		83
		84	seq_next_save = 0;
87		85
88	FILE *fp;	86	FILE *fp;
89		87
90	if (!(fp = fopen (filename, "r")))	88	if (!(fp = fopen (filename, "r")))
91	{	89	{
92	if (errno == ENOENT)	90	if (errno == ENOENT)
93	{	91	{
94	LOG (llevInfo, "RESET uid to 1\n");	92	LOG (llevInfo, "RESET uid to 1\n");
95	uuid.seq = 0;	93	UUID::cur.seq = 0;
96	write_uuid ();	94	write_uuid (UUID_GAP, true);
97	return;	95	return;
98	}	96	}
99		97
100	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
101	_exit (1);	99	_exit (1);
102	}	100	}
103		101
104	int version;	102	UUID::BUF buf;
105	unsigned long long uid;	103	buf[0] = 0;
106	if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)	104	fgets (buf, sizeof (buf), fp);
		105
		106	if (!UUID::cur.parse (buf))
107	{	107	{
108	LOG (llevError, "FATAL: error reading uid from %s!\n", filename);	108	LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
109	_exit (1);	109	_exit (1);
110	}	110	}
111		111
112	uuid.seq = uid;	112	LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
113	write_uuid ();	113
114	LOG (llevDebug, "read UID: %" PRId64 "\n", uid);	114	write_uuid (UUID_GAP, true);
115	fclose (fp);	115	fclose (fp);
116	}	116	}
117		117
118	UUID	118	UUID
119	gen_uuid ()	119	UUID::gen ()
120	{	120	{
121	UUID uid;	121	UUID uid;
122		122
123	uid.seq = ++uuid.seq;	123	uid.seq = ++cur.seq;
124		124
125	if (!(uuid.seq & (UUID_SKIP - 1)))	125	if (expect_false (cur.seq >= seq_next_save))
126	write_uuid ();	126	{
		127	seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
		128	write_uuid (UUID_GAP, false);
		129	}
		130
127		131
128	return uid;	132	return uid;
129	}	133	}
130		134
131	void	135	void
132	init_uuid ()	136	UUID::init ()
133	{	137	{
134	read_uuid ();	138	read_uuid ();
135	}	139	}
136		140
137	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
138	static int	142	static bool
139	compare_ob_value_lists_one (const object *wants, const object *has)	143	compare_ob_value_lists_one (const object *wants, const object *has)
140	{	144	{
141	key_value *wants_field;
142
143	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	145	/* n-squared behaviour (see kv_get), but I'm hoping both
144	* objects with lists are rare, and lists stay short. If not, use a	146	* objects with lists are rare, and lists stay short. If not, use a
145	* different structure or at least keep the lists sorted...	147	* different structure or at least keep the lists sorted...
146	*/	148	*/
147		149
148	/* For each field in wants, */	150	/* For each field in wants, */
149	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	151	for (key_value *kv = wants->key_values; kv; kv = kv->next)
150	{	152	if (has->kv_get (kv->key) != kv->value)
151	key_value *has_field;	153	return false;
152
153	/* Look for a field in has with the same key. */
154	has_field = get_ob_key_link (has, wants_field->key);
155
156	if (has_field == NULL)
157	{
158	/* No field with that name. */
159	return FALSE;
160	}
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	{
165	/* Values don't match, so this half of the comparison is false. */
166	return FALSE;
167	}
168
169	/* If we get here, we found a match. Now for the next field in wants. */
170	}
171		154
172	/* If we get here, every field in wants has a matching field in has. */	155	/* If we get here, every field in wants has a matching field in has. */
173	return TRUE;	156	return true;
174	}	157	}
175		158
176	/* Returns TRUE if ob1 has the same key_values as ob2. */	159	/* Returns TRUE if ob1 has the same key_values as ob2. */
177	static int	160	static bool
178	compare_ob_value_lists (const object *ob1, const object *ob2)	161	compare_ob_value_lists (const object *ob1, const object *ob2)
179	{	162	{
180	/* However, there may be fields in has which aren't partnered in wants,	163	/* However, there may be fields in has which aren't partnered in wants,
181	* so we need to run the comparison *twice*. :(	164	* so we need to run the comparison *twice*. :(
182	*/	165	*/
183	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	166	return compare_ob_value_lists_one (ob1, ob2)
		167	&& compare_ob_value_lists_one (ob2, ob1);
184	}	168	}
185		169
186	/* Function examines the 2 objects given to it, and returns true if	170	/* Function examines the 2 objects given to it, and returns true if
187	* they can be merged together.	171	* they can be merged together.
188	*	172	*
…		…
203	|| ob1->speed != ob2->speed	187	|| ob1->speed != ob2->speed
204	|| ob1->value != ob2->value	188	|| ob1->value != ob2->value
205	|| ob1->name != ob2->name)	189	|| ob1->name != ob2->name)
206	return 0;	190	return 0;
207		191
208	//TODO: this ain't working well, use nicer and correct overflow check
209	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that	192	/* Do not merge objects if nrof would overflow, assume nrof
210	* value could not be stored in a sint32 (which unfortunately sometimes is	193	* is always 0 .. 2**31-1 */
211	* used to store nrof).	194	if (ob1->nrof > 0x7fffffff - ob2->nrof)
212	*/
213	if (ob1->nrof + ob2->nrof >= 1UL << 31)
214	return 0;	195	return 0;
215		196
216	/* If the objects have been identified, set the BEEN_APPLIED flag.	197	/* If the objects have been identified, set the BEEN_APPLIED flag.
217	* This is to the comparison of the flags below will be OK. We	198	* This is to the comparison of the flags below will be OK. We
218	* just can't ignore the been applied or identified flags, as they	199	* just can't ignore the been applied or identified flags, as they
219	* are not equal - just if it has been identified, the been_applied	200	* are not equal - just if it has been identified, the been_applied
220	* flags lose any meaning.	201	* flags lose any meaning.
221	*/	202	*/
222	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	203	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
223	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	204	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
224		205
225	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	206	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
226	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	207	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
227		208
228	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()	209	if (ob1->arch->archname != ob2->arch->archname
229	|| ob1->arch != ob2->arch
230	|| ob1->name != ob2->name	210	|| ob1->name != ob2->name
231	|| ob1->title != ob2->title	211	|| ob1->title != ob2->title
232	|| ob1->msg != ob2->msg	212	|| ob1->msg != ob2->msg
233	|| ob1->weight != ob2->weight	213	|| ob1->weight != ob2->weight
234	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
235	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
236	|| ob1->attacktype != ob2->attacktype	214	|| ob1->attacktype != ob2->attacktype
237	|| ob1->magic != ob2->magic	215	|| ob1->magic != ob2->magic
238	|| ob1->slaying != ob2->slaying	216	|| ob1->slaying != ob2->slaying
239	|| ob1->skill != ob2->skill	217	|| ob1->skill != ob2->skill
240	|| ob1->value != ob2->value	218	|| ob1->value != ob2->value
241	|| ob1->animation_id != ob2->animation_id	219	|| ob1->animation_id != ob2->animation_id
		220	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
242	|| ob1->client_type != ob2->client_type	221	|| ob1->client_type != ob2->client_type
243	|| ob1->materialname != ob2->materialname	222	|| ob1->materialname != ob2->materialname
244	|| ob1->lore != ob2->lore	223	|| ob1->lore != ob2->lore
245	|| ob1->subtype != ob2->subtype	224	|| ob1->subtype != ob2->subtype
246	|| ob1->move_type != ob2->move_type	225	|| ob1->move_type != ob2->move_type
247	|| ob1->move_block != ob2->move_block	226	|| ob1->move_block != ob2->move_block
248	|| ob1->move_allow != ob2->move_allow	227	|| ob1->move_allow != ob2->move_allow
249	|| ob1->move_on != ob2->move_on	228	|| ob1->move_on != ob2->move_on
250	|| ob1->move_off != ob2->move_off	229	|| ob1->move_off != ob2->move_off
251	|| ob1->move_slow != ob2->move_slow	230	|| ob1->move_slow != ob2->move_slow
252	|| ob1->move_slow_penalty != ob2->move_slow_penalty)	231	|| ob1->move_slow_penalty != ob2->move_slow_penalty
		232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
		233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
253	return 0;	234	return 0;
254		235
		236	if ((ob1->flag ^ ob2->flag)
		237	.reset (FLAG_INV_LOCKED)
		238	.reset (FLAG_REMOVED)
		239	.any ())
		240	return 0;
		241
255	/* This is really a spellbook check - really, we should	242	/* This is really a spellbook check - we should in general
256	* check all objects in the inventory.	243	* not merge objects with real inventories, as splitting them
		244	* is hard.
257	*/	245	*/
258	if (ob1->inv || ob2->inv)	246	if (ob1->inv || ob2->inv)
259	{	247	{
260	/* if one object has inventory but the other doesn't, not equiv */	248	if (!(ob1->inv && ob2->inv))
261	if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))	249	return 0; /* inventories differ in length */
262	return 0;
263		250
264	/* Now check to see if the two inventory objects could merge */	251	if (ob1->inv->below || ob2->inv->below)
		252	return 0; /* more than one object in inv */
		253
265	if (!object::can_merge (ob1->inv, ob2->inv))	254	if (!object::can_merge (ob1->inv, ob2->inv))
266	return 0;	255	return 0; /* inventory objects differ */
267		256
268	/* inventory ok - still need to check rest of this object to see	257	/* inventory ok - still need to check rest of this object to see
269	* if it is valid.	258	* if it is valid.
270	*/	259	*/
271	}	260	}
…		…
290	if (ob1->level != ob2->level)	279	if (ob1->level != ob2->level)
291	return 0;	280	return 0;
292	break;	281	break;
293	}	282	}
294		283
295	if (ob1->key_values != NULL || ob2->key_values != NULL)	284	if (ob1->key_values || ob2->key_values)
296	{	285	{
297	/* At least one of these has key_values. */	286	/* At least one of these has key_values. */
298	if ((ob1->key_values == NULL) != (ob2->key_values == NULL))	287	if ((!ob1->key_values) != (!ob2->key_values))
299	/* One has fields, but the other one doesn't. */	288	return 0; /* One has fields, but the other one doesn't. */
		289
		290	if (!compare_ob_value_lists (ob1, ob2))
300	return 0;	291	return 0;
301	else if (!compare_ob_value_lists (ob1, ob2))
302	return 0;
303	}	292	}
304		293
305	//TODO: generate an event or call into perl for additional checks
306	if (ob1->self || ob2->self)	294	if (ob1->self || ob2->self)
307	{	295	{
308	ob1->optimise ();	296	ob1->optimise ();
309	ob2->optimise ();	297	ob2->optimise ();
310		298
311	if (ob1->self || ob2->self)	299	if (ob1->self || ob2->self)
		300	{
		301	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
		302	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
		303
		304	if (k1 != k2)
312	return 0;	305	return 0;
		306
		307	if (k1 == 0)
		308	return 1;
		309
		310	if (!cfperl_can_merge (ob1, ob2))
		311	return 0;
		312	}
313	}	313	}
314		314
315	/* Everything passes, must be OK. */	315	/* Everything passes, must be OK. */
316	return 1;	316	return 1;
317	}	317	}
318		318
		319	// find player who can see this object
		320	object *
		321	object::visible_to () const
		322	{
		323	if (client_visible () && !flag [FLAG_REMOVED])
		324	{
		325	// see if we are in a container of sorts
		326	if (env)
		327	{
		328	// the player inventory itself is always visible
		329	if (env->is_player ())
		330	return env;
		331
		332	// else a player could have our env open
		333	object *envest = env->outer_env ();
		334
		335	// the player itself is always on a map, so we will find him here
		336	// even if our inv is in a player.
		337	if (envest->is_on_map ())
		338	if (object *pl = envest->ms ().player ())
		339	if (pl->container == env)
		340	return pl;
		341	}
		342	else
		343	{
		344	// maybe there is a player standing on the same mapspace
		345	// this will catch the case where "this" is a player
		346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		348	|| this == pl->container)
		349	return pl;
		350	}
		351	}
		352
		353	return 0;
		354	}
		355
		356	// adjust weight per container type ("of holding")
		357	static sint32
		358	weight_adjust_for (object *op, sint32 weight)
		359	{
		360	return op->type == CONTAINER
		361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
		362	: weight;
		363	}
		364
319	/*	365	/*
		366	* adjust_weight(object, weight) adds the specified weight to an object,
		367	* and also updates how much the environment(s) is/are carrying.
		368	*/
		369	static void
		370	adjust_weight (object *op, sint32 weight)
		371	{
		372	while (op)
		373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
		376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
		378
		379	if (!weight)
		380	return;
		381
		382	op->carrying += weight;
		383
		384	if (object *pl = op->visible_to ())
		385	if (pl != op) // player is handled lazily
		386	esrv_update_item (UPD_WEIGHT, pl, op);
		387
		388	op = op->env;
		389	}
		390	}
		391
		392	/*
320	* sum_weight() is a recursive function which calculates the weight	393	* this is a recursive function which calculates the weight
321	* an object is carrying. It goes through in figures out how much	394	* an object is carrying. It goes through op and figures out how much
322	* containers are carrying, and sums it up.	395	* containers are carrying, and sums it up.
323	*/	396	*/
324	long	397	void
325	sum_weight (object *op)	398	object::update_weight ()
326	{	399	{
327	long sum;	400	sint32 sum = 0;
328	object *inv;
329		401
330	for (sum = 0, inv = op->inv; inv; inv = inv->below)	402	for (object *op = inv; op; op = op->below)
331	{	403	{
332	if (inv->inv)	404	if (op->inv)
333	sum_weight (inv);	405	op->update_weight ();
334		406
335	sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);	407	sum += op->total_weight ();
		408	}
		409
		410	sum = weight_adjust_for (this, sum);
		411
		412	if (sum != carrying)
336	}	413	{
337
338	if (op->type == CONTAINER && op->stats.Str)
339	sum = (sum * (100 - op->stats.Str)) / 100;
340
341	if (op->carrying != sum)
342	op->carrying = sum;	414	carrying = sum;
343		415
344	return sum;	416	if (object *pl = visible_to ())
		417	if (pl != this) // player is handled lazily
		418	esrv_update_item (UPD_WEIGHT, pl, this);
		419	}
345	}	420	}
346		421
347	/**	422	/*
348	* Return the outermost environment object for a given object.	423	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
349	*/
350
351	object *
352	object_get_env_recursive (object *op)
353	{
354	while (op->env != NULL)
355	op = op->env;
356	return op;
357	}
358
359	/*
360	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
361	* Some error messages.
362	* The result of the dump is stored in the static global errmsg array.
363	*/	424	*/
364	char *	425	char *
365	dump_object (object *op)	426	dump_object (object *op)
366	{	427	{
367	if (!op)	428	if (!op)
…		…
375	/*	436	/*
376	* get_nearest_part(multi-object, object 2) returns the part of the	437	* get_nearest_part(multi-object, object 2) returns the part of the
377	* multi-object 1 which is closest to the second object.	438	* multi-object 1 which is closest to the second object.
378	* If it's not a multi-object, it is returned.	439	* If it's not a multi-object, it is returned.
379	*/	440	*/
380
381	object *	441	object *
382	get_nearest_part (object *op, const object *pl)	442	get_nearest_part (object *op, const object *pl)
383	{	443	{
384	object *tmp, *closest;	444	object *tmp, *closest;
385	int last_dist, i;	445	int last_dist, i;
386		446
387	if (op->more == NULL)	447	if (!op->more)
388	return op;	448	return op;
		449
389	for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)	450	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
		451	tmp;
		452	tmp = tmp->more)
390	if ((i = distance (tmp, pl)) < last_dist)	453	if ((i = distance (tmp, pl)) < last_dist)
391	closest = tmp, last_dist = i;	454	closest = tmp, last_dist = i;
		455
392	return closest;	456	return closest;
393	}	457	}
394		458
395	/*	459	/*
396	* Returns the object which has the count-variable equal to the argument.	460	* Returns the object which has the count-variable equal to the argument.
		461	* VERRRY slow.
397	*/	462	*/
398	object *	463	object *
399	find_object (tag_t i)	464	find_object (tag_t i)
400	{	465	{
401	for_all_objects (op)	466	for_all_objects (op)
…		…
412	*/	477	*/
413	object *	478	object *
414	find_object_name (const char *str)	479	find_object_name (const char *str)
415	{	480	{
416	shstr_cmp str_ (str);	481	shstr_cmp str_ (str);
417	object *op;
418		482
		483	if (str_)
419	for_all_objects (op)	484	for_all_objects (op)
420	if (op->name == str_)	485	if (op->name == str_)
421	break;	486	return op;
422		487
423	return op;	488	return 0;
424	}
425
426	void
427	free_all_object_data ()
428	{
429	LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
430	}	489	}
431		490
432	/*	491	/*
433	* Sets the owner and sets the skill and exp pointers to owner's current	492	* Sets the owner and sets the skill and exp pointers to owner's current
434	* skill and experience objects.	493	* skill and experience objects.
		494	* ACTUALLY NO! investigate! TODO
435	*/	495	*/
436	void	496	void
437	object::set_owner (object *owner)	497	object::set_owner (object *owner)
438	{	498	{
		499	// allow objects which own objects
439	if (!owner)	500	if (owner)
440	return;
441
442	/* next line added to allow objects which own objects */
443	/* Add a check for ownercounts in here, as I got into an endless loop
444	* with the fireball owning a poison cloud which then owned the
445	* fireball. I believe that was caused by one of the objects getting
446	* freed and then another object replacing it. Since the ownercounts
447	* didn't match, this check is valid and I believe that cause is valid.
448	*/
449	while (owner->owner)	501	while (owner->owner)
450	owner = owner->owner;	502	owner = owner->owner;
		503
		504	if (flag [FLAG_FREED])
		505	{
		506	LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
		507	return;
		508	}
451		509
452	this->owner = owner;	510	this->owner = owner;
453	}	511	}
454		512
455	int	513	int
…		…
533	}	591	}
534		592
535	op->key_values = 0;	593	op->key_values = 0;
536	}	594	}
537		595
538	object &	596	/*
539	object::operator =(const object &src)	597	* copy_to first frees everything allocated by the dst object,
		598	* and then copies the contents of itself into the second
		599	* object, allocating what needs to be allocated. Basically, any
		600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		601	* if the first object is freed, the pointers in the new object
		602	* will point at garbage.
		603	*/
		604	void
		605	object::copy_to (object *dst)
540	{	606	{
541	bool is_freed = flag [FLAG_FREED];	607	dst->remove ();
542	bool is_removed = flag [FLAG_REMOVED];
543
544	*(object_copy *)this = src;	608	*(object_copy *)dst = *this;
545
546	flag [FLAG_FREED] = is_freed;
547	flag [FLAG_REMOVED] = is_removed;	609	dst->flag [FLAG_REMOVED] = true;
548		610
549	/* Copy over key_values, if any. */	611	/* Copy over key_values, if any. */
550	if (src.key_values)	612	if (key_values)
551	{	613	{
552	key_value *tail = 0;	614	key_value *tail = 0;
553	key_values = 0;	615	dst->key_values = 0;
554		616
555	for (key_value *i = src.key_values; i; i = i->next)	617	for (key_value *i = key_values; i; i = i->next)
556	{	618	{
557	key_value *new_link = new key_value;	619	key_value *new_link = new key_value;
558		620
559	new_link->next = 0;	621	new_link->next = 0;
560	new_link->key = i->key;	622	new_link->key = i->key;
561	new_link->value = i->value;	623	new_link->value = i->value;
562		624
563	/* Try and be clever here, too. */	625	/* Try and be clever here, too. */
564	if (!key_values)	626	if (!dst->key_values)
565	{	627	{
566	key_values = new_link;	628	dst->key_values = new_link;
567	tail = new_link;	629	tail = new_link;
568	}	630	}
569	else	631	else
570	{	632	{
571	tail->next = new_link;	633	tail->next = new_link;
572	tail = new_link;	634	tail = new_link;
573	}	635	}
574	}	636	}
575	}	637	}
576	}
577
578	/*
579	* copy_to first frees everything allocated by the dst object,
580	* and then copies the contents of itself into the second
581	* object, allocating what needs to be allocated. Basically, any
582	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
583	* if the first object is freed, the pointers in the new object
584	* will point at garbage.
585	*/
586	void
587	object::copy_to (object *dst)
588	{
589	*dst = *this;
590		638
591	if (speed < 0)	639	if (speed < 0)
592	dst->speed_left = speed_left - rndm ();	640	dst->speed_left -= rndm ();
593		641
594	dst->set_speed (dst->speed);	642	dst->activate ();
595	}	643	}
596		644
597	void	645	void
598	object::instantiate ()	646	object::instantiate ()
599	{	647	{
600	if (!uuid.seq) // HACK	648	if (!uuid.seq) // HACK
601	uuid = gen_uuid ();	649	uuid = UUID::gen ();
602		650
603	speed_left = -0.1f;	651	speed_left = -0.1f;
604	/* copy the body_info to the body_used - this is only really	652	/* copy the body_info to the body_used - this is only really
605	* need for monsters, but doesn't hurt to do it for everything.	653	* need for monsters, but doesn't hurt to do it for everything.
606	* by doing so, when a monster is created, it has good starting	654	* by doing so, when a monster is created, it has good starting
…		…
616	object *	664	object *
617	object::clone ()	665	object::clone ()
618	{	666	{
619	object *neu = create ();	667	object *neu = create ();
620	copy_to (neu);	668	copy_to (neu);
		669	neu->map = map; // not copied by copy_to
621	return neu;	670	return neu;
622	}	671	}
623		672
624	/*	673	/*
625	* If an object with the IS_TURNABLE() flag needs to be turned due	674	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
676	* UP_OBJ_FACE: only the objects face has changed.	725	* UP_OBJ_FACE: only the objects face has changed.
677	*/	726	*/
678	void	727	void
679	update_object (object *op, int action)	728	update_object (object *op, int action)
680	{	729	{
681	if (op == NULL)	730	if (!op)
682	{	731	{
683	/* this should never happen */	732	/* this should never happen */
684	LOG (llevDebug, "update_object() called for NULL object.\n");	733	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
685	return;	734	return;
686	}	735	}
687		736
688	if (op->env)	737	if (!op->is_on_map ())
689	{	738	{
690	/* Animation is currently handled by client, so nothing	739	/* Animation is currently handled by client, so nothing
691	* to do in this case.	740	* to do in this case.
692	*/	741	*/
693	return;	742	return;
694	}	743	}
695
696	/* If the map is saving, don't do anything as everything is
697	* going to get freed anyways.
698	*/
699	if (!op->map || op->map->in_memory == MAP_SAVING)
700	return;
701		744
702	/* make sure the object is within map boundaries */	745	/* make sure the object is within map boundaries */
703	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	746	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
704	{	747	{
705	LOG (llevError, "update_object() called for object out of map!\n");	748	LOG (llevError, "update_object() called for object out of map!\n");
…		…
716	else if (action == UP_OBJ_INSERT)	759	else if (action == UP_OBJ_INSERT)
717	{	760	{
718	// this is likely overkill, TODO: revisit (schmorp)	761	// this is likely overkill, TODO: revisit (schmorp)
719	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	762	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
720	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	763	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
721	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	764	|| (op->is_player () && !(m.flags_ & P_PLAYER))
722	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	765	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
723	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	766	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
724	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	767	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
725	|| (m.move_on | op->move_on ) != m.move_on	768	|| (m.move_on | op->move_on ) != m.move_on
726	|| (m.move_off | op->move_off ) != m.move_off	769	|| (m.move_off | op->move_off ) != m.move_off
727	|| (m.move_slow | op->move_slow) != m.move_slow	770	|| (m.move_slow | op->move_slow) != m.move_slow
728	/* This isn't perfect, but I don't expect a lot of objects to	771	/* This isn't perfect, but I don't expect a lot of objects to
729	* to have move_allow right now.	772	* have move_allow right now.
730	*/	773	*/
731	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	774	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
732	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	775	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
733	m.flags_ = 0;	776	m.invalidate ();
734	}	777	}
735	/* if the object is being removed, we can't make intelligent	778	/* if the object is being removed, we can't make intelligent
736	* decisions, because remove_ob can't really pass the object	779	* decisions, because remove_ob can't really pass the object
737	* that is being removed.	780	* that is being removed.
738	*/	781	*/
739	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	782	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
740	m.flags_ = 0;	783	m.invalidate ();
741	else if (action == UP_OBJ_FACE)	784	else if (action == UP_OBJ_FACE)
742	/* Nothing to do for that case */ ;	785	/* Nothing to do for that case */ ;
743	else	786	else
744	LOG (llevError, "update_object called with invalid action: %d\n", action);	787	LOG (llevError, "update_object called with invalid action: %d\n", action);
745		788
…		…
765	static int object_count;	808	static int object_count;
766		809
767	void object::link ()	810	void object::link ()
768	{	811	{
769	assert (!index);//D	812	assert (!index);//D
770	uuid = gen_uuid ();	813	uuid = UUID::gen ();
771	count = ++object_count;	814	count = ++object_count;
772		815
773	refcnt_inc ();	816	refcnt_inc ();
774	objects.insert (this);	817	objects.insert (this);
775	}	818	}
…		…
787	object::activate ()	830	object::activate ()
788	{	831	{
789	/* If already on active list, don't do anything */	832	/* If already on active list, don't do anything */
790	if (active)	833	if (active)
791	return;	834	return;
		835
		836	if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		837	if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
792		838
793	if (has_active_speed ())	839	if (has_active_speed ())
794	actives.insert (this);	840	actives.insert (this);
795	}	841	}
796		842
…		…
848	object::destroy_inv (bool drop_to_ground)	894	object::destroy_inv (bool drop_to_ground)
849	{	895	{
850	// need to check first, because the checks below might segfault	896	// need to check first, because the checks below might segfault
851	// as we might be on an invalid mapspace and crossfire code	897	// as we might be on an invalid mapspace and crossfire code
852	// is too buggy to ensure that the inventory is empty.	898	// is too buggy to ensure that the inventory is empty.
853	// corollary: if you create arrows etc. with stuff in tis inventory,	899	// corollary: if you create arrows etc. with stuff in its inventory,
854	// cf will crash below with off-map x and y	900	// cf will crash below with off-map x and y
855	if (!inv)	901	if (!inv)
856	return;	902	return;
857		903
858	/* Only if the space blocks everything do we not process -	904	/* Only if the space blocks everything do we not process -
859	* if some form of movement is allowed, let objects	905	* if some form of movement is allowed, let objects
860	* drop on that space.	906	* drop on that space.
861	*/	907	*/
862	if (!drop_to_ground	908	if (!drop_to_ground
863	|| !map	909	|| !map
864	|| map->in_memory != MAP_IN_MEMORY	910	|| map->in_memory != MAP_ACTIVE
865	|| map->nodrop	911	|| map->no_drop
866	|| ms ().move_block == MOVE_ALL)	912	|| ms ().move_block == MOVE_ALL)
867	{	913	{
868	while (inv)	914	while (inv)
869	{
870	inv->destroy_inv (drop_to_ground);
871	inv->destroy ();	915	inv->destroy ();
872	}
873	}	916	}
874	else	917	else
875	{ /* Put objects in inventory onto this space */	918	{ /* Put objects in inventory onto this space */
876	while (inv)	919	while (inv)
877	{	920	{
…		…
895	object *op = new object;	938	object *op = new object;
896	op->link ();	939	op->link ();
897	return op;	940	return op;
898	}	941	}
899		942
		943	static struct freed_map : maptile
		944	{
		945	freed_map ()
		946	{
		947	path = "<freed objects map>";
		948	name = "/internal/freed_objects_map";
		949	width = 3;
		950	height = 3;
		951	no_drop = 1;
		952	no_reset = 1;
		953
		954	alloc ();
		955	in_memory = MAP_ACTIVE;
		956	}
		957
		958	~freed_map ()
		959	{
		960	destroy ();
		961	}
		962	} freed_map; // freed objects are moved here to avoid crashes
		963
900	void	964	void
901	object::do_destroy ()	965	object::do_destroy ()
902	{	966	{
903	attachable::do_destroy ();
904
905	if (flag [FLAG_IS_LINKED])	967	if (flag [FLAG_IS_LINKED])
906	remove_button_link (this);	968	remove_button_link (this);
907		969
908	if (flag [FLAG_FRIENDLY])	970	if (flag [FLAG_FRIENDLY])
909	remove_friendly_object (this);	971	remove_friendly_object (this);
910		972
911	if (!flag [FLAG_REMOVED])
912	remove ();	973	remove ();
913		974
914	destroy_inv (true);	975	attachable::do_destroy ();
915		976
916	deactivate ();	977	deactivate ();
917	unlink ();	978	unlink ();
918		979
919	flag [FLAG_FREED] = 1;	980	flag [FLAG_FREED] = 1;
920		981
921	// hack to ensure that freed objects still have a valid map	982	// hack to ensure that freed objects still have a valid map
922	{
923	static maptile *freed_map; // freed objects are moved here to avoid crashes
924
925	if (!freed_map)
926	{
927	freed_map = new maptile;
928
929	freed_map->name = "/internal/freed_objects_map";
930	freed_map->width = 3;
931	freed_map->height = 3;
932
933	freed_map->alloc ();
934	freed_map->in_memory = MAP_IN_MEMORY;
935	}
936
937	map = freed_map;	983	map = &freed_map;
938	x = 1;	984	x = 1;
939	y = 1;	985	y = 1;
940	}
941		986
942	if (more)	987	if (more)
943	{	988	{
944	more->destroy ();	989	more->destroy ();
945	more = 0;	990	more = 0;
…		…
953	attacked_by = 0;	998	attacked_by = 0;
954	current_weapon = 0;	999	current_weapon = 0;
955	}	1000	}
956		1001
957	void	1002	void
958	object::destroy (bool destroy_inventory)	1003	object::destroy ()
959	{	1004	{
960	if (destroyed ())	1005	if (destroyed ())
961	return;	1006	return;
962		1007
963	if (destroy_inventory)	1008	if (!is_head () && !head->destroyed ())
		1009	{
		1010	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1011	head->destroy ();
		1012	return;
		1013	}
		1014
964	destroy_inv (false);	1015	destroy_inv (false);
		1016
		1017	if (is_head ())
		1018	if (sound_destroy)
		1019	play_sound (sound_destroy);
		1020	else if (flag [FLAG_MONSTER])
		1021	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
965		1022
966	attachable::destroy ();	1023	attachable::destroy ();
967	}
968
969	/*
970	* sub_weight() recursively (outwards) subtracts a number from the
971	* weight of an object (and what is carried by it's environment(s)).
972	*/
973	void
974	sub_weight (object *op, signed long weight)
975	{
976	while (op != NULL)
977	{
978	if (op->type == CONTAINER)
979	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
980
981	op->carrying -= weight;
982	op = op->env;
983	}
984	}	1024	}
985		1025
986	/* op->remove ():	1026	/* op->remove ():
987	* This function removes the object op from the linked list of objects	1027	* This function removes the object op from the linked list of objects
988	* which it is currently tied to. When this function is done, the	1028	* which it is currently tied to. When this function is done, the
…		…
994	object::do_remove ()	1034	object::do_remove ()
995	{	1035	{
996	object *tmp, *last = 0;	1036	object *tmp, *last = 0;
997	object *otmp;	1037	object *otmp;
998		1038
999	if (QUERY_FLAG (this, FLAG_REMOVED))	1039	if (flag [FLAG_REMOVED])
1000	return;	1040	return;
1001		1041
1002	SET_FLAG (this, FLAG_REMOVED);
1003	INVOKE_OBJECT (REMOVE, this);	1042	INVOKE_OBJECT (REMOVE, this);
		1043
		1044	flag [FLAG_REMOVED] = true;
1004		1045
1005	if (more)	1046	if (more)
1006	more->remove ();	1047	more->remove ();
1007		1048
1008	/*	1049	/*
1009	* In this case, the object to be removed is in someones	1050	* In this case, the object to be removed is in someones
1010	* inventory.	1051	* inventory.
1011	*/	1052	*/
1012	if (env)	1053	if (env)
1013	{	1054	{
1014	if (nrof)	1055	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1015	sub_weight (env, weight * nrof);	1056	if (object *pl = visible_to ())
1016	else	1057	esrv_del_item (pl->contr, count);
1017	sub_weight (env, weight + carrying);	1058	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1059
		1060	adjust_weight (env, -total_weight ());
		1061
		1062	object *pl = in_player ();
		1063
		1064	/* we set up values so that it could be inserted into
		1065	* the map, but we don't actually do that - it is up
		1066	* to the caller to decide what we want to do.
		1067	*/
		1068	map = env->map;
		1069	x = env->x;
		1070	y = env->y;
		1071
		1072	// make sure cmov optimisation is applicable
		1073	*(above ? &above->below : &env->inv) = below;
		1074	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1075
		1076	above = 0;
		1077	below = 0;
		1078	env = 0;
1018		1079
1019	/* NO_FIX_PLAYER is set when a great many changes are being	1080	/* NO_FIX_PLAYER is set when a great many changes are being
1020	* made to players inventory. If set, avoiding the call	1081	* made to players inventory. If set, avoiding the call
1021	* to save cpu time.	1082	* to save cpu time.
1022	*/	1083	*/
1023	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1084	if (pl)
		1085	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1086	{
1024	otmp->update_stats ();	1087	pl->update_stats ();
1025		1088
1026	if (above)	1089	if (glow_radius && pl->is_on_map ())
1027	above->below = below;	1090	update_all_los (pl->map, pl->x, pl->y);
1028	else	1091	}
1029	env->inv = below;
1030
1031	if (below)
1032	below->above = above;
1033
1034	/* we set up values so that it could be inserted into
1035	* the map, but we don't actually do that - it is up
1036	* to the caller to decide what we want to do.
1037	*/
1038	x = env->x, y = env->y;
1039	map = env->map;
1040	above = 0, below = 0;
1041	env = 0;
1042	}	1092	}
1043	else if (map)	1093	else if (map)
1044	{	1094	{
1045	if (type == PLAYER)
1046	{
1047	// leaving a spot always closes any open container on the ground
1048	if (container && !container->env)
1049	// this causes spurious floorbox updates, but it ensures
1050	// that the CLOSE event is being sent.
1051	close_container ();
1052
1053	--map->players;
1054	map->touch ();
1055	}
1056
1057	map->dirty = true;	1095	map->dirty = true;
1058	mapspace &ms = this->ms ();	1096	mapspace &ms = this->ms ();
1059		1097
		1098	if (object *pl = ms.player ())
		1099	{
		1100	if (is_player ())
		1101	{
		1102	if (!flag [FLAG_WIZPASS])
		1103	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1104
		1105	// leaving a spot always closes any open container on the ground
		1106	if (container && !container->env)
		1107	// this causes spurious floorbox updates, but it ensures
		1108	// that the CLOSE event is being sent.
		1109	close_container ();
		1110
		1111	--map->players;
		1112	map->touch ();
		1113	}
		1114	else if (pl->container == this)
		1115	{
		1116	// removing a container should close it
		1117	close_container ();
		1118	}
		1119
		1120	esrv_del_item (pl->contr, count);
		1121	}
		1122
1060	/* link the object above us */	1123	/* link the object above us */
1061	if (above)	1124	// re-link, make sure compiler can easily use cmove
1062	above->below = below;	1125	*(above ? &above->below : &ms.top) = below;
1063	else	1126	*(below ? &below->above : &ms.bot) = above;
1064	ms.top = below; /* we were top, set new top */
1065
1066	/* Relink the object below us, if there is one */
1067	if (below)
1068	below->above = above;
1069	else
1070	{
1071	/* Nothing below, which means we need to relink map object for this space
1072	* use translated coordinates in case some oddness with map tiling is
1073	* evident
1074	*/
1075	if (GET_MAP_OB (map, x, y) != this)
1076	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1077
1078	ms.bot = above; /* goes on above it. */
1079	}
1080		1127
1081	above = 0;	1128	above = 0;
1082	below = 0;	1129	below = 0;
1083		1130
		1131	ms.invalidate ();
		1132
1084	if (map->in_memory == MAP_SAVING)	1133	if (map->in_memory == MAP_SAVING)
1085	return;	1134	return;
1086		1135
1087	int check_walk_off = !flag [FLAG_NO_APPLY];	1136	int check_walk_off = !flag [FLAG_NO_APPLY];
		1137
		1138	if (object *pl = ms.player ())
		1139	{
		1140	if (pl->container == this)
		1141	/* If a container that the player is currently using somehow gets
		1142	* removed (most likely destroyed), update the player view
		1143	* appropriately.
		1144	*/
		1145	pl->close_container ();
		1146
		1147	//TODO: the floorbox prev/next might need updating
		1148	//esrv_del_item (pl->contr, count);
		1149	//TODO: update floorbox to preserve ordering
		1150	if (pl->contr->ns)
		1151	pl->contr->ns->floorbox_update ();
		1152	}
1088		1153
1089	for (tmp = ms.bot; tmp; tmp = tmp->above)	1154	for (tmp = ms.bot; tmp; tmp = tmp->above)
1090	{	1155	{
1091	/* No point updating the players look faces if he is the object	1156	/* No point updating the players look faces if he is the object
1092	* being removed.	1157	* being removed.
1093	*/	1158	*/
1094
1095	if (tmp->type == PLAYER && tmp != this)
1096	{
1097	/* If a container that the player is currently using somehow gets
1098	* removed (most likely destroyed), update the player view
1099	* appropriately.
1100	*/
1101	if (tmp->container == this)
1102	{
1103	flag [FLAG_APPLIED] = 0;
1104	tmp->container = 0;
1105	}
1106
1107	if (tmp->contr->ns)
1108	tmp->contr->ns->floorbox_update ();
1109	}
1110		1159
1111	/* See if object moving off should effect something */	1160	/* See if object moving off should effect something */
1112	if (check_walk_off	1161	if (check_walk_off
1113	&& ((move_type & tmp->move_off)	1162	&& ((move_type & tmp->move_off)
1114	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1163	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
…		…
1120	}	1169	}
1121		1170
1122	last = tmp;	1171	last = tmp;
1123	}	1172	}
1124		1173
1125	/* last == NULL if there are no objects on this space */	1174	if (affects_los ())
1126	//TODO: this makes little sense, why only update the topmost object?
1127	if (!last)
1128	map->at (x, y).flags_ = 0;
1129	else
1130	update_object (last, UP_OBJ_REMOVE);
1131
1132	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1133	update_all_los (map, x, y);	1175	update_all_los (map, x, y);
1134	}	1176	}
1135	}	1177	}
1136		1178
1137	/*	1179	/*
…		…
1146	merge_ob (object *op, object *top)	1188	merge_ob (object *op, object *top)
1147	{	1189	{
1148	if (!op->nrof)	1190	if (!op->nrof)
1149	return 0;	1191	return 0;
1150		1192
1151	if (top)	1193	if (!top)
1152	for (top = op; top && top->above; top = top->above)	1194	for (top = op; top && top->above; top = top->above)
1153	;	1195	;
1154		1196
1155	for (; top; top = top->below)	1197	for (; top; top = top->below)
1156	{
1157	if (top == op)
1158	continue;
1159
1160	if (object::can_merge (op, top))	1198	if (object::can_merge (op, top))
1161	{	1199	{
1162	top->nrof += op->nrof;	1200	top->nrof += op->nrof;
1163		1201
1164	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1202	if (object *pl = top->visible_to ())
1165	op->weight = 0; /* Don't want any adjustements now */	1203	esrv_update_item (UPD_NROF, pl, top);
		1204
		1205	op->weight = 0; // cancel the addition above
		1206	op->carrying = 0; // must be 0 already
		1207
1166	op->destroy ();	1208	op->destroy ();
		1209
1167	return top;	1210	return top;
1168	}	1211	}
1169	}
1170		1212
1171	return 0;	1213	return 0;
1172	}	1214	}
1173		1215
1174	void	1216	void
…		…
1199	* job preparing multi-part monsters.	1241	* job preparing multi-part monsters.
1200	*/	1242	*/
1201	object *	1243	object *
1202	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1244	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1203	{	1245	{
		1246	op->remove ();
		1247
1204	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1248	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1205	{	1249	{
1206	tmp->x = x + tmp->arch->x;	1250	tmp->x = x + tmp->arch->x;
1207	tmp->y = y + tmp->arch->y;	1251	tmp->y = y + tmp->arch->y;
1208	}	1252	}
…		…
1231	* just 'op' otherwise	1275	* just 'op' otherwise
1232	*/	1276	*/
1233	object *	1277	object *
1234	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1278	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1235	{	1279	{
1236	assert (!op->flag [FLAG_FREED]);
1237
1238	object *top, *floor = NULL;
1239
1240	op->remove ();	1280	op->remove ();
1241		1281
1242	#if 0	1282	if (m == &freed_map)//D TODO: remove soon
1243	if (!m->active != !op->active)
1244	if (m->active)
1245	op->activate_recursive ();
1246	else
1247	op->deactivate_recursive ();
1248	#endif
1249
1250	if (out_of_map (m, op->x, op->y))
1251	{	1283	{//D
1252	LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());	1284	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1253	#ifdef MANY_CORES
1254	/* Better to catch this here, as otherwise the next use of this object
1255	* is likely to cause a crash. Better to find out where it is getting
1256	* improperly inserted.
1257	*/
1258	abort ();
1259	#endif
1260	return op;
1261	}	1285	}//D
1262
1263	if (object *more = op->more)
1264	if (!insert_ob_in_map (more, m, originator, flag))
1265	return 0;
1266
1267	CLEAR_FLAG (op, FLAG_REMOVED);
1268		1286
1269	/* Ideally, the caller figures this out. However, it complicates a lot	1287	/* Ideally, the caller figures this out. However, it complicates a lot
1270	* of areas of callers (eg, anything that uses find_free_spot would now	1288	* of areas of callers (eg, anything that uses find_free_spot would now
1271	* need extra work	1289	* need extra work
1272	*/	1290	*/
		1291	maptile *newmap = m;
1273	if (!xy_normalise (m, op->x, op->y))	1292	if (!xy_normalise (newmap, op->x, op->y))
		1293	{
		1294	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1274	return 0;	1295	return 0;
		1296	}
1275		1297
		1298	if (object *more = op->more)
		1299	if (!insert_ob_in_map (more, m, originator, flag))
		1300	return 0;
		1301
		1302	CLEAR_FLAG (op, FLAG_REMOVED);
		1303
1276	op->map = m;	1304	op->map = newmap;
1277	mapspace &ms = op->ms ();	1305	mapspace &ms = op->ms ();
1278		1306
1279	/* this has to be done after we translate the coordinates.	1307	/* this has to be done after we translate the coordinates.
1280	*/	1308	*/
1281	if (op->nrof && !(flag & INS_NO_MERGE))	1309	if (op->nrof && !(flag & INS_NO_MERGE))
1282	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1310	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1283	if (object::can_merge (op, tmp))	1311	if (object::can_merge (op, tmp))
1284	{	1312	{
		1313	// TODO: we actually want to update tmp, not op,
		1314	// but some caller surely breaks when we return tmp
		1315	// from here :/
1285	op->nrof += tmp->nrof;	1316	op->nrof += tmp->nrof;
1286	tmp->destroy ();	1317	tmp->destroy ();
1287	}	1318	}
1288		1319
1289	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1320	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
…		…
1298	{	1329	{
1299	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1330	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1300	abort ();	1331	abort ();
1301	}	1332	}
1302		1333
		1334	if (!originator->is_on_map ())
		1335	LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1336	op->debug_desc (), originator->debug_desc ());
		1337
1303	op->above = originator;	1338	op->above = originator;
1304	op->below = originator->below;	1339	op->below = originator->below;
1305
1306	if (op->below)
1307	op->below->above = op;
1308	else
1309	ms.bot = op;
1310
1311	/* since *below* originator, no need to update top */
1312	originator->below = op;	1340	originator->below = op;
		1341
		1342	*(op->below ? &op->below->above : &ms.bot) = op;
1313	}	1343	}
1314	else	1344	else
1315	{	1345	{
1316	top = ms.bot;	1346	object *floor = 0;
		1347	object *top = ms.top;
1317		1348
1318	/* If there are other objects, then */	1349	/* If there are other objects, then */
1319	if ((!(flag & INS_MAP_LOAD)) && top)	1350	if (top)
1320	{	1351	{
1321	object *last = 0;
1322
1323	/*	1352	/*
1324	* If there are multiple objects on this space, we do some trickier handling.	1353	* If there are multiple objects on this space, we do some trickier handling.
1325	* We've already dealt with merging if appropriate.	1354	* We've already dealt with merging if appropriate.
1326	* Generally, we want to put the new object on top. But if	1355	* Generally, we want to put the new object on top. But if
1327	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1356	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1330	* once we get to them. This reduces the need to traverse over all of	1359	* once we get to them. This reduces the need to traverse over all of
1331	* them when adding another one - this saves quite a bit of cpu time	1360	* them when adding another one - this saves quite a bit of cpu time
1332	* when lots of spells are cast in one area. Currently, it is presumed	1361	* when lots of spells are cast in one area. Currently, it is presumed
1333	* that flying non pickable objects are spell objects.	1362	* that flying non pickable objects are spell objects.
1334	*/	1363	*/
1335	for (top = ms.bot; top; top = top->above)	1364	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1336	{	1365	{
1337	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1366	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1338	floor = top;	1367	floor = tmp;
1339		1368
1340	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1369	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1341	{	1370	{
1342	/* We insert above top, so we want this object below this */	1371	/* We insert above top, so we want this object below this */
1343	top = top->below;	1372	top = tmp->below;
1344	break;	1373	break;
1345	}	1374	}
1346		1375
1347	last = top;	1376	top = tmp;
1348	}	1377	}
1349
1350	/* Don't want top to be NULL, so set it to the last valid object */
1351	top = last;
1352		1378
1353	/* We let update_position deal with figuring out what the space	1379	/* We let update_position deal with figuring out what the space
1354	* looks like instead of lots of conditions here.	1380	* looks like instead of lots of conditions here.
1355	* makes things faster, and effectively the same result.	1381	* makes things faster, and effectively the same result.
1356	*/	1382	*/
…		…
1363	*/	1389	*/
1364	if (!(flag & INS_ON_TOP)	1390	if (!(flag & INS_ON_TOP)
1365	&& ms.flags () & P_BLOCKSVIEW	1391	&& ms.flags () & P_BLOCKSVIEW
1366	&& (op->face && !faces [op->face].visibility))	1392	&& (op->face && !faces [op->face].visibility))
1367	{	1393	{
		1394	object *last;
		1395
1368	for (last = top; last != floor; last = last->below)	1396	for (last = top; last != floor; last = last->below)
1369	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1397	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1370	break;	1398	break;
1371		1399
1372	/* Check to see if we found the object that blocks view,	1400	/* Check to see if we found the object that blocks view,
…		…
1377	if (last && last->below && last != floor)	1405	if (last && last->below && last != floor)
1378	top = last->below;	1406	top = last->below;
1379	}	1407	}
1380	} /* If objects on this space */	1408	} /* If objects on this space */
1381		1409
1382	if (flag & INS_MAP_LOAD)
1383	top = ms.top;
1384
1385	if (flag & INS_ABOVE_FLOOR_ONLY)	1410	if (flag & INS_ABOVE_FLOOR_ONLY)
1386	top = floor;	1411	top = floor;
1387		1412
1388	/* Top is the object that our object (op) is going to get inserted above.	1413	// insert object above top, or bottom-most if top = 0
1389	*/
1390
1391	/* First object on this space */
1392	if (!top)	1414	if (!top)
1393	{	1415	{
		1416	op->below = 0;
1394	op->above = ms.bot;	1417	op->above = ms.bot;
1395
1396	if (op->above)
1397	op->above->below = op;
1398
1399	op->below = 0;
1400	ms.bot = op;	1418	ms.bot = op;
		1419
		1420	*(op->above ? &op->above->below : &ms.top) = op;
1401	}	1421	}
1402	else	1422	else
1403	{ /* get inserted into the stack above top */	1423	{
1404	op->above = top->above;	1424	op->above = top->above;
1405
1406	if (op->above)
1407	op->above->below = op;	1425	top->above = op;
1408		1426
1409	op->below = top;	1427	op->below = top;
1410	top->above = op;	1428	*(op->above ? &op->above->below : &ms.top) = op;
1411	}	1429	}
		1430	}
1412		1431
1413	if (!op->above)	1432	if (op->is_player ())
1414	ms.top = op;
1415	} /* else not INS_BELOW_ORIGINATOR */
1416
1417	if (op->type == PLAYER)
1418	{	1433	{
1419	op->contr->do_los = 1;	1434	op->contr->do_los = 1;
1420	++op->map->players;	1435	++op->map->players;
1421	op->map->touch ();	1436	op->map->touch ();
1422	}	1437	}
1423		1438
1424	op->map->dirty = true;	1439	op->map->dirty = true;
1425		1440
1426	/* If we have a floor, we know the player, if any, will be above
1427	* it, so save a few ticks and start from there.
1428	*/
1429	if (!(flag & INS_MAP_LOAD))
1430	if (object *pl = ms.player ())	1441	if (object *pl = ms.player ())
		1442	//TODO: the floorbox prev/next might need updating
		1443	//esrv_send_item (pl, op);
		1444	//TODO: update floorbox to preserve ordering
1431	if (pl->contr->ns)	1445	if (pl->contr->ns)
1432	pl->contr->ns->floorbox_update ();	1446	pl->contr->ns->floorbox_update ();
1433		1447
1434	/* If this object glows, it may affect lighting conditions that are	1448	/* If this object glows, it may affect lighting conditions that are
1435	* visible to others on this map. But update_all_los is really	1449	* visible to others on this map. But update_all_los is really
1436	* an inefficient way to do this, as it means los for all players	1450	* an inefficient way to do this, as it means los for all players
1437	* on the map will get recalculated. The players could very well	1451	* on the map will get recalculated. The players could very well
1438	* be far away from this change and not affected in any way -	1452	* be far away from this change and not affected in any way -
1439	* this should get redone to only look for players within range,	1453	* this should get redone to only look for players within range,
1440	* or just updating the P_UPTODATE for spaces within this area	1454	* or just updating the P_UPTODATE for spaces within this area
1441	* of effect may be sufficient.	1455	* of effect may be sufficient.
1442	*/	1456	*/
1443	if (op->map->darkness && (op->glow_radius != 0))	1457	if (op->affects_los ())
		1458	{
		1459	op->ms ().invalidate ();
1444	update_all_los (op->map, op->x, op->y);	1460	update_all_los (op->map, op->x, op->y);
		1461	}
1445		1462
1446	/* updates flags (blocked, alive, no magic, etc) for this map space */	1463	/* updates flags (blocked, alive, no magic, etc) for this map space */
1447	update_object (op, UP_OBJ_INSERT);	1464	update_object (op, UP_OBJ_INSERT);
1448		1465
1449	INVOKE_OBJECT (INSERT, op);	1466	INVOKE_OBJECT (INSERT, op);
…		…
1479	* op is the object to insert it under: supplies x and the map.	1496	* op is the object to insert it under: supplies x and the map.
1480	*/	1497	*/
1481	void	1498	void
1482	replace_insert_ob_in_map (const char *arch_string, object *op)	1499	replace_insert_ob_in_map (const char *arch_string, object *op)
1483	{	1500	{
1484	object *tmp, *tmp1;
1485
1486	/* first search for itself and remove any old instances */	1501	/* first search for itself and remove any old instances */
1487		1502
1488	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)	1503	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1489	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1504	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1490	tmp->destroy ();	1505	tmp->destroy ();
1491		1506
1492	tmp1 = arch_to_object (archetype::find (arch_string));	1507	object *tmp = arch_to_object (archetype::find (arch_string));
1493		1508
1494	tmp1->x = op->x;	1509	tmp->x = op->x;
1495	tmp1->y = op->y;	1510	tmp->y = op->y;
		1511
1496	insert_ob_in_map (tmp1, op->map, op, 0);	1512	insert_ob_in_map (tmp, op->map, op, 0);
1497	}	1513	}
1498		1514
1499	object *	1515	object *
1500	object::insert_at (object *where, object *originator, int flags)	1516	object::insert_at (object *where, object *originator, int flags)
1501	{	1517	{
		1518	if (where->env)
		1519	return where->env->insert (this);
		1520	else
1502	return where->map->insert (this, where->x, where->y, originator, flags);	1521	return where->map->insert (this, where->x, where->y, originator, flags);
1503	}	1522	}
1504		1523
1505	/*	1524	/*
1506	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1507	* is returned contains nr objects, and the remaining parts contains
1508	* the rest (or is removed and freed if that number is 0).
1509	* On failure, NULL is returned, and the reason put into the
1510	* global static errmsg array.
1511	*/
1512	object *
1513	get_split_ob (object *orig_ob, uint32 nr)
1514	{
1515	object *newob;
1516	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1517
1518	if (orig_ob->nrof < nr)
1519	{
1520	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1521	return NULL;
1522	}
1523
1524	newob = object_create_clone (orig_ob);
1525
1526	if ((orig_ob->nrof -= nr) < 1)
1527	orig_ob->destroy (1);
1528	else if (!is_removed)
1529	{
1530	if (orig_ob->env != NULL)
1531	sub_weight (orig_ob->env, orig_ob->weight * nr);
1532	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1533	{
1534	strcpy (errmsg, "Tried to split object whose map is not in memory.");
1535	LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1536	return NULL;
1537	}
1538	}
1539
1540	newob->nrof = nr;
1541
1542	return newob;
1543	}
1544
1545	/*
1546	* decrease_ob_nr(object, number) decreases a specified number from	1525	* decrease(object, number) decreases a specified number from
1547	* the amount of an object. If the amount reaches 0, the object	1526	* the amount of an object. If the amount reaches 0, the object
1548	* is subsequently removed and freed.	1527	* is subsequently removed and freed.
1549	*	1528	*
1550	* Return value: 'op' if something is left, NULL if the amount reached 0	1529	* Return value: 'op' if something is left, NULL if the amount reached 0
1551	*/	1530	*/
		1531	bool
		1532	object::decrease (sint32 nr)
		1533	{
		1534	if (!nr)
		1535	return true;
		1536
		1537	nr = min (nr, nrof);
		1538
		1539	if (nrof > nr)
		1540	{
		1541	nrof -= nr;
		1542	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
		1543
		1544	if (object *pl = visible_to ())
		1545	esrv_update_item (UPD_NROF, pl, this);
		1546
		1547	return true;
		1548	}
		1549	else
		1550	{
		1551	destroy ();
		1552	return false;
		1553	}
		1554	}
		1555
		1556	/*
		1557	* split(ob,nr) splits up ob into two parts. The part which
		1558	* is returned contains nr objects, and the remaining parts contains
		1559	* the rest (or is removed and returned if that number is 0).
		1560	* On failure, NULL is returned.
		1561	*/
1552	object *	1562	object *
1553	decrease_ob_nr (object *op, uint32 i)	1563	object::split (sint32 nr)
1554	{	1564	{
1555	object *tmp;	1565	int have = number_of ();
1556		1566
1557	if (i == 0) /* objects with op->nrof require this check */	1567	if (have < nr)
1558	return op;	1568	return 0;
1559		1569	else if (have == nr)
1560	if (i > op->nrof)
1561	i = op->nrof;
1562
1563	if (QUERY_FLAG (op, FLAG_REMOVED))
1564	op->nrof -= i;
1565	else if (op->env)
1566	{	1570	{
1567	/* is this object in the players inventory, or sub container
1568	* therein?
1569	*/
1570	tmp = op->in_player ();
1571	/* nope. Is this a container the player has opened?
1572	* If so, set tmp to that player.
1573	* IMO, searching through all the players will mostly
1574	* likely be quicker than following op->env to the map,
1575	* and then searching the map for a player.
1576	*/
1577	if (!tmp)
1578	for_all_players (pl)
1579	if (pl->ob->container == op->env)
1580	{
1581	tmp = pl->ob;
1582	break;
1583	}
1584
1585	if (i < op->nrof)
1586	{
1587	sub_weight (op->env, op->weight * i);
1588	op->nrof -= i;
1589	if (tmp)
1590	esrv_send_item (tmp, op);
1591	}
1592	else
1593	{
1594	op->remove ();	1571	remove ();
1595	op->nrof = 0;	1572	return this;
1596	if (tmp)
1597	esrv_del_item (tmp->contr, op->count);
1598	}
1599	}	1573	}
1600	else	1574	else
1601	{	1575	{
1602	object *above = op->above;	1576	decrease (nr);
1603		1577
1604	if (i < op->nrof)	1578	object *op = deep_clone ();
1605	op->nrof -= i;	1579	op->nrof = nr;
1606	else
1607	{
1608	op->remove ();
1609	op->nrof = 0;
1610	}
1611
1612	/* Since we just removed op, op->above is null */
1613	for (tmp = above; tmp; tmp = tmp->above)
1614	if (tmp->type == PLAYER)
1615	{
1616	if (op->nrof)
1617	esrv_send_item (tmp, op);
1618	else
1619	esrv_del_item (tmp->contr, op->count);
1620	}
1621	}
1622
1623	if (op->nrof)
1624	return op;	1580	return op;
1625	else
1626	{
1627	op->destroy ();
1628	return 0;
1629	}
1630	}
1631
1632	/*
1633	* add_weight(object, weight) adds the specified weight to an object,
1634	* and also updates how much the environment(s) is/are carrying.
1635	*/
1636	void
1637	add_weight (object *op, signed long weight)
1638	{
1639	while (op != NULL)
1640	{
1641	if (op->type == CONTAINER)
1642	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1643
1644	op->carrying += weight;
1645	op = op->env;
1646	}	1581	}
1647	}	1582	}
1648		1583
1649	object *	1584	object *
1650	insert_ob_in_ob (object *op, object *where)	1585	insert_ob_in_ob (object *op, object *where)
…		…
1675	* be != op, if items are merged. -Tero	1610	* be != op, if items are merged. -Tero
1676	*/	1611	*/
1677	object *	1612	object *
1678	object::insert (object *op)	1613	object::insert (object *op)
1679	{	1614	{
1680	object *tmp, *otmp;
1681
1682	if (!QUERY_FLAG (op, FLAG_REMOVED))
1683	op->remove ();
1684
1685	if (op->more)	1615	if (op->more)
1686	{	1616	{
1687	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1617	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1688	return op;	1618	return op;
1689	}	1619	}
1690		1620
1691	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1621	op->remove ();
1692	CLEAR_FLAG (op, FLAG_REMOVED);	1622
		1623	op->flag [FLAG_OBJ_ORIGINAL] = 0;
		1624
1693	if (op->nrof)	1625	if (op->nrof)
1694	{
1695	for (tmp = inv; tmp != NULL; tmp = tmp->below)	1626	for (object *tmp = inv; tmp; tmp = tmp->below)
1696	if (object::can_merge (tmp, op))	1627	if (object::can_merge (tmp, op))
1697	{	1628	{
1698	/* return the original object and remove inserted object	1629	/* return the original object and remove inserted object
1699	(client needs the original object) */	1630	(client needs the original object) */
1700	tmp->nrof += op->nrof;	1631	tmp->nrof += op->nrof;
1701	/* Weight handling gets pretty funky. Since we are adding to	1632
1702	* tmp->nrof, we need to increase the weight.	1633	if (object *pl = tmp->visible_to ())
1703	*/	1634	esrv_update_item (UPD_NROF, pl, tmp);
		1635
1704	add_weight (this, op->weight * op->nrof);	1636	adjust_weight (this, op->total_weight ());
1705	SET_FLAG (op, FLAG_REMOVED);	1637
1706	op->destroy (); /* free the inserted object */	1638	op->destroy ();
1707	op = tmp;	1639	op = tmp;
1708	op->remove (); /* and fix old object's links */	1640	goto inserted;
1709	CLEAR_FLAG (op, FLAG_REMOVED);
1710	break;
1711	}	1641	}
1712		1642
1713	/* I assume combined objects have no inventory	1643	op->owner = 0; // it's his/hers now. period.
1714	* We add the weight - this object could have just been removed
1715	* (if it was possible to merge). calling remove_ob will subtract
1716	* the weight, so we need to add it in again, since we actually do
1717	* the linking below
1718	*/
1719	add_weight (this, op->weight * op->nrof);
1720	}
1721	else
1722	add_weight (this, (op->weight + op->carrying));
1723
1724	otmp = this->in_player ();
1725	if (otmp && otmp->contr)
1726	if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1727	otmp->update_stats ();
1728
1729	op->map = 0;	1644	op->map = 0;
1730	op->env = this;	1645	op->x = 0;
		1646	op->y = 0;
		1647
1731	op->above = 0;	1648	op->above = 0;
1732	op->below = 0;	1649	op->below = inv;
1733	op->x = 0, op->y = 0;	1650	op->env = this;
1734		1651
		1652	if (inv)
		1653	inv->above = op;
		1654
		1655	inv = op;
		1656
		1657	op->flag [FLAG_REMOVED] = 0;
		1658
		1659	if (object *pl = op->visible_to ())
		1660	esrv_send_item (pl, op);
		1661
		1662	adjust_weight (this, op->total_weight ());
		1663
		1664	inserted:
1735	/* reset the light list and los of the players on the map */	1665	/* reset the light list and los of the players on the map */
1736	if ((op->glow_radius != 0) && map)	1666	if (op->glow_radius && is_on_map ())
1737	{	1667	{
1738	#ifdef DEBUG_LIGHTS	1668	update_stats ();
1739	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1740	#endif /* DEBUG_LIGHTS */
1741	if (map->darkness)
1742	update_all_los (map, x, y);	1669	update_all_los (map, x, y);
1743	}
1744
1745	/* Client has no idea of ordering so lets not bother ordering it here.
1746	* It sure simplifies this function...
1747	*/
1748	if (!inv)
1749	inv = op;
1750	else
1751	{	1670	}
1752	op->below = inv;	1671	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1753	op->below->above = op;	1672	// if this is a player's inventory, update stats
1754	inv = op;	1673	update_stats ();
1755	}
1756		1674
1757	INVOKE_OBJECT (INSERT, this);	1675	INVOKE_OBJECT (INSERT, this);
1758		1676
1759	return op;	1677	return op;
1760	}	1678	}
…		…
1843	{	1761	{
1844		1762
1845	float	1763	float
1846	diff = tmp->move_slow_penalty * fabs (op->speed);	1764	diff = tmp->move_slow_penalty * fabs (op->speed);
1847		1765
1848	if (op->type == PLAYER)	1766	if (op->is_player ())
1849	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1767	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1850	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1768	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1851	diff /= 4.0;	1769	diff /= 4.0;
1852		1770
1853	op->speed_left -= diff;	1771	op->speed_left -= diff;
…		…
1888	LOG (llevError, "Present_arch called outside map.\n");	1806	LOG (llevError, "Present_arch called outside map.\n");
1889	return NULL;	1807	return NULL;
1890	}	1808	}
1891		1809
1892	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1810	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1893	if (tmp->arch == at)	1811	if (tmp->arch->archname == at->archname)
1894	return tmp;	1812	return tmp;
1895		1813
1896	return NULL;	1814	return NULL;
1897	}	1815	}
1898		1816
…		…
1962	* The first matching object is returned, or NULL if none.	1880	* The first matching object is returned, or NULL if none.
1963	*/	1881	*/
1964	object *	1882	object *
1965	present_arch_in_ob (const archetype *at, const object *op)	1883	present_arch_in_ob (const archetype *at, const object *op)
1966	{	1884	{
1967	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1885	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1968	if (tmp->arch == at)	1886	if (tmp->arch->archname == at->archname)
1969	return tmp;	1887	return tmp;
1970		1888
1971	return NULL;	1889	return NULL;
1972	}	1890	}
1973		1891
…		…
1975	* activate recursively a flag on an object inventory	1893	* activate recursively a flag on an object inventory
1976	*/	1894	*/
1977	void	1895	void
1978	flag_inv (object *op, int flag)	1896	flag_inv (object *op, int flag)
1979	{	1897	{
1980	if (op->inv)
1981	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1898	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1982	{	1899	{
1983	SET_FLAG (tmp, flag);	1900	SET_FLAG (tmp, flag);
1984	flag_inv (tmp, flag);	1901	flag_inv (tmp, flag);
1985	}	1902	}
1986	}	1903	}
1987		1904
1988	/*	1905	/*
1989	* deactivate recursively a flag on an object inventory	1906	* deactivate recursively a flag on an object inventory
1990	*/	1907	*/
1991	void	1908	void
1992	unflag_inv (object *op, int flag)	1909	unflag_inv (object *op, int flag)
1993	{	1910	{
1994	if (op->inv)
1995	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1911	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1996	{	1912	{
1997	CLEAR_FLAG (tmp, flag);	1913	CLEAR_FLAG (tmp, flag);
1998	unflag_inv (tmp, flag);	1914	unflag_inv (tmp, flag);
1999	}	1915	}
2000	}	1916	}
2001		1917
2002	/*	1918	/*
2003	* find_free_spot(object, map, x, y, start, stop) will search for	1919	* find_free_spot(object, map, x, y, start, stop) will search for
2004	* a spot at the given map and coordinates which will be able to contain	1920	* a spot at the given map and coordinates which will be able to contain
…		…
2006	* to search (see the freearr_x/y[] definition).	1922	* to search (see the freearr_x/y[] definition).
2007	* It returns a random choice among the alternatives found.	1923	* It returns a random choice among the alternatives found.
2008	* start and stop are where to start relative to the free_arr array (1,9	1924	* start and stop are where to start relative to the free_arr array (1,9
2009	* does all 4 immediate directions). This returns the index into the	1925	* does all 4 immediate directions). This returns the index into the
2010	* array of the free spot, -1 if no spot available (dir 0 = x,y)	1926	* array of the free spot, -1 if no spot available (dir 0 = x,y)
2011	* Note - this only checks to see if there is space for the head of the
2012	* object - if it is a multispace object, this should be called for all
2013	* pieces.
2014	* Note2: This function does correctly handle tiled maps, but does not	1927	* Note: This function does correctly handle tiled maps, but does not
2015	* inform the caller. However, insert_ob_in_map will update as	1928	* inform the caller. However, insert_ob_in_map will update as
2016	* necessary, so the caller shouldn't need to do any special work.	1929	* necessary, so the caller shouldn't need to do any special work.
2017	* Note - updated to take an object instead of archetype - this is necessary	1930	* Note - updated to take an object instead of archetype - this is necessary
2018	* because arch_blocked (now ob_blocked) needs to know the movement type	1931	* because arch_blocked (now ob_blocked) needs to know the movement type
2019	* to know if the space in question will block the object. We can't use	1932	* to know if the space in question will block the object. We can't use
…		…
2021	* customized, changed states, etc.	1934	* customized, changed states, etc.
2022	*/	1935	*/
2023	int	1936	int
2024	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)	1937	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2025	{	1938	{
		1939	int altern[SIZEOFFREE];
2026	int index = 0, flag;	1940	int index = 0, flag;
2027	int altern[SIZEOFFREE];
2028		1941
2029	for (int i = start; i < stop; i++)	1942	for (int i = start; i < stop; i++)
2030	{	1943	{
2031	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);	1944	mapxy pos (m, x, y); pos.move (i);
2032	if (!flag)	1945
		1946	if (!pos.normalise ())
		1947	continue;
		1948
		1949	mapspace &ms = *pos;
		1950
		1951	if (ms.flags () & P_IS_ALIVE)
		1952	continue;
		1953
		1954	/* However, often
		1955	* ob doesn't have any move type (when used to place exits)
		1956	* so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work.
		1957	*/
		1958	if (ob && ob->move_type == 0 && ms.move_block != MOVE_ALL)
		1959	{
2033	altern [index++] = i;	1960	altern [index++] = i;
		1961	continue;
		1962	}
2034		1963
2035	/* Basically, if we find a wall on a space, we cut down the search size.	1964	/* Basically, if we find a wall on a space, we cut down the search size.
2036	* In this way, we won't return spaces that are on another side of a wall.	1965	* In this way, we won't return spaces that are on another side of a wall.
2037	* This mostly work, but it cuts down the search size in all directions -	1966	* This mostly work, but it cuts down the search size in all directions -
2038	* if the space being examined only has a wall to the north and empty	1967	* if the space being examined only has a wall to the north and empty
2039	* spaces in all the other directions, this will reduce the search space	1968	* spaces in all the other directions, this will reduce the search space
2040	* to only the spaces immediately surrounding the target area, and	1969	* to only the spaces immediately surrounding the target area, and
2041	* won't look 2 spaces south of the target space.	1970	* won't look 2 spaces south of the target space.
2042	*/	1971	*/
2043	else if ((flag & P_NO_PASS) && maxfree[i] < stop)	1972	if (ms.move_block == MOVE_ALL && maxfree[i] < stop)
		1973	{
2044	stop = maxfree[i];	1974	stop = maxfree[i];
		1975	continue;
		1976	}
		1977
		1978	/* Note it is intentional that we check ob - the movement type of the
		1979	* head of the object should correspond for the entire object.
		1980	*/
		1981	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
		1982	continue;
		1983
		1984	if (ob->blocked (pos.m, pos.x, pos.y))
		1985	continue;
		1986
		1987	altern [index++] = i;
2045	}	1988	}
2046		1989
2047	if (!index)	1990	if (!index)
2048	return -1;	1991	return -1;
2049		1992
…		…
2058	*/	2001	*/
2059	int	2002	int
2060	find_first_free_spot (const object *ob, maptile *m, int x, int y)	2003	find_first_free_spot (const object *ob, maptile *m, int x, int y)
2061	{	2004	{
2062	for (int i = 0; i < SIZEOFFREE; i++)	2005	for (int i = 0; i < SIZEOFFREE; i++)
2063	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))	2006	if (!ob->blocked (m, x + freearr_x[i], y + freearr_y[i]))
2064	return i;	2007	return i;
2065		2008
2066	return -1;	2009	return -1;
2067	}	2010	}
2068		2011
…		…
2154	if ((move_type & blocked) == move_type)	2097	if ((move_type & blocked) == move_type)
2155	max = maxfree[i];	2098	max = maxfree[i];
2156	else if (mflags & P_IS_ALIVE)	2099	else if (mflags & P_IS_ALIVE)
2157	{	2100	{
2158	for (tmp = ms.bot; tmp; tmp = tmp->above)	2101	for (tmp = ms.bot; tmp; tmp = tmp->above)
2159	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2102	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2160	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2103	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2161	break;	2104	break;
2162		2105
2163	if (tmp)	2106	if (tmp)
2164	return freedir[i];	2107	return freedir[i];
…		…
2345	* Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause	2288	* Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause
2346	* core dumps if they do.	2289	* core dumps if they do.
2347	*	2290	*
2348	* Add a check so we can't pick up invisible objects (0.93.8)	2291	* Add a check so we can't pick up invisible objects (0.93.8)
2349	*/	2292	*/
2350
2351	int	2293	int
2352	can_pick (const object *who, const object *item)	2294	can_pick (const object *who, const object *item)
2353	{	2295	{
2354	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2296	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2355	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2297	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2356	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2298	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2357	}	2299	}
2358		2300
2359	/*	2301	/*
2360	* create clone from object to another	2302	* create clone from object to another
2361	*/	2303	*/
2362	object *	2304	object *
2363	object_create_clone (object *asrc)	2305	object::deep_clone ()
2364	{	2306	{
2365	object *dst = 0, *tmp, *src, *prev, *item;	2307	assert (("deep_clone called on non-head object", is_head ()));
2366		2308
2367	if (!asrc)	2309	object *dst = clone ();
2368	return 0;
2369		2310
2370	src = asrc->head_ ();	2311	object *prev = dst;
2371
2372	prev = 0;
2373	for (object *part = src; part; part = part->more)	2312	for (object *part = this->more; part; part = part->more)
2374	{	2313	{
2375	tmp = part->clone ();	2314	object *tmp = part->clone ();
2376	tmp->x -= src->x;
2377	tmp->y -= src->y;
2378
2379	if (!part->head)
2380	{
2381	dst = tmp;
2382	tmp->head = 0;
2383	}
2384	else
2385	tmp->head = dst;	2315	tmp->head = dst;
2386
2387	tmp->more = 0;
2388
2389	if (prev)
2390	prev->more = tmp;	2316	prev->more = tmp;
2391
2392	prev = tmp;	2317	prev = tmp;
2393	}	2318	}
2394		2319
2395	for (item = src->inv; item; item = item->below)	2320	for (object *item = inv; item; item = item->below)
2396	insert_ob_in_ob (object_create_clone (item), dst);	2321	insert_ob_in_ob (item->deep_clone (), dst);
2397		2322
2398	return dst;	2323	return dst;
2399	}	2324	}
2400		2325
2401	/* This returns the first object in who's inventory that	2326	/* This returns the first object in who's inventory that
…		…
2410	return tmp;	2335	return tmp;
2411		2336
2412	return 0;	2337	return 0;
2413	}	2338	}
2414		2339
2415	/* If ob has a field named key, return the link from the list,	2340	const shstr &
2416	* otherwise return NULL.	2341	object::kv_get (const shstr &key) const
2417	*
2418	* key must be a passed in shared string - otherwise, this won't
2419	* do the desired thing.
2420	*/
2421	key_value *
2422	get_ob_key_link (const object *ob, const char *key)
2423	{	2342	{
2424	for (key_value *link = ob->key_values; link; link = link->next)	2343	for (key_value *kv = key_values; kv; kv = kv->next)
2425	if (link->key == key)	2344	if (kv->key == key)
2426	return link;
2427
2428	return 0;
2429	}
2430
2431	/*
2432	* Returns the value of op has an extra_field for key, or NULL.
2433	*
2434	* The argument doesn't need to be a shared string.
2435	*
2436	* The returned string is shared.
2437	*/
2438	const char *
2439	get_ob_key_value (const object *op, const char *const key)
2440	{
2441	key_value *link;
2442	shstr_cmp canonical_key (key);
2443
2444	if (!canonical_key)
2445	{
2446	/* 1. There being a field named key on any object
2447	* implies there'd be a shared string to find.
2448	* 2. Since there isn't, no object has this field.
2449	* 3. Therefore, *this* object doesn't have this field.
2450	*/
2451	return 0;
2452	}
2453
2454	/* This is copied from get_ob_key_link() above -
2455	* only 4 lines, and saves the function call overhead.
2456	*/
2457	for (link = op->key_values; link; link = link->next)
2458	if (link->key == canonical_key)
2459	return link->value;	2345	return kv->value;
2460		2346
2461	return 0;	2347	return shstr_null;
2462	}	2348	}
2463		2349
2464	/*	2350	void
2465	* Updates the canonical_key in op to value.	2351	object::kv_set (const shstr &key, const shstr &value)
2466	*
2467	* canonical_key is a shared string (value doesn't have to be).
2468	*
2469	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2470	* keys.
2471	*
2472	* Returns TRUE on success.
2473	*/
2474	int
2475	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2476	{	2352	{
2477	key_value *field = NULL, *last = NULL;	2353	for (key_value *kv = key_values; kv; kv = kv->next)
2478		2354	if (kv->key == key)
2479	for (field = op->key_values; field != NULL; field = field->next)
2480	{
2481	if (field->key != canonical_key)
2482	{	2355	{
2483	last = field;	2356	kv->value = value;
2484	continue;	2357	return;
2485	}	2358	}
2486		2359
2487	if (value)	2360	key_value *kv = new key_value;
2488	field->value = value;	2361
2489	else	2362	kv->next = key_values;
		2363	kv->key = key;
		2364	kv->value = value;
		2365
		2366	key_values = kv;
		2367	}
		2368
		2369	void
		2370	object::kv_del (const shstr &key)
		2371	{
		2372	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2373	if ((*kvp)->key == key)
2490	{	2374	{
2491	/* Basically, if the archetype has this key set,	2375	key_value *kv = *kvp;
2492	* we need to store the null value so when we save	2376	*kvp = (*kvp)->next;
2493	* it, we save the empty value so that when we load,	2377	delete kv;
2494	* we get this value back again.	2378	return;
2495	*/
2496	if (get_ob_key_link (op->arch, canonical_key))
2497	field->value = 0;
2498	else
2499	{
2500	if (last)
2501	last->next = field->next;
2502	else
2503	op->key_values = field->next;
2504
2505	delete field;
2506	}
2507	}	2379	}
2508	return TRUE;
2509	}
2510	/* IF we get here, key doesn't exist */
2511
2512	/* No field, we'll have to add it. */
2513
2514	if (!add_key)
2515	return FALSE;
2516
2517	/* There isn't any good reason to store a null
2518	* value in the key/value list. If the archetype has
2519	* this key, then we should also have it, so shouldn't
2520	* be here. If user wants to store empty strings,
2521	* should pass in ""
2522	*/
2523	if (value == NULL)
2524	return TRUE;
2525
2526	field = new key_value;
2527
2528	field->key = canonical_key;
2529	field->value = value;
2530	/* Usual prepend-addition. */
2531	field->next = op->key_values;
2532	op->key_values = field;
2533
2534	return TRUE;
2535	}
2536
2537	/*
2538	* Updates the key in op to value.
2539	*
2540	* If add_key is FALSE, this will only update existing keys,
2541	* and not add new ones.
2542	* In general, should be little reason FALSE is ever passed in for add_key
2543	*
2544	* Returns TRUE on success.
2545	*/
2546	int
2547	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2548	{
2549	shstr key_ (key);
2550
2551	return set_ob_key_value_s (op, key_, value, add_key);
2552	}	2380	}
2553		2381
2554	object::depth_iterator::depth_iterator (object *container)	2382	object::depth_iterator::depth_iterator (object *container)
2555	: iterator_base (container)	2383	: iterator_base (container)
2556	{	2384	{
…		…
2606	{	2434	{
2607	char flagdesc[512];	2435	char flagdesc[512];
2608	char info2[256 * 4];	2436	char info2[256 * 4];
2609	char *p = info;	2437	char *p = info;
2610		2438
2611	p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",	2439	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2612	count, uuid.seq,	2440	count,
		2441	uuid.c_str (),
2613	&name,	2442	&name,
2614	title ? "\",title:\"" : "",	2443	title ? ",title:\"" : "",
2615	title ? (const char *)title : "",	2444	title ? (const char *)title : "",
		2445	title ? "\"" : "",
2616	flag_desc (flagdesc, 512), type);	2446	flag_desc (flagdesc, 512), type);
2617		2447
2618	if (env)	2448	if (!flag[FLAG_REMOVED] && env)
2619	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2449	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2620		2450
2621	if (map)	2451	if (map)
2622	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2452	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2623		2453
…		…
2641	}	2471	}
2642		2472
2643	const materialtype_t *	2473	const materialtype_t *
2644	object::dominant_material () const	2474	object::dominant_material () const
2645	{	2475	{
2646	if (materialtype_t *mat = name_to_material (materialname))	2476	if (materialtype_t *mt = name_to_material (materialname))
2647	return mat;	2477	return mt;
2648		2478
2649	// omfg this is slow, this has to be temporary :)
2650	shstr unknown ("unknown");
2651
2652	return name_to_material (unknown);	2479	return name_to_material (shstr_unknown);
2653	}	2480	}
2654		2481
2655	void	2482	void
2656	object::open_container (object *new_container)	2483	object::open_container (object *new_container)
2657	{	2484	{
2658	if (container == new_container)	2485	if (container == new_container)
2659	return;	2486	return;
2660		2487
2661	if (object *old_container = container)	2488	object *old_container = container;
		2489
		2490	if (old_container)
2662	{	2491	{
2663	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2492	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2664	return;	2493	return;
2665		2494
2666	#if 0	2495	#if 0
…		…
2668	if (object *closer = old_container->inv)	2497	if (object *closer = old_container->inv)
2669	if (closer->type == CLOSE_CON)	2498	if (closer->type == CLOSE_CON)
2670	closer->destroy ();	2499	closer->destroy ();
2671	#endif	2500	#endif
2672		2501
		2502	// make sure the container is available
		2503	esrv_send_item (this, old_container);
		2504
2673	old_container->flag [FLAG_APPLIED] = 0;	2505	old_container->flag [FLAG_APPLIED] = false;
2674	container = 0;	2506	container = 0;
2675		2507
		2508	// client needs item update to make it work, client bug requires this to be separate
2676	esrv_update_item (UPD_FLAGS, this, old_container);	2509	esrv_update_item (UPD_FLAGS, this, old_container);
		2510
2677	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2511	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
		2512	play_sound (sound_find ("chest_close"));
2678	}	2513	}
2679		2514
2680	if (new_container)	2515	if (new_container)
2681	{	2516	{
2682	if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))	2517	if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
…		…
2693	}	2528	}
2694	#endif	2529	#endif
2695		2530
2696	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2531	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2697		2532
		2533	// make sure the container is available, client bug requires this to be separate
		2534	esrv_send_item (this, new_container);
		2535
2698	new_container->flag [FLAG_APPLIED] = 1;	2536	new_container->flag [FLAG_APPLIED] = true;
2699	container = new_container;	2537	container = new_container;
2700		2538
		2539	// client needs flag change
2701	esrv_update_item (UPD_FLAGS, this, new_container);	2540	esrv_update_item (UPD_FLAGS, this, new_container);
2702	esrv_send_inventory (this, new_container);	2541	esrv_send_inventory (this, new_container);
		2542	play_sound (sound_find ("chest_open"));
		2543	}
		2544	// else if (!old_container->env && contr && contr->ns)
		2545	// contr->ns->floorbox_reset ();
		2546	}
		2547
		2548	object *
		2549	object::force_find (const shstr name)
		2550	{
		2551	/* cycle through his inventory to look for the MARK we want to
		2552	* place
		2553	*/
		2554	for (object *tmp = inv; tmp; tmp = tmp->below)
		2555	if (tmp->type == FORCE && tmp->slaying == name)
		2556	return splay (tmp);
		2557
		2558	return 0;
		2559	}
		2560
		2561	object *
		2562	object::force_add (const shstr name, int duration)
		2563	{
		2564	if (object *force = force_find (name))
		2565	force->destroy ();
		2566
		2567	object *force = get_archetype (FORCE_NAME);
		2568
		2569	force->slaying = name;
		2570	force->stats.food = 1;
		2571	force->speed_left = -1.f;
		2572
		2573	force->set_speed (duration ? 1.f / duration : 0.f);
		2574	force->flag [FLAG_IS_USED_UP] = true;
		2575	force->flag [FLAG_APPLIED] = true;
		2576
		2577	return insert (force);
		2578	}
		2579
		2580	void
		2581	object::play_sound (faceidx sound)
		2582	{
		2583	if (!sound)
		2584	return;
		2585
		2586	if (flag [FLAG_REMOVED])
		2587	return;
		2588
		2589	if (env)
2703	}	2590	{
		2591	if (object *pl = in_player ())
		2592	pl->contr->play_sound (sound);
		2593	}
		2594	else
		2595	map->play_sound (sound, x, y);
2704	}	2596	}
2705		2597
		2598	void
		2599	object::make_noise ()
		2600	{
		2601	// we do not model noise in the map, so instead put
		2602	// a temporary light into the noise source
		2603	// could use the map instead, but that's less reliable for our
		2604	// goal, which is to make invisibility a bit harder to exploit
2706		2605
		2606	// currently only works sensibly for players
		2607	if (!is_player ())
		2608	return;
		2609
		2610	// find old force, or create new one
		2611	object *force = force_find (shstr_noise_force);
		2612
		2613	if (force)
		2614	force->speed_left = -1.f; // patch old speed up
		2615	else
		2616	{
		2617	force = archetype::get (shstr_noise_force);
		2618
		2619	force->slaying = shstr_noise_force;
		2620	force->stats.food = 1;
		2621	force->speed_left = -1.f;
		2622
		2623	force->set_speed (1.f / 4.f);
		2624	force->flag [FLAG_IS_USED_UP] = true;
		2625	force->flag [FLAG_APPLIED] = true;
		2626
		2627	insert (force);
		2628	}
		2629	}
		2630

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines