ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.238 by root, Wed May 7 11:02:50 2008 UTC vs.
Revision 1.276 by root, Wed Dec 31 18:07:41 2008 UTC

32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
40 41
41short freearr_x[SIZEOFFREE] = { 42short freearr_x[SIZEOFFREE] = {
186 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 188 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
189 return 0; 190 return 0;
190 191
191 /* Do not merge objects if nrof would overflow. First part checks 192 /* Do not merge objects if nrof would overflow, assume nrof
192 * for unsigned overflow (2c), second part checks whether the result 193 * is always 0 .. 2**31-1 */
193 * would fit into a 32 bit signed int, which is often used to hold 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
194 * nrof values.
195 */
196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
197 return 0; 195 return 0;
198 196
199 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
200 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
201 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
206 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
207 205
208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
209 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
210 208
211 if (ob1->arch->name != ob2->arch->name 209 if (ob1->arch->archname != ob2->arch->archname
212 || ob1->name != ob2->name 210 || ob1->name != ob2->name
213 || ob1->title != ob2->title 211 || ob1->title != ob2->title
214 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
215 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
216 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
217 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
218 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
219 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
220 || ob1->value != ob2->value 218 || ob1->value != ob2->value
221 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
222 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
223 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
224 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
225 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
226 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
235 return 0; 234 return 0;
236 235
237 if ((ob1->flag ^ ob2->flag) 236 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED) 237 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED) 238 .reset (FLAG_REMOVED)
241 .any ()) 239 .any ())
242 return 0; 240 return 0;
243 241
244 /* This is really a spellbook check - we should in general 242 /* This is really a spellbook check - we should in general
326 { 324 {
327 // see if we are in a container of sorts 325 // see if we are in a container of sorts
328 if (env) 326 if (env)
329 { 327 {
330 // the player inventory itself is always visible 328 // the player inventory itself is always visible
331 if (env->type == PLAYER) 329 if (env->is_player ())
332 return env; 330 return env;
333 331
334 // else a player could have our env open 332 // else a player could have our env open
335 object *envest = env->outer_env (); 333 object *envest = env->outer_env ();
336 334
344 else 342 else
345 { 343 {
346 // maybe there is a player standing on the same mapspace 344 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player 345 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ()) 346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
349 if (!pl->container || this == pl->container) 348 || this == pl->container)
350 return pl; 349 return pl;
351 } 350 }
352 } 351 }
353 352
354 return 0; 353 return 0;
478 */ 477 */
479object * 478object *
480find_object_name (const char *str) 479find_object_name (const char *str)
481{ 480{
482 shstr_cmp str_ (str); 481 shstr_cmp str_ (str);
483 object *op;
484 482
483 if (str_)
485 for_all_objects (op) 484 for_all_objects (op)
486 if (op->name == str_) 485 if (op->name == str_)
487 break; 486 return op;
488 487
489 return op; 488 return 0;
490} 489}
491 490
492/* 491/*
493 * Sets the owner and sets the skill and exp pointers to owner's current 492 * Sets the owner and sets the skill and exp pointers to owner's current
494 * skill and experience objects. 493 * skill and experience objects.
638 } 637 }
639 638
640 if (speed < 0) 639 if (speed < 0)
641 dst->speed_left -= rndm (); 640 dst->speed_left -= rndm ();
642 641
643 dst->set_speed (dst->speed); 642 dst->activate ();
644} 643}
645 644
646void 645void
647object::instantiate () 646object::instantiate ()
648{ 647{
760 else if (action == UP_OBJ_INSERT) 759 else if (action == UP_OBJ_INSERT)
761 { 760 {
762 // this is likely overkill, TODO: revisit (schmorp) 761 // this is likely overkill, TODO: revisit (schmorp)
763 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 762 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
764 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 763 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
765 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 764 || (op->is_player () && !(m.flags_ & P_PLAYER))
766 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 765 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
767 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 766 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
768 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 767 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
769 || (m.move_on | op->move_on ) != m.move_on 768 || (m.move_on | op->move_on ) != m.move_on
770 || (m.move_off | op->move_off ) != m.move_off 769 || (m.move_off | op->move_off ) != m.move_off
771 || (m.move_slow | op->move_slow) != m.move_slow 770 || (m.move_slow | op->move_slow) != m.move_slow
772 /* This isn't perfect, but I don't expect a lot of objects to 771 /* This isn't perfect, but I don't expect a lot of objects to
773 * to have move_allow right now. 772 * have move_allow right now.
774 */ 773 */
775 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 774 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
776 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 775 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
777 m.flags_ = 0; 776 m.invalidate ();
778 } 777 }
779 /* if the object is being removed, we can't make intelligent 778 /* if the object is being removed, we can't make intelligent
780 * decisions, because remove_ob can't really pass the object 779 * decisions, because remove_ob can't really pass the object
781 * that is being removed. 780 * that is being removed.
782 */ 781 */
783 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 782 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
784 m.flags_ = 0; 783 m.invalidate ();
785 else if (action == UP_OBJ_FACE) 784 else if (action == UP_OBJ_FACE)
786 /* Nothing to do for that case */ ; 785 /* Nothing to do for that case */ ;
787 else 786 else
788 LOG (llevError, "update_object called with invalid action: %d\n", action); 787 LOG (llevError, "update_object called with invalid action: %d\n", action);
789 788
831object::activate () 830object::activate ()
832{ 831{
833 /* If already on active list, don't do anything */ 832 /* If already on active list, don't do anything */
834 if (active) 833 if (active)
835 return; 834 return;
835
836 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
837 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
836 838
837 if (has_active_speed ()) 839 if (has_active_speed ())
838 actives.insert (this); 840 actives.insert (this);
839} 841}
840 842
908 || map->in_memory != MAP_ACTIVE 910 || map->in_memory != MAP_ACTIVE
909 || map->no_drop 911 || map->no_drop
910 || ms ().move_block == MOVE_ALL) 912 || ms ().move_block == MOVE_ALL)
911 { 913 {
912 while (inv) 914 while (inv)
913 {
914 inv->destroy_inv (false);
915 inv->destroy (); 915 inv->destroy ();
916 }
917 } 916 }
918 else 917 else
919 { /* Put objects in inventory onto this space */ 918 { /* Put objects in inventory onto this space */
920 while (inv) 919 while (inv)
921 { 920 {
925 || op->flag [FLAG_NO_DROP] 924 || op->flag [FLAG_NO_DROP]
926 || op->type == RUNE 925 || op->type == RUNE
927 || op->type == TRAP 926 || op->type == TRAP
928 || op->flag [FLAG_IS_A_TEMPLATE] 927 || op->flag [FLAG_IS_A_TEMPLATE]
929 || op->flag [FLAG_DESTROY_ON_DEATH]) 928 || op->flag [FLAG_DESTROY_ON_DEATH])
930 op->destroy (true); 929 op->destroy ();
931 else 930 else
932 map->insert (op, x, y); 931 map->insert (op, x, y);
933 } 932 }
934 } 933 }
935} 934}
999 attacked_by = 0; 998 attacked_by = 0;
1000 current_weapon = 0; 999 current_weapon = 0;
1001} 1000}
1002 1001
1003void 1002void
1004object::destroy (bool destroy_inventory) 1003object::destroy ()
1005{ 1004{
1006 if (destroyed ()) 1005 if (destroyed ())
1007 return; 1006 return;
1008 1007
1009 if (!is_head () && !head->destroyed ()) 1008 if (!is_head () && !head->destroyed ())
1010 { 1009 {
1011 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1010 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1012 head->destroy (destroy_inventory); 1011 head->destroy ();
1013 return; 1012 return;
1014 } 1013 }
1015 1014
1016 destroy_inv (!destroy_inventory); 1015 destroy_inv (false);
1017 1016
1018 if (is_head ()) 1017 if (is_head ())
1019 if (sound_destroy) 1018 if (sound_destroy)
1020 play_sound (sound_destroy); 1019 play_sound (sound_destroy);
1021 else if (flag [FLAG_MONSTER]) 1020 else if (flag [FLAG_MONSTER])
1057 if (object *pl = visible_to ()) 1056 if (object *pl = visible_to ())
1058 esrv_del_item (pl->contr, count); 1057 esrv_del_item (pl->contr, count);
1059 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1058 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1060 1059
1061 adjust_weight (env, -total_weight ()); 1060 adjust_weight (env, -total_weight ());
1061
1062 object *pl = in_player ();
1062 1063
1063 /* we set up values so that it could be inserted into 1064 /* we set up values so that it could be inserted into
1064 * the map, but we don't actually do that - it is up 1065 * the map, but we don't actually do that - it is up
1065 * to the caller to decide what we want to do. 1066 * to the caller to decide what we want to do.
1066 */ 1067 */
1078 1079
1079 /* NO_FIX_PLAYER is set when a great many changes are being 1080 /* NO_FIX_PLAYER is set when a great many changes are being
1080 * made to players inventory. If set, avoiding the call 1081 * made to players inventory. If set, avoiding the call
1081 * to save cpu time. 1082 * to save cpu time.
1082 */ 1083 */
1083 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1084 if (pl)
1085 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1086 {
1084 otmp->update_stats (); 1087 pl->update_stats ();
1088
1089 if (glow_radius && pl->is_on_map ())
1090 update_all_los (pl->map, pl->x, pl->y);
1091 }
1085 } 1092 }
1086 else if (map) 1093 else if (map)
1087 { 1094 {
1088 map->dirty = true; 1095 map->dirty = true;
1089 mapspace &ms = this->ms (); 1096 mapspace &ms = this->ms ();
1090 1097
1091 if (object *pl = ms.player ()) 1098 if (object *pl = ms.player ())
1092 { 1099 {
1093 if (type == PLAYER) // this == pl(!) 1100 if (is_player ())
1094 { 1101 {
1102 if (!flag [FLAG_WIZPASS])
1103 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1104
1095 // leaving a spot always closes any open container on the ground 1105 // leaving a spot always closes any open container on the ground
1096 if (container && !container->env) 1106 if (container && !container->env)
1097 // this causes spurious floorbox updates, but it ensures 1107 // this causes spurious floorbox updates, but it ensures
1098 // that the CLOSE event is being sent. 1108 // that the CLOSE event is being sent.
1099 close_container (); 1109 close_container ();
1116 *(below ? &below->above : &ms.bot) = above; 1126 *(below ? &below->above : &ms.bot) = above;
1117 1127
1118 above = 0; 1128 above = 0;
1119 below = 0; 1129 below = 0;
1120 1130
1131 ms.invalidate ();
1132
1121 if (map->in_memory == MAP_SAVING) 1133 if (map->in_memory == MAP_SAVING)
1122 return; 1134 return;
1123 1135
1124 int check_walk_off = !flag [FLAG_NO_APPLY]; 1136 int check_walk_off = !flag [FLAG_NO_APPLY];
1125 1137
1157 } 1169 }
1158 1170
1159 last = tmp; 1171 last = tmp;
1160 } 1172 }
1161 1173
1162 /* last == NULL if there are no objects on this space */ 1174 if (affects_los ())
1163 //TODO: this makes little sense, why only update the topmost object?
1164 if (!last)
1165 map->at (x, y).flags_ = 0;
1166 else
1167 update_object (last, UP_OBJ_REMOVE);
1168
1169 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1170 update_all_los (map, x, y); 1175 update_all_los (map, x, y);
1171 } 1176 }
1172} 1177}
1173 1178
1174/* 1179/*
1198 esrv_update_item (UPD_NROF, pl, top); 1203 esrv_update_item (UPD_NROF, pl, top);
1199 1204
1200 op->weight = 0; // cancel the addition above 1205 op->weight = 0; // cancel the addition above
1201 op->carrying = 0; // must be 0 already 1206 op->carrying = 0; // must be 0 already
1202 1207
1203 op->destroy (1); 1208 op->destroy ();
1204 1209
1205 return top; 1210 return top;
1206 } 1211 }
1207 1212
1208 return 0; 1213 return 0;
1236 * job preparing multi-part monsters. 1241 * job preparing multi-part monsters.
1237 */ 1242 */
1238object * 1243object *
1239insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1244insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1240{ 1245{
1246 op->remove ();
1247
1241 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1248 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1242 { 1249 {
1243 tmp->x = x + tmp->arch->x; 1250 tmp->x = x + tmp->arch->x;
1244 tmp->y = y + tmp->arch->y; 1251 tmp->y = y + tmp->arch->y;
1245 } 1252 }
1270object * 1277object *
1271insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1278insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1272{ 1279{
1273 op->remove (); 1280 op->remove ();
1274 1281
1282 if (m == &freed_map)//D TODO: remove soon
1283 {//D
1284 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1285 }//D
1286
1275 /* Ideally, the caller figures this out. However, it complicates a lot 1287 /* Ideally, the caller figures this out. However, it complicates a lot
1276 * of areas of callers (eg, anything that uses find_free_spot would now 1288 * of areas of callers (eg, anything that uses find_free_spot would now
1277 * need extra work 1289 * need extra work
1278 */ 1290 */
1291 maptile *newmap = m;
1279 if (!xy_normalise (m, op->x, op->y)) 1292 if (!xy_normalise (newmap, op->x, op->y))
1280 { 1293 {
1281 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found 1294 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1282 return 0; 1295 return 0;
1283 } 1296 }
1284 1297
1285 if (object *more = op->more) 1298 if (object *more = op->more)
1286 if (!insert_ob_in_map (more, m, originator, flag)) 1299 if (!insert_ob_in_map (more, m, originator, flag))
1287 return 0; 1300 return 0;
1288 1301
1289 CLEAR_FLAG (op, FLAG_REMOVED); 1302 CLEAR_FLAG (op, FLAG_REMOVED);
1290 1303
1291 op->map = m; 1304 op->map = newmap;
1292 mapspace &ms = op->ms (); 1305 mapspace &ms = op->ms ();
1293 1306
1294 /* this has to be done after we translate the coordinates. 1307 /* this has to be done after we translate the coordinates.
1295 */ 1308 */
1296 if (op->nrof && !(flag & INS_NO_MERGE)) 1309 if (op->nrof && !(flag & INS_NO_MERGE))
1299 { 1312 {
1300 // TODO: we actually want to update tmp, not op, 1313 // TODO: we actually want to update tmp, not op,
1301 // but some caller surely breaks when we return tmp 1314 // but some caller surely breaks when we return tmp
1302 // from here :/ 1315 // from here :/
1303 op->nrof += tmp->nrof; 1316 op->nrof += tmp->nrof;
1304 tmp->destroy (1); 1317 tmp->destroy ();
1305 } 1318 }
1306 1319
1307 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1320 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1308 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1321 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1309 1322
1310 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1323 if (!QUERY_FLAG (op, FLAG_ALIVE))
1311 CLEAR_FLAG (op, FLAG_NO_STEAL); 1324 CLEAR_FLAG (op, FLAG_NO_STEAL);
1312 1325
1313 if (flag & INS_BELOW_ORIGINATOR) 1326 if (flag & INS_BELOW_ORIGINATOR)
1314 { 1327 {
1315 if (originator->map != op->map || originator->x != op->x || originator->y != op->y || !originator->is_on_map ()) 1328 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1316 { 1329 {
1317 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1330 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1318 abort (); 1331 abort ();
1319 } 1332 }
1333
1334 if (!originator->is_on_map ())
1335 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1336 op->debug_desc (), originator->debug_desc ());
1320 1337
1321 op->above = originator; 1338 op->above = originator;
1322 op->below = originator->below; 1339 op->below = originator->below;
1323 originator->below = op; 1340 originator->below = op;
1324 1341
1391 } /* If objects on this space */ 1408 } /* If objects on this space */
1392 1409
1393 if (flag & INS_ABOVE_FLOOR_ONLY) 1410 if (flag & INS_ABOVE_FLOOR_ONLY)
1394 top = floor; 1411 top = floor;
1395 1412
1396 /* Top is the object that our object (op) is going to get inserted above. 1413 // insert object above top, or bottom-most if top = 0
1397 */
1398
1399 /* no top found, insert on top */
1400 if (!top) 1414 if (!top)
1401 { 1415 {
1402 op->above = 0; 1416 op->below = 0;
1403 op->below = ms.top; 1417 op->above = ms.bot;
1404 ms.top = op; 1418 ms.bot = op;
1405 1419
1406 *(op->below ? &op->below->above : &ms.bot) = op; 1420 *(op->above ? &op->above->below : &ms.top) = op;
1407 } 1421 }
1408 else 1422 else
1409 { /* get inserted into the stack above top */ 1423 {
1410 op->above = top->above; 1424 op->above = top->above;
1411 top->above = op; 1425 top->above = op;
1412 1426
1413 op->below = top; 1427 op->below = top;
1414 *(op->above ? &op->above->below : &ms.top) = op; 1428 *(op->above ? &op->above->below : &ms.top) = op;
1415 } 1429 }
1416 } /* else not INS_BELOW_ORIGINATOR */ 1430 }
1417 1431
1418 if (op->type == PLAYER) 1432 if (op->is_player ())
1419 { 1433 {
1420 op->contr->do_los = 1; 1434 op->contr->do_los = 1;
1421 ++op->map->players; 1435 ++op->map->players;
1422 op->map->touch (); 1436 op->map->touch ();
1423 } 1437 }
1438 * be far away from this change and not affected in any way - 1452 * be far away from this change and not affected in any way -
1439 * this should get redone to only look for players within range, 1453 * this should get redone to only look for players within range,
1440 * or just updating the P_UPTODATE for spaces within this area 1454 * or just updating the P_UPTODATE for spaces within this area
1441 * of effect may be sufficient. 1455 * of effect may be sufficient.
1442 */ 1456 */
1443 if (op->map->darkness && (op->glow_radius != 0)) 1457 if (op->affects_los ())
1458 {
1459 op->ms ().invalidate ();
1444 update_all_los (op->map, op->x, op->y); 1460 update_all_los (op->map, op->x, op->y);
1461 }
1445 1462
1446 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1463 /* updates flags (blocked, alive, no magic, etc) for this map space */
1447 update_object (op, UP_OBJ_INSERT); 1464 update_object (op, UP_OBJ_INSERT);
1448 1465
1449 INVOKE_OBJECT (INSERT, op); 1466 INVOKE_OBJECT (INSERT, op);
1483{ 1500{
1484 /* first search for itself and remove any old instances */ 1501 /* first search for itself and remove any old instances */
1485 1502
1486 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1503 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1487 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1504 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1488 tmp->destroy (1); 1505 tmp->destroy ();
1489 1506
1490 object *tmp = arch_to_object (archetype::find (arch_string)); 1507 object *tmp = arch_to_object (archetype::find (arch_string));
1491 1508
1492 tmp->x = op->x; 1509 tmp->x = op->x;
1493 tmp->y = op->y; 1510 tmp->y = op->y;
1517 if (!nr) 1534 if (!nr)
1518 return true; 1535 return true;
1519 1536
1520 nr = min (nr, nrof); 1537 nr = min (nr, nrof);
1521 1538
1539 if (nrof > nr)
1540 {
1522 nrof -= nr; 1541 nrof -= nr;
1523
1524 if (nrof)
1525 {
1526 adjust_weight (env, -weight * nr); // carrying == 0 1542 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1527 1543
1528 if (object *pl = visible_to ()) 1544 if (object *pl = visible_to ())
1529 esrv_update_item (UPD_NROF, pl, this); 1545 esrv_update_item (UPD_NROF, pl, this);
1530 1546
1531 return true; 1547 return true;
1532 } 1548 }
1533 else 1549 else
1534 { 1550 {
1535 destroy (1); 1551 destroy ();
1536 return false; 1552 return false;
1537 } 1553 }
1538} 1554}
1539 1555
1540/* 1556/*
1617 if (object *pl = tmp->visible_to ()) 1633 if (object *pl = tmp->visible_to ())
1618 esrv_update_item (UPD_NROF, pl, tmp); 1634 esrv_update_item (UPD_NROF, pl, tmp);
1619 1635
1620 adjust_weight (this, op->total_weight ()); 1636 adjust_weight (this, op->total_weight ());
1621 1637
1622 op->destroy (1); 1638 op->destroy ();
1623 op = tmp; 1639 op = tmp;
1624 goto inserted; 1640 goto inserted;
1625 } 1641 }
1626 1642
1627 op->owner = 0; // it's his/hers now. period. 1643 op->owner = 0; // it's his/hers now. period.
1645 1661
1646 adjust_weight (this, op->total_weight ()); 1662 adjust_weight (this, op->total_weight ());
1647 1663
1648inserted: 1664inserted:
1649 /* reset the light list and los of the players on the map */ 1665 /* reset the light list and los of the players on the map */
1650 if (op->glow_radius && map && map->darkness) 1666 if (op->glow_radius && is_on_map ())
1667 {
1668 update_stats ();
1651 update_all_los (map, x, y); 1669 update_all_los (map, x, y);
1652 1670 }
1671 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1653 // if this is a player's inventory, update stats 1672 // if this is a player's inventory, update stats
1654 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1655 update_stats (); 1673 update_stats ();
1656 1674
1657 INVOKE_OBJECT (INSERT, this); 1675 INVOKE_OBJECT (INSERT, this);
1658 1676
1659 return op; 1677 return op;
1743 { 1761 {
1744 1762
1745 float 1763 float
1746 diff = tmp->move_slow_penalty * fabs (op->speed); 1764 diff = tmp->move_slow_penalty * fabs (op->speed);
1747 1765
1748 if (op->type == PLAYER) 1766 if (op->is_player ())
1749 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1767 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1750 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1768 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1751 diff /= 4.0; 1769 diff /= 4.0;
1752 1770
1753 op->speed_left -= diff; 1771 op->speed_left -= diff;
1961 * head of the object should correspond for the entire object. 1979 * head of the object should correspond for the entire object.
1962 */ 1980 */
1963 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1981 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1964 continue; 1982 continue;
1965 1983
1966 if (ob->blocked (m, pos.x, pos.y)) 1984 if (ob->blocked (pos.m, pos.x, pos.y))
1967 continue; 1985 continue;
1968 1986
1969 altern [index++] = i; 1987 altern [index++] = i;
1970 } 1988 }
1971 1989
2039 * there is capable of. 2057 * there is capable of.
2040 */ 2058 */
2041int 2059int
2042find_dir (maptile *m, int x, int y, object *exclude) 2060find_dir (maptile *m, int x, int y, object *exclude)
2043{ 2061{
2044 int i, max = SIZEOFFREE, mflags; 2062 int max = SIZEOFFREE, mflags;
2045
2046 sint16 nx, ny;
2047 object *tmp;
2048 maptile *mp;
2049
2050 MoveType blocked, move_type; 2063 MoveType move_type;
2051 2064
2052 if (exclude && exclude->head_ () != exclude) 2065 if (exclude && exclude->head_ () != exclude)
2053 { 2066 {
2054 exclude = exclude->head; 2067 exclude = exclude->head;
2055 move_type = exclude->move_type; 2068 move_type = exclude->move_type;
2058 { 2071 {
2059 /* If we don't have anything, presume it can use all movement types. */ 2072 /* If we don't have anything, presume it can use all movement types. */
2060 move_type = MOVE_ALL; 2073 move_type = MOVE_ALL;
2061 } 2074 }
2062 2075
2063 for (i = 1; i < max; i++) 2076 for (int i = 1; i < max; i++)
2064 { 2077 {
2065 mp = m; 2078 mapxy pos (m, x, y);
2066 nx = x + freearr_x[i]; 2079 pos.move (i);
2067 ny = y + freearr_y[i];
2068 2080
2069 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2081 if (!pos.normalise ())
2070
2071 if (mflags & P_OUT_OF_MAP)
2072 max = maxfree[i]; 2082 max = maxfree[i];
2073 else 2083 else
2074 { 2084 {
2075 mapspace &ms = mp->at (nx, ny); 2085 mapspace &ms = *pos;
2076 2086
2077 blocked = ms.move_block;
2078
2079 if ((move_type & blocked) == move_type) 2087 if ((move_type & ms.move_block) == move_type)
2080 max = maxfree[i]; 2088 max = maxfree [i];
2081 else if (mflags & P_IS_ALIVE) 2089 else if (ms.flags () & P_IS_ALIVE)
2082 { 2090 {
2083 for (tmp = ms.bot; tmp; tmp = tmp->above) 2091 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2084 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2092 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2085 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2093 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2086 break;
2087
2088 if (tmp)
2089 return freedir[i]; 2094 return freedir [i];
2090 } 2095 }
2091 } 2096 }
2092 } 2097 }
2093 2098
2094 return 0; 2099 return 0;
2275int 2280int
2276can_pick (const object *who, const object *item) 2281can_pick (const object *who, const object *item)
2277{ 2282{
2278 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2283 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2279 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2284 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2280 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2285 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2281} 2286}
2282 2287
2283/* 2288/*
2284 * create clone from object to another 2289 * create clone from object to another
2285 */ 2290 */
2317 return tmp; 2322 return tmp;
2318 2323
2319 return 0; 2324 return 0;
2320} 2325}
2321 2326
2322const shstr & 2327shstr_tmp
2323object::kv_get (const shstr &key) const 2328object::kv_get (shstr_tmp key) const
2324{ 2329{
2325 for (key_value *kv = key_values; kv; kv = kv->next) 2330 for (key_value *kv = key_values; kv; kv = kv->next)
2326 if (kv->key == key) 2331 if (kv->key == key)
2327 return kv->value; 2332 return kv->value;
2328 2333
2329 return shstr_null; 2334 return shstr ();
2330} 2335}
2331 2336
2332void 2337void
2333object::kv_set (const shstr &key, const shstr &value) 2338object::kv_set (shstr_tmp key, shstr_tmp value)
2334{ 2339{
2335 for (key_value *kv = key_values; kv; kv = kv->next) 2340 for (key_value *kv = key_values; kv; kv = kv->next)
2336 if (kv->key == key) 2341 if (kv->key == key)
2337 { 2342 {
2338 kv->value = value; 2343 kv->value = value;
2347 2352
2348 key_values = kv; 2353 key_values = kv;
2349} 2354}
2350 2355
2351void 2356void
2352object::kv_del (const shstr &key) 2357object::kv_del (shstr_tmp key)
2353{ 2358{
2354 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2359 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2355 if ((*kvp)->key == key) 2360 if ((*kvp)->key == key)
2356 { 2361 {
2357 key_value *kv = *kvp; 2362 key_value *kv = *kvp;
2416{ 2421{
2417 char flagdesc[512]; 2422 char flagdesc[512];
2418 char info2[256 * 4]; 2423 char info2[256 * 4];
2419 char *p = info; 2424 char *p = info;
2420 2425
2421 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2426 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2422 count, 2427 count,
2423 uuid.c_str (), 2428 uuid.c_str (),
2424 &name, 2429 &name,
2425 title ? "\",title:\"" : "", 2430 title ? ",title:\"" : "",
2426 title ? (const char *)title : "", 2431 title ? (const char *)title : "",
2432 title ? "\"" : "",
2427 flag_desc (flagdesc, 512), type); 2433 flag_desc (flagdesc, 512), type);
2428 2434
2429 if (!flag[FLAG_REMOVED] && env) 2435 if (!flag[FLAG_REMOVED] && env)
2430 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2436 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2431 2437
2525// else if (!old_container->env && contr && contr->ns) 2531// else if (!old_container->env && contr && contr->ns)
2526// contr->ns->floorbox_reset (); 2532// contr->ns->floorbox_reset ();
2527} 2533}
2528 2534
2529object * 2535object *
2530object::force_find (const shstr name) 2536object::force_find (shstr_tmp name)
2531{ 2537{
2532 /* cycle through his inventory to look for the MARK we want to 2538 /* cycle through his inventory to look for the MARK we want to
2533 * place 2539 * place
2534 */ 2540 */
2535 for (object *tmp = inv; tmp; tmp = tmp->below) 2541 for (object *tmp = inv; tmp; tmp = tmp->below)
2537 return splay (tmp); 2543 return splay (tmp);
2538 2544
2539 return 0; 2545 return 0;
2540} 2546}
2541 2547
2542void 2548object *
2543object::force_add (const shstr name, int duration) 2549object::force_add (shstr_tmp name, int duration)
2544{ 2550{
2545 if (object *force = force_find (name)) 2551 if (object *force = force_find (name))
2546 force->destroy (); 2552 force->destroy ();
2547 2553
2548 object *force = get_archetype (FORCE_NAME); 2554 object *force = get_archetype (FORCE_NAME);
2553 2559
2554 force->set_speed (duration ? 1.f / duration : 0.f); 2560 force->set_speed (duration ? 1.f / duration : 0.f);
2555 force->flag [FLAG_IS_USED_UP] = true; 2561 force->flag [FLAG_IS_USED_UP] = true;
2556 force->flag [FLAG_APPLIED] = true; 2562 force->flag [FLAG_APPLIED] = true;
2557 2563
2558 insert (force); 2564 return insert (force);
2559} 2565}
2560 2566
2561void 2567void
2562object::play_sound (faceidx sound) 2568object::play_sound (faceidx sound)
2563{ 2569{
2574 } 2580 }
2575 else 2581 else
2576 map->play_sound (sound, x, y); 2582 map->play_sound (sound, x, y);
2577} 2583}
2578 2584
2585void
2586object::make_noise ()
2587{
2588 // we do not model noise in the map, so instead put
2589 // a temporary light into the noise source
2590 // could use the map instead, but that's less reliable for our
2591 // goal, which is to make invisibility a bit harder to exploit
2592
2593 // currently only works sensibly for players
2594 if (!is_player ())
2595 return;
2596
2597 // find old force, or create new one
2598 object *force = force_find (shstr_noise_force);
2599
2600 if (force)
2601 force->speed_left = -1.f; // patch old speed up
2602 else
2603 {
2604 force = archetype::get (shstr_noise_force);
2605
2606 force->slaying = shstr_noise_force;
2607 force->stats.food = 1;
2608 force->speed_left = -1.f;
2609
2610 force->set_speed (1.f / 4.f);
2611 force->flag [FLAG_IS_USED_UP] = true;
2612 force->flag [FLAG_APPLIED] = true;
2613
2614 insert (force);
2615 }
2616}
2617

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines