ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.202 by root, Thu Apr 10 15:35:15 2008 UTC vs.
Revision 1.288 by root, Sat Oct 3 22:36:08 2009 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify
9	* it under the terms of the GNU General Public License as published by	9	* it under the terms of the GNU General Public License as published by
…		…
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* along with this program. If not, see <http://www.gnu.org/licenses/>.
20	*	20	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	21	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	22	*/
23		23
24	/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25	sub/add_weight will transcend the environment updating the carrying
26	variable. */
27	#include <global.h>	24	#include <global.h>
28	#include <stdio.h>	25	#include <stdio.h>
29	#include <sys/types.h>	26	#include <sys/types.h>
30	#include <sys/uio.h>	27	#include <sys/uio.h>
31	#include <object.h>	28	#include <object.h>
32	#include <funcpoint.h>
33	#include <sproto.h>	29	#include <sproto.h>
34	#include <loader.h>	30	#include <loader.h>
35		31
36	#include <bitset>	32	#include <bitset>
37		33
38	UUID UUID::cur;	34	UUID UUID::cur;
		35	static uint64_t seq_next_save;
39	static const uint64 UUID_SKIP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
40		38
41	objectvec objects;	39	objectvec objects;
42	activevec actives;	40	activevec actives;
43		41
44	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	42	short freearr_x[SIZEOFFREE] = {
		43	0,
		44	0, 1, 1, 1, 0, -1, -1, -1,
		45	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
45	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1	46	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
46	};	47	};
47	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	48	short freearr_y[SIZEOFFREE] = {
		49	0,
		50	-1, -1, 0, 1, 1, 1, 0, -1,
		51	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
48	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	52	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
49	};	53	};
50	int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45,	54	int maxfree[SIZEOFFREE] = {
		55	0,
		56	9, 10, 13, 14, 17, 18, 21, 22,
		57	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
51	48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49	58	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
52	};	59	};
53	int freedir[SIZEOFFREE] = {	60	int freedir[SIZEOFFREE] = {
54	0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	61	0,
		62	1, 2, 3, 4, 5, 6, 7, 8,
		63	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
55	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	64	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
56	};	65	};
57		66
58	static void	67	static void
59	write_uuid (void)	68	write_uuid (uval64 skip, bool sync)
60	{	69	{
61	char filename1[MAX_BUF], filename2[MAX_BUF];	70	CALL_BEGIN (2);
62		71	CALL_ARG_SV (newSVval64 (skip));
63	sprintf (filename1, "%s/uuid", settings.localdir);	72	CALL_ARG_SV (boolSV (sync));
64	sprintf (filename2, "%s/uuid~", settings.localdir);	73	CALL_CALL ("cf::write_uuid", G_DISCARD);
65		74	CALL_END;
66	FILE *fp;
67
68	if (!(fp = fopen (filename2, "w")))
69	{
70	LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
71	return;
72	}
73
74	fprintf (fp, "<1,%llx>\n", (unsigned long long)UUID::cur.seq + UUID_SKIP * 2);
75	fclose (fp);
76	rename (filename2, filename1);
77	}	75	}
78		76
79	static void	77	static void
80	read_uuid (void)	78	read_uuid (void)
81	{	79	{
82	char filename[MAX_BUF];	80	char filename[MAX_BUF];
83		81
84	sprintf (filename, "%s/uuid", settings.localdir);	82	sprintf (filename, "%s/uuid", settings.localdir);
		83
		84	seq_next_save = 0;
85		85
86	FILE *fp;	86	FILE *fp;
87		87
88	if (!(fp = fopen (filename, "r")))	88	if (!(fp = fopen (filename, "r")))
89	{	89	{
90	if (errno == ENOENT)	90	if (errno == ENOENT)
91	{	91	{
92	LOG (llevInfo, "RESET uid to 1\n");	92	LOG (llevInfo, "RESET uid to 1\n");
93	UUID::cur.seq = 0;	93	UUID::cur.seq = 0;
94	write_uuid ();	94	write_uuid (UUID_GAP, true);
95	return;	95	return;
96	}	96	}
97		97
98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
99	_exit (1);	99	_exit (1);
100	}	100	}
101		101
102	int version;	102	UUID::BUF buf;
103	unsigned long long uid;	103	buf[0] = 0;
104	if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)	104	fgets (buf, sizeof (buf), fp);
		105
		106	if (!UUID::cur.parse (buf))
105	{	107	{
106	LOG (llevError, "FATAL: error reading uid from %s!\n", filename);	108	LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
107	_exit (1);	109	_exit (1);
108	}	110	}
109		111
110	UUID::cur.seq = uid;	112	LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
111	write_uuid ();	113
112	LOG (llevDebug, "read UID: %" PRId64 "\n", uid);	114	write_uuid (UUID_GAP, true);
113	fclose (fp);	115	fclose (fp);
114	}	116	}
115		117
116	UUID	118	UUID
117	UUID::gen ()	119	UUID::gen ()
118	{	120	{
119	UUID uid;	121	UUID uid;
120		122
121	uid.seq = ++cur.seq;	123	uid.seq = ++cur.seq;
122		124
123	if (!(cur.seq & (UUID_SKIP - 1)))	125	if (expect_false (cur.seq >= seq_next_save))
124	write_uuid ();	126	{
		127	seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
		128	write_uuid (UUID_GAP, false);
		129	}
		130
125		131
126	return uid;	132	return uid;
127	}	133	}
128		134
129	void	135	void
…		…
131	{	137	{
132	read_uuid ();	138	read_uuid ();
133	}	139	}
134		140
135	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
136	static int	142	static bool
137	compare_ob_value_lists_one (const object *wants, const object *has)	143	compare_ob_value_lists_one (const object *wants, const object *has)
138	{	144	{
139	key_value *wants_field;
140
141	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	145	/* n-squared behaviour (see kv_get), but I'm hoping both
142	* objects with lists are rare, and lists stay short. If not, use a	146	* objects with lists are rare, and lists stay short. If not, use a
143	* different structure or at least keep the lists sorted...	147	* different structure or at least keep the lists sorted...
144	*/	148	*/
145		149
146	/* For each field in wants, */	150	/* For each field in wants, */
147	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	151	for (key_value *kv = wants->key_values; kv; kv = kv->next)
148	{	152	if (has->kv_get (kv->key) != kv->value)
149	key_value *has_field;	153	return false;
150
151	/* Look for a field in has with the same key. */
152	has_field = get_ob_key_link (has, wants_field->key);
153
154	if (has_field == NULL)
155	{
156	/* No field with that name. */
157	return FALSE;
158	}
159
160	/* Found the matching field. */
161	if (has_field->value != wants_field->value)
162	{
163	/* Values don't match, so this half of the comparison is false. */
164	return FALSE;
165	}
166
167	/* If we get here, we found a match. Now for the next field in wants. */
168	}
169		154
170	/* If we get here, every field in wants has a matching field in has. */	155	/* If we get here, every field in wants has a matching field in has. */
171	return TRUE;	156	return true;
172	}	157	}
173		158
174	/* Returns TRUE if ob1 has the same key_values as ob2. */	159	/* Returns TRUE if ob1 has the same key_values as ob2. */
175	static int	160	static bool
176	compare_ob_value_lists (const object *ob1, const object *ob2)	161	compare_ob_value_lists (const object *ob1, const object *ob2)
177	{	162	{
178	/* However, there may be fields in has which aren't partnered in wants,	163	/* However, there may be fields in has which aren't partnered in wants,
179	* so we need to run the comparison *twice*. :(	164	* so we need to run the comparison *twice*. :(
180	*/	165	*/
181	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	166	return compare_ob_value_lists_one (ob1, ob2)
		167	&& compare_ob_value_lists_one (ob2, ob1);
182	}	168	}
183		169
184	/* Function examines the 2 objects given to it, and returns true if	170	/* Function examines the 2 objects given to it, and returns true if
185	* they can be merged together.	171	* they can be merged together.
186	*	172	*
…		…
201	|| ob1->speed != ob2->speed	187	|| ob1->speed != ob2->speed
202	|| ob1->value != ob2->value	188	|| ob1->value != ob2->value
203	|| ob1->name != ob2->name)	189	|| ob1->name != ob2->name)
204	return 0;	190	return 0;
205		191
206	//TODO: this ain't working well, use nicer and correct overflow check
207	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that	192	/* Do not merge objects if nrof would overflow, assume nrof
208	* value could not be stored in a sint32 (which unfortunately sometimes is	193	* is always 0 .. 2**31-1 */
209	* used to store nrof).	194	if (ob1->nrof > 0x7fffffff - ob2->nrof)
210	*/
211	if (ob1->nrof + ob2->nrof >= 1UL << 31)
212	return 0;	195	return 0;
213		196
214	/* If the objects have been identified, set the BEEN_APPLIED flag.	197	/* If the objects have been identified, set the BEEN_APPLIED flag.
215	* This is to the comparison of the flags below will be OK. We	198	* This is to the comparison of the flags below will be OK. We
216	* just can't ignore the been applied or identified flags, as they	199	* just can't ignore the been applied or identified flags, as they
217	* are not equal - just if it has been identified, the been_applied	200	* are not equal - just if it has been identified, the been_applied
218	* flags lose any meaning.	201	* flags lose any meaning.
219	*/	202	*/
220	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	203	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
221	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	204	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222		205
223	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	206	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	207	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225		208
226	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()	209	if (ob1->arch->archname != ob2->arch->archname
227	|| ob1->arch != ob2->arch
228	|| ob1->name != ob2->name	210	|| ob1->name != ob2->name
229	|| ob1->title != ob2->title	211	|| ob1->title != ob2->title
230	|| ob1->msg != ob2->msg	212	|| ob1->msg != ob2->msg
231	|| ob1->weight != ob2->weight	213	|| ob1->weight != ob2->weight
232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
234	|| ob1->attacktype != ob2->attacktype	214	|| ob1->attacktype != ob2->attacktype
235	|| ob1->magic != ob2->magic	215	|| ob1->magic != ob2->magic
236	|| ob1->slaying != ob2->slaying	216	|| ob1->slaying != ob2->slaying
237	|| ob1->skill != ob2->skill	217	|| ob1->skill != ob2->skill
238	|| ob1->value != ob2->value	218	|| ob1->value != ob2->value
239	|| ob1->animation_id != ob2->animation_id	219	|| ob1->animation_id != ob2->animation_id
		220	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
240	|| ob1->client_type != ob2->client_type	221	|| ob1->client_type != ob2->client_type
241	|| ob1->materialname != ob2->materialname	222	|| ob1->materialname != ob2->materialname
242	|| ob1->lore != ob2->lore	223	|| ob1->lore != ob2->lore
243	|| ob1->subtype != ob2->subtype	224	|| ob1->subtype != ob2->subtype
244	|| ob1->move_type != ob2->move_type	225	|| ob1->move_type != ob2->move_type
245	|| ob1->move_block != ob2->move_block	226	|| ob1->move_block != ob2->move_block
246	|| ob1->move_allow != ob2->move_allow	227	|| ob1->move_allow != ob2->move_allow
247	|| ob1->move_on != ob2->move_on	228	|| ob1->move_on != ob2->move_on
248	|| ob1->move_off != ob2->move_off	229	|| ob1->move_off != ob2->move_off
249	|| ob1->move_slow != ob2->move_slow	230	|| ob1->move_slow != ob2->move_slow
250	|| ob1->move_slow_penalty != ob2->move_slow_penalty)	231	|| ob1->move_slow_penalty != ob2->move_slow_penalty
		232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
		233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
251	return 0;	234	return 0;
252		235
		236	if ((ob1->flag ^ ob2->flag)
		237	.reset (FLAG_INV_LOCKED)
		238	.reset (FLAG_REMOVED)
		239	.any ())
		240	return 0;
		241
253	/* This is really a spellbook check - really, we should	242	/* This is really a spellbook check - we should in general
254	* check all objects in the inventory.	243	* not merge objects with real inventories, as splitting them
		244	* is hard.
255	*/	245	*/
256	if (ob1->inv || ob2->inv)	246	if (ob1->inv || ob2->inv)
257	{	247	{
258	if (!(ob1->inv && ob2->inv))	248	if (!(ob1->inv && ob2->inv))
259	return 0; /* inventories differ in length */	249	return 0; /* inventories differ in length */
260		250
261	if (ob1->inv->below || ob2->inv->below)	251	if (ob1->inv->below || ob2->inv->below)
262	return 0; /* more than one object in inv */	252	return 0; /* more than one object in inv */
263		253
264	if (!object::can_merge (ob1->inv, ob2->inv))	254	if (!object::can_merge (ob1->inv, ob2->inv))
265	return 0; /* inventory objexts differ */	255	return 0; /* inventory objects differ */
266		256
267	/* inventory ok - still need to check rest of this object to see	257	/* inventory ok - still need to check rest of this object to see
268	* if it is valid.	258	* if it is valid.
269	*/	259	*/
270	}	260	}
…		…
289	if (ob1->level != ob2->level)	279	if (ob1->level != ob2->level)
290	return 0;	280	return 0;
291	break;	281	break;
292	}	282	}
293		283
294	if (ob1->key_values != NULL || ob2->key_values != NULL)	284	if (ob1->key_values || ob2->key_values)
295	{	285	{
296	/* At least one of these has key_values. */	286	/* At least one of these has key_values. */
297	if ((ob1->key_values == NULL) != (ob2->key_values == NULL))	287	if ((!ob1->key_values) != (!ob2->key_values))
298	/* One has fields, but the other one doesn't. */	288	return 0; /* One has fields, but the other one doesn't. */
299	return 0;	289
300	else if (!compare_ob_value_lists (ob1, ob2))	290	if (!compare_ob_value_lists (ob1, ob2))
301	return 0;	291	return 0;
302	}	292	}
303		293
304	if (ob1->self || ob2->self)	294	if (ob1->self || ob2->self)
305	{	295	{
…		…
311	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;	301	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
312	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;	302	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
313		303
314	if (k1 != k2)	304	if (k1 != k2)
315	return 0;	305	return 0;
		306
316	else if (k1 == 0)	307	if (k1 == 0)
317	return 1;	308	return 1;
		309
318	else if (!cfperl_can_merge (ob1, ob2))	310	if (!cfperl_can_merge (ob1, ob2))
319	return 0;	311	return 0;
320	}	312	}
321	}	313	}
322		314
323	/* Everything passes, must be OK. */	315	/* Everything passes, must be OK. */
324	return 1;	316	return 1;
325	}	317	}
326		318
		319	// find player who can see this object
		320	object *
		321	object::visible_to () const
		322	{
		323	if (client_visible () && !flag [FLAG_REMOVED])
		324	{
		325	// see if we are in a container of sorts
		326	if (env)
		327	{
		328	// the player inventory itself is always visible
		329	if (env->is_player ())
		330	return env;
		331
		332	// else a player could have our env open
		333	object *envest = env->outer_env_or_self ();
		334
		335	// the player itself is always on a map, so we will find him here
		336	// even if our inv is in a player.
		337	if (envest->is_on_map ())
		338	if (object *pl = envest->ms ().player ())
		339	if (pl->container == env)
		340	return pl;
		341	}
		342	else
		343	{
		344	// maybe there is a player standing on the same mapspace
		345	// this will catch the case where "this" is a player
		346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		348	|| this == pl->container)
		349	return pl;
		350	}
		351	}
		352
		353	return 0;
		354	}
		355
		356	// adjust weight per container type ("of holding")
		357	static sint32
		358	weight_adjust_for (object *op, sint32 weight)
		359	{
		360	return op->type == CONTAINER
		361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
		362	: weight;
		363	}
		364
327	/*	365	/*
		366	* adjust_weight(object, weight) adds the specified weight to an object,
		367	* and also updates how much the environment(s) is/are carrying.
		368	*/
		369	static void
		370	adjust_weight (object *op, sint32 weight)
		371	{
		372	while (op)
		373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
		376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
		378
		379	if (!weight)
		380	return;
		381
		382	op->carrying += weight;
		383
		384	if (object *pl = op->visible_to ())
		385	if (pl != op) // player is handled lazily
		386	esrv_update_item (UPD_WEIGHT, pl, op);
		387
		388	op = op->env;
		389	}
		390	}
		391
		392	/*
328	* sum_weight() is a recursive function which calculates the weight	393	* this is a recursive function which calculates the weight
329	* an object is carrying. It goes through in figures out how much	394	* an object is carrying. It goes through op and figures out how much
330	* containers are carrying, and sums it up.	395	* containers are carrying, and sums it up.
331	*/	396	*/
332	long	397	void
333	sum_weight (object *op)	398	object::update_weight ()
334	{	399	{
335	long sum;	400	sint32 sum = 0;
336	object *inv;
337		401
338	for (sum = 0, inv = op->inv; inv; inv = inv->below)	402	for (object *op = inv; op; op = op->below)
339	{	403	{
340	if (inv->inv)	404	if (op->inv)
341	sum_weight (inv);	405	op->update_weight ();
342		406
343	sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);	407	sum += op->total_weight ();
		408	}
		409
		410	sum = weight_adjust_for (this, sum);
		411
		412	if (sum != carrying)
344	}	413	{
345
346	if (op->type == CONTAINER && op->stats.Str)
347	sum = (sum * (100 - op->stats.Str)) / 100;
348
349	if (op->carrying != sum)
350	op->carrying = sum;	414	carrying = sum;
351		415
352	return sum;	416	if (object *pl = visible_to ())
		417	if (pl != this) // player is handled lazily
		418	esrv_update_item (UPD_WEIGHT, pl, this);
		419	}
353	}	420	}
354		421
355	/**	422	/*
356	* Return the outermost environment object for a given object.	423	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
357	*/
358
359	object *
360	object_get_env_recursive (object *op)
361	{
362	while (op->env != NULL)
363	op = op->env;
364	return op;
365	}
366
367	/*
368	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
369	* Some error messages.
370	* The result of the dump is stored in the static global errmsg array.
371	*/	424	*/
372	char *	425	char *
373	dump_object (object *op)	426	dump_object (object *op)
374	{	427	{
375	if (!op)	428	if (!op)
…		…
389	get_nearest_part (object *op, const object *pl)	442	get_nearest_part (object *op, const object *pl)
390	{	443	{
391	object *tmp, *closest;	444	object *tmp, *closest;
392	int last_dist, i;	445	int last_dist, i;
393		446
394	if (op->more == NULL)	447	if (!op->more)
395	return op;	448	return op;
		449
396	for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)	450	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
		451	tmp;
		452	tmp = tmp->more)
397	if ((i = distance (tmp, pl)) < last_dist)	453	if ((i = distance (tmp, pl)) < last_dist)
398	closest = tmp, last_dist = i;	454	closest = tmp, last_dist = i;
		455
399	return closest;	456	return closest;
400	}	457	}
401		458
402	/*	459	/*
403	* Returns the object which has the count-variable equal to the argument.	460	* Returns the object which has the count-variable equal to the argument.
		461	* VERRRY slow.
404	*/	462	*/
405	object *	463	object *
406	find_object (tag_t i)	464	find_object (tag_t i)
407	{	465	{
408	for_all_objects (op)	466	for_all_objects (op)
…		…
419	*/	477	*/
420	object *	478	object *
421	find_object_name (const char *str)	479	find_object_name (const char *str)
422	{	480	{
423	shstr_cmp str_ (str);	481	shstr_cmp str_ (str);
424	object *op;
425		482
		483	if (str_)
426	for_all_objects (op)	484	for_all_objects (op)
427	if (op->name == str_)	485	if (op->name == str_)
428	break;	486	return op;
429		487
430	return op;	488	return 0;
431	}	489	}
432		490
433	/*	491	/*
434	* Sets the owner and sets the skill and exp pointers to owner's current	492	* Sets the owner and sets the skill and exp pointers to owner's current
435	* skill and experience objects.	493	* skill and experience objects.
…		…
497	update_stats ();	555	update_stats ();
498		556
499	new_draw_info_format (NDI_UNIQUE, 0, this,	557	new_draw_info_format (NDI_UNIQUE, 0, this,
500	"You try to balance all your items at once, "	558	"You try to balance all your items at once, "
501	"but the %s is just too much for your body. "	559	"but the %s is just too much for your body. "
502	"[You need to unapply some items first.]", &ob->name);	560	"[You need to unapply some items first - use the 'body' command to see "
		561	"how many items you cna wera on a specific body part.]", &ob->name);
503	return false;	562	return false;
504	}	563	}
505		564
506	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);	565	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
507	}	566	}
…		…
533	}	592	}
534		593
535	op->key_values = 0;	594	op->key_values = 0;
536	}	595	}
537		596
538	object &	597	/*
539	object::operator =(const object &src)	598	* copy_to first frees everything allocated by the dst object,
		599	* and then copies the contents of itself into the second
		600	* object, allocating what needs to be allocated. Basically, any
		601	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		602	* if the first object is freed, the pointers in the new object
		603	* will point at garbage.
		604	*/
		605	void
		606	object::copy_to (object *dst)
540	{	607	{
541	bool is_freed = flag [FLAG_FREED];	608	dst->remove ();
542	bool is_removed = flag [FLAG_REMOVED];
543
544	*(object_copy *)this = src;	609	*(object_copy *)dst = *this;
545
546	flag [FLAG_FREED] = is_freed;
547	flag [FLAG_REMOVED] = is_removed;	610	dst->flag [FLAG_REMOVED] = true;
548		611
549	/* Copy over key_values, if any. */	612	/* Copy over key_values, if any. */
550	if (src.key_values)	613	if (key_values)
551	{	614	{
552	key_value *tail = 0;	615	key_value *tail = 0;
553	key_values = 0;	616	dst->key_values = 0;
554		617
555	for (key_value *i = src.key_values; i; i = i->next)	618	for (key_value *i = key_values; i; i = i->next)
556	{	619	{
557	key_value *new_link = new key_value;	620	key_value *new_link = new key_value;
558		621
559	new_link->next = 0;	622	new_link->next = 0;
560	new_link->key = i->key;	623	new_link->key = i->key;
561	new_link->value = i->value;	624	new_link->value = i->value;
562		625
563	/* Try and be clever here, too. */	626	/* Try and be clever here, too. */
564	if (!key_values)	627	if (!dst->key_values)
565	{	628	{
566	key_values = new_link;	629	dst->key_values = new_link;
567	tail = new_link;	630	tail = new_link;
568	}	631	}
569	else	632	else
570	{	633	{
571	tail->next = new_link;	634	tail->next = new_link;
572	tail = new_link;	635	tail = new_link;
573	}	636	}
574	}	637	}
575	}	638	}
576	}
577
578	/*
579	* copy_to first frees everything allocated by the dst object,
580	* and then copies the contents of itself into the second
581	* object, allocating what needs to be allocated. Basically, any
582	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
583	* if the first object is freed, the pointers in the new object
584	* will point at garbage.
585	*/
586	void
587	object::copy_to (object *dst)
588	{
589	*dst = *this;
590		639
591	if (speed < 0)	640	if (speed < 0)
592	dst->speed_left -= rndm ();	641	dst->speed_left -= rndm ();
593		642
594	dst->set_speed (dst->speed);	643	dst->activate ();
595	}	644	}
596		645
597	void	646	void
598	object::instantiate ()	647	object::instantiate ()
599	{	648	{
…		…
616	object *	665	object *
617	object::clone ()	666	object::clone ()
618	{	667	{
619	object *neu = create ();	668	object *neu = create ();
620	copy_to (neu);	669	copy_to (neu);
		670	neu->map = map; // not copied by copy_to
621	return neu;	671	return neu;
622	}	672	}
623		673
624	/*	674	/*
625	* If an object with the IS_TURNABLE() flag needs to be turned due	675	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
676	* UP_OBJ_FACE: only the objects face has changed.	726	* UP_OBJ_FACE: only the objects face has changed.
677	*/	727	*/
678	void	728	void
679	update_object (object *op, int action)	729	update_object (object *op, int action)
680	{	730	{
681	if (op == NULL)	731	if (!op)
682	{	732	{
683	/* this should never happen */	733	/* this should never happen */
684	LOG (llevDebug, "update_object() called for NULL object.\n");	734	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
685	return;	735	return;
686	}	736	}
687		737
688	if (op->env)	738	if (!op->is_on_map ())
689	{	739	{
690	/* Animation is currently handled by client, so nothing	740	/* Animation is currently handled by client, so nothing
691	* to do in this case.	741	* to do in this case.
692	*/	742	*/
693	return;	743	return;
694	}	744	}
695
696	/* If the map is saving, don't do anything as everything is
697	* going to get freed anyways.
698	*/
699	if (!op->map || op->map->in_memory == MAP_SAVING)
700	return;
701		745
702	/* make sure the object is within map boundaries */	746	/* make sure the object is within map boundaries */
703	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	747	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
704	{	748	{
705	LOG (llevError, "update_object() called for object out of map!\n");	749	LOG (llevError, "update_object() called for object out of map!\n");
…		…
716	else if (action == UP_OBJ_INSERT)	760	else if (action == UP_OBJ_INSERT)
717	{	761	{
718	// this is likely overkill, TODO: revisit (schmorp)	762	// this is likely overkill, TODO: revisit (schmorp)
719	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	763	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
720	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	764	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
721	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	765	|| (op->is_player () && !(m.flags_ & P_PLAYER))
722	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	766	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
723	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	767	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
724	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	768	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
725	|| (m.move_on | op->move_on ) != m.move_on	769	|| (m.move_on | op->move_on ) != m.move_on
726	|| (m.move_off | op->move_off ) != m.move_off	770	|| (m.move_off | op->move_off ) != m.move_off
727	|| (m.move_slow | op->move_slow) != m.move_slow	771	|| (m.move_slow | op->move_slow) != m.move_slow
728	/* This isn't perfect, but I don't expect a lot of objects to	772	/* This isn't perfect, but I don't expect a lot of objects to
729	* to have move_allow right now.	773	* have move_allow right now.
730	*/	774	*/
731	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	775	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
732	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	776	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
733	m.flags_ = 0;	777	m.invalidate ();
734	}	778	}
735	/* if the object is being removed, we can't make intelligent	779	/* if the object is being removed, we can't make intelligent
736	* decisions, because remove_ob can't really pass the object	780	* decisions, because remove_ob can't really pass the object
737	* that is being removed.	781	* that is being removed.
738	*/	782	*/
739	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	783	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
740	m.flags_ = 0;	784	m.invalidate ();
741	else if (action == UP_OBJ_FACE)	785	else if (action == UP_OBJ_FACE)
742	/* Nothing to do for that case */ ;	786	/* Nothing to do for that case */ ;
743	else	787	else
744	LOG (llevError, "update_object called with invalid action: %d\n", action);	788	LOG (llevError, "update_object called with invalid action: %d\n", action);
745		789
…		…
749		793
750	object::object ()	794	object::object ()
751	{	795	{
752	SET_FLAG (this, FLAG_REMOVED);	796	SET_FLAG (this, FLAG_REMOVED);
753		797
754	expmul = 1.0;	798	//expmul = 1.0; declared const for the time being
755	face = blank_face;	799	face = blank_face;
756	}	800	}
757		801
758	object::~object ()	802	object::~object ()
759	{	803	{
…		…
789	/* If already on active list, don't do anything */	833	/* If already on active list, don't do anything */
790	if (active)	834	if (active)
791	return;	835	return;
792		836
793	if (has_active_speed ())	837	if (has_active_speed ())
		838	{
		839	if (flag [FLAG_FREED])
		840	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		841
794	actives.insert (this);	842	actives.insert (this);
		843	}
795	}	844	}
796		845
797	void	846	void
798	object::activate_recursive ()	847	object::activate_recursive ()
799	{	848	{
…		…
848	object::destroy_inv (bool drop_to_ground)	897	object::destroy_inv (bool drop_to_ground)
849	{	898	{
850	// need to check first, because the checks below might segfault	899	// need to check first, because the checks below might segfault
851	// as we might be on an invalid mapspace and crossfire code	900	// as we might be on an invalid mapspace and crossfire code
852	// is too buggy to ensure that the inventory is empty.	901	// is too buggy to ensure that the inventory is empty.
853	// corollary: if you create arrows etc. with stuff in tis inventory,	902	// corollary: if you create arrows etc. with stuff in its inventory,
854	// cf will crash below with off-map x and y	903	// cf will crash below with off-map x and y
855	if (!inv)	904	if (!inv)
856	return;	905	return;
857		906
858	/* Only if the space blocks everything do we not process -	907	/* Only if the space blocks everything do we not process -
859	* if some form of movement is allowed, let objects	908	* if some form of movement is allowed, let objects
860	* drop on that space.	909	* drop on that space.
861	*/	910	*/
862	if (!drop_to_ground	911	if (!drop_to_ground
863	|| !map	912	|| !map
864	|| map->in_memory != MAP_IN_MEMORY	913	|| map->in_memory != MAP_ACTIVE
865	|| map->nodrop	914	|| map->no_drop
866	|| ms ().move_block == MOVE_ALL)	915	|| ms ().move_block == MOVE_ALL)
867	{	916	{
868	while (inv)	917	while (inv)
869	{
870	inv->destroy_inv (drop_to_ground);
871	inv->destroy ();	918	inv->destroy ();
872	}
873	}	919	}
874	else	920	else
875	{ /* Put objects in inventory onto this space */	921	{ /* Put objects in inventory onto this space */
876	while (inv)	922	while (inv)
877	{	923	{
…		…
895	object *op = new object;	941	object *op = new object;
896	op->link ();	942	op->link ();
897	return op;	943	return op;
898	}	944	}
899		945
		946	static struct freed_map : maptile
		947	{
		948	freed_map ()
		949	{
		950	path = "<freed objects map>";
		951	name = "/internal/freed_objects_map";
		952	width = 3;
		953	height = 3;
		954	no_drop = 1;
		955	no_reset = 1;
		956
		957	alloc ();
		958	in_memory = MAP_ACTIVE;
		959	}
		960
		961	~freed_map ()
		962	{
		963	destroy ();
		964	}
		965	} freed_map; // freed objects are moved here to avoid crashes
		966
900	void	967	void
901	object::do_destroy ()	968	object::do_destroy ()
902	{	969	{
903	attachable::do_destroy ();
904
905	if (flag [FLAG_IS_LINKED])	970	if (flag [FLAG_IS_LINKED])
906	remove_button_link (this);	971	remove_link ();
907		972
908	if (flag [FLAG_FRIENDLY])	973	if (flag [FLAG_FRIENDLY])
909	remove_friendly_object (this);	974	remove_friendly_object (this);
910		975
911	if (!flag [FLAG_REMOVED])
912	remove ();	976	remove ();
913		977
914	destroy_inv (true);	978	attachable::do_destroy ();
915		979
916	deactivate ();	980	deactivate ();
917	unlink ();	981	unlink ();
918		982
919	flag [FLAG_FREED] = 1;	983	flag [FLAG_FREED] = 1;
920		984
921	// hack to ensure that freed objects still have a valid map	985	// hack to ensure that freed objects still have a valid map
922	{
923	static maptile *freed_map; // freed objects are moved here to avoid crashes
924
925	if (!freed_map)
926	{
927	freed_map = new maptile;
928
929	freed_map->path = "<freed objects map>";
930	freed_map->name = "/internal/freed_objects_map";
931	freed_map->width = 3;
932	freed_map->height = 3;
933	freed_map->nodrop = 1;
934
935	freed_map->alloc ();
936	freed_map->in_memory = MAP_IN_MEMORY;
937	}
938
939	map = freed_map;	986	map = &freed_map;
940	x = 1;	987	x = 1;
941	y = 1;	988	y = 1;
942	}
943		989
944	if (more)	990	if (more)
945	{	991	{
946	more->destroy ();	992	more->destroy ();
947	more = 0;	993	more = 0;
…		…
955	attacked_by = 0;	1001	attacked_by = 0;
956	current_weapon = 0;	1002	current_weapon = 0;
957	}	1003	}
958		1004
959	void	1005	void
960	object::destroy (bool destroy_inventory)	1006	object::destroy ()
961	{	1007	{
962	if (destroyed ())	1008	if (destroyed ())
963	return;	1009	return;
964		1010
965	if (destroy_inventory)	1011	if (!is_head () && !head->destroyed ())
		1012	{
		1013	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1014	head->destroy ();
		1015	return;
		1016	}
		1017
966	destroy_inv (false);	1018	destroy_inv (false);
967		1019
968	if (is_head ())	1020	if (is_head ())
969	if (sound_destroy)	1021	if (sound_destroy)
970	play_sound (sound_destroy);	1022	play_sound (sound_destroy);
971	else if (flag [FLAG_MONSTER])	1023	else if (flag [FLAG_MONSTER])
972	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism	1024	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
973		1025
974	attachable::destroy ();	1026	attachable::destroy ();
975	}
976
977	/*
978	* sub_weight() recursively (outwards) subtracts a number from the
979	* weight of an object (and what is carried by it's environment(s)).
980	*/
981	void
982	sub_weight (object *op, signed long weight)
983	{
984	while (op != NULL)
985	{
986	if (op->type == CONTAINER)
987	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
988
989	op->carrying -= weight;
990	op = op->env;
991	}
992	}	1027	}
993		1028
994	/* op->remove ():	1029	/* op->remove ():
995	* This function removes the object op from the linked list of objects	1030	* This function removes the object op from the linked list of objects
996	* which it is currently tied to. When this function is done, the	1031	* which it is currently tied to. When this function is done, the
…		…
1002	object::do_remove ()	1037	object::do_remove ()
1003	{	1038	{
1004	object *tmp, *last = 0;	1039	object *tmp, *last = 0;
1005	object *otmp;	1040	object *otmp;
1006		1041
1007	if (QUERY_FLAG (this, FLAG_REMOVED))	1042	if (flag [FLAG_REMOVED])
1008	return;	1043	return;
1009		1044
1010	SET_FLAG (this, FLAG_REMOVED);
1011	INVOKE_OBJECT (REMOVE, this);	1045	INVOKE_OBJECT (REMOVE, this);
		1046
		1047	flag [FLAG_REMOVED] = true;
1012		1048
1013	if (more)	1049	if (more)
1014	more->remove ();	1050	more->remove ();
1015		1051
1016	/*	1052	/*
1017	* In this case, the object to be removed is in someones	1053	* In this case, the object to be removed is in someones
1018	* inventory.	1054	* inventory.
1019	*/	1055	*/
1020	if (env)	1056	if (env)
1021	{	1057	{
1022	if (nrof)	1058	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1023	sub_weight (env, weight * nrof);	1059	if (object *pl = visible_to ())
1024	else	1060	esrv_del_item (pl->contr, count);
1025	sub_weight (env, weight + carrying);	1061	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1062
		1063	adjust_weight (env, -total_weight ());
		1064
		1065	object *pl = in_player ();
		1066
		1067	/* we set up values so that it could be inserted into
		1068	* the map, but we don't actually do that - it is up
		1069	* to the caller to decide what we want to do.
		1070	*/
		1071	map = env->map;
		1072	x = env->x;
		1073	y = env->y;
		1074
		1075	// make sure cmov optimisation is applicable
		1076	*(above ? &above->below : &env->inv) = below;
		1077	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1078
		1079	above = 0;
		1080	below = 0;
		1081	env = 0;
1026		1082
1027	/* NO_FIX_PLAYER is set when a great many changes are being	1083	/* NO_FIX_PLAYER is set when a great many changes are being
1028	* made to players inventory. If set, avoiding the call	1084	* made to players inventory. If set, avoiding the call
1029	* to save cpu time.	1085	* to save cpu time.
1030	*/	1086	*/
1031	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1087	if (pl)
		1088	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1089	{
1032	otmp->update_stats ();	1090	pl->update_stats ();
1033		1091
1034	if (above)	1092	if (glow_radius && pl->is_on_map ())
1035	above->below = below;	1093	update_all_los (pl->map, pl->x, pl->y);
1036	else	1094	}
1037	env->inv = below;
1038
1039	if (below)
1040	below->above = above;
1041
1042	/* we set up values so that it could be inserted into
1043	* the map, but we don't actually do that - it is up
1044	* to the caller to decide what we want to do.
1045	*/
1046	x = env->x, y = env->y;
1047	map = env->map;
1048	above = 0, below = 0;
1049	env = 0;
1050	}	1095	}
1051	else if (map)	1096	else if (map)
1052	{	1097	{
1053	if (type == PLAYER)
1054	{
1055	// leaving a spot always closes any open container on the ground
1056	if (container && !container->env)
1057	// this causes spurious floorbox updates, but it ensures
1058	// that the CLOSE event is being sent.
1059	close_container ();
1060
1061	--map->players;
1062	map->touch ();
1063	}
1064
1065	map->dirty = true;	1098	map->dirty = true;
1066	mapspace &ms = this->ms ();	1099	mapspace &ms = this->ms ();
1067		1100
		1101	if (object *pl = ms.player ())
		1102	{
		1103	if (is_player ())
		1104	{
		1105	if (!flag [FLAG_WIZPASS])
		1106	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1107
		1108	// leaving a spot always closes any open container on the ground
		1109	if (container && !container->env)
		1110	// this causes spurious floorbox updates, but it ensures
		1111	// that the CLOSE event is being sent.
		1112	close_container ();
		1113
		1114	--map->players;
		1115	map->touch ();
		1116	}
		1117	else if (pl->container == this)
		1118	{
		1119	// removing a container should close it
		1120	close_container ();
		1121	}
		1122
		1123	esrv_del_item (pl->contr, count);
		1124	}
		1125
1068	/* link the object above us */	1126	/* link the object above us */
1069	if (above)	1127	// re-link, make sure compiler can easily use cmove
1070	above->below = below;	1128	*(above ? &above->below : &ms.top) = below;
1071	else	1129	*(below ? &below->above : &ms.bot) = above;
1072	ms.top = below; /* we were top, set new top */
1073
1074	/* Relink the object below us, if there is one */
1075	if (below)
1076	below->above = above;
1077	else
1078	{
1079	/* Nothing below, which means we need to relink map object for this space
1080	* use translated coordinates in case some oddness with map tiling is
1081	* evident
1082	*/
1083	if (GET_MAP_OB (map, x, y) != this)
1084	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1085
1086	ms.bot = above; /* goes on above it. */
1087	}
1088		1130
1089	above = 0;	1131	above = 0;
1090	below = 0;	1132	below = 0;
		1133
		1134	ms.invalidate ();
1091		1135
1092	if (map->in_memory == MAP_SAVING)	1136	if (map->in_memory == MAP_SAVING)
1093	return;	1137	return;
1094		1138
1095	int check_walk_off = !flag [FLAG_NO_APPLY];	1139	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1101	* removed (most likely destroyed), update the player view	1145	* removed (most likely destroyed), update the player view
1102	* appropriately.	1146	* appropriately.
1103	*/	1147	*/
1104	pl->close_container ();	1148	pl->close_container ();
1105		1149
		1150	//TODO: the floorbox prev/next might need updating
		1151	//esrv_del_item (pl->contr, count);
		1152	//TODO: update floorbox to preserve ordering
		1153	if (pl->contr->ns)
1106	pl->contr->ns->floorbox_update ();	1154	pl->contr->ns->floorbox_update ();
1107	}	1155	}
1108		1156
1109	for (tmp = ms.bot; tmp; tmp = tmp->above)	1157	for (tmp = ms.bot; tmp; tmp = tmp->above)
1110	{	1158	{
1111	/* No point updating the players look faces if he is the object	1159	/* No point updating the players look faces if he is the object
…		…
1124	}	1172	}
1125		1173
1126	last = tmp;	1174	last = tmp;
1127	}	1175	}
1128		1176
1129	/* last == NULL if there are no objects on this space */	1177	if (affects_los ())
1130	//TODO: this makes little sense, why only update the topmost object?
1131	if (!last)
1132	map->at (x, y).flags_ = 0;
1133	else
1134	update_object (last, UP_OBJ_REMOVE);
1135
1136	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1137	update_all_los (map, x, y);	1178	update_all_los (map, x, y);
1138	}	1179	}
1139	}	1180	}
1140		1181
1141	/*	1182	/*
…		…
1155	if (!top)	1196	if (!top)
1156	for (top = op; top && top->above; top = top->above)	1197	for (top = op; top && top->above; top = top->above)
1157	;	1198	;
1158		1199
1159	for (; top; top = top->below)	1200	for (; top; top = top->below)
1160	{
1161	if (top == op)
1162	continue;
1163
1164	if (object::can_merge (op, top))	1201	if (object::can_merge (op, top))
1165	{	1202	{
1166	top->nrof += op->nrof;	1203	top->nrof += op->nrof;
1167		1204
1168	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1205	if (object *pl = top->visible_to ())
1169	op->weight = 0; /* Don't want any adjustements now */	1206	esrv_update_item (UPD_NROF, pl, top);
		1207
		1208	op->weight = 0; // cancel the addition above
		1209	op->carrying = 0; // must be 0 already
		1210
1170	op->destroy ();	1211	op->destroy ();
		1212
1171	return top;	1213	return top;
1172	}	1214	}
1173	}
1174		1215
1175	return 0;	1216	return 0;
1176	}	1217	}
1177		1218
1178	void	1219	void
…		…
1203	* job preparing multi-part monsters.	1244	* job preparing multi-part monsters.
1204	*/	1245	*/
1205	object *	1246	object *
1206	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1247	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1207	{	1248	{
		1249	op->remove ();
		1250
1208	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1251	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1209	{	1252	{
1210	tmp->x = x + tmp->arch->x;	1253	tmp->x = x + tmp->arch->x;
1211	tmp->y = y + tmp->arch->y;	1254	tmp->y = y + tmp->arch->y;
1212	}	1255	}
…		…
1235	* just 'op' otherwise	1278	* just 'op' otherwise
1236	*/	1279	*/
1237	object *	1280	object *
1238	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1281	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1239	{	1282	{
1240	assert (!op->flag [FLAG_FREED]);
1241
1242	object *top, *floor = NULL;
1243
1244	op->remove ();	1283	op->remove ();
		1284
		1285	if (m == &freed_map)//D TODO: remove soon
		1286	{//D
		1287	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1288	}//D
1245		1289
1246	/* Ideally, the caller figures this out. However, it complicates a lot	1290	/* Ideally, the caller figures this out. However, it complicates a lot
1247	* of areas of callers (eg, anything that uses find_free_spot would now	1291	* of areas of callers (eg, anything that uses find_free_spot would now
1248	* need extra work	1292	* need extra work
1249	*/	1293	*/
		1294	maptile *newmap = m;
1250	if (!xy_normalise (m, op->x, op->y))	1295	if (!xy_normalise (newmap, op->x, op->y))
1251	{	1296	{
1252	op->destroy ();	1297	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1253	return 0;	1298	return 0;
1254	}	1299	}
1255		1300
1256	if (object *more = op->more)	1301	if (object *more = op->more)
1257	if (!insert_ob_in_map (more, m, originator, flag))	1302	if (!insert_ob_in_map (more, m, originator, flag))
1258	return 0;	1303	return 0;
1259		1304
1260	CLEAR_FLAG (op, FLAG_REMOVED);	1305	op->flag [FLAG_REMOVED] = false;
1261		1306	op->env = 0;
1262	op->map = m;	1307	op->map = newmap;
		1308
1263	mapspace &ms = op->ms ();	1309	mapspace &ms = op->ms ();
1264		1310
1265	/* this has to be done after we translate the coordinates.	1311	/* this has to be done after we translate the coordinates.
1266	*/	1312	*/
1267	if (op->nrof && !(flag & INS_NO_MERGE))	1313	if (op->nrof && !(flag & INS_NO_MERGE))
1268	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1314	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1269	if (object::can_merge (op, tmp))	1315	if (object::can_merge (op, tmp))
1270	{	1316	{
		1317	// TODO: we actually want to update tmp, not op,
		1318	// but some caller surely breaks when we return tmp
		1319	// from here :/
1271	op->nrof += tmp->nrof;	1320	op->nrof += tmp->nrof;
1272	tmp->destroy ();	1321	tmp->destroy ();
1273	}	1322	}
1274		1323
1275	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1324	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
…		…
1284	{	1333	{
1285	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1334	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1286	abort ();	1335	abort ();
1287	}	1336	}
1288		1337
		1338	if (!originator->is_on_map ())
		1339	{
		1340	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1341	op->debug_desc (), originator->debug_desc ());
		1342	abort ();
		1343	}
		1344
1289	op->above = originator;	1345	op->above = originator;
1290	op->below = originator->below;	1346	op->below = originator->below;
1291
1292	if (op->below)
1293	op->below->above = op;
1294	else
1295	ms.bot = op;
1296
1297	/* since *below* originator, no need to update top */
1298	originator->below = op;	1347	originator->below = op;
		1348
		1349	*(op->below ? &op->below->above : &ms.bot) = op;
1299	}	1350	}
1300	else	1351	else
1301	{	1352	{
1302	top = ms.bot;	1353	object *floor = 0;
		1354	object *top = ms.top;
1303		1355
1304	/* If there are other objects, then */	1356	/* If there are other objects, then */
1305	if (top)	1357	if (top)
1306	{	1358	{
1307	object *last = 0;
1308
1309	/*	1359	/*
1310	* If there are multiple objects on this space, we do some trickier handling.	1360	* If there are multiple objects on this space, we do some trickier handling.
1311	* We've already dealt with merging if appropriate.	1361	* We've already dealt with merging if appropriate.
1312	* Generally, we want to put the new object on top. But if	1362	* Generally, we want to put the new object on top. But if
1313	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1363	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1316	* once we get to them. This reduces the need to traverse over all of	1366	* once we get to them. This reduces the need to traverse over all of
1317	* them when adding another one - this saves quite a bit of cpu time	1367	* them when adding another one - this saves quite a bit of cpu time
1318	* when lots of spells are cast in one area. Currently, it is presumed	1368	* when lots of spells are cast in one area. Currently, it is presumed
1319	* that flying non pickable objects are spell objects.	1369	* that flying non pickable objects are spell objects.
1320	*/	1370	*/
1321	for (top = ms.bot; top; top = top->above)	1371	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322	{	1372	{
1323	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1373	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1324	floor = top;	1374	floor = tmp;
1325		1375
1326	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1376	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1327	{	1377	{
1328	/* We insert above top, so we want this object below this */	1378	/* We insert above top, so we want this object below this */
1329	top = top->below;	1379	top = tmp->below;
1330	break;	1380	break;
1331	}	1381	}
1332		1382
1333	last = top;	1383	top = tmp;
1334	}	1384	}
1335
1336	/* Don't want top to be NULL, so set it to the last valid object */
1337	top = last;
1338		1385
1339	/* We let update_position deal with figuring out what the space	1386	/* We let update_position deal with figuring out what the space
1340	* looks like instead of lots of conditions here.	1387	* looks like instead of lots of conditions here.
1341	* makes things faster, and effectively the same result.	1388	* makes things faster, and effectively the same result.
1342	*/	1389	*/
…		…
1349	*/	1396	*/
1350	if (!(flag & INS_ON_TOP)	1397	if (!(flag & INS_ON_TOP)
1351	&& ms.flags () & P_BLOCKSVIEW	1398	&& ms.flags () & P_BLOCKSVIEW
1352	&& (op->face && !faces [op->face].visibility))	1399	&& (op->face && !faces [op->face].visibility))
1353	{	1400	{
		1401	object *last;
		1402
1354	for (last = top; last != floor; last = last->below)	1403	for (last = top; last != floor; last = last->below)
1355	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1404	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1356	break;	1405	break;
1357		1406
1358	/* Check to see if we found the object that blocks view,	1407	/* Check to see if we found the object that blocks view,
…		…
1366	} /* If objects on this space */	1415	} /* If objects on this space */
1367		1416
1368	if (flag & INS_ABOVE_FLOOR_ONLY)	1417	if (flag & INS_ABOVE_FLOOR_ONLY)
1369	top = floor;	1418	top = floor;
1370		1419
1371	/* Top is the object that our object (op) is going to get inserted above.	1420	// insert object above top, or bottom-most if top = 0
1372	*/
1373
1374	/* First object on this space */
1375	if (!top)	1421	if (!top)
1376	{	1422	{
		1423	op->below = 0;
1377	op->above = ms.bot;	1424	op->above = ms.bot;
1378
1379	if (op->above)
1380	op->above->below = op;
1381
1382	op->below = 0;
1383	ms.bot = op;	1425	ms.bot = op;
		1426
		1427	*(op->above ? &op->above->below : &ms.top) = op;
1384	}	1428	}
1385	else	1429	else
1386	{ /* get inserted into the stack above top */	1430	{
1387	op->above = top->above;	1431	op->above = top->above;
1388
1389	if (op->above)
1390	op->above->below = op;	1432	top->above = op;
1391		1433
1392	op->below = top;	1434	op->below = top;
1393	top->above = op;	1435	*(op->above ? &op->above->below : &ms.top) = op;
1394	}	1436	}
		1437	}
1395		1438
1396	if (!op->above)	1439	if (op->is_player ())
1397	ms.top = op;
1398	} /* else not INS_BELOW_ORIGINATOR */
1399
1400	if (op->type == PLAYER)
1401	{	1440	{
1402	op->contr->do_los = 1;	1441	op->contr->do_los = 1;
1403	++op->map->players;	1442	++op->map->players;
1404	op->map->touch ();	1443	op->map->touch ();
1405	}	1444	}
1406		1445
1407	op->map->dirty = true;	1446	op->map->dirty = true;
1408		1447
1409	if (object *pl = ms.player ())	1448	if (object *pl = ms.player ())
		1449	//TODO: the floorbox prev/next might need updating
		1450	//esrv_send_item (pl, op);
		1451	//TODO: update floorbox to preserve ordering
		1452	if (pl->contr->ns)
1410	pl->contr->ns->floorbox_update ();	1453	pl->contr->ns->floorbox_update ();
1411		1454
1412	/* If this object glows, it may affect lighting conditions that are	1455	/* If this object glows, it may affect lighting conditions that are
1413	* visible to others on this map. But update_all_los is really	1456	* visible to others on this map. But update_all_los is really
1414	* an inefficient way to do this, as it means los for all players	1457	* an inefficient way to do this, as it means los for all players
1415	* on the map will get recalculated. The players could very well	1458	* on the map will get recalculated. The players could very well
1416	* be far away from this change and not affected in any way -	1459	* be far away from this change and not affected in any way -
1417	* this should get redone to only look for players within range,	1460	* this should get redone to only look for players within range,
1418	* or just updating the P_UPTODATE for spaces within this area	1461	* or just updating the P_UPTODATE for spaces within this area
1419	* of effect may be sufficient.	1462	* of effect may be sufficient.
1420	*/	1463	*/
1421	if (op->map->darkness && (op->glow_radius != 0))	1464	if (op->affects_los ())
		1465	{
		1466	op->ms ().invalidate ();
1422	update_all_los (op->map, op->x, op->y);	1467	update_all_los (op->map, op->x, op->y);
		1468	}
1423		1469
1424	/* updates flags (blocked, alive, no magic, etc) for this map space */	1470	/* updates flags (blocked, alive, no magic, etc) for this map space */
1425	update_object (op, UP_OBJ_INSERT);	1471	update_object (op, UP_OBJ_INSERT);
1426		1472
1427	INVOKE_OBJECT (INSERT, op);	1473	INVOKE_OBJECT (INSERT, op);
…		…
1434	* blocked() and wall() work properly), and these flags are updated by	1480	* blocked() and wall() work properly), and these flags are updated by
1435	* update_object().	1481	* update_object().
1436	*/	1482	*/
1437		1483
1438	/* if this is not the head or flag has been passed, don't check walk on status */	1484	/* if this is not the head or flag has been passed, don't check walk on status */
1439	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1485	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1440	{	1486	{
1441	if (check_move_on (op, originator))	1487	if (check_move_on (op, originator))
1442	return 0;	1488	return 0;
1443		1489
1444	/* If we are a multi part object, lets work our way through the check	1490	/* If we are a multi part object, lets work our way through the check
…		…
1455	/* this function inserts an object in the map, but if it	1501	/* this function inserts an object in the map, but if it
1456	* finds an object of its own type, it'll remove that one first.	1502	* finds an object of its own type, it'll remove that one first.
1457	* op is the object to insert it under: supplies x and the map.	1503	* op is the object to insert it under: supplies x and the map.
1458	*/	1504	*/
1459	void	1505	void
1460	replace_insert_ob_in_map (const char *arch_string, object *op)	1506	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1461	{	1507	{
1462	object *tmp, *tmp1;
1463
1464	/* first search for itself and remove any old instances */	1508	/* first search for itself and remove any old instances */
1465		1509
1466	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)	1510	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1467	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1511	if (tmp->arch->archname == archname) /* same archetype */
1468	tmp->destroy ();	1512	tmp->destroy ();
1469		1513
1470	tmp1 = arch_to_object (archetype::find (arch_string));	1514	object *tmp = arch_to_object (archetype::find (archname));
1471		1515
1472	tmp1->x = op->x;	1516	tmp->x = op->x;
1473	tmp1->y = op->y;	1517	tmp->y = op->y;
		1518
1474	insert_ob_in_map (tmp1, op->map, op, 0);	1519	insert_ob_in_map (tmp, op->map, op, 0);
1475	}	1520	}
1476		1521
1477	object *	1522	object *
1478	object::insert_at (object *where, object *originator, int flags)	1523	object::insert_at (object *where, object *originator, int flags)
1479	{	1524	{
		1525	if (where->env)
		1526	return where->env->insert (this);
		1527	else
1480	return where->map->insert (this, where->x, where->y, originator, flags);	1528	return where->map->insert (this, where->x, where->y, originator, flags);
1481	}	1529	}
1482		1530
1483	/*	1531	/*
1484	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1485	* is returned contains nr objects, and the remaining parts contains
1486	* the rest (or is removed and freed if that number is 0).
1487	* On failure, NULL is returned, and the reason put into the
1488	* global static errmsg array.
1489	*/
1490	object *
1491	get_split_ob (object *orig_ob, uint32 nr)
1492	{
1493	object *newob;
1494	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1495
1496	if (orig_ob->nrof < nr)
1497	{
1498	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1499	return NULL;
1500	}
1501
1502	newob = object_create_clone (orig_ob);
1503
1504	if ((orig_ob->nrof -= nr) < 1)
1505	orig_ob->destroy (1);
1506	else if (!is_removed)
1507	{
1508	if (orig_ob->env != NULL)
1509	sub_weight (orig_ob->env, orig_ob->weight * nr);
1510	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1511	{
1512	strcpy (errmsg, "Tried to split object whose map is not in memory.");
1513	LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1514	return NULL;
1515	}
1516	}
1517
1518	newob->nrof = nr;
1519
1520	return newob;
1521	}
1522
1523	/*
1524	* decrease_ob_nr(object, number) decreases a specified number from	1532	* decrease(object, number) decreases a specified number from
1525	* the amount of an object. If the amount reaches 0, the object	1533	* the amount of an object. If the amount reaches 0, the object
1526	* is subsequently removed and freed.	1534	* is subsequently removed and freed.
1527	*	1535	*
1528	* Return value: 'op' if something is left, NULL if the amount reached 0	1536	* Return value: 'op' if something is left, NULL if the amount reached 0
1529	*/	1537	*/
		1538	bool
		1539	object::decrease (sint32 nr)
		1540	{
		1541	if (!nr)
		1542	return true;
		1543
		1544	nr = min (nr, nrof);
		1545
		1546	if (nrof > nr)
		1547	{
		1548	nrof -= nr;
		1549	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
		1550
		1551	if (object *pl = visible_to ())
		1552	esrv_update_item (UPD_NROF, pl, this);
		1553
		1554	return true;
		1555	}
		1556	else
		1557	{
		1558	destroy ();
		1559	return false;
		1560	}
		1561	}
		1562
		1563	/*
		1564	* split(ob,nr) splits up ob into two parts. The part which
		1565	* is returned contains nr objects, and the remaining parts contains
		1566	* the rest (or is removed and returned if that number is 0).
		1567	* On failure, NULL is returned.
		1568	*/
1530	object *	1569	object *
1531	decrease_ob_nr (object *op, uint32 i)	1570	object::split (sint32 nr)
1532	{	1571	{
1533	object *tmp;	1572	int have = number_of ();
1534		1573
1535	if (i == 0) /* objects with op->nrof require this check */	1574	if (have < nr)
1536	return op;	1575	return 0;
1537		1576	else if (have == nr)
1538	if (i > op->nrof)
1539	i = op->nrof;
1540
1541	if (QUERY_FLAG (op, FLAG_REMOVED))
1542	op->nrof -= i;
1543	else if (op->env)
1544	{	1577	{
1545	/* is this object in the players inventory, or sub container
1546	* therein?
1547	*/
1548	tmp = op->in_player ();
1549	/* nope. Is this a container the player has opened?
1550	* If so, set tmp to that player.
1551	* IMO, searching through all the players will mostly
1552	* likely be quicker than following op->env to the map,
1553	* and then searching the map for a player.
1554	*/
1555	if (!tmp)
1556	for_all_players (pl)
1557	if (pl->ob->container == op->env)
1558	{
1559	tmp = pl->ob;
1560	break;
1561	}
1562
1563	if (i < op->nrof)
1564	{
1565	sub_weight (op->env, op->weight * i);
1566	op->nrof -= i;
1567	if (tmp)
1568	esrv_send_item (tmp, op);
1569	}
1570	else
1571	{
1572	op->remove ();	1578	remove ();
1573	op->nrof = 0;	1579	return this;
1574	if (tmp)
1575	esrv_del_item (tmp->contr, op->count);
1576	}
1577	}	1580	}
1578	else	1581	else
1579	{	1582	{
1580	object *above = op->above;	1583	decrease (nr);
1581		1584
1582	if (i < op->nrof)	1585	object *op = deep_clone ();
1583	op->nrof -= i;	1586	op->nrof = nr;
1584	else
1585	{
1586	op->remove ();
1587	op->nrof = 0;
1588	}
1589
1590	/* Since we just removed op, op->above is null */
1591	for (tmp = above; tmp; tmp = tmp->above)
1592	if (tmp->type == PLAYER)
1593	{
1594	if (op->nrof)
1595	esrv_send_item (tmp, op);
1596	else
1597	esrv_del_item (tmp->contr, op->count);
1598	}
1599	}
1600
1601	if (op->nrof)
1602	return op;	1587	return op;
1603	else
1604	{
1605	op->destroy ();
1606	return 0;
1607	}
1608	}
1609
1610	/*
1611	* add_weight(object, weight) adds the specified weight to an object,
1612	* and also updates how much the environment(s) is/are carrying.
1613	*/
1614	void
1615	add_weight (object *op, signed long weight)
1616	{
1617	while (op != NULL)
1618	{
1619	if (op->type == CONTAINER)
1620	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1621
1622	op->carrying += weight;
1623	op = op->env;
1624	}	1588	}
1625	}	1589	}
1626		1590
1627	object *	1591	object *
1628	insert_ob_in_ob (object *op, object *where)	1592	insert_ob_in_ob (object *op, object *where)
…		…
1653	* be != op, if items are merged. -Tero	1617	* be != op, if items are merged. -Tero
1654	*/	1618	*/
1655	object *	1619	object *
1656	object::insert (object *op)	1620	object::insert (object *op)
1657	{	1621	{
1658	if (!QUERY_FLAG (op, FLAG_REMOVED))
1659	op->remove ();
1660
1661	if (op->more)	1622	if (op->more)
1662	{	1623	{
1663	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1624	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1664	return op;	1625	return op;
1665	}	1626	}
1666		1627
1667	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1628	op->remove ();
1668	CLEAR_FLAG (op, FLAG_REMOVED);	1629
		1630	op->flag [FLAG_OBJ_ORIGINAL] = 0;
1669		1631
1670	if (op->nrof)	1632	if (op->nrof)
1671	{
1672	for (object *tmp = inv; tmp; tmp = tmp->below)	1633	for (object *tmp = inv; tmp; tmp = tmp->below)
1673	if (object::can_merge (tmp, op))	1634	if (object::can_merge (tmp, op))
1674	{	1635	{
1675	/* return the original object and remove inserted object	1636	/* return the original object and remove inserted object
1676	(client needs the original object) */	1637	(client needs the original object) */
1677	tmp->nrof += op->nrof;	1638	tmp->nrof += op->nrof;
1678	/* Weight handling gets pretty funky. Since we are adding to	1639
1679	* tmp->nrof, we need to increase the weight.	1640	if (object *pl = tmp->visible_to ())
1680	*/	1641	esrv_update_item (UPD_NROF, pl, tmp);
		1642
1681	add_weight (this, op->weight * op->nrof);	1643	adjust_weight (this, op->total_weight ());
1682	SET_FLAG (op, FLAG_REMOVED);	1644
1683	op->destroy (); /* free the inserted object */	1645	op->destroy ();
1684	op = tmp;	1646	op = tmp;
1685	op->remove (); /* and fix old object's links */	1647	goto inserted;
1686	CLEAR_FLAG (op, FLAG_REMOVED);
1687	break;
1688	}	1648	}
1689		1649
1690	/* I assume combined objects have no inventory
1691	* We add the weight - this object could have just been removed
1692	* (if it was possible to merge). calling remove_ob will subtract
1693	* the weight, so we need to add it in again, since we actually do
1694	* the linking below
1695	*/
1696	add_weight (this, op->weight * op->nrof);
1697	}
1698	else
1699	add_weight (this, (op->weight + op->carrying));
1700
1701	if (object *otmp = this->in_player ())
1702	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1703	otmp->update_stats ();
1704
1705	op->owner = 0; // its his/hers now. period.	1650	op->owner = 0; // it's his/hers now. period.
1706	op->map = 0;	1651	op->map = 0;
		1652	op->x = 0;
		1653	op->y = 0;
		1654
		1655	op->above = 0;
		1656	op->below = inv;
1707	op->env = this;	1657	op->env = this;
1708	op->above = 0;
1709	op->below = 0;
1710	op->x = op->y = 0;
1711		1658
		1659	if (inv)
		1660	inv->above = op;
		1661
		1662	inv = op;
		1663
		1664	op->flag [FLAG_REMOVED] = 0;
		1665
		1666	if (object *pl = op->visible_to ())
		1667	esrv_send_item (pl, op);
		1668
		1669	adjust_weight (this, op->total_weight ());
		1670
		1671	inserted:
1712	/* reset the light list and los of the players on the map */	1672	/* reset the light list and los of the players on the map */
1713	if (op->glow_radius && map)	1673	if (op->glow_radius && is_on_map ())
1714	{	1674	{
1715	#ifdef DEBUG_LIGHTS	1675	update_stats ();
1716	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1717	#endif /* DEBUG_LIGHTS */
1718	if (map->darkness)
1719	update_all_los (map, x, y);	1676	update_all_los (map, x, y);
1720	}
1721
1722	/* Client has no idea of ordering so lets not bother ordering it here.
1723	* It sure simplifies this function...
1724	*/
1725	if (!inv)
1726	inv = op;
1727	else
1728	{	1677	}
1729	op->below = inv;	1678	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1730	op->below->above = op;	1679	// if this is a player's inventory, update stats
1731	inv = op;	1680	update_stats ();
1732	}
1733		1681
1734	INVOKE_OBJECT (INSERT, this);	1682	INVOKE_OBJECT (INSERT, this);
1735		1683
1736	return op;	1684	return op;
1737	}	1685	}
…		…
1757	* on top.	1705	* on top.
1758	*/	1706	*/
1759	int	1707	int
1760	check_move_on (object *op, object *originator)	1708	check_move_on (object *op, object *originator)
1761	{	1709	{
		1710	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1711	return 0;
		1712
1762	object *tmp;	1713	object *tmp;
1763	maptile *m = op->map;	1714	maptile *m = op->map;
1764	int x = op->x, y = op->y;	1715	int x = op->x, y = op->y;
1765		1716
1766	MoveType move_on, move_slow, move_block;	1717	mapspace &ms = m->at (x, y);
1767		1718
1768	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1719	ms.update ();
1769	return 0;
1770		1720
1771	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1721	MoveType move_on = ms.move_on;
1772	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1722	MoveType move_slow = ms.move_slow;
1773	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1723	MoveType move_block = ms.move_block;
1774		1724
1775	/* if nothing on this space will slow op down or be applied,	1725	/* if nothing on this space will slow op down or be applied,
1776	* no need to do checking below. have to make sure move_type	1726	* no need to do checking below. have to make sure move_type
1777	* is set, as lots of objects don't have it set - we treat that	1727	* is set, as lots of objects don't have it set - we treat that
1778	* as walking.	1728	* as walking.
…		…
1789	return 0;	1739	return 0;
1790		1740
1791	/* The objects have to be checked from top to bottom.	1741	/* The objects have to be checked from top to bottom.
1792	* Hence, we first go to the top:	1742	* Hence, we first go to the top:
1793	*/	1743	*/
1794		1744	for (object *next, *tmp = ms.top; tmp; tmp = next)
1795	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1796	{
1797	/* Trim the search when we find the first other spell effect
1798	* this helps performance so that if a space has 50 spell objects,
1799	* we don't need to check all of them.
1800	*/
1801	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1802	break;
1803	}	1745	{
		1746	next = tmp->below;
1804		1747
1805	for (; tmp; tmp = tmp->below)
1806	{
1807	if (tmp == op)	1748	if (tmp == op)
1808	continue; /* Can't apply yourself */	1749	continue; /* Can't apply yourself */
1809		1750
1810	/* Check to see if one of the movement types should be slowed down.	1751	/* Check to see if one of the movement types should be slowed down.
1811	* Second check makes sure that the movement types not being slowed	1752	* Second check makes sure that the movement types not being slowed
…		…
1816	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1757	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1817	{	1758	{
1818	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1759	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1819	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1760	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1820	{	1761	{
1821
1822	float
1823	diff = tmp->move_slow_penalty * fabs (op->speed);	1762	float diff = tmp->move_slow_penalty * fabs (op->speed);
1824		1763
1825	if (op->type == PLAYER)	1764	if (op->is_player ())
1826	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1765	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1827	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1766	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1828	diff /= 4.0;	1767	diff /= 4.0;
1829		1768
1830	op->speed_left -= diff;	1769	op->speed_left -= diff;
1831	}	1770	}
1832	}	1771	}
…		…
1865	LOG (llevError, "Present_arch called outside map.\n");	1804	LOG (llevError, "Present_arch called outside map.\n");
1866	return NULL;	1805	return NULL;
1867	}	1806	}
1868		1807
1869	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1808	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1870	if (tmp->arch == at)	1809	if (tmp->arch->archname == at->archname)
1871	return tmp;	1810	return tmp;
1872		1811
1873	return NULL;	1812	return NULL;
1874	}	1813	}
1875		1814
…		…
1939	* The first matching object is returned, or NULL if none.	1878	* The first matching object is returned, or NULL if none.
1940	*/	1879	*/
1941	object *	1880	object *
1942	present_arch_in_ob (const archetype *at, const object *op)	1881	present_arch_in_ob (const archetype *at, const object *op)
1943	{	1882	{
1944	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1883	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1945	if (tmp->arch == at)	1884	if (tmp->arch->archname == at->archname)
1946	return tmp;	1885	return tmp;
1947		1886
1948	return NULL;	1887	return NULL;
1949	}	1888	}
1950		1889
…		…
2038	* head of the object should correspond for the entire object.	1977	* head of the object should correspond for the entire object.
2039	*/	1978	*/
2040	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1979	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2041	continue;	1980	continue;
2042		1981
2043	if (ob->blocked (m, pos.x, pos.y))	1982	if (ob->blocked (pos.m, pos.x, pos.y))
2044	continue;	1983	continue;
2045		1984
2046	altern [index++] = i;	1985	altern [index++] = i;
2047	}	1986	}
2048		1987
…		…
2116	* there is capable of.	2055	* there is capable of.
2117	*/	2056	*/
2118	int	2057	int
2119	find_dir (maptile *m, int x, int y, object *exclude)	2058	find_dir (maptile *m, int x, int y, object *exclude)
2120	{	2059	{
2121	int i, max = SIZEOFFREE, mflags;	2060	int max = SIZEOFFREE, mflags;
2122
2123	sint16 nx, ny;
2124	object *tmp;
2125	maptile *mp;
2126
2127	MoveType blocked, move_type;	2061	MoveType move_type;
2128		2062
2129	if (exclude && exclude->head_ () != exclude)	2063	if (exclude && exclude->head_ () != exclude)
2130	{	2064	{
2131	exclude = exclude->head;	2065	exclude = exclude->head;
2132	move_type = exclude->move_type;	2066	move_type = exclude->move_type;
…		…
2135	{	2069	{
2136	/* If we don't have anything, presume it can use all movement types. */	2070	/* If we don't have anything, presume it can use all movement types. */
2137	move_type = MOVE_ALL;	2071	move_type = MOVE_ALL;
2138	}	2072	}
2139		2073
2140	for (i = 1; i < max; i++)	2074	for (int i = 1; i < max; i++)
2141	{	2075	{
2142	mp = m;	2076	mapxy pos (m, x, y);
2143	nx = x + freearr_x[i];	2077	pos.move (i);
2144	ny = y + freearr_y[i];
2145		2078
2146	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2079	if (!pos.normalise ())
2147
2148	if (mflags & P_OUT_OF_MAP)
2149	max = maxfree[i];	2080	max = maxfree[i];
2150	else	2081	else
2151	{	2082	{
2152	mapspace &ms = mp->at (nx, ny);	2083	mapspace &ms = *pos;
2153		2084
2154	blocked = ms.move_block;
2155
2156	if ((move_type & blocked) == move_type)	2085	if ((move_type & ms.move_block) == move_type)
2157	max = maxfree[i];	2086	max = maxfree [i];
2158	else if (mflags & P_IS_ALIVE)	2087	else if (ms.flags () & P_IS_ALIVE)
2159	{	2088	{
2160	for (tmp = ms.bot; tmp; tmp = tmp->above)	2089	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2161	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2090	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2162	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2091	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2163	break;
2164
2165	if (tmp)
2166	return freedir[i];	2092	return freedir [i];
2167	}	2093	}
2168	}	2094	}
2169	}	2095	}
2170		2096
2171	return 0;	2097	return 0;
…		…
2246	* This basically means that if direction is 15, then it could either go	2172	* This basically means that if direction is 15, then it could either go
2247	* direction 4, 14, or 16 to get back to where we are.	2173	* direction 4, 14, or 16 to get back to where we are.
2248	* Moved from spell_util.c to object.c with the other related direction	2174	* Moved from spell_util.c to object.c with the other related direction
2249	* functions.	2175	* functions.
2250	*/	2176	*/
2251	int reduction_dir[SIZEOFFREE][3] = {	2177	const int reduction_dir[SIZEOFFREE][3] = {
2252	{0, 0, 0}, /* 0 */	2178	{0, 0, 0}, /* 0 */
2253	{0, 0, 0}, /* 1 */	2179	{0, 0, 0}, /* 1 */
2254	{0, 0, 0}, /* 2 */	2180	{0, 0, 0}, /* 2 */
2255	{0, 0, 0}, /* 3 */	2181	{0, 0, 0}, /* 3 */
2256	{0, 0, 0}, /* 4 */	2182	{0, 0, 0}, /* 4 */
…		…
2352	int	2278	int
2353	can_pick (const object *who, const object *item)	2279	can_pick (const object *who, const object *item)
2354	{	2280	{
2355	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2281	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2356	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2282	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2357	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2283	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2358	}	2284	}
2359		2285
2360	/*	2286	/*
2361	* create clone from object to another	2287	* create clone from object to another
2362	*/	2288	*/
2363	object *	2289	object *
2364	object_create_clone (object *asrc)	2290	object::deep_clone ()
2365	{	2291	{
2366	object *dst = 0, *tmp, *src, *prev, *item;	2292	assert (("deep_clone called on non-head object", is_head ()));
2367		2293
2368	if (!asrc)	2294	object *dst = clone ();
2369	return 0;
2370		2295
2371	src = asrc->head_ ();	2296	object *prev = dst;
2372
2373	prev = 0;
2374	for (object *part = src; part; part = part->more)	2297	for (object *part = this->more; part; part = part->more)
2375	{	2298	{
2376	tmp = part->clone ();	2299	object *tmp = part->clone ();
2377	tmp->x -= src->x;
2378	tmp->y -= src->y;
2379
2380	if (!part->head)
2381	{
2382	dst = tmp;
2383	tmp->head = 0;
2384	}
2385	else
2386	tmp->head = dst;	2300	tmp->head = dst;
2387
2388	tmp->more = 0;
2389
2390	if (prev)
2391	prev->more = tmp;	2301	prev->more = tmp;
2392
2393	prev = tmp;	2302	prev = tmp;
2394	}	2303	}
2395		2304
2396	for (item = src->inv; item; item = item->below)	2305	for (object *item = inv; item; item = item->below)
2397	insert_ob_in_ob (object_create_clone (item), dst);	2306	insert_ob_in_ob (item->deep_clone (), dst);
2398		2307
2399	return dst;	2308	return dst;
2400	}	2309	}
2401		2310
2402	/* This returns the first object in who's inventory that	2311	/* This returns the first object in who's inventory that
…		…
2411	return tmp;	2320	return tmp;
2412		2321
2413	return 0;	2322	return 0;
2414	}	2323	}
2415		2324
2416	/* If ob has a field named key, return the link from the list,	2325	shstr_tmp
2417	* otherwise return NULL.	2326	object::kv_get (shstr_tmp key) const
2418	*
2419	* key must be a passed in shared string - otherwise, this won't
2420	* do the desired thing.
2421	*/
2422	key_value *
2423	get_ob_key_link (const object *ob, const char *key)
2424	{	2327	{
2425	for (key_value *link = ob->key_values; link; link = link->next)	2328	for (key_value *kv = key_values; kv; kv = kv->next)
2426	if (link->key == key)	2329	if (kv->key == key)
2427	return link;
2428
2429	return 0;
2430	}
2431
2432	/*
2433	* Returns the value of op has an extra_field for key, or NULL.
2434	*
2435	* The argument doesn't need to be a shared string.
2436	*
2437	* The returned string is shared.
2438	*/
2439	const char *
2440	get_ob_key_value (const object *op, const char *const key)
2441	{
2442	key_value *link;
2443	shstr_cmp canonical_key (key);
2444
2445	if (!canonical_key)
2446	{
2447	/* 1. There being a field named key on any object
2448	* implies there'd be a shared string to find.
2449	* 2. Since there isn't, no object has this field.
2450	* 3. Therefore, *this* object doesn't have this field.
2451	*/
2452	return 0;
2453	}
2454
2455	/* This is copied from get_ob_key_link() above -
2456	* only 4 lines, and saves the function call overhead.
2457	*/
2458	for (link = op->key_values; link; link = link->next)
2459	if (link->key == canonical_key)
2460	return link->value;	2330	return kv->value;
2461		2331
2462	return 0;	2332	return shstr ();
2463	}	2333	}
2464		2334
2465	/*	2335	void
2466	* Updates the canonical_key in op to value.	2336	object::kv_set (shstr_tmp key, shstr_tmp value)
2467	*
2468	* canonical_key is a shared string (value doesn't have to be).
2469	*
2470	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2471	* keys.
2472	*
2473	* Returns TRUE on success.
2474	*/
2475	int
2476	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2477	{	2337	{
2478	key_value *field = NULL, *last = NULL;	2338	for (key_value *kv = key_values; kv; kv = kv->next)
2479		2339	if (kv->key == key)
2480	for (field = op->key_values; field != NULL; field = field->next)
2481	{
2482	if (field->key != canonical_key)
2483	{	2340	{
2484	last = field;	2341	kv->value = value;
2485	continue;	2342	return;
2486	}	2343	}
2487		2344
2488	if (value)	2345	key_value *kv = new key_value;
2489	field->value = value;	2346
2490	else	2347	kv->next = key_values;
		2348	kv->key = key;
		2349	kv->value = value;
		2350
		2351	key_values = kv;
		2352	}
		2353
		2354	void
		2355	object::kv_del (shstr_tmp key)
		2356	{
		2357	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2358	if ((*kvp)->key == key)
2491	{	2359	{
2492	/* Basically, if the archetype has this key set,	2360	key_value *kv = *kvp;
2493	* we need to store the null value so when we save	2361	*kvp = (*kvp)->next;
2494	* it, we save the empty value so that when we load,	2362	delete kv;
2495	* we get this value back again.	2363	return;
2496	*/
2497	if (get_ob_key_link (op->arch, canonical_key))
2498	field->value = 0;
2499	else
2500	{
2501	if (last)
2502	last->next = field->next;
2503	else
2504	op->key_values = field->next;
2505
2506	delete field;
2507	}
2508	}	2364	}
2509	return TRUE;
2510	}
2511	/* IF we get here, key doesn't exist */
2512
2513	/* No field, we'll have to add it. */
2514
2515	if (!add_key)
2516	return FALSE;
2517
2518	/* There isn't any good reason to store a null
2519	* value in the key/value list. If the archetype has
2520	* this key, then we should also have it, so shouldn't
2521	* be here. If user wants to store empty strings,
2522	* should pass in ""
2523	*/
2524	if (value == NULL)
2525	return TRUE;
2526
2527	field = new key_value;
2528
2529	field->key = canonical_key;
2530	field->value = value;
2531	/* Usual prepend-addition. */
2532	field->next = op->key_values;
2533	op->key_values = field;
2534
2535	return TRUE;
2536	}
2537
2538	/*
2539	* Updates the key in op to value.
2540	*
2541	* If add_key is FALSE, this will only update existing keys,
2542	* and not add new ones.
2543	* In general, should be little reason FALSE is ever passed in for add_key
2544	*
2545	* Returns TRUE on success.
2546	*/
2547	int
2548	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2549	{
2550	shstr key_ (key);
2551
2552	return set_ob_key_value_s (op, key_, value, add_key);
2553	}	2365	}
2554		2366
2555	object::depth_iterator::depth_iterator (object *container)	2367	object::depth_iterator::depth_iterator (object *container)
2556	: iterator_base (container)	2368	: iterator_base (container)
2557	{	2369	{
…		…
2607	{	2419	{
2608	char flagdesc[512];	2420	char flagdesc[512];
2609	char info2[256 * 4];	2421	char info2[256 * 4];
2610	char *p = info;	2422	char *p = info;
2611		2423
2612	p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",	2424	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2613	count, uuid.seq,	2425	count,
		2426	uuid.c_str (),
2614	&name,	2427	&name,
2615	title ? "\",title:\"" : "",	2428	title ? ",title:\"" : "",
2616	title ? (const char *)title : "",	2429	title ? (const char *)title : "",
		2430	title ? "\"" : "",
2617	flag_desc (flagdesc, 512), type);	2431	flag_desc (flagdesc, 512), type);
2618		2432
2619	if (!this->flag[FLAG_REMOVED] && env)	2433	if (!flag[FLAG_REMOVED] && env)
2620	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2434	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2621		2435
2622	if (map)	2436	if (map)
2623	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2437	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2624		2438
…		…
2654	object::open_container (object *new_container)	2468	object::open_container (object *new_container)
2655	{	2469	{
2656	if (container == new_container)	2470	if (container == new_container)
2657	return;	2471	return;
2658		2472
2659	if (object *old_container = container)	2473	object *old_container = container;
		2474
		2475	if (old_container)
2660	{	2476	{
2661	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2477	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2662	return;	2478	return;
2663		2479
2664	#if 0	2480	#if 0
…		…
2666	if (object *closer = old_container->inv)	2482	if (object *closer = old_container->inv)
2667	if (closer->type == CLOSE_CON)	2483	if (closer->type == CLOSE_CON)
2668	closer->destroy ();	2484	closer->destroy ();
2669	#endif	2485	#endif
2670		2486
		2487	// make sure the container is available
		2488	esrv_send_item (this, old_container);
		2489
2671	old_container->flag [FLAG_APPLIED] = 0;	2490	old_container->flag [FLAG_APPLIED] = false;
2672	container = 0;	2491	container = 0;
2673		2492
		2493	// client needs item update to make it work, client bug requires this to be separate
2674	esrv_update_item (UPD_FLAGS, this, old_container);	2494	esrv_update_item (UPD_FLAGS, this, old_container);
		2495
2675	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2496	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2676	play_sound (sound_find ("chest_close"));	2497	play_sound (sound_find ("chest_close"));
2677	}	2498	}
2678		2499
2679	if (new_container)	2500	if (new_container)
2680	{	2501	{
…		…
2690	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2511	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2691	new_container->insert (closer);	2512	new_container->insert (closer);
2692	}	2513	}
2693	#endif	2514	#endif
2694		2515
2695	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2516	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2696		2517
		2518	// make sure the container is available, client bug requires this to be separate
		2519	esrv_send_item (this, new_container);
		2520
2697	new_container->flag [FLAG_APPLIED] = 1;	2521	new_container->flag [FLAG_APPLIED] = true;
2698	container = new_container;	2522	container = new_container;
2699		2523
		2524	// client needs flag change
2700	esrv_update_item (UPD_FLAGS, this, new_container);	2525	esrv_update_item (UPD_FLAGS, this, new_container);
2701	esrv_send_inventory (this, new_container);	2526	esrv_send_inventory (this, new_container);
2702	play_sound (sound_find ("chest_open"));	2527	play_sound (sound_find ("chest_open"));
2703	}	2528	}
		2529	// else if (!old_container->env && contr && contr->ns)
		2530	// contr->ns->floorbox_reset ();
2704	}	2531	}
2705		2532
2706	object *	2533	object *
2707	object::force_find (const shstr name)	2534	object::force_find (shstr_tmp name)
2708	{	2535	{
2709	/* cycle through his inventory to look for the MARK we want to	2536	/* cycle through his inventory to look for the MARK we want to
2710	* place	2537	* place
2711	*/	2538	*/
2712	for (object *tmp = inv; tmp; tmp = tmp->below)	2539	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2714	return splay (tmp);	2541	return splay (tmp);
2715		2542
2716	return 0;	2543	return 0;
2717	}	2544	}
2718		2545
2719	void	2546	object *
2720	object::force_add (const shstr name, int duration)	2547	object::force_add (shstr_tmp name, int duration)
2721	{	2548	{
2722	if (object *force = force_find (name))	2549	if (object *force = force_find (name))
2723	force->destroy ();	2550	force->destroy ();
2724		2551
2725	object *force = get_archetype (FORCE_NAME);	2552	object *force = get_archetype (FORCE_NAME);
…		…
2730		2557
2731	force->set_speed (duration ? 1.f / duration : 0.f);	2558	force->set_speed (duration ? 1.f / duration : 0.f);
2732	force->flag [FLAG_IS_USED_UP] = true;	2559	force->flag [FLAG_IS_USED_UP] = true;
2733	force->flag [FLAG_APPLIED] = true;	2560	force->flag [FLAG_APPLIED] = true;
2734		2561
2735	insert (force);	2562	return insert (force);
2736	}	2563	}
2737		2564
2738	void	2565	void
2739	object::play_sound (faceidx sound) const	2566	object::play_sound (faceidx sound) const
2740	{	2567	{
2741	if (!sound)	2568	if (!sound)
2742	return;	2569	return;
2743		2570
2744	if (flag [FLAG_REMOVED])	2571	if (is_on_map ())
		2572	map->play_sound (sound, x, y);
		2573	else if (object *pl = in_player ())
		2574	pl->contr->play_sound (sound);
		2575	}
		2576
		2577	void
		2578	object::say_msg (const char *msg) const
		2579	{
		2580	if (is_on_map ())
		2581	map->say_msg (msg, x, y);
		2582	else if (object *pl = in_player ())
		2583	pl->contr->play_sound (sound);
		2584	}
		2585
		2586	void
		2587	object::make_noise ()
		2588	{
		2589	// we do not model noise in the map, so instead put
		2590	// a temporary light into the noise source
		2591	// could use the map instead, but that's less reliable for our
		2592	// goal, which is to make invisibility a bit harder to exploit
		2593
		2594	// currently only works sensibly for players
		2595	if (!is_player ())
2745	return;	2596	return;
2746		2597
2747	if (env)	2598	// find old force, or create new one
2748	{	2599	object *force = force_find (shstr_noise_force);
2749	if (object *pl = in_player ())	2600
2750	pl->contr->play_sound (sound);	2601	if (force)
2751	}	2602	force->speed_left = -1.f; // patch old speed up
2752	else	2603	else
2753	map->play_sound (sound, x, y);	2604	{
2754	}	2605	force = archetype::get (shstr_noise_force);
2755		2606
		2607	force->slaying = shstr_noise_force;
		2608	force->stats.food = 1;
		2609	force->speed_left = -1.f;
		2610
		2611	force->set_speed (1.f / 4.f);
		2612	force->flag [FLAG_IS_USED_UP] = true;
		2613	force->flag [FLAG_APPLIED] = true;
		2614
		2615	insert (force);
		2616	}
		2617	}
		2618

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines