ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.230 by root, Sun May 4 08:25:32 2008 UTC vs.
Revision 1.289 by root, Sun Oct 11 05:31:54 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
40 41
41short freearr_x[SIZEOFFREE] = { 42short freearr_x[SIZEOFFREE] = {
186 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 188 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
189 return 0; 190 return 0;
190 191
191 /* Do not merge objects if nrof would overflow. First part checks 192 /* Do not merge objects if nrof would overflow, assume nrof
192 * for unsigned overflow (2c), second part checks whether the result 193 * is always 0 .. 2**31-1 */
193 * would fit into a 32 bit signed int, which is often used to hold 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
194 * nrof values.
195 */
196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
197 return 0; 195 return 0;
198 196
199 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
200 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
201 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
206 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
207 205
208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
209 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
210 208
211 if (ob1->arch->name != ob2->arch->name 209 if (ob1->arch->archname != ob2->arch->archname
212 || ob1->name != ob2->name 210 || ob1->name != ob2->name
213 || ob1->title != ob2->title 211 || ob1->title != ob2->title
214 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
215 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
216 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
217 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
218 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
219 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
220 || ob1->value != ob2->value 218 || ob1->value != ob2->value
221 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
222 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
223 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
224 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
225 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
226 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
235 return 0; 234 return 0;
236 235
237 if ((ob1->flag ^ ob2->flag) 236 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED) 237 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED) 238 .reset (FLAG_REMOVED)
241 .any ()) 239 .any ())
242 return 0; 240 return 0;
243 241
244 /* This is really a spellbook check - we should in general 242 /* This is really a spellbook check - we should in general
326 { 324 {
327 // see if we are in a container of sorts 325 // see if we are in a container of sorts
328 if (env) 326 if (env)
329 { 327 {
330 // the player inventory itself is always visible 328 // the player inventory itself is always visible
331 if (env->type == PLAYER) 329 if (env->is_player ())
332 return env; 330 return env;
333 331
334 // else a player could have our env open 332 // else a player could have our env open
335 object *envest = env->outer_env (); 333 object *envest = env->outer_env_or_self ();
336 334
337 // the player itself is always on a map, so we will find him here 335 // the player itself is always on a map, so we will find him here
338 // even if our inv is in a player. 336 // even if our inv is in a player.
339 if (envest->is_on_map ()) 337 if (envest->is_on_map ())
340 if (object *pl = envest->ms ().player ()) 338 if (object *pl = envest->ms ().player ())
344 else 342 else
345 { 343 {
346 // maybe there is a player standing on the same mapspace 344 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player 345 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ()) 346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
349 if (!pl->container || this == pl->container) 348 || this == pl->container)
350 return pl; 349 return pl;
351 } 350 }
352 } 351 }
353 352
354 return 0; 353 return 0;
355} 354}
356 355
357// adjust weight per container type ("of holding") 356// adjust weight per container type ("of holding")
358static sint32 357static sint32
359weight_adjust (object *op, sint32 weight) 358weight_adjust_for (object *op, sint32 weight)
360{ 359{
361 return op->type == CONTAINER 360 return op->type == CONTAINER
362 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 361 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
363 : weight; 362 : weight;
364} 363}
370static void 369static void
371adjust_weight (object *op, sint32 weight) 370adjust_weight (object *op, sint32 weight)
372{ 371{
373 while (op) 372 while (op)
374 { 373 {
374 // adjust by actual difference to account for rounding errors
375 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
375 weight = weight_adjust (op, weight); 376 weight = weight_adjust_for (op, op->carrying)
377 - weight_adjust_for (op, op->carrying - weight);
376 378
377 if (!weight) 379 if (!weight)
378 return; 380 return;
379 381
380 op->carrying += weight; 382 op->carrying += weight;
403 op->update_weight (); 405 op->update_weight ();
404 406
405 sum += op->total_weight (); 407 sum += op->total_weight ();
406 } 408 }
407 409
408 sum = weight_adjust (this, sum); 410 sum = weight_adjust_for (this, sum);
409 411
410 if (sum != carrying) 412 if (sum != carrying)
411 { 413 {
412 carrying = sum; 414 carrying = sum;
413 415
427 return strdup ("[NULLOBJ]"); 429 return strdup ("[NULLOBJ]");
428 430
429 object_freezer freezer; 431 object_freezer freezer;
430 op->write (freezer); 432 op->write (freezer);
431 return freezer.as_string (); 433 return freezer.as_string ();
434}
435
436char *
437object::as_string ()
438{
439 return dump_object (this);
432} 440}
433 441
434/* 442/*
435 * get_nearest_part(multi-object, object 2) returns the part of the 443 * get_nearest_part(multi-object, object 2) returns the part of the
436 * multi-object 1 which is closest to the second object. 444 * multi-object 1 which is closest to the second object.
475 */ 483 */
476object * 484object *
477find_object_name (const char *str) 485find_object_name (const char *str)
478{ 486{
479 shstr_cmp str_ (str); 487 shstr_cmp str_ (str);
480 object *op;
481 488
489 if (str_)
482 for_all_objects (op) 490 for_all_objects (op)
483 if (op->name == str_) 491 if (op->name == str_)
484 break; 492 return op;
485 493
486 return op; 494 return 0;
487} 495}
488 496
489/* 497/*
490 * Sets the owner and sets the skill and exp pointers to owner's current 498 * Sets the owner and sets the skill and exp pointers to owner's current
491 * skill and experience objects. 499 * skill and experience objects.
553 update_stats (); 561 update_stats ();
554 562
555 new_draw_info_format (NDI_UNIQUE, 0, this, 563 new_draw_info_format (NDI_UNIQUE, 0, this,
556 "You try to balance all your items at once, " 564 "You try to balance all your items at once, "
557 "but the %s is just too much for your body. " 565 "but the %s is just too much for your body. "
558 "[You need to unapply some items first.]", &ob->name); 566 "[You need to unapply some items first - use the 'body' command to see "
567 "how many items you cna wera on a specific body part.]", &ob->name);
559 return false; 568 return false;
560 } 569 }
561 570
562 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 571 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
563 } 572 }
635 } 644 }
636 645
637 if (speed < 0) 646 if (speed < 0)
638 dst->speed_left -= rndm (); 647 dst->speed_left -= rndm ();
639 648
640 dst->set_speed (dst->speed); 649 dst->activate ();
641} 650}
642 651
643void 652void
644object::instantiate () 653object::instantiate ()
645{ 654{
757 else if (action == UP_OBJ_INSERT) 766 else if (action == UP_OBJ_INSERT)
758 { 767 {
759 // this is likely overkill, TODO: revisit (schmorp) 768 // this is likely overkill, TODO: revisit (schmorp)
760 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 769 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
761 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 770 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
762 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 771 || (op->is_player () && !(m.flags_ & P_PLAYER))
763 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 772 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
764 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 773 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
765 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 774 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
766 || (m.move_on | op->move_on ) != m.move_on 775 || (m.move_on | op->move_on ) != m.move_on
767 || (m.move_off | op->move_off ) != m.move_off 776 || (m.move_off | op->move_off ) != m.move_off
768 || (m.move_slow | op->move_slow) != m.move_slow 777 || (m.move_slow | op->move_slow) != m.move_slow
769 /* This isn't perfect, but I don't expect a lot of objects to 778 /* This isn't perfect, but I don't expect a lot of objects to
770 * to have move_allow right now. 779 * have move_allow right now.
771 */ 780 */
772 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 781 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
773 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 782 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
774 m.flags_ = 0; 783 m.invalidate ();
775 } 784 }
776 /* if the object is being removed, we can't make intelligent 785 /* if the object is being removed, we can't make intelligent
777 * decisions, because remove_ob can't really pass the object 786 * decisions, because remove_ob can't really pass the object
778 * that is being removed. 787 * that is being removed.
779 */ 788 */
780 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 789 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
781 m.flags_ = 0; 790 m.invalidate ();
782 else if (action == UP_OBJ_FACE) 791 else if (action == UP_OBJ_FACE)
783 /* Nothing to do for that case */ ; 792 /* Nothing to do for that case */ ;
784 else 793 else
785 LOG (llevError, "update_object called with invalid action: %d\n", action); 794 LOG (llevError, "update_object called with invalid action: %d\n", action);
786 795
790 799
791object::object () 800object::object ()
792{ 801{
793 SET_FLAG (this, FLAG_REMOVED); 802 SET_FLAG (this, FLAG_REMOVED);
794 803
795 expmul = 1.0; 804 //expmul = 1.0; declared const for the time being
796 face = blank_face; 805 face = blank_face;
797} 806}
798 807
799object::~object () 808object::~object ()
800{ 809{
830 /* If already on active list, don't do anything */ 839 /* If already on active list, don't do anything */
831 if (active) 840 if (active)
832 return; 841 return;
833 842
834 if (has_active_speed ()) 843 if (has_active_speed ())
844 {
845 if (flag [FLAG_FREED])
846 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
847
835 actives.insert (this); 848 actives.insert (this);
849 }
836} 850}
837 851
838void 852void
839object::activate_recursive () 853object::activate_recursive ()
840{ 854{
901 * drop on that space. 915 * drop on that space.
902 */ 916 */
903 if (!drop_to_ground 917 if (!drop_to_ground
904 || !map 918 || !map
905 || map->in_memory != MAP_ACTIVE 919 || map->in_memory != MAP_ACTIVE
906 || map->nodrop 920 || map->no_drop
907 || ms ().move_block == MOVE_ALL) 921 || ms ().move_block == MOVE_ALL)
908 { 922 {
909 while (inv) 923 while (inv)
910 {
911 inv->destroy_inv (false);
912 inv->destroy (); 924 inv->destroy ();
913 }
914 } 925 }
915 else 926 else
916 { /* Put objects in inventory onto this space */ 927 { /* Put objects in inventory onto this space */
917 while (inv) 928 while (inv)
918 { 929 {
922 || op->flag [FLAG_NO_DROP] 933 || op->flag [FLAG_NO_DROP]
923 || op->type == RUNE 934 || op->type == RUNE
924 || op->type == TRAP 935 || op->type == TRAP
925 || op->flag [FLAG_IS_A_TEMPLATE] 936 || op->flag [FLAG_IS_A_TEMPLATE]
926 || op->flag [FLAG_DESTROY_ON_DEATH]) 937 || op->flag [FLAG_DESTROY_ON_DEATH])
927 op->destroy (true); 938 op->destroy ();
928 else 939 else
929 map->insert (op, x, y); 940 map->insert (op, x, y);
930 } 941 }
931 } 942 }
932} 943}
940 951
941static struct freed_map : maptile 952static struct freed_map : maptile
942{ 953{
943 freed_map () 954 freed_map ()
944 { 955 {
945 path = "<freed objects map>"; 956 path = "<freed objects map>";
946 name = "/internal/freed_objects_map"; 957 name = "/internal/freed_objects_map";
947 width = 3; 958 width = 3;
948 height = 3; 959 height = 3;
949 nodrop = 1; 960 no_drop = 1;
961 no_reset = 1;
950 962
951 alloc (); 963 alloc ();
952 in_memory = MAP_ACTIVE; 964 in_memory = MAP_ACTIVE;
953 } 965 }
954 966
960 972
961void 973void
962object::do_destroy () 974object::do_destroy ()
963{ 975{
964 if (flag [FLAG_IS_LINKED]) 976 if (flag [FLAG_IS_LINKED])
965 remove_button_link (this); 977 remove_link ();
966 978
967 if (flag [FLAG_FRIENDLY]) 979 if (flag [FLAG_FRIENDLY])
968 remove_friendly_object (this); 980 remove_friendly_object (this);
969 981
970 remove (); 982 remove ();
995 attacked_by = 0; 1007 attacked_by = 0;
996 current_weapon = 0; 1008 current_weapon = 0;
997} 1009}
998 1010
999void 1011void
1000object::destroy (bool destroy_inventory) 1012object::destroy ()
1001{ 1013{
1002 if (destroyed ()) 1014 if (destroyed ())
1003 return; 1015 return;
1004 1016
1005 if (!is_head () && !head->destroyed ()) 1017 if (!is_head () && !head->destroyed ())
1006 { 1018 {
1007 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1019 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1008 head->destroy (destroy_inventory); 1020 head->destroy ();
1009 return; 1021 return;
1010 } 1022 }
1011 1023
1012 destroy_inv (!destroy_inventory); 1024 destroy_inv (false);
1013 1025
1014 if (is_head ()) 1026 if (is_head ())
1015 if (sound_destroy) 1027 if (sound_destroy)
1016 play_sound (sound_destroy); 1028 play_sound (sound_destroy);
1017 else if (flag [FLAG_MONSTER]) 1029 else if (flag [FLAG_MONSTER])
1054 esrv_del_item (pl->contr, count); 1066 esrv_del_item (pl->contr, count);
1055 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1067 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1056 1068
1057 adjust_weight (env, -total_weight ()); 1069 adjust_weight (env, -total_weight ());
1058 1070
1059 *(above ? &above->below : &env->inv) = below; 1071 object *pl = in_player ();
1060
1061 if (below)
1062 below->above = above;
1063 1072
1064 /* we set up values so that it could be inserted into 1073 /* we set up values so that it could be inserted into
1065 * the map, but we don't actually do that - it is up 1074 * the map, but we don't actually do that - it is up
1066 * to the caller to decide what we want to do. 1075 * to the caller to decide what we want to do.
1067 */ 1076 */
1068 map = env->map; 1077 map = env->map;
1069 x = env->x; 1078 x = env->x;
1070 y = env->y; 1079 y = env->y;
1080
1081 // make sure cmov optimisation is applicable
1082 *(above ? &above->below : &env->inv) = below;
1083 *(below ? &below->above : &above ) = above; // &above is just a dummy
1084
1071 above = 0; 1085 above = 0;
1072 below = 0; 1086 below = 0;
1073 env = 0; 1087 env = 0;
1074 1088
1075 /* NO_FIX_PLAYER is set when a great many changes are being 1089 /* NO_FIX_PLAYER is set when a great many changes are being
1076 * made to players inventory. If set, avoiding the call 1090 * made to players inventory. If set, avoiding the call
1077 * to save cpu time. 1091 * to save cpu time.
1078 */ 1092 */
1079 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1093 if (pl)
1094 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1095 {
1080 otmp->update_stats (); 1096 pl->update_stats ();
1097
1098 if (glow_radius && pl->is_on_map ())
1099 update_all_los (pl->map, pl->x, pl->y);
1100 }
1081 } 1101 }
1082 else if (map) 1102 else if (map)
1083 { 1103 {
1084 map->dirty = true; 1104 map->dirty = true;
1085 mapspace &ms = this->ms (); 1105 mapspace &ms = this->ms ();
1086 1106
1087 if (object *pl = ms.player ()) 1107 if (object *pl = ms.player ())
1088 { 1108 {
1089 if (type == PLAYER) // this == pl(!) 1109 if (is_player ())
1090 { 1110 {
1111 if (!flag [FLAG_WIZPASS])
1112 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1113
1091 // leaving a spot always closes any open container on the ground 1114 // leaving a spot always closes any open container on the ground
1092 if (container && !container->env) 1115 if (container && !container->env)
1093 // this causes spurious floorbox updates, but it ensures 1116 // this causes spurious floorbox updates, but it ensures
1094 // that the CLOSE event is being sent. 1117 // that the CLOSE event is being sent.
1095 close_container (); 1118 close_container ();
1105 1128
1106 esrv_del_item (pl->contr, count); 1129 esrv_del_item (pl->contr, count);
1107 } 1130 }
1108 1131
1109 /* link the object above us */ 1132 /* link the object above us */
1110 if (above) 1133 // re-link, make sure compiler can easily use cmove
1111 above->below = below; 1134 *(above ? &above->below : &ms.top) = below;
1112 else 1135 *(below ? &below->above : &ms.bot) = above;
1113 ms.top = below; /* we were top, set new top */
1114
1115 /* Relink the object below us, if there is one */
1116 if (below)
1117 below->above = above;
1118 else
1119 {
1120 /* Nothing below, which means we need to relink map object for this space
1121 * use translated coordinates in case some oddness with map tiling is
1122 * evident
1123 */
1124 if (GET_MAP_OB (map, x, y) != this)
1125 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1126
1127 ms.bot = above; /* goes on above it. */
1128 }
1129 1136
1130 above = 0; 1137 above = 0;
1131 below = 0; 1138 below = 0;
1139
1140 ms.invalidate ();
1132 1141
1133 if (map->in_memory == MAP_SAVING) 1142 if (map->in_memory == MAP_SAVING)
1134 return; 1143 return;
1135 1144
1136 int check_walk_off = !flag [FLAG_NO_APPLY]; 1145 int check_walk_off = !flag [FLAG_NO_APPLY];
1169 } 1178 }
1170 1179
1171 last = tmp; 1180 last = tmp;
1172 } 1181 }
1173 1182
1174 /* last == NULL if there are no objects on this space */ 1183 if (affects_los ())
1175 //TODO: this makes little sense, why only update the topmost object?
1176 if (!last)
1177 map->at (x, y).flags_ = 0;
1178 else
1179 update_object (last, UP_OBJ_REMOVE);
1180
1181 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1182 update_all_los (map, x, y); 1184 update_all_los (map, x, y);
1183 } 1185 }
1184} 1186}
1185 1187
1186/* 1188/*
1210 esrv_update_item (UPD_NROF, pl, top); 1212 esrv_update_item (UPD_NROF, pl, top);
1211 1213
1212 op->weight = 0; // cancel the addition above 1214 op->weight = 0; // cancel the addition above
1213 op->carrying = 0; // must be 0 already 1215 op->carrying = 0; // must be 0 already
1214 1216
1215 op->destroy (1); 1217 op->destroy ();
1216 1218
1217 return top; 1219 return top;
1218 } 1220 }
1219 1221
1220 return 0; 1222 return 0;
1248 * job preparing multi-part monsters. 1250 * job preparing multi-part monsters.
1249 */ 1251 */
1250object * 1252object *
1251insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1253insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1252{ 1254{
1255 op->remove ();
1256
1253 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1257 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1254 { 1258 {
1255 tmp->x = x + tmp->arch->x; 1259 tmp->x = x + tmp->arch->x;
1256 tmp->y = y + tmp->arch->y; 1260 tmp->y = y + tmp->arch->y;
1257 } 1261 }
1280 * just 'op' otherwise 1284 * just 'op' otherwise
1281 */ 1285 */
1282object * 1286object *
1283insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1287insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1284{ 1288{
1285 assert (!op->flag [FLAG_FREED]);
1286
1287 op->remove (); 1289 op->remove ();
1290
1291 if (m == &freed_map)//D TODO: remove soon
1292 {//D
1293 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1294 }//D
1288 1295
1289 /* Ideally, the caller figures this out. However, it complicates a lot 1296 /* Ideally, the caller figures this out. However, it complicates a lot
1290 * of areas of callers (eg, anything that uses find_free_spot would now 1297 * of areas of callers (eg, anything that uses find_free_spot would now
1291 * need extra work 1298 * need extra work
1292 */ 1299 */
1300 maptile *newmap = m;
1293 if (!xy_normalise (m, op->x, op->y)) 1301 if (!xy_normalise (newmap, op->x, op->y))
1294 { 1302 {
1295 op->destroy (1); 1303 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1296 return 0; 1304 return 0;
1297 } 1305 }
1298 1306
1299 if (object *more = op->more) 1307 if (object *more = op->more)
1300 if (!insert_ob_in_map (more, m, originator, flag)) 1308 if (!insert_ob_in_map (more, m, originator, flag))
1301 return 0; 1309 return 0;
1302 1310
1303 CLEAR_FLAG (op, FLAG_REMOVED); 1311 op->flag [FLAG_REMOVED] = false;
1304 1312 op->env = 0;
1305 op->map = m; 1313 op->map = newmap;
1314
1306 mapspace &ms = op->ms (); 1315 mapspace &ms = op->ms ();
1307 1316
1308 /* this has to be done after we translate the coordinates. 1317 /* this has to be done after we translate the coordinates.
1309 */ 1318 */
1310 if (op->nrof && !(flag & INS_NO_MERGE)) 1319 if (op->nrof && !(flag & INS_NO_MERGE))
1311 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1320 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1312 if (object::can_merge (op, tmp)) 1321 if (object::can_merge (op, tmp))
1313 { 1322 {
1314 // TODO: we atcually want to update tmp, not op, 1323 // TODO: we actually want to update tmp, not op,
1315 // but some caller surely breaks when we return tmp 1324 // but some caller surely breaks when we return tmp
1316 // from here :/ 1325 // from here :/
1317 op->nrof += tmp->nrof; 1326 op->nrof += tmp->nrof;
1318 tmp->destroy (1); 1327 tmp->destroy ();
1319 } 1328 }
1320 1329
1321 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1330 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1322 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1331 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1323 1332
1330 { 1339 {
1331 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1340 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1332 abort (); 1341 abort ();
1333 } 1342 }
1334 1343
1344 if (!originator->is_on_map ())
1345 {
1346 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1347 op->debug_desc (), originator->debug_desc ());
1348 abort ();
1349 }
1350
1335 op->above = originator; 1351 op->above = originator;
1336 op->below = originator->below; 1352 op->below = originator->below;
1337
1338 if (op->below)
1339 op->below->above = op;
1340 else
1341 ms.bot = op;
1342
1343 /* since *below* originator, no need to update top */
1344 originator->below = op; 1353 originator->below = op;
1354
1355 *(op->below ? &op->below->above : &ms.bot) = op;
1345 } 1356 }
1346 else 1357 else
1347 { 1358 {
1348 object *top, *floor = NULL; 1359 object *floor = 0;
1349 1360 object *top = ms.top;
1350 top = ms.bot;
1351 1361
1352 /* If there are other objects, then */ 1362 /* If there are other objects, then */
1353 if (top) 1363 if (top)
1354 { 1364 {
1355 object *last = 0;
1356
1357 /* 1365 /*
1358 * If there are multiple objects on this space, we do some trickier handling. 1366 * If there are multiple objects on this space, we do some trickier handling.
1359 * We've already dealt with merging if appropriate. 1367 * We've already dealt with merging if appropriate.
1360 * Generally, we want to put the new object on top. But if 1368 * Generally, we want to put the new object on top. But if
1361 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1369 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1364 * once we get to them. This reduces the need to traverse over all of 1372 * once we get to them. This reduces the need to traverse over all of
1365 * them when adding another one - this saves quite a bit of cpu time 1373 * them when adding another one - this saves quite a bit of cpu time
1366 * when lots of spells are cast in one area. Currently, it is presumed 1374 * when lots of spells are cast in one area. Currently, it is presumed
1367 * that flying non pickable objects are spell objects. 1375 * that flying non pickable objects are spell objects.
1368 */ 1376 */
1369 for (top = ms.bot; top; top = top->above) 1377 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1370 { 1378 {
1371 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1379 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1372 floor = top; 1380 floor = tmp;
1373 1381
1374 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1382 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1375 { 1383 {
1376 /* We insert above top, so we want this object below this */ 1384 /* We insert above top, so we want this object below this */
1377 top = top->below; 1385 top = tmp->below;
1378 break; 1386 break;
1379 } 1387 }
1380 1388
1381 last = top; 1389 top = tmp;
1382 } 1390 }
1383
1384 /* Don't want top to be NULL, so set it to the last valid object */
1385 top = last;
1386 1391
1387 /* We let update_position deal with figuring out what the space 1392 /* We let update_position deal with figuring out what the space
1388 * looks like instead of lots of conditions here. 1393 * looks like instead of lots of conditions here.
1389 * makes things faster, and effectively the same result. 1394 * makes things faster, and effectively the same result.
1390 */ 1395 */
1397 */ 1402 */
1398 if (!(flag & INS_ON_TOP) 1403 if (!(flag & INS_ON_TOP)
1399 && ms.flags () & P_BLOCKSVIEW 1404 && ms.flags () & P_BLOCKSVIEW
1400 && (op->face && !faces [op->face].visibility)) 1405 && (op->face && !faces [op->face].visibility))
1401 { 1406 {
1407 object *last;
1408
1402 for (last = top; last != floor; last = last->below) 1409 for (last = top; last != floor; last = last->below)
1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1410 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1404 break; 1411 break;
1405 1412
1406 /* Check to see if we found the object that blocks view, 1413 /* Check to see if we found the object that blocks view,
1414 } /* If objects on this space */ 1421 } /* If objects on this space */
1415 1422
1416 if (flag & INS_ABOVE_FLOOR_ONLY) 1423 if (flag & INS_ABOVE_FLOOR_ONLY)
1417 top = floor; 1424 top = floor;
1418 1425
1419 /* Top is the object that our object (op) is going to get inserted above. 1426 // insert object above top, or bottom-most if top = 0
1420 */
1421
1422 /* First object on this space */
1423 if (!top) 1427 if (!top)
1424 { 1428 {
1429 op->below = 0;
1425 op->above = ms.bot; 1430 op->above = ms.bot;
1426
1427 if (op->above)
1428 op->above->below = op;
1429
1430 op->below = 0;
1431 ms.bot = op; 1431 ms.bot = op;
1432
1433 *(op->above ? &op->above->below : &ms.top) = op;
1432 } 1434 }
1433 else 1435 else
1434 { /* get inserted into the stack above top */ 1436 {
1435 op->above = top->above; 1437 op->above = top->above;
1436
1437 if (op->above)
1438 op->above->below = op; 1438 top->above = op;
1439 1439
1440 op->below = top; 1440 op->below = top;
1441 top->above = op; 1441 *(op->above ? &op->above->below : &ms.top) = op;
1442 } 1442 }
1443 }
1443 1444
1444 if (!op->above) 1445 if (op->is_player ())
1445 ms.top = op;
1446 } /* else not INS_BELOW_ORIGINATOR */
1447
1448 if (op->type == PLAYER)
1449 { 1446 {
1450 op->contr->do_los = 1; 1447 op->contr->do_los = 1;
1451 ++op->map->players; 1448 ++op->map->players;
1452 op->map->touch (); 1449 op->map->touch ();
1453 } 1450 }
1468 * be far away from this change and not affected in any way - 1465 * be far away from this change and not affected in any way -
1469 * this should get redone to only look for players within range, 1466 * this should get redone to only look for players within range,
1470 * or just updating the P_UPTODATE for spaces within this area 1467 * or just updating the P_UPTODATE for spaces within this area
1471 * of effect may be sufficient. 1468 * of effect may be sufficient.
1472 */ 1469 */
1473 if (op->map->darkness && (op->glow_radius != 0)) 1470 if (op->affects_los ())
1471 {
1472 op->ms ().invalidate ();
1474 update_all_los (op->map, op->x, op->y); 1473 update_all_los (op->map, op->x, op->y);
1474 }
1475 1475
1476 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1476 /* updates flags (blocked, alive, no magic, etc) for this map space */
1477 update_object (op, UP_OBJ_INSERT); 1477 update_object (op, UP_OBJ_INSERT);
1478 1478
1479 INVOKE_OBJECT (INSERT, op); 1479 INVOKE_OBJECT (INSERT, op);
1486 * blocked() and wall() work properly), and these flags are updated by 1486 * blocked() and wall() work properly), and these flags are updated by
1487 * update_object(). 1487 * update_object().
1488 */ 1488 */
1489 1489
1490 /* if this is not the head or flag has been passed, don't check walk on status */ 1490 /* if this is not the head or flag has been passed, don't check walk on status */
1491 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1491 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1492 { 1492 {
1493 if (check_move_on (op, originator)) 1493 if (check_move_on (op, originator))
1494 return 0; 1494 return 0;
1495 1495
1496 /* If we are a multi part object, lets work our way through the check 1496 /* If we are a multi part object, lets work our way through the check
1507/* this function inserts an object in the map, but if it 1507/* this function inserts an object in the map, but if it
1508 * finds an object of its own type, it'll remove that one first. 1508 * finds an object of its own type, it'll remove that one first.
1509 * op is the object to insert it under: supplies x and the map. 1509 * op is the object to insert it under: supplies x and the map.
1510 */ 1510 */
1511void 1511void
1512replace_insert_ob_in_map (const char *arch_string, object *op) 1512replace_insert_ob_in_map (shstr_tmp archname, object *op)
1513{ 1513{
1514 /* first search for itself and remove any old instances */ 1514 /* first search for itself and remove any old instances */
1515 1515
1516 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1516 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1517 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1517 if (tmp->arch->archname == archname) /* same archetype */
1518 tmp->destroy (1); 1518 tmp->destroy ();
1519 1519
1520 object *tmp = arch_to_object (archetype::find (arch_string)); 1520 object *tmp = arch_to_object (archetype::find (archname));
1521 1521
1522 tmp->x = op->x; 1522 tmp->x = op->x;
1523 tmp->y = op->y; 1523 tmp->y = op->y;
1524 1524
1525 insert_ob_in_map (tmp, op->map, op, 0); 1525 insert_ob_in_map (tmp, op->map, op, 0);
1547 if (!nr) 1547 if (!nr)
1548 return true; 1548 return true;
1549 1549
1550 nr = min (nr, nrof); 1550 nr = min (nr, nrof);
1551 1551
1552 if (nrof > nr)
1553 {
1552 nrof -= nr; 1554 nrof -= nr;
1553
1554 if (nrof)
1555 {
1556 adjust_weight (env, -weight * nr); // carrying == 0 1555 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1557 1556
1558 if (object *pl = visible_to ()) 1557 if (object *pl = visible_to ())
1559 esrv_update_item (UPD_NROF, pl, this); 1558 esrv_update_item (UPD_NROF, pl, this);
1560 1559
1561 return true; 1560 return true;
1562 } 1561 }
1563 else 1562 else
1564 { 1563 {
1565 destroy (1); 1564 destroy ();
1566 return false; 1565 return false;
1567 } 1566 }
1568} 1567}
1569 1568
1570/* 1569/*
1647 if (object *pl = tmp->visible_to ()) 1646 if (object *pl = tmp->visible_to ())
1648 esrv_update_item (UPD_NROF, pl, tmp); 1647 esrv_update_item (UPD_NROF, pl, tmp);
1649 1648
1650 adjust_weight (this, op->total_weight ()); 1649 adjust_weight (this, op->total_weight ());
1651 1650
1652 op->destroy (1); 1651 op->destroy ();
1653 op = tmp; 1652 op = tmp;
1654 goto inserted; 1653 goto inserted;
1655 } 1654 }
1656 1655
1657 op->owner = 0; // it's his/hers now. period. 1656 op->owner = 0; // it's his/hers now. period.
1675 1674
1676 adjust_weight (this, op->total_weight ()); 1675 adjust_weight (this, op->total_weight ());
1677 1676
1678inserted: 1677inserted:
1679 /* reset the light list and los of the players on the map */ 1678 /* reset the light list and los of the players on the map */
1680 if (op->glow_radius && map && map->darkness) 1679 if (op->glow_radius && is_on_map ())
1680 {
1681 update_stats ();
1681 update_all_los (map, x, y); 1682 update_all_los (map, x, y);
1682 1683 }
1684 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1683 // if this is a player's inventory, update stats 1685 // if this is a player's inventory, update stats
1684 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1685 update_stats (); 1686 update_stats ();
1686 1687
1687 INVOKE_OBJECT (INSERT, this); 1688 INVOKE_OBJECT (INSERT, this);
1688 1689
1689 return op; 1690 return op;
1710 * on top. 1711 * on top.
1711 */ 1712 */
1712int 1713int
1713check_move_on (object *op, object *originator) 1714check_move_on (object *op, object *originator)
1714{ 1715{
1716 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1717 return 0;
1718
1715 object *tmp; 1719 object *tmp;
1716 maptile *m = op->map; 1720 maptile *m = op->map;
1717 int x = op->x, y = op->y; 1721 int x = op->x, y = op->y;
1718 1722
1719 MoveType move_on, move_slow, move_block; 1723 mapspace &ms = m->at (x, y);
1720 1724
1721 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1725 ms.update ();
1722 return 0;
1723 1726
1724 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1727 MoveType move_on = ms.move_on;
1725 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1728 MoveType move_slow = ms.move_slow;
1726 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1729 MoveType move_block = ms.move_block;
1727 1730
1728 /* if nothing on this space will slow op down or be applied, 1731 /* if nothing on this space will slow op down or be applied,
1729 * no need to do checking below. have to make sure move_type 1732 * no need to do checking below. have to make sure move_type
1730 * is set, as lots of objects don't have it set - we treat that 1733 * is set, as lots of objects don't have it set - we treat that
1731 * as walking. 1734 * as walking.
1742 return 0; 1745 return 0;
1743 1746
1744 /* The objects have to be checked from top to bottom. 1747 /* The objects have to be checked from top to bottom.
1745 * Hence, we first go to the top: 1748 * Hence, we first go to the top:
1746 */ 1749 */
1747 1750 for (object *next, *tmp = ms.top; tmp; tmp = next)
1748 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1749 {
1750 /* Trim the search when we find the first other spell effect
1751 * this helps performance so that if a space has 50 spell objects,
1752 * we don't need to check all of them.
1753 */
1754 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1755 break;
1756 } 1751 {
1752 next = tmp->below;
1757 1753
1758 for (; tmp; tmp = tmp->below)
1759 {
1760 if (tmp == op) 1754 if (tmp == op)
1761 continue; /* Can't apply yourself */ 1755 continue; /* Can't apply yourself */
1762 1756
1763 /* Check to see if one of the movement types should be slowed down. 1757 /* Check to see if one of the movement types should be slowed down.
1764 * Second check makes sure that the movement types not being slowed 1758 * Second check makes sure that the movement types not being slowed
1769 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1763 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1770 { 1764 {
1771 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1765 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1772 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1766 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1773 { 1767 {
1774
1775 float
1776 diff = tmp->move_slow_penalty * fabs (op->speed); 1768 float diff = tmp->move_slow_penalty * fabs (op->speed);
1777 1769
1778 if (op->type == PLAYER) 1770 if (op->is_player ())
1779 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1771 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1780 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1772 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1781 diff /= 4.0; 1773 diff /= 4.0;
1782 1774
1783 op->speed_left -= diff; 1775 op->speed_left -= diff;
1784 } 1776 }
1785 } 1777 }
1818 LOG (llevError, "Present_arch called outside map.\n"); 1810 LOG (llevError, "Present_arch called outside map.\n");
1819 return NULL; 1811 return NULL;
1820 } 1812 }
1821 1813
1822 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1814 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1823 if (tmp->arch == at) 1815 if (tmp->arch->archname == at->archname)
1824 return tmp; 1816 return tmp;
1825 1817
1826 return NULL; 1818 return NULL;
1827} 1819}
1828 1820
1892 * The first matching object is returned, or NULL if none. 1884 * The first matching object is returned, or NULL if none.
1893 */ 1885 */
1894object * 1886object *
1895present_arch_in_ob (const archetype *at, const object *op) 1887present_arch_in_ob (const archetype *at, const object *op)
1896{ 1888{
1897 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1889 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1898 if (tmp->arch == at) 1890 if (tmp->arch->archname == at->archname)
1899 return tmp; 1891 return tmp;
1900 1892
1901 return NULL; 1893 return NULL;
1902} 1894}
1903 1895
1991 * head of the object should correspond for the entire object. 1983 * head of the object should correspond for the entire object.
1992 */ 1984 */
1993 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1985 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1994 continue; 1986 continue;
1995 1987
1996 if (ob->blocked (m, pos.x, pos.y)) 1988 if (ob->blocked (pos.m, pos.x, pos.y))
1997 continue; 1989 continue;
1998 1990
1999 altern [index++] = i; 1991 altern [index++] = i;
2000 } 1992 }
2001 1993
2069 * there is capable of. 2061 * there is capable of.
2070 */ 2062 */
2071int 2063int
2072find_dir (maptile *m, int x, int y, object *exclude) 2064find_dir (maptile *m, int x, int y, object *exclude)
2073{ 2065{
2074 int i, max = SIZEOFFREE, mflags; 2066 int max = SIZEOFFREE, mflags;
2075
2076 sint16 nx, ny;
2077 object *tmp;
2078 maptile *mp;
2079
2080 MoveType blocked, move_type; 2067 MoveType move_type;
2081 2068
2082 if (exclude && exclude->head_ () != exclude) 2069 if (exclude && exclude->head_ () != exclude)
2083 { 2070 {
2084 exclude = exclude->head; 2071 exclude = exclude->head;
2085 move_type = exclude->move_type; 2072 move_type = exclude->move_type;
2088 { 2075 {
2089 /* If we don't have anything, presume it can use all movement types. */ 2076 /* If we don't have anything, presume it can use all movement types. */
2090 move_type = MOVE_ALL; 2077 move_type = MOVE_ALL;
2091 } 2078 }
2092 2079
2093 for (i = 1; i < max; i++) 2080 for (int i = 1; i < max; i++)
2094 { 2081 {
2095 mp = m; 2082 mapxy pos (m, x, y);
2096 nx = x + freearr_x[i]; 2083 pos.move (i);
2097 ny = y + freearr_y[i];
2098 2084
2099 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2085 if (!pos.normalise ())
2100
2101 if (mflags & P_OUT_OF_MAP)
2102 max = maxfree[i]; 2086 max = maxfree[i];
2103 else 2087 else
2104 { 2088 {
2105 mapspace &ms = mp->at (nx, ny); 2089 mapspace &ms = *pos;
2106 2090
2107 blocked = ms.move_block;
2108
2109 if ((move_type & blocked) == move_type) 2091 if ((move_type & ms.move_block) == move_type)
2110 max = maxfree[i]; 2092 max = maxfree [i];
2111 else if (mflags & P_IS_ALIVE) 2093 else if (ms.flags () & P_IS_ALIVE)
2112 { 2094 {
2113 for (tmp = ms.bot; tmp; tmp = tmp->above) 2095 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2114 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2096 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2115 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2097 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2116 break;
2117
2118 if (tmp)
2119 return freedir[i]; 2098 return freedir [i];
2120 } 2099 }
2121 } 2100 }
2122 } 2101 }
2123 2102
2124 return 0; 2103 return 0;
2199 * This basically means that if direction is 15, then it could either go 2178 * This basically means that if direction is 15, then it could either go
2200 * direction 4, 14, or 16 to get back to where we are. 2179 * direction 4, 14, or 16 to get back to where we are.
2201 * Moved from spell_util.c to object.c with the other related direction 2180 * Moved from spell_util.c to object.c with the other related direction
2202 * functions. 2181 * functions.
2203 */ 2182 */
2204int reduction_dir[SIZEOFFREE][3] = { 2183const int reduction_dir[SIZEOFFREE][3] = {
2205 {0, 0, 0}, /* 0 */ 2184 {0, 0, 0}, /* 0 */
2206 {0, 0, 0}, /* 1 */ 2185 {0, 0, 0}, /* 1 */
2207 {0, 0, 0}, /* 2 */ 2186 {0, 0, 0}, /* 2 */
2208 {0, 0, 0}, /* 3 */ 2187 {0, 0, 0}, /* 3 */
2209 {0, 0, 0}, /* 4 */ 2188 {0, 0, 0}, /* 4 */
2305int 2284int
2306can_pick (const object *who, const object *item) 2285can_pick (const object *who, const object *item)
2307{ 2286{
2308 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2287 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2309 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2288 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2310 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2289 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2311} 2290}
2312 2291
2313/* 2292/*
2314 * create clone from object to another 2293 * create clone from object to another
2315 */ 2294 */
2347 return tmp; 2326 return tmp;
2348 2327
2349 return 0; 2328 return 0;
2350} 2329}
2351 2330
2352const shstr & 2331shstr_tmp
2353object::kv_get (const shstr &key) const 2332object::kv_get (shstr_tmp key) const
2354{ 2333{
2355 for (key_value *kv = key_values; kv; kv = kv->next) 2334 for (key_value *kv = key_values; kv; kv = kv->next)
2356 if (kv->key == key) 2335 if (kv->key == key)
2357 return kv->value; 2336 return kv->value;
2358 2337
2359 return shstr_null; 2338 return shstr ();
2360} 2339}
2361 2340
2362void 2341void
2363object::kv_set (const shstr &key, const shstr &value) 2342object::kv_set (shstr_tmp key, shstr_tmp value)
2364{ 2343{
2365 for (key_value *kv = key_values; kv; kv = kv->next) 2344 for (key_value *kv = key_values; kv; kv = kv->next)
2366 if (kv->key == key) 2345 if (kv->key == key)
2367 { 2346 {
2368 kv->value = value; 2347 kv->value = value;
2377 2356
2378 key_values = kv; 2357 key_values = kv;
2379} 2358}
2380 2359
2381void 2360void
2382object::kv_del (const shstr &key) 2361object::kv_del (shstr_tmp key)
2383{ 2362{
2384 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2363 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2385 if ((*kvp)->key == key) 2364 if ((*kvp)->key == key)
2386 { 2365 {
2387 key_value *kv = *kvp; 2366 key_value *kv = *kvp;
2446{ 2425{
2447 char flagdesc[512]; 2426 char flagdesc[512];
2448 char info2[256 * 4]; 2427 char info2[256 * 4];
2449 char *p = info; 2428 char *p = info;
2450 2429
2451 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2430 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2452 count, 2431 count,
2453 uuid.c_str (), 2432 uuid.c_str (),
2454 &name, 2433 &name,
2455 title ? "\",title:\"" : "", 2434 title ? ",title:\"" : "",
2456 title ? (const char *)title : "", 2435 title ? (const char *)title : "",
2436 title ? "\"" : "",
2457 flag_desc (flagdesc, 512), type); 2437 flag_desc (flagdesc, 512), type);
2458 2438
2459 if (!flag[FLAG_REMOVED] && env) 2439 if (!flag[FLAG_REMOVED] && env)
2460 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2440 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2461 2441
2517 container = 0; 2497 container = 0;
2518 2498
2519 // client needs item update to make it work, client bug requires this to be separate 2499 // client needs item update to make it work, client bug requires this to be separate
2520 esrv_update_item (UPD_FLAGS, this, old_container); 2500 esrv_update_item (UPD_FLAGS, this, old_container);
2521 2501
2522 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2502 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2523 play_sound (sound_find ("chest_close")); 2503 play_sound (sound_find ("chest_close"));
2524 } 2504 }
2525 2505
2526 if (new_container) 2506 if (new_container)
2527 { 2507 {
2537 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2517 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2538 new_container->insert (closer); 2518 new_container->insert (closer);
2539 } 2519 }
2540#endif 2520#endif
2541 2521
2542 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2522 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2543 2523
2544 // make sure the container is available, client bug requires this to be separate 2524 // make sure the container is available, client bug requires this to be separate
2545 esrv_send_item (this, new_container); 2525 esrv_send_item (this, new_container);
2546 2526
2547 new_container->flag [FLAG_APPLIED] = true; 2527 new_container->flag [FLAG_APPLIED] = true;
2555// else if (!old_container->env && contr && contr->ns) 2535// else if (!old_container->env && contr && contr->ns)
2556// contr->ns->floorbox_reset (); 2536// contr->ns->floorbox_reset ();
2557} 2537}
2558 2538
2559object * 2539object *
2560object::force_find (const shstr name) 2540object::force_find (shstr_tmp name)
2561{ 2541{
2562 /* cycle through his inventory to look for the MARK we want to 2542 /* cycle through his inventory to look for the MARK we want to
2563 * place 2543 * place
2564 */ 2544 */
2565 for (object *tmp = inv; tmp; tmp = tmp->below) 2545 for (object *tmp = inv; tmp; tmp = tmp->below)
2567 return splay (tmp); 2547 return splay (tmp);
2568 2548
2569 return 0; 2549 return 0;
2570} 2550}
2571 2551
2572void 2552object *
2573object::force_add (const shstr name, int duration) 2553object::force_add (shstr_tmp name, int duration)
2574{ 2554{
2575 if (object *force = force_find (name)) 2555 if (object *force = force_find (name))
2576 force->destroy (); 2556 force->destroy ();
2577 2557
2578 object *force = get_archetype (FORCE_NAME); 2558 object *force = get_archetype (FORCE_NAME);
2583 2563
2584 force->set_speed (duration ? 1.f / duration : 0.f); 2564 force->set_speed (duration ? 1.f / duration : 0.f);
2585 force->flag [FLAG_IS_USED_UP] = true; 2565 force->flag [FLAG_IS_USED_UP] = true;
2586 force->flag [FLAG_APPLIED] = true; 2566 force->flag [FLAG_APPLIED] = true;
2587 2567
2588 insert (force); 2568 return insert (force);
2589} 2569}
2590 2570
2591void 2571void
2592object::play_sound (faceidx sound) 2572object::play_sound (faceidx sound) const
2593{ 2573{
2594 if (!sound) 2574 if (!sound)
2595 return; 2575 return;
2596 2576
2597 if (flag [FLAG_REMOVED]) 2577 if (is_on_map ())
2578 map->play_sound (sound, x, y);
2579 else if (object *pl = in_player ())
2580 pl->contr->play_sound (sound);
2581}
2582
2583void
2584object::say_msg (const char *msg) const
2585{
2586 if (is_on_map ())
2587 map->say_msg (msg, x, y);
2588 else if (object *pl = in_player ())
2589 pl->contr->play_sound (sound);
2590}
2591
2592void
2593object::make_noise ()
2594{
2595 // we do not model noise in the map, so instead put
2596 // a temporary light into the noise source
2597 // could use the map instead, but that's less reliable for our
2598 // goal, which is to make invisibility a bit harder to exploit
2599
2600 // currently only works sensibly for players
2601 if (!is_player ())
2598 return; 2602 return;
2599 2603
2600 if (env) 2604 // find old force, or create new one
2601 { 2605 object *force = force_find (shstr_noise_force);
2602 if (object *pl = in_player ()) 2606
2603 pl->contr->play_sound (sound); 2607 if (force)
2604 } 2608 force->speed_left = -1.f; // patch old speed up
2605 else 2609 else
2606 map->play_sound (sound, x, y); 2610 {
2607} 2611 force = archetype::get (shstr_noise_force);
2608 2612
2613 force->slaying = shstr_noise_force;
2614 force->stats.food = 1;
2615 force->speed_left = -1.f;
2616
2617 force->set_speed (1.f / 4.f);
2618 force->flag [FLAG_IS_USED_UP] = true;
2619 force->flag [FLAG_APPLIED] = true;
2620
2621 insert (force);
2622 }
2623}
2624

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines