ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.212 by root, Mon Apr 21 23:35:24 2008 UTC vs.
Revision 1.290 by sf-marcmagus, Sun Oct 11 05:43:35 2009 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify
9	* it under the terms of the GNU General Public License as published by	9	* it under the terms of the GNU General Public License as published by
…		…
32	#include <bitset>	32	#include <bitset>
33		33
34	UUID UUID::cur;	34	UUID UUID::cur;
35	static uint64_t seq_next_save;	35	static uint64_t seq_next_save;
36	static const uint64 UUID_GAP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
37		38
38	objectvec objects;	39	objectvec objects;
39	activevec actives;	40	activevec actives;
40		41
41	short freearr_x[SIZEOFFREE] = {	42	short freearr_x[SIZEOFFREE] = {
…		…
139		140
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	142	static bool
142	compare_ob_value_lists_one (const object *wants, const object *has)	143	compare_ob_value_lists_one (const object *wants, const object *has)
143	{	144	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	145	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	146	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	147	* different structure or at least keep the lists sorted...
149	*/	148	*/
150		149
151	/* For each field in wants, */	150	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	151	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	152	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	153	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		154
169	/* If we get here, every field in wants has a matching field in has. */	155	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	156	return true;
171	}	157	}
172		158
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	159	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	160	static bool
175	compare_ob_value_lists (const object *ob1, const object *ob2)	161	compare_ob_value_lists (const object *ob1, const object *ob2)
176	{	162	{
177	/* However, there may be fields in has which aren't partnered in wants,	163	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison *twice*. :(	164	* so we need to run the comparison *twice*. :(
179	*/	165	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	166	return compare_ob_value_lists_one (ob1, ob2)
		167	&& compare_ob_value_lists_one (ob2, ob1);
181	}	168	}
182		169
183	/* Function examines the 2 objects given to it, and returns true if	170	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	171	* they can be merged together.
185	*	172	*
…		…
200	|| ob1->speed != ob2->speed	187	|| ob1->speed != ob2->speed
201	|| ob1->value != ob2->value	188	|| ob1->value != ob2->value
202	|| ob1->name != ob2->name)	189	|| ob1->name != ob2->name)
203	return 0;	190	return 0;
204		191
205	/* Do not merge objects if nrof would overflow. First part checks	192	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	193	* is always 0 .. 2**31-1 */
207	* would fit into a 32 bit signed int, which is often used to hold	194	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	195	return 0;
212		196
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	197	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	198	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	199	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	204	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		205
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	206	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	207	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		208
225	if (ob1->arch->name != ob2->arch->name	209	if (ob1->arch->archname != ob2->arch->archname
226	|| ob1->name != ob2->name	210	|| ob1->name != ob2->name
227	|| ob1->title != ob2->title	211	|| ob1->title != ob2->title
228	|| ob1->msg != ob2->msg	212	|| ob1->msg != ob2->msg
229	|| ob1->weight != ob2->weight	213	|| ob1->weight != ob2->weight
230	|| ob1->attacktype != ob2->attacktype	214	|| ob1->attacktype != ob2->attacktype
231	|| ob1->magic != ob2->magic	215	|| ob1->magic != ob2->magic
232	|| ob1->slaying != ob2->slaying	216	|| ob1->slaying != ob2->slaying
233	|| ob1->skill != ob2->skill	217	|| ob1->skill != ob2->skill
234	|| ob1->value != ob2->value	218	|| ob1->value != ob2->value
235	|| ob1->animation_id != ob2->animation_id	219	|| ob1->animation_id != ob2->animation_id
		220	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	|| ob1->client_type != ob2->client_type	221	|| ob1->client_type != ob2->client_type
237	|| ob1->materialname != ob2->materialname	222	|| ob1->materialname != ob2->materialname
238	|| ob1->lore != ob2->lore	223	|| ob1->lore != ob2->lore
239	|| ob1->subtype != ob2->subtype	224	|| ob1->subtype != ob2->subtype
240	|| ob1->move_type != ob2->move_type	225	|| ob1->move_type != ob2->move_type
…		…
248	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	234	return 0;
250		235
251	if ((ob1->flag ^ ob2->flag)	236	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	237	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	238	.reset (FLAG_REMOVED)
255	.any ())	239	.any ())
256	return 0;	240	return 0;
257		241
258	/* This is really a spellbook check - we should in general	242	/* This is really a spellbook check - we should in general
…		…
330		314
331	/* Everything passes, must be OK. */	315	/* Everything passes, must be OK. */
332	return 1;	316	return 1;
333	}	317	}
334		318
		319	// find player who can see this object
		320	object *
		321	object::visible_to () const
		322	{
		323	if (client_visible () && !flag [FLAG_REMOVED])
		324	{
		325	// see if we are in a container of sorts
		326	if (env)
		327	{
		328	// the player inventory itself is always visible
		329	if (env->is_player ())
		330	return env;
		331
		332	// else a player could have our env open
		333	object *envest = env->outer_env_or_self ();
		334
		335	// the player itself is always on a map, so we will find him here
		336	// even if our inv is in a player.
		337	if (envest->is_on_map ())
		338	if (object *pl = envest->ms ().player ())
		339	if (pl->container == env)
		340	return pl;
		341	}
		342	else
		343	{
		344	// maybe there is a player standing on the same mapspace
		345	// this will catch the case where "this" is a player
		346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		348	|| this == pl->container)
		349	return pl;
		350	}
		351	}
		352
		353	return 0;
		354	}
		355
335	// adjust weight per container type ("of holding")	356	// adjust weight per container type ("of holding")
336	static sint32	357	static sint32
337	weight_adjust (object *op, sint32 weight)	358	weight_adjust_for (object *op, sint32 weight)
338	{	359	{
339	return op->type == CONTAINER	360	return op->type == CONTAINER
340	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
341	: weight;	362	: weight;
342	}	363	}
…		…
348	static void	369	static void
349	adjust_weight (object *op, sint32 weight)	370	adjust_weight (object *op, sint32 weight)
350	{	371	{
351	while (op)	372	while (op)
352	{	373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
353	weight = weight_adjust (op, weight);	376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
354		378
355	if (!weight)	379	if (!weight)
356	return;	380	return;
357		381
358	op->carrying += weight;	382	op->carrying += weight;
359		383
360	if (object *pl = op->visible_to ())	384	if (object *pl = op->visible_to ())
		385	if (pl != op) // player is handled lazily
361	esrv_update_item (UPD_WEIGHT, pl, op);	386	esrv_update_item (UPD_WEIGHT, pl, op);
362		387
363	op = op->env;	388	op = op->env;
364	}	389	}
365	}	390	}
366		391
…		…
380	op->update_weight ();	405	op->update_weight ();
381		406
382	sum += op->total_weight ();	407	sum += op->total_weight ();
383	}	408	}
384		409
385	sum = weight_adjust (this, sum);	410	sum = weight_adjust_for (this, sum);
386		411
387	if (sum != carrying)	412	if (sum != carrying)
388	{	413	{
389	carrying = sum;	414	carrying = sum;
390		415
391	if (object *pl = visible_to ())	416	if (object *pl = visible_to ())
		417	if (pl != this) // player is handled lazily
392	esrv_update_item (UPD_WEIGHT, pl, this);	418	esrv_update_item (UPD_WEIGHT, pl, this);
393	}	419	}
394	}	420	}
395		421
396	/*	422	/*
397	* Used by: Server DM commands: dumpbelow, dump. Some error messages.	423	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
…		…
403	return strdup ("[NULLOBJ]");	429	return strdup ("[NULLOBJ]");
404		430
405	object_freezer freezer;	431	object_freezer freezer;
406	op->write (freezer);	432	op->write (freezer);
407	return freezer.as_string ();	433	return freezer.as_string ();
		434	}
		435
		436	char *
		437	object::as_string ()
		438	{
		439	return dump_object (this);
408	}	440	}
409		441
410	/*	442	/*
411	* get_nearest_part(multi-object, object 2) returns the part of the	443	* get_nearest_part(multi-object, object 2) returns the part of the
412	* multi-object 1 which is closest to the second object.	444	* multi-object 1 which is closest to the second object.
…		…
451	*/	483	*/
452	object *	484	object *
453	find_object_name (const char *str)	485	find_object_name (const char *str)
454	{	486	{
455	shstr_cmp str_ (str);	487	shstr_cmp str_ (str);
456	object *op;
457		488
		489	if (str_)
458	for_all_objects (op)	490	for_all_objects (op)
459	if (op->name == str_)	491	if (op->name == str_)
460	break;	492	return op;
461		493
462	return op;	494	return 0;
463	}	495	}
464		496
465	/*	497	/*
466	* Sets the owner and sets the skill and exp pointers to owner's current	498	* Sets the owner and sets the skill and exp pointers to owner's current
467	* skill and experience objects.	499	* skill and experience objects.
…		…
529	update_stats ();	561	update_stats ();
530		562
531	new_draw_info_format (NDI_UNIQUE, 0, this,	563	new_draw_info_format (NDI_UNIQUE, 0, this,
532	"You try to balance all your items at once, "	564	"You try to balance all your items at once, "
533	"but the %s is just too much for your body. "	565	"but the %s is just too much for your body. "
534	"[You need to unapply some items first.]", &ob->name);	566	"[You need to unapply some items first - use the 'body' command to see "
		567	"how many items you cna wera on a specific body part.]", &ob->name);
535	return false;	568	return false;
536	}	569	}
537		570
538	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);	571	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
539	}	572	}
…		…
565	}	598	}
566		599
567	op->key_values = 0;	600	op->key_values = 0;
568	}	601	}
569		602
570	object &	603	/*
571	object::operator =(const object &src)	604	* copy_to first frees everything allocated by the dst object,
		605	* and then copies the contents of itself into the second
		606	* object, allocating what needs to be allocated. Basically, any
		607	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		608	* if the first object is freed, the pointers in the new object
		609	* will point at garbage.
		610	*/
		611	void
		612	object::copy_to (object *dst)
572	{	613	{
573	bool is_freed = flag [FLAG_FREED];	614	dst->remove ();
574	bool is_removed = flag [FLAG_REMOVED];
575
576	*(object_copy *)this = src;	615	*(object_copy *)dst = *this;
577
578	flag [FLAG_FREED] = is_freed;
579	flag [FLAG_REMOVED] = is_removed;	616	dst->flag [FLAG_REMOVED] = true;
580		617
581	/* Copy over key_values, if any. */	618	/* Copy over key_values, if any. */
582	if (src.key_values)	619	if (key_values)
583	{	620	{
584	key_value *tail = 0;	621	key_value *tail = 0;
585	key_values = 0;	622	dst->key_values = 0;
586		623
587	for (key_value *i = src.key_values; i; i = i->next)	624	for (key_value *i = key_values; i; i = i->next)
588	{	625	{
589	key_value *new_link = new key_value;	626	key_value *new_link = new key_value;
590		627
591	new_link->next = 0;	628	new_link->next = 0;
592	new_link->key = i->key;	629	new_link->key = i->key;
593	new_link->value = i->value;	630	new_link->value = i->value;
594		631
595	/* Try and be clever here, too. */	632	/* Try and be clever here, too. */
596	if (!key_values)	633	if (!dst->key_values)
597	{	634	{
598	key_values = new_link;	635	dst->key_values = new_link;
599	tail = new_link;	636	tail = new_link;
600	}	637	}
601	else	638	else
602	{	639	{
603	tail->next = new_link;	640	tail->next = new_link;
604	tail = new_link;	641	tail = new_link;
605	}	642	}
606	}	643	}
607	}	644	}
608	}
609
610	/*
611	* copy_to first frees everything allocated by the dst object,
612	* and then copies the contents of itself into the second
613	* object, allocating what needs to be allocated. Basically, any
614	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
615	* if the first object is freed, the pointers in the new object
616	* will point at garbage.
617	*/
618	void
619	object::copy_to (object *dst)
620	{
621	*dst = *this;
622		645
623	if (speed < 0)	646	if (speed < 0)
624	dst->speed_left -= rndm ();	647	dst->speed_left -= rndm ();
625		648
626	dst->set_speed (dst->speed);	649	dst->activate ();
627	}	650	}
628		651
629	void	652	void
630	object::instantiate ()	653	object::instantiate ()
631	{	654	{
…		…
648	object *	671	object *
649	object::clone ()	672	object::clone ()
650	{	673	{
651	object *neu = create ();	674	object *neu = create ();
652	copy_to (neu);	675	copy_to (neu);
		676	neu->map = map; // not copied by copy_to
653	return neu;	677	return neu;
654	}	678	}
655		679
656	/*	680	/*
657	* If an object with the IS_TURNABLE() flag needs to be turned due	681	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
708	* UP_OBJ_FACE: only the objects face has changed.	732	* UP_OBJ_FACE: only the objects face has changed.
709	*/	733	*/
710	void	734	void
711	update_object (object *op, int action)	735	update_object (object *op, int action)
712	{	736	{
713	if (op == NULL)	737	if (!op)
714	{	738	{
715	/* this should never happen */	739	/* this should never happen */
716	LOG (llevDebug, "update_object() called for NULL object.\n");	740	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
717	return;	741	return;
718	}	742	}
719		743
720	if (op->env)	744	if (!op->is_on_map ())
721	{	745	{
722	/* Animation is currently handled by client, so nothing	746	/* Animation is currently handled by client, so nothing
723	* to do in this case.	747	* to do in this case.
724	*/	748	*/
725	return;	749	return;
726	}	750	}
727
728	/* If the map is saving, don't do anything as everything is
729	* going to get freed anyways.
730	*/
731	if (!op->map || op->map->in_memory == MAP_SAVING)
732	return;
733		751
734	/* make sure the object is within map boundaries */	752	/* make sure the object is within map boundaries */
735	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	753	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
736	{	754	{
737	LOG (llevError, "update_object() called for object out of map!\n");	755	LOG (llevError, "update_object() called for object out of map!\n");
…		…
748	else if (action == UP_OBJ_INSERT)	766	else if (action == UP_OBJ_INSERT)
749	{	767	{
750	// this is likely overkill, TODO: revisit (schmorp)	768	// this is likely overkill, TODO: revisit (schmorp)
751	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	769	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
752	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	770	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
753	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	771	|| (op->is_player () && !(m.flags_ & P_PLAYER))
754	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	772	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
755	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	773	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
756	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	774	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
757	|| (m.move_on | op->move_on ) != m.move_on	775	|| (m.move_on | op->move_on ) != m.move_on
758	|| (m.move_off | op->move_off ) != m.move_off	776	|| (m.move_off | op->move_off ) != m.move_off
759	|| (m.move_slow | op->move_slow) != m.move_slow	777	|| (m.move_slow | op->move_slow) != m.move_slow
760	/* This isn't perfect, but I don't expect a lot of objects to	778	/* This isn't perfect, but I don't expect a lot of objects to
761	* to have move_allow right now.	779	* have move_allow right now.
762	*/	780	*/
763	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	781	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
764	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	782	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
765	m.flags_ = 0;	783	m.invalidate ();
766	}	784	}
767	/* if the object is being removed, we can't make intelligent	785	/* if the object is being removed, we can't make intelligent
768	* decisions, because remove_ob can't really pass the object	786	* decisions, because remove_ob can't really pass the object
769	* that is being removed.	787	* that is being removed.
770	*/	788	*/
771	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	789	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
772	m.flags_ = 0;	790	m.invalidate ();
773	else if (action == UP_OBJ_FACE)	791	else if (action == UP_OBJ_FACE)
774	/* Nothing to do for that case */ ;	792	/* Nothing to do for that case */ ;
775	else	793	else
776	LOG (llevError, "update_object called with invalid action: %d\n", action);	794	LOG (llevError, "update_object called with invalid action: %d\n", action);
777		795
…		…
781		799
782	object::object ()	800	object::object ()
783	{	801	{
784	SET_FLAG (this, FLAG_REMOVED);	802	SET_FLAG (this, FLAG_REMOVED);
785		803
786	expmul = 1.0;	804	//expmul = 1.0; declared const for the time being
787	face = blank_face;	805	face = blank_face;
788	}	806	}
789		807
790	object::~object ()	808	object::~object ()
791	{	809	{
…		…
821	/* If already on active list, don't do anything */	839	/* If already on active list, don't do anything */
822	if (active)	840	if (active)
823	return;	841	return;
824		842
825	if (has_active_speed ())	843	if (has_active_speed ())
		844	{
		845	if (flag [FLAG_FREED])
		846	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		847
826	actives.insert (this);	848	actives.insert (this);
		849	}
827	}	850	}
828		851
829	void	852	void
830	object::activate_recursive ()	853	object::activate_recursive ()
831	{	854	{
…		…
880	object::destroy_inv (bool drop_to_ground)	903	object::destroy_inv (bool drop_to_ground)
881	{	904	{
882	// need to check first, because the checks below might segfault	905	// need to check first, because the checks below might segfault
883	// as we might be on an invalid mapspace and crossfire code	906	// as we might be on an invalid mapspace and crossfire code
884	// is too buggy to ensure that the inventory is empty.	907	// is too buggy to ensure that the inventory is empty.
885	// corollary: if you create arrows etc. with stuff in tis inventory,	908	// corollary: if you create arrows etc. with stuff in its inventory,
886	// cf will crash below with off-map x and y	909	// cf will crash below with off-map x and y
887	if (!inv)	910	if (!inv)
888	return;	911	return;
889		912
890	/* Only if the space blocks everything do we not process -	913	/* Only if the space blocks everything do we not process -
…		…
892	* drop on that space.	915	* drop on that space.
893	*/	916	*/
894	if (!drop_to_ground	917	if (!drop_to_ground
895	|| !map	918	|| !map
896	|| map->in_memory != MAP_ACTIVE	919	|| map->in_memory != MAP_ACTIVE
897	|| map->nodrop	920	|| map->no_drop
898	|| ms ().move_block == MOVE_ALL)	921	|| ms ().move_block == MOVE_ALL)
899	{	922	{
900	while (inv)	923	while (inv)
901	{
902	inv->destroy_inv (drop_to_ground);
903	inv->destroy ();	924	inv->destroy ();
904	}
905	}	925	}
906	else	926	else
907	{ /* Put objects in inventory onto this space */	927	{ /* Put objects in inventory onto this space */
908	while (inv)	928	while (inv)
909	{	929	{
…		…
927	object *op = new object;	947	object *op = new object;
928	op->link ();	948	op->link ();
929	return op;	949	return op;
930	}	950	}
931		951
		952	static struct freed_map : maptile
		953	{
		954	freed_map ()
		955	{
		956	path = "<freed objects map>";
		957	name = "/internal/freed_objects_map";
		958	width = 3;
		959	height = 3;
		960	no_drop = 1;
		961	no_reset = 1;
		962
		963	alloc ();
		964	in_memory = MAP_ACTIVE;
		965	}
		966
		967	~freed_map ()
		968	{
		969	destroy ();
		970	}
		971	} freed_map; // freed objects are moved here to avoid crashes
		972
932	void	973	void
933	object::do_destroy ()	974	object::do_destroy ()
934	{	975	{
935	if (object *pl = visible_to ())
936	esrv_del_item (pl->contr, count);
937
938	attachable::do_destroy ();
939
940	if (flag [FLAG_IS_LINKED])	976	if (flag [FLAG_IS_LINKED])
941	remove_button_link (this);	977	remove_link ();
942		978
943	if (flag [FLAG_FRIENDLY])	979	if (flag [FLAG_FRIENDLY])
944	remove_friendly_object (this);	980	remove_friendly_object (this);
945		981
946	if (!flag [FLAG_REMOVED])
947	remove ();	982	remove ();
948		983
949	destroy_inv (true);	984	attachable::do_destroy ();
950		985
951	deactivate ();	986	deactivate ();
952	unlink ();	987	unlink ();
953		988
954	flag [FLAG_FREED] = 1;	989	flag [FLAG_FREED] = 1;
955		990
956	// hack to ensure that freed objects still have a valid map	991	// hack to ensure that freed objects still have a valid map
957	{
958	static maptile *freed_map; // freed objects are moved here to avoid crashes
959
960	if (!freed_map)
961	{
962	freed_map = new maptile;
963
964	freed_map->path = "<freed objects map>";
965	freed_map->name = "/internal/freed_objects_map";
966	freed_map->width = 3;
967	freed_map->height = 3;
968	freed_map->nodrop = 1;
969
970	freed_map->alloc ();
971	freed_map->in_memory = MAP_ACTIVE;
972	}
973
974	map = freed_map;	992	map = &freed_map;
975	x = 1;	993	x = 1;
976	y = 1;	994	y = 1;
977	}
978		995
979	if (more)	996	if (more)
980	{	997	{
981	more->destroy ();	998	more->destroy ();
982	more = 0;	999	more = 0;
…		…
990	attacked_by = 0;	1007	attacked_by = 0;
991	current_weapon = 0;	1008	current_weapon = 0;
992	}	1009	}
993		1010
994	void	1011	void
995	object::destroy (bool destroy_inventory)	1012	object::destroy ()
996	{	1013	{
997	if (destroyed ())	1014	if (destroyed ())
998	return;	1015	return;
999		1016
1000	if (destroy_inventory)	1017	if (!is_head () && !head->destroyed ())
		1018	{
		1019	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1020	head->destroy ();
		1021	return;
		1022	}
		1023
1001	destroy_inv (false);	1024	destroy_inv (false);
1002		1025
1003	if (is_head ())	1026	if (is_head ())
1004	if (sound_destroy)	1027	if (sound_destroy)
1005	play_sound (sound_destroy);	1028	play_sound (sound_destroy);
1006	else if (flag [FLAG_MONSTER])	1029	else if (flag [FLAG_MONSTER])
…		…
1020	object::do_remove ()	1043	object::do_remove ()
1021	{	1044	{
1022	object *tmp, *last = 0;	1045	object *tmp, *last = 0;
1023	object *otmp;	1046	object *otmp;
1024		1047
1025	if (QUERY_FLAG (this, FLAG_REMOVED))	1048	if (flag [FLAG_REMOVED])
1026	return;	1049	return;
1027		1050
1028	SET_FLAG (this, FLAG_REMOVED);
1029	INVOKE_OBJECT (REMOVE, this);	1051	INVOKE_OBJECT (REMOVE, this);
		1052
		1053	flag [FLAG_REMOVED] = true;
1030		1054
1031	if (more)	1055	if (more)
1032	more->remove ();	1056	more->remove ();
1033		1057
1034	/*	1058	/*
1035	* In this case, the object to be removed is in someones	1059	* In this case, the object to be removed is in someones
1036	* inventory.	1060	* inventory.
1037	*/	1061	*/
1038	if (env)	1062	if (env)
1039	{	1063	{
		1064	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1065	if (object *pl = visible_to ())
		1066	esrv_del_item (pl->contr, count);
		1067	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1068
1040	adjust_weight (env, -total_weight ());	1069	adjust_weight (env, -total_weight ());
1041		1070
1042	*(above ? &above->below : &env->inv) = below;	1071	object *pl = in_player ();
1043
1044	if (below)
1045	below->above = above;
1046		1072
1047	/* we set up values so that it could be inserted into	1073	/* we set up values so that it could be inserted into
1048	* the map, but we don't actually do that - it is up	1074	* the map, but we don't actually do that - it is up
1049	* to the caller to decide what we want to do.	1075	* to the caller to decide what we want to do.
1050	*/	1076	*/
1051	map = env->map;	1077	map = env->map;
1052	x = env->x;	1078	x = env->x;
1053	y = env->y;	1079	y = env->y;
		1080
		1081	// make sure cmov optimisation is applicable
		1082	*(above ? &above->below : &env->inv) = below;
		1083	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1084
1054	above = 0;	1085	above = 0;
1055	below = 0;	1086	below = 0;
1056	env = 0;	1087	env = 0;
1057		1088
1058	/* NO_FIX_PLAYER is set when a great many changes are being	1089	/* NO_FIX_PLAYER is set when a great many changes are being
1059	* made to players inventory. If set, avoiding the call	1090	* made to players inventory. If set, avoiding the call
1060	* to save cpu time.	1091	* to save cpu time.
1061	*/	1092	*/
1062	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1093	if (pl)
		1094	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1095	{
1063	otmp->update_stats ();	1096	pl->update_stats ();
		1097
		1098	if (glow_radius && pl->is_on_map ())
		1099	update_all_los (pl->map, pl->x, pl->y);
		1100	}
1064	}	1101	}
1065	else if (map)	1102	else if (map)
1066	{	1103	{
1067	if (type == PLAYER)
1068	{
1069	// leaving a spot always closes any open container on the ground
1070	if (container && !container->env)
1071	// this causes spurious floorbox updates, but it ensures
1072	// that the CLOSE event is being sent.
1073	close_container ();
1074
1075	--map->players;
1076	map->touch ();
1077	}
1078
1079	map->dirty = true;	1104	map->dirty = true;
1080	mapspace &ms = this->ms ();	1105	mapspace &ms = this->ms ();
1081		1106
		1107	if (object *pl = ms.player ())
		1108	{
		1109	if (is_player ())
		1110	{
		1111	if (!flag [FLAG_WIZPASS])
		1112	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1113
		1114	// leaving a spot always closes any open container on the ground
		1115	if (container && !container->env)
		1116	// this causes spurious floorbox updates, but it ensures
		1117	// that the CLOSE event is being sent.
		1118	close_container ();
		1119
		1120	--map->players;
		1121	map->touch ();
		1122	}
		1123	else if (pl->container == this)
		1124	{
		1125	// removing a container should close it
		1126	close_container ();
		1127	}
		1128
		1129	esrv_del_item (pl->contr, count);
		1130	}
		1131
1082	/* link the object above us */	1132	/* link the object above us */
1083	if (above)	1133	// re-link, make sure compiler can easily use cmove
1084	above->below = below;	1134	*(above ? &above->below : &ms.top) = below;
1085	else	1135	*(below ? &below->above : &ms.bot) = above;
1086	ms.top = below; /* we were top, set new top */
1087
1088	/* Relink the object below us, if there is one */
1089	if (below)
1090	below->above = above;
1091	else
1092	{
1093	/* Nothing below, which means we need to relink map object for this space
1094	* use translated coordinates in case some oddness with map tiling is
1095	* evident
1096	*/
1097	if (GET_MAP_OB (map, x, y) != this)
1098	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1099
1100	ms.bot = above; /* goes on above it. */
1101	}
1102		1136
1103	above = 0;	1137	above = 0;
1104	below = 0;	1138	below = 0;
		1139
		1140	ms.invalidate ();
1105		1141
1106	if (map->in_memory == MAP_SAVING)	1142	if (map->in_memory == MAP_SAVING)
1107	return;	1143	return;
1108		1144
1109	int check_walk_off = !flag [FLAG_NO_APPLY];	1145	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1115	* removed (most likely destroyed), update the player view	1151	* removed (most likely destroyed), update the player view
1116	* appropriately.	1152	* appropriately.
1117	*/	1153	*/
1118	pl->close_container ();	1154	pl->close_container ();
1119		1155
		1156	//TODO: the floorbox prev/next might need updating
		1157	//esrv_del_item (pl->contr, count);
		1158	//TODO: update floorbox to preserve ordering
		1159	if (pl->contr->ns)
1120	pl->contr->ns->floorbox_update ();	1160	pl->contr->ns->floorbox_update ();
1121	}	1161	}
1122		1162
1123	for (tmp = ms.bot; tmp; tmp = tmp->above)	1163	for (tmp = ms.bot; tmp; tmp = tmp->above)
1124	{	1164	{
1125	/* No point updating the players look faces if he is the object	1165	/* No point updating the players look faces if he is the object
…		…
1138	}	1178	}
1139		1179
1140	last = tmp;	1180	last = tmp;
1141	}	1181	}
1142		1182
1143	/* last == NULL if there are no objects on this space */	1183	if (affects_los ())
1144	//TODO: this makes little sense, why only update the topmost object?
1145	if (!last)
1146	map->at (x, y).flags_ = 0;
1147	else
1148	update_object (last, UP_OBJ_REMOVE);
1149
1150	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1151	update_all_los (map, x, y);	1184	update_all_los (map, x, y);
1152	}	1185	}
1153	}	1186	}
1154		1187
1155	/*	1188	/*
…		…
1169	if (!top)	1202	if (!top)
1170	for (top = op; top && top->above; top = top->above)	1203	for (top = op; top && top->above; top = top->above)
1171	;	1204	;
1172		1205
1173	for (; top; top = top->below)	1206	for (; top; top = top->below)
1174	{
1175	if (top == op)
1176	continue;
1177
1178	if (object::can_merge (op, top))	1207	if (object::can_merge (op, top))
1179	{	1208	{
1180	top->nrof += op->nrof;	1209	top->nrof += op->nrof;
1181		1210
1182	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1211	if (object *pl = top->visible_to ())
1183	op->weight = 0; /* Don't want any adjustements now */	1212	esrv_update_item (UPD_NROF, pl, top);
		1213
		1214	op->weight = 0; // cancel the addition above
		1215	op->carrying = 0; // must be 0 already
		1216
1184	op->destroy ();	1217	op->destroy ();
		1218
1185	return top;	1219	return top;
1186	}	1220	}
1187	}
1188		1221
1189	return 0;	1222	return 0;
1190	}	1223	}
1191		1224
1192	void	1225	void
…		…
1217	* job preparing multi-part monsters.	1250	* job preparing multi-part monsters.
1218	*/	1251	*/
1219	object *	1252	object *
1220	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1253	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1221	{	1254	{
		1255	op->remove ();
		1256
1222	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1257	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1223	{	1258	{
1224	tmp->x = x + tmp->arch->x;	1259	tmp->x = x + tmp->arch->x;
1225	tmp->y = y + tmp->arch->y;	1260	tmp->y = y + tmp->arch->y;
1226	}	1261	}
…		…
1249	* just 'op' otherwise	1284	* just 'op' otherwise
1250	*/	1285	*/
1251	object *	1286	object *
1252	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1287	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1253	{	1288	{
1254	assert (!op->flag [FLAG_FREED]);
1255
1256	object *top, *floor = NULL;
1257
1258	op->remove ();	1289	op->remove ();
		1290
		1291	if (m == &freed_map)//D TODO: remove soon
		1292	{//D
		1293	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1294	}//D
1259		1295
1260	/* Ideally, the caller figures this out. However, it complicates a lot	1296	/* Ideally, the caller figures this out. However, it complicates a lot
1261	* of areas of callers (eg, anything that uses find_free_spot would now	1297	* of areas of callers (eg, anything that uses find_free_spot would now
1262	* need extra work	1298	* need extra work
1263	*/	1299	*/
		1300	maptile *newmap = m;
1264	if (!xy_normalise (m, op->x, op->y))	1301	if (!xy_normalise (newmap, op->x, op->y))
1265	{	1302	{
1266	op->destroy ();	1303	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1267	return 0;	1304	return 0;
1268	}	1305	}
1269		1306
1270	if (object *more = op->more)	1307	if (object *more = op->more)
1271	if (!insert_ob_in_map (more, m, originator, flag))	1308	if (!insert_ob_in_map (more, m, originator, flag))
1272	return 0;	1309	return 0;
1273		1310
1274	CLEAR_FLAG (op, FLAG_REMOVED);	1311	op->flag [FLAG_REMOVED] = false;
1275		1312	op->env = 0;
1276	op->map = m;	1313	op->map = newmap;
		1314
1277	mapspace &ms = op->ms ();	1315	mapspace &ms = op->ms ();
1278		1316
1279	/* this has to be done after we translate the coordinates.	1317	/* this has to be done after we translate the coordinates.
1280	*/	1318	*/
1281	if (op->nrof && !(flag & INS_NO_MERGE))	1319	if (op->nrof && !(flag & INS_NO_MERGE))
1282	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1320	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1283	if (object::can_merge (op, tmp))	1321	if (object::can_merge (op, tmp))
1284	{	1322	{
		1323	// TODO: we actually want to update tmp, not op,
		1324	// but some caller surely breaks when we return tmp
		1325	// from here :/
1285	op->nrof += tmp->nrof;	1326	op->nrof += tmp->nrof;
1286	tmp->destroy (1);	1327	tmp->destroy ();
1287	}	1328	}
1288		1329
1289	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1330	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1290	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1331	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1291		1332
…		…
1298	{	1339	{
1299	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1340	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1300	abort ();	1341	abort ();
1301	}	1342	}
1302		1343
		1344	if (!originator->is_on_map ())
		1345	{
		1346	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1347	op->debug_desc (), originator->debug_desc ());
		1348	abort ();
		1349	}
		1350
1303	op->above = originator;	1351	op->above = originator;
1304	op->below = originator->below;	1352	op->below = originator->below;
1305
1306	if (op->below)
1307	op->below->above = op;
1308	else
1309	ms.bot = op;
1310
1311	/* since *below* originator, no need to update top */
1312	originator->below = op;	1353	originator->below = op;
		1354
		1355	*(op->below ? &op->below->above : &ms.bot) = op;
1313	}	1356	}
1314	else	1357	else
1315	{	1358	{
1316	top = ms.bot;	1359	object *floor = 0;
		1360	object *top = ms.top;
1317		1361
1318	/* If there are other objects, then */	1362	/* If there are other objects, then */
1319	if (top)	1363	if (top)
1320	{	1364	{
1321	object *last = 0;
1322
1323	/*	1365	/*
1324	* If there are multiple objects on this space, we do some trickier handling.	1366	* If there are multiple objects on this space, we do some trickier handling.
1325	* We've already dealt with merging if appropriate.	1367	* We've already dealt with merging if appropriate.
1326	* Generally, we want to put the new object on top. But if	1368	* Generally, we want to put the new object on top. But if
1327	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1369	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1330	* once we get to them. This reduces the need to traverse over all of	1372	* once we get to them. This reduces the need to traverse over all of
1331	* them when adding another one - this saves quite a bit of cpu time	1373	* them when adding another one - this saves quite a bit of cpu time
1332	* when lots of spells are cast in one area. Currently, it is presumed	1374	* when lots of spells are cast in one area. Currently, it is presumed
1333	* that flying non pickable objects are spell objects.	1375	* that flying non pickable objects are spell objects.
1334	*/	1376	*/
1335	for (top = ms.bot; top; top = top->above)	1377	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1336	{	1378	{
1337	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1379	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1338	floor = top;	1380	floor = tmp;
1339		1381
1340	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1382	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1341	{	1383	{
1342	/* We insert above top, so we want this object below this */	1384	/* We insert above top, so we want this object below this */
1343	top = top->below;	1385	top = tmp->below;
1344	break;	1386	break;
1345	}	1387	}
1346		1388
1347	last = top;	1389	top = tmp;
1348	}	1390	}
1349
1350	/* Don't want top to be NULL, so set it to the last valid object */
1351	top = last;
1352		1391
1353	/* We let update_position deal with figuring out what the space	1392	/* We let update_position deal with figuring out what the space
1354	* looks like instead of lots of conditions here.	1393	* looks like instead of lots of conditions here.
1355	* makes things faster, and effectively the same result.	1394	* makes things faster, and effectively the same result.
1356	*/	1395	*/
…		…
1363	*/	1402	*/
1364	if (!(flag & INS_ON_TOP)	1403	if (!(flag & INS_ON_TOP)
1365	&& ms.flags () & P_BLOCKSVIEW	1404	&& ms.flags () & P_BLOCKSVIEW
1366	&& (op->face && !faces [op->face].visibility))	1405	&& (op->face && !faces [op->face].visibility))
1367	{	1406	{
		1407	object *last;
		1408
1368	for (last = top; last != floor; last = last->below)	1409	for (last = top; last != floor; last = last->below)
1369	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1410	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1370	break;	1411	break;
1371		1412
1372	/* Check to see if we found the object that blocks view,	1413	/* Check to see if we found the object that blocks view,
…		…
1380	} /* If objects on this space */	1421	} /* If objects on this space */
1381		1422
1382	if (flag & INS_ABOVE_FLOOR_ONLY)	1423	if (flag & INS_ABOVE_FLOOR_ONLY)
1383	top = floor;	1424	top = floor;
1384		1425
1385	/* Top is the object that our object (op) is going to get inserted above.	1426	// insert object above top, or bottom-most if top = 0
1386	*/
1387
1388	/* First object on this space */
1389	if (!top)	1427	if (!top)
1390	{	1428	{
		1429	op->below = 0;
1391	op->above = ms.bot;	1430	op->above = ms.bot;
1392
1393	if (op->above)
1394	op->above->below = op;
1395
1396	op->below = 0;
1397	ms.bot = op;	1431	ms.bot = op;
		1432
		1433	*(op->above ? &op->above->below : &ms.top) = op;
1398	}	1434	}
1399	else	1435	else
1400	{ /* get inserted into the stack above top */	1436	{
1401	op->above = top->above;	1437	op->above = top->above;
1402
1403	if (op->above)
1404	op->above->below = op;	1438	top->above = op;
1405		1439
1406	op->below = top;	1440	op->below = top;
1407	top->above = op;	1441	*(op->above ? &op->above->below : &ms.top) = op;
1408	}	1442	}
		1443	}
1409		1444
1410	if (!op->above)	1445	if (op->is_player ())
1411	ms.top = op;
1412	} /* else not INS_BELOW_ORIGINATOR */
1413
1414	if (op->type == PLAYER)
1415	{	1446	{
1416	op->contr->do_los = 1;	1447	op->contr->do_los = 1;
1417	++op->map->players;	1448	++op->map->players;
1418	op->map->touch ();	1449	op->map->touch ();
1419	}	1450	}
1420		1451
1421	op->map->dirty = true;	1452	op->map->dirty = true;
1422		1453
1423	if (object *pl = ms.player ())	1454	if (object *pl = ms.player ())
		1455	//TODO: the floorbox prev/next might need updating
		1456	//esrv_send_item (pl, op);
		1457	//TODO: update floorbox to preserve ordering
		1458	if (pl->contr->ns)
1424	pl->contr->ns->floorbox_update ();	1459	pl->contr->ns->floorbox_update ();
1425		1460
1426	/* If this object glows, it may affect lighting conditions that are	1461	/* If this object glows, it may affect lighting conditions that are
1427	* visible to others on this map. But update_all_los is really	1462	* visible to others on this map. But update_all_los is really
1428	* an inefficient way to do this, as it means los for all players	1463	* an inefficient way to do this, as it means los for all players
1429	* on the map will get recalculated. The players could very well	1464	* on the map will get recalculated. The players could very well
1430	* be far away from this change and not affected in any way -	1465	* be far away from this change and not affected in any way -
1431	* this should get redone to only look for players within range,	1466	* this should get redone to only look for players within range,
1432	* or just updating the P_UPTODATE for spaces within this area	1467	* or just updating the P_UPTODATE for spaces within this area
1433	* of effect may be sufficient.	1468	* of effect may be sufficient.
1434	*/	1469	*/
1435	if (op->map->darkness && (op->glow_radius != 0))	1470	if (op->affects_los ())
		1471	{
		1472	op->ms ().invalidate ();
1436	update_all_los (op->map, op->x, op->y);	1473	update_all_los (op->map, op->x, op->y);
		1474	}
1437		1475
1438	/* updates flags (blocked, alive, no magic, etc) for this map space */	1476	/* updates flags (blocked, alive, no magic, etc) for this map space */
1439	update_object (op, UP_OBJ_INSERT);	1477	update_object (op, UP_OBJ_INSERT);
1440		1478
1441	INVOKE_OBJECT (INSERT, op);	1479	INVOKE_OBJECT (INSERT, op);
…		…
1448	* blocked() and wall() work properly), and these flags are updated by	1486	* blocked() and wall() work properly), and these flags are updated by
1449	* update_object().	1487	* update_object().
1450	*/	1488	*/
1451		1489
1452	/* if this is not the head or flag has been passed, don't check walk on status */	1490	/* if this is not the head or flag has been passed, don't check walk on status */
1453	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1491	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1454	{	1492	{
1455	if (check_move_on (op, originator))	1493	if (check_move_on (op, originator))
1456	return 0;	1494	return 0;
1457		1495
1458	/* If we are a multi part object, lets work our way through the check	1496	/* If we are a multi part object, lets work our way through the check
…		…
1469	/* this function inserts an object in the map, but if it	1507	/* this function inserts an object in the map, but if it
1470	* finds an object of its own type, it'll remove that one first.	1508	* finds an object of its own type, it'll remove that one first.
1471	* op is the object to insert it under: supplies x and the map.	1509	* op is the object to insert it under: supplies x and the map.
1472	*/	1510	*/
1473	void	1511	void
1474	replace_insert_ob_in_map (const char *arch_string, object *op)	1512	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1475	{	1513	{
1476	/* first search for itself and remove any old instances */	1514	/* first search for itself and remove any old instances */
1477		1515
1478	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1516	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1479	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1517	if (tmp->arch->archname == archname) /* same archetype */
1480	tmp->destroy (1);	1518	tmp->destroy ();
1481		1519
1482	object *tmp = arch_to_object (archetype::find (arch_string));	1520	object *tmp = arch_to_object (archetype::find (archname));
1483		1521
1484	tmp->x = op->x;	1522	tmp->x = op->x;
1485	tmp->y = op->y;	1523	tmp->y = op->y;
1486		1524
1487	insert_ob_in_map (tmp, op->map, op, 0);	1525	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1492	{	1530	{
1493	if (where->env)	1531	if (where->env)
1494	return where->env->insert (this);	1532	return where->env->insert (this);
1495	else	1533	else
1496	return where->map->insert (this, where->x, where->y, originator, flags);	1534	return where->map->insert (this, where->x, where->y, originator, flags);
1497	}
1498
1499	// find player who can see this object
1500	object *
1501	object::visible_to () const
1502	{
1503	if (!flag [FLAG_REMOVED])
1504	{
1505	// see if we are in a container of sorts
1506	if (env)
1507	{
1508	// the player inventory itself is always visible
1509	if (env->type == PLAYER)
1510	return env;
1511
1512	// else a player could have our env open
1513	object *envest = env->outer_env ();
1514
1515	// the player itself is always on a map, so we will find him here
1516	// even if our inv is in a player.
1517	if (envest->is_on_map ())
1518	if (object *pl = envest->ms ().player ())
1519	if (pl->container == env)
1520	return pl;
1521	}
1522	else
1523	{
1524	// maybe there is a player standing on the same mapspace
1525	// this will catch the case where "this" is a player
1526	if (object *pl = ms ().player ())
1527	return pl;
1528	}
1529	}
1530
1531	return 0;
1532	}	1535	}
1533		1536
1534	/*	1537	/*
1535	* decrease(object, number) decreases a specified number from	1538	* decrease(object, number) decreases a specified number from
1536	* the amount of an object. If the amount reaches 0, the object	1539	* the amount of an object. If the amount reaches 0, the object
…		…
1544	if (!nr)	1547	if (!nr)
1545	return true;	1548	return true;
1546		1549
1547	nr = min (nr, nrof);	1550	nr = min (nr, nrof);
1548		1551
		1552	if (nrof > nr)
		1553	{
1549	nrof -= nr;	1554	nrof -= nr;
1550
1551	if (nrof)
1552	{
1553	adjust_weight (env, -weight * nr); // carrying == 0	1555	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1554		1556
1555	if (object *pl = visible_to ())	1557	if (object *pl = visible_to ())
1556	esrv_update_item (UPD_NROF, pl, this);	1558	esrv_update_item (UPD_NROF, pl, this);
1557		1559
1558	return true;	1560	return true;
1559	}	1561	}
1560	else	1562	else
1561	{	1563	{
1562	destroy (1);	1564	destroy ();
1563	return false;	1565	return false;
1564	}	1566	}
1565	}	1567	}
1566		1568
1567	/*	1569	/*
…		…
1584	}	1586	}
1585	else	1587	else
1586	{	1588	{
1587	decrease (nr);	1589	decrease (nr);
1588		1590
1589	object *op = object_create_clone (this);	1591	object *op = deep_clone ();
1590	op->nrof = nr;	1592	op->nrof = nr;
1591	return op;	1593	return op;
1592	}	1594	}
1593	}	1595	}
1594		1596
…		…
1638	if (object::can_merge (tmp, op))	1640	if (object::can_merge (tmp, op))
1639	{	1641	{
1640	/* return the original object and remove inserted object	1642	/* return the original object and remove inserted object
1641	(client needs the original object) */	1643	(client needs the original object) */
1642	tmp->nrof += op->nrof;	1644	tmp->nrof += op->nrof;
		1645
		1646	if (object *pl = tmp->visible_to ())
		1647	esrv_update_item (UPD_NROF, pl, tmp);
		1648
1643	adjust_weight (this, op->total_weight ());	1649	adjust_weight (this, op->total_weight ());
1644		1650
1645	op->destroy (1);	1651	op->destroy ();
1646	op = tmp;	1652	op = tmp;
1647	goto inserted;	1653	goto inserted;
1648	}	1654	}
1649		1655
1650	op->owner = 0; // it's his/hers now. period.	1656	op->owner = 0; // it's his/hers now. period.
…		…
1661		1667
1662	inv = op;	1668	inv = op;
1663		1669
1664	op->flag [FLAG_REMOVED] = 0;	1670	op->flag [FLAG_REMOVED] = 0;
1665		1671
		1672	if (object *pl = op->visible_to ())
		1673	esrv_send_item (pl, op);
		1674
1666	adjust_weight (this, op->total_weight ());	1675	adjust_weight (this, op->total_weight ());
1667		1676
1668	inserted:	1677	inserted:
1669	/* reset the light list and los of the players on the map */	1678	/* reset the light list and los of the players on the map */
1670	if (op->glow_radius && map && map->darkness)	1679	if (op->glow_radius && is_on_map ())
		1680	{
		1681	update_stats ();
1671	update_all_los (map, x, y);	1682	update_all_los (map, x, y);
1672		1683	}
1673	if (object *otmp = in_player ())	1684	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1674	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1685	// if this is a player's inventory, update stats
1675	otmp->update_stats ();	1686	update_stats ();
1676		1687
1677	INVOKE_OBJECT (INSERT, this);	1688	INVOKE_OBJECT (INSERT, this);
1678		1689
1679	return op;	1690	return op;
1680	}	1691	}
…		…
1700	* on top.	1711	* on top.
1701	*/	1712	*/
1702	int	1713	int
1703	check_move_on (object *op, object *originator)	1714	check_move_on (object *op, object *originator)
1704	{	1715	{
		1716	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1717	return 0;
		1718
1705	object *tmp;	1719	object *tmp;
1706	maptile *m = op->map;	1720	maptile *m = op->map;
1707	int x = op->x, y = op->y;	1721	int x = op->x, y = op->y;
1708		1722
1709	MoveType move_on, move_slow, move_block;	1723	mapspace &ms = m->at (x, y);
1710		1724
1711	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1725	ms.update ();
1712	return 0;
1713		1726
1714	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1727	MoveType move_on = ms.move_on;
1715	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1728	MoveType move_slow = ms.move_slow;
1716	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1729	MoveType move_block = ms.move_block;
1717		1730
1718	/* if nothing on this space will slow op down or be applied,	1731	/* if nothing on this space will slow op down or be applied,
1719	* no need to do checking below. have to make sure move_type	1732	* no need to do checking below. have to make sure move_type
1720	* is set, as lots of objects don't have it set - we treat that	1733	* is set, as lots of objects don't have it set - we treat that
1721	* as walking.	1734	* as walking.
…		…
1732	return 0;	1745	return 0;
1733		1746
1734	/* The objects have to be checked from top to bottom.	1747	/* The objects have to be checked from top to bottom.
1735	* Hence, we first go to the top:	1748	* Hence, we first go to the top:
1736	*/	1749	*/
1737		1750	for (object *next, *tmp = ms.top; tmp; tmp = next)
1738	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1739	{
1740	/* Trim the search when we find the first other spell effect
1741	* this helps performance so that if a space has 50 spell objects,
1742	* we don't need to check all of them.
1743	*/
1744	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1745	break;
1746	}	1751	{
		1752	next = tmp->below;
1747		1753
1748	for (; tmp; tmp = tmp->below)
1749	{
1750	if (tmp == op)	1754	if (tmp == op)
1751	continue; /* Can't apply yourself */	1755	continue; /* Can't apply yourself */
1752		1756
1753	/* Check to see if one of the movement types should be slowed down.	1757	/* Check to see if one of the movement types should be slowed down.
1754	* Second check makes sure that the movement types not being slowed	1758	* Second check makes sure that the movement types not being slowed
…		…
1759	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1763	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1760	{	1764	{
1761	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1765	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1762	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1766	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1763	{	1767	{
1764
1765	float
1766	diff = tmp->move_slow_penalty * fabs (op->speed);	1768	float diff = tmp->move_slow_penalty * fabs (op->speed);
1767		1769
1768	if (op->type == PLAYER)	1770	if (op->is_player ())
1769	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1771	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1770	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1772	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1771	diff /= 4.0;	1773	diff /= 4.0;
1772		1774
1773	op->speed_left -= diff;	1775	op->speed_left -= diff;
1774	}	1776	}
1775	}	1777	}
…		…
1808	LOG (llevError, "Present_arch called outside map.\n");	1810	LOG (llevError, "Present_arch called outside map.\n");
1809	return NULL;	1811	return NULL;
1810	}	1812	}
1811		1813
1812	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1814	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1813	if (tmp->arch == at)	1815	if (tmp->arch->archname == at->archname)
1814	return tmp;	1816	return tmp;
1815		1817
1816	return NULL;	1818	return NULL;
1817	}	1819	}
1818		1820
…		…
1882	* The first matching object is returned, or NULL if none.	1884	* The first matching object is returned, or NULL if none.
1883	*/	1885	*/
1884	object *	1886	object *
1885	present_arch_in_ob (const archetype *at, const object *op)	1887	present_arch_in_ob (const archetype *at, const object *op)
1886	{	1888	{
1887	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1889	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1888	if (tmp->arch == at)	1890	if (tmp->arch->archname == at->archname)
1889	return tmp;	1891	return tmp;
1890		1892
1891	return NULL;	1893	return NULL;
1892	}	1894	}
1893		1895
…		…
1981	* head of the object should correspond for the entire object.	1983	* head of the object should correspond for the entire object.
1982	*/	1984	*/
1983	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1985	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1984	continue;	1986	continue;
1985		1987
1986	if (ob->blocked (m, pos.x, pos.y))	1988	if (ob->blocked (pos.m, pos.x, pos.y))
1987	continue;	1989	continue;
1988		1990
1989	altern [index++] = i;	1991	altern [index++] = i;
1990	}	1992	}
1991		1993
…		…
2059	* there is capable of.	2061	* there is capable of.
2060	*/	2062	*/
2061	int	2063	int
2062	find_dir (maptile *m, int x, int y, object *exclude)	2064	find_dir (maptile *m, int x, int y, object *exclude)
2063	{	2065	{
2064	int i, max = SIZEOFFREE, mflags;	2066	int max = SIZEOFFREE, mflags;
2065
2066	sint16 nx, ny;
2067	object *tmp;
2068	maptile *mp;
2069
2070	MoveType blocked, move_type;	2067	MoveType move_type;
2071		2068
2072	if (exclude && exclude->head_ () != exclude)	2069	if (exclude && exclude->head_ () != exclude)
2073	{	2070	{
2074	exclude = exclude->head;	2071	exclude = exclude->head;
2075	move_type = exclude->move_type;	2072	move_type = exclude->move_type;
…		…
2078	{	2075	{
2079	/* If we don't have anything, presume it can use all movement types. */	2076	/* If we don't have anything, presume it can use all movement types. */
2080	move_type = MOVE_ALL;	2077	move_type = MOVE_ALL;
2081	}	2078	}
2082		2079
2083	for (i = 1; i < max; i++)	2080	for (int i = 1; i < max; i++)
2084	{	2081	{
2085	mp = m;	2082	mapxy pos (m, x, y);
2086	nx = x + freearr_x[i];	2083	pos.move (i);
2087	ny = y + freearr_y[i];
2088		2084
2089	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2085	if (!pos.normalise ())
2090
2091	if (mflags & P_OUT_OF_MAP)
2092	max = maxfree[i];	2086	max = maxfree[i];
2093	else	2087	else
2094	{	2088	{
2095	mapspace &ms = mp->at (nx, ny);	2089	mapspace &ms = *pos;
2096		2090
2097	blocked = ms.move_block;
2098
2099	if ((move_type & blocked) == move_type)	2091	if ((move_type & ms.move_block) == move_type)
2100	max = maxfree[i];	2092	max = maxfree [i];
2101	else if (mflags & P_IS_ALIVE)	2093	else if (ms.flags () & P_IS_ALIVE)
2102	{	2094	{
2103	for (tmp = ms.bot; tmp; tmp = tmp->above)	2095	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2104	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2096	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2105	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2097	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2106	break;
2107
2108	if (tmp)
2109	return freedir[i];	2098	return freedir [i];
2110	}	2099	}
2111	}	2100	}
2112	}	2101	}
2113		2102
2114	return 0;	2103	return 0;
…		…
2189	* This basically means that if direction is 15, then it could either go	2178	* This basically means that if direction is 15, then it could either go
2190	* direction 4, 14, or 16 to get back to where we are.	2179	* direction 4, 14, or 16 to get back to where we are.
2191	* Moved from spell_util.c to object.c with the other related direction	2180	* Moved from spell_util.c to object.c with the other related direction
2192	* functions.	2181	* functions.
2193	*/	2182	*/
2194	int reduction_dir[SIZEOFFREE][3] = {	2183	const int reduction_dir[SIZEOFFREE][3] = {
2195	{0, 0, 0}, /* 0 */	2184	{0, 0, 0}, /* 0 */
2196	{0, 0, 0}, /* 1 */	2185	{0, 0, 0}, /* 1 */
2197	{0, 0, 0}, /* 2 */	2186	{0, 0, 0}, /* 2 */
2198	{0, 0, 0}, /* 3 */	2187	{0, 0, 0}, /* 3 */
2199	{0, 0, 0}, /* 4 */	2188	{0, 0, 0}, /* 4 */
…		…
2295	int	2284	int
2296	can_pick (const object *who, const object *item)	2285	can_pick (const object *who, const object *item)
2297	{	2286	{
2298	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2287	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2299	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2288	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2300	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2289	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2301	}	2290	}
2302		2291
2303	/*	2292	/*
2304	* create clone from object to another	2293	* create clone from object to another
2305	*/	2294	*/
2306	object *	2295	object *
2307	object_create_clone (object *asrc)	2296	object::deep_clone ()
2308	{	2297	{
2309	object *dst = 0, *tmp, *src, *prev, *item;	2298	assert (("deep_clone called on non-head object", is_head ()));
2310		2299
2311	if (!asrc)	2300	object *dst = clone ();
2312	return 0;
2313		2301
2314	src = asrc->head_ ();	2302	object *prev = dst;
2315
2316	prev = 0;
2317	for (object *part = src; part; part = part->more)	2303	for (object *part = this->more; part; part = part->more)
2318	{	2304	{
2319	tmp = part->clone ();	2305	object *tmp = part->clone ();
2320	tmp->x -= src->x;
2321	tmp->y -= src->y;
2322
2323	if (!part->head)
2324	{
2325	dst = tmp;
2326	tmp->head = 0;
2327	}
2328	else
2329	tmp->head = dst;	2306	tmp->head = dst;
2330
2331	tmp->more = 0;
2332
2333	if (prev)
2334	prev->more = tmp;	2307	prev->more = tmp;
2335
2336	prev = tmp;	2308	prev = tmp;
2337	}	2309	}
2338		2310
2339	for (item = src->inv; item; item = item->below)	2311	for (object *item = inv; item; item = item->below)
2340	insert_ob_in_ob (object_create_clone (item), dst);	2312	insert_ob_in_ob (item->deep_clone (), dst);
2341		2313
2342	return dst;	2314	return dst;
2343	}	2315	}
2344		2316
2345	/* This returns the first object in who's inventory that	2317	/* This returns the first object in who's inventory that
…		…
2354	return tmp;	2326	return tmp;
2355		2327
2356	return 0;	2328	return 0;
2357	}	2329	}
2358		2330
2359	/* If ob has a field named key, return the link from the list,	2331	shstr_tmp
2360	* otherwise return NULL.	2332	object::kv_get (shstr_tmp key) const
2361	*
2362	* key must be a passed in shared string - otherwise, this won't
2363	* do the desired thing.
2364	*/
2365	key_value *
2366	get_ob_key_link (const object *ob, const char *key)
2367	{	2333	{
2368	for (key_value *link = ob->key_values; link; link = link->next)	2334	for (key_value *kv = key_values; kv; kv = kv->next)
2369	if (link->key == key)	2335	if (kv->key == key)
2370	return link;
2371
2372	return 0;
2373	}
2374
2375	/*
2376	* Returns the value of op has an extra_field for key, or NULL.
2377	*
2378	* The argument doesn't need to be a shared string.
2379	*
2380	* The returned string is shared.
2381	*/
2382	const char *
2383	get_ob_key_value (const object *op, const char *const key)
2384	{
2385	key_value *link;
2386	shstr_cmp canonical_key (key);
2387
2388	if (!canonical_key)
2389	{
2390	/* 1. There being a field named key on any object
2391	* implies there'd be a shared string to find.
2392	* 2. Since there isn't, no object has this field.
2393	* 3. Therefore, *this* object doesn't have this field.
2394	*/
2395	return 0;
2396	}
2397
2398	/* This is copied from get_ob_key_link() above -
2399	* only 4 lines, and saves the function call overhead.
2400	*/
2401	for (link = op->key_values; link; link = link->next)
2402	if (link->key == canonical_key)
2403	return link->value;	2336	return kv->value;
2404		2337
2405	return 0;	2338	return shstr ();
2406	}	2339	}
2407		2340
2408	/*	2341	void
2409	* Updates the canonical_key in op to value.	2342	object::kv_set (shstr_tmp key, shstr_tmp value)
2410	*
2411	* canonical_key is a shared string (value doesn't have to be).
2412	*
2413	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2414	* keys.
2415	*
2416	* Returns TRUE on success.
2417	*/
2418	int
2419	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2420	{	2343	{
2421	key_value *field = NULL, *last = NULL;	2344	for (key_value *kv = key_values; kv; kv = kv->next)
2422		2345	if (kv->key == key)
2423	for (field = op->key_values; field != NULL; field = field->next)
2424	{
2425	if (field->key != canonical_key)
2426	{	2346	{
2427	last = field;	2347	kv->value = value;
2428	continue;	2348	return;
2429	}	2349	}
2430		2350
2431	if (value)	2351	key_value *kv = new key_value;
2432	field->value = value;	2352
2433	else	2353	kv->next = key_values;
		2354	kv->key = key;
		2355	kv->value = value;
		2356
		2357	key_values = kv;
		2358	}
		2359
		2360	void
		2361	object::kv_del (shstr_tmp key)
		2362	{
		2363	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2364	if ((*kvp)->key == key)
2434	{	2365	{
2435	/* Basically, if the archetype has this key set,	2366	key_value *kv = *kvp;
2436	* we need to store the null value so when we save	2367	*kvp = (*kvp)->next;
2437	* it, we save the empty value so that when we load,	2368	delete kv;
2438	* we get this value back again.	2369	return;
2439	*/
2440	if (get_ob_key_link (op->arch, canonical_key))
2441	field->value = 0;
2442	else
2443	{
2444	if (last)
2445	last->next = field->next;
2446	else
2447	op->key_values = field->next;
2448
2449	delete field;
2450	}
2451	}	2370	}
2452	return TRUE;
2453	}
2454	/* IF we get here, key doesn't exist */
2455
2456	/* No field, we'll have to add it. */
2457
2458	if (!add_key)
2459	return FALSE;
2460
2461	/* There isn't any good reason to store a null
2462	* value in the key/value list. If the archetype has
2463	* this key, then we should also have it, so shouldn't
2464	* be here. If user wants to store empty strings,
2465	* should pass in ""
2466	*/
2467	if (value == NULL)
2468	return TRUE;
2469
2470	field = new key_value;
2471
2472	field->key = canonical_key;
2473	field->value = value;
2474	/* Usual prepend-addition. */
2475	field->next = op->key_values;
2476	op->key_values = field;
2477
2478	return TRUE;
2479	}
2480
2481	/*
2482	* Updates the key in op to value.
2483	*
2484	* If add_key is FALSE, this will only update existing keys,
2485	* and not add new ones.
2486	* In general, should be little reason FALSE is ever passed in for add_key
2487	*
2488	* Returns TRUE on success.
2489	*/
2490	int
2491	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2492	{
2493	shstr key_ (key);
2494
2495	return set_ob_key_value_s (op, key_, value, add_key);
2496	}	2371	}
2497		2372
2498	object::depth_iterator::depth_iterator (object *container)	2373	object::depth_iterator::depth_iterator (object *container)
2499	: iterator_base (container)	2374	: iterator_base (container)
2500	{	2375	{
…		…
2550	{	2425	{
2551	char flagdesc[512];	2426	char flagdesc[512];
2552	char info2[256 * 4];	2427	char info2[256 * 4];
2553	char *p = info;	2428	char *p = info;
2554		2429
2555	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2430	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2556	count,	2431	count,
2557	uuid.c_str (),	2432	uuid.c_str (),
2558	&name,	2433	&name,
2559	title ? "\",title:\"" : "",	2434	title ? ",title:\"" : "",
2560	title ? (const char *)title : "",	2435	title ? (const char *)title : "",
		2436	title ? "\"" : "",
2561	flag_desc (flagdesc, 512), type);	2437	flag_desc (flagdesc, 512), type);
2562		2438
2563	if (!this->flag[FLAG_REMOVED] && env)	2439	if (!flag[FLAG_REMOVED] && env)
2564	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2440	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2565		2441
2566	if (map)	2442	if (map)
2567	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2443	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2568		2444
…		…
2598	object::open_container (object *new_container)	2474	object::open_container (object *new_container)
2599	{	2475	{
2600	if (container == new_container)	2476	if (container == new_container)
2601	return;	2477	return;
2602		2478
2603	if (object *old_container = container)	2479	object *old_container = container;
		2480
		2481	if (old_container)
2604	{	2482	{
2605	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2483	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2606	return;	2484	return;
2607		2485
2608	#if 0	2486	#if 0
…		…
2610	if (object *closer = old_container->inv)	2488	if (object *closer = old_container->inv)
2611	if (closer->type == CLOSE_CON)	2489	if (closer->type == CLOSE_CON)
2612	closer->destroy ();	2490	closer->destroy ();
2613	#endif	2491	#endif
2614		2492
		2493	// make sure the container is available
		2494	esrv_send_item (this, old_container);
		2495
2615	old_container->flag [FLAG_APPLIED] = 0;	2496	old_container->flag [FLAG_APPLIED] = false;
2616	container = 0;	2497	container = 0;
2617		2498
		2499	// client needs item update to make it work, client bug requires this to be separate
2618	esrv_update_item (UPD_FLAGS, this, old_container);	2500	esrv_update_item (UPD_FLAGS, this, old_container);
		2501
2619	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2502	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2620	play_sound (sound_find ("chest_close"));	2503	play_sound (sound_find ("chest_close"));
2621	}	2504	}
2622		2505
2623	if (new_container)	2506	if (new_container)
2624	{	2507	{
…		…
2634	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2517	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2635	new_container->insert (closer);	2518	new_container->insert (closer);
2636	}	2519	}
2637	#endif	2520	#endif
2638		2521
2639	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2522	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2640		2523
		2524	// make sure the container is available, client bug requires this to be separate
		2525	esrv_send_item (this, new_container);
		2526
2641	new_container->flag [FLAG_APPLIED] = 1;	2527	new_container->flag [FLAG_APPLIED] = true;
2642	container = new_container;	2528	container = new_container;
2643		2529
		2530	// client needs flag change
2644	esrv_update_item (UPD_FLAGS, this, new_container);	2531	esrv_update_item (UPD_FLAGS, this, new_container);
2645	esrv_send_inventory (this, new_container);	2532	esrv_send_inventory (this, new_container);
2646	play_sound (sound_find ("chest_open"));	2533	play_sound (sound_find ("chest_open"));
2647	}	2534	}
		2535	// else if (!old_container->env && contr && contr->ns)
		2536	// contr->ns->floorbox_reset ();
2648	}	2537	}
2649		2538
2650	object *	2539	object *
2651	object::force_find (const shstr name)	2540	object::force_find (shstr_tmp name)
2652	{	2541	{
2653	/* cycle through his inventory to look for the MARK we want to	2542	/* cycle through his inventory to look for the MARK we want to
2654	* place	2543	* place
2655	*/	2544	*/
2656	for (object *tmp = inv; tmp; tmp = tmp->below)	2545	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2659		2548
2660	return 0;	2549	return 0;
2661	}	2550	}
2662		2551
2663	void	2552	void
		2553	object::force_set_timer (int duration)
		2554	{
		2555	this->duration = 1;
		2556	this->speed_left = -1.f;
		2557
		2558	this->set_speed (duration ? 1.f / duration : 0.f);
		2559	}
		2560
		2561	object *
2664	object::force_add (const shstr name, int duration)	2562	object::force_add (shstr_tmp name, int duration)
2665	{	2563	{
2666	if (object *force = force_find (name))	2564	if (object *force = force_find (name))
2667	force->destroy ();	2565	force->destroy ();
2668		2566
2669	object *force = get_archetype (FORCE_NAME);	2567	object *force = get_archetype (FORCE_NAME);
2670		2568
2671	force->slaying = name;	2569	force->slaying = name;
2672	force->stats.food = 1;
2673	force->speed_left = -1.f;
2674		2570
2675	force->set_speed (duration ? 1.f / duration : 0.f);	2571	force->force_set_timer (duration);
2676	force->flag [FLAG_IS_USED_UP] = true;	2572
2677	force->flag [FLAG_APPLIED] = true;	2573	force->flag [FLAG_APPLIED] = true;
2678		2574
2679	insert (force);	2575	return insert (force);
2680	}	2576	}
2681		2577
2682	void	2578	void
2683	object::play_sound (faceidx sound)	2579	object::play_sound (faceidx sound) const
2684	{	2580	{
2685	if (!sound)	2581	if (!sound)
2686	return;	2582	return;
2687		2583
2688	if (flag [FLAG_REMOVED])	2584	if (is_on_map ())
		2585	map->play_sound (sound, x, y);
		2586	else if (object *pl = in_player ())
		2587	pl->contr->play_sound (sound);
		2588	}
		2589
		2590	void
		2591	object::say_msg (const char *msg) const
		2592	{
		2593	if (is_on_map ())
		2594	map->say_msg (msg, x, y);
		2595	else if (object *pl = in_player ())
		2596	pl->contr->play_sound (sound);
		2597	}
		2598
		2599	void
		2600	object::make_noise ()
		2601	{
		2602	// we do not model noise in the map, so instead put
		2603	// a temporary light into the noise source
		2604	// could use the map instead, but that's less reliable for our
		2605	// goal, which is to make invisibility a bit harder to exploit
		2606
		2607	// currently only works sensibly for players
		2608	if (!is_player ())
2689	return;	2609	return;
2690		2610
2691	if (env)	2611	// find old force, or create new one
2692	{	2612	object *force = force_find (shstr_noise_force);
2693	if (object *pl = in_player ())	2613
2694	pl->contr->play_sound (sound);	2614	if (force)
2695	}	2615	force->speed_left = -1.f; // patch old speed up
2696	else	2616	else
2697	map->play_sound (sound, x, y);	2617	{
2698	}	2618	force = archetype::get (shstr_noise_force);
2699		2619
		2620	force->slaying = shstr_noise_force;
		2621	force->stats.food = 1;
		2622	force->speed_left = -1.f;
		2623
		2624	force->set_speed (1.f / 4.f);
		2625	force->flag [FLAG_IS_USED_UP] = true;
		2626	force->flag [FLAG_APPLIED] = true;
		2627
		2628	insert (force);
		2629	}
		2630	}
		2631

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines