ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.210 by root, Mon Apr 21 07:01:40 2008 UTC vs.
Revision 1.292 by root, Mon Oct 19 21:48:49 2009 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
25	#include <stdio.h>	26	#include <stdio.h>
26	#include <sys/types.h>	27	#include <sys/types.h>
27	#include <sys/uio.h>	28	#include <sys/uio.h>
28	#include <object.h>	29	#include <object.h>
29	#include <funcpoint.h>
30	#include <sproto.h>	30	#include <sproto.h>
31	#include <loader.h>	31	#include <loader.h>
32		32
33	#include <bitset>	33	#include <bitset>
34		34
35	UUID UUID::cur;	35	UUID UUID::cur;
36	static uint64_t seq_next_save;	36	static uint64_t seq_next_save;
37	static const uint64 UUID_GAP = 1<<19;	37	static const uint64 UUID_GAP = 1<<19;
		38	uint32_t mapspace::smellcount = 10000;
38		39
39	objectvec objects;	40	objectvec objects;
40	activevec actives;	41	activevec actives;
41		42
42	short freearr_x[SIZEOFFREE] = {	43	short freearr_x[SIZEOFFREE] = {
…		…
140		141
141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	142	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
142	static bool	143	static bool
143	compare_ob_value_lists_one (const object *wants, const object *has)	144	compare_ob_value_lists_one (const object *wants, const object *has)
144	{	145	{
145	key_value *wants_field;
146
147	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	146	/* n-squared behaviour (see kv_get), but I'm hoping both
148	* objects with lists are rare, and lists stay short. If not, use a	147	* objects with lists are rare, and lists stay short. If not, use a
149	* different structure or at least keep the lists sorted...	148	* different structure or at least keep the lists sorted...
150	*/	149	*/
151		150
152	/* For each field in wants, */	151	/* For each field in wants, */
153	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	152	for (key_value *kv = wants->key_values; kv; kv = kv->next)
154	{	153	if (has->kv_get (kv->key) != kv->value)
155	key_value *has_field;	154	return false;
156
157	/* Look for a field in has with the same key. */
158	has_field = get_ob_key_link (has, wants_field->key);
159
160	if (!has_field)
161	return 0; /* No field with that name. */
162
163	/* Found the matching field. */
164	if (has_field->value != wants_field->value)
165	return 0; /* Values don't match, so this half of the comparison is false. */
166
167	/* If we get here, we found a match. Now for the next field in wants. */
168	}
169		155
170	/* If we get here, every field in wants has a matching field in has. */	156	/* If we get here, every field in wants has a matching field in has. */
171	return 1;	157	return true;
172	}	158	}
173		159
174	/* Returns TRUE if ob1 has the same key_values as ob2. */	160	/* Returns TRUE if ob1 has the same key_values as ob2. */
175	static bool	161	static bool
176	compare_ob_value_lists (const object *ob1, const object *ob2)	162	compare_ob_value_lists (const object *ob1, const object *ob2)
177	{	163	{
178	/* However, there may be fields in has which aren't partnered in wants,	164	/* However, there may be fields in has which aren't partnered in wants,
179	* so we need to run the comparison *twice*. :(	165	* so we need to run the comparison *twice*. :(
180	*/	166	*/
181	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	167	return compare_ob_value_lists_one (ob1, ob2)
		168	&& compare_ob_value_lists_one (ob2, ob1);
182	}	169	}
183		170
184	/* Function examines the 2 objects given to it, and returns true if	171	/* Function examines the 2 objects given to it, and returns true if
185	* they can be merged together.	172	* they can be merged together.
186	*	173	*
…		…
201	|| ob1->speed != ob2->speed	188	|| ob1->speed != ob2->speed
202	|| ob1->value != ob2->value	189	|| ob1->value != ob2->value
203	|| ob1->name != ob2->name)	190	|| ob1->name != ob2->name)
204	return 0;	191	return 0;
205		192
206	/* Do not merge objects if nrof would overflow. First part checks	193	/* Do not merge objects if nrof would overflow, assume nrof
207	* for unsigned overflow (2c), second part checks whether the result	194	* is always 0 .. 2**31-1 */
208	* would fit into a 32 bit signed int, which is often used to hold	195	if (ob1->nrof > 0x7fffffff - ob2->nrof)
209	* nrof values.
210	*/
211	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
212	return 0;	196	return 0;
213		197
214	/* If the objects have been identified, set the BEEN_APPLIED flag.	198	/* If the objects have been identified, set the BEEN_APPLIED flag.
215	* This is to the comparison of the flags below will be OK. We	199	* This is to the comparison of the flags below will be OK. We
216	* just can't ignore the been applied or identified flags, as they	200	* just can't ignore the been applied or identified flags, as they
…		…
221	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	205	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222		206
223	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	207	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	208	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225		209
226	if (ob1->arch->name != ob2->arch->name	210	if (ob1->arch->archname != ob2->arch->archname
227	|| ob1->name != ob2->name	211	|| ob1->name != ob2->name
228	|| ob1->title != ob2->title	212	|| ob1->title != ob2->title
229	|| ob1->msg != ob2->msg	213	|| ob1->msg != ob2->msg
230	|| ob1->weight != ob2->weight	214	|| ob1->weight != ob2->weight
231	|| ob1->attacktype != ob2->attacktype	215	|| ob1->attacktype != ob2->attacktype
232	|| ob1->magic != ob2->magic	216	|| ob1->magic != ob2->magic
233	|| ob1->slaying != ob2->slaying	217	|| ob1->slaying != ob2->slaying
234	|| ob1->skill != ob2->skill	218	|| ob1->skill != ob2->skill
235	|| ob1->value != ob2->value	219	|| ob1->value != ob2->value
236	|| ob1->animation_id != ob2->animation_id	220	|| ob1->animation_id != ob2->animation_id
		221	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
237	|| ob1->client_type != ob2->client_type	222	|| ob1->client_type != ob2->client_type
238	|| ob1->materialname != ob2->materialname	223	|| ob1->materialname != ob2->materialname
239	|| ob1->lore != ob2->lore	224	|| ob1->lore != ob2->lore
240	|| ob1->subtype != ob2->subtype	225	|| ob1->subtype != ob2->subtype
241	|| ob1->move_type != ob2->move_type	226	|| ob1->move_type != ob2->move_type
…		…
249	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	234	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
250	return 0;	235	return 0;
251		236
252	if ((ob1->flag ^ ob2->flag)	237	if ((ob1->flag ^ ob2->flag)
253	.reset (FLAG_INV_LOCKED)	238	.reset (FLAG_INV_LOCKED)
254	.reset (FLAG_CLIENT_SENT)
255	.reset (FLAG_REMOVED)	239	.reset (FLAG_REMOVED)
256	.any ())	240	.any ())
257	return 0;	241	return 0;
258		242
259	/* This is really a spellbook check - we should in general	243	/* This is really a spellbook check - we should in general
…		…
331		315
332	/* Everything passes, must be OK. */	316	/* Everything passes, must be OK. */
333	return 1;	317	return 1;
334	}	318	}
335		319
		320	// find player who can see this object
		321	object *
		322	object::visible_to () const
		323	{
		324	if (client_visible () && !flag [FLAG_REMOVED])
		325	{
		326	// see if we are in a container of sorts
		327	if (env)
		328	{
		329	// the player inventory itself is always visible
		330	if (env->is_player ())
		331	return env;
		332
		333	// else a player could have our env open
		334	object *envest = env->outer_env_or_self ();
		335
		336	// the player itself is always on a map, so we will find him here
		337	// even if our inv is in a player.
		338	if (envest->is_on_map ())
		339	if (object *pl = envest->ms ().player ())
		340	if (pl->container_ () == env)
		341	return pl;
		342	}
		343	else
		344	{
		345	// maybe there is a player standing on the same mapspace
		346	// this will catch the case where "this" is a player
		347	if (object *pl = ms ().player ())
		348	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		349	|| pl->container_ () == this)
		350	return pl;
		351	}
		352	}
		353
		354	return 0;
		355	}
		356
336	// adjust weight per container type ("of holding")	357	// adjust weight per container type ("of holding")
337	static sint32	358	static sint32
338	weight_adjust (object *op, sint32 weight)	359	weight_adjust_for (object *op, sint32 weight)
339	{	360	{
340	return op->type == CONTAINER	361	return op->type == CONTAINER
341	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	362	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
342	: weight;	363	: weight;
343	}	364	}
…		…
349	static void	370	static void
350	adjust_weight (object *op, sint32 weight)	371	adjust_weight (object *op, sint32 weight)
351	{	372	{
352	while (op)	373	while (op)
353	{	374	{
		375	// adjust by actual difference to account for rounding errors
		376	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
354	weight = weight_adjust (op, weight);	377	weight = weight_adjust_for (op, op->carrying)
		378	- weight_adjust_for (op, op->carrying - weight);
		379
		380	if (!weight)
		381	return;
355		382
356	op->carrying += weight;	383	op->carrying += weight;
		384
		385	if (object *pl = op->visible_to ())
		386	if (pl != op) // player is handled lazily
		387	esrv_update_item (UPD_WEIGHT, pl, op);
		388
357	op = op->env;	389	op = op->env;
358	}	390	}
359	}	391	}
360		392
361	/*	393	/*
…		…
374	op->update_weight ();	406	op->update_weight ();
375		407
376	sum += op->total_weight ();	408	sum += op->total_weight ();
377	}	409	}
378		410
379	carrying = weight_adjust (this, sum);	411	sum = weight_adjust_for (this, sum);
		412
		413	if (sum != carrying)
		414	{
		415	carrying = sum;
		416
		417	if (object *pl = visible_to ())
		418	if (pl != this) // player is handled lazily
		419	esrv_update_item (UPD_WEIGHT, pl, this);
		420	}
380	}	421	}
381		422
382	/*	423	/*
383	* Used by: Server DM commands: dumpbelow, dump. Some error messages.	424	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
384	*/	425	*/
…		…
389	return strdup ("[NULLOBJ]");	430	return strdup ("[NULLOBJ]");
390		431
391	object_freezer freezer;	432	object_freezer freezer;
392	op->write (freezer);	433	op->write (freezer);
393	return freezer.as_string ();	434	return freezer.as_string ();
		435	}
		436
		437	char *
		438	object::as_string ()
		439	{
		440	return dump_object (this);
394	}	441	}
395		442
396	/*	443	/*
397	* get_nearest_part(multi-object, object 2) returns the part of the	444	* get_nearest_part(multi-object, object 2) returns the part of the
398	* multi-object 1 which is closest to the second object.	445	* multi-object 1 which is closest to the second object.
…		…
437	*/	484	*/
438	object *	485	object *
439	find_object_name (const char *str)	486	find_object_name (const char *str)
440	{	487	{
441	shstr_cmp str_ (str);	488	shstr_cmp str_ (str);
442	object *op;
443		489
		490	if (str_)
444	for_all_objects (op)	491	for_all_objects (op)
445	if (op->name == str_)	492	if (op->name == str_)
446	break;	493	return op;
447		494
448	return op;	495	return 0;
449	}	496	}
450		497
451	/*	498	/*
452	* Sets the owner and sets the skill and exp pointers to owner's current	499	* Sets the owner and sets the skill and exp pointers to owner's current
453	* skill and experience objects.	500	* skill and experience objects.
…		…
515	update_stats ();	562	update_stats ();
516		563
517	new_draw_info_format (NDI_UNIQUE, 0, this,	564	new_draw_info_format (NDI_UNIQUE, 0, this,
518	"You try to balance all your items at once, "	565	"You try to balance all your items at once, "
519	"but the %s is just too much for your body. "	566	"but the %s is just too much for your body. "
520	"[You need to unapply some items first.]", &ob->name);	567	"[You need to unapply some items first - use the 'body' command to see "
		568	"how many items you cna wera on a specific body part.]", &ob->name);
521	return false;	569	return false;
522	}	570	}
523		571
524	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);	572	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
525	}	573	}
…		…
551	}	599	}
552		600
553	op->key_values = 0;	601	op->key_values = 0;
554	}	602	}
555		603
556	object &	604	/*
557	object::operator =(const object &src)	605	* copy_to first frees everything allocated by the dst object,
		606	* and then copies the contents of itself into the second
		607	* object, allocating what needs to be allocated. Basically, any
		608	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		609	* if the first object is freed, the pointers in the new object
		610	* will point at garbage.
		611	*/
		612	void
		613	object::copy_to (object *dst)
558	{	614	{
559	bool is_freed = flag [FLAG_FREED];	615	dst->remove ();
560	bool is_removed = flag [FLAG_REMOVED];
561
562	*(object_copy *)this = src;	616	*(object_copy *)dst = *this;
563
564	flag [FLAG_FREED] = is_freed;
565	flag [FLAG_REMOVED] = is_removed;	617	dst->flag [FLAG_REMOVED] = true;
566		618
567	/* Copy over key_values, if any. */	619	/* Copy over key_values, if any. */
568	if (src.key_values)	620	if (key_values)
569	{	621	{
570	key_value *tail = 0;	622	key_value *tail = 0;
571	key_values = 0;	623	dst->key_values = 0;
572		624
573	for (key_value *i = src.key_values; i; i = i->next)	625	for (key_value *i = key_values; i; i = i->next)
574	{	626	{
575	key_value *new_link = new key_value;	627	key_value *new_link = new key_value;
576		628
577	new_link->next = 0;	629	new_link->next = 0;
578	new_link->key = i->key;	630	new_link->key = i->key;
579	new_link->value = i->value;	631	new_link->value = i->value;
580		632
581	/* Try and be clever here, too. */	633	/* Try and be clever here, too. */
582	if (!key_values)	634	if (!dst->key_values)
583	{	635	{
584	key_values = new_link;	636	dst->key_values = new_link;
585	tail = new_link;	637	tail = new_link;
586	}	638	}
587	else	639	else
588	{	640	{
589	tail->next = new_link;	641	tail->next = new_link;
590	tail = new_link;	642	tail = new_link;
591	}	643	}
592	}	644	}
593	}	645	}
594	}
595
596	/*
597	* copy_to first frees everything allocated by the dst object,
598	* and then copies the contents of itself into the second
599	* object, allocating what needs to be allocated. Basically, any
600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
601	* if the first object is freed, the pointers in the new object
602	* will point at garbage.
603	*/
604	void
605	object::copy_to (object *dst)
606	{
607	*dst = *this;
608		646
609	if (speed < 0)	647	if (speed < 0)
610	dst->speed_left -= rndm ();	648	dst->speed_left -= rndm ();
611		649
612	dst->set_speed (dst->speed);	650	dst->activate ();
613	}	651	}
614		652
615	void	653	void
616	object::instantiate ()	654	object::instantiate ()
617	{	655	{
…		…
634	object *	672	object *
635	object::clone ()	673	object::clone ()
636	{	674	{
637	object *neu = create ();	675	object *neu = create ();
638	copy_to (neu);	676	copy_to (neu);
		677	neu->map = map; // not copied by copy_to
639	return neu;	678	return neu;
640	}	679	}
641		680
642	/*	681	/*
643	* If an object with the IS_TURNABLE() flag needs to be turned due	682	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
694	* UP_OBJ_FACE: only the objects face has changed.	733	* UP_OBJ_FACE: only the objects face has changed.
695	*/	734	*/
696	void	735	void
697	update_object (object *op, int action)	736	update_object (object *op, int action)
698	{	737	{
699	if (op == NULL)	738	if (!op)
700	{	739	{
701	/* this should never happen */	740	/* this should never happen */
702	LOG (llevDebug, "update_object() called for NULL object.\n");	741	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
703	return;	742	return;
704	}	743	}
705		744
706	if (op->env)	745	if (!op->is_on_map ())
707	{	746	{
708	/* Animation is currently handled by client, so nothing	747	/* Animation is currently handled by client, so nothing
709	* to do in this case.	748	* to do in this case.
710	*/	749	*/
711	return;	750	return;
712	}	751	}
713
714	/* If the map is saving, don't do anything as everything is
715	* going to get freed anyways.
716	*/
717	if (!op->map || op->map->in_memory == MAP_SAVING)
718	return;
719		752
720	/* make sure the object is within map boundaries */	753	/* make sure the object is within map boundaries */
721	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	754	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
722	{	755	{
723	LOG (llevError, "update_object() called for object out of map!\n");	756	LOG (llevError, "update_object() called for object out of map!\n");
…		…
734	else if (action == UP_OBJ_INSERT)	767	else if (action == UP_OBJ_INSERT)
735	{	768	{
736	// this is likely overkill, TODO: revisit (schmorp)	769	// this is likely overkill, TODO: revisit (schmorp)
737	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	770	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
738	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	771	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
739	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	772	|| (op->is_player () && !(m.flags_ & P_PLAYER))
740	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	773	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
741	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	774	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
742	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	775	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
743	|| (m.move_on | op->move_on ) != m.move_on	776	|| (m.move_on | op->move_on ) != m.move_on
744	|| (m.move_off | op->move_off ) != m.move_off	777	|| (m.move_off | op->move_off ) != m.move_off
745	|| (m.move_slow | op->move_slow) != m.move_slow	778	|| (m.move_slow | op->move_slow) != m.move_slow
746	/* This isn't perfect, but I don't expect a lot of objects to	779	/* This isn't perfect, but I don't expect a lot of objects to
747	* to have move_allow right now.	780	* have move_allow right now.
748	*/	781	*/
749	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	782	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
750	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	783	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
751	m.flags_ = 0;	784	m.invalidate ();
752	}	785	}
753	/* if the object is being removed, we can't make intelligent	786	/* if the object is being removed, we can't make intelligent
754	* decisions, because remove_ob can't really pass the object	787	* decisions, because remove_ob can't really pass the object
755	* that is being removed.	788	* that is being removed.
756	*/	789	*/
757	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	790	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
758	m.flags_ = 0;	791	m.invalidate ();
759	else if (action == UP_OBJ_FACE)	792	else if (action == UP_OBJ_FACE)
760	/* Nothing to do for that case */ ;	793	/* Nothing to do for that case */ ;
761	else	794	else
762	LOG (llevError, "update_object called with invalid action: %d\n", action);	795	LOG (llevError, "update_object called with invalid action: %d\n", action);
763		796
…		…
767		800
768	object::object ()	801	object::object ()
769	{	802	{
770	SET_FLAG (this, FLAG_REMOVED);	803	SET_FLAG (this, FLAG_REMOVED);
771		804
772	expmul = 1.0;	805	//expmul = 1.0; declared const for the time being
773	face = blank_face;	806	face = blank_face;
774	}	807	}
775		808
776	object::~object ()	809	object::~object ()
777	{	810	{
…		…
807	/* If already on active list, don't do anything */	840	/* If already on active list, don't do anything */
808	if (active)	841	if (active)
809	return;	842	return;
810		843
811	if (has_active_speed ())	844	if (has_active_speed ())
		845	{
		846	if (flag [FLAG_FREED])
		847	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		848
812	actives.insert (this);	849	actives.insert (this);
		850	}
813	}	851	}
814		852
815	void	853	void
816	object::activate_recursive ()	854	object::activate_recursive ()
817	{	855	{
…		…
866	object::destroy_inv (bool drop_to_ground)	904	object::destroy_inv (bool drop_to_ground)
867	{	905	{
868	// need to check first, because the checks below might segfault	906	// need to check first, because the checks below might segfault
869	// as we might be on an invalid mapspace and crossfire code	907	// as we might be on an invalid mapspace and crossfire code
870	// is too buggy to ensure that the inventory is empty.	908	// is too buggy to ensure that the inventory is empty.
871	// corollary: if you create arrows etc. with stuff in tis inventory,	909	// corollary: if you create arrows etc. with stuff in its inventory,
872	// cf will crash below with off-map x and y	910	// cf will crash below with off-map x and y
873	if (!inv)	911	if (!inv)
874	return;	912	return;
875		913
876	/* Only if the space blocks everything do we not process -	914	/* Only if the space blocks everything do we not process -
…		…
878	* drop on that space.	916	* drop on that space.
879	*/	917	*/
880	if (!drop_to_ground	918	if (!drop_to_ground
881	|| !map	919	|| !map
882	|| map->in_memory != MAP_ACTIVE	920	|| map->in_memory != MAP_ACTIVE
883	|| map->nodrop	921	|| map->no_drop
884	|| ms ().move_block == MOVE_ALL)	922	|| ms ().move_block == MOVE_ALL)
885	{	923	{
886	while (inv)	924	while (inv)
887	{
888	inv->destroy_inv (drop_to_ground);
889	inv->destroy ();	925	inv->destroy ();
890	}
891	}	926	}
892	else	927	else
893	{ /* Put objects in inventory onto this space */	928	{ /* Put objects in inventory onto this space */
894	while (inv)	929	while (inv)
895	{	930	{
…		…
913	object *op = new object;	948	object *op = new object;
914	op->link ();	949	op->link ();
915	return op;	950	return op;
916	}	951	}
917		952
		953	static struct freed_map : maptile
		954	{
		955	freed_map ()
		956	{
		957	path = "<freed objects map>";
		958	name = "/internal/freed_objects_map";
		959	width = 3;
		960	height = 3;
		961	no_drop = 1;
		962	no_reset = 1;
		963
		964	alloc ();
		965	in_memory = MAP_ACTIVE;
		966	}
		967
		968	~freed_map ()
		969	{
		970	destroy ();
		971	}
		972	} freed_map; // freed objects are moved here to avoid crashes
		973
918	void	974	void
919	object::do_destroy ()	975	object::do_destroy ()
920	{	976	{
921	attachable::do_destroy ();
922
923	if (flag [FLAG_IS_LINKED])	977	if (flag [FLAG_IS_LINKED])
924	remove_button_link (this);	978	remove_link ();
925		979
926	if (flag [FLAG_FRIENDLY])	980	if (flag [FLAG_FRIENDLY])
927	remove_friendly_object (this);	981	remove_friendly_object (this);
928		982
929	if (!flag [FLAG_REMOVED])
930	remove ();	983	remove ();
931		984
932	destroy_inv (true);	985	attachable::do_destroy ();
933		986
934	deactivate ();	987	deactivate ();
935	unlink ();	988	unlink ();
936		989
937	flag [FLAG_FREED] = 1;	990	flag [FLAG_FREED] = 1;
938		991
939	// hack to ensure that freed objects still have a valid map	992	// hack to ensure that freed objects still have a valid map
940	{
941	static maptile *freed_map; // freed objects are moved here to avoid crashes
942
943	if (!freed_map)
944	{
945	freed_map = new maptile;
946
947	freed_map->path = "<freed objects map>";
948	freed_map->name = "/internal/freed_objects_map";
949	freed_map->width = 3;
950	freed_map->height = 3;
951	freed_map->nodrop = 1;
952
953	freed_map->alloc ();
954	freed_map->in_memory = MAP_ACTIVE;
955	}
956
957	map = freed_map;	993	map = &freed_map;
958	x = 1;	994	x = 1;
959	y = 1;	995	y = 1;
960	}
961		996
962	if (more)	997	if (more)
963	{	998	{
964	more->destroy ();	999	more->destroy ();
965	more = 0;	1000	more = 0;
…		…
973	attacked_by = 0;	1008	attacked_by = 0;
974	current_weapon = 0;	1009	current_weapon = 0;
975	}	1010	}
976		1011
977	void	1012	void
978	object::destroy (bool destroy_inventory)	1013	object::destroy ()
979	{	1014	{
980	if (destroyed ())	1015	if (destroyed ())
981	return;	1016	return;
982		1017
983	if (destroy_inventory)	1018	if (!is_head () && !head->destroyed ())
		1019	{
		1020	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1021	head->destroy ();
		1022	return;
		1023	}
		1024
984	destroy_inv (false);	1025	destroy_inv (false);
985		1026
986	if (is_head ())	1027	if (is_head ())
987	if (sound_destroy)	1028	if (sound_destroy)
988	play_sound (sound_destroy);	1029	play_sound (sound_destroy);
989	else if (flag [FLAG_MONSTER])	1030	else if (flag [FLAG_MONSTER])
…		…
1003	object::do_remove ()	1044	object::do_remove ()
1004	{	1045	{
1005	object *tmp, *last = 0;	1046	object *tmp, *last = 0;
1006	object *otmp;	1047	object *otmp;
1007		1048
1008	if (QUERY_FLAG (this, FLAG_REMOVED))	1049	if (flag [FLAG_REMOVED])
1009	return;	1050	return;
1010		1051
1011	SET_FLAG (this, FLAG_REMOVED);
1012	INVOKE_OBJECT (REMOVE, this);	1052	INVOKE_OBJECT (REMOVE, this);
		1053
		1054	flag [FLAG_REMOVED] = true;
1013		1055
1014	if (more)	1056	if (more)
1015	more->remove ();	1057	more->remove ();
1016		1058
1017	/*	1059	/*
1018	* In this case, the object to be removed is in someones	1060	* In this case, the object to be removed is in someones
1019	* inventory.	1061	* inventory.
1020	*/	1062	*/
1021	if (env)	1063	if (env)
1022	{	1064	{
		1065	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1066	if (object *pl = visible_to ())
		1067	esrv_del_item (pl->contr, count);
		1068	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1069
1023	adjust_weight (env, -total_weight ());	1070	adjust_weight (env, -total_weight ());
1024		1071
1025	*(above ? &above->below : &env->inv) = below;	1072	object *pl = in_player ();
1026
1027	if (below)
1028	below->above = above;
1029		1073
1030	/* we set up values so that it could be inserted into	1074	/* we set up values so that it could be inserted into
1031	* the map, but we don't actually do that - it is up	1075	* the map, but we don't actually do that - it is up
1032	* to the caller to decide what we want to do.	1076	* to the caller to decide what we want to do.
1033	*/	1077	*/
1034	map = env->map;	1078	map = env->map;
1035	x = env->x;	1079	x = env->x;
1036	y = env->y;	1080	y = env->y;
		1081
		1082	// make sure cmov optimisation is applicable
		1083	*(above ? &above->below : &env->inv) = below;
		1084	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1085
1037	above = 0;	1086	above = 0;
1038	below = 0;	1087	below = 0;
1039	env = 0;	1088	env = 0;
1040		1089
1041	/* NO_FIX_PLAYER is set when a great many changes are being	1090	/* NO_FIX_PLAYER is set when a great many changes are being
1042	* made to players inventory. If set, avoiding the call	1091	* made to players inventory. If set, avoiding the call
1043	* to save cpu time.	1092	* to save cpu time.
1044	*/	1093	*/
1045	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1094	if (pl)
		1095	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1096	{
1046	otmp->update_stats ();	1097	pl->update_stats ();
		1098
		1099	if (glow_radius && pl->is_on_map ())
		1100	update_all_los (pl->map, pl->x, pl->y);
		1101	}
1047	}	1102	}
1048	else if (map)	1103	else if (map)
1049	{	1104	{
1050	if (type == PLAYER)
1051	{
1052	// leaving a spot always closes any open container on the ground
1053	if (container && !container->env)
1054	// this causes spurious floorbox updates, but it ensures
1055	// that the CLOSE event is being sent.
1056	close_container ();
1057
1058	--map->players;
1059	map->touch ();
1060	}
1061
1062	map->dirty = true;	1105	map->dirty = true;
1063	mapspace &ms = this->ms ();	1106	mapspace &ms = this->ms ();
1064		1107
		1108	if (object *pl = ms.player ())
		1109	{
		1110	if (is_player ())
		1111	{
		1112	if (!flag [FLAG_WIZPASS])
		1113	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1114
		1115	// leaving a spot always closes any open container on the ground
		1116	if (container && !container->env)
		1117	// this causes spurious floorbox updates, but it ensures
		1118	// that the CLOSE event is being sent.
		1119	close_container ();
		1120
		1121	--map->players;
		1122	map->touch ();
		1123	}
		1124	else if (pl->container_ () == this)
		1125	{
		1126	// removing a container should close it
		1127	close_container ();
		1128	}
		1129
		1130	esrv_del_item (pl->contr, count);
		1131	}
		1132
1065	/* link the object above us */	1133	/* link the object above us */
1066	if (above)	1134	// re-link, make sure compiler can easily use cmove
1067	above->below = below;	1135	*(above ? &above->below : &ms.top) = below;
1068	else	1136	*(below ? &below->above : &ms.bot) = above;
1069	ms.top = below; /* we were top, set new top */
1070
1071	/* Relink the object below us, if there is one */
1072	if (below)
1073	below->above = above;
1074	else
1075	{
1076	/* Nothing below, which means we need to relink map object for this space
1077	* use translated coordinates in case some oddness with map tiling is
1078	* evident
1079	*/
1080	if (GET_MAP_OB (map, x, y) != this)
1081	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1082
1083	ms.bot = above; /* goes on above it. */
1084	}
1085		1137
1086	above = 0;	1138	above = 0;
1087	below = 0;	1139	below = 0;
1088		1140
		1141	ms.invalidate ();
		1142
1089	if (map->in_memory == MAP_SAVING)	1143	if (map->in_memory == MAP_SAVING)
1090	return;	1144	return;
1091		1145
1092	int check_walk_off = !flag [FLAG_NO_APPLY];	1146	int check_walk_off = !flag [FLAG_NO_APPLY];
1093		1147
1094	if (object *pl = ms.player ())	1148	if (object *pl = ms.player ())
1095	{	1149	{
1096	if (pl->container == this)	1150	if (pl->container_ () == this)
1097	/* If a container that the player is currently using somehow gets	1151	/* If a container that the player is currently using somehow gets
1098	* removed (most likely destroyed), update the player view	1152	* removed (most likely destroyed), update the player view
1099	* appropriately.	1153	* appropriately.
1100	*/	1154	*/
1101	pl->close_container ();	1155	pl->close_container ();
1102		1156
		1157	//TODO: the floorbox prev/next might need updating
		1158	//esrv_del_item (pl->contr, count);
		1159	//TODO: update floorbox to preserve ordering
		1160	if (pl->contr->ns)
1103	pl->contr->ns->floorbox_update ();	1161	pl->contr->ns->floorbox_update ();
1104	}	1162	}
1105		1163
1106	for (tmp = ms.bot; tmp; tmp = tmp->above)	1164	for (tmp = ms.bot; tmp; tmp = tmp->above)
1107	{	1165	{
1108	/* No point updating the players look faces if he is the object	1166	/* No point updating the players look faces if he is the object
…		…
1121	}	1179	}
1122		1180
1123	last = tmp;	1181	last = tmp;
1124	}	1182	}
1125		1183
1126	/* last == NULL if there are no objects on this space */	1184	if (affects_los ())
1127	//TODO: this makes little sense, why only update the topmost object?
1128	if (!last)
1129	map->at (x, y).flags_ = 0;
1130	else
1131	update_object (last, UP_OBJ_REMOVE);
1132
1133	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1134	update_all_los (map, x, y);	1185	update_all_los (map, x, y);
1135	}	1186	}
1136	}	1187	}
1137		1188
1138	/*	1189	/*
…		…
1152	if (!top)	1203	if (!top)
1153	for (top = op; top && top->above; top = top->above)	1204	for (top = op; top && top->above; top = top->above)
1154	;	1205	;
1155		1206
1156	for (; top; top = top->below)	1207	for (; top; top = top->below)
1157	{
1158	if (top == op)
1159	continue;
1160
1161	if (object::can_merge (op, top))	1208	if (object::can_merge (op, top))
1162	{	1209	{
1163	top->nrof += op->nrof;	1210	top->nrof += op->nrof;
1164		1211
1165	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1212	if (object *pl = top->visible_to ())
1166	op->weight = 0; /* Don't want any adjustements now */	1213	esrv_update_item (UPD_NROF, pl, top);
		1214
		1215	op->weight = 0; // cancel the addition above
		1216	op->carrying = 0; // must be 0 already
		1217
1167	op->destroy ();	1218	op->destroy ();
		1219
1168	return top;	1220	return top;
1169	}	1221	}
1170	}
1171		1222
1172	return 0;	1223	return 0;
1173	}	1224	}
1174		1225
1175	void	1226	void
…		…
1200	* job preparing multi-part monsters.	1251	* job preparing multi-part monsters.
1201	*/	1252	*/
1202	object *	1253	object *
1203	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1254	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1204	{	1255	{
		1256	op->remove ();
		1257
1205	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1258	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1206	{	1259	{
1207	tmp->x = x + tmp->arch->x;	1260	tmp->x = x + tmp->arch->x;
1208	tmp->y = y + tmp->arch->y;	1261	tmp->y = y + tmp->arch->y;
1209	}	1262	}
…		…
1232	* just 'op' otherwise	1285	* just 'op' otherwise
1233	*/	1286	*/
1234	object *	1287	object *
1235	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1288	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1236	{	1289	{
1237	assert (!op->flag [FLAG_FREED]);
1238
1239	object *top, *floor = NULL;
1240
1241	op->remove ();	1290	op->remove ();
		1291
		1292	if (m == &freed_map)//D TODO: remove soon
		1293	{//D
		1294	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1295	}//D
1242		1296
1243	/* Ideally, the caller figures this out. However, it complicates a lot	1297	/* Ideally, the caller figures this out. However, it complicates a lot
1244	* of areas of callers (eg, anything that uses find_free_spot would now	1298	* of areas of callers (eg, anything that uses find_free_spot would now
1245	* need extra work	1299	* need extra work
1246	*/	1300	*/
		1301	maptile *newmap = m;
1247	if (!xy_normalise (m, op->x, op->y))	1302	if (!xy_normalise (newmap, op->x, op->y))
1248	{	1303	{
1249	op->destroy ();	1304	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1250	return 0;	1305	return 0;
1251	}	1306	}
1252		1307
1253	if (object *more = op->more)	1308	if (object *more = op->more)
1254	if (!insert_ob_in_map (more, m, originator, flag))	1309	if (!insert_ob_in_map (more, m, originator, flag))
1255	return 0;	1310	return 0;
1256		1311
1257	CLEAR_FLAG (op, FLAG_REMOVED);	1312	op->flag [FLAG_REMOVED] = false;
1258		1313	op->env = 0;
1259	op->map = m;	1314	op->map = newmap;
		1315
1260	mapspace &ms = op->ms ();	1316	mapspace &ms = op->ms ();
1261		1317
1262	/* this has to be done after we translate the coordinates.	1318	/* this has to be done after we translate the coordinates.
1263	*/	1319	*/
1264	if (op->nrof && !(flag & INS_NO_MERGE))	1320	if (op->nrof && !(flag & INS_NO_MERGE))
1265	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1321	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1266	if (object::can_merge (op, tmp))	1322	if (object::can_merge (op, tmp))
1267	{	1323	{
		1324	// TODO: we actually want to update tmp, not op,
		1325	// but some caller surely breaks when we return tmp
		1326	// from here :/
1268	op->nrof += tmp->nrof;	1327	op->nrof += tmp->nrof;
1269	tmp->destroy (1);	1328	tmp->destroy ();
1270	}	1329	}
1271		1330
1272	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1331	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1273	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1332	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1274		1333
…		…
1281	{	1340	{
1282	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1341	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1283	abort ();	1342	abort ();
1284	}	1343	}
1285		1344
		1345	if (!originator->is_on_map ())
		1346	{
		1347	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1348	op->debug_desc (), originator->debug_desc ());
		1349	abort ();
		1350	}
		1351
1286	op->above = originator;	1352	op->above = originator;
1287	op->below = originator->below;	1353	op->below = originator->below;
1288
1289	if (op->below)
1290	op->below->above = op;
1291	else
1292	ms.bot = op;
1293
1294	/* since *below* originator, no need to update top */
1295	originator->below = op;	1354	originator->below = op;
		1355
		1356	*(op->below ? &op->below->above : &ms.bot) = op;
1296	}	1357	}
1297	else	1358	else
1298	{	1359	{
1299	top = ms.bot;	1360	object *floor = 0;
		1361	object *top = ms.top;
1300		1362
1301	/* If there are other objects, then */	1363	/* If there are other objects, then */
1302	if (top)	1364	if (top)
1303	{	1365	{
1304	object *last = 0;
1305
1306	/*	1366	/*
1307	* If there are multiple objects on this space, we do some trickier handling.	1367	* If there are multiple objects on this space, we do some trickier handling.
1308	* We've already dealt with merging if appropriate.	1368	* We've already dealt with merging if appropriate.
1309	* Generally, we want to put the new object on top. But if	1369	* Generally, we want to put the new object on top. But if
1310	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1370	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1313	* once we get to them. This reduces the need to traverse over all of	1373	* once we get to them. This reduces the need to traverse over all of
1314	* them when adding another one - this saves quite a bit of cpu time	1374	* them when adding another one - this saves quite a bit of cpu time
1315	* when lots of spells are cast in one area. Currently, it is presumed	1375	* when lots of spells are cast in one area. Currently, it is presumed
1316	* that flying non pickable objects are spell objects.	1376	* that flying non pickable objects are spell objects.
1317	*/	1377	*/
1318	for (top = ms.bot; top; top = top->above)	1378	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1319	{	1379	{
1320	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1380	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1321	floor = top;	1381	floor = tmp;
1322		1382
1323	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1383	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1324	{	1384	{
1325	/* We insert above top, so we want this object below this */	1385	/* We insert above top, so we want this object below this */
1326	top = top->below;	1386	top = tmp->below;
1327	break;	1387	break;
1328	}	1388	}
1329		1389
1330	last = top;	1390	top = tmp;
1331	}	1391	}
1332
1333	/* Don't want top to be NULL, so set it to the last valid object */
1334	top = last;
1335		1392
1336	/* We let update_position deal with figuring out what the space	1393	/* We let update_position deal with figuring out what the space
1337	* looks like instead of lots of conditions here.	1394	* looks like instead of lots of conditions here.
1338	* makes things faster, and effectively the same result.	1395	* makes things faster, and effectively the same result.
1339	*/	1396	*/
…		…
1346	*/	1403	*/
1347	if (!(flag & INS_ON_TOP)	1404	if (!(flag & INS_ON_TOP)
1348	&& ms.flags () & P_BLOCKSVIEW	1405	&& ms.flags () & P_BLOCKSVIEW
1349	&& (op->face && !faces [op->face].visibility))	1406	&& (op->face && !faces [op->face].visibility))
1350	{	1407	{
		1408	object *last;
		1409
1351	for (last = top; last != floor; last = last->below)	1410	for (last = top; last != floor; last = last->below)
1352	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1411	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1353	break;	1412	break;
1354		1413
1355	/* Check to see if we found the object that blocks view,	1414	/* Check to see if we found the object that blocks view,
…		…
1363	} /* If objects on this space */	1422	} /* If objects on this space */
1364		1423
1365	if (flag & INS_ABOVE_FLOOR_ONLY)	1424	if (flag & INS_ABOVE_FLOOR_ONLY)
1366	top = floor;	1425	top = floor;
1367		1426
1368	/* Top is the object that our object (op) is going to get inserted above.	1427	// insert object above top, or bottom-most if top = 0
1369	*/
1370
1371	/* First object on this space */
1372	if (!top)	1428	if (!top)
1373	{	1429	{
		1430	op->below = 0;
1374	op->above = ms.bot;	1431	op->above = ms.bot;
1375
1376	if (op->above)
1377	op->above->below = op;
1378
1379	op->below = 0;
1380	ms.bot = op;	1432	ms.bot = op;
		1433
		1434	*(op->above ? &op->above->below : &ms.top) = op;
1381	}	1435	}
1382	else	1436	else
1383	{ /* get inserted into the stack above top */	1437	{
1384	op->above = top->above;	1438	op->above = top->above;
1385
1386	if (op->above)
1387	op->above->below = op;	1439	top->above = op;
1388		1440
1389	op->below = top;	1441	op->below = top;
1390	top->above = op;	1442	*(op->above ? &op->above->below : &ms.top) = op;
1391	}	1443	}
		1444	}
1392		1445
1393	if (!op->above)	1446	if (op->is_player ())
1394	ms.top = op;
1395	} /* else not INS_BELOW_ORIGINATOR */
1396
1397	if (op->type == PLAYER)
1398	{	1447	{
1399	op->contr->do_los = 1;	1448	op->contr->do_los = 1;
1400	++op->map->players;	1449	++op->map->players;
1401	op->map->touch ();	1450	op->map->touch ();
1402	}	1451	}
1403		1452
1404	op->map->dirty = true;	1453	op->map->dirty = true;
1405		1454
1406	if (object *pl = ms.player ())	1455	if (object *pl = ms.player ())
		1456	//TODO: the floorbox prev/next might need updating
		1457	//esrv_send_item (pl, op);
		1458	//TODO: update floorbox to preserve ordering
		1459	if (pl->contr->ns)
1407	pl->contr->ns->floorbox_update ();	1460	pl->contr->ns->floorbox_update ();
1408		1461
1409	/* If this object glows, it may affect lighting conditions that are	1462	/* If this object glows, it may affect lighting conditions that are
1410	* visible to others on this map. But update_all_los is really	1463	* visible to others on this map. But update_all_los is really
1411	* an inefficient way to do this, as it means los for all players	1464	* an inefficient way to do this, as it means los for all players
1412	* on the map will get recalculated. The players could very well	1465	* on the map will get recalculated. The players could very well
1413	* be far away from this change and not affected in any way -	1466	* be far away from this change and not affected in any way -
1414	* this should get redone to only look for players within range,	1467	* this should get redone to only look for players within range,
1415	* or just updating the P_UPTODATE for spaces within this area	1468	* or just updating the P_UPTODATE for spaces within this area
1416	* of effect may be sufficient.	1469	* of effect may be sufficient.
1417	*/	1470	*/
1418	if (op->map->darkness && (op->glow_radius != 0))	1471	if (op->affects_los ())
		1472	{
		1473	op->ms ().invalidate ();
1419	update_all_los (op->map, op->x, op->y);	1474	update_all_los (op->map, op->x, op->y);
		1475	}
1420		1476
1421	/* updates flags (blocked, alive, no magic, etc) for this map space */	1477	/* updates flags (blocked, alive, no magic, etc) for this map space */
1422	update_object (op, UP_OBJ_INSERT);	1478	update_object (op, UP_OBJ_INSERT);
1423		1479
1424	INVOKE_OBJECT (INSERT, op);	1480	INVOKE_OBJECT (INSERT, op);
…		…
1431	* blocked() and wall() work properly), and these flags are updated by	1487	* blocked() and wall() work properly), and these flags are updated by
1432	* update_object().	1488	* update_object().
1433	*/	1489	*/
1434		1490
1435	/* if this is not the head or flag has been passed, don't check walk on status */	1491	/* if this is not the head or flag has been passed, don't check walk on status */
1436	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1492	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1437	{	1493	{
1438	if (check_move_on (op, originator))	1494	if (check_move_on (op, originator))
1439	return 0;	1495	return 0;
1440		1496
1441	/* If we are a multi part object, lets work our way through the check	1497	/* If we are a multi part object, lets work our way through the check
…		…
1452	/* this function inserts an object in the map, but if it	1508	/* this function inserts an object in the map, but if it
1453	* finds an object of its own type, it'll remove that one first.	1509	* finds an object of its own type, it'll remove that one first.
1454	* op is the object to insert it under: supplies x and the map.	1510	* op is the object to insert it under: supplies x and the map.
1455	*/	1511	*/
1456	void	1512	void
1457	replace_insert_ob_in_map (const char *arch_string, object *op)	1513	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1458	{	1514	{
1459	/* first search for itself and remove any old instances */	1515	/* first search for itself and remove any old instances */
1460		1516
1461	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1517	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1462	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1518	if (tmp->arch->archname == archname) /* same archetype */
1463	tmp->destroy (1);	1519	tmp->destroy ();
1464		1520
1465	object *tmp = arch_to_object (archetype::find (arch_string));	1521	object *tmp = arch_to_object (archetype::find (archname));
1466		1522
1467	tmp->x = op->x;	1523	tmp->x = op->x;
1468	tmp->y = op->y;	1524	tmp->y = op->y;
1469		1525
1470	insert_ob_in_map (tmp, op->map, op, 0);	1526	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1475	{	1531	{
1476	if (where->env)	1532	if (where->env)
1477	return where->env->insert (this);	1533	return where->env->insert (this);
1478	else	1534	else
1479	return where->map->insert (this, where->x, where->y, originator, flags);	1535	return where->map->insert (this, where->x, where->y, originator, flags);
1480	}
1481
1482	// find player who can see this object
1483	static object *
1484	visible_to (object *op)
1485	{
1486	if (!op->flag [FLAG_REMOVED])
1487	{
1488	// see if we are in a container of sorts
1489	if (object *env = op->env)
1490	{
1491	// the player inventory itself is always visible
1492	if (env->type == PLAYER)
1493	return env;
1494
1495	// else a player could have our env open
1496	env = env->outer_env ();
1497
1498	// the player itself is always on a map, so we will find him here
1499	// even if our inv is in a player.
1500	if (env->is_on_map ())
1501	if (object *pl = env->ms ().player ())
1502	if (pl->container == op->env)
1503	return pl;
1504	}
1505	else
1506	{
1507	// maybe there is a player standing on the same mapspace
1508	if (object *pl = env->ms ().player ())
1509	return pl;
1510	}
1511	}
1512
1513	return 0;
1514	}	1536	}
1515		1537
1516	/*	1538	/*
1517	* decrease(object, number) decreases a specified number from	1539	* decrease(object, number) decreases a specified number from
1518	* the amount of an object. If the amount reaches 0, the object	1540	* the amount of an object. If the amount reaches 0, the object
…		…
1521	* Return value: 'op' if something is left, NULL if the amount reached 0	1543	* Return value: 'op' if something is left, NULL if the amount reached 0
1522	*/	1544	*/
1523	bool	1545	bool
1524	object::decrease (sint32 nr)	1546	object::decrease (sint32 nr)
1525	{	1547	{
		1548	if (!nr)
		1549	return true;
		1550
1526	nr = min (nr, nrof);	1551	nr = min (nr, nrof);
1527		1552
1528	if (!nr)	1553	if (nrof > nr)
1529	return 1;	1554	{
1530
1531	nrof -= nr;	1555	nrof -= nr;
1532
1533	object *visible = visible_to (this);
1534
1535	if (nrof)
1536	{
1537	adjust_weight (env, -weight * nr); // carrying == 0	1556	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1538		1557
1539	if (visible)	1558	if (object *pl = visible_to ())
1540	esrv_send_item (visible, this);	1559	esrv_update_item (UPD_NROF, pl, this);
1541		1560
1542	return 1;	1561	return true;
1543	}	1562	}
1544	else	1563	else
1545	{	1564	{
1546	if (visible)
1547	esrv_del_item (visible->contr, count);
1548
1549	this->destroy (1);	1565	destroy ();
1550	return 0;	1566	return false;
1551	}	1567	}
1552	}	1568	}
1553		1569
1554	/*	1570	/*
1555	* split(ob,nr) splits up ob into two parts. The part which	1571	* split(ob,nr) splits up ob into two parts. The part which
…		…
1558	* On failure, NULL is returned.	1574	* On failure, NULL is returned.
1559	*/	1575	*/
1560	object *	1576	object *
1561	object::split (sint32 nr)	1577	object::split (sint32 nr)
1562	{	1578	{
		1579	int have = number_of ();
		1580
1563	if (nrof < nr)	1581	if (have < nr)
1564	return 0;	1582	return 0;
1565	else if (nrof == nr)	1583	else if (have == nr)
1566	{	1584	{
1567	remove ();	1585	remove ();
1568	return this;	1586	return this;
1569	}	1587	}
1570	else	1588	else
1571	{	1589	{
1572	decrease (nr);	1590	decrease (nr);
1573		1591
1574	object *op = object_create_clone (this);	1592	object *op = deep_clone ();
1575	op->nrof = nr;	1593	op->nrof = nr;
1576	return op;	1594	return op;
1577	}	1595	}
1578	}	1596	}
1579		1597
…		…
1623	if (object::can_merge (tmp, op))	1641	if (object::can_merge (tmp, op))
1624	{	1642	{
1625	/* return the original object and remove inserted object	1643	/* return the original object and remove inserted object
1626	(client needs the original object) */	1644	(client needs the original object) */
1627	tmp->nrof += op->nrof;	1645	tmp->nrof += op->nrof;
		1646
		1647	if (object *pl = tmp->visible_to ())
		1648	esrv_update_item (UPD_NROF, pl, tmp);
		1649
1628	adjust_weight (this, op->total_weight ());	1650	adjust_weight (this, op->total_weight ());
1629		1651
1630	op->destroy (1);	1652	op->destroy ();
1631	op = tmp;	1653	op = tmp;
1632	goto inserted;	1654	goto inserted;
1633	}	1655	}
1634		1656
1635	op->owner = 0; // it's his/hers now. period.	1657	op->owner = 0; // it's his/hers now. period.
…		…
1646		1668
1647	inv = op;	1669	inv = op;
1648		1670
1649	op->flag [FLAG_REMOVED] = 0;	1671	op->flag [FLAG_REMOVED] = 0;
1650		1672
		1673	if (object *pl = op->visible_to ())
		1674	esrv_send_item (pl, op);
		1675
1651	adjust_weight (this, op->total_weight ());	1676	adjust_weight (this, op->total_weight ());
1652		1677
1653	inserted:	1678	inserted:
1654	/* reset the light list and los of the players on the map */	1679	/* reset the light list and los of the players on the map */
1655	if (op->glow_radius && map && map->darkness)	1680	if (op->glow_radius && is_on_map ())
		1681	{
		1682	update_stats ();
1656	update_all_los (map, x, y);	1683	update_all_los (map, x, y);
1657		1684	}
1658	if (object *otmp = in_player ())	1685	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1659	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1686	// if this is a player's inventory, update stats
1660	otmp->update_stats ();	1687	update_stats ();
1661		1688
1662	INVOKE_OBJECT (INSERT, this);	1689	INVOKE_OBJECT (INSERT, this);
1663		1690
1664	return op;	1691	return op;
1665	}	1692	}
…		…
1685	* on top.	1712	* on top.
1686	*/	1713	*/
1687	int	1714	int
1688	check_move_on (object *op, object *originator)	1715	check_move_on (object *op, object *originator)
1689	{	1716	{
		1717	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1718	return 0;
		1719
1690	object *tmp;	1720	object *tmp;
1691	maptile *m = op->map;	1721	maptile *m = op->map;
1692	int x = op->x, y = op->y;	1722	int x = op->x, y = op->y;
1693		1723
1694	MoveType move_on, move_slow, move_block;	1724	mapspace &ms = m->at (x, y);
1695		1725
1696	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1726	ms.update ();
1697	return 0;
1698		1727
1699	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1728	MoveType move_on = ms.move_on;
1700	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1729	MoveType move_slow = ms.move_slow;
1701	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1730	MoveType move_block = ms.move_block;
1702		1731
1703	/* if nothing on this space will slow op down or be applied,	1732	/* if nothing on this space will slow op down or be applied,
1704	* no need to do checking below. have to make sure move_type	1733	* no need to do checking below. have to make sure move_type
1705	* is set, as lots of objects don't have it set - we treat that	1734	* is set, as lots of objects don't have it set - we treat that
1706	* as walking.	1735	* as walking.
…		…
1717	return 0;	1746	return 0;
1718		1747
1719	/* The objects have to be checked from top to bottom.	1748	/* The objects have to be checked from top to bottom.
1720	* Hence, we first go to the top:	1749	* Hence, we first go to the top:
1721	*/	1750	*/
1722		1751	for (object *next, *tmp = ms.top; tmp; tmp = next)
1723	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1724	{
1725	/* Trim the search when we find the first other spell effect
1726	* this helps performance so that if a space has 50 spell objects,
1727	* we don't need to check all of them.
1728	*/
1729	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1730	break;
1731	}	1752	{
		1753	next = tmp->below;
1732		1754
1733	for (; tmp; tmp = tmp->below)
1734	{
1735	if (tmp == op)	1755	if (tmp == op)
1736	continue; /* Can't apply yourself */	1756	continue; /* Can't apply yourself */
1737		1757
1738	/* Check to see if one of the movement types should be slowed down.	1758	/* Check to see if one of the movement types should be slowed down.
1739	* Second check makes sure that the movement types not being slowed	1759	* Second check makes sure that the movement types not being slowed
…		…
1744	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1764	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1745	{	1765	{
1746	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1766	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1747	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1767	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1748	{	1768	{
1749
1750	float
1751	diff = tmp->move_slow_penalty * fabs (op->speed);	1769	float diff = tmp->move_slow_penalty * fabs (op->speed);
1752		1770
1753	if (op->type == PLAYER)	1771	if (op->is_player ())
1754	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1772	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1755	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1773	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1756	diff /= 4.0;	1774	diff /= 4.0;
1757		1775
1758	op->speed_left -= diff;	1776	op->speed_left -= diff;
1759	}	1777	}
1760	}	1778	}
…		…
1793	LOG (llevError, "Present_arch called outside map.\n");	1811	LOG (llevError, "Present_arch called outside map.\n");
1794	return NULL;	1812	return NULL;
1795	}	1813	}
1796		1814
1797	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1815	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1798	if (tmp->arch == at)	1816	if (tmp->arch->archname == at->archname)
1799	return tmp;	1817	return tmp;
1800		1818
1801	return NULL;	1819	return NULL;
1802	}	1820	}
1803		1821
…		…
1867	* The first matching object is returned, or NULL if none.	1885	* The first matching object is returned, or NULL if none.
1868	*/	1886	*/
1869	object *	1887	object *
1870	present_arch_in_ob (const archetype *at, const object *op)	1888	present_arch_in_ob (const archetype *at, const object *op)
1871	{	1889	{
1872	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1890	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1873	if (tmp->arch == at)	1891	if (tmp->arch->archname == at->archname)
1874	return tmp;	1892	return tmp;
1875		1893
1876	return NULL;	1894	return NULL;
1877	}	1895	}
1878		1896
…		…
1966	* head of the object should correspond for the entire object.	1984	* head of the object should correspond for the entire object.
1967	*/	1985	*/
1968	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1986	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1969	continue;	1987	continue;
1970		1988
1971	if (ob->blocked (m, pos.x, pos.y))	1989	if (ob->blocked (pos.m, pos.x, pos.y))
1972	continue;	1990	continue;
1973		1991
1974	altern [index++] = i;	1992	altern [index++] = i;
1975	}	1993	}
1976		1994
…		…
2044	* there is capable of.	2062	* there is capable of.
2045	*/	2063	*/
2046	int	2064	int
2047	find_dir (maptile *m, int x, int y, object *exclude)	2065	find_dir (maptile *m, int x, int y, object *exclude)
2048	{	2066	{
2049	int i, max = SIZEOFFREE, mflags;	2067	int max = SIZEOFFREE, mflags;
2050
2051	sint16 nx, ny;
2052	object *tmp;
2053	maptile *mp;
2054
2055	MoveType blocked, move_type;	2068	MoveType move_type;
2056		2069
2057	if (exclude && exclude->head_ () != exclude)	2070	if (exclude && exclude->head_ () != exclude)
2058	{	2071	{
2059	exclude = exclude->head;	2072	exclude = exclude->head;
2060	move_type = exclude->move_type;	2073	move_type = exclude->move_type;
…		…
2063	{	2076	{
2064	/* If we don't have anything, presume it can use all movement types. */	2077	/* If we don't have anything, presume it can use all movement types. */
2065	move_type = MOVE_ALL;	2078	move_type = MOVE_ALL;
2066	}	2079	}
2067		2080
2068	for (i = 1; i < max; i++)	2081	for (int i = 1; i < max; i++)
2069	{	2082	{
2070	mp = m;	2083	mapxy pos (m, x, y);
2071	nx = x + freearr_x[i];	2084	pos.move (i);
2072	ny = y + freearr_y[i];
2073		2085
2074	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2086	if (!pos.normalise ())
2075
2076	if (mflags & P_OUT_OF_MAP)
2077	max = maxfree[i];	2087	max = maxfree[i];
2078	else	2088	else
2079	{	2089	{
2080	mapspace &ms = mp->at (nx, ny);	2090	mapspace &ms = *pos;
2081		2091
2082	blocked = ms.move_block;
2083
2084	if ((move_type & blocked) == move_type)	2092	if ((move_type & ms.move_block) == move_type)
2085	max = maxfree[i];	2093	max = maxfree [i];
2086	else if (mflags & P_IS_ALIVE)	2094	else if (ms.flags () & P_IS_ALIVE)
2087	{	2095	{
2088	for (tmp = ms.bot; tmp; tmp = tmp->above)	2096	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2089	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2097	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2090	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2098	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2091	break;
2092
2093	if (tmp)
2094	return freedir[i];	2099	return freedir [i];
2095	}	2100	}
2096	}	2101	}
2097	}	2102	}
2098		2103
2099	return 0;	2104	return 0;
…		…
2174	* This basically means that if direction is 15, then it could either go	2179	* This basically means that if direction is 15, then it could either go
2175	* direction 4, 14, or 16 to get back to where we are.	2180	* direction 4, 14, or 16 to get back to where we are.
2176	* Moved from spell_util.c to object.c with the other related direction	2181	* Moved from spell_util.c to object.c with the other related direction
2177	* functions.	2182	* functions.
2178	*/	2183	*/
2179	int reduction_dir[SIZEOFFREE][3] = {	2184	const int reduction_dir[SIZEOFFREE][3] = {
2180	{0, 0, 0}, /* 0 */	2185	{0, 0, 0}, /* 0 */
2181	{0, 0, 0}, /* 1 */	2186	{0, 0, 0}, /* 1 */
2182	{0, 0, 0}, /* 2 */	2187	{0, 0, 0}, /* 2 */
2183	{0, 0, 0}, /* 3 */	2188	{0, 0, 0}, /* 3 */
2184	{0, 0, 0}, /* 4 */	2189	{0, 0, 0}, /* 4 */
…		…
2280	int	2285	int
2281	can_pick (const object *who, const object *item)	2286	can_pick (const object *who, const object *item)
2282	{	2287	{
2283	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2288	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2284	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2289	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2285	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2290	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2286	}	2291	}
2287		2292
2288	/*	2293	/*
2289	* create clone from object to another	2294	* create clone from object to another
2290	*/	2295	*/
2291	object *	2296	object *
2292	object_create_clone (object *asrc)	2297	object::deep_clone ()
2293	{	2298	{
2294	object *dst = 0, *tmp, *src, *prev, *item;	2299	assert (("deep_clone called on non-head object", is_head ()));
2295		2300
2296	if (!asrc)	2301	object *dst = clone ();
2297	return 0;
2298		2302
2299	src = asrc->head_ ();	2303	object *prev = dst;
2300
2301	prev = 0;
2302	for (object *part = src; part; part = part->more)	2304	for (object *part = this->more; part; part = part->more)
2303	{	2305	{
2304	tmp = part->clone ();	2306	object *tmp = part->clone ();
2305	tmp->x -= src->x;
2306	tmp->y -= src->y;
2307
2308	if (!part->head)
2309	{
2310	dst = tmp;
2311	tmp->head = 0;
2312	}
2313	else
2314	tmp->head = dst;	2307	tmp->head = dst;
2315
2316	tmp->more = 0;
2317
2318	if (prev)
2319	prev->more = tmp;	2308	prev->more = tmp;
2320
2321	prev = tmp;	2309	prev = tmp;
2322	}	2310	}
2323		2311
2324	for (item = src->inv; item; item = item->below)	2312	for (object *item = inv; item; item = item->below)
2325	insert_ob_in_ob (object_create_clone (item), dst);	2313	insert_ob_in_ob (item->deep_clone (), dst);
2326		2314
2327	return dst;	2315	return dst;
2328	}	2316	}
2329		2317
2330	/* This returns the first object in who's inventory that	2318	/* This returns the first object in who's inventory that
…		…
2339	return tmp;	2327	return tmp;
2340		2328
2341	return 0;	2329	return 0;
2342	}	2330	}
2343		2331
2344	/* If ob has a field named key, return the link from the list,	2332	shstr_tmp
2345	* otherwise return NULL.	2333	object::kv_get (shstr_tmp key) const
2346	*
2347	* key must be a passed in shared string - otherwise, this won't
2348	* do the desired thing.
2349	*/
2350	key_value *
2351	get_ob_key_link (const object *ob, const char *key)
2352	{	2334	{
2353	for (key_value *link = ob->key_values; link; link = link->next)	2335	for (key_value *kv = key_values; kv; kv = kv->next)
2354	if (link->key == key)	2336	if (kv->key == key)
2355	return link;
2356
2357	return 0;
2358	}
2359
2360	/*
2361	* Returns the value of op has an extra_field for key, or NULL.
2362	*
2363	* The argument doesn't need to be a shared string.
2364	*
2365	* The returned string is shared.
2366	*/
2367	const char *
2368	get_ob_key_value (const object *op, const char *const key)
2369	{
2370	key_value *link;
2371	shstr_cmp canonical_key (key);
2372
2373	if (!canonical_key)
2374	{
2375	/* 1. There being a field named key on any object
2376	* implies there'd be a shared string to find.
2377	* 2. Since there isn't, no object has this field.
2378	* 3. Therefore, *this* object doesn't have this field.
2379	*/
2380	return 0;
2381	}
2382
2383	/* This is copied from get_ob_key_link() above -
2384	* only 4 lines, and saves the function call overhead.
2385	*/
2386	for (link = op->key_values; link; link = link->next)
2387	if (link->key == canonical_key)
2388	return link->value;	2337	return kv->value;
2389		2338
2390	return 0;	2339	return shstr ();
2391	}	2340	}
2392		2341
2393	/*	2342	void
2394	* Updates the canonical_key in op to value.	2343	object::kv_set (shstr_tmp key, shstr_tmp value)
2395	*
2396	* canonical_key is a shared string (value doesn't have to be).
2397	*
2398	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2399	* keys.
2400	*
2401	* Returns TRUE on success.
2402	*/
2403	int
2404	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2405	{	2344	{
2406	key_value *field = NULL, *last = NULL;	2345	for (key_value *kv = key_values; kv; kv = kv->next)
2407		2346	if (kv->key == key)
2408	for (field = op->key_values; field != NULL; field = field->next)
2409	{
2410	if (field->key != canonical_key)
2411	{	2347	{
2412	last = field;	2348	kv->value = value;
2413	continue;	2349	return;
2414	}	2350	}
2415		2351
2416	if (value)	2352	key_value *kv = new key_value;
2417	field->value = value;	2353
2418	else	2354	kv->next = key_values;
		2355	kv->key = key;
		2356	kv->value = value;
		2357
		2358	key_values = kv;
		2359	}
		2360
		2361	void
		2362	object::kv_del (shstr_tmp key)
		2363	{
		2364	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2365	if ((*kvp)->key == key)
2419	{	2366	{
2420	/* Basically, if the archetype has this key set,	2367	key_value *kv = *kvp;
2421	* we need to store the null value so when we save	2368	*kvp = (*kvp)->next;
2422	* it, we save the empty value so that when we load,	2369	delete kv;
2423	* we get this value back again.	2370	return;
2424	*/
2425	if (get_ob_key_link (op->arch, canonical_key))
2426	field->value = 0;
2427	else
2428	{
2429	if (last)
2430	last->next = field->next;
2431	else
2432	op->key_values = field->next;
2433
2434	delete field;
2435	}
2436	}	2371	}
2437	return TRUE;
2438	}
2439	/* IF we get here, key doesn't exist */
2440
2441	/* No field, we'll have to add it. */
2442
2443	if (!add_key)
2444	return FALSE;
2445
2446	/* There isn't any good reason to store a null
2447	* value in the key/value list. If the archetype has
2448	* this key, then we should also have it, so shouldn't
2449	* be here. If user wants to store empty strings,
2450	* should pass in ""
2451	*/
2452	if (value == NULL)
2453	return TRUE;
2454
2455	field = new key_value;
2456
2457	field->key = canonical_key;
2458	field->value = value;
2459	/* Usual prepend-addition. */
2460	field->next = op->key_values;
2461	op->key_values = field;
2462
2463	return TRUE;
2464	}
2465
2466	/*
2467	* Updates the key in op to value.
2468	*
2469	* If add_key is FALSE, this will only update existing keys,
2470	* and not add new ones.
2471	* In general, should be little reason FALSE is ever passed in for add_key
2472	*
2473	* Returns TRUE on success.
2474	*/
2475	int
2476	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2477	{
2478	shstr key_ (key);
2479
2480	return set_ob_key_value_s (op, key_, value, add_key);
2481	}	2372	}
2482		2373
2483	object::depth_iterator::depth_iterator (object *container)	2374	object::depth_iterator::depth_iterator (object *container)
2484	: iterator_base (container)	2375	: iterator_base (container)
2485	{	2376	{
…		…
2535	{	2426	{
2536	char flagdesc[512];	2427	char flagdesc[512];
2537	char info2[256 * 4];	2428	char info2[256 * 4];
2538	char *p = info;	2429	char *p = info;
2539		2430
2540	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2431	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2541	count,	2432	count,
2542	uuid.c_str (),	2433	uuid.c_str (),
2543	&name,	2434	&name,
2544	title ? "\",title:\"" : "",	2435	title ? ",title:\"" : "",
2545	title ? (const char *)title : "",	2436	title ? (const char *)title : "",
		2437	title ? "\"" : "",
2546	flag_desc (flagdesc, 512), type);	2438	flag_desc (flagdesc, 512), type);
2547		2439
2548	if (!this->flag[FLAG_REMOVED] && env)	2440	if (!flag[FLAG_REMOVED] && env)
2549	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2441	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2550		2442
2551	if (map)	2443	if (map)
2552	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2444	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2553		2445
…		…
2583	object::open_container (object *new_container)	2475	object::open_container (object *new_container)
2584	{	2476	{
2585	if (container == new_container)	2477	if (container == new_container)
2586	return;	2478	return;
2587		2479
2588	if (object *old_container = container)	2480	object *old_container = container;
		2481
		2482	if (old_container)
2589	{	2483	{
2590	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2484	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2591	return;	2485	return;
2592		2486
2593	#if 0	2487	#if 0
…		…
2595	if (object *closer = old_container->inv)	2489	if (object *closer = old_container->inv)
2596	if (closer->type == CLOSE_CON)	2490	if (closer->type == CLOSE_CON)
2597	closer->destroy ();	2491	closer->destroy ();
2598	#endif	2492	#endif
2599		2493
		2494	// make sure the container is available
		2495	esrv_send_item (this, old_container);
		2496
2600	old_container->flag [FLAG_APPLIED] = 0;	2497	old_container->flag [FLAG_APPLIED] = false;
2601	container = 0;	2498	container = 0;
2602		2499
		2500	// client needs item update to make it work, client bug requires this to be separate
2603	esrv_update_item (UPD_FLAGS, this, old_container);	2501	esrv_update_item (UPD_FLAGS, this, old_container);
		2502
2604	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2503	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2605	play_sound (sound_find ("chest_close"));	2504	play_sound (sound_find ("chest_close"));
2606	}	2505	}
2607		2506
2608	if (new_container)	2507	if (new_container)
2609	{	2508	{
…		…
2619	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2518	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2620	new_container->insert (closer);	2519	new_container->insert (closer);
2621	}	2520	}
2622	#endif	2521	#endif
2623		2522
2624	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2523	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2625		2524
		2525	// make sure the container is available, client bug requires this to be separate
		2526	esrv_send_item (this, new_container);
		2527
2626	new_container->flag [FLAG_APPLIED] = 1;	2528	new_container->flag [FLAG_APPLIED] = true;
2627	container = new_container;	2529	container = new_container;
2628		2530
		2531	// client needs flag change
2629	esrv_update_item (UPD_FLAGS, this, new_container);	2532	esrv_update_item (UPD_FLAGS, this, new_container);
2630	esrv_send_inventory (this, new_container);	2533	esrv_send_inventory (this, new_container);
2631	play_sound (sound_find ("chest_open"));	2534	play_sound (sound_find ("chest_open"));
2632	}	2535	}
		2536	// else if (!old_container->env && contr && contr->ns)
		2537	// contr->ns->floorbox_reset ();
2633	}	2538	}
2634		2539
2635	object *	2540	object *
2636	object::force_find (const shstr name)	2541	object::force_find (shstr_tmp name)
2637	{	2542	{
2638	/* cycle through his inventory to look for the MARK we want to	2543	/* cycle through his inventory to look for the MARK we want to
2639	* place	2544	* place
2640	*/	2545	*/
2641	for (object *tmp = inv; tmp; tmp = tmp->below)	2546	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2644		2549
2645	return 0;	2550	return 0;
2646	}	2551	}
2647		2552
2648	void	2553	void
		2554	object::force_set_timer (int duration)
		2555	{
		2556	this->duration = 1;
		2557	this->speed_left = -1.f;
		2558
		2559	this->set_speed (duration ? 1.f / duration : 0.f);
		2560	}
		2561
		2562	object *
2649	object::force_add (const shstr name, int duration)	2563	object::force_add (shstr_tmp name, int duration)
2650	{	2564	{
2651	if (object *force = force_find (name))	2565	if (object *force = force_find (name))
2652	force->destroy ();	2566	force->destroy ();
2653		2567
2654	object *force = get_archetype (FORCE_NAME);	2568	object *force = get_archetype (FORCE_NAME);
2655		2569
2656	force->slaying = name;	2570	force->slaying = name;
2657	force->stats.food = 1;
2658	force->speed_left = -1.f;
2659		2571
2660	force->set_speed (duration ? 1.f / duration : 0.f);	2572	force->force_set_timer (duration);
2661	force->flag [FLAG_IS_USED_UP] = true;	2573
2662	force->flag [FLAG_APPLIED] = true;	2574	force->flag [FLAG_APPLIED] = true;
2663		2575
2664	insert (force);	2576	return insert (force);
2665	}	2577	}
2666		2578
2667	void	2579	void
2668	object::play_sound (faceidx sound)	2580	object::play_sound (faceidx sound) const
2669	{	2581	{
2670	if (!sound)	2582	if (!sound)
2671	return;	2583	return;
2672		2584
2673	if (flag [FLAG_REMOVED])	2585	if (is_on_map ())
		2586	map->play_sound (sound, x, y);
		2587	else if (object *pl = in_player ())
		2588	pl->contr->play_sound (sound);
		2589	}
		2590
		2591	void
		2592	object::say_msg (const char *msg) const
		2593	{
		2594	if (is_on_map ())
		2595	map->say_msg (msg, x, y);
		2596	else if (object *pl = in_player ())
		2597	pl->contr->play_sound (sound);
		2598	}
		2599
		2600	void
		2601	object::make_noise ()
		2602	{
		2603	// we do not model noise in the map, so instead put
		2604	// a temporary light into the noise source
		2605	// could use the map instead, but that's less reliable for our
		2606	// goal, which is to make invisibility a bit harder to exploit
		2607
		2608	// currently only works sensibly for players
		2609	if (!is_player ())
2674	return;	2610	return;
2675		2611
2676	if (env)	2612	// find old force, or create new one
2677	{	2613	object *force = force_find (shstr_noise_force);
2678	if (object *pl = in_player ())	2614
2679	pl->contr->play_sound (sound);	2615	if (force)
2680	}	2616	force->speed_left = -1.f; // patch old speed up
2681	else	2617	else
2682	map->play_sound (sound, x, y);	2618	{
2683	}	2619	force = archetype::get (shstr_noise_force);
2684		2620
		2621	force->slaying = shstr_noise_force;
		2622	force->stats.food = 1;
		2623	force->speed_left = -1.f;
		2624
		2625	force->set_speed (1.f / 4.f);
		2626	force->flag [FLAG_IS_USED_UP] = true;
		2627	force->flag [FLAG_APPLIED] = true;
		2628
		2629	insert (force);
		2630	}
		2631	}
		2632

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines