ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.238 by root, Wed May 7 11:02:50 2008 UTC vs.
Revision 1.295 by root, Fri Nov 6 13:03:34 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 52 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 56};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
60 0, 58 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
62};
63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64}; 69};
65 70
66static void 71static void
67write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
68{ 73{
186 || ob1->speed != ob2->speed 191 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 192 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 193 || ob1->name != ob2->name)
189 return 0; 194 return 0;
190 195
191 /* Do not merge objects if nrof would overflow. First part checks 196 /* Do not merge objects if nrof would overflow, assume nrof
192 * for unsigned overflow (2c), second part checks whether the result 197 * is always 0 .. 2**31-1 */
193 * would fit into a 32 bit signed int, which is often used to hold 198 if (ob1->nrof > 0x7fffffff - ob2->nrof)
194 * nrof values.
195 */
196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
197 return 0; 199 return 0;
198 200
199 /* If the objects have been identified, set the BEEN_APPLIED flag. 201 /* If the objects have been identified, set the BEEN_APPLIED flag.
200 * This is to the comparison of the flags below will be OK. We 202 * This is to the comparison of the flags below will be OK. We
201 * just can't ignore the been applied or identified flags, as they 203 * just can't ignore the been applied or identified flags, as they
206 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
207 209
208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 210 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
209 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 211 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
210 212
211 if (ob1->arch->name != ob2->arch->name 213 if (ob1->arch->archname != ob2->arch->archname
212 || ob1->name != ob2->name 214 || ob1->name != ob2->name
213 || ob1->title != ob2->title 215 || ob1->title != ob2->title
214 || ob1->msg != ob2->msg 216 || ob1->msg != ob2->msg
215 || ob1->weight != ob2->weight 217 || ob1->weight != ob2->weight
216 || ob1->attacktype != ob2->attacktype 218 || ob1->attacktype != ob2->attacktype
217 || ob1->magic != ob2->magic 219 || ob1->magic != ob2->magic
218 || ob1->slaying != ob2->slaying 220 || ob1->slaying != ob2->slaying
219 || ob1->skill != ob2->skill 221 || ob1->skill != ob2->skill
220 || ob1->value != ob2->value 222 || ob1->value != ob2->value
221 || ob1->animation_id != ob2->animation_id 223 || ob1->animation_id != ob2->animation_id
224 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
222 || ob1->client_type != ob2->client_type 225 || ob1->client_type != ob2->client_type
223 || ob1->materialname != ob2->materialname 226 || ob1->materialname != ob2->materialname
224 || ob1->lore != ob2->lore 227 || ob1->lore != ob2->lore
225 || ob1->subtype != ob2->subtype 228 || ob1->subtype != ob2->subtype
226 || ob1->move_type != ob2->move_type 229 || ob1->move_type != ob2->move_type
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
235 return 0; 238 return 0;
236 239
237 if ((ob1->flag ^ ob2->flag) 240 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED) 241 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED) 242 .reset (FLAG_REMOVED)
241 .any ()) 243 .any ())
242 return 0; 244 return 0;
243 245
244 /* This is really a spellbook check - we should in general 246 /* This is really a spellbook check - we should in general
326 { 328 {
327 // see if we are in a container of sorts 329 // see if we are in a container of sorts
328 if (env) 330 if (env)
329 { 331 {
330 // the player inventory itself is always visible 332 // the player inventory itself is always visible
331 if (env->type == PLAYER) 333 if (env->is_player ())
332 return env; 334 return env;
333 335
334 // else a player could have our env open 336 // else a player could have our env open
335 object *envest = env->outer_env (); 337 object *envest = env->outer_env_or_self ();
336 338
337 // the player itself is always on a map, so we will find him here 339 // the player itself is always on a map, so we will find him here
338 // even if our inv is in a player. 340 // even if our inv is in a player.
339 if (envest->is_on_map ()) 341 if (envest->is_on_map ())
340 if (object *pl = envest->ms ().player ()) 342 if (object *pl = envest->ms ().player ())
341 if (pl->container == env) 343 if (pl->container_ () == env)
342 return pl; 344 return pl;
343 } 345 }
344 else 346 else
345 { 347 {
346 // maybe there is a player standing on the same mapspace 348 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player 349 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ()) 350 if (object *pl = ms ().player ())
349 if (!pl->container || this == pl->container) 351 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
352 || pl->container_ () == this)
350 return pl; 353 return pl;
351 } 354 }
352 } 355 }
353 356
354 return 0; 357 return 0;
432 object_freezer freezer; 435 object_freezer freezer;
433 op->write (freezer); 436 op->write (freezer);
434 return freezer.as_string (); 437 return freezer.as_string ();
435} 438}
436 439
440char *
441object::as_string ()
442{
443 return dump_object (this);
444}
445
437/* 446/*
438 * get_nearest_part(multi-object, object 2) returns the part of the 447 * get_nearest_part(multi-object, object 2) returns the part of the
439 * multi-object 1 which is closest to the second object. 448 * multi-object 1 which is closest to the second object.
440 * If it's not a multi-object, it is returned. 449 * If it's not a multi-object, it is returned.
441 */ 450 */
442object * 451static object *
443get_nearest_part (object *op, const object *pl) 452get_nearest_part (object *op, const object *pl)
444{ 453{
445 object *tmp, *closest; 454 object *tmp, *closest;
446 int last_dist, i; 455 int last_dist, i;
447 456
478 */ 487 */
479object * 488object *
480find_object_name (const char *str) 489find_object_name (const char *str)
481{ 490{
482 shstr_cmp str_ (str); 491 shstr_cmp str_ (str);
483 object *op;
484 492
493 if (str_)
485 for_all_objects (op) 494 for_all_objects (op)
486 if (op->name == str_) 495 if (op->name == str_)
487 break; 496 return op;
488 497
489 return op; 498 return 0;
490} 499}
491 500
492/* 501/*
493 * Sets the owner and sets the skill and exp pointers to owner's current 502 * Sets the owner and sets the skill and exp pointers to owner's current
494 * skill and experience objects. 503 * skill and experience objects.
556 update_stats (); 565 update_stats ();
557 566
558 new_draw_info_format (NDI_UNIQUE, 0, this, 567 new_draw_info_format (NDI_UNIQUE, 0, this,
559 "You try to balance all your items at once, " 568 "You try to balance all your items at once, "
560 "but the %s is just too much for your body. " 569 "but the %s is just too much for your body. "
561 "[You need to unapply some items first.]", &ob->name); 570 "[You need to unapply some items first - use the 'body' command to see "
571 "how many items you cna wera on a specific body part.]", &ob->name);
562 return false; 572 return false;
563 } 573 }
564 574
565 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 575 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
566 } 576 }
638 } 648 }
639 649
640 if (speed < 0) 650 if (speed < 0)
641 dst->speed_left -= rndm (); 651 dst->speed_left -= rndm ();
642 652
643 dst->set_speed (dst->speed); 653 dst->activate ();
644} 654}
645 655
646void 656void
647object::instantiate () 657object::instantiate ()
648{ 658{
760 else if (action == UP_OBJ_INSERT) 770 else if (action == UP_OBJ_INSERT)
761 { 771 {
762 // this is likely overkill, TODO: revisit (schmorp) 772 // this is likely overkill, TODO: revisit (schmorp)
763 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 773 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
764 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 774 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
765 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 775 || (op->is_player () && !(m.flags_ & P_PLAYER))
766 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 776 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
767 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 777 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
768 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 778 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
769 || (m.move_on | op->move_on ) != m.move_on 779 || (m.move_on | op->move_on ) != m.move_on
770 || (m.move_off | op->move_off ) != m.move_off 780 || (m.move_off | op->move_off ) != m.move_off
771 || (m.move_slow | op->move_slow) != m.move_slow 781 || (m.move_slow | op->move_slow) != m.move_slow
772 /* This isn't perfect, but I don't expect a lot of objects to 782 /* This isn't perfect, but I don't expect a lot of objects to
773 * to have move_allow right now. 783 * have move_allow right now.
774 */ 784 */
775 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 785 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
776 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 786 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
777 m.flags_ = 0; 787 m.invalidate ();
778 } 788 }
779 /* if the object is being removed, we can't make intelligent 789 /* if the object is being removed, we can't make intelligent
780 * decisions, because remove_ob can't really pass the object 790 * decisions, because remove_ob can't really pass the object
781 * that is being removed. 791 * that is being removed.
782 */ 792 */
783 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 793 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
784 m.flags_ = 0; 794 m.invalidate ();
785 else if (action == UP_OBJ_FACE) 795 else if (action == UP_OBJ_FACE)
786 /* Nothing to do for that case */ ; 796 /* Nothing to do for that case */ ;
787 else 797 else
788 LOG (llevError, "update_object called with invalid action: %d\n", action); 798 LOG (llevError, "update_object called with invalid action: %d\n", action);
789 799
793 803
794object::object () 804object::object ()
795{ 805{
796 SET_FLAG (this, FLAG_REMOVED); 806 SET_FLAG (this, FLAG_REMOVED);
797 807
798 expmul = 1.0; 808 //expmul = 1.0; declared const for the time being
799 face = blank_face; 809 face = blank_face;
800} 810}
801 811
802object::~object () 812object::~object ()
803{ 813{
833 /* If already on active list, don't do anything */ 843 /* If already on active list, don't do anything */
834 if (active) 844 if (active)
835 return; 845 return;
836 846
837 if (has_active_speed ()) 847 if (has_active_speed ())
848 {
849 if (flag [FLAG_FREED])
850 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
851
838 actives.insert (this); 852 actives.insert (this);
853 }
839} 854}
840 855
841void 856void
842object::activate_recursive () 857object::activate_recursive ()
843{ 858{
908 || map->in_memory != MAP_ACTIVE 923 || map->in_memory != MAP_ACTIVE
909 || map->no_drop 924 || map->no_drop
910 || ms ().move_block == MOVE_ALL) 925 || ms ().move_block == MOVE_ALL)
911 { 926 {
912 while (inv) 927 while (inv)
913 {
914 inv->destroy_inv (false);
915 inv->destroy (); 928 inv->destroy ();
916 }
917 } 929 }
918 else 930 else
919 { /* Put objects in inventory onto this space */ 931 { /* Put objects in inventory onto this space */
920 while (inv) 932 while (inv)
921 { 933 {
925 || op->flag [FLAG_NO_DROP] 937 || op->flag [FLAG_NO_DROP]
926 || op->type == RUNE 938 || op->type == RUNE
927 || op->type == TRAP 939 || op->type == TRAP
928 || op->flag [FLAG_IS_A_TEMPLATE] 940 || op->flag [FLAG_IS_A_TEMPLATE]
929 || op->flag [FLAG_DESTROY_ON_DEATH]) 941 || op->flag [FLAG_DESTROY_ON_DEATH])
930 op->destroy (true); 942 op->destroy ();
931 else 943 else
932 map->insert (op, x, y); 944 map->insert (op, x, y);
933 } 945 }
934 } 946 }
935} 947}
964 976
965void 977void
966object::do_destroy () 978object::do_destroy ()
967{ 979{
968 if (flag [FLAG_IS_LINKED]) 980 if (flag [FLAG_IS_LINKED])
969 remove_button_link (this); 981 remove_link ();
970 982
971 if (flag [FLAG_FRIENDLY]) 983 if (flag [FLAG_FRIENDLY])
972 remove_friendly_object (this); 984 remove_friendly_object (this);
973 985
974 remove (); 986 remove ();
999 attacked_by = 0; 1011 attacked_by = 0;
1000 current_weapon = 0; 1012 current_weapon = 0;
1001} 1013}
1002 1014
1003void 1015void
1004object::destroy (bool destroy_inventory) 1016object::destroy ()
1005{ 1017{
1006 if (destroyed ()) 1018 if (destroyed ())
1007 return; 1019 return;
1008 1020
1009 if (!is_head () && !head->destroyed ()) 1021 if (!is_head () && !head->destroyed ())
1010 { 1022 {
1011 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1023 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1012 head->destroy (destroy_inventory); 1024 head->destroy ();
1013 return; 1025 return;
1014 } 1026 }
1015 1027
1016 destroy_inv (!destroy_inventory); 1028 destroy_inv (false);
1017 1029
1018 if (is_head ()) 1030 if (is_head ())
1019 if (sound_destroy) 1031 if (sound_destroy)
1020 play_sound (sound_destroy); 1032 play_sound (sound_destroy);
1021 else if (flag [FLAG_MONSTER]) 1033 else if (flag [FLAG_MONSTER])
1032 * the previous environment. 1044 * the previous environment.
1033 */ 1045 */
1034void 1046void
1035object::do_remove () 1047object::do_remove ()
1036{ 1048{
1037 object *tmp, *last = 0;
1038 object *otmp;
1039
1040 if (flag [FLAG_REMOVED]) 1049 if (flag [FLAG_REMOVED])
1041 return; 1050 return;
1042 1051
1043 INVOKE_OBJECT (REMOVE, this); 1052 INVOKE_OBJECT (REMOVE, this);
1044 1053
1057 if (object *pl = visible_to ()) 1066 if (object *pl = visible_to ())
1058 esrv_del_item (pl->contr, count); 1067 esrv_del_item (pl->contr, count);
1059 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1068 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1060 1069
1061 adjust_weight (env, -total_weight ()); 1070 adjust_weight (env, -total_weight ());
1071
1072 object *pl = in_player ();
1062 1073
1063 /* we set up values so that it could be inserted into 1074 /* we set up values so that it could be inserted into
1064 * the map, but we don't actually do that - it is up 1075 * the map, but we don't actually do that - it is up
1065 * to the caller to decide what we want to do. 1076 * to the caller to decide what we want to do.
1066 */ 1077 */
1078 1089
1079 /* NO_FIX_PLAYER is set when a great many changes are being 1090 /* NO_FIX_PLAYER is set when a great many changes are being
1080 * made to players inventory. If set, avoiding the call 1091 * made to players inventory. If set, avoiding the call
1081 * to save cpu time. 1092 * to save cpu time.
1082 */ 1093 */
1083 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1094 if (pl)
1095 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1096 {
1084 otmp->update_stats (); 1097 pl->update_stats ();
1098
1099 if (glow_radius && pl->is_on_map ())
1100 update_all_los (pl->map, pl->x, pl->y);
1101 }
1085 } 1102 }
1086 else if (map) 1103 else if (map)
1087 { 1104 {
1088 map->dirty = true; 1105 map->dirty = true;
1089 mapspace &ms = this->ms (); 1106 mapspace &ms = this->ms ();
1090 1107
1091 if (object *pl = ms.player ()) 1108 if (object *pl = ms.player ())
1092 { 1109 {
1093 if (type == PLAYER) // this == pl(!) 1110 if (is_player ())
1094 { 1111 {
1112 if (!flag [FLAG_WIZPASS])
1113 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1114
1095 // leaving a spot always closes any open container on the ground 1115 // leaving a spot always closes any open container on the ground
1096 if (container && !container->env) 1116 if (container && !container->env)
1097 // this causes spurious floorbox updates, but it ensures 1117 // this causes spurious floorbox updates, but it ensures
1098 // that the CLOSE event is being sent. 1118 // that the CLOSE event is being sent.
1099 close_container (); 1119 close_container ();
1100 1120
1101 --map->players; 1121 --map->players;
1102 map->touch (); 1122 map->touch ();
1103 } 1123 }
1104 else if (pl->container == this) 1124 else if (pl->container_ () == this)
1105 { 1125 {
1106 // removing a container should close it 1126 // removing a container should close it
1107 close_container (); 1127 close_container ();
1108 } 1128 }
1109 1129
1116 *(below ? &below->above : &ms.bot) = above; 1136 *(below ? &below->above : &ms.bot) = above;
1117 1137
1118 above = 0; 1138 above = 0;
1119 below = 0; 1139 below = 0;
1120 1140
1141 ms.invalidate ();
1142
1121 if (map->in_memory == MAP_SAVING) 1143 if (map->in_memory == MAP_SAVING)
1122 return; 1144 return;
1123 1145
1124 int check_walk_off = !flag [FLAG_NO_APPLY]; 1146 int check_walk_off = !flag [FLAG_NO_APPLY];
1125 1147
1126 if (object *pl = ms.player ()) 1148 if (object *pl = ms.player ())
1127 { 1149 {
1128 if (pl->container == this) 1150 if (pl->container_ () == this)
1129 /* If a container that the player is currently using somehow gets 1151 /* If a container that the player is currently using somehow gets
1130 * removed (most likely destroyed), update the player view 1152 * removed (most likely destroyed), update the player view
1131 * appropriately. 1153 * appropriately.
1132 */ 1154 */
1133 pl->close_container (); 1155 pl->close_container ();
1137 //TODO: update floorbox to preserve ordering 1159 //TODO: update floorbox to preserve ordering
1138 if (pl->contr->ns) 1160 if (pl->contr->ns)
1139 pl->contr->ns->floorbox_update (); 1161 pl->contr->ns->floorbox_update ();
1140 } 1162 }
1141 1163
1164 if (check_walk_off)
1142 for (tmp = ms.bot; tmp; tmp = tmp->above) 1165 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1143 { 1166 {
1167 above = tmp->above;
1168
1144 /* No point updating the players look faces if he is the object 1169 /* No point updating the players look faces if he is the object
1145 * being removed. 1170 * being removed.
1146 */ 1171 */
1147 1172
1148 /* See if object moving off should effect something */ 1173 /* See if object moving off should effect something */
1149 if (check_walk_off
1150 && ((move_type & tmp->move_off) 1174 if ((move_type & tmp->move_off)
1151 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1175 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1152 {
1153 move_apply (tmp, this, 0); 1176 move_apply (tmp, this, 0);
1154
1155 if (destroyed ())
1156 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1157 } 1177 }
1158 1178
1159 last = tmp; 1179 if (affects_los ())
1160 }
1161
1162 /* last == NULL if there are no objects on this space */
1163 //TODO: this makes little sense, why only update the topmost object?
1164 if (!last)
1165 map->at (x, y).flags_ = 0;
1166 else
1167 update_object (last, UP_OBJ_REMOVE);
1168
1169 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1170 update_all_los (map, x, y); 1180 update_all_los (map, x, y);
1171 } 1181 }
1172} 1182}
1173 1183
1174/* 1184/*
1198 esrv_update_item (UPD_NROF, pl, top); 1208 esrv_update_item (UPD_NROF, pl, top);
1199 1209
1200 op->weight = 0; // cancel the addition above 1210 op->weight = 0; // cancel the addition above
1201 op->carrying = 0; // must be 0 already 1211 op->carrying = 0; // must be 0 already
1202 1212
1203 op->destroy (1); 1213 op->destroy ();
1204 1214
1205 return top; 1215 return top;
1206 } 1216 }
1207 1217
1208 return 0; 1218 return 0;
1236 * job preparing multi-part monsters. 1246 * job preparing multi-part monsters.
1237 */ 1247 */
1238object * 1248object *
1239insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1249insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1240{ 1250{
1251 op->remove ();
1252
1241 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1253 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1242 { 1254 {
1243 tmp->x = x + tmp->arch->x; 1255 tmp->x = x + tmp->arch->x;
1244 tmp->y = y + tmp->arch->y; 1256 tmp->y = y + tmp->arch->y;
1245 } 1257 }
1270object * 1282object *
1271insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1283insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1272{ 1284{
1273 op->remove (); 1285 op->remove ();
1274 1286
1287 if (m == &freed_map)//D TODO: remove soon
1288 {//D
1289 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1290 }//D
1291
1275 /* Ideally, the caller figures this out. However, it complicates a lot 1292 /* Ideally, the caller figures this out. However, it complicates a lot
1276 * of areas of callers (eg, anything that uses find_free_spot would now 1293 * of areas of callers (eg, anything that uses find_free_spot would now
1277 * need extra work 1294 * need extra work
1278 */ 1295 */
1296 maptile *newmap = m;
1279 if (!xy_normalise (m, op->x, op->y)) 1297 if (!xy_normalise (newmap, op->x, op->y))
1280 { 1298 {
1281 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found 1299 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1282 return 0; 1300 return 0;
1283 } 1301 }
1284 1302
1285 if (object *more = op->more) 1303 if (object *more = op->more)
1286 if (!insert_ob_in_map (more, m, originator, flag)) 1304 if (!insert_ob_in_map (more, m, originator, flag))
1287 return 0; 1305 return 0;
1288 1306
1289 CLEAR_FLAG (op, FLAG_REMOVED); 1307 op->flag [FLAG_REMOVED] = false;
1290 1308 op->env = 0;
1291 op->map = m; 1309 op->map = newmap;
1310
1292 mapspace &ms = op->ms (); 1311 mapspace &ms = op->ms ();
1293 1312
1294 /* this has to be done after we translate the coordinates. 1313 /* this has to be done after we translate the coordinates.
1295 */ 1314 */
1296 if (op->nrof && !(flag & INS_NO_MERGE)) 1315 if (op->nrof && !(flag & INS_NO_MERGE))
1299 { 1318 {
1300 // TODO: we actually want to update tmp, not op, 1319 // TODO: we actually want to update tmp, not op,
1301 // but some caller surely breaks when we return tmp 1320 // but some caller surely breaks when we return tmp
1302 // from here :/ 1321 // from here :/
1303 op->nrof += tmp->nrof; 1322 op->nrof += tmp->nrof;
1304 tmp->destroy (1); 1323 tmp->destroy ();
1305 } 1324 }
1306 1325
1307 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1326 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1308 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1327 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1309 1328
1310 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1329 if (!QUERY_FLAG (op, FLAG_ALIVE))
1311 CLEAR_FLAG (op, FLAG_NO_STEAL); 1330 CLEAR_FLAG (op, FLAG_NO_STEAL);
1312 1331
1313 if (flag & INS_BELOW_ORIGINATOR) 1332 if (flag & INS_BELOW_ORIGINATOR)
1314 { 1333 {
1315 if (originator->map != op->map || originator->x != op->x || originator->y != op->y || !originator->is_on_map ()) 1334 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1316 { 1335 {
1317 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1336 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1337 abort ();
1338 }
1339
1340 if (!originator->is_on_map ())
1341 {
1342 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1343 op->debug_desc (), originator->debug_desc ());
1318 abort (); 1344 abort ();
1319 } 1345 }
1320 1346
1321 op->above = originator; 1347 op->above = originator;
1322 op->below = originator->below; 1348 op->below = originator->below;
1391 } /* If objects on this space */ 1417 } /* If objects on this space */
1392 1418
1393 if (flag & INS_ABOVE_FLOOR_ONLY) 1419 if (flag & INS_ABOVE_FLOOR_ONLY)
1394 top = floor; 1420 top = floor;
1395 1421
1396 /* Top is the object that our object (op) is going to get inserted above. 1422 // insert object above top, or bottom-most if top = 0
1397 */
1398
1399 /* no top found, insert on top */
1400 if (!top) 1423 if (!top)
1401 { 1424 {
1402 op->above = 0; 1425 op->below = 0;
1403 op->below = ms.top; 1426 op->above = ms.bot;
1404 ms.top = op; 1427 ms.bot = op;
1405 1428
1406 *(op->below ? &op->below->above : &ms.bot) = op; 1429 *(op->above ? &op->above->below : &ms.top) = op;
1407 } 1430 }
1408 else 1431 else
1409 { /* get inserted into the stack above top */ 1432 {
1410 op->above = top->above; 1433 op->above = top->above;
1411 top->above = op; 1434 top->above = op;
1412 1435
1413 op->below = top; 1436 op->below = top;
1414 *(op->above ? &op->above->below : &ms.top) = op; 1437 *(op->above ? &op->above->below : &ms.top) = op;
1415 } 1438 }
1416 } /* else not INS_BELOW_ORIGINATOR */ 1439 }
1417 1440
1418 if (op->type == PLAYER) 1441 if (op->is_player ())
1419 { 1442 {
1420 op->contr->do_los = 1; 1443 op->contr->do_los = 1;
1421 ++op->map->players; 1444 ++op->map->players;
1422 op->map->touch (); 1445 op->map->touch ();
1423 } 1446 }
1438 * be far away from this change and not affected in any way - 1461 * be far away from this change and not affected in any way -
1439 * this should get redone to only look for players within range, 1462 * this should get redone to only look for players within range,
1440 * or just updating the P_UPTODATE for spaces within this area 1463 * or just updating the P_UPTODATE for spaces within this area
1441 * of effect may be sufficient. 1464 * of effect may be sufficient.
1442 */ 1465 */
1443 if (op->map->darkness && (op->glow_radius != 0)) 1466 if (op->affects_los ())
1467 {
1468 op->ms ().invalidate ();
1444 update_all_los (op->map, op->x, op->y); 1469 update_all_los (op->map, op->x, op->y);
1470 }
1445 1471
1446 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1472 /* updates flags (blocked, alive, no magic, etc) for this map space */
1447 update_object (op, UP_OBJ_INSERT); 1473 update_object (op, UP_OBJ_INSERT);
1448 1474
1449 INVOKE_OBJECT (INSERT, op); 1475 INVOKE_OBJECT (INSERT, op);
1456 * blocked() and wall() work properly), and these flags are updated by 1482 * blocked() and wall() work properly), and these flags are updated by
1457 * update_object(). 1483 * update_object().
1458 */ 1484 */
1459 1485
1460 /* if this is not the head or flag has been passed, don't check walk on status */ 1486 /* if this is not the head or flag has been passed, don't check walk on status */
1461 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1487 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1462 { 1488 {
1463 if (check_move_on (op, originator)) 1489 if (check_move_on (op, originator))
1464 return 0; 1490 return 0;
1465 1491
1466 /* If we are a multi part object, lets work our way through the check 1492 /* If we are a multi part object, lets work our way through the check
1477/* this function inserts an object in the map, but if it 1503/* this function inserts an object in the map, but if it
1478 * finds an object of its own type, it'll remove that one first. 1504 * finds an object of its own type, it'll remove that one first.
1479 * op is the object to insert it under: supplies x and the map. 1505 * op is the object to insert it under: supplies x and the map.
1480 */ 1506 */
1481void 1507void
1482replace_insert_ob_in_map (const char *arch_string, object *op) 1508replace_insert_ob_in_map (shstr_tmp archname, object *op)
1483{ 1509{
1484 /* first search for itself and remove any old instances */ 1510 /* first search for itself and remove any old instances */
1485 1511
1486 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1512 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1487 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1513 if (tmp->arch->archname == archname) /* same archetype */
1488 tmp->destroy (1); 1514 tmp->destroy ();
1489 1515
1490 object *tmp = arch_to_object (archetype::find (arch_string)); 1516 object *tmp = arch_to_object (archetype::find (archname));
1491 1517
1492 tmp->x = op->x; 1518 tmp->x = op->x;
1493 tmp->y = op->y; 1519 tmp->y = op->y;
1494 1520
1495 insert_ob_in_map (tmp, op->map, op, 0); 1521 insert_ob_in_map (tmp, op->map, op, 0);
1517 if (!nr) 1543 if (!nr)
1518 return true; 1544 return true;
1519 1545
1520 nr = min (nr, nrof); 1546 nr = min (nr, nrof);
1521 1547
1548 if (nrof > nr)
1549 {
1522 nrof -= nr; 1550 nrof -= nr;
1523
1524 if (nrof)
1525 {
1526 adjust_weight (env, -weight * nr); // carrying == 0 1551 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1527 1552
1528 if (object *pl = visible_to ()) 1553 if (object *pl = visible_to ())
1529 esrv_update_item (UPD_NROF, pl, this); 1554 esrv_update_item (UPD_NROF, pl, this);
1530 1555
1531 return true; 1556 return true;
1532 } 1557 }
1533 else 1558 else
1534 { 1559 {
1535 destroy (1); 1560 destroy ();
1536 return false; 1561 return false;
1537 } 1562 }
1538} 1563}
1539 1564
1540/* 1565/*
1617 if (object *pl = tmp->visible_to ()) 1642 if (object *pl = tmp->visible_to ())
1618 esrv_update_item (UPD_NROF, pl, tmp); 1643 esrv_update_item (UPD_NROF, pl, tmp);
1619 1644
1620 adjust_weight (this, op->total_weight ()); 1645 adjust_weight (this, op->total_weight ());
1621 1646
1622 op->destroy (1); 1647 op->destroy ();
1623 op = tmp; 1648 op = tmp;
1624 goto inserted; 1649 goto inserted;
1625 } 1650 }
1626 1651
1627 op->owner = 0; // it's his/hers now. period. 1652 op->owner = 0; // it's his/hers now. period.
1645 1670
1646 adjust_weight (this, op->total_weight ()); 1671 adjust_weight (this, op->total_weight ());
1647 1672
1648inserted: 1673inserted:
1649 /* reset the light list and los of the players on the map */ 1674 /* reset the light list and los of the players on the map */
1650 if (op->glow_radius && map && map->darkness) 1675 if (op->glow_radius && is_on_map ())
1676 {
1677 update_stats ();
1651 update_all_los (map, x, y); 1678 update_all_los (map, x, y);
1652 1679 }
1680 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1653 // if this is a player's inventory, update stats 1681 // if this is a player's inventory, update stats
1654 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1655 update_stats (); 1682 update_stats ();
1656 1683
1657 INVOKE_OBJECT (INSERT, this); 1684 INVOKE_OBJECT (INSERT, this);
1658 1685
1659 return op; 1686 return op;
1680 * on top. 1707 * on top.
1681 */ 1708 */
1682int 1709int
1683check_move_on (object *op, object *originator) 1710check_move_on (object *op, object *originator)
1684{ 1711{
1712 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1713 return 0;
1714
1685 object *tmp; 1715 object *tmp;
1686 maptile *m = op->map; 1716 maptile *m = op->map;
1687 int x = op->x, y = op->y; 1717 int x = op->x, y = op->y;
1688 1718
1689 MoveType move_on, move_slow, move_block; 1719 mapspace &ms = m->at (x, y);
1690 1720
1691 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1721 ms.update ();
1692 return 0;
1693 1722
1694 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1723 MoveType move_on = ms.move_on;
1695 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1724 MoveType move_slow = ms.move_slow;
1696 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1725 MoveType move_block = ms.move_block;
1697 1726
1698 /* if nothing on this space will slow op down or be applied, 1727 /* if nothing on this space will slow op down or be applied,
1699 * no need to do checking below. have to make sure move_type 1728 * no need to do checking below. have to make sure move_type
1700 * is set, as lots of objects don't have it set - we treat that 1729 * is set, as lots of objects don't have it set - we treat that
1701 * as walking. 1730 * as walking.
1712 return 0; 1741 return 0;
1713 1742
1714 /* The objects have to be checked from top to bottom. 1743 /* The objects have to be checked from top to bottom.
1715 * Hence, we first go to the top: 1744 * Hence, we first go to the top:
1716 */ 1745 */
1717 1746 for (object *next, *tmp = ms.top; tmp; tmp = next)
1718 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1719 {
1720 /* Trim the search when we find the first other spell effect
1721 * this helps performance so that if a space has 50 spell objects,
1722 * we don't need to check all of them.
1723 */
1724 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1725 break;
1726 } 1747 {
1748 next = tmp->below;
1727 1749
1728 for (; tmp; tmp = tmp->below)
1729 {
1730 if (tmp == op) 1750 if (tmp == op)
1731 continue; /* Can't apply yourself */ 1751 continue; /* Can't apply yourself */
1732 1752
1733 /* Check to see if one of the movement types should be slowed down. 1753 /* Check to see if one of the movement types should be slowed down.
1734 * Second check makes sure that the movement types not being slowed 1754 * Second check makes sure that the movement types not being slowed
1739 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1759 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1740 { 1760 {
1741 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1761 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1742 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1762 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1743 { 1763 {
1744
1745 float
1746 diff = tmp->move_slow_penalty * fabs (op->speed); 1764 float diff = tmp->move_slow_penalty * fabs (op->speed);
1747 1765
1748 if (op->type == PLAYER) 1766 if (op->is_player ())
1749 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1767 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1750 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1768 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1751 diff /= 4.0; 1769 diff /= 4.0;
1752 1770
1753 op->speed_left -= diff; 1771 op->speed_left -= diff;
1754 } 1772 }
1755 } 1773 }
1961 * head of the object should correspond for the entire object. 1979 * head of the object should correspond for the entire object.
1962 */ 1980 */
1963 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1981 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1964 continue; 1982 continue;
1965 1983
1966 if (ob->blocked (m, pos.x, pos.y)) 1984 if (ob->blocked (pos.m, pos.x, pos.y))
1967 continue; 1985 continue;
1968 1986
1969 altern [index++] = i; 1987 altern [index++] = i;
1970 } 1988 }
1971 1989
2039 * there is capable of. 2057 * there is capable of.
2040 */ 2058 */
2041int 2059int
2042find_dir (maptile *m, int x, int y, object *exclude) 2060find_dir (maptile *m, int x, int y, object *exclude)
2043{ 2061{
2044 int i, max = SIZEOFFREE, mflags; 2062 int max = SIZEOFFREE, mflags;
2045
2046 sint16 nx, ny;
2047 object *tmp;
2048 maptile *mp;
2049
2050 MoveType blocked, move_type; 2063 MoveType move_type;
2051 2064
2052 if (exclude && exclude->head_ () != exclude) 2065 if (exclude && exclude->head_ () != exclude)
2053 { 2066 {
2054 exclude = exclude->head; 2067 exclude = exclude->head;
2055 move_type = exclude->move_type; 2068 move_type = exclude->move_type;
2058 { 2071 {
2059 /* If we don't have anything, presume it can use all movement types. */ 2072 /* If we don't have anything, presume it can use all movement types. */
2060 move_type = MOVE_ALL; 2073 move_type = MOVE_ALL;
2061 } 2074 }
2062 2075
2063 for (i = 1; i < max; i++) 2076 for (int i = 1; i < max; i++)
2064 { 2077 {
2065 mp = m; 2078 mapxy pos (m, x, y);
2066 nx = x + freearr_x[i]; 2079 pos.move (i);
2067 ny = y + freearr_y[i];
2068 2080
2069 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2081 if (!pos.normalise ())
2070
2071 if (mflags & P_OUT_OF_MAP)
2072 max = maxfree[i]; 2082 max = maxfree[i];
2073 else 2083 else
2074 { 2084 {
2075 mapspace &ms = mp->at (nx, ny); 2085 mapspace &ms = *pos;
2076 2086
2077 blocked = ms.move_block;
2078
2079 if ((move_type & blocked) == move_type) 2087 if ((move_type & ms.move_block) == move_type)
2080 max = maxfree[i]; 2088 max = maxfree [i];
2081 else if (mflags & P_IS_ALIVE) 2089 else if (ms.flags () & P_IS_ALIVE)
2082 { 2090 {
2083 for (tmp = ms.bot; tmp; tmp = tmp->above) 2091 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2084 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2092 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2085 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2093 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2086 break;
2087
2088 if (tmp)
2089 return freedir[i]; 2094 return freedir [i];
2090 } 2095 }
2091 } 2096 }
2092 } 2097 }
2093 2098
2094 return 0; 2099 return 0;
2169 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2170 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2171 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2172 * functions. 2177 * functions.
2173 */ 2178 */
2174int reduction_dir[SIZEOFFREE][3] = { 2179static const int reduction_dir[SIZEOFFREE][3] = {
2175 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2176 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2177 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2178 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2179 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
2275int 2280int
2276can_pick (const object *who, const object *item) 2281can_pick (const object *who, const object *item)
2277{ 2282{
2278 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2283 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2279 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2284 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2280 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2285 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2281} 2286}
2282 2287
2283/* 2288/*
2284 * create clone from object to another 2289 * create clone from object to another
2285 */ 2290 */
2317 return tmp; 2322 return tmp;
2318 2323
2319 return 0; 2324 return 0;
2320} 2325}
2321 2326
2322const shstr & 2327shstr_tmp
2323object::kv_get (const shstr &key) const 2328object::kv_get (shstr_tmp key) const
2324{ 2329{
2325 for (key_value *kv = key_values; kv; kv = kv->next) 2330 for (key_value *kv = key_values; kv; kv = kv->next)
2326 if (kv->key == key) 2331 if (kv->key == key)
2327 return kv->value; 2332 return kv->value;
2328 2333
2329 return shstr_null; 2334 return shstr ();
2330} 2335}
2331 2336
2332void 2337void
2333object::kv_set (const shstr &key, const shstr &value) 2338object::kv_set (shstr_tmp key, shstr_tmp value)
2334{ 2339{
2335 for (key_value *kv = key_values; kv; kv = kv->next) 2340 for (key_value *kv = key_values; kv; kv = kv->next)
2336 if (kv->key == key) 2341 if (kv->key == key)
2337 { 2342 {
2338 kv->value = value; 2343 kv->value = value;
2347 2352
2348 key_values = kv; 2353 key_values = kv;
2349} 2354}
2350 2355
2351void 2356void
2352object::kv_del (const shstr &key) 2357object::kv_del (shstr_tmp key)
2353{ 2358{
2354 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2359 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2355 if ((*kvp)->key == key) 2360 if ((*kvp)->key == key)
2356 { 2361 {
2357 key_value *kv = *kvp; 2362 key_value *kv = *kvp;
2416{ 2421{
2417 char flagdesc[512]; 2422 char flagdesc[512];
2418 char info2[256 * 4]; 2423 char info2[256 * 4];
2419 char *p = info; 2424 char *p = info;
2420 2425
2421 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2426 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2422 count, 2427 count,
2423 uuid.c_str (), 2428 uuid.c_str (),
2424 &name, 2429 &name,
2425 title ? "\",title:\"" : "", 2430 title ? ",title:\"" : "",
2426 title ? (const char *)title : "", 2431 title ? (const char *)title : "",
2432 title ? "\"" : "",
2427 flag_desc (flagdesc, 512), type); 2433 flag_desc (flagdesc, 512), type);
2428 2434
2429 if (!flag[FLAG_REMOVED] && env) 2435 if (!flag[FLAG_REMOVED] && env)
2430 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2436 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2431 2437
2487 container = 0; 2493 container = 0;
2488 2494
2489 // client needs item update to make it work, client bug requires this to be separate 2495 // client needs item update to make it work, client bug requires this to be separate
2490 esrv_update_item (UPD_FLAGS, this, old_container); 2496 esrv_update_item (UPD_FLAGS, this, old_container);
2491 2497
2492 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2498 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2493 play_sound (sound_find ("chest_close")); 2499 play_sound (sound_find ("chest_close"));
2494 } 2500 }
2495 2501
2496 if (new_container) 2502 if (new_container)
2497 { 2503 {
2507 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2513 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2508 new_container->insert (closer); 2514 new_container->insert (closer);
2509 } 2515 }
2510#endif 2516#endif
2511 2517
2512 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2518 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2513 2519
2514 // make sure the container is available, client bug requires this to be separate 2520 // make sure the container is available, client bug requires this to be separate
2515 esrv_send_item (this, new_container); 2521 esrv_send_item (this, new_container);
2516 2522
2517 new_container->flag [FLAG_APPLIED] = true; 2523 new_container->flag [FLAG_APPLIED] = true;
2525// else if (!old_container->env && contr && contr->ns) 2531// else if (!old_container->env && contr && contr->ns)
2526// contr->ns->floorbox_reset (); 2532// contr->ns->floorbox_reset ();
2527} 2533}
2528 2534
2529object * 2535object *
2530object::force_find (const shstr name) 2536object::force_find (shstr_tmp name)
2531{ 2537{
2532 /* cycle through his inventory to look for the MARK we want to 2538 /* cycle through his inventory to look for the MARK we want to
2533 * place 2539 * place
2534 */ 2540 */
2535 for (object *tmp = inv; tmp; tmp = tmp->below) 2541 for (object *tmp = inv; tmp; tmp = tmp->below)
2537 return splay (tmp); 2543 return splay (tmp);
2538 2544
2539 return 0; 2545 return 0;
2540} 2546}
2541 2547
2548//-GPL
2549
2542void 2550void
2551object::force_set_timer (int duration)
2552{
2553 this->duration = 1;
2554 this->speed_left = -1.f;
2555
2556 this->set_speed (duration ? 1.f / duration : 0.f);
2557}
2558
2559object *
2543object::force_add (const shstr name, int duration) 2560object::force_add (shstr_tmp name, int duration)
2544{ 2561{
2545 if (object *force = force_find (name)) 2562 if (object *force = force_find (name))
2546 force->destroy (); 2563 force->destroy ();
2547 2564
2548 object *force = get_archetype (FORCE_NAME); 2565 object *force = get_archetype (FORCE_NAME);
2549 2566
2550 force->slaying = name; 2567 force->slaying = name;
2551 force->stats.food = 1; 2568 force->force_set_timer (duration);
2552 force->speed_left = -1.f;
2553
2554 force->set_speed (duration ? 1.f / duration : 0.f);
2555 force->flag [FLAG_IS_USED_UP] = true;
2556 force->flag [FLAG_APPLIED] = true; 2569 force->flag [FLAG_APPLIED] = true;
2557 2570
2558 insert (force); 2571 return insert (force);
2559} 2572}
2560 2573
2561void 2574void
2562object::play_sound (faceidx sound) 2575object::play_sound (faceidx sound) const
2563{ 2576{
2564 if (!sound) 2577 if (!sound)
2565 return; 2578 return;
2566 2579
2567 if (flag [FLAG_REMOVED]) 2580 if (is_on_map ())
2581 map->play_sound (sound, x, y);
2582 else if (object *pl = in_player ())
2583 pl->contr->play_sound (sound);
2584}
2585
2586void
2587object::say_msg (const char *msg) const
2588{
2589 if (is_on_map ())
2590 map->say_msg (msg, x, y);
2591 else if (object *pl = in_player ())
2592 pl->contr->play_sound (sound);
2593}
2594
2595void
2596object::make_noise ()
2597{
2598 // we do not model noise in the map, so instead put
2599 // a temporary light into the noise source
2600 // could use the map instead, but that's less reliable for our
2601 // goal, which is to make invisibility a bit harder to exploit
2602
2603 // currently only works sensibly for players
2604 if (!is_player ())
2568 return; 2605 return;
2569 2606
2570 if (env) 2607 // find old force, or create new one
2571 { 2608 object *force = force_find (shstr_noise_force);
2572 if (object *pl = in_player ()) 2609
2573 pl->contr->play_sound (sound); 2610 if (force)
2574 } 2611 force->speed_left = -1.f; // patch old speed up
2575 else 2612 else
2576 map->play_sound (sound, x, y); 2613 {
2577} 2614 force = archetype::get (shstr_noise_force);
2578 2615
2616 force->slaying = shstr_noise_force;
2617 force->stats.food = 1;
2618 force->speed_left = -1.f;
2619
2620 force->set_speed (1.f / 4.f);
2621 force->flag [FLAG_IS_USED_UP] = true;
2622 force->flag [FLAG_APPLIED] = true;
2623
2624 insert (force);
2625 }
2626}
2627

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines