ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.207 by root, Sun Apr 20 23:25:09 2008 UTC vs.
Revision 1.308 by root, Sun Nov 29 17:26:28 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27 24
28#include <global.h> 25#include <global.h>
29#include <stdio.h> 26#include <stdio.h>
30#include <sys/types.h> 27#include <sys/types.h>
31#include <sys/uio.h> 28#include <sys/uio.h>
32#include <object.h> 29#include <object.h>
33#include <funcpoint.h>
34#include <sproto.h> 30#include <sproto.h>
35#include <loader.h> 31#include <loader.h>
36 32
37#include <bitset> 33#include <bitset>
38 34
39UUID UUID::cur; 35UUID UUID::cur;
40static uint64_t seq_next_save; 36static uint64_t seq_next_save;
41static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
42 39
43objectvec objects; 40objectvec objects;
44activevec actives; 41activevec actives;
42
43//+GPL
45 44
46short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
47 0, 46 0,
48 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
49 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
53 0, 52 0,
54 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
55 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
56 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
57}; 56};
58int maxfree[SIZEOFFREE] = {
59 0,
60 9, 10, 13, 14, 17, 18, 21, 22,
61 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
62 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
63};
64int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
65 0, 58 0,
66 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
67 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
68 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
69}; 62};
70 63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
69};
70
71static void 71static void
72write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
73{ 73{
74 CALL_BEGIN (2); 74 CALL_BEGIN (2);
75 CALL_ARG_SV (newSVval64 (skip)); 75 CALL_ARG_SV (newSVval64 (skip));
77 CALL_CALL ("cf::write_uuid", G_DISCARD); 77 CALL_CALL ("cf::write_uuid", G_DISCARD);
78 CALL_END; 78 CALL_END;
79} 79}
80 80
81static void 81static void
82read_uuid (void) 82read_uuid ()
83{ 83{
84 char filename[MAX_BUF]; 84 char filename[MAX_BUF];
85 85
86 sprintf (filename, "%s/uuid", settings.localdir); 86 sprintf (filename, "%s/uuid", settings.localdir);
87 87
101 101
102 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 102 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
103 _exit (1); 103 _exit (1);
104 } 104 }
105 105
106 UUID::BUF buf; 106 char buf [UUID::MAX_LEN];
107 buf[0] = 0; 107 buf[0] = 0;
108 fgets (buf, sizeof (buf), fp); 108 fgets (buf, sizeof (buf), fp);
109 109
110 if (!UUID::cur.parse (buf)) 110 if (!UUID::cur.parse (buf))
111 { 111 {
138 138
139void 139void
140UUID::init () 140UUID::init ()
141{ 141{
142 read_uuid (); 142 read_uuid ();
143}
144
145bool
146UUID::parse (const char *s)
147{
148 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
149 return false;
150
151 seq = 0;
152
153 while (*s != '>')
154 {
155 if (*s < '0')
156 return false;
157
158 // this gives nice branchless code with gcc
159 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
160 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
161
162 seq = (seq << 4) | digit;
163
164 ++s;
165 }
166
167 return true;
168}
169
170char *
171UUID::append (char *buf) const
172{
173 *buf++ = '<';
174 *buf++ = '1';
175 *buf++ = '.';
176
177 uint64_t seq = this->seq;
178 const int bits = 64;
179 char nz = 0;
180 static const char tohex [] = "0123456789abcdef";
181
182 // assert (len >= 3 + bits / 4 + 1 + 1);
183 for (int i = bits / 4; --i; )
184 {
185 uint8_t digit = seq >> (bits - 4);
186
187 *buf = tohex [digit];
188 nz |= digit;
189 buf += nz ? 1 : 0;
190 seq <<= 4;
191 }
192
193 // last digit is special - always emit
194 uint8_t digit = seq >> (bits - 4);
195 *buf++ = tohex [digit];
196
197 *buf++ = '>';
198
199 return buf;
200}
201
202char *
203UUID::c_str () const
204{
205 static char buf [MAX_LEN];
206 *append (buf) = 0;
207 return buf;
143} 208}
144 209
145/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 210/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
146static bool 211static bool
147compare_ob_value_lists_one (const object *wants, const object *has) 212compare_ob_value_lists_one (const object *wants, const object *has)
148{ 213{
149 key_value *wants_field;
150
151 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 214 /* n-squared behaviour (see kv_get), but I'm hoping both
152 * objects with lists are rare, and lists stay short. If not, use a 215 * objects with lists are rare, and lists stay short. If not, use a
153 * different structure or at least keep the lists sorted... 216 * different structure or at least keep the lists sorted...
154 */ 217 */
155 218
156 /* For each field in wants, */ 219 /* For each field in wants, */
157 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 220 for (key_value *kv = wants->key_values; kv; kv = kv->next)
158 { 221 if (has->kv_get (kv->key) != kv->value)
159 key_value *has_field; 222 return false;
160
161 /* Look for a field in has with the same key. */
162 has_field = get_ob_key_link (has, wants_field->key);
163
164 if (!has_field)
165 return 0; /* No field with that name. */
166
167 /* Found the matching field. */
168 if (has_field->value != wants_field->value)
169 return 0; /* Values don't match, so this half of the comparison is false. */
170
171 /* If we get here, we found a match. Now for the next field in wants. */
172 }
173 223
174 /* If we get here, every field in wants has a matching field in has. */ 224 /* If we get here, every field in wants has a matching field in has. */
175 return 1; 225 return true;
176} 226}
177 227
178/* Returns TRUE if ob1 has the same key_values as ob2. */ 228/* Returns TRUE if ob1 has the same key_values as ob2. */
179static bool 229static bool
180compare_ob_value_lists (const object *ob1, const object *ob2) 230compare_ob_value_lists (const object *ob1, const object *ob2)
181{ 231{
182 /* However, there may be fields in has which aren't partnered in wants, 232 /* However, there may be fields in has which aren't partnered in wants,
183 * so we need to run the comparison *twice*. :( 233 * so we need to run the comparison *twice*. :(
184 */ 234 */
185 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 235 return compare_ob_value_lists_one (ob1, ob2)
236 && compare_ob_value_lists_one (ob2, ob1);
186} 237}
187 238
188/* Function examines the 2 objects given to it, and returns true if 239/* Function examines the 2 objects given to it, and returns true if
189 * they can be merged together. 240 * they can be merged together.
190 * 241 *
200bool object::can_merge_slow (object *ob1, object *ob2) 251bool object::can_merge_slow (object *ob1, object *ob2)
201{ 252{
202 /* A couple quicksanity checks */ 253 /* A couple quicksanity checks */
203 if (ob1 == ob2 254 if (ob1 == ob2
204 || ob1->type != ob2->type 255 || ob1->type != ob2->type
205 || ob1->speed != ob2->speed 256 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED
206 || ob1->value != ob2->value 257 || ob1->value != ob2->value
207 || ob1->name != ob2->name) 258 || ob1->name != ob2->name)
208 return 0; 259 return 0;
209 260
210 /* Do not merge objects if nrof would overflow. First part checks 261 /* Do not merge objects if nrof would overflow, assume nrof
211 * for unsigned overflow (2c), second part checks wether the result 262 * is always 0 .. 2**31-1 */
212 * would fit into a 32 bit signed int, which is often used to hold 263 if (ob1->nrof > 0x7fffffff - ob2->nrof)
213 * nrof values.
214 */
215 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
216 return 0; 264 return 0;
217 265
218 /* If the objects have been identified, set the BEEN_APPLIED flag. 266 /* If the objects have been identified, set the BEEN_APPLIED flag.
219 * This is to the comparison of the flags below will be OK. We 267 * This is to the comparison of the flags below will be OK. We
220 * just can't ignore the been applied or identified flags, as they 268 * just can't ignore the been applied or identified flags, as they
225 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 273 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
226 274
227 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 275 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
228 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 276 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
229 277
230 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 278 if (ob1->arch->archname != ob2->arch->archname
231 || ob1->arch != ob2->arch
232 || ob1->name != ob2->name 279 || ob1->name != ob2->name
233 || ob1->title != ob2->title 280 || ob1->title != ob2->title
234 || ob1->msg != ob2->msg 281 || ob1->msg != ob2->msg
235 || ob1->weight != ob2->weight 282 || ob1->weight != ob2->weight
236 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 || ob1->attacktype != ob2->attacktype 283 || ob1->attacktype != ob2->attacktype
239 || ob1->magic != ob2->magic 284 || ob1->magic != ob2->magic
240 || ob1->slaying != ob2->slaying 285 || ob1->slaying != ob2->slaying
241 || ob1->skill != ob2->skill 286 || ob1->skill != ob2->skill
242 || ob1->value != ob2->value 287 || ob1->value != ob2->value
243 || ob1->animation_id != ob2->animation_id 288 || ob1->animation_id != ob2->animation_id
289 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
244 || ob1->client_type != ob2->client_type 290 || ob1->client_type != ob2->client_type
245 || ob1->materialname != ob2->materialname 291 || ob1->material != ob2->material
246 || ob1->lore != ob2->lore 292 || ob1->lore != ob2->lore
247 || ob1->subtype != ob2->subtype 293 || ob1->subtype != ob2->subtype
248 || ob1->move_type != ob2->move_type 294 || ob1->move_type != ob2->move_type
249 || ob1->move_block != ob2->move_block 295 || ob1->move_block != ob2->move_block
250 || ob1->move_allow != ob2->move_allow 296 || ob1->move_allow != ob2->move_allow
251 || ob1->move_on != ob2->move_on 297 || ob1->move_on != ob2->move_on
252 || ob1->move_off != ob2->move_off 298 || ob1->move_off != ob2->move_off
253 || ob1->move_slow != ob2->move_slow 299 || ob1->move_slow != ob2->move_slow
254 || ob1->move_slow_penalty != ob2->move_slow_penalty) 300 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
301 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
302 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
303 return 0;
304
305 if ((ob1->flag ^ ob2->flag)
306 .reset (FLAG_INV_LOCKED)
307 .reset (FLAG_REMOVED)
308 .any ())
255 return 0; 309 return 0;
256 310
257 /* This is really a spellbook check - we should in general 311 /* This is really a spellbook check - we should in general
258 * not merge objects with real inventories, as splitting them 312 * not merge objects with real inventories, as splitting them
259 * is hard. 313 * is hard.
298 352
299 if (ob1->key_values || ob2->key_values) 353 if (ob1->key_values || ob2->key_values)
300 { 354 {
301 /* At least one of these has key_values. */ 355 /* At least one of these has key_values. */
302 if ((!ob1->key_values) != (!ob2->key_values)) 356 if ((!ob1->key_values) != (!ob2->key_values))
303 /* One has fields, but the other one doesn't. */ 357 return 0; /* One has fields, but the other one doesn't. */
304 return 0; 358
305 else if (!compare_ob_value_lists (ob1, ob2)) 359 if (!compare_ob_value_lists (ob1, ob2))
306 return 0; 360 return 0;
307 } 361 }
308 362
309 if (ob1->self || ob2->self) 363 if (ob1->self || ob2->self)
310 { 364 {
316 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 370 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
317 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 371 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
318 372
319 if (k1 != k2) 373 if (k1 != k2)
320 return 0; 374 return 0;
375
321 else if (k1 == 0) 376 if (k1 == 0)
322 return 1; 377 return 1;
378
323 else if (!cfperl_can_merge (ob1, ob2)) 379 if (!cfperl_can_merge (ob1, ob2))
324 return 0; 380 return 0;
325 } 381 }
326 } 382 }
327 383
328 /* Everything passes, must be OK. */ 384 /* Everything passes, must be OK. */
329 return 1; 385 return 1;
330} 386}
331 387
388// find player who can see this object
389object *
390object::visible_to () const
391{
392 if (client_visible () && !flag [FLAG_REMOVED])
393 {
394 // see if we are in a container of sorts
395 if (env)
396 {
397 // the player inventory itself is always visible
398 if (env->is_player ())
399 return env;
400
401 // else a player could have our env open
402 object *envest = env->outer_env_or_self ();
403
404 // the player itself is always on a map, so we will find him here
405 // even if our inv is in a player.
406 if (envest->is_on_map ())
407 if (object *pl = envest->ms ().player ())
408 if (pl->container_ () == env)
409 return pl;
410 }
411 else
412 {
413 // maybe there is a player standing on the same mapspace
414 // this will catch the case where "this" is a player
415 if (object *pl = ms ().player ())
416 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
417 || pl->container_ () == this)
418 return pl;
419 }
420 }
421
422 return 0;
423}
424
425// adjust weight per container type ("of holding")
332static sint32 426static sint32
333weight_adjust (object *op, sint32 weight) 427weight_adjust_for (object *op, sint32 weight)
334{ 428{
335 return op->type == CONTAINER 429 return op->type == CONTAINER
336 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 430 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
337 : weight; 431 : weight;
338} 432}
339 433
340/* 434/*
341 * add_weight(object, weight) adds the specified weight to an object, 435 * adjust_weight(object, weight) adds the specified weight to an object,
342 * and also updates how much the environment(s) is/are carrying. 436 * and also updates how much the environment(s) is/are carrying.
343 */ 437 */
344static void 438static void
345add_weight (object *op, sint32 weight) 439adjust_weight (object *op, sint32 weight)
346{ 440{
347 while (op) 441 while (op)
348 { 442 {
443 // adjust by actual difference to account for rounding errors
444 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
349 weight = weight_adjust (op, weight); 445 weight = weight_adjust_for (op, op->carrying)
446 - weight_adjust_for (op, op->carrying - weight);
447
448 if (!weight)
449 return;
350 450
351 op->carrying += weight; 451 op->carrying += weight;
452
453 if (object *pl = op->visible_to ())
454 if (pl != op) // player is handled lazily
455 esrv_update_item (UPD_WEIGHT, pl, op);
456
352 op = op->env; 457 op = op->env;
353 } 458 }
354}
355
356/*
357 * sub_weight() recursively (outwards) subtracts a number from the
358 * weight of an object (and what is carried by it's environment(s)).
359 */
360static void
361sub_weight (object *op, long weight)
362{
363 add_weight (op, -weight);
364} 459}
365 460
366/* 461/*
367 * this is a recursive function which calculates the weight 462 * this is a recursive function which calculates the weight
368 * an object is carrying. It goes through op and figures out how much 463 * an object is carrying. It goes through op and figures out how much
379 op->update_weight (); 474 op->update_weight ();
380 475
381 sum += op->total_weight (); 476 sum += op->total_weight ();
382 } 477 }
383 478
384 carrying = weight_adjust (this, sum); 479 sum = weight_adjust_for (this, sum);
385}
386 480
481 if (sum != carrying)
482 {
483 carrying = sum;
484
485 if (object *pl = visible_to ())
486 if (pl != this) // player is handled lazily
487 esrv_update_item (UPD_WEIGHT, pl, this);
488 }
489}
490
387/* 491/*
388 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 492 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
389 * Some error messages.
390 * The result of the dump is stored in the static global errmsg array.
391 */ 493 */
392char * 494char *
393dump_object (object *op) 495dump_object (object *op)
394{ 496{
395 if (!op) 497 if (!op)
398 object_freezer freezer; 500 object_freezer freezer;
399 op->write (freezer); 501 op->write (freezer);
400 return freezer.as_string (); 502 return freezer.as_string ();
401} 503}
402 504
403/* 505char *
404 * get_nearest_part(multi-object, object 2) returns the part of the 506object::as_string ()
405 * multi-object 1 which is closest to the second object.
406 * If it's not a multi-object, it is returned.
407 */
408object *
409get_nearest_part (object *op, const object *pl)
410{ 507{
411 object *tmp, *closest; 508 return dump_object (this);
412 int last_dist, i;
413
414 if (op->more == NULL)
415 return op;
416 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)
417 if ((i = distance (tmp, pl)) < last_dist)
418 closest = tmp, last_dist = i;
419 return closest;
420} 509}
421 510
422/* 511/*
423 * Returns the object which has the count-variable equal to the argument. 512 * Returns the object which has the count-variable equal to the argument.
513 * VERRRY slow.
424 */ 514 */
425object * 515object *
426find_object (tag_t i) 516find_object (tag_t i)
427{ 517{
428 for_all_objects (op) 518 for_all_objects (op)
439 */ 529 */
440object * 530object *
441find_object_name (const char *str) 531find_object_name (const char *str)
442{ 532{
443 shstr_cmp str_ (str); 533 shstr_cmp str_ (str);
444 object *op;
445 534
535 if (str_)
446 for_all_objects (op) 536 for_all_objects (op)
447 if (op->name == str_) 537 if (op->name == str_)
448 break; 538 return op;
449 539
450 return op; 540 return 0;
451} 541}
452 542
453/* 543/*
454 * Sets the owner and sets the skill and exp pointers to owner's current 544 * Sets the owner and sets the skill and exp pointers to owner's current
455 * skill and experience objects. 545 * skill and experience objects.
517 update_stats (); 607 update_stats ();
518 608
519 new_draw_info_format (NDI_UNIQUE, 0, this, 609 new_draw_info_format (NDI_UNIQUE, 0, this,
520 "You try to balance all your items at once, " 610 "You try to balance all your items at once, "
521 "but the %s is just too much for your body. " 611 "but the %s is just too much for your body. "
522 "[You need to unapply some items first.]", &ob->name); 612 "[You need to unapply some items first - use the 'body' command to see "
613 "how many items you cna wera on a specific body part.]", &ob->name);
523 return false; 614 return false;
524 } 615 }
525 616
526 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 617 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
527 } 618 }
553 } 644 }
554 645
555 op->key_values = 0; 646 op->key_values = 0;
556} 647}
557 648
558object & 649/*
559object::operator =(const object &src) 650 * copy_to first frees everything allocated by the dst object,
651 * and then copies the contents of itself into the second
652 * object, allocating what needs to be allocated. Basically, any
653 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
654 * if the first object is freed, the pointers in the new object
655 * will point at garbage.
656 */
657void
658object::copy_to (object *dst)
560{ 659{
561 bool is_freed = flag [FLAG_FREED]; 660 dst->remove ();
562 bool is_removed = flag [FLAG_REMOVED];
563
564 *(object_copy *)this = src; 661 *(object_copy *)dst = *this;
565
566 flag [FLAG_FREED] = is_freed;
567 flag [FLAG_REMOVED] = is_removed; 662 dst->flag [FLAG_REMOVED] = true;
568 663
569 /* Copy over key_values, if any. */ 664 /* Copy over key_values, if any. */
570 if (src.key_values) 665 if (key_values)
571 { 666 {
572 key_value *tail = 0; 667 key_value *tail = 0;
573 key_values = 0; 668 dst->key_values = 0;
574 669
575 for (key_value *i = src.key_values; i; i = i->next) 670 for (key_value *i = key_values; i; i = i->next)
576 { 671 {
577 key_value *new_link = new key_value; 672 key_value *new_link = new key_value;
578 673
579 new_link->next = 0; 674 new_link->next = 0;
580 new_link->key = i->key; 675 new_link->key = i->key;
581 new_link->value = i->value; 676 new_link->value = i->value;
582 677
583 /* Try and be clever here, too. */ 678 /* Try and be clever here, too. */
584 if (!key_values) 679 if (!dst->key_values)
585 { 680 {
586 key_values = new_link; 681 dst->key_values = new_link;
587 tail = new_link; 682 tail = new_link;
588 } 683 }
589 else 684 else
590 { 685 {
591 tail->next = new_link; 686 tail->next = new_link;
592 tail = new_link; 687 tail = new_link;
593 } 688 }
594 } 689 }
595 } 690 }
596}
597 691
598/* 692 dst->activate ();
599 * copy_to first frees everything allocated by the dst object,
600 * and then copies the contents of itself into the second
601 * object, allocating what needs to be allocated. Basically, any
602 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
603 * if the first object is freed, the pointers in the new object
604 * will point at garbage.
605 */
606void
607object::copy_to (object *dst)
608{
609 *dst = *this;
610
611 if (speed < 0)
612 dst->speed_left -= rndm ();
613
614 dst->set_speed (dst->speed);
615} 693}
616 694
617void 695void
618object::instantiate () 696object::instantiate ()
619{ 697{
620 if (!uuid.seq) // HACK 698 if (!uuid.seq) // HACK
621 uuid = UUID::gen (); 699 uuid = UUID::gen ();
622 700
701 // TODO: unclean state changes, should nt be done in copy_to AND instantiate
702 if (flag [FLAG_RANDOM_SPEED] && speed)
703 speed_left = - speed - rndm (); // TODO animation
704 else
623 speed_left = -0.1f; 705 speed_left = -1.;
706
624 /* copy the body_info to the body_used - this is only really 707 /* copy the body_info to the body_used - this is only really
625 * need for monsters, but doesn't hurt to do it for everything. 708 * need for monsters, but doesn't hurt to do it for everything.
626 * by doing so, when a monster is created, it has good starting 709 * by doing so, when a monster is created, it has good starting
627 * values for the body_used info, so when items are created 710 * values for the body_used info, so when items are created
628 * for it, they can be properly equipped. 711 * for it, they can be properly equipped.
636object * 719object *
637object::clone () 720object::clone ()
638{ 721{
639 object *neu = create (); 722 object *neu = create ();
640 copy_to (neu); 723 copy_to (neu);
724
725 // TODO: unclean state changes, should not be done in clone AND instantiate
726 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
727 neu->speed_left = - neu->speed - rndm (); // TODO animation
728
729 neu->map = map; // not copied by copy_to
641 return neu; 730 return neu;
642} 731}
643 732
644/* 733/*
645 * If an object with the IS_TURNABLE() flag needs to be turned due 734 * If an object with the IS_TURNABLE() flag needs to be turned due
662 * This function needs to be called whenever the speed of an object changes. 751 * This function needs to be called whenever the speed of an object changes.
663 */ 752 */
664void 753void
665object::set_speed (float speed) 754object::set_speed (float speed)
666{ 755{
667 if (flag [FLAG_FREED] && speed)
668 {
669 LOG (llevError, "Object %s is freed but has speed.\n", &name);
670 speed = 0;
671 }
672
673 this->speed = speed; 756 this->speed = speed;
674 757
675 if (has_active_speed ()) 758 if (has_active_speed ())
676 activate (); 759 activate ();
677 else 760 else
696 * UP_OBJ_FACE: only the objects face has changed. 779 * UP_OBJ_FACE: only the objects face has changed.
697 */ 780 */
698void 781void
699update_object (object *op, int action) 782update_object (object *op, int action)
700{ 783{
701 if (op == NULL) 784 if (!op)
702 { 785 {
703 /* this should never happen */ 786 /* this should never happen */
704 LOG (llevDebug, "update_object() called for NULL object.\n"); 787 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
705 return; 788 return;
706 } 789 }
707 790
708 if (op->env) 791 if (!op->is_on_map ())
709 { 792 {
710 /* Animation is currently handled by client, so nothing 793 /* Animation is currently handled by client, so nothing
711 * to do in this case. 794 * to do in this case.
712 */ 795 */
713 return; 796 return;
714 } 797 }
715
716 /* If the map is saving, don't do anything as everything is
717 * going to get freed anyways.
718 */
719 if (!op->map || op->map->in_memory == MAP_SAVING)
720 return;
721 798
722 /* make sure the object is within map boundaries */ 799 /* make sure the object is within map boundaries */
723 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 800 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
724 { 801 {
725 LOG (llevError, "update_object() called for object out of map!\n"); 802 LOG (llevError, "update_object() called for object out of map!\n");
733 810
734 if (!(m.flags_ & P_UPTODATE)) 811 if (!(m.flags_ & P_UPTODATE))
735 /* nop */; 812 /* nop */;
736 else if (action == UP_OBJ_INSERT) 813 else if (action == UP_OBJ_INSERT)
737 { 814 {
815#if 0
738 // this is likely overkill, TODO: revisit (schmorp) 816 // this is likely overkill, TODO: revisit (schmorp)
739 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 817 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
740 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 818 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
741 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 819 || (op->is_player () && !(m.flags_ & P_PLAYER))
742 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 820 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
743 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 821 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
744 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 822 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
745 || (m.move_on | op->move_on ) != m.move_on 823 || (m.move_on | op->move_on ) != m.move_on
746 || (m.move_off | op->move_off ) != m.move_off 824 || (m.move_off | op->move_off ) != m.move_off
747 || (m.move_slow | op->move_slow) != m.move_slow 825 || (m.move_slow | op->move_slow) != m.move_slow
748 /* This isn't perfect, but I don't expect a lot of objects to 826 /* This isn't perfect, but I don't expect a lot of objects to
749 * to have move_allow right now. 827 * have move_allow right now.
750 */ 828 */
751 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 829 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
830 m.invalidate ();
831#else
752 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 832 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
753 m.flags_ = 0; 833 m.invalidate ();
834#endif
754 } 835 }
755 /* if the object is being removed, we can't make intelligent 836 /* if the object is being removed, we can't make intelligent
756 * decisions, because remove_ob can't really pass the object 837 * decisions, because remove_ob can't really pass the object
757 * that is being removed. 838 * that is being removed.
758 */ 839 */
759 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 840 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
760 m.flags_ = 0; 841 m.invalidate ();
761 else if (action == UP_OBJ_FACE) 842 else if (action == UP_OBJ_FACE)
762 /* Nothing to do for that case */ ; 843 /* Nothing to do for that case */ ;
763 else 844 else
764 LOG (llevError, "update_object called with invalid action: %d\n", action); 845 LOG (llevError, "update_object called with invalid action: %d\n", action);
765 846
769 850
770object::object () 851object::object ()
771{ 852{
772 SET_FLAG (this, FLAG_REMOVED); 853 SET_FLAG (this, FLAG_REMOVED);
773 854
774 expmul = 1.0; 855 //expmul = 1.0; declared const for the time being
775 face = blank_face; 856 face = blank_face;
857 material = MATERIAL_NULL;
776} 858}
777 859
778object::~object () 860object::~object ()
779{ 861{
780 unlink (); 862 unlink ();
809 /* If already on active list, don't do anything */ 891 /* If already on active list, don't do anything */
810 if (active) 892 if (active)
811 return; 893 return;
812 894
813 if (has_active_speed ()) 895 if (has_active_speed ())
896 {
897 if (flag [FLAG_FREED])
898 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
899
814 actives.insert (this); 900 actives.insert (this);
901 }
815} 902}
816 903
817void 904void
818object::activate_recursive () 905object::activate_recursive ()
819{ 906{
868object::destroy_inv (bool drop_to_ground) 955object::destroy_inv (bool drop_to_ground)
869{ 956{
870 // need to check first, because the checks below might segfault 957 // need to check first, because the checks below might segfault
871 // as we might be on an invalid mapspace and crossfire code 958 // as we might be on an invalid mapspace and crossfire code
872 // is too buggy to ensure that the inventory is empty. 959 // is too buggy to ensure that the inventory is empty.
873 // corollary: if you create arrows etc. with stuff in tis inventory, 960 // corollary: if you create arrows etc. with stuff in its inventory,
874 // cf will crash below with off-map x and y 961 // cf will crash below with off-map x and y
875 if (!inv) 962 if (!inv)
876 return; 963 return;
877 964
878 /* Only if the space blocks everything do we not process - 965 /* Only if the space blocks everything do we not process -
880 * drop on that space. 967 * drop on that space.
881 */ 968 */
882 if (!drop_to_ground 969 if (!drop_to_ground
883 || !map 970 || !map
884 || map->in_memory != MAP_ACTIVE 971 || map->in_memory != MAP_ACTIVE
885 || map->nodrop 972 || map->no_drop
886 || ms ().move_block == MOVE_ALL) 973 || ms ().move_block == MOVE_ALL)
887 { 974 {
888 while (inv) 975 while (inv)
889 {
890 inv->destroy_inv (drop_to_ground);
891 inv->destroy (); 976 inv->destroy ();
892 }
893 } 977 }
894 else 978 else
895 { /* Put objects in inventory onto this space */ 979 { /* Put objects in inventory onto this space */
896 while (inv) 980 while (inv)
897 { 981 {
915 object *op = new object; 999 object *op = new object;
916 op->link (); 1000 op->link ();
917 return op; 1001 return op;
918} 1002}
919 1003
1004static struct freed_map : maptile
1005{
1006 freed_map ()
1007 {
1008 path = "<freed objects map>";
1009 name = "/internal/freed_objects_map";
1010 width = 3;
1011 height = 3;
1012 no_drop = 1;
1013 no_reset = 1;
1014
1015 alloc ();
1016 in_memory = MAP_ACTIVE;
1017 }
1018
1019 ~freed_map ()
1020 {
1021 destroy ();
1022 }
1023} freed_map; // freed objects are moved here to avoid crashes
1024
920void 1025void
921object::do_destroy () 1026object::do_destroy ()
922{ 1027{
923 attachable::do_destroy ();
924
925 if (flag [FLAG_IS_LINKED]) 1028 if (flag [FLAG_IS_LINKED])
926 remove_button_link (this); 1029 remove_link ();
927 1030
928 if (flag [FLAG_FRIENDLY]) 1031 if (flag [FLAG_FRIENDLY])
929 remove_friendly_object (this); 1032 remove_friendly_object (this);
930 1033
931 if (!flag [FLAG_REMOVED])
932 remove (); 1034 remove ();
933 1035
934 destroy_inv (true); 1036 attachable::do_destroy ();
935 1037
936 deactivate (); 1038 deactivate ();
937 unlink (); 1039 unlink ();
938 1040
939 flag [FLAG_FREED] = 1; 1041 flag [FLAG_FREED] = 1;
940 1042
941 // hack to ensure that freed objects still have a valid map 1043 // hack to ensure that freed objects still have a valid map
942 {
943 static maptile *freed_map; // freed objects are moved here to avoid crashes
944
945 if (!freed_map)
946 {
947 freed_map = new maptile;
948
949 freed_map->path = "<freed objects map>";
950 freed_map->name = "/internal/freed_objects_map";
951 freed_map->width = 3;
952 freed_map->height = 3;
953 freed_map->nodrop = 1;
954
955 freed_map->alloc ();
956 freed_map->in_memory = MAP_ACTIVE;
957 }
958
959 map = freed_map; 1044 map = &freed_map;
960 x = 1; 1045 x = 1;
961 y = 1; 1046 y = 1;
962 }
963 1047
964 if (more) 1048 if (more)
965 { 1049 {
966 more->destroy (); 1050 more->destroy ();
967 more = 0; 1051 more = 0;
975 attacked_by = 0; 1059 attacked_by = 0;
976 current_weapon = 0; 1060 current_weapon = 0;
977} 1061}
978 1062
979void 1063void
980object::destroy (bool destroy_inventory) 1064object::destroy ()
981{ 1065{
982 if (destroyed ()) 1066 if (destroyed ())
983 return; 1067 return;
984 1068
985 if (destroy_inventory) 1069 if (!is_head () && !head->destroyed ())
1070 {
1071 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1072 head->destroy ();
1073 return;
1074 }
1075
986 destroy_inv (false); 1076 destroy_inv (false);
987 1077
988 if (is_head ()) 1078 if (is_head ())
989 if (sound_destroy) 1079 if (sound_destroy)
990 play_sound (sound_destroy); 1080 play_sound (sound_destroy);
991 else if (flag [FLAG_MONSTER]) 1081 else if (flag [FLAG_MONSTER])
1002 * the previous environment. 1092 * the previous environment.
1003 */ 1093 */
1004void 1094void
1005object::do_remove () 1095object::do_remove ()
1006{ 1096{
1007 object *tmp, *last = 0; 1097 if (flag [FLAG_REMOVED])
1008 object *otmp;
1009
1010 if (QUERY_FLAG (this, FLAG_REMOVED))
1011 return; 1098 return;
1012 1099
1013 SET_FLAG (this, FLAG_REMOVED);
1014 INVOKE_OBJECT (REMOVE, this); 1100 INVOKE_OBJECT (REMOVE, this);
1101
1102 flag [FLAG_REMOVED] = true;
1015 1103
1016 if (more) 1104 if (more)
1017 more->remove (); 1105 more->remove ();
1018 1106
1019 /* 1107 /*
1020 * In this case, the object to be removed is in someones 1108 * In this case, the object to be removed is in someones
1021 * inventory. 1109 * inventory.
1022 */ 1110 */
1023 if (env) 1111 if (env)
1024 { 1112 {
1025 if (nrof) 1113 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1026 sub_weight (env, weight * nrof); 1114 if (object *pl = visible_to ())
1027 else 1115 esrv_del_item (pl->contr, count);
1028 sub_weight (env, weight + carrying); 1116 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1029 1117
1030 /* NO_FIX_PLAYER is set when a great many changes are being 1118 adjust_weight (env, -total_weight ());
1031 * made to players inventory. If set, avoiding the call
1032 * to save cpu time.
1033 */
1034 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1035 otmp->update_stats ();
1036 1119
1037 if (above) 1120 object *pl = in_player ();
1038 above->below = below;
1039 else
1040 env->inv = below;
1041
1042 if (below)
1043 below->above = above;
1044 1121
1045 /* we set up values so that it could be inserted into 1122 /* we set up values so that it could be inserted into
1046 * the map, but we don't actually do that - it is up 1123 * the map, but we don't actually do that - it is up
1047 * to the caller to decide what we want to do. 1124 * to the caller to decide what we want to do.
1048 */ 1125 */
1049 x = env->x, y = env->y;
1050 map = env->map; 1126 map = env->map;
1051 above = 0, below = 0; 1127 x = env->x;
1128 y = env->y;
1129
1130 // make sure cmov optimisation is applicable
1131 *(above ? &above->below : &env->inv) = below;
1132 *(below ? &below->above : &above ) = above; // &above is just a dummy
1133
1134 above = 0;
1135 below = 0;
1052 env = 0; 1136 env = 0;
1137
1138 if (pl && pl->is_player ())
1139 {
1140 pl->contr->queue_stats_update ();
1141
1142 if (glow_radius && pl->is_on_map ())
1143 update_all_los (pl->map, pl->x, pl->y);
1144 }
1053 } 1145 }
1054 else if (map) 1146 else if (map)
1055 { 1147 {
1056 if (type == PLAYER)
1057 {
1058 // leaving a spot always closes any open container on the ground
1059 if (container && !container->env)
1060 // this causes spurious floorbox updates, but it ensures
1061 // that the CLOSE event is being sent.
1062 close_container ();
1063
1064 --map->players;
1065 map->touch ();
1066 }
1067
1068 map->dirty = true; 1148 map->dirty = true;
1069 mapspace &ms = this->ms (); 1149 mapspace &ms = this->ms ();
1070 1150
1151 if (object *pl = ms.player ())
1152 {
1153 if (is_player ())
1154 {
1155 if (!flag [FLAG_WIZPASS])
1156 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1157
1158 // leaving a spot always closes any open container on the ground
1159 if (container && !container->env)
1160 // this causes spurious floorbox updates, but it ensures
1161 // that the CLOSE event is being sent.
1162 close_container ();
1163
1164 --map->players;
1165 map->touch ();
1166 }
1167 else if (pl->container_ () == this)
1168 {
1169 // removing a container should close it
1170 close_container ();
1171 }
1172
1173 esrv_del_item (pl->contr, count);
1174 }
1175
1071 /* link the object above us */ 1176 /* link the object above us */
1072 if (above) 1177 // re-link, make sure compiler can easily use cmove
1073 above->below = below; 1178 *(above ? &above->below : &ms.top) = below;
1074 else 1179 *(below ? &below->above : &ms.bot) = above;
1075 ms.top = below; /* we were top, set new top */
1076
1077 /* Relink the object below us, if there is one */
1078 if (below)
1079 below->above = above;
1080 else
1081 {
1082 /* Nothing below, which means we need to relink map object for this space
1083 * use translated coordinates in case some oddness with map tiling is
1084 * evident
1085 */
1086 if (GET_MAP_OB (map, x, y) != this)
1087 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1088
1089 ms.bot = above; /* goes on above it. */
1090 }
1091 1180
1092 above = 0; 1181 above = 0;
1093 below = 0; 1182 below = 0;
1094 1183
1184 ms.invalidate ();
1185
1095 if (map->in_memory == MAP_SAVING) 1186 if (map->in_memory == MAP_SAVING)
1096 return; 1187 return;
1097 1188
1098 int check_walk_off = !flag [FLAG_NO_APPLY]; 1189 int check_walk_off = !flag [FLAG_NO_APPLY];
1099 1190
1100 if (object *pl = ms.player ()) 1191 if (object *pl = ms.player ())
1101 { 1192 {
1102 if (pl->container == this) 1193 if (pl->container_ () == this)
1103 /* If a container that the player is currently using somehow gets 1194 /* If a container that the player is currently using somehow gets
1104 * removed (most likely destroyed), update the player view 1195 * removed (most likely destroyed), update the player view
1105 * appropriately. 1196 * appropriately.
1106 */ 1197 */
1107 pl->close_container (); 1198 pl->close_container ();
1108 1199
1200 //TODO: the floorbox prev/next might need updating
1201 //esrv_del_item (pl->contr, count);
1202 //TODO: update floorbox to preserve ordering
1203 if (pl->contr->ns)
1109 pl->contr->ns->floorbox_update (); 1204 pl->contr->ns->floorbox_update ();
1110 } 1205 }
1111 1206
1207 if (check_walk_off)
1112 for (tmp = ms.bot; tmp; tmp = tmp->above) 1208 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1113 { 1209 {
1210 above = tmp->above;
1211
1114 /* No point updating the players look faces if he is the object 1212 /* No point updating the players look faces if he is the object
1115 * being removed. 1213 * being removed.
1116 */ 1214 */
1117 1215
1118 /* See if object moving off should effect something */ 1216 /* See if object moving off should effect something */
1119 if (check_walk_off
1120 && ((move_type & tmp->move_off) 1217 if ((move_type & tmp->move_off)
1121 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1218 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1122 {
1123 move_apply (tmp, this, 0); 1219 move_apply (tmp, this, 0);
1124
1125 if (destroyed ())
1126 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1127 } 1220 }
1128 1221
1129 last = tmp; 1222 if (affects_los ())
1130 }
1131
1132 /* last == NULL if there are no objects on this space */
1133 //TODO: this makes little sense, why only update the topmost object?
1134 if (!last)
1135 map->at (x, y).flags_ = 0;
1136 else
1137 update_object (last, UP_OBJ_REMOVE);
1138
1139 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1140 update_all_los (map, x, y); 1223 update_all_los (map, x, y);
1141 } 1224 }
1142} 1225}
1143 1226
1144/* 1227/*
1158 if (!top) 1241 if (!top)
1159 for (top = op; top && top->above; top = top->above) 1242 for (top = op; top && top->above; top = top->above)
1160 ; 1243 ;
1161 1244
1162 for (; top; top = top->below) 1245 for (; top; top = top->below)
1163 {
1164 if (top == op)
1165 continue;
1166
1167 if (object::can_merge (op, top)) 1246 if (object::can_merge (op, top))
1168 { 1247 {
1169 top->nrof += op->nrof; 1248 top->nrof += op->nrof;
1170 1249
1171/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1250 if (object *pl = top->visible_to ())
1172 op->weight = 0; /* Don't want any adjustements now */ 1251 esrv_update_item (UPD_NROF, pl, top);
1252
1253 op->weight = 0; // cancel the addition above
1254 op->carrying = 0; // must be 0 already
1255
1173 op->destroy (); 1256 op->destroy ();
1257
1174 return top; 1258 return top;
1175 } 1259 }
1176 }
1177 1260
1178 return 0; 1261 return 0;
1179} 1262}
1180 1263
1181void 1264void
1206 * job preparing multi-part monsters. 1289 * job preparing multi-part monsters.
1207 */ 1290 */
1208object * 1291object *
1209insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1292insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1210{ 1293{
1294 op->remove ();
1295
1211 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1296 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1212 { 1297 {
1213 tmp->x = x + tmp->arch->x; 1298 tmp->x = x + tmp->arch->x;
1214 tmp->y = y + tmp->arch->y; 1299 tmp->y = y + tmp->arch->y;
1215 } 1300 }
1238 * just 'op' otherwise 1323 * just 'op' otherwise
1239 */ 1324 */
1240object * 1325object *
1241insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1326insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1242{ 1327{
1243 assert (!op->flag [FLAG_FREED]);
1244
1245 object *top, *floor = NULL;
1246
1247 op->remove (); 1328 op->remove ();
1329
1330 if (m == &freed_map)//D TODO: remove soon
1331 {//D
1332 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1333 }//D
1248 1334
1249 /* Ideally, the caller figures this out. However, it complicates a lot 1335 /* Ideally, the caller figures this out. However, it complicates a lot
1250 * of areas of callers (eg, anything that uses find_free_spot would now 1336 * of areas of callers (eg, anything that uses find_free_spot would now
1251 * need extra work 1337 * need extra work
1252 */ 1338 */
1339 maptile *newmap = m;
1253 if (!xy_normalise (m, op->x, op->y)) 1340 if (!xy_normalise (newmap, op->x, op->y))
1254 { 1341 {
1255 op->destroy (); 1342 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1256 return 0; 1343 return 0;
1257 } 1344 }
1258 1345
1259 if (object *more = op->more) 1346 if (object *more = op->more)
1260 if (!insert_ob_in_map (more, m, originator, flag)) 1347 if (!insert_ob_in_map (more, m, originator, flag))
1261 return 0; 1348 return 0;
1262 1349
1263 CLEAR_FLAG (op, FLAG_REMOVED); 1350 op->flag [FLAG_REMOVED] = false;
1264 1351 op->env = 0;
1265 op->map = m; 1352 op->map = newmap;
1353
1266 mapspace &ms = op->ms (); 1354 mapspace &ms = op->ms ();
1267 1355
1268 /* this has to be done after we translate the coordinates. 1356 /* this has to be done after we translate the coordinates.
1269 */ 1357 */
1270 if (op->nrof && !(flag & INS_NO_MERGE)) 1358 if (op->nrof && !(flag & INS_NO_MERGE))
1271 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1359 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1272 if (object::can_merge (op, tmp)) 1360 if (object::can_merge (op, tmp))
1273 { 1361 {
1362 // TODO: we actually want to update tmp, not op,
1363 // but some caller surely breaks when we return tmp
1364 // from here :/
1274 op->nrof += tmp->nrof; 1365 op->nrof += tmp->nrof;
1275 tmp->destroy (); 1366 tmp->destroy ();
1276 } 1367 }
1277 1368
1278 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1369 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1287 { 1378 {
1288 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1379 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1289 abort (); 1380 abort ();
1290 } 1381 }
1291 1382
1383 if (!originator->is_on_map ())
1384 {
1385 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1386 op->debug_desc (), originator->debug_desc ());
1387 abort ();
1388 }
1389
1292 op->above = originator; 1390 op->above = originator;
1293 op->below = originator->below; 1391 op->below = originator->below;
1294
1295 if (op->below)
1296 op->below->above = op;
1297 else
1298 ms.bot = op;
1299
1300 /* since *below* originator, no need to update top */
1301 originator->below = op; 1392 originator->below = op;
1393
1394 *(op->below ? &op->below->above : &ms.bot) = op;
1302 } 1395 }
1303 else 1396 else
1304 { 1397 {
1305 top = ms.bot; 1398 object *floor = 0;
1399 object *top = ms.top;
1306 1400
1307 /* If there are other objects, then */ 1401 /* If there are other objects, then */
1308 if (top) 1402 if (top)
1309 { 1403 {
1310 object *last = 0;
1311
1312 /* 1404 /*
1313 * If there are multiple objects on this space, we do some trickier handling. 1405 * If there are multiple objects on this space, we do some trickier handling.
1314 * We've already dealt with merging if appropriate. 1406 * We've already dealt with merging if appropriate.
1315 * Generally, we want to put the new object on top. But if 1407 * Generally, we want to put the new object on top. But if
1316 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1408 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1319 * once we get to them. This reduces the need to traverse over all of 1411 * once we get to them. This reduces the need to traverse over all of
1320 * them when adding another one - this saves quite a bit of cpu time 1412 * them when adding another one - this saves quite a bit of cpu time
1321 * when lots of spells are cast in one area. Currently, it is presumed 1413 * when lots of spells are cast in one area. Currently, it is presumed
1322 * that flying non pickable objects are spell objects. 1414 * that flying non pickable objects are spell objects.
1323 */ 1415 */
1324 for (top = ms.bot; top; top = top->above) 1416 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1325 { 1417 {
1326 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1418 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1327 floor = top; 1419 floor = tmp;
1328 1420
1329 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1421 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1330 { 1422 {
1331 /* We insert above top, so we want this object below this */ 1423 /* We insert above top, so we want this object below this */
1332 top = top->below; 1424 top = tmp->below;
1333 break; 1425 break;
1334 } 1426 }
1335 1427
1336 last = top; 1428 top = tmp;
1337 } 1429 }
1338
1339 /* Don't want top to be NULL, so set it to the last valid object */
1340 top = last;
1341 1430
1342 /* We let update_position deal with figuring out what the space 1431 /* We let update_position deal with figuring out what the space
1343 * looks like instead of lots of conditions here. 1432 * looks like instead of lots of conditions here.
1344 * makes things faster, and effectively the same result. 1433 * makes things faster, and effectively the same result.
1345 */ 1434 */
1352 */ 1441 */
1353 if (!(flag & INS_ON_TOP) 1442 if (!(flag & INS_ON_TOP)
1354 && ms.flags () & P_BLOCKSVIEW 1443 && ms.flags () & P_BLOCKSVIEW
1355 && (op->face && !faces [op->face].visibility)) 1444 && (op->face && !faces [op->face].visibility))
1356 { 1445 {
1446 object *last;
1447
1357 for (last = top; last != floor; last = last->below) 1448 for (last = top; last != floor; last = last->below)
1358 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1449 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1359 break; 1450 break;
1360 1451
1361 /* Check to see if we found the object that blocks view, 1452 /* Check to see if we found the object that blocks view,
1369 } /* If objects on this space */ 1460 } /* If objects on this space */
1370 1461
1371 if (flag & INS_ABOVE_FLOOR_ONLY) 1462 if (flag & INS_ABOVE_FLOOR_ONLY)
1372 top = floor; 1463 top = floor;
1373 1464
1374 /* Top is the object that our object (op) is going to get inserted above. 1465 // insert object above top, or bottom-most if top = 0
1375 */
1376
1377 /* First object on this space */
1378 if (!top) 1466 if (!top)
1379 { 1467 {
1468 op->below = 0;
1380 op->above = ms.bot; 1469 op->above = ms.bot;
1381
1382 if (op->above)
1383 op->above->below = op;
1384
1385 op->below = 0;
1386 ms.bot = op; 1470 ms.bot = op;
1471
1472 *(op->above ? &op->above->below : &ms.top) = op;
1387 } 1473 }
1388 else 1474 else
1389 { /* get inserted into the stack above top */ 1475 {
1390 op->above = top->above; 1476 op->above = top->above;
1391
1392 if (op->above)
1393 op->above->below = op; 1477 top->above = op;
1394 1478
1395 op->below = top; 1479 op->below = top;
1396 top->above = op; 1480 *(op->above ? &op->above->below : &ms.top) = op;
1397 } 1481 }
1482 }
1398 1483
1399 if (!op->above) 1484 if (op->is_player ())
1400 ms.top = op;
1401 } /* else not INS_BELOW_ORIGINATOR */
1402
1403 if (op->type == PLAYER)
1404 { 1485 {
1405 op->contr->do_los = 1; 1486 op->contr->do_los = 1;
1406 ++op->map->players; 1487 ++op->map->players;
1407 op->map->touch (); 1488 op->map->touch ();
1408 } 1489 }
1409 1490
1410 op->map->dirty = true; 1491 op->map->dirty = true;
1411 1492
1412 if (object *pl = ms.player ()) 1493 if (object *pl = ms.player ())
1494 //TODO: the floorbox prev/next might need updating
1495 //esrv_send_item (pl, op);
1496 //TODO: update floorbox to preserve ordering
1497 if (pl->contr->ns)
1413 pl->contr->ns->floorbox_update (); 1498 pl->contr->ns->floorbox_update ();
1414 1499
1415 /* If this object glows, it may affect lighting conditions that are 1500 /* If this object glows, it may affect lighting conditions that are
1416 * visible to others on this map. But update_all_los is really 1501 * visible to others on this map. But update_all_los is really
1417 * an inefficient way to do this, as it means los for all players 1502 * an inefficient way to do this, as it means los for all players
1418 * on the map will get recalculated. The players could very well 1503 * on the map will get recalculated. The players could very well
1419 * be far away from this change and not affected in any way - 1504 * be far away from this change and not affected in any way -
1420 * this should get redone to only look for players within range, 1505 * this should get redone to only look for players within range,
1421 * or just updating the P_UPTODATE for spaces within this area 1506 * or just updating the P_UPTODATE for spaces within this area
1422 * of effect may be sufficient. 1507 * of effect may be sufficient.
1423 */ 1508 */
1424 if (op->map->darkness && (op->glow_radius != 0)) 1509 if (op->affects_los ())
1510 {
1511 op->ms ().invalidate ();
1425 update_all_los (op->map, op->x, op->y); 1512 update_all_los (op->map, op->x, op->y);
1513 }
1426 1514
1427 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1515 /* updates flags (blocked, alive, no magic, etc) for this map space */
1428 update_object (op, UP_OBJ_INSERT); 1516 update_object (op, UP_OBJ_INSERT);
1429 1517
1430 INVOKE_OBJECT (INSERT, op); 1518 INVOKE_OBJECT (INSERT, op);
1437 * blocked() and wall() work properly), and these flags are updated by 1525 * blocked() and wall() work properly), and these flags are updated by
1438 * update_object(). 1526 * update_object().
1439 */ 1527 */
1440 1528
1441 /* if this is not the head or flag has been passed, don't check walk on status */ 1529 /* if this is not the head or flag has been passed, don't check walk on status */
1442 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1530 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1443 { 1531 {
1444 if (check_move_on (op, originator)) 1532 if (check_move_on (op, originator))
1445 return 0; 1533 return 0;
1446 1534
1447 /* If we are a multi part object, lets work our way through the check 1535 /* If we are a multi part object, lets work our way through the check
1458/* this function inserts an object in the map, but if it 1546/* this function inserts an object in the map, but if it
1459 * finds an object of its own type, it'll remove that one first. 1547 * finds an object of its own type, it'll remove that one first.
1460 * op is the object to insert it under: supplies x and the map. 1548 * op is the object to insert it under: supplies x and the map.
1461 */ 1549 */
1462void 1550void
1463replace_insert_ob_in_map (const char *arch_string, object *op) 1551replace_insert_ob_in_map (shstr_tmp archname, object *op)
1464{ 1552{
1465 object *tmp, *tmp1;
1466
1467 /* first search for itself and remove any old instances */ 1553 /* first search for itself and remove any old instances */
1468 1554
1469 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1555 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1470 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1556 if (tmp->arch->archname == archname) /* same archetype */
1471 tmp->destroy (); 1557 tmp->destroy ();
1472 1558
1473 tmp1 = arch_to_object (archetype::find (arch_string)); 1559 object *tmp = archetype::find (archname)->instance ();
1474 1560
1475 tmp1->x = op->x; 1561 tmp->x = op->x;
1476 tmp1->y = op->y; 1562 tmp->y = op->y;
1563
1477 insert_ob_in_map (tmp1, op->map, op, 0); 1564 insert_ob_in_map (tmp, op->map, op, 0);
1478} 1565}
1479 1566
1480object * 1567object *
1481object::insert_at (object *where, object *originator, int flags) 1568object::insert_at (object *where, object *originator, int flags)
1482{ 1569{
1484 return where->env->insert (this); 1571 return where->env->insert (this);
1485 else 1572 else
1486 return where->map->insert (this, where->x, where->y, originator, flags); 1573 return where->map->insert (this, where->x, where->y, originator, flags);
1487} 1574}
1488 1575
1489/* 1576// check whether we can put this into the map, respect max_volume, max_items
1490 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1577bool
1491 * is returned contains nr objects, and the remaining parts contains 1578object::can_drop_at (maptile *m, int x, int y, object *originator)
1492 * the rest (or is removed and freed if that number is 0).
1493 * On failure, NULL is returned, and the reason put into the
1494 * global static errmsg array.
1495 */
1496object *
1497get_split_ob (object *orig_ob, uint32 nr)
1498{ 1579{
1499 object *newob; 1580 mapspace &ms = m->at (x, y);
1500 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1501 1581
1502 if (orig_ob->nrof < nr) 1582 int items = ms.items ();
1503 {
1504 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1505 return NULL;
1506 }
1507 1583
1508 newob = object_create_clone (orig_ob); 1584 if (!items // testing !items ensures we can drop at least one item
1585 || (items < m->max_items
1586 && ms.volume () < m->max_volume))
1587 return true;
1509 1588
1510 if ((orig_ob->nrof -= nr) < 1) 1589 if (originator && originator->is_player ())
1511 orig_ob->destroy (1); 1590 originator->contr->failmsg (format (
1512 else if (!is_removed) 1591 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1513 { 1592 query_name ()
1514 if (orig_ob->env != NULL) 1593 ));
1515 sub_weight (orig_ob->env, orig_ob->weight * nr);
1516 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_ACTIVE)
1517 {
1518 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1519 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1520 return NULL;
1521 }
1522 }
1523 1594
1524 newob->nrof = nr; 1595 return false;
1525
1526 return newob;
1527} 1596}
1528 1597
1529/* 1598/*
1530 * decrease_ob_nr(object, number) decreases a specified number from 1599 * decrease(object, number) decreases a specified number from
1531 * the amount of an object. If the amount reaches 0, the object 1600 * the amount of an object. If the amount reaches 0, the object
1532 * is subsequently removed and freed. 1601 * is subsequently removed and freed.
1533 * 1602 *
1534 * Return value: 'op' if something is left, NULL if the amount reached 0 1603 * Return value: 'op' if something is left, NULL if the amount reached 0
1535 */ 1604 */
1605bool
1606object::decrease (sint32 nr)
1607{
1608 if (!nr)
1609 return true;
1610
1611 nr = min (nr, nrof);
1612
1613 if (nrof > nr)
1614 {
1615 nrof -= nr;
1616 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1617
1618 if (object *pl = visible_to ())
1619 esrv_update_item (UPD_NROF, pl, this);
1620
1621 return true;
1622 }
1623 else
1624 {
1625 destroy ();
1626 return false;
1627 }
1628}
1629
1630/*
1631 * split(ob,nr) splits up ob into two parts. The part which
1632 * is returned contains nr objects, and the remaining parts contains
1633 * the rest (or is removed and returned if that number is 0).
1634 * On failure, NULL is returned.
1635 */
1536object * 1636object *
1537decrease_ob_nr (object *op, uint32 i) 1637object::split (sint32 nr)
1538{ 1638{
1539 object *tmp; 1639 int have = number_of ();
1540 1640
1541 if (i == 0) /* objects with op->nrof require this check */ 1641 if (have < nr)
1542 return op; 1642 return 0;
1543 1643 else if (have == nr)
1544 if (i > op->nrof)
1545 i = op->nrof;
1546
1547 if (QUERY_FLAG (op, FLAG_REMOVED))
1548 op->nrof -= i;
1549 else if (op->env)
1550 { 1644 {
1551 /* is this object in the players inventory, or sub container
1552 * therein?
1553 */
1554 tmp = op->in_player ();
1555 /* nope. Is this a container the player has opened?
1556 * If so, set tmp to that player.
1557 * IMO, searching through all the players will mostly
1558 * likely be quicker than following op->env to the map,
1559 * and then searching the map for a player.
1560 */
1561 if (!tmp)
1562 for_all_players (pl)
1563 if (pl->ob->container == op->env)
1564 {
1565 tmp = pl->ob;
1566 break;
1567 }
1568
1569 if (i < op->nrof)
1570 {
1571 sub_weight (op->env, op->weight * i);
1572 op->nrof -= i;
1573 if (tmp)
1574 esrv_send_item (tmp, op);
1575 }
1576 else
1577 {
1578 op->remove (); 1645 remove ();
1579 op->nrof = 0; 1646 return this;
1580 if (tmp)
1581 esrv_del_item (tmp->contr, op->count);
1582 }
1583 } 1647 }
1584 else 1648 else
1585 { 1649 {
1586 object *above = op->above; 1650 decrease (nr);
1587 1651
1588 if (i < op->nrof) 1652 object *op = deep_clone ();
1589 op->nrof -= i; 1653 op->nrof = nr;
1590 else
1591 {
1592 op->remove ();
1593 op->nrof = 0;
1594 }
1595
1596 /* Since we just removed op, op->above is null */
1597 for (tmp = above; tmp; tmp = tmp->above)
1598 if (tmp->type == PLAYER)
1599 {
1600 if (op->nrof)
1601 esrv_send_item (tmp, op);
1602 else
1603 esrv_del_item (tmp->contr, op->count);
1604 }
1605 }
1606
1607 if (op->nrof)
1608 return op; 1654 return op;
1609 else
1610 {
1611 op->destroy ();
1612 return 0;
1613 } 1655 }
1614} 1656}
1615 1657
1616object * 1658object *
1617insert_ob_in_ob (object *op, object *where) 1659insert_ob_in_ob (object *op, object *where)
1642 * be != op, if items are merged. -Tero 1684 * be != op, if items are merged. -Tero
1643 */ 1685 */
1644object * 1686object *
1645object::insert (object *op) 1687object::insert (object *op)
1646{ 1688{
1647 if (!QUERY_FLAG (op, FLAG_REMOVED))
1648 op->remove ();
1649
1650 if (op->more) 1689 if (op->more)
1651 { 1690 {
1652 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1691 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1653 return op; 1692 return op;
1654 } 1693 }
1655 1694
1656 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1695 op->remove ();
1657 CLEAR_FLAG (op, FLAG_REMOVED); 1696
1697 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1658 1698
1659 if (op->nrof) 1699 if (op->nrof)
1660 {
1661 for (object *tmp = inv; tmp; tmp = tmp->below) 1700 for (object *tmp = inv; tmp; tmp = tmp->below)
1662 if (object::can_merge (tmp, op)) 1701 if (object::can_merge (tmp, op))
1663 { 1702 {
1664 /* return the original object and remove inserted object 1703 /* return the original object and remove inserted object
1665 (client needs the original object) */ 1704 (client needs the original object) */
1666 tmp->nrof += op->nrof; 1705 tmp->nrof += op->nrof;
1667 /* Weight handling gets pretty funky. Since we are adding to 1706
1668 * tmp->nrof, we need to increase the weight. 1707 if (object *pl = tmp->visible_to ())
1669 */ 1708 esrv_update_item (UPD_NROF, pl, tmp);
1709
1670 add_weight (this, op->weight * op->nrof); 1710 adjust_weight (this, op->total_weight ());
1671 SET_FLAG (op, FLAG_REMOVED); 1711
1672 op->destroy (); /* free the inserted object */ 1712 op->destroy ();
1673 op = tmp; 1713 op = tmp;
1674 op->remove (); /* and fix old object's links */ 1714 goto inserted;
1675 CLEAR_FLAG (op, FLAG_REMOVED);
1676 break;
1677 } 1715 }
1678 1716
1679 /* I assume combined objects have no inventory
1680 * We add the weight - this object could have just been removed
1681 * (if it was possible to merge). calling remove_ob will subtract
1682 * the weight, so we need to add it in again, since we actually do
1683 * the linking below
1684 */
1685 add_weight (this, op->weight * op->nrof);
1686 }
1687 else
1688 add_weight (this, (op->weight + op->carrying));
1689
1690 if (object *otmp = this->in_player ())
1691 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1692 otmp->update_stats ();
1693
1694 op->owner = 0; // its his/hers now. period. 1717 op->owner = 0; // it's his/hers now. period.
1695 op->map = 0; 1718 op->map = 0;
1719 op->x = 0;
1720 op->y = 0;
1721
1722 op->above = 0;
1723 op->below = inv;
1696 op->env = this; 1724 op->env = this;
1697 op->above = 0;
1698 op->below = 0;
1699 op->x = op->y = 0;
1700 1725
1726 if (inv)
1727 inv->above = op;
1728
1729 inv = op;
1730
1731 op->flag [FLAG_REMOVED] = 0;
1732
1733 if (object *pl = op->visible_to ())
1734 esrv_send_item (pl, op);
1735
1736 adjust_weight (this, op->total_weight ());
1737
1738inserted:
1701 /* reset the light list and los of the players on the map */ 1739 /* reset the light list and los of the players on the map */
1702 if (op->glow_radius && map) 1740 if (op->glow_radius && is_on_map ())
1703 { 1741 {
1704#ifdef DEBUG_LIGHTS 1742 update_stats ();
1705 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1706#endif /* DEBUG_LIGHTS */
1707 if (map->darkness)
1708 update_all_los (map, x, y); 1743 update_all_los (map, x, y);
1709 }
1710
1711 /* Client has no idea of ordering so lets not bother ordering it here.
1712 * It sure simplifies this function...
1713 */
1714 if (!inv)
1715 inv = op;
1716 else
1717 { 1744 }
1718 op->below = inv; 1745 else if (is_player ())
1719 op->below->above = op; 1746 // if this is a player's inventory, update stats
1720 inv = op; 1747 contr->queue_stats_update ();
1721 }
1722 1748
1723 INVOKE_OBJECT (INSERT, this); 1749 INVOKE_OBJECT (INSERT, this);
1724 1750
1725 return op; 1751 return op;
1726} 1752}
1746 * on top. 1772 * on top.
1747 */ 1773 */
1748int 1774int
1749check_move_on (object *op, object *originator) 1775check_move_on (object *op, object *originator)
1750{ 1776{
1777 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1778 return 0;
1779
1751 object *tmp; 1780 object *tmp;
1752 maptile *m = op->map; 1781 maptile *m = op->map;
1753 int x = op->x, y = op->y; 1782 int x = op->x, y = op->y;
1754 1783
1755 MoveType move_on, move_slow, move_block; 1784 mapspace &ms = m->at (x, y);
1756 1785
1757 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1786 ms.update ();
1758 return 0;
1759 1787
1760 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1788 MoveType move_on = ms.move_on;
1761 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1789 MoveType move_slow = ms.move_slow;
1762 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1790 MoveType move_block = ms.move_block;
1763 1791
1764 /* if nothing on this space will slow op down or be applied, 1792 /* if nothing on this space will slow op down or be applied,
1765 * no need to do checking below. have to make sure move_type 1793 * no need to do checking below. have to make sure move_type
1766 * is set, as lots of objects don't have it set - we treat that 1794 * is set, as lots of objects don't have it set - we treat that
1767 * as walking. 1795 * as walking.
1778 return 0; 1806 return 0;
1779 1807
1780 /* The objects have to be checked from top to bottom. 1808 /* The objects have to be checked from top to bottom.
1781 * Hence, we first go to the top: 1809 * Hence, we first go to the top:
1782 */ 1810 */
1783 1811 for (object *next, *tmp = ms.top; tmp; tmp = next)
1784 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1785 {
1786 /* Trim the search when we find the first other spell effect
1787 * this helps performance so that if a space has 50 spell objects,
1788 * we don't need to check all of them.
1789 */
1790 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1791 break;
1792 } 1812 {
1813 next = tmp->below;
1793 1814
1794 for (; tmp; tmp = tmp->below)
1795 {
1796 if (tmp == op) 1815 if (tmp == op)
1797 continue; /* Can't apply yourself */ 1816 continue; /* Can't apply yourself */
1798 1817
1799 /* Check to see if one of the movement types should be slowed down. 1818 /* Check to see if one of the movement types should be slowed down.
1800 * Second check makes sure that the movement types not being slowed 1819 * Second check makes sure that the movement types not being slowed
1805 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1824 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1806 { 1825 {
1807 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1826 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1808 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1827 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1809 { 1828 {
1810
1811 float
1812 diff = tmp->move_slow_penalty * fabs (op->speed); 1829 float diff = tmp->move_slow_penalty * fabs (op->speed);
1813 1830
1814 if (op->type == PLAYER) 1831 if (op->is_player ())
1815 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1832 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1816 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1833 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1817 diff /= 4.0; 1834 diff /= 4.0;
1818 1835
1819 op->speed_left -= diff; 1836 op->speed_left -= diff;
1820 } 1837 }
1821 } 1838 }
1854 LOG (llevError, "Present_arch called outside map.\n"); 1871 LOG (llevError, "Present_arch called outside map.\n");
1855 return NULL; 1872 return NULL;
1856 } 1873 }
1857 1874
1858 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1875 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1859 if (tmp->arch == at) 1876 if (tmp->arch->archname == at->archname)
1860 return tmp; 1877 return tmp;
1861 1878
1862 return NULL; 1879 return NULL;
1863} 1880}
1864 1881
1928 * The first matching object is returned, or NULL if none. 1945 * The first matching object is returned, or NULL if none.
1929 */ 1946 */
1930object * 1947object *
1931present_arch_in_ob (const archetype *at, const object *op) 1948present_arch_in_ob (const archetype *at, const object *op)
1932{ 1949{
1933 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1950 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1934 if (tmp->arch == at) 1951 if (tmp->arch->archname == at->archname)
1935 return tmp; 1952 return tmp;
1936 1953
1937 return NULL; 1954 return NULL;
1938} 1955}
1939 1956
2027 * head of the object should correspond for the entire object. 2044 * head of the object should correspond for the entire object.
2028 */ 2045 */
2029 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2046 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2030 continue; 2047 continue;
2031 2048
2032 if (ob->blocked (m, pos.x, pos.y)) 2049 if (ob->blocked (pos.m, pos.x, pos.y))
2033 continue; 2050 continue;
2034 2051
2035 altern [index++] = i; 2052 altern [index++] = i;
2036 } 2053 }
2037 2054
2105 * there is capable of. 2122 * there is capable of.
2106 */ 2123 */
2107int 2124int
2108find_dir (maptile *m, int x, int y, object *exclude) 2125find_dir (maptile *m, int x, int y, object *exclude)
2109{ 2126{
2110 int i, max = SIZEOFFREE, mflags; 2127 int max = SIZEOFFREE, mflags;
2111
2112 sint16 nx, ny;
2113 object *tmp;
2114 maptile *mp;
2115
2116 MoveType blocked, move_type; 2128 MoveType move_type;
2117 2129
2118 if (exclude && exclude->head_ () != exclude) 2130 if (exclude && exclude->head_ () != exclude)
2119 { 2131 {
2120 exclude = exclude->head; 2132 exclude = exclude->head;
2121 move_type = exclude->move_type; 2133 move_type = exclude->move_type;
2124 { 2136 {
2125 /* If we don't have anything, presume it can use all movement types. */ 2137 /* If we don't have anything, presume it can use all movement types. */
2126 move_type = MOVE_ALL; 2138 move_type = MOVE_ALL;
2127 } 2139 }
2128 2140
2129 for (i = 1; i < max; i++) 2141 for (int i = 1; i < max; i++)
2130 { 2142 {
2131 mp = m; 2143 mapxy pos (m, x, y);
2132 nx = x + freearr_x[i]; 2144 pos.move (i);
2133 ny = y + freearr_y[i];
2134 2145
2135 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2146 if (!pos.normalise ())
2136
2137 if (mflags & P_OUT_OF_MAP)
2138 max = maxfree[i]; 2147 max = maxfree[i];
2139 else 2148 else
2140 { 2149 {
2141 mapspace &ms = mp->at (nx, ny); 2150 mapspace &ms = *pos;
2142 2151
2143 blocked = ms.move_block;
2144
2145 if ((move_type & blocked) == move_type) 2152 if ((move_type & ms.move_block) == move_type)
2146 max = maxfree[i]; 2153 max = maxfree [i];
2147 else if (mflags & P_IS_ALIVE) 2154 else if (ms.flags () & P_IS_ALIVE)
2148 { 2155 {
2149 for (tmp = ms.bot; tmp; tmp = tmp->above) 2156 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2150 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2157 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2151 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2158 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2152 break;
2153
2154 if (tmp)
2155 return freedir[i]; 2159 return freedir [i];
2156 } 2160 }
2157 } 2161 }
2158 } 2162 }
2159 2163
2160 return 0; 2164 return 0;
2235 * This basically means that if direction is 15, then it could either go 2239 * This basically means that if direction is 15, then it could either go
2236 * direction 4, 14, or 16 to get back to where we are. 2240 * direction 4, 14, or 16 to get back to where we are.
2237 * Moved from spell_util.c to object.c with the other related direction 2241 * Moved from spell_util.c to object.c with the other related direction
2238 * functions. 2242 * functions.
2239 */ 2243 */
2240int reduction_dir[SIZEOFFREE][3] = { 2244static const int reduction_dir[SIZEOFFREE][3] = {
2241 {0, 0, 0}, /* 0 */ 2245 {0, 0, 0}, /* 0 */
2242 {0, 0, 0}, /* 1 */ 2246 {0, 0, 0}, /* 1 */
2243 {0, 0, 0}, /* 2 */ 2247 {0, 0, 0}, /* 2 */
2244 {0, 0, 0}, /* 3 */ 2248 {0, 0, 0}, /* 3 */
2245 {0, 0, 0}, /* 4 */ 2249 {0, 0, 0}, /* 4 */
2341int 2345int
2342can_pick (const object *who, const object *item) 2346can_pick (const object *who, const object *item)
2343{ 2347{
2344 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2348 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2345 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2349 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2346 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2350 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2347} 2351}
2348 2352
2349/* 2353/*
2350 * create clone from object to another 2354 * create clone from object to another
2351 */ 2355 */
2352object * 2356object *
2353object_create_clone (object *asrc) 2357object::deep_clone ()
2354{ 2358{
2355 object *dst = 0, *tmp, *src, *prev, *item; 2359 assert (("deep_clone called on non-head object", is_head ()));
2356 2360
2357 if (!asrc) 2361 object *dst = clone ();
2358 return 0;
2359 2362
2360 src = asrc->head_ (); 2363 object *prev = dst;
2361
2362 prev = 0;
2363 for (object *part = src; part; part = part->more) 2364 for (object *part = this->more; part; part = part->more)
2364 { 2365 {
2365 tmp = part->clone (); 2366 object *tmp = part->clone ();
2366 tmp->x -= src->x;
2367 tmp->y -= src->y;
2368
2369 if (!part->head)
2370 {
2371 dst = tmp;
2372 tmp->head = 0;
2373 }
2374 else
2375 tmp->head = dst; 2367 tmp->head = dst;
2376
2377 tmp->more = 0;
2378
2379 if (prev)
2380 prev->more = tmp; 2368 prev->more = tmp;
2381
2382 prev = tmp; 2369 prev = tmp;
2383 } 2370 }
2384 2371
2385 for (item = src->inv; item; item = item->below) 2372 for (object *item = inv; item; item = item->below)
2386 insert_ob_in_ob (object_create_clone (item), dst); 2373 insert_ob_in_ob (item->deep_clone (), dst);
2387 2374
2388 return dst; 2375 return dst;
2389} 2376}
2390 2377
2391/* This returns the first object in who's inventory that 2378/* This returns the first object in who's inventory that
2400 return tmp; 2387 return tmp;
2401 2388
2402 return 0; 2389 return 0;
2403} 2390}
2404 2391
2405/* If ob has a field named key, return the link from the list, 2392shstr_tmp
2406 * otherwise return NULL. 2393object::kv_get (shstr_tmp key) const
2407 *
2408 * key must be a passed in shared string - otherwise, this won't
2409 * do the desired thing.
2410 */
2411key_value *
2412get_ob_key_link (const object *ob, const char *key)
2413{ 2394{
2414 for (key_value *link = ob->key_values; link; link = link->next) 2395 for (key_value *kv = key_values; kv; kv = kv->next)
2415 if (link->key == key) 2396 if (kv->key == key)
2416 return link;
2417
2418 return 0;
2419}
2420
2421/*
2422 * Returns the value of op has an extra_field for key, or NULL.
2423 *
2424 * The argument doesn't need to be a shared string.
2425 *
2426 * The returned string is shared.
2427 */
2428const char *
2429get_ob_key_value (const object *op, const char *const key)
2430{
2431 key_value *link;
2432 shstr_cmp canonical_key (key);
2433
2434 if (!canonical_key)
2435 {
2436 /* 1. There being a field named key on any object
2437 * implies there'd be a shared string to find.
2438 * 2. Since there isn't, no object has this field.
2439 * 3. Therefore, *this* object doesn't have this field.
2440 */
2441 return 0;
2442 }
2443
2444 /* This is copied from get_ob_key_link() above -
2445 * only 4 lines, and saves the function call overhead.
2446 */
2447 for (link = op->key_values; link; link = link->next)
2448 if (link->key == canonical_key)
2449 return link->value; 2397 return kv->value;
2450 2398
2451 return 0; 2399 return shstr ();
2452} 2400}
2453 2401
2454/* 2402void
2455 * Updates the canonical_key in op to value. 2403object::kv_set (shstr_tmp key, shstr_tmp value)
2456 *
2457 * canonical_key is a shared string (value doesn't have to be).
2458 *
2459 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2460 * keys.
2461 *
2462 * Returns TRUE on success.
2463 */
2464int
2465set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2466{ 2404{
2467 key_value *field = NULL, *last = NULL; 2405 for (key_value *kv = key_values; kv; kv = kv->next)
2468 2406 if (kv->key == key)
2469 for (field = op->key_values; field != NULL; field = field->next)
2470 {
2471 if (field->key != canonical_key)
2472 { 2407 {
2473 last = field; 2408 kv->value = value;
2474 continue; 2409 return;
2475 } 2410 }
2476 2411
2477 if (value) 2412 key_value *kv = new key_value;
2478 field->value = value; 2413
2479 else 2414 kv->next = key_values;
2415 kv->key = key;
2416 kv->value = value;
2417
2418 key_values = kv;
2419}
2420
2421void
2422object::kv_del (shstr_tmp key)
2423{
2424 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2425 if ((*kvp)->key == key)
2480 { 2426 {
2481 /* Basically, if the archetype has this key set, 2427 key_value *kv = *kvp;
2482 * we need to store the null value so when we save 2428 *kvp = (*kvp)->next;
2483 * it, we save the empty value so that when we load, 2429 delete kv;
2484 * we get this value back again. 2430 return;
2485 */
2486 if (get_ob_key_link (op->arch, canonical_key))
2487 field->value = 0;
2488 else
2489 {
2490 if (last)
2491 last->next = field->next;
2492 else
2493 op->key_values = field->next;
2494
2495 delete field;
2496 }
2497 } 2431 }
2498 return TRUE;
2499 }
2500 /* IF we get here, key doesn't exist */
2501
2502 /* No field, we'll have to add it. */
2503
2504 if (!add_key)
2505 return FALSE;
2506
2507 /* There isn't any good reason to store a null
2508 * value in the key/value list. If the archetype has
2509 * this key, then we should also have it, so shouldn't
2510 * be here. If user wants to store empty strings,
2511 * should pass in ""
2512 */
2513 if (value == NULL)
2514 return TRUE;
2515
2516 field = new key_value;
2517
2518 field->key = canonical_key;
2519 field->value = value;
2520 /* Usual prepend-addition. */
2521 field->next = op->key_values;
2522 op->key_values = field;
2523
2524 return TRUE;
2525}
2526
2527/*
2528 * Updates the key in op to value.
2529 *
2530 * If add_key is FALSE, this will only update existing keys,
2531 * and not add new ones.
2532 * In general, should be little reason FALSE is ever passed in for add_key
2533 *
2534 * Returns TRUE on success.
2535 */
2536int
2537set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2538{
2539 shstr key_ (key);
2540
2541 return set_ob_key_value_s (op, key_, value, add_key);
2542} 2432}
2543 2433
2544object::depth_iterator::depth_iterator (object *container) 2434object::depth_iterator::depth_iterator (object *container)
2545: iterator_base (container) 2435: iterator_base (container)
2546{ 2436{
2596{ 2486{
2597 char flagdesc[512]; 2487 char flagdesc[512];
2598 char info2[256 * 4]; 2488 char info2[256 * 4];
2599 char *p = info; 2489 char *p = info;
2600 2490
2601 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2491 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2602 count, 2492 count,
2603 uuid.c_str (), 2493 uuid.c_str (),
2604 &name, 2494 &name,
2605 title ? "\",title:\"" : "", 2495 title ? ",title:\"" : "",
2606 title ? (const char *)title : "", 2496 title ? (const char *)title : "",
2497 title ? "\"" : "",
2607 flag_desc (flagdesc, 512), type); 2498 flag_desc (flagdesc, 512), type);
2608 2499
2609 if (!this->flag[FLAG_REMOVED] && env) 2500 if (!flag[FLAG_REMOVED] && env)
2610 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2501 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2611 2502
2612 if (map) 2503 if (map)
2613 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2504 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2614 2505
2629{ 2520{
2630 return map ? map->region (x, y) 2521 return map ? map->region (x, y)
2631 : region::default_region (); 2522 : region::default_region ();
2632} 2523}
2633 2524
2634const materialtype_t *
2635object::dominant_material () const
2636{
2637 if (materialtype_t *mt = name_to_material (materialname))
2638 return mt;
2639
2640 return name_to_material (shstr_unknown);
2641}
2642
2643void 2525void
2644object::open_container (object *new_container) 2526object::open_container (object *new_container)
2645{ 2527{
2646 if (container == new_container) 2528 if (container == new_container)
2647 return; 2529 return;
2648 2530
2649 if (object *old_container = container) 2531 object *old_container = container;
2532
2533 if (old_container)
2650 { 2534 {
2651 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2535 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2652 return; 2536 return;
2653 2537
2654#if 0 2538#if 0
2656 if (object *closer = old_container->inv) 2540 if (object *closer = old_container->inv)
2657 if (closer->type == CLOSE_CON) 2541 if (closer->type == CLOSE_CON)
2658 closer->destroy (); 2542 closer->destroy ();
2659#endif 2543#endif
2660 2544
2545 // make sure the container is available
2546 esrv_send_item (this, old_container);
2547
2661 old_container->flag [FLAG_APPLIED] = 0; 2548 old_container->flag [FLAG_APPLIED] = false;
2662 container = 0; 2549 container = 0;
2663 2550
2551 // client needs item update to make it work, client bug requires this to be separate
2664 esrv_update_item (UPD_FLAGS, this, old_container); 2552 esrv_update_item (UPD_FLAGS, this, old_container);
2553
2665 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2554 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2666 play_sound (sound_find ("chest_close")); 2555 play_sound (sound_find ("chest_close"));
2667 } 2556 }
2668 2557
2669 if (new_container) 2558 if (new_container)
2670 { 2559 {
2680 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2569 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2681 new_container->insert (closer); 2570 new_container->insert (closer);
2682 } 2571 }
2683#endif 2572#endif
2684 2573
2685 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2574 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2686 2575
2576 // make sure the container is available, client bug requires this to be separate
2577 esrv_send_item (this, new_container);
2578
2687 new_container->flag [FLAG_APPLIED] = 1; 2579 new_container->flag [FLAG_APPLIED] = true;
2688 container = new_container; 2580 container = new_container;
2689 2581
2582 // client needs flag change
2690 esrv_update_item (UPD_FLAGS, this, new_container); 2583 esrv_update_item (UPD_FLAGS, this, new_container);
2691 esrv_send_inventory (this, new_container); 2584 esrv_send_inventory (this, new_container);
2692 play_sound (sound_find ("chest_open")); 2585 play_sound (sound_find ("chest_open"));
2693 } 2586 }
2587// else if (!old_container->env && contr && contr->ns)
2588// contr->ns->floorbox_reset ();
2694} 2589}
2695 2590
2696object * 2591object *
2697object::force_find (const shstr name) 2592object::force_find (shstr_tmp name)
2698{ 2593{
2699 /* cycle through his inventory to look for the MARK we want to 2594 /* cycle through his inventory to look for the MARK we want to
2700 * place 2595 * place
2701 */ 2596 */
2702 for (object *tmp = inv; tmp; tmp = tmp->below) 2597 for (object *tmp = inv; tmp; tmp = tmp->below)
2704 return splay (tmp); 2599 return splay (tmp);
2705 2600
2706 return 0; 2601 return 0;
2707} 2602}
2708 2603
2604//-GPL
2605
2709void 2606void
2607object::force_set_timer (int duration)
2608{
2609 this->duration = 1;
2610 this->speed_left = -1.f;
2611
2612 this->set_speed (duration ? 1.f / duration : 0.f);
2613}
2614
2615object *
2710object::force_add (const shstr name, int duration) 2616object::force_add (shstr_tmp name, int duration)
2711{ 2617{
2712 if (object *force = force_find (name)) 2618 if (object *force = force_find (name))
2713 force->destroy (); 2619 force->destroy ();
2714 2620
2715 object *force = get_archetype (FORCE_NAME); 2621 object *force = get_archetype (FORCE_NAME);
2716 2622
2717 force->slaying = name; 2623 force->slaying = name;
2718 force->stats.food = 1; 2624 force->force_set_timer (duration);
2719 force->speed_left = -1.f;
2720
2721 force->set_speed (duration ? 1.f / duration : 0.f);
2722 force->flag [FLAG_IS_USED_UP] = true;
2723 force->flag [FLAG_APPLIED] = true; 2625 force->flag [FLAG_APPLIED] = true;
2724 2626
2725 insert (force); 2627 return insert (force);
2726} 2628}
2727 2629
2728void 2630void
2729object::play_sound (faceidx sound) const 2631object::play_sound (faceidx sound) const
2730{ 2632{
2731 if (!sound) 2633 if (!sound)
2732 return; 2634 return;
2733 2635
2734 if (flag [FLAG_REMOVED]) 2636 if (is_on_map ())
2637 map->play_sound (sound, x, y);
2638 else if (object *pl = in_player ())
2639 pl->contr->play_sound (sound);
2640}
2641
2642void
2643object::say_msg (const char *msg) const
2644{
2645 if (is_on_map ())
2646 map->say_msg (msg, x, y);
2647 else if (object *pl = in_player ())
2648 pl->contr->play_sound (sound);
2649}
2650
2651void
2652object::make_noise ()
2653{
2654 // we do not model noise in the map, so instead put
2655 // a temporary light into the noise source
2656 // could use the map instead, but that's less reliable for our
2657 // goal, which is to make invisibility a bit harder to exploit
2658
2659 // currently only works sensibly for players
2660 if (!is_player ())
2735 return; 2661 return;
2736 2662
2737 if (env) 2663 // find old force, or create new one
2738 { 2664 object *force = force_find (shstr_noise_force);
2739 if (object *pl = in_player ()) 2665
2740 pl->contr->play_sound (sound); 2666 if (force)
2741 } 2667 force->speed_left = -1.f; // patch old speed up
2742 else 2668 else
2743 map->play_sound (sound, x, y); 2669 {
2744} 2670 force = archetype::get (shstr_noise_force);
2745 2671
2672 force->slaying = shstr_noise_force;
2673 force->stats.food = 1;
2674 force->speed_left = -1.f;
2675
2676 force->set_speed (1.f / 4.f);
2677 force->flag [FLAG_IS_USED_UP] = true;
2678 force->flag [FLAG_APPLIED] = true;
2679
2680 insert (force);
2681 }
2682}
2683

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines