ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.309 by root, Sun Nov 29 17:41:07 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 52 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 56};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
60 0, 58 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 62};
65 63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
69};
70
66static void 71static void
67write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
68{ 73{
69 CALL_BEGIN (2); 74 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 75 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 77 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 78 CALL_END;
74} 79}
75 80
76static void 81static void
77read_uuid (void) 82read_uuid ()
78{ 83{
79 char filename[MAX_BUF]; 84 char filename[MAX_BUF];
80 85
81 sprintf (filename, "%s/uuid", settings.localdir); 86 sprintf (filename, "%s/uuid", settings.localdir);
82 87
96 101
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 102 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 103 _exit (1);
99 } 104 }
100 105
101 UUID::BUF buf; 106 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 107 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 108 fgets (buf, sizeof (buf), fp);
104 109
105 if (!UUID::cur.parse (buf)) 110 if (!UUID::cur.parse (buf))
106 { 111 {
133 138
134void 139void
135UUID::init () 140UUID::init ()
136{ 141{
137 read_uuid (); 142 read_uuid ();
143}
144
145bool
146UUID::parse (const char *s)
147{
148 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
149 return false;
150
151 seq = 0;
152
153 while (*s != '>')
154 {
155 if (*s < '0')
156 return false;
157
158 // this gives nice branchless code with gcc
159 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
160 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
161
162 seq = (seq << 4) | digit;
163
164 ++s;
165 }
166
167 return true;
168}
169
170char *
171UUID::append (char *buf) const
172{
173 *buf++ = '<';
174 *buf++ = '1';
175 *buf++ = '.';
176
177 uint64_t seq = this->seq;
178 const int bits = 64;
179 char nz = 0;
180 static const char tohex [] = "0123456789abcdef";
181
182 // assert (len >= 3 + bits / 4 + 1 + 1);
183 for (int i = bits / 4; --i; )
184 {
185 uint8_t digit = seq >> (bits - 4);
186
187 *buf = tohex [digit];
188 nz |= digit;
189 buf += nz ? 1 : 0;
190 seq <<= 4;
191 }
192
193 // last digit is special - always emit
194 uint8_t digit = seq >> (bits - 4);
195 *buf++ = tohex [digit];
196
197 *buf++ = '>';
198
199 return buf;
200}
201
202char *
203UUID::c_str () const
204{
205 static char buf [MAX_LEN];
206 *append (buf) = 0;
207 return buf;
138} 208}
139 209
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 210/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 211static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 212compare_ob_value_lists_one (const object *wants, const object *has)
143{ 213{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 214 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 215 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 216 * different structure or at least keep the lists sorted...
149 */ 217 */
150 218
151 /* For each field in wants, */ 219 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 220 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 221 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 222 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 223
169 /* If we get here, every field in wants has a matching field in has. */ 224 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 225 return true;
171} 226}
172 227
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 228/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 229static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 230compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 231{
177 /* However, there may be fields in has which aren't partnered in wants, 232 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 233 * so we need to run the comparison *twice*. :(
179 */ 234 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 235 return compare_ob_value_lists_one (ob1, ob2)
236 && compare_ob_value_lists_one (ob2, ob1);
181} 237}
182 238
183/* Function examines the 2 objects given to it, and returns true if 239/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 240 * they can be merged together.
185 * 241 *
195bool object::can_merge_slow (object *ob1, object *ob2) 251bool object::can_merge_slow (object *ob1, object *ob2)
196{ 252{
197 /* A couple quicksanity checks */ 253 /* A couple quicksanity checks */
198 if (ob1 == ob2 254 if (ob1 == ob2
199 || ob1->type != ob2->type 255 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed 256 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED
201 || ob1->value != ob2->value 257 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 258 || ob1->name != ob2->name)
203 return 0; 259 return 0;
204 260
205 /* Do not merge objects if nrof would overflow. First part checks 261 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 262 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 263 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 264 return 0;
212 265
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 266 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 267 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 268 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 273 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 274
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 275 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 276 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 277
225 if (ob1->arch->name != ob2->arch->name 278 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 279 || ob1->name != ob2->name
227 || ob1->title != ob2->title 280 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 281 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 282 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 283 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 284 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 285 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 286 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 287 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 288 || ob1->animation_id != ob2->animation_id
289 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 290 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 291 || ob1->material != ob2->material
238 || ob1->lore != ob2->lore 292 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 293 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 294 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 295 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 296 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 297 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 298 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 299 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 300 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 301 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 302 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 303 return 0;
250 304
251 if ((ob1->flag ^ ob2->flag) 305 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 306 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 307 .reset (FLAG_REMOVED)
255 .any ()) 308 .any ())
256 return 0; 309 return 0;
257 310
258 /* This is really a spellbook check - we should in general 311 /* This is really a spellbook check - we should in general
340 { 393 {
341 // see if we are in a container of sorts 394 // see if we are in a container of sorts
342 if (env) 395 if (env)
343 { 396 {
344 // the player inventory itself is always visible 397 // the player inventory itself is always visible
345 if (env->type == PLAYER) 398 if (env->is_player ())
346 return env; 399 return env;
347 400
348 // else a player could have our env open 401 // else a player could have our env open
349 object *envest = env->outer_env (); 402 object *envest = env->outer_env_or_self ();
350 403
351 // the player itself is always on a map, so we will find him here 404 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 405 // even if our inv is in a player.
353 if (envest->is_on_map ()) 406 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 407 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 408 if (pl->container_ () == env)
356 return pl; 409 return pl;
357 } 410 }
358 else 411 else
359 { 412 {
360 // maybe there is a player standing on the same mapspace 413 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 414 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 415 if (object *pl = ms ().player ())
363 if (!pl->container || this == pl->container) 416 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
417 || pl->container_ () == this)
364 return pl; 418 return pl;
365 } 419 }
366 } 420 }
367 421
368 return 0; 422 return 0;
369} 423}
370 424
371// adjust weight per container type ("of holding") 425// adjust weight per container type ("of holding")
372static sint32 426static sint32
373weight_adjust (object *op, sint32 weight) 427weight_adjust_for (object *op, sint32 weight)
374{ 428{
375 return op->type == CONTAINER 429 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 430 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 431 : weight;
378} 432}
384static void 438static void
385adjust_weight (object *op, sint32 weight) 439adjust_weight (object *op, sint32 weight)
386{ 440{
387 while (op) 441 while (op)
388 { 442 {
443 // adjust by actual difference to account for rounding errors
444 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 445 weight = weight_adjust_for (op, op->carrying)
446 - weight_adjust_for (op, op->carrying - weight);
390 447
391 if (!weight) 448 if (!weight)
392 return; 449 return;
393 450
394 op->carrying += weight; 451 op->carrying += weight;
417 op->update_weight (); 474 op->update_weight ();
418 475
419 sum += op->total_weight (); 476 sum += op->total_weight ();
420 } 477 }
421 478
422 sum = weight_adjust (this, sum); 479 sum = weight_adjust_for (this, sum);
423 480
424 if (sum != carrying) 481 if (sum != carrying)
425 { 482 {
426 carrying = sum; 483 carrying = sum;
427 484
443 object_freezer freezer; 500 object_freezer freezer;
444 op->write (freezer); 501 op->write (freezer);
445 return freezer.as_string (); 502 return freezer.as_string ();
446} 503}
447 504
448/* 505char *
449 * get_nearest_part(multi-object, object 2) returns the part of the 506object::as_string ()
450 * multi-object 1 which is closest to the second object.
451 * If it's not a multi-object, it is returned.
452 */
453object *
454get_nearest_part (object *op, const object *pl)
455{ 507{
456 object *tmp, *closest; 508 return dump_object (this);
457 int last_dist, i;
458
459 if (!op->more)
460 return op;
461
462 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
463 tmp;
464 tmp = tmp->more)
465 if ((i = distance (tmp, pl)) < last_dist)
466 closest = tmp, last_dist = i;
467
468 return closest;
469} 509}
470 510
471/* 511/*
472 * Returns the object which has the count-variable equal to the argument. 512 * Returns the object which has the count-variable equal to the argument.
473 * VERRRY slow. 513 * VERRRY slow.
489 */ 529 */
490object * 530object *
491find_object_name (const char *str) 531find_object_name (const char *str)
492{ 532{
493 shstr_cmp str_ (str); 533 shstr_cmp str_ (str);
494 object *op;
495 534
535 if (str_)
496 for_all_objects (op) 536 for_all_objects (op)
497 if (op->name == str_) 537 if (op->name == str_)
498 break; 538 return op;
499 539
500 return op; 540 return 0;
501} 541}
502 542
503/* 543/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 544 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 545 * skill and experience objects.
567 update_stats (); 607 update_stats ();
568 608
569 new_draw_info_format (NDI_UNIQUE, 0, this, 609 new_draw_info_format (NDI_UNIQUE, 0, this,
570 "You try to balance all your items at once, " 610 "You try to balance all your items at once, "
571 "but the %s is just too much for your body. " 611 "but the %s is just too much for your body. "
572 "[You need to unapply some items first.]", &ob->name); 612 "[You need to unapply some items first - use the 'body' command to see "
613 "how many items you cna wera on a specific body part.]", &ob->name);
573 return false; 614 return false;
574 } 615 }
575 616
576 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 617 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577 } 618 }
603 } 644 }
604 645
605 op->key_values = 0; 646 op->key_values = 0;
606} 647}
607 648
608object & 649/*
609object::operator =(const object &src) 650 * copy_to first frees everything allocated by the dst object,
651 * and then copies the contents of itself into the second
652 * object, allocating what needs to be allocated. Basically, any
653 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
654 * if the first object is freed, the pointers in the new object
655 * will point at garbage.
656 */
657void
658object::copy_to (object *dst)
610{ 659{
611 bool is_freed = flag [FLAG_FREED]; 660 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 661 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 662 dst->flag [FLAG_REMOVED] = true;
618 663
619 /* Copy over key_values, if any. */ 664 /* Copy over key_values, if any. */
620 if (src.key_values) 665 if (key_values)
621 { 666 {
622 key_value *tail = 0; 667 key_value *tail = 0;
623 key_values = 0; 668 dst->key_values = 0;
624 669
625 for (key_value *i = src.key_values; i; i = i->next) 670 for (key_value *i = key_values; i; i = i->next)
626 { 671 {
627 key_value *new_link = new key_value; 672 key_value *new_link = new key_value;
628 673
629 new_link->next = 0; 674 new_link->next = 0;
630 new_link->key = i->key; 675 new_link->key = i->key;
631 new_link->value = i->value; 676 new_link->value = i->value;
632 677
633 /* Try and be clever here, too. */ 678 /* Try and be clever here, too. */
634 if (!key_values) 679 if (!dst->key_values)
635 { 680 {
636 key_values = new_link; 681 dst->key_values = new_link;
637 tail = new_link; 682 tail = new_link;
638 } 683 }
639 else 684 else
640 { 685 {
641 tail->next = new_link; 686 tail->next = new_link;
642 tail = new_link; 687 tail = new_link;
643 } 688 }
644 } 689 }
645 } 690 }
646}
647 691
648/* 692 dst->activate ();
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660
661 if (speed < 0)
662 dst->speed_left -= rndm ();
663
664 dst->set_speed (dst->speed);
665} 693}
666 694
667void 695void
668object::instantiate () 696object::instantiate ()
669{ 697{
670 if (!uuid.seq) // HACK 698 if (!uuid.seq) // HACK
671 uuid = UUID::gen (); 699 uuid = UUID::gen ();
672 700
701 // TODO: unclean state changes, should nt be done in copy_to AND instantiate
702 if (flag [FLAG_RANDOM_SPEED] && speed)
703 speed_left = - speed - rndm (); // TODO animation
704 else
673 speed_left = -0.1f; 705 speed_left = -1.;
706
674 /* copy the body_info to the body_used - this is only really 707 /* copy the body_info to the body_used - this is only really
675 * need for monsters, but doesn't hurt to do it for everything. 708 * need for monsters, but doesn't hurt to do it for everything.
676 * by doing so, when a monster is created, it has good starting 709 * by doing so, when a monster is created, it has good starting
677 * values for the body_used info, so when items are created 710 * values for the body_used info, so when items are created
678 * for it, they can be properly equipped. 711 * for it, they can be properly equipped.
686object * 719object *
687object::clone () 720object::clone ()
688{ 721{
689 object *neu = create (); 722 object *neu = create ();
690 copy_to (neu); 723 copy_to (neu);
724
725 // TODO: unclean state changes, should not be done in clone AND instantiate
726 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
727 neu->speed_left = - neu->speed - rndm (); // TODO animation
728
729 neu->map = map; // not copied by copy_to
691 return neu; 730 return neu;
692} 731}
693 732
694/* 733/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 734 * If an object with the IS_TURNABLE() flag needs to be turned due
712 * This function needs to be called whenever the speed of an object changes. 751 * This function needs to be called whenever the speed of an object changes.
713 */ 752 */
714void 753void
715object::set_speed (float speed) 754object::set_speed (float speed)
716{ 755{
717 if (flag [FLAG_FREED] && speed)
718 {
719 LOG (llevError, "Object %s is freed but has speed.\n", &name);
720 speed = 0;
721 }
722
723 this->speed = speed; 756 this->speed = speed;
724 757
725 if (has_active_speed ()) 758 if (has_active_speed ())
726 activate (); 759 activate ();
727 else 760 else
746 * UP_OBJ_FACE: only the objects face has changed. 779 * UP_OBJ_FACE: only the objects face has changed.
747 */ 780 */
748void 781void
749update_object (object *op, int action) 782update_object (object *op, int action)
750{ 783{
751 if (op == NULL) 784 if (!op)
752 { 785 {
753 /* this should never happen */ 786 /* this should never happen */
754 LOG (llevDebug, "update_object() called for NULL object.\n"); 787 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
755 return; 788 return;
756 } 789 }
757 790
758 if (op->env) 791 if (!op->is_on_map ())
759 { 792 {
760 /* Animation is currently handled by client, so nothing 793 /* Animation is currently handled by client, so nothing
761 * to do in this case. 794 * to do in this case.
762 */ 795 */
763 return; 796 return;
764 } 797 }
765
766 /* If the map is saving, don't do anything as everything is
767 * going to get freed anyways.
768 */
769 if (!op->map || op->map->in_memory == MAP_SAVING)
770 return;
771 798
772 /* make sure the object is within map boundaries */ 799 /* make sure the object is within map boundaries */
773 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 800 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
774 { 801 {
775 LOG (llevError, "update_object() called for object out of map!\n"); 802 LOG (llevError, "update_object() called for object out of map!\n");
783 810
784 if (!(m.flags_ & P_UPTODATE)) 811 if (!(m.flags_ & P_UPTODATE))
785 /* nop */; 812 /* nop */;
786 else if (action == UP_OBJ_INSERT) 813 else if (action == UP_OBJ_INSERT)
787 { 814 {
815#if 0
788 // this is likely overkill, TODO: revisit (schmorp) 816 // this is likely overkill, TODO: revisit (schmorp)
789 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 817 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
790 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 818 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
791 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 819 || (op->is_player () && !(m.flags_ & P_PLAYER))
792 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 820 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
793 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 821 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
794 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 822 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
795 || (m.move_on | op->move_on ) != m.move_on 823 || (m.move_on | op->move_on ) != m.move_on
796 || (m.move_off | op->move_off ) != m.move_off 824 || (m.move_off | op->move_off ) != m.move_off
797 || (m.move_slow | op->move_slow) != m.move_slow 825 || (m.move_slow | op->move_slow) != m.move_slow
798 /* This isn't perfect, but I don't expect a lot of objects to 826 /* This isn't perfect, but I don't expect a lot of objects to
799 * to have move_allow right now. 827 * have move_allow right now.
800 */ 828 */
801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 829 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
830 m.invalidate ();
831#else
802 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 832 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
803 m.flags_ = 0; 833 m.invalidate ();
834#endif
804 } 835 }
805 /* if the object is being removed, we can't make intelligent 836 /* if the object is being removed, we can't make intelligent
806 * decisions, because remove_ob can't really pass the object 837 * decisions, because remove_ob can't really pass the object
807 * that is being removed. 838 * that is being removed.
808 */ 839 */
809 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 840 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
810 m.flags_ = 0; 841 m.invalidate ();
811 else if (action == UP_OBJ_FACE) 842 else if (action == UP_OBJ_FACE)
812 /* Nothing to do for that case */ ; 843 /* Nothing to do for that case */ ;
813 else 844 else
814 LOG (llevError, "update_object called with invalid action: %d\n", action); 845 LOG (llevError, "update_object called with invalid action: %d\n", action);
815 846
819 850
820object::object () 851object::object ()
821{ 852{
822 SET_FLAG (this, FLAG_REMOVED); 853 SET_FLAG (this, FLAG_REMOVED);
823 854
824 expmul = 1.0; 855 //expmul = 1.0; declared const for the time being
825 face = blank_face; 856 face = blank_face;
857 material = MATERIAL_NULL;
826} 858}
827 859
828object::~object () 860object::~object ()
829{ 861{
830 unlink (); 862 unlink ();
859 /* If already on active list, don't do anything */ 891 /* If already on active list, don't do anything */
860 if (active) 892 if (active)
861 return; 893 return;
862 894
863 if (has_active_speed ()) 895 if (has_active_speed ())
896 {
897 if (flag [FLAG_FREED])
898 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
899
864 actives.insert (this); 900 actives.insert (this);
901 }
865} 902}
866 903
867void 904void
868object::activate_recursive () 905object::activate_recursive ()
869{ 906{
930 * drop on that space. 967 * drop on that space.
931 */ 968 */
932 if (!drop_to_ground 969 if (!drop_to_ground
933 || !map 970 || !map
934 || map->in_memory != MAP_ACTIVE 971 || map->in_memory != MAP_ACTIVE
935 || map->nodrop 972 || map->no_drop
936 || ms ().move_block == MOVE_ALL) 973 || ms ().move_block == MOVE_ALL)
937 { 974 {
938 while (inv) 975 while (inv)
939 {
940 inv->destroy_inv (false);
941 inv->destroy (); 976 inv->destroy ();
942 }
943 } 977 }
944 else 978 else
945 { /* Put objects in inventory onto this space */ 979 { /* Put objects in inventory onto this space */
946 while (inv) 980 while (inv)
947 { 981 {
951 || op->flag [FLAG_NO_DROP] 985 || op->flag [FLAG_NO_DROP]
952 || op->type == RUNE 986 || op->type == RUNE
953 || op->type == TRAP 987 || op->type == TRAP
954 || op->flag [FLAG_IS_A_TEMPLATE] 988 || op->flag [FLAG_IS_A_TEMPLATE]
955 || op->flag [FLAG_DESTROY_ON_DEATH]) 989 || op->flag [FLAG_DESTROY_ON_DEATH])
956 op->destroy (true); 990 op->destroy ();
957 else 991 else
958 map->insert (op, x, y); 992 map->insert (op, x, y);
959 } 993 }
960 } 994 }
961} 995}
965 object *op = new object; 999 object *op = new object;
966 op->link (); 1000 op->link ();
967 return op; 1001 return op;
968} 1002}
969 1003
1004static struct freed_map : maptile
1005{
1006 freed_map ()
1007 {
1008 path = "<freed objects map>";
1009 name = "/internal/freed_objects_map";
1010 width = 3;
1011 height = 3;
1012 no_drop = 1;
1013 no_reset = 1;
1014
1015 alloc ();
1016 in_memory = MAP_ACTIVE;
1017 }
1018
1019 ~freed_map ()
1020 {
1021 destroy ();
1022 }
1023} freed_map; // freed objects are moved here to avoid crashes
1024
970void 1025void
971object::do_destroy () 1026object::do_destroy ()
972{ 1027{
973 if (flag [FLAG_IS_LINKED]) 1028 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 1029 remove_link ();
975 1030
976 if (flag [FLAG_FRIENDLY]) 1031 if (flag [FLAG_FRIENDLY])
977 remove_friendly_object (this); 1032 remove_friendly_object (this);
978 1033
979 remove (); 1034 remove ();
984 unlink (); 1039 unlink ();
985 1040
986 flag [FLAG_FREED] = 1; 1041 flag [FLAG_FREED] = 1;
987 1042
988 // hack to ensure that freed objects still have a valid map 1043 // hack to ensure that freed objects still have a valid map
989 {
990 static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992 if (!freed_map)
993 {
994 freed_map = new maptile;
995
996 freed_map->path = "<freed objects map>";
997 freed_map->name = "/internal/freed_objects_map";
998 freed_map->width = 3;
999 freed_map->height = 3;
1000 freed_map->nodrop = 1;
1001
1002 freed_map->alloc ();
1003 freed_map->in_memory = MAP_ACTIVE;
1004 }
1005
1006 map = freed_map; 1044 map = &freed_map;
1007 x = 1; 1045 x = 1;
1008 y = 1; 1046 y = 1;
1009 }
1010 1047
1011 if (more) 1048 if (more)
1012 { 1049 {
1013 more->destroy (); 1050 more->destroy ();
1014 more = 0; 1051 more = 0;
1022 attacked_by = 0; 1059 attacked_by = 0;
1023 current_weapon = 0; 1060 current_weapon = 0;
1024} 1061}
1025 1062
1026void 1063void
1027object::destroy (bool destroy_inventory) 1064object::destroy ()
1028{ 1065{
1029 if (destroyed ()) 1066 if (destroyed ())
1030 return; 1067 return;
1031 1068
1032 if (!is_head () && !head->destroyed ()) 1069 if (!is_head () && !head->destroyed ())
1033 { 1070 {
1034 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1071 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1035 head->destroy (destroy_inventory); 1072 head->destroy ();
1073 return;
1036 } 1074 }
1037 1075
1038 destroy_inv (!destroy_inventory); 1076 destroy_inv (false);
1039 1077
1040 if (is_head ()) 1078 if (is_head ())
1041 if (sound_destroy) 1079 if (sound_destroy)
1042 play_sound (sound_destroy); 1080 play_sound (sound_destroy);
1043 else if (flag [FLAG_MONSTER]) 1081 else if (flag [FLAG_MONSTER])
1054 * the previous environment. 1092 * the previous environment.
1055 */ 1093 */
1056void 1094void
1057object::do_remove () 1095object::do_remove ()
1058{ 1096{
1059 object *tmp, *last = 0;
1060 object *otmp;
1061
1062 if (flag [FLAG_REMOVED]) 1097 if (flag [FLAG_REMOVED])
1063 return; 1098 return;
1064 1099
1065 INVOKE_OBJECT (REMOVE, this); 1100 INVOKE_OBJECT (REMOVE, this);
1066 1101
1080 esrv_del_item (pl->contr, count); 1115 esrv_del_item (pl->contr, count);
1081 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1116 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1082 1117
1083 adjust_weight (env, -total_weight ()); 1118 adjust_weight (env, -total_weight ());
1084 1119
1085 *(above ? &above->below : &env->inv) = below; 1120 object *pl = in_player ();
1086
1087 if (below)
1088 below->above = above;
1089 1121
1090 /* we set up values so that it could be inserted into 1122 /* we set up values so that it could be inserted into
1091 * the map, but we don't actually do that - it is up 1123 * the map, but we don't actually do that - it is up
1092 * to the caller to decide what we want to do. 1124 * to the caller to decide what we want to do.
1093 */ 1125 */
1094 map = env->map; 1126 map = env->map;
1095 x = env->x; 1127 x = env->x;
1096 y = env->y; 1128 y = env->y;
1129
1130 // make sure cmov optimisation is applicable
1131 *(above ? &above->below : &env->inv) = below;
1132 *(below ? &below->above : &above ) = above; // &above is just a dummy
1133
1097 above = 0; 1134 above = 0;
1098 below = 0; 1135 below = 0;
1099 env = 0; 1136 env = 0;
1100 1137
1101 /* NO_FIX_PLAYER is set when a great many changes are being 1138 if (pl && pl->is_player ())
1102 * made to players inventory. If set, avoiding the call
1103 * to save cpu time.
1104 */ 1139 {
1105 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1140 pl->contr->queue_stats_update ();
1106 otmp->update_stats (); 1141
1142 if (glow_radius && pl->is_on_map ())
1143 update_all_los (pl->map, pl->x, pl->y);
1144 }
1107 } 1145 }
1108 else if (map) 1146 else if (map)
1109 { 1147 {
1110 map->dirty = true; 1148 map->dirty = true;
1111 mapspace &ms = this->ms (); 1149 mapspace &ms = this->ms ();
1112 1150
1113 if (object *pl = ms.player ()) 1151 if (object *pl = ms.player ())
1114 { 1152 {
1115 if (type == PLAYER) // this == pl(!) 1153 if (is_player ())
1116 { 1154 {
1155 if (!flag [FLAG_WIZPASS])
1156 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1157
1117 // leaving a spot always closes any open container on the ground 1158 // leaving a spot always closes any open container on the ground
1118 if (container && !container->env) 1159 if (container && !container->env)
1119 // this causes spurious floorbox updates, but it ensures 1160 // this causes spurious floorbox updates, but it ensures
1120 // that the CLOSE event is being sent. 1161 // that the CLOSE event is being sent.
1121 close_container (); 1162 close_container ();
1122 1163
1123 --map->players; 1164 --map->players;
1124 map->touch (); 1165 map->touch ();
1125 } 1166 }
1126 else if (pl->container == this) 1167 else if (pl->container_ () == this)
1127 { 1168 {
1128 // removing a container should close it 1169 // removing a container should close it
1129 close_container (); 1170 close_container ();
1130 } 1171 }
1131 1172
1132 esrv_del_item (pl->contr, count); 1173 esrv_del_item (pl->contr, count);
1133 } 1174 }
1134 1175
1135 /* link the object above us */ 1176 /* link the object above us */
1136 if (above) 1177 // re-link, make sure compiler can easily use cmove
1137 above->below = below; 1178 *(above ? &above->below : &ms.top) = below;
1138 else 1179 *(below ? &below->above : &ms.bot) = above;
1139 ms.top = below; /* we were top, set new top */
1140
1141 /* Relink the object below us, if there is one */
1142 if (below)
1143 below->above = above;
1144 else
1145 {
1146 /* Nothing below, which means we need to relink map object for this space
1147 * use translated coordinates in case some oddness with map tiling is
1148 * evident
1149 */
1150 if (GET_MAP_OB (map, x, y) != this)
1151 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1152
1153 ms.bot = above; /* goes on above it. */
1154 }
1155 1180
1156 above = 0; 1181 above = 0;
1157 below = 0; 1182 below = 0;
1158 1183
1184 ms.invalidate ();
1185
1159 if (map->in_memory == MAP_SAVING) 1186 if (map->in_memory == MAP_SAVING)
1160 return; 1187 return;
1161 1188
1162 int check_walk_off = !flag [FLAG_NO_APPLY]; 1189 int check_walk_off = !flag [FLAG_NO_APPLY];
1163 1190
1164 if (object *pl = ms.player ()) 1191 if (object *pl = ms.player ())
1165 { 1192 {
1166 if (pl->container == this) 1193 if (pl->container_ () == this)
1167 /* If a container that the player is currently using somehow gets 1194 /* If a container that the player is currently using somehow gets
1168 * removed (most likely destroyed), update the player view 1195 * removed (most likely destroyed), update the player view
1169 * appropriately. 1196 * appropriately.
1170 */ 1197 */
1171 pl->close_container (); 1198 pl->close_container ();
1172 1199
1173 //TODO: the floorbox prev/next might need updating 1200 //TODO: the floorbox prev/next might need updating
1174 esrv_del_item (pl->contr, count); 1201 //esrv_del_item (pl->contr, count);
1202 //TODO: update floorbox to preserve ordering
1203 if (pl->contr->ns)
1204 pl->contr->ns->floorbox_update ();
1175 } 1205 }
1176 1206
1207 if (check_walk_off)
1177 for (tmp = ms.bot; tmp; tmp = tmp->above) 1208 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1178 { 1209 {
1210 above = tmp->above;
1211
1179 /* No point updating the players look faces if he is the object 1212 /* No point updating the players look faces if he is the object
1180 * being removed. 1213 * being removed.
1181 */ 1214 */
1182 1215
1183 /* See if object moving off should effect something */ 1216 /* See if object moving off should effect something */
1184 if (check_walk_off
1185 && ((move_type & tmp->move_off) 1217 if ((move_type & tmp->move_off)
1186 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1218 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1187 {
1188 move_apply (tmp, this, 0); 1219 move_apply (tmp, this, 0);
1189
1190 if (destroyed ())
1191 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1192 } 1220 }
1193 1221
1194 last = tmp; 1222 if (affects_los ())
1195 }
1196
1197 /* last == NULL if there are no objects on this space */
1198 //TODO: this makes little sense, why only update the topmost object?
1199 if (!last)
1200 map->at (x, y).flags_ = 0;
1201 else
1202 update_object (last, UP_OBJ_REMOVE);
1203
1204 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1205 update_all_los (map, x, y); 1223 update_all_los (map, x, y);
1206 } 1224 }
1207} 1225}
1208 1226
1209/* 1227/*
1233 esrv_update_item (UPD_NROF, pl, top); 1251 esrv_update_item (UPD_NROF, pl, top);
1234 1252
1235 op->weight = 0; // cancel the addition above 1253 op->weight = 0; // cancel the addition above
1236 op->carrying = 0; // must be 0 already 1254 op->carrying = 0; // must be 0 already
1237 1255
1238 op->destroy (1); 1256 op->destroy ();
1239 1257
1240 return top; 1258 return top;
1241 } 1259 }
1242 1260
1243 return 0; 1261 return 0;
1251 1269
1252 object *prev = this; 1270 object *prev = this;
1253 1271
1254 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1272 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1255 { 1273 {
1256 object *op = arch_to_object (at); 1274 object *op = at->instance ();
1257 1275
1258 op->name = name; 1276 op->name = name;
1259 op->name_pl = name_pl; 1277 op->name_pl = name_pl;
1260 op->title = title; 1278 op->title = title;
1261 1279
1271 * job preparing multi-part monsters. 1289 * job preparing multi-part monsters.
1272 */ 1290 */
1273object * 1291object *
1274insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1292insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1275{ 1293{
1294 op->remove ();
1295
1276 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1296 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1277 { 1297 {
1278 tmp->x = x + tmp->arch->x; 1298 tmp->x = x + tmp->arch->x;
1279 tmp->y = y + tmp->arch->y; 1299 tmp->y = y + tmp->arch->y;
1280 } 1300 }
1303 * just 'op' otherwise 1323 * just 'op' otherwise
1304 */ 1324 */
1305object * 1325object *
1306insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1326insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1307{ 1327{
1308 assert (!op->flag [FLAG_FREED]);
1309
1310 op->remove (); 1328 op->remove ();
1329
1330 if (m == &freed_map)//D TODO: remove soon
1331 {//D
1332 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1333 }//D
1311 1334
1312 /* Ideally, the caller figures this out. However, it complicates a lot 1335 /* Ideally, the caller figures this out. However, it complicates a lot
1313 * of areas of callers (eg, anything that uses find_free_spot would now 1336 * of areas of callers (eg, anything that uses find_free_spot would now
1314 * need extra work 1337 * need extra work
1315 */ 1338 */
1339 maptile *newmap = m;
1316 if (!xy_normalise (m, op->x, op->y)) 1340 if (!xy_normalise (newmap, op->x, op->y))
1317 { 1341 {
1318 op->destroy (1); 1342 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1319 return 0; 1343 return 0;
1320 } 1344 }
1321 1345
1322 if (object *more = op->more) 1346 if (object *more = op->more)
1323 if (!insert_ob_in_map (more, m, originator, flag)) 1347 if (!insert_ob_in_map (more, m, originator, flag))
1324 return 0; 1348 return 0;
1325 1349
1326 CLEAR_FLAG (op, FLAG_REMOVED); 1350 op->flag [FLAG_REMOVED] = false;
1327 1351 op->env = 0;
1328 op->map = m; 1352 op->map = newmap;
1353
1329 mapspace &ms = op->ms (); 1354 mapspace &ms = op->ms ();
1330 1355
1331 /* this has to be done after we translate the coordinates. 1356 /* this has to be done after we translate the coordinates.
1332 */ 1357 */
1333 if (op->nrof && !(flag & INS_NO_MERGE)) 1358 if (op->nrof && !(flag & INS_NO_MERGE))
1334 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1359 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335 if (object::can_merge (op, tmp)) 1360 if (object::can_merge (op, tmp))
1336 { 1361 {
1337 // TODO: we atcually want to update tmp, not op, 1362 // TODO: we actually want to update tmp, not op,
1338 // but some caller surely breaks when we return tmp 1363 // but some caller surely breaks when we return tmp
1339 // from here :/ 1364 // from here :/
1340 op->nrof += tmp->nrof; 1365 op->nrof += tmp->nrof;
1341 tmp->destroy (1); 1366 tmp->destroy ();
1342 } 1367 }
1343 1368
1344 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1369 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1345 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1370 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1346 1371
1353 { 1378 {
1354 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1379 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1355 abort (); 1380 abort ();
1356 } 1381 }
1357 1382
1383 if (!originator->is_on_map ())
1384 {
1385 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1386 op->debug_desc (), originator->debug_desc ());
1387 abort ();
1388 }
1389
1358 op->above = originator; 1390 op->above = originator;
1359 op->below = originator->below; 1391 op->below = originator->below;
1360
1361 if (op->below)
1362 op->below->above = op;
1363 else
1364 ms.bot = op;
1365
1366 /* since *below* originator, no need to update top */
1367 originator->below = op; 1392 originator->below = op;
1393
1394 *(op->below ? &op->below->above : &ms.bot) = op;
1368 } 1395 }
1369 else 1396 else
1370 { 1397 {
1371 object *top, *floor = NULL; 1398 object *floor = 0;
1372 1399 object *top = ms.top;
1373 top = ms.bot;
1374 1400
1375 /* If there are other objects, then */ 1401 /* If there are other objects, then */
1376 if (top) 1402 if (top)
1377 { 1403 {
1378 object *last = 0;
1379
1380 /* 1404 /*
1381 * If there are multiple objects on this space, we do some trickier handling. 1405 * If there are multiple objects on this space, we do some trickier handling.
1382 * We've already dealt with merging if appropriate. 1406 * We've already dealt with merging if appropriate.
1383 * Generally, we want to put the new object on top. But if 1407 * Generally, we want to put the new object on top. But if
1384 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1408 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1387 * once we get to them. This reduces the need to traverse over all of 1411 * once we get to them. This reduces the need to traverse over all of
1388 * them when adding another one - this saves quite a bit of cpu time 1412 * them when adding another one - this saves quite a bit of cpu time
1389 * when lots of spells are cast in one area. Currently, it is presumed 1413 * when lots of spells are cast in one area. Currently, it is presumed
1390 * that flying non pickable objects are spell objects. 1414 * that flying non pickable objects are spell objects.
1391 */ 1415 */
1392 for (top = ms.bot; top; top = top->above) 1416 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1393 { 1417 {
1394 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1418 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1395 floor = top; 1419 floor = tmp;
1396 1420
1397 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1421 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1398 { 1422 {
1399 /* We insert above top, so we want this object below this */ 1423 /* We insert above top, so we want this object below this */
1400 top = top->below; 1424 top = tmp->below;
1401 break; 1425 break;
1402 } 1426 }
1403 1427
1404 last = top; 1428 top = tmp;
1405 } 1429 }
1406
1407 /* Don't want top to be NULL, so set it to the last valid object */
1408 top = last;
1409 1430
1410 /* We let update_position deal with figuring out what the space 1431 /* We let update_position deal with figuring out what the space
1411 * looks like instead of lots of conditions here. 1432 * looks like instead of lots of conditions here.
1412 * makes things faster, and effectively the same result. 1433 * makes things faster, and effectively the same result.
1413 */ 1434 */
1420 */ 1441 */
1421 if (!(flag & INS_ON_TOP) 1442 if (!(flag & INS_ON_TOP)
1422 && ms.flags () & P_BLOCKSVIEW 1443 && ms.flags () & P_BLOCKSVIEW
1423 && (op->face && !faces [op->face].visibility)) 1444 && (op->face && !faces [op->face].visibility))
1424 { 1445 {
1446 object *last;
1447
1425 for (last = top; last != floor; last = last->below) 1448 for (last = top; last != floor; last = last->below)
1426 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1449 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1427 break; 1450 break;
1428 1451
1429 /* Check to see if we found the object that blocks view, 1452 /* Check to see if we found the object that blocks view,
1437 } /* If objects on this space */ 1460 } /* If objects on this space */
1438 1461
1439 if (flag & INS_ABOVE_FLOOR_ONLY) 1462 if (flag & INS_ABOVE_FLOOR_ONLY)
1440 top = floor; 1463 top = floor;
1441 1464
1442 /* Top is the object that our object (op) is going to get inserted above. 1465 // insert object above top, or bottom-most if top = 0
1443 */
1444
1445 /* First object on this space */
1446 if (!top) 1466 if (!top)
1447 { 1467 {
1468 op->below = 0;
1448 op->above = ms.bot; 1469 op->above = ms.bot;
1449
1450 if (op->above)
1451 op->above->below = op;
1452
1453 op->below = 0;
1454 ms.bot = op; 1470 ms.bot = op;
1471
1472 *(op->above ? &op->above->below : &ms.top) = op;
1455 } 1473 }
1456 else 1474 else
1457 { /* get inserted into the stack above top */ 1475 {
1458 op->above = top->above; 1476 op->above = top->above;
1459
1460 if (op->above)
1461 op->above->below = op; 1477 top->above = op;
1462 1478
1463 op->below = top; 1479 op->below = top;
1464 top->above = op; 1480 *(op->above ? &op->above->below : &ms.top) = op;
1465 } 1481 }
1482 }
1466 1483
1467 if (!op->above) 1484 if (op->is_player ())
1468 ms.top = op;
1469 } /* else not INS_BELOW_ORIGINATOR */
1470
1471 if (op->type == PLAYER)
1472 { 1485 {
1473 op->contr->do_los = 1; 1486 op->contr->do_los = 1;
1474 ++op->map->players; 1487 ++op->map->players;
1475 op->map->touch (); 1488 op->map->touch ();
1476 } 1489 }
1477 1490
1478 op->map->dirty = true; 1491 op->map->dirty = true;
1479 1492
1480 if (object *pl = ms.player ()) 1493 if (object *pl = ms.player ())
1481 //TODO: the floorbox prev/next might need updating 1494 //TODO: the floorbox prev/next might need updating
1482 esrv_send_item (pl, op); 1495 //esrv_send_item (pl, op);
1496 //TODO: update floorbox to preserve ordering
1497 if (pl->contr->ns)
1498 pl->contr->ns->floorbox_update ();
1483 1499
1484 /* If this object glows, it may affect lighting conditions that are 1500 /* If this object glows, it may affect lighting conditions that are
1485 * visible to others on this map. But update_all_los is really 1501 * visible to others on this map. But update_all_los is really
1486 * an inefficient way to do this, as it means los for all players 1502 * an inefficient way to do this, as it means los for all players
1487 * on the map will get recalculated. The players could very well 1503 * on the map will get recalculated. The players could very well
1488 * be far away from this change and not affected in any way - 1504 * be far away from this change and not affected in any way -
1489 * this should get redone to only look for players within range, 1505 * this should get redone to only look for players within range,
1490 * or just updating the P_UPTODATE for spaces within this area 1506 * or just updating the P_UPTODATE for spaces within this area
1491 * of effect may be sufficient. 1507 * of effect may be sufficient.
1492 */ 1508 */
1493 if (op->map->darkness && (op->glow_radius != 0)) 1509 if (op->affects_los ())
1510 {
1511 op->ms ().invalidate ();
1494 update_all_los (op->map, op->x, op->y); 1512 update_all_los (op->map, op->x, op->y);
1513 }
1495 1514
1496 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1515 /* updates flags (blocked, alive, no magic, etc) for this map space */
1497 update_object (op, UP_OBJ_INSERT); 1516 update_object (op, UP_OBJ_INSERT);
1498 1517
1499 INVOKE_OBJECT (INSERT, op); 1518 INVOKE_OBJECT (INSERT, op);
1506 * blocked() and wall() work properly), and these flags are updated by 1525 * blocked() and wall() work properly), and these flags are updated by
1507 * update_object(). 1526 * update_object().
1508 */ 1527 */
1509 1528
1510 /* if this is not the head or flag has been passed, don't check walk on status */ 1529 /* if this is not the head or flag has been passed, don't check walk on status */
1511 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1530 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1512 { 1531 {
1513 if (check_move_on (op, originator)) 1532 if (check_move_on (op, originator))
1514 return 0; 1533 return 0;
1515 1534
1516 /* If we are a multi part object, lets work our way through the check 1535 /* If we are a multi part object, lets work our way through the check
1527/* this function inserts an object in the map, but if it 1546/* this function inserts an object in the map, but if it
1528 * finds an object of its own type, it'll remove that one first. 1547 * finds an object of its own type, it'll remove that one first.
1529 * op is the object to insert it under: supplies x and the map. 1548 * op is the object to insert it under: supplies x and the map.
1530 */ 1549 */
1531void 1550void
1532replace_insert_ob_in_map (const char *arch_string, object *op) 1551replace_insert_ob_in_map (shstr_tmp archname, object *op)
1533{ 1552{
1534 /* first search for itself and remove any old instances */ 1553 /* first search for itself and remove any old instances */
1535 1554
1536 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1555 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1537 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1556 if (tmp->arch->archname == archname) /* same archetype */
1538 tmp->destroy (1); 1557 tmp->destroy ();
1539 1558
1540 object *tmp = arch_to_object (archetype::find (arch_string)); 1559 object *tmp = archetype::find (archname)->instance ();
1541 1560
1542 tmp->x = op->x; 1561 tmp->x = op->x;
1543 tmp->y = op->y; 1562 tmp->y = op->y;
1544 1563
1545 insert_ob_in_map (tmp, op->map, op, 0); 1564 insert_ob_in_map (tmp, op->map, op, 0);
1550{ 1569{
1551 if (where->env) 1570 if (where->env)
1552 return where->env->insert (this); 1571 return where->env->insert (this);
1553 else 1572 else
1554 return where->map->insert (this, where->x, where->y, originator, flags); 1573 return where->map->insert (this, where->x, where->y, originator, flags);
1574}
1575
1576// check whether we can put this into the map, respect max_volume, max_items
1577bool
1578object::can_drop_at (maptile *m, int x, int y, object *originator)
1579{
1580 mapspace &ms = m->at (x, y);
1581
1582 int items = ms.items ();
1583
1584 if (!items // testing !items ensures we can drop at least one item
1585 || (items < m->max_items
1586 && ms.volume () < m->max_volume))
1587 return true;
1588
1589 if (originator && originator->is_player ())
1590 originator->contr->failmsg (format (
1591 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1592 query_name ()
1593 ));
1594
1595 return false;
1555} 1596}
1556 1597
1557/* 1598/*
1558 * decrease(object, number) decreases a specified number from 1599 * decrease(object, number) decreases a specified number from
1559 * the amount of an object. If the amount reaches 0, the object 1600 * the amount of an object. If the amount reaches 0, the object
1567 if (!nr) 1608 if (!nr)
1568 return true; 1609 return true;
1569 1610
1570 nr = min (nr, nrof); 1611 nr = min (nr, nrof);
1571 1612
1613 if (nrof > nr)
1614 {
1572 nrof -= nr; 1615 nrof -= nr;
1573
1574 if (nrof)
1575 {
1576 adjust_weight (env, -weight * nr); // carrying == 0 1616 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1577 1617
1578 if (object *pl = visible_to ()) 1618 if (object *pl = visible_to ())
1579 esrv_update_item (UPD_NROF, pl, this); 1619 esrv_update_item (UPD_NROF, pl, this);
1580 1620
1581 return true; 1621 return true;
1582 } 1622 }
1583 else 1623 else
1584 { 1624 {
1585 destroy (1); 1625 destroy ();
1586 return false; 1626 return false;
1587 } 1627 }
1588} 1628}
1589 1629
1590/* 1630/*
1607 } 1647 }
1608 else 1648 else
1609 { 1649 {
1610 decrease (nr); 1650 decrease (nr);
1611 1651
1612 object *op = object_create_clone (this); 1652 object *op = deep_clone ();
1613 op->nrof = nr; 1653 op->nrof = nr;
1614 return op; 1654 return op;
1615 } 1655 }
1616} 1656}
1617 1657
1667 if (object *pl = tmp->visible_to ()) 1707 if (object *pl = tmp->visible_to ())
1668 esrv_update_item (UPD_NROF, pl, tmp); 1708 esrv_update_item (UPD_NROF, pl, tmp);
1669 1709
1670 adjust_weight (this, op->total_weight ()); 1710 adjust_weight (this, op->total_weight ());
1671 1711
1672 op->destroy (1); 1712 op->destroy ();
1673 op = tmp; 1713 op = tmp;
1674 goto inserted; 1714 goto inserted;
1675 } 1715 }
1676 1716
1677 op->owner = 0; // it's his/hers now. period. 1717 op->owner = 0; // it's his/hers now. period.
1695 1735
1696 adjust_weight (this, op->total_weight ()); 1736 adjust_weight (this, op->total_weight ());
1697 1737
1698inserted: 1738inserted:
1699 /* reset the light list and los of the players on the map */ 1739 /* reset the light list and los of the players on the map */
1700 if (op->glow_radius && map && map->darkness) 1740 if (op->glow_radius && is_on_map ())
1741 {
1742 update_stats ();
1701 update_all_los (map, x, y); 1743 update_all_los (map, x, y);
1702 1744 }
1745 else if (is_player ())
1703 // if this is a player's inventory, update stats 1746 // if this is a player's inventory, update stats
1704 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1747 contr->queue_stats_update ();
1705 update_stats ();
1706 1748
1707 INVOKE_OBJECT (INSERT, this); 1749 INVOKE_OBJECT (INSERT, this);
1708 1750
1709 return op; 1751 return op;
1710} 1752}
1730 * on top. 1772 * on top.
1731 */ 1773 */
1732int 1774int
1733check_move_on (object *op, object *originator) 1775check_move_on (object *op, object *originator)
1734{ 1776{
1777 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1778 return 0;
1779
1735 object *tmp; 1780 object *tmp;
1736 maptile *m = op->map; 1781 maptile *m = op->map;
1737 int x = op->x, y = op->y; 1782 int x = op->x, y = op->y;
1738 1783
1739 MoveType move_on, move_slow, move_block; 1784 mapspace &ms = m->at (x, y);
1740 1785
1741 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1786 ms.update ();
1742 return 0;
1743 1787
1744 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1788 MoveType move_on = ms.move_on;
1745 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1789 MoveType move_slow = ms.move_slow;
1746 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1790 MoveType move_block = ms.move_block;
1747 1791
1748 /* if nothing on this space will slow op down or be applied, 1792 /* if nothing on this space will slow op down or be applied,
1749 * no need to do checking below. have to make sure move_type 1793 * no need to do checking below. have to make sure move_type
1750 * is set, as lots of objects don't have it set - we treat that 1794 * is set, as lots of objects don't have it set - we treat that
1751 * as walking. 1795 * as walking.
1762 return 0; 1806 return 0;
1763 1807
1764 /* The objects have to be checked from top to bottom. 1808 /* The objects have to be checked from top to bottom.
1765 * Hence, we first go to the top: 1809 * Hence, we first go to the top:
1766 */ 1810 */
1767 1811 for (object *next, *tmp = ms.top; tmp; tmp = next)
1768 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1769 {
1770 /* Trim the search when we find the first other spell effect
1771 * this helps performance so that if a space has 50 spell objects,
1772 * we don't need to check all of them.
1773 */
1774 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1775 break;
1776 } 1812 {
1813 next = tmp->below;
1777 1814
1778 for (; tmp; tmp = tmp->below)
1779 {
1780 if (tmp == op) 1815 if (tmp == op)
1781 continue; /* Can't apply yourself */ 1816 continue; /* Can't apply yourself */
1782 1817
1783 /* Check to see if one of the movement types should be slowed down. 1818 /* Check to see if one of the movement types should be slowed down.
1784 * Second check makes sure that the movement types not being slowed 1819 * Second check makes sure that the movement types not being slowed
1789 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1824 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1790 { 1825 {
1791 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1826 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1792 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1827 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1793 { 1828 {
1794
1795 float
1796 diff = tmp->move_slow_penalty * fabs (op->speed); 1829 float diff = tmp->move_slow_penalty * fabs (op->speed);
1797 1830
1798 if (op->type == PLAYER) 1831 if (op->is_player ())
1799 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1832 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1800 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1833 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1801 diff /= 4.0; 1834 diff /= 4.0;
1802 1835
1803 op->speed_left -= diff; 1836 op->speed_left -= diff;
1804 } 1837 }
1805 } 1838 }
1838 LOG (llevError, "Present_arch called outside map.\n"); 1871 LOG (llevError, "Present_arch called outside map.\n");
1839 return NULL; 1872 return NULL;
1840 } 1873 }
1841 1874
1842 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1875 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1843 if (tmp->arch == at) 1876 if (tmp->arch->archname == at->archname)
1844 return tmp; 1877 return tmp;
1845 1878
1846 return NULL; 1879 return NULL;
1847} 1880}
1848 1881
1912 * The first matching object is returned, or NULL if none. 1945 * The first matching object is returned, or NULL if none.
1913 */ 1946 */
1914object * 1947object *
1915present_arch_in_ob (const archetype *at, const object *op) 1948present_arch_in_ob (const archetype *at, const object *op)
1916{ 1949{
1917 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1950 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1918 if (tmp->arch == at) 1951 if (tmp->arch->archname == at->archname)
1919 return tmp; 1952 return tmp;
1920 1953
1921 return NULL; 1954 return NULL;
1922} 1955}
1923 1956
2011 * head of the object should correspond for the entire object. 2044 * head of the object should correspond for the entire object.
2012 */ 2045 */
2013 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2046 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2014 continue; 2047 continue;
2015 2048
2016 if (ob->blocked (m, pos.x, pos.y)) 2049 if (ob->blocked (pos.m, pos.x, pos.y))
2017 continue; 2050 continue;
2018 2051
2019 altern [index++] = i; 2052 altern [index++] = i;
2020 } 2053 }
2021 2054
2089 * there is capable of. 2122 * there is capable of.
2090 */ 2123 */
2091int 2124int
2092find_dir (maptile *m, int x, int y, object *exclude) 2125find_dir (maptile *m, int x, int y, object *exclude)
2093{ 2126{
2094 int i, max = SIZEOFFREE, mflags; 2127 int max = SIZEOFFREE, mflags;
2095
2096 sint16 nx, ny;
2097 object *tmp;
2098 maptile *mp;
2099
2100 MoveType blocked, move_type; 2128 MoveType move_type;
2101 2129
2102 if (exclude && exclude->head_ () != exclude) 2130 if (exclude && exclude->head_ () != exclude)
2103 { 2131 {
2104 exclude = exclude->head; 2132 exclude = exclude->head;
2105 move_type = exclude->move_type; 2133 move_type = exclude->move_type;
2108 { 2136 {
2109 /* If we don't have anything, presume it can use all movement types. */ 2137 /* If we don't have anything, presume it can use all movement types. */
2110 move_type = MOVE_ALL; 2138 move_type = MOVE_ALL;
2111 } 2139 }
2112 2140
2113 for (i = 1; i < max; i++) 2141 for (int i = 1; i < max; i++)
2114 { 2142 {
2115 mp = m; 2143 mapxy pos (m, x, y);
2116 nx = x + freearr_x[i]; 2144 pos.move (i);
2117 ny = y + freearr_y[i];
2118 2145
2119 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2146 if (!pos.normalise ())
2120
2121 if (mflags & P_OUT_OF_MAP)
2122 max = maxfree[i]; 2147 max = maxfree[i];
2123 else 2148 else
2124 { 2149 {
2125 mapspace &ms = mp->at (nx, ny); 2150 mapspace &ms = *pos;
2126 2151
2127 blocked = ms.move_block;
2128
2129 if ((move_type & blocked) == move_type) 2152 if ((move_type & ms.move_block) == move_type)
2130 max = maxfree[i]; 2153 max = maxfree [i];
2131 else if (mflags & P_IS_ALIVE) 2154 else if (ms.flags () & P_IS_ALIVE)
2132 { 2155 {
2133 for (tmp = ms.bot; tmp; tmp = tmp->above) 2156 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2134 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2157 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2135 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2158 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2136 break;
2137
2138 if (tmp)
2139 return freedir[i]; 2159 return freedir [i];
2140 } 2160 }
2141 } 2161 }
2142 } 2162 }
2143 2163
2144 return 0; 2164 return 0;
2219 * This basically means that if direction is 15, then it could either go 2239 * This basically means that if direction is 15, then it could either go
2220 * direction 4, 14, or 16 to get back to where we are. 2240 * direction 4, 14, or 16 to get back to where we are.
2221 * Moved from spell_util.c to object.c with the other related direction 2241 * Moved from spell_util.c to object.c with the other related direction
2222 * functions. 2242 * functions.
2223 */ 2243 */
2224int reduction_dir[SIZEOFFREE][3] = { 2244static const int reduction_dir[SIZEOFFREE][3] = {
2225 {0, 0, 0}, /* 0 */ 2245 {0, 0, 0}, /* 0 */
2226 {0, 0, 0}, /* 1 */ 2246 {0, 0, 0}, /* 1 */
2227 {0, 0, 0}, /* 2 */ 2247 {0, 0, 0}, /* 2 */
2228 {0, 0, 0}, /* 3 */ 2248 {0, 0, 0}, /* 3 */
2229 {0, 0, 0}, /* 4 */ 2249 {0, 0, 0}, /* 4 */
2325int 2345int
2326can_pick (const object *who, const object *item) 2346can_pick (const object *who, const object *item)
2327{ 2347{
2328 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2348 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2329 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2349 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2330 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2350 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2331} 2351}
2332 2352
2333/* 2353/*
2334 * create clone from object to another 2354 * create clone from object to another
2335 */ 2355 */
2336object * 2356object *
2337object_create_clone (object *asrc) 2357object::deep_clone ()
2338{ 2358{
2339 object *dst = 0, *tmp, *src, *prev, *item; 2359 assert (("deep_clone called on non-head object", is_head ()));
2340 2360
2341 if (!asrc) 2361 object *dst = clone ();
2342 return 0;
2343 2362
2344 src = asrc->head_ (); 2363 object *prev = dst;
2345
2346 prev = 0;
2347 for (object *part = src; part; part = part->more) 2364 for (object *part = this->more; part; part = part->more)
2348 { 2365 {
2349 tmp = part->clone (); 2366 object *tmp = part->clone ();
2350 tmp->x -= src->x;
2351 tmp->y -= src->y;
2352
2353 if (!part->head)
2354 {
2355 dst = tmp;
2356 tmp->head = 0;
2357 }
2358 else
2359 tmp->head = dst; 2367 tmp->head = dst;
2360
2361 tmp->more = 0;
2362
2363 if (prev)
2364 prev->more = tmp; 2368 prev->more = tmp;
2365
2366 prev = tmp; 2369 prev = tmp;
2367 } 2370 }
2368 2371
2369 for (item = src->inv; item; item = item->below) 2372 for (object *item = inv; item; item = item->below)
2370 insert_ob_in_ob (object_create_clone (item), dst); 2373 insert_ob_in_ob (item->deep_clone (), dst);
2371 2374
2372 return dst; 2375 return dst;
2373} 2376}
2374 2377
2375/* This returns the first object in who's inventory that 2378/* This returns the first object in who's inventory that
2384 return tmp; 2387 return tmp;
2385 2388
2386 return 0; 2389 return 0;
2387} 2390}
2388 2391
2389/* If ob has a field named key, return the link from the list, 2392shstr_tmp
2390 * otherwise return NULL. 2393object::kv_get (shstr_tmp key) const
2391 *
2392 * key must be a passed in shared string - otherwise, this won't
2393 * do the desired thing.
2394 */
2395key_value *
2396get_ob_key_link (const object *ob, const char *key)
2397{ 2394{
2398 for (key_value *link = ob->key_values; link; link = link->next) 2395 for (key_value *kv = key_values; kv; kv = kv->next)
2399 if (link->key == key) 2396 if (kv->key == key)
2400 return link;
2401
2402 return 0;
2403}
2404
2405/*
2406 * Returns the value of op has an extra_field for key, or NULL.
2407 *
2408 * The argument doesn't need to be a shared string.
2409 *
2410 * The returned string is shared.
2411 */
2412const char *
2413get_ob_key_value (const object *op, const char *const key)
2414{
2415 key_value *link;
2416 shstr_cmp canonical_key (key);
2417
2418 if (!canonical_key)
2419 {
2420 /* 1. There being a field named key on any object
2421 * implies there'd be a shared string to find.
2422 * 2. Since there isn't, no object has this field.
2423 * 3. Therefore, *this* object doesn't have this field.
2424 */
2425 return 0;
2426 }
2427
2428 /* This is copied from get_ob_key_link() above -
2429 * only 4 lines, and saves the function call overhead.
2430 */
2431 for (link = op->key_values; link; link = link->next)
2432 if (link->key == canonical_key)
2433 return link->value; 2397 return kv->value;
2434 2398
2435 return 0; 2399 return shstr ();
2436} 2400}
2437 2401
2438/* 2402void
2439 * Updates the canonical_key in op to value. 2403object::kv_set (shstr_tmp key, shstr_tmp value)
2440 *
2441 * canonical_key is a shared string (value doesn't have to be).
2442 *
2443 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2444 * keys.
2445 *
2446 * Returns TRUE on success.
2447 */
2448int
2449set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2450{ 2404{
2451 key_value *field = NULL, *last = NULL; 2405 for (key_value *kv = key_values; kv; kv = kv->next)
2452 2406 if (kv->key == key)
2453 for (field = op->key_values; field != NULL; field = field->next)
2454 {
2455 if (field->key != canonical_key)
2456 { 2407 {
2457 last = field; 2408 kv->value = value;
2458 continue; 2409 return;
2459 } 2410 }
2460 2411
2461 if (value) 2412 key_value *kv = new key_value;
2462 field->value = value; 2413
2463 else 2414 kv->next = key_values;
2415 kv->key = key;
2416 kv->value = value;
2417
2418 key_values = kv;
2419}
2420
2421void
2422object::kv_del (shstr_tmp key)
2423{
2424 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2425 if ((*kvp)->key == key)
2464 { 2426 {
2465 /* Basically, if the archetype has this key set, 2427 key_value *kv = *kvp;
2466 * we need to store the null value so when we save 2428 *kvp = (*kvp)->next;
2467 * it, we save the empty value so that when we load, 2429 delete kv;
2468 * we get this value back again. 2430 return;
2469 */
2470 if (get_ob_key_link (op->arch, canonical_key))
2471 field->value = 0;
2472 else
2473 {
2474 if (last)
2475 last->next = field->next;
2476 else
2477 op->key_values = field->next;
2478
2479 delete field;
2480 }
2481 } 2431 }
2482 return TRUE;
2483 }
2484 /* IF we get here, key doesn't exist */
2485
2486 /* No field, we'll have to add it. */
2487
2488 if (!add_key)
2489 return FALSE;
2490
2491 /* There isn't any good reason to store a null
2492 * value in the key/value list. If the archetype has
2493 * this key, then we should also have it, so shouldn't
2494 * be here. If user wants to store empty strings,
2495 * should pass in ""
2496 */
2497 if (value == NULL)
2498 return TRUE;
2499
2500 field = new key_value;
2501
2502 field->key = canonical_key;
2503 field->value = value;
2504 /* Usual prepend-addition. */
2505 field->next = op->key_values;
2506 op->key_values = field;
2507
2508 return TRUE;
2509}
2510
2511/*
2512 * Updates the key in op to value.
2513 *
2514 * If add_key is FALSE, this will only update existing keys,
2515 * and not add new ones.
2516 * In general, should be little reason FALSE is ever passed in for add_key
2517 *
2518 * Returns TRUE on success.
2519 */
2520int
2521set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2522{
2523 shstr key_ (key);
2524
2525 return set_ob_key_value_s (op, key_, value, add_key);
2526} 2432}
2527 2433
2528object::depth_iterator::depth_iterator (object *container) 2434object::depth_iterator::depth_iterator (object *container)
2529: iterator_base (container) 2435: iterator_base (container)
2530{ 2436{
2580{ 2486{
2581 char flagdesc[512]; 2487 char flagdesc[512];
2582 char info2[256 * 4]; 2488 char info2[256 * 4];
2583 char *p = info; 2489 char *p = info;
2584 2490
2585 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2491 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2586 count, 2492 count,
2587 uuid.c_str (), 2493 uuid.c_str (),
2588 &name, 2494 &name,
2589 title ? "\",title:\"" : "", 2495 title ? ",title:\"" : "",
2590 title ? (const char *)title : "", 2496 title ? (const char *)title : "",
2497 title ? "\"" : "",
2591 flag_desc (flagdesc, 512), type); 2498 flag_desc (flagdesc, 512), type);
2592 2499
2593 if (!flag[FLAG_REMOVED] && env) 2500 if (!flag[FLAG_REMOVED] && env)
2594 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2501 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2595 2502
2611struct region * 2518struct region *
2612object::region () const 2519object::region () const
2613{ 2520{
2614 return map ? map->region (x, y) 2521 return map ? map->region (x, y)
2615 : region::default_region (); 2522 : region::default_region ();
2616}
2617
2618const materialtype_t *
2619object::dominant_material () const
2620{
2621 if (materialtype_t *mt = name_to_material (materialname))
2622 return mt;
2623
2624 return name_to_material (shstr_unknown);
2625} 2523}
2626 2524
2627void 2525void
2628object::open_container (object *new_container) 2526object::open_container (object *new_container)
2629{ 2527{
2651 container = 0; 2549 container = 0;
2652 2550
2653 // client needs item update to make it work, client bug requires this to be separate 2551 // client needs item update to make it work, client bug requires this to be separate
2654 esrv_update_item (UPD_FLAGS, this, old_container); 2552 esrv_update_item (UPD_FLAGS, this, old_container);
2655 2553
2656 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2554 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2657 play_sound (sound_find ("chest_close")); 2555 play_sound (sound_find ("chest_close"));
2658 } 2556 }
2659 2557
2660 if (new_container) 2558 if (new_container)
2661 { 2559 {
2665 // TODO: this does not seem to serve any purpose anymore? 2563 // TODO: this does not seem to serve any purpose anymore?
2666#if 0 2564#if 0
2667 // insert the "Close Container" object. 2565 // insert the "Close Container" object.
2668 if (archetype *closer = new_container->other_arch) 2566 if (archetype *closer = new_container->other_arch)
2669 { 2567 {
2670 object *closer = arch_to_object (new_container->other_arch); 2568 object *closer = new_container->other_arch->instance ();
2671 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2569 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2672 new_container->insert (closer); 2570 new_container->insert (closer);
2673 } 2571 }
2674#endif 2572#endif
2675 2573
2676 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2574 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2677 2575
2678 // make sure the container is available, client bug requires this to be separate 2576 // make sure the container is available, client bug requires this to be separate
2679 esrv_send_item (this, new_container); 2577 esrv_send_item (this, new_container);
2680 2578
2681 new_container->flag [FLAG_APPLIED] = true; 2579 new_container->flag [FLAG_APPLIED] = true;
2689// else if (!old_container->env && contr && contr->ns) 2587// else if (!old_container->env && contr && contr->ns)
2690// contr->ns->floorbox_reset (); 2588// contr->ns->floorbox_reset ();
2691} 2589}
2692 2590
2693object * 2591object *
2694object::force_find (const shstr name) 2592object::force_find (shstr_tmp name)
2695{ 2593{
2696 /* cycle through his inventory to look for the MARK we want to 2594 /* cycle through his inventory to look for the MARK we want to
2697 * place 2595 * place
2698 */ 2596 */
2699 for (object *tmp = inv; tmp; tmp = tmp->below) 2597 for (object *tmp = inv; tmp; tmp = tmp->below)
2701 return splay (tmp); 2599 return splay (tmp);
2702 2600
2703 return 0; 2601 return 0;
2704} 2602}
2705 2603
2604//-GPL
2605
2706void 2606void
2607object::force_set_timer (int duration)
2608{
2609 this->duration = 1;
2610 this->speed_left = -1.f;
2611
2612 this->set_speed (duration ? 1.f / duration : 0.f);
2613}
2614
2615object *
2707object::force_add (const shstr name, int duration) 2616object::force_add (shstr_tmp name, int duration)
2708{ 2617{
2709 if (object *force = force_find (name)) 2618 if (object *force = force_find (name))
2710 force->destroy (); 2619 force->destroy ();
2711 2620
2712 object *force = get_archetype (FORCE_NAME); 2621 object *force = get_archetype (FORCE_NAME);
2713 2622
2714 force->slaying = name; 2623 force->slaying = name;
2715 force->stats.food = 1; 2624 force->force_set_timer (duration);
2716 force->speed_left = -1.f;
2717
2718 force->set_speed (duration ? 1.f / duration : 0.f);
2719 force->flag [FLAG_IS_USED_UP] = true;
2720 force->flag [FLAG_APPLIED] = true; 2625 force->flag [FLAG_APPLIED] = true;
2721 2626
2722 insert (force); 2627 return insert (force);
2723} 2628}
2724 2629
2725void 2630void
2726object::play_sound (faceidx sound) 2631object::play_sound (faceidx sound) const
2727{ 2632{
2728 if (!sound) 2633 if (!sound)
2729 return; 2634 return;
2730 2635
2731 if (flag [FLAG_REMOVED]) 2636 if (is_on_map ())
2637 map->play_sound (sound, x, y);
2638 else if (object *pl = in_player ())
2639 pl->contr->play_sound (sound);
2640}
2641
2642void
2643object::say_msg (const char *msg) const
2644{
2645 if (is_on_map ())
2646 map->say_msg (msg, x, y);
2647 else if (object *pl = in_player ())
2648 pl->contr->play_sound (sound);
2649}
2650
2651void
2652object::make_noise ()
2653{
2654 // we do not model noise in the map, so instead put
2655 // a temporary light into the noise source
2656 // could use the map instead, but that's less reliable for our
2657 // goal, which is to make invisibility a bit harder to exploit
2658
2659 // currently only works sensibly for players
2660 if (!is_player ())
2732 return; 2661 return;
2733 2662
2734 if (env) 2663 // find old force, or create new one
2735 { 2664 object *force = force_find (shstr_noise_force);
2736 if (object *pl = in_player ()) 2665
2737 pl->contr->play_sound (sound); 2666 if (force)
2738 } 2667 force->speed_left = -1.f; // patch old speed up
2739 else 2668 else
2740 map->play_sound (sound, x, y); 2669 {
2741} 2670 force = archetype::get (shstr_noise_force);
2742 2671
2672 force->slaying = shstr_noise_force;
2673 force->stats.food = 1;
2674 force->speed_left = -1.f;
2675
2676 force->set_speed (1.f / 4.f);
2677 force->flag [FLAG_IS_USED_UP] = true;
2678 force->flag [FLAG_APPLIED] = true;
2679
2680 insert (force);
2681 }
2682}
2683

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines