ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.256 by root, Sun Aug 31 05:47:14 2008 UTC vs.
Revision 1.337 by root, Thu May 6 21:45:49 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
40 49
41short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
42 0, 51 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 57 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 61};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
60 0, 63 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 67};
65 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
66static void 76static void
67write_uuid (uval64 skip, bool sync) 77write_uuid (uval64 skip, bool sync)
68{ 78{
69 CALL_BEGIN (2); 79 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 80 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 82 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 83 CALL_END;
74} 84}
75 85
76static void 86static void
77read_uuid (void) 87read_uuid ()
78{ 88{
79 char filename[MAX_BUF]; 89 char filename[MAX_BUF];
80 90
81 sprintf (filename, "%s/uuid", settings.localdir); 91 sprintf (filename, "%s/uuid", settings.localdir);
82 92
96 106
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 107 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 108 _exit (1);
99 } 109 }
100 110
101 UUID::BUF buf; 111 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 112 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 113 fgets (buf, sizeof (buf), fp);
104 114
105 if (!UUID::cur.parse (buf)) 115 if (!UUID::cur.parse (buf))
106 { 116 {
133 143
134void 144void
135UUID::init () 145UUID::init ()
136{ 146{
137 read_uuid (); 147 read_uuid ();
148}
149
150bool
151UUID::parse (const char *s)
152{
153 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
154 return false;
155
156 seq = 0;
157
158 while (*s != '>')
159 {
160 if (*s < '0')
161 return false;
162
163 // this gives nice branchless code with gcc
164 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
165 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
166
167 seq = (seq << 4) | digit;
168
169 ++s;
170 }
171
172 return true;
173}
174
175char *
176UUID::append (char *buf) const
177{
178 *buf++ = '<';
179 *buf++ = '1';
180 *buf++ = '.';
181
182 uint64_t seq = this->seq;
183 const int bits = 64;
184 char nz = 0;
185 static const char tohex [] = "0123456789abcdef";
186
187 // assert (len >= 3 + bits / 4 + 1 + 1);
188 for (int i = bits / 4; --i; )
189 {
190 uint8_t digit = seq >> (bits - 4);
191
192 *buf = tohex [digit];
193 nz |= digit;
194 buf += nz ? 1 : 0;
195 seq <<= 4;
196 }
197
198 // last digit is special - always emit
199 uint8_t digit = seq >> (bits - 4);
200 *buf++ = tohex [digit];
201
202 *buf++ = '>';
203
204 return buf;
205}
206
207char *
208UUID::c_str () const
209{
210 static char buf [MAX_LEN];
211 *append (buf) = 0;
212 return buf;
138} 213}
139 214
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 215/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 216static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 217compare_ob_value_lists_one (const object *wants, const object *has)
178 * Improvements made with merge: Better checking on potion, and also 253 * Improvements made with merge: Better checking on potion, and also
179 * check weight 254 * check weight
180 */ 255 */
181bool object::can_merge_slow (object *ob1, object *ob2) 256bool object::can_merge_slow (object *ob1, object *ob2)
182{ 257{
183 /* A couple quicksanity checks */ 258 /* A couple quick sanity checks */
184 if (ob1 == ob2 259 if (ob1 == ob2
185 || ob1->type != ob2->type 260 || ob1->type != ob2->type
186 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 261 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 262 || ob1->name != ob2->name
263 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
189 return 0; 264 return 0;
190 265
191 /* Do not merge objects if nrof would overflow, assume nrof 266 /* Do not merge objects if nrof would overflow, assume nrof
192 * is always 0 .. 2**31-1 */ 267 * is always 0 .. 2**31-1 */
193 if (ob1->nrof > 0x7fffffff - ob2->nrof) 268 if (ob1->nrof > 0x7fffffff - ob2->nrof)
197 * This is to the comparison of the flags below will be OK. We 272 * This is to the comparison of the flags below will be OK. We
198 * just can't ignore the been applied or identified flags, as they 273 * just can't ignore the been applied or identified flags, as they
199 * are not equal - just if it has been identified, the been_applied 274 * are not equal - just if it has been identified, the been_applied
200 * flags lose any meaning. 275 * flags lose any meaning.
201 */ 276 */
202 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 277 if (ob1->flag [FLAG_IDENTIFIED])
203 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 278 ob1->set_flag (FLAG_BEEN_APPLIED);
204 279
205 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 280 if (ob2->flag [FLAG_IDENTIFIED])
206 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 281 ob2->set_flag (FLAG_BEEN_APPLIED);
207 282
208 if (ob1->arch->archname != ob2->arch->archname 283 if (ob1->arch->archname != ob2->arch->archname
209 || ob1->name != ob2->name 284 || ob1->name != ob2->name
210 || ob1->title != ob2->title 285 || ob1->title != ob2->title
211 || ob1->msg != ob2->msg 286 || ob1->msg != ob2->msg
214 || ob1->magic != ob2->magic 289 || ob1->magic != ob2->magic
215 || ob1->slaying != ob2->slaying 290 || ob1->slaying != ob2->slaying
216 || ob1->skill != ob2->skill 291 || ob1->skill != ob2->skill
217 || ob1->value != ob2->value 292 || ob1->value != ob2->value
218 || ob1->animation_id != ob2->animation_id 293 || ob1->animation_id != ob2->animation_id
219 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other 294 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
220 || ob1->client_type != ob2->client_type 295 || ob1->client_type != ob2->client_type
221 || ob1->materialname != ob2->materialname 296 || ob1->material != ob2->material
222 || ob1->lore != ob2->lore 297 || ob1->lore != ob2->lore
223 || ob1->subtype != ob2->subtype 298 || ob1->subtype != ob2->subtype
224 || ob1->move_type != ob2->move_type 299 || ob1->move_type != ob2->move_type
225 || ob1->move_block != ob2->move_block 300 || ob1->move_block != ob2->move_block
226 || ob1->move_allow != ob2->move_allow 301 || ob1->move_allow != ob2->move_allow
227 || ob1->move_on != ob2->move_on 302 || ob1->move_on != ob2->move_on
228 || ob1->move_off != ob2->move_off 303 || ob1->move_off != ob2->move_off
229 || ob1->move_slow != ob2->move_slow 304 || ob1->move_slow != ob2->move_slow
230 || ob1->move_slow_penalty != ob2->move_slow_penalty 305 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 306 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 307 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
233 return 0; 308 return 0;
234 309
235 if ((ob1->flag ^ ob2->flag) 310 if ((ob1->flag ^ ob2->flag)
260 335
261 /* Don't merge objects that are applied. With the new 'body' code, 336 /* Don't merge objects that are applied. With the new 'body' code,
262 * it is possible for most any character to have more than one of 337 * it is possible for most any character to have more than one of
263 * some items equipped, and we don't want those to merge. 338 * some items equipped, and we don't want those to merge.
264 */ 339 */
265 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 340 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
266 return 0; 341 return 0;
267 342
268 /* Note sure why the following is the case - either the object has to 343 /* Note sure why the following is the case - either the object has to
269 * be animated or have a very low speed. Is this an attempted monster 344 * be animated or have a very low speed. Is this an attempted monster
270 * check? 345 * check?
271 */ 346 */
272 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 347 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
273 return 0; 348 return 0;
274 349
275 switch (ob1->type) 350 switch (ob1->type)
276 { 351 {
277 case SCROLL: 352 case SCROLL:
323 { 398 {
324 // see if we are in a container of sorts 399 // see if we are in a container of sorts
325 if (env) 400 if (env)
326 { 401 {
327 // the player inventory itself is always visible 402 // the player inventory itself is always visible
328 if (env->type == PLAYER) 403 if (env->is_player ())
329 return env; 404 return env;
330 405
331 // else a player could have our env open 406 // else a player could have our env open
332 object *envest = env->outer_env (); 407 object *envest = env->outer_env_or_self ();
333 408
334 // the player itself is always on a map, so we will find him here 409 // the player itself is always on a map, so we will find him here
335 // even if our inv is in a player. 410 // even if our inv is in a player.
336 if (envest->is_on_map ()) 411 if (envest->is_on_map ())
337 if (object *pl = envest->ms ().player ()) 412 if (object *pl = envest->ms ().player ())
338 if (pl->container == env) 413 if (pl->container_ () == env)
339 return pl; 414 return pl;
340 } 415 }
341 else 416 else
342 { 417 {
343 // maybe there is a player standing on the same mapspace 418 // maybe there is a player standing on the same mapspace
344 // this will catch the case where "this" is a player 419 // this will catch the case where "this" is a player
345 if (object *pl = ms ().player ()) 420 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look) 421 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
347 || this == pl->container) 422 || pl->container_ () == this)
348 return pl; 423 return pl;
349 } 424 }
350 } 425 }
351 426
352 return 0; 427 return 0;
353} 428}
354 429
355// adjust weight per container type ("of holding") 430// adjust weight per container type ("of holding")
356static sint32 431static uint32
357weight_adjust_for (object *op, sint32 weight) 432weight_adjust_for (object *op, uint32 weight)
358{ 433{
359 return op->type == CONTAINER 434 return op->type == CONTAINER
360 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 435 ? weight - weight * op->stats.Str / 100
361 : weight; 436 : weight;
362} 437}
363 438
364/* 439/*
365 * adjust_weight(object, weight) adds the specified weight to an object, 440 * subtracts, then adds, the specified weight to an object,
366 * and also updates how much the environment(s) is/are carrying. 441 * and also updates how much the environment(s) is/are carrying.
367 */ 442 */
368static void 443static void
369adjust_weight (object *op, sint32 weight) 444adjust_weight (object *op, sint32 sub, sint32 add)
370{ 445{
371 while (op) 446 while (op)
372 { 447 {
373 // adjust by actual difference to account for rounding errors 448 sint32 ocarrying = op->carrying;
374 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
375 weight = weight_adjust_for (op, op->carrying)
376 - weight_adjust_for (op, op->carrying - weight);
377 449
378 if (!weight) 450 op->carrying -= weight_adjust_for (op, sub);
379 return; 451 op->carrying += weight_adjust_for (op, add);
380
381 op->carrying += weight;
382 452
383 if (object *pl = op->visible_to ()) 453 if (object *pl = op->visible_to ())
384 if (pl != op) // player is handled lazily 454 if (pl != op) // player is handled lazily
385 esrv_update_item (UPD_WEIGHT, pl, op); 455 esrv_update_item (UPD_WEIGHT, pl, op);
386 456
457 sub = ocarrying;
458 add = op->carrying;
459
387 op = op->env; 460 op = op->env;
388 } 461 }
389} 462}
390 463
391/* 464/*
398{ 471{
399 sint32 sum = 0; 472 sint32 sum = 0;
400 473
401 for (object *op = inv; op; op = op->below) 474 for (object *op = inv; op; op = op->below)
402 { 475 {
403 if (op->inv)
404 op->update_weight (); 476 op->update_weight ();
405 477
406 sum += op->total_weight (); 478 sum += weight_adjust_for (this, op->total_weight ());
407 } 479 }
408
409 sum = weight_adjust_for (this, sum);
410 480
411 if (sum != carrying) 481 if (sum != carrying)
412 { 482 {
483 if (carrying != sum && carrying)//D
484 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
485 (long long)sum, (long long)carrying, debug_desc ());
486
413 carrying = sum; 487 carrying = sum;
414 488
415 if (object *pl = visible_to ()) 489 if (object *pl = visible_to ())
416 if (pl != this) // player is handled lazily 490 if (pl != this) // player is handled lazily
417 esrv_update_item (UPD_WEIGHT, pl, this); 491 esrv_update_item (UPD_WEIGHT, pl, this);
430 object_freezer freezer; 504 object_freezer freezer;
431 op->write (freezer); 505 op->write (freezer);
432 return freezer.as_string (); 506 return freezer.as_string ();
433} 507}
434 508
435/* 509char *
436 * get_nearest_part(multi-object, object 2) returns the part of the 510object::as_string ()
437 * multi-object 1 which is closest to the second object.
438 * If it's not a multi-object, it is returned.
439 */
440object *
441get_nearest_part (object *op, const object *pl)
442{ 511{
443 object *tmp, *closest; 512 return dump_object (this);
444 int last_dist, i;
445
446 if (!op->more)
447 return op;
448
449 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
450 tmp;
451 tmp = tmp->more)
452 if ((i = distance (tmp, pl)) < last_dist)
453 closest = tmp, last_dist = i;
454
455 return closest;
456} 513}
457 514
458/* 515/*
459 * Returns the object which has the count-variable equal to the argument. 516 * Returns the object which has the count-variable equal to the argument.
460 * VERRRY slow. 517 * VERRRY slow.
462object * 519object *
463find_object (tag_t i) 520find_object (tag_t i)
464{ 521{
465 for_all_objects (op) 522 for_all_objects (op)
466 if (op->count == i) 523 if (op->count == i)
524 return op;
525
526 return 0;
527}
528
529/*
530 * Returns the object which has the uuid equal to the argument.
531 * MOAR VERRRY slow.
532 */
533
534object *
535find_object_uuid (UUID i)
536{
537 for_all_objects (op)
538 if (op->uuid == i)
467 return op; 539 return op;
468 540
469 return 0; 541 return 0;
470} 542}
471 543
505 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ()); 577 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
506 return; 578 return;
507 } 579 }
508 580
509 this->owner = owner; 581 this->owner = owner;
510}
511
512int
513object::slottype () const
514{
515 if (type == SKILL)
516 {
517 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
518 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
519 }
520 else
521 {
522 if (slot [body_combat].info) return slot_combat;
523 if (slot [body_range ].info) return slot_ranged;
524 }
525
526 return slot_none;
527}
528
529bool
530object::change_weapon (object *ob)
531{
532 if (current_weapon == ob)
533 return true;
534
535 if (chosen_skill)
536 chosen_skill->flag [FLAG_APPLIED] = false;
537
538 current_weapon = ob;
539 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
540
541 if (chosen_skill)
542 chosen_skill->flag [FLAG_APPLIED] = true;
543
544 update_stats ();
545
546 if (ob)
547 {
548 // now check wether any body locations became invalid, in which case
549 // we cannot apply the weapon at the moment.
550 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
551 if (slot[i].used < 0)
552 {
553 current_weapon = chosen_skill = 0;
554 update_stats ();
555
556 new_draw_info_format (NDI_UNIQUE, 0, this,
557 "You try to balance all your items at once, "
558 "but the %s is just too much for your body. "
559 "[You need to unapply some items first.]", &ob->name);
560 return false;
561 }
562
563 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
564 }
565 else
566 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
567
568 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
569 {
570 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
571 &name, ob->debug_desc ());
572 return false;
573 }
574
575 return true;
576} 582}
577 583
578/* Zero the key_values on op, decrementing the shared-string 584/* Zero the key_values on op, decrementing the shared-string
579 * refcounts and freeing the links. 585 * refcounts and freeing the links.
580 */ 586 */
633 tail = new_link; 639 tail = new_link;
634 } 640 }
635 } 641 }
636 } 642 }
637 643
638 if (speed < 0)
639 dst->speed_left -= rndm ();
640
641 dst->activate (); 644 dst->activate ();
642} 645}
643 646
644void 647void
645object::instantiate () 648object::instantiate ()
646{ 649{
647 if (!uuid.seq) // HACK 650 if (!uuid.seq) // HACK
648 uuid = UUID::gen (); 651 uuid = UUID::gen ();
649 652
653 // TODO: unclean state changes, should nt be done in copy_to AND instantiate
654 if (flag [FLAG_RANDOM_SPEED] && speed)
655 speed_left = - speed - rndm (); // TODO animation
656 else
650 speed_left = -0.1f; 657 speed_left = -1.;
658
651 /* copy the body_info to the body_used - this is only really 659 /* copy the body_info to the body_used - this is only really
652 * need for monsters, but doesn't hurt to do it for everything. 660 * need for monsters, but doesn't hurt to do it for everything.
653 * by doing so, when a monster is created, it has good starting 661 * by doing so, when a monster is created, it has good starting
654 * values for the body_used info, so when items are created 662 * values for the body_used info, so when items are created
655 * for it, they can be properly equipped. 663 * for it, they can be properly equipped.
663object * 671object *
664object::clone () 672object::clone ()
665{ 673{
666 object *neu = create (); 674 object *neu = create ();
667 copy_to (neu); 675 copy_to (neu);
676
677 // TODO: unclean state changes, should not be done in clone AND instantiate
678 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
679 neu->speed_left = - neu->speed - rndm (); // TODO animation
680
668 neu->map = map; // not copied by copy_to 681 neu->map = map; // not copied by copy_to
669 return neu; 682 return neu;
670} 683}
671 684
672/* 685/*
675 * be called to update the face variable, _and_ how it looks on the map. 688 * be called to update the face variable, _and_ how it looks on the map.
676 */ 689 */
677void 690void
678update_turn_face (object *op) 691update_turn_face (object *op)
679{ 692{
680 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 693 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
681 return; 694 return;
682 695
683 SET_ANIMATION (op, op->direction); 696 SET_ANIMATION (op, op->direction);
684 update_object (op, UP_OBJ_FACE); 697 update_object (op, UP_OBJ_FACE);
685} 698}
690 * This function needs to be called whenever the speed of an object changes. 703 * This function needs to be called whenever the speed of an object changes.
691 */ 704 */
692void 705void
693object::set_speed (float speed) 706object::set_speed (float speed)
694{ 707{
695 if (flag [FLAG_FREED] && speed)
696 {
697 LOG (llevError, "Object %s is freed but has speed.\n", &name);
698 speed = 0;
699 }
700
701 this->speed = speed; 708 this->speed = speed;
702 709
703 if (has_active_speed ()) 710 if (has_active_speed ())
704 activate (); 711 activate ();
705 else 712 else
755 762
756 if (!(m.flags_ & P_UPTODATE)) 763 if (!(m.flags_ & P_UPTODATE))
757 /* nop */; 764 /* nop */;
758 else if (action == UP_OBJ_INSERT) 765 else if (action == UP_OBJ_INSERT)
759 { 766 {
767#if 0
760 // this is likely overkill, TODO: revisit (schmorp) 768 // this is likely overkill, TODO: revisit (schmorp)
761 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 769 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
762 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 770 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
763 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 771 || (op->is_player () && !(m.flags_ & P_PLAYER))
764 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 772 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
765 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 773 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 774 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
767 || (m.move_on | op->move_on ) != m.move_on 775 || (m.move_on | op->move_on ) != m.move_on
768 || (m.move_off | op->move_off ) != m.move_off 776 || (m.move_off | op->move_off ) != m.move_off
769 || (m.move_slow | op->move_slow) != m.move_slow 777 || (m.move_slow | op->move_slow) != m.move_slow
770 /* This isn't perfect, but I don't expect a lot of objects to 778 /* This isn't perfect, but I don't expect a lot of objects to
771 * have move_allow right now. 779 * have move_allow right now.
772 */ 780 */
773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 781 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
782 m.invalidate ();
783#else
774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 784 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
775 m.flags_ = 0; 785 m.invalidate ();
786#endif
776 } 787 }
777 /* if the object is being removed, we can't make intelligent 788 /* if the object is being removed, we can't make intelligent
778 * decisions, because remove_ob can't really pass the object 789 * decisions, because remove_ob can't really pass the object
779 * that is being removed. 790 * that is being removed.
780 */ 791 */
781 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 792 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
782 m.flags_ = 0; 793 m.invalidate ();
783 else if (action == UP_OBJ_FACE) 794 else if (action == UP_OBJ_FACE)
784 /* Nothing to do for that case */ ; 795 /* Nothing to do for that case */ ;
785 else 796 else
786 LOG (llevError, "update_object called with invalid action: %d\n", action); 797 LOG (llevError, "update_object called with invalid action: %d\n", action);
787 798
789 update_object (op->more, action); 800 update_object (op->more, action);
790} 801}
791 802
792object::object () 803object::object ()
793{ 804{
794 SET_FLAG (this, FLAG_REMOVED); 805 this->set_flag (FLAG_REMOVED);
795 806
796 expmul = 1.0; 807 //expmul = 1.0; declared const for the time being
797 face = blank_face; 808 face = blank_face;
809 material = MATERIAL_NULL;
798} 810}
799 811
800object::~object () 812object::~object ()
801{ 813{
802 unlink (); 814 unlink ();
803 815
804 free_key_values (this); 816 free_key_values (this);
805} 817}
806
807static int object_count;
808 818
809void object::link () 819void object::link ()
810{ 820{
811 assert (!index);//D 821 assert (!index);//D
812 uuid = UUID::gen (); 822 uuid = UUID::gen ();
813 count = ++object_count;
814 823
815 refcnt_inc (); 824 refcnt_inc ();
816 objects.insert (this); 825 objects.insert (this);
826
827 ++create_count;
828
817} 829}
818 830
819void object::unlink () 831void object::unlink ()
820{ 832{
821 if (!index) 833 if (!index)
822 return; 834 return;
835
836 ++destroy_count;
823 837
824 objects.erase (this); 838 objects.erase (this);
825 refcnt_dec (); 839 refcnt_dec ();
826} 840}
827 841
830{ 844{
831 /* If already on active list, don't do anything */ 845 /* If already on active list, don't do anything */
832 if (active) 846 if (active)
833 return; 847 return;
834 848
835 if (has_active_speed () && flag [FLAG_FREED ]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
836
837 if (has_active_speed ()) 849 if (has_active_speed ())
850 {
851 if (flag [FLAG_FREED])
852 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
853
838 actives.insert (this); 854 actives.insert (this);
855 }
839} 856}
840 857
841void 858void
842object::activate_recursive () 859object::activate_recursive ()
843{ 860{
908 || map->in_memory != MAP_ACTIVE 925 || map->in_memory != MAP_ACTIVE
909 || map->no_drop 926 || map->no_drop
910 || ms ().move_block == MOVE_ALL) 927 || ms ().move_block == MOVE_ALL)
911 { 928 {
912 while (inv) 929 while (inv)
913 inv->destroy (true); 930 inv->destroy ();
914 } 931 }
915 else 932 else
916 { /* Put objects in inventory onto this space */ 933 { /* Put objects in inventory onto this space */
917 while (inv) 934 while (inv)
918 { 935 {
922 || op->flag [FLAG_NO_DROP] 939 || op->flag [FLAG_NO_DROP]
923 || op->type == RUNE 940 || op->type == RUNE
924 || op->type == TRAP 941 || op->type == TRAP
925 || op->flag [FLAG_IS_A_TEMPLATE] 942 || op->flag [FLAG_IS_A_TEMPLATE]
926 || op->flag [FLAG_DESTROY_ON_DEATH]) 943 || op->flag [FLAG_DESTROY_ON_DEATH])
927 op->destroy (true); 944 op->destroy ();
928 else 945 else
929 map->insert (op, x, y); 946 map->insert (op, x, y);
930 } 947 }
931 } 948 }
932} 949}
933 950
951/*
952 * Remove and free all objects in the inventory of the given object.
953 * Unlike destroy_inv, this assumes the *this is destroyed as well
954 * well, so we can (and have to!) take shortcuts.
955 */
956void
957object::destroy_inv_fast ()
958{
959 while (object *op = inv)
960 {
961 // remove from object the fast way
962 op->flag [FLAG_REMOVED] = true;
963 op->env = 0;
964 if ((inv = inv->below))
965 inv->above = 0;
966
967 // then destroy
968 op->destroy ();
969 }
970}
971
972void
973object::freelist_free (int count)
974{
975 while (count-- && freelist)
976 {
977 freelist_item *next = freelist->next;
978 // count is being "destroyed"
979
980 sfree ((char *)freelist, sizeof (object));
981
982 freelist = next;
983 --free_count;
984 }
985}
986
987object *
934object *object::create () 988object::create ()
935{ 989{
936 object *op = new object; 990 object *op;
991
992 if (freelist)
993 {
994 freelist_item li = *freelist;
995 memset (freelist, 0, sizeof (object));
996
997 op = new (freelist) object;
998 op->count = li.count;
999
1000 freelist = li.next;
1001 --free_count;
1002 }
1003 else
1004 {
1005 void *ni = salloc0<char> (sizeof (object));
1006
1007 op = new(ni) object;
1008
1009 op->count = ++object_count;
1010 }
1011
937 op->link (); 1012 op->link ();
1013
938 return op; 1014 return op;
939} 1015}
940 1016
1017void
1018object::do_delete ()
1019{
1020 uint32_t count = this->count;
1021
1022 this->~object ();
1023
1024 freelist_item *li = (freelist_item *)this;
1025 li->next = freelist;
1026 li->count = count;
1027
1028 freelist = li;
1029 ++free_count;
1030}
1031
941static struct freed_map : maptile 1032static struct freed_map : maptile
942{ 1033{
943 freed_map () 1034 freed_map ()
1035 : maptile (3, 3)
944 { 1036 {
945 path = "<freed objects map>"; 1037 path = "<freed objects map>";
946 name = "/internal/freed_objects_map"; 1038 name = "/internal/freed_objects_map";
947 width = 3;
948 height = 3;
949 no_drop = 1; 1039 no_drop = 1;
950 no_reset = 1; 1040 no_reset = 1;
951 1041
952 alloc ();
953 in_memory = MAP_ACTIVE; 1042 in_memory = MAP_ACTIVE;
954 } 1043 }
955 1044
956 ~freed_map () 1045 ~freed_map ()
957 { 1046 {
961 1050
962void 1051void
963object::do_destroy () 1052object::do_destroy ()
964{ 1053{
965 if (flag [FLAG_IS_LINKED]) 1054 if (flag [FLAG_IS_LINKED])
966 remove_button_link (this); 1055 remove_link ();
967 1056
968 if (flag [FLAG_FRIENDLY]) 1057 if (flag [FLAG_FRIENDLY])
969 remove_friendly_object (this); 1058 remove_friendly_object (this);
970 1059
971 remove (); 1060 remove ();
996 attacked_by = 0; 1085 attacked_by = 0;
997 current_weapon = 0; 1086 current_weapon = 0;
998} 1087}
999 1088
1000void 1089void
1001object::destroy (bool destroy_inventory) 1090object::destroy ()
1002{ 1091{
1003 if (destroyed ()) 1092 if (destroyed ())
1004 return; 1093 return;
1005 1094
1006 if (!is_head () && !head->destroyed ()) 1095 if (!is_head () && !head->destroyed ())
1007 { 1096 {
1008 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1097 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1009 head->destroy (destroy_inventory); 1098 head->destroy ();
1010 return; 1099 return;
1011 } 1100 }
1012 1101
1013 destroy_inv (!destroy_inventory); 1102 destroy_inv_fast ();
1014 1103
1015 if (is_head ()) 1104 if (is_head ())
1016 if (sound_destroy) 1105 if (sound_destroy)
1017 play_sound (sound_destroy); 1106 play_sound (sound_destroy);
1018 else if (flag [FLAG_MONSTER]) 1107 else if (flag [FLAG_MONSTER])
1029 * the previous environment. 1118 * the previous environment.
1030 */ 1119 */
1031void 1120void
1032object::do_remove () 1121object::do_remove ()
1033{ 1122{
1034 object *tmp, *last = 0;
1035 object *otmp;
1036
1037 if (flag [FLAG_REMOVED]) 1123 if (flag [FLAG_REMOVED])
1038 return; 1124 return;
1039 1125
1040 INVOKE_OBJECT (REMOVE, this); 1126 INVOKE_OBJECT (REMOVE, this);
1041 1127
1053 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed 1139 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1054 if (object *pl = visible_to ()) 1140 if (object *pl = visible_to ())
1055 esrv_del_item (pl->contr, count); 1141 esrv_del_item (pl->contr, count);
1056 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1142 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1057 1143
1058 adjust_weight (env, -total_weight ()); 1144 adjust_weight (env, total_weight (), 0);
1145
1146 object *pl = in_player ();
1059 1147
1060 /* we set up values so that it could be inserted into 1148 /* we set up values so that it could be inserted into
1061 * the map, but we don't actually do that - it is up 1149 * the map, but we don't actually do that - it is up
1062 * to the caller to decide what we want to do. 1150 * to the caller to decide what we want to do.
1063 */ 1151 */
1071 1159
1072 above = 0; 1160 above = 0;
1073 below = 0; 1161 below = 0;
1074 env = 0; 1162 env = 0;
1075 1163
1076 /* NO_FIX_PLAYER is set when a great many changes are being 1164 if (pl && pl->is_player ())
1077 * made to players inventory. If set, avoiding the call
1078 * to save cpu time.
1079 */ 1165 {
1080 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1166 if (expect_false (pl->contr->combat_ob == this))
1081 otmp->update_stats (); 1167 {
1168 pl->apply (pl->contr->combat_ob, AP_UNAPPLY);
1169 pl->contr->combat_ob = 0;
1170 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1171 }
1172
1173 if (expect_false (pl->contr->ranged_ob == this))
1174 {
1175 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY);
1176 pl->contr->ranged_ob = 0;
1177 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1178 }
1179
1180 pl->contr->queue_stats_update ();
1181
1182 if (expect_false (glow_radius) && pl->is_on_map ())
1183 update_all_los (pl->map, pl->x, pl->y);
1184 }
1082 } 1185 }
1083 else if (map) 1186 else if (map)
1084 { 1187 {
1085 map->dirty = true; 1188 map->dirty = true;
1086 mapspace &ms = this->ms (); 1189 mapspace &ms = this->ms ();
1087 1190
1088 if (object *pl = ms.player ()) 1191 if (object *pl = ms.player ())
1089 { 1192 {
1090 if (type == PLAYER) // this == pl(!) 1193 if (is_player ())
1091 { 1194 {
1195 if (!flag [FLAG_WIZPASS])
1196 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1197
1092 // leaving a spot always closes any open container on the ground 1198 // leaving a spot always closes any open container on the ground
1093 if (container && !container->env) 1199 if (container && !container->env)
1094 // this causes spurious floorbox updates, but it ensures 1200 // this causes spurious floorbox updates, but it ensures
1095 // that the CLOSE event is being sent. 1201 // that the CLOSE event is being sent.
1096 close_container (); 1202 close_container ();
1097 1203
1098 --map->players; 1204 --map->players;
1099 map->touch (); 1205 map->touch ();
1100 } 1206 }
1101 else if (pl->container == this) 1207 else if (pl->container_ () == this)
1102 { 1208 {
1103 // removing a container should close it 1209 // removing a container should close it
1104 close_container (); 1210 close_container ();
1105 } 1211 }
1106 1212 else
1107 esrv_del_item (pl->contr, count); 1213 esrv_del_item (pl->contr, count);
1108 } 1214 }
1109 1215
1110 /* link the object above us */ 1216 /* link the object above us */
1111 // re-link, make sure compiler can easily use cmove 1217 // re-link, make sure compiler can easily use cmove
1112 *(above ? &above->below : &ms.top) = below; 1218 *(above ? &above->below : &ms.top) = below;
1113 *(below ? &below->above : &ms.bot) = above; 1219 *(below ? &below->above : &ms.bot) = above;
1114 1220
1115 above = 0; 1221 above = 0;
1116 below = 0; 1222 below = 0;
1117 1223
1118 ms.flags_ = 0; 1224 ms.invalidate ();
1119 1225
1120 if (map->in_memory == MAP_SAVING) 1226 if (map->in_memory == MAP_SAVING)
1121 return; 1227 return;
1122 1228
1123 int check_walk_off = !flag [FLAG_NO_APPLY]; 1229 int check_walk_off = !flag [FLAG_NO_APPLY];
1124 1230
1125 if (object *pl = ms.player ()) 1231 if (object *pl = ms.player ())
1126 { 1232 {
1127 if (pl->container == this) 1233 if (pl->container_ () == this)
1128 /* If a container that the player is currently using somehow gets 1234 /* If a container that the player is currently using somehow gets
1129 * removed (most likely destroyed), update the player view 1235 * removed (most likely destroyed), update the player view
1130 * appropriately. 1236 * appropriately.
1131 */ 1237 */
1132 pl->close_container (); 1238 pl->close_container ();
1136 //TODO: update floorbox to preserve ordering 1242 //TODO: update floorbox to preserve ordering
1137 if (pl->contr->ns) 1243 if (pl->contr->ns)
1138 pl->contr->ns->floorbox_update (); 1244 pl->contr->ns->floorbox_update ();
1139 } 1245 }
1140 1246
1247 if (check_walk_off)
1141 for (tmp = ms.bot; tmp; tmp = tmp->above) 1248 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1142 { 1249 {
1250 above = tmp->above;
1251
1143 /* No point updating the players look faces if he is the object 1252 /* No point updating the players look faces if he is the object
1144 * being removed. 1253 * being removed.
1145 */ 1254 */
1146 1255
1147 /* See if object moving off should effect something */ 1256 /* See if object moving off should effect something */
1148 if (check_walk_off
1149 && ((move_type & tmp->move_off) 1257 if ((move_type & tmp->move_off)
1150 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1258 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1151 {
1152 move_apply (tmp, this, 0); 1259 move_apply (tmp, this, 0);
1153
1154 if (destroyed ())
1155 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1156 } 1260 }
1157 1261
1158 last = tmp; 1262 if (affects_los ())
1159 }
1160
1161 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1162 update_all_los (map, x, y); 1263 update_all_los (map, x, y);
1163 } 1264 }
1164} 1265}
1165 1266
1166/* 1267/*
1190 esrv_update_item (UPD_NROF, pl, top); 1291 esrv_update_item (UPD_NROF, pl, top);
1191 1292
1192 op->weight = 0; // cancel the addition above 1293 op->weight = 0; // cancel the addition above
1193 op->carrying = 0; // must be 0 already 1294 op->carrying = 0; // must be 0 already
1194 1295
1195 op->destroy (1); 1296 op->destroy ();
1196 1297
1197 return top; 1298 return top;
1198 } 1299 }
1199 1300
1200 return 0; 1301 return 0;
1208 1309
1209 object *prev = this; 1310 object *prev = this;
1210 1311
1211 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1312 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1212 { 1313 {
1213 object *op = arch_to_object (at); 1314 object *op = at->instance ();
1214 1315
1215 op->name = name; 1316 op->name = name;
1216 op->name_pl = name_pl; 1317 op->name_pl = name_pl;
1217 op->title = title; 1318 op->title = title;
1218 1319
1256 * Passing 0 for flag gives proper default values, so flag really only needs 1357 * Passing 0 for flag gives proper default values, so flag really only needs
1257 * to be set if special handling is needed. 1358 * to be set if special handling is needed.
1258 * 1359 *
1259 * Return value: 1360 * Return value:
1260 * new object if 'op' was merged with other object 1361 * new object if 'op' was merged with other object
1261 * NULL if 'op' was destroyed 1362 * NULL if there was an error (destroyed, blocked etc.)
1262 * just 'op' otherwise 1363 * just 'op' otherwise
1263 */ 1364 */
1264object * 1365object *
1265insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1366insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1266{ 1367{
1267 if (op->is_on_map ())
1268 {
1269 LOG (llevError, "insert_ob_in_map called for object already on map");
1270 abort ();
1271 }
1272
1273 if (op->env)
1274 {
1275 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1276 op->remove (); 1368 op->remove ();
1277 }
1278 1369
1279 if (op->face && !face_info (op->face))//D TODO: remove soon 1370 if (m == &freed_map)//D TODO: remove soon
1280 {//D 1371 {//D
1281 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D 1372 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1282 op->face = 1;//D
1283 }//D 1373 }//D
1284 1374
1285 /* Ideally, the caller figures this out. However, it complicates a lot 1375 /* Ideally, the caller figures this out. However, it complicates a lot
1286 * of areas of callers (eg, anything that uses find_free_spot would now 1376 * of areas of callers (eg, anything that uses find_free_spot would now
1287 * need extra work 1377 * need extra work
1288 */ 1378 */
1379 maptile *newmap = m;
1289 if (!xy_normalise (m, op->x, op->y)) 1380 if (!xy_normalise (newmap, op->x, op->y))
1290 { 1381 {
1291 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found 1382 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1292 return 0; 1383 return 0;
1293 } 1384 }
1294 1385
1295 if (object *more = op->more) 1386 if (object *more = op->more)
1296 if (!insert_ob_in_map (more, m, originator, flag)) 1387 if (!insert_ob_in_map (more, m, originator, flag))
1297 return 0; 1388 return 0;
1298 1389
1299 CLEAR_FLAG (op, FLAG_REMOVED); 1390 op->flag [FLAG_REMOVED] = false;
1300 1391 op->env = 0;
1301 op->map = m; 1392 op->map = newmap;
1393
1302 mapspace &ms = op->ms (); 1394 mapspace &ms = op->ms ();
1303 1395
1304 /* this has to be done after we translate the coordinates. 1396 /* this has to be done after we translate the coordinates.
1305 */ 1397 */
1306 if (op->nrof && !(flag & INS_NO_MERGE)) 1398 if (op->nrof && !(flag & INS_NO_MERGE))
1309 { 1401 {
1310 // TODO: we actually want to update tmp, not op, 1402 // TODO: we actually want to update tmp, not op,
1311 // but some caller surely breaks when we return tmp 1403 // but some caller surely breaks when we return tmp
1312 // from here :/ 1404 // from here :/
1313 op->nrof += tmp->nrof; 1405 op->nrof += tmp->nrof;
1314 tmp->destroy (1); 1406 tmp->destroy ();
1315 } 1407 }
1316 1408
1317 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1409 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1318 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1410 op->clr_flag (FLAG_INV_LOCKED);
1319 1411
1320 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1412 if (!op->flag [FLAG_ALIVE])
1321 CLEAR_FLAG (op, FLAG_NO_STEAL); 1413 op->clr_flag (FLAG_NO_STEAL);
1322 1414
1323 if (flag & INS_BELOW_ORIGINATOR) 1415 if (flag & INS_BELOW_ORIGINATOR)
1324 { 1416 {
1325 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1417 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1326 { 1418 {
1327 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1419 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1328 abort (); 1420 abort ();
1329 } 1421 }
1330 1422
1331 if (!originator->is_on_map ()) 1423 if (!originator->is_on_map ())
1424 {
1332 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map", 1425 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1333 op->debug_desc (), originator->debug_desc ()); 1426 op->debug_desc (), originator->debug_desc ());
1427 abort ();
1428 }
1334 1429
1335 op->above = originator; 1430 op->above = originator;
1336 op->below = originator->below; 1431 op->below = originator->below;
1337 originator->below = op; 1432 originator->below = op;
1338 1433
1358 * when lots of spells are cast in one area. Currently, it is presumed 1453 * when lots of spells are cast in one area. Currently, it is presumed
1359 * that flying non pickable objects are spell objects. 1454 * that flying non pickable objects are spell objects.
1360 */ 1455 */
1361 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1456 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1362 { 1457 {
1363 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR)) 1458 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1364 floor = tmp; 1459 floor = tmp;
1365 1460
1366 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 1461 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1367 { 1462 {
1368 /* We insert above top, so we want this object below this */ 1463 /* We insert above top, so we want this object below this */
1369 top = tmp->below; 1464 top = tmp->below;
1370 break; 1465 break;
1371 } 1466 }
1389 && (op->face && !faces [op->face].visibility)) 1484 && (op->face && !faces [op->face].visibility))
1390 { 1485 {
1391 object *last; 1486 object *last;
1392 1487
1393 for (last = top; last != floor; last = last->below) 1488 for (last = top; last != floor; last = last->below)
1394 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1489 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1395 break; 1490 break;
1396 1491
1397 /* Check to see if we found the object that blocks view, 1492 /* Check to see if we found the object that blocks view,
1398 * and make sure we have a below pointer for it so that 1493 * and make sure we have a below pointer for it so that
1399 * we can get inserted below this one, which requires we 1494 * we can get inserted below this one, which requires we
1424 op->below = top; 1519 op->below = top;
1425 *(op->above ? &op->above->below : &ms.top) = op; 1520 *(op->above ? &op->above->below : &ms.top) = op;
1426 } 1521 }
1427 } 1522 }
1428 1523
1429 if (op->type == PLAYER) 1524 if (op->is_player ())
1430 { 1525 {
1431 op->contr->do_los = 1; 1526 op->contr->do_los = 1;
1432 ++op->map->players; 1527 ++op->map->players;
1433 op->map->touch (); 1528 op->map->touch ();
1434 } 1529 }
1449 * be far away from this change and not affected in any way - 1544 * be far away from this change and not affected in any way -
1450 * this should get redone to only look for players within range, 1545 * this should get redone to only look for players within range,
1451 * or just updating the P_UPTODATE for spaces within this area 1546 * or just updating the P_UPTODATE for spaces within this area
1452 * of effect may be sufficient. 1547 * of effect may be sufficient.
1453 */ 1548 */
1454 if (op->map->darkness && (op->glow_radius != 0)) 1549 if (op->affects_los ())
1550 {
1551 op->ms ().invalidate ();
1455 update_all_los (op->map, op->x, op->y); 1552 update_all_los (op->map, op->x, op->y);
1553 }
1456 1554
1457 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1555 /* updates flags (blocked, alive, no magic, etc) for this map space */
1458 update_object (op, UP_OBJ_INSERT); 1556 update_object (op, UP_OBJ_INSERT);
1459 1557
1460 INVOKE_OBJECT (INSERT, op); 1558 INVOKE_OBJECT (INSERT, op);
1467 * blocked() and wall() work properly), and these flags are updated by 1565 * blocked() and wall() work properly), and these flags are updated by
1468 * update_object(). 1566 * update_object().
1469 */ 1567 */
1470 1568
1471 /* if this is not the head or flag has been passed, don't check walk on status */ 1569 /* if this is not the head or flag has been passed, don't check walk on status */
1472 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1570 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1473 { 1571 {
1474 if (check_move_on (op, originator)) 1572 if (check_move_on (op, originator, flag))
1475 return 0; 1573 return 0;
1476 1574
1477 /* If we are a multi part object, lets work our way through the check 1575 /* If we are a multi part object, let's work our way through the check
1478 * walk on's. 1576 * walk on's.
1479 */ 1577 */
1480 for (object *tmp = op->more; tmp; tmp = tmp->more) 1578 for (object *tmp = op->more; tmp; tmp = tmp->more)
1481 if (check_move_on (tmp, originator)) 1579 if (check_move_on (tmp, originator, flag))
1482 return 0; 1580 return 0;
1483 } 1581 }
1484 1582
1485 return op; 1583 return op;
1486} 1584}
1488/* this function inserts an object in the map, but if it 1586/* this function inserts an object in the map, but if it
1489 * finds an object of its own type, it'll remove that one first. 1587 * finds an object of its own type, it'll remove that one first.
1490 * op is the object to insert it under: supplies x and the map. 1588 * op is the object to insert it under: supplies x and the map.
1491 */ 1589 */
1492void 1590void
1493replace_insert_ob_in_map (const char *arch_string, object *op) 1591replace_insert_ob_in_map (shstr_tmp archname, object *op)
1494{ 1592{
1495 /* first search for itself and remove any old instances */ 1593 /* first search for itself and remove any old instances */
1496 1594
1497 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1595 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1498 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1596 if (tmp->arch->archname == archname) /* same archetype */
1499 tmp->destroy (1); 1597 tmp->destroy ();
1500 1598
1501 object *tmp = arch_to_object (archetype::find (arch_string)); 1599 object *tmp = archetype::find (archname)->instance ();
1502 1600
1503 tmp->x = op->x; 1601 tmp->x = op->x;
1504 tmp->y = op->y; 1602 tmp->y = op->y;
1505 1603
1506 insert_ob_in_map (tmp, op->map, op, 0); 1604 insert_ob_in_map (tmp, op->map, op, 0);
1511{ 1609{
1512 if (where->env) 1610 if (where->env)
1513 return where->env->insert (this); 1611 return where->env->insert (this);
1514 else 1612 else
1515 return where->map->insert (this, where->x, where->y, originator, flags); 1613 return where->map->insert (this, where->x, where->y, originator, flags);
1614}
1615
1616// check whether we can put this into the map, respect max_volume, max_items
1617bool
1618object::can_drop_at (maptile *m, int x, int y, object *originator)
1619{
1620 mapspace &ms = m->at (x, y);
1621
1622 int items = ms.items ();
1623
1624 if (!items // testing !items ensures we can drop at least one item
1625 || (items < m->max_items
1626 && ms.volume () < m->max_volume))
1627 return true;
1628
1629 if (originator && originator->is_player ())
1630 originator->contr->failmsgf (
1631 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1632 query_name ()
1633 );
1634
1635 return false;
1516} 1636}
1517 1637
1518/* 1638/*
1519 * decrease(object, number) decreases a specified number from 1639 * decrease(object, number) decreases a specified number from
1520 * the amount of an object. If the amount reaches 0, the object 1640 * the amount of an object. If the amount reaches 0, the object
1530 1650
1531 nr = min (nr, nrof); 1651 nr = min (nr, nrof);
1532 1652
1533 if (nrof > nr) 1653 if (nrof > nr)
1534 { 1654 {
1655 sint64 oweight = total_weight ();
1656
1535 nrof -= nr; 1657 nrof -= nr;
1536 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1537 1658
1538 if (object *pl = visible_to ()) 1659 if (object *pl = visible_to ())
1539 esrv_update_item (UPD_NROF, pl, this); 1660 esrv_update_item (UPD_NROF, pl, this);
1661
1662 adjust_weight (env, oweight, total_weight ());
1540 1663
1541 return true; 1664 return true;
1542 } 1665 }
1543 else 1666 else
1544 { 1667 {
1619 if (op->nrof) 1742 if (op->nrof)
1620 for (object *tmp = inv; tmp; tmp = tmp->below) 1743 for (object *tmp = inv; tmp; tmp = tmp->below)
1621 if (object::can_merge (tmp, op)) 1744 if (object::can_merge (tmp, op))
1622 { 1745 {
1623 /* return the original object and remove inserted object 1746 /* return the original object and remove inserted object
1624 (client needs the original object) */ 1747 (client prefers the original object) */
1748
1749 // carring must be 0 for mergable objects
1750 sint64 oweight = tmp->weight * tmp->nrof;
1751
1625 tmp->nrof += op->nrof; 1752 tmp->nrof += op->nrof;
1626 1753
1627 if (object *pl = tmp->visible_to ()) 1754 if (object *pl = tmp->visible_to ())
1628 esrv_update_item (UPD_NROF, pl, tmp); 1755 esrv_update_item (UPD_NROF, pl, tmp);
1629 1756
1630 adjust_weight (this, op->total_weight ()); 1757 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1631 1758
1632 op->destroy (1); 1759 op->destroy ();
1633 op = tmp; 1760 op = tmp;
1634 goto inserted; 1761 goto inserted;
1635 } 1762 }
1636 1763
1637 op->owner = 0; // it's his/hers now. period. 1764 op->owner = 0; // it's his/hers now. period.
1651 op->flag [FLAG_REMOVED] = 0; 1778 op->flag [FLAG_REMOVED] = 0;
1652 1779
1653 if (object *pl = op->visible_to ()) 1780 if (object *pl = op->visible_to ())
1654 esrv_send_item (pl, op); 1781 esrv_send_item (pl, op);
1655 1782
1656 adjust_weight (this, op->total_weight ()); 1783 adjust_weight (this, 0, op->total_weight ());
1657 1784
1658inserted: 1785inserted:
1659 /* reset the light list and los of the players on the map */ 1786 /* reset the light list and los of the players on the map */
1660 if (op->glow_radius && map && map->darkness) 1787 if (op->glow_radius && is_on_map ())
1788 {
1789 update_stats ();
1661 update_all_los (map, x, y); 1790 update_all_los (map, x, y);
1662 1791 }
1792 else if (is_player ())
1663 // if this is a player's inventory, update stats 1793 // if this is a player's inventory, update stats
1664 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1794 contr->queue_stats_update ();
1665 update_stats ();
1666 1795
1667 INVOKE_OBJECT (INSERT, this); 1796 INVOKE_OBJECT (INSERT, this);
1668 1797
1669 return op; 1798 return op;
1670} 1799}
1688 * MSW 2001-07-08: Check all objects on space, not just those below 1817 * MSW 2001-07-08: Check all objects on space, not just those below
1689 * object being inserted. insert_ob_in_map may not put new objects 1818 * object being inserted. insert_ob_in_map may not put new objects
1690 * on top. 1819 * on top.
1691 */ 1820 */
1692int 1821int
1693check_move_on (object *op, object *originator) 1822check_move_on (object *op, object *originator, int flags)
1694{ 1823{
1824 if (op->flag [FLAG_NO_APPLY])
1825 return 0;
1826
1695 object *tmp; 1827 object *tmp;
1696 maptile *m = op->map; 1828 maptile *m = op->map;
1697 int x = op->x, y = op->y; 1829 int x = op->x, y = op->y;
1698 1830
1699 MoveType move_on, move_slow, move_block; 1831 mapspace &ms = m->at (x, y);
1700 1832
1701 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1833 ms.update ();
1702 return 0;
1703 1834
1704 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1835 MoveType move_on = ms.move_on;
1705 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1836 MoveType move_slow = ms.move_slow;
1706 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1837 MoveType move_block = ms.move_block;
1707 1838
1708 /* if nothing on this space will slow op down or be applied, 1839 /* if nothing on this space will slow op down or be applied,
1709 * no need to do checking below. have to make sure move_type 1840 * no need to do checking below. have to make sure move_type
1710 * is set, as lots of objects don't have it set - we treat that 1841 * is set, as lots of objects don't have it set - we treat that
1711 * as walking. 1842 * as walking.
1722 return 0; 1853 return 0;
1723 1854
1724 /* The objects have to be checked from top to bottom. 1855 /* The objects have to be checked from top to bottom.
1725 * Hence, we first go to the top: 1856 * Hence, we first go to the top:
1726 */ 1857 */
1727 1858 for (object *next, *tmp = ms.top; tmp; tmp = next)
1728 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1729 {
1730 /* Trim the search when we find the first other spell effect
1731 * this helps performance so that if a space has 50 spell objects,
1732 * we don't need to check all of them.
1733 */
1734 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1735 break;
1736 } 1859 {
1860 next = tmp->below;
1737 1861
1738 for (; tmp; tmp = tmp->below)
1739 {
1740 if (tmp == op) 1862 if (tmp == op)
1741 continue; /* Can't apply yourself */ 1863 continue; /* Can't apply yourself */
1742 1864
1743 /* Check to see if one of the movement types should be slowed down. 1865 /* Check to see if one of the movement types should be slowed down.
1744 * Second check makes sure that the movement types not being slowed 1866 * Second check makes sure that the movement types not being slowed
1745 * (~slow_move) is not blocked on this space - just because the 1867 * (~slow_move) is not blocked on this space - just because the
1746 * space doesn't slow down swimming (for example), if you can't actually 1868 * space doesn't slow down swimming (for example), if you can't actually
1747 * swim on that space, can't use it to avoid the penalty. 1869 * swim on that space, can't use it to avoid the penalty.
1748 */ 1870 */
1749 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1871 if (!op->flag [FLAG_WIZPASS])
1750 { 1872 {
1751 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1873 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1752 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1874 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1753 { 1875 {
1754
1755 float
1756 diff = tmp->move_slow_penalty * fabs (op->speed); 1876 float diff = tmp->move_slow_penalty * fabs (op->speed);
1757 1877
1758 if (op->type == PLAYER) 1878 if (op->is_player ())
1759 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1879 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1760 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1880 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1761 diff /= 4.0; 1881 diff /= 4.0;
1762 1882
1763 op->speed_left -= diff; 1883 op->speed_left -= diff;
1764 } 1884 }
1765 } 1885 }
1766 1886
1767 /* Basically same logic as above, except now for actual apply. */ 1887 /* Basically same logic as above, except now for actual apply. */
1768 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1888 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1769 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1889 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1770 { 1890 {
1891 if ((flags & INS_NO_AUTO_EXIT)
1892 && (tmp->type == EXIT || tmp->type == TELEPORTER
1893 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1894 continue;
1895
1771 move_apply (tmp, op, originator); 1896 move_apply (tmp, op, originator);
1772 1897
1773 if (op->destroyed ()) 1898 if (op->destroyed ())
1774 return 1; 1899 return 1;
1775 1900
1887void 2012void
1888flag_inv (object *op, int flag) 2013flag_inv (object *op, int flag)
1889{ 2014{
1890 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2015 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1891 { 2016 {
1892 SET_FLAG (tmp, flag); 2017 tmp->set_flag (flag);
1893 flag_inv (tmp, flag); 2018 flag_inv (tmp, flag);
1894 } 2019 }
1895} 2020}
1896 2021
1897/* 2022/*
1900void 2025void
1901unflag_inv (object *op, int flag) 2026unflag_inv (object *op, int flag)
1902{ 2027{
1903 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2028 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1904 { 2029 {
1905 CLEAR_FLAG (tmp, flag); 2030 tmp->clr_flag (flag);
1906 unflag_inv (tmp, flag); 2031 unflag_inv (tmp, flag);
1907 } 2032 }
1908} 2033}
1909 2034
1910/* 2035/*
1971 * head of the object should correspond for the entire object. 2096 * head of the object should correspond for the entire object.
1972 */ 2097 */
1973 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2098 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1974 continue; 2099 continue;
1975 2100
1976 if (ob->blocked (m, pos.x, pos.y)) 2101 if (ob->blocked (pos.m, pos.x, pos.y))
1977 continue; 2102 continue;
1978 2103
1979 altern [index++] = i; 2104 altern [index++] = i;
1980 } 2105 }
1981 2106
2049 * there is capable of. 2174 * there is capable of.
2050 */ 2175 */
2051int 2176int
2052find_dir (maptile *m, int x, int y, object *exclude) 2177find_dir (maptile *m, int x, int y, object *exclude)
2053{ 2178{
2054 int i, max = SIZEOFFREE, mflags; 2179 int max = SIZEOFFREE, mflags;
2055
2056 sint16 nx, ny;
2057 object *tmp;
2058 maptile *mp;
2059
2060 MoveType blocked, move_type; 2180 MoveType move_type;
2061 2181
2062 if (exclude && exclude->head_ () != exclude) 2182 if (exclude && exclude->head_ () != exclude)
2063 { 2183 {
2064 exclude = exclude->head; 2184 exclude = exclude->head;
2065 move_type = exclude->move_type; 2185 move_type = exclude->move_type;
2068 { 2188 {
2069 /* If we don't have anything, presume it can use all movement types. */ 2189 /* If we don't have anything, presume it can use all movement types. */
2070 move_type = MOVE_ALL; 2190 move_type = MOVE_ALL;
2071 } 2191 }
2072 2192
2073 for (i = 1; i < max; i++) 2193 for (int i = 1; i < max; i++)
2074 { 2194 {
2075 mp = m; 2195 mapxy pos (m, x, y);
2076 nx = x + freearr_x[i]; 2196 pos.move (i);
2077 ny = y + freearr_y[i];
2078 2197
2079 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2198 if (!pos.normalise ())
2080
2081 if (mflags & P_OUT_OF_MAP)
2082 max = maxfree[i]; 2199 max = maxfree[i];
2083 else 2200 else
2084 { 2201 {
2085 mapspace &ms = mp->at (nx, ny); 2202 mapspace &ms = *pos;
2086 2203
2087 blocked = ms.move_block;
2088
2089 if ((move_type & blocked) == move_type) 2204 if ((move_type & ms.move_block) == move_type)
2090 max = maxfree[i]; 2205 max = maxfree [i];
2091 else if (mflags & P_IS_ALIVE) 2206 else if (ms.flags () & P_IS_ALIVE)
2092 { 2207 {
2093 for (tmp = ms.bot; tmp; tmp = tmp->above) 2208 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2094 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2209 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2095 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2210 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2096 break;
2097
2098 if (tmp)
2099 return freedir[i]; 2211 return freedir [i];
2100 } 2212 }
2101 } 2213 }
2102 } 2214 }
2103 2215
2104 return 0; 2216 return 0;
2113{ 2225{
2114 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2226 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2115} 2227}
2116 2228
2117/* 2229/*
2118 * find_dir_2(delta-x,delta-y) will return a direction in which 2230 * find_dir_2(delta-x,delta-y) will return a direction value
2119 * an object which has subtracted the x and y coordinates of another 2231 * for running into direct [dx, dy].
2120 * object, needs to travel toward it. 2232 * (the opposite of crossfire's find_dir_2!)
2121 */ 2233 */
2122int 2234int
2123find_dir_2 (int x, int y) 2235find_dir_2 (int x, int y)
2124{ 2236{
2237#if 1 // new algorithm
2238 // this works by putting x, y into 16 sectors, which
2239 // are not equal sized, but are a better approximation
2240 // then the old algorithm, and then using a mapping
2241 // table to map it into a direction value.
2242 // basically, it maps these comparisons to each bit
2243 // bit #3: x < 0
2244 // bit #2: y < 0
2245 // bit #1: x > y
2246 // bit #0: x > 2y
2247
2248 static const uint8 dir[16] = {
2249 4, 5, 4, 3,
2250 2, 1, 2, 3,
2251 6, 5, 6, 7,
2252 8, 1, 8, 7,
2253 };
2254 int sector = 0;
2255
2256 // this is a bit ugly, but more likely to result in branchless code
2257 sector |= x < 0 ? 8 : 0;
2258 x = x < 0 ? -x : x; // abs
2259
2260 sector |= y < 0 ? 4 : 0;
2261 y = y < 0 ? -y : y; // abs
2262
2263 if (x > y)
2264 {
2265 sector |= 2;
2266
2267 if (x > y * 2)
2268 sector |= 1;
2269 }
2270 else
2271 {
2272 if (y > x * 2)
2273 sector |= 1;
2274 else if (!y)
2275 return 0; // x == 0 here
2276 }
2277
2278 return dir [sector];
2279#else // old algorithm
2125 int q; 2280 int q;
2126 2281
2127 if (y) 2282 if (y)
2128 q = x * 100 / y; 2283 q = 128 * x / y;
2129 else if (x) 2284 else if (x)
2130 q = -300 * x; 2285 q = -512 * x; // to make it > 309
2131 else 2286 else
2132 return 0; 2287 return 0;
2133 2288
2134 if (y > 0) 2289 if (y > 0)
2135 { 2290 {
2136 if (q < -242) 2291 if (q < -309) return 7;
2292 if (q < -52) return 6;
2293 if (q < 52) return 5;
2294 if (q < 309) return 4;
2295
2137 return 3; 2296 return 3;
2138 if (q < -41) 2297 }
2139 return 2; 2298 else
2140 if (q < 41) 2299 {
2141 return 1; 2300 if (q < -309) return 3;
2142 if (q < 242) 2301 if (q < -52) return 2;
2143 return 8; 2302 if (q < 52) return 1;
2303 if (q < 309) return 8;
2304
2144 return 7; 2305 return 7;
2145 } 2306 }
2146 2307#endif
2147 if (q < -242)
2148 return 7;
2149 if (q < -41)
2150 return 6;
2151 if (q < 41)
2152 return 5;
2153 if (q < 242)
2154 return 4;
2155
2156 return 3;
2157} 2308}
2158 2309
2159/* 2310/*
2160 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2311 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2161 * between two directions (which are expected to be absolute (see absdir()) 2312 * between two directions (which are expected to be absolute (see absdir())
2162 */ 2313 */
2163int 2314int
2164dirdiff (int dir1, int dir2) 2315dirdiff (int dir1, int dir2)
2165{ 2316{
2166 int d;
2167
2168 d = abs (dir1 - dir2); 2317 int d = abs (dir1 - dir2);
2169 if (d > 4)
2170 d = 8 - d;
2171 2318
2172 return d; 2319 return d > 4 ? 8 - d : d;
2173} 2320}
2174 2321
2175/* peterm: 2322/* peterm:
2176 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2323 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2177 * Basically, this is a table of directions, and what directions 2324 * Basically, this is a table of directions, and what directions
2179 * This basically means that if direction is 15, then it could either go 2326 * This basically means that if direction is 15, then it could either go
2180 * direction 4, 14, or 16 to get back to where we are. 2327 * direction 4, 14, or 16 to get back to where we are.
2181 * Moved from spell_util.c to object.c with the other related direction 2328 * Moved from spell_util.c to object.c with the other related direction
2182 * functions. 2329 * functions.
2183 */ 2330 */
2184int reduction_dir[SIZEOFFREE][3] = { 2331static const int reduction_dir[SIZEOFFREE][3] = {
2185 {0, 0, 0}, /* 0 */ 2332 {0, 0, 0}, /* 0 */
2186 {0, 0, 0}, /* 1 */ 2333 {0, 0, 0}, /* 1 */
2187 {0, 0, 0}, /* 2 */ 2334 {0, 0, 0}, /* 2 */
2188 {0, 0, 0}, /* 3 */ 2335 {0, 0, 0}, /* 3 */
2189 {0, 0, 0}, /* 4 */ 2336 {0, 0, 0}, /* 4 */
2283 * Add a check so we can't pick up invisible objects (0.93.8) 2430 * Add a check so we can't pick up invisible objects (0.93.8)
2284 */ 2431 */
2285int 2432int
2286can_pick (const object *who, const object *item) 2433can_pick (const object *who, const object *item)
2287{ 2434{
2288 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2435 return /*who->flag [FLAG_WIZ]|| */
2289 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2436 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2290 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2437 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2291} 2438}
2292 2439
2293/* 2440/*
2294 * create clone from object to another 2441 * create clone from object to another
2295 */ 2442 */
2327 return tmp; 2474 return tmp;
2328 2475
2329 return 0; 2476 return 0;
2330} 2477}
2331 2478
2332const shstr & 2479shstr_tmp
2333object::kv_get (const shstr &key) const 2480object::kv_get (shstr_tmp key) const
2334{ 2481{
2335 for (key_value *kv = key_values; kv; kv = kv->next) 2482 for (key_value *kv = key_values; kv; kv = kv->next)
2336 if (kv->key == key) 2483 if (kv->key == key)
2337 return kv->value; 2484 return kv->value;
2338 2485
2339 return shstr_null; 2486 return shstr ();
2340} 2487}
2341 2488
2342void 2489void
2343object::kv_set (const shstr &key, const shstr &value) 2490object::kv_set (shstr_tmp key, shstr_tmp value)
2344{ 2491{
2345 for (key_value *kv = key_values; kv; kv = kv->next) 2492 for (key_value *kv = key_values; kv; kv = kv->next)
2346 if (kv->key == key) 2493 if (kv->key == key)
2347 { 2494 {
2348 kv->value = value; 2495 kv->value = value;
2357 2504
2358 key_values = kv; 2505 key_values = kv;
2359} 2506}
2360 2507
2361void 2508void
2362object::kv_del (const shstr &key) 2509object::kv_del (shstr_tmp key)
2363{ 2510{
2364 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2511 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2365 if ((*kvp)->key == key) 2512 if ((*kvp)->key == key)
2366 { 2513 {
2367 key_value *kv = *kvp; 2514 key_value *kv = *kvp;
2460{ 2607{
2461 return map ? map->region (x, y) 2608 return map ? map->region (x, y)
2462 : region::default_region (); 2609 : region::default_region ();
2463} 2610}
2464 2611
2465const materialtype_t *
2466object::dominant_material () const
2467{
2468 if (materialtype_t *mt = name_to_material (materialname))
2469 return mt;
2470
2471 return name_to_material (shstr_unknown);
2472}
2473
2474void 2612void
2475object::open_container (object *new_container) 2613object::open_container (object *new_container)
2476{ 2614{
2477 if (container == new_container) 2615 if (container == new_container)
2478 return; 2616 return;
2498 container = 0; 2636 container = 0;
2499 2637
2500 // client needs item update to make it work, client bug requires this to be separate 2638 // client needs item update to make it work, client bug requires this to be separate
2501 esrv_update_item (UPD_FLAGS, this, old_container); 2639 esrv_update_item (UPD_FLAGS, this, old_container);
2502 2640
2503 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2641 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2504 play_sound (sound_find ("chest_close")); 2642 play_sound (sound_find ("chest_close"));
2505 } 2643 }
2506 2644
2507 if (new_container) 2645 if (new_container)
2508 { 2646 {
2512 // TODO: this does not seem to serve any purpose anymore? 2650 // TODO: this does not seem to serve any purpose anymore?
2513#if 0 2651#if 0
2514 // insert the "Close Container" object. 2652 // insert the "Close Container" object.
2515 if (archetype *closer = new_container->other_arch) 2653 if (archetype *closer = new_container->other_arch)
2516 { 2654 {
2517 object *closer = arch_to_object (new_container->other_arch); 2655 object *closer = new_container->other_arch->instance ();
2518 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2656 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2519 new_container->insert (closer); 2657 new_container->insert (closer);
2520 } 2658 }
2521#endif 2659#endif
2522 2660
2523 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2661 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2524 2662
2525 // make sure the container is available, client bug requires this to be separate 2663 // make sure the container is available, client bug requires this to be separate
2526 esrv_send_item (this, new_container); 2664 esrv_send_item (this, new_container);
2527 2665
2528 new_container->flag [FLAG_APPLIED] = true; 2666 new_container->flag [FLAG_APPLIED] = true;
2536// else if (!old_container->env && contr && contr->ns) 2674// else if (!old_container->env && contr && contr->ns)
2537// contr->ns->floorbox_reset (); 2675// contr->ns->floorbox_reset ();
2538} 2676}
2539 2677
2540object * 2678object *
2541object::force_find (const shstr name) 2679object::force_find (shstr_tmp name)
2542{ 2680{
2543 /* cycle through his inventory to look for the MARK we want to 2681 /* cycle through his inventory to look for the MARK we want to
2544 * place 2682 * place
2545 */ 2683 */
2546 for (object *tmp = inv; tmp; tmp = tmp->below) 2684 for (object *tmp = inv; tmp; tmp = tmp->below)
2548 return splay (tmp); 2686 return splay (tmp);
2549 2687
2550 return 0; 2688 return 0;
2551} 2689}
2552 2690
2691//-GPL
2692
2553void 2693void
2694object::force_set_timer (int duration)
2695{
2696 this->duration = 1;
2697 this->speed_left = -1.f;
2698
2699 this->set_speed (duration ? 1.f / duration : 0.f);
2700}
2701
2702object *
2554object::force_add (const shstr name, int duration) 2703object::force_add (shstr_tmp name, int duration)
2555{ 2704{
2556 if (object *force = force_find (name)) 2705 if (object *force = force_find (name))
2557 force->destroy (); 2706 force->destroy ();
2558 2707
2559 object *force = get_archetype (FORCE_NAME); 2708 object *force = get_archetype (FORCE_NAME);
2560 2709
2561 force->slaying = name; 2710 force->slaying = name;
2562 force->stats.food = 1; 2711 force->force_set_timer (duration);
2563 force->speed_left = -1.f;
2564
2565 force->set_speed (duration ? 1.f / duration : 0.f);
2566 force->flag [FLAG_IS_USED_UP] = true;
2567 force->flag [FLAG_APPLIED] = true; 2712 force->flag [FLAG_APPLIED] = true;
2568 2713
2569 insert (force); 2714 return insert (force);
2570} 2715}
2571 2716
2572void 2717void
2573object::play_sound (faceidx sound) 2718object::play_sound (faceidx sound) const
2574{ 2719{
2575 if (!sound) 2720 if (!sound)
2576 return; 2721 return;
2577 2722
2578 if (flag [FLAG_REMOVED]) 2723 if (is_on_map ())
2724 map->play_sound (sound, x, y);
2725 else if (object *pl = in_player ())
2726 pl->contr->play_sound (sound);
2727}
2728
2729void
2730object::say_msg (const char *msg) const
2731{
2732 if (is_on_map ())
2733 map->say_msg (msg, x, y);
2734 else if (object *pl = in_player ())
2735 pl->contr->play_sound (sound);
2736}
2737
2738void
2739object::make_noise ()
2740{
2741 // we do not model noise in the map, so instead put
2742 // a temporary light into the noise source
2743 // could use the map instead, but that's less reliable for our
2744 // goal, which is to make invisibility a bit harder to exploit
2745
2746 // currently only works sensibly for players
2747 if (!is_player ())
2579 return; 2748 return;
2580 2749
2581 if (env) 2750 // find old force, or create new one
2582 { 2751 object *force = force_find (shstr_noise_force);
2583 if (object *pl = in_player ()) 2752
2584 pl->contr->play_sound (sound); 2753 if (force)
2585 } 2754 force->speed_left = -1.f; // patch old speed up
2586 else 2755 else
2587 map->play_sound (sound, x, y); 2756 {
2588} 2757 force = archetype::get (shstr_noise_force);
2589 2758
2759 force->slaying = shstr_noise_force;
2760 force->stats.food = 1;
2761 force->speed_left = -1.f;
2762
2763 force->set_speed (1.f / 4.f);
2764 force->flag [FLAG_IS_USED_UP] = true;
2765 force->flag [FLAG_APPLIED] = true;
2766
2767 insert (force);
2768 }
2769}
2770
2771void object::change_move_type (MoveType mt)
2772{
2773 if (move_type == mt)
2774 return;
2775
2776 if (is_on_map ())
2777 {
2778 // we are on the map, so handle move_on/off effects
2779 remove ();
2780 move_type = mt;
2781 map->insert (this, x, y, this);
2782 }
2783 else
2784 move_type = mt;
2785}
2786
2787/* object should be a player.
2788 * we return the object the player has marked with the 'mark' command
2789 * below. If no match is found (or object has changed), we return
2790 * NULL. We leave it up to the calling function to print messages if
2791 * nothing is found.
2792 */
2793object *
2794object::mark () const
2795{
2796 if (contr && contr->mark && contr->mark->env == this)
2797 return contr->mark;
2798 else
2799 return 0;
2800}
2801

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines