ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.319 by root, Sat Apr 3 02:29:40 2010 UTC vs.
Revision 1.337 by root, Thu May 6 21:45:49 2010 UTC

… …
37uint32_t mapspace::smellcount = 10000; 37uint32_t mapspace::smellcount = 10000;
38 38
39objectvec objects; 39objectvec objects;
40activevec actives; 40activevec actives;
41 41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
42//+GPL 48//+GPL
43 49
44short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
45 0, 51 0,
46 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
… …
266 * This is to the comparison of the flags below will be OK. We 272 * This is to the comparison of the flags below will be OK. We
267 * just can't ignore the been applied or identified flags, as they 273 * just can't ignore the been applied or identified flags, as they
268 * are not equal - just if it has been identified, the been_applied 274 * are not equal - just if it has been identified, the been_applied
269 * flags lose any meaning. 275 * flags lose any meaning.
270 */ 276 */
271 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 277 if (ob1->flag [FLAG_IDENTIFIED])
272 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 278 ob1->set_flag (FLAG_BEEN_APPLIED);
273 279
274 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 280 if (ob2->flag [FLAG_IDENTIFIED])
275 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 281 ob2->set_flag (FLAG_BEEN_APPLIED);
276 282
277 if (ob1->arch->archname != ob2->arch->archname 283 if (ob1->arch->archname != ob2->arch->archname
278 || ob1->name != ob2->name 284 || ob1->name != ob2->name
279 || ob1->title != ob2->title 285 || ob1->title != ob2->title
280 || ob1->msg != ob2->msg 286 || ob1->msg != ob2->msg
… …
329 335
330 /* Don't merge objects that are applied. With the new 'body' code, 336 /* Don't merge objects that are applied. With the new 'body' code,
331 * it is possible for most any character to have more than one of 337 * it is possible for most any character to have more than one of
332 * some items equipped, and we don't want those to merge. 338 * some items equipped, and we don't want those to merge.
333 */ 339 */
334 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 340 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
335 return 0; 341 return 0;
336 342
337 /* Note sure why the following is the case - either the object has to 343 /* Note sure why the following is the case - either the object has to
338 * be animated or have a very low speed. Is this an attempted monster 344 * be animated or have a very low speed. Is this an attempted monster
339 * check? 345 * check?
340 */ 346 */
341 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 347 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
342 return 0; 348 return 0;
343 349
344 switch (ob1->type) 350 switch (ob1->type)
345 { 351 {
346 case SCROLL: 352 case SCROLL:
… …
420 426
421 return 0; 427 return 0;
422} 428}
423 429
424// adjust weight per container type ("of holding") 430// adjust weight per container type ("of holding")
425static sint32 431static uint32
426weight_adjust_for (object *op, sint32 weight) 432weight_adjust_for (object *op, uint32 weight)
427{ 433{
428 return op->type == CONTAINER 434 return op->type == CONTAINER
429 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 435 ? weight - weight * op->stats.Str / 100
430 : weight; 436 : weight;
431} 437}
432 438
433/* 439/*
434 * adjust_weight(object, weight) adds the specified weight to an object, 440 * subtracts, then adds, the specified weight to an object,
435 * and also updates how much the environment(s) is/are carrying. 441 * and also updates how much the environment(s) is/are carrying.
436 */ 442 */
437static void 443static void
438adjust_weight (object *op, sint32 weight) 444adjust_weight (object *op, sint32 sub, sint32 add)
439{ 445{
440 while (op) 446 while (op)
441 { 447 {
442 // adjust by actual difference to account for rounding errors 448 sint32 ocarrying = op->carrying;
443 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
444 weight = weight_adjust_for (op, op->carrying)
445 - weight_adjust_for (op, op->carrying - weight);
446 449
447 if (!weight) 450 op->carrying -= weight_adjust_for (op, sub);
448 return; 451 op->carrying += weight_adjust_for (op, add);
449
450 op->carrying += weight;
451 452
452 if (object *pl = op->visible_to ()) 453 if (object *pl = op->visible_to ())
453 if (pl != op) // player is handled lazily 454 if (pl != op) // player is handled lazily
454 esrv_update_item (UPD_WEIGHT, pl, op); 455 esrv_update_item (UPD_WEIGHT, pl, op);
455 456
457 sub = ocarrying;
458 add = op->carrying;
459
456 op = op->env; 460 op = op->env;
457 } 461 }
458} 462}
459 463
460/* 464/*
… …
467{ 471{
468 sint32 sum = 0; 472 sint32 sum = 0;
469 473
470 for (object *op = inv; op; op = op->below) 474 for (object *op = inv; op; op = op->below)
471 { 475 {
472 if (op->inv)
473 op->update_weight (); 476 op->update_weight ();
474 477
475 sum += op->total_weight (); 478 sum += weight_adjust_for (this, op->total_weight ());
476 } 479 }
477
478 sum = weight_adjust_for (this, sum);
479 480
480 if (sum != carrying) 481 if (sum != carrying)
481 { 482 {
483 if (carrying != sum && carrying)//D
484 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
485 (long long)sum, (long long)carrying, debug_desc ());
486
482 carrying = sum; 487 carrying = sum;
483 488
484 if (object *pl = visible_to ()) 489 if (object *pl = visible_to ())
485 if (pl != this) // player is handled lazily 490 if (pl != this) // player is handled lazily
486 esrv_update_item (UPD_WEIGHT, pl, this); 491 esrv_update_item (UPD_WEIGHT, pl, this);
… …
683 * be called to update the face variable, _and_ how it looks on the map. 688 * be called to update the face variable, _and_ how it looks on the map.
684 */ 689 */
685void 690void
686update_turn_face (object *op) 691update_turn_face (object *op)
687{ 692{
688 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 693 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
689 return; 694 return;
690 695
691 SET_ANIMATION (op, op->direction); 696 SET_ANIMATION (op, op->direction);
692 update_object (op, UP_OBJ_FACE); 697 update_object (op, UP_OBJ_FACE);
693} 698}
… …
759 /* nop */; 764 /* nop */;
760 else if (action == UP_OBJ_INSERT) 765 else if (action == UP_OBJ_INSERT)
761 { 766 {
762#if 0 767#if 0
763 // this is likely overkill, TODO: revisit (schmorp) 768 // this is likely overkill, TODO: revisit (schmorp)
764 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 769 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
765 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 770 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
766 || (op->is_player () && !(m.flags_ & P_PLAYER)) 771 || (op->is_player () && !(m.flags_ & P_PLAYER))
767 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 772 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
768 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 773 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
769 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 774 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
770 || (m.move_on | op->move_on ) != m.move_on 775 || (m.move_on | op->move_on ) != m.move_on
771 || (m.move_off | op->move_off ) != m.move_off 776 || (m.move_off | op->move_off ) != m.move_off
772 || (m.move_slow | op->move_slow) != m.move_slow 777 || (m.move_slow | op->move_slow) != m.move_slow
773 /* This isn't perfect, but I don't expect a lot of objects to 778 /* This isn't perfect, but I don't expect a lot of objects to
774 * have move_allow right now. 779 * have move_allow right now.
… …
795 update_object (op->more, action); 800 update_object (op->more, action);
796} 801}
797 802
798object::object () 803object::object ()
799{ 804{
800 SET_FLAG (this, FLAG_REMOVED); 805 this->set_flag (FLAG_REMOVED);
801 806
802 //expmul = 1.0; declared const for the time being 807 //expmul = 1.0; declared const for the time being
803 face = blank_face; 808 face = blank_face;
804 material = MATERIAL_NULL; 809 material = MATERIAL_NULL;
805} 810}
… …
809 unlink (); 814 unlink ();
810 815
811 free_key_values (this); 816 free_key_values (this);
812} 817}
813 818
814static int object_count;
815
816void object::link () 819void object::link ()
817{ 820{
818 assert (!index);//D 821 assert (!index);//D
819 uuid = UUID::gen (); 822 uuid = UUID::gen ();
820 count = ++object_count;
821 823
822 refcnt_inc (); 824 refcnt_inc ();
823 objects.insert (this); 825 objects.insert (this);
826
827 ++create_count;
828
824} 829}
825 830
826void object::unlink () 831void object::unlink ()
827{ 832{
828 if (!index) 833 if (!index)
829 return; 834 return;
835
836 ++destroy_count;
830 837
831 objects.erase (this); 838 objects.erase (this);
832 refcnt_dec (); 839 refcnt_dec ();
833} 840}
834 841
… …
939 map->insert (op, x, y); 946 map->insert (op, x, y);
940 } 947 }
941 } 948 }
942} 949}
943 950
951/*
952 * Remove and free all objects in the inventory of the given object.
953 * Unlike destroy_inv, this assumes the *this is destroyed as well
954 * well, so we can (and have to!) take shortcuts.
955 */
956void
957object::destroy_inv_fast ()
958{
959 while (object *op = inv)
960 {
961 // remove from object the fast way
962 op->flag [FLAG_REMOVED] = true;
963 op->env = 0;
964 if ((inv = inv->below))
965 inv->above = 0;
966
967 // then destroy
968 op->destroy ();
969 }
970}
971
972void
973object::freelist_free (int count)
974{
975 while (count-- && freelist)
976 {
977 freelist_item *next = freelist->next;
978 // count is being "destroyed"
979
980 sfree ((char *)freelist, sizeof (object));
981
982 freelist = next;
983 --free_count;
984 }
985}
986
987object *
944object *object::create () 988object::create ()
945{ 989{
946 object *op = new object; 990 object *op;
991
992 if (freelist)
993 {
994 freelist_item li = *freelist;
995 memset (freelist, 0, sizeof (object));
996
997 op = new (freelist) object;
998 op->count = li.count;
999
1000 freelist = li.next;
1001 --free_count;
1002 }
1003 else
1004 {
1005 void *ni = salloc0<char> (sizeof (object));
1006
1007 op = new(ni) object;
1008
1009 op->count = ++object_count;
1010 }
1011
947 op->link (); 1012 op->link ();
1013
948 return op; 1014 return op;
949} 1015}
950 1016
1017void
1018object::do_delete ()
1019{
1020 uint32_t count = this->count;
1021
1022 this->~object ();
1023
1024 freelist_item *li = (freelist_item *)this;
1025 li->next = freelist;
1026 li->count = count;
1027
1028 freelist = li;
1029 ++free_count;
1030}
1031
951static struct freed_map : maptile 1032static struct freed_map : maptile
952{ 1033{
953 freed_map () 1034 freed_map ()
1035 : maptile (3, 3)
954 { 1036 {
955 path = "<freed objects map>"; 1037 path = "<freed objects map>";
956 name = "/internal/freed_objects_map"; 1038 name = "/internal/freed_objects_map";
957 width = 3;
958 height = 3;
959 no_drop = 1; 1039 no_drop = 1;
960 no_reset = 1; 1040 no_reset = 1;
961 1041
962 alloc ();
963 in_memory = MAP_ACTIVE; 1042 in_memory = MAP_ACTIVE;
964 } 1043 }
965 1044
966 ~freed_map () 1045 ~freed_map ()
967 { 1046 {
… …
1018 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1097 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1019 head->destroy (); 1098 head->destroy ();
1020 return; 1099 return;
1021 } 1100 }
1022 1101
1023 destroy_inv (false); 1102 destroy_inv_fast ();
1024 1103
1025 if (is_head ()) 1104 if (is_head ())
1026 if (sound_destroy) 1105 if (sound_destroy)
1027 play_sound (sound_destroy); 1106 play_sound (sound_destroy);
1028 else if (flag [FLAG_MONSTER]) 1107 else if (flag [FLAG_MONSTER])
… …
1060 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed 1139 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1061 if (object *pl = visible_to ()) 1140 if (object *pl = visible_to ())
1062 esrv_del_item (pl->contr, count); 1141 esrv_del_item (pl->contr, count);
1063 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1142 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1064 1143
1065 adjust_weight (env, -total_weight ()); 1144 adjust_weight (env, total_weight (), 0);
1066 1145
1067 object *pl = in_player (); 1146 object *pl = in_player ();
1068 1147
1069 /* we set up values so that it could be inserted into 1148 /* we set up values so that it could be inserted into
1070 * the map, but we don't actually do that - it is up 1149 * the map, but we don't actually do that - it is up
… …
1128 else if (pl->container_ () == this) 1207 else if (pl->container_ () == this)
1129 { 1208 {
1130 // removing a container should close it 1209 // removing a container should close it
1131 close_container (); 1210 close_container ();
1132 } 1211 }
1133 1212 else
1134 esrv_del_item (pl->contr, count); 1213 esrv_del_item (pl->contr, count);
1135 } 1214 }
1136 1215
1137 /* link the object above us */ 1216 /* link the object above us */
1138 // re-link, make sure compiler can easily use cmove 1217 // re-link, make sure compiler can easily use cmove
1139 *(above ? &above->below : &ms.top) = below; 1218 *(above ? &above->below : &ms.top) = below;
… …
1325 // from here :/ 1404 // from here :/
1326 op->nrof += tmp->nrof; 1405 op->nrof += tmp->nrof;
1327 tmp->destroy (); 1406 tmp->destroy ();
1328 } 1407 }
1329 1408
1330 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1409 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1331 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1410 op->clr_flag (FLAG_INV_LOCKED);
1332 1411
1333 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1412 if (!op->flag [FLAG_ALIVE])
1334 CLEAR_FLAG (op, FLAG_NO_STEAL); 1413 op->clr_flag (FLAG_NO_STEAL);
1335 1414
1336 if (flag & INS_BELOW_ORIGINATOR) 1415 if (flag & INS_BELOW_ORIGINATOR)
1337 { 1416 {
1338 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1417 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1339 { 1418 {
… …
1374 * when lots of spells are cast in one area. Currently, it is presumed 1453 * when lots of spells are cast in one area. Currently, it is presumed
1375 * that flying non pickable objects are spell objects. 1454 * that flying non pickable objects are spell objects.
1376 */ 1455 */
1377 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1456 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1378 { 1457 {
1379 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR)) 1458 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1380 floor = tmp; 1459 floor = tmp;
1381 1460
1382 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 1461 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1383 { 1462 {
1384 /* We insert above top, so we want this object below this */ 1463 /* We insert above top, so we want this object below this */
1385 top = tmp->below; 1464 top = tmp->below;
1386 break; 1465 break;
1387 } 1466 }
… …
1405 && (op->face && !faces [op->face].visibility)) 1484 && (op->face && !faces [op->face].visibility))
1406 { 1485 {
1407 object *last; 1486 object *last;
1408 1487
1409 for (last = top; last != floor; last = last->below) 1488 for (last = top; last != floor; last = last->below)
1410 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1489 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1411 break; 1490 break;
1412 1491
1413 /* Check to see if we found the object that blocks view, 1492 /* Check to see if we found the object that blocks view,
1414 * and make sure we have a below pointer for it so that 1493 * and make sure we have a below pointer for it so that
1415 * we can get inserted below this one, which requires we 1494 * we can get inserted below this one, which requires we
… …
1488 */ 1567 */
1489 1568
1490 /* if this is not the head or flag has been passed, don't check walk on status */ 1569 /* if this is not the head or flag has been passed, don't check walk on status */
1491 if (!(flag & INS_NO_WALK_ON) && op->is_head ()) 1570 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1492 { 1571 {
1493 if (check_move_on (op, originator)) 1572 if (check_move_on (op, originator, flag))
1494 return 0; 1573 return 0;
1495 1574
1496 /* If we are a multi part object, lets work our way through the check 1575 /* If we are a multi part object, let's work our way through the check
1497 * walk on's. 1576 * walk on's.
1498 */ 1577 */
1499 for (object *tmp = op->more; tmp; tmp = tmp->more) 1578 for (object *tmp = op->more; tmp; tmp = tmp->more)
1500 if (check_move_on (tmp, originator)) 1579 if (check_move_on (tmp, originator, flag))
1501 return 0; 1580 return 0;
1502 } 1581 }
1503 1582
1504 return op; 1583 return op;
1505} 1584}
… …
1546 || (items < m->max_items 1625 || (items < m->max_items
1547 && ms.volume () < m->max_volume)) 1626 && ms.volume () < m->max_volume))
1548 return true; 1627 return true;
1549 1628
1550 if (originator && originator->is_player ()) 1629 if (originator && originator->is_player ())
1551 originator->contr->failmsg (format ( 1630 originator->contr->failmsgf (
1552 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>", 1631 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1553 query_name () 1632 query_name ()
1554 )); 1633 );
1555 1634
1556 return false; 1635 return false;
1557} 1636}
1558 1637
1559/* 1638/*
… …
1571 1650
1572 nr = min (nr, nrof); 1651 nr = min (nr, nrof);
1573 1652
1574 if (nrof > nr) 1653 if (nrof > nr)
1575 { 1654 {
1655 sint64 oweight = total_weight ();
1656
1576 nrof -= nr; 1657 nrof -= nr;
1577 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1578 1658
1579 if (object *pl = visible_to ()) 1659 if (object *pl = visible_to ())
1580 esrv_update_item (UPD_NROF, pl, this); 1660 esrv_update_item (UPD_NROF, pl, this);
1661
1662 adjust_weight (env, oweight, total_weight ());
1581 1663
1582 return true; 1664 return true;
1583 } 1665 }
1584 else 1666 else
1585 { 1667 {
… …
1660 if (op->nrof) 1742 if (op->nrof)
1661 for (object *tmp = inv; tmp; tmp = tmp->below) 1743 for (object *tmp = inv; tmp; tmp = tmp->below)
1662 if (object::can_merge (tmp, op)) 1744 if (object::can_merge (tmp, op))
1663 { 1745 {
1664 /* return the original object and remove inserted object 1746 /* return the original object and remove inserted object
1665 (client needs the original object) */ 1747 (client prefers the original object) */
1748
1749 // carring must be 0 for mergable objects
1750 sint64 oweight = tmp->weight * tmp->nrof;
1751
1666 tmp->nrof += op->nrof; 1752 tmp->nrof += op->nrof;
1667 1753
1668 if (object *pl = tmp->visible_to ()) 1754 if (object *pl = tmp->visible_to ())
1669 esrv_update_item (UPD_NROF, pl, tmp); 1755 esrv_update_item (UPD_NROF, pl, tmp);
1670 1756
1671 adjust_weight (this, op->total_weight ()); 1757 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1672 1758
1673 op->destroy (); 1759 op->destroy ();
1674 op = tmp; 1760 op = tmp;
1675 goto inserted; 1761 goto inserted;
1676 } 1762 }
… …
1692 op->flag [FLAG_REMOVED] = 0; 1778 op->flag [FLAG_REMOVED] = 0;
1693 1779
1694 if (object *pl = op->visible_to ()) 1780 if (object *pl = op->visible_to ())
1695 esrv_send_item (pl, op); 1781 esrv_send_item (pl, op);
1696 1782
1697 adjust_weight (this, op->total_weight ()); 1783 adjust_weight (this, 0, op->total_weight ());
1698 1784
1699inserted: 1785inserted:
1700 /* reset the light list and los of the players on the map */ 1786 /* reset the light list and los of the players on the map */
1701 if (op->glow_radius && is_on_map ()) 1787 if (op->glow_radius && is_on_map ())
1702 { 1788 {
… …
1731 * MSW 2001-07-08: Check all objects on space, not just those below 1817 * MSW 2001-07-08: Check all objects on space, not just those below
1732 * object being inserted. insert_ob_in_map may not put new objects 1818 * object being inserted. insert_ob_in_map may not put new objects
1733 * on top. 1819 * on top.
1734 */ 1820 */
1735int 1821int
1736check_move_on (object *op, object *originator) 1822check_move_on (object *op, object *originator, int flags)
1737{ 1823{
1738 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1824 if (op->flag [FLAG_NO_APPLY])
1739 return 0; 1825 return 0;
1740 1826
1741 object *tmp; 1827 object *tmp;
1742 maptile *m = op->map; 1828 maptile *m = op->map;
1743 int x = op->x, y = op->y; 1829 int x = op->x, y = op->y;
… …
1780 * Second check makes sure that the movement types not being slowed 1866 * Second check makes sure that the movement types not being slowed
1781 * (~slow_move) is not blocked on this space - just because the 1867 * (~slow_move) is not blocked on this space - just because the
1782 * space doesn't slow down swimming (for example), if you can't actually 1868 * space doesn't slow down swimming (for example), if you can't actually
1783 * swim on that space, can't use it to avoid the penalty. 1869 * swim on that space, can't use it to avoid the penalty.
1784 */ 1870 */
1785 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1871 if (!op->flag [FLAG_WIZPASS])
1786 { 1872 {
1787 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1873 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1788 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1874 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1789 { 1875 {
1790 float diff = tmp->move_slow_penalty * fabs (op->speed); 1876 float diff = tmp->move_slow_penalty * fabs (op->speed);
… …
1800 1886
1801 /* Basically same logic as above, except now for actual apply. */ 1887 /* Basically same logic as above, except now for actual apply. */
1802 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1888 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1803 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1889 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1804 { 1890 {
1891 if ((flags & INS_NO_AUTO_EXIT)
1892 && (tmp->type == EXIT || tmp->type == TELEPORTER
1893 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1894 continue;
1895
1805 move_apply (tmp, op, originator); 1896 move_apply (tmp, op, originator);
1806 1897
1807 if (op->destroyed ()) 1898 if (op->destroyed ())
1808 return 1; 1899 return 1;
1809 1900
… …
1921void 2012void
1922flag_inv (object *op, int flag) 2013flag_inv (object *op, int flag)
1923{ 2014{
1924 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2015 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1925 { 2016 {
1926 SET_FLAG (tmp, flag); 2017 tmp->set_flag (flag);
1927 flag_inv (tmp, flag); 2018 flag_inv (tmp, flag);
1928 } 2019 }
1929} 2020}
1930 2021
1931/* 2022/*
… …
1934void 2025void
1935unflag_inv (object *op, int flag) 2026unflag_inv (object *op, int flag)
1936{ 2027{
1937 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2028 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1938 { 2029 {
1939 CLEAR_FLAG (tmp, flag); 2030 tmp->clr_flag (flag);
1940 unflag_inv (tmp, flag); 2031 unflag_inv (tmp, flag);
1941 } 2032 }
1942} 2033}
1943 2034
1944/* 2035/*
… …
2134{ 2225{
2135 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2226 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2136} 2227}
2137 2228
2138/* 2229/*
2139 * find_dir_2(delta-x,delta-y) will return a direction in which 2230 * find_dir_2(delta-x,delta-y) will return a direction value
2140 * an object which has subtracted the x and y coordinates of another 2231 * for running into direct [dx, dy].
2141 * object, needs to travel toward it. 2232 * (the opposite of crossfire's find_dir_2!)
2142 */ 2233 */
2143int 2234int
2144find_dir_2 (int x, int y) 2235find_dir_2 (int x, int y)
2145{ 2236{
2237#if 1 // new algorithm
2238 // this works by putting x, y into 16 sectors, which
2239 // are not equal sized, but are a better approximation
2240 // then the old algorithm, and then using a mapping
2241 // table to map it into a direction value.
2242 // basically, it maps these comparisons to each bit
2243 // bit #3: x < 0
2244 // bit #2: y < 0
2245 // bit #1: x > y
2246 // bit #0: x > 2y
2247
2248 static const uint8 dir[16] = {
2249 4, 5, 4, 3,
2250 2, 1, 2, 3,
2251 6, 5, 6, 7,
2252 8, 1, 8, 7,
2253 };
2254 int sector = 0;
2255
2256 // this is a bit ugly, but more likely to result in branchless code
2257 sector |= x < 0 ? 8 : 0;
2258 x = x < 0 ? -x : x; // abs
2259
2260 sector |= y < 0 ? 4 : 0;
2261 y = y < 0 ? -y : y; // abs
2262
2263 if (x > y)
2264 {
2265 sector |= 2;
2266
2267 if (x > y * 2)
2268 sector |= 1;
2269 }
2270 else
2271 {
2272 if (y > x * 2)
2273 sector |= 1;
2274 else if (!y)
2275 return 0; // x == 0 here
2276 }
2277
2278 return dir [sector];
2279#else // old algorithm
2146 int q; 2280 int q;
2147 2281
2148 if (y) 2282 if (y)
2149 q = x * 100 / y; 2283 q = 128 * x / y;
2150 else if (x) 2284 else if (x)
2151 q = -300 * x; 2285 q = -512 * x; // to make it > 309
2152 else 2286 else
2153 return 0; 2287 return 0;
2154 2288
2155 if (y > 0) 2289 if (y > 0)
2156 { 2290 {
2157 if (q < -242) 2291 if (q < -309) return 7;
2292 if (q < -52) return 6;
2293 if (q < 52) return 5;
2294 if (q < 309) return 4;
2295
2158 return 3; 2296 return 3;
2159 if (q < -41) 2297 }
2160 return 2; 2298 else
2161 if (q < 41) 2299 {
2162 return 1; 2300 if (q < -309) return 3;
2163 if (q < 242) 2301 if (q < -52) return 2;
2164 return 8; 2302 if (q < 52) return 1;
2303 if (q < 309) return 8;
2304
2165 return 7; 2305 return 7;
2166 } 2306 }
2167 2307#endif
2168 if (q < -242)
2169 return 7;
2170 if (q < -41)
2171 return 6;
2172 if (q < 41)
2173 return 5;
2174 if (q < 242)
2175 return 4;
2176
2177 return 3;
2178} 2308}
2179 2309
2180/* 2310/*
2181 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2311 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2182 * between two directions (which are expected to be absolute (see absdir()) 2312 * between two directions (which are expected to be absolute (see absdir())
2183 */ 2313 */
2184int 2314int
2185dirdiff (int dir1, int dir2) 2315dirdiff (int dir1, int dir2)
2186{ 2316{
2187 int d;
2188
2189 d = abs (dir1 - dir2); 2317 int d = abs (dir1 - dir2);
2190 if (d > 4)
2191 d = 8 - d;
2192 2318
2193 return d; 2319 return d > 4 ? 8 - d : d;
2194} 2320}
2195 2321
2196/* peterm: 2322/* peterm:
2197 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2323 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2198 * Basically, this is a table of directions, and what directions 2324 * Basically, this is a table of directions, and what directions
… …
2304 * Add a check so we can't pick up invisible objects (0.93.8) 2430 * Add a check so we can't pick up invisible objects (0.93.8)
2305 */ 2431 */
2306int 2432int
2307can_pick (const object *who, const object *item) 2433can_pick (const object *who, const object *item)
2308{ 2434{
2309 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2435 return /*who->flag [FLAG_WIZ]|| */
2310 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2436 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2311 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3)); 2437 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2312} 2438}
2313 2439
2314/* 2440/*
2315 * create clone from object to another 2441 * create clone from object to another
2316 */ 2442 */
… …
2656 } 2782 }
2657 else 2783 else
2658 move_type = mt; 2784 move_type = mt;
2659} 2785}
2660 2786
2787/* object should be a player.
2788 * we return the object the player has marked with the 'mark' command
2789 * below. If no match is found (or object has changed), we return
2790 * NULL. We leave it up to the calling function to print messages if
2791 * nothing is found.
2792 */
2793object *
2794object::mark () const
2795{
2796 if (contr && contr->mark && contr->mark->env == this)
2797 return contr->mark;
2798 else
2799 return 0;
2800}
2801

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines