ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.207 by root, Sun Apr 20 23:25:09 2008 UTC vs.
Revision 1.339 by root, Fri Jul 2 17:39:23 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27 24
28#include <global.h> 25#include <global.h>
29#include <stdio.h> 26#include <stdio.h>
30#include <sys/types.h> 27#include <sys/types.h>
31#include <sys/uio.h> 28#include <sys/uio.h>
32#include <object.h> 29#include <object.h>
33#include <funcpoint.h>
34#include <sproto.h> 30#include <sproto.h>
35#include <loader.h>
36 31
37#include <bitset> 32#include <bitset>
38 33
39UUID UUID::cur; 34UUID UUID::cur;
40static uint64_t seq_next_save; 35static uint64_t seq_next_save;
41static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
42 38
43objectvec objects; 39objectvec objects;
44activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
45 49
46short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
47 0, 51 0,
48 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
49 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
53 0, 57 0,
54 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
55 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
56 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
57}; 61};
58int maxfree[SIZEOFFREE] = {
59 0,
60 9, 10, 13, 14, 17, 18, 21, 22,
61 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
62 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
63};
64int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
65 0, 63 0,
66 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
67 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
68 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
69}; 67};
70 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
76const char *wall_suffix[16] = {
77 "0",
78 "1_3",
79 "1_4",
80 "2_1_2",
81 "1_2",
82 "2_2_4",
83 "2_2_1",
84 "3_1",
85 "1_1",
86 "2_2_3",
87 "2_2_2",
88 "3_3",
89 "2_1_1",
90 "3_4",
91 "3_2",
92 "4"
93};
94
71static void 95static void
72write_uuid (uval64 skip, bool sync) 96write_uuid (uval64 skip, bool sync)
73{ 97{
74 CALL_BEGIN (2); 98 CALL_BEGIN (2);
75 CALL_ARG_SV (newSVval64 (skip)); 99 CALL_ARG_SV (newSVval64 (skip));
77 CALL_CALL ("cf::write_uuid", G_DISCARD); 101 CALL_CALL ("cf::write_uuid", G_DISCARD);
78 CALL_END; 102 CALL_END;
79} 103}
80 104
81static void 105static void
82read_uuid (void) 106read_uuid ()
83{ 107{
84 char filename[MAX_BUF]; 108 char filename[MAX_BUF];
85 109
86 sprintf (filename, "%s/uuid", settings.localdir); 110 sprintf (filename, "%s/uuid", settings.localdir);
87 111
101 125
102 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 126 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
103 _exit (1); 127 _exit (1);
104 } 128 }
105 129
106 UUID::BUF buf; 130 char buf [UUID::MAX_LEN];
107 buf[0] = 0; 131 buf[0] = 0;
108 fgets (buf, sizeof (buf), fp); 132 fgets (buf, sizeof (buf), fp);
109 133
110 if (!UUID::cur.parse (buf)) 134 if (!UUID::cur.parse (buf))
111 { 135 {
138 162
139void 163void
140UUID::init () 164UUID::init ()
141{ 165{
142 read_uuid (); 166 read_uuid ();
167}
168
169bool
170UUID::parse (const char *s)
171{
172 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
173 return false;
174
175 seq = 0;
176
177 while (*s != '>')
178 {
179 if (*s < '0')
180 return false;
181
182 // this gives nice branchless code with gcc
183 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
184 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
185
186 seq = (seq << 4) | digit;
187
188 ++s;
189 }
190
191 return true;
192}
193
194char *
195UUID::append (char *buf) const
196{
197 *buf++ = '<';
198 *buf++ = '1';
199 *buf++ = '.';
200
201 uint64_t seq = this->seq;
202 const int bits = 64;
203 char nz = 0;
204 static const char tohex [] = "0123456789abcdef";
205
206 // assert (len >= 3 + bits / 4 + 1 + 1);
207 for (int i = bits / 4; --i; )
208 {
209 uint8_t digit = seq >> (bits - 4);
210
211 *buf = tohex [digit];
212 nz |= digit;
213 buf += nz ? 1 : 0;
214 seq <<= 4;
215 }
216
217 // last digit is special - always emit
218 uint8_t digit = seq >> (bits - 4);
219 *buf++ = tohex [digit];
220
221 *buf++ = '>';
222
223 return buf;
224}
225
226char *
227UUID::c_str () const
228{
229 static char buf [MAX_LEN];
230 *append (buf) = 0;
231 return buf;
143} 232}
144 233
145/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 234/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
146static bool 235static bool
147compare_ob_value_lists_one (const object *wants, const object *has) 236compare_ob_value_lists_one (const object *wants, const object *has)
148{ 237{
149 key_value *wants_field;
150
151 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 238 /* n-squared behaviour (see kv_get), but I'm hoping both
152 * objects with lists are rare, and lists stay short. If not, use a 239 * objects with lists are rare, and lists stay short. If not, use a
153 * different structure or at least keep the lists sorted... 240 * different structure or at least keep the lists sorted...
154 */ 241 */
155 242
156 /* For each field in wants, */ 243 /* For each field in wants, */
157 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 244 for (key_value *kv = wants->key_values; kv; kv = kv->next)
158 { 245 if (has->kv_get (kv->key) != kv->value)
159 key_value *has_field; 246 return false;
160
161 /* Look for a field in has with the same key. */
162 has_field = get_ob_key_link (has, wants_field->key);
163
164 if (!has_field)
165 return 0; /* No field with that name. */
166
167 /* Found the matching field. */
168 if (has_field->value != wants_field->value)
169 return 0; /* Values don't match, so this half of the comparison is false. */
170
171 /* If we get here, we found a match. Now for the next field in wants. */
172 }
173 247
174 /* If we get here, every field in wants has a matching field in has. */ 248 /* If we get here, every field in wants has a matching field in has. */
175 return 1; 249 return true;
176} 250}
177 251
178/* Returns TRUE if ob1 has the same key_values as ob2. */ 252/* Returns TRUE if ob1 has the same key_values as ob2. */
179static bool 253static bool
180compare_ob_value_lists (const object *ob1, const object *ob2) 254compare_ob_value_lists (const object *ob1, const object *ob2)
181{ 255{
182 /* However, there may be fields in has which aren't partnered in wants, 256 /* However, there may be fields in has which aren't partnered in wants,
183 * so we need to run the comparison *twice*. :( 257 * so we need to run the comparison *twice*. :(
184 */ 258 */
185 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 259 return compare_ob_value_lists_one (ob1, ob2)
260 && compare_ob_value_lists_one (ob2, ob1);
186} 261}
187 262
188/* Function examines the 2 objects given to it, and returns true if 263/* Function examines the 2 objects given to it, and returns true if
189 * they can be merged together. 264 * they can be merged together.
190 * 265 *
197 * Improvements made with merge: Better checking on potion, and also 272 * Improvements made with merge: Better checking on potion, and also
198 * check weight 273 * check weight
199 */ 274 */
200bool object::can_merge_slow (object *ob1, object *ob2) 275bool object::can_merge_slow (object *ob1, object *ob2)
201{ 276{
202 /* A couple quicksanity checks */ 277 /* A couple quick sanity checks */
203 if (ob1 == ob2 278 if (ob1 == ob2
204 || ob1->type != ob2->type 279 || ob1->type != ob2->type
205 || ob1->speed != ob2->speed
206 || ob1->value != ob2->value 280 || ob1->value != ob2->value
207 || ob1->name != ob2->name) 281 || ob1->name != ob2->name
282 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
208 return 0; 283 return 0;
209 284
210 /* Do not merge objects if nrof would overflow. First part checks 285 /* Do not merge objects if nrof would overflow, assume nrof
211 * for unsigned overflow (2c), second part checks wether the result 286 * is always 0 .. 2**31-1 */
212 * would fit into a 32 bit signed int, which is often used to hold 287 if (ob1->nrof > 0x7fffffff - ob2->nrof)
213 * nrof values.
214 */
215 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
216 return 0; 288 return 0;
217 289
218 /* If the objects have been identified, set the BEEN_APPLIED flag. 290 /* If the objects have been identified, set the BEEN_APPLIED flag.
219 * This is to the comparison of the flags below will be OK. We 291 * This is to the comparison of the flags below will be OK. We
220 * just can't ignore the been applied or identified flags, as they 292 * just can't ignore the been applied or identified flags, as they
221 * are not equal - just if it has been identified, the been_applied 293 * are not equal - just if it has been identified, the been_applied
222 * flags lose any meaning. 294 * flags lose any meaning.
223 */ 295 */
224 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 296 if (ob1->flag [FLAG_IDENTIFIED])
225 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 297 ob1->set_flag (FLAG_BEEN_APPLIED);
226 298
227 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 299 if (ob2->flag [FLAG_IDENTIFIED])
228 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 300 ob2->set_flag (FLAG_BEEN_APPLIED);
229 301
230 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 302 if (ob1->arch->archname != ob2->arch->archname
231 || ob1->arch != ob2->arch
232 || ob1->name != ob2->name 303 || ob1->name != ob2->name
233 || ob1->title != ob2->title 304 || ob1->title != ob2->title
234 || ob1->msg != ob2->msg 305 || ob1->msg != ob2->msg
235 || ob1->weight != ob2->weight 306 || ob1->weight != ob2->weight
236 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 || ob1->attacktype != ob2->attacktype 307 || ob1->attacktype != ob2->attacktype
239 || ob1->magic != ob2->magic 308 || ob1->magic != ob2->magic
240 || ob1->slaying != ob2->slaying 309 || ob1->slaying != ob2->slaying
241 || ob1->skill != ob2->skill 310 || ob1->skill != ob2->skill
242 || ob1->value != ob2->value 311 || ob1->value != ob2->value
243 || ob1->animation_id != ob2->animation_id 312 || ob1->animation_id != ob2->animation_id
313 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
244 || ob1->client_type != ob2->client_type 314 || ob1->client_type != ob2->client_type
245 || ob1->materialname != ob2->materialname 315 || ob1->material != ob2->material
246 || ob1->lore != ob2->lore 316 || ob1->lore != ob2->lore
247 || ob1->subtype != ob2->subtype 317 || ob1->subtype != ob2->subtype
248 || ob1->move_type != ob2->move_type 318 || ob1->move_type != ob2->move_type
249 || ob1->move_block != ob2->move_block 319 || ob1->move_block != ob2->move_block
250 || ob1->move_allow != ob2->move_allow 320 || ob1->move_allow != ob2->move_allow
251 || ob1->move_on != ob2->move_on 321 || ob1->move_on != ob2->move_on
252 || ob1->move_off != ob2->move_off 322 || ob1->move_off != ob2->move_off
253 || ob1->move_slow != ob2->move_slow 323 || ob1->move_slow != ob2->move_slow
254 || ob1->move_slow_penalty != ob2->move_slow_penalty) 324 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
325 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
326 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
327 return 0;
328
329 if ((ob1->flag ^ ob2->flag)
330 .reset (FLAG_INV_LOCKED)
331 .reset (FLAG_REMOVED)
332 .any ())
255 return 0; 333 return 0;
256 334
257 /* This is really a spellbook check - we should in general 335 /* This is really a spellbook check - we should in general
258 * not merge objects with real inventories, as splitting them 336 * not merge objects with real inventories, as splitting them
259 * is hard. 337 * is hard.
276 354
277 /* Don't merge objects that are applied. With the new 'body' code, 355 /* Don't merge objects that are applied. With the new 'body' code,
278 * it is possible for most any character to have more than one of 356 * it is possible for most any character to have more than one of
279 * some items equipped, and we don't want those to merge. 357 * some items equipped, and we don't want those to merge.
280 */ 358 */
281 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 359 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
282 return 0; 360 return 0;
283 361
284 /* Note sure why the following is the case - either the object has to 362 /* Note sure why the following is the case - either the object has to
285 * be animated or have a very low speed. Is this an attempted monster 363 * be animated or have a very low speed. Is this an attempted monster
286 * check? 364 * check?
287 */ 365 */
288 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 366 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
289 return 0; 367 return 0;
290 368
291 switch (ob1->type) 369 switch (ob1->type)
292 { 370 {
293 case SCROLL: 371 case SCROLL:
298 376
299 if (ob1->key_values || ob2->key_values) 377 if (ob1->key_values || ob2->key_values)
300 { 378 {
301 /* At least one of these has key_values. */ 379 /* At least one of these has key_values. */
302 if ((!ob1->key_values) != (!ob2->key_values)) 380 if ((!ob1->key_values) != (!ob2->key_values))
303 /* One has fields, but the other one doesn't. */ 381 return 0; /* One has fields, but the other one doesn't. */
304 return 0; 382
305 else if (!compare_ob_value_lists (ob1, ob2)) 383 if (!compare_ob_value_lists (ob1, ob2))
306 return 0; 384 return 0;
307 } 385 }
308 386
309 if (ob1->self || ob2->self) 387 if (ob1->self || ob2->self)
310 { 388 {
316 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 394 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
317 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 395 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
318 396
319 if (k1 != k2) 397 if (k1 != k2)
320 return 0; 398 return 0;
399
321 else if (k1 == 0) 400 if (k1 == 0)
322 return 1; 401 return 1;
402
323 else if (!cfperl_can_merge (ob1, ob2)) 403 if (!cfperl_can_merge (ob1, ob2))
324 return 0; 404 return 0;
325 } 405 }
326 } 406 }
327 407
328 /* Everything passes, must be OK. */ 408 /* Everything passes, must be OK. */
329 return 1; 409 return 1;
330} 410}
331 411
412// find player who can see this object
413object *
414object::visible_to () const
415{
416 if (client_visible () && !flag [FLAG_REMOVED])
417 {
418 // see if we are in a container of sorts
419 if (env)
420 {
421 // the player inventory itself is always visible
422 if (env->is_player ())
423 return env;
424
425 // else a player could have our env open
426 object *envest = env->outer_env_or_self ();
427
428 // the player itself is always on a map, so we will find him here
429 // even if our inv is in a player.
430 if (envest->is_on_map ())
431 if (object *pl = envest->ms ().player ())
432 if (pl->container_ () == env)
433 return pl;
434 }
435 else
436 {
437 // maybe there is a player standing on the same mapspace
438 // this will catch the case where "this" is a player
439 if (object *pl = ms ().player ())
440 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
441 || pl->container_ () == this)
442 return pl;
443 }
444 }
445
446 return 0;
447}
448
449// adjust weight per container type ("of holding")
332static sint32 450static uint32
333weight_adjust (object *op, sint32 weight) 451weight_adjust_for (object *op, uint32 weight)
334{ 452{
335 return op->type == CONTAINER 453 return op->type == CONTAINER
336 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 454 ? weight - weight * op->stats.Str / 100
337 : weight; 455 : weight;
338} 456}
339 457
340/* 458/*
341 * add_weight(object, weight) adds the specified weight to an object, 459 * subtracts, then adds, the specified weight to an object,
342 * and also updates how much the environment(s) is/are carrying. 460 * and also updates how much the environment(s) is/are carrying.
343 */ 461 */
344static void 462static void
345add_weight (object *op, sint32 weight) 463adjust_weight (object *op, sint32 sub, sint32 add)
346{ 464{
347 while (op) 465 while (op)
348 { 466 {
349 weight = weight_adjust (op, weight); 467 sint32 ocarrying = op->carrying;
350 468
351 op->carrying += weight; 469 op->carrying -= weight_adjust_for (op, sub);
470 op->carrying += weight_adjust_for (op, add);
471
472 if (object *pl = op->visible_to ())
473 if (pl != op) // player is handled lazily
474 esrv_update_item (UPD_WEIGHT, pl, op);
475
476 sub = ocarrying;
477 add = op->carrying;
478
352 op = op->env; 479 op = op->env;
353 } 480 }
354}
355
356/*
357 * sub_weight() recursively (outwards) subtracts a number from the
358 * weight of an object (and what is carried by it's environment(s)).
359 */
360static void
361sub_weight (object *op, long weight)
362{
363 add_weight (op, -weight);
364} 481}
365 482
366/* 483/*
367 * this is a recursive function which calculates the weight 484 * this is a recursive function which calculates the weight
368 * an object is carrying. It goes through op and figures out how much 485 * an object is carrying. It goes through op and figures out how much
373{ 490{
374 sint32 sum = 0; 491 sint32 sum = 0;
375 492
376 for (object *op = inv; op; op = op->below) 493 for (object *op = inv; op; op = op->below)
377 { 494 {
378 if (op->inv)
379 op->update_weight (); 495 op->update_weight ();
380 496
381 sum += op->total_weight (); 497 sum += weight_adjust_for (this, op->total_weight ());
498 }
499
500 if (sum != carrying)
382 } 501 {
502 if (carrying != sum && carrying)//D
503 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
504 (long long)sum, (long long)carrying, debug_desc ());
383 505
384 carrying = weight_adjust (this, sum); 506 carrying = sum;
385}
386 507
508 if (object *pl = visible_to ())
509 if (pl != this) // player is handled lazily
510 esrv_update_item (UPD_WEIGHT, pl, this);
511 }
512}
513
387/* 514/*
388 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 515 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
389 * Some error messages.
390 * The result of the dump is stored in the static global errmsg array.
391 */ 516 */
392char * 517char *
393dump_object (object *op) 518dump_object (object *op)
394{ 519{
395 if (!op) 520 if (!op)
398 object_freezer freezer; 523 object_freezer freezer;
399 op->write (freezer); 524 op->write (freezer);
400 return freezer.as_string (); 525 return freezer.as_string ();
401} 526}
402 527
403/* 528char *
404 * get_nearest_part(multi-object, object 2) returns the part of the 529object::as_string ()
405 * multi-object 1 which is closest to the second object.
406 * If it's not a multi-object, it is returned.
407 */
408object *
409get_nearest_part (object *op, const object *pl)
410{ 530{
411 object *tmp, *closest; 531 return dump_object (this);
412 int last_dist, i;
413
414 if (op->more == NULL)
415 return op;
416 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)
417 if ((i = distance (tmp, pl)) < last_dist)
418 closest = tmp, last_dist = i;
419 return closest;
420} 532}
421 533
422/* 534/*
423 * Returns the object which has the count-variable equal to the argument. 535 * Returns the object which has the count-variable equal to the argument.
536 * VERRRY slow.
424 */ 537 */
425object * 538object *
426find_object (tag_t i) 539find_object (tag_t i)
427{ 540{
428 for_all_objects (op) 541 for_all_objects (op)
431 544
432 return 0; 545 return 0;
433} 546}
434 547
435/* 548/*
549 * Returns the object which has the uuid equal to the argument.
550 * MOAR VERRRY slow.
551 */
552
553object *
554find_object_uuid (UUID i)
555{
556 for_all_objects (op)
557 if (op->uuid == i)
558 return op;
559
560 return 0;
561}
562
563/*
436 * Returns the first object which has a name equal to the argument. 564 * Returns the first object which has a name equal to the argument.
437 * Used only by the patch command, but not all that useful. 565 * Used only by the patch command, but not all that useful.
438 * Enables features like "patch <name-of-other-player> food 999" 566 * Enables features like "patch <name-of-other-player> food 999"
439 */ 567 */
440object * 568object *
441find_object_name (const char *str) 569find_object_name (const char *str)
442{ 570{
443 shstr_cmp str_ (str); 571 shstr_cmp str_ (str);
444 object *op;
445 572
573 if (str_)
446 for_all_objects (op) 574 for_all_objects (op)
447 if (op->name == str_) 575 if (op->name == str_)
448 break; 576 return op;
449 577
450 return op; 578 return 0;
451} 579}
452 580
453/* 581/*
454 * Sets the owner and sets the skill and exp pointers to owner's current 582 * Sets the owner and sets the skill and exp pointers to owner's current
455 * skill and experience objects. 583 * skill and experience objects.
470 } 598 }
471 599
472 this->owner = owner; 600 this->owner = owner;
473} 601}
474 602
475int
476object::slottype () const
477{
478 if (type == SKILL)
479 {
480 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
481 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
482 }
483 else
484 {
485 if (slot [body_combat].info) return slot_combat;
486 if (slot [body_range ].info) return slot_ranged;
487 }
488
489 return slot_none;
490}
491
492bool
493object::change_weapon (object *ob)
494{
495 if (current_weapon == ob)
496 return true;
497
498 if (chosen_skill)
499 chosen_skill->flag [FLAG_APPLIED] = false;
500
501 current_weapon = ob;
502 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
503
504 if (chosen_skill)
505 chosen_skill->flag [FLAG_APPLIED] = true;
506
507 update_stats ();
508
509 if (ob)
510 {
511 // now check wether any body locations became invalid, in which case
512 // we cannot apply the weapon at the moment.
513 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
514 if (slot[i].used < 0)
515 {
516 current_weapon = chosen_skill = 0;
517 update_stats ();
518
519 new_draw_info_format (NDI_UNIQUE, 0, this,
520 "You try to balance all your items at once, "
521 "but the %s is just too much for your body. "
522 "[You need to unapply some items first.]", &ob->name);
523 return false;
524 }
525
526 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
527 }
528 else
529 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
530
531 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
532 {
533 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
534 &name, ob->debug_desc ());
535 return false;
536 }
537
538 return true;
539}
540
541/* Zero the key_values on op, decrementing the shared-string 603/* Zero the key_values on op, decrementing the shared-string
542 * refcounts and freeing the links. 604 * refcounts and freeing the links.
543 */ 605 */
544static void 606static void
545free_key_values (object *op) 607free_key_values (object *op)
553 } 615 }
554 616
555 op->key_values = 0; 617 op->key_values = 0;
556} 618}
557 619
558object & 620/*
559object::operator =(const object &src) 621 * copy_to first frees everything allocated by the dst object,
622 * and then copies the contents of itself into the second
623 * object, allocating what needs to be allocated. Basically, any
624 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
625 * if the first object is freed, the pointers in the new object
626 * will point at garbage.
627 */
628void
629object::copy_to (object *dst)
560{ 630{
561 bool is_freed = flag [FLAG_FREED]; 631 dst->remove ();
562 bool is_removed = flag [FLAG_REMOVED];
563
564 *(object_copy *)this = src; 632 *(object_copy *)dst = *this;
565
566 flag [FLAG_FREED] = is_freed;
567 flag [FLAG_REMOVED] = is_removed; 633 dst->flag [FLAG_REMOVED] = true;
568 634
569 /* Copy over key_values, if any. */ 635 /* Copy over key_values, if any. */
570 if (src.key_values) 636 if (key_values)
571 { 637 {
572 key_value *tail = 0; 638 key_value *tail = 0;
573 key_values = 0; 639 dst->key_values = 0;
574 640
575 for (key_value *i = src.key_values; i; i = i->next) 641 for (key_value *i = key_values; i; i = i->next)
576 { 642 {
577 key_value *new_link = new key_value; 643 key_value *new_link = new key_value;
578 644
579 new_link->next = 0; 645 new_link->next = 0;
580 new_link->key = i->key; 646 new_link->key = i->key;
581 new_link->value = i->value; 647 new_link->value = i->value;
582 648
583 /* Try and be clever here, too. */ 649 /* Try and be clever here, too. */
584 if (!key_values) 650 if (!dst->key_values)
585 { 651 {
586 key_values = new_link; 652 dst->key_values = new_link;
587 tail = new_link; 653 tail = new_link;
588 } 654 }
589 else 655 else
590 { 656 {
591 tail->next = new_link; 657 tail->next = new_link;
592 tail = new_link; 658 tail = new_link;
593 } 659 }
594 } 660 }
595 } 661 }
596}
597 662
598/* 663 dst->activate ();
599 * copy_to first frees everything allocated by the dst object,
600 * and then copies the contents of itself into the second
601 * object, allocating what needs to be allocated. Basically, any
602 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
603 * if the first object is freed, the pointers in the new object
604 * will point at garbage.
605 */
606void
607object::copy_to (object *dst)
608{
609 *dst = *this;
610
611 if (speed < 0)
612 dst->speed_left -= rndm ();
613
614 dst->set_speed (dst->speed);
615} 664}
616 665
617void 666void
618object::instantiate () 667object::instantiate ()
619{ 668{
620 if (!uuid.seq) // HACK 669 if (!uuid.seq) // HACK
621 uuid = UUID::gen (); 670 uuid = UUID::gen ();
622 671
672 // TODO: unclean state changes, should nt be done in copy_to AND instantiate
673 if (flag [FLAG_RANDOM_SPEED] && speed)
674 speed_left = - speed - rndm (); // TODO animation
675 else
623 speed_left = -0.1f; 676 speed_left = -1.;
677
624 /* copy the body_info to the body_used - this is only really 678 /* copy the body_info to the body_used - this is only really
625 * need for monsters, but doesn't hurt to do it for everything. 679 * need for monsters, but doesn't hurt to do it for everything.
626 * by doing so, when a monster is created, it has good starting 680 * by doing so, when a monster is created, it has good starting
627 * values for the body_used info, so when items are created 681 * values for the body_used info, so when items are created
628 * for it, they can be properly equipped. 682 * for it, they can be properly equipped.
636object * 690object *
637object::clone () 691object::clone ()
638{ 692{
639 object *neu = create (); 693 object *neu = create ();
640 copy_to (neu); 694 copy_to (neu);
695
696 // TODO: unclean state changes, should not be done in clone AND instantiate
697 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
698 neu->speed_left = - neu->speed - rndm (); // TODO animation
699
700 neu->map = map; // not copied by copy_to
641 return neu; 701 return neu;
642} 702}
643 703
644/* 704/*
645 * If an object with the IS_TURNABLE() flag needs to be turned due 705 * If an object with the IS_TURNABLE() flag needs to be turned due
647 * be called to update the face variable, _and_ how it looks on the map. 707 * be called to update the face variable, _and_ how it looks on the map.
648 */ 708 */
649void 709void
650update_turn_face (object *op) 710update_turn_face (object *op)
651{ 711{
652 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 712 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
653 return; 713 return;
654 714
655 SET_ANIMATION (op, op->direction); 715 SET_ANIMATION (op, op->direction);
656 update_object (op, UP_OBJ_FACE); 716 update_object (op, UP_OBJ_FACE);
657} 717}
662 * This function needs to be called whenever the speed of an object changes. 722 * This function needs to be called whenever the speed of an object changes.
663 */ 723 */
664void 724void
665object::set_speed (float speed) 725object::set_speed (float speed)
666{ 726{
667 if (flag [FLAG_FREED] && speed)
668 {
669 LOG (llevError, "Object %s is freed but has speed.\n", &name);
670 speed = 0;
671 }
672
673 this->speed = speed; 727 this->speed = speed;
674 728
675 if (has_active_speed ()) 729 if (has_active_speed ())
676 activate (); 730 activate ();
677 else 731 else
696 * UP_OBJ_FACE: only the objects face has changed. 750 * UP_OBJ_FACE: only the objects face has changed.
697 */ 751 */
698void 752void
699update_object (object *op, int action) 753update_object (object *op, int action)
700{ 754{
701 if (op == NULL) 755 if (!op)
702 { 756 {
703 /* this should never happen */ 757 /* this should never happen */
704 LOG (llevDebug, "update_object() called for NULL object.\n"); 758 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
705 return; 759 return;
706 } 760 }
707 761
708 if (op->env) 762 if (!op->is_on_map ())
709 { 763 {
710 /* Animation is currently handled by client, so nothing 764 /* Animation is currently handled by client, so nothing
711 * to do in this case. 765 * to do in this case.
712 */ 766 */
713 return; 767 return;
714 } 768 }
715
716 /* If the map is saving, don't do anything as everything is
717 * going to get freed anyways.
718 */
719 if (!op->map || op->map->in_memory == MAP_SAVING)
720 return;
721 769
722 /* make sure the object is within map boundaries */ 770 /* make sure the object is within map boundaries */
723 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 771 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
724 { 772 {
725 LOG (llevError, "update_object() called for object out of map!\n"); 773 LOG (llevError, "update_object() called for object out of map!\n");
733 781
734 if (!(m.flags_ & P_UPTODATE)) 782 if (!(m.flags_ & P_UPTODATE))
735 /* nop */; 783 /* nop */;
736 else if (action == UP_OBJ_INSERT) 784 else if (action == UP_OBJ_INSERT)
737 { 785 {
786#if 0
738 // this is likely overkill, TODO: revisit (schmorp) 787 // this is likely overkill, TODO: revisit (schmorp)
739 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 788 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
740 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 789 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
741 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 790 || (op->is_player () && !(m.flags_ & P_PLAYER))
742 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 791 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
743 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 792 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
744 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 793 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
745 || (m.move_on | op->move_on ) != m.move_on 794 || (m.move_on | op->move_on ) != m.move_on
746 || (m.move_off | op->move_off ) != m.move_off 795 || (m.move_off | op->move_off ) != m.move_off
747 || (m.move_slow | op->move_slow) != m.move_slow 796 || (m.move_slow | op->move_slow) != m.move_slow
748 /* This isn't perfect, but I don't expect a lot of objects to 797 /* This isn't perfect, but I don't expect a lot of objects to
749 * to have move_allow right now. 798 * have move_allow right now.
750 */ 799 */
751 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 800 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
801 m.invalidate ();
802#else
752 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 803 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
753 m.flags_ = 0; 804 m.invalidate ();
805#endif
754 } 806 }
755 /* if the object is being removed, we can't make intelligent 807 /* if the object is being removed, we can't make intelligent
756 * decisions, because remove_ob can't really pass the object 808 * decisions, because remove_ob can't really pass the object
757 * that is being removed. 809 * that is being removed.
758 */ 810 */
759 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 811 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
760 m.flags_ = 0; 812 m.invalidate ();
761 else if (action == UP_OBJ_FACE) 813 else if (action == UP_OBJ_FACE)
762 /* Nothing to do for that case */ ; 814 /* Nothing to do for that case */ ;
763 else 815 else
764 LOG (llevError, "update_object called with invalid action: %d\n", action); 816 LOG (llevError, "update_object called with invalid action: %d\n", action);
765 817
767 update_object (op->more, action); 819 update_object (op->more, action);
768} 820}
769 821
770object::object () 822object::object ()
771{ 823{
772 SET_FLAG (this, FLAG_REMOVED); 824 this->set_flag (FLAG_REMOVED);
773 825
774 expmul = 1.0; 826 //expmul = 1.0; declared const for the time being
775 face = blank_face; 827 face = blank_face;
828 material = MATERIAL_NULL;
776} 829}
777 830
778object::~object () 831object::~object ()
779{ 832{
780 unlink (); 833 unlink ();
781 834
782 free_key_values (this); 835 free_key_values (this);
783} 836}
784
785static int object_count;
786 837
787void object::link () 838void object::link ()
788{ 839{
789 assert (!index);//D 840 assert (!index);//D
790 uuid = UUID::gen (); 841 uuid = UUID::gen ();
791 count = ++object_count;
792 842
793 refcnt_inc (); 843 refcnt_inc ();
794 objects.insert (this); 844 objects.insert (this);
845
846 ++create_count;
847
795} 848}
796 849
797void object::unlink () 850void object::unlink ()
798{ 851{
799 if (!index) 852 if (!index)
800 return; 853 return;
854
855 ++destroy_count;
801 856
802 objects.erase (this); 857 objects.erase (this);
803 refcnt_dec (); 858 refcnt_dec ();
804} 859}
805 860
809 /* If already on active list, don't do anything */ 864 /* If already on active list, don't do anything */
810 if (active) 865 if (active)
811 return; 866 return;
812 867
813 if (has_active_speed ()) 868 if (has_active_speed ())
869 {
870 if (flag [FLAG_FREED])
871 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
872
814 actives.insert (this); 873 actives.insert (this);
874 }
815} 875}
816 876
817void 877void
818object::activate_recursive () 878object::activate_recursive ()
819{ 879{
868object::destroy_inv (bool drop_to_ground) 928object::destroy_inv (bool drop_to_ground)
869{ 929{
870 // need to check first, because the checks below might segfault 930 // need to check first, because the checks below might segfault
871 // as we might be on an invalid mapspace and crossfire code 931 // as we might be on an invalid mapspace and crossfire code
872 // is too buggy to ensure that the inventory is empty. 932 // is too buggy to ensure that the inventory is empty.
873 // corollary: if you create arrows etc. with stuff in tis inventory, 933 // corollary: if you create arrows etc. with stuff in its inventory,
874 // cf will crash below with off-map x and y 934 // cf will crash below with off-map x and y
875 if (!inv) 935 if (!inv)
876 return; 936 return;
877 937
878 /* Only if the space blocks everything do we not process - 938 /* Only if the space blocks everything do we not process -
880 * drop on that space. 940 * drop on that space.
881 */ 941 */
882 if (!drop_to_ground 942 if (!drop_to_ground
883 || !map 943 || !map
884 || map->in_memory != MAP_ACTIVE 944 || map->in_memory != MAP_ACTIVE
885 || map->nodrop 945 || map->no_drop
886 || ms ().move_block == MOVE_ALL) 946 || ms ().move_block == MOVE_ALL)
887 { 947 {
888 while (inv) 948 while (inv)
889 {
890 inv->destroy_inv (drop_to_ground);
891 inv->destroy (); 949 inv->destroy ();
892 }
893 } 950 }
894 else 951 else
895 { /* Put objects in inventory onto this space */ 952 { /* Put objects in inventory onto this space */
896 while (inv) 953 while (inv)
897 { 954 {
908 map->insert (op, x, y); 965 map->insert (op, x, y);
909 } 966 }
910 } 967 }
911} 968}
912 969
970/*
971 * Remove and free all objects in the inventory of the given object.
972 * Unlike destroy_inv, this assumes the *this is destroyed as well
973 * well, so we can (and have to!) take shortcuts.
974 */
975void
976object::destroy_inv_fast ()
977{
978 while (object *op = inv)
979 {
980 // remove from object the fast way
981 op->flag [FLAG_REMOVED] = true;
982 op->env = 0;
983 if ((inv = inv->below))
984 inv->above = 0;
985
986 // then destroy
987 op->destroy ();
988 }
989}
990
991void
992object::freelist_free (int count)
993{
994 while (count-- && freelist)
995 {
996 freelist_item *next = freelist->next;
997 // count is being "destroyed"
998
999 sfree ((char *)freelist, sizeof (object));
1000
1001 freelist = next;
1002 --free_count;
1003 }
1004}
1005
1006object *
913object *object::create () 1007object::create ()
914{ 1008{
915 object *op = new object; 1009 object *op;
1010
1011 if (freelist)
1012 {
1013 freelist_item li = *freelist;
1014 memset (freelist, 0, sizeof (object));
1015
1016 op = new (freelist) object;
1017 op->count = li.count;
1018
1019 freelist = li.next;
1020 --free_count;
1021 }
1022 else
1023 {
1024 void *ni = salloc0<char> (sizeof (object));
1025
1026 op = new(ni) object;
1027
1028 op->count = ++object_count;
1029 }
1030
916 op->link (); 1031 op->link ();
1032
917 return op; 1033 return op;
918} 1034}
919 1035
920void 1036void
1037object::do_delete ()
1038{
1039 uint32_t count = this->count;
1040
1041 this->~object ();
1042
1043 freelist_item *li = (freelist_item *)this;
1044 li->next = freelist;
1045 li->count = count;
1046
1047 freelist = li;
1048 ++free_count;
1049}
1050
1051static struct freed_map : maptile
1052{
1053 freed_map ()
1054 : maptile (3, 3)
1055 {
1056 path = "<freed objects map>";
1057 name = "/internal/freed_objects_map";
1058 no_drop = 1;
1059 no_reset = 1;
1060
1061 in_memory = MAP_ACTIVE;
1062 }
1063
1064 ~freed_map ()
1065 {
1066 destroy ();
1067 }
1068} freed_map; // freed objects are moved here to avoid crashes
1069
1070void
921object::do_destroy () 1071object::do_destroy ()
922{ 1072{
923 attachable::do_destroy ();
924
925 if (flag [FLAG_IS_LINKED]) 1073 if (flag [FLAG_IS_LINKED])
926 remove_button_link (this); 1074 remove_link ();
927 1075
928 if (flag [FLAG_FRIENDLY]) 1076 if (flag [FLAG_FRIENDLY])
929 remove_friendly_object (this); 1077 remove_friendly_object (this);
930 1078
931 if (!flag [FLAG_REMOVED])
932 remove (); 1079 remove ();
933 1080
934 destroy_inv (true); 1081 attachable::do_destroy ();
935 1082
936 deactivate (); 1083 deactivate ();
937 unlink (); 1084 unlink ();
938 1085
939 flag [FLAG_FREED] = 1; 1086 flag [FLAG_FREED] = 1;
940 1087
941 // hack to ensure that freed objects still have a valid map 1088 // hack to ensure that freed objects still have a valid map
942 {
943 static maptile *freed_map; // freed objects are moved here to avoid crashes
944
945 if (!freed_map)
946 {
947 freed_map = new maptile;
948
949 freed_map->path = "<freed objects map>";
950 freed_map->name = "/internal/freed_objects_map";
951 freed_map->width = 3;
952 freed_map->height = 3;
953 freed_map->nodrop = 1;
954
955 freed_map->alloc ();
956 freed_map->in_memory = MAP_ACTIVE;
957 }
958
959 map = freed_map; 1089 map = &freed_map;
960 x = 1; 1090 x = 1;
961 y = 1; 1091 y = 1;
962 }
963 1092
964 if (more) 1093 if (more)
965 { 1094 {
966 more->destroy (); 1095 more->destroy ();
967 more = 0; 1096 more = 0;
975 attacked_by = 0; 1104 attacked_by = 0;
976 current_weapon = 0; 1105 current_weapon = 0;
977} 1106}
978 1107
979void 1108void
980object::destroy (bool destroy_inventory) 1109object::destroy ()
981{ 1110{
982 if (destroyed ()) 1111 if (destroyed ())
983 return; 1112 return;
984 1113
985 if (destroy_inventory) 1114 if (!is_head () && !head->destroyed ())
1115 {
1116 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1117 head->destroy ();
1118 return;
1119 }
1120
986 destroy_inv (false); 1121 destroy_inv_fast ();
987 1122
988 if (is_head ()) 1123 if (is_head ())
989 if (sound_destroy) 1124 if (sound_destroy)
990 play_sound (sound_destroy); 1125 play_sound (sound_destroy);
991 else if (flag [FLAG_MONSTER]) 1126 else if (flag [FLAG_MONSTER])
1002 * the previous environment. 1137 * the previous environment.
1003 */ 1138 */
1004void 1139void
1005object::do_remove () 1140object::do_remove ()
1006{ 1141{
1007 object *tmp, *last = 0; 1142 if (flag [FLAG_REMOVED])
1008 object *otmp;
1009
1010 if (QUERY_FLAG (this, FLAG_REMOVED))
1011 return; 1143 return;
1012 1144
1013 SET_FLAG (this, FLAG_REMOVED);
1014 INVOKE_OBJECT (REMOVE, this); 1145 INVOKE_OBJECT (REMOVE, this);
1146
1147 flag [FLAG_REMOVED] = true;
1015 1148
1016 if (more) 1149 if (more)
1017 more->remove (); 1150 more->remove ();
1018 1151
1019 /* 1152 /*
1020 * In this case, the object to be removed is in someones 1153 * In this case, the object to be removed is in someones
1021 * inventory. 1154 * inventory.
1022 */ 1155 */
1023 if (env) 1156 if (env)
1024 { 1157 {
1025 if (nrof) 1158 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1026 sub_weight (env, weight * nrof); 1159 if (object *pl = visible_to ())
1027 else 1160 esrv_del_item (pl->contr, count);
1028 sub_weight (env, weight + carrying); 1161 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1029 1162
1030 /* NO_FIX_PLAYER is set when a great many changes are being 1163 adjust_weight (env, total_weight (), 0);
1031 * made to players inventory. If set, avoiding the call
1032 * to save cpu time.
1033 */
1034 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1035 otmp->update_stats ();
1036 1164
1037 if (above) 1165 object *pl = in_player ();
1038 above->below = below;
1039 else
1040 env->inv = below;
1041
1042 if (below)
1043 below->above = above;
1044 1166
1045 /* we set up values so that it could be inserted into 1167 /* we set up values so that it could be inserted into
1046 * the map, but we don't actually do that - it is up 1168 * the map, but we don't actually do that - it is up
1047 * to the caller to decide what we want to do. 1169 * to the caller to decide what we want to do.
1048 */ 1170 */
1049 x = env->x, y = env->y;
1050 map = env->map; 1171 map = env->map;
1051 above = 0, below = 0; 1172 x = env->x;
1173 y = env->y;
1174
1175 // make sure cmov optimisation is applicable
1176 *(above ? &above->below : &env->inv) = below;
1177 *(below ? &below->above : &above ) = above; // &above is just a dummy
1178
1179 above = 0;
1180 below = 0;
1052 env = 0; 1181 env = 0;
1182
1183 if (pl && pl->is_player ())
1184 {
1185 if (expect_false (pl->contr->combat_ob == this))
1186 {
1187 pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1188 pl->contr->combat_ob = 0;
1189 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1190 }
1191
1192 if (expect_false (pl->contr->ranged_ob == this))
1193 {
1194 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1195 pl->contr->ranged_ob = 0;
1196 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1197 }
1198
1199 pl->contr->queue_stats_update ();
1200
1201 if (expect_false (glow_radius) && pl->is_on_map ())
1202 update_all_los (pl->map, pl->x, pl->y);
1203 }
1053 } 1204 }
1054 else if (map) 1205 else if (map)
1055 { 1206 {
1056 if (type == PLAYER)
1057 {
1058 // leaving a spot always closes any open container on the ground
1059 if (container && !container->env)
1060 // this causes spurious floorbox updates, but it ensures
1061 // that the CLOSE event is being sent.
1062 close_container ();
1063
1064 --map->players;
1065 map->touch ();
1066 }
1067
1068 map->dirty = true; 1207 map->dirty = true;
1069 mapspace &ms = this->ms (); 1208 mapspace &ms = this->ms ();
1070 1209
1210 if (object *pl = ms.player ())
1211 {
1212 if (is_player ())
1213 {
1214 if (!flag [FLAG_WIZPASS])
1215 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1216
1217 // leaving a spot always closes any open container on the ground
1218 if (container && !container->env)
1219 // this causes spurious floorbox updates, but it ensures
1220 // that the CLOSE event is being sent.
1221 close_container ();
1222
1223 --map->players;
1224 map->touch ();
1225 }
1226 else if (pl->container_ () == this)
1227 {
1228 // removing a container should close it
1229 close_container ();
1230 }
1231 else
1232 esrv_del_item (pl->contr, count);
1233 }
1234
1071 /* link the object above us */ 1235 /* link the object above us */
1072 if (above) 1236 // re-link, make sure compiler can easily use cmove
1073 above->below = below; 1237 *(above ? &above->below : &ms.top) = below;
1074 else 1238 *(below ? &below->above : &ms.bot) = above;
1075 ms.top = below; /* we were top, set new top */
1076
1077 /* Relink the object below us, if there is one */
1078 if (below)
1079 below->above = above;
1080 else
1081 {
1082 /* Nothing below, which means we need to relink map object for this space
1083 * use translated coordinates in case some oddness with map tiling is
1084 * evident
1085 */
1086 if (GET_MAP_OB (map, x, y) != this)
1087 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1088
1089 ms.bot = above; /* goes on above it. */
1090 }
1091 1239
1092 above = 0; 1240 above = 0;
1093 below = 0; 1241 below = 0;
1094 1242
1243 ms.invalidate ();
1244
1095 if (map->in_memory == MAP_SAVING) 1245 if (map->in_memory == MAP_SAVING)
1096 return; 1246 return;
1097 1247
1098 int check_walk_off = !flag [FLAG_NO_APPLY]; 1248 int check_walk_off = !flag [FLAG_NO_APPLY];
1099 1249
1100 if (object *pl = ms.player ()) 1250 if (object *pl = ms.player ())
1101 { 1251 {
1102 if (pl->container == this) 1252 if (pl->container_ () == this)
1103 /* If a container that the player is currently using somehow gets 1253 /* If a container that the player is currently using somehow gets
1104 * removed (most likely destroyed), update the player view 1254 * removed (most likely destroyed), update the player view
1105 * appropriately. 1255 * appropriately.
1106 */ 1256 */
1107 pl->close_container (); 1257 pl->close_container ();
1108 1258
1259 //TODO: the floorbox prev/next might need updating
1260 //esrv_del_item (pl->contr, count);
1261 //TODO: update floorbox to preserve ordering
1262 if (pl->contr->ns)
1109 pl->contr->ns->floorbox_update (); 1263 pl->contr->ns->floorbox_update ();
1110 } 1264 }
1111 1265
1266 if (check_walk_off)
1112 for (tmp = ms.bot; tmp; tmp = tmp->above) 1267 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1113 { 1268 {
1269 above = tmp->above;
1270
1114 /* No point updating the players look faces if he is the object 1271 /* No point updating the players look faces if he is the object
1115 * being removed. 1272 * being removed.
1116 */ 1273 */
1117 1274
1118 /* See if object moving off should effect something */ 1275 /* See if object moving off should effect something */
1119 if (check_walk_off
1120 && ((move_type & tmp->move_off) 1276 if ((move_type & tmp->move_off)
1121 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1277 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1122 {
1123 move_apply (tmp, this, 0); 1278 move_apply (tmp, this, 0);
1124
1125 if (destroyed ())
1126 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1127 } 1279 }
1128 1280
1129 last = tmp; 1281 if (affects_los ())
1130 }
1131
1132 /* last == NULL if there are no objects on this space */
1133 //TODO: this makes little sense, why only update the topmost object?
1134 if (!last)
1135 map->at (x, y).flags_ = 0;
1136 else
1137 update_object (last, UP_OBJ_REMOVE);
1138
1139 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1140 update_all_los (map, x, y); 1282 update_all_los (map, x, y);
1141 } 1283 }
1142} 1284}
1143 1285
1144/* 1286/*
1158 if (!top) 1300 if (!top)
1159 for (top = op; top && top->above; top = top->above) 1301 for (top = op; top && top->above; top = top->above)
1160 ; 1302 ;
1161 1303
1162 for (; top; top = top->below) 1304 for (; top; top = top->below)
1163 {
1164 if (top == op)
1165 continue;
1166
1167 if (object::can_merge (op, top)) 1305 if (object::can_merge (op, top))
1168 { 1306 {
1169 top->nrof += op->nrof; 1307 top->nrof += op->nrof;
1170 1308
1171/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1309 if (object *pl = top->visible_to ())
1172 op->weight = 0; /* Don't want any adjustements now */ 1310 esrv_update_item (UPD_NROF, pl, top);
1311
1312 op->weight = 0; // cancel the addition above
1313 op->carrying = 0; // must be 0 already
1314
1173 op->destroy (); 1315 op->destroy ();
1316
1174 return top; 1317 return top;
1175 } 1318 }
1176 }
1177 1319
1178 return 0; 1320 return 0;
1179} 1321}
1180 1322
1181void 1323void
1186 1328
1187 object *prev = this; 1329 object *prev = this;
1188 1330
1189 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1331 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1190 { 1332 {
1191 object *op = arch_to_object (at); 1333 object *op = at->instance ();
1192 1334
1193 op->name = name; 1335 op->name = name;
1194 op->name_pl = name_pl; 1336 op->name_pl = name_pl;
1195 op->title = title; 1337 op->title = title;
1196 1338
1206 * job preparing multi-part monsters. 1348 * job preparing multi-part monsters.
1207 */ 1349 */
1208object * 1350object *
1209insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1351insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1210{ 1352{
1353 op->remove ();
1354
1211 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1355 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1212 { 1356 {
1213 tmp->x = x + tmp->arch->x; 1357 tmp->x = x + tmp->arch->x;
1214 tmp->y = y + tmp->arch->y; 1358 tmp->y = y + tmp->arch->y;
1215 } 1359 }
1232 * Passing 0 for flag gives proper default values, so flag really only needs 1376 * Passing 0 for flag gives proper default values, so flag really only needs
1233 * to be set if special handling is needed. 1377 * to be set if special handling is needed.
1234 * 1378 *
1235 * Return value: 1379 * Return value:
1236 * new object if 'op' was merged with other object 1380 * new object if 'op' was merged with other object
1237 * NULL if 'op' was destroyed 1381 * NULL if there was an error (destroyed, blocked etc.)
1238 * just 'op' otherwise 1382 * just 'op' otherwise
1239 */ 1383 */
1240object * 1384object *
1241insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1385insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1242{ 1386{
1243 assert (!op->flag [FLAG_FREED]);
1244
1245 object *top, *floor = NULL;
1246
1247 op->remove (); 1387 op->remove ();
1388
1389 if (m == &freed_map)//D TODO: remove soon
1390 {//D
1391 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1392 }//D
1248 1393
1249 /* Ideally, the caller figures this out. However, it complicates a lot 1394 /* Ideally, the caller figures this out. However, it complicates a lot
1250 * of areas of callers (eg, anything that uses find_free_spot would now 1395 * of areas of callers (eg, anything that uses find_free_spot would now
1251 * need extra work 1396 * need extra work
1252 */ 1397 */
1398 maptile *newmap = m;
1253 if (!xy_normalise (m, op->x, op->y)) 1399 if (!xy_normalise (newmap, op->x, op->y))
1254 { 1400 {
1255 op->destroy (); 1401 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1256 return 0; 1402 return 0;
1257 } 1403 }
1258 1404
1259 if (object *more = op->more) 1405 if (object *more = op->more)
1260 if (!insert_ob_in_map (more, m, originator, flag)) 1406 if (!insert_ob_in_map (more, m, originator, flag))
1261 return 0; 1407 return 0;
1262 1408
1263 CLEAR_FLAG (op, FLAG_REMOVED); 1409 op->flag [FLAG_REMOVED] = false;
1264 1410 op->env = 0;
1265 op->map = m; 1411 op->map = newmap;
1412
1266 mapspace &ms = op->ms (); 1413 mapspace &ms = op->ms ();
1267 1414
1268 /* this has to be done after we translate the coordinates. 1415 /* this has to be done after we translate the coordinates.
1269 */ 1416 */
1270 if (op->nrof && !(flag & INS_NO_MERGE)) 1417 if (op->nrof && !(flag & INS_NO_MERGE))
1271 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1418 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1272 if (object::can_merge (op, tmp)) 1419 if (object::can_merge (op, tmp))
1273 { 1420 {
1421 // TODO: we actually want to update tmp, not op,
1422 // but some caller surely breaks when we return tmp
1423 // from here :/
1274 op->nrof += tmp->nrof; 1424 op->nrof += tmp->nrof;
1275 tmp->destroy (); 1425 tmp->destroy ();
1276 } 1426 }
1277 1427
1278 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1428 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1279 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1429 op->clr_flag (FLAG_INV_LOCKED);
1280 1430
1281 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1431 if (!op->flag [FLAG_ALIVE])
1282 CLEAR_FLAG (op, FLAG_NO_STEAL); 1432 op->clr_flag (FLAG_NO_STEAL);
1283 1433
1284 if (flag & INS_BELOW_ORIGINATOR) 1434 if (flag & INS_BELOW_ORIGINATOR)
1285 { 1435 {
1286 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1436 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1287 { 1437 {
1288 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1438 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1289 abort (); 1439 abort ();
1290 } 1440 }
1291 1441
1442 if (!originator->is_on_map ())
1443 {
1444 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1445 op->debug_desc (), originator->debug_desc ());
1446 abort ();
1447 }
1448
1292 op->above = originator; 1449 op->above = originator;
1293 op->below = originator->below; 1450 op->below = originator->below;
1294
1295 if (op->below)
1296 op->below->above = op;
1297 else
1298 ms.bot = op;
1299
1300 /* since *below* originator, no need to update top */
1301 originator->below = op; 1451 originator->below = op;
1452
1453 *(op->below ? &op->below->above : &ms.bot) = op;
1302 } 1454 }
1303 else 1455 else
1304 { 1456 {
1305 top = ms.bot; 1457 object *floor = 0;
1458 object *top = ms.top;
1306 1459
1307 /* If there are other objects, then */ 1460 /* If there are other objects, then */
1308 if (top) 1461 if (top)
1309 { 1462 {
1310 object *last = 0;
1311
1312 /* 1463 /*
1313 * If there are multiple objects on this space, we do some trickier handling. 1464 * If there are multiple objects on this space, we do some trickier handling.
1314 * We've already dealt with merging if appropriate. 1465 * We've already dealt with merging if appropriate.
1315 * Generally, we want to put the new object on top. But if 1466 * Generally, we want to put the new object on top. But if
1316 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1467 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1319 * once we get to them. This reduces the need to traverse over all of 1470 * once we get to them. This reduces the need to traverse over all of
1320 * them when adding another one - this saves quite a bit of cpu time 1471 * them when adding another one - this saves quite a bit of cpu time
1321 * when lots of spells are cast in one area. Currently, it is presumed 1472 * when lots of spells are cast in one area. Currently, it is presumed
1322 * that flying non pickable objects are spell objects. 1473 * that flying non pickable objects are spell objects.
1323 */ 1474 */
1324 for (top = ms.bot; top; top = top->above) 1475 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1325 { 1476 {
1326 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1477 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1327 floor = top; 1478 floor = tmp;
1328 1479
1329 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1480 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1330 { 1481 {
1331 /* We insert above top, so we want this object below this */ 1482 /* We insert above top, so we want this object below this */
1332 top = top->below; 1483 top = tmp->below;
1333 break; 1484 break;
1334 } 1485 }
1335 1486
1336 last = top; 1487 top = tmp;
1337 } 1488 }
1338
1339 /* Don't want top to be NULL, so set it to the last valid object */
1340 top = last;
1341 1489
1342 /* We let update_position deal with figuring out what the space 1490 /* We let update_position deal with figuring out what the space
1343 * looks like instead of lots of conditions here. 1491 * looks like instead of lots of conditions here.
1344 * makes things faster, and effectively the same result. 1492 * makes things faster, and effectively the same result.
1345 */ 1493 */
1352 */ 1500 */
1353 if (!(flag & INS_ON_TOP) 1501 if (!(flag & INS_ON_TOP)
1354 && ms.flags () & P_BLOCKSVIEW 1502 && ms.flags () & P_BLOCKSVIEW
1355 && (op->face && !faces [op->face].visibility)) 1503 && (op->face && !faces [op->face].visibility))
1356 { 1504 {
1505 object *last;
1506
1357 for (last = top; last != floor; last = last->below) 1507 for (last = top; last != floor; last = last->below)
1358 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1508 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1359 break; 1509 break;
1360 1510
1361 /* Check to see if we found the object that blocks view, 1511 /* Check to see if we found the object that blocks view,
1362 * and make sure we have a below pointer for it so that 1512 * and make sure we have a below pointer for it so that
1363 * we can get inserted below this one, which requires we 1513 * we can get inserted below this one, which requires we
1369 } /* If objects on this space */ 1519 } /* If objects on this space */
1370 1520
1371 if (flag & INS_ABOVE_FLOOR_ONLY) 1521 if (flag & INS_ABOVE_FLOOR_ONLY)
1372 top = floor; 1522 top = floor;
1373 1523
1374 /* Top is the object that our object (op) is going to get inserted above. 1524 // insert object above top, or bottom-most if top = 0
1375 */
1376
1377 /* First object on this space */
1378 if (!top) 1525 if (!top)
1379 { 1526 {
1527 op->below = 0;
1380 op->above = ms.bot; 1528 op->above = ms.bot;
1381
1382 if (op->above)
1383 op->above->below = op;
1384
1385 op->below = 0;
1386 ms.bot = op; 1529 ms.bot = op;
1530
1531 *(op->above ? &op->above->below : &ms.top) = op;
1387 } 1532 }
1388 else 1533 else
1389 { /* get inserted into the stack above top */ 1534 {
1390 op->above = top->above; 1535 op->above = top->above;
1391
1392 if (op->above)
1393 op->above->below = op; 1536 top->above = op;
1394 1537
1395 op->below = top; 1538 op->below = top;
1396 top->above = op; 1539 *(op->above ? &op->above->below : &ms.top) = op;
1397 } 1540 }
1541 }
1398 1542
1399 if (!op->above) 1543 if (op->is_player ())
1400 ms.top = op;
1401 } /* else not INS_BELOW_ORIGINATOR */
1402
1403 if (op->type == PLAYER)
1404 { 1544 {
1405 op->contr->do_los = 1; 1545 op->contr->do_los = 1;
1406 ++op->map->players; 1546 ++op->map->players;
1407 op->map->touch (); 1547 op->map->touch ();
1408 } 1548 }
1409 1549
1410 op->map->dirty = true; 1550 op->map->dirty = true;
1411 1551
1412 if (object *pl = ms.player ()) 1552 if (object *pl = ms.player ())
1553 //TODO: the floorbox prev/next might need updating
1554 //esrv_send_item (pl, op);
1555 //TODO: update floorbox to preserve ordering
1556 if (pl->contr->ns)
1413 pl->contr->ns->floorbox_update (); 1557 pl->contr->ns->floorbox_update ();
1414 1558
1415 /* If this object glows, it may affect lighting conditions that are 1559 /* If this object glows, it may affect lighting conditions that are
1416 * visible to others on this map. But update_all_los is really 1560 * visible to others on this map. But update_all_los is really
1417 * an inefficient way to do this, as it means los for all players 1561 * an inefficient way to do this, as it means los for all players
1418 * on the map will get recalculated. The players could very well 1562 * on the map will get recalculated. The players could very well
1419 * be far away from this change and not affected in any way - 1563 * be far away from this change and not affected in any way -
1420 * this should get redone to only look for players within range, 1564 * this should get redone to only look for players within range,
1421 * or just updating the P_UPTODATE for spaces within this area 1565 * or just updating the P_UPTODATE for spaces within this area
1422 * of effect may be sufficient. 1566 * of effect may be sufficient.
1423 */ 1567 */
1424 if (op->map->darkness && (op->glow_radius != 0)) 1568 if (op->affects_los ())
1569 {
1570 op->ms ().invalidate ();
1425 update_all_los (op->map, op->x, op->y); 1571 update_all_los (op->map, op->x, op->y);
1572 }
1426 1573
1427 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1574 /* updates flags (blocked, alive, no magic, etc) for this map space */
1428 update_object (op, UP_OBJ_INSERT); 1575 update_object (op, UP_OBJ_INSERT);
1429 1576
1430 INVOKE_OBJECT (INSERT, op); 1577 INVOKE_OBJECT (INSERT, op);
1437 * blocked() and wall() work properly), and these flags are updated by 1584 * blocked() and wall() work properly), and these flags are updated by
1438 * update_object(). 1585 * update_object().
1439 */ 1586 */
1440 1587
1441 /* if this is not the head or flag has been passed, don't check walk on status */ 1588 /* if this is not the head or flag has been passed, don't check walk on status */
1442 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1589 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1443 { 1590 {
1444 if (check_move_on (op, originator)) 1591 if (check_move_on (op, originator, flag))
1445 return 0; 1592 return 0;
1446 1593
1447 /* If we are a multi part object, lets work our way through the check 1594 /* If we are a multi part object, let's work our way through the check
1448 * walk on's. 1595 * walk on's.
1449 */ 1596 */
1450 for (object *tmp = op->more; tmp; tmp = tmp->more) 1597 for (object *tmp = op->more; tmp; tmp = tmp->more)
1451 if (check_move_on (tmp, originator)) 1598 if (check_move_on (tmp, originator, flag))
1452 return 0; 1599 return 0;
1453 } 1600 }
1454 1601
1455 return op; 1602 return op;
1456} 1603}
1458/* this function inserts an object in the map, but if it 1605/* this function inserts an object in the map, but if it
1459 * finds an object of its own type, it'll remove that one first. 1606 * finds an object of its own type, it'll remove that one first.
1460 * op is the object to insert it under: supplies x and the map. 1607 * op is the object to insert it under: supplies x and the map.
1461 */ 1608 */
1462void 1609void
1463replace_insert_ob_in_map (const char *arch_string, object *op) 1610replace_insert_ob_in_map (shstr_tmp archname, object *op)
1464{ 1611{
1465 object *tmp, *tmp1;
1466
1467 /* first search for itself and remove any old instances */ 1612 /* first search for itself and remove any old instances */
1468 1613
1469 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1614 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1470 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1615 if (tmp->arch->archname == archname) /* same archetype */
1471 tmp->destroy (); 1616 tmp->destroy ();
1472 1617
1473 tmp1 = arch_to_object (archetype::find (arch_string)); 1618 object *tmp = archetype::find (archname)->instance ();
1474 1619
1475 tmp1->x = op->x; 1620 tmp->x = op->x;
1476 tmp1->y = op->y; 1621 tmp->y = op->y;
1622
1477 insert_ob_in_map (tmp1, op->map, op, 0); 1623 insert_ob_in_map (tmp, op->map, op, 0);
1478} 1624}
1479 1625
1480object * 1626object *
1481object::insert_at (object *where, object *originator, int flags) 1627object::insert_at (object *where, object *originator, int flags)
1482{ 1628{
1484 return where->env->insert (this); 1630 return where->env->insert (this);
1485 else 1631 else
1486 return where->map->insert (this, where->x, where->y, originator, flags); 1632 return where->map->insert (this, where->x, where->y, originator, flags);
1487} 1633}
1488 1634
1489/* 1635// check whether we can put this into the map, respect max_volume, max_items
1490 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1636bool
1491 * is returned contains nr objects, and the remaining parts contains 1637object::can_drop_at (maptile *m, int x, int y, object *originator)
1492 * the rest (or is removed and freed if that number is 0).
1493 * On failure, NULL is returned, and the reason put into the
1494 * global static errmsg array.
1495 */
1496object *
1497get_split_ob (object *orig_ob, uint32 nr)
1498{ 1638{
1499 object *newob; 1639 mapspace &ms = m->at (x, y);
1500 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1501 1640
1502 if (orig_ob->nrof < nr) 1641 int items = ms.items ();
1503 {
1504 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1505 return NULL;
1506 }
1507 1642
1508 newob = object_create_clone (orig_ob); 1643 if (!items // testing !items ensures we can drop at least one item
1644 || (items < m->max_items
1645 && ms.volume () < m->max_volume))
1646 return true;
1509 1647
1510 if ((orig_ob->nrof -= nr) < 1) 1648 if (originator && originator->is_player ())
1511 orig_ob->destroy (1); 1649 originator->contr->failmsgf (
1512 else if (!is_removed) 1650 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1513 { 1651 query_name ()
1514 if (orig_ob->env != NULL) 1652 );
1515 sub_weight (orig_ob->env, orig_ob->weight * nr);
1516 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_ACTIVE)
1517 {
1518 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1519 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1520 return NULL;
1521 }
1522 }
1523 1653
1524 newob->nrof = nr; 1654 return false;
1525
1526 return newob;
1527} 1655}
1528 1656
1529/* 1657/*
1530 * decrease_ob_nr(object, number) decreases a specified number from 1658 * decrease(object, number) decreases a specified number from
1531 * the amount of an object. If the amount reaches 0, the object 1659 * the amount of an object. If the amount reaches 0, the object
1532 * is subsequently removed and freed. 1660 * is subsequently removed and freed.
1533 * 1661 *
1534 * Return value: 'op' if something is left, NULL if the amount reached 0 1662 * Return value: 'op' if something is left, NULL if the amount reached 0
1535 */ 1663 */
1664bool
1665object::decrease (sint32 nr)
1666{
1667 if (!nr)
1668 return true;
1669
1670 nr = min (nr, nrof);
1671
1672 if (nrof > nr)
1673 {
1674 sint64 oweight = total_weight ();
1675
1676 nrof -= nr;
1677
1678 if (object *pl = visible_to ())
1679 esrv_update_item (UPD_NROF, pl, this);
1680
1681 adjust_weight (env, oweight, total_weight ());
1682
1683 return true;
1684 }
1685 else
1686 {
1687 destroy ();
1688 return false;
1689 }
1690}
1691
1692/*
1693 * split(ob,nr) splits up ob into two parts. The part which
1694 * is returned contains nr objects, and the remaining parts contains
1695 * the rest (or is removed and returned if that number is 0).
1696 * On failure, NULL is returned.
1697 */
1536object * 1698object *
1537decrease_ob_nr (object *op, uint32 i) 1699object::split (sint32 nr)
1538{ 1700{
1539 object *tmp; 1701 int have = number_of ();
1540 1702
1541 if (i == 0) /* objects with op->nrof require this check */ 1703 if (have < nr)
1542 return op; 1704 return 0;
1543 1705 else if (have == nr)
1544 if (i > op->nrof)
1545 i = op->nrof;
1546
1547 if (QUERY_FLAG (op, FLAG_REMOVED))
1548 op->nrof -= i;
1549 else if (op->env)
1550 { 1706 {
1551 /* is this object in the players inventory, or sub container
1552 * therein?
1553 */
1554 tmp = op->in_player ();
1555 /* nope. Is this a container the player has opened?
1556 * If so, set tmp to that player.
1557 * IMO, searching through all the players will mostly
1558 * likely be quicker than following op->env to the map,
1559 * and then searching the map for a player.
1560 */
1561 if (!tmp)
1562 for_all_players (pl)
1563 if (pl->ob->container == op->env)
1564 {
1565 tmp = pl->ob;
1566 break;
1567 }
1568
1569 if (i < op->nrof)
1570 {
1571 sub_weight (op->env, op->weight * i);
1572 op->nrof -= i;
1573 if (tmp)
1574 esrv_send_item (tmp, op);
1575 }
1576 else
1577 {
1578 op->remove (); 1707 remove ();
1579 op->nrof = 0; 1708 return this;
1580 if (tmp)
1581 esrv_del_item (tmp->contr, op->count);
1582 }
1583 } 1709 }
1584 else 1710 else
1585 { 1711 {
1586 object *above = op->above; 1712 decrease (nr);
1587 1713
1588 if (i < op->nrof) 1714 object *op = deep_clone ();
1589 op->nrof -= i; 1715 op->nrof = nr;
1590 else
1591 {
1592 op->remove ();
1593 op->nrof = 0;
1594 }
1595
1596 /* Since we just removed op, op->above is null */
1597 for (tmp = above; tmp; tmp = tmp->above)
1598 if (tmp->type == PLAYER)
1599 {
1600 if (op->nrof)
1601 esrv_send_item (tmp, op);
1602 else
1603 esrv_del_item (tmp->contr, op->count);
1604 }
1605 }
1606
1607 if (op->nrof)
1608 return op; 1716 return op;
1609 else
1610 {
1611 op->destroy ();
1612 return 0;
1613 } 1717 }
1614} 1718}
1615 1719
1616object * 1720object *
1617insert_ob_in_ob (object *op, object *where) 1721insert_ob_in_ob (object *op, object *where)
1642 * be != op, if items are merged. -Tero 1746 * be != op, if items are merged. -Tero
1643 */ 1747 */
1644object * 1748object *
1645object::insert (object *op) 1749object::insert (object *op)
1646{ 1750{
1647 if (!QUERY_FLAG (op, FLAG_REMOVED))
1648 op->remove ();
1649
1650 if (op->more) 1751 if (op->more)
1651 { 1752 {
1652 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1753 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1653 return op; 1754 return op;
1654 } 1755 }
1655 1756
1656 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1757 op->remove ();
1657 CLEAR_FLAG (op, FLAG_REMOVED); 1758
1759 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1658 1760
1659 if (op->nrof) 1761 if (op->nrof)
1660 {
1661 for (object *tmp = inv; tmp; tmp = tmp->below) 1762 for (object *tmp = inv; tmp; tmp = tmp->below)
1662 if (object::can_merge (tmp, op)) 1763 if (object::can_merge (tmp, op))
1663 { 1764 {
1664 /* return the original object and remove inserted object 1765 /* return the original object and remove inserted object
1665 (client needs the original object) */ 1766 (client prefers the original object) */
1767
1768 // carring must be 0 for mergable objects
1769 sint64 oweight = tmp->weight * tmp->nrof;
1770
1666 tmp->nrof += op->nrof; 1771 tmp->nrof += op->nrof;
1667 /* Weight handling gets pretty funky. Since we are adding to 1772
1668 * tmp->nrof, we need to increase the weight. 1773 if (object *pl = tmp->visible_to ())
1669 */ 1774 esrv_update_item (UPD_NROF, pl, tmp);
1775
1670 add_weight (this, op->weight * op->nrof); 1776 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1671 SET_FLAG (op, FLAG_REMOVED); 1777
1672 op->destroy (); /* free the inserted object */ 1778 op->destroy ();
1673 op = tmp; 1779 op = tmp;
1674 op->remove (); /* and fix old object's links */ 1780 goto inserted;
1675 CLEAR_FLAG (op, FLAG_REMOVED);
1676 break;
1677 } 1781 }
1678 1782
1679 /* I assume combined objects have no inventory
1680 * We add the weight - this object could have just been removed
1681 * (if it was possible to merge). calling remove_ob will subtract
1682 * the weight, so we need to add it in again, since we actually do
1683 * the linking below
1684 */
1685 add_weight (this, op->weight * op->nrof);
1686 }
1687 else
1688 add_weight (this, (op->weight + op->carrying));
1689
1690 if (object *otmp = this->in_player ())
1691 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1692 otmp->update_stats ();
1693
1694 op->owner = 0; // its his/hers now. period. 1783 op->owner = 0; // it's his/hers now. period.
1695 op->map = 0; 1784 op->map = 0;
1785 op->x = 0;
1786 op->y = 0;
1787
1788 op->above = 0;
1789 op->below = inv;
1696 op->env = this; 1790 op->env = this;
1697 op->above = 0;
1698 op->below = 0;
1699 op->x = op->y = 0;
1700 1791
1792 if (inv)
1793 inv->above = op;
1794
1795 inv = op;
1796
1797 op->flag [FLAG_REMOVED] = 0;
1798
1799 if (object *pl = op->visible_to ())
1800 esrv_send_item (pl, op);
1801
1802 adjust_weight (this, 0, op->total_weight ());
1803
1804inserted:
1701 /* reset the light list and los of the players on the map */ 1805 /* reset the light list and los of the players on the map */
1702 if (op->glow_radius && map) 1806 if (op->glow_radius && is_on_map ())
1703 { 1807 {
1704#ifdef DEBUG_LIGHTS 1808 update_stats ();
1705 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1706#endif /* DEBUG_LIGHTS */
1707 if (map->darkness)
1708 update_all_los (map, x, y); 1809 update_all_los (map, x, y);
1709 }
1710
1711 /* Client has no idea of ordering so lets not bother ordering it here.
1712 * It sure simplifies this function...
1713 */
1714 if (!inv)
1715 inv = op;
1716 else
1717 { 1810 }
1718 op->below = inv; 1811 else if (is_player ())
1719 op->below->above = op; 1812 // if this is a player's inventory, update stats
1720 inv = op; 1813 contr->queue_stats_update ();
1721 }
1722 1814
1723 INVOKE_OBJECT (INSERT, this); 1815 INVOKE_OBJECT (INSERT, this);
1724 1816
1725 return op; 1817 return op;
1726} 1818}
1744 * MSW 2001-07-08: Check all objects on space, not just those below 1836 * MSW 2001-07-08: Check all objects on space, not just those below
1745 * object being inserted. insert_ob_in_map may not put new objects 1837 * object being inserted. insert_ob_in_map may not put new objects
1746 * on top. 1838 * on top.
1747 */ 1839 */
1748int 1840int
1749check_move_on (object *op, object *originator) 1841check_move_on (object *op, object *originator, int flags)
1750{ 1842{
1843 if (op->flag [FLAG_NO_APPLY])
1844 return 0;
1845
1751 object *tmp; 1846 object *tmp;
1752 maptile *m = op->map; 1847 maptile *m = op->map;
1753 int x = op->x, y = op->y; 1848 int x = op->x, y = op->y;
1754 1849
1755 MoveType move_on, move_slow, move_block; 1850 mapspace &ms = m->at (x, y);
1756 1851
1757 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1852 ms.update ();
1758 return 0;
1759 1853
1760 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1854 MoveType move_on = ms.move_on;
1761 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1855 MoveType move_slow = ms.move_slow;
1762 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1856 MoveType move_block = ms.move_block;
1763 1857
1764 /* if nothing on this space will slow op down or be applied, 1858 /* if nothing on this space will slow op down or be applied,
1765 * no need to do checking below. have to make sure move_type 1859 * no need to do checking below. have to make sure move_type
1766 * is set, as lots of objects don't have it set - we treat that 1860 * is set, as lots of objects don't have it set - we treat that
1767 * as walking. 1861 * as walking.
1778 return 0; 1872 return 0;
1779 1873
1780 /* The objects have to be checked from top to bottom. 1874 /* The objects have to be checked from top to bottom.
1781 * Hence, we first go to the top: 1875 * Hence, we first go to the top:
1782 */ 1876 */
1783 1877 for (object *next, *tmp = ms.top; tmp; tmp = next)
1784 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1785 {
1786 /* Trim the search when we find the first other spell effect
1787 * this helps performance so that if a space has 50 spell objects,
1788 * we don't need to check all of them.
1789 */
1790 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1791 break;
1792 } 1878 {
1879 next = tmp->below;
1793 1880
1794 for (; tmp; tmp = tmp->below)
1795 {
1796 if (tmp == op) 1881 if (tmp == op)
1797 continue; /* Can't apply yourself */ 1882 continue; /* Can't apply yourself */
1798 1883
1799 /* Check to see if one of the movement types should be slowed down. 1884 /* Check to see if one of the movement types should be slowed down.
1800 * Second check makes sure that the movement types not being slowed 1885 * Second check makes sure that the movement types not being slowed
1801 * (~slow_move) is not blocked on this space - just because the 1886 * (~slow_move) is not blocked on this space - just because the
1802 * space doesn't slow down swimming (for example), if you can't actually 1887 * space doesn't slow down swimming (for example), if you can't actually
1803 * swim on that space, can't use it to avoid the penalty. 1888 * swim on that space, can't use it to avoid the penalty.
1804 */ 1889 */
1805 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1890 if (!op->flag [FLAG_WIZPASS])
1806 { 1891 {
1807 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1892 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1808 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1893 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1809 { 1894 {
1810
1811 float
1812 diff = tmp->move_slow_penalty * fabs (op->speed); 1895 float diff = tmp->move_slow_penalty * fabs (op->speed);
1813 1896
1814 if (op->type == PLAYER) 1897 if (op->is_player ())
1815 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1898 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1816 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1899 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1817 diff /= 4.0; 1900 diff /= 4.0;
1818 1901
1819 op->speed_left -= diff; 1902 op->speed_left -= diff;
1820 } 1903 }
1821 } 1904 }
1822 1905
1823 /* Basically same logic as above, except now for actual apply. */ 1906 /* Basically same logic as above, except now for actual apply. */
1824 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1907 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1825 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1908 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1826 { 1909 {
1910 if ((flags & INS_NO_AUTO_EXIT)
1911 && (tmp->type == EXIT || tmp->type == TELEPORTER
1912 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1913 continue;
1914
1827 move_apply (tmp, op, originator); 1915 move_apply (tmp, op, originator);
1828 1916
1829 if (op->destroyed ()) 1917 if (op->destroyed ())
1830 return 1; 1918 return 1;
1831 1919
1854 LOG (llevError, "Present_arch called outside map.\n"); 1942 LOG (llevError, "Present_arch called outside map.\n");
1855 return NULL; 1943 return NULL;
1856 } 1944 }
1857 1945
1858 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1946 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1859 if (tmp->arch == at) 1947 if (tmp->arch->archname == at->archname)
1860 return tmp; 1948 return tmp;
1861 1949
1862 return NULL; 1950 return NULL;
1863} 1951}
1864 1952
1928 * The first matching object is returned, or NULL if none. 2016 * The first matching object is returned, or NULL if none.
1929 */ 2017 */
1930object * 2018object *
1931present_arch_in_ob (const archetype *at, const object *op) 2019present_arch_in_ob (const archetype *at, const object *op)
1932{ 2020{
1933 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 2021 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1934 if (tmp->arch == at) 2022 if (tmp->arch->archname == at->archname)
1935 return tmp; 2023 return tmp;
1936 2024
1937 return NULL; 2025 return NULL;
1938} 2026}
1939 2027
1943void 2031void
1944flag_inv (object *op, int flag) 2032flag_inv (object *op, int flag)
1945{ 2033{
1946 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2034 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1947 { 2035 {
1948 SET_FLAG (tmp, flag); 2036 tmp->set_flag (flag);
1949 flag_inv (tmp, flag); 2037 flag_inv (tmp, flag);
1950 } 2038 }
1951} 2039}
1952 2040
1953/* 2041/*
1956void 2044void
1957unflag_inv (object *op, int flag) 2045unflag_inv (object *op, int flag)
1958{ 2046{
1959 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2047 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1960 { 2048 {
1961 CLEAR_FLAG (tmp, flag); 2049 tmp->clr_flag (flag);
1962 unflag_inv (tmp, flag); 2050 unflag_inv (tmp, flag);
1963 } 2051 }
1964} 2052}
1965 2053
1966/* 2054/*
2027 * head of the object should correspond for the entire object. 2115 * head of the object should correspond for the entire object.
2028 */ 2116 */
2029 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2117 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2030 continue; 2118 continue;
2031 2119
2032 if (ob->blocked (m, pos.x, pos.y)) 2120 if (ob->blocked (pos.m, pos.x, pos.y))
2033 continue; 2121 continue;
2034 2122
2035 altern [index++] = i; 2123 altern [index++] = i;
2036 } 2124 }
2037 2125
2105 * there is capable of. 2193 * there is capable of.
2106 */ 2194 */
2107int 2195int
2108find_dir (maptile *m, int x, int y, object *exclude) 2196find_dir (maptile *m, int x, int y, object *exclude)
2109{ 2197{
2110 int i, max = SIZEOFFREE, mflags; 2198 int max = SIZEOFFREE, mflags;
2111
2112 sint16 nx, ny;
2113 object *tmp;
2114 maptile *mp;
2115
2116 MoveType blocked, move_type; 2199 MoveType move_type;
2117 2200
2118 if (exclude && exclude->head_ () != exclude) 2201 if (exclude && exclude->head_ () != exclude)
2119 { 2202 {
2120 exclude = exclude->head; 2203 exclude = exclude->head;
2121 move_type = exclude->move_type; 2204 move_type = exclude->move_type;
2124 { 2207 {
2125 /* If we don't have anything, presume it can use all movement types. */ 2208 /* If we don't have anything, presume it can use all movement types. */
2126 move_type = MOVE_ALL; 2209 move_type = MOVE_ALL;
2127 } 2210 }
2128 2211
2129 for (i = 1; i < max; i++) 2212 for (int i = 1; i < max; i++)
2130 { 2213 {
2131 mp = m; 2214 mapxy pos (m, x, y);
2132 nx = x + freearr_x[i]; 2215 pos.move (i);
2133 ny = y + freearr_y[i];
2134 2216
2135 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2217 if (!pos.normalise ())
2136
2137 if (mflags & P_OUT_OF_MAP)
2138 max = maxfree[i]; 2218 max = maxfree[i];
2139 else 2219 else
2140 { 2220 {
2141 mapspace &ms = mp->at (nx, ny); 2221 mapspace &ms = *pos;
2142 2222
2143 blocked = ms.move_block;
2144
2145 if ((move_type & blocked) == move_type) 2223 if ((move_type & ms.move_block) == move_type)
2146 max = maxfree[i]; 2224 max = maxfree [i];
2147 else if (mflags & P_IS_ALIVE) 2225 else if (ms.flags () & P_IS_ALIVE)
2148 { 2226 {
2149 for (tmp = ms.bot; tmp; tmp = tmp->above) 2227 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2150 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2228 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2151 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2229 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2152 break;
2153
2154 if (tmp)
2155 return freedir[i]; 2230 return freedir [i];
2156 } 2231 }
2157 } 2232 }
2158 } 2233 }
2159 2234
2160 return 0; 2235 return 0;
2169{ 2244{
2170 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2245 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2171} 2246}
2172 2247
2173/* 2248/*
2174 * find_dir_2(delta-x,delta-y) will return a direction in which 2249 * find_dir_2(delta-x,delta-y) will return a direction value
2175 * an object which has subtracted the x and y coordinates of another 2250 * for running into direct [dx, dy].
2176 * object, needs to travel toward it. 2251 * (the opposite of crossfire's find_dir_2!)
2177 */ 2252 */
2178int 2253int
2179find_dir_2 (int x, int y) 2254find_dir_2 (int x, int y)
2180{ 2255{
2256#if 1 // new algorithm
2257 // this works by putting x, y into 16 sectors, which
2258 // are not equal sized, but are a better approximation
2259 // then the old algorithm, and then using a mapping
2260 // table to map it into a direction value.
2261 // basically, it maps these comparisons to each bit
2262 // bit #3: x < 0
2263 // bit #2: y < 0
2264 // bit #1: x > y
2265 // bit #0: x > 2y
2266
2267 static const uint8 dir[16] = {
2268 4, 5, 4, 3,
2269 2, 1, 2, 3,
2270 6, 5, 6, 7,
2271 8, 1, 8, 7,
2272 };
2273 int sector = 0;
2274
2275 // this is a bit ugly, but more likely to result in branchless code
2276 sector |= x < 0 ? 8 : 0;
2277 x = x < 0 ? -x : x; // abs
2278
2279 sector |= y < 0 ? 4 : 0;
2280 y = y < 0 ? -y : y; // abs
2281
2282 if (x > y)
2283 {
2284 sector |= 2;
2285
2286 if (x > y * 2)
2287 sector |= 1;
2288 }
2289 else
2290 {
2291 if (y > x * 2)
2292 sector |= 1;
2293 else if (!y)
2294 return 0; // x == 0 here
2295 }
2296
2297 return dir [sector];
2298#else // old algorithm
2181 int q; 2299 int q;
2182 2300
2183 if (y) 2301 if (y)
2184 q = x * 100 / y; 2302 q = 128 * x / y;
2185 else if (x) 2303 else if (x)
2186 q = -300 * x; 2304 q = -512 * x; // to make it > 309
2187 else 2305 else
2188 return 0; 2306 return 0;
2189 2307
2190 if (y > 0) 2308 if (y > 0)
2191 { 2309 {
2192 if (q < -242) 2310 if (q < -309) return 7;
2311 if (q < -52) return 6;
2312 if (q < 52) return 5;
2313 if (q < 309) return 4;
2314
2193 return 3; 2315 return 3;
2194 if (q < -41) 2316 }
2195 return 2; 2317 else
2196 if (q < 41) 2318 {
2197 return 1; 2319 if (q < -309) return 3;
2198 if (q < 242) 2320 if (q < -52) return 2;
2199 return 8; 2321 if (q < 52) return 1;
2322 if (q < 309) return 8;
2323
2200 return 7; 2324 return 7;
2201 } 2325 }
2202 2326#endif
2203 if (q < -242)
2204 return 7;
2205 if (q < -41)
2206 return 6;
2207 if (q < 41)
2208 return 5;
2209 if (q < 242)
2210 return 4;
2211
2212 return 3;
2213} 2327}
2214 2328
2215/* 2329/*
2216 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2330 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2217 * between two directions (which are expected to be absolute (see absdir()) 2331 * between two directions (which are expected to be absolute (see absdir())
2218 */ 2332 */
2219int 2333int
2220dirdiff (int dir1, int dir2) 2334dirdiff (int dir1, int dir2)
2221{ 2335{
2222 int d;
2223
2224 d = abs (dir1 - dir2); 2336 int d = abs (dir1 - dir2);
2225 if (d > 4)
2226 d = 8 - d;
2227 2337
2228 return d; 2338 return d > 4 ? 8 - d : d;
2229} 2339}
2230 2340
2231/* peterm: 2341/* peterm:
2232 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2342 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2233 * Basically, this is a table of directions, and what directions 2343 * Basically, this is a table of directions, and what directions
2235 * This basically means that if direction is 15, then it could either go 2345 * This basically means that if direction is 15, then it could either go
2236 * direction 4, 14, or 16 to get back to where we are. 2346 * direction 4, 14, or 16 to get back to where we are.
2237 * Moved from spell_util.c to object.c with the other related direction 2347 * Moved from spell_util.c to object.c with the other related direction
2238 * functions. 2348 * functions.
2239 */ 2349 */
2240int reduction_dir[SIZEOFFREE][3] = { 2350static const int reduction_dir[SIZEOFFREE][3] = {
2241 {0, 0, 0}, /* 0 */ 2351 {0, 0, 0}, /* 0 */
2242 {0, 0, 0}, /* 1 */ 2352 {0, 0, 0}, /* 1 */
2243 {0, 0, 0}, /* 2 */ 2353 {0, 0, 0}, /* 2 */
2244 {0, 0, 0}, /* 3 */ 2354 {0, 0, 0}, /* 3 */
2245 {0, 0, 0}, /* 4 */ 2355 {0, 0, 0}, /* 4 */
2339 * Add a check so we can't pick up invisible objects (0.93.8) 2449 * Add a check so we can't pick up invisible objects (0.93.8)
2340 */ 2450 */
2341int 2451int
2342can_pick (const object *who, const object *item) 2452can_pick (const object *who, const object *item)
2343{ 2453{
2344 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2454 return /*who->flag [FLAG_WIZ]|| */
2345 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2455 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2346 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2456 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2347} 2457}
2348 2458
2349/* 2459/*
2350 * create clone from object to another 2460 * create clone from object to another
2351 */ 2461 */
2352object * 2462object *
2353object_create_clone (object *asrc) 2463object::deep_clone ()
2354{ 2464{
2355 object *dst = 0, *tmp, *src, *prev, *item; 2465 assert (("deep_clone called on non-head object", is_head ()));
2356 2466
2357 if (!asrc) 2467 object *dst = clone ();
2358 return 0;
2359 2468
2360 src = asrc->head_ (); 2469 object *prev = dst;
2361
2362 prev = 0;
2363 for (object *part = src; part; part = part->more) 2470 for (object *part = this->more; part; part = part->more)
2364 { 2471 {
2365 tmp = part->clone (); 2472 object *tmp = part->clone ();
2366 tmp->x -= src->x;
2367 tmp->y -= src->y;
2368
2369 if (!part->head)
2370 {
2371 dst = tmp;
2372 tmp->head = 0;
2373 }
2374 else
2375 tmp->head = dst; 2473 tmp->head = dst;
2376
2377 tmp->more = 0;
2378
2379 if (prev)
2380 prev->more = tmp; 2474 prev->more = tmp;
2381
2382 prev = tmp; 2475 prev = tmp;
2383 } 2476 }
2384 2477
2385 for (item = src->inv; item; item = item->below) 2478 for (object *item = inv; item; item = item->below)
2386 insert_ob_in_ob (object_create_clone (item), dst); 2479 insert_ob_in_ob (item->deep_clone (), dst);
2387 2480
2388 return dst; 2481 return dst;
2389} 2482}
2390 2483
2391/* This returns the first object in who's inventory that 2484/* This returns the first object in who's inventory that
2400 return tmp; 2493 return tmp;
2401 2494
2402 return 0; 2495 return 0;
2403} 2496}
2404 2497
2405/* If ob has a field named key, return the link from the list, 2498shstr_tmp
2406 * otherwise return NULL. 2499object::kv_get (shstr_tmp key) const
2407 *
2408 * key must be a passed in shared string - otherwise, this won't
2409 * do the desired thing.
2410 */
2411key_value *
2412get_ob_key_link (const object *ob, const char *key)
2413{ 2500{
2414 for (key_value *link = ob->key_values; link; link = link->next) 2501 for (key_value *kv = key_values; kv; kv = kv->next)
2415 if (link->key == key) 2502 if (kv->key == key)
2416 return link;
2417
2418 return 0;
2419}
2420
2421/*
2422 * Returns the value of op has an extra_field for key, or NULL.
2423 *
2424 * The argument doesn't need to be a shared string.
2425 *
2426 * The returned string is shared.
2427 */
2428const char *
2429get_ob_key_value (const object *op, const char *const key)
2430{
2431 key_value *link;
2432 shstr_cmp canonical_key (key);
2433
2434 if (!canonical_key)
2435 {
2436 /* 1. There being a field named key on any object
2437 * implies there'd be a shared string to find.
2438 * 2. Since there isn't, no object has this field.
2439 * 3. Therefore, *this* object doesn't have this field.
2440 */
2441 return 0;
2442 }
2443
2444 /* This is copied from get_ob_key_link() above -
2445 * only 4 lines, and saves the function call overhead.
2446 */
2447 for (link = op->key_values; link; link = link->next)
2448 if (link->key == canonical_key)
2449 return link->value; 2503 return kv->value;
2450 2504
2451 return 0; 2505 return shstr ();
2452} 2506}
2453 2507
2454/* 2508void
2455 * Updates the canonical_key in op to value. 2509object::kv_set (shstr_tmp key, shstr_tmp value)
2456 *
2457 * canonical_key is a shared string (value doesn't have to be).
2458 *
2459 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2460 * keys.
2461 *
2462 * Returns TRUE on success.
2463 */
2464int
2465set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2466{ 2510{
2467 key_value *field = NULL, *last = NULL; 2511 for (key_value *kv = key_values; kv; kv = kv->next)
2468 2512 if (kv->key == key)
2469 for (field = op->key_values; field != NULL; field = field->next)
2470 {
2471 if (field->key != canonical_key)
2472 { 2513 {
2473 last = field; 2514 kv->value = value;
2474 continue; 2515 return;
2475 } 2516 }
2476 2517
2477 if (value) 2518 key_value *kv = new key_value;
2478 field->value = value; 2519
2479 else 2520 kv->next = key_values;
2521 kv->key = key;
2522 kv->value = value;
2523
2524 key_values = kv;
2525}
2526
2527void
2528object::kv_del (shstr_tmp key)
2529{
2530 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2531 if ((*kvp)->key == key)
2480 { 2532 {
2481 /* Basically, if the archetype has this key set, 2533 key_value *kv = *kvp;
2482 * we need to store the null value so when we save 2534 *kvp = (*kvp)->next;
2483 * it, we save the empty value so that when we load, 2535 delete kv;
2484 * we get this value back again. 2536 return;
2485 */
2486 if (get_ob_key_link (op->arch, canonical_key))
2487 field->value = 0;
2488 else
2489 {
2490 if (last)
2491 last->next = field->next;
2492 else
2493 op->key_values = field->next;
2494
2495 delete field;
2496 }
2497 } 2537 }
2498 return TRUE;
2499 }
2500 /* IF we get here, key doesn't exist */
2501
2502 /* No field, we'll have to add it. */
2503
2504 if (!add_key)
2505 return FALSE;
2506
2507 /* There isn't any good reason to store a null
2508 * value in the key/value list. If the archetype has
2509 * this key, then we should also have it, so shouldn't
2510 * be here. If user wants to store empty strings,
2511 * should pass in ""
2512 */
2513 if (value == NULL)
2514 return TRUE;
2515
2516 field = new key_value;
2517
2518 field->key = canonical_key;
2519 field->value = value;
2520 /* Usual prepend-addition. */
2521 field->next = op->key_values;
2522 op->key_values = field;
2523
2524 return TRUE;
2525}
2526
2527/*
2528 * Updates the key in op to value.
2529 *
2530 * If add_key is FALSE, this will only update existing keys,
2531 * and not add new ones.
2532 * In general, should be little reason FALSE is ever passed in for add_key
2533 *
2534 * Returns TRUE on success.
2535 */
2536int
2537set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2538{
2539 shstr key_ (key);
2540
2541 return set_ob_key_value_s (op, key_, value, add_key);
2542} 2538}
2543 2539
2544object::depth_iterator::depth_iterator (object *container) 2540object::depth_iterator::depth_iterator (object *container)
2545: iterator_base (container) 2541: iterator_base (container)
2546{ 2542{
2596{ 2592{
2597 char flagdesc[512]; 2593 char flagdesc[512];
2598 char info2[256 * 4]; 2594 char info2[256 * 4];
2599 char *p = info; 2595 char *p = info;
2600 2596
2601 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2597 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2602 count, 2598 count,
2603 uuid.c_str (), 2599 uuid.c_str (),
2604 &name, 2600 &name,
2605 title ? "\",title:\"" : "", 2601 title ? ",title:\"" : "",
2606 title ? (const char *)title : "", 2602 title ? (const char *)title : "",
2603 title ? "\"" : "",
2607 flag_desc (flagdesc, 512), type); 2604 flag_desc (flagdesc, 512), type);
2608 2605
2609 if (!this->flag[FLAG_REMOVED] && env) 2606 if (!flag[FLAG_REMOVED] && env)
2610 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2607 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2611 2608
2612 if (map) 2609 if (map)
2613 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2610 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2614 2611
2629{ 2626{
2630 return map ? map->region (x, y) 2627 return map ? map->region (x, y)
2631 : region::default_region (); 2628 : region::default_region ();
2632} 2629}
2633 2630
2634const materialtype_t *
2635object::dominant_material () const
2636{
2637 if (materialtype_t *mt = name_to_material (materialname))
2638 return mt;
2639
2640 return name_to_material (shstr_unknown);
2641}
2642
2643void 2631void
2644object::open_container (object *new_container) 2632object::open_container (object *new_container)
2645{ 2633{
2646 if (container == new_container) 2634 if (container == new_container)
2647 return; 2635 return;
2648 2636
2649 if (object *old_container = container) 2637 object *old_container = container;
2638
2639 if (old_container)
2650 { 2640 {
2651 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2641 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2652 return; 2642 return;
2653 2643
2654#if 0 2644#if 0
2656 if (object *closer = old_container->inv) 2646 if (object *closer = old_container->inv)
2657 if (closer->type == CLOSE_CON) 2647 if (closer->type == CLOSE_CON)
2658 closer->destroy (); 2648 closer->destroy ();
2659#endif 2649#endif
2660 2650
2651 // make sure the container is available
2652 esrv_send_item (this, old_container);
2653
2661 old_container->flag [FLAG_APPLIED] = 0; 2654 old_container->flag [FLAG_APPLIED] = false;
2662 container = 0; 2655 container = 0;
2663 2656
2657 // client needs item update to make it work, client bug requires this to be separate
2664 esrv_update_item (UPD_FLAGS, this, old_container); 2658 esrv_update_item (UPD_FLAGS, this, old_container);
2659
2665 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2660 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2666 play_sound (sound_find ("chest_close")); 2661 play_sound (sound_find ("chest_close"));
2667 } 2662 }
2668 2663
2669 if (new_container) 2664 if (new_container)
2670 { 2665 {
2674 // TODO: this does not seem to serve any purpose anymore? 2669 // TODO: this does not seem to serve any purpose anymore?
2675#if 0 2670#if 0
2676 // insert the "Close Container" object. 2671 // insert the "Close Container" object.
2677 if (archetype *closer = new_container->other_arch) 2672 if (archetype *closer = new_container->other_arch)
2678 { 2673 {
2679 object *closer = arch_to_object (new_container->other_arch); 2674 object *closer = new_container->other_arch->instance ();
2680 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2675 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2681 new_container->insert (closer); 2676 new_container->insert (closer);
2682 } 2677 }
2683#endif 2678#endif
2684 2679
2685 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2680 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2686 2681
2682 // make sure the container is available, client bug requires this to be separate
2683 esrv_send_item (this, new_container);
2684
2687 new_container->flag [FLAG_APPLIED] = 1; 2685 new_container->flag [FLAG_APPLIED] = true;
2688 container = new_container; 2686 container = new_container;
2689 2687
2688 // client needs flag change
2690 esrv_update_item (UPD_FLAGS, this, new_container); 2689 esrv_update_item (UPD_FLAGS, this, new_container);
2691 esrv_send_inventory (this, new_container); 2690 esrv_send_inventory (this, new_container);
2692 play_sound (sound_find ("chest_open")); 2691 play_sound (sound_find ("chest_open"));
2693 } 2692 }
2693// else if (!old_container->env && contr && contr->ns)
2694// contr->ns->floorbox_reset ();
2694} 2695}
2695 2696
2696object * 2697object *
2697object::force_find (const shstr name) 2698object::force_find (shstr_tmp name)
2698{ 2699{
2699 /* cycle through his inventory to look for the MARK we want to 2700 /* cycle through his inventory to look for the MARK we want to
2700 * place 2701 * place
2701 */ 2702 */
2702 for (object *tmp = inv; tmp; tmp = tmp->below) 2703 for (object *tmp = inv; tmp; tmp = tmp->below)
2704 return splay (tmp); 2705 return splay (tmp);
2705 2706
2706 return 0; 2707 return 0;
2707} 2708}
2708 2709
2710//-GPL
2711
2709void 2712void
2713object::force_set_timer (int duration)
2714{
2715 this->duration = 1;
2716 this->speed_left = -1.f;
2717
2718 this->set_speed (duration ? 1.f / duration : 0.f);
2719}
2720
2721object *
2710object::force_add (const shstr name, int duration) 2722object::force_add (shstr_tmp name, int duration)
2711{ 2723{
2712 if (object *force = force_find (name)) 2724 if (object *force = force_find (name))
2713 force->destroy (); 2725 force->destroy ();
2714 2726
2715 object *force = get_archetype (FORCE_NAME); 2727 object *force = get_archetype (FORCE_NAME);
2716 2728
2717 force->slaying = name; 2729 force->slaying = name;
2718 force->stats.food = 1; 2730 force->force_set_timer (duration);
2719 force->speed_left = -1.f;
2720
2721 force->set_speed (duration ? 1.f / duration : 0.f);
2722 force->flag [FLAG_IS_USED_UP] = true;
2723 force->flag [FLAG_APPLIED] = true; 2731 force->flag [FLAG_APPLIED] = true;
2724 2732
2725 insert (force); 2733 return insert (force);
2726} 2734}
2727 2735
2728void 2736void
2729object::play_sound (faceidx sound) const 2737object::play_sound (faceidx sound) const
2730{ 2738{
2731 if (!sound) 2739 if (!sound)
2732 return; 2740 return;
2733 2741
2734 if (flag [FLAG_REMOVED]) 2742 if (is_on_map ())
2743 map->play_sound (sound, x, y);
2744 else if (object *pl = in_player ())
2745 pl->contr->play_sound (sound);
2746}
2747
2748void
2749object::say_msg (const char *msg) const
2750{
2751 if (is_on_map ())
2752 map->say_msg (msg, x, y);
2753 else if (object *pl = in_player ())
2754 pl->contr->play_sound (sound);
2755}
2756
2757void
2758object::make_noise ()
2759{
2760 // we do not model noise in the map, so instead put
2761 // a temporary light into the noise source
2762 // could use the map instead, but that's less reliable for our
2763 // goal, which is to make invisibility a bit harder to exploit
2764
2765 // currently only works sensibly for players
2766 if (!is_player ())
2735 return; 2767 return;
2736 2768
2737 if (env) 2769 // find old force, or create new one
2738 { 2770 object *force = force_find (shstr_noise_force);
2739 if (object *pl = in_player ()) 2771
2740 pl->contr->play_sound (sound); 2772 if (force)
2741 } 2773 force->speed_left = -1.f; // patch old speed up
2742 else 2774 else
2743 map->play_sound (sound, x, y); 2775 {
2744} 2776 force = archetype::get (shstr_noise_force);
2745 2777
2778 force->slaying = shstr_noise_force;
2779 force->stats.food = 1;
2780 force->speed_left = -1.f;
2781
2782 force->set_speed (1.f / 4.f);
2783 force->flag [FLAG_IS_USED_UP] = true;
2784 force->flag [FLAG_APPLIED] = true;
2785
2786 insert (force);
2787 }
2788}
2789
2790void object::change_move_type (MoveType mt)
2791{
2792 if (move_type == mt)
2793 return;
2794
2795 if (is_on_map ())
2796 {
2797 // we are on the map, so handle move_on/off effects
2798 remove ();
2799 move_type = mt;
2800 map->insert (this, x, y, this);
2801 }
2802 else
2803 move_type = mt;
2804}
2805
2806/* object should be a player.
2807 * we return the object the player has marked with the 'mark' command
2808 * below. If no match is found (or object has changed), we return
2809 * NULL. We leave it up to the calling function to print messages if
2810 * nothing is found.
2811 */
2812object *
2813object::mark () const
2814{
2815 if (contr && contr->mark && contr->mark->env == this)
2816 return contr->mark;
2817 else
2818 return 0;
2819}
2820

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines