ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.217 by root, Wed Apr 23 07:13:23 2008 UTC vs.
Revision 1.345 by root, Sun May 1 16:58:15 2011 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
40 49
41short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
42 0, 51 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 57 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 61};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
60 0, 63 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 67};
65 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
76const char *wall_suffix[16] = {
77 "0",
78 "1_3",
79 "1_4",
80 "2_1_2",
81 "1_2",
82 "2_2_4",
83 "2_2_1",
84 "3_1",
85 "1_1",
86 "2_2_3",
87 "2_2_2",
88 "3_3",
89 "2_1_1",
90 "3_4",
91 "3_2",
92 "4"
93};
94
66static void 95static void
67write_uuid (uval64 skip, bool sync) 96write_uuid (uval64 skip, bool sync)
68{ 97{
69 CALL_BEGIN (2); 98 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 99 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 101 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 102 CALL_END;
74} 103}
75 104
76static void 105static void
77read_uuid (void) 106read_uuid ()
78{ 107{
79 char filename[MAX_BUF]; 108 char filename[MAX_BUF];
80 109
81 sprintf (filename, "%s/uuid", settings.localdir); 110 sprintf (filename, "%s/uuid", settings.localdir);
82 111
96 125
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 126 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 127 _exit (1);
99 } 128 }
100 129
101 UUID::BUF buf; 130 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 131 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 132 fgets (buf, sizeof (buf), fp);
104 133
105 if (!UUID::cur.parse (buf)) 134 if (!UUID::cur.parse (buf))
106 { 135 {
133 162
134void 163void
135UUID::init () 164UUID::init ()
136{ 165{
137 read_uuid (); 166 read_uuid ();
167}
168
169bool
170UUID::parse (const char *s)
171{
172 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
173 return false;
174
175 seq = 0;
176
177 while (*s != '>')
178 {
179 if (*s < '0')
180 return false;
181
182 // this gives nice branchless code with gcc
183 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
184 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
185
186 seq = (seq << 4) | digit;
187
188 ++s;
189 }
190
191 return true;
192}
193
194char *
195UUID::append (char *buf) const
196{
197 *buf++ = '<';
198 *buf++ = '1';
199 *buf++ = '.';
200
201 uint64_t seq = this->seq;
202 const int bits = 64;
203 char nz = 0;
204 static const char tohex [] = "0123456789abcdef";
205
206 // assert (len >= 3 + bits / 4 + 1 + 1);
207 for (int i = bits / 4; --i; )
208 {
209 uint8_t digit = seq >> (bits - 4);
210
211 *buf = tohex [digit];
212 nz |= digit;
213 buf += nz ? 1 : 0;
214 seq <<= 4;
215 }
216
217 // last digit is special - always emit
218 uint8_t digit = seq >> (bits - 4);
219 *buf++ = tohex [digit];
220
221 *buf++ = '>';
222
223 return buf;
224}
225
226char *
227UUID::c_str () const
228{
229 static char buf [MAX_LEN];
230 *append (buf) = 0;
231 return buf;
138} 232}
139 233
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 234/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 235static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 236compare_ob_value_lists_one (const object *wants, const object *has)
143{ 237{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 238 /* n-squared behaviour (see kv.get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 239 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 240 * different structure or at least keep the lists sorted...
149 */ 241 */
150 242
151 /* For each field in wants, */ 243 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 244 for (key_value *kv = wants->kv.first; kv; kv = kv->next)
153 { 245 if (has->kv.get (kv->key) != kv->value)
154 key_value *has_field; 246 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 247
169 /* If we get here, every field in wants has a matching field in has. */ 248 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 249 return true;
171} 250}
172 251
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 252/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 253static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 254compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 255{
177 /* However, there may be fields in has which aren't partnered in wants, 256 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 257 * so we need to run the comparison *twice*. :(
179 */ 258 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 259 return compare_ob_value_lists_one (ob1, ob2)
260 && compare_ob_value_lists_one (ob2, ob1);
181} 261}
182 262
183/* Function examines the 2 objects given to it, and returns true if 263/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 264 * they can be merged together.
185 * 265 *
192 * Improvements made with merge: Better checking on potion, and also 272 * Improvements made with merge: Better checking on potion, and also
193 * check weight 273 * check weight
194 */ 274 */
195bool object::can_merge_slow (object *ob1, object *ob2) 275bool object::can_merge_slow (object *ob1, object *ob2)
196{ 276{
197 /* A couple quicksanity checks */ 277 /* A couple quick sanity checks */
198 if (ob1 == ob2 278 if (ob1 == ob2
199 || ob1->type != ob2->type 279 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 280 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 281 || ob1->name != ob2->name
282 || ob1->custom_name != ob2->custom_name
283 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
203 return 0; 284 return 0;
204 285
205 /* Do not merge objects if nrof would overflow. First part checks 286 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 287 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 288 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 289 return 0;
212 290
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 291 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 292 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 293 * just can't ignore the been applied or identified flags, as they
216 * are not equal - just if it has been identified, the been_applied 294 * are not equal - just if it has been identified, the been_applied
217 * flags lose any meaning. 295 * flags lose any meaning.
218 */ 296 */
219 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 297 if (ob1->flag [FLAG_IDENTIFIED])
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 298 ob1->set_flag (FLAG_BEEN_APPLIED);
221 299
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 300 if (ob2->flag [FLAG_IDENTIFIED])
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 301 ob2->set_flag (FLAG_BEEN_APPLIED);
224 302
225 if (ob1->arch->name != ob2->arch->name 303 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 304 || ob1->name != ob2->name
227 || ob1->title != ob2->title 305 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 306 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 307 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 308 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 309 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 310 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 311 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 312 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 313 || ob1->animation_id != ob2->animation_id
314 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
236 || ob1->client_type != ob2->client_type 315 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 316 || ob1->material != ob2->material
238 || ob1->lore != ob2->lore 317 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 318 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 319 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 320 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 321 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 322 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 323 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 324 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 325 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 326 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 327 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 328 return 0;
250 329
251 if ((ob1->flag ^ ob2->flag) 330 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 331 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 332 .reset (FLAG_REMOVED)
255 .any ()) 333 .any ())
256 return 0; 334 return 0;
257 335
258 /* This is really a spellbook check - we should in general 336 /* This is really a spellbook check - we should in general
277 355
278 /* Don't merge objects that are applied. With the new 'body' code, 356 /* Don't merge objects that are applied. With the new 'body' code,
279 * it is possible for most any character to have more than one of 357 * it is possible for most any character to have more than one of
280 * some items equipped, and we don't want those to merge. 358 * some items equipped, and we don't want those to merge.
281 */ 359 */
282 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 360 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
283 return 0; 361 return 0;
284 362
285 /* Note sure why the following is the case - either the object has to 363 /* Note sure why the following is the case - either the object has to
286 * be animated or have a very low speed. Is this an attempted monster 364 * be animated or have a very low speed. Is this an attempted monster
287 * check? 365 * check?
288 */ 366 */
289 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 367 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
290 return 0; 368 return 0;
291 369
292 switch (ob1->type) 370 switch (ob1->type)
293 { 371 {
294 case SCROLL: 372 case SCROLL:
295 if (ob1->level != ob2->level) 373 if (ob1->level != ob2->level)
296 return 0; 374 return 0;
297 break; 375 break;
298 } 376 }
299 377
300 if (ob1->key_values || ob2->key_values) 378 if (!ob1->kv.empty () || !ob2->kv.empty ())
301 { 379 {
302 /* At least one of these has key_values. */ 380 /* At least one of these has key_values. */
303 if ((!ob1->key_values) != (!ob2->key_values)) 381 if (ob1->kv.empty () != ob2->kv.empty ())
304 return 0; /* One has fields, but the other one doesn't. */ 382 return 0; /* One has fields, but the other one doesn't. */
305 383
306 if (!compare_ob_value_lists (ob1, ob2)) 384 if (!compare_ob_value_lists (ob1, ob2))
307 return 0; 385 return 0;
308 } 386 }
334 412
335// find player who can see this object 413// find player who can see this object
336object * 414object *
337object::visible_to () const 415object::visible_to () const
338{ 416{
339 if (!flag [FLAG_REMOVED]) 417 if (client_visible () && !flag [FLAG_REMOVED])
340 { 418 {
341 // see if we are in a container of sorts 419 // see if we are in a container of sorts
342 if (env) 420 if (env)
343 { 421 {
344 // the player inventory itself is always visible 422 // the player inventory itself is always visible
345 if (env->type == PLAYER) 423 if (env->is_player ())
346 return env; 424 return env;
347 425
348 // else a player could have our env open 426 // else a player could have our env open
349 object *envest = env->outer_env (); 427 object *envest = env->outer_env_or_self ();
350 428
351 // the player itself is always on a map, so we will find him here 429 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 430 // even if our inv is in a player.
353 if (envest->is_on_map ()) 431 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 432 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 433 if (pl->container_ () == env)
356 return pl; 434 return pl;
357 } 435 }
358 else 436 else
359 { 437 {
360 // maybe there is a player standing on the same mapspace 438 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 439 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 440 if (object *pl = ms ().player ())
441 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
442 || pl->container_ () == this)
363 return pl; 443 return pl;
364 } 444 }
365 } 445 }
366 446
367 return 0; 447 return 0;
368} 448}
369 449
370// adjust weight per container type ("of holding") 450// adjust weight per container type ("of holding")
371static sint32 451static uint32
372weight_adjust (object *op, sint32 weight) 452weight_adjust_for (object *op, uint32 weight)
373{ 453{
374 return op->type == CONTAINER 454 return op->type == CONTAINER
375 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 455 ? weight - weight * op->stats.Str / 100
376 : weight; 456 : weight;
377} 457}
378 458
379/* 459/*
380 * adjust_weight(object, weight) adds the specified weight to an object, 460 * subtracts, then adds, the specified weight to an object,
381 * and also updates how much the environment(s) is/are carrying. 461 * and also updates how much the environment(s) is/are carrying.
382 */ 462 */
383static void 463static void
384adjust_weight (object *op, sint32 weight) 464adjust_weight (object *op, sint32 sub, sint32 add)
385{ 465{
386 while (op) 466 while (op)
387 { 467 {
388 weight = weight_adjust (op, weight); 468 sint32 ocarrying = op->carrying;
389 469
390 if (!weight) 470 op->carrying -= weight_adjust_for (op, sub);
391 return; 471 op->carrying += weight_adjust_for (op, add);
392
393 op->carrying += weight;
394 472
395 if (object *pl = op->visible_to ()) 473 if (object *pl = op->visible_to ())
396 if (pl != op) // player is handled lazily 474 if (pl != op) // player is handled lazily
397 esrv_update_item (UPD_WEIGHT, pl, op); 475 esrv_update_item (UPD_WEIGHT, pl, op);
398 476
477 sub = ocarrying;
478 add = op->carrying;
479
399 op = op->env; 480 op = op->env;
400 } 481 }
401} 482}
402 483
403/* 484/*
410{ 491{
411 sint32 sum = 0; 492 sint32 sum = 0;
412 493
413 for (object *op = inv; op; op = op->below) 494 for (object *op = inv; op; op = op->below)
414 { 495 {
415 if (op->inv)
416 op->update_weight (); 496 op->update_weight ();
417 497
418 sum += op->total_weight (); 498 sum += weight_adjust_for (this, op->total_weight ());
419 } 499 }
420
421 sum = weight_adjust (this, sum);
422 500
423 if (sum != carrying) 501 if (sum != carrying)
424 { 502 {
503 if (carrying != sum && carrying)//D
504 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
505 (long long)sum, (long long)carrying, debug_desc ());
506
425 carrying = sum; 507 carrying = sum;
426 508
427 if (object *pl = visible_to ()) 509 if (object *pl = visible_to ())
428 if (pl != this) // player is handled lazily 510 if (pl != this) // player is handled lazily
429 esrv_update_item (UPD_WEIGHT, pl, this); 511 esrv_update_item (UPD_WEIGHT, pl, this);
442 object_freezer freezer; 524 object_freezer freezer;
443 op->write (freezer); 525 op->write (freezer);
444 return freezer.as_string (); 526 return freezer.as_string ();
445} 527}
446 528
447/* 529char *
448 * get_nearest_part(multi-object, object 2) returns the part of the 530object::as_string ()
449 * multi-object 1 which is closest to the second object.
450 * If it's not a multi-object, it is returned.
451 */
452object *
453get_nearest_part (object *op, const object *pl)
454{ 531{
455 object *tmp, *closest; 532 return dump_object (this);
456 int last_dist, i;
457
458 if (!op->more)
459 return op;
460
461 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
462 tmp;
463 tmp = tmp->more)
464 if ((i = distance (tmp, pl)) < last_dist)
465 closest = tmp, last_dist = i;
466
467 return closest;
468} 533}
469 534
470/* 535/*
471 * Returns the object which has the count-variable equal to the argument. 536 * Returns the object which has the count-variable equal to the argument.
472 * VERRRY slow. 537 * VERRRY slow.
480 545
481 return 0; 546 return 0;
482} 547}
483 548
484/* 549/*
550 * Returns the object which has the uuid equal to the argument.
551 * MOAR VERRRY slow.
552 */
553
554object *
555find_object_uuid (UUID i)
556{
557 for_all_objects (op)
558 if (op->uuid == i)
559 return op;
560
561 return 0;
562}
563
564/*
485 * Returns the first object which has a name equal to the argument. 565 * Returns the first object which has a name equal to the argument.
486 * Used only by the patch command, but not all that useful. 566 * Used only by the patch command, but not all that useful.
487 * Enables features like "patch <name-of-other-player> food 999" 567 * Enables features like "patch <name-of-other-player> food 999"
488 */ 568 */
489object * 569object *
490find_object_name (const char *str) 570find_object_name (const char *str)
491{ 571{
492 shstr_cmp str_ (str); 572 shstr_cmp str_ (str);
493 object *op;
494 573
574 if (str_)
495 for_all_objects (op) 575 for_all_objects (op)
496 if (op->name == str_) 576 if (op->name == str_)
497 break; 577 return op;
498 578
499 return op; 579 return 0;
500} 580}
501 581
502/* 582/*
503 * Sets the owner and sets the skill and exp pointers to owner's current 583 * Sets the owner and sets the skill and exp pointers to owner's current
504 * skill and experience objects. 584 * skill and experience objects.
517 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ()); 597 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
518 return; 598 return;
519 } 599 }
520 600
521 this->owner = owner; 601 this->owner = owner;
522}
523
524int
525object::slottype () const
526{
527 if (type == SKILL)
528 {
529 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
530 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
531 }
532 else
533 {
534 if (slot [body_combat].info) return slot_combat;
535 if (slot [body_range ].info) return slot_ranged;
536 }
537
538 return slot_none;
539}
540
541bool
542object::change_weapon (object *ob)
543{
544 if (current_weapon == ob)
545 return true;
546
547 if (chosen_skill)
548 chosen_skill->flag [FLAG_APPLIED] = false;
549
550 current_weapon = ob;
551 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
552
553 if (chosen_skill)
554 chosen_skill->flag [FLAG_APPLIED] = true;
555
556 update_stats ();
557
558 if (ob)
559 {
560 // now check wether any body locations became invalid, in which case
561 // we cannot apply the weapon at the moment.
562 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
563 if (slot[i].used < 0)
564 {
565 current_weapon = chosen_skill = 0;
566 update_stats ();
567
568 new_draw_info_format (NDI_UNIQUE, 0, this,
569 "You try to balance all your items at once, "
570 "but the %s is just too much for your body. "
571 "[You need to unapply some items first.]", &ob->name);
572 return false;
573 }
574
575 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
576 }
577 else
578 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
579
580 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
581 {
582 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
583 &name, ob->debug_desc ());
584 return false;
585 }
586
587 return true;
588}
589
590/* Zero the key_values on op, decrementing the shared-string
591 * refcounts and freeing the links.
592 */
593static void
594free_key_values (object *op)
595{
596 for (key_value *i = op->key_values; i; )
597 {
598 key_value *next = i->next;
599 delete i;
600
601 i = next;
602 }
603
604 op->key_values = 0;
605}
606
607object &
608object::operator =(const object &src)
609{
610 bool is_freed = flag [FLAG_FREED];
611 bool is_removed = flag [FLAG_REMOVED];
612
613 *(object_copy *)this = src;
614
615 flag [FLAG_FREED] = is_freed;
616 flag [FLAG_REMOVED] = is_removed;
617
618 /* Copy over key_values, if any. */
619 if (src.key_values)
620 {
621 key_value *tail = 0;
622 key_values = 0;
623
624 for (key_value *i = src.key_values; i; i = i->next)
625 {
626 key_value *new_link = new key_value;
627
628 new_link->next = 0;
629 new_link->key = i->key;
630 new_link->value = i->value;
631
632 /* Try and be clever here, too. */
633 if (!key_values)
634 {
635 key_values = new_link;
636 tail = new_link;
637 }
638 else
639 {
640 tail->next = new_link;
641 tail = new_link;
642 }
643 }
644 }
645} 602}
646 603
647/* 604/*
648 * copy_to first frees everything allocated by the dst object, 605 * copy_to first frees everything allocated by the dst object,
649 * and then copies the contents of itself into the second 606 * and then copies the contents of itself into the second
653 * will point at garbage. 610 * will point at garbage.
654 */ 611 */
655void 612void
656object::copy_to (object *dst) 613object::copy_to (object *dst)
657{ 614{
658 *dst = *this; 615 dst->remove ();
616 *(object_copy *)dst = *this;
659 617
660 if (speed < 0) 618 // maybe move to object_copy?
661 dst->speed_left -= rndm (); 619 dst->kv = kv;
662 620
663 dst->set_speed (dst->speed); 621 dst->flag [FLAG_REMOVED] = true;
622 dst->activate ();
664} 623}
665 624
666void 625void
667object::instantiate () 626object::instantiate ()
668{ 627{
669 if (!uuid.seq) // HACK 628 if (!uuid.seq) // HACK
670 uuid = UUID::gen (); 629 uuid = UUID::gen ();
671 630
631 // TODO: unclean state changes, should not be done in copy_to AND instantiate
632 if (flag [FLAG_RANDOM_SPEED] && speed)
633 speed_left = - speed - rndm (); // TODO animation
634 else
672 speed_left = -0.1f; 635 speed_left = -1.;
636
673 /* copy the body_info to the body_used - this is only really 637 /* copy the body_info to the body_used - this is only really
674 * need for monsters, but doesn't hurt to do it for everything. 638 * need for monsters, but doesn't hurt to do it for everything.
675 * by doing so, when a monster is created, it has good starting 639 * by doing so, when a monster is created, it has good starting
676 * values for the body_used info, so when items are created 640 * values for the body_used info, so when items are created
677 * for it, they can be properly equipped. 641 * for it, they can be properly equipped.
685object * 649object *
686object::clone () 650object::clone ()
687{ 651{
688 object *neu = create (); 652 object *neu = create ();
689 copy_to (neu); 653 copy_to (neu);
654
655 // TODO: unclean state changes, should not be done in clone AND instantiate
656 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
657 neu->speed_left = - neu->speed - rndm (); // TODO animation
658
659 neu->map = map; // not copied by copy_to
690 return neu; 660 return neu;
691} 661}
692 662
693/* 663/*
694 * If an object with the IS_TURNABLE() flag needs to be turned due 664 * If an object with the IS_TURNABLE() flag needs to be turned due
696 * be called to update the face variable, _and_ how it looks on the map. 666 * be called to update the face variable, _and_ how it looks on the map.
697 */ 667 */
698void 668void
699update_turn_face (object *op) 669update_turn_face (object *op)
700{ 670{
701 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 671 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
702 return; 672 return;
703 673
704 SET_ANIMATION (op, op->direction); 674 SET_ANIMATION (op, op->direction);
705 update_object (op, UP_OBJ_FACE); 675 update_object (op, UP_OBJ_FACE);
706} 676}
711 * This function needs to be called whenever the speed of an object changes. 681 * This function needs to be called whenever the speed of an object changes.
712 */ 682 */
713void 683void
714object::set_speed (float speed) 684object::set_speed (float speed)
715{ 685{
716 if (flag [FLAG_FREED] && speed)
717 {
718 LOG (llevError, "Object %s is freed but has speed.\n", &name);
719 speed = 0;
720 }
721
722 this->speed = speed; 686 this->speed = speed;
723 687
724 if (has_active_speed ()) 688 if (has_active_speed ())
725 activate (); 689 activate ();
726 else 690 else
745 * UP_OBJ_FACE: only the objects face has changed. 709 * UP_OBJ_FACE: only the objects face has changed.
746 */ 710 */
747void 711void
748update_object (object *op, int action) 712update_object (object *op, int action)
749{ 713{
750 if (op == NULL) 714 if (!op)
751 { 715 {
752 /* this should never happen */ 716 /* this should never happen */
753 LOG (llevDebug, "update_object() called for NULL object.\n"); 717 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754 return; 718 return;
755 } 719 }
756 720
757 if (op->env) 721 if (!op->is_on_map ())
758 { 722 {
759 /* Animation is currently handled by client, so nothing 723 /* Animation is currently handled by client, so nothing
760 * to do in this case. 724 * to do in this case.
761 */ 725 */
762 return; 726 return;
763 } 727 }
764
765 /* If the map is saving, don't do anything as everything is
766 * going to get freed anyways.
767 */
768 if (!op->map || op->map->in_memory == MAP_SAVING)
769 return;
770 728
771 /* make sure the object is within map boundaries */ 729 /* make sure the object is within map boundaries */
772 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 730 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773 { 731 {
774 LOG (llevError, "update_object() called for object out of map!\n"); 732 LOG (llevError, "update_object() called for object out of map!\n");
782 740
783 if (!(m.flags_ & P_UPTODATE)) 741 if (!(m.flags_ & P_UPTODATE))
784 /* nop */; 742 /* nop */;
785 else if (action == UP_OBJ_INSERT) 743 else if (action == UP_OBJ_INSERT)
786 { 744 {
745#if 0
787 // this is likely overkill, TODO: revisit (schmorp) 746 // this is likely overkill, TODO: revisit (schmorp)
788 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 747 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
789 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 748 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
790 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 749 || (op->is_player () && !(m.flags_ & P_PLAYER))
791 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 750 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
792 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 751 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
793 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 752 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
794 || (m.move_on | op->move_on ) != m.move_on 753 || (m.move_on | op->move_on ) != m.move_on
795 || (m.move_off | op->move_off ) != m.move_off 754 || (m.move_off | op->move_off ) != m.move_off
796 || (m.move_slow | op->move_slow) != m.move_slow 755 || (m.move_slow | op->move_slow) != m.move_slow
797 /* This isn't perfect, but I don't expect a lot of objects to 756 /* This isn't perfect, but I don't expect a lot of objects to
798 * to have move_allow right now. 757 * have move_allow right now.
799 */ 758 */
800 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 759 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
760 m.invalidate ();
761#else
801 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 762 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
802 m.flags_ = 0; 763 m.invalidate ();
764#endif
803 } 765 }
804 /* if the object is being removed, we can't make intelligent 766 /* if the object is being removed, we can't make intelligent
805 * decisions, because remove_ob can't really pass the object 767 * decisions, because remove_ob can't really pass the object
806 * that is being removed. 768 * that is being removed.
807 */ 769 */
808 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 770 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
809 m.flags_ = 0; 771 m.invalidate ();
810 else if (action == UP_OBJ_FACE) 772 else if (action == UP_OBJ_FACE)
811 /* Nothing to do for that case */ ; 773 /* Nothing to do for that case */ ;
812 else 774 else
813 LOG (llevError, "update_object called with invalid action: %d\n", action); 775 LOG (llevError, "update_object called with invalid action: %d\n", action);
814 776
816 update_object (op->more, action); 778 update_object (op->more, action);
817} 779}
818 780
819object::object () 781object::object ()
820{ 782{
821 SET_FLAG (this, FLAG_REMOVED); 783 this->set_flag (FLAG_REMOVED);
822 784
823 expmul = 1.0; 785 //expmul = 1.0; declared const for the time being
824 face = blank_face; 786 face = blank_face;
787 material = MATERIAL_NULL;
825} 788}
826 789
827object::~object () 790object::~object ()
828{ 791{
829 unlink (); 792 unlink ();
830 793
831 free_key_values (this); 794 kv.clear ();
832} 795}
833
834static int object_count;
835 796
836void object::link () 797void object::link ()
837{ 798{
838 assert (!index);//D 799 assert (!index);//D
839 uuid = UUID::gen (); 800 uuid = UUID::gen ();
840 count = ++object_count;
841 801
842 refcnt_inc (); 802 refcnt_inc ();
843 objects.insert (this); 803 objects.insert (this);
804
805 ++create_count;
806
844} 807}
845 808
846void object::unlink () 809void object::unlink ()
847{ 810{
848 if (!index) 811 if (!index)
849 return; 812 return;
813
814 ++destroy_count;
850 815
851 objects.erase (this); 816 objects.erase (this);
852 refcnt_dec (); 817 refcnt_dec ();
853} 818}
854 819
858 /* If already on active list, don't do anything */ 823 /* If already on active list, don't do anything */
859 if (active) 824 if (active)
860 return; 825 return;
861 826
862 if (has_active_speed ()) 827 if (has_active_speed ())
828 {
829 if (flag [FLAG_FREED])
830 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
831
863 actives.insert (this); 832 actives.insert (this);
833 }
864} 834}
865 835
866void 836void
867object::activate_recursive () 837object::activate_recursive ()
868{ 838{
929 * drop on that space. 899 * drop on that space.
930 */ 900 */
931 if (!drop_to_ground 901 if (!drop_to_ground
932 || !map 902 || !map
933 || map->in_memory != MAP_ACTIVE 903 || map->in_memory != MAP_ACTIVE
934 || map->nodrop 904 || map->no_drop
935 || ms ().move_block == MOVE_ALL) 905 || ms ().move_block == MOVE_ALL)
936 { 906 {
937 while (inv) 907 while (inv)
938 {
939 inv->destroy_inv (false);
940 inv->destroy (); 908 inv->destroy ();
941 }
942 } 909 }
943 else 910 else
944 { /* Put objects in inventory onto this space */ 911 { /* Put objects in inventory onto this space */
945 while (inv) 912 while (inv)
946 { 913 {
950 || op->flag [FLAG_NO_DROP] 917 || op->flag [FLAG_NO_DROP]
951 || op->type == RUNE 918 || op->type == RUNE
952 || op->type == TRAP 919 || op->type == TRAP
953 || op->flag [FLAG_IS_A_TEMPLATE] 920 || op->flag [FLAG_IS_A_TEMPLATE]
954 || op->flag [FLAG_DESTROY_ON_DEATH]) 921 || op->flag [FLAG_DESTROY_ON_DEATH])
955 op->destroy (true); 922 op->destroy ();
956 else 923 else
957 map->insert (op, x, y); 924 map->insert (op, x, y);
958 } 925 }
959 } 926 }
960} 927}
961 928
929/*
930 * Remove and free all objects in the inventory of the given object.
931 * Unlike destroy_inv, this assumes the *this is destroyed as well
932 * well, so we can (and have to!) take shortcuts.
933 */
934void
935object::destroy_inv_fast ()
936{
937 while (object *op = inv)
938 {
939 // remove from object the fast way
940 op->flag [FLAG_REMOVED] = true;
941 op->env = 0;
942 if ((inv = inv->below))
943 inv->above = 0;
944
945 // then destroy
946 op->destroy ();
947 }
948}
949
950void
951object::freelist_free (int count)
952{
953 while (count-- && freelist)
954 {
955 freelist_item *next = freelist->next;
956 // count is being "destroyed"
957
958 sfree ((char *)freelist, sizeof (object));
959
960 freelist = next;
961 --free_count;
962 }
963}
964
965object *
962object *object::create () 966object::create ()
963{ 967{
964 object *op = new object; 968 object *op;
969
970 if (freelist)
971 {
972 freelist_item li = *freelist;
973 memset (freelist, 0, sizeof (object));
974
975 op = new (freelist) object;
976 op->count = li.count;
977
978 freelist = li.next;
979 --free_count;
980 }
981 else
982 {
983 void *ni = salloc0<char> (sizeof (object));
984
985 op = new(ni) object;
986
987 op->count = ++object_count;
988 }
989
965 op->link (); 990 op->link ();
991
966 return op; 992 return op;
967} 993}
968 994
969void 995void
996object::do_delete ()
997{
998 uint32_t count = this->count;
999
1000 this->~object ();
1001
1002 freelist_item *li = (freelist_item *)this;
1003 li->next = freelist;
1004 li->count = count;
1005
1006 freelist = li;
1007 ++free_count;
1008}
1009
1010static struct freed_map : maptile
1011{
1012 freed_map ()
1013 : maptile (3, 3)
1014 {
1015 path = "<freed objects map>";
1016 name = "/internal/freed_objects_map";
1017 no_drop = 1;
1018 no_reset = 1;
1019
1020 in_memory = MAP_ACTIVE;
1021 }
1022
1023 ~freed_map ()
1024 {
1025 destroy ();
1026 }
1027} freed_map; // freed objects are moved here to avoid crashes
1028
1029void
970object::do_destroy () 1030object::do_destroy ()
971{ 1031{
972 if (flag [FLAG_IS_LINKED]) 1032 if (flag [FLAG_IS_LINKED])
973 remove_button_link (this); 1033 remove_link ();
974 1034
975 if (flag [FLAG_FRIENDLY]) 1035 if (flag [FLAG_FRIENDLY])
976 remove_friendly_object (this); 1036 remove_friendly_object (this);
977 1037
978 remove (); 1038 remove ();
983 unlink (); 1043 unlink ();
984 1044
985 flag [FLAG_FREED] = 1; 1045 flag [FLAG_FREED] = 1;
986 1046
987 // hack to ensure that freed objects still have a valid map 1047 // hack to ensure that freed objects still have a valid map
988 {
989 static maptile *freed_map; // freed objects are moved here to avoid crashes
990
991 if (!freed_map)
992 {
993 freed_map = new maptile;
994
995 freed_map->path = "<freed objects map>";
996 freed_map->name = "/internal/freed_objects_map";
997 freed_map->width = 3;
998 freed_map->height = 3;
999 freed_map->nodrop = 1;
1000
1001 freed_map->alloc ();
1002 freed_map->in_memory = MAP_ACTIVE;
1003 }
1004
1005 map = freed_map; 1048 map = &freed_map;
1006 x = 1; 1049 x = 1;
1007 y = 1; 1050 y = 1;
1008 }
1009 1051
1010 if (more) 1052 if (more)
1011 { 1053 {
1012 more->destroy (); 1054 more->destroy ();
1013 more = 0; 1055 more = 0;
1021 attacked_by = 0; 1063 attacked_by = 0;
1022 current_weapon = 0; 1064 current_weapon = 0;
1023} 1065}
1024 1066
1025void 1067void
1026object::destroy (bool destroy_inventory) 1068object::destroy ()
1027{ 1069{
1028 if (destroyed ()) 1070 if (destroyed ())
1029 return; 1071 return;
1030 1072
1031 destroy_inv (!destroy_inventory); 1073 if (!is_head () && !head->destroyed ())
1074 {
1075 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1076 head->destroy ();
1077 return;
1078 }
1079
1080 destroy_inv_fast ();
1032 1081
1033 if (is_head ()) 1082 if (is_head ())
1034 if (sound_destroy) 1083 if (sound_destroy)
1035 play_sound (sound_destroy); 1084 play_sound (sound_destroy);
1036 else if (flag [FLAG_MONSTER]) 1085 else if (flag [FLAG_MONSTER])
1047 * the previous environment. 1096 * the previous environment.
1048 */ 1097 */
1049void 1098void
1050object::do_remove () 1099object::do_remove ()
1051{ 1100{
1052 object *tmp, *last = 0;
1053 object *otmp;
1054
1055 if (flag [FLAG_REMOVED]) 1101 if (flag [FLAG_REMOVED])
1056 return; 1102 return;
1057 1103
1058 INVOKE_OBJECT (REMOVE, this); 1104 INVOKE_OBJECT (REMOVE, this);
1059
1060 if (object *pl = visible_to ())
1061 esrv_del_item (pl->contr, count);
1062 1105
1063 flag [FLAG_REMOVED] = true; 1106 flag [FLAG_REMOVED] = true;
1064 1107
1065 if (more) 1108 if (more)
1066 more->remove (); 1109 more->remove ();
1069 * In this case, the object to be removed is in someones 1112 * In this case, the object to be removed is in someones
1070 * inventory. 1113 * inventory.
1071 */ 1114 */
1072 if (env) 1115 if (env)
1073 { 1116 {
1117 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1118 if (object *pl = visible_to ())
1119 esrv_del_item (pl->contr, count);
1120 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1121
1074 adjust_weight (env, -total_weight ()); 1122 adjust_weight (env, total_weight (), 0);
1075 1123
1076 *(above ? &above->below : &env->inv) = below; 1124 object *pl = in_player ();
1077
1078 if (below)
1079 below->above = above;
1080 1125
1081 /* we set up values so that it could be inserted into 1126 /* we set up values so that it could be inserted into
1082 * the map, but we don't actually do that - it is up 1127 * the map, but we don't actually do that - it is up
1083 * to the caller to decide what we want to do. 1128 * to the caller to decide what we want to do.
1084 */ 1129 */
1085 map = env->map; 1130 map = env->map;
1086 x = env->x; 1131 x = env->x;
1087 y = env->y; 1132 y = env->y;
1133
1134 // make sure cmov optimisation is applicable
1135 *(above ? &above->below : &env->inv) = below;
1136 *(below ? &below->above : &above ) = above; // &above is just a dummy
1137
1088 above = 0; 1138 above = 0;
1089 below = 0; 1139 below = 0;
1090 env = 0; 1140 env = 0;
1091 1141
1092 /* NO_FIX_PLAYER is set when a great many changes are being 1142 if (pl && pl->is_player ())
1093 * made to players inventory. If set, avoiding the call
1094 * to save cpu time.
1095 */ 1143 {
1096 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1144 if (expect_false (pl->contr->combat_ob == this))
1097 otmp->update_stats (); 1145 {
1146 pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1147 pl->contr->combat_ob = 0;
1148 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1149 }
1150
1151 if (expect_false (pl->contr->ranged_ob == this))
1152 {
1153 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1154 pl->contr->ranged_ob = 0;
1155 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1156 }
1157
1158 pl->contr->queue_stats_update ();
1159
1160 if (expect_false (glow_radius) && pl->is_on_map ())
1161 update_all_los (pl->map, pl->x, pl->y);
1162 }
1098 } 1163 }
1099 else if (map) 1164 else if (map)
1100 { 1165 {
1101 if (type == PLAYER)
1102 {
1103 // leaving a spot always closes any open container on the ground
1104 if (container && !container->env)
1105 // this causes spurious floorbox updates, but it ensures
1106 // that the CLOSE event is being sent.
1107 close_container ();
1108
1109 --map->players;
1110 map->touch ();
1111 }
1112
1113 map->dirty = true; 1166 map->dirty = true;
1114 mapspace &ms = this->ms (); 1167 mapspace &ms = this->ms ();
1115 1168
1169 if (object *pl = ms.player ())
1170 {
1171 if (is_player ())
1172 {
1173 if (!flag [FLAG_WIZPASS])
1174 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1175
1176 // leaving a spot always closes any open container on the ground
1177 if (container && !container->env)
1178 // this causes spurious floorbox updates, but it ensures
1179 // that the CLOSE event is being sent.
1180 close_container ();
1181
1182 --map->players;
1183 map->touch ();
1184 }
1185 else if (pl->container_ () == this)
1186 {
1187 // removing a container should close it
1188 close_container ();
1189 }
1190 else
1191 esrv_del_item (pl->contr, count);
1192 }
1193
1116 /* link the object above us */ 1194 /* link the object above us */
1117 if (above) 1195 // re-link, make sure compiler can easily use cmove
1118 above->below = below; 1196 *(above ? &above->below : &ms.top) = below;
1119 else 1197 *(below ? &below->above : &ms.bot) = above;
1120 ms.top = below; /* we were top, set new top */
1121
1122 /* Relink the object below us, if there is one */
1123 if (below)
1124 below->above = above;
1125 else
1126 {
1127 /* Nothing below, which means we need to relink map object for this space
1128 * use translated coordinates in case some oddness with map tiling is
1129 * evident
1130 */
1131 if (GET_MAP_OB (map, x, y) != this)
1132 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1133
1134 ms.bot = above; /* goes on above it. */
1135 }
1136 1198
1137 above = 0; 1199 above = 0;
1138 below = 0; 1200 below = 0;
1139 1201
1202 ms.invalidate ();
1203
1140 if (map->in_memory == MAP_SAVING) 1204 if (map->in_memory == MAP_SAVING)
1141 return; 1205 return;
1142 1206
1143 int check_walk_off = !flag [FLAG_NO_APPLY]; 1207 int check_walk_off = !flag [FLAG_NO_APPLY];
1144 1208
1145 if (object *pl = ms.player ()) 1209 if (object *pl = ms.player ())
1146 { 1210 {
1147 if (pl->container == this) 1211 if (pl->container_ () == this)
1148 /* If a container that the player is currently using somehow gets 1212 /* If a container that the player is currently using somehow gets
1149 * removed (most likely destroyed), update the player view 1213 * removed (most likely destroyed), update the player view
1150 * appropriately. 1214 * appropriately.
1151 */ 1215 */
1152 pl->close_container (); 1216 pl->close_container ();
1153 1217
1218 //TODO: the floorbox prev/next might need updating
1154 esrv_del_item (pl, count); 1219 //esrv_del_item (pl->contr, count);
1220 //TODO: update floorbox to preserve ordering
1221 if (pl->contr->ns)
1222 pl->contr->ns->floorbox_update ();
1155 } 1223 }
1156 1224
1225 if (check_walk_off)
1157 for (tmp = ms.bot; tmp; tmp = tmp->above) 1226 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1158 { 1227 {
1228 above = tmp->above;
1229
1159 /* No point updating the players look faces if he is the object 1230 /* No point updating the players look faces if he is the object
1160 * being removed. 1231 * being removed.
1161 */ 1232 */
1162 1233
1163 /* See if object moving off should effect something */ 1234 /* See if object moving off should effect something */
1164 if (check_walk_off
1165 && ((move_type & tmp->move_off) 1235 if ((move_type & tmp->move_off)
1166 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1236 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1167 {
1168 move_apply (tmp, this, 0); 1237 move_apply (tmp, this, 0);
1169
1170 if (destroyed ())
1171 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1172 } 1238 }
1173 1239
1174 last = tmp; 1240 if (affects_los ())
1175 }
1176
1177 /* last == NULL if there are no objects on this space */
1178 //TODO: this makes little sense, why only update the topmost object?
1179 if (!last)
1180 map->at (x, y).flags_ = 0;
1181 else
1182 update_object (last, UP_OBJ_REMOVE);
1183
1184 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1185 update_all_los (map, x, y); 1241 update_all_los (map, x, y);
1186 } 1242 }
1187} 1243}
1188 1244
1189/* 1245/*
1213 esrv_update_item (UPD_NROF, pl, top); 1269 esrv_update_item (UPD_NROF, pl, top);
1214 1270
1215 op->weight = 0; // cancel the addition above 1271 op->weight = 0; // cancel the addition above
1216 op->carrying = 0; // must be 0 already 1272 op->carrying = 0; // must be 0 already
1217 1273
1218 op->destroy (1); 1274 op->destroy ();
1219 1275
1220 return top; 1276 return top;
1221 } 1277 }
1222 1278
1223 return 0; 1279 return 0;
1231 1287
1232 object *prev = this; 1288 object *prev = this;
1233 1289
1234 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1290 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1235 { 1291 {
1236 object *op = arch_to_object (at); 1292 object *op = at->instance ();
1237 1293
1238 op->name = name; 1294 op->name = name;
1239 op->name_pl = name_pl; 1295 op->name_pl = name_pl;
1240 op->title = title; 1296 op->title = title;
1241 1297
1251 * job preparing multi-part monsters. 1307 * job preparing multi-part monsters.
1252 */ 1308 */
1253object * 1309object *
1254insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1310insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1255{ 1311{
1312 op->remove ();
1313
1256 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1314 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1257 { 1315 {
1258 tmp->x = x + tmp->arch->x; 1316 tmp->x = x + tmp->arch->x;
1259 tmp->y = y + tmp->arch->y; 1317 tmp->y = y + tmp->arch->y;
1260 } 1318 }
1277 * Passing 0 for flag gives proper default values, so flag really only needs 1335 * Passing 0 for flag gives proper default values, so flag really only needs
1278 * to be set if special handling is needed. 1336 * to be set if special handling is needed.
1279 * 1337 *
1280 * Return value: 1338 * Return value:
1281 * new object if 'op' was merged with other object 1339 * new object if 'op' was merged with other object
1282 * NULL if 'op' was destroyed 1340 * NULL if there was an error (destroyed, blocked etc.)
1283 * just 'op' otherwise 1341 * just 'op' otherwise
1284 */ 1342 */
1285object * 1343object *
1286insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1344insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1287{ 1345{
1288 assert (!op->flag [FLAG_FREED]);
1289
1290 object *top, *floor = NULL;
1291
1292 op->remove (); 1346 op->remove ();
1347
1348 if (m == &freed_map)//D TODO: remove soon
1349 {//D
1350 LOG (llevError | logBacktrace, "tries to insert object on freed objects map: %s", op->debug_desc ());//D
1351 }//D
1293 1352
1294 /* Ideally, the caller figures this out. However, it complicates a lot 1353 /* Ideally, the caller figures this out. However, it complicates a lot
1295 * of areas of callers (eg, anything that uses find_free_spot would now 1354 * of areas of callers (eg, anything that uses find_free_spot would now
1296 * need extra work 1355 * need extra work
1297 */ 1356 */
1357 maptile *newmap = m;
1298 if (!xy_normalise (m, op->x, op->y)) 1358 if (!xy_normalise (newmap, op->x, op->y))
1299 { 1359 {
1300 op->destroy (1); 1360 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1301 return 0; 1361 return 0;
1302 } 1362 }
1303 1363
1304 if (object *more = op->more) 1364 if (object *more = op->more)
1305 if (!insert_ob_in_map (more, m, originator, flag)) 1365 if (!insert_ob_in_map (more, m, originator, flag))
1306 return 0; 1366 return 0;
1307 1367
1308 CLEAR_FLAG (op, FLAG_REMOVED); 1368 op->flag [FLAG_REMOVED] = false;
1309 1369 op->env = 0;
1310 op->map = m; 1370 op->map = newmap;
1371
1311 mapspace &ms = op->ms (); 1372 mapspace &ms = op->ms ();
1312 1373
1313 /* this has to be done after we translate the coordinates. 1374 /* this has to be done after we translate the coordinates.
1314 */ 1375 */
1315 if (op->nrof && !(flag & INS_NO_MERGE)) 1376 if (op->nrof && !(flag & INS_NO_MERGE))
1316 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1377 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1317 if (object::can_merge (op, tmp)) 1378 if (object::can_merge (op, tmp))
1318 { 1379 {
1380 // TODO: we actually want to update tmp, not op,
1381 // but some caller surely breaks when we return tmp
1382 // from here :/
1319 op->nrof += tmp->nrof; 1383 op->nrof += tmp->nrof;
1320 tmp->destroy (1); 1384 tmp->destroy ();
1321 } 1385 }
1322 1386
1323 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1387 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1324 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1388 op->clr_flag (FLAG_INV_LOCKED);
1325 1389
1326 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1390 if (!op->flag [FLAG_ALIVE])
1327 CLEAR_FLAG (op, FLAG_NO_STEAL); 1391 op->clr_flag (FLAG_NO_STEAL);
1328 1392
1329 if (flag & INS_BELOW_ORIGINATOR) 1393 if (flag & INS_BELOW_ORIGINATOR)
1330 { 1394 {
1331 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1395 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1332 { 1396 {
1333 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1397 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1334 abort (); 1398 abort ();
1335 } 1399 }
1336 1400
1401 if (!originator->is_on_map ())
1402 {
1403 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1404 op->debug_desc (), originator->debug_desc ());
1405 abort ();
1406 }
1407
1337 op->above = originator; 1408 op->above = originator;
1338 op->below = originator->below; 1409 op->below = originator->below;
1339
1340 if (op->below)
1341 op->below->above = op;
1342 else
1343 ms.bot = op;
1344
1345 /* since *below* originator, no need to update top */
1346 originator->below = op; 1410 originator->below = op;
1411
1412 *(op->below ? &op->below->above : &ms.bot) = op;
1347 } 1413 }
1348 else 1414 else
1349 { 1415 {
1350 top = ms.bot; 1416 object *floor = 0;
1417 object *top = ms.top;
1351 1418
1352 /* If there are other objects, then */ 1419 /* If there are other objects, then */
1353 if (top) 1420 if (top)
1354 { 1421 {
1355 object *last = 0;
1356
1357 /* 1422 /*
1358 * If there are multiple objects on this space, we do some trickier handling. 1423 * If there are multiple objects on this space, we do some trickier handling.
1359 * We've already dealt with merging if appropriate. 1424 * We've already dealt with merging if appropriate.
1360 * Generally, we want to put the new object on top. But if 1425 * Generally, we want to put the new object on top. But if
1361 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1426 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1364 * once we get to them. This reduces the need to traverse over all of 1429 * once we get to them. This reduces the need to traverse over all of
1365 * them when adding another one - this saves quite a bit of cpu time 1430 * them when adding another one - this saves quite a bit of cpu time
1366 * when lots of spells are cast in one area. Currently, it is presumed 1431 * when lots of spells are cast in one area. Currently, it is presumed
1367 * that flying non pickable objects are spell objects. 1432 * that flying non pickable objects are spell objects.
1368 */ 1433 */
1369 for (top = ms.bot; top; top = top->above) 1434 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1370 { 1435 {
1371 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1436 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1372 floor = top; 1437 floor = tmp;
1373 1438
1374 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1439 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1375 { 1440 {
1376 /* We insert above top, so we want this object below this */ 1441 /* We insert above top, so we want this object below this */
1377 top = top->below; 1442 top = tmp->below;
1378 break; 1443 break;
1379 } 1444 }
1380 1445
1381 last = top; 1446 top = tmp;
1382 } 1447 }
1383
1384 /* Don't want top to be NULL, so set it to the last valid object */
1385 top = last;
1386 1448
1387 /* We let update_position deal with figuring out what the space 1449 /* We let update_position deal with figuring out what the space
1388 * looks like instead of lots of conditions here. 1450 * looks like instead of lots of conditions here.
1389 * makes things faster, and effectively the same result. 1451 * makes things faster, and effectively the same result.
1390 */ 1452 */
1397 */ 1459 */
1398 if (!(flag & INS_ON_TOP) 1460 if (!(flag & INS_ON_TOP)
1399 && ms.flags () & P_BLOCKSVIEW 1461 && ms.flags () & P_BLOCKSVIEW
1400 && (op->face && !faces [op->face].visibility)) 1462 && (op->face && !faces [op->face].visibility))
1401 { 1463 {
1464 object *last;
1465
1402 for (last = top; last != floor; last = last->below) 1466 for (last = top; last != floor; last = last->below)
1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1467 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1404 break; 1468 break;
1405 1469
1406 /* Check to see if we found the object that blocks view, 1470 /* Check to see if we found the object that blocks view,
1407 * and make sure we have a below pointer for it so that 1471 * and make sure we have a below pointer for it so that
1408 * we can get inserted below this one, which requires we 1472 * we can get inserted below this one, which requires we
1414 } /* If objects on this space */ 1478 } /* If objects on this space */
1415 1479
1416 if (flag & INS_ABOVE_FLOOR_ONLY) 1480 if (flag & INS_ABOVE_FLOOR_ONLY)
1417 top = floor; 1481 top = floor;
1418 1482
1419 /* Top is the object that our object (op) is going to get inserted above. 1483 // insert object above top, or bottom-most if top = 0
1420 */
1421
1422 /* First object on this space */
1423 if (!top) 1484 if (!top)
1424 { 1485 {
1486 op->below = 0;
1425 op->above = ms.bot; 1487 op->above = ms.bot;
1426
1427 if (op->above)
1428 op->above->below = op;
1429
1430 op->below = 0;
1431 ms.bot = op; 1488 ms.bot = op;
1489
1490 *(op->above ? &op->above->below : &ms.top) = op;
1432 } 1491 }
1433 else 1492 else
1434 { /* get inserted into the stack above top */ 1493 {
1435 op->above = top->above; 1494 op->above = top->above;
1436
1437 if (op->above)
1438 op->above->below = op; 1495 top->above = op;
1439 1496
1440 op->below = top; 1497 op->below = top;
1441 top->above = op; 1498 *(op->above ? &op->above->below : &ms.top) = op;
1442 } 1499 }
1500 }
1443 1501
1444 if (!op->above) 1502 if (op->is_player ())
1445 ms.top = op;
1446 } /* else not INS_BELOW_ORIGINATOR */
1447
1448 if (op->type == PLAYER)
1449 { 1503 {
1450 op->contr->do_los = 1; 1504 op->contr->do_los = 1;
1451 ++op->map->players; 1505 ++op->map->players;
1452 op->map->touch (); 1506 op->map->touch ();
1453 } 1507 }
1454 1508
1455 op->map->dirty = true; 1509 op->map->dirty = true;
1456 1510
1457 if (object *pl = ms.player ()) 1511 if (object *pl = ms.player ())
1512 //TODO: the floorbox prev/next might need updating
1458 esrv_send_item (pl, op); 1513 //esrv_send_item (pl, op);
1514 //TODO: update floorbox to preserve ordering
1515 if (pl->contr->ns)
1516 pl->contr->ns->floorbox_update ();
1459 1517
1460 /* If this object glows, it may affect lighting conditions that are 1518 /* If this object glows, it may affect lighting conditions that are
1461 * visible to others on this map. But update_all_los is really 1519 * visible to others on this map. But update_all_los is really
1462 * an inefficient way to do this, as it means los for all players 1520 * an inefficient way to do this, as it means los for all players
1463 * on the map will get recalculated. The players could very well 1521 * on the map will get recalculated. The players could very well
1464 * be far away from this change and not affected in any way - 1522 * be far away from this change and not affected in any way -
1465 * this should get redone to only look for players within range, 1523 * this should get redone to only look for players within range,
1466 * or just updating the P_UPTODATE for spaces within this area 1524 * or just updating the P_UPTODATE for spaces within this area
1467 * of effect may be sufficient. 1525 * of effect may be sufficient.
1468 */ 1526 */
1469 if (op->map->darkness && (op->glow_radius != 0)) 1527 if (op->affects_los ())
1528 {
1529 op->ms ().invalidate ();
1470 update_all_los (op->map, op->x, op->y); 1530 update_all_los (op->map, op->x, op->y);
1531 }
1471 1532
1472 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1533 /* updates flags (blocked, alive, no magic, etc) for this map space */
1473 update_object (op, UP_OBJ_INSERT); 1534 update_object (op, UP_OBJ_INSERT);
1474 1535
1475 INVOKE_OBJECT (INSERT, op); 1536 INVOKE_OBJECT (INSERT, op);
1482 * blocked() and wall() work properly), and these flags are updated by 1543 * blocked() and wall() work properly), and these flags are updated by
1483 * update_object(). 1544 * update_object().
1484 */ 1545 */
1485 1546
1486 /* if this is not the head or flag has been passed, don't check walk on status */ 1547 /* if this is not the head or flag has been passed, don't check walk on status */
1487 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1548 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1488 { 1549 {
1489 if (check_move_on (op, originator)) 1550 if (check_move_on (op, originator, flag))
1490 return 0; 1551 return 0;
1491 1552
1492 /* If we are a multi part object, lets work our way through the check 1553 /* If we are a multi part object, let's work our way through the check
1493 * walk on's. 1554 * walk on's.
1494 */ 1555 */
1495 for (object *tmp = op->more; tmp; tmp = tmp->more) 1556 for (object *tmp = op->more; tmp; tmp = tmp->more)
1496 if (check_move_on (tmp, originator)) 1557 if (check_move_on (tmp, originator, flag))
1497 return 0; 1558 return 0;
1498 } 1559 }
1499 1560
1500 return op; 1561 return op;
1501} 1562}
1503/* this function inserts an object in the map, but if it 1564/* this function inserts an object in the map, but if it
1504 * finds an object of its own type, it'll remove that one first. 1565 * finds an object of its own type, it'll remove that one first.
1505 * op is the object to insert it under: supplies x and the map. 1566 * op is the object to insert it under: supplies x and the map.
1506 */ 1567 */
1507void 1568void
1508replace_insert_ob_in_map (const char *arch_string, object *op) 1569replace_insert_ob_in_map (shstr_tmp archname, object *op)
1509{ 1570{
1510 /* first search for itself and remove any old instances */ 1571 /* first search for itself and remove any old instances */
1511 1572
1512 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1573 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1513 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1574 if (tmp->arch->archname == archname) /* same archetype */
1514 tmp->destroy (1); 1575 tmp->destroy ();
1515 1576
1516 object *tmp = arch_to_object (archetype::find (arch_string)); 1577 object *tmp = archetype::find (archname)->instance ();
1517 1578
1518 tmp->x = op->x; 1579 tmp->x = op->x;
1519 tmp->y = op->y; 1580 tmp->y = op->y;
1520 1581
1521 insert_ob_in_map (tmp, op->map, op, 0); 1582 insert_ob_in_map (tmp, op->map, op, 0);
1526{ 1587{
1527 if (where->env) 1588 if (where->env)
1528 return where->env->insert (this); 1589 return where->env->insert (this);
1529 else 1590 else
1530 return where->map->insert (this, where->x, where->y, originator, flags); 1591 return where->map->insert (this, where->x, where->y, originator, flags);
1592}
1593
1594// check whether we can put this into the map, respect max_volume, max_items
1595bool
1596object::can_drop_at (maptile *m, int x, int y, object *originator)
1597{
1598 mapspace &ms = m->at (x, y);
1599
1600 int items = ms.items ();
1601
1602 if (!items // testing !items ensures we can drop at least one item
1603 || (items < m->max_items
1604 && ms.volume () < m->max_volume))
1605 return true;
1606
1607 if (originator && originator->is_player ())
1608 originator->contr->failmsgf (
1609 "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
1610 query_name ()
1611 );
1612
1613 return false;
1531} 1614}
1532 1615
1533/* 1616/*
1534 * decrease(object, number) decreases a specified number from 1617 * decrease(object, number) decreases a specified number from
1535 * the amount of an object. If the amount reaches 0, the object 1618 * the amount of an object. If the amount reaches 0, the object
1543 if (!nr) 1626 if (!nr)
1544 return true; 1627 return true;
1545 1628
1546 nr = min (nr, nrof); 1629 nr = min (nr, nrof);
1547 1630
1631 if (nrof > nr)
1632 {
1633 sint64 oweight = total_weight ();
1634
1548 nrof -= nr; 1635 nrof -= nr;
1549
1550 if (nrof)
1551 {
1552 adjust_weight (env, -weight * nr); // carrying == 0
1553 1636
1554 if (object *pl = visible_to ()) 1637 if (object *pl = visible_to ())
1555 esrv_update_item (UPD_NROF, pl, this); 1638 esrv_update_item (UPD_NROF, pl, this);
1556 1639
1640 adjust_weight (env, oweight, total_weight ());
1641
1557 return true; 1642 return true;
1558 } 1643 }
1559 else 1644 else
1560 { 1645 {
1561 destroy (1); 1646 destroy ();
1562 return false; 1647 return false;
1563 } 1648 }
1564} 1649}
1565 1650
1566/* 1651/*
1583 } 1668 }
1584 else 1669 else
1585 { 1670 {
1586 decrease (nr); 1671 decrease (nr);
1587 1672
1588 object *op = object_create_clone (this); 1673 object *op = deep_clone ();
1589 op->nrof = nr; 1674 op->nrof = nr;
1590 return op; 1675 return op;
1591 } 1676 }
1592} 1677}
1593 1678
1635 if (op->nrof) 1720 if (op->nrof)
1636 for (object *tmp = inv; tmp; tmp = tmp->below) 1721 for (object *tmp = inv; tmp; tmp = tmp->below)
1637 if (object::can_merge (tmp, op)) 1722 if (object::can_merge (tmp, op))
1638 { 1723 {
1639 /* return the original object and remove inserted object 1724 /* return the original object and remove inserted object
1640 (client needs the original object) */ 1725 (client prefers the original object) */
1726
1727 // carring must be 0 for mergable objects
1728 sint64 oweight = tmp->weight * tmp->nrof;
1729
1641 tmp->nrof += op->nrof; 1730 tmp->nrof += op->nrof;
1642 1731
1643 if (object *pl = tmp->visible_to ()) 1732 if (object *pl = tmp->visible_to ())
1644 esrv_update_item (UPD_NROF, pl, tmp); 1733 esrv_update_item (UPD_NROF, pl, tmp);
1645 1734
1646 adjust_weight (this, op->total_weight ()); 1735 adjust_weight (this, oweight, tmp->weight * tmp->nrof);
1647 1736
1648 op->destroy (1); 1737 op->destroy ();
1649 op = tmp; 1738 op = tmp;
1650 goto inserted; 1739 goto inserted;
1651 } 1740 }
1652 1741
1653 op->owner = 0; // it's his/hers now. period. 1742 op->owner = 0; // it's his/hers now. period.
1667 op->flag [FLAG_REMOVED] = 0; 1756 op->flag [FLAG_REMOVED] = 0;
1668 1757
1669 if (object *pl = op->visible_to ()) 1758 if (object *pl = op->visible_to ())
1670 esrv_send_item (pl, op); 1759 esrv_send_item (pl, op);
1671 1760
1672 adjust_weight (this, op->total_weight ()); 1761 adjust_weight (this, 0, op->total_weight ());
1673 1762
1674inserted: 1763inserted:
1675 /* reset the light list and los of the players on the map */ 1764 /* reset the light list and los of the players on the map */
1676 if (op->glow_radius && map && map->darkness) 1765 if (op->glow_radius && is_on_map ())
1766 {
1767 update_stats ();
1677 update_all_los (map, x, y); 1768 update_all_los (map, x, y);
1678 1769 }
1770 else if (is_player ())
1679 // if this is a player's inventory, update stats 1771 // if this is a player's inventory, update stats
1680 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1772 contr->queue_stats_update ();
1681 update_stats ();
1682 1773
1683 INVOKE_OBJECT (INSERT, this); 1774 INVOKE_OBJECT (INSERT, this);
1684 1775
1685 return op; 1776 return op;
1686} 1777}
1704 * MSW 2001-07-08: Check all objects on space, not just those below 1795 * MSW 2001-07-08: Check all objects on space, not just those below
1705 * object being inserted. insert_ob_in_map may not put new objects 1796 * object being inserted. insert_ob_in_map may not put new objects
1706 * on top. 1797 * on top.
1707 */ 1798 */
1708int 1799int
1709check_move_on (object *op, object *originator) 1800check_move_on (object *op, object *originator, int flags)
1710{ 1801{
1802 if (op->flag [FLAG_NO_APPLY])
1803 return 0;
1804
1711 object *tmp; 1805 object *tmp;
1712 maptile *m = op->map; 1806 maptile *m = op->map;
1713 int x = op->x, y = op->y; 1807 int x = op->x, y = op->y;
1714 1808
1715 MoveType move_on, move_slow, move_block; 1809 mapspace &ms = m->at (x, y);
1716 1810
1717 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1811 ms.update ();
1718 return 0;
1719 1812
1720 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1813 MoveType move_on = ms.move_on;
1721 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1814 MoveType move_slow = ms.move_slow;
1722 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1815 MoveType move_block = ms.move_block;
1723 1816
1724 /* if nothing on this space will slow op down or be applied, 1817 /* if nothing on this space will slow op down or be applied,
1725 * no need to do checking below. have to make sure move_type 1818 * no need to do checking below. have to make sure move_type
1726 * is set, as lots of objects don't have it set - we treat that 1819 * is set, as lots of objects don't have it set - we treat that
1727 * as walking. 1820 * as walking.
1738 return 0; 1831 return 0;
1739 1832
1740 /* The objects have to be checked from top to bottom. 1833 /* The objects have to be checked from top to bottom.
1741 * Hence, we first go to the top: 1834 * Hence, we first go to the top:
1742 */ 1835 */
1743 1836 for (object *next, *tmp = ms.top; tmp; tmp = next)
1744 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1745 {
1746 /* Trim the search when we find the first other spell effect
1747 * this helps performance so that if a space has 50 spell objects,
1748 * we don't need to check all of them.
1749 */
1750 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1751 break;
1752 } 1837 {
1838 next = tmp->below;
1753 1839
1754 for (; tmp; tmp = tmp->below)
1755 {
1756 if (tmp == op) 1840 if (tmp == op)
1757 continue; /* Can't apply yourself */ 1841 continue; /* Can't apply yourself */
1758 1842
1759 /* Check to see if one of the movement types should be slowed down. 1843 /* Check to see if one of the movement types should be slowed down.
1760 * Second check makes sure that the movement types not being slowed 1844 * Second check makes sure that the movement types not being slowed
1761 * (~slow_move) is not blocked on this space - just because the 1845 * (~slow_move) is not blocked on this space - just because the
1762 * space doesn't slow down swimming (for example), if you can't actually 1846 * space doesn't slow down swimming (for example), if you can't actually
1763 * swim on that space, can't use it to avoid the penalty. 1847 * swim on that space, can't use it to avoid the penalty.
1764 */ 1848 */
1765 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1849 if (!op->flag [FLAG_WIZPASS])
1766 { 1850 {
1767 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1851 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1768 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1852 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1769 { 1853 {
1770
1771 float
1772 diff = tmp->move_slow_penalty * fabs (op->speed); 1854 float diff = tmp->move_slow_penalty * fabs (op->speed);
1773 1855
1774 if (op->type == PLAYER) 1856 if (op->is_player ())
1775 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1857 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1776 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1858 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1777 diff /= 4.0; 1859 diff /= 4.0;
1778 1860
1779 op->speed_left -= diff; 1861 op->speed_left -= diff;
1780 } 1862 }
1781 } 1863 }
1782 1864
1783 /* Basically same logic as above, except now for actual apply. */ 1865 /* Basically same logic as above, except now for actual apply. */
1784 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1866 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1785 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1867 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1786 { 1868 {
1869 if ((flags & INS_NO_AUTO_EXIT)
1870 && (tmp->type == EXIT || tmp->type == TELEPORTER
1871 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1872 continue;
1873
1787 move_apply (tmp, op, originator); 1874 move_apply (tmp, op, originator);
1788 1875
1789 if (op->destroyed ()) 1876 if (op->destroyed ())
1790 return 1; 1877 return 1;
1791 1878
1814 LOG (llevError, "Present_arch called outside map.\n"); 1901 LOG (llevError, "Present_arch called outside map.\n");
1815 return NULL; 1902 return NULL;
1816 } 1903 }
1817 1904
1818 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1905 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1819 if (tmp->arch == at) 1906 if (tmp->arch->archname == at->archname)
1820 return tmp; 1907 return tmp;
1821 1908
1822 return NULL; 1909 return NULL;
1823} 1910}
1824 1911
1888 * The first matching object is returned, or NULL if none. 1975 * The first matching object is returned, or NULL if none.
1889 */ 1976 */
1890object * 1977object *
1891present_arch_in_ob (const archetype *at, const object *op) 1978present_arch_in_ob (const archetype *at, const object *op)
1892{ 1979{
1893 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1980 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1894 if (tmp->arch == at) 1981 if (tmp->arch->archname == at->archname)
1895 return tmp; 1982 return tmp;
1896 1983
1897 return NULL; 1984 return NULL;
1898} 1985}
1899 1986
1903void 1990void
1904flag_inv (object *op, int flag) 1991flag_inv (object *op, int flag)
1905{ 1992{
1906 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1993 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1907 { 1994 {
1908 SET_FLAG (tmp, flag); 1995 tmp->set_flag (flag);
1909 flag_inv (tmp, flag); 1996 flag_inv (tmp, flag);
1910 } 1997 }
1911} 1998}
1912 1999
1913/* 2000/*
1916void 2003void
1917unflag_inv (object *op, int flag) 2004unflag_inv (object *op, int flag)
1918{ 2005{
1919 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2006 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1920 { 2007 {
1921 CLEAR_FLAG (tmp, flag); 2008 tmp->clr_flag (flag);
1922 unflag_inv (tmp, flag); 2009 unflag_inv (tmp, flag);
1923 } 2010 }
1924} 2011}
1925 2012
1926/* 2013/*
1987 * head of the object should correspond for the entire object. 2074 * head of the object should correspond for the entire object.
1988 */ 2075 */
1989 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2076 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1990 continue; 2077 continue;
1991 2078
1992 if (ob->blocked (m, pos.x, pos.y)) 2079 if (ob->blocked (pos.m, pos.x, pos.y))
1993 continue; 2080 continue;
1994 2081
1995 altern [index++] = i; 2082 altern [index++] = i;
1996 } 2083 }
1997 2084
2065 * there is capable of. 2152 * there is capable of.
2066 */ 2153 */
2067int 2154int
2068find_dir (maptile *m, int x, int y, object *exclude) 2155find_dir (maptile *m, int x, int y, object *exclude)
2069{ 2156{
2070 int i, max = SIZEOFFREE, mflags; 2157 int max = SIZEOFFREE, mflags;
2071
2072 sint16 nx, ny;
2073 object *tmp;
2074 maptile *mp;
2075
2076 MoveType blocked, move_type; 2158 MoveType move_type;
2077 2159
2078 if (exclude && exclude->head_ () != exclude) 2160 if (exclude && exclude->head_ () != exclude)
2079 { 2161 {
2080 exclude = exclude->head; 2162 exclude = exclude->head;
2081 move_type = exclude->move_type; 2163 move_type = exclude->move_type;
2084 { 2166 {
2085 /* If we don't have anything, presume it can use all movement types. */ 2167 /* If we don't have anything, presume it can use all movement types. */
2086 move_type = MOVE_ALL; 2168 move_type = MOVE_ALL;
2087 } 2169 }
2088 2170
2089 for (i = 1; i < max; i++) 2171 for (int i = 1; i < max; i++)
2090 { 2172 {
2091 mp = m; 2173 mapxy pos (m, x, y);
2092 nx = x + freearr_x[i]; 2174 pos.move (i);
2093 ny = y + freearr_y[i];
2094 2175
2095 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2176 if (!pos.normalise ())
2096
2097 if (mflags & P_OUT_OF_MAP)
2098 max = maxfree[i]; 2177 max = maxfree[i];
2099 else 2178 else
2100 { 2179 {
2101 mapspace &ms = mp->at (nx, ny); 2180 mapspace &ms = *pos;
2102 2181
2103 blocked = ms.move_block;
2104
2105 if ((move_type & blocked) == move_type) 2182 if ((move_type & ms.move_block) == move_type)
2106 max = maxfree[i]; 2183 max = maxfree [i];
2107 else if (mflags & P_IS_ALIVE) 2184 else if (ms.flags () & P_IS_ALIVE)
2108 { 2185 {
2109 for (tmp = ms.bot; tmp; tmp = tmp->above) 2186 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2110 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2187 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2111 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2188 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2112 break;
2113
2114 if (tmp)
2115 return freedir[i]; 2189 return freedir [i];
2116 } 2190 }
2117 } 2191 }
2118 } 2192 }
2119 2193
2120 return 0; 2194 return 0;
2129{ 2203{
2130 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2204 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2131} 2205}
2132 2206
2133/* 2207/*
2134 * find_dir_2(delta-x,delta-y) will return a direction in which 2208 * find_dir_2(delta-x,delta-y) will return a direction value
2135 * an object which has subtracted the x and y coordinates of another 2209 * for running into direct [dx, dy].
2136 * object, needs to travel toward it. 2210 * (the opposite of crossfire's find_dir_2!)
2137 */ 2211 */
2138int 2212int
2139find_dir_2 (int x, int y) 2213find_dir_2 (int x, int y)
2140{ 2214{
2215#if 1 // new algorithm
2216 // this works by putting x, y into 16 sectors, which
2217 // are not equal sized, but are a better approximation
2218 // then the old algorithm, and then using a mapping
2219 // table to map it into a direction value.
2220 // basically, it maps these comparisons to each bit
2221 // bit #3: x < 0
2222 // bit #2: y < 0
2223 // bit #1: x > y
2224 // bit #0: x > 2y
2225
2226 static const uint8 dir[16] = {
2227 4, 5, 4, 3,
2228 2, 1, 2, 3,
2229 6, 5, 6, 7,
2230 8, 1, 8, 7,
2231 };
2232 int sector = 0;
2233
2234 // this is a bit ugly, but more likely to result in branchless code
2235 sector |= x < 0 ? 8 : 0;
2236 x = x < 0 ? -x : x; // abs
2237
2238 sector |= y < 0 ? 4 : 0;
2239 y = y < 0 ? -y : y; // abs
2240
2241 if (x > y)
2242 {
2243 sector |= 2;
2244
2245 if (x > y * 2)
2246 sector |= 1;
2247 }
2248 else
2249 {
2250 if (y > x * 2)
2251 sector |= 1;
2252 else if (!y)
2253 return 0; // x == 0 here
2254 }
2255
2256 return dir [sector];
2257#else // old algorithm
2141 int q; 2258 int q;
2142 2259
2143 if (y) 2260 if (y)
2144 q = x * 100 / y; 2261 q = 128 * x / y;
2145 else if (x) 2262 else if (x)
2146 q = -300 * x; 2263 q = -512 * x; // to make it > 309
2147 else 2264 else
2148 return 0; 2265 return 0;
2149 2266
2150 if (y > 0) 2267 if (y > 0)
2151 { 2268 {
2152 if (q < -242) 2269 if (q < -309) return 7;
2270 if (q < -52) return 6;
2271 if (q < 52) return 5;
2272 if (q < 309) return 4;
2273
2153 return 3; 2274 return 3;
2154 if (q < -41) 2275 }
2155 return 2; 2276 else
2156 if (q < 41) 2277 {
2157 return 1; 2278 if (q < -309) return 3;
2158 if (q < 242) 2279 if (q < -52) return 2;
2159 return 8; 2280 if (q < 52) return 1;
2281 if (q < 309) return 8;
2282
2160 return 7; 2283 return 7;
2161 } 2284 }
2162 2285#endif
2163 if (q < -242)
2164 return 7;
2165 if (q < -41)
2166 return 6;
2167 if (q < 41)
2168 return 5;
2169 if (q < 242)
2170 return 4;
2171
2172 return 3;
2173} 2286}
2174 2287
2175/* 2288/*
2176 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2289 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2177 * between two directions (which are expected to be absolute (see absdir()) 2290 * between two directions (which are expected to be absolute (see absdir())
2178 */ 2291 */
2179int 2292int
2180dirdiff (int dir1, int dir2) 2293dirdiff (int dir1, int dir2)
2181{ 2294{
2182 int d;
2183
2184 d = abs (dir1 - dir2); 2295 int d = abs (dir1 - dir2);
2185 if (d > 4)
2186 d = 8 - d;
2187 2296
2188 return d; 2297 return d > 4 ? 8 - d : d;
2189} 2298}
2190 2299
2191/* peterm: 2300/* peterm:
2192 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2301 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2193 * Basically, this is a table of directions, and what directions 2302 * Basically, this is a table of directions, and what directions
2195 * This basically means that if direction is 15, then it could either go 2304 * This basically means that if direction is 15, then it could either go
2196 * direction 4, 14, or 16 to get back to where we are. 2305 * direction 4, 14, or 16 to get back to where we are.
2197 * Moved from spell_util.c to object.c with the other related direction 2306 * Moved from spell_util.c to object.c with the other related direction
2198 * functions. 2307 * functions.
2199 */ 2308 */
2200int reduction_dir[SIZEOFFREE][3] = { 2309static const int reduction_dir[SIZEOFFREE][3] = {
2201 {0, 0, 0}, /* 0 */ 2310 {0, 0, 0}, /* 0 */
2202 {0, 0, 0}, /* 1 */ 2311 {0, 0, 0}, /* 1 */
2203 {0, 0, 0}, /* 2 */ 2312 {0, 0, 0}, /* 2 */
2204 {0, 0, 0}, /* 3 */ 2313 {0, 0, 0}, /* 3 */
2205 {0, 0, 0}, /* 4 */ 2314 {0, 0, 0}, /* 4 */
2299 * Add a check so we can't pick up invisible objects (0.93.8) 2408 * Add a check so we can't pick up invisible objects (0.93.8)
2300 */ 2409 */
2301int 2410int
2302can_pick (const object *who, const object *item) 2411can_pick (const object *who, const object *item)
2303{ 2412{
2304 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2413 return /*who->flag [FLAG_WIZ]|| */
2305 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2414 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2306 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2415 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2307} 2416}
2308 2417
2309/* 2418/*
2310 * create clone from object to another 2419 * create clone from object to another
2311 */ 2420 */
2312object * 2421object *
2313object_create_clone (object *asrc) 2422object::deep_clone ()
2314{ 2423{
2315 object *dst = 0, *tmp, *src, *prev, *item; 2424 assert (("deep_clone called on non-head object", is_head ()));
2316 2425
2317 if (!asrc) 2426 object *dst = clone ();
2318 return 0;
2319 2427
2320 src = asrc->head_ (); 2428 object *prev = dst;
2321
2322 prev = 0;
2323 for (object *part = src; part; part = part->more) 2429 for (object *part = this->more; part; part = part->more)
2324 { 2430 {
2325 tmp = part->clone (); 2431 object *tmp = part->clone ();
2326 tmp->x -= src->x;
2327 tmp->y -= src->y;
2328
2329 if (!part->head)
2330 {
2331 dst = tmp;
2332 tmp->head = 0;
2333 }
2334 else
2335 tmp->head = dst; 2432 tmp->head = dst;
2336
2337 tmp->more = 0;
2338
2339 if (prev)
2340 prev->more = tmp; 2433 prev->more = tmp;
2341
2342 prev = tmp; 2434 prev = tmp;
2343 } 2435 }
2344 2436
2345 for (item = src->inv; item; item = item->below) 2437 for (object *item = inv; item; item = item->below)
2346 insert_ob_in_ob (object_create_clone (item), dst); 2438 insert_ob_in_ob (item->deep_clone (), dst);
2347 2439
2348 return dst; 2440 return dst;
2349} 2441}
2350 2442
2351/* This returns the first object in who's inventory that 2443/* This returns the first object in who's inventory that
2360 return tmp; 2452 return tmp;
2361 2453
2362 return 0; 2454 return 0;
2363} 2455}
2364 2456
2365/* If ob has a field named key, return the link from the list, 2457/* Zero the key_values on op, decrementing the shared-string
2366 * otherwise return NULL. 2458 * refcounts and freeing the links.
2367 * 2459 */
2368 * key must be a passed in shared string - otherwise, this won't 2460void
2369 * do the desired thing. 2461key_values::clear ()
2370 */
2371key_value *
2372get_ob_key_link (const object *ob, const char *key)
2373{ 2462{
2374 for (key_value *link = ob->key_values; link; link = link->next) 2463 for (key_value *kvp = first; kvp; )
2464 {
2465 key_value *next = kvp->next;
2466 delete kvp;
2467 kvp = next;
2468 }
2469
2470 first = 0;
2471}
2472
2473shstr_tmp
2474key_values::get (shstr_tmp key) const
2475{
2476 for (key_value *kv = first; kv; kv = kv->next)
2375 if (link->key == key) 2477 if (kv->key == key)
2376 return link;
2377
2378 return 0;
2379}
2380
2381/*
2382 * Returns the value of op has an extra_field for key, or NULL.
2383 *
2384 * The argument doesn't need to be a shared string.
2385 *
2386 * The returned string is shared.
2387 */
2388const char *
2389get_ob_key_value (const object *op, const char *const key)
2390{
2391 key_value *link;
2392 shstr_cmp canonical_key (key);
2393
2394 if (!canonical_key)
2395 {
2396 /* 1. There being a field named key on any object
2397 * implies there'd be a shared string to find.
2398 * 2. Since there isn't, no object has this field.
2399 * 3. Therefore, *this* object doesn't have this field.
2400 */
2401 return 0;
2402 }
2403
2404 /* This is copied from get_ob_key_link() above -
2405 * only 4 lines, and saves the function call overhead.
2406 */
2407 for (link = op->key_values; link; link = link->next)
2408 if (link->key == canonical_key)
2409 return link->value; 2478 return kv->value;
2410 2479
2411 return 0; 2480 return shstr ();
2412} 2481}
2413 2482
2414/* 2483void
2415 * Updates the canonical_key in op to value. 2484key_values::add (shstr_tmp key, shstr_tmp value)
2416 *
2417 * canonical_key is a shared string (value doesn't have to be).
2418 *
2419 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2420 * keys.
2421 *
2422 * Returns TRUE on success.
2423 */
2424int
2425set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2426{ 2485{
2427 key_value *field = NULL, *last = NULL; 2486 key_value *kv = new key_value;
2428 2487
2429 for (field = op->key_values; field != NULL; field = field->next) 2488 kv->next = first;
2430 { 2489 kv->key = key;
2431 if (field->key != canonical_key) 2490 kv->value = value;
2491
2492 first = kv;
2493}
2494
2495void
2496key_values::set (shstr_tmp key, shstr_tmp value)
2497{
2498 for (key_value *kv = first; kv; kv = kv->next)
2499 if (kv->key == key)
2432 { 2500 {
2433 last = field; 2501 kv->value = value;
2434 continue; 2502 return;
2435 } 2503 }
2436 2504
2437 if (value) 2505 add (key, value);
2438 field->value = value; 2506}
2439 else 2507
2508void
2509key_values::del (shstr_tmp key)
2510{
2511 for (key_value **kvp = &first; *kvp; kvp = &(*kvp)->next)
2512 if ((*kvp)->key == key)
2440 { 2513 {
2441 /* Basically, if the archetype has this key set, 2514 key_value *kv = *kvp;
2442 * we need to store the null value so when we save 2515 *kvp = (*kvp)->next;
2443 * it, we save the empty value so that when we load, 2516 delete kv;
2444 * we get this value back again. 2517 return;
2445 */
2446 if (get_ob_key_link (op->arch, canonical_key))
2447 field->value = 0;
2448 else
2449 {
2450 if (last)
2451 last->next = field->next;
2452 else
2453 op->key_values = field->next;
2454
2455 delete field;
2456 }
2457 } 2518 }
2458 return TRUE; 2519}
2520
2521void
2522key_values::reverse ()
2523{
2524 key_value *prev = 0;
2525 key_value *head = first;
2526
2527 while (head)
2459 } 2528 {
2460 /* IF we get here, key doesn't exist */ 2529 key_value *node = head;
2530 head = head->next;
2531 node->next = prev;
2532 prev = node;
2533 }
2461 2534
2462 /* No field, we'll have to add it. */ 2535 first = prev;
2463
2464 if (!add_key)
2465 return FALSE;
2466
2467 /* There isn't any good reason to store a null
2468 * value in the key/value list. If the archetype has
2469 * this key, then we should also have it, so shouldn't
2470 * be here. If user wants to store empty strings,
2471 * should pass in ""
2472 */
2473 if (value == NULL)
2474 return TRUE;
2475
2476 field = new key_value;
2477
2478 field->key = canonical_key;
2479 field->value = value;
2480 /* Usual prepend-addition. */
2481 field->next = op->key_values;
2482 op->key_values = field;
2483
2484 return TRUE;
2485} 2536}
2486 2537
2487/* 2538key_values &
2488 * Updates the key in op to value. 2539key_values::operator =(const key_values &kv)
2489 *
2490 * If add_key is FALSE, this will only update existing keys,
2491 * and not add new ones.
2492 * In general, should be little reason FALSE is ever passed in for add_key
2493 *
2494 * Returns TRUE on success.
2495 */
2496int
2497set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2498{ 2540{
2499 shstr key_ (key); 2541 clear ();
2500 2542
2501 return set_ob_key_value_s (op, key_, value, add_key); 2543 for (key_value *kvp = kv.first; kvp; kvp = kvp->next)
2544 add (kvp->key, kvp->value);
2545
2546 reverse ();
2502} 2547}
2503 2548
2504object::depth_iterator::depth_iterator (object *container) 2549object::depth_iterator::depth_iterator (object *container)
2505: iterator_base (container) 2550: iterator_base (container)
2506{ 2551{
2556{ 2601{
2557 char flagdesc[512]; 2602 char flagdesc[512];
2558 char info2[256 * 4]; 2603 char info2[256 * 4];
2559 char *p = info; 2604 char *p = info;
2560 2605
2561 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2606 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2562 count, 2607 count,
2563 uuid.c_str (), 2608 uuid.c_str (),
2564 &name, 2609 &name,
2565 title ? "\",title:\"" : "", 2610 title ? ",title:\"" : "",
2566 title ? (const char *)title : "", 2611 title ? (const char *)title : "",
2612 title ? "\"" : "",
2567 flag_desc (flagdesc, 512), type); 2613 flag_desc (flagdesc, 512), type);
2568 2614
2569 if (!flag[FLAG_REMOVED] && env) 2615 if (!flag[FLAG_REMOVED] && env)
2570 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2616 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2571 2617
2589{ 2635{
2590 return map ? map->region (x, y) 2636 return map ? map->region (x, y)
2591 : region::default_region (); 2637 : region::default_region ();
2592} 2638}
2593 2639
2594const materialtype_t *
2595object::dominant_material () const
2596{
2597 if (materialtype_t *mt = name_to_material (materialname))
2598 return mt;
2599
2600 return name_to_material (shstr_unknown);
2601}
2602
2603void 2640void
2604object::open_container (object *new_container) 2641object::open_container (object *new_container)
2605{ 2642{
2606 if (container == new_container) 2643 if (container == new_container)
2607 return; 2644 return;
2608 2645
2609 if (object *old_container = container) 2646 object *old_container = container;
2647
2648 if (old_container)
2610 { 2649 {
2611 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2650 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2612 return; 2651 return;
2613 2652
2614#if 0 2653#if 0
2616 if (object *closer = old_container->inv) 2655 if (object *closer = old_container->inv)
2617 if (closer->type == CLOSE_CON) 2656 if (closer->type == CLOSE_CON)
2618 closer->destroy (); 2657 closer->destroy ();
2619#endif 2658#endif
2620 2659
2660 // make sure the container is available
2661 esrv_send_item (this, old_container);
2662
2621 old_container->flag [FLAG_APPLIED] = false; 2663 old_container->flag [FLAG_APPLIED] = false;
2622 container = 0; 2664 container = 0;
2623 2665
2666 // client needs item update to make it work, client bug requires this to be separate
2624 esrv_update_item (UPD_FLAGS, this, old_container); 2667 esrv_update_item (UPD_FLAGS, this, old_container);
2668
2625 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2669 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2626 play_sound (sound_find ("chest_close")); 2670 play_sound (sound_find ("chest_close"));
2627 } 2671 }
2628 2672
2629 if (new_container) 2673 if (new_container)
2630 { 2674 {
2634 // TODO: this does not seem to serve any purpose anymore? 2678 // TODO: this does not seem to serve any purpose anymore?
2635#if 0 2679#if 0
2636 // insert the "Close Container" object. 2680 // insert the "Close Container" object.
2637 if (archetype *closer = new_container->other_arch) 2681 if (archetype *closer = new_container->other_arch)
2638 { 2682 {
2639 object *closer = arch_to_object (new_container->other_arch); 2683 object *closer = new_container->other_arch->instance ();
2640 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2684 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2641 new_container->insert (closer); 2685 new_container->insert (closer);
2642 } 2686 }
2643#endif 2687#endif
2644 2688
2645 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2689 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2690
2691 // make sure the container is available, client bug requires this to be separate
2692 esrv_send_item (this, new_container);
2646 2693
2647 new_container->flag [FLAG_APPLIED] = true; 2694 new_container->flag [FLAG_APPLIED] = true;
2648 container = new_container; 2695 container = new_container;
2649 2696
2697 // client needs flag change
2650 esrv_update_item (UPD_FLAGS, this, new_container); 2698 esrv_update_item (UPD_FLAGS, this, new_container);
2651 esrv_send_inventory (this, new_container); 2699 esrv_send_inventory (this, new_container);
2652 play_sound (sound_find ("chest_open")); 2700 play_sound (sound_find ("chest_open"));
2653 } 2701 }
2702// else if (!old_container->env && contr && contr->ns)
2703// contr->ns->floorbox_reset ();
2654} 2704}
2655 2705
2656object * 2706object *
2657object::force_find (const shstr name) 2707object::force_find (shstr_tmp name)
2658{ 2708{
2659 /* cycle through his inventory to look for the MARK we want to 2709 /* cycle through his inventory to look for the MARK we want to
2660 * place 2710 * place
2661 */ 2711 */
2662 for (object *tmp = inv; tmp; tmp = tmp->below) 2712 for (object *tmp = inv; tmp; tmp = tmp->below)
2664 return splay (tmp); 2714 return splay (tmp);
2665 2715
2666 return 0; 2716 return 0;
2667} 2717}
2668 2718
2719//-GPL
2720
2669void 2721void
2722object::force_set_timer (int duration)
2723{
2724 this->duration = 1;
2725 this->speed_left = -1.f;
2726
2727 this->set_speed (duration ? 1.f / duration : 0.f);
2728}
2729
2730object *
2670object::force_add (const shstr name, int duration) 2731object::force_add (shstr_tmp name, int duration)
2671{ 2732{
2672 if (object *force = force_find (name)) 2733 if (object *force = force_find (name))
2673 force->destroy (); 2734 force->destroy ();
2674 2735
2675 object *force = get_archetype (FORCE_NAME); 2736 object *force = archetype::get (FORCE_NAME);
2676 2737
2677 force->slaying = name; 2738 force->slaying = name;
2678 force->stats.food = 1; 2739 force->force_set_timer (duration);
2679 force->speed_left = -1.f;
2680
2681 force->set_speed (duration ? 1.f / duration : 0.f);
2682 force->flag [FLAG_IS_USED_UP] = true;
2683 force->flag [FLAG_APPLIED] = true; 2740 force->flag [FLAG_APPLIED] = true;
2684 2741
2685 insert (force); 2742 return insert (force);
2686} 2743}
2687 2744
2688void 2745void
2689object::play_sound (faceidx sound) 2746object::play_sound (faceidx sound) const
2690{ 2747{
2691 if (!sound) 2748 if (!sound)
2692 return; 2749 return;
2693 2750
2694 if (flag [FLAG_REMOVED]) 2751 if (is_on_map ())
2752 map->play_sound (sound, x, y);
2753 else if (object *pl = in_player ())
2754 pl->contr->play_sound (sound);
2755}
2756
2757void
2758object::say_msg (const char *msg) const
2759{
2760 if (is_on_map ())
2761 map->say_msg (msg, x, y);
2762 else if (object *pl = in_player ())
2763 pl->contr->play_sound (sound);
2764}
2765
2766void
2767object::make_noise ()
2768{
2769 // we do not model noise in the map, so instead put
2770 // a temporary light into the noise source
2771 // could use the map instead, but that's less reliable for our
2772 // goal, which is to make invisibility a bit harder to exploit
2773
2774 // currently only works sensibly for players
2775 if (!is_player ())
2695 return; 2776 return;
2696 2777
2697 if (env) 2778 // find old force, or create new one
2698 { 2779 object *force = force_find (shstr_noise_force);
2699 if (object *pl = in_player ()) 2780
2700 pl->contr->play_sound (sound); 2781 if (force)
2701 } 2782 force->speed_left = -1.f; // patch old speed up
2702 else 2783 else
2703 map->play_sound (sound, x, y); 2784 {
2704} 2785 force = archetype::get (shstr_noise_force);
2705 2786
2787 force->slaying = shstr_noise_force;
2788 force->stats.food = 1;
2789 force->speed_left = -1.f;
2790
2791 force->set_speed (1.f / 4.f);
2792 force->flag [FLAG_IS_USED_UP] = true;
2793 force->flag [FLAG_APPLIED] = true;
2794
2795 insert (force);
2796 }
2797}
2798
2799void object::change_move_type (MoveType mt)
2800{
2801 if (move_type == mt)
2802 return;
2803
2804 if (is_on_map ())
2805 {
2806 // we are on the map, so handle move_on/off effects
2807 remove ();
2808 move_type = mt;
2809 map->insert (this, x, y, this);
2810 }
2811 else
2812 move_type = mt;
2813}
2814
2815/* object should be a player.
2816 * we return the object the player has marked with the 'mark' command
2817 * below. If no match is found (or object has changed), we return
2818 * NULL. We leave it up to the calling function to print messages if
2819 * nothing is found.
2820 */
2821object *
2822object::mark () const
2823{
2824 if (contr && contr->mark && contr->mark->env == this)
2825 return contr->mark;
2826 else
2827 return 0;
2828}
2829
2830// put marked object first in the inventory
2831// this is used by identify-like spells so players can influence
2832// the order a bit.
2833void
2834object::splay_marked ()
2835{
2836 if (object *marked = mark ())
2837 splay (marked);
2838}
2839

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines