ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.214 by root, Tue Apr 22 07:01:46 2008 UTC vs.
Revision 1.359 by root, Wed Dec 12 02:13:04 2012 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <stdio.h> 26#include <stdio.h>
26#include <sys/types.h> 27#include <sys/types.h>
27#include <sys/uio.h> 28#include <sys/uio.h>
28#include <object.h> 29#include <object.h>
29#include <sproto.h> 30#include <sproto.h>
30#include <loader.h>
31 31
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
41
42freelist_item *object::freelist;
43uint32_t object::object_count;
44uint32_t object::free_count;
45uint32_t object::create_count;
46uint32_t object::destroy_count;
47
48//+GPL
40 49
41short freearr_x[SIZEOFFREE] = { 50short freearr_x[SIZEOFFREE] = {
42 0, 51 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 52 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 53 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
48 0, 57 0,
49 -1, -1, 0, 1, 1, 1, 0, -1, 58 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 59 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 60 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52}; 61};
53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58};
59int freedir[SIZEOFFREE] = { 62int freedir[SIZEOFFREE] = {
60 0, 63 0,
61 1, 2, 3, 4, 5, 6, 7, 8, 64 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 65 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 66 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
64}; 67};
65 68
69static int maxfree[SIZEOFFREE] = {
70 0,
71 9, 10, 13, 14, 17, 18, 21, 22,
72 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
73 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
74};
75
76const char *wall_suffix[16] = {
77 "0",
78 "1_3",
79 "1_4",
80 "2_1_2",
81 "1_2",
82 "2_2_4",
83 "2_2_1",
84 "3_1",
85 "1_1",
86 "2_2_3",
87 "2_2_2",
88 "3_3",
89 "2_1_1",
90 "3_4",
91 "3_2",
92 "4"
93};
94
66static void 95static void
67write_uuid (uval64 skip, bool sync) 96write_uuid (uval64 skip, bool sync)
68{ 97{
69 CALL_BEGIN (2); 98 CALL_BEGIN (2);
70 CALL_ARG_SV (newSVval64 (skip)); 99 CALL_ARG_SV (newSVval64 (skip));
72 CALL_CALL ("cf::write_uuid", G_DISCARD); 101 CALL_CALL ("cf::write_uuid", G_DISCARD);
73 CALL_END; 102 CALL_END;
74} 103}
75 104
76static void 105static void
77read_uuid (void) 106read_uuid ()
78{ 107{
79 char filename[MAX_BUF]; 108 char filename[MAX_BUF];
80 109
81 sprintf (filename, "%s/uuid", settings.localdir); 110 sprintf (filename, "%s/uuid", settings.localdir);
82 111
96 125
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 126 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1); 127 _exit (1);
99 } 128 }
100 129
101 UUID::BUF buf; 130 char buf [UUID::MAX_LEN];
102 buf[0] = 0; 131 buf[0] = 0;
103 fgets (buf, sizeof (buf), fp); 132 fgets (buf, sizeof (buf), fp);
104 133
105 if (!UUID::cur.parse (buf)) 134 if (!UUID::cur.parse (buf))
106 { 135 {
133 162
134void 163void
135UUID::init () 164UUID::init ()
136{ 165{
137 read_uuid (); 166 read_uuid ();
167}
168
169bool
170UUID::parse (const char *s)
171{
172 if (*s++ != '<' || *s++ != '1' || *s++ != '.')
173 return false;
174
175 seq = 0;
176
177 while (*s != '>')
178 {
179 if (*s < '0')
180 return false;
181
182 // this gives nice branchless code with gcc
183 assert ('0' < 'a' && '0' == 48 && 'a' == 97);
184 int digit = (*s + (*s & 0x40 ? 9 : 0)) & 15;
185
186 seq = (seq << 4) | digit;
187
188 ++s;
189 }
190
191 return true;
192}
193
194char *
195UUID::append (char *buf) const
196{
197 *buf++ = '<';
198 *buf++ = '1';
199 *buf++ = '.';
200
201 uint64_t seq = this->seq;
202 const int bits = 64;
203 char nz = 0;
204 static const char tohex [] = "0123456789abcdef";
205
206 // assert (len >= 3 + bits / 4 + 1 + 1);
207 for (int i = bits / 4; --i; )
208 {
209 uint8_t digit = seq >> (bits - 4);
210
211 *buf = tohex [digit];
212 nz |= digit;
213 buf += nz ? 1 : 0;
214 seq <<= 4;
215 }
216
217 // last digit is special - always emit
218 uint8_t digit = seq >> (bits - 4);
219 *buf++ = tohex [digit];
220
221 *buf++ = '>';
222
223 return buf;
224}
225
226char *
227UUID::c_str () const
228{
229 static char buf [MAX_LEN];
230 *append (buf) = 0;
231 return buf;
138} 232}
139 233
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 234/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 235static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 236compare_ob_value_lists_one (const object *wants, const object *has)
143{ 237{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 238 /* n-squared behaviour (see kv.get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 239 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 240 * different structure or at least keep the lists sorted...
149 */ 241 */
150 242
151 /* For each field in wants, */ 243 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 244 for (key_value *kv = wants->kv.first; kv; kv = kv->next)
153 { 245 if (has->kv.get (kv->key) != kv->value)
154 key_value *has_field; 246 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 247
169 /* If we get here, every field in wants has a matching field in has. */ 248 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 249 return true;
171} 250}
172 251
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 252/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 253static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 254compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 255{
177 /* However, there may be fields in has which aren't partnered in wants, 256 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 257 * so we need to run the comparison *twice*. :(
179 */ 258 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 259 return compare_ob_value_lists_one (ob1, ob2)
260 && compare_ob_value_lists_one (ob2, ob1);
181} 261}
182 262
183/* Function examines the 2 objects given to it, and returns true if 263/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 264 * they can be merged together.
185 * 265 *
192 * Improvements made with merge: Better checking on potion, and also 272 * Improvements made with merge: Better checking on potion, and also
193 * check weight 273 * check weight
194 */ 274 */
195bool object::can_merge_slow (object *ob1, object *ob2) 275bool object::can_merge_slow (object *ob1, object *ob2)
196{ 276{
197 /* A couple quicksanity checks */ 277 /* A couple quick sanity checks */
198 if (ob1 == ob2 278 if (ob1 == ob2
199 || ob1->type != ob2->type 279 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 280 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 281 || ob1->name != ob2->name
282 || ob1->custom_name != ob2->custom_name
283 || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
203 return 0; 284 return 0;
204 285
205 /* Do not merge objects if nrof would overflow. First part checks 286 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 287 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 288 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 289 return 0;
212 290
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 291 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 292 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 293 * just can't ignore the been applied or identified flags, as they
216 * are not equal - just if it has been identified, the been_applied 294 * are not equal - just if it has been identified, the been_applied
217 * flags lose any meaning. 295 * flags lose any meaning.
218 */ 296 */
219 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 297 if (ob1->flag [FLAG_IDENTIFIED])
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 298 ob1->set_flag (FLAG_BEEN_APPLIED);
221 299
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 300 if (ob2->flag [FLAG_IDENTIFIED])
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 301 ob2->set_flag (FLAG_BEEN_APPLIED);
224 302
225 if (ob1->arch->name != ob2->arch->name 303 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 304 || ob1->name != ob2->name
227 || ob1->title != ob2->title 305 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 306 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 307 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 308 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 309 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 310 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 311 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 312 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 313 || ob1->animation_id != ob2->animation_id
314 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
236 || ob1->client_type != ob2->client_type 315 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 316 || ob1->material != ob2->material
238 || ob1->lore != ob2->lore 317 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 318 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 319 || ob1->move_type != ob2->move_type
241 || ob1->move_block != ob2->move_block 320 || ob1->move_block != ob2->move_block
242 || ob1->move_allow != ob2->move_allow 321 || ob1->move_allow != ob2->move_allow
243 || ob1->move_on != ob2->move_on 322 || ob1->move_on != ob2->move_on
244 || ob1->move_off != ob2->move_off 323 || ob1->move_off != ob2->move_off
245 || ob1->move_slow != ob2->move_slow 324 || ob1->move_slow != ob2->move_slow
246 || ob1->move_slow_penalty != ob2->move_slow_penalty 325 || fabs (ob1->move_slow_penalty - ob2->move_slow_penalty) >= (1.f / 1024.f)
247 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) 326 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 327 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 328 return 0;
250 329
251 if ((ob1->flag ^ ob2->flag) 330 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 331 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 332 .reset (FLAG_REMOVED)
255 .any ()) 333 .any ())
256 return 0; 334 return 0;
257 335
258 /* This is really a spellbook check - we should in general 336 /* This is really a spellbook check - we should in general
273 /* inventory ok - still need to check rest of this object to see 351 /* inventory ok - still need to check rest of this object to see
274 * if it is valid. 352 * if it is valid.
275 */ 353 */
276 } 354 }
277 355
278 /* Don't merge objects that are applied. With the new 'body' code, 356 /* Don't merge objects that are applied. With the new 'body' code,
279 * it is possible for most any character to have more than one of 357 * it is possible for most any character to have more than one of
280 * some items equipped, and we don't want those to merge. 358 * some items equipped, and we don't want those to merge.
281 */ 359 */
282 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED)) 360 if (ob1->flag [FLAG_APPLIED] || ob2->flag [FLAG_APPLIED])
283 return 0; 361 return 0;
284 362
285 /* Note sure why the following is the case - either the object has to 363 /* Not sure why the following is the case - either the object has to
286 * be animated or have a very low speed. Is this an attempted monster 364 * be animated or have a very low speed. Is this an attempted monster
287 * check? 365 * check?
288 */ 366 */
289 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ()) 367 if (!ob1->flag [FLAG_ANIMATE] && ob1->has_active_speed ())
290 return 0; 368 return 0;
291 369
292 switch (ob1->type) 370 switch (ob1->type)
293 { 371 {
294 case SCROLL: 372 case SCROLL:
295 if (ob1->level != ob2->level) 373 if (ob1->level != ob2->level)
296 return 0; 374 return 0;
297 break; 375 break;
298 } 376 }
299 377
300 if (ob1->key_values || ob2->key_values) 378 if (!ob1->kv.empty () || !ob2->kv.empty ())
301 { 379 {
302 /* At least one of these has key_values. */ 380 /* At least one of these has key_values. */
303 if ((!ob1->key_values) != (!ob2->key_values)) 381 if (ob1->kv.empty () != ob2->kv.empty ())
304 return 0; /* One has fields, but the other one doesn't. */ 382 return 0; /* One has fields, but the other one doesn't. */
305 383
306 if (!compare_ob_value_lists (ob1, ob2)) 384 if (!compare_ob_value_lists (ob1, ob2))
307 return 0; 385 return 0;
308 } 386 }
334 412
335// find player who can see this object 413// find player who can see this object
336object * 414object *
337object::visible_to () const 415object::visible_to () const
338{ 416{
339 if (!flag [FLAG_REMOVED]) 417 if (client_visible () && !flag [FLAG_REMOVED])
340 { 418 {
341 // see if we are in a container of sorts 419 // see if we are in a container of sorts
342 if (env) 420 if (env)
343 { 421 {
344 // the player inventory itself is always visible 422 // the player inventory itself is always visible
345 if (env->type == PLAYER) 423 if (env->is_player ())
346 return env; 424 return env;
347 425
348 // else a player could have our env open 426 // else a player could have our env open
349 object *envest = env->outer_env (); 427 object *envest = env->outer_env_or_self ();
350 428
351 // the player itself is always on a map, so we will find him here 429 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 430 // even if our inv is in a player.
353 if (envest->is_on_map ()) 431 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 432 if (object *pl = envest->ms ().player ())
355 if (pl->container == env) 433 if (pl->container_ () == env)
356 return pl; 434 return pl;
357 } 435 }
358 else 436 else
359 { 437 {
360 // maybe there is a player standing on the same mapspace 438 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 439 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 440 if (object *pl = ms ().player ())
441 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
442 || pl->container_ () == this)
363 return pl; 443 return pl;
364 } 444 }
365 } 445 }
366 446
367 return 0; 447 return 0;
368} 448}
369 449
370// adjust weight per container type ("of holding") 450// adjust weight per container type ("of holding")
371static sint32 451static weight_t
372weight_adjust (object *op, sint32 weight) 452weight_adjust_for (object *op, weight_t weight)
373{ 453{
374 return op->type == CONTAINER 454 if (op->type == CONTAINER)
375 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 455 weight -= weight * op->stats.Str / 100;
376 : weight;
377}
378 456
457 return weight;
458}
459
379/* 460/*
380 * adjust_weight(object, weight) adds the specified weight to an object, 461 * subtracts, then adds, the specified weight to an object,
381 * and also updates how much the environment(s) is/are carrying. 462 * and also updates how much the environment(s) is/are carrying.
382 */ 463 */
383static void 464static void
384adjust_weight (object *op, sint32 weight) 465adjust_weight (object *op, weight_t sub, weight_t add)
385{ 466{
386 while (op) 467 while (op)
387 { 468 {
388 weight = weight_adjust (op, weight); 469 weight_t carrying = (weight_t)op->carrying
470 - weight_adjust_for (op, sub)
471 + weight_adjust_for (op, add);
389 472
390 if (!weight) 473 sub = op->carrying;
391 return;
392
393 op->carrying += weight; 474 op->carrying = carrying;
475 add = op->carrying;
394 476
395 if (object *pl = op->visible_to ()) 477 if (object *pl = op->visible_to ())
478 if (pl != op) // player is handled lazily
396 esrv_update_item (UPD_WEIGHT, pl, op); 479 esrv_update_item (UPD_WEIGHT, pl, op);
397 480
398 op = op->env; 481 op = op->env;
399 } 482 }
400} 483}
401 484
405 * containers are carrying, and sums it up. 488 * containers are carrying, and sums it up.
406 */ 489 */
407void 490void
408object::update_weight () 491object::update_weight ()
409{ 492{
410 sint32 sum = 0; 493 weight_t sum = 0;
411 494
412 for (object *op = inv; op; op = op->below) 495 for (object *op = inv; op; op = op->below)
413 { 496 {
414 if (op->inv)
415 op->update_weight (); 497 op->update_weight ();
416 498
417 sum += op->total_weight (); 499 sum += weight_adjust_for (this, op->total_weight ());
418 } 500 }
419
420 sum = weight_adjust (this, sum);
421 501
422 if (sum != carrying) 502 if (sum != carrying)
423 { 503 {
504 if (carrying != sum && carrying)//D
505 LOG (llevDebug, "updating carrying got %ld, expected %ld (%s)\n",
506 (long long)sum, (long long)carrying, debug_desc ());
507
424 carrying = sum; 508 carrying = sum;
425 509
426 if (object *pl = visible_to ()) 510 if (object *pl = visible_to ())
511 if (pl != this) // player is handled lazily
427 esrv_update_item (UPD_WEIGHT, pl, this); 512 esrv_update_item (UPD_WEIGHT, pl, this);
428 } 513 }
429} 514}
430 515
431/* 516/*
432 * Used by: Server DM commands: dumpbelow, dump. Some error messages. 517 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
440 object_freezer freezer; 525 object_freezer freezer;
441 op->write (freezer); 526 op->write (freezer);
442 return freezer.as_string (); 527 return freezer.as_string ();
443} 528}
444 529
445/* 530char *
446 * get_nearest_part(multi-object, object 2) returns the part of the 531object::as_string ()
447 * multi-object 1 which is closest to the second object.
448 * If it's not a multi-object, it is returned.
449 */
450object *
451get_nearest_part (object *op, const object *pl)
452{ 532{
453 object *tmp, *closest; 533 return dump_object (this);
454 int last_dist, i;
455
456 if (!op->more)
457 return op;
458
459 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
460 tmp;
461 tmp = tmp->more)
462 if ((i = distance (tmp, pl)) < last_dist)
463 closest = tmp, last_dist = i;
464
465 return closest;
466} 534}
467 535
468/* 536/*
469 * Returns the object which has the count-variable equal to the argument. 537 * Returns the object which has the count-variable equal to the argument.
470 * VERRRY slow. 538 * VERRRY slow.
478 546
479 return 0; 547 return 0;
480} 548}
481 549
482/* 550/*
551 * Returns the object which has the uuid equal to the argument.
552 * MOAR VERRRY slow.
553 */
554
555object *
556find_object_uuid (UUID i)
557{
558 for_all_objects (op)
559 if (op->uuid == i)
560 return op;
561
562 return 0;
563}
564
565/*
483 * Returns the first object which has a name equal to the argument. 566 * Returns the first object which has a name equal to the argument.
484 * Used only by the patch command, but not all that useful. 567 * Used only by the patch command, but not all that useful.
485 * Enables features like "patch <name-of-other-player> food 999" 568 * Enables features like "patch <name-of-other-player> food 999"
486 */ 569 */
487object * 570object *
488find_object_name (const char *str) 571find_object_name (const char *str)
489{ 572{
490 shstr_cmp str_ (str); 573 shstr_cmp str_ (str);
491 object *op;
492 574
575 if (str_)
493 for_all_objects (op) 576 for_all_objects (op)
494 if (op->name == str_) 577 if (op->name == str_)
495 break; 578 return op;
496 579
497 return op; 580 return 0;
498} 581}
499 582
500/* 583/*
501 * Sets the owner and sets the skill and exp pointers to owner's current 584 * Sets the owner and sets the skill and exp pointers to owner's current
502 * skill and experience objects. 585 * skill and experience objects.
515 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ()); 598 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
516 return; 599 return;
517 } 600 }
518 601
519 this->owner = owner; 602 this->owner = owner;
520}
521
522int
523object::slottype () const
524{
525 if (type == SKILL)
526 {
527 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
528 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
529 }
530 else
531 {
532 if (slot [body_combat].info) return slot_combat;
533 if (slot [body_range ].info) return slot_ranged;
534 }
535
536 return slot_none;
537}
538
539bool
540object::change_weapon (object *ob)
541{
542 if (current_weapon == ob)
543 return true;
544
545 if (chosen_skill)
546 chosen_skill->flag [FLAG_APPLIED] = false;
547
548 current_weapon = ob;
549 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
550
551 if (chosen_skill)
552 chosen_skill->flag [FLAG_APPLIED] = true;
553
554 update_stats ();
555
556 if (ob)
557 {
558 // now check wether any body locations became invalid, in which case
559 // we cannot apply the weapon at the moment.
560 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
561 if (slot[i].used < 0)
562 {
563 current_weapon = chosen_skill = 0;
564 update_stats ();
565
566 new_draw_info_format (NDI_UNIQUE, 0, this,
567 "You try to balance all your items at once, "
568 "but the %s is just too much for your body. "
569 "[You need to unapply some items first.]", &ob->name);
570 return false;
571 }
572
573 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
574 }
575 else
576 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
577
578 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
579 {
580 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
581 &name, ob->debug_desc ());
582 return false;
583 }
584
585 return true;
586}
587
588/* Zero the key_values on op, decrementing the shared-string
589 * refcounts and freeing the links.
590 */
591static void
592free_key_values (object *op)
593{
594 for (key_value *i = op->key_values; i; )
595 {
596 key_value *next = i->next;
597 delete i;
598
599 i = next;
600 }
601
602 op->key_values = 0;
603}
604
605object &
606object::operator =(const object &src)
607{
608 bool is_freed = flag [FLAG_FREED];
609 bool is_removed = flag [FLAG_REMOVED];
610
611 *(object_copy *)this = src;
612
613 flag [FLAG_FREED] = is_freed;
614 flag [FLAG_REMOVED] = is_removed;
615
616 /* Copy over key_values, if any. */
617 if (src.key_values)
618 {
619 key_value *tail = 0;
620 key_values = 0;
621
622 for (key_value *i = src.key_values; i; i = i->next)
623 {
624 key_value *new_link = new key_value;
625
626 new_link->next = 0;
627 new_link->key = i->key;
628 new_link->value = i->value;
629
630 /* Try and be clever here, too. */
631 if (!key_values)
632 {
633 key_values = new_link;
634 tail = new_link;
635 }
636 else
637 {
638 tail->next = new_link;
639 tail = new_link;
640 }
641 }
642 }
643} 603}
644 604
645/* 605/*
646 * copy_to first frees everything allocated by the dst object, 606 * copy_to first frees everything allocated by the dst object,
647 * and then copies the contents of itself into the second 607 * and then copies the contents of itself into the second
651 * will point at garbage. 611 * will point at garbage.
652 */ 612 */
653void 613void
654object::copy_to (object *dst) 614object::copy_to (object *dst)
655{ 615{
656 *dst = *this; 616 dst->remove ();
617 *(object_copy *)dst = *this;
657 618
658 if (speed < 0) 619 // maybe move to object_copy?
659 dst->speed_left -= rndm (); 620 dst->kv = kv;
660 621
661 dst->set_speed (dst->speed); 622 dst->flag [FLAG_REMOVED] = true;
623 dst->activate ();
662} 624}
663 625
664void 626void
665object::instantiate () 627object::instantiate ()
666{ 628{
667 if (!uuid.seq) // HACK 629 if (!uuid.seq) // HACK
668 uuid = UUID::gen (); 630 uuid = UUID::gen ();
669 631
632 // TODO: unclean state changes, should not be done in copy_to AND instantiate
633 if (flag [FLAG_RANDOM_SPEED] && speed)
634 speed_left = - speed - rndm (); // TODO animation
635 else
670 speed_left = -0.1f; 636 speed_left = -1.;
637
671 /* copy the body_info to the body_used - this is only really 638 /* copy the body_info to the body_used - this is only really
672 * need for monsters, but doesn't hurt to do it for everything. 639 * need for monsters, but doesn't hurt to do it for everything.
673 * by doing so, when a monster is created, it has good starting 640 * by doing so, when a monster is created, it has good starting
674 * values for the body_used info, so when items are created 641 * values for the body_used info, so when items are created
675 * for it, they can be properly equipped. 642 * for it, they can be properly equipped.
676 */ 643 */
677 for (int i = NUM_BODY_LOCATIONS; i--; ) 644 for (int i = NUM_BODY_LOCATIONS; i--; )
678 slot[i].used = slot[i].info; 645 slot[i].used = slot[i].info;
679 646
683object * 650object *
684object::clone () 651object::clone ()
685{ 652{
686 object *neu = create (); 653 object *neu = create ();
687 copy_to (neu); 654 copy_to (neu);
655
656 // TODO: unclean state changes, should not be done in clone AND instantiate
657 if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
658 neu->speed_left = - neu->speed - rndm (); // TODO animation
659
660 neu->map = map; // not copied by copy_to
688 return neu; 661 return neu;
689} 662}
690 663
691/* 664/*
692 * If an object with the IS_TURNABLE() flag needs to be turned due 665 * If an object with the IS_TURNABLE() flag needs to be turned due
694 * be called to update the face variable, _and_ how it looks on the map. 667 * be called to update the face variable, _and_ how it looks on the map.
695 */ 668 */
696void 669void
697update_turn_face (object *op) 670update_turn_face (object *op)
698{ 671{
699 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch) 672 if (!op->flag [FLAG_IS_TURNABLE] || !op->arch)
700 return; 673 return;
701 674
702 SET_ANIMATION (op, op->direction); 675 SET_ANIMATION (op, op->direction);
703 update_object (op, UP_OBJ_FACE); 676 update_object (op, UP_OBJ_FACE);
704} 677}
709 * This function needs to be called whenever the speed of an object changes. 682 * This function needs to be called whenever the speed of an object changes.
710 */ 683 */
711void 684void
712object::set_speed (float speed) 685object::set_speed (float speed)
713{ 686{
714 if (flag [FLAG_FREED] && speed)
715 {
716 LOG (llevError, "Object %s is freed but has speed.\n", &name);
717 speed = 0;
718 }
719
720 this->speed = speed; 687 this->speed = speed;
721 688
722 if (has_active_speed ()) 689 if (has_active_speed ())
723 activate (); 690 activate ();
724 else 691 else
743 * UP_OBJ_FACE: only the objects face has changed. 710 * UP_OBJ_FACE: only the objects face has changed.
744 */ 711 */
745void 712void
746update_object (object *op, int action) 713update_object (object *op, int action)
747{ 714{
748 if (op == NULL) 715 if (!op)
749 { 716 {
750 /* this should never happen */ 717 /* this should never happen */
751 LOG (llevDebug, "update_object() called for NULL object.\n"); 718 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
752 return; 719 return;
753 } 720 }
754 721
755 if (op->env) 722 if (!op->is_on_map ())
756 { 723 {
757 /* Animation is currently handled by client, so nothing 724 /* Animation is currently handled by client, so nothing
758 * to do in this case. 725 * to do in this case.
759 */ 726 */
760 return; 727 return;
761 } 728 }
762
763 /* If the map is saving, don't do anything as everything is
764 * going to get freed anyways.
765 */
766 if (!op->map || op->map->in_memory == MAP_SAVING)
767 return;
768 729
769 /* make sure the object is within map boundaries */ 730 /* make sure the object is within map boundaries */
770 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 731 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
771 { 732 {
772 LOG (llevError, "update_object() called for object out of map!\n"); 733 LOG (llevError, "update_object() called for object out of map!\n");
777 } 738 }
778 739
779 mapspace &m = op->ms (); 740 mapspace &m = op->ms ();
780 741
781 if (!(m.flags_ & P_UPTODATE)) 742 if (!(m.flags_ & P_UPTODATE))
782 /* nop */; 743 m.update_up (); // nothing to do except copy up
783 else if (action == UP_OBJ_INSERT) 744 else if (action == UP_OBJ_INSERT)
784 { 745 {
746#if 0
785 // this is likely overkill, TODO: revisit (schmorp) 747 // this is likely overkill, TODO: revisit (schmorp)
786 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 748 if ((op->flag [FLAG_BLOCKSVIEW] && !(m.flags_ & P_BLOCKSVIEW))
787 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 749 || (op->flag [FLAG_NO_MAGIC] && !(m.flags_ & P_NO_MAGIC))
788 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 750 || (op->is_player () && !(m.flags_ & P_PLAYER))
789 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 751 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
790 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 752 || (op->flag [FLAG_ALIVE] && !(m.flags_ & P_IS_ALIVE))
791 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 753 || (op->flag [FLAG_DAMNED] && !(m.flags_ & P_NO_CLERIC))
792 || (m.move_on | op->move_on ) != m.move_on 754 || (m.move_on | op->move_on ) != m.move_on
793 || (m.move_off | op->move_off ) != m.move_off 755 || (m.move_off | op->move_off ) != m.move_off
794 || (m.move_slow | op->move_slow) != m.move_slow 756 || (m.move_slow | op->move_slow) != m.move_slow
795 /* This isn't perfect, but I don't expect a lot of objects to 757 /* This isn't perfect, but I don't expect a lot of objects to
796 * to have move_allow right now. 758 * have move_allow right now.
797 */ 759 */
798 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 760 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
761 m.invalidate ();
762#else
799 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 763 // the above is not strong enough a test to skip updating. los maybe? TODO (schmorp)
800 m.flags_ = 0; 764 m.invalidate ();
765#endif
801 } 766 }
802 /* if the object is being removed, we can't make intelligent 767 /* if the object is being removed, we can't make intelligent
803 * decisions, because remove_ob can't really pass the object 768 * decisions, because remove_ob can't really pass the object
804 * that is being removed. 769 * that is being removed.
805 */ 770 */
806 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 771 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
807 m.flags_ = 0; 772 m.invalidate ();
808 else if (action == UP_OBJ_FACE) 773 else if (action == UP_OBJ_FACE)
809 /* Nothing to do for that case */ ; 774 m.update_up (); // nothing to do for that case, except copy up
810 else 775 else
811 LOG (llevError, "update_object called with invalid action: %d\n", action); 776 LOG (llevError, "update_object called with invalid action: %d\n", action);
812 777
813 if (op->more) 778 if (op->more)
814 update_object (op->more, action); 779 update_object (op->more, action);
815} 780}
816 781
817object::object () 782object::object ()
818{ 783{
819 SET_FLAG (this, FLAG_REMOVED); 784 this->set_flag (FLAG_REMOVED);
820 785
821 expmul = 1.0; 786 //expmul = 1.0; declared const for the time being
822 face = blank_face; 787 face = blank_face;
788 material = MATERIAL_NULL;
823} 789}
824 790
825object::~object () 791object::~object ()
826{ 792{
827 unlink (); 793 unlink ();
828 794
829 free_key_values (this); 795 kv.clear ();
830} 796}
831
832static int object_count;
833 797
834void object::link () 798void object::link ()
835{ 799{
836 assert (!index);//D 800 assert (!index);//D
837 uuid = UUID::gen (); 801 uuid = UUID::gen ();
838 count = ++object_count;
839 802
840 refcnt_inc (); 803 refcnt_inc ();
841 objects.insert (this); 804 objects.insert (this);
805
806 ++create_count;
807
842} 808}
843 809
844void object::unlink () 810void object::unlink ()
845{ 811{
846 if (!index) 812 if (!index)
847 return; 813 return;
814
815 ++destroy_count;
848 816
849 objects.erase (this); 817 objects.erase (this);
850 refcnt_dec (); 818 refcnt_dec ();
851} 819}
852 820
856 /* If already on active list, don't do anything */ 824 /* If already on active list, don't do anything */
857 if (active) 825 if (active)
858 return; 826 return;
859 827
860 if (has_active_speed ()) 828 if (has_active_speed ())
829 {
830 if (flag [FLAG_FREED])
831 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
832
861 actives.insert (this); 833 actives.insert (this);
834 }
862} 835}
863 836
864void 837void
865object::activate_recursive () 838object::activate_recursive ()
866{ 839{
915object::destroy_inv (bool drop_to_ground) 888object::destroy_inv (bool drop_to_ground)
916{ 889{
917 // need to check first, because the checks below might segfault 890 // need to check first, because the checks below might segfault
918 // as we might be on an invalid mapspace and crossfire code 891 // as we might be on an invalid mapspace and crossfire code
919 // is too buggy to ensure that the inventory is empty. 892 // is too buggy to ensure that the inventory is empty.
920 // corollary: if you create arrows etc. with stuff in tis inventory, 893 // corollary: if you create arrows etc. with stuff in its inventory,
921 // cf will crash below with off-map x and y 894 // cf will crash below with off-map x and y
922 if (!inv) 895 if (!inv)
923 return; 896 return;
924 897
925 /* Only if the space blocks everything do we not process - 898 /* Only if the space blocks everything do we not process -
926 * if some form of movement is allowed, let objects 899 * if some form of movement is allowed, let objects
927 * drop on that space. 900 * drop on that space.
928 */ 901 */
929 if (!drop_to_ground 902 if (!drop_to_ground
930 || !map 903 || !map
931 || map->in_memory != MAP_ACTIVE 904 || !map->linkable ()
932 || map->nodrop 905 || map->no_drop
933 || ms ().move_block == MOVE_ALL) 906 || ms ().move_block == MOVE_ALL)
934 { 907 {
935 while (inv) 908 while (inv)
936 {
937 inv->destroy_inv (drop_to_ground);
938 inv->destroy (); 909 inv->destroy ();
939 }
940 } 910 }
941 else 911 else
942 { /* Put objects in inventory onto this space */ 912 { /* Put objects in inventory onto this space */
943 while (inv) 913 while (inv)
944 { 914 {
955 map->insert (op, x, y); 925 map->insert (op, x, y);
956 } 926 }
957 } 927 }
958} 928}
959 929
930/*
931 * Remove and free all objects in the inventory of the given object.
932 * Unlike destroy_inv, this assumes the *this is destroyed as well
933 * well, so we can (and have to!) take shortcuts.
934 */
935void
936object::destroy_inv_fast ()
937{
938 while (object *op = inv)
939 {
940 // remove from object the fast way
941 op->flag [FLAG_REMOVED] = true;
942 op->env = 0;
943 if ((inv = inv->below))
944 inv->above = 0;
945
946 // then destroy
947 op->destroy ();
948 }
949}
950
951void
952object::freelist_free (int count)
953{
954 while (count-- && freelist)
955 {
956 freelist_item *next = freelist->next;
957 // count is being "destroyed"
958
959 sfree ((char *)freelist, sizeof (object));
960
961 freelist = next;
962 --free_count;
963 }
964}
965
966object *
960object *object::create () 967object::create ()
961{ 968{
962 object *op = new object; 969 object *op;
970
971 if (freelist)
972 {
973 freelist_item li = *freelist;
974 memset (freelist, 0, sizeof (object));
975
976 op = new (freelist) object;
977 op->count = li.count;
978
979 freelist = li.next;
980 --free_count;
981 }
982 else
983 {
984 void *ni = salloc0<char> (sizeof (object));
985
986 op = new(ni) object;
987
988 op->count = ++object_count;
989 }
990
963 op->link (); 991 op->link ();
992
964 return op; 993 return op;
965} 994}
966 995
967void 996void
997object::do_delete ()
998{
999 uint32_t count = this->count;
1000
1001 this->~object ();
1002
1003 freelist_item *li = (freelist_item *)this;
1004 li->next = freelist;
1005 li->count = count;
1006
1007 freelist = li;
1008 ++free_count;
1009}
1010
1011void
968object::do_destroy () 1012object::do_destroy ()
969{ 1013{
970 if (flag [FLAG_IS_LINKED]) 1014 if (flag [FLAG_IS_LINKED])
971 remove_button_link (this); 1015 remove_link ();
972 1016
973 if (flag [FLAG_FRIENDLY]) 1017 if (flag [FLAG_FRIENDLY])
974 remove_friendly_object (this); 1018 remove_friendly_object (this);
975 1019
976 remove (); 1020 remove ();
977 1021
978 attachable::do_destroy (); 1022 attachable::do_destroy ();
979 1023
980 destroy_inv (true);
981
982 deactivate (); 1024 deactivate ();
983 unlink (); 1025 unlink ();
984 1026
985 flag [FLAG_FREED] = 1; 1027 flag [FLAG_FREED] = 1;
986 1028
987 // hack to ensure that freed objects still have a valid map 1029 // hack to ensure that freed objects still have a valid map
988 {
989 static maptile *freed_map; // freed objects are moved here to avoid crashes
990
991 if (!freed_map)
992 {
993 freed_map = new maptile;
994
995 freed_map->path = "<freed objects map>";
996 freed_map->name = "/internal/freed_objects_map";
997 freed_map->width = 3;
998 freed_map->height = 3;
999 freed_map->nodrop = 1;
1000
1001 freed_map->alloc ();
1002 freed_map->in_memory = MAP_ACTIVE;
1003 }
1004
1005 map = freed_map; 1030 map = &freed_map;
1006 x = 1; 1031 x = 1;
1007 y = 1; 1032 y = 1;
1008 }
1009 1033
1010 if (more) 1034 if (more)
1011 { 1035 {
1012 more->destroy (); 1036 more->destroy ();
1013 more = 0; 1037 more = 0;
1021 attacked_by = 0; 1045 attacked_by = 0;
1022 current_weapon = 0; 1046 current_weapon = 0;
1023} 1047}
1024 1048
1025void 1049void
1026object::destroy (bool destroy_inventory) 1050object::destroy ()
1027{ 1051{
1028 if (destroyed ()) 1052 if (destroyed ())
1029 return; 1053 return;
1030 1054
1031 if (destroy_inventory) 1055 if (!is_head () && !head->destroyed ())
1056 {
1057 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1058 head->destroy ();
1059 return;
1060 }
1061
1032 destroy_inv (false); 1062 destroy_inv_fast ();
1033 1063
1034 if (is_head ()) 1064 if (is_head ())
1035 if (sound_destroy) 1065 if (sound_destroy)
1036 play_sound (sound_destroy); 1066 play_sound (sound_destroy);
1037 else if (flag [FLAG_MONSTER]) 1067 else if (flag [FLAG_MONSTER])
1048 * the previous environment. 1078 * the previous environment.
1049 */ 1079 */
1050void 1080void
1051object::do_remove () 1081object::do_remove ()
1052{ 1082{
1053 object *tmp, *last = 0;
1054 object *otmp;
1055
1056 if (flag [FLAG_REMOVED]) 1083 if (flag [FLAG_REMOVED])
1057 return; 1084 return;
1058 1085
1059 INVOKE_OBJECT (REMOVE, this); 1086 INVOKE_OBJECT (REMOVE, this);
1060
1061 if (object *pl = visible_to ())
1062 esrv_del_item (pl->contr, count);
1063 1087
1064 flag [FLAG_REMOVED] = true; 1088 flag [FLAG_REMOVED] = true;
1065 1089
1066 if (more) 1090 if (more)
1067 more->remove (); 1091 more->remove ();
1070 * In this case, the object to be removed is in someones 1094 * In this case, the object to be removed is in someones
1071 * inventory. 1095 * inventory.
1072 */ 1096 */
1073 if (env) 1097 if (env)
1074 { 1098 {
1099 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1100 if (object *pl = visible_to ())
1101 esrv_del_item (pl->contr, count);
1102 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1103
1075 adjust_weight (env, -total_weight ()); 1104 adjust_weight (env, total_weight (), 0);
1076 1105
1077 *(above ? &above->below : &env->inv) = below; 1106 object *pl = in_player ();
1078
1079 if (below)
1080 below->above = above;
1081 1107
1082 /* we set up values so that it could be inserted into 1108 /* we set up values so that it could be inserted into
1083 * the map, but we don't actually do that - it is up 1109 * the map, but we don't actually do that - it is up
1084 * to the caller to decide what we want to do. 1110 * to the caller to decide what we want to do.
1085 */ 1111 */
1086 map = env->map; 1112 map = env->map;
1087 x = env->x; 1113 x = env->x;
1088 y = env->y; 1114 y = env->y;
1115
1116 // make sure cmov optimisation is applicable
1117 *(above ? &above->below : &env->inv) = below;
1118 *(below ? &below->above : &above ) = above; // &above is just a dummy
1119
1089 above = 0; 1120 above = 0;
1090 below = 0; 1121 below = 0;
1091 env = 0; 1122 env = 0;
1092 1123
1093 /* NO_FIX_PLAYER is set when a great many changes are being 1124 if (pl && pl->is_player ())
1094 * made to players inventory. If set, avoiding the call
1095 * to save cpu time.
1096 */ 1125 {
1097 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1126 if (expect_false (pl->contr->combat_ob == this))
1098 otmp->update_stats (); 1127 {
1128 pl->apply (pl->contr->combat_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1129 pl->contr->combat_ob = 0;
1130 if (pl->contr->ranged_ob) pl->apply (pl->contr->ranged_ob);
1131 }
1132
1133 if (expect_false (pl->contr->ranged_ob == this))
1134 {
1135 pl->apply (pl->contr->ranged_ob, AP_UNAPPLY | AP_IGNORE_CURSE);
1136 pl->contr->ranged_ob = 0;
1137 if (pl->contr->combat_ob) pl->apply (pl->contr->combat_ob);
1138 }
1139
1140 pl->contr->queue_stats_update ();
1141
1142 if (expect_false (glow_radius) && pl->is_on_map ())
1143 update_all_los (pl->map, pl->x, pl->y);
1144 }
1099 } 1145 }
1100 else if (map) 1146 else if (map)
1101 { 1147 {
1102 if (type == PLAYER)
1103 {
1104 // leaving a spot always closes any open container on the ground
1105 if (container && !container->env)
1106 // this causes spurious floorbox updates, but it ensures
1107 // that the CLOSE event is being sent.
1108 close_container ();
1109
1110 --map->players;
1111 map->touch ();
1112 }
1113
1114 map->dirty = true; 1148 map->dirty = true;
1115 mapspace &ms = this->ms (); 1149 mapspace &ms = this->ms ();
1116 1150
1151 if (object *pl = ms.player ())
1152 {
1153 if (is_player ())
1154 {
1155 if (!flag [FLAG_WIZPASS])
1156 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1157
1158 // leaving a spot always closes any open container on the ground
1159 if (container && !container->env)
1160 // this causes spurious floorbox updates, but it ensures
1161 // that the CLOSE event is being sent.
1162 close_container ();
1163
1164 --map->players;
1165 map->touch ();
1166 }
1167 else if (pl->container_ () == this)
1168 {
1169 // removing a container should close it
1170 close_container ();
1171 }
1172 else
1173 esrv_del_item (pl->contr, count);
1174 }
1175
1117 /* link the object above us */ 1176 /* link the object above us */
1118 if (above) 1177 // re-link, make sure compiler can easily use cmove
1119 above->below = below; 1178 *(above ? &above->below : &ms.top) = below;
1120 else 1179 *(below ? &below->above : &ms.bot) = above;
1121 ms.top = below; /* we were top, set new top */
1122
1123 /* Relink the object below us, if there is one */
1124 if (below)
1125 below->above = above;
1126 else
1127 {
1128 /* Nothing below, which means we need to relink map object for this space
1129 * use translated coordinates in case some oddness with map tiling is
1130 * evident
1131 */
1132 if (GET_MAP_OB (map, x, y) != this)
1133 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1134
1135 ms.bot = above; /* goes on above it. */
1136 }
1137 1180
1138 above = 0; 1181 above = 0;
1139 below = 0; 1182 below = 0;
1140 1183
1141 if (map->in_memory == MAP_SAVING) 1184 ms.invalidate ();
1142 return;
1143 1185
1144 int check_walk_off = !flag [FLAG_NO_APPLY]; 1186 int check_walk_off = !flag [FLAG_NO_APPLY];
1145 1187
1146 if (object *pl = ms.player ()) 1188 if (object *pl = ms.player ())
1147 { 1189 {
1148 if (pl->container == this) 1190 if (pl->container_ () == this)
1149 /* If a container that the player is currently using somehow gets 1191 /* If a container that the player is currently using somehow gets
1150 * removed (most likely destroyed), update the player view 1192 * removed (most likely destroyed), update the player view
1151 * appropriately. 1193 * appropriately.
1152 */ 1194 */
1153 pl->close_container (); 1195 pl->close_container ();
1154 1196
1197 //TODO: the floorbox prev/next might need updating
1198 //esrv_del_item (pl->contr, count);
1199 //TODO: update floorbox to preserve ordering
1200 if (pl->contr->ns)
1155 pl->contr->ns->floorbox_update (); 1201 pl->contr->ns->floorbox_update ();
1156 } 1202 }
1157 1203
1204 if (check_walk_off)
1158 for (tmp = ms.bot; tmp; tmp = tmp->above) 1205 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1159 { 1206 {
1207 above = tmp->above;
1208
1160 /* No point updating the players look faces if he is the object 1209 /* No point updating the players look faces if he is the object
1161 * being removed. 1210 * being removed.
1162 */ 1211 */
1163 1212
1164 /* See if object moving off should effect something */ 1213 /* See if object moving off should effect something */
1165 if (check_walk_off
1166 && ((move_type & tmp->move_off) 1214 if ((move_type & tmp->move_off)
1167 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1215 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1168 {
1169 move_apply (tmp, this, 0); 1216 move_apply (tmp, this, 0);
1170
1171 if (destroyed ())
1172 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1173 } 1217 }
1174 1218
1175 last = tmp; 1219 if (affects_los ())
1176 }
1177
1178 /* last == NULL if there are no objects on this space */
1179 //TODO: this makes little sense, why only update the topmost object?
1180 if (!last)
1181 map->at (x, y).flags_ = 0;
1182 else
1183 update_object (last, UP_OBJ_REMOVE);
1184
1185 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1186 update_all_los (map, x, y); 1220 update_all_los (map, x, y);
1187 } 1221 }
1188} 1222}
1189 1223
1190/* 1224/*
1214 esrv_update_item (UPD_NROF, pl, top); 1248 esrv_update_item (UPD_NROF, pl, top);
1215 1249
1216 op->weight = 0; // cancel the addition above 1250 op->weight = 0; // cancel the addition above
1217 op->carrying = 0; // must be 0 already 1251 op->carrying = 0; // must be 0 already
1218 1252
1219 op->destroy (1); 1253 op->destroy ();
1220 1254
1221 return top; 1255 return top;
1222 } 1256 }
1223 1257
1224 return 0; 1258 return 0;
1232 1266
1233 object *prev = this; 1267 object *prev = this;
1234 1268
1235 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more) 1269 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1236 { 1270 {
1237 object *op = arch_to_object (at); 1271 object *op = at->instance ();
1238 1272
1239 op->name = name; 1273 op->name = name;
1240 op->name_pl = name_pl; 1274 op->name_pl = name_pl;
1241 op->title = title; 1275 op->title = title;
1242 1276
1252 * job preparing multi-part monsters. 1286 * job preparing multi-part monsters.
1253 */ 1287 */
1254object * 1288object *
1255insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1289insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1256{ 1290{
1291 op->remove ();
1292
1257 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1293 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1258 { 1294 {
1259 tmp->x = x + tmp->arch->x; 1295 tmp->x = x + tmp->arch->x;
1260 tmp->y = y + tmp->arch->y; 1296 tmp->y = y + tmp->arch->y;
1261 } 1297 }
1278 * Passing 0 for flag gives proper default values, so flag really only needs 1314 * Passing 0 for flag gives proper default values, so flag really only needs
1279 * to be set if special handling is needed. 1315 * to be set if special handling is needed.
1280 * 1316 *
1281 * Return value: 1317 * Return value:
1282 * new object if 'op' was merged with other object 1318 * new object if 'op' was merged with other object
1283 * NULL if 'op' was destroyed 1319 * NULL if there was an error (destroyed, blocked etc.)
1284 * just 'op' otherwise 1320 * just 'op' otherwise
1285 */ 1321 */
1286object * 1322object *
1287insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1323insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1288{ 1324{
1289 assert (!op->flag [FLAG_FREED]);
1290
1291 object *top, *floor = NULL;
1292
1293 op->remove (); 1325 op->remove ();
1326
1327 if (m == &freed_map)//D TODO: remove soon
1328 {//D
1329 LOG (llevError | logBacktrace, "tries to insert object on freed objects map: %s", op->debug_desc ());//D
1330 }//D
1294 1331
1295 /* Ideally, the caller figures this out. However, it complicates a lot 1332 /* Ideally, the caller figures this out. However, it complicates a lot
1296 * of areas of callers (eg, anything that uses find_free_spot would now 1333 * of areas of callers (eg, anything that uses find_free_spot would now
1297 * need extra work 1334 * need extra work
1298 */ 1335 */
1336 maptile *newmap = m;
1299 if (!xy_normalise (m, op->x, op->y)) 1337 if (!xy_normalise (newmap, op->x, op->y))
1300 { 1338 {
1301 op->destroy (); 1339 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1302 return 0; 1340 return 0;
1303 } 1341 }
1304 1342
1305 if (object *more = op->more) 1343 if (object *more = op->more)
1306 if (!insert_ob_in_map (more, m, originator, flag)) 1344 if (!insert_ob_in_map (more, m, originator, flag))
1307 return 0; 1345 return 0;
1308 1346
1309 CLEAR_FLAG (op, FLAG_REMOVED); 1347 op->flag [FLAG_REMOVED] = false;
1310 1348 op->env = 0;
1311 op->map = m; 1349 op->map = newmap;
1350
1312 mapspace &ms = op->ms (); 1351 mapspace &ms = op->ms ();
1313 1352
1314 /* this has to be done after we translate the coordinates. 1353 /* this has to be done after we translate the coordinates.
1315 */ 1354 */
1316 if (op->nrof && !(flag & INS_NO_MERGE)) 1355 if (op->nrof && !(flag & INS_NO_MERGE))
1317 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1356 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1318 if (object::can_merge (op, tmp)) 1357 if (object::can_merge (op, tmp))
1319 { 1358 {
1359 // TODO: we actually want to update tmp, not op,
1360 // but some caller surely breaks when we return tmp
1361 // from here :/
1320 op->nrof += tmp->nrof; 1362 op->nrof += tmp->nrof;
1321 tmp->destroy (1); 1363 tmp->destroy ();
1322 } 1364 }
1323 1365
1324 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1366 op->clr_flag (FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1325 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1367 op->clr_flag (FLAG_INV_LOCKED);
1326 1368
1327 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1369 if (!op->flag [FLAG_ALIVE])
1328 CLEAR_FLAG (op, FLAG_NO_STEAL); 1370 op->clr_flag (FLAG_NO_STEAL);
1329 1371
1330 if (flag & INS_BELOW_ORIGINATOR) 1372 if (flag & INS_BELOW_ORIGINATOR)
1331 { 1373 {
1332 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1374 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1333 { 1375 {
1334 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1376 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1335 abort (); 1377 abort ();
1336 } 1378 }
1337 1379
1380 if (!originator->is_on_map ())
1381 {
1382 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1383 op->debug_desc (), originator->debug_desc ());
1384 abort ();
1385 }
1386
1338 op->above = originator; 1387 op->above = originator;
1339 op->below = originator->below; 1388 op->below = originator->below;
1340
1341 if (op->below)
1342 op->below->above = op;
1343 else
1344 ms.bot = op;
1345
1346 /* since *below* originator, no need to update top */
1347 originator->below = op; 1389 originator->below = op;
1390
1391 *(op->below ? &op->below->above : &ms.bot) = op;
1348 } 1392 }
1349 else 1393 else
1350 { 1394 {
1351 top = ms.bot; 1395 object *floor = 0;
1396 object *top = ms.top;
1352 1397
1353 /* If there are other objects, then */ 1398 /* If there are other objects, then */
1354 if (top) 1399 if (top)
1355 { 1400 {
1356 object *last = 0;
1357
1358 /* 1401 /*
1359 * If there are multiple objects on this space, we do some trickier handling. 1402 * If there are multiple objects on this space, we do some trickier handling.
1360 * We've already dealt with merging if appropriate. 1403 * We've already dealt with merging if appropriate.
1361 * Generally, we want to put the new object on top. But if 1404 * Generally, we want to put the new object on top. But if
1362 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1405 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1365 * once we get to them. This reduces the need to traverse over all of 1408 * once we get to them. This reduces the need to traverse over all of
1366 * them when adding another one - this saves quite a bit of cpu time 1409 * them when adding another one - this saves quite a bit of cpu time
1367 * when lots of spells are cast in one area. Currently, it is presumed 1410 * when lots of spells are cast in one area. Currently, it is presumed
1368 * that flying non pickable objects are spell objects. 1411 * that flying non pickable objects are spell objects.
1369 */ 1412 */
1370 for (top = ms.bot; top; top = top->above) 1413 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1371 { 1414 {
1372 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1415 if (tmp->flag [FLAG_IS_FLOOR] || tmp->flag [FLAG_OVERLAY_FLOOR])
1373 floor = top; 1416 floor = tmp;
1374 1417
1375 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1418 if (tmp->flag [FLAG_NO_PICK] && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !tmp->flag [FLAG_IS_FLOOR])
1376 { 1419 {
1377 /* We insert above top, so we want this object below this */ 1420 /* We insert above top, so we want this object below this */
1378 top = top->below; 1421 top = tmp->below;
1379 break; 1422 break;
1380 } 1423 }
1381 1424
1382 last = top; 1425 top = tmp;
1383 } 1426 }
1384
1385 /* Don't want top to be NULL, so set it to the last valid object */
1386 top = last;
1387 1427
1388 /* We let update_position deal with figuring out what the space 1428 /* We let update_position deal with figuring out what the space
1389 * looks like instead of lots of conditions here. 1429 * looks like instead of lots of conditions here.
1390 * makes things faster, and effectively the same result. 1430 * makes things faster, and effectively the same result.
1391 */ 1431 */
1398 */ 1438 */
1399 if (!(flag & INS_ON_TOP) 1439 if (!(flag & INS_ON_TOP)
1400 && ms.flags () & P_BLOCKSVIEW 1440 && ms.flags () & P_BLOCKSVIEW
1401 && (op->face && !faces [op->face].visibility)) 1441 && (op->face && !faces [op->face].visibility))
1402 { 1442 {
1443 object *last;
1444
1403 for (last = top; last != floor; last = last->below) 1445 for (last = top; last != floor; last = last->below)
1404 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1446 if (last->flag [FLAG_BLOCKSVIEW] && (last->type != EXIT))
1405 break; 1447 break;
1406 1448
1407 /* Check to see if we found the object that blocks view, 1449 /* Check to see if we found the object that blocks view,
1408 * and make sure we have a below pointer for it so that 1450 * and make sure we have a below pointer for it so that
1409 * we can get inserted below this one, which requires we 1451 * we can get inserted below this one, which requires we
1415 } /* If objects on this space */ 1457 } /* If objects on this space */
1416 1458
1417 if (flag & INS_ABOVE_FLOOR_ONLY) 1459 if (flag & INS_ABOVE_FLOOR_ONLY)
1418 top = floor; 1460 top = floor;
1419 1461
1420 /* Top is the object that our object (op) is going to get inserted above. 1462 // insert object above top, or bottom-most if top = 0
1421 */
1422
1423 /* First object on this space */
1424 if (!top) 1463 if (!top)
1425 { 1464 {
1465 op->below = 0;
1426 op->above = ms.bot; 1466 op->above = ms.bot;
1427
1428 if (op->above)
1429 op->above->below = op;
1430
1431 op->below = 0;
1432 ms.bot = op; 1467 ms.bot = op;
1468
1469 *(op->above ? &op->above->below : &ms.top) = op;
1433 } 1470 }
1434 else 1471 else
1435 { /* get inserted into the stack above top */ 1472 {
1436 op->above = top->above; 1473 op->above = top->above;
1437
1438 if (op->above)
1439 op->above->below = op; 1474 top->above = op;
1440 1475
1441 op->below = top; 1476 op->below = top;
1442 top->above = op; 1477 *(op->above ? &op->above->below : &ms.top) = op;
1443 } 1478 }
1479 }
1444 1480
1445 if (!op->above) 1481 if (op->is_player ())
1446 ms.top = op;
1447 } /* else not INS_BELOW_ORIGINATOR */
1448
1449 if (op->type == PLAYER)
1450 { 1482 {
1451 op->contr->do_los = 1; 1483 op->contr->do_los = 1;
1452 ++op->map->players; 1484 ++op->map->players;
1453 op->map->touch (); 1485 op->map->touch ();
1454 } 1486 }
1455 1487
1456 op->map->dirty = true; 1488 op->map->dirty = true;
1457 1489
1458 if (object *pl = ms.player ()) 1490 if (object *pl = ms.player ())
1491 //TODO: the floorbox prev/next might need updating
1492 //esrv_send_item (pl, op);
1493 //TODO: update floorbox to preserve ordering
1494 if (pl->contr->ns)
1459 pl->contr->ns->floorbox_update (); 1495 pl->contr->ns->floorbox_update ();
1460 1496
1461 /* If this object glows, it may affect lighting conditions that are 1497 /* If this object glows, it may affect lighting conditions that are
1462 * visible to others on this map. But update_all_los is really 1498 * visible to others on this map. But update_all_los is really
1463 * an inefficient way to do this, as it means los for all players 1499 * an inefficient way to do this, as it means los for all players
1464 * on the map will get recalculated. The players could very well 1500 * on the map will get recalculated. The players could very well
1465 * be far away from this change and not affected in any way - 1501 * be far away from this change and not affected in any way -
1466 * this should get redone to only look for players within range, 1502 * this should get redone to only look for players within range,
1467 * or just updating the P_UPTODATE for spaces within this area 1503 * or just updating the P_UPTODATE for spaces within this area
1468 * of effect may be sufficient. 1504 * of effect may be sufficient.
1469 */ 1505 */
1470 if (op->map->darkness && (op->glow_radius != 0)) 1506 if (op->affects_los ())
1507 {
1508 op->ms ().invalidate ();
1471 update_all_los (op->map, op->x, op->y); 1509 update_all_los (op->map, op->x, op->y);
1510 }
1472 1511
1473 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1512 /* updates flags (blocked, alive, no magic, etc) for this map space */
1474 update_object (op, UP_OBJ_INSERT); 1513 update_object (op, UP_OBJ_INSERT);
1475 1514
1476 INVOKE_OBJECT (INSERT, op); 1515 INVOKE_OBJECT (INSERT, op);
1483 * blocked() and wall() work properly), and these flags are updated by 1522 * blocked() and wall() work properly), and these flags are updated by
1484 * update_object(). 1523 * update_object().
1485 */ 1524 */
1486 1525
1487 /* if this is not the head or flag has been passed, don't check walk on status */ 1526 /* if this is not the head or flag has been passed, don't check walk on status */
1488 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1527 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1489 { 1528 {
1490 if (check_move_on (op, originator)) 1529 if (check_move_on (op, originator, flag))
1491 return 0; 1530 return 0;
1492 1531
1493 /* If we are a multi part object, lets work our way through the check 1532 /* If we are a multi part object, let's work our way through the check
1494 * walk on's. 1533 * walk on's.
1495 */ 1534 */
1496 for (object *tmp = op->more; tmp; tmp = tmp->more) 1535 for (object *tmp = op->more; tmp; tmp = tmp->more)
1497 if (check_move_on (tmp, originator)) 1536 if (check_move_on (tmp, originator, flag))
1498 return 0; 1537 return 0;
1499 } 1538 }
1500 1539
1501 return op; 1540 return op;
1502} 1541}
1504/* this function inserts an object in the map, but if it 1543/* this function inserts an object in the map, but if it
1505 * finds an object of its own type, it'll remove that one first. 1544 * finds an object of its own type, it'll remove that one first.
1506 * op is the object to insert it under: supplies x and the map. 1545 * op is the object to insert it under: supplies x and the map.
1507 */ 1546 */
1508void 1547void
1509replace_insert_ob_in_map (const char *arch_string, object *op) 1548replace_insert_ob_in_map (shstr_tmp archname, object *op)
1510{ 1549{
1511 /* first search for itself and remove any old instances */ 1550 /* first search for itself and remove any old instances */
1512 1551
1513 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1552 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1514 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1553 if (tmp->arch->archname == archname) /* same archetype */
1515 tmp->destroy (1); 1554 tmp->destroy ();
1516 1555
1517 object *tmp = arch_to_object (archetype::find (arch_string)); 1556 object *tmp = archetype::find (archname)->instance ();
1518 1557
1519 tmp->x = op->x; 1558 tmp->x = op->x;
1520 tmp->y = op->y; 1559 tmp->y = op->y;
1521 1560
1522 insert_ob_in_map (tmp, op->map, op, 0); 1561 insert_ob_in_map (tmp, op->map, op, 0);
1527{ 1566{
1528 if (where->env) 1567 if (where->env)
1529 return where->env->insert (this); 1568 return where->env->insert (this);
1530 else 1569 else
1531 return where->map->insert (this, where->x, where->y, originator, flags); 1570 return where->map->insert (this, where->x, where->y, originator, flags);
1571}
1572
1573// check whether we can put this into the map, respect max_volume, max_items
1574bool
1575object::can_drop_at (maptile *m, int x, int y, object *originator)
1576{
1577 mapspace &ms = m->at (x, y);
1578
1579 int items = ms.items ();
1580
1581 if (!items // testing !items ensures we can drop at least one item
1582 || (items < m->max_items
1583 && ms.volume () < m->max_volume))
1584 return true;
1585
1586 if (originator)
1587 originator->failmsgf (
1588 "No matter how hard you try, you just cannot put the %s here! H<Try to remove some items from the floor first.>",
1589 query_name ()
1590 );
1591
1592 return false;
1532} 1593}
1533 1594
1534/* 1595/*
1535 * decrease(object, number) decreases a specified number from 1596 * decrease(object, number) decreases a specified number from
1536 * the amount of an object. If the amount reaches 0, the object 1597 * the amount of an object. If the amount reaches 0, the object
1544 if (!nr) 1605 if (!nr)
1545 return true; 1606 return true;
1546 1607
1547 nr = min (nr, nrof); 1608 nr = min (nr, nrof);
1548 1609
1610 if (nrof > nr)
1611 {
1612 weight_t oweight = total_weight ();
1613
1549 nrof -= nr; 1614 nrof -= nr;
1550
1551 if (nrof)
1552 {
1553 adjust_weight (env, -weight * nr); // carrying == 0
1554 1615
1555 if (object *pl = visible_to ()) 1616 if (object *pl = visible_to ())
1556 esrv_update_item (UPD_NROF, pl, this); 1617 esrv_update_item (UPD_NROF, pl, this);
1557 1618
1619 adjust_weight (env, oweight, total_weight ());
1620
1558 return true; 1621 return true;
1559 } 1622 }
1560 else 1623 else
1561 { 1624 {
1562 destroy (1); 1625 destroy ();
1563 return false; 1626 return false;
1564 } 1627 }
1565} 1628}
1566 1629
1567/* 1630/*
1584 } 1647 }
1585 else 1648 else
1586 { 1649 {
1587 decrease (nr); 1650 decrease (nr);
1588 1651
1589 object *op = object_create_clone (this); 1652 object *op = deep_clone ();
1590 op->nrof = nr; 1653 op->nrof = nr;
1591 return op; 1654 return op;
1592 } 1655 }
1593} 1656}
1594 1657
1636 if (op->nrof) 1699 if (op->nrof)
1637 for (object *tmp = inv; tmp; tmp = tmp->below) 1700 for (object *tmp = inv; tmp; tmp = tmp->below)
1638 if (object::can_merge (tmp, op)) 1701 if (object::can_merge (tmp, op))
1639 { 1702 {
1640 /* return the original object and remove inserted object 1703 /* return the original object and remove inserted object
1641 (client needs the original object) */ 1704 (client prefers the original object) */
1705
1706 // carrying must be 0 for mergable objects
1707 weight_t oweight = weight_t (tmp->weight) * tmp->nrof;
1708
1642 tmp->nrof += op->nrof; 1709 tmp->nrof += op->nrof;
1643 1710
1644 if (object *pl = tmp->visible_to ()) 1711 if (object *pl = tmp->visible_to ())
1645 esrv_update_item (UPD_NROF, pl, tmp); 1712 esrv_update_item (UPD_NROF, pl, tmp);
1646 1713
1647 adjust_weight (this, op->total_weight ()); 1714 adjust_weight (this, oweight, weight_t (tmp->weight) * tmp->nrof);
1648 1715
1649 op->destroy (1); 1716 op->destroy ();
1650 op = tmp; 1717 op = tmp;
1651 goto inserted; 1718 goto inserted;
1652 } 1719 }
1653 1720
1654 op->owner = 0; // it's his/hers now. period. 1721 op->owner = 0; // it's his/hers now. period.
1668 op->flag [FLAG_REMOVED] = 0; 1735 op->flag [FLAG_REMOVED] = 0;
1669 1736
1670 if (object *pl = op->visible_to ()) 1737 if (object *pl = op->visible_to ())
1671 esrv_send_item (pl, op); 1738 esrv_send_item (pl, op);
1672 1739
1673 adjust_weight (this, op->total_weight ()); 1740 adjust_weight (this, 0, op->total_weight ());
1674 1741
1675inserted: 1742inserted:
1676 /* reset the light list and los of the players on the map */ 1743 /* reset the light list and los of the players on the map */
1677 if (op->glow_radius && map && map->darkness) 1744 if (op->glow_radius && is_on_map ())
1745 {
1746 update_stats ();
1678 update_all_los (map, x, y); 1747 update_all_los (map, x, y);
1679 1748 }
1749 else if (is_player ())
1680 // if this is a player's inventory, update stats 1750 // if this is a player's inventory, update stats
1681 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER]) 1751 contr->queue_stats_update ();
1682 update_stats ();
1683 1752
1684 INVOKE_OBJECT (INSERT, this); 1753 INVOKE_OBJECT (INSERT, this);
1685 1754
1686 return op; 1755 return op;
1687} 1756}
1705 * MSW 2001-07-08: Check all objects on space, not just those below 1774 * MSW 2001-07-08: Check all objects on space, not just those below
1706 * object being inserted. insert_ob_in_map may not put new objects 1775 * object being inserted. insert_ob_in_map may not put new objects
1707 * on top. 1776 * on top.
1708 */ 1777 */
1709int 1778int
1710check_move_on (object *op, object *originator) 1779check_move_on (object *op, object *originator, int flags)
1711{ 1780{
1781 if (op->flag [FLAG_NO_APPLY])
1782 return 0;
1783
1712 object *tmp; 1784 object *tmp;
1713 maptile *m = op->map; 1785 maptile *m = op->map;
1714 int x = op->x, y = op->y; 1786 int x = op->x, y = op->y;
1715 1787
1716 MoveType move_on, move_slow, move_block; 1788 mapspace &ms = m->at (x, y);
1717 1789
1718 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1790 ms.update ();
1719 return 0;
1720 1791
1721 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1792 MoveType move_on = ms.move_on;
1722 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1793 MoveType move_slow = ms.move_slow;
1723 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1794 MoveType move_block = ms.move_block;
1724 1795
1725 /* if nothing on this space will slow op down or be applied, 1796 /* if nothing on this space will slow op down or be applied,
1726 * no need to do checking below. have to make sure move_type 1797 * no need to do checking below. have to make sure move_type
1727 * is set, as lots of objects don't have it set - we treat that 1798 * is set, as lots of objects don't have it set - we treat that
1728 * as walking. 1799 * as walking.
1739 return 0; 1810 return 0;
1740 1811
1741 /* The objects have to be checked from top to bottom. 1812 /* The objects have to be checked from top to bottom.
1742 * Hence, we first go to the top: 1813 * Hence, we first go to the top:
1743 */ 1814 */
1744 1815 for (object *next, *tmp = ms.top; tmp; tmp = next)
1745 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1746 {
1747 /* Trim the search when we find the first other spell effect
1748 * this helps performance so that if a space has 50 spell objects,
1749 * we don't need to check all of them.
1750 */
1751 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1752 break;
1753 } 1816 {
1817 next = tmp->below;
1754 1818
1755 for (; tmp; tmp = tmp->below)
1756 {
1757 if (tmp == op) 1819 if (tmp == op)
1758 continue; /* Can't apply yourself */ 1820 continue; /* Can't apply yourself */
1759 1821
1760 /* Check to see if one of the movement types should be slowed down. 1822 /* Check to see if one of the movement types should be slowed down.
1761 * Second check makes sure that the movement types not being slowed 1823 * Second check makes sure that the movement types not being slowed
1762 * (~slow_move) is not blocked on this space - just because the 1824 * (~slow_move) is not blocked on this space - just because the
1763 * space doesn't slow down swimming (for example), if you can't actually 1825 * space doesn't slow down swimming (for example), if you can't actually
1764 * swim on that space, can't use it to avoid the penalty. 1826 * swim on that space, can't use it to avoid the penalty.
1765 */ 1827 */
1766 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1828 if (!op->flag [FLAG_WIZPASS])
1767 { 1829 {
1768 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1830 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1769 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1831 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1770 { 1832 {
1771
1772 float
1773 diff = tmp->move_slow_penalty * fabs (op->speed); 1833 float diff = tmp->move_slow_penalty * fabs (op->speed);
1774 1834
1775 if (op->type == PLAYER) 1835 if (op->is_player ())
1776 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1836 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1777 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1837 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1778 diff /= 4.0; 1838 diff /= 4.0;
1779 1839
1780 op->speed_left -= diff; 1840 op->speed_left -= diff;
1781 } 1841 }
1782 } 1842 }
1783 1843
1784 /* Basically same logic as above, except now for actual apply. */ 1844 /* Basically same logic as above, except now for actual apply. */
1785 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1845 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1786 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1846 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1787 { 1847 {
1848 if ((flags & INS_NO_AUTO_EXIT)
1849 && (tmp->type == EXIT || tmp->type == TELEPORTER
1850 || tmp->type == HOLE || tmp->type == TRAPDOOR)) //TODO: temporary, fix exits instead
1851 continue;
1852
1788 move_apply (tmp, op, originator); 1853 move_apply (tmp, op, originator);
1789 1854
1790 if (op->destroyed ()) 1855 if (op->destroyed ())
1791 return 1; 1856 return 1;
1792 1857
1815 LOG (llevError, "Present_arch called outside map.\n"); 1880 LOG (llevError, "Present_arch called outside map.\n");
1816 return NULL; 1881 return NULL;
1817 } 1882 }
1818 1883
1819 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1884 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1820 if (tmp->arch == at) 1885 if (tmp->arch->archname == at->archname)
1821 return tmp; 1886 return tmp;
1822 1887
1823 return NULL; 1888 return NULL;
1824} 1889}
1825 1890
1889 * The first matching object is returned, or NULL if none. 1954 * The first matching object is returned, or NULL if none.
1890 */ 1955 */
1891object * 1956object *
1892present_arch_in_ob (const archetype *at, const object *op) 1957present_arch_in_ob (const archetype *at, const object *op)
1893{ 1958{
1894 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1959 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1895 if (tmp->arch == at) 1960 if (tmp->arch->archname == at->archname)
1896 return tmp; 1961 return tmp;
1897 1962
1898 return NULL; 1963 return NULL;
1899} 1964}
1900 1965
1904void 1969void
1905flag_inv (object *op, int flag) 1970flag_inv (object *op, int flag)
1906{ 1971{
1907 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1972 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1908 { 1973 {
1909 SET_FLAG (tmp, flag); 1974 tmp->set_flag (flag);
1910 flag_inv (tmp, flag); 1975 flag_inv (tmp, flag);
1911 } 1976 }
1912} 1977}
1913 1978
1914/* 1979/*
1917void 1982void
1918unflag_inv (object *op, int flag) 1983unflag_inv (object *op, int flag)
1919{ 1984{
1920 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1985 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1921 { 1986 {
1922 CLEAR_FLAG (tmp, flag); 1987 tmp->clr_flag (flag);
1923 unflag_inv (tmp, flag); 1988 unflag_inv (tmp, flag);
1924 } 1989 }
1925} 1990}
1926 1991
1927/* 1992/*
1944 */ 2009 */
1945int 2010int
1946find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2011find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
1947{ 2012{
1948 int altern[SIZEOFFREE]; 2013 int altern[SIZEOFFREE];
1949 int index = 0, flag; 2014 int index = 0;
1950 2015
1951 for (int i = start; i < stop; i++) 2016 for (int i = start; i < stop; i++)
1952 { 2017 {
1953 mapxy pos (m, x, y); pos.move (i); 2018 mapxy pos (m, x, y); pos.move (i);
1954 2019
1988 * head of the object should correspond for the entire object. 2053 * head of the object should correspond for the entire object.
1989 */ 2054 */
1990 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 2055 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1991 continue; 2056 continue;
1992 2057
1993 if (ob->blocked (m, pos.x, pos.y)) 2058 if (ob->blocked (pos.m, pos.x, pos.y))
1994 continue; 2059 continue;
1995 2060
1996 altern [index++] = i; 2061 altern [index++] = i;
1997 } 2062 }
1998 2063
2066 * there is capable of. 2131 * there is capable of.
2067 */ 2132 */
2068int 2133int
2069find_dir (maptile *m, int x, int y, object *exclude) 2134find_dir (maptile *m, int x, int y, object *exclude)
2070{ 2135{
2071 int i, max = SIZEOFFREE, mflags; 2136 int max = SIZEOFFREE;
2072
2073 sint16 nx, ny;
2074 object *tmp;
2075 maptile *mp;
2076
2077 MoveType blocked, move_type; 2137 MoveType move_type;
2078 2138
2079 if (exclude && exclude->head_ () != exclude) 2139 if (exclude && exclude->head_ () != exclude)
2080 { 2140 {
2081 exclude = exclude->head; 2141 exclude = exclude->head;
2082 move_type = exclude->move_type; 2142 move_type = exclude->move_type;
2085 { 2145 {
2086 /* If we don't have anything, presume it can use all movement types. */ 2146 /* If we don't have anything, presume it can use all movement types. */
2087 move_type = MOVE_ALL; 2147 move_type = MOVE_ALL;
2088 } 2148 }
2089 2149
2090 for (i = 1; i < max; i++) 2150 for (int i = 1; i < max; i++)
2091 { 2151 {
2092 mp = m; 2152 mapxy pos (m, x, y);
2093 nx = x + freearr_x[i]; 2153 pos.move (i);
2094 ny = y + freearr_y[i];
2095 2154
2096 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2155 if (!pos.normalise ())
2097
2098 if (mflags & P_OUT_OF_MAP)
2099 max = maxfree[i]; 2156 max = maxfree[i];
2100 else 2157 else
2101 { 2158 {
2102 mapspace &ms = mp->at (nx, ny); 2159 mapspace &ms = *pos;
2103 2160
2104 blocked = ms.move_block;
2105
2106 if ((move_type & blocked) == move_type) 2161 if ((move_type & ms.move_block) == move_type)
2107 max = maxfree[i]; 2162 max = maxfree [i];
2108 else if (mflags & P_IS_ALIVE) 2163 else if (ms.flags () & P_IS_ALIVE)
2109 { 2164 {
2110 for (tmp = ms.bot; tmp; tmp = tmp->above) 2165 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2111 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2166 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2112 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2167 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2113 break;
2114
2115 if (tmp)
2116 return freedir[i]; 2168 return freedir [i];
2117 } 2169 }
2118 } 2170 }
2119 } 2171 }
2120 2172
2121 return 0; 2173 return 0;
2130{ 2182{
2131 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2183 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2132} 2184}
2133 2185
2134/* 2186/*
2135 * find_dir_2(delta-x,delta-y) will return a direction in which 2187 * find_dir_2(delta-x,delta-y) will return a direction value
2136 * an object which has subtracted the x and y coordinates of another 2188 * for running into direct [dx, dy].
2137 * object, needs to travel toward it. 2189 * (the opposite of crossfire's find_dir_2!)
2138 */ 2190 */
2139int 2191int
2140find_dir_2 (int x, int y) 2192find_dir_2 (int x, int y)
2141{ 2193{
2194#if 1 // new algorithm
2195 // this works by putting x, y into 16 sectors, which
2196 // are not equal sized, but are a better approximation
2197 // then the old algorithm, and then using a mapping
2198 // table to map it into a direction value.
2199 // basically, it maps these comparisons to each bit
2200 // bit #3: x < 0
2201 // bit #2: y < 0
2202 // bit #1: x > y
2203 // bit #0: x > 2y
2204
2205 static const uint8 dir[16] = {
2206 4, 5, 4, 3,
2207 2, 1, 2, 3,
2208 6, 5, 6, 7,
2209 8, 1, 8, 7,
2210 };
2211 int sector = 0;
2212
2213 // this is a bit ugly, but more likely to result in branchless code
2214 sector |= x < 0 ? 8 : 0;
2215 x = x < 0 ? -x : x; // abs
2216
2217 sector |= y < 0 ? 4 : 0;
2218 y = y < 0 ? -y : y; // abs
2219
2220 if (x > y)
2221 {
2222 sector |= 2;
2223
2224 if (x > y * 2)
2225 sector |= 1;
2226 }
2227 else
2228 {
2229 if (y > x * 2)
2230 sector |= 1;
2231 else if (!y)
2232 return 0; // x == 0 here
2233 }
2234
2235 return dir [sector];
2236#else // old algorithm
2142 int q; 2237 int q;
2143 2238
2144 if (y) 2239 if (y)
2145 q = x * 100 / y; 2240 q = 128 * x / y;
2146 else if (x) 2241 else if (x)
2147 q = -300 * x; 2242 q = -512 * x; // to make it > 309
2148 else 2243 else
2149 return 0; 2244 return 0;
2150 2245
2151 if (y > 0) 2246 if (y > 0)
2152 { 2247 {
2153 if (q < -242) 2248 if (q < -309) return 7;
2249 if (q < -52) return 6;
2250 if (q < 52) return 5;
2251 if (q < 309) return 4;
2252
2154 return 3; 2253 return 3;
2155 if (q < -41) 2254 }
2156 return 2; 2255 else
2157 if (q < 41) 2256 {
2158 return 1; 2257 if (q < -309) return 3;
2159 if (q < 242) 2258 if (q < -52) return 2;
2160 return 8; 2259 if (q < 52) return 1;
2260 if (q < 309) return 8;
2261
2161 return 7; 2262 return 7;
2162 } 2263 }
2163 2264#endif
2164 if (q < -242)
2165 return 7;
2166 if (q < -41)
2167 return 6;
2168 if (q < 41)
2169 return 5;
2170 if (q < 242)
2171 return 4;
2172
2173 return 3;
2174} 2265}
2175 2266
2176/* 2267/*
2177 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2268 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2178 * between two directions (which are expected to be absolute (see absdir()) 2269 * between two directions (which are expected to be absolute (see absdir())
2179 */ 2270 */
2180int 2271int
2181dirdiff (int dir1, int dir2) 2272dirdiff (int dir1, int dir2)
2182{ 2273{
2183 int d;
2184
2185 d = abs (dir1 - dir2); 2274 int d = abs (dir1 - dir2);
2186 if (d > 4)
2187 d = 8 - d;
2188 2275
2189 return d; 2276 return d > 4 ? 8 - d : d;
2190} 2277}
2191 2278
2192/* peterm: 2279/* peterm:
2193 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2280 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2194 * Basically, this is a table of directions, and what directions 2281 * Basically, this is a table of directions, and what directions
2196 * This basically means that if direction is 15, then it could either go 2283 * This basically means that if direction is 15, then it could either go
2197 * direction 4, 14, or 16 to get back to where we are. 2284 * direction 4, 14, or 16 to get back to where we are.
2198 * Moved from spell_util.c to object.c with the other related direction 2285 * Moved from spell_util.c to object.c with the other related direction
2199 * functions. 2286 * functions.
2200 */ 2287 */
2201int reduction_dir[SIZEOFFREE][3] = { 2288static const int reduction_dir[SIZEOFFREE][3] = {
2202 {0, 0, 0}, /* 0 */ 2289 {0, 0, 0}, /* 0 */
2203 {0, 0, 0}, /* 1 */ 2290 {0, 0, 0}, /* 1 */
2204 {0, 0, 0}, /* 2 */ 2291 {0, 0, 0}, /* 2 */
2205 {0, 0, 0}, /* 3 */ 2292 {0, 0, 0}, /* 3 */
2206 {0, 0, 0}, /* 4 */ 2293 {0, 0, 0}, /* 4 */
2300 * Add a check so we can't pick up invisible objects (0.93.8) 2387 * Add a check so we can't pick up invisible objects (0.93.8)
2301 */ 2388 */
2302int 2389int
2303can_pick (const object *who, const object *item) 2390can_pick (const object *who, const object *item)
2304{ 2391{
2305 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2392 return /*who->flag [FLAG_WIZ]|| */
2306 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2393 (item->weight > 0 && !item->flag [FLAG_NO_PICK] &&
2307 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2394 !item->flag [FLAG_ALIVE] && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2308} 2395}
2396
2397//-GPL
2309 2398
2310/* 2399/*
2311 * create clone from object to another 2400 * create clone from object to another
2312 */ 2401 */
2313object * 2402object *
2314object_create_clone (object *asrc) 2403object::deep_clone ()
2315{ 2404{
2316 object *dst = 0, *tmp, *src, *prev, *item; 2405 assert (("deep_clone called on non-head object", is_head ()));
2317 2406
2318 if (!asrc) 2407 object *dst = clone ();
2319 return 0;
2320 2408
2321 src = asrc->head_ (); 2409 object *prev = dst;
2322
2323 prev = 0;
2324 for (object *part = src; part; part = part->more) 2410 for (object *part = this->more; part; part = part->more)
2325 { 2411 {
2326 tmp = part->clone (); 2412 object *tmp = part->clone ();
2327 tmp->x -= src->x;
2328 tmp->y -= src->y;
2329
2330 if (!part->head)
2331 {
2332 dst = tmp;
2333 tmp->head = 0;
2334 }
2335 else
2336 tmp->head = dst; 2413 tmp->head = dst;
2337
2338 tmp->more = 0;
2339
2340 if (prev)
2341 prev->more = tmp; 2414 prev->more = tmp;
2342
2343 prev = tmp; 2415 prev = tmp;
2344 } 2416 }
2345 2417
2346 for (item = src->inv; item; item = item->below) 2418 for (object *item = inv; item; item = item->below)
2347 insert_ob_in_ob (object_create_clone (item), dst); 2419 insert_ob_in_ob (item->deep_clone (), dst);
2348 2420
2349 return dst; 2421 return dst;
2350} 2422}
2351 2423
2352/* This returns the first object in who's inventory that 2424/* This returns the first object in who's inventory that
2361 return tmp; 2433 return tmp;
2362 2434
2363 return 0; 2435 return 0;
2364} 2436}
2365 2437
2366/* If ob has a field named key, return the link from the list, 2438/* Zero the key_values on op, decrementing the shared-string
2367 * otherwise return NULL. 2439 * refcounts and freeing the links.
2368 * 2440 */
2369 * key must be a passed in shared string - otherwise, this won't 2441void
2370 * do the desired thing. 2442key_values::clear ()
2371 */
2372key_value *
2373get_ob_key_link (const object *ob, const char *key)
2374{ 2443{
2375 for (key_value *link = ob->key_values; link; link = link->next) 2444 for (key_value *kvp = first; kvp; )
2445 {
2446 key_value *next = kvp->next;
2447 delete kvp;
2448 kvp = next;
2449 }
2450
2451 first = 0;
2452}
2453
2454shstr_tmp
2455key_values::get (shstr_tmp key) const
2456{
2457 for (key_value *kv = first; kv; kv = kv->next)
2376 if (link->key == key) 2458 if (kv->key == key)
2377 return link;
2378
2379 return 0;
2380}
2381
2382/*
2383 * Returns the value of op has an extra_field for key, or NULL.
2384 *
2385 * The argument doesn't need to be a shared string.
2386 *
2387 * The returned string is shared.
2388 */
2389const char *
2390get_ob_key_value (const object *op, const char *const key)
2391{
2392 key_value *link;
2393 shstr_cmp canonical_key (key);
2394
2395 if (!canonical_key)
2396 {
2397 /* 1. There being a field named key on any object
2398 * implies there'd be a shared string to find.
2399 * 2. Since there isn't, no object has this field.
2400 * 3. Therefore, *this* object doesn't have this field.
2401 */
2402 return 0;
2403 }
2404
2405 /* This is copied from get_ob_key_link() above -
2406 * only 4 lines, and saves the function call overhead.
2407 */
2408 for (link = op->key_values; link; link = link->next)
2409 if (link->key == canonical_key)
2410 return link->value; 2459 return kv->value;
2411 2460
2412 return 0; 2461 return shstr ();
2413} 2462}
2414 2463
2415/* 2464void
2416 * Updates the canonical_key in op to value. 2465key_values::add (shstr_tmp key, shstr_tmp value)
2417 *
2418 * canonical_key is a shared string (value doesn't have to be).
2419 *
2420 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2421 * keys.
2422 *
2423 * Returns TRUE on success.
2424 */
2425int
2426set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2427{ 2466{
2428 key_value *field = NULL, *last = NULL; 2467 key_value *kv = new key_value;
2429 2468
2430 for (field = op->key_values; field != NULL; field = field->next) 2469 kv->next = first;
2431 { 2470 kv->key = key;
2432 if (field->key != canonical_key) 2471 kv->value = value;
2472
2473 first = kv;
2474}
2475
2476void
2477key_values::set (shstr_tmp key, shstr_tmp value)
2478{
2479 for (key_value *kv = first; kv; kv = kv->next)
2480 if (kv->key == key)
2433 { 2481 {
2434 last = field; 2482 kv->value = value;
2435 continue; 2483 return;
2436 } 2484 }
2437 2485
2438 if (value) 2486 add (key, value);
2439 field->value = value; 2487}
2440 else 2488
2489void
2490key_values::del (shstr_tmp key)
2491{
2492 for (key_value **kvp = &first; *kvp; kvp = &(*kvp)->next)
2493 if ((*kvp)->key == key)
2441 { 2494 {
2442 /* Basically, if the archetype has this key set, 2495 key_value *kv = *kvp;
2443 * we need to store the null value so when we save 2496 *kvp = (*kvp)->next;
2444 * it, we save the empty value so that when we load, 2497 delete kv;
2445 * we get this value back again. 2498 return;
2446 */
2447 if (get_ob_key_link (op->arch, canonical_key))
2448 field->value = 0;
2449 else
2450 {
2451 if (last)
2452 last->next = field->next;
2453 else
2454 op->key_values = field->next;
2455
2456 delete field;
2457 }
2458 } 2499 }
2459 return TRUE; 2500}
2501
2502void
2503key_values::reverse ()
2504{
2505 key_value *prev = 0;
2506 key_value *head = first;
2507
2508 while (head)
2460 } 2509 {
2461 /* IF we get here, key doesn't exist */ 2510 key_value *node = head;
2511 head = head->next;
2512 node->next = prev;
2513 prev = node;
2514 }
2462 2515
2463 /* No field, we'll have to add it. */ 2516 first = prev;
2464
2465 if (!add_key)
2466 return FALSE;
2467
2468 /* There isn't any good reason to store a null
2469 * value in the key/value list. If the archetype has
2470 * this key, then we should also have it, so shouldn't
2471 * be here. If user wants to store empty strings,
2472 * should pass in ""
2473 */
2474 if (value == NULL)
2475 return TRUE;
2476
2477 field = new key_value;
2478
2479 field->key = canonical_key;
2480 field->value = value;
2481 /* Usual prepend-addition. */
2482 field->next = op->key_values;
2483 op->key_values = field;
2484
2485 return TRUE;
2486} 2517}
2487 2518
2488/* 2519key_values &
2489 * Updates the key in op to value. 2520key_values::operator =(const key_values &kv)
2490 *
2491 * If add_key is FALSE, this will only update existing keys,
2492 * and not add new ones.
2493 * In general, should be little reason FALSE is ever passed in for add_key
2494 *
2495 * Returns TRUE on success.
2496 */
2497int
2498set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2499{ 2521{
2500 shstr key_ (key); 2522 clear ();
2501 2523
2502 return set_ob_key_value_s (op, key_, value, add_key); 2524 for (key_value *kvp = kv.first; kvp; kvp = kvp->next)
2525 add (kvp->key, kvp->value);
2526
2527 reverse ();
2503} 2528}
2504 2529
2505object::depth_iterator::depth_iterator (object *container) 2530object::depth_iterator::depth_iterator (object *container)
2506: iterator_base (container) 2531: iterator_base (container)
2507{ 2532{
2557{ 2582{
2558 char flagdesc[512]; 2583 char flagdesc[512];
2559 char info2[256 * 4]; 2584 char info2[256 * 4];
2560 char *p = info; 2585 char *p = info;
2561 2586
2562 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2587 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2563 count, 2588 count,
2564 uuid.c_str (), 2589 uuid.c_str (),
2565 &name, 2590 &name,
2566 title ? "\",title:\"" : "", 2591 title ? ",title:\"" : "",
2567 title ? (const char *)title : "", 2592 title ? (const char *)title : "",
2593 title ? "\"" : "",
2568 flag_desc (flagdesc, 512), type); 2594 flag_desc (flagdesc, 512), type);
2569 2595
2570 if (!this->flag[FLAG_REMOVED] && env) 2596 if (!flag[FLAG_REMOVED] && env)
2571 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2597 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2572 2598
2573 if (map) 2599 if (map)
2574 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2600 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2575 2601
2590{ 2616{
2591 return map ? map->region (x, y) 2617 return map ? map->region (x, y)
2592 : region::default_region (); 2618 : region::default_region ();
2593} 2619}
2594 2620
2595const materialtype_t * 2621//+GPL
2596object::dominant_material () const
2597{
2598 if (materialtype_t *mt = name_to_material (materialname))
2599 return mt;
2600
2601 return name_to_material (shstr_unknown);
2602}
2603 2622
2604void 2623void
2605object::open_container (object *new_container) 2624object::open_container (object *new_container)
2606{ 2625{
2607 if (container == new_container) 2626 if (container == new_container)
2608 return; 2627 return;
2609 2628
2610 if (object *old_container = container) 2629 object *old_container = container;
2630
2631 if (old_container)
2611 { 2632 {
2612 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2633 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2613 return; 2634 return;
2614 2635
2615#if 0 2636#if 0
2617 if (object *closer = old_container->inv) 2638 if (object *closer = old_container->inv)
2618 if (closer->type == CLOSE_CON) 2639 if (closer->type == CLOSE_CON)
2619 closer->destroy (); 2640 closer->destroy ();
2620#endif 2641#endif
2621 2642
2643 // make sure the container is available
2644 esrv_send_item (this, old_container);
2645
2622 old_container->flag [FLAG_APPLIED] = 0; 2646 old_container->flag [FLAG_APPLIED] = false;
2623 container = 0; 2647 container = 0;
2624 2648
2649 // client needs item update to make it work, client bug requires this to be separate
2625 esrv_update_item (UPD_FLAGS, this, old_container); 2650 esrv_update_item (UPD_FLAGS, this, old_container);
2651
2626 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2652 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2627 play_sound (sound_find ("chest_close")); 2653 play_sound (sound_find ("chest_close"));
2628 } 2654 }
2629 2655
2630 if (new_container) 2656 if (new_container)
2631 { 2657 {
2635 // TODO: this does not seem to serve any purpose anymore? 2661 // TODO: this does not seem to serve any purpose anymore?
2636#if 0 2662#if 0
2637 // insert the "Close Container" object. 2663 // insert the "Close Container" object.
2638 if (archetype *closer = new_container->other_arch) 2664 if (archetype *closer = new_container->other_arch)
2639 { 2665 {
2640 object *closer = arch_to_object (new_container->other_arch); 2666 object *closer = new_container->other_arch->instance ();
2641 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2667 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2642 new_container->insert (closer); 2668 new_container->insert (closer);
2643 } 2669 }
2644#endif 2670#endif
2645 2671
2646 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2672 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2647 2673
2674 // make sure the container is available, client bug requires this to be separate
2675 esrv_send_item (this, new_container);
2676
2648 new_container->flag [FLAG_APPLIED] = 1; 2677 new_container->flag [FLAG_APPLIED] = true;
2649 container = new_container; 2678 container = new_container;
2650 2679
2680 // client needs flag change
2651 esrv_update_item (UPD_FLAGS, this, new_container); 2681 esrv_update_item (UPD_FLAGS, this, new_container);
2652 esrv_send_inventory (this, new_container); 2682 esrv_send_inventory (this, new_container);
2653 play_sound (sound_find ("chest_open")); 2683 play_sound (sound_find ("chest_open"));
2654 } 2684 }
2685// else if (!old_container->env && contr && contr->ns)
2686// contr->ns->floorbox_reset ();
2655} 2687}
2688
2689//-GPL
2690
2691// prefetch some flat area around the player
2692static void
2693prefetch_surrounding_area (object *op, maptile *map, int range)
2694{
2695 for (maprect *rect = map->split_to_tiles (mapwalk_buf,
2696 op->x - range , op->y - range ,
2697 op->x + range + 1, op->y + range + 1);
2698 rect->m;
2699 ++rect)
2700 {
2701 rect->m->touch ();
2702 rect->m->activate ();
2703 }
2704}
2705
2706// prefetch a generous area around the player, also up and down
2707void
2708object::prefetch_surrounding_maps ()
2709{
2710 prefetch_surrounding_area (this, map, 40);
2711
2712 if (maptile *m = map->tile_available (TILE_DOWN))
2713 prefetch_surrounding_area (this, m, 20);
2714
2715 if (maptile *m = map->tile_available (TILE_UP))
2716 prefetch_surrounding_area (this, m, 20);
2717}
2718
2719//+GPL
2656 2720
2657object * 2721object *
2658object::force_find (const shstr name) 2722object::force_find (shstr_tmp name)
2659{ 2723{
2660 /* cycle through his inventory to look for the MARK we want to 2724 /* cycle through his inventory to look for the MARK we want to
2661 * place 2725 * place
2662 */ 2726 */
2663 for (object *tmp = inv; tmp; tmp = tmp->below) 2727 for (object *tmp = inv; tmp; tmp = tmp->below)
2666 2730
2667 return 0; 2731 return 0;
2668} 2732}
2669 2733
2670void 2734void
2735object::force_set_timer (int duration)
2736{
2737 this->duration = 1;
2738 this->speed_left = -1.f;
2739
2740 this->set_speed (duration ? 1.f / duration : 0.f);
2741}
2742
2743object *
2671object::force_add (const shstr name, int duration) 2744object::force_add (shstr_tmp name, int duration)
2672{ 2745{
2673 if (object *force = force_find (name)) 2746 if (object *force = force_find (name))
2674 force->destroy (); 2747 force->destroy ();
2675 2748
2676 object *force = get_archetype (FORCE_NAME); 2749 object *force = archetype::get (FORCE_NAME);
2677 2750
2678 force->slaying = name; 2751 force->slaying = name;
2679 force->stats.food = 1; 2752 force->force_set_timer (duration);
2680 force->speed_left = -1.f;
2681
2682 force->set_speed (duration ? 1.f / duration : 0.f);
2683 force->flag [FLAG_IS_USED_UP] = true;
2684 force->flag [FLAG_APPLIED] = true; 2753 force->flag [FLAG_APPLIED] = true;
2685 2754
2686 insert (force); 2755 return insert (force);
2687} 2756}
2688 2757
2689void 2758void
2690object::play_sound (faceidx sound) 2759object::play_sound (faceidx sound) const
2691{ 2760{
2692 if (!sound) 2761 if (!sound)
2693 return; 2762 return;
2694 2763
2695 if (flag [FLAG_REMOVED]) 2764 if (is_on_map ())
2765 map->play_sound (sound, x, y);
2766 else if (object *pl = in_player ())
2767 pl->contr->play_sound (sound);
2768}
2769
2770void
2771object::say_msg (const char *msg) const
2772{
2773 if (is_on_map ())
2774 map->say_msg (msg, x, y);
2775 else if (object *pl = in_player ())
2776 pl->contr->play_sound (sound);
2777}
2778
2779void
2780object::make_noise ()
2781{
2782 // we do not model noise in the map, so instead put
2783 // a temporary light into the noise source
2784 // could use the map instead, but that's less reliable for our
2785 // goal, which is to make invisibility a bit harder to exploit
2786
2787 // currently only works sensibly for players
2788 if (!is_player ())
2696 return; 2789 return;
2697 2790
2698 if (env) 2791 // find old force, or create new one
2699 { 2792 object *force = force_find (shstr_noise_force);
2700 if (object *pl = in_player ()) 2793
2701 pl->contr->play_sound (sound); 2794 if (force)
2702 } 2795 force->speed_left = -1.f; // patch old speed up
2703 else 2796 else
2704 map->play_sound (sound, x, y); 2797 {
2705} 2798 force = archetype::get (shstr_noise_force);
2706 2799
2800 force->slaying = shstr_noise_force;
2801 force->stats.food = 1;
2802 force->speed_left = -1.f;
2803
2804 force->set_speed (1.f / 4.f);
2805 force->flag [FLAG_IS_USED_UP] = true;
2806 force->flag [FLAG_APPLIED] = true;
2807
2808 insert (force);
2809 }
2810}
2811
2812void object::change_move_type (MoveType mt)
2813{
2814 if (move_type == mt)
2815 return;
2816
2817 if (is_on_map ())
2818 {
2819 // we are on the map, so handle move_on/off effects
2820 remove ();
2821 move_type = mt;
2822 map->insert (this, x, y, this);
2823 }
2824 else
2825 move_type = mt;
2826}
2827
2828/* object should be a player.
2829 * we return the object the player has marked with the 'mark' command
2830 * below. If no match is found (or object has changed), we return
2831 * NULL. We leave it up to the calling function to print messages if
2832 * nothing is found.
2833 */
2834object *
2835object::mark () const
2836{
2837 if (contr && contr->mark && contr->mark->env == this)
2838 return contr->mark;
2839 else
2840 return 0;
2841}
2842
2843// put marked object first in the inventory
2844// this is used by identify-like spells so players can influence
2845// the order a bit.
2846void
2847object::splay_marked ()
2848{
2849 if (object *marked = mark ())
2850 splay (marked);
2851}
2852

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines