ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.4 by root, Sat Aug 26 23:36:30 2006 UTC vs.
Revision 1.10 by root, Thu Aug 31 17:54:14 2006 UTC

1/* 1/*
2 * static char *rcsid_object_c = 2 * static char *rcsid_object_c =
3 * "$Id: object.C,v 1.4 2006/08/26 23:36:30 root Exp $"; 3 * "$Id: object.C,v 1.10 2006/08/31 17:54:14 root Exp $";
4 */ 4 */
5 5
6/* 6/*
7 CrossFire, A Multiplayer game for X-windows 7 CrossFire, A Multiplayer game for X-windows
8 8
132 /* Note sure why the following is the case - either the object has to 132 /* Note sure why the following is the case - either the object has to
133 * be animated or have a very low speed. Is this an attempted monster 133 * be animated or have a very low speed. Is this an attempted monster
134 * check? 134 * check?
135 */ 135 */
136 if (!QUERY_FLAG(ob1,FLAG_ANIMATE) && FABS((ob1)->speed) > MIN_ACTIVE_SPEED) 136 if (!QUERY_FLAG(ob1,FLAG_ANIMATE) && FABS((ob1)->speed) > MIN_ACTIVE_SPEED)
137 return 0; 137 return 0;
138 138
139 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 139 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
140 * value could not be stored in a sint32 (which unfortunately sometimes is 140 * value could not be stored in a sint32 (which unfortunately sometimes is
141 * used to store nrof). 141 * used to store nrof).
142 */ 142 */
143 if (ob1->nrof+ob2->nrof >= 1UL<<31) 143 if (ob1->nrof+ob2->nrof >= 1UL<<31)
144 return 0; 144 return 0;
145 145
146 /* This is really a spellbook check - really, we should 146 /* This is really a spellbook check - really, we should
147 * check all objects in the inventory. 147 * check all objects in the inventory.
148 */ 148 */
149 if (ob1->inv || ob2->inv) { 149 if (ob1->inv || ob2->inv) {
150 /* if one object has inventory but the other doesn't, not equiv */ 150 /* if one object has inventory but the other doesn't, not equiv */
151 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) return 0; 151 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) return 0;
152 152
153 /* Now check to see if the two inventory objects could merge */ 153 /* Now check to see if the two inventory objects could merge */
154 if (!CAN_MERGE(ob1->inv, ob2->inv)) return 0; 154 if (!CAN_MERGE(ob1->inv, ob2->inv)) return 0;
155 155
156 /* inventory ok - still need to check rest of this object to see 156 /* inventory ok - still need to check rest of this object to see
157 * if it is valid. 157 * if it is valid.
158 */ 158 */
159 } 159 }
160 160
161 /* If the objects have been identified, set the BEEN_APPLIED flag. 161 /* If the objects have been identified, set the BEEN_APPLIED flag.
162 * This is to the comparison of the flags below will be OK. We 162 * This is to the comparison of the flags below will be OK. We
163 * just can't ignore the been applied or identified flags, as they 163 * just can't ignore the been applied or identified flags, as they
164 * are not equal - just if it has been identified, the been_applied 164 * are not equal - just if it has been identified, the been_applied
165 * flags lose any meaning. 165 * flags lose any meaning.
166 */ 166 */
167 if (QUERY_FLAG(ob1, FLAG_IDENTIFIED)) 167 if (QUERY_FLAG(ob1, FLAG_IDENTIFIED))
168 SET_FLAG(ob1, FLAG_BEEN_APPLIED); 168 SET_FLAG(ob1, FLAG_BEEN_APPLIED);
169 169
170 if (QUERY_FLAG(ob2, FLAG_IDENTIFIED)) 170 if (QUERY_FLAG(ob2, FLAG_IDENTIFIED))
171 SET_FLAG(ob2, FLAG_BEEN_APPLIED); 171 SET_FLAG(ob2, FLAG_BEEN_APPLIED);
172 172
173 173
174 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 174 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something
175 * being locked in inventory should prevent merging. 175 * being locked in inventory should prevent merging.
176 * 0x4 in flags3 is CLIENT_SENT 176 * 0x4 in flags3 is CLIENT_SENT
177 */ 177 */
178 if ((ob1->arch != ob2->arch) || 178 if ((ob1->arch != ob2->arch) ||
179 (ob1->flags[0] != ob2->flags[0]) || 179 (ob1->flags[0] != ob2->flags[0]) ||
180 (ob1->flags[1] != ob2->flags[1]) || 180 (ob1->flags[1] != ob2->flags[1]) ||
181 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~ 0x400000)) || 181 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~ 0x400000)) ||
182 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) || 182 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
183 (ob1->name != ob2->name) || 183 (ob1->name != ob2->name) ||
184 (ob1->title != ob2->title) || 184 (ob1->title != ob2->title) ||
185 (ob1->msg != ob2->msg) || 185 (ob1->msg != ob2->msg) ||
186 (ob1->weight != ob2->weight) || 186 (ob1->weight != ob2->weight) ||
187 (memcmp(&ob1->resist, &ob2->resist, sizeof(ob1->resist))!=0) || 187 (memcmp(&ob1->resist, &ob2->resist, sizeof(ob1->resist))!=0) ||
188 (memcmp(&ob1->stats, &ob2->stats, sizeof(ob1->stats))!=0) || 188 (memcmp(&ob1->stats, &ob2->stats, sizeof(ob1->stats))!=0) ||
189 (ob1->attacktype != ob2->attacktype) || 189 (ob1->attacktype != ob2->attacktype) ||
190 (ob1->magic != ob2->magic) || 190 (ob1->magic != ob2->magic) ||
191 (ob1->slaying != ob2->slaying) || 191 (ob1->slaying != ob2->slaying) ||
192 (ob1->skill != ob2->skill) || 192 (ob1->skill != ob2->skill) ||
193 (ob1->value != ob2->value) || 193 (ob1->value != ob2->value) ||
194 (ob1->animation_id != ob2->animation_id) || 194 (ob1->animation_id != ob2->animation_id) ||
195 (ob1->client_type != ob2->client_type) || 195 (ob1->client_type != ob2->client_type) ||
196 (ob1->materialname != ob2->materialname) || 196 (ob1->materialname != ob2->materialname) ||
197 (ob1->lore != ob2->lore) || 197 (ob1->lore != ob2->lore) ||
198 (ob1->subtype != ob2->subtype) || 198 (ob1->subtype != ob2->subtype) ||
199 (ob1->move_type != ob2->move_type) || 199 (ob1->move_type != ob2->move_type) ||
200 (ob1->move_block != ob2->move_block) || 200 (ob1->move_block != ob2->move_block) ||
201 (ob1->move_allow != ob2->move_allow) || 201 (ob1->move_allow != ob2->move_allow) ||
202 (ob1->move_on != ob2->move_on) || 202 (ob1->move_on != ob2->move_on) ||
203 (ob1->move_off != ob2->move_off) || 203 (ob1->move_off != ob2->move_off) ||
204 (ob1->move_slow != ob2->move_slow) || 204 (ob1->move_slow != ob2->move_slow) ||
205 (ob1->move_slow_penalty != ob2->move_slow_penalty) 205 (ob1->move_slow_penalty != ob2->move_slow_penalty)
206 ) 206 )
207 return 0; 207 return 0;
208 208
209 /* Don't merge objects that are applied. With the new 'body' code, 209 /* Don't merge objects that are applied. With the new 'body' code,
210 * it is possible for most any character to have more than one of 210 * it is possible for most any character to have more than one of
211 * some items equipped, and we don't want those to merge. 211 * some items equipped, and we don't want those to merge.
212 */ 212 */
213 if (QUERY_FLAG(ob1, FLAG_APPLIED) || QUERY_FLAG(ob2, FLAG_APPLIED)) 213 if (QUERY_FLAG(ob1, FLAG_APPLIED) || QUERY_FLAG(ob2, FLAG_APPLIED))
214 return 0; 214 return 0;
215 215
216 switch (ob1->type) { 216 switch (ob1->type) {
217 case SCROLL: 217 case SCROLL:
218 if (ob1->level != ob2->level) return 0; 218 if (ob1->level != ob2->level) return 0;
219 break; 219 break;
220 220
221 } 221 }
222 if (ob1->key_values != NULL || ob2->key_values != NULL) { 222 if (ob1->key_values != NULL || ob2->key_values != NULL) {
223 /* At least one of these has key_values. */ 223 /* At least one of these has key_values. */
224 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) { 224 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) {
241signed long sum_weight(object *op) { 241signed long sum_weight(object *op) {
242 signed long sum; 242 signed long sum;
243 object *inv; 243 object *inv;
244 for(sum = 0, inv = op->inv; inv != NULL; inv = inv->below) { 244 for(sum = 0, inv = op->inv; inv != NULL; inv = inv->below) {
245 if (inv->inv) 245 if (inv->inv)
246 sum_weight(inv); 246 sum_weight(inv);
247 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 247 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
248 } 248 }
249 if (op->type == CONTAINER && op->stats.Str) 249 if (op->type == CONTAINER && op->stats.Str)
250 sum = (sum * (100 - op->stats.Str))/100; 250 sum = (sum * (100 - op->stats.Str))/100;
251 if(op->carrying != sum) 251 if(op->carrying != sum)
270 */ 270 */
271 271
272object *is_player_inv (object *op) { 272object *is_player_inv (object *op) {
273 for (;op!=NULL&&op->type!=PLAYER; op=op->env) 273 for (;op!=NULL&&op->type!=PLAYER; op=op->env)
274 if (op->env==op) 274 if (op->env==op)
275 op->env = NULL; 275 op->env = NULL;
276 return op; 276 return op;
277} 277}
278 278
279/* 279/*
280 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 280 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
281 * Some error messages. 281 * Some error messages.
282 * The result of the dump is stored in the static global errmsg array. 282 * The result of the dump is stored in the static global errmsg array.
283 */ 283 */
284 284
285void dump_object2(object *op) { 285void dump_object2(object *op) {
286errmsg[0] = 0;
287return;
288 //TODO//D#d#
289#if 0
286 char *cp; 290 char *cp;
287/* object *tmp;*/ 291/* object *tmp;*/
288 292
289 if(op->arch!=NULL) { 293 if(op->arch!=NULL) {
290 strcat(errmsg,"arch "); 294 strcat(errmsg,"arch ");
291 strcat(errmsg,op->arch->name?op->arch->name:"(null)"); 295 strcat(errmsg,op->arch->name?op->arch->name:"(null)");
292 strcat(errmsg,"\n"); 296 strcat(errmsg,"\n");
293 if((cp=get_ob_diff(op,&empty_archetype->clone))!=NULL) 297 if((cp=get_ob_diff(op,&empty_archetype->clone))!=NULL)
294 strcat(errmsg,cp); 298 strcat(errmsg,cp);
295#if 0 299#if 0
296 /* Don't dump player diffs - they are too long, mostly meaningless, and 300 /* Don't dump player diffs - they are too long, mostly meaningless, and
297 * will overflow the buffer. 301 * will overflow the buffer.
298 * Changed so that we don't dump inventory either. This may 302 * Changed so that we don't dump inventory either. This may
299 * also overflow the buffer. 303 * also overflow the buffer.
315 for (tmp=op->inv; tmp; tmp=tmp->below) 319 for (tmp=op->inv; tmp; tmp=tmp->below)
316 dump_object2(tmp); 320 dump_object2(tmp);
317#endif 321#endif
318 strcat(errmsg,"end\n"); 322 strcat(errmsg,"end\n");
319 } 323 }
324#endif
320} 325}
321 326
322/* 327/*
323 * Dumps an object. Returns output in the static global errmsg array. 328 * Dumps an object. Returns output in the static global errmsg array.
324 */ 329 */
329 return; 334 return;
330 } 335 }
331 errmsg[0]='\0'; 336 errmsg[0]='\0';
332 dump_object2(op); 337 dump_object2(op);
333} 338}
334
335/* GROS - Dumps an object. Return the result into a string */
336/* Note that no checking is done for the validity of the target string, so */
337/* you need to be sure that you allocated enough space for it. */
338void dump_me(object *op, char *outstr)
339{
340 char *cp;
341
342 if(op==NULL)
343 {
344 strcpy(outstr,"[NULL pointer]");
345 return;
346 }
347 outstr[0]='\0';
348
349 if(op->arch!=NULL)
350 {
351 strcat(outstr,"arch ");
352 strcat(outstr,op->arch->name?op->arch->name:"(null)");
353 strcat(outstr,"\n");
354 if((cp=get_ob_diff(op,&empty_archetype->clone))!=NULL)
355 strcat(outstr,cp);
356 strcat(outstr,"end\n");
357 }
358 else
359 {
360 strcat(outstr,"Object ");
361 if (op->name==NULL)
362 strcat(outstr, "(null)");
363 else
364 strcat(outstr,op->name);
365 strcat(outstr,"\n");
366 strcat(outstr,"end\n");
367 }
368}
369
370/*
371 * This is really verbose...Can be triggered by the P key while in DM mode.
372 * All objects are dumped to stderr (or alternate logfile, if in server-mode)
373 */
374 339
375void dump_all_objects(void) { 340void dump_all_objects(void) {
376 object *op; 341 object *op;
377 for(op=objects;op!=NULL;op=op->next) { 342 for(op=objects;op!=NULL;op=op->next) {
378 dump_object(op); 343 dump_object(op);
428void free_all_object_data(void) { 393void free_all_object_data(void) {
429#ifdef MEMORY_DEBUG 394#ifdef MEMORY_DEBUG
430 object *op, *next; 395 object *op, *next;
431 396
432 for (op=free_objects; op!=NULL; ) { 397 for (op=free_objects; op!=NULL; ) {
433 next=op->next; 398 next=op->next;
434 free(op); 399 free(op);
435 nrofallocobjects--; 400 nrofallocobjects--;
436 nroffreeobjects--; 401 nroffreeobjects--;
437 op=next; 402 op=next;
438 } 403 }
439#endif 404#endif
440 LOG(llevDebug,"%d allocated objects, %d free objects, STARMAX=%d\n", 405 LOG(llevDebug,"%d allocated objects, %d free objects, STARMAX=%d\n",
441 nrofallocobjects, nroffreeobjects,STARTMAX); 406 nrofallocobjects, nroffreeobjects,STARTMAX);
442} 407}
443 408
444/* 409/*
445 * Returns the object which this object marks as being the owner. 410 * Returns the object which this object marks as being the owner.
446 * A id-scheme is used to avoid pointing to objects which have been 411 * A id-scheme is used to avoid pointing to objects which have been
452 * anything - once an object is removed, it is basically dead anyways. 417 * anything - once an object is removed, it is basically dead anyways.
453 */ 418 */
454 419
455object *get_owner(object *op) { 420object *get_owner(object *op) {
456 if(op->owner==NULL) 421 if(op->owner==NULL)
457 return NULL; 422 return NULL;
458 423
459 if (!QUERY_FLAG(op->owner,FLAG_FREED) && !QUERY_FLAG(op->owner, FLAG_REMOVED) && 424 if (!QUERY_FLAG(op->owner,FLAG_FREED) && !QUERY_FLAG(op->owner, FLAG_REMOVED) &&
460 op->owner->count==op->ownercount) 425 op->owner->count==op->ownercount)
461 return op->owner; 426 return op->owner;
462 427
463 op->owner=NULL; 428 op->owner=NULL;
464 op->ownercount=0; 429 op->ownercount=0;
465 return NULL; 430 return NULL;
466} 431}
468void clear_owner(object *op) 433void clear_owner(object *op)
469{ 434{
470 if (!op) return; 435 if (!op) return;
471 436
472 if (op->owner && op->ownercount == op->owner->count) 437 if (op->owner && op->ownercount == op->owner->count)
473 op->owner->refcount--; 438 op->owner->refcount--;
474 439
475 op->owner = NULL; 440 op->owner = NULL;
476 op->ownercount = 0; 441 op->ownercount = 0;
477} 442}
478 443
483 * skill and experience objects. 448 * skill and experience objects.
484 */ 449 */
485void set_owner (object *op, object *owner) 450void set_owner (object *op, object *owner)
486{ 451{
487 if(owner==NULL||op==NULL) 452 if(owner==NULL||op==NULL)
488 return; 453 return;
489 454
490 /* next line added to allow objects which own objects */ 455 /* next line added to allow objects which own objects */
491 /* Add a check for ownercounts in here, as I got into an endless loop 456 /* Add a check for ownercounts in here, as I got into an endless loop
492 * with the fireball owning a poison cloud which then owned the 457 * with the fireball owning a poison cloud which then owned the
493 * fireball. I believe that was caused by one of the objects getting 458 * fireball. I believe that was caused by one of the objects getting
494 * freed and then another object replacing it. Since the ownercounts 459 * freed and then another object replacing it. Since the ownercounts
495 * didn't match, this check is valid and I believe that cause is valid. 460 * didn't match, this check is valid and I believe that cause is valid.
496 */ 461 */
497 while (owner->owner && owner!=owner->owner && 462 while (owner->owner && owner!=owner->owner &&
498 owner->ownercount==owner->owner->count) owner=owner->owner; 463 owner->ownercount==owner->owner->count) owner=owner->owner;
499 464
500 /* IF the owner still has an owner, we did not resolve to a final owner. 465 /* IF the owner still has an owner, we did not resolve to a final owner.
501 * so lets not add to that. 466 * so lets not add to that.
502 */ 467 */
503 if (owner->owner) return; 468 if (owner->owner) return;
521 */ 486 */
522void copy_owner (object *op, object *clone) 487void copy_owner (object *op, object *clone)
523{ 488{
524 object *owner = get_owner (clone); 489 object *owner = get_owner (clone);
525 if (owner == NULL) { 490 if (owner == NULL) {
526 /* players don't have owners - they own themselves. Update 491 /* players don't have owners - they own themselves. Update
527 * as appropriate. 492 * as appropriate.
528 */ 493 */
529 if (clone->type == PLAYER) owner=clone; 494 if (clone->type == PLAYER) owner=clone;
530 else return; 495 else return;
531 } 496 }
532 set_owner(op, owner); 497 set_owner(op, owner);
533 498
534} 499}
535 500
546 op->slaying = NULL; 511 op->slaying = NULL;
547 op->skill = NULL; 512 op->skill = NULL;
548 op->msg = NULL; 513 op->msg = NULL;
549 op->materialname = NULL; 514 op->materialname = NULL;
550 op->lore = NULL; 515 op->lore = NULL;
551 op->current_weapon_script = NULL;
552 clear_object(op); 516 clear_object(op);
553} 517}
554 518
555/* Zero the key_values on op, decrementing the shared-string 519/* Zero the key_values on op, decrementing the shared-string
556 * refcounts and freeing the links. 520 * refcounts and freeing the links.
563 527
564 for (i = op->key_values; i != NULL; i = next) { 528 for (i = op->key_values; i != NULL; i = next) {
565 /* Store next *first*. */ 529 /* Store next *first*. */
566 next = i->next; 530 next = i->next;
567 531
568 if (i->key) FREE_AND_CLEAR_STR(i->key); 532 if (i->key) FREE_AND_CLEAR_STR(i->key);
569 if (i->value) FREE_AND_CLEAR_STR(i->value); 533 if (i->value) FREE_AND_CLEAR_STR(i->value);
570 i->next = NULL; 534 i->next = NULL;
571 free(i); 535 free(i);
572 } 536 }
573 537
574 op->key_values = NULL; 538 op->key_values = NULL;
590 * crashes in the old code. Move this to the top - am 554 * crashes in the old code. Move this to the top - am
591 * seeing periodic crashes in this code, and would like to have 555 * seeing periodic crashes in this code, and would like to have
592 * as much info available as possible (eg, object name). 556 * as much info available as possible (eg, object name).
593 */ 557 */
594 for (evt = op->events; evt; evt=evt2) { 558 for (evt = op->events; evt; evt=evt2) {
595 evt2 = evt->next; 559 evt2 = evt->next;
596 560
597 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook); 561 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook);
598 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin); 562 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin);
599 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options); 563 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options);
600 564
643 607
644 op->expmul=1.0; 608 op->expmul=1.0;
645 op->face = blank_face; 609 op->face = blank_face;
646 op->attacked_by_count = (tag_t) -1; 610 op->attacked_by_count = (tag_t) -1;
647 if (settings.casting_time) 611 if (settings.casting_time)
648 op->casting_time = -1; 612 op->casting_time = -1;
649 613
650} 614}
651 615
652/* 616/*
653 * copy object first frees everything allocated by the second object, 617 * copy object first frees everything allocated by the second object,
677 if(op->materialname != NULL) free_string(op->materialname); 641 if(op->materialname != NULL) free_string(op->materialname);
678 if(op->custom_name != NULL) free_string(op->custom_name); 642 if(op->custom_name != NULL) free_string(op->custom_name);
679 643
680 /* Basically, same code as from clear_object() */ 644 /* Basically, same code as from clear_object() */
681 for (evt = op->events; evt; evt=evt2) { 645 for (evt = op->events; evt; evt=evt2) {
682 evt2 = evt->next; 646 evt2 = evt->next;
683 647
684 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook); 648 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook);
685 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin); 649 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin);
686 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options); 650 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options);
687 651
688 free(evt); 652 free(evt);
689 } 653 }
690 op->events = NULL; 654 op->events = NULL;
691 655
692 free_key_values(op); 656 free_key_values(op);
693 657
706 if(op->msg!=NULL) add_refcount(op->msg); 670 if(op->msg!=NULL) add_refcount(op->msg);
707 if(op->custom_name!=NULL) add_refcount(op->custom_name); 671 if(op->custom_name!=NULL) add_refcount(op->custom_name);
708 if (op->materialname != NULL) add_refcount(op->materialname); 672 if (op->materialname != NULL) add_refcount(op->materialname);
709 673
710 if((op2->speed<0) && !editor) 674 if((op2->speed<0) && !editor)
711 op->speed_left=op2->speed_left-RANDOM()%200/100.0; 675 op->speed_left=op2->speed_left-RANDOM()%200/100.0;
712 676
713 /* Copy over event information */ 677 /* Copy over event information */
714 evt2 = NULL; 678 evt2 = NULL;
715 for (evt = op2->events; evt; evt=evt->next) { 679 for (evt = op2->events; evt; evt=evt->next) {
716 evt_new = (event *) malloc(sizeof(event)); 680 evt_new = (event *) malloc(sizeof(event));
717 memcpy(evt_new, evt, sizeof(event)); 681 memcpy(evt_new, evt, sizeof(event));
718 if (evt_new->hook) add_refcount(evt_new->hook); 682 if (evt_new->hook) add_refcount(evt_new->hook);
719 if (evt_new->plugin) add_refcount(evt_new->plugin); 683 if (evt_new->plugin) add_refcount(evt_new->plugin);
720 if (evt_new->options) add_refcount(evt_new->options); 684 if (evt_new->options) add_refcount(evt_new->options);
721 evt_new->next = NULL; 685 evt_new->next = NULL;
722 686
723 /* Try to be a little clever here, and store away the 687 /* Try to be a little clever here, and store away the
724 * last event we copied, so that its simpler to update the 688 * last event we copied, so that its simpler to update the
725 * pointer. 689 * pointer.
726 */ 690 */
727 if (evt2) 691 if (evt2)
728 evt2->next = evt_new; 692 evt2->next = evt_new;
729 else 693 else
730 op->events = evt_new; 694 op->events = evt_new;
731 695
732 evt2 = evt_new; 696 evt2 = evt_new;
733 } 697 }
734 /* Copy over key_values, if any. */ 698 /* Copy over key_values, if any. */
735 if (op2->key_values != NULL) { 699 if (op2->key_values != NULL) {
736 key_value * tail = NULL; 700 key_value * tail = NULL;
737 key_value * i; 701 key_value * i;
738 702
739 op->key_values = NULL; 703 op->key_values = NULL;
740 704
741 for (i = op2->key_values; i != NULL; i = i->next) { 705 for (i = op2->key_values; i != NULL; i = i->next) {
742 key_value * new_link = (key_value *) malloc(sizeof(key_value)); 706 key_value * new_link = (key_value *) malloc(sizeof(key_value));
743 707
744 new_link->next = NULL; 708 new_link->next = NULL;
745 new_link->key = add_refcount(i->key); 709 new_link->key = add_refcount(i->key);
746 if (i->value) 710 if (i->value)
747 new_link->value = add_refcount(i->value); 711 new_link->value = add_refcount(i->value);
748 else 712 else
749 new_link->value = NULL; 713 new_link->value = NULL;
750 714
751 /* Try and be clever here, too. */ 715 /* Try and be clever here, too. */
752 if (op->key_values == NULL) { 716 if (op->key_values == NULL) {
753 op->key_values = new_link; 717 op->key_values = new_link;
754 tail = new_link; 718 tail = new_link;
755 } else { 719 } else {
756 tail->next = new_link; 720 tail->next = new_link;
757 tail = new_link; 721 tail = new_link;
758 } 722 }
759 } 723 }
760 } 724 }
761 725
762 update_ob_speed(op); 726 update_ob_speed(op);
763} 727}
764 728
853 * be called to update the face variable, _and_ how it looks on the map. 817 * be called to update the face variable, _and_ how it looks on the map.
854 */ 818 */
855 819
856void update_turn_face(object *op) { 820void update_turn_face(object *op) {
857 if(!QUERY_FLAG(op,FLAG_IS_TURNABLE)||op->arch==NULL) 821 if(!QUERY_FLAG(op,FLAG_IS_TURNABLE)||op->arch==NULL)
858 return; 822 return;
859 SET_ANIMATION(op, op->direction); 823 SET_ANIMATION(op, op->direction);
860 update_object(op,UP_OBJ_FACE); 824 update_object(op,UP_OBJ_FACE);
861} 825}
862 826
863/* 827/*
872 /* No reason putting the archetypes objects on the speed list, 836 /* No reason putting the archetypes objects on the speed list,
873 * since they never really need to be updated. 837 * since they never really need to be updated.
874 */ 838 */
875 839
876 if (QUERY_FLAG(op, FLAG_FREED) && op->speed) { 840 if (QUERY_FLAG(op, FLAG_FREED) && op->speed) {
877 LOG(llevError,"Object %s is freed but has speed.\n", op->name); 841 LOG(llevError,"Object %s is freed but has speed.\n", op->name);
878#ifdef MANY_CORES 842#ifdef MANY_CORES
879 abort(); 843 abort();
880#else 844#else
881 op->speed = 0; 845 op->speed = 0;
882#endif 846#endif
883 } 847 }
884 if (arch_init) { 848 if (arch_init) {
885 return; 849 return;
886 } 850 }
887 if (FABS(op->speed)>MIN_ACTIVE_SPEED) { 851 if (FABS(op->speed)>MIN_ACTIVE_SPEED) {
888 /* If already on active list, don't do anything */ 852 /* If already on active list, don't do anything */
889 if (op->active_next || op->active_prev || op==active_objects) 853 if (op->active_next || op->active_prev || op==active_objects)
890 return; 854 return;
891 855
892 /* process_events() expects us to insert the object at the beginning 856 /* process_events() expects us to insert the object at the beginning
893 * of the list. */ 857 * of the list. */
894 op->active_next = active_objects; 858 op->active_next = active_objects;
895 if (op->active_next!=NULL) 859 if (op->active_next!=NULL)
896 op->active_next->active_prev = op; 860 op->active_next->active_prev = op;
897 active_objects = op; 861 active_objects = op;
898 } 862 }
899 else { 863 else {
900 /* If not on the active list, nothing needs to be done */ 864 /* If not on the active list, nothing needs to be done */
901 if (!op->active_next && !op->active_prev && op!=active_objects) 865 if (!op->active_next && !op->active_prev && op!=active_objects)
902 return; 866 return;
903 867
904 if (op->active_prev==NULL) { 868 if (op->active_prev==NULL) {
905 active_objects = op->active_next; 869 active_objects = op->active_next;
906 if (op->active_next!=NULL) 870 if (op->active_next!=NULL)
907 op->active_next->active_prev = NULL; 871 op->active_next->active_prev = NULL;
908 } 872 }
909 else { 873 else {
910 op->active_prev->active_next = op->active_next; 874 op->active_prev->active_next = op->active_next;
911 if (op->active_next) 875 if (op->active_next)
912 op->active_next->active_prev = op->active_prev; 876 op->active_next->active_prev = op->active_prev;
913 } 877 }
914 op->active_next = NULL; 878 op->active_next = NULL;
915 op->active_prev = NULL; 879 op->active_prev = NULL;
916 } 880 }
917} 881}
918 882
919/* This function removes object 'op' from the list of active 883/* This function removes object 'op' from the list of active
920 * objects. 884 * objects.
926 */ 890 */
927void remove_from_active_list(object *op) 891void remove_from_active_list(object *op)
928{ 892{
929 /* If not on the active list, nothing needs to be done */ 893 /* If not on the active list, nothing needs to be done */
930 if (!op->active_next && !op->active_prev && op!=active_objects) 894 if (!op->active_next && !op->active_prev && op!=active_objects)
931 return; 895 return;
932 896
933 if (op->active_prev==NULL) { 897 if (op->active_prev==NULL) {
934 active_objects = op->active_next; 898 active_objects = op->active_next;
935 if (op->active_next!=NULL) 899 if (op->active_next!=NULL)
936 op->active_next->active_prev = NULL; 900 op->active_next->active_prev = NULL;
937 } 901 }
938 else { 902 else {
939 op->active_prev->active_next = op->active_next; 903 op->active_prev->active_next = op->active_next;
940 if (op->active_next) 904 if (op->active_next)
941 op->active_next->active_prev = op->active_prev; 905 op->active_next->active_prev = op->active_prev;
942 } 906 }
943 op->active_next = NULL; 907 op->active_next = NULL;
944 op->active_prev = NULL; 908 op->active_prev = NULL;
945} 909}
946 910
971 MoveType move_on, move_off, move_block, move_slow; 935 MoveType move_on, move_off, move_block, move_slow;
972 936
973 if (op == NULL) { 937 if (op == NULL) {
974 /* this should never happen */ 938 /* this should never happen */
975 LOG(llevDebug,"update_object() called for NULL object.\n"); 939 LOG(llevDebug,"update_object() called for NULL object.\n");
976 return; 940 return;
977 } 941 }
978 942
979 if(op->env!=NULL) { 943 if(op->env!=NULL) {
980 /* Animation is currently handled by client, so nothing 944 /* Animation is currently handled by client, so nothing
981 * to do in this case. 945 * to do in this case.
982 */ 946 */
983 return; 947 return;
984 } 948 }
985 949
986 /* If the map is saving, don't do anything as everything is 950 /* If the map is saving, don't do anything as everything is
987 * going to get freed anyways. 951 * going to get freed anyways.
988 */ 952 */
989 if (!op->map || op->map->in_memory == MAP_SAVING) return; 953 if (!op->map || op->map->in_memory == MAP_SAVING) return;
990 954
991 /* make sure the object is within map boundaries */ 955 /* make sure the object is within map boundaries */
992 if (op->x < 0 || op->x >= MAP_WIDTH(op->map) || 956 if (op->x < 0 || op->x >= MAP_WIDTH(op->map) ||
993 op->y < 0 || op->y >= MAP_HEIGHT(op->map)) { 957 op->y < 0 || op->y >= MAP_HEIGHT(op->map)) {
994 LOG(llevError,"update_object() called for object out of map!\n"); 958 LOG(llevError,"update_object() called for object out of map!\n");
995#ifdef MANY_CORES 959#ifdef MANY_CORES
996 abort(); 960 abort();
997#endif 961#endif
998 return; 962 return;
999 } 963 }
1000 964
1001 flags = GET_MAP_FLAGS(op->map, op->x, op->y); 965 flags = GET_MAP_FLAGS(op->map, op->x, op->y);
1002 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NEED_UPDATE); 966 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NEED_UPDATE);
1003 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y); 967 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y);
1016 update_now=1; 980 update_now=1;
1017 981
1018 if (QUERY_FLAG(op, FLAG_ALIVE) && !(flags & P_IS_ALIVE)) 982 if (QUERY_FLAG(op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
1019 update_now=1; 983 update_now=1;
1020 984
1021 if ((move_on | op->move_on) != move_on) update_now=1; 985 if ((move_on | op->move_on) != move_on) update_now=1;
1022 if ((move_off | op->move_off) != move_off) update_now=1; 986 if ((move_off | op->move_off) != move_off) update_now=1;
1023 /* This isn't perfect, but I don't expect a lot of objects to 987 /* This isn't perfect, but I don't expect a lot of objects to
1024 * to have move_allow right now. 988 * to have move_allow right now.
1025 */ 989 */
1026 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 990 if (((move_block | op->move_block) & ~op->move_allow) != move_block)
1027 update_now=1; 991 update_now=1;
1028 if ((move_slow | op->move_slow) != move_slow) update_now=1; 992 if ((move_slow | op->move_slow) != move_slow) update_now=1;
1029 } 993 }
1030 /* if the object is being removed, we can't make intelligent 994 /* if the object is being removed, we can't make intelligent
1031 * decisions, because remove_ob can't really pass the object 995 * decisions, because remove_ob can't really pass the object
1032 * that is being removed. 996 * that is being removed.
1033 */ 997 */
1034 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) { 998 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) {
1035 update_now=1; 999 update_now=1;
1036 } else if (action == UP_OBJ_FACE) { 1000 } else if (action == UP_OBJ_FACE) {
1037 /* Nothing to do for that case */ 1001 /* Nothing to do for that case */
1038 } 1002 }
1039 else { 1003 else {
1040 LOG(llevError,"update_object called with invalid action: %d\n", action); 1004 LOG(llevError,"update_object called with invalid action: %d\n", action);
1041 } 1005 }
1042 1006
1043 if (update_now) { 1007 if (update_now) {
1044 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE); 1008 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
1045 update_position(op->map, op->x, op->y); 1009 update_position(op->map, op->x, op->y);
1046 } 1010 }
1047 1011
1048 if(op->more!=NULL) 1012 if(op->more!=NULL)
1049 update_object(op->more, action); 1013 update_object(op->more, action);
1050} 1014}
1051 1015
1052 1016
1053/* 1017/*
1054 * free_object() frees everything allocated by an object, removes 1018 * free_object() frees everything allocated by an object, removes
1068 object *tmp,*op; 1032 object *tmp,*op;
1069 1033
1070 ob->clear (); 1034 ob->clear ();
1071 1035
1072 if (!QUERY_FLAG(ob,FLAG_REMOVED)) { 1036 if (!QUERY_FLAG(ob,FLAG_REMOVED)) {
1073 LOG(llevDebug,"Free object called with non removed object\n"); 1037 LOG(llevDebug,"Free object called with non removed object\n");
1074 dump_object(ob); 1038 dump_object(ob);
1075#ifdef MANY_CORES 1039#ifdef MANY_CORES
1076 abort(); 1040 abort();
1077#endif 1041#endif
1078 } 1042 }
1079 if(QUERY_FLAG(ob,FLAG_FRIENDLY)) { 1043 if(QUERY_FLAG(ob,FLAG_FRIENDLY)) {
1080 LOG(llevMonster,"Warning: tried to free friendly object.\n"); 1044 LOG(llevMonster,"Warning: tried to free friendly object.\n");
1081 remove_friendly_object(ob); 1045 remove_friendly_object(ob);
1082 } 1046 }
1083 if(QUERY_FLAG(ob,FLAG_FREED)) { 1047 if(QUERY_FLAG(ob,FLAG_FREED)) {
1084 dump_object(ob); 1048 dump_object(ob);
1085 LOG(llevError,"Trying to free freed object.\n%s\n",errmsg); 1049 LOG(llevError,"Trying to free freed object.\n%s\n",errmsg);
1086 return; 1050 return;
1087 } 1051 }
1088 if(ob->more!=NULL) { 1052 if(ob->more!=NULL) {
1089 free_object2(ob->more, free_inventory); 1053 free_object2(ob->more, free_inventory);
1090 ob->more=NULL; 1054 ob->more=NULL;
1091 } 1055 }
1092 if (ob->inv) { 1056 if (ob->inv) {
1093 /* Only if the space blocks everything do we not process - 1057 /* Only if the space blocks everything do we not process -
1094 * if some form of movemnt is allowed, let objects 1058 * if some form of movemnt is allowed, let objects
1095 * drop on that space. 1059 * drop on that space.
1096 */ 1060 */
1097 if (free_inventory || ob->map==NULL || ob->map->in_memory!=MAP_IN_MEMORY || 1061 if (free_inventory || ob->map==NULL || ob->map->in_memory!=MAP_IN_MEMORY ||
1098 (GET_MAP_MOVE_BLOCK(ob->map, ob->x, ob->y) == MOVE_ALL)) 1062 (GET_MAP_MOVE_BLOCK(ob->map, ob->x, ob->y) == MOVE_ALL))
1099 { 1063 {
1100 op=ob->inv; 1064 op=ob->inv;
1101 while(op!=NULL) { 1065 while(op!=NULL) {
1102 tmp=op->below; 1066 tmp=op->below;
1103 remove_ob(op); 1067 remove_ob(op);
1104 free_object2(op, free_inventory); 1068 free_object2(op, free_inventory);
1105 op=tmp; 1069 op=tmp;
1106 } 1070 }
1107 } 1071 }
1108 else { /* Put objects in inventory onto this space */ 1072 else { /* Put objects in inventory onto this space */
1109 op=ob->inv; 1073 op=ob->inv;
1110 while(op!=NULL) { 1074 while(op!=NULL) {
1111 tmp=op->below; 1075 tmp=op->below;
1112 remove_ob(op); 1076 remove_ob(op);
1113 if(QUERY_FLAG(op,FLAG_STARTEQUIP)||QUERY_FLAG(op,FLAG_NO_DROP) || 1077 if(QUERY_FLAG(op,FLAG_STARTEQUIP)||QUERY_FLAG(op,FLAG_NO_DROP) ||
1114 op->type==RUNE || op->type==TRAP || QUERY_FLAG(op,FLAG_IS_A_TEMPLATE)) 1078 op->type==RUNE || op->type==TRAP || QUERY_FLAG(op,FLAG_IS_A_TEMPLATE))
1115 free_object(op); 1079 free_object(op);
1116 else { 1080 else {
1117 op->x=ob->x; 1081 op->x=ob->x;
1118 op->y=ob->y; 1082 op->y=ob->y;
1119 insert_ob_in_map(op,ob->map,NULL,0); /* Insert in same map as the envir */ 1083 insert_ob_in_map(op,ob->map,NULL,0); /* Insert in same map as the envir */
1120 } 1084 }
1121 op=tmp; 1085 op=tmp;
1122 } 1086 }
1123 } 1087 }
1124 } 1088 }
1125 /* Remove object from the active list */ 1089 /* Remove object from the active list */
1126 ob->speed = 0; 1090 ob->speed = 0;
1127 update_ob_speed(ob); 1091 update_ob_speed(ob);
1128 1092
1129 SET_FLAG(ob, FLAG_FREED); 1093 SET_FLAG(ob, FLAG_FREED);
1130 ob->count = 0; 1094 ob->count = 0;
1131 1095
1132 /* Remove this object from the list of used objects */ 1096 /* Remove this object from the list of used objects */
1133 if(ob->prev==NULL) { 1097 if(ob->prev==NULL) {
1134 objects=ob->next; 1098 objects=ob->next;
1135 if(objects!=NULL) 1099 if(objects!=NULL)
1136 objects->prev=NULL; 1100 objects->prev=NULL;
1137 } 1101 }
1138 else { 1102 else {
1139 ob->prev->next=ob->next; 1103 ob->prev->next=ob->next;
1140 if(ob->next!=NULL) 1104 if(ob->next!=NULL)
1141 ob->next->prev=ob->prev; 1105 ob->next->prev=ob->prev;
1142 } 1106 }
1143 1107
1144 if(ob->name!=NULL) FREE_AND_CLEAR_STR(ob->name); 1108 if(ob->name!=NULL) FREE_AND_CLEAR_STR(ob->name);
1145 if(ob->name_pl!=NULL) FREE_AND_CLEAR_STR(ob->name_pl); 1109 if(ob->name_pl!=NULL) FREE_AND_CLEAR_STR(ob->name_pl);
1146 if(ob->title!=NULL) FREE_AND_CLEAR_STR(ob->title); 1110 if(ob->title!=NULL) FREE_AND_CLEAR_STR(ob->title);
1171 1135
1172 /* Now link it with the free_objects list: */ 1136 /* Now link it with the free_objects list: */
1173 ob->prev=NULL; 1137 ob->prev=NULL;
1174 ob->next=free_objects; 1138 ob->next=free_objects;
1175 if(free_objects!=NULL) 1139 if(free_objects!=NULL)
1176 free_objects->prev=ob; 1140 free_objects->prev=ob;
1177 free_objects=ob; 1141 free_objects=ob;
1178 nroffreeobjects++; 1142 nroffreeobjects++;
1179#endif 1143#endif
1180} 1144}
1181 1145
1247 mapstruct *m; 1211 mapstruct *m;
1248 sint16 x,y; 1212 sint16 x,y;
1249 1213
1250 1214
1251 if(QUERY_FLAG(op,FLAG_REMOVED)) { 1215 if(QUERY_FLAG(op,FLAG_REMOVED)) {
1252 dump_object(op); 1216 dump_object(op);
1253 LOG(llevError,"Trying to remove removed object.\n%s\n",errmsg); 1217 LOG(llevError,"Trying to remove removed object.\n%s\n",errmsg);
1254 1218
1255 /* Changed it to always dump core in this case. As has been learned 1219 /* Changed it to always dump core in this case. As has been learned
1256 * in the past, trying to recover from errors almost always 1220 * in the past, trying to recover from errors almost always
1257 * make things worse, and this is a real error here - something 1221 * make things worse, and this is a real error here - something
1258 * that should not happen. 1222 * that should not happen.
1259 * Yes, if this was a mission critical app, trying to do something 1223 * Yes, if this was a mission critical app, trying to do something
1260 * to recover may make sense, but that is because failure of the app 1224 * to recover may make sense, but that is because failure of the app
1261 * may have other disastrous problems. Cf runs out of a script 1225 * may have other disastrous problems. Cf runs out of a script
1262 * so is easily enough restarted without any real problems. 1226 * so is easily enough restarted without any real problems.
1263 * MSW 2001-07-01 1227 * MSW 2001-07-01
1264 */ 1228 */
1265 abort(); 1229 abort();
1266 } 1230 }
1267 if(op->more!=NULL) 1231 if(op->more!=NULL)
1268 remove_ob(op->more); 1232 remove_ob(op->more);
1269 1233
1270 SET_FLAG(op, FLAG_REMOVED); 1234 SET_FLAG(op, FLAG_REMOVED);
1271 1235
1272 /* 1236 /*
1273 * In this case, the object to be removed is in someones 1237 * In this case, the object to be removed is in someones
1274 * inventory. 1238 * inventory.
1275 */ 1239 */
1276 if(op->env!=NULL) { 1240 if(op->env!=NULL) {
1277 if(op->nrof) 1241 if(op->nrof)
1278 sub_weight(op->env, op->weight*op->nrof); 1242 sub_weight(op->env, op->weight*op->nrof);
1279 else 1243 else
1280 sub_weight(op->env, op->weight+op->carrying); 1244 sub_weight(op->env, op->weight+op->carrying);
1281 1245
1282 /* NO_FIX_PLAYER is set when a great many changes are being 1246 /* NO_FIX_PLAYER is set when a great many changes are being
1283 * made to players inventory. If set, avoiding the call 1247 * made to players inventory. If set, avoiding the call
1284 * to save cpu time. 1248 * to save cpu time.
1285 */ 1249 */
1286 if ((otmp=is_player_inv(op->env))!=NULL && otmp->contr && 1250 if ((otmp=is_player_inv(op->env))!=NULL && otmp->contr &&
1287 !QUERY_FLAG(otmp,FLAG_NO_FIX_PLAYER)) 1251 !QUERY_FLAG(otmp,FLAG_NO_FIX_PLAYER))
1288 fix_player(otmp); 1252 fix_player(otmp);
1289 1253
1290 if(op->above!=NULL) 1254 if(op->above!=NULL)
1291 op->above->below=op->below; 1255 op->above->below=op->below;
1292 else 1256 else
1293 op->env->inv=op->below; 1257 op->env->inv=op->below;
1294 1258
1295 if(op->below!=NULL) 1259 if(op->below!=NULL)
1296 op->below->above=op->above; 1260 op->below->above=op->above;
1297 1261
1298 /* we set up values so that it could be inserted into 1262 /* we set up values so that it could be inserted into
1299 * the map, but we don't actually do that - it is up 1263 * the map, but we don't actually do that - it is up
1300 * to the caller to decide what we want to do. 1264 * to the caller to decide what we want to do.
1301 */ 1265 */
1302 op->x=op->env->x,op->y=op->env->y; 1266 op->x=op->env->x,op->y=op->env->y;
1303 op->ox=op->x,op->oy=op->y; 1267 op->ox=op->x,op->oy=op->y;
1304 op->map=op->env->map; 1268 op->map=op->env->map;
1305 op->above=NULL,op->below=NULL; 1269 op->above=NULL,op->below=NULL;
1306 op->env=NULL; 1270 op->env=NULL;
1307 return; 1271 return;
1308 } 1272 }
1309 1273
1310 /* If we get here, we are removing it from a map */ 1274 /* If we get here, we are removing it from a map */
1311 if (op->map == NULL) return; 1275 if (op->map == NULL) return;
1312 1276
1313 x = op->x; 1277 x = op->x;
1314 y = op->y; 1278 y = op->y;
1315 m = get_map_from_coord(op->map, &x, &y); 1279 m = get_map_from_coord(op->map, &x, &y);
1316 1280
1317 if (!m) { 1281 if (!m) {
1318 LOG(llevError,"remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 1282 LOG(llevError,"remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1319 op->map->path, op->x, op->y); 1283 op->map->path, op->x, op->y);
1320 /* in old days, we used to set x and y to 0 and continue. 1284 /* in old days, we used to set x and y to 0 and continue.
1321 * it seems if we get into this case, something is probablye 1285 * it seems if we get into this case, something is probablye
1322 * screwed up and should be fixed. 1286 * screwed up and should be fixed.
1323 */ 1287 */
1324 abort(); 1288 abort();
1325 } 1289 }
1326 if (op->map != m) { 1290 if (op->map != m) {
1327 LOG(llevDebug,"remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 1291 LOG(llevDebug,"remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1328 op->map->path, m->path, op->x, op->y, x, y); 1292 op->map->path, m->path, op->x, op->y, x, y);
1329 } 1293 }
1330 1294
1331 /* Re did the following section of code - it looks like it had 1295 /* Re did the following section of code - it looks like it had
1332 * lots of logic for things we no longer care about 1296 * lots of logic for things we no longer care about
1333 */ 1297 */
1334 1298
1335 /* link the object above us */ 1299 /* link the object above us */
1336 if (op->above) 1300 if (op->above)
1337 op->above->below=op->below; 1301 op->above->below=op->below;
1338 else 1302 else
1339 SET_MAP_TOP(m,x,y,op->below); /* we were top, set new top */ 1303 SET_MAP_TOP(m,x,y,op->below); /* we were top, set new top */
1340 1304
1341 /* Relink the object below us, if there is one */ 1305 /* Relink the object below us, if there is one */
1342 if(op->below) { 1306 if(op->below) {
1343 op->below->above=op->above; 1307 op->below->above=op->above;
1344 } else { 1308 } else {
1345 /* Nothing below, which means we need to relink map object for this space 1309 /* Nothing below, which means we need to relink map object for this space
1346 * use translated coordinates in case some oddness with map tiling is 1310 * use translated coordinates in case some oddness with map tiling is
1347 * evident 1311 * evident
1348 */ 1312 */
1349 if(GET_MAP_OB(m,x,y)!=op) { 1313 if(GET_MAP_OB(m,x,y)!=op) {
1350 dump_object(op); 1314 dump_object(op);
1351 LOG(llevError,"remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1315 LOG(llevError,"remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg);
1352 dump_object(GET_MAP_OB(m,x,y)); 1316 dump_object(GET_MAP_OB(m,x,y));
1353 LOG(llevError,"%s\n",errmsg); 1317 LOG(llevError,"%s\n",errmsg);
1354 } 1318 }
1355 SET_MAP_OB(m,x,y,op->above); /* goes on above it. */ 1319 SET_MAP_OB(m,x,y,op->above); /* goes on above it. */
1356 } 1320 }
1357 op->above=NULL; 1321 op->above=NULL;
1358 op->below=NULL; 1322 op->below=NULL;
1359 1323
1360 if (op->map->in_memory == MAP_SAVING) 1324 if (op->map->in_memory == MAP_SAVING)
1361 return; 1325 return;
1362 1326
1363 tag = op->count; 1327 tag = op->count;
1364 check_walk_off = ! QUERY_FLAG (op, FLAG_NO_APPLY); 1328 check_walk_off = ! QUERY_FLAG (op, FLAG_NO_APPLY);
1365 for(tmp=GET_MAP_OB(m,x,y);tmp!=NULL;tmp=tmp->above) { 1329 for(tmp=GET_MAP_OB(m,x,y);tmp!=NULL;tmp=tmp->above) {
1366 /* No point updating the players look faces if he is the object 1330 /* No point updating the players look faces if he is the object
1367 * being removed. 1331 * being removed.
1368 */ 1332 */
1369 1333
1370 if(tmp->type==PLAYER && tmp!=op) { 1334 if(tmp->type==PLAYER && tmp!=op) {
1371 /* If a container that the player is currently using somehow gets 1335 /* If a container that the player is currently using somehow gets
1372 * removed (most likely destroyed), update the player view 1336 * removed (most likely destroyed), update the player view
1373 * appropriately. 1337 * appropriately.
1374 */ 1338 */
1375 if (tmp->container==op) { 1339 if (tmp->container==op) {
1376 CLEAR_FLAG(op, FLAG_APPLIED); 1340 CLEAR_FLAG(op, FLAG_APPLIED);
1377 tmp->container=NULL; 1341 tmp->container=NULL;
1378 } 1342 }
1379 tmp->contr->socket.update_look=1; 1343 tmp->contr->socket.update_look=1;
1380 } 1344 }
1381 /* See if player moving off should effect something */ 1345 /* See if player moving off should effect something */
1382 if (check_walk_off && ((op->move_type & tmp->move_off) && 1346 if (check_walk_off && ((op->move_type & tmp->move_off) &&
1383 (op->move_type & ~tmp->move_off & ~tmp->move_block)==0)) { 1347 (op->move_type & ~tmp->move_off & ~tmp->move_block)==0)) {
1384 1348
1385 move_apply(tmp, op, NULL); 1349 move_apply(tmp, op, NULL);
1386 if (was_destroyed (op, tag)) { 1350 if (was_destroyed (op, tag)) {
1387 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " 1351 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed "
1388 "leaving object\n", tmp->name, tmp->arch->name); 1352 "leaving object\n", tmp->name, tmp->arch->name);
1389 } 1353 }
1390 } 1354 }
1391 1355
1392 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1356 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1393 1357
1394 if(tmp->above == tmp) 1358 if(tmp->above == tmp)
1395 tmp->above = NULL; 1359 tmp->above = NULL;
1396 last=tmp; 1360 last=tmp;
1397 } 1361 }
1398 /* last == NULL of there are no objects on this space */ 1362 /* last == NULL of there are no objects on this space */
1399 if (last==NULL) { 1363 if (last==NULL) {
1400 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, 1364 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1401 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures 1365 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1402 * those out anyways, and if there are any flags set right now, they won't 1366 * those out anyways, and if there are any flags set right now, they won't
1403 * be correct anyways. 1367 * be correct anyways.
1404 */ 1368 */
1405 SET_MAP_FLAGS(op->map, op->x, op->y, P_NEED_UPDATE); 1369 SET_MAP_FLAGS(op->map, op->x, op->y, P_NEED_UPDATE);
1406 update_position(op->map, op->x, op->y); 1370 update_position(op->map, op->x, op->y);
1407 } 1371 }
1408 else 1372 else
1409 update_object(last, UP_OBJ_REMOVE); 1373 update_object(last, UP_OBJ_REMOVE);
1410 1374
1411 if(QUERY_FLAG(op,FLAG_BLOCKSVIEW)|| (op->glow_radius != 0)) 1375 if(QUERY_FLAG(op,FLAG_BLOCKSVIEW)|| (op->glow_radius != 0))
1412 update_all_los(op->map, op->x, op->y); 1376 update_all_los(op->map, op->x, op->y);
1413 1377
1414} 1378}
1415 1379
1416/* 1380/*
1417 * merge_ob(op,top): 1381 * merge_ob(op,top):
1483{ 1447{
1484 object *tmp, *top, *floor=NULL; 1448 object *tmp, *top, *floor=NULL;
1485 sint16 x,y; 1449 sint16 x,y;
1486 1450
1487 if (QUERY_FLAG (op, FLAG_FREED)) { 1451 if (QUERY_FLAG (op, FLAG_FREED)) {
1488 LOG (llevError, "Trying to insert freed object!\n"); 1452 LOG (llevError, "Trying to insert freed object!\n");
1489 return NULL; 1453 return NULL;
1490 } 1454 }
1491 if(m==NULL) { 1455 if(m==NULL) {
1492 dump_object(op); 1456 dump_object(op);
1493 LOG(llevError,"Trying to insert in null-map!\n%s\n",errmsg); 1457 LOG(llevError,"Trying to insert in null-map!\n%s\n",errmsg);
1494 return op; 1458 return op;
1495 } 1459 }
1496 if(out_of_map(m,op->x,op->y)) { 1460 if(out_of_map(m,op->x,op->y)) {
1497 dump_object(op); 1461 dump_object(op);
1498 LOG(llevError,"Trying to insert object outside the map.\n%s\n", errmsg); 1462 LOG(llevError,"Trying to insert object outside the map.\n%s\n", errmsg);
1499#ifdef MANY_CORES 1463#ifdef MANY_CORES
1500 /* Better to catch this here, as otherwise the next use of this object 1464 /* Better to catch this here, as otherwise the next use of this object
1501 * is likely to cause a crash. Better to find out where it is getting 1465 * is likely to cause a crash. Better to find out where it is getting
1502 * improperly inserted. 1466 * improperly inserted.
1503 */ 1467 */
1504 abort(); 1468 abort();
1505#endif 1469#endif
1506 return op; 1470 return op;
1507 } 1471 }
1508 if(!QUERY_FLAG(op,FLAG_REMOVED)) { 1472 if(!QUERY_FLAG(op,FLAG_REMOVED)) {
1509 dump_object(op); 1473 dump_object(op);
1510 LOG(llevError,"Trying to insert (map) inserted object.\n%s\n", errmsg); 1474 LOG(llevError,"Trying to insert (map) inserted object.\n%s\n", errmsg);
1511 return op; 1475 return op;
1512 } 1476 }
1513 if(op->more!=NULL) { 1477 if(op->more!=NULL) {
1514 /* The part may be on a different map. */ 1478 /* The part may be on a different map. */
1515 1479
1516 object *more = op->more; 1480 object *more = op->more;
1517 1481
1518 /* We really need the caller to normalize coordinates - if 1482 /* We really need the caller to normalize coordinates - if
1519 * we set the map, that doesn't work if the location is within 1483 * we set the map, that doesn't work if the location is within
1520 * a map and this is straddling an edge. So only if coordinate 1484 * a map and this is straddling an edge. So only if coordinate
1521 * is clear wrong do we normalize it. 1485 * is clear wrong do we normalize it.
1522 */ 1486 */
1523 if (OUT_OF_REAL_MAP(more->map, more->x, more->y)) { 1487 if (OUT_OF_REAL_MAP(more->map, more->x, more->y)) {
1524 /* Debugging information so you can see the last coordinates this object had */ 1488 /* Debugging information so you can see the last coordinates this object had */
1525 more->ox = more->x; 1489 more->ox = more->x;
1526 more->oy = more->y; 1490 more->oy = more->y;
1527 more->map = get_map_from_coord(m, &more->x, &more->y); 1491 more->map = get_map_from_coord(m, &more->x, &more->y);
1528 } else if (!more->map) { 1492 } else if (!more->map) {
1529 /* For backwards compatibility - when not dealing with tiled maps, 1493 /* For backwards compatibility - when not dealing with tiled maps,
1530 * more->map should always point to the parent. 1494 * more->map should always point to the parent.
1531 */ 1495 */
1532 more->map = m; 1496 more->map = m;
1533 } 1497 }
1534 1498
1535 if (insert_ob_in_map(more, more->map, originator, flag) == NULL) { 1499 if (insert_ob_in_map(more, more->map, originator, flag) == NULL) {
1536 if ( ! op->head) 1500 if ( ! op->head)
1537 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1501 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1538 return NULL; 1502 return NULL;
1539 } 1503 }
1540 } 1504 }
1541 CLEAR_FLAG(op,FLAG_REMOVED); 1505 CLEAR_FLAG(op,FLAG_REMOVED);
1542 1506
1543 /* Debugging information so you can see the last coordinates this object had */ 1507 /* Debugging information so you can see the last coordinates this object had */
1544 op->ox=op->x; 1508 op->ox=op->x;
1553 y = op->y; 1517 y = op->y;
1554 1518
1555 /* this has to be done after we translate the coordinates. 1519 /* this has to be done after we translate the coordinates.
1556 */ 1520 */
1557 if(op->nrof && !(flag & INS_NO_MERGE)) { 1521 if(op->nrof && !(flag & INS_NO_MERGE)) {
1558 for(tmp=GET_MAP_OB(op->map,x,y);tmp!=NULL;tmp=tmp->above) 1522 for(tmp=GET_MAP_OB(op->map,x,y);tmp!=NULL;tmp=tmp->above)
1559 if (CAN_MERGE(op,tmp)) { 1523 if (CAN_MERGE(op,tmp)) {
1560 op->nrof+=tmp->nrof; 1524 op->nrof+=tmp->nrof;
1561 remove_ob(tmp); 1525 remove_ob(tmp);
1562 free_object(tmp); 1526 free_object(tmp);
1563 } 1527 }
1564 } 1528 }
1565 1529
1566 CLEAR_FLAG(op,FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1530 CLEAR_FLAG(op,FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1567 CLEAR_FLAG(op, FLAG_INV_LOCKED); 1531 CLEAR_FLAG(op, FLAG_INV_LOCKED);
1568 if (!QUERY_FLAG(op, FLAG_ALIVE)) 1532 if (!QUERY_FLAG(op, FLAG_ALIVE))
1569 CLEAR_FLAG(op, FLAG_NO_STEAL); 1533 CLEAR_FLAG(op, FLAG_NO_STEAL);
1570 1534
1571 if (flag & INS_BELOW_ORIGINATOR) { 1535 if (flag & INS_BELOW_ORIGINATOR) {
1572 if (originator->map != op->map || originator->x != op->x || 1536 if (originator->map != op->map || originator->x != op->x ||
1573 originator->y != op->y) { 1537 originator->y != op->y) {
1574 LOG(llevError,"insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1538 LOG(llevError,"insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1575 abort(); 1539 abort();
1576 } 1540 }
1577 op->above = originator; 1541 op->above = originator;
1578 op->below = originator->below; 1542 op->below = originator->below;
1579 if (op->below) op->below->above = op; 1543 if (op->below) op->below->above = op;
1580 else SET_MAP_OB(op->map, op->x, op->y, op); 1544 else SET_MAP_OB(op->map, op->x, op->y, op);
1581 /* since *below* originator, no need to update top */ 1545 /* since *below* originator, no need to update top */
1582 originator->below = op; 1546 originator->below = op;
1583 } else { 1547 } else {
1584 /* If there are other objects, then */ 1548 /* If there are other objects, then */
1585 if((! (flag & INS_MAP_LOAD)) && ((top=GET_MAP_OB(op->map,op->x,op->y))!=NULL)) { 1549 if((! (flag & INS_MAP_LOAD)) && ((top=GET_MAP_OB(op->map,op->x,op->y))!=NULL)) {
1586 object *last=NULL; 1550 object *last=NULL;
1587 /* 1551 /*
1588 * If there are multiple objects on this space, we do some trickier handling. 1552 * If there are multiple objects on this space, we do some trickier handling.
1589 * We've already dealt with merging if appropriate. 1553 * We've already dealt with merging if appropriate.
1590 * Generally, we want to put the new object on top. But if 1554 * Generally, we want to put the new object on top. But if
1591 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1555 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1592 * floor, we want to insert above that and no further. 1556 * floor, we want to insert above that and no further.
1593 * Also, if there are spell objects on this space, we stop processing 1557 * Also, if there are spell objects on this space, we stop processing
1594 * once we get to them. This reduces the need to traverse over all of 1558 * once we get to them. This reduces the need to traverse over all of
1595 * them when adding another one - this saves quite a bit of cpu time 1559 * them when adding another one - this saves quite a bit of cpu time
1596 * when lots of spells are cast in one area. Currently, it is presumed 1560 * when lots of spells are cast in one area. Currently, it is presumed
1597 * that flying non pickable objects are spell objects. 1561 * that flying non pickable objects are spell objects.
1598 */ 1562 */
1599 1563
1600 while (top != NULL) { 1564 while (top != NULL) {
1601 if (QUERY_FLAG(top, FLAG_IS_FLOOR) || 1565 if (QUERY_FLAG(top, FLAG_IS_FLOOR) ||
1602 QUERY_FLAG(top, FLAG_OVERLAY_FLOOR)) floor = top; 1566 QUERY_FLAG(top, FLAG_OVERLAY_FLOOR)) floor = top;
1603 if (QUERY_FLAG(top, FLAG_NO_PICK) 1567 if (QUERY_FLAG(top, FLAG_NO_PICK)
1604 && (top->move_type & (MOVE_FLY_LOW |MOVE_FLY_HIGH)) 1568 && (top->move_type & (MOVE_FLY_LOW |MOVE_FLY_HIGH))
1605 && !QUERY_FLAG(top, FLAG_IS_FLOOR)) 1569 && !QUERY_FLAG(top, FLAG_IS_FLOOR))
1606 { 1570 {
1607 /* We insert above top, so we want this object below this */ 1571 /* We insert above top, so we want this object below this */
1608 top=top->below; 1572 top=top->below;
1609 break; 1573 break;
1610 } 1574 }
1611 last = top; 1575 last = top;
1612 top = top->above; 1576 top = top->above;
1613 } 1577 }
1614 /* Don't want top to be NULL, so set it to the last valid object */ 1578 /* Don't want top to be NULL, so set it to the last valid object */
1615 top = last; 1579 top = last;
1616 1580
1617 /* We let update_position deal with figuring out what the space 1581 /* We let update_position deal with figuring out what the space
1618 * looks like instead of lots of conditions here. 1582 * looks like instead of lots of conditions here.
1619 * makes things faster, and effectively the same result. 1583 * makes things faster, and effectively the same result.
1620 */ 1584 */
1621 1585
1622 /* Have object 'fall below' other objects that block view. 1586 /* Have object 'fall below' other objects that block view.
1623 * Unless those objects are exits, type 66 1587 * Unless those objects are exits, type 66
1624 * If INS_ON_TOP is used, don't do this processing 1588 * If INS_ON_TOP is used, don't do this processing
1625 * Need to find the object that in fact blocks view, otherwise 1589 * Need to find the object that in fact blocks view, otherwise
1626 * stacking is a bit odd. 1590 * stacking is a bit odd.
1627 */ 1591 */
1628 if (!(flag & INS_ON_TOP) && 1592 if (!(flag & INS_ON_TOP) &&
1629 (get_map_flags(op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && 1593 (get_map_flags(op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) &&
1630 (op->face && !op->face->visibility)) { 1594 (op->face && !op->face->visibility)) {
1631 for (last=top; last != floor; last=last->below) 1595 for (last=top; last != floor; last=last->below)
1632 if (QUERY_FLAG(last, FLAG_BLOCKSVIEW)&&(last->type != EXIT)) break; 1596 if (QUERY_FLAG(last, FLAG_BLOCKSVIEW)&&(last->type != EXIT)) break;
1633 /* Check to see if we found the object that blocks view, 1597 /* Check to see if we found the object that blocks view,
1634 * and make sure we have a below pointer for it so that 1598 * and make sure we have a below pointer for it so that
1635 * we can get inserted below this one, which requires we 1599 * we can get inserted below this one, which requires we
1636 * set top to the object below us. 1600 * set top to the object below us.
1637 */ 1601 */
1638 if (last && last->below && last != floor) top=last->below; 1602 if (last && last->below && last != floor) top=last->below;
1639 } 1603 }
1640 } /* If objects on this space */ 1604 } /* If objects on this space */
1641 if (flag & INS_MAP_LOAD) 1605 if (flag & INS_MAP_LOAD)
1642 top = GET_MAP_TOP(op->map,op->x,op->y); 1606 top = GET_MAP_TOP(op->map,op->x,op->y);
1643 if (flag & INS_ABOVE_FLOOR_ONLY) top = floor; 1607 if (flag & INS_ABOVE_FLOOR_ONLY) top = floor;
1644 1608
1645 /* Top is the object that our object (op) is going to get inserted above. 1609 /* Top is the object that our object (op) is going to get inserted above.
1646 */ 1610 */
1647 1611
1648 /* First object on this space */ 1612 /* First object on this space */
1649 if (!top) { 1613 if (!top) {
1650 op->above = GET_MAP_OB(op->map, op->x, op->y); 1614 op->above = GET_MAP_OB(op->map, op->x, op->y);
1651 if (op->above) op->above->below = op; 1615 if (op->above) op->above->below = op;
1652 op->below = NULL; 1616 op->below = NULL;
1653 SET_MAP_OB(op->map, op->x, op->y, op); 1617 SET_MAP_OB(op->map, op->x, op->y, op);
1654 } else { /* get inserted into the stack above top */ 1618 } else { /* get inserted into the stack above top */
1655 op->above = top->above; 1619 op->above = top->above;
1656 if (op->above) op->above->below = op; 1620 if (op->above) op->above->below = op;
1657 op->below = top; 1621 op->below = top;
1658 top->above = op; 1622 top->above = op;
1659 } 1623 }
1660 if (op->above==NULL) 1624 if (op->above==NULL)
1661 SET_MAP_TOP(op->map,op->x, op->y, op); 1625 SET_MAP_TOP(op->map,op->x, op->y, op);
1662 } /* else not INS_BELOW_ORIGINATOR */ 1626 } /* else not INS_BELOW_ORIGINATOR */
1663 1627
1664 if(op->type==PLAYER) 1628 if(op->type==PLAYER)
1665 op->contr->do_los=1; 1629 op->contr->do_los=1;
1666 1630
1667 /* If we have a floor, we know the player, if any, will be above 1631 /* If we have a floor, we know the player, if any, will be above
1668 * it, so save a few ticks and start from there. 1632 * it, so save a few ticks and start from there.
1669 */ 1633 */
1670 if (!(flag & INS_MAP_LOAD)) 1634 if (!(flag & INS_MAP_LOAD))
1671 for(tmp=floor?floor:GET_MAP_OB(op->map,op->x,op->y);tmp!=NULL;tmp=tmp->above) { 1635 for(tmp=floor?floor:GET_MAP_OB(op->map,op->x,op->y);tmp!=NULL;tmp=tmp->above) {
1672 if (tmp->type == PLAYER) 1636 if (tmp->type == PLAYER)
1673 tmp->contr->socket.update_look=1; 1637 tmp->contr->socket.update_look=1;
1674 } 1638 }
1675 1639
1676 /* If this object glows, it may affect lighting conditions that are 1640 /* If this object glows, it may affect lighting conditions that are
1677 * visible to others on this map. But update_all_los is really 1641 * visible to others on this map. But update_all_los is really
1678 * an inefficient way to do this, as it means los for all players 1642 * an inefficient way to do this, as it means los for all players
1681 * this should get redone to only look for players within range, 1645 * this should get redone to only look for players within range,
1682 * or just updating the P_NEED_UPDATE for spaces within this area 1646 * or just updating the P_NEED_UPDATE for spaces within this area
1683 * of effect may be sufficient. 1647 * of effect may be sufficient.
1684 */ 1648 */
1685 if(MAP_DARKNESS(op->map) && (op->glow_radius != 0)) 1649 if(MAP_DARKNESS(op->map) && (op->glow_radius != 0))
1686 update_all_los(op->map, op->x, op->y); 1650 update_all_los(op->map, op->x, op->y);
1687 1651
1688 1652
1689 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1653 /* updates flags (blocked, alive, no magic, etc) for this map space */
1690 update_object(op,UP_OBJ_INSERT); 1654 update_object(op,UP_OBJ_INSERT);
1691 1655
1701 1665
1702 /* if this is not the head or flag has been passed, don't check walk on status */ 1666 /* if this is not the head or flag has been passed, don't check walk on status */
1703 1667
1704 if (!(flag & INS_NO_WALK_ON) && !op->head) { 1668 if (!(flag & INS_NO_WALK_ON) && !op->head) {
1705 if (check_move_on(op, originator)) 1669 if (check_move_on(op, originator))
1706 return NULL; 1670 return NULL;
1707 1671
1708 /* If we are a multi part object, lets work our way through the check 1672 /* If we are a multi part object, lets work our way through the check
1709 * walk on's. 1673 * walk on's.
1710 */ 1674 */
1711 for (tmp=op->more; tmp!=NULL; tmp=tmp->more) 1675 for (tmp=op->more; tmp!=NULL; tmp=tmp->more)
1712 if (check_move_on (tmp, originator)) 1676 if (check_move_on (tmp, originator))
1713 return NULL; 1677 return NULL;
1714 } 1678 }
1715 return op; 1679 return op;
1716} 1680}
1717 1681
1718/* this function inserts an object in the map, but if it 1682/* this function inserts an object in the map, but if it
1724 object *tmp1; 1688 object *tmp1;
1725 1689
1726 /* first search for itself and remove any old instances */ 1690 /* first search for itself and remove any old instances */
1727 1691
1728 for(tmp=GET_MAP_OB(op->map,op->x,op->y); tmp!=NULL; tmp=tmp->above) { 1692 for(tmp=GET_MAP_OB(op->map,op->x,op->y); tmp!=NULL; tmp=tmp->above) {
1729 if(!strcmp(tmp->arch->name,arch_string)) /* same archetype */ { 1693 if(!strcmp(tmp->arch->name,arch_string)) /* same archetype */ {
1730 remove_ob(tmp); 1694 remove_ob(tmp);
1731 free_object(tmp); 1695 free_object(tmp);
1732 } 1696 }
1733 } 1697 }
1734 1698
1735 tmp1=arch_to_object(find_archetype(arch_string)); 1699 tmp1=arch_to_object(find_archetype(arch_string));
1736 1700
1737 1701
1750object *get_split_ob(object *orig_ob, uint32 nr) { 1714object *get_split_ob(object *orig_ob, uint32 nr) {
1751 object *newob; 1715 object *newob;
1752 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1716 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1753 1717
1754 if(orig_ob->nrof<nr) { 1718 if(orig_ob->nrof<nr) {
1755 sprintf(errmsg,"There are only %d %ss.", 1719 sprintf(errmsg,"There are only %d %ss.",
1756 orig_ob->nrof?orig_ob->nrof:1, orig_ob->name); 1720 orig_ob->nrof?orig_ob->nrof:1, orig_ob->name);
1757 return NULL; 1721 return NULL;
1758 } 1722 }
1759 newob = object_create_clone(orig_ob); 1723 newob = object_create_clone(orig_ob);
1760 if((orig_ob->nrof-=nr)<1) { 1724 if((orig_ob->nrof-=nr)<1) {
1761 if ( ! is_removed) 1725 if ( ! is_removed)
1762 remove_ob(orig_ob); 1726 remove_ob(orig_ob);
1763 free_object2(orig_ob, 1); 1727 free_object2(orig_ob, 1);
1764 } 1728 }
1765 else if ( ! is_removed) { 1729 else if ( ! is_removed) {
1766 if(orig_ob->env!=NULL) 1730 if(orig_ob->env!=NULL)
1767 sub_weight (orig_ob->env,orig_ob->weight*nr); 1731 sub_weight (orig_ob->env,orig_ob->weight*nr);
1768 if (orig_ob->env == NULL && orig_ob->map->in_memory!=MAP_IN_MEMORY) { 1732 if (orig_ob->env == NULL && orig_ob->map->in_memory!=MAP_IN_MEMORY) {
1769 strcpy(errmsg, "Tried to split object whose map is not in memory."); 1733 strcpy(errmsg, "Tried to split object whose map is not in memory.");
1770 LOG(llevDebug, 1734 LOG(llevDebug,
1771 "Error, Tried to split object whose map is not in memory.\n"); 1735 "Error, Tried to split object whose map is not in memory.\n");
1772 return NULL; 1736 return NULL;
1773 } 1737 }
1774 } 1738 }
1775 newob->nrof=nr; 1739 newob->nrof=nr;
1776 1740
1777 return newob; 1741 return newob;
1778} 1742}
1800 { 1764 {
1801 op->nrof -= i; 1765 op->nrof -= i;
1802 } 1766 }
1803 else if (op->env != NULL) 1767 else if (op->env != NULL)
1804 { 1768 {
1805 /* is this object in the players inventory, or sub container 1769 /* is this object in the players inventory, or sub container
1806 * therein? 1770 * therein?
1807 */ 1771 */
1808 tmp = is_player_inv (op->env); 1772 tmp = is_player_inv (op->env);
1809 /* nope. Is this a container the player has opened? 1773 /* nope. Is this a container the player has opened?
1810 * If so, set tmp to that player. 1774 * If so, set tmp to that player.
1811 * IMO, searching through all the players will mostly 1775 * IMO, searching through all the players will mostly
1812 * likely be quicker than following op->env to the map, 1776 * likely be quicker than following op->env to the map,
1813 * and then searching the map for a player. 1777 * and then searching the map for a player.
1814 */ 1778 */
1815 if (!tmp) { 1779 if (!tmp) {
1816 for (pl=first_player; pl; pl=pl->next) 1780 for (pl=first_player; pl; pl=pl->next)
1817 if (pl->ob->container == op->env) break; 1781 if (pl->ob->container == op->env) break;
1818 if (pl) tmp=pl->ob; 1782 if (pl) tmp=pl->ob;
1819 else tmp=NULL; 1783 else tmp=NULL;
1820 } 1784 }
1821 1785
1822 if (i < op->nrof) { 1786 if (i < op->nrof) {
1823 sub_weight (op->env, op->weight * i); 1787 sub_weight (op->env, op->weight * i);
1824 op->nrof -= i; 1788 op->nrof -= i;
1825 if (tmp) { 1789 if (tmp) {
1833 } 1797 }
1834 } 1798 }
1835 } 1799 }
1836 else 1800 else
1837 { 1801 {
1838 object *above = op->above; 1802 object *above = op->above;
1839 1803
1840 if (i < op->nrof) { 1804 if (i < op->nrof) {
1841 op->nrof -= i; 1805 op->nrof -= i;
1842 } else { 1806 } else {
1843 remove_ob (op); 1807 remove_ob (op);
1844 op->nrof = 0; 1808 op->nrof = 0;
1845 } 1809 }
1846 /* Since we just removed op, op->above is null */ 1810 /* Since we just removed op, op->above is null */
1847 for (tmp = above; tmp != NULL; tmp = tmp->above) 1811 for (tmp = above; tmp != NULL; tmp = tmp->above)
1848 if (tmp->type == PLAYER) { 1812 if (tmp->type == PLAYER) {
1849 if (op->nrof) 1813 if (op->nrof)
1850 esrv_send_item(tmp, op); 1814 esrv_send_item(tmp, op);
1851 else 1815 else
1903 LOG(llevError,"Trying to put object in NULL.\n%s\n", errmsg); 1867 LOG(llevError,"Trying to put object in NULL.\n%s\n", errmsg);
1904 return op; 1868 return op;
1905 } 1869 }
1906 if (where->head) { 1870 if (where->head) {
1907 LOG(llevDebug, 1871 LOG(llevDebug,
1908 "Warning: Tried to insert object wrong part of multipart object.\n"); 1872 "Warning: Tried to insert object wrong part of multipart object.\n");
1909 where = where->head; 1873 where = where->head;
1910 } 1874 }
1911 if (op->more) { 1875 if (op->more) {
1912 LOG(llevError, "Tried to insert multipart object %s (%d)\n", 1876 LOG(llevError, "Tried to insert multipart object %s (%d)\n",
1913 op->name, op->count); 1877 op->name, op->count);
1916 CLEAR_FLAG(op, FLAG_OBJ_ORIGINAL); 1880 CLEAR_FLAG(op, FLAG_OBJ_ORIGINAL);
1917 CLEAR_FLAG(op, FLAG_REMOVED); 1881 CLEAR_FLAG(op, FLAG_REMOVED);
1918 if(op->nrof) { 1882 if(op->nrof) {
1919 for(tmp=where->inv;tmp!=NULL;tmp=tmp->below) 1883 for(tmp=where->inv;tmp!=NULL;tmp=tmp->below)
1920 if ( CAN_MERGE(tmp,op) ) { 1884 if ( CAN_MERGE(tmp,op) ) {
1921 /* return the original object and remove inserted object 1885 /* return the original object and remove inserted object
1922 (client needs the original object) */ 1886 (client needs the original object) */
1923 tmp->nrof += op->nrof; 1887 tmp->nrof += op->nrof;
1924 /* Weight handling gets pretty funky. Since we are adding to 1888 /* Weight handling gets pretty funky. Since we are adding to
1925 * tmp->nrof, we need to increase the weight. 1889 * tmp->nrof, we need to increase the weight.
1926 */ 1890 */
1927 add_weight (where, op->weight*op->nrof); 1891 add_weight (where, op->weight*op->nrof);
1928 SET_FLAG(op, FLAG_REMOVED); 1892 SET_FLAG(op, FLAG_REMOVED);
1929 free_object(op); /* free the inserted object */ 1893 free_object(op); /* free the inserted object */
1930 op = tmp; 1894 op = tmp;
1931 remove_ob (op); /* and fix old object's links */ 1895 remove_ob (op); /* and fix old object's links */
1932 CLEAR_FLAG(op, FLAG_REMOVED); 1896 CLEAR_FLAG(op, FLAG_REMOVED);
1933 break; 1897 break;
1934 } 1898 }
1935 1899
1936 /* I assume combined objects have no inventory 1900 /* I assume combined objects have no inventory
1937 * We add the weight - this object could have just been removed 1901 * We add the weight - this object could have just been removed
1938 * (if it was possible to merge). calling remove_ob will subtract 1902 * (if it was possible to merge). calling remove_ob will subtract
1959 /* reset the light list and los of the players on the map */ 1923 /* reset the light list and los of the players on the map */
1960 if((op->glow_radius!=0)&&where->map) 1924 if((op->glow_radius!=0)&&where->map)
1961 { 1925 {
1962#ifdef DEBUG_LIGHTS 1926#ifdef DEBUG_LIGHTS
1963 LOG(llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", 1927 LOG(llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n",
1964 op->name); 1928 op->name);
1965#endif /* DEBUG_LIGHTS */ 1929#endif /* DEBUG_LIGHTS */
1966 if (MAP_DARKNESS(where->map)) update_all_los(where->map, where->x, where->y); 1930 if (MAP_DARKNESS(where->map)) update_all_los(where->map, where->x, where->y);
1967 } 1931 }
1968 1932
1969 /* Client has no idea of ordering so lets not bother ordering it here. 1933 /* Client has no idea of ordering so lets not bother ordering it here.
2007 mapstruct *m=op->map; 1971 mapstruct *m=op->map;
2008 int x=op->x, y=op->y; 1972 int x=op->x, y=op->y;
2009 MoveType move_on, move_slow, move_block; 1973 MoveType move_on, move_slow, move_block;
2010 1974
2011 if(QUERY_FLAG(op,FLAG_NO_APPLY)) 1975 if(QUERY_FLAG(op,FLAG_NO_APPLY))
2012 return 0; 1976 return 0;
2013 1977
2014 tag = op->count; 1978 tag = op->count;
2015 1979
2016 move_on = GET_MAP_MOVE_ON(op->map, op->x, op->y); 1980 move_on = GET_MAP_MOVE_ON(op->map, op->x, op->y);
2017 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y); 1981 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y);
2021 * no need to do checking below. have to make sure move_type 1985 * no need to do checking below. have to make sure move_type
2022 * is set, as lots of objects don't have it set - we treat that 1986 * is set, as lots of objects don't have it set - we treat that
2023 * as walking. 1987 * as walking.
2024 */ 1988 */
2025 if (op->move_type && !(op->move_type & move_on) && !(op->move_type & move_slow)) 1989 if (op->move_type && !(op->move_type & move_on) && !(op->move_type & move_slow))
2026 return 0; 1990 return 0;
2027 1991
2028 /* This is basically inverse logic of that below - basically, 1992 /* This is basically inverse logic of that below - basically,
2029 * if the object can avoid the move on or slow move, they do so, 1993 * if the object can avoid the move on or slow move, they do so,
2030 * but can't do it if the alternate movement they are using is 1994 * but can't do it if the alternate movement they are using is
2031 * blocked. Logic on this seems confusing, but does seem correct. 1995 * blocked. Logic on this seems confusing, but does seem correct.
2032 */ 1996 */
2033 if ((op->move_type & ~move_on & ~move_block) != 0 && 1997 if ((op->move_type & ~move_on & ~move_block) != 0 &&
2034 (op->move_type & ~move_slow & ~move_block) != 0) return 0; 1998 (op->move_type & ~move_slow & ~move_block) != 0) return 0;
2035 1999
2036 /* The objects have to be checked from top to bottom. 2000 /* The objects have to be checked from top to bottom.
2037 * Hence, we first go to the top: 2001 * Hence, we first go to the top:
2038 */ 2002 */
2039 2003
2040 for (tmp=GET_MAP_OB(op->map, op->x, op->y); tmp!=NULL && 2004 for (tmp=GET_MAP_OB(op->map, op->x, op->y); tmp!=NULL &&
2041 tmp->above!=NULL; tmp=tmp->above) { 2005 tmp->above!=NULL; tmp=tmp->above) {
2042 /* Trim the search when we find the first other spell effect 2006 /* Trim the search when we find the first other spell effect
2043 * this helps performance so that if a space has 50 spell objects, 2007 * this helps performance so that if a space has 50 spell objects,
2044 * we don't need to check all of them. 2008 * we don't need to check all of them.
2045 */ 2009 */
2046 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG(tmp, FLAG_NO_PICK)) break; 2010 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG(tmp, FLAG_NO_PICK)) break;
2047 } 2011 }
2048 for(;tmp!=NULL; tmp=tmp->below) { 2012 for(;tmp!=NULL; tmp=tmp->below) {
2049 if (tmp == op) continue; /* Can't apply yourself */ 2013 if (tmp == op) continue; /* Can't apply yourself */
2050 2014
2051 /* Check to see if one of the movement types should be slowed down. 2015 /* Check to see if one of the movement types should be slowed down.
2052 * Second check makes sure that the movement types not being slowed 2016 * Second check makes sure that the movement types not being slowed
2053 * (~slow_move) is not blocked on this space - just because the 2017 * (~slow_move) is not blocked on this space - just because the
2054 * space doesn't slow down swimming (for example), if you can't actually 2018 * space doesn't slow down swimming (for example), if you can't actually
2055 * swim on that space, can't use it to avoid the penalty. 2019 * swim on that space, can't use it to avoid the penalty.
2056 */ 2020 */
2057 if (!QUERY_FLAG(op, FLAG_WIZPASS)) { 2021 if (!QUERY_FLAG(op, FLAG_WIZPASS)) {
2058 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 2022 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2059 ((op->move_type & tmp->move_slow) && 2023 ((op->move_type & tmp->move_slow) &&
2060 (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) { 2024 (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) {
2061 2025
2062 float diff; 2026 float diff;
2063 2027
2064 diff = tmp->move_slow_penalty*FABS(op->speed); 2028 diff = tmp->move_slow_penalty*FABS(op->speed);
2065 if (op->type == PLAYER) { 2029 if (op->type == PLAYER) {
2066 if ((QUERY_FLAG(tmp, FLAG_IS_HILLY) && find_skill_by_number(op, SK_CLIMBING)) || 2030 if ((QUERY_FLAG(tmp, FLAG_IS_HILLY) && find_skill_by_number(op, SK_CLIMBING)) ||
2067 (QUERY_FLAG(tmp, FLAG_IS_WOODED) && find_skill_by_number(op, SK_WOODSMAN))) { 2031 (QUERY_FLAG(tmp, FLAG_IS_WOODED) && find_skill_by_number(op, SK_WOODSMAN))) {
2068 diff /= 4.0; 2032 diff /= 4.0;
2069 } 2033 }
2070 } 2034 }
2071 op->speed_left -= diff; 2035 op->speed_left -= diff;
2072 } 2036 }
2073 } 2037 }
2074 2038
2075 /* Basically same logic as above, except now for actual apply. */ 2039 /* Basically same logic as above, except now for actual apply. */
2076 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 2040 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2077 ((op->move_type & tmp->move_on) && 2041 ((op->move_type & tmp->move_on) &&
2078 (op->move_type & ~tmp->move_on & ~tmp->move_block)==0)) { 2042 (op->move_type & ~tmp->move_on & ~tmp->move_block)==0)) {
2079 2043
2080 move_apply(tmp, op, originator); 2044 move_apply(tmp, op, originator);
2081 if (was_destroyed (op, tag)) 2045 if (was_destroyed (op, tag))
2082 return 1; 2046 return 1;
2083 2047
2084 /* what the person/creature stepped onto has moved the object 2048 /* what the person/creature stepped onto has moved the object
2085 * someplace new. Don't process any further - if we did, 2049 * someplace new. Don't process any further - if we did,
2086 * have a feeling strange problems would result. 2050 * have a feeling strange problems would result.
2087 */ 2051 */
2088 if (op->map != m || op->x != x || op->y != y) return 0; 2052 if (op->map != m || op->x != x || op->y != y) return 0;
2089 } 2053 }
2090 } 2054 }
2091 return 0; 2055 return 0;
2092} 2056}
2093 2057
2094/* 2058/*
2158 2122
2159object *present_in_ob_by_name(int type, const char *str, const object *op) { 2123object *present_in_ob_by_name(int type, const char *str, const object *op) {
2160 object *tmp; 2124 object *tmp;
2161 2125
2162 for(tmp=op->inv; tmp!=NULL; tmp=tmp->below) { 2126 for(tmp=op->inv; tmp!=NULL; tmp=tmp->below) {
2163 if ((type==-1 || tmp->type==type) && (!strcmp(str, tmp->name))) 2127 if ((type==-1 || tmp->type==type) && (!strcmp(str, tmp->name)))
2164 return tmp; 2128 return tmp;
2165 } 2129 }
2166 return NULL; 2130 return NULL;
2167} 2131}
2168 2132
2169/* 2133/*
2239int find_free_spot(const object *ob, mapstruct *m,int x,int y,int start,int stop) { 2203int find_free_spot(const object *ob, mapstruct *m,int x,int y,int start,int stop) {
2240 int i,index=0, flag; 2204 int i,index=0, flag;
2241 static int altern[SIZEOFFREE]; 2205 static int altern[SIZEOFFREE];
2242 2206
2243 for(i=start;i<stop;i++) { 2207 for(i=start;i<stop;i++) {
2244 flag = ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i]); 2208 flag = ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i]);
2245 if(!flag) 2209 if(!flag)
2246 altern[index++]=i; 2210 altern[index++]=i;
2247 2211
2248 /* Basically, if we find a wall on a space, we cut down the search size. 2212 /* Basically, if we find a wall on a space, we cut down the search size.
2249 * In this way, we won't return spaces that are on another side of a wall. 2213 * In this way, we won't return spaces that are on another side of a wall.
2250 * This mostly work, but it cuts down the search size in all directions - 2214 * This mostly work, but it cuts down the search size in all directions -
2251 * if the space being examined only has a wall to the north and empty 2215 * if the space being examined only has a wall to the north and empty
2252 * spaces in all the other directions, this will reduce the search space 2216 * spaces in all the other directions, this will reduce the search space
2253 * to only the spaces immediately surrounding the target area, and 2217 * to only the spaces immediately surrounding the target area, and
2254 * won't look 2 spaces south of the target space. 2218 * won't look 2 spaces south of the target space.
2255 */ 2219 */
2256 else if ((flag & AB_NO_PASS) && maxfree[i]<stop) 2220 else if ((flag & AB_NO_PASS) && maxfree[i]<stop)
2257 stop=maxfree[i]; 2221 stop=maxfree[i];
2258 } 2222 }
2259 if(!index) return -1; 2223 if(!index) return -1;
2260 return altern[RANDOM()%index]; 2224 return altern[RANDOM()%index];
2261} 2225}
2262 2226
2268 */ 2232 */
2269 2233
2270int find_first_free_spot(const object *ob, mapstruct *m,int x,int y) { 2234int find_first_free_spot(const object *ob, mapstruct *m,int x,int y) {
2271 int i; 2235 int i;
2272 for(i=0;i<SIZEOFFREE;i++) { 2236 for(i=0;i<SIZEOFFREE;i++) {
2273 if(!ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i])) 2237 if(!ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i]))
2274 return i; 2238 return i;
2275 } 2239 }
2276 return -1; 2240 return -1;
2277} 2241}
2278 2242
2279/* 2243/*
2285 int i, j, tmp, len; 2249 int i, j, tmp, len;
2286 2250
2287 len = end-begin; 2251 len = end-begin;
2288 for(i = begin; i < end; i++) 2252 for(i = begin; i < end; i++)
2289 { 2253 {
2290 j = begin+RANDOM()%len; 2254 j = begin+RANDOM()%len;
2291 2255
2292 tmp = arr[i]; 2256 tmp = arr[i];
2293 arr[i] = arr[j]; 2257 arr[i] = arr[j];
2294 arr[j] = tmp; 2258 arr[j] = tmp;
2295 } 2259 }
2296} 2260}
2297 2261
2298/* new function to make monster searching more efficient, and effective! 2262/* new function to make monster searching more efficient, and effective!
2299 * This basically returns a randomized array (in the passed pointer) of 2263 * This basically returns a randomized array (in the passed pointer) of
2306{ 2270{
2307 int i; 2271 int i;
2308 2272
2309 for(i = 0; i < SIZEOFFREE; i++) 2273 for(i = 0; i < SIZEOFFREE; i++)
2310 { 2274 {
2311 search_arr[i] = i; 2275 search_arr[i] = i;
2312 } 2276 }
2313 2277
2314 permute(search_arr, 1, SIZEOFFREE1+1); 2278 permute(search_arr, 1, SIZEOFFREE1+1);
2315 permute(search_arr, SIZEOFFREE1+1, SIZEOFFREE2+1); 2279 permute(search_arr, SIZEOFFREE1+1, SIZEOFFREE2+1);
2316 permute(search_arr, SIZEOFFREE2+1, SIZEOFFREE); 2280 permute(search_arr, SIZEOFFREE2+1, SIZEOFFREE);
2335 object *tmp; 2299 object *tmp;
2336 mapstruct *mp; 2300 mapstruct *mp;
2337 MoveType blocked, move_type; 2301 MoveType blocked, move_type;
2338 2302
2339 if (exclude && exclude->head) { 2303 if (exclude && exclude->head) {
2340 exclude = exclude->head; 2304 exclude = exclude->head;
2341 move_type = exclude->move_type; 2305 move_type = exclude->move_type;
2342 } else { 2306 } else {
2343 /* If we don't have anything, presume it can use all movement types. */ 2307 /* If we don't have anything, presume it can use all movement types. */
2344 move_type=MOVE_ALL; 2308 move_type=MOVE_ALL;
2345 } 2309 }
2346 2310
2347 for(i=1;i<max;i++) { 2311 for(i=1;i<max;i++) {
2348 mp = m; 2312 mp = m;
2349 nx = x + freearr_x[i]; 2313 nx = x + freearr_x[i];
2350 ny = y + freearr_y[i]; 2314 ny = y + freearr_y[i];
2351 2315
2352 mflags = get_map_flags(m, &mp, nx, ny, &nx, &ny); 2316 mflags = get_map_flags(m, &mp, nx, ny, &nx, &ny);
2353 if (mflags & P_OUT_OF_MAP) { 2317 if (mflags & P_OUT_OF_MAP) {
2354 max = maxfree[i]; 2318 max = maxfree[i];
2355 } else { 2319 } else {
2356 blocked = GET_MAP_MOVE_BLOCK(mp, nx, ny); 2320 blocked = GET_MAP_MOVE_BLOCK(mp, nx, ny);
2357 2321
2358 if ((move_type & blocked) == move_type) { 2322 if ((move_type & blocked) == move_type) {
2359 max=maxfree[i]; 2323 max=maxfree[i];
2360 } else if (mflags & P_IS_ALIVE) { 2324 } else if (mflags & P_IS_ALIVE) {
2361 for (tmp=GET_MAP_OB(mp,nx,ny); tmp!= NULL; tmp=tmp->above) { 2325 for (tmp=GET_MAP_OB(mp,nx,ny); tmp!= NULL; tmp=tmp->above) {
2362 if ((QUERY_FLAG(tmp,FLAG_MONSTER) || tmp->type==PLAYER) && 2326 if ((QUERY_FLAG(tmp,FLAG_MONSTER) || tmp->type==PLAYER) &&
2363 (tmp != exclude ||(tmp->head && tmp->head != exclude))) { 2327 (tmp != exclude ||(tmp->head && tmp->head != exclude))) {
2364 break; 2328 break;
2365 } 2329 }
2366 } 2330 }
2367 if(tmp) { 2331 if(tmp) {
2368 return freedir[i]; 2332 return freedir[i];
2369 } 2333 }
2370 } 2334 }
2371 } 2335 }
2372 } 2336 }
2373 return 0; 2337 return 0;
2374} 2338}
2375 2339
2376/* 2340/*
2540 if (mflags & (P_OUT_OF_MAP | P_BLOCKSVIEW)) return 0; 2504 if (mflags & (P_OUT_OF_MAP | P_BLOCKSVIEW)) return 0;
2541 2505
2542 /* yes, can see. */ 2506 /* yes, can see. */
2543 if(dir < 9) return 1; 2507 if(dir < 9) return 1;
2544 return can_see_monsterP(m, x, y, reduction_dir[dir][0]) | 2508 return can_see_monsterP(m, x, y, reduction_dir[dir][0]) |
2545 can_see_monsterP(m,x,y, reduction_dir[dir][1]) | 2509 can_see_monsterP(m,x,y, reduction_dir[dir][1]) |
2546 can_see_monsterP(m,x,y, reduction_dir[dir][2]); 2510 can_see_monsterP(m,x,y, reduction_dir[dir][2]);
2547} 2511}
2548 2512
2549 2513
2550 2514
2551/* 2515/*
2552 * can_pick(picker, item): finds out if an object is possible to be 2516 * can_pick(picker, item): finds out if an object is possible to be
2553 * picked up by the picker. Returnes 1 if it can be 2517 * picked up by the picker. Returnes 1 if it can be
2554 * picked up, otherwise 0. 2518 * picked up, otherwise 0.
2555 * 2519 *
2560 */ 2524 */
2561 2525
2562int can_pick(const object *who, const object *item) { 2526int can_pick(const object *who, const object *item) {
2563 return /*QUERY_FLAG(who,FLAG_WIZ)||*/ 2527 return /*QUERY_FLAG(who,FLAG_WIZ)||*/
2564 (item->weight>0&&!QUERY_FLAG(item,FLAG_NO_PICK)&& 2528 (item->weight>0&&!QUERY_FLAG(item,FLAG_NO_PICK)&&
2565 !QUERY_FLAG(item,FLAG_ALIVE)&&!item->invisible && 2529 !QUERY_FLAG(item,FLAG_ALIVE)&&!item->invisible &&
2566 (who->type==PLAYER||item->weight<who->weight/3)); 2530 (who->type==PLAYER||item->weight<who->weight/3));
2567} 2531}
2568 2532
2569 2533
2570/* 2534/*
2595 prev->more = tmp; 2559 prev->more = tmp;
2596 prev = tmp; 2560 prev = tmp;
2597 } 2561 }
2598 /*** copy inventory ***/ 2562 /*** copy inventory ***/
2599 for(item = src->inv; item; item = item->below) { 2563 for(item = src->inv; item; item = item->below) {
2600 (void) insert_ob_in_ob(object_create_clone(item),dst); 2564 (void) insert_ob_in_ob(object_create_clone(item),dst);
2601 } 2565 }
2602 2566
2603 return dst; 2567 return dst;
2604} 2568}
2605 2569
2619/* Also remember that multiparts objects are not supported for now. */ 2583/* Also remember that multiparts objects are not supported for now. */
2620 2584
2621object* load_object_str(const char *obstr) 2585object* load_object_str(const char *obstr)
2622{ 2586{
2623 object *op; 2587 object *op;
2624 FILE *tempfile;
2625 char filename[MAX_BUF]; 2588 char filename[MAX_BUF];
2626 sprintf(filename,"%s/cfloadobstr2044",settings.tmpdir); 2589 sprintf(filename,"%s/cfloadobstr2044",settings.tmpdir);
2590
2627 tempfile=fopen(filename,"w"); 2591 FILE *tempfile=fopen(filename,"w");
2628 if (tempfile == NULL) 2592 if (tempfile == NULL)
2629 { 2593 {
2630 LOG(llevError,"Error - Unable to access load object temp file\n"); 2594 LOG(llevError,"Error - Unable to access load object temp file\n");
2631 return NULL; 2595 return NULL;
2632 }; 2596 };
2633 fprintf(tempfile,obstr); 2597 fprintf(tempfile,obstr);
2634 fclose(tempfile); 2598 fclose(tempfile);
2635 2599
2636 op=get_object(); 2600 op=get_object();
2637 2601
2638 tempfile=fopen(filename,"r"); 2602 object_thawer thawer (filename);
2639 if (tempfile == NULL) 2603 if (thawer)
2640 {
2641 LOG(llevError,"Error - Unable to read object temp file\n");
2642 return NULL;
2643 };
2644 load_object(tempfile,op,LO_NEWFILE,0); 2604 load_object(thawer,op,LO_NEWFILE,0);
2645 LOG(llevDebug," load str completed, object=%s\n",op->name); 2605 LOG(llevDebug," load str completed, object=%s\n",op->name);
2646 CLEAR_FLAG(op,FLAG_REMOVED); 2606 CLEAR_FLAG(op,FLAG_REMOVED);
2647 fclose(tempfile); 2607
2648 return op; 2608 return op;
2649} 2609}
2650 2610
2651/* This returns the first object in who's inventory that 2611/* This returns the first object in who's inventory that
2652 * has the same type and subtype match. 2612 * has the same type and subtype match.
2655object *find_obj_by_type_subtype(const object *who, int type, int subtype) 2615object *find_obj_by_type_subtype(const object *who, int type, int subtype)
2656{ 2616{
2657 object *tmp; 2617 object *tmp;
2658 2618
2659 for (tmp=who->inv; tmp; tmp=tmp->below) 2619 for (tmp=who->inv; tmp; tmp=tmp->below)
2660 if (tmp->type == type && tmp->subtype == subtype) return tmp; 2620 if (tmp->type == type && tmp->subtype == subtype) return tmp;
2661 2621
2662 return NULL; 2622 return NULL;
2663} 2623}
2664 2624
2665/* If ob has a field named key, return the link from the list, 2625/* If ob has a field named key, return the link from the list,
2726 */ 2686 */
2727int set_ob_key_value_s(object * op, const char * canonical_key, const char * value, int add_key) { 2687int set_ob_key_value_s(object * op, const char * canonical_key, const char * value, int add_key) {
2728 key_value * field = NULL, *last=NULL; 2688 key_value * field = NULL, *last=NULL;
2729 2689
2730 for (field=op->key_values; field != NULL; field=field->next) { 2690 for (field=op->key_values; field != NULL; field=field->next) {
2731 if (field->key != canonical_key) { 2691 if (field->key != canonical_key) {
2732 last = field; 2692 last = field;
2733 continue; 2693 continue;
2734 } 2694 }
2735 2695
2736 if (field->value) FREE_AND_CLEAR_STR(field->value); 2696 if (field->value) FREE_AND_CLEAR_STR(field->value);
2737 if (value) 2697 if (value)
2738 field->value = add_string(value); 2698 field->value = add_string(value);
2739 else { 2699 else {
2740 /* Basically, if the archetype has this key set, 2700 /* Basically, if the archetype has this key set,
2741 * we need to store the null value so when we save 2701 * we need to store the null value so when we save
2742 * it, we save the empty value so that when we load, 2702 * it, we save the empty value so that when we load,
2743 * we get this value back again. 2703 * we get this value back again.
2744 */ 2704 */
2745 if (get_ob_key_link(&op->arch->clone, canonical_key)) 2705 if (get_ob_key_link(&op->arch->clone, canonical_key))
2746 field->value = NULL; 2706 field->value = NULL;
2747 else { 2707 else {
2748 /* Delete this link */ 2708 /* Delete this link */
2749 if (field->key) FREE_AND_CLEAR_STR(field->key); 2709 if (field->key) FREE_AND_CLEAR_STR(field->key);
2750 if (field->value) FREE_AND_CLEAR_STR(field->value); 2710 if (field->value) FREE_AND_CLEAR_STR(field->value);
2751 if (last) last->next = field->next; 2711 if (last) last->next = field->next;
2752 else op->key_values = field->next; 2712 else op->key_values = field->next;
2753 free(field); 2713 free(field);
2754 } 2714 }
2755 } 2715 }
2756 return TRUE; 2716 return TRUE;
2757 } 2717 }
2758 /* IF we get here, key doesn't exist */ 2718 /* IF we get here, key doesn't exist */
2759 2719
2760 /* No field, we'll have to add it. */ 2720 /* No field, we'll have to add it. */

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines