ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.42 by root, Thu Sep 14 01:19:47 2006 UTC vs.
Revision 1.120 by root, Sun Jan 21 21:28:27 2007 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
4 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
7 7 *
8 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
11 (at your option) any later version. 11 * (at your option) any later version.
12 12 *
13 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details. 16 * GNU General Public License for more details.
17 17 *
18 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 21 *
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 27 variable. */
28#include <global.h> 28#include <global.h>
… …
31#include <sys/uio.h> 31#include <sys/uio.h>
32#include <object.h> 32#include <object.h>
33#include <funcpoint.h> 33#include <funcpoint.h>
34#include <loader.h> 34#include <loader.h>
35 35
36#include <bitset>
37
36int nrofallocobjects = 0; 38int nrofallocobjects = 0;
37static UUID uuid; 39static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
39 41
40object *objects; /* Pointer to the list of used objects */ 42objectvec objects;
41object *active_objects; /* List of active objects that need to be processed */ 43activevec actives;
42 44
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 47};
46short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
106 _exit (1); 108 _exit (1);
107 } 109 }
108 110
109 uuid.seq = uid; 111 uuid.seq = uid;
110 write_uuid (); 112 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 114 fclose (fp);
113} 115}
114 116
115UUID 117UUID
116gen_uuid () 118gen_uuid ()
… …
141 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
143 */ 145 */
144 146
145 /* For each field in wants, */ 147 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 149 {
148 key_value *has_field; 150 key_value *has_field;
149 151
150 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
… …
185 * 187 *
186 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
189 * 191 *
190 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
191 * 193 *
192 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
193 * check weight 195 * check weight
194 */ 196 */
195
196bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
197{ 198{
198 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
200 return 0; 205 return 0;
201 206
202 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 210 * used to store nrof).
208 */ 211 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 223
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 226
224 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 252 return 0;
256 253
257 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 255 * check all objects in the inventory.
259 */ 256 */
… …
262 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 261 return 0;
265 262
266 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 265 return 0;
269 266
270 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 268 * if it is valid.
272 */ 269 */
… …
281 278
282 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
284 * check? 281 * check?
285 */ 282 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 284 return 0;
288 285
289 switch (ob1->type) 286 switch (ob1->type)
290 { 287 {
291 case SCROLL: 288 case SCROLL:
… …
356 op = op->env; 353 op = op->env;
357 return op; 354 return op;
358} 355}
359 356
360/* 357/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 359 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
379 */ 361 */
380 362
381void 363char *
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 364dump_object (object *op)
437{ 365{
438 if (op == NULL) 366 if (!op)
439 { 367 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 368
447void 369 object_freezer freezer;
448dump_all_objects (void) 370 save_object (freezer, op, 1);
449{ 371 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 372}
458 373
459/* 374/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 376 * multi-object 1 which is closest to the second object.
… …
477} 392}
478 393
479/* 394/*
480 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
481 */ 396 */
482
483object * 397object *
484find_object (tag_t i) 398find_object (tag_t i)
485{ 399{
486 object *op; 400 for_all_objects (op)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 401 if (op->count == i)
490 break;
491 return op; 402 return op;
403
404 return 0;
492} 405}
493 406
494/* 407/*
495 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
497 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
498 */ 411 */
499
500object * 412object *
501find_object_name (const char *str) 413find_object_name (const char *str)
502{ 414{
503 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
504 object *op; 416 object *op;
505 417
506 for (op = objects; op != NULL; op = op->next) 418 for_all_objects (op)
507 if (op->name == str_) 419 if (op->name == str_)
508 break; 420 break;
509 421
510 return op; 422 return op;
511} 423}
512 424
513void 425void
514free_all_object_data () 426free_all_object_data ()
515{ 427{
516 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 428 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
517}
518
519/*
520 * Returns the object which this object marks as being the owner.
521 * A id-scheme is used to avoid pointing to objects which have been
522 * freed and are now reused. If this is detected, the owner is
523 * set to NULL, and NULL is returned.
524 * Changed 2004-02-12 - if the player is setting at the play again
525 * prompt, he is removed, and we don't want to treat him as an owner of
526 * anything, so check removed flag. I don't expect that this should break
527 * anything - once an object is removed, it is basically dead anyways.
528 */
529object *
530object::get_owner ()
531{
532 if (!owner
533 || QUERY_FLAG (owner, FLAG_FREED)
534 || QUERY_FLAG (owner, FLAG_REMOVED))
535 owner = 0;
536
537 return owner;
538} 429}
539 430
540/* 431/*
541 * Sets the owner and sets the skill and exp pointers to owner's current 432 * Sets the owner and sets the skill and exp pointers to owner's current
542 * skill and experience objects. 433 * skill and experience objects.
… …
575 } 466 }
576 467
577 op->key_values = 0; 468 op->key_values = 0;
578} 469}
579 470
580void object::clear ()
581{
582 attachable_base::clear ();
583
584 free_key_values (this);
585
586 owner = 0;
587 name = 0;
588 name_pl = 0;
589 title = 0;
590 race = 0;
591 slaying = 0;
592 skill = 0;
593 msg = 0;
594 lore = 0;
595 custom_name = 0;
596 materialname = 0;
597 contr = 0;
598 below = 0;
599 above = 0;
600 inv = 0;
601 container = 0;
602 env = 0;
603 more = 0;
604 head = 0;
605 map = 0;
606 active_next = 0;
607 active_prev = 0;
608
609 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
610
611 SET_FLAG (this, FLAG_REMOVED);
612
613 /* What is not cleared is next, prev, and count */
614
615 expmul = 1.0;
616 face = blank_face;
617 attacked_by_count = -1;
618
619 if (settings.casting_time)
620 casting_time = -1;
621}
622
623void object::clone (object *destination)
624{
625 *(object_copy *)destination = *this;
626 *(object_pod *)destination = *this;
627
628 if (self || cb)
629 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
630}
631
632/* 471/*
633 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
634 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
635 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
636 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
637 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
638 * will point at garbage. 477 * will point at garbage.
639 */ 478 */
640void 479void
641copy_object (object *op2, object *op) 480object::copy_to (object *dst)
642{ 481{
643 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
644 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
645 484
646 op2->clone (op); 485 *(object_copy *)dst = *this;
647 486
648 if (is_freed) 487 if (is_freed)
649 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
650 if (is_removed) 490 if (is_removed)
651 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
652 492
653 if (op2->speed < 0) 493 if (speed < 0)
654 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
655 495
656 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
657 if (op2->key_values) 497 if (key_values)
658 { 498 {
659 key_value *tail = 0; 499 key_value *tail = 0;
660 key_value *i; 500 key_value *i;
661 501
662 op->key_values = 0; 502 dst->key_values = 0;
663 503
664 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
665 { 505 {
666 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
667 507
668 new_link->next = 0; 508 new_link->next = 0;
669 new_link->key = i->key; 509 new_link->key = i->key;
670 new_link->value = i->value; 510 new_link->value = i->value;
671 511
672 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
673 if (!op->key_values) 513 if (!dst->key_values)
674 { 514 {
675 op->key_values = new_link; 515 dst->key_values = new_link;
676 tail = new_link; 516 tail = new_link;
677 } 517 }
678 else 518 else
679 { 519 {
680 tail->next = new_link; 520 tail->next = new_link;
681 tail = new_link; 521 tail = new_link;
682 } 522 }
683 } 523 }
684 } 524 }
685 525
686 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
687} 535}
688 536
689/* 537/*
690 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
691 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
692 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
693 */ 541 */
694
695void 542void
696update_turn_face (object *op) 543update_turn_face (object *op)
697{ 544{
698 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
699 return; 546 return;
547
700 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
701 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
702} 550}
703 551
704/* 552/*
705 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
706 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
707 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
708 */ 556 */
709void 557void
710update_ob_speed (object *op) 558object::set_speed (float speed)
711{ 559{
712 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
713
714 /* No reason putting the archetypes objects on the speed list,
715 * since they never really need to be updated.
716 */
717
718 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
719 { 561 {
720 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
721#ifdef MANY_CORES
722 abort ();
723#else
724 op->speed = 0; 563 speed = 0;
725#endif
726 }
727
728 if (arch_init)
729 return;
730
731 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
732 { 564 }
733 /* If already on active list, don't do anything */
734 if (op->active_next || op->active_prev || op == active_objects)
735 return;
736 565
737 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
738 * of the list. */
739 op->active_next = active_objects;
740 567
741 if (op->active_next != NULL) 568 if (has_active_speed ())
742 op->active_next->active_prev = op; 569 activate ();
743
744 active_objects = op;
745 }
746 else 570 else
747 { 571 deactivate ();
748 /* If not on the active list, nothing needs to be done */
749 if (!op->active_next && !op->active_prev && op != active_objects)
750 return;
751
752 if (op->active_prev == NULL)
753 {
754 active_objects = op->active_next;
755
756 if (op->active_next != NULL)
757 op->active_next->active_prev = NULL;
758 }
759 else
760 {
761 op->active_prev->active_next = op->active_next;
762
763 if (op->active_next)
764 op->active_next->active_prev = op->active_prev;
765 }
766
767 op->active_next = NULL;
768 op->active_prev = NULL;
769 }
770} 572}
771 573
772/* This function removes object 'op' from the list of active
773 * objects.
774 * This should only be used for style maps or other such
775 * reference maps where you don't want an object that isn't
776 * in play chewing up cpu time getting processed.
777 * The reverse of this is to call update_ob_speed, which
778 * will do the right thing based on the speed of the object.
779 */
780void
781remove_from_active_list (object *op)
782{
783 /* If not on the active list, nothing needs to be done */
784 if (!op->active_next && !op->active_prev && op != active_objects)
785 return;
786
787 if (op->active_prev == NULL)
788 {
789 active_objects = op->active_next;
790 if (op->active_next != NULL)
791 op->active_next->active_prev = NULL;
792 }
793 else
794 {
795 op->active_prev->active_next = op->active_next;
796 if (op->active_next)
797 op->active_next->active_prev = op->active_prev;
798 }
799 op->active_next = NULL;
800 op->active_prev = NULL;
801}
802
803/* 574/*
804 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
805 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
806 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
807 * invisible object, etc...) 578 * invisible object, etc...)
808 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
809 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
810 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
811 * 582 *
812 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
813 * For example, if the only thing that has changed is the face (due to
814 * an animation), we don't need to call update_position until that actually
815 * comes into view of a player. OTOH, many other things, like addition/removal
816 * of walls or living creatures may need us to update the flags now.
817 * current action are: 584 * current action are:
818 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
819 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
820 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
821 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
822 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
823 */ 590 */
824
825void 591void
826update_object (object *op, int action) 592update_object (object *op, int action)
827{ 593{
828 int update_now = 0, flags;
829 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
830 595
831 if (op == NULL) 596 if (op == NULL)
832 { 597 {
833 /* this should never happen */ 598 /* this should never happen */
834 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
835 return; 600 return;
836 } 601 }
837 602
838 if (op->env != NULL) 603 if (op->env)
839 { 604 {
840 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
841 * to do in this case. 606 * to do in this case.
842 */ 607 */
843 return; 608 return;
… …
848 */ 613 */
849 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
850 return; 615 return;
851 616
852 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
853 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
854 { 619 {
855 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
856#ifdef MANY_CORES 621#ifdef MANY_CORES
857 abort (); 622 abort ();
858#endif 623#endif
859 return; 624 return;
860 } 625 }
861 626
862 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
863 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
864 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
865 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
866 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
867 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
868 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
869 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
870 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
871 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
872 update_now = 1;
873
874 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
875 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
876 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
877 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
878 update_now = 1;
879
880 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
881 update_now = 1;
882
883 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
884 update_now = 1;
885
886 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
887 update_now = 1;
888
889 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
890 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
891
892 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
893 * to have move_allow right now. 644 * to have move_allow right now.
894 */ 645 */
895 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
896 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
897 648 m.flags_ = 0;
898 if ((move_slow | op->move_slow) != move_slow)
899 update_now = 1;
900 } 649 }
901 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
902 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
903 * that is being removed. 652 * that is being removed.
904 */ 653 */
905 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
906 update_now = 1; 655 m.flags_ = 0;
907 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
908 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
909 else 658 else
910 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
911 660
912 if (update_now)
913 {
914 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
915 update_position (op->map, op->x, op->y);
916 }
917
918 if (op->more != NULL) 661 if (op->more)
919 update_object (op->more, action); 662 update_object (op->more, action);
920}
921
922static unordered_vector<object *> mortals;
923
924void object::free_mortals ()
925{
926 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
927 if ((*i)->refcnt)
928 ++i; // further delay freeing
929 else
930 {
931 delete *i;
932 mortals.erase (i);
933 }
934
935 static int lastmortals = 0;//D
936
937 if (mortals.size() != lastmortals)//D
938 {
939 lastmortals = mortals.size ();//D
940 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
941 }
942} 663}
943 664
944object::object () 665object::object ()
945{ 666{
946 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
947 668
948 expmul = 1.0; 669 expmul = 1.0;
949 face = blank_face; 670 face = blank_face;
950 attacked_by_count = -1;
951} 671}
952 672
953object::~object () 673object::~object ()
954{ 674{
675 if (index)
676 unlink ();
677
955 free_key_values (this); 678 free_key_values (this);
956} 679}
957 680
681static int object_count;
682
958void object::link () 683void object::link ()
959{ 684{
960 count = ++ob_count; 685 assert (!index);//D
961 uuid = gen_uuid (); 686 uuid = gen_uuid ();
687 count = ++object_count;
962 688
963 prev = 0; 689 refcnt_inc ();
964 next = objects; 690 objects.insert (this);
965
966 if (objects)
967 objects->prev = this;
968
969 objects = this;
970} 691}
971 692
972void object::unlink () 693void object::unlink ()
973{ 694{
974 //count = 0;//D 695 assert (index);//D
975 if (!prev && !next) return;//D 696 objects.erase (this);
697 refcnt_dec ();
698}
976 699
977 if (this == objects) 700void
978 objects = next; 701object::activate ()
702{
703 /* If already on active list, don't do anything */
704 if (active)
705 return;
979 706
980 /* Remove this object from the list of used objects */ 707 if (has_active_speed ())
981 if (prev) prev->next = next; 708 actives.insert (this);
982 if (next) next->prev = prev; 709}
983 710
984 prev = 0; 711void
985 next = 0; 712object::activate_recursive ()
713{
714 activate ();
715
716 for (object *op = inv; op; op = op->below)
717 op->activate_recursive ();
718}
719
720/* This function removes object 'op' from the list of active
721 * objects.
722 * This should only be used for style maps or other such
723 * reference maps where you don't want an object that isn't
724 * in play chewing up cpu time getting processed.
725 * The reverse of this is to call update_ob_speed, which
726 * will do the right thing based on the speed of the object.
727 */
728void
729object::deactivate ()
730{
731 /* If not on the active list, nothing needs to be done */
732 if (!active)
733 return;
734
735 actives.erase (this);
736}
737
738void
739object::deactivate_recursive ()
740{
741 for (object *op = inv; op; op = op->below)
742 op->deactivate_recursive ();
743
744 deactivate ();
745}
746
747void
748object::set_flag_inv (int flag, int value)
749{
750 for (object *op = inv; op; op = op->below)
751 {
752 op->flag [flag] = value;
753 op->set_flag_inv (flag, value);
754 }
755}
756
757/*
758 * Remove and free all objects in the inventory of the given object.
759 * object.c ?
760 */
761void
762object::destroy_inv (bool drop_to_ground)
763{
764 // need to check first, because the checks below might segfault
765 // as we might be on an invalid mapspace and crossfire code
766 // is too buggy to ensure that the inventory is empty.
767 // corollary: if you create arrows etc. with stuff in tis inventory,
768 // cf will crash below with off-map x and y
769 if (!inv)
770 return;
771
772 /* Only if the space blocks everything do we not process -
773 * if some form of movement is allowed, let objects
774 * drop on that space.
775 */
776 if (!drop_to_ground
777 || !map
778 || map->in_memory != MAP_IN_MEMORY
779 || ms ().move_block == MOVE_ALL)
780 {
781 while (inv)
782 {
783 inv->destroy_inv (drop_to_ground);
784 inv->destroy ();
785 }
786 }
787 else
788 { /* Put objects in inventory onto this space */
789 while (inv)
790 {
791 object *op = inv;
792
793 if (op->flag [FLAG_STARTEQUIP]
794 || op->flag [FLAG_NO_DROP]
795 || op->type == RUNE
796 || op->type == TRAP
797 || op->flag [FLAG_IS_A_TEMPLATE]
798 || op->flag [FLAG_DESTROY_ON_DEATH])
799 op->destroy ();
800 else
801 map->insert (op, x, y);
802 }
803 }
986} 804}
987 805
988object *object::create () 806object *object::create ()
989{ 807{
990 object *op = new object; 808 object *op = new object;
991 op->link (); 809 op->link ();
992 return op; 810 return op;
993} 811}
994 812
995/* 813void
996 * free_object() frees everything allocated by an object, removes 814object::do_destroy ()
997 * it from the list of used objects, and puts it on the list of
998 * free objects. The IS_FREED() flag is set in the object.
999 * The object must have been removed by remove_ob() first for
1000 * this function to succeed.
1001 *
1002 * If free_inventory is set, free inventory as well. Else drop items in
1003 * inventory to the ground.
1004 */
1005void object::free (bool free_inventory)
1006{ 815{
1007 if (QUERY_FLAG (this, FLAG_FREED)) 816 attachable::do_destroy ();
817
818 if (flag [FLAG_IS_LINKED])
819 remove_button_link (this);
820
821 if (flag [FLAG_FRIENDLY])
822 remove_friendly_object (this);
823
824 if (!flag [FLAG_REMOVED])
825 remove ();
826
827 destroy_inv (true);
828
829 deactivate ();
830 unlink ();
831
832 flag [FLAG_FREED] = 1;
833
834 // hack to ensure that freed objects still have a valid map
835 {
836 static maptile *freed_map; // freed objects are moved here to avoid crashes
837
838 if (!freed_map)
839 {
840 freed_map = new maptile;
841
842 freed_map->name = "/internal/freed_objects_map";
843 freed_map->width = 3;
844 freed_map->height = 3;
845
846 freed_map->alloc ();
847 freed_map->in_memory = MAP_IN_MEMORY;
848 }
849
850 map = freed_map;
851 x = 1;
852 y = 1;
853 }
854
855 head = 0;
856
857 if (more)
858 {
859 more->destroy ();
860 more = 0;
861 }
862
863 // clear those pointers that likely might have circular references to us
864 owner = 0;
865 enemy = 0;
866 attacked_by = 0;
867}
868
869void
870object::destroy (bool destroy_inventory)
871{
872 if (destroyed ())
1008 return; 873 return;
1009 874
1010 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 875 if (destroy_inventory)
1011 remove_friendly_object (this); 876 destroy_inv (false);
1012 877
1013 if (!QUERY_FLAG (this, FLAG_REMOVED)) 878 attachable::destroy ();
1014 remove_ob (this);
1015
1016 SET_FLAG (this, FLAG_FREED);
1017
1018 if (more)
1019 {
1020 more->free (free_inventory);
1021 more = 0;
1022 }
1023
1024 if (inv)
1025 {
1026 /* Only if the space blocks everything do we not process -
1027 * if some form of movement is allowed, let objects
1028 * drop on that space.
1029 */
1030 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1031 {
1032 object *op = inv;
1033
1034 while (op)
1035 {
1036 object *tmp = op->below;
1037 op->free (free_inventory);
1038 op = tmp;
1039 }
1040 }
1041 else
1042 { /* Put objects in inventory onto this space */
1043 object *op = inv;
1044
1045 while (op)
1046 {
1047 object *tmp = op->below;
1048
1049 remove_ob (op);
1050
1051 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1052 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1053 free_object (op);
1054 else
1055 {
1056 op->x = x;
1057 op->y = y;
1058 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1059 }
1060
1061 op = tmp;
1062 }
1063 }
1064 }
1065
1066 owner = 0;
1067
1068 /* Remove object from the active list */
1069 speed = 0;
1070 update_ob_speed (this);
1071
1072 unlink ();
1073
1074 mortals.push_back (this);
1075} 879}
1076 880
1077/* 881/*
1078 * sub_weight() recursively (outwards) subtracts a number from the 882 * sub_weight() recursively (outwards) subtracts a number from the
1079 * weight of an object (and what is carried by it's environment(s)). 883 * weight of an object (and what is carried by it's environment(s)).
1080 */ 884 */
1081
1082void 885void
1083sub_weight (object *op, signed long weight) 886sub_weight (object *op, signed long weight)
1084{ 887{
1085 while (op != NULL) 888 while (op != NULL)
1086 { 889 {
1087 if (op->type == CONTAINER) 890 if (op->type == CONTAINER)
1088 {
1089 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 891 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1090 } 892
1091 op->carrying -= weight; 893 op->carrying -= weight;
1092 op = op->env; 894 op = op->env;
1093 } 895 }
1094} 896}
1095 897
1096/* remove_ob(op): 898/* op->remove ():
1097 * This function removes the object op from the linked list of objects 899 * This function removes the object op from the linked list of objects
1098 * which it is currently tied to. When this function is done, the 900 * which it is currently tied to. When this function is done, the
1099 * object will have no environment. If the object previously had an 901 * object will have no environment. If the object previously had an
1100 * environment, the x and y coordinates will be updated to 902 * environment, the x and y coordinates will be updated to
1101 * the previous environment. 903 * the previous environment.
1102 * Beware: This function is called from the editor as well! 904 * Beware: This function is called from the editor as well!
1103 */ 905 */
1104
1105void 906void
1106remove_ob (object *op) 907object::remove_slow ()
1107{ 908{
909 object *tmp, *last = 0;
1108 object * 910 object *otmp;
1109 tmp, *
1110 last = NULL;
1111 object *
1112 otmp;
1113 911
1114 tag_t
1115 tag;
1116 int
1117 check_walk_off;
1118 mapstruct *
1119 m;
1120
1121 sint16
1122 x,
1123 y;
1124
1125 if (QUERY_FLAG (op, FLAG_REMOVED)) 912 if (QUERY_FLAG (this, FLAG_REMOVED))
1126 return; 913 return;
1127 914
1128 SET_FLAG (op, FLAG_REMOVED); 915 SET_FLAG (this, FLAG_REMOVED);
916 INVOKE_OBJECT (REMOVE, this);
1129 917
1130 if (op->more != NULL) 918 if (more)
1131 remove_ob (op->more); 919 more->remove ();
1132 920
1133 /* 921 /*
1134 * In this case, the object to be removed is in someones 922 * In this case, the object to be removed is in someones
1135 * inventory. 923 * inventory.
1136 */ 924 */
1137 if (op->env != NULL) 925 if (env)
1138 { 926 {
1139 if (op->nrof) 927 if (nrof)
1140 sub_weight (op->env, op->weight * op->nrof); 928 sub_weight (env, weight * nrof);
1141 else 929 else
1142 sub_weight (op->env, op->weight + op->carrying); 930 sub_weight (env, weight + carrying);
1143 931
1144 /* NO_FIX_PLAYER is set when a great many changes are being 932 /* NO_FIX_PLAYER is set when a great many changes are being
1145 * made to players inventory. If set, avoiding the call 933 * made to players inventory. If set, avoiding the call
1146 * to save cpu time. 934 * to save cpu time.
1147 */ 935 */
1148 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 936 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1149 fix_player (otmp); 937 otmp->update_stats ();
1150 938
1151 if (op->above != NULL) 939 if (above)
1152 op->above->below = op->below; 940 above->below = below;
1153 else 941 else
1154 op->env->inv = op->below; 942 env->inv = below;
1155 943
1156 if (op->below != NULL) 944 if (below)
1157 op->below->above = op->above; 945 below->above = above;
1158 946
1159 /* we set up values so that it could be inserted into 947 /* we set up values so that it could be inserted into
1160 * the map, but we don't actually do that - it is up 948 * the map, but we don't actually do that - it is up
1161 * to the caller to decide what we want to do. 949 * to the caller to decide what we want to do.
1162 */ 950 */
1163 op->x = op->env->x, op->y = op->env->y; 951 x = env->x, y = env->y;
1164 op->map = op->env->map; 952 map = env->map;
1165 op->above = NULL, op->below = NULL; 953 above = 0, below = 0;
1166 op->env = NULL; 954 env = 0;
1167 } 955 }
1168 else if (op->map) 956 else if (map)
1169 { 957 {
1170 x = op->x; 958 if (type == PLAYER)
1171 y = op->y;
1172 m = get_map_from_coord (op->map, &x, &y);
1173
1174 if (!m)
1175 { 959 {
1176 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 960 --map->players;
1177 op->map->path, op->x, op->y); 961 map->touch ();
1178 /* in old days, we used to set x and y to 0 and continue.
1179 * it seems if we get into this case, something is probablye
1180 * screwed up and should be fixed.
1181 */
1182 abort ();
1183 } 962 }
1184 963
1185 if (op->map != m) 964 map->dirty = true;
1186 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 965 mapspace &ms = this->ms ();
1187 op->map->path, m->path, op->x, op->y, x, y);
1188
1189 /* Re did the following section of code - it looks like it had
1190 * lots of logic for things we no longer care about
1191 */
1192 966
1193 /* link the object above us */ 967 /* link the object above us */
1194 if (op->above) 968 if (above)
1195 op->above->below = op->below; 969 above->below = below;
1196 else 970 else
1197 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 971 ms.top = below; /* we were top, set new top */
1198 972
1199 /* Relink the object below us, if there is one */ 973 /* Relink the object below us, if there is one */
1200 if (op->below) 974 if (below)
1201 op->below->above = op->above; 975 below->above = above;
1202 else 976 else
1203 { 977 {
1204 /* Nothing below, which means we need to relink map object for this space 978 /* Nothing below, which means we need to relink map object for this space
1205 * use translated coordinates in case some oddness with map tiling is 979 * use translated coordinates in case some oddness with map tiling is
1206 * evident 980 * evident
1207 */ 981 */
1208 if (GET_MAP_OB (m, x, y) != op) 982 if (GET_MAP_OB (map, x, y) != this)
1209 {
1210 dump_object (op);
1211 LOG (llevError,
1212 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 983 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1213 dump_object (GET_MAP_OB (m, x, y));
1214 LOG (llevError, "%s\n", errmsg);
1215 }
1216 984
1217 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 985 ms.bot = above; /* goes on above it. */
1218 } 986 }
1219 987
1220 op->above = 0; 988 above = 0;
1221 op->below = 0; 989 below = 0;
1222 990
1223 if (op->map->in_memory == MAP_SAVING) 991 if (map->in_memory == MAP_SAVING)
1224 return; 992 return;
1225 993
1226 tag = op->count; 994 int check_walk_off = !flag [FLAG_NO_APPLY];
1227 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1228 995
1229 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 996 for (tmp = ms.bot; tmp; tmp = tmp->above)
1230 { 997 {
1231 /* No point updating the players look faces if he is the object 998 /* No point updating the players look faces if he is the object
1232 * being removed. 999 * being removed.
1233 */ 1000 */
1234 1001
1235 if (tmp->type == PLAYER && tmp != op) 1002 if (tmp->type == PLAYER && tmp != this)
1236 { 1003 {
1237 /* If a container that the player is currently using somehow gets 1004 /* If a container that the player is currently using somehow gets
1238 * removed (most likely destroyed), update the player view 1005 * removed (most likely destroyed), update the player view
1239 * appropriately. 1006 * appropriately.
1240 */ 1007 */
1241 if (tmp->container == op) 1008 if (tmp->container == this)
1242 { 1009 {
1243 CLEAR_FLAG (op, FLAG_APPLIED); 1010 flag [FLAG_APPLIED] = 0;
1244 tmp->container = NULL; 1011 tmp->container = 0;
1245 } 1012 }
1246 1013
1247 tmp->contr->socket.update_look = 1; 1014 if (tmp->contr->ns)
1015 tmp->contr->ns->floorbox_update ();
1248 } 1016 }
1249 1017
1250 /* See if player moving off should effect something */ 1018 /* See if object moving off should effect something */
1251 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1019 if (check_walk_off
1020 && ((move_type & tmp->move_off)
1021 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1252 { 1022 {
1253 move_apply (tmp, op, NULL); 1023 move_apply (tmp, this, 0);
1254 1024
1255 if (was_destroyed (op, tag)) 1025 if (destroyed ())
1256 {
1257 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1026 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1258 }
1259 } 1027 }
1260 1028
1261 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1029 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1262 1030 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1263 if (tmp->above == tmp) 1031 if (tmp->above == tmp)
1264 tmp->above = NULL; 1032 tmp->above = 0;
1265 1033
1266 last = tmp; 1034 last = tmp;
1267 } 1035 }
1268 1036
1269 /* last == NULL of there are no objects on this space */ 1037 /* last == NULL if there are no objects on this space */
1038 //TODO: this makes little sense, why only update the topmost object?
1270 if (last == NULL) 1039 if (!last)
1271 { 1040 map->at (x, y).flags_ = 0;
1272 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1273 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1274 * those out anyways, and if there are any flags set right now, they won't
1275 * be correct anyways.
1276 */
1277 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1278 update_position (op->map, op->x, op->y);
1279 }
1280 else 1041 else
1281 update_object (last, UP_OBJ_REMOVE); 1042 update_object (last, UP_OBJ_REMOVE);
1282 1043
1283 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1044 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1284 update_all_los (op->map, op->x, op->y); 1045 update_all_los (map, x, y);
1285 } 1046 }
1286} 1047}
1287 1048
1288/* 1049/*
1289 * merge_ob(op,top): 1050 * merge_ob(op,top):
… …
1297merge_ob (object *op, object *top) 1058merge_ob (object *op, object *top)
1298{ 1059{
1299 if (!op->nrof) 1060 if (!op->nrof)
1300 return 0; 1061 return 0;
1301 1062
1302 if (top == NULL) 1063 if (top)
1303 for (top = op; top != NULL && top->above != NULL; top = top->above); 1064 for (top = op; top && top->above; top = top->above)
1065 ;
1304 1066
1305 for (; top != NULL; top = top->below) 1067 for (; top; top = top->below)
1306 { 1068 {
1307 if (top == op) 1069 if (top == op)
1308 continue; 1070 continue;
1309 if (CAN_MERGE (op, top)) 1071
1072 if (object::can_merge (op, top))
1310 { 1073 {
1311 top->nrof += op->nrof; 1074 top->nrof += op->nrof;
1312 1075
1313/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1076/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1314 op->weight = 0; /* Don't want any adjustements now */ 1077 op->weight = 0; /* Don't want any adjustements now */
1315 remove_ob (op); 1078 op->destroy ();
1316 free_object (op);
1317 return top; 1079 return top;
1318 } 1080 }
1319 } 1081 }
1320 1082
1321 return NULL; 1083 return 0;
1322} 1084}
1323 1085
1324/* 1086/*
1325 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1087 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1326 * job preparing multi-part monsters 1088 * job preparing multi-part monsters.
1327 */ 1089 */
1328object * 1090object *
1329insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1091insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1330{ 1092{
1331 object *tmp;
1332
1333 if (op->head)
1334 op = op->head;
1335
1336 for (tmp = op; tmp; tmp = tmp->more) 1093 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1337 { 1094 {
1338 tmp->x = x + tmp->arch->clone.x; 1095 tmp->x = x + tmp->arch->clone.x;
1339 tmp->y = y + tmp->arch->clone.y; 1096 tmp->y = y + tmp->arch->clone.y;
1340 } 1097 }
1341 1098
… …
1360 * Return value: 1117 * Return value:
1361 * new object if 'op' was merged with other object 1118 * new object if 'op' was merged with other object
1362 * NULL if 'op' was destroyed 1119 * NULL if 'op' was destroyed
1363 * just 'op' otherwise 1120 * just 'op' otherwise
1364 */ 1121 */
1365
1366object * 1122object *
1367insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1123insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1368{ 1124{
1369 object *tmp, *top, *floor = NULL; 1125 object *tmp, *top, *floor = NULL;
1370 sint16 x, y;
1371 1126
1372 if (QUERY_FLAG (op, FLAG_FREED)) 1127 if (QUERY_FLAG (op, FLAG_FREED))
1373 { 1128 {
1374 LOG (llevError, "Trying to insert freed object!\n"); 1129 LOG (llevError, "Trying to insert freed object!\n");
1375 return NULL; 1130 return NULL;
1376 } 1131 }
1377 1132
1378 if (m == NULL) 1133 if (!QUERY_FLAG (op, FLAG_REMOVED))
1134 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1135
1136 op->remove ();
1137
1138 if (!m)
1379 { 1139 {
1380 dump_object (op); 1140 char *dump = dump_object (op);
1381 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1141 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1142 free (dump);
1382 return op; 1143 return op;
1383 } 1144 }
1384 1145
1385 if (out_of_map (m, op->x, op->y)) 1146 if (out_of_map (m, op->x, op->y))
1386 { 1147 {
1387 dump_object (op); 1148 char *dump = dump_object (op);
1388 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1149 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1389#ifdef MANY_CORES 1150#ifdef MANY_CORES
1390 /* Better to catch this here, as otherwise the next use of this object 1151 /* Better to catch this here, as otherwise the next use of this object
1391 * is likely to cause a crash. Better to find out where it is getting 1152 * is likely to cause a crash. Better to find out where it is getting
1392 * improperly inserted. 1153 * improperly inserted.
1393 */ 1154 */
1394 abort (); 1155 abort ();
1395#endif 1156#endif
1157 free (dump);
1396 return op; 1158 return op;
1397 } 1159 }
1398 1160
1399 if (!QUERY_FLAG (op, FLAG_REMOVED))
1400 {
1401 dump_object (op);
1402 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1403 return op;
1404 }
1405
1406 if (op->more != NULL)
1407 {
1408 /* The part may be on a different map. */
1409
1410 object *more = op->more; 1161 if (object *more = op->more)
1411 1162 {
1412 /* We really need the caller to normalize coordinates - if
1413 * we set the map, that doesn't work if the location is within
1414 * a map and this is straddling an edge. So only if coordinate
1415 * is clear wrong do we normalize it.
1416 */
1417 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1418 more->map = get_map_from_coord (m, &more->x, &more->y);
1419 else if (!more->map)
1420 {
1421 /* For backwards compatibility - when not dealing with tiled maps,
1422 * more->map should always point to the parent.
1423 */
1424 more->map = m;
1425 }
1426
1427 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1163 if (!insert_ob_in_map (more, m, originator, flag))
1428 { 1164 {
1429 if (!op->head) 1165 if (!op->head)
1430 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1166 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1431 1167
1432 return NULL; 1168 return 0;
1433 } 1169 }
1434 } 1170 }
1435 1171
1436 CLEAR_FLAG (op, FLAG_REMOVED); 1172 CLEAR_FLAG (op, FLAG_REMOVED);
1437 1173
1438 /* Ideally, the caller figures this out. However, it complicates a lot 1174 /* Ideally, the caller figures this out. However, it complicates a lot
1439 * of areas of callers (eg, anything that uses find_free_spot would now 1175 * of areas of callers (eg, anything that uses find_free_spot would now
1440 * need extra work 1176 * need extra work
1441 */ 1177 */
1442 op->map = get_map_from_coord (m, &op->x, &op->y); 1178 if (!xy_normalise (m, op->x, op->y))
1443 x = op->x; 1179 return 0;
1444 y = op->y; 1180
1181 op->map = m;
1182 mapspace &ms = op->ms ();
1445 1183
1446 /* this has to be done after we translate the coordinates. 1184 /* this has to be done after we translate the coordinates.
1447 */ 1185 */
1448 if (op->nrof && !(flag & INS_NO_MERGE)) 1186 if (op->nrof && !(flag & INS_NO_MERGE))
1449 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1187 for (tmp = ms.bot; tmp; tmp = tmp->above)
1450 if (CAN_MERGE (op, tmp)) 1188 if (object::can_merge (op, tmp))
1451 { 1189 {
1452 op->nrof += tmp->nrof; 1190 op->nrof += tmp->nrof;
1453 remove_ob (tmp); 1191 tmp->destroy ();
1454 free_object (tmp);
1455 } 1192 }
1456 1193
1457 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1194 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1458 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1195 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1459 1196
… …
1472 op->below = originator->below; 1209 op->below = originator->below;
1473 1210
1474 if (op->below) 1211 if (op->below)
1475 op->below->above = op; 1212 op->below->above = op;
1476 else 1213 else
1477 SET_MAP_OB (op->map, op->x, op->y, op); 1214 ms.bot = op;
1478 1215
1479 /* since *below* originator, no need to update top */ 1216 /* since *below* originator, no need to update top */
1480 originator->below = op; 1217 originator->below = op;
1481 } 1218 }
1482 else 1219 else
1483 { 1220 {
1221 top = ms.bot;
1222
1484 /* If there are other objects, then */ 1223 /* If there are other objects, then */
1485 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1224 if ((!(flag & INS_MAP_LOAD)) && top)
1486 { 1225 {
1487 object *last = NULL; 1226 object *last = 0;
1488 1227
1489 /* 1228 /*
1490 * If there are multiple objects on this space, we do some trickier handling. 1229 * If there are multiple objects on this space, we do some trickier handling.
1491 * We've already dealt with merging if appropriate. 1230 * We've already dealt with merging if appropriate.
1492 * Generally, we want to put the new object on top. But if 1231 * Generally, we want to put the new object on top. But if
… …
1496 * once we get to them. This reduces the need to traverse over all of 1235 * once we get to them. This reduces the need to traverse over all of
1497 * them when adding another one - this saves quite a bit of cpu time 1236 * them when adding another one - this saves quite a bit of cpu time
1498 * when lots of spells are cast in one area. Currently, it is presumed 1237 * when lots of spells are cast in one area. Currently, it is presumed
1499 * that flying non pickable objects are spell objects. 1238 * that flying non pickable objects are spell objects.
1500 */ 1239 */
1501 1240 for (top = ms.bot; top; top = top->above)
1502 while (top != NULL)
1503 { 1241 {
1504 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1242 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1505 floor = top; 1243 floor = top;
1506 1244
1507 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1245 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1510 top = top->below; 1248 top = top->below;
1511 break; 1249 break;
1512 } 1250 }
1513 1251
1514 last = top; 1252 last = top;
1515 top = top->above;
1516 } 1253 }
1517 1254
1518 /* Don't want top to be NULL, so set it to the last valid object */ 1255 /* Don't want top to be NULL, so set it to the last valid object */
1519 top = last; 1256 top = last;
1520 1257
… …
1527 * Unless those objects are exits, type 66 1264 * Unless those objects are exits, type 66
1528 * If INS_ON_TOP is used, don't do this processing 1265 * If INS_ON_TOP is used, don't do this processing
1529 * Need to find the object that in fact blocks view, otherwise 1266 * Need to find the object that in fact blocks view, otherwise
1530 * stacking is a bit odd. 1267 * stacking is a bit odd.
1531 */ 1268 */
1532 if (!(flag & INS_ON_TOP) && 1269 if (!(flag & INS_ON_TOP)
1533 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1270 && ms.flags () & P_BLOCKSVIEW
1271 && (op->face && !op->face->visibility))
1534 { 1272 {
1535 for (last = top; last != floor; last = last->below) 1273 for (last = top; last != floor; last = last->below)
1536 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1274 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1537 break; 1275 break;
1276
1538 /* Check to see if we found the object that blocks view, 1277 /* Check to see if we found the object that blocks view,
1539 * and make sure we have a below pointer for it so that 1278 * and make sure we have a below pointer for it so that
1540 * we can get inserted below this one, which requires we 1279 * we can get inserted below this one, which requires we
1541 * set top to the object below us. 1280 * set top to the object below us.
1542 */ 1281 */
… …
1544 top = last->below; 1283 top = last->below;
1545 } 1284 }
1546 } /* If objects on this space */ 1285 } /* If objects on this space */
1547 1286
1548 if (flag & INS_MAP_LOAD) 1287 if (flag & INS_MAP_LOAD)
1549 top = GET_MAP_TOP (op->map, op->x, op->y); 1288 top = ms.top;
1550 1289
1551 if (flag & INS_ABOVE_FLOOR_ONLY) 1290 if (flag & INS_ABOVE_FLOOR_ONLY)
1552 top = floor; 1291 top = floor;
1553 1292
1554 /* Top is the object that our object (op) is going to get inserted above. 1293 /* Top is the object that our object (op) is going to get inserted above.
1555 */ 1294 */
1556 1295
1557 /* First object on this space */ 1296 /* First object on this space */
1558 if (!top) 1297 if (!top)
1559 { 1298 {
1560 op->above = GET_MAP_OB (op->map, op->x, op->y); 1299 op->above = ms.bot;
1561 1300
1562 if (op->above) 1301 if (op->above)
1563 op->above->below = op; 1302 op->above->below = op;
1564 1303
1565 op->below = NULL; 1304 op->below = 0;
1566 SET_MAP_OB (op->map, op->x, op->y, op); 1305 ms.bot = op;
1567 } 1306 }
1568 else 1307 else
1569 { /* get inserted into the stack above top */ 1308 { /* get inserted into the stack above top */
1570 op->above = top->above; 1309 op->above = top->above;
1571 1310
… …
1574 1313
1575 op->below = top; 1314 op->below = top;
1576 top->above = op; 1315 top->above = op;
1577 } 1316 }
1578 1317
1579 if (op->above == NULL) 1318 if (!op->above)
1580 SET_MAP_TOP (op->map, op->x, op->y, op); 1319 ms.top = op;
1581 } /* else not INS_BELOW_ORIGINATOR */ 1320 } /* else not INS_BELOW_ORIGINATOR */
1582 1321
1583 if (op->type == PLAYER) 1322 if (op->type == PLAYER)
1323 {
1584 op->contr->do_los = 1; 1324 op->contr->do_los = 1;
1325 ++op->map->players;
1326 op->map->touch ();
1327 }
1328
1329 op->map->dirty = true;
1585 1330
1586 /* If we have a floor, we know the player, if any, will be above 1331 /* If we have a floor, we know the player, if any, will be above
1587 * it, so save a few ticks and start from there. 1332 * it, so save a few ticks and start from there.
1588 */ 1333 */
1589 if (!(flag & INS_MAP_LOAD)) 1334 if (!(flag & INS_MAP_LOAD))
1590 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1335 if (object *pl = ms.player ())
1591 if (tmp->type == PLAYER) 1336 if (pl->contr->ns)
1592 tmp->contr->socket.update_look = 1; 1337 pl->contr->ns->floorbox_update ();
1593 1338
1594 /* If this object glows, it may affect lighting conditions that are 1339 /* If this object glows, it may affect lighting conditions that are
1595 * visible to others on this map. But update_all_los is really 1340 * visible to others on this map. But update_all_los is really
1596 * an inefficient way to do this, as it means los for all players 1341 * an inefficient way to do this, as it means los for all players
1597 * on the map will get recalculated. The players could very well 1342 * on the map will get recalculated. The players could very well
1598 * be far away from this change and not affected in any way - 1343 * be far away from this change and not affected in any way -
1599 * this should get redone to only look for players within range, 1344 * this should get redone to only look for players within range,
1600 * or just updating the P_NEED_UPDATE for spaces within this area 1345 * or just updating the P_UPTODATE for spaces within this area
1601 * of effect may be sufficient. 1346 * of effect may be sufficient.
1602 */ 1347 */
1603 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1348 if (op->map->darkness && (op->glow_radius != 0))
1604 update_all_los (op->map, op->x, op->y); 1349 update_all_los (op->map, op->x, op->y);
1605 1350
1606 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1351 /* updates flags (blocked, alive, no magic, etc) for this map space */
1607 update_object (op, UP_OBJ_INSERT); 1352 update_object (op, UP_OBJ_INSERT);
1608 1353
1354 INVOKE_OBJECT (INSERT, op);
1355
1609 /* Don't know if moving this to the end will break anything. However, 1356 /* Don't know if moving this to the end will break anything. However,
1610 * we want to have update_look set above before calling this. 1357 * we want to have floorbox_update called before calling this.
1611 * 1358 *
1612 * check_move_on() must be after this because code called from 1359 * check_move_on() must be after this because code called from
1613 * check_move_on() depends on correct map flags (so functions like 1360 * check_move_on() depends on correct map flags (so functions like
1614 * blocked() and wall() work properly), and these flags are updated by 1361 * blocked() and wall() work properly), and these flags are updated by
1615 * update_object(). 1362 * update_object().
… …
1617 1364
1618 /* if this is not the head or flag has been passed, don't check walk on status */ 1365 /* if this is not the head or flag has been passed, don't check walk on status */
1619 if (!(flag & INS_NO_WALK_ON) && !op->head) 1366 if (!(flag & INS_NO_WALK_ON) && !op->head)
1620 { 1367 {
1621 if (check_move_on (op, originator)) 1368 if (check_move_on (op, originator))
1622 return NULL; 1369 return 0;
1623 1370
1624 /* If we are a multi part object, lets work our way through the check 1371 /* If we are a multi part object, lets work our way through the check
1625 * walk on's. 1372 * walk on's.
1626 */ 1373 */
1627 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1374 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1628 if (check_move_on (tmp, originator)) 1375 if (check_move_on (tmp, originator))
1629 return NULL; 1376 return 0;
1630 } 1377 }
1631 1378
1632 return op; 1379 return op;
1633} 1380}
1634 1381
1635/* this function inserts an object in the map, but if it 1382/* this function inserts an object in the map, but if it
1636 * finds an object of its own type, it'll remove that one first. 1383 * finds an object of its own type, it'll remove that one first.
1637 * op is the object to insert it under: supplies x and the map. 1384 * op is the object to insert it under: supplies x and the map.
1638 */ 1385 */
1639void 1386void
1640replace_insert_ob_in_map (const char *arch_string, object *op) 1387replace_insert_ob_in_map (const char *arch_string, object *op)
1641{ 1388{
1642 object * 1389 object *tmp, *tmp1;
1643 tmp;
1644 object *
1645 tmp1;
1646 1390
1647 /* first search for itself and remove any old instances */ 1391 /* first search for itself and remove any old instances */
1648 1392
1649 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1393 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1650 {
1651 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1394 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1652 { 1395 tmp->destroy ();
1653 remove_ob (tmp);
1654 free_object (tmp);
1655 }
1656 }
1657 1396
1658 tmp1 = arch_to_object (find_archetype (arch_string)); 1397 tmp1 = arch_to_object (archetype::find (arch_string));
1659 1398
1660 tmp1->x = op->x; 1399 tmp1->x = op->x;
1661 tmp1->y = op->y; 1400 tmp1->y = op->y;
1662 insert_ob_in_map (tmp1, op->map, op, 0); 1401 insert_ob_in_map (tmp1, op->map, op, 0);
1402}
1403
1404object *
1405object::insert_at (object *where, object *originator, int flags)
1406{
1407 where->map->insert (this, where->x, where->y, originator, flags);
1663} 1408}
1664 1409
1665/* 1410/*
1666 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1411 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1667 * is returned contains nr objects, and the remaining parts contains 1412 * is returned contains nr objects, and the remaining parts contains
1668 * the rest (or is removed and freed if that number is 0). 1413 * the rest (or is removed and freed if that number is 0).
1669 * On failure, NULL is returned, and the reason put into the 1414 * On failure, NULL is returned, and the reason put into the
1670 * global static errmsg array. 1415 * global static errmsg array.
1671 */ 1416 */
1672
1673object * 1417object *
1674get_split_ob (object *orig_ob, uint32 nr) 1418get_split_ob (object *orig_ob, uint32 nr)
1675{ 1419{
1676 object * 1420 object *newob;
1677 newob;
1678 int
1679 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1421 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1680 1422
1681 if (orig_ob->nrof < nr) 1423 if (orig_ob->nrof < nr)
1682 { 1424 {
1683 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1425 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1684 return NULL; 1426 return NULL;
1685 } 1427 }
1686 1428
1687 newob = object_create_clone (orig_ob); 1429 newob = object_create_clone (orig_ob);
1688 1430
1689 if ((orig_ob->nrof -= nr) < 1) 1431 if ((orig_ob->nrof -= nr) < 1)
1690 { 1432 orig_ob->destroy (1);
1691 if (!is_removed)
1692 remove_ob (orig_ob);
1693 free_object2 (orig_ob, 1);
1694 }
1695 else if (!is_removed) 1433 else if (!is_removed)
1696 { 1434 {
1697 if (orig_ob->env != NULL) 1435 if (orig_ob->env != NULL)
1698 sub_weight (orig_ob->env, orig_ob->weight * nr); 1436 sub_weight (orig_ob->env, orig_ob->weight * nr);
1699 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1437 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1719 1457
1720object * 1458object *
1721decrease_ob_nr (object *op, uint32 i) 1459decrease_ob_nr (object *op, uint32 i)
1722{ 1460{
1723 object *tmp; 1461 object *tmp;
1724 player *pl;
1725 1462
1726 if (i == 0) /* objects with op->nrof require this check */ 1463 if (i == 0) /* objects with op->nrof require this check */
1727 return op; 1464 return op;
1728 1465
1729 if (i > op->nrof) 1466 if (i > op->nrof)
1730 i = op->nrof; 1467 i = op->nrof;
1731 1468
1732 if (QUERY_FLAG (op, FLAG_REMOVED)) 1469 if (QUERY_FLAG (op, FLAG_REMOVED))
1733 op->nrof -= i; 1470 op->nrof -= i;
1734 else if (op->env != NULL) 1471 else if (op->env)
1735 { 1472 {
1736 /* is this object in the players inventory, or sub container 1473 /* is this object in the players inventory, or sub container
1737 * therein? 1474 * therein?
1738 */ 1475 */
1739 tmp = is_player_inv (op->env); 1476 tmp = op->in_player ();
1740 /* nope. Is this a container the player has opened? 1477 /* nope. Is this a container the player has opened?
1741 * If so, set tmp to that player. 1478 * If so, set tmp to that player.
1742 * IMO, searching through all the players will mostly 1479 * IMO, searching through all the players will mostly
1743 * likely be quicker than following op->env to the map, 1480 * likely be quicker than following op->env to the map,
1744 * and then searching the map for a player. 1481 * and then searching the map for a player.
1745 */ 1482 */
1746 if (!tmp) 1483 if (!tmp)
1747 { 1484 for_all_players (pl)
1748 for (pl = first_player; pl; pl = pl->next)
1749 if (pl->ob->container == op->env) 1485 if (pl->ob->container == op->env)
1486 {
1487 tmp = pl->ob;
1750 break; 1488 break;
1751 if (pl)
1752 tmp = pl->ob;
1753 else
1754 tmp = NULL;
1755 } 1489 }
1756 1490
1757 if (i < op->nrof) 1491 if (i < op->nrof)
1758 { 1492 {
1759 sub_weight (op->env, op->weight * i); 1493 sub_weight (op->env, op->weight * i);
1760 op->nrof -= i; 1494 op->nrof -= i;
1761 if (tmp) 1495 if (tmp)
1762 {
1763 esrv_send_item (tmp, op); 1496 esrv_send_item (tmp, op);
1764 }
1765 } 1497 }
1766 else 1498 else
1767 { 1499 {
1768 remove_ob (op); 1500 op->remove ();
1769 op->nrof = 0; 1501 op->nrof = 0;
1770 if (tmp) 1502 if (tmp)
1771 {
1772 esrv_del_item (tmp->contr, op->count); 1503 esrv_del_item (tmp->contr, op->count);
1773 }
1774 } 1504 }
1775 } 1505 }
1776 else 1506 else
1777 { 1507 {
1778 object *above = op->above; 1508 object *above = op->above;
1779 1509
1780 if (i < op->nrof) 1510 if (i < op->nrof)
1781 op->nrof -= i; 1511 op->nrof -= i;
1782 else 1512 else
1783 { 1513 {
1784 remove_ob (op); 1514 op->remove ();
1785 op->nrof = 0; 1515 op->nrof = 0;
1786 } 1516 }
1787 1517
1788 /* Since we just removed op, op->above is null */ 1518 /* Since we just removed op, op->above is null */
1789 for (tmp = above; tmp != NULL; tmp = tmp->above) 1519 for (tmp = above; tmp; tmp = tmp->above)
1790 if (tmp->type == PLAYER) 1520 if (tmp->type == PLAYER)
1791 { 1521 {
1792 if (op->nrof) 1522 if (op->nrof)
1793 esrv_send_item (tmp, op); 1523 esrv_send_item (tmp, op);
1794 else 1524 else
… …
1798 1528
1799 if (op->nrof) 1529 if (op->nrof)
1800 return op; 1530 return op;
1801 else 1531 else
1802 { 1532 {
1803 free_object (op); 1533 op->destroy ();
1804 return NULL; 1534 return 0;
1805 } 1535 }
1806} 1536}
1807 1537
1808/* 1538/*
1809 * add_weight(object, weight) adds the specified weight to an object, 1539 * add_weight(object, weight) adds the specified weight to an object,
… …
1821 op->carrying += weight; 1551 op->carrying += weight;
1822 op = op->env; 1552 op = op->env;
1823 } 1553 }
1824} 1554}
1825 1555
1556object *
1557insert_ob_in_ob (object *op, object *where)
1558{
1559 if (!where)
1560 {
1561 char *dump = dump_object (op);
1562 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1563 free (dump);
1564 return op;
1565 }
1566
1567 if (where->head)
1568 {
1569 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1570 where = where->head;
1571 }
1572
1573 return where->insert (op);
1574}
1575
1826/* 1576/*
1827 * insert_ob_in_ob(op,environment): 1577 * env->insert (op)
1828 * This function inserts the object op in the linked list 1578 * This function inserts the object op in the linked list
1829 * inside the object environment. 1579 * inside the object environment.
1830 * 1580 *
1831 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1832 * the inventory at the last position or next to other objects of the same
1833 * type.
1834 * Frank: Now sorted by type, archetype and magic!
1835 *
1836 * The function returns now pointer to inserted item, and return value can 1581 * The function returns now pointer to inserted item, and return value can
1837 * be != op, if items are merged. -Tero 1582 * be != op, if items are merged. -Tero
1838 */ 1583 */
1839 1584
1840object * 1585object *
1841insert_ob_in_ob (object *op, object *where) 1586object::insert (object *op)
1842{ 1587{
1843 object * 1588 object *tmp, *otmp;
1844 tmp, *
1845 otmp;
1846 1589
1847 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1590 if (!QUERY_FLAG (op, FLAG_REMOVED))
1848 { 1591 op->remove ();
1849 dump_object (op);
1850 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1851 return op;
1852 }
1853
1854 if (where == NULL)
1855 {
1856 dump_object (op);
1857 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1858 return op;
1859 }
1860
1861 if (where->head)
1862 {
1863 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1864 where = where->head;
1865 }
1866 1592
1867 if (op->more) 1593 if (op->more)
1868 { 1594 {
1869 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1595 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1870 return op; 1596 return op;
… …
1872 1598
1873 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1599 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1874 CLEAR_FLAG (op, FLAG_REMOVED); 1600 CLEAR_FLAG (op, FLAG_REMOVED);
1875 if (op->nrof) 1601 if (op->nrof)
1876 { 1602 {
1877 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1603 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1878 if (CAN_MERGE (tmp, op)) 1604 if (object::can_merge (tmp, op))
1879 { 1605 {
1880 /* return the original object and remove inserted object 1606 /* return the original object and remove inserted object
1881 (client needs the original object) */ 1607 (client needs the original object) */
1882 tmp->nrof += op->nrof; 1608 tmp->nrof += op->nrof;
1883 /* Weight handling gets pretty funky. Since we are adding to 1609 /* Weight handling gets pretty funky. Since we are adding to
1884 * tmp->nrof, we need to increase the weight. 1610 * tmp->nrof, we need to increase the weight.
1885 */ 1611 */
1886 add_weight (where, op->weight * op->nrof); 1612 add_weight (this, op->weight * op->nrof);
1887 SET_FLAG (op, FLAG_REMOVED); 1613 SET_FLAG (op, FLAG_REMOVED);
1888 free_object (op); /* free the inserted object */ 1614 op->destroy (); /* free the inserted object */
1889 op = tmp; 1615 op = tmp;
1890 remove_ob (op); /* and fix old object's links */ 1616 op->remove (); /* and fix old object's links */
1891 CLEAR_FLAG (op, FLAG_REMOVED); 1617 CLEAR_FLAG (op, FLAG_REMOVED);
1892 break; 1618 break;
1893 } 1619 }
1894 1620
1895 /* I assume combined objects have no inventory 1621 /* I assume combined objects have no inventory
1896 * We add the weight - this object could have just been removed 1622 * We add the weight - this object could have just been removed
1897 * (if it was possible to merge). calling remove_ob will subtract 1623 * (if it was possible to merge). calling remove_ob will subtract
1898 * the weight, so we need to add it in again, since we actually do 1624 * the weight, so we need to add it in again, since we actually do
1899 * the linking below 1625 * the linking below
1900 */ 1626 */
1901 add_weight (where, op->weight * op->nrof); 1627 add_weight (this, op->weight * op->nrof);
1902 } 1628 }
1903 else 1629 else
1904 add_weight (where, (op->weight + op->carrying)); 1630 add_weight (this, (op->weight + op->carrying));
1905 1631
1906 otmp = is_player_inv (where); 1632 otmp = this->in_player ();
1907 if (otmp && otmp->contr != NULL) 1633 if (otmp && otmp->contr)
1908 {
1909 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1634 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1910 fix_player (otmp); 1635 otmp->update_stats ();
1911 }
1912 1636
1913 op->map = NULL; 1637 op->map = 0;
1914 op->env = where; 1638 op->env = this;
1915 op->above = NULL; 1639 op->above = 0;
1916 op->below = NULL; 1640 op->below = 0;
1917 op->x = 0, op->y = 0; 1641 op->x = 0, op->y = 0;
1918 1642
1919 /* reset the light list and los of the players on the map */ 1643 /* reset the light list and los of the players on the map */
1920 if ((op->glow_radius != 0) && where->map) 1644 if ((op->glow_radius != 0) && map)
1921 { 1645 {
1922#ifdef DEBUG_LIGHTS 1646#ifdef DEBUG_LIGHTS
1923 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1647 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1924#endif /* DEBUG_LIGHTS */ 1648#endif /* DEBUG_LIGHTS */
1925 if (MAP_DARKNESS (where->map)) 1649 if (map->darkness)
1926 update_all_los (where->map, where->x, where->y); 1650 update_all_los (map, x, y);
1927 } 1651 }
1928 1652
1929 /* Client has no idea of ordering so lets not bother ordering it here. 1653 /* Client has no idea of ordering so lets not bother ordering it here.
1930 * It sure simplifies this function... 1654 * It sure simplifies this function...
1931 */ 1655 */
1932 if (where->inv == NULL) 1656 if (!inv)
1933 where->inv = op; 1657 inv = op;
1934 else 1658 else
1935 { 1659 {
1936 op->below = where->inv; 1660 op->below = inv;
1937 op->below->above = op; 1661 op->below->above = op;
1938 where->inv = op; 1662 inv = op;
1939 } 1663 }
1664
1665 INVOKE_OBJECT (INSERT, this);
1666
1940 return op; 1667 return op;
1941} 1668}
1942 1669
1943/* 1670/*
1944 * Checks if any objects has a move_type that matches objects 1671 * Checks if any objects has a move_type that matches objects
… …
1958 * 1685 *
1959 * MSW 2001-07-08: Check all objects on space, not just those below 1686 * MSW 2001-07-08: Check all objects on space, not just those below
1960 * object being inserted. insert_ob_in_map may not put new objects 1687 * object being inserted. insert_ob_in_map may not put new objects
1961 * on top. 1688 * on top.
1962 */ 1689 */
1963
1964int 1690int
1965check_move_on (object *op, object *originator) 1691check_move_on (object *op, object *originator)
1966{ 1692{
1967 object * 1693 object *tmp;
1968 tmp; 1694 maptile *m = op->map;
1969 tag_t
1970 tag;
1971 mapstruct *
1972 m = op->map;
1973 int
1974 x = op->x, y = op->y; 1695 int x = op->x, y = op->y;
1975 1696
1976 MoveType 1697 MoveType move_on, move_slow, move_block;
1977 move_on,
1978 move_slow,
1979 move_block;
1980 1698
1981 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1699 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1982 return 0; 1700 return 0;
1983
1984 tag = op->count;
1985 1701
1986 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1702 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1987 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1703 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1988 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1704 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1989 1705
… …
2005 1721
2006 /* The objects have to be checked from top to bottom. 1722 /* The objects have to be checked from top to bottom.
2007 * Hence, we first go to the top: 1723 * Hence, we first go to the top:
2008 */ 1724 */
2009 1725
2010 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1726 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
2011 { 1727 {
2012 /* Trim the search when we find the first other spell effect 1728 /* Trim the search when we find the first other spell effect
2013 * this helps performance so that if a space has 50 spell objects, 1729 * this helps performance so that if a space has 50 spell objects,
2014 * we don't need to check all of them. 1730 * we don't need to check all of them.
2015 */ 1731 */
… …
2033 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1749 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2034 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1750 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2035 { 1751 {
2036 1752
2037 float 1753 float
2038 diff = tmp->move_slow_penalty * FABS (op->speed); 1754 diff = tmp->move_slow_penalty * fabs (op->speed);
2039 1755
2040 if (op->type == PLAYER) 1756 if (op->type == PLAYER)
2041 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1757 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2042 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1758 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2043 diff /= 4.0; 1759 diff /= 4.0;
… …
2050 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1766 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2051 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1767 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2052 { 1768 {
2053 move_apply (tmp, op, originator); 1769 move_apply (tmp, op, originator);
2054 1770
2055 if (was_destroyed (op, tag)) 1771 if (op->destroyed ())
2056 return 1; 1772 return 1;
2057 1773
2058 /* what the person/creature stepped onto has moved the object 1774 /* what the person/creature stepped onto has moved the object
2059 * someplace new. Don't process any further - if we did, 1775 * someplace new. Don't process any further - if we did,
2060 * have a feeling strange problems would result. 1776 * have a feeling strange problems would result.
… …
2070/* 1786/*
2071 * present_arch(arch, map, x, y) searches for any objects with 1787 * present_arch(arch, map, x, y) searches for any objects with
2072 * a matching archetype at the given map and coordinates. 1788 * a matching archetype at the given map and coordinates.
2073 * The first matching object is returned, or NULL if none. 1789 * The first matching object is returned, or NULL if none.
2074 */ 1790 */
2075
2076object * 1791object *
2077present_arch (const archetype *at, mapstruct *m, int x, int y) 1792present_arch (const archetype *at, maptile *m, int x, int y)
2078{ 1793{
2079 object *
2080 tmp;
2081
2082 if (m == NULL || out_of_map (m, x, y)) 1794 if (!m || out_of_map (m, x, y))
2083 { 1795 {
2084 LOG (llevError, "Present_arch called outside map.\n"); 1796 LOG (llevError, "Present_arch called outside map.\n");
2085 return NULL; 1797 return NULL;
2086 } 1798 }
2087 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1799
1800 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2088 if (tmp->arch == at) 1801 if (tmp->arch == at)
2089 return tmp; 1802 return tmp;
1803
2090 return NULL; 1804 return NULL;
2091} 1805}
2092 1806
2093/* 1807/*
2094 * present(type, map, x, y) searches for any objects with 1808 * present(type, map, x, y) searches for any objects with
2095 * a matching type variable at the given map and coordinates. 1809 * a matching type variable at the given map and coordinates.
2096 * The first matching object is returned, or NULL if none. 1810 * The first matching object is returned, or NULL if none.
2097 */ 1811 */
2098
2099object * 1812object *
2100present (unsigned char type, mapstruct *m, int x, int y) 1813present (unsigned char type, maptile *m, int x, int y)
2101{ 1814{
2102 object *
2103 tmp;
2104
2105 if (out_of_map (m, x, y)) 1815 if (out_of_map (m, x, y))
2106 { 1816 {
2107 LOG (llevError, "Present called outside map.\n"); 1817 LOG (llevError, "Present called outside map.\n");
2108 return NULL; 1818 return NULL;
2109 } 1819 }
2110 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1820
1821 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2111 if (tmp->type == type) 1822 if (tmp->type == type)
2112 return tmp; 1823 return tmp;
1824
2113 return NULL; 1825 return NULL;
2114} 1826}
2115 1827
2116/* 1828/*
2117 * present_in_ob(type, object) searches for any objects with 1829 * present_in_ob(type, object) searches for any objects with
2118 * a matching type variable in the inventory of the given object. 1830 * a matching type variable in the inventory of the given object.
2119 * The first matching object is returned, or NULL if none. 1831 * The first matching object is returned, or NULL if none.
2120 */ 1832 */
2121
2122object * 1833object *
2123present_in_ob (unsigned char type, const object *op) 1834present_in_ob (unsigned char type, const object *op)
2124{ 1835{
2125 object *
2126 tmp;
2127
2128 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1836 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2129 if (tmp->type == type) 1837 if (tmp->type == type)
2130 return tmp; 1838 return tmp;
1839
2131 return NULL; 1840 return NULL;
2132} 1841}
2133 1842
2134/* 1843/*
2135 * present_in_ob (type, str, object) searches for any objects with 1844 * present_in_ob (type, str, object) searches for any objects with
… …
2143 * str is the string to match against. Note that we match against 1852 * str is the string to match against. Note that we match against
2144 * the object name, not the archetype name. this is so that the 1853 * the object name, not the archetype name. this is so that the
2145 * spell code can use one object type (force), but change it's name 1854 * spell code can use one object type (force), but change it's name
2146 * to be unique. 1855 * to be unique.
2147 */ 1856 */
2148
2149object * 1857object *
2150present_in_ob_by_name (int type, const char *str, const object *op) 1858present_in_ob_by_name (int type, const char *str, const object *op)
2151{ 1859{
2152 object *
2153 tmp;
2154
2155 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2156 {
2157 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1861 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2158 return tmp; 1862 return tmp;
2159 } 1863
2160 return NULL; 1864 return 0;
2161} 1865}
2162 1866
2163/* 1867/*
2164 * present_arch_in_ob(archetype, object) searches for any objects with 1868 * present_arch_in_ob(archetype, object) searches for any objects with
2165 * a matching archetype in the inventory of the given object. 1869 * a matching archetype in the inventory of the given object.
2166 * The first matching object is returned, or NULL if none. 1870 * The first matching object is returned, or NULL if none.
2167 */ 1871 */
2168
2169object * 1872object *
2170present_arch_in_ob (const archetype *at, const object *op) 1873present_arch_in_ob (const archetype *at, const object *op)
2171{ 1874{
2172 object *
2173 tmp;
2174
2175 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1875 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2176 if (tmp->arch == at) 1876 if (tmp->arch == at)
2177 return tmp; 1877 return tmp;
1878
2178 return NULL; 1879 return NULL;
2179} 1880}
2180 1881
2181/* 1882/*
2182 * activate recursively a flag on an object inventory 1883 * activate recursively a flag on an object inventory
2183 */ 1884 */
2184void 1885void
2185flag_inv (object *op, int flag) 1886flag_inv (object *op, int flag)
2186{ 1887{
2187 object *
2188 tmp;
2189
2190 if (op->inv) 1888 if (op->inv)
2191 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1889 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2192 { 1890 {
2193 SET_FLAG (tmp, flag); 1891 SET_FLAG (tmp, flag);
2194 flag_inv (tmp, flag); 1892 flag_inv (tmp, flag);
2195 } 1893 }
2196} /* 1894}
1895
1896/*
2197 * desactivate recursively a flag on an object inventory 1897 * deactivate recursively a flag on an object inventory
2198 */ 1898 */
2199void 1899void
2200unflag_inv (object *op, int flag) 1900unflag_inv (object *op, int flag)
2201{ 1901{
2202 object *
2203 tmp;
2204
2205 if (op->inv) 1902 if (op->inv)
2206 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1903 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2207 { 1904 {
2208 CLEAR_FLAG (tmp, flag); 1905 CLEAR_FLAG (tmp, flag);
2209 unflag_inv (tmp, flag); 1906 unflag_inv (tmp, flag);
2210 } 1907 }
2211} 1908}
… …
2214 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1911 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2215 * all it's inventory (recursively). 1912 * all it's inventory (recursively).
2216 * If checksums are used, a player will get set_cheat called for 1913 * If checksums are used, a player will get set_cheat called for
2217 * him/her-self and all object carried by a call to this function. 1914 * him/her-self and all object carried by a call to this function.
2218 */ 1915 */
2219
2220void 1916void
2221set_cheat (object *op) 1917set_cheat (object *op)
2222{ 1918{
2223 SET_FLAG (op, FLAG_WAS_WIZ); 1919 SET_FLAG (op, FLAG_WAS_WIZ);
2224 flag_inv (op, FLAG_WAS_WIZ); 1920 flag_inv (op, FLAG_WAS_WIZ);
… …
2243 * because arch_blocked (now ob_blocked) needs to know the movement type 1939 * because arch_blocked (now ob_blocked) needs to know the movement type
2244 * to know if the space in question will block the object. We can't use 1940 * to know if the space in question will block the object. We can't use
2245 * the archetype because that isn't correct if the monster has been 1941 * the archetype because that isn't correct if the monster has been
2246 * customized, changed states, etc. 1942 * customized, changed states, etc.
2247 */ 1943 */
2248
2249int 1944int
2250find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1945find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2251{ 1946{
2252 int
2253 i,
2254 index = 0, flag; 1947 int index = 0, flag;
2255 static int
2256 altern[SIZEOFFREE]; 1948 int altern[SIZEOFFREE];
2257 1949
2258 for (i = start; i < stop; i++) 1950 for (int i = start; i < stop; i++)
2259 { 1951 {
2260 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1952 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2261 if (!flag) 1953 if (!flag)
2262 altern[index++] = i; 1954 altern [index++] = i;
2263 1955
2264 /* Basically, if we find a wall on a space, we cut down the search size. 1956 /* Basically, if we find a wall on a space, we cut down the search size.
2265 * In this way, we won't return spaces that are on another side of a wall. 1957 * In this way, we won't return spaces that are on another side of a wall.
2266 * This mostly work, but it cuts down the search size in all directions - 1958 * This mostly work, but it cuts down the search size in all directions -
2267 * if the space being examined only has a wall to the north and empty 1959 * if the space being examined only has a wall to the north and empty
2268 * spaces in all the other directions, this will reduce the search space 1960 * spaces in all the other directions, this will reduce the search space
2269 * to only the spaces immediately surrounding the target area, and 1961 * to only the spaces immediately surrounding the target area, and
2270 * won't look 2 spaces south of the target space. 1962 * won't look 2 spaces south of the target space.
2271 */ 1963 */
2272 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1964 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2273 stop = maxfree[i]; 1965 stop = maxfree[i];
2274 } 1966 }
1967
2275 if (!index) 1968 if (!index)
2276 return -1; 1969 return -1;
1970
2277 return altern[RANDOM () % index]; 1971 return altern[RANDOM () % index];
2278} 1972}
2279 1973
2280/* 1974/*
2281 * find_first_free_spot(archetype, mapstruct, x, y) works like 1975 * find_first_free_spot(archetype, maptile, x, y) works like
2282 * find_free_spot(), but it will search max number of squares. 1976 * find_free_spot(), but it will search max number of squares.
2283 * But it will return the first available spot, not a random choice. 1977 * But it will return the first available spot, not a random choice.
2284 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1978 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2285 */ 1979 */
2286
2287int 1980int
2288find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 1981find_first_free_spot (const object *ob, maptile *m, int x, int y)
2289{ 1982{
2290 int
2291 i;
2292
2293 for (i = 0; i < SIZEOFFREE; i++) 1983 for (int i = 0; i < SIZEOFFREE; i++)
2294 {
2295 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1984 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2296 return i; 1985 return i;
2297 } 1986
2298 return -1; 1987 return -1;
2299} 1988}
2300 1989
2301/* 1990/*
2302 * The function permute(arr, begin, end) randomly reorders the array 1991 * The function permute(arr, begin, end) randomly reorders the array
2303 * arr[begin..end-1]. 1992 * arr[begin..end-1].
1993 * now uses a fisher-yates shuffle, old permute was broken
2304 */ 1994 */
2305static void 1995static void
2306permute (int *arr, int begin, int end) 1996permute (int *arr, int begin, int end)
2307{ 1997{
2308 int 1998 arr += begin;
2309 i,
2310 j,
2311 tmp,
2312 len;
2313
2314 len = end - begin; 1999 end -= begin;
2315 for (i = begin; i < end; i++)
2316 {
2317 j = begin + RANDOM () % len;
2318 2000
2319 tmp = arr[i]; 2001 while (--end)
2320 arr[i] = arr[j]; 2002 swap (arr [end], arr [RANDOM () % (end + 1)]);
2321 arr[j] = tmp;
2322 }
2323} 2003}
2324 2004
2325/* new function to make monster searching more efficient, and effective! 2005/* new function to make monster searching more efficient, and effective!
2326 * This basically returns a randomized array (in the passed pointer) of 2006 * This basically returns a randomized array (in the passed pointer) of
2327 * the spaces to find monsters. In this way, it won't always look for 2007 * the spaces to find monsters. In this way, it won't always look for
… …
2330 * the 3x3 area will be searched, just not in a predictable order. 2010 * the 3x3 area will be searched, just not in a predictable order.
2331 */ 2011 */
2332void 2012void
2333get_search_arr (int *search_arr) 2013get_search_arr (int *search_arr)
2334{ 2014{
2335 int 2015 int i;
2336 i;
2337 2016
2338 for (i = 0; i < SIZEOFFREE; i++) 2017 for (i = 0; i < SIZEOFFREE; i++)
2339 {
2340 search_arr[i] = i; 2018 search_arr[i] = i;
2341 }
2342 2019
2343 permute (search_arr, 1, SIZEOFFREE1 + 1); 2020 permute (search_arr, 1, SIZEOFFREE1 + 1);
2344 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2021 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2345 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2022 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2346} 2023}
… …
2355 * Perhaps incorrectly, but I'm making the assumption that exclude 2032 * Perhaps incorrectly, but I'm making the assumption that exclude
2356 * is actually want is going to try and move there. We need this info 2033 * is actually want is going to try and move there. We need this info
2357 * because we have to know what movement the thing looking to move 2034 * because we have to know what movement the thing looking to move
2358 * there is capable of. 2035 * there is capable of.
2359 */ 2036 */
2360
2361int 2037int
2362find_dir (mapstruct *m, int x, int y, object *exclude) 2038find_dir (maptile *m, int x, int y, object *exclude)
2363{ 2039{
2364 int
2365 i,
2366 max = SIZEOFFREE, mflags; 2040 int i, max = SIZEOFFREE, mflags;
2367 2041
2368 sint16 nx, ny; 2042 sint16 nx, ny;
2369 object * 2043 object *tmp;
2370 tmp; 2044 maptile *mp;
2371 mapstruct *
2372 mp;
2373 2045
2374 MoveType blocked, move_type; 2046 MoveType blocked, move_type;
2375 2047
2376 if (exclude && exclude->head) 2048 if (exclude && exclude->head)
2377 { 2049 {
… …
2389 mp = m; 2061 mp = m;
2390 nx = x + freearr_x[i]; 2062 nx = x + freearr_x[i];
2391 ny = y + freearr_y[i]; 2063 ny = y + freearr_y[i];
2392 2064
2393 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2065 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2066
2394 if (mflags & P_OUT_OF_MAP) 2067 if (mflags & P_OUT_OF_MAP)
2395 {
2396 max = maxfree[i]; 2068 max = maxfree[i];
2397 }
2398 else 2069 else
2399 { 2070 {
2400 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2071 mapspace &ms = mp->at (nx, ny);
2072
2073 blocked = ms.move_block;
2401 2074
2402 if ((move_type & blocked) == move_type) 2075 if ((move_type & blocked) == move_type)
2403 {
2404 max = maxfree[i]; 2076 max = maxfree[i];
2405 }
2406 else if (mflags & P_IS_ALIVE) 2077 else if (mflags & P_IS_ALIVE)
2407 { 2078 {
2408 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2079 for (tmp = ms.bot; tmp; tmp = tmp->above)
2409 { 2080 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2410 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2081 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2411 {
2412 break; 2082 break;
2413 } 2083
2414 }
2415 if (tmp) 2084 if (tmp)
2416 {
2417 return freedir[i]; 2085 return freedir[i];
2418 }
2419 } 2086 }
2420 } 2087 }
2421 } 2088 }
2089
2422 return 0; 2090 return 0;
2423} 2091}
2424 2092
2425/* 2093/*
2426 * distance(object 1, object 2) will return the square of the 2094 * distance(object 1, object 2) will return the square of the
2427 * distance between the two given objects. 2095 * distance between the two given objects.
2428 */ 2096 */
2429
2430int 2097int
2431distance (const object *ob1, const object *ob2) 2098distance (const object *ob1, const object *ob2)
2432{ 2099{
2433 int
2434 i;
2435
2436 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2100 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2437 return i;
2438} 2101}
2439 2102
2440/* 2103/*
2441 * find_dir_2(delta-x,delta-y) will return a direction in which 2104 * find_dir_2(delta-x,delta-y) will return a direction in which
2442 * an object which has subtracted the x and y coordinates of another 2105 * an object which has subtracted the x and y coordinates of another
2443 * object, needs to travel toward it. 2106 * object, needs to travel toward it.
2444 */ 2107 */
2445
2446int 2108int
2447find_dir_2 (int x, int y) 2109find_dir_2 (int x, int y)
2448{ 2110{
2449 int 2111 int q;
2450 q;
2451 2112
2452 if (y) 2113 if (y)
2453 q = x * 100 / y; 2114 q = x * 100 / y;
2454 else if (x) 2115 else if (x)
2455 q = -300 * x; 2116 q = -300 * x;
… …
2480 2141
2481 return 3; 2142 return 3;
2482} 2143}
2483 2144
2484/* 2145/*
2485 * absdir(int): Returns a number between 1 and 8, which represent
2486 * the "absolute" direction of a number (it actually takes care of
2487 * "overflow" in previous calculations of a direction).
2488 */
2489
2490int
2491absdir (int d)
2492{
2493 while (d < 1)
2494 d += 8;
2495 while (d > 8)
2496 d -= 8;
2497 return d;
2498}
2499
2500/*
2501 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2146 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2502 * between two directions (which are expected to be absolute (see absdir()) 2147 * between two directions (which are expected to be absolute (see absdir())
2503 */ 2148 */
2504
2505int 2149int
2506dirdiff (int dir1, int dir2) 2150dirdiff (int dir1, int dir2)
2507{ 2151{
2508 int 2152 int d;
2509 d;
2510 2153
2511 d = abs (dir1 - dir2); 2154 d = abs (dir1 - dir2);
2512 if (d > 4) 2155 if (d > 4)
2513 d = 8 - d; 2156 d = 8 - d;
2157
2514 return d; 2158 return d;
2515} 2159}
2516 2160
2517/* peterm: 2161/* peterm:
2518 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2162 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2521 * This basically means that if direction is 15, then it could either go 2165 * This basically means that if direction is 15, then it could either go
2522 * direction 4, 14, or 16 to get back to where we are. 2166 * direction 4, 14, or 16 to get back to where we are.
2523 * Moved from spell_util.c to object.c with the other related direction 2167 * Moved from spell_util.c to object.c with the other related direction
2524 * functions. 2168 * functions.
2525 */ 2169 */
2526
2527int
2528 reduction_dir[SIZEOFFREE][3] = { 2170int reduction_dir[SIZEOFFREE][3] = {
2529 {0, 0, 0}, /* 0 */ 2171 {0, 0, 0}, /* 0 */
2530 {0, 0, 0}, /* 1 */ 2172 {0, 0, 0}, /* 1 */
2531 {0, 0, 0}, /* 2 */ 2173 {0, 0, 0}, /* 2 */
2532 {0, 0, 0}, /* 3 */ 2174 {0, 0, 0}, /* 3 */
2533 {0, 0, 0}, /* 4 */ 2175 {0, 0, 0}, /* 4 */
… …
2581 * find a path to that monster that we found. If not, 2223 * find a path to that monster that we found. If not,
2582 * we don't bother going toward it. Returns 1 if we 2224 * we don't bother going toward it. Returns 1 if we
2583 * can see a direct way to get it 2225 * can see a direct way to get it
2584 * Modified to be map tile aware -.MSW 2226 * Modified to be map tile aware -.MSW
2585 */ 2227 */
2586
2587
2588int 2228int
2589can_see_monsterP (mapstruct *m, int x, int y, int dir) 2229can_see_monsterP (maptile *m, int x, int y, int dir)
2590{ 2230{
2591 sint16 dx, dy; 2231 sint16 dx, dy;
2592 int
2593 mflags; 2232 int mflags;
2594 2233
2595 if (dir < 0) 2234 if (dir < 0)
2596 return 0; /* exit condition: invalid direction */ 2235 return 0; /* exit condition: invalid direction */
2597 2236
2598 dx = x + freearr_x[dir]; 2237 dx = x + freearr_x[dir];
… …
2611 return 0; 2250 return 0;
2612 2251
2613 /* yes, can see. */ 2252 /* yes, can see. */
2614 if (dir < 9) 2253 if (dir < 9)
2615 return 1; 2254 return 1;
2255
2616 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2256 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2617 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2257 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2258 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2618} 2259}
2619
2620
2621 2260
2622/* 2261/*
2623 * can_pick(picker, item): finds out if an object is possible to be 2262 * can_pick(picker, item): finds out if an object is possible to be
2624 * picked up by the picker. Returnes 1 if it can be 2263 * picked up by the picker. Returnes 1 if it can be
2625 * picked up, otherwise 0. 2264 * picked up, otherwise 0.
… …
2636 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2275 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2637 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2276 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2638 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2277 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2639} 2278}
2640 2279
2641
2642/* 2280/*
2643 * create clone from object to another 2281 * create clone from object to another
2644 */ 2282 */
2645object * 2283object *
2646object_create_clone (object *asrc) 2284object_create_clone (object *asrc)
2647{ 2285{
2648 object *
2649 dst = NULL, *tmp, *src, *part, *prev, *item; 2286 object *dst = 0, *tmp, *src, *part, *prev, *item;
2650 2287
2651 if (!asrc) 2288 if (!asrc)
2652 return NULL; 2289 return 0;
2290
2653 src = asrc; 2291 src = asrc;
2654 if (src->head) 2292 if (src->head)
2655 src = src->head; 2293 src = src->head;
2656 2294
2657 prev = NULL; 2295 prev = 0;
2658 for (part = src; part; part = part->more) 2296 for (part = src; part; part = part->more)
2659 { 2297 {
2660 tmp = get_object (); 2298 tmp = part->clone ();
2661 copy_object (part, tmp);
2662 tmp->x -= src->x; 2299 tmp->x -= src->x;
2663 tmp->y -= src->y; 2300 tmp->y -= src->y;
2301
2664 if (!part->head) 2302 if (!part->head)
2665 { 2303 {
2666 dst = tmp; 2304 dst = tmp;
2667 tmp->head = NULL; 2305 tmp->head = 0;
2668 } 2306 }
2669 else 2307 else
2670 {
2671 tmp->head = dst; 2308 tmp->head = dst;
2672 } 2309
2673 tmp->more = NULL; 2310 tmp->more = 0;
2311
2674 if (prev) 2312 if (prev)
2675 prev->more = tmp; 2313 prev->more = tmp;
2314
2676 prev = tmp; 2315 prev = tmp;
2677 } 2316 }
2678 2317
2679 /*** copy inventory ***/
2680 for (item = src->inv; item; item = item->below) 2318 for (item = src->inv; item; item = item->below)
2681 {
2682 (void) insert_ob_in_ob (object_create_clone (item), dst); 2319 insert_ob_in_ob (object_create_clone (item), dst);
2683 }
2684 2320
2685 return dst; 2321 return dst;
2686} 2322}
2687 2323
2688/* return true if the object was destroyed, 0 otherwise */
2689int
2690was_destroyed (const object *op, tag_t old_tag)
2691{
2692 /* checking for FLAG_FREED isn't necessary, but makes this function more
2693 * robust */
2694 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2695}
2696
2697/* GROS - Creates an object using a string representing its content. */ 2324/* GROS - Creates an object using a string representing its content. */
2698
2699/* Basically, we save the content of the string to a temp file, then call */ 2325/* Basically, we save the content of the string to a temp file, then call */
2700
2701/* load_object on it. I admit it is a highly inefficient way to make things, */ 2326/* load_object on it. I admit it is a highly inefficient way to make things, */
2702
2703/* but it was simple to make and allows reusing the load_object function. */ 2327/* but it was simple to make and allows reusing the load_object function. */
2704
2705/* Remember not to use load_object_str in a time-critical situation. */ 2328/* Remember not to use load_object_str in a time-critical situation. */
2706
2707/* Also remember that multiparts objects are not supported for now. */ 2329/* Also remember that multiparts objects are not supported for now. */
2708
2709object * 2330object *
2710load_object_str (const char *obstr) 2331load_object_str (const char *obstr)
2711{ 2332{
2712 object * 2333 object *op;
2713 op;
2714 char
2715 filename[MAX_BUF]; 2334 char filename[MAX_BUF];
2716 2335
2717 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2336 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2718 2337
2719 FILE *
2720 tempfile = fopen (filename, "w"); 2338 FILE *tempfile = fopen (filename, "w");
2721 2339
2722 if (tempfile == NULL) 2340 if (tempfile == NULL)
2723 { 2341 {
2724 LOG (llevError, "Error - Unable to access load object temp file\n"); 2342 LOG (llevError, "Error - Unable to access load object temp file\n");
2725 return NULL; 2343 return NULL;
2726 } 2344 }
2727 2345
2728 fprintf (tempfile, obstr); 2346 fprintf (tempfile, obstr);
2729 fclose (tempfile); 2347 fclose (tempfile);
2730 2348
2731 op = get_object (); 2349 op = object::create ();
2732 2350
2733 object_thawer thawer (filename); 2351 object_thawer thawer (filename);
2734 2352
2735 if (thawer) 2353 if (thawer)
2736 load_object (thawer, op, 0); 2354 load_object (thawer, op, 0);
… …
2746 * returns NULL if no match. 2364 * returns NULL if no match.
2747 */ 2365 */
2748object * 2366object *
2749find_obj_by_type_subtype (const object *who, int type, int subtype) 2367find_obj_by_type_subtype (const object *who, int type, int subtype)
2750{ 2368{
2751 object *
2752 tmp;
2753
2754 for (tmp = who->inv; tmp; tmp = tmp->below) 2369 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2755 if (tmp->type == type && tmp->subtype == subtype) 2370 if (tmp->type == type && tmp->subtype == subtype)
2756 return tmp; 2371 return tmp;
2757 2372
2758 return NULL; 2373 return 0;
2759} 2374}
2760 2375
2761/* If ob has a field named key, return the link from the list, 2376/* If ob has a field named key, return the link from the list,
2762 * otherwise return NULL. 2377 * otherwise return NULL.
2763 * 2378 *
… …
2765 * do the desired thing. 2380 * do the desired thing.
2766 */ 2381 */
2767key_value * 2382key_value *
2768get_ob_key_link (const object *ob, const char *key) 2383get_ob_key_link (const object *ob, const char *key)
2769{ 2384{
2770 key_value *
2771 link;
2772
2773 for (link = ob->key_values; link != NULL; link = link->next) 2385 for (key_value *link = ob->key_values; link; link = link->next)
2774 {
2775 if (link->key == key) 2386 if (link->key == key)
2776 {
2777 return link; 2387 return link;
2778 }
2779 }
2780 2388
2781 return NULL; 2389 return 0;
2782} 2390}
2783 2391
2784/* 2392/*
2785 * Returns the value of op has an extra_field for key, or NULL. 2393 * Returns the value of op has an extra_field for key, or NULL.
2786 * 2394 *
… …
2826 * Returns TRUE on success. 2434 * Returns TRUE on success.
2827 */ 2435 */
2828int 2436int
2829set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2437set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2830{ 2438{
2831 key_value *
2832 field = NULL, *last = NULL; 2439 key_value *field = NULL, *last = NULL;
2833 2440
2834 for (field = op->key_values; field != NULL; field = field->next) 2441 for (field = op->key_values; field != NULL; field = field->next)
2835 { 2442 {
2836 if (field->key != canonical_key) 2443 if (field->key != canonical_key)
2837 { 2444 {
… …
2865 /* IF we get here, key doesn't exist */ 2472 /* IF we get here, key doesn't exist */
2866 2473
2867 /* No field, we'll have to add it. */ 2474 /* No field, we'll have to add it. */
2868 2475
2869 if (!add_key) 2476 if (!add_key)
2870 {
2871 return FALSE; 2477 return FALSE;
2872 } 2478
2873 /* There isn't any good reason to store a null 2479 /* There isn't any good reason to store a null
2874 * value in the key/value list. If the archetype has 2480 * value in the key/value list. If the archetype has
2875 * this key, then we should also have it, so shouldn't 2481 * this key, then we should also have it, so shouldn't
2876 * be here. If user wants to store empty strings, 2482 * be here. If user wants to store empty strings,
2877 * should pass in "" 2483 * should pass in ""
… …
2926 } 2532 }
2927 else 2533 else
2928 item = item->env; 2534 item = item->env;
2929} 2535}
2930 2536
2537
2538const char *
2539object::flag_desc (char *desc, int len) const
2540{
2541 char *p = desc;
2542 bool first = true;
2543
2544 *p = 0;
2545
2546 for (int i = 0; i < NUM_FLAGS; i++)
2547 {
2548 if (len <= 10) // magic constant!
2549 {
2550 snprintf (p, len, ",...");
2551 break;
2552 }
2553
2554 if (flag [i])
2555 {
2556 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2557 len -= cnt;
2558 p += cnt;
2559 first = false;
2560 }
2561 }
2562
2563 return desc;
2564}
2565
2931// return a suitable string describing an objetc in enough detail to find it 2566// return a suitable string describing an object in enough detail to find it
2932const char * 2567const char *
2933object::debug_desc (char *info) const 2568object::debug_desc (char *info) const
2934{ 2569{
2570 char flagdesc[512];
2935 char info2[256 * 3]; 2571 char info2[256 * 4];
2936 char *p = info; 2572 char *p = info;
2937 2573
2938 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2574 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2939 count, 2575 count, uuid.seq,
2940 &name, 2576 &name,
2941 title ? " " : "", 2577 title ? "\",title:\"" : "",
2942 title ? (const char *)title : ""); 2578 title ? (const char *)title : "",
2579 flag_desc (flagdesc, 512), type);
2943 2580
2944 if (env) 2581 if (env)
2945 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2582 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2946 2583
2947 if (map) 2584 if (map)
2948 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2585 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2949 2586
2950 return info; 2587 return info;
2951} 2588}
2952 2589
2953const char * 2590const char *
2954object::debug_desc () const 2591object::debug_desc () const
2955{ 2592{
2956 static char info[256 * 3]; 2593 static char info[256 * 4];
2957 return debug_desc (info); 2594 return debug_desc (info);
2958} 2595}
2959 2596
2597const char *
2598object::debug_desc2 () const
2599{
2600 static char info[256 * 4];
2601 return debug_desc (info);
2602}
2603

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines