ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.44 by root, Thu Sep 14 17:29:27 2006 UTC vs.
Revision 1.106 by root, Wed Jan 3 20:08:04 2007 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
4 3
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
… …
17 16
18 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 20
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 22*/
24 23
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 26 variable. */
… …
31#include <sys/uio.h> 30#include <sys/uio.h>
32#include <object.h> 31#include <object.h>
33#include <funcpoint.h> 32#include <funcpoint.h>
34#include <loader.h> 33#include <loader.h>
35 34
35#include <bitset>
36
36int nrofallocobjects = 0; 37int nrofallocobjects = 0;
37static UUID uuid; 38static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
39 40
40object *objects; /* Pointer to the list of used objects */
41object *active_objects; /* List of active objects that need to be processed */ 41object *active_objects; /* List of active objects that need to be processed */
42 42
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 45};
… …
106 _exit (1); 106 _exit (1);
107 } 107 }
108 108
109 uuid.seq = uid; 109 uuid.seq = uid;
110 write_uuid (); 110 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 112 fclose (fp);
113} 113}
114 114
115UUID 115UUID
116gen_uuid () 116gen_uuid ()
… …
141 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
143 */ 143 */
144 144
145 /* For each field in wants, */ 145 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 147 {
148 key_value *has_field; 148 key_value *has_field;
149 149
150 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
… …
185 * 185 *
186 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
189 * 189 *
190 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
191 * 191 *
192 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
193 * check weight 193 * check weight
194 */ 194 */
195
196bool object::can_merge (object *ob1, object *ob2) 195bool object::can_merge_slow (object *ob1, object *ob2)
197{ 196{
198 /* A couple quicksanity checks */ 197 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 198 if (ob1 == ob2
199 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value
202 || ob1->name != ob2->name)
200 return 0; 203 return 0;
201 204
202 if (ob1->speed != ob2->speed) 205 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 206 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 207 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 208 * used to store nrof).
208 */ 209 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 210 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 220 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 221
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 224
224 225 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 226 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 227 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 228 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 229 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 230 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 233 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 234 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 235 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 236 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 237 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 238 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 239 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 240 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 241 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 242 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 243 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 244 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 245 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 246 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 247 || ob1->move_off != ob2->move_off
248 || ob1->move_slow != ob2->move_slow
249 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 250 return 0;
256 251
257 /* This is really a spellbook check - really, we should 252 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 253 * check all objects in the inventory.
259 */ 254 */
… …
262 /* if one object has inventory but the other doesn't, not equiv */ 257 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 258 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 259 return 0;
265 260
266 /* Now check to see if the two inventory objects could merge */ 261 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 262 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 263 return 0;
269 264
270 /* inventory ok - still need to check rest of this object to see 265 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 266 * if it is valid.
272 */ 267 */
… …
281 276
282 /* Note sure why the following is the case - either the object has to 277 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 278 * be animated or have a very low speed. Is this an attempted monster
284 * check? 279 * check?
285 */ 280 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 281 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 282 return 0;
288 283
289 switch (ob1->type) 284 switch (ob1->type)
290 { 285 {
291 case SCROLL: 286 case SCROLL:
… …
356 op = op->env; 351 op = op->env;
357 return op; 352 return op;
358} 353}
359 354
360/* 355/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 356 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 357 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 358 * The result of the dump is stored in the static global errmsg array.
379 */ 359 */
380 360
381void 361char *
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 362dump_object (object *op)
437{ 363{
438 if (op == NULL) 364 if (!op)
439 { 365 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 366
447void 367 object_freezer freezer;
448dump_all_objects (void) 368 save_object (freezer, op, 1);
449{ 369 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 370}
458 371
459/* 372/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 373 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 374 * multi-object 1 which is closest to the second object.
… …
481 */ 394 */
482 395
483object * 396object *
484find_object (tag_t i) 397find_object (tag_t i)
485{ 398{
486 object *op; 399 for (object *op = object::first; op; op = op->next)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 400 if (op->count == i)
490 break; 401 return op;
402
491 return op; 403 return 0;
492} 404}
493 405
494/* 406/*
495 * Returns the first object which has a name equal to the argument. 407 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 408 * Used only by the patch command, but not all that useful.
… …
501find_object_name (const char *str) 413find_object_name (const char *str)
502{ 414{
503 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
504 object *op; 416 object *op;
505 417
506 for (op = objects; op != NULL; op = op->next) 418 for (op = object::first; op != NULL; op = op->next)
507 if (op->name == str_) 419 if (op->name == str_)
508 break; 420 break;
509 421
510 return op; 422 return op;
511} 423}
… …
554 } 466 }
555 467
556 op->key_values = 0; 468 op->key_values = 0;
557} 469}
558 470
559void object::clear ()
560{
561 attachable_base::clear ();
562
563 free_key_values (this);
564
565 owner = 0;
566 name = 0;
567 name_pl = 0;
568 title = 0;
569 race = 0;
570 slaying = 0;
571 skill = 0;
572 msg = 0;
573 lore = 0;
574 custom_name = 0;
575 materialname = 0;
576 contr = 0;
577 below = 0;
578 above = 0;
579 inv = 0;
580 container = 0;
581 env = 0;
582 more = 0;
583 head = 0;
584 map = 0;
585 active_next = 0;
586 active_prev = 0;
587
588 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
589
590 SET_FLAG (this, FLAG_REMOVED);
591
592 /* What is not cleared is next, prev, and count */
593
594 expmul = 1.0;
595 face = blank_face;
596
597 if (settings.casting_time)
598 casting_time = -1;
599}
600
601void object::clone (object *destination)
602{
603 *(object_copy *)destination = *this;
604 *(object_pod *)destination = *this;
605
606 if (self || cb)
607 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
608}
609
610/* 471/*
611 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
612 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
613 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
614 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
615 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
616 * will point at garbage. 477 * will point at garbage.
617 */ 478 */
618void 479void
619copy_object (object *op2, object *op) 480object::copy_to (object *dst)
620{ 481{
621 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
622 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
623 484
624 op2->clone (op); 485 *(object_copy *)dst = *this;
625 486
626 if (is_freed) 487 if (is_freed)
627 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
628 if (is_removed) 490 if (is_removed)
629 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
630 492
631 if (op2->speed < 0) 493 if (speed < 0)
632 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
633 495
634 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
635 if (op2->key_values) 497 if (key_values)
636 { 498 {
637 key_value *tail = 0; 499 key_value *tail = 0;
638 key_value *i; 500 key_value *i;
639 501
640 op->key_values = 0; 502 dst->key_values = 0;
641 503
642 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
643 { 505 {
644 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
645 507
646 new_link->next = 0; 508 new_link->next = 0;
647 new_link->key = i->key; 509 new_link->key = i->key;
648 new_link->value = i->value; 510 new_link->value = i->value;
649 511
650 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
651 if (!op->key_values) 513 if (!dst->key_values)
652 { 514 {
653 op->key_values = new_link; 515 dst->key_values = new_link;
654 tail = new_link; 516 tail = new_link;
655 } 517 }
656 else 518 else
657 { 519 {
658 tail->next = new_link; 520 tail->next = new_link;
659 tail = new_link; 521 tail = new_link;
660 } 522 }
661 } 523 }
662 } 524 }
663 525
664 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
665} 535}
666 536
667/* 537/*
668 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
669 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
670 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
671 */ 541 */
672
673void 542void
674update_turn_face (object *op) 543update_turn_face (object *op)
675{ 544{
676 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
677 return; 546 return;
547
678 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
679 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
680} 550}
681 551
682/* 552/*
683 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
684 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
685 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
686 */ 556 */
687void 557void
688update_ob_speed (object *op) 558object::set_speed (float speed)
689{ 559{
690 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
691
692 /* No reason putting the archetypes objects on the speed list,
693 * since they never really need to be updated.
694 */
695
696 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
697 { 561 {
698 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
699#ifdef MANY_CORES
700 abort ();
701#else
702 op->speed = 0; 563 speed = 0;
703#endif
704 }
705
706 if (arch_init)
707 return;
708
709 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
710 { 564 }
711 /* If already on active list, don't do anything */
712 if (op->active_next || op->active_prev || op == active_objects)
713 return;
714 565
715 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
716 * of the list. */
717 op->active_next = active_objects;
718 567
719 if (op->active_next != NULL) 568 if (has_active_speed ())
720 op->active_next->active_prev = op; 569 activate ();
721
722 active_objects = op;
723 }
724 else 570 else
725 { 571 deactivate ();
726 /* If not on the active list, nothing needs to be done */
727 if (!op->active_next && !op->active_prev && op != active_objects)
728 return;
729
730 if (op->active_prev == NULL)
731 {
732 active_objects = op->active_next;
733
734 if (op->active_next != NULL)
735 op->active_next->active_prev = NULL;
736 }
737 else
738 {
739 op->active_prev->active_next = op->active_next;
740
741 if (op->active_next)
742 op->active_next->active_prev = op->active_prev;
743 }
744
745 op->active_next = NULL;
746 op->active_prev = NULL;
747 }
748} 572}
749 573
750/* This function removes object 'op' from the list of active
751 * objects.
752 * This should only be used for style maps or other such
753 * reference maps where you don't want an object that isn't
754 * in play chewing up cpu time getting processed.
755 * The reverse of this is to call update_ob_speed, which
756 * will do the right thing based on the speed of the object.
757 */
758void
759remove_from_active_list (object *op)
760{
761 /* If not on the active list, nothing needs to be done */
762 if (!op->active_next && !op->active_prev && op != active_objects)
763 return;
764
765 if (op->active_prev == NULL)
766 {
767 active_objects = op->active_next;
768 if (op->active_next != NULL)
769 op->active_next->active_prev = NULL;
770 }
771 else
772 {
773 op->active_prev->active_next = op->active_next;
774 if (op->active_next)
775 op->active_next->active_prev = op->active_prev;
776 }
777 op->active_next = NULL;
778 op->active_prev = NULL;
779}
780
781/* 574/*
782 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
783 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
784 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
785 * invisible object, etc...) 578 * invisible object, etc...)
786 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
787 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
788 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
789 * 582 *
790 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
791 * For example, if the only thing that has changed is the face (due to
792 * an animation), we don't need to call update_position until that actually
793 * comes into view of a player. OTOH, many other things, like addition/removal
794 * of walls or living creatures may need us to update the flags now.
795 * current action are: 584 * current action are:
796 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
797 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
798 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
799 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
800 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
801 */ 590 */
802
803void 591void
804update_object (object *op, int action) 592update_object (object *op, int action)
805{ 593{
806 int update_now = 0, flags;
807 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
808 595
809 if (op == NULL) 596 if (op == NULL)
810 { 597 {
811 /* this should never happen */ 598 /* this should never happen */
812 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
813 return; 600 return;
814 } 601 }
815 602
816 if (op->env != NULL) 603 if (op->env)
817 { 604 {
818 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
819 * to do in this case. 606 * to do in this case.
820 */ 607 */
821 return; 608 return;
… …
826 */ 613 */
827 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
828 return; 615 return;
829 616
830 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
831 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
832 { 619 {
833 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
834#ifdef MANY_CORES 621#ifdef MANY_CORES
835 abort (); 622 abort ();
836#endif 623#endif
837 return; 624 return;
838 } 625 }
839 626
840 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
841 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
842 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
843 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
844 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
845 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
846 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
847 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
848 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
849 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
850 update_now = 1;
851
852 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
853 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
854 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
855 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
856 update_now = 1;
857
858 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
859 update_now = 1;
860
861 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
862 update_now = 1;
863
864 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
865 update_now = 1;
866
867 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
868 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
869
870 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
871 * to have move_allow right now. 644 * to have move_allow right now.
872 */ 645 */
873 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
874 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
875 648 m.flags_ = 0;
876 if ((move_slow | op->move_slow) != move_slow)
877 update_now = 1;
878 } 649 }
879 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
880 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
881 * that is being removed. 652 * that is being removed.
882 */ 653 */
883 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
884 update_now = 1; 655 m.flags_ = 0;
885 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
886 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
887 else 658 else
888 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
889 660
890 if (update_now)
891 {
892 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
893 update_position (op->map, op->x, op->y);
894 }
895
896 if (op->more != NULL) 661 if (op->more)
897 update_object (op->more, action); 662 update_object (op->more, action);
898} 663}
899 664
900static unordered_vector<object *> mortals; 665object *object::first;
901
902void object::free_mortals ()
903{
904 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
905 if ((*i)->refcnt)
906 ++i; // further delay freeing
907 else
908 {
909 delete *i;
910 mortals.erase (i);
911 }
912
913 static int lastmortals = 0;//D
914
915 if (mortals.size() != lastmortals)//D
916 {
917 lastmortals = mortals.size ();//D
918 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
919 }
920}
921 666
922object::object () 667object::object ()
923{ 668{
924 SET_FLAG (this, FLAG_REMOVED); 669 SET_FLAG (this, FLAG_REMOVED);
925 670
… …
936{ 681{
937 count = ++ob_count; 682 count = ++ob_count;
938 uuid = gen_uuid (); 683 uuid = gen_uuid ();
939 684
940 prev = 0; 685 prev = 0;
941 next = objects; 686 next = object::first;
942 687
943 if (objects) 688 if (object::first)
944 objects->prev = this; 689 object::first->prev = this;
945 690
946 objects = this; 691 object::first = this;
947} 692}
948 693
949void object::unlink () 694void object::unlink ()
950{ 695{
951 //count = 0;//D
952 if (!prev && !next) return;//D
953
954 if (this == objects) 696 if (this == object::first)
955 objects = next; 697 object::first = next;
956 698
957 /* Remove this object from the list of used objects */ 699 /* Remove this object from the list of used objects */
958 if (prev) prev->next = next; 700 if (prev) prev->next = next;
959 if (next) next->prev = prev; 701 if (next) next->prev = prev;
960 702
961 prev = 0; 703 prev = 0;
962 next = 0; 704 next = 0;
963} 705}
964 706
707bool
708object::active () const
709{
710 return active_next || active_prev || this == active_objects;
711}
712
713void
714object::activate ()
715{
716 /* If already on active list, don't do anything */
717 if (active ())
718 return;
719
720 if (has_active_speed ())
721 {
722 /* process_events() expects us to insert the object at the beginning
723 * of the list. */
724 active_next = active_objects;
725
726 if (active_next)
727 active_next->active_prev = this;
728
729 active_objects = this;
730 }
731}
732
733void
734object::activate_recursive ()
735{
736 activate ();
737
738 for (object *op = inv; op; op = op->below)
739 op->activate_recursive ();
740}
741
742/* This function removes object 'op' from the list of active
743 * objects.
744 * This should only be used for style maps or other such
745 * reference maps where you don't want an object that isn't
746 * in play chewing up cpu time getting processed.
747 * The reverse of this is to call update_ob_speed, which
748 * will do the right thing based on the speed of the object.
749 */
750void
751object::deactivate ()
752{
753 /* If not on the active list, nothing needs to be done */
754 if (!active ())
755 return;
756
757 if (active_prev == 0)
758 {
759 active_objects = active_next;
760 if (active_next)
761 active_next->active_prev = 0;
762 }
763 else
764 {
765 active_prev->active_next = active_next;
766 if (active_next)
767 active_next->active_prev = active_prev;
768 }
769
770 active_next = 0;
771 active_prev = 0;
772}
773
774void
775object::deactivate_recursive ()
776{
777 for (object *op = inv; op; op = op->below)
778 op->deactivate_recursive ();
779
780 deactivate ();
781}
782
783void
784object::set_flag_inv (int flag, int value)
785{
786 for (object *op = inv; op; op = op->below)
787 {
788 op->flag [flag] = value;
789 op->set_flag_inv (flag, value);
790 }
791}
792
793/*
794 * Remove and free all objects in the inventory of the given object.
795 * object.c ?
796 */
797void
798object::destroy_inv (bool drop_to_ground)
799{
800 // need to check first, because the checks below might segfault
801 // as we might be on an invalid mapspace and crossfire code
802 // is too buggy to ensure that the inventory is empty.
803 // corollary: if you create arrows etc. with stuff in tis inventory,
804 // cf will crash below with off-map x and y
805 if (!inv)
806 return;
807
808 /* Only if the space blocks everything do we not process -
809 * if some form of movement is allowed, let objects
810 * drop on that space.
811 */
812 if (!drop_to_ground
813 || !map
814 || map->in_memory != MAP_IN_MEMORY
815 || ms ().move_block == MOVE_ALL)
816 {
817 while (inv)
818 {
819 inv->destroy_inv (drop_to_ground);
820 inv->destroy ();
821 }
822 }
823 else
824 { /* Put objects in inventory onto this space */
825 while (inv)
826 {
827 object *op = inv;
828
829 if (op->flag [FLAG_STARTEQUIP]
830 || op->flag [FLAG_NO_DROP]
831 || op->type == RUNE
832 || op->type == TRAP
833 || op->flag [FLAG_IS_A_TEMPLATE])
834 op->destroy ();
835 else
836 map->insert (op, x, y);
837 }
838 }
839}
840
965object *object::create () 841object *object::create ()
966{ 842{
967 object *op = new object; 843 object *op = new object;
968 op->link (); 844 op->link ();
969 return op; 845 return op;
970} 846}
971 847
972/* 848void
973 * free_object() frees everything allocated by an object, removes 849object::do_destroy ()
974 * it from the list of used objects, and puts it on the list of
975 * free objects. The IS_FREED() flag is set in the object.
976 * The object must have been removed by remove_ob() first for
977 * this function to succeed.
978 *
979 * If free_inventory is set, free inventory as well. Else drop items in
980 * inventory to the ground.
981 */
982void object::free (bool free_inventory)
983{ 850{
984 if (QUERY_FLAG (this, FLAG_FREED)) 851 if (flag [FLAG_IS_LINKED])
852 remove_button_link (this);
853
854 if (flag [FLAG_FRIENDLY])
855 remove_friendly_object (this);
856
857 if (!flag [FLAG_REMOVED])
858 remove ();
859
860 if (flag [FLAG_FREED])
985 return; 861 return;
986 862
987 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 863 set_speed (0);
988 remove_friendly_object (this);
989 864
990 if (!QUERY_FLAG (this, FLAG_REMOVED)) 865 flag [FLAG_FREED] = 1;
991 remove_ob (this);
992 866
993 SET_FLAG (this, FLAG_FREED); 867 attachable::do_destroy ();
868
869 destroy_inv (true);
870 unlink ();
871
872 // hack to ensure that freed objects still have a valid map
873 {
874 static maptile *freed_map; // freed objects are moved here to avoid crashes
875
876 if (!freed_map)
877 {
878 freed_map = new maptile;
879
880 freed_map->name = "/internal/freed_objects_map";
881 freed_map->width = 3;
882 freed_map->height = 3;
883
884 freed_map->alloc ();
885 freed_map->in_memory = MAP_IN_MEMORY;
886 }
887
888 map = freed_map;
889 x = 1;
890 y = 1;
891 }
892
893 head = 0;
994 894
995 if (more) 895 if (more)
996 { 896 {
997 more->free (free_inventory); 897 more->destroy ();
998 more = 0; 898 more = 0;
999 }
1000
1001 if (inv)
1002 {
1003 /* Only if the space blocks everything do we not process -
1004 * if some form of movement is allowed, let objects
1005 * drop on that space.
1006 */
1007 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1008 {
1009 object *op = inv;
1010
1011 while (op)
1012 {
1013 object *tmp = op->below;
1014 op->free (free_inventory);
1015 op = tmp;
1016 }
1017 }
1018 else
1019 { /* Put objects in inventory onto this space */
1020 object *op = inv;
1021
1022 while (op)
1023 {
1024 object *tmp = op->below;
1025
1026 remove_ob (op);
1027
1028 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1029 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1030 free_object (op);
1031 else
1032 {
1033 op->x = x;
1034 op->y = y;
1035 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1036 }
1037
1038 op = tmp;
1039 }
1040 }
1041 } 899 }
1042 900
1043 // clear those pointers that likely might have circular references to us 901 // clear those pointers that likely might have circular references to us
1044 owner = 0; 902 owner = 0;
1045 enemy = 0; 903 enemy = 0;
1046 attacked_by = 0; 904 attacked_by = 0;
1047 905
1048 /* Remove object from the active list */ 906 // only relevant for players(?), but make sure of it anyways
1049 speed = 0; 907 contr = 0;
1050 update_ob_speed (this); 908}
1051 909
1052 unlink (); 910void
911object::destroy (bool destroy_inventory)
912{
913 if (destroyed ())
914 return;
1053 915
1054 mortals.push_back (this); 916 if (destroy_inventory)
917 destroy_inv (false);
918
919 attachable::destroy ();
1055} 920}
1056 921
1057/* 922/*
1058 * sub_weight() recursively (outwards) subtracts a number from the 923 * sub_weight() recursively (outwards) subtracts a number from the
1059 * weight of an object (and what is carried by it's environment(s)). 924 * weight of an object (and what is carried by it's environment(s)).
1060 */ 925 */
1061
1062void 926void
1063sub_weight (object *op, signed long weight) 927sub_weight (object *op, signed long weight)
1064{ 928{
1065 while (op != NULL) 929 while (op != NULL)
1066 { 930 {
1067 if (op->type == CONTAINER) 931 if (op->type == CONTAINER)
1068 {
1069 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 932 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1070 } 933
1071 op->carrying -= weight; 934 op->carrying -= weight;
1072 op = op->env; 935 op = op->env;
1073 } 936 }
1074} 937}
1075 938
1076/* remove_ob(op): 939/* op->remove ():
1077 * This function removes the object op from the linked list of objects 940 * This function removes the object op from the linked list of objects
1078 * which it is currently tied to. When this function is done, the 941 * which it is currently tied to. When this function is done, the
1079 * object will have no environment. If the object previously had an 942 * object will have no environment. If the object previously had an
1080 * environment, the x and y coordinates will be updated to 943 * environment, the x and y coordinates will be updated to
1081 * the previous environment. 944 * the previous environment.
1082 * Beware: This function is called from the editor as well! 945 * Beware: This function is called from the editor as well!
1083 */ 946 */
1084
1085void 947void
1086remove_ob (object *op) 948object::remove ()
1087{ 949{
950 object *tmp, *last = 0;
1088 object * 951 object *otmp;
1089 tmp, *
1090 last = NULL;
1091 object *
1092 otmp;
1093 952
1094 tag_t
1095 tag;
1096 int
1097 check_walk_off;
1098 mapstruct *
1099 m;
1100
1101 sint16
1102 x,
1103 y;
1104
1105 if (QUERY_FLAG (op, FLAG_REMOVED)) 953 if (QUERY_FLAG (this, FLAG_REMOVED))
1106 return; 954 return;
1107 955
1108 SET_FLAG (op, FLAG_REMOVED); 956 SET_FLAG (this, FLAG_REMOVED);
957 INVOKE_OBJECT (REMOVE, this);
1109 958
1110 if (op->more != NULL) 959 if (more)
1111 remove_ob (op->more); 960 more->remove ();
1112 961
1113 /* 962 /*
1114 * In this case, the object to be removed is in someones 963 * In this case, the object to be removed is in someones
1115 * inventory. 964 * inventory.
1116 */ 965 */
1117 if (op->env != NULL) 966 if (env)
1118 { 967 {
1119 if (op->nrof) 968 if (nrof)
1120 sub_weight (op->env, op->weight * op->nrof); 969 sub_weight (env, weight * nrof);
1121 else 970 else
1122 sub_weight (op->env, op->weight + op->carrying); 971 sub_weight (env, weight + carrying);
1123 972
1124 /* NO_FIX_PLAYER is set when a great many changes are being 973 /* NO_FIX_PLAYER is set when a great many changes are being
1125 * made to players inventory. If set, avoiding the call 974 * made to players inventory. If set, avoiding the call
1126 * to save cpu time. 975 * to save cpu time.
1127 */ 976 */
1128 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 977 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1129 fix_player (otmp); 978 otmp->update_stats ();
1130 979
1131 if (op->above != NULL) 980 if (above)
1132 op->above->below = op->below; 981 above->below = below;
1133 else 982 else
1134 op->env->inv = op->below; 983 env->inv = below;
1135 984
1136 if (op->below != NULL) 985 if (below)
1137 op->below->above = op->above; 986 below->above = above;
1138 987
1139 /* we set up values so that it could be inserted into 988 /* we set up values so that it could be inserted into
1140 * the map, but we don't actually do that - it is up 989 * the map, but we don't actually do that - it is up
1141 * to the caller to decide what we want to do. 990 * to the caller to decide what we want to do.
1142 */ 991 */
1143 op->x = op->env->x, op->y = op->env->y; 992 x = env->x, y = env->y;
1144 op->map = op->env->map; 993 map = env->map;
1145 op->above = NULL, op->below = NULL; 994 above = 0, below = 0;
1146 op->env = NULL; 995 env = 0;
1147 } 996 }
1148 else if (op->map) 997 else if (map)
1149 { 998 {
1150 x = op->x; 999 if (type == PLAYER)
1151 y = op->y;
1152 m = get_map_from_coord (op->map, &x, &y);
1153
1154 if (!m)
1155 {
1156 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1157 op->map->path, op->x, op->y);
1158 /* in old days, we used to set x and y to 0 and continue.
1159 * it seems if we get into this case, something is probablye
1160 * screwed up and should be fixed.
1161 */
1162 abort ();
1163 } 1000 {
1164 1001 --map->players;
1165 if (op->map != m) 1002 map->touch ();
1166 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1167 op->map->path, m->path, op->x, op->y, x, y);
1168
1169 /* Re did the following section of code - it looks like it had
1170 * lots of logic for things we no longer care about
1171 */ 1003 }
1004
1005 map->dirty = true;
1172 1006
1173 /* link the object above us */ 1007 /* link the object above us */
1174 if (op->above) 1008 if (above)
1175 op->above->below = op->below; 1009 above->below = below;
1176 else 1010 else
1177 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1011 map->at (x, y).top = below; /* we were top, set new top */
1178 1012
1179 /* Relink the object below us, if there is one */ 1013 /* Relink the object below us, if there is one */
1180 if (op->below) 1014 if (below)
1181 op->below->above = op->above; 1015 below->above = above;
1182 else 1016 else
1183 { 1017 {
1184 /* Nothing below, which means we need to relink map object for this space 1018 /* Nothing below, which means we need to relink map object for this space
1185 * use translated coordinates in case some oddness with map tiling is 1019 * use translated coordinates in case some oddness with map tiling is
1186 * evident 1020 * evident
1187 */ 1021 */
1188 if (GET_MAP_OB (m, x, y) != op) 1022 if (GET_MAP_OB (map, x, y) != this)
1189 { 1023 {
1190 dump_object (op); 1024 char *dump = dump_object (this);
1191 LOG (llevError, 1025 LOG (llevError,
1192 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1026 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1027 free (dump);
1193 dump_object (GET_MAP_OB (m, x, y)); 1028 dump = dump_object (GET_MAP_OB (map, x, y));
1194 LOG (llevError, "%s\n", errmsg); 1029 LOG (llevError, "%s\n", dump);
1030 free (dump);
1195 } 1031 }
1196 1032
1197 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1033 map->at (x, y).bot = above; /* goes on above it. */
1198 } 1034 }
1199 1035
1200 op->above = 0; 1036 above = 0;
1201 op->below = 0; 1037 below = 0;
1202 1038
1203 if (op->map->in_memory == MAP_SAVING) 1039 if (map->in_memory == MAP_SAVING)
1204 return; 1040 return;
1205 1041
1206 tag = op->count; 1042 int check_walk_off = !flag [FLAG_NO_APPLY];
1207 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1208 1043
1209 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1044 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1210 { 1045 {
1211 /* No point updating the players look faces if he is the object 1046 /* No point updating the players look faces if he is the object
1212 * being removed. 1047 * being removed.
1213 */ 1048 */
1214 1049
1215 if (tmp->type == PLAYER && tmp != op) 1050 if (tmp->type == PLAYER && tmp != this)
1216 { 1051 {
1217 /* If a container that the player is currently using somehow gets 1052 /* If a container that the player is currently using somehow gets
1218 * removed (most likely destroyed), update the player view 1053 * removed (most likely destroyed), update the player view
1219 * appropriately. 1054 * appropriately.
1220 */ 1055 */
1221 if (tmp->container == op) 1056 if (tmp->container == this)
1222 { 1057 {
1223 CLEAR_FLAG (op, FLAG_APPLIED); 1058 flag [FLAG_APPLIED] = 0;
1224 tmp->container = NULL; 1059 tmp->container = 0;
1225 } 1060 }
1226 1061
1227 tmp->contr->socket.update_look = 1; 1062 if (tmp->contr->ns)
1063 tmp->contr->ns->floorbox_update ();
1228 } 1064 }
1229 1065
1230 /* See if player moving off should effect something */ 1066 /* See if object moving off should effect something */
1231 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1067 if (check_walk_off
1068 && ((move_type & tmp->move_off)
1069 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1232 { 1070 {
1233 move_apply (tmp, op, NULL); 1071 move_apply (tmp, this, 0);
1234 1072
1235 if (was_destroyed (op, tag)) 1073 if (destroyed ())
1236 {
1237 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1074 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1238 }
1239 } 1075 }
1240 1076
1241 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1077 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1242 1078 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1243 if (tmp->above == tmp) 1079 if (tmp->above == tmp)
1244 tmp->above = NULL; 1080 tmp->above = 0;
1245 1081
1246 last = tmp; 1082 last = tmp;
1247 } 1083 }
1248 1084
1249 /* last == NULL of there are no objects on this space */ 1085 /* last == NULL if there are no objects on this space */
1086 //TODO: this makes little sense, why only update the topmost object?
1250 if (last == NULL) 1087 if (!last)
1251 { 1088 map->at (x, y).flags_ = 0;
1252 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1253 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1254 * those out anyways, and if there are any flags set right now, they won't
1255 * be correct anyways.
1256 */
1257 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1258 update_position (op->map, op->x, op->y);
1259 }
1260 else 1089 else
1261 update_object (last, UP_OBJ_REMOVE); 1090 update_object (last, UP_OBJ_REMOVE);
1262 1091
1263 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1092 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1264 update_all_los (op->map, op->x, op->y); 1093 update_all_los (map, x, y);
1265 } 1094 }
1266} 1095}
1267 1096
1268/* 1097/*
1269 * merge_ob(op,top): 1098 * merge_ob(op,top):
… …
1277merge_ob (object *op, object *top) 1106merge_ob (object *op, object *top)
1278{ 1107{
1279 if (!op->nrof) 1108 if (!op->nrof)
1280 return 0; 1109 return 0;
1281 1110
1282 if (top == NULL) 1111 if (top)
1283 for (top = op; top != NULL && top->above != NULL; top = top->above); 1112 for (top = op; top && top->above; top = top->above)
1113 ;
1284 1114
1285 for (; top != NULL; top = top->below) 1115 for (; top; top = top->below)
1286 { 1116 {
1287 if (top == op) 1117 if (top == op)
1288 continue; 1118 continue;
1289 if (CAN_MERGE (op, top)) 1119
1120 if (object::can_merge (op, top))
1290 { 1121 {
1291 top->nrof += op->nrof; 1122 top->nrof += op->nrof;
1292 1123
1293/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1124/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1294 op->weight = 0; /* Don't want any adjustements now */ 1125 op->weight = 0; /* Don't want any adjustements now */
1295 remove_ob (op); 1126 op->destroy ();
1296 free_object (op);
1297 return top; 1127 return top;
1298 } 1128 }
1299 } 1129 }
1300 1130
1301 return NULL; 1131 return 0;
1302} 1132}
1303 1133
1304/* 1134/*
1305 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1135 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1306 * job preparing multi-part monsters 1136 * job preparing multi-part monsters
1307 */ 1137 */
1308object * 1138object *
1309insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1139insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1310{ 1140{
1311 object *tmp;
1312
1313 if (op->head)
1314 op = op->head;
1315
1316 for (tmp = op; tmp; tmp = tmp->more) 1141 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1317 { 1142 {
1318 tmp->x = x + tmp->arch->clone.x; 1143 tmp->x = x + tmp->arch->clone.x;
1319 tmp->y = y + tmp->arch->clone.y; 1144 tmp->y = y + tmp->arch->clone.y;
1320 } 1145 }
1321 1146
… …
1340 * Return value: 1165 * Return value:
1341 * new object if 'op' was merged with other object 1166 * new object if 'op' was merged with other object
1342 * NULL if 'op' was destroyed 1167 * NULL if 'op' was destroyed
1343 * just 'op' otherwise 1168 * just 'op' otherwise
1344 */ 1169 */
1345
1346object * 1170object *
1347insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1171insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1348{ 1172{
1349 object *tmp, *top, *floor = NULL; 1173 object *tmp, *top, *floor = NULL;
1350 sint16 x, y; 1174 sint16 x, y;
1351 1175
1352 if (QUERY_FLAG (op, FLAG_FREED)) 1176 if (QUERY_FLAG (op, FLAG_FREED))
1353 { 1177 {
1354 LOG (llevError, "Trying to insert freed object!\n"); 1178 LOG (llevError, "Trying to insert freed object!\n");
1355 return NULL; 1179 return NULL;
1356 } 1180 }
1357 1181
1358 if (m == NULL) 1182 if (!m)
1359 { 1183 {
1360 dump_object (op); 1184 char *dump = dump_object (op);
1361 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1185 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1186 free (dump);
1362 return op; 1187 return op;
1363 } 1188 }
1364 1189
1365 if (out_of_map (m, op->x, op->y)) 1190 if (out_of_map (m, op->x, op->y))
1366 { 1191 {
1367 dump_object (op); 1192 char *dump = dump_object (op);
1368 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1193 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1369#ifdef MANY_CORES 1194#ifdef MANY_CORES
1370 /* Better to catch this here, as otherwise the next use of this object 1195 /* Better to catch this here, as otherwise the next use of this object
1371 * is likely to cause a crash. Better to find out where it is getting 1196 * is likely to cause a crash. Better to find out where it is getting
1372 * improperly inserted. 1197 * improperly inserted.
1373 */ 1198 */
1374 abort (); 1199 abort ();
1375#endif 1200#endif
1201 free (dump);
1376 return op; 1202 return op;
1377 } 1203 }
1378 1204
1379 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1205 if (!QUERY_FLAG (op, FLAG_REMOVED))
1380 { 1206 {
1381 dump_object (op); 1207 char *dump = dump_object (op);
1382 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1208 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1209 free (dump);
1383 return op; 1210 return op;
1384 } 1211 }
1385 1212
1386 if (op->more != NULL) 1213 if (op->more)
1387 { 1214 {
1388 /* The part may be on a different map. */ 1215 /* The part may be on a different map. */
1389 1216
1390 object *more = op->more; 1217 object *more = op->more;
1391 1218
1392 /* We really need the caller to normalize coordinates - if 1219 /* We really need the caller to normalise coordinates - if
1393 * we set the map, that doesn't work if the location is within 1220 * we set the map, that doesn't work if the location is within
1394 * a map and this is straddling an edge. So only if coordinate 1221 * a map and this is straddling an edge. So only if coordinate
1395 * is clear wrong do we normalize it. 1222 * is clear wrong do we normalise it.
1396 */ 1223 */
1397 if (OUT_OF_REAL_MAP (more->map, more->x, more->y)) 1224 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1398 more->map = get_map_from_coord (m, &more->x, &more->y); 1225 more->map = get_map_from_coord (m, &more->x, &more->y);
1399 else if (!more->map) 1226 else if (!more->map)
1400 { 1227 {
… …
1407 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1234 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1408 { 1235 {
1409 if (!op->head) 1236 if (!op->head)
1410 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1237 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1411 1238
1412 return NULL; 1239 return 0;
1413 } 1240 }
1414 } 1241 }
1415 1242
1416 CLEAR_FLAG (op, FLAG_REMOVED); 1243 CLEAR_FLAG (op, FLAG_REMOVED);
1417 1244
… …
1424 y = op->y; 1251 y = op->y;
1425 1252
1426 /* this has to be done after we translate the coordinates. 1253 /* this has to be done after we translate the coordinates.
1427 */ 1254 */
1428 if (op->nrof && !(flag & INS_NO_MERGE)) 1255 if (op->nrof && !(flag & INS_NO_MERGE))
1429 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1256 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1430 if (CAN_MERGE (op, tmp)) 1257 if (object::can_merge (op, tmp))
1431 { 1258 {
1432 op->nrof += tmp->nrof; 1259 op->nrof += tmp->nrof;
1433 remove_ob (tmp); 1260 tmp->destroy ();
1434 free_object (tmp);
1435 } 1261 }
1436 1262
1437 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1263 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1438 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1264 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1439 1265
… …
1452 op->below = originator->below; 1278 op->below = originator->below;
1453 1279
1454 if (op->below) 1280 if (op->below)
1455 op->below->above = op; 1281 op->below->above = op;
1456 else 1282 else
1457 SET_MAP_OB (op->map, op->x, op->y, op); 1283 op->ms ().bot = op;
1458 1284
1459 /* since *below* originator, no need to update top */ 1285 /* since *below* originator, no need to update top */
1460 originator->below = op; 1286 originator->below = op;
1461 } 1287 }
1462 else 1288 else
1463 { 1289 {
1464 /* If there are other objects, then */ 1290 /* If there are other objects, then */
1465 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1291 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1466 { 1292 {
1467 object *last = NULL; 1293 object *last = 0;
1468 1294
1469 /* 1295 /*
1470 * If there are multiple objects on this space, we do some trickier handling. 1296 * If there are multiple objects on this space, we do some trickier handling.
1471 * We've already dealt with merging if appropriate. 1297 * We've already dealt with merging if appropriate.
1472 * Generally, we want to put the new object on top. But if 1298 * Generally, we want to put the new object on top. But if
… …
1476 * once we get to them. This reduces the need to traverse over all of 1302 * once we get to them. This reduces the need to traverse over all of
1477 * them when adding another one - this saves quite a bit of cpu time 1303 * them when adding another one - this saves quite a bit of cpu time
1478 * when lots of spells are cast in one area. Currently, it is presumed 1304 * when lots of spells are cast in one area. Currently, it is presumed
1479 * that flying non pickable objects are spell objects. 1305 * that flying non pickable objects are spell objects.
1480 */ 1306 */
1481
1482 while (top != NULL) 1307 while (top)
1483 { 1308 {
1484 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1309 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1485 floor = top; 1310 floor = top;
1486 1311
1487 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1312 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1508 * If INS_ON_TOP is used, don't do this processing 1333 * If INS_ON_TOP is used, don't do this processing
1509 * Need to find the object that in fact blocks view, otherwise 1334 * Need to find the object that in fact blocks view, otherwise
1510 * stacking is a bit odd. 1335 * stacking is a bit odd.
1511 */ 1336 */
1512 if (!(flag & INS_ON_TOP) && 1337 if (!(flag & INS_ON_TOP) &&
1513 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1338 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1514 { 1339 {
1515 for (last = top; last != floor; last = last->below) 1340 for (last = top; last != floor; last = last->below)
1516 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1341 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1517 break; 1342 break;
1518 /* Check to see if we found the object that blocks view, 1343 /* Check to see if we found the object that blocks view,
… …
1540 op->above = GET_MAP_OB (op->map, op->x, op->y); 1365 op->above = GET_MAP_OB (op->map, op->x, op->y);
1541 1366
1542 if (op->above) 1367 if (op->above)
1543 op->above->below = op; 1368 op->above->below = op;
1544 1369
1545 op->below = NULL; 1370 op->below = 0;
1546 SET_MAP_OB (op->map, op->x, op->y, op); 1371 op->ms ().bot = op;
1547 } 1372 }
1548 else 1373 else
1549 { /* get inserted into the stack above top */ 1374 { /* get inserted into the stack above top */
1550 op->above = top->above; 1375 op->above = top->above;
1551 1376
… …
1554 1379
1555 op->below = top; 1380 op->below = top;
1556 top->above = op; 1381 top->above = op;
1557 } 1382 }
1558 1383
1559 if (op->above == NULL) 1384 if (!op->above)
1560 SET_MAP_TOP (op->map, op->x, op->y, op); 1385 op->ms ().top = op;
1561 } /* else not INS_BELOW_ORIGINATOR */ 1386 } /* else not INS_BELOW_ORIGINATOR */
1562 1387
1563 if (op->type == PLAYER) 1388 if (op->type == PLAYER)
1389 {
1564 op->contr->do_los = 1; 1390 op->contr->do_los = 1;
1391 ++op->map->players;
1392 op->map->touch ();
1393 }
1394
1395 op->map->dirty = true;
1565 1396
1566 /* If we have a floor, we know the player, if any, will be above 1397 /* If we have a floor, we know the player, if any, will be above
1567 * it, so save a few ticks and start from there. 1398 * it, so save a few ticks and start from there.
1568 */ 1399 */
1569 if (!(flag & INS_MAP_LOAD)) 1400 if (!(flag & INS_MAP_LOAD))
1570 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1401 if (object *pl = op->ms ().player ())
1571 if (tmp->type == PLAYER) 1402 if (pl->contr->ns)
1572 tmp->contr->socket.update_look = 1; 1403 pl->contr->ns->floorbox_update ();
1573 1404
1574 /* If this object glows, it may affect lighting conditions that are 1405 /* If this object glows, it may affect lighting conditions that are
1575 * visible to others on this map. But update_all_los is really 1406 * visible to others on this map. But update_all_los is really
1576 * an inefficient way to do this, as it means los for all players 1407 * an inefficient way to do this, as it means los for all players
1577 * on the map will get recalculated. The players could very well 1408 * on the map will get recalculated. The players could very well
1578 * be far away from this change and not affected in any way - 1409 * be far away from this change and not affected in any way -
1579 * this should get redone to only look for players within range, 1410 * this should get redone to only look for players within range,
1580 * or just updating the P_NEED_UPDATE for spaces within this area 1411 * or just updating the P_UPTODATE for spaces within this area
1581 * of effect may be sufficient. 1412 * of effect may be sufficient.
1582 */ 1413 */
1583 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1414 if (op->map->darkness && (op->glow_radius != 0))
1584 update_all_los (op->map, op->x, op->y); 1415 update_all_los (op->map, op->x, op->y);
1585 1416
1586 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1417 /* updates flags (blocked, alive, no magic, etc) for this map space */
1587 update_object (op, UP_OBJ_INSERT); 1418 update_object (op, UP_OBJ_INSERT);
1588 1419
1420 INVOKE_OBJECT (INSERT, op);
1421
1589 /* Don't know if moving this to the end will break anything. However, 1422 /* Don't know if moving this to the end will break anything. However,
1590 * we want to have update_look set above before calling this. 1423 * we want to have floorbox_update called before calling this.
1591 * 1424 *
1592 * check_move_on() must be after this because code called from 1425 * check_move_on() must be after this because code called from
1593 * check_move_on() depends on correct map flags (so functions like 1426 * check_move_on() depends on correct map flags (so functions like
1594 * blocked() and wall() work properly), and these flags are updated by 1427 * blocked() and wall() work properly), and these flags are updated by
1595 * update_object(). 1428 * update_object().
… …
1597 1430
1598 /* if this is not the head or flag has been passed, don't check walk on status */ 1431 /* if this is not the head or flag has been passed, don't check walk on status */
1599 if (!(flag & INS_NO_WALK_ON) && !op->head) 1432 if (!(flag & INS_NO_WALK_ON) && !op->head)
1600 { 1433 {
1601 if (check_move_on (op, originator)) 1434 if (check_move_on (op, originator))
1602 return NULL; 1435 return 0;
1603 1436
1604 /* If we are a multi part object, lets work our way through the check 1437 /* If we are a multi part object, lets work our way through the check
1605 * walk on's. 1438 * walk on's.
1606 */ 1439 */
1607 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1440 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1608 if (check_move_on (tmp, originator)) 1441 if (check_move_on (tmp, originator))
1609 return NULL; 1442 return 0;
1610 } 1443 }
1611 1444
1612 return op; 1445 return op;
1613} 1446}
1614 1447
1615/* this function inserts an object in the map, but if it 1448/* this function inserts an object in the map, but if it
1616 * finds an object of its own type, it'll remove that one first. 1449 * finds an object of its own type, it'll remove that one first.
1617 * op is the object to insert it under: supplies x and the map. 1450 * op is the object to insert it under: supplies x and the map.
1618 */ 1451 */
1619void 1452void
1620replace_insert_ob_in_map (const char *arch_string, object *op) 1453replace_insert_ob_in_map (const char *arch_string, object *op)
1621{ 1454{
1622 object * 1455 object *tmp, *tmp1;
1623 tmp;
1624 object *
1625 tmp1;
1626 1456
1627 /* first search for itself and remove any old instances */ 1457 /* first search for itself and remove any old instances */
1628 1458
1629 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1459 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1630 {
1631 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1460 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1632 { 1461 tmp->destroy ();
1633 remove_ob (tmp);
1634 free_object (tmp);
1635 }
1636 }
1637 1462
1638 tmp1 = arch_to_object (find_archetype (arch_string)); 1463 tmp1 = arch_to_object (archetype::find (arch_string));
1639 1464
1640 tmp1->x = op->x; 1465 tmp1->x = op->x;
1641 tmp1->y = op->y; 1466 tmp1->y = op->y;
1642 insert_ob_in_map (tmp1, op->map, op, 0); 1467 insert_ob_in_map (tmp1, op->map, op, 0);
1468}
1469
1470object *
1471object::insert_at (object *where, object *originator, int flags)
1472{
1473 where->map->insert (this, where->x, where->y, originator, flags);
1643} 1474}
1644 1475
1645/* 1476/*
1646 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1477 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1647 * is returned contains nr objects, and the remaining parts contains 1478 * is returned contains nr objects, and the remaining parts contains
1648 * the rest (or is removed and freed if that number is 0). 1479 * the rest (or is removed and freed if that number is 0).
1649 * On failure, NULL is returned, and the reason put into the 1480 * On failure, NULL is returned, and the reason put into the
1650 * global static errmsg array. 1481 * global static errmsg array.
1651 */ 1482 */
1652
1653object * 1483object *
1654get_split_ob (object *orig_ob, uint32 nr) 1484get_split_ob (object *orig_ob, uint32 nr)
1655{ 1485{
1656 object * 1486 object *newob;
1657 newob;
1658 int
1659 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1487 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1660 1488
1661 if (orig_ob->nrof < nr) 1489 if (orig_ob->nrof < nr)
1662 { 1490 {
1663 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1491 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1664 return NULL; 1492 return NULL;
1665 } 1493 }
1666 1494
1667 newob = object_create_clone (orig_ob); 1495 newob = object_create_clone (orig_ob);
1668 1496
1669 if ((orig_ob->nrof -= nr) < 1) 1497 if ((orig_ob->nrof -= nr) < 1)
1670 { 1498 orig_ob->destroy (1);
1671 if (!is_removed)
1672 remove_ob (orig_ob);
1673 free_object2 (orig_ob, 1);
1674 }
1675 else if (!is_removed) 1499 else if (!is_removed)
1676 { 1500 {
1677 if (orig_ob->env != NULL) 1501 if (orig_ob->env != NULL)
1678 sub_weight (orig_ob->env, orig_ob->weight * nr); 1502 sub_weight (orig_ob->env, orig_ob->weight * nr);
1679 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1503 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1699 1523
1700object * 1524object *
1701decrease_ob_nr (object *op, uint32 i) 1525decrease_ob_nr (object *op, uint32 i)
1702{ 1526{
1703 object *tmp; 1527 object *tmp;
1704 player *pl;
1705 1528
1706 if (i == 0) /* objects with op->nrof require this check */ 1529 if (i == 0) /* objects with op->nrof require this check */
1707 return op; 1530 return op;
1708 1531
1709 if (i > op->nrof) 1532 if (i > op->nrof)
1710 i = op->nrof; 1533 i = op->nrof;
1711 1534
1712 if (QUERY_FLAG (op, FLAG_REMOVED)) 1535 if (QUERY_FLAG (op, FLAG_REMOVED))
1713 op->nrof -= i; 1536 op->nrof -= i;
1714 else if (op->env != NULL) 1537 else if (op->env)
1715 { 1538 {
1716 /* is this object in the players inventory, or sub container 1539 /* is this object in the players inventory, or sub container
1717 * therein? 1540 * therein?
1718 */ 1541 */
1719 tmp = is_player_inv (op->env); 1542 tmp = op->in_player ();
1720 /* nope. Is this a container the player has opened? 1543 /* nope. Is this a container the player has opened?
1721 * If so, set tmp to that player. 1544 * If so, set tmp to that player.
1722 * IMO, searching through all the players will mostly 1545 * IMO, searching through all the players will mostly
1723 * likely be quicker than following op->env to the map, 1546 * likely be quicker than following op->env to the map,
1724 * and then searching the map for a player. 1547 * and then searching the map for a player.
1725 */ 1548 */
1726 if (!tmp) 1549 if (!tmp)
1727 { 1550 for_all_players (pl)
1728 for (pl = first_player; pl; pl = pl->next)
1729 if (pl->ob->container == op->env) 1551 if (pl->ob->container == op->env)
1552 {
1553 tmp = pl->ob;
1730 break; 1554 break;
1731 if (pl)
1732 tmp = pl->ob;
1733 else
1734 tmp = NULL;
1735 } 1555 }
1736 1556
1737 if (i < op->nrof) 1557 if (i < op->nrof)
1738 { 1558 {
1739 sub_weight (op->env, op->weight * i); 1559 sub_weight (op->env, op->weight * i);
1740 op->nrof -= i; 1560 op->nrof -= i;
1741 if (tmp) 1561 if (tmp)
1742 {
1743 esrv_send_item (tmp, op); 1562 esrv_send_item (tmp, op);
1744 }
1745 } 1563 }
1746 else 1564 else
1747 { 1565 {
1748 remove_ob (op); 1566 op->remove ();
1749 op->nrof = 0; 1567 op->nrof = 0;
1750 if (tmp) 1568 if (tmp)
1751 {
1752 esrv_del_item (tmp->contr, op->count); 1569 esrv_del_item (tmp->contr, op->count);
1753 }
1754 } 1570 }
1755 } 1571 }
1756 else 1572 else
1757 { 1573 {
1758 object *above = op->above; 1574 object *above = op->above;
1759 1575
1760 if (i < op->nrof) 1576 if (i < op->nrof)
1761 op->nrof -= i; 1577 op->nrof -= i;
1762 else 1578 else
1763 { 1579 {
1764 remove_ob (op); 1580 op->remove ();
1765 op->nrof = 0; 1581 op->nrof = 0;
1766 } 1582 }
1767 1583
1768 /* Since we just removed op, op->above is null */ 1584 /* Since we just removed op, op->above is null */
1769 for (tmp = above; tmp != NULL; tmp = tmp->above) 1585 for (tmp = above; tmp; tmp = tmp->above)
1770 if (tmp->type == PLAYER) 1586 if (tmp->type == PLAYER)
1771 { 1587 {
1772 if (op->nrof) 1588 if (op->nrof)
1773 esrv_send_item (tmp, op); 1589 esrv_send_item (tmp, op);
1774 else 1590 else
… …
1778 1594
1779 if (op->nrof) 1595 if (op->nrof)
1780 return op; 1596 return op;
1781 else 1597 else
1782 { 1598 {
1783 free_object (op); 1599 op->destroy ();
1784 return NULL; 1600 return 0;
1785 } 1601 }
1786} 1602}
1787 1603
1788/* 1604/*
1789 * add_weight(object, weight) adds the specified weight to an object, 1605 * add_weight(object, weight) adds the specified weight to an object,
… …
1801 op->carrying += weight; 1617 op->carrying += weight;
1802 op = op->env; 1618 op = op->env;
1803 } 1619 }
1804} 1620}
1805 1621
1622object *
1623insert_ob_in_ob (object *op, object *where)
1624{
1625 if (!where)
1626 {
1627 char *dump = dump_object (op);
1628 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1629 free (dump);
1630 return op;
1631 }
1632
1633 if (where->head)
1634 {
1635 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1636 where = where->head;
1637 }
1638
1639 return where->insert (op);
1640}
1641
1806/* 1642/*
1807 * insert_ob_in_ob(op,environment): 1643 * env->insert (op)
1808 * This function inserts the object op in the linked list 1644 * This function inserts the object op in the linked list
1809 * inside the object environment. 1645 * inside the object environment.
1810 * 1646 *
1811 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1812 * the inventory at the last position or next to other objects of the same
1813 * type.
1814 * Frank: Now sorted by type, archetype and magic!
1815 *
1816 * The function returns now pointer to inserted item, and return value can 1647 * The function returns now pointer to inserted item, and return value can
1817 * be != op, if items are merged. -Tero 1648 * be != op, if items are merged. -Tero
1818 */ 1649 */
1819 1650
1820object * 1651object *
1821insert_ob_in_ob (object *op, object *where) 1652object::insert (object *op)
1822{ 1653{
1823 object * 1654 object *tmp, *otmp;
1824 tmp, *
1825 otmp;
1826 1655
1827 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1656 if (!QUERY_FLAG (op, FLAG_REMOVED))
1828 { 1657 op->remove ();
1829 dump_object (op);
1830 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1831 return op;
1832 }
1833
1834 if (where == NULL)
1835 {
1836 dump_object (op);
1837 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1838 return op;
1839 }
1840
1841 if (where->head)
1842 {
1843 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1844 where = where->head;
1845 }
1846 1658
1847 if (op->more) 1659 if (op->more)
1848 { 1660 {
1849 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1661 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1850 return op; 1662 return op;
… …
1852 1664
1853 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1665 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1854 CLEAR_FLAG (op, FLAG_REMOVED); 1666 CLEAR_FLAG (op, FLAG_REMOVED);
1855 if (op->nrof) 1667 if (op->nrof)
1856 { 1668 {
1857 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1669 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1858 if (CAN_MERGE (tmp, op)) 1670 if (object::can_merge (tmp, op))
1859 { 1671 {
1860 /* return the original object and remove inserted object 1672 /* return the original object and remove inserted object
1861 (client needs the original object) */ 1673 (client needs the original object) */
1862 tmp->nrof += op->nrof; 1674 tmp->nrof += op->nrof;
1863 /* Weight handling gets pretty funky. Since we are adding to 1675 /* Weight handling gets pretty funky. Since we are adding to
1864 * tmp->nrof, we need to increase the weight. 1676 * tmp->nrof, we need to increase the weight.
1865 */ 1677 */
1866 add_weight (where, op->weight * op->nrof); 1678 add_weight (this, op->weight * op->nrof);
1867 SET_FLAG (op, FLAG_REMOVED); 1679 SET_FLAG (op, FLAG_REMOVED);
1868 free_object (op); /* free the inserted object */ 1680 op->destroy (); /* free the inserted object */
1869 op = tmp; 1681 op = tmp;
1870 remove_ob (op); /* and fix old object's links */ 1682 op->remove (); /* and fix old object's links */
1871 CLEAR_FLAG (op, FLAG_REMOVED); 1683 CLEAR_FLAG (op, FLAG_REMOVED);
1872 break; 1684 break;
1873 } 1685 }
1874 1686
1875 /* I assume combined objects have no inventory 1687 /* I assume combined objects have no inventory
1876 * We add the weight - this object could have just been removed 1688 * We add the weight - this object could have just been removed
1877 * (if it was possible to merge). calling remove_ob will subtract 1689 * (if it was possible to merge). calling remove_ob will subtract
1878 * the weight, so we need to add it in again, since we actually do 1690 * the weight, so we need to add it in again, since we actually do
1879 * the linking below 1691 * the linking below
1880 */ 1692 */
1881 add_weight (where, op->weight * op->nrof); 1693 add_weight (this, op->weight * op->nrof);
1882 } 1694 }
1883 else 1695 else
1884 add_weight (where, (op->weight + op->carrying)); 1696 add_weight (this, (op->weight + op->carrying));
1885 1697
1886 otmp = is_player_inv (where); 1698 otmp = this->in_player ();
1887 if (otmp && otmp->contr != NULL) 1699 if (otmp && otmp->contr)
1888 {
1889 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1700 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1890 fix_player (otmp); 1701 otmp->update_stats ();
1891 }
1892 1702
1893 op->map = NULL; 1703 op->map = 0;
1894 op->env = where; 1704 op->env = this;
1895 op->above = NULL; 1705 op->above = 0;
1896 op->below = NULL; 1706 op->below = 0;
1897 op->x = 0, op->y = 0; 1707 op->x = 0, op->y = 0;
1898 1708
1899 /* reset the light list and los of the players on the map */ 1709 /* reset the light list and los of the players on the map */
1900 if ((op->glow_radius != 0) && where->map) 1710 if ((op->glow_radius != 0) && map)
1901 { 1711 {
1902#ifdef DEBUG_LIGHTS 1712#ifdef DEBUG_LIGHTS
1903 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1713 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1904#endif /* DEBUG_LIGHTS */ 1714#endif /* DEBUG_LIGHTS */
1905 if (MAP_DARKNESS (where->map)) 1715 if (map->darkness)
1906 update_all_los (where->map, where->x, where->y); 1716 update_all_los (map, x, y);
1907 } 1717 }
1908 1718
1909 /* Client has no idea of ordering so lets not bother ordering it here. 1719 /* Client has no idea of ordering so lets not bother ordering it here.
1910 * It sure simplifies this function... 1720 * It sure simplifies this function...
1911 */ 1721 */
1912 if (where->inv == NULL) 1722 if (!inv)
1913 where->inv = op; 1723 inv = op;
1914 else 1724 else
1915 { 1725 {
1916 op->below = where->inv; 1726 op->below = inv;
1917 op->below->above = op; 1727 op->below->above = op;
1918 where->inv = op; 1728 inv = op;
1919 } 1729 }
1730
1731 INVOKE_OBJECT (INSERT, this);
1732
1920 return op; 1733 return op;
1921} 1734}
1922 1735
1923/* 1736/*
1924 * Checks if any objects has a move_type that matches objects 1737 * Checks if any objects has a move_type that matches objects
… …
1938 * 1751 *
1939 * MSW 2001-07-08: Check all objects on space, not just those below 1752 * MSW 2001-07-08: Check all objects on space, not just those below
1940 * object being inserted. insert_ob_in_map may not put new objects 1753 * object being inserted. insert_ob_in_map may not put new objects
1941 * on top. 1754 * on top.
1942 */ 1755 */
1943
1944int 1756int
1945check_move_on (object *op, object *originator) 1757check_move_on (object *op, object *originator)
1946{ 1758{
1947 object * 1759 object *tmp;
1948 tmp; 1760 maptile *m = op->map;
1949 tag_t
1950 tag;
1951 mapstruct *
1952 m = op->map;
1953 int
1954 x = op->x, y = op->y; 1761 int x = op->x, y = op->y;
1955 1762
1956 MoveType 1763 MoveType move_on, move_slow, move_block;
1957 move_on,
1958 move_slow,
1959 move_block;
1960 1764
1961 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1765 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1962 return 0; 1766 return 0;
1963
1964 tag = op->count;
1965 1767
1966 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1768 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1967 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1769 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1968 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1770 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1969 1771
… …
1985 1787
1986 /* The objects have to be checked from top to bottom. 1788 /* The objects have to be checked from top to bottom.
1987 * Hence, we first go to the top: 1789 * Hence, we first go to the top:
1988 */ 1790 */
1989 1791
1990 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1792 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1991 { 1793 {
1992 /* Trim the search when we find the first other spell effect 1794 /* Trim the search when we find the first other spell effect
1993 * this helps performance so that if a space has 50 spell objects, 1795 * this helps performance so that if a space has 50 spell objects,
1994 * we don't need to check all of them. 1796 * we don't need to check all of them.
1995 */ 1797 */
… …
2030 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1832 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2031 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1833 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2032 { 1834 {
2033 move_apply (tmp, op, originator); 1835 move_apply (tmp, op, originator);
2034 1836
2035 if (was_destroyed (op, tag)) 1837 if (op->destroyed ())
2036 return 1; 1838 return 1;
2037 1839
2038 /* what the person/creature stepped onto has moved the object 1840 /* what the person/creature stepped onto has moved the object
2039 * someplace new. Don't process any further - if we did, 1841 * someplace new. Don't process any further - if we did,
2040 * have a feeling strange problems would result. 1842 * have a feeling strange problems would result.
… …
2050/* 1852/*
2051 * present_arch(arch, map, x, y) searches for any objects with 1853 * present_arch(arch, map, x, y) searches for any objects with
2052 * a matching archetype at the given map and coordinates. 1854 * a matching archetype at the given map and coordinates.
2053 * The first matching object is returned, or NULL if none. 1855 * The first matching object is returned, or NULL if none.
2054 */ 1856 */
2055
2056object * 1857object *
2057present_arch (const archetype *at, mapstruct *m, int x, int y) 1858present_arch (const archetype *at, maptile *m, int x, int y)
2058{ 1859{
2059 object *
2060 tmp;
2061
2062 if (m == NULL || out_of_map (m, x, y)) 1860 if (!m || out_of_map (m, x, y))
2063 { 1861 {
2064 LOG (llevError, "Present_arch called outside map.\n"); 1862 LOG (llevError, "Present_arch called outside map.\n");
2065 return NULL; 1863 return NULL;
2066 } 1864 }
2067 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1865
1866 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2068 if (tmp->arch == at) 1867 if (tmp->arch == at)
2069 return tmp; 1868 return tmp;
1869
2070 return NULL; 1870 return NULL;
2071} 1871}
2072 1872
2073/* 1873/*
2074 * present(type, map, x, y) searches for any objects with 1874 * present(type, map, x, y) searches for any objects with
2075 * a matching type variable at the given map and coordinates. 1875 * a matching type variable at the given map and coordinates.
2076 * The first matching object is returned, or NULL if none. 1876 * The first matching object is returned, or NULL if none.
2077 */ 1877 */
2078
2079object * 1878object *
2080present (unsigned char type, mapstruct *m, int x, int y) 1879present (unsigned char type, maptile *m, int x, int y)
2081{ 1880{
2082 object *
2083 tmp;
2084
2085 if (out_of_map (m, x, y)) 1881 if (out_of_map (m, x, y))
2086 { 1882 {
2087 LOG (llevError, "Present called outside map.\n"); 1883 LOG (llevError, "Present called outside map.\n");
2088 return NULL; 1884 return NULL;
2089 } 1885 }
2090 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1886
1887 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2091 if (tmp->type == type) 1888 if (tmp->type == type)
2092 return tmp; 1889 return tmp;
1890
2093 return NULL; 1891 return NULL;
2094} 1892}
2095 1893
2096/* 1894/*
2097 * present_in_ob(type, object) searches for any objects with 1895 * present_in_ob(type, object) searches for any objects with
2098 * a matching type variable in the inventory of the given object. 1896 * a matching type variable in the inventory of the given object.
2099 * The first matching object is returned, or NULL if none. 1897 * The first matching object is returned, or NULL if none.
2100 */ 1898 */
2101
2102object * 1899object *
2103present_in_ob (unsigned char type, const object *op) 1900present_in_ob (unsigned char type, const object *op)
2104{ 1901{
2105 object *
2106 tmp;
2107
2108 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1902 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2109 if (tmp->type == type) 1903 if (tmp->type == type)
2110 return tmp; 1904 return tmp;
1905
2111 return NULL; 1906 return NULL;
2112} 1907}
2113 1908
2114/* 1909/*
2115 * present_in_ob (type, str, object) searches for any objects with 1910 * present_in_ob (type, str, object) searches for any objects with
… …
2123 * str is the string to match against. Note that we match against 1918 * str is the string to match against. Note that we match against
2124 * the object name, not the archetype name. this is so that the 1919 * the object name, not the archetype name. this is so that the
2125 * spell code can use one object type (force), but change it's name 1920 * spell code can use one object type (force), but change it's name
2126 * to be unique. 1921 * to be unique.
2127 */ 1922 */
2128
2129object * 1923object *
2130present_in_ob_by_name (int type, const char *str, const object *op) 1924present_in_ob_by_name (int type, const char *str, const object *op)
2131{ 1925{
2132 object *
2133 tmp;
2134
2135 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1926 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2136 {
2137 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1927 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2138 return tmp; 1928 return tmp;
2139 } 1929
2140 return NULL; 1930 return 0;
2141} 1931}
2142 1932
2143/* 1933/*
2144 * present_arch_in_ob(archetype, object) searches for any objects with 1934 * present_arch_in_ob(archetype, object) searches for any objects with
2145 * a matching archetype in the inventory of the given object. 1935 * a matching archetype in the inventory of the given object.
2146 * The first matching object is returned, or NULL if none. 1936 * The first matching object is returned, or NULL if none.
2147 */ 1937 */
2148
2149object * 1938object *
2150present_arch_in_ob (const archetype *at, const object *op) 1939present_arch_in_ob (const archetype *at, const object *op)
2151{ 1940{
2152 object *
2153 tmp;
2154
2155 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1941 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2156 if (tmp->arch == at) 1942 if (tmp->arch == at)
2157 return tmp; 1943 return tmp;
1944
2158 return NULL; 1945 return NULL;
2159} 1946}
2160 1947
2161/* 1948/*
2162 * activate recursively a flag on an object inventory 1949 * activate recursively a flag on an object inventory
2163 */ 1950 */
2164void 1951void
2165flag_inv (object *op, int flag) 1952flag_inv (object *op, int flag)
2166{ 1953{
2167 object *
2168 tmp;
2169
2170 if (op->inv) 1954 if (op->inv)
2171 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1955 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2172 { 1956 {
2173 SET_FLAG (tmp, flag); 1957 SET_FLAG (tmp, flag);
2174 flag_inv (tmp, flag); 1958 flag_inv (tmp, flag);
2175 } 1959 }
2176} /* 1960}
1961
1962/*
2177 * desactivate recursively a flag on an object inventory 1963 * deactivate recursively a flag on an object inventory
2178 */ 1964 */
2179void 1965void
2180unflag_inv (object *op, int flag) 1966unflag_inv (object *op, int flag)
2181{ 1967{
2182 object *
2183 tmp;
2184
2185 if (op->inv) 1968 if (op->inv)
2186 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1969 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2187 { 1970 {
2188 CLEAR_FLAG (tmp, flag); 1971 CLEAR_FLAG (tmp, flag);
2189 unflag_inv (tmp, flag); 1972 unflag_inv (tmp, flag);
2190 } 1973 }
2191} 1974}
… …
2194 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1977 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2195 * all it's inventory (recursively). 1978 * all it's inventory (recursively).
2196 * If checksums are used, a player will get set_cheat called for 1979 * If checksums are used, a player will get set_cheat called for
2197 * him/her-self and all object carried by a call to this function. 1980 * him/her-self and all object carried by a call to this function.
2198 */ 1981 */
2199
2200void 1982void
2201set_cheat (object *op) 1983set_cheat (object *op)
2202{ 1984{
2203 SET_FLAG (op, FLAG_WAS_WIZ); 1985 SET_FLAG (op, FLAG_WAS_WIZ);
2204 flag_inv (op, FLAG_WAS_WIZ); 1986 flag_inv (op, FLAG_WAS_WIZ);
… …
2223 * because arch_blocked (now ob_blocked) needs to know the movement type 2005 * because arch_blocked (now ob_blocked) needs to know the movement type
2224 * to know if the space in question will block the object. We can't use 2006 * to know if the space in question will block the object. We can't use
2225 * the archetype because that isn't correct if the monster has been 2007 * the archetype because that isn't correct if the monster has been
2226 * customized, changed states, etc. 2008 * customized, changed states, etc.
2227 */ 2009 */
2228
2229int 2010int
2230find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2011find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2231{ 2012{
2232 int
2233 i,
2234 index = 0, flag; 2013 int index = 0, flag;
2235 static int
2236 altern[SIZEOFFREE]; 2014 int altern[SIZEOFFREE];
2237 2015
2238 for (i = start; i < stop; i++) 2016 for (int i = start; i < stop; i++)
2239 { 2017 {
2240 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2018 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2241 if (!flag) 2019 if (!flag)
2242 altern[index++] = i; 2020 altern [index++] = i;
2243 2021
2244 /* Basically, if we find a wall on a space, we cut down the search size. 2022 /* Basically, if we find a wall on a space, we cut down the search size.
2245 * In this way, we won't return spaces that are on another side of a wall. 2023 * In this way, we won't return spaces that are on another side of a wall.
2246 * This mostly work, but it cuts down the search size in all directions - 2024 * This mostly work, but it cuts down the search size in all directions -
2247 * if the space being examined only has a wall to the north and empty 2025 * if the space being examined only has a wall to the north and empty
2248 * spaces in all the other directions, this will reduce the search space 2026 * spaces in all the other directions, this will reduce the search space
2249 * to only the spaces immediately surrounding the target area, and 2027 * to only the spaces immediately surrounding the target area, and
2250 * won't look 2 spaces south of the target space. 2028 * won't look 2 spaces south of the target space.
2251 */ 2029 */
2252 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2030 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2253 stop = maxfree[i]; 2031 stop = maxfree[i];
2254 } 2032 }
2033
2255 if (!index) 2034 if (!index)
2256 return -1; 2035 return -1;
2036
2257 return altern[RANDOM () % index]; 2037 return altern[RANDOM () % index];
2258} 2038}
2259 2039
2260/* 2040/*
2261 * find_first_free_spot(archetype, mapstruct, x, y) works like 2041 * find_first_free_spot(archetype, maptile, x, y) works like
2262 * find_free_spot(), but it will search max number of squares. 2042 * find_free_spot(), but it will search max number of squares.
2263 * But it will return the first available spot, not a random choice. 2043 * But it will return the first available spot, not a random choice.
2264 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2044 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2265 */ 2045 */
2266
2267int 2046int
2268find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2047find_first_free_spot (const object *ob, maptile *m, int x, int y)
2269{ 2048{
2270 int
2271 i;
2272
2273 for (i = 0; i < SIZEOFFREE; i++) 2049 for (int i = 0; i < SIZEOFFREE; i++)
2274 {
2275 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2050 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2276 return i; 2051 return i;
2277 } 2052
2278 return -1; 2053 return -1;
2279} 2054}
2280 2055
2281/* 2056/*
2282 * The function permute(arr, begin, end) randomly reorders the array 2057 * The function permute(arr, begin, end) randomly reorders the array
2283 * arr[begin..end-1]. 2058 * arr[begin..end-1].
2059 * now uses a fisher-yates shuffle, old permute was broken
2284 */ 2060 */
2285static void 2061static void
2286permute (int *arr, int begin, int end) 2062permute (int *arr, int begin, int end)
2287{ 2063{
2288 int 2064 arr += begin;
2289 i,
2290 j,
2291 tmp,
2292 len;
2293
2294 len = end - begin; 2065 end -= begin;
2295 for (i = begin; i < end; i++)
2296 {
2297 j = begin + RANDOM () % len;
2298 2066
2299 tmp = arr[i]; 2067 while (--end)
2300 arr[i] = arr[j]; 2068 swap (arr [end], arr [RANDOM () % (end + 1)]);
2301 arr[j] = tmp;
2302 }
2303} 2069}
2304 2070
2305/* new function to make monster searching more efficient, and effective! 2071/* new function to make monster searching more efficient, and effective!
2306 * This basically returns a randomized array (in the passed pointer) of 2072 * This basically returns a randomized array (in the passed pointer) of
2307 * the spaces to find monsters. In this way, it won't always look for 2073 * the spaces to find monsters. In this way, it won't always look for
… …
2310 * the 3x3 area will be searched, just not in a predictable order. 2076 * the 3x3 area will be searched, just not in a predictable order.
2311 */ 2077 */
2312void 2078void
2313get_search_arr (int *search_arr) 2079get_search_arr (int *search_arr)
2314{ 2080{
2315 int 2081 int i;
2316 i;
2317 2082
2318 for (i = 0; i < SIZEOFFREE; i++) 2083 for (i = 0; i < SIZEOFFREE; i++)
2319 {
2320 search_arr[i] = i; 2084 search_arr[i] = i;
2321 }
2322 2085
2323 permute (search_arr, 1, SIZEOFFREE1 + 1); 2086 permute (search_arr, 1, SIZEOFFREE1 + 1);
2324 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2087 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2325 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2088 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2326} 2089}
… …
2335 * Perhaps incorrectly, but I'm making the assumption that exclude 2098 * Perhaps incorrectly, but I'm making the assumption that exclude
2336 * is actually want is going to try and move there. We need this info 2099 * is actually want is going to try and move there. We need this info
2337 * because we have to know what movement the thing looking to move 2100 * because we have to know what movement the thing looking to move
2338 * there is capable of. 2101 * there is capable of.
2339 */ 2102 */
2340
2341int 2103int
2342find_dir (mapstruct *m, int x, int y, object *exclude) 2104find_dir (maptile *m, int x, int y, object *exclude)
2343{ 2105{
2344 int
2345 i,
2346 max = SIZEOFFREE, mflags; 2106 int i, max = SIZEOFFREE, mflags;
2347 2107
2348 sint16 nx, ny; 2108 sint16 nx, ny;
2349 object * 2109 object *tmp;
2350 tmp; 2110 maptile *mp;
2351 mapstruct *
2352 mp;
2353 2111
2354 MoveType blocked, move_type; 2112 MoveType blocked, move_type;
2355 2113
2356 if (exclude && exclude->head) 2114 if (exclude && exclude->head)
2357 { 2115 {
… …
2369 mp = m; 2127 mp = m;
2370 nx = x + freearr_x[i]; 2128 nx = x + freearr_x[i];
2371 ny = y + freearr_y[i]; 2129 ny = y + freearr_y[i];
2372 2130
2373 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2131 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2132
2374 if (mflags & P_OUT_OF_MAP) 2133 if (mflags & P_OUT_OF_MAP)
2375 {
2376 max = maxfree[i]; 2134 max = maxfree[i];
2377 }
2378 else 2135 else
2379 { 2136 {
2380 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2137 mapspace &ms = mp->at (nx, ny);
2138
2139 blocked = ms.move_block;
2381 2140
2382 if ((move_type & blocked) == move_type) 2141 if ((move_type & blocked) == move_type)
2383 {
2384 max = maxfree[i]; 2142 max = maxfree[i];
2385 }
2386 else if (mflags & P_IS_ALIVE) 2143 else if (mflags & P_IS_ALIVE)
2387 { 2144 {
2388 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2145 for (tmp = ms.bot; tmp; tmp = tmp->above)
2389 { 2146 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2390 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2147 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2391 {
2392 break; 2148 break;
2393 } 2149
2394 }
2395 if (tmp) 2150 if (tmp)
2396 {
2397 return freedir[i]; 2151 return freedir[i];
2398 }
2399 } 2152 }
2400 } 2153 }
2401 } 2154 }
2155
2402 return 0; 2156 return 0;
2403} 2157}
2404 2158
2405/* 2159/*
2406 * distance(object 1, object 2) will return the square of the 2160 * distance(object 1, object 2) will return the square of the
2407 * distance between the two given objects. 2161 * distance between the two given objects.
2408 */ 2162 */
2409
2410int 2163int
2411distance (const object *ob1, const object *ob2) 2164distance (const object *ob1, const object *ob2)
2412{ 2165{
2413 int
2414 i;
2415
2416 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2166 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2417 return i;
2418} 2167}
2419 2168
2420/* 2169/*
2421 * find_dir_2(delta-x,delta-y) will return a direction in which 2170 * find_dir_2(delta-x,delta-y) will return a direction in which
2422 * an object which has subtracted the x and y coordinates of another 2171 * an object which has subtracted the x and y coordinates of another
2423 * object, needs to travel toward it. 2172 * object, needs to travel toward it.
2424 */ 2173 */
2425
2426int 2174int
2427find_dir_2 (int x, int y) 2175find_dir_2 (int x, int y)
2428{ 2176{
2429 int 2177 int q;
2430 q;
2431 2178
2432 if (y) 2179 if (y)
2433 q = x * 100 / y; 2180 q = x * 100 / y;
2434 else if (x) 2181 else if (x)
2435 q = -300 * x; 2182 q = -300 * x;
… …
2470int 2217int
2471absdir (int d) 2218absdir (int d)
2472{ 2219{
2473 while (d < 1) 2220 while (d < 1)
2474 d += 8; 2221 d += 8;
2222
2475 while (d > 8) 2223 while (d > 8)
2476 d -= 8; 2224 d -= 8;
2225
2477 return d; 2226 return d;
2478} 2227}
2479 2228
2480/* 2229/*
2481 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2230 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
… …
2483 */ 2232 */
2484 2233
2485int 2234int
2486dirdiff (int dir1, int dir2) 2235dirdiff (int dir1, int dir2)
2487{ 2236{
2488 int 2237 int d;
2489 d;
2490 2238
2491 d = abs (dir1 - dir2); 2239 d = abs (dir1 - dir2);
2492 if (d > 4) 2240 if (d > 4)
2493 d = 8 - d; 2241 d = 8 - d;
2242
2494 return d; 2243 return d;
2495} 2244}
2496 2245
2497/* peterm: 2246/* peterm:
2498 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2247 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2501 * This basically means that if direction is 15, then it could either go 2250 * This basically means that if direction is 15, then it could either go
2502 * direction 4, 14, or 16 to get back to where we are. 2251 * direction 4, 14, or 16 to get back to where we are.
2503 * Moved from spell_util.c to object.c with the other related direction 2252 * Moved from spell_util.c to object.c with the other related direction
2504 * functions. 2253 * functions.
2505 */ 2254 */
2506
2507int
2508 reduction_dir[SIZEOFFREE][3] = { 2255int reduction_dir[SIZEOFFREE][3] = {
2509 {0, 0, 0}, /* 0 */ 2256 {0, 0, 0}, /* 0 */
2510 {0, 0, 0}, /* 1 */ 2257 {0, 0, 0}, /* 1 */
2511 {0, 0, 0}, /* 2 */ 2258 {0, 0, 0}, /* 2 */
2512 {0, 0, 0}, /* 3 */ 2259 {0, 0, 0}, /* 3 */
2513 {0, 0, 0}, /* 4 */ 2260 {0, 0, 0}, /* 4 */
… …
2561 * find a path to that monster that we found. If not, 2308 * find a path to that monster that we found. If not,
2562 * we don't bother going toward it. Returns 1 if we 2309 * we don't bother going toward it. Returns 1 if we
2563 * can see a direct way to get it 2310 * can see a direct way to get it
2564 * Modified to be map tile aware -.MSW 2311 * Modified to be map tile aware -.MSW
2565 */ 2312 */
2566
2567
2568int 2313int
2569can_see_monsterP (mapstruct *m, int x, int y, int dir) 2314can_see_monsterP (maptile *m, int x, int y, int dir)
2570{ 2315{
2571 sint16 dx, dy; 2316 sint16 dx, dy;
2572 int
2573 mflags; 2317 int mflags;
2574 2318
2575 if (dir < 0) 2319 if (dir < 0)
2576 return 0; /* exit condition: invalid direction */ 2320 return 0; /* exit condition: invalid direction */
2577 2321
2578 dx = x + freearr_x[dir]; 2322 dx = x + freearr_x[dir];
… …
2591 return 0; 2335 return 0;
2592 2336
2593 /* yes, can see. */ 2337 /* yes, can see. */
2594 if (dir < 9) 2338 if (dir < 9)
2595 return 1; 2339 return 1;
2340
2596 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2341 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2597 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2342 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2343 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2598} 2344}
2599
2600
2601 2345
2602/* 2346/*
2603 * can_pick(picker, item): finds out if an object is possible to be 2347 * can_pick(picker, item): finds out if an object is possible to be
2604 * picked up by the picker. Returnes 1 if it can be 2348 * picked up by the picker. Returnes 1 if it can be
2605 * picked up, otherwise 0. 2349 * picked up, otherwise 0.
… …
2616 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2360 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2617 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2361 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2618 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2362 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2619} 2363}
2620 2364
2621
2622/* 2365/*
2623 * create clone from object to another 2366 * create clone from object to another
2624 */ 2367 */
2625object * 2368object *
2626object_create_clone (object *asrc) 2369object_create_clone (object *asrc)
2627{ 2370{
2628 object *
2629 dst = NULL, *tmp, *src, *part, *prev, *item; 2371 object *dst = 0, *tmp, *src, *part, *prev, *item;
2630 2372
2631 if (!asrc) 2373 if (!asrc)
2632 return NULL; 2374 return 0;
2375
2633 src = asrc; 2376 src = asrc;
2634 if (src->head) 2377 if (src->head)
2635 src = src->head; 2378 src = src->head;
2636 2379
2637 prev = NULL; 2380 prev = 0;
2638 for (part = src; part; part = part->more) 2381 for (part = src; part; part = part->more)
2639 { 2382 {
2640 tmp = get_object (); 2383 tmp = part->clone ();
2641 copy_object (part, tmp);
2642 tmp->x -= src->x; 2384 tmp->x -= src->x;
2643 tmp->y -= src->y; 2385 tmp->y -= src->y;
2386
2644 if (!part->head) 2387 if (!part->head)
2645 { 2388 {
2646 dst = tmp; 2389 dst = tmp;
2647 tmp->head = NULL; 2390 tmp->head = 0;
2648 } 2391 }
2649 else 2392 else
2650 {
2651 tmp->head = dst; 2393 tmp->head = dst;
2652 } 2394
2653 tmp->more = NULL; 2395 tmp->more = 0;
2396
2654 if (prev) 2397 if (prev)
2655 prev->more = tmp; 2398 prev->more = tmp;
2399
2656 prev = tmp; 2400 prev = tmp;
2657 } 2401 }
2658 2402
2659 /*** copy inventory ***/
2660 for (item = src->inv; item; item = item->below) 2403 for (item = src->inv; item; item = item->below)
2661 {
2662 (void) insert_ob_in_ob (object_create_clone (item), dst); 2404 insert_ob_in_ob (object_create_clone (item), dst);
2663 }
2664 2405
2665 return dst; 2406 return dst;
2666} 2407}
2667 2408
2668/* return true if the object was destroyed, 0 otherwise */
2669int
2670was_destroyed (const object *op, tag_t old_tag)
2671{
2672 /* checking for FLAG_FREED isn't necessary, but makes this function more
2673 * robust */
2674 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2675}
2676
2677/* GROS - Creates an object using a string representing its content. */ 2409/* GROS - Creates an object using a string representing its content. */
2678
2679/* Basically, we save the content of the string to a temp file, then call */ 2410/* Basically, we save the content of the string to a temp file, then call */
2680
2681/* load_object on it. I admit it is a highly inefficient way to make things, */ 2411/* load_object on it. I admit it is a highly inefficient way to make things, */
2682
2683/* but it was simple to make and allows reusing the load_object function. */ 2412/* but it was simple to make and allows reusing the load_object function. */
2684
2685/* Remember not to use load_object_str in a time-critical situation. */ 2413/* Remember not to use load_object_str in a time-critical situation. */
2686
2687/* Also remember that multiparts objects are not supported for now. */ 2414/* Also remember that multiparts objects are not supported for now. */
2688
2689object * 2415object *
2690load_object_str (const char *obstr) 2416load_object_str (const char *obstr)
2691{ 2417{
2692 object * 2418 object *op;
2693 op;
2694 char
2695 filename[MAX_BUF]; 2419 char filename[MAX_BUF];
2696 2420
2697 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2421 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2698 2422
2699 FILE *
2700 tempfile = fopen (filename, "w"); 2423 FILE *tempfile = fopen (filename, "w");
2701 2424
2702 if (tempfile == NULL) 2425 if (tempfile == NULL)
2703 { 2426 {
2704 LOG (llevError, "Error - Unable to access load object temp file\n"); 2427 LOG (llevError, "Error - Unable to access load object temp file\n");
2705 return NULL; 2428 return NULL;
2706 } 2429 }
2707 2430
2708 fprintf (tempfile, obstr); 2431 fprintf (tempfile, obstr);
2709 fclose (tempfile); 2432 fclose (tempfile);
2710 2433
2711 op = get_object (); 2434 op = object::create ();
2712 2435
2713 object_thawer thawer (filename); 2436 object_thawer thawer (filename);
2714 2437
2715 if (thawer) 2438 if (thawer)
2716 load_object (thawer, op, 0); 2439 load_object (thawer, op, 0);
… …
2726 * returns NULL if no match. 2449 * returns NULL if no match.
2727 */ 2450 */
2728object * 2451object *
2729find_obj_by_type_subtype (const object *who, int type, int subtype) 2452find_obj_by_type_subtype (const object *who, int type, int subtype)
2730{ 2453{
2731 object *
2732 tmp;
2733
2734 for (tmp = who->inv; tmp; tmp = tmp->below) 2454 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2735 if (tmp->type == type && tmp->subtype == subtype) 2455 if (tmp->type == type && tmp->subtype == subtype)
2736 return tmp; 2456 return tmp;
2737 2457
2738 return NULL; 2458 return 0;
2739} 2459}
2740 2460
2741/* If ob has a field named key, return the link from the list, 2461/* If ob has a field named key, return the link from the list,
2742 * otherwise return NULL. 2462 * otherwise return NULL.
2743 * 2463 *
… …
2745 * do the desired thing. 2465 * do the desired thing.
2746 */ 2466 */
2747key_value * 2467key_value *
2748get_ob_key_link (const object *ob, const char *key) 2468get_ob_key_link (const object *ob, const char *key)
2749{ 2469{
2750 key_value *
2751 link;
2752
2753 for (link = ob->key_values; link != NULL; link = link->next) 2470 for (key_value *link = ob->key_values; link; link = link->next)
2754 {
2755 if (link->key == key) 2471 if (link->key == key)
2756 {
2757 return link; 2472 return link;
2758 }
2759 }
2760 2473
2761 return NULL; 2474 return 0;
2762} 2475}
2763 2476
2764/* 2477/*
2765 * Returns the value of op has an extra_field for key, or NULL. 2478 * Returns the value of op has an extra_field for key, or NULL.
2766 * 2479 *
… …
2806 * Returns TRUE on success. 2519 * Returns TRUE on success.
2807 */ 2520 */
2808int 2521int
2809set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2522set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2810{ 2523{
2811 key_value *
2812 field = NULL, *last = NULL; 2524 key_value *field = NULL, *last = NULL;
2813 2525
2814 for (field = op->key_values; field != NULL; field = field->next) 2526 for (field = op->key_values; field != NULL; field = field->next)
2815 { 2527 {
2816 if (field->key != canonical_key) 2528 if (field->key != canonical_key)
2817 { 2529 {
… …
2845 /* IF we get here, key doesn't exist */ 2557 /* IF we get here, key doesn't exist */
2846 2558
2847 /* No field, we'll have to add it. */ 2559 /* No field, we'll have to add it. */
2848 2560
2849 if (!add_key) 2561 if (!add_key)
2850 {
2851 return FALSE; 2562 return FALSE;
2852 } 2563
2853 /* There isn't any good reason to store a null 2564 /* There isn't any good reason to store a null
2854 * value in the key/value list. If the archetype has 2565 * value in the key/value list. If the archetype has
2855 * this key, then we should also have it, so shouldn't 2566 * this key, then we should also have it, so shouldn't
2856 * be here. If user wants to store empty strings, 2567 * be here. If user wants to store empty strings,
2857 * should pass in "" 2568 * should pass in ""
… …
2906 } 2617 }
2907 else 2618 else
2908 item = item->env; 2619 item = item->env;
2909} 2620}
2910 2621
2622
2623const char *
2624object::flag_desc (char *desc, int len) const
2625{
2626 char *p = desc;
2627 bool first = true;
2628
2629 *p = 0;
2630
2631 for (int i = 0; i < NUM_FLAGS; i++)
2632 {
2633 if (len <= 10) // magic constant!
2634 {
2635 snprintf (p, len, ",...");
2636 break;
2637 }
2638
2639 if (flag [i])
2640 {
2641 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2642 len -= cnt;
2643 p += cnt;
2644 first = false;
2645 }
2646 }
2647
2648 return desc;
2649}
2650
2911// return a suitable string describing an objetc in enough detail to find it 2651// return a suitable string describing an object in enough detail to find it
2912const char * 2652const char *
2913object::debug_desc (char *info) const 2653object::debug_desc (char *info) const
2914{ 2654{
2655 char flagdesc[512];
2915 char info2[256 * 3]; 2656 char info2[256 * 4];
2916 char *p = info; 2657 char *p = info;
2917 2658
2918 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2659 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2919 count, 2660 count, uuid.seq,
2920 &name, 2661 &name,
2921 title ? " " : "", 2662 title ? "\",title:" : "",
2922 title ? (const char *)title : ""); 2663 title ? (const char *)title : "",
2664 flag_desc (flagdesc, 512), type);
2923 2665
2924 if (env) 2666 if (env)
2925 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2667 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2926 2668
2927 if (map) 2669 if (map)
2928 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2670 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2929 2671
2930 return info; 2672 return info;
2931} 2673}
2932 2674
2933const char * 2675const char *
2934object::debug_desc () const 2676object::debug_desc () const
2935{ 2677{
2936 static char info[256 * 3]; 2678 static char info[256 * 4];
2937 return debug_desc (info); 2679 return debug_desc (info);
2938} 2680}
2939 2681

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines