ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.44 by root, Thu Sep 14 17:29:27 2006 UTC vs.
Revision 1.119 by root, Fri Jan 19 18:06:51 2007 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
4 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
7 7 *
8 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
11 (at your option) any later version. 11 * (at your option) any later version.
12 12 *
13 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details. 16 * GNU General Public License for more details.
17 17 *
18 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 21 *
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 27 variable. */
28#include <global.h> 28#include <global.h>
… …
31#include <sys/uio.h> 31#include <sys/uio.h>
32#include <object.h> 32#include <object.h>
33#include <funcpoint.h> 33#include <funcpoint.h>
34#include <loader.h> 34#include <loader.h>
35 35
36#include <bitset>
37
36int nrofallocobjects = 0; 38int nrofallocobjects = 0;
37static UUID uuid; 39static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
39 41
40object *objects; /* Pointer to the list of used objects */ 42objectvec objects;
41object *active_objects; /* List of active objects that need to be processed */ 43activevec actives;
42 44
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 47};
46short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
106 _exit (1); 108 _exit (1);
107 } 109 }
108 110
109 uuid.seq = uid; 111 uuid.seq = uid;
110 write_uuid (); 112 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 114 fclose (fp);
113} 115}
114 116
115UUID 117UUID
116gen_uuid () 118gen_uuid ()
… …
141 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
143 */ 145 */
144 146
145 /* For each field in wants, */ 147 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 149 {
148 key_value *has_field; 150 key_value *has_field;
149 151
150 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
… …
185 * 187 *
186 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
189 * 191 *
190 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
191 * 193 *
192 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
193 * check weight 195 * check weight
194 */ 196 */
195
196bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
197{ 198{
198 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
200 return 0; 205 return 0;
201 206
202 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 210 * used to store nrof).
208 */ 211 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 223
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 226
224 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 252 return 0;
256 253
257 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 255 * check all objects in the inventory.
259 */ 256 */
… …
262 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 261 return 0;
265 262
266 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 265 return 0;
269 266
270 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 268 * if it is valid.
272 */ 269 */
… …
281 278
282 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
284 * check? 281 * check?
285 */ 282 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 284 return 0;
288 285
289 switch (ob1->type) 286 switch (ob1->type)
290 { 287 {
291 case SCROLL: 288 case SCROLL:
… …
356 op = op->env; 353 op = op->env;
357 return op; 354 return op;
358} 355}
359 356
360/* 357/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 359 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
379 */ 361 */
380 362
381void 363char *
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 364dump_object (object *op)
437{ 365{
438 if (op == NULL) 366 if (!op)
439 { 367 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 368
447void 369 object_freezer freezer;
448dump_all_objects (void) 370 save_object (freezer, op, 1);
449{ 371 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 372}
458 373
459/* 374/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 376 * multi-object 1 which is closest to the second object.
… …
477} 392}
478 393
479/* 394/*
480 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
481 */ 396 */
482
483object * 397object *
484find_object (tag_t i) 398find_object (tag_t i)
485{ 399{
486 object *op; 400 for_all_objects (op)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 401 if (op->count == i)
490 break;
491 return op; 402 return op;
403
404 return 0;
492} 405}
493 406
494/* 407/*
495 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
497 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
498 */ 411 */
499
500object * 412object *
501find_object_name (const char *str) 413find_object_name (const char *str)
502{ 414{
503 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
504 object *op; 416 object *op;
505 417
506 for (op = objects; op != NULL; op = op->next) 418 for_all_objects (op)
507 if (op->name == str_) 419 if (op->name == str_)
508 break; 420 break;
509 421
510 return op; 422 return op;
511} 423}
… …
554 } 466 }
555 467
556 op->key_values = 0; 468 op->key_values = 0;
557} 469}
558 470
559void object::clear ()
560{
561 attachable_base::clear ();
562
563 free_key_values (this);
564
565 owner = 0;
566 name = 0;
567 name_pl = 0;
568 title = 0;
569 race = 0;
570 slaying = 0;
571 skill = 0;
572 msg = 0;
573 lore = 0;
574 custom_name = 0;
575 materialname = 0;
576 contr = 0;
577 below = 0;
578 above = 0;
579 inv = 0;
580 container = 0;
581 env = 0;
582 more = 0;
583 head = 0;
584 map = 0;
585 active_next = 0;
586 active_prev = 0;
587
588 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
589
590 SET_FLAG (this, FLAG_REMOVED);
591
592 /* What is not cleared is next, prev, and count */
593
594 expmul = 1.0;
595 face = blank_face;
596
597 if (settings.casting_time)
598 casting_time = -1;
599}
600
601void object::clone (object *destination)
602{
603 *(object_copy *)destination = *this;
604 *(object_pod *)destination = *this;
605
606 if (self || cb)
607 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
608}
609
610/* 471/*
611 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
612 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
613 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
614 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
615 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
616 * will point at garbage. 477 * will point at garbage.
617 */ 478 */
618void 479void
619copy_object (object *op2, object *op) 480object::copy_to (object *dst)
620{ 481{
621 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
622 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
623 484
624 op2->clone (op); 485 *(object_copy *)dst = *this;
625 486
626 if (is_freed) 487 if (is_freed)
627 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
628 if (is_removed) 490 if (is_removed)
629 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
630 492
631 if (op2->speed < 0) 493 if (speed < 0)
632 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
633 495
634 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
635 if (op2->key_values) 497 if (key_values)
636 { 498 {
637 key_value *tail = 0; 499 key_value *tail = 0;
638 key_value *i; 500 key_value *i;
639 501
640 op->key_values = 0; 502 dst->key_values = 0;
641 503
642 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
643 { 505 {
644 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
645 507
646 new_link->next = 0; 508 new_link->next = 0;
647 new_link->key = i->key; 509 new_link->key = i->key;
648 new_link->value = i->value; 510 new_link->value = i->value;
649 511
650 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
651 if (!op->key_values) 513 if (!dst->key_values)
652 { 514 {
653 op->key_values = new_link; 515 dst->key_values = new_link;
654 tail = new_link; 516 tail = new_link;
655 } 517 }
656 else 518 else
657 { 519 {
658 tail->next = new_link; 520 tail->next = new_link;
659 tail = new_link; 521 tail = new_link;
660 } 522 }
661 } 523 }
662 } 524 }
663 525
664 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
665} 535}
666 536
667/* 537/*
668 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
669 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
670 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
671 */ 541 */
672
673void 542void
674update_turn_face (object *op) 543update_turn_face (object *op)
675{ 544{
676 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
677 return; 546 return;
547
678 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
679 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
680} 550}
681 551
682/* 552/*
683 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
684 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
685 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
686 */ 556 */
687void 557void
688update_ob_speed (object *op) 558object::set_speed (float speed)
689{ 559{
690 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
691
692 /* No reason putting the archetypes objects on the speed list,
693 * since they never really need to be updated.
694 */
695
696 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
697 { 561 {
698 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
699#ifdef MANY_CORES
700 abort ();
701#else
702 op->speed = 0; 563 speed = 0;
703#endif
704 }
705
706 if (arch_init)
707 return;
708
709 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
710 { 564 }
711 /* If already on active list, don't do anything */
712 if (op->active_next || op->active_prev || op == active_objects)
713 return;
714 565
715 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
716 * of the list. */
717 op->active_next = active_objects;
718 567
719 if (op->active_next != NULL) 568 if (has_active_speed ())
720 op->active_next->active_prev = op; 569 activate ();
721
722 active_objects = op;
723 }
724 else 570 else
725 { 571 deactivate ();
726 /* If not on the active list, nothing needs to be done */
727 if (!op->active_next && !op->active_prev && op != active_objects)
728 return;
729
730 if (op->active_prev == NULL)
731 {
732 active_objects = op->active_next;
733
734 if (op->active_next != NULL)
735 op->active_next->active_prev = NULL;
736 }
737 else
738 {
739 op->active_prev->active_next = op->active_next;
740
741 if (op->active_next)
742 op->active_next->active_prev = op->active_prev;
743 }
744
745 op->active_next = NULL;
746 op->active_prev = NULL;
747 }
748} 572}
749 573
750/* This function removes object 'op' from the list of active
751 * objects.
752 * This should only be used for style maps or other such
753 * reference maps where you don't want an object that isn't
754 * in play chewing up cpu time getting processed.
755 * The reverse of this is to call update_ob_speed, which
756 * will do the right thing based on the speed of the object.
757 */
758void
759remove_from_active_list (object *op)
760{
761 /* If not on the active list, nothing needs to be done */
762 if (!op->active_next && !op->active_prev && op != active_objects)
763 return;
764
765 if (op->active_prev == NULL)
766 {
767 active_objects = op->active_next;
768 if (op->active_next != NULL)
769 op->active_next->active_prev = NULL;
770 }
771 else
772 {
773 op->active_prev->active_next = op->active_next;
774 if (op->active_next)
775 op->active_next->active_prev = op->active_prev;
776 }
777 op->active_next = NULL;
778 op->active_prev = NULL;
779}
780
781/* 574/*
782 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
783 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
784 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
785 * invisible object, etc...) 578 * invisible object, etc...)
786 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
787 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
788 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
789 * 582 *
790 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
791 * For example, if the only thing that has changed is the face (due to
792 * an animation), we don't need to call update_position until that actually
793 * comes into view of a player. OTOH, many other things, like addition/removal
794 * of walls or living creatures may need us to update the flags now.
795 * current action are: 584 * current action are:
796 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
797 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
798 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
799 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
800 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
801 */ 590 */
802
803void 591void
804update_object (object *op, int action) 592update_object (object *op, int action)
805{ 593{
806 int update_now = 0, flags;
807 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
808 595
809 if (op == NULL) 596 if (op == NULL)
810 { 597 {
811 /* this should never happen */ 598 /* this should never happen */
812 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
813 return; 600 return;
814 } 601 }
815 602
816 if (op->env != NULL) 603 if (op->env)
817 { 604 {
818 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
819 * to do in this case. 606 * to do in this case.
820 */ 607 */
821 return; 608 return;
… …
826 */ 613 */
827 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
828 return; 615 return;
829 616
830 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
831 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
832 { 619 {
833 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
834#ifdef MANY_CORES 621#ifdef MANY_CORES
835 abort (); 622 abort ();
836#endif 623#endif
837 return; 624 return;
838 } 625 }
839 626
840 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
841 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
842 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
843 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
844 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
845 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
846 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
847 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
848 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
849 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
850 update_now = 1;
851
852 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
853 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
854 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
855 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
856 update_now = 1;
857
858 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
859 update_now = 1;
860
861 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
862 update_now = 1;
863
864 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
865 update_now = 1;
866
867 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
868 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
869
870 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
871 * to have move_allow right now. 644 * to have move_allow right now.
872 */ 645 */
873 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
874 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
875 648 m.flags_ = 0;
876 if ((move_slow | op->move_slow) != move_slow)
877 update_now = 1;
878 } 649 }
879 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
880 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
881 * that is being removed. 652 * that is being removed.
882 */ 653 */
883 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
884 update_now = 1; 655 m.flags_ = 0;
885 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
886 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
887 else 658 else
888 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
889 660
890 if (update_now)
891 {
892 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
893 update_position (op->map, op->x, op->y);
894 }
895
896 if (op->more != NULL) 661 if (op->more)
897 update_object (op->more, action); 662 update_object (op->more, action);
898}
899
900static unordered_vector<object *> mortals;
901
902void object::free_mortals ()
903{
904 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
905 if ((*i)->refcnt)
906 ++i; // further delay freeing
907 else
908 {
909 delete *i;
910 mortals.erase (i);
911 }
912
913 static int lastmortals = 0;//D
914
915 if (mortals.size() != lastmortals)//D
916 {
917 lastmortals = mortals.size ();//D
918 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
919 }
920} 663}
921 664
922object::object () 665object::object ()
923{ 666{
924 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
… …
927 face = blank_face; 670 face = blank_face;
928} 671}
929 672
930object::~object () 673object::~object ()
931{ 674{
675 if (index)
676 unlink ();
677
932 free_key_values (this); 678 free_key_values (this);
933} 679}
934 680
681static int object_count;
682
935void object::link () 683void object::link ()
936{ 684{
937 count = ++ob_count; 685 assert (!index);//D
938 uuid = gen_uuid (); 686 uuid = gen_uuid ();
687 count = ++object_count;
939 688
940 prev = 0; 689 refcnt_inc ();
941 next = objects; 690 objects.insert (this);
942
943 if (objects)
944 objects->prev = this;
945
946 objects = this;
947} 691}
948 692
949void object::unlink () 693void object::unlink ()
950{ 694{
951 //count = 0;//D 695 assert (index);//D
952 if (!prev && !next) return;//D 696 objects.erase (this);
697 refcnt_dec ();
698}
953 699
954 if (this == objects) 700void
955 objects = next; 701object::activate ()
702{
703 /* If already on active list, don't do anything */
704 if (active)
705 return;
956 706
957 /* Remove this object from the list of used objects */ 707 if (has_active_speed ())
958 if (prev) prev->next = next; 708 actives.insert (this);
959 if (next) next->prev = prev; 709}
960 710
961 prev = 0; 711void
962 next = 0; 712object::activate_recursive ()
713{
714 activate ();
715
716 for (object *op = inv; op; op = op->below)
717 op->activate_recursive ();
718}
719
720/* This function removes object 'op' from the list of active
721 * objects.
722 * This should only be used for style maps or other such
723 * reference maps where you don't want an object that isn't
724 * in play chewing up cpu time getting processed.
725 * The reverse of this is to call update_ob_speed, which
726 * will do the right thing based on the speed of the object.
727 */
728void
729object::deactivate ()
730{
731 /* If not on the active list, nothing needs to be done */
732 if (!active)
733 return;
734
735 actives.erase (this);
736}
737
738void
739object::deactivate_recursive ()
740{
741 for (object *op = inv; op; op = op->below)
742 op->deactivate_recursive ();
743
744 deactivate ();
745}
746
747void
748object::set_flag_inv (int flag, int value)
749{
750 for (object *op = inv; op; op = op->below)
751 {
752 op->flag [flag] = value;
753 op->set_flag_inv (flag, value);
754 }
755}
756
757/*
758 * Remove and free all objects in the inventory of the given object.
759 * object.c ?
760 */
761void
762object::destroy_inv (bool drop_to_ground)
763{
764 // need to check first, because the checks below might segfault
765 // as we might be on an invalid mapspace and crossfire code
766 // is too buggy to ensure that the inventory is empty.
767 // corollary: if you create arrows etc. with stuff in tis inventory,
768 // cf will crash below with off-map x and y
769 if (!inv)
770 return;
771
772 /* Only if the space blocks everything do we not process -
773 * if some form of movement is allowed, let objects
774 * drop on that space.
775 */
776 if (!drop_to_ground
777 || !map
778 || map->in_memory != MAP_IN_MEMORY
779 || ms ().move_block == MOVE_ALL)
780 {
781 while (inv)
782 {
783 inv->destroy_inv (drop_to_ground);
784 inv->destroy ();
785 }
786 }
787 else
788 { /* Put objects in inventory onto this space */
789 while (inv)
790 {
791 object *op = inv;
792
793 if (op->flag [FLAG_STARTEQUIP]
794 || op->flag [FLAG_NO_DROP]
795 || op->type == RUNE
796 || op->type == TRAP
797 || op->flag [FLAG_IS_A_TEMPLATE]
798 || op->flag [FLAG_DESTROY_ON_DEATH])
799 op->destroy ();
800 else
801 map->insert (op, x, y);
802 }
803 }
963} 804}
964 805
965object *object::create () 806object *object::create ()
966{ 807{
967 object *op = new object; 808 object *op = new object;
968 op->link (); 809 op->link ();
969 return op; 810 return op;
970} 811}
971 812
972/* 813void
973 * free_object() frees everything allocated by an object, removes 814object::do_destroy ()
974 * it from the list of used objects, and puts it on the list of
975 * free objects. The IS_FREED() flag is set in the object.
976 * The object must have been removed by remove_ob() first for
977 * this function to succeed.
978 *
979 * If free_inventory is set, free inventory as well. Else drop items in
980 * inventory to the ground.
981 */
982void object::free (bool free_inventory)
983{ 815{
984 if (QUERY_FLAG (this, FLAG_FREED)) 816 attachable::do_destroy ();
985 return;
986 817
987 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 818 if (flag [FLAG_IS_LINKED])
819 remove_button_link (this);
820
821 if (flag [FLAG_FRIENDLY])
988 remove_friendly_object (this); 822 remove_friendly_object (this);
989 823
990 if (!QUERY_FLAG (this, FLAG_REMOVED)) 824 if (!flag [FLAG_REMOVED])
991 remove_ob (this); 825 remove ();
992 826
993 SET_FLAG (this, FLAG_FREED); 827 destroy_inv (true);
828
829 deactivate ();
830 unlink ();
831
832 flag [FLAG_FREED] = 1;
833
834 // hack to ensure that freed objects still have a valid map
835 {
836 static maptile *freed_map; // freed objects are moved here to avoid crashes
837
838 if (!freed_map)
839 {
840 freed_map = new maptile;
841
842 freed_map->name = "/internal/freed_objects_map";
843 freed_map->width = 3;
844 freed_map->height = 3;
845
846 freed_map->alloc ();
847 freed_map->in_memory = MAP_IN_MEMORY;
848 }
849
850 map = freed_map;
851 x = 1;
852 y = 1;
853 }
854
855 head = 0;
994 856
995 if (more) 857 if (more)
996 { 858 {
997 more->free (free_inventory); 859 more->destroy ();
998 more = 0; 860 more = 0;
999 }
1000
1001 if (inv)
1002 {
1003 /* Only if the space blocks everything do we not process -
1004 * if some form of movement is allowed, let objects
1005 * drop on that space.
1006 */
1007 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1008 {
1009 object *op = inv;
1010
1011 while (op)
1012 {
1013 object *tmp = op->below;
1014 op->free (free_inventory);
1015 op = tmp;
1016 }
1017 }
1018 else
1019 { /* Put objects in inventory onto this space */
1020 object *op = inv;
1021
1022 while (op)
1023 {
1024 object *tmp = op->below;
1025
1026 remove_ob (op);
1027
1028 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1029 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1030 free_object (op);
1031 else
1032 {
1033 op->x = x;
1034 op->y = y;
1035 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1036 }
1037
1038 op = tmp;
1039 }
1040 }
1041 } 861 }
1042 862
1043 // clear those pointers that likely might have circular references to us 863 // clear those pointers that likely might have circular references to us
1044 owner = 0; 864 owner = 0;
1045 enemy = 0; 865 enemy = 0;
1046 attacked_by = 0; 866 attacked_by = 0;
867}
1047 868
1048 /* Remove object from the active list */ 869void
1049 speed = 0; 870object::destroy (bool destroy_inventory)
1050 update_ob_speed (this); 871{
872 if (destroyed ())
873 return;
1051 874
1052 unlink (); 875 if (destroy_inventory)
876 destroy_inv (false);
1053 877
1054 mortals.push_back (this); 878 attachable::destroy ();
1055} 879}
1056 880
1057/* 881/*
1058 * sub_weight() recursively (outwards) subtracts a number from the 882 * sub_weight() recursively (outwards) subtracts a number from the
1059 * weight of an object (and what is carried by it's environment(s)). 883 * weight of an object (and what is carried by it's environment(s)).
1060 */ 884 */
1061
1062void 885void
1063sub_weight (object *op, signed long weight) 886sub_weight (object *op, signed long weight)
1064{ 887{
1065 while (op != NULL) 888 while (op != NULL)
1066 { 889 {
1067 if (op->type == CONTAINER) 890 if (op->type == CONTAINER)
1068 {
1069 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 891 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1070 } 892
1071 op->carrying -= weight; 893 op->carrying -= weight;
1072 op = op->env; 894 op = op->env;
1073 } 895 }
1074} 896}
1075 897
1076/* remove_ob(op): 898/* op->remove ():
1077 * This function removes the object op from the linked list of objects 899 * This function removes the object op from the linked list of objects
1078 * which it is currently tied to. When this function is done, the 900 * which it is currently tied to. When this function is done, the
1079 * object will have no environment. If the object previously had an 901 * object will have no environment. If the object previously had an
1080 * environment, the x and y coordinates will be updated to 902 * environment, the x and y coordinates will be updated to
1081 * the previous environment. 903 * the previous environment.
1082 * Beware: This function is called from the editor as well! 904 * Beware: This function is called from the editor as well!
1083 */ 905 */
1084
1085void 906void
1086remove_ob (object *op) 907object::remove_slow ()
1087{ 908{
909 object *tmp, *last = 0;
1088 object * 910 object *otmp;
1089 tmp, *
1090 last = NULL;
1091 object *
1092 otmp;
1093 911
1094 tag_t
1095 tag;
1096 int
1097 check_walk_off;
1098 mapstruct *
1099 m;
1100
1101 sint16
1102 x,
1103 y;
1104
1105 if (QUERY_FLAG (op, FLAG_REMOVED)) 912 if (QUERY_FLAG (this, FLAG_REMOVED))
1106 return; 913 return;
1107 914
1108 SET_FLAG (op, FLAG_REMOVED); 915 SET_FLAG (this, FLAG_REMOVED);
916 INVOKE_OBJECT (REMOVE, this);
1109 917
1110 if (op->more != NULL) 918 if (more)
1111 remove_ob (op->more); 919 more->remove ();
1112 920
1113 /* 921 /*
1114 * In this case, the object to be removed is in someones 922 * In this case, the object to be removed is in someones
1115 * inventory. 923 * inventory.
1116 */ 924 */
1117 if (op->env != NULL) 925 if (env)
1118 { 926 {
1119 if (op->nrof) 927 if (nrof)
1120 sub_weight (op->env, op->weight * op->nrof); 928 sub_weight (env, weight * nrof);
1121 else 929 else
1122 sub_weight (op->env, op->weight + op->carrying); 930 sub_weight (env, weight + carrying);
1123 931
1124 /* NO_FIX_PLAYER is set when a great many changes are being 932 /* NO_FIX_PLAYER is set when a great many changes are being
1125 * made to players inventory. If set, avoiding the call 933 * made to players inventory. If set, avoiding the call
1126 * to save cpu time. 934 * to save cpu time.
1127 */ 935 */
1128 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 936 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1129 fix_player (otmp); 937 otmp->update_stats ();
1130 938
1131 if (op->above != NULL) 939 if (above)
1132 op->above->below = op->below; 940 above->below = below;
1133 else 941 else
1134 op->env->inv = op->below; 942 env->inv = below;
1135 943
1136 if (op->below != NULL) 944 if (below)
1137 op->below->above = op->above; 945 below->above = above;
1138 946
1139 /* we set up values so that it could be inserted into 947 /* we set up values so that it could be inserted into
1140 * the map, but we don't actually do that - it is up 948 * the map, but we don't actually do that - it is up
1141 * to the caller to decide what we want to do. 949 * to the caller to decide what we want to do.
1142 */ 950 */
1143 op->x = op->env->x, op->y = op->env->y; 951 x = env->x, y = env->y;
1144 op->map = op->env->map; 952 map = env->map;
1145 op->above = NULL, op->below = NULL; 953 above = 0, below = 0;
1146 op->env = NULL; 954 env = 0;
1147 } 955 }
1148 else if (op->map) 956 else if (map)
1149 { 957 {
1150 x = op->x; 958 if (type == PLAYER)
1151 y = op->y;
1152 m = get_map_from_coord (op->map, &x, &y);
1153
1154 if (!m)
1155 { 959 {
1156 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 960 --map->players;
1157 op->map->path, op->x, op->y); 961 map->touch ();
1158 /* in old days, we used to set x and y to 0 and continue.
1159 * it seems if we get into this case, something is probablye
1160 * screwed up and should be fixed.
1161 */
1162 abort ();
1163 } 962 }
1164 963
1165 if (op->map != m) 964 map->dirty = true;
1166 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 965 mapspace &ms = this->ms ();
1167 op->map->path, m->path, op->x, op->y, x, y);
1168
1169 /* Re did the following section of code - it looks like it had
1170 * lots of logic for things we no longer care about
1171 */
1172 966
1173 /* link the object above us */ 967 /* link the object above us */
1174 if (op->above) 968 if (above)
1175 op->above->below = op->below; 969 above->below = below;
1176 else 970 else
1177 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 971 ms.top = below; /* we were top, set new top */
1178 972
1179 /* Relink the object below us, if there is one */ 973 /* Relink the object below us, if there is one */
1180 if (op->below) 974 if (below)
1181 op->below->above = op->above; 975 below->above = above;
1182 else 976 else
1183 { 977 {
1184 /* Nothing below, which means we need to relink map object for this space 978 /* Nothing below, which means we need to relink map object for this space
1185 * use translated coordinates in case some oddness with map tiling is 979 * use translated coordinates in case some oddness with map tiling is
1186 * evident 980 * evident
1187 */ 981 */
1188 if (GET_MAP_OB (m, x, y) != op) 982 if (GET_MAP_OB (map, x, y) != this)
1189 {
1190 dump_object (op);
1191 LOG (llevError,
1192 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 983 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1193 dump_object (GET_MAP_OB (m, x, y));
1194 LOG (llevError, "%s\n", errmsg);
1195 }
1196 984
1197 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 985 ms.bot = above; /* goes on above it. */
1198 } 986 }
1199 987
1200 op->above = 0; 988 above = 0;
1201 op->below = 0; 989 below = 0;
1202 990
1203 if (op->map->in_memory == MAP_SAVING) 991 if (map->in_memory == MAP_SAVING)
1204 return; 992 return;
1205 993
1206 tag = op->count; 994 int check_walk_off = !flag [FLAG_NO_APPLY];
1207 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1208 995
1209 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 996 for (tmp = ms.bot; tmp; tmp = tmp->above)
1210 { 997 {
1211 /* No point updating the players look faces if he is the object 998 /* No point updating the players look faces if he is the object
1212 * being removed. 999 * being removed.
1213 */ 1000 */
1214 1001
1215 if (tmp->type == PLAYER && tmp != op) 1002 if (tmp->type == PLAYER && tmp != this)
1216 { 1003 {
1217 /* If a container that the player is currently using somehow gets 1004 /* If a container that the player is currently using somehow gets
1218 * removed (most likely destroyed), update the player view 1005 * removed (most likely destroyed), update the player view
1219 * appropriately. 1006 * appropriately.
1220 */ 1007 */
1221 if (tmp->container == op) 1008 if (tmp->container == this)
1222 { 1009 {
1223 CLEAR_FLAG (op, FLAG_APPLIED); 1010 flag [FLAG_APPLIED] = 0;
1224 tmp->container = NULL; 1011 tmp->container = 0;
1225 } 1012 }
1226 1013
1227 tmp->contr->socket.update_look = 1; 1014 if (tmp->contr->ns)
1015 tmp->contr->ns->floorbox_update ();
1228 } 1016 }
1229 1017
1230 /* See if player moving off should effect something */ 1018 /* See if object moving off should effect something */
1231 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1019 if (check_walk_off
1020 && ((move_type & tmp->move_off)
1021 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1232 { 1022 {
1233 move_apply (tmp, op, NULL); 1023 move_apply (tmp, this, 0);
1234 1024
1235 if (was_destroyed (op, tag)) 1025 if (destroyed ())
1236 {
1237 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1026 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1238 }
1239 } 1027 }
1240 1028
1241 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1029 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1242 1030 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1243 if (tmp->above == tmp) 1031 if (tmp->above == tmp)
1244 tmp->above = NULL; 1032 tmp->above = 0;
1245 1033
1246 last = tmp; 1034 last = tmp;
1247 } 1035 }
1248 1036
1249 /* last == NULL of there are no objects on this space */ 1037 /* last == NULL if there are no objects on this space */
1038 //TODO: this makes little sense, why only update the topmost object?
1250 if (last == NULL) 1039 if (!last)
1251 { 1040 map->at (x, y).flags_ = 0;
1252 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1253 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1254 * those out anyways, and if there are any flags set right now, they won't
1255 * be correct anyways.
1256 */
1257 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1258 update_position (op->map, op->x, op->y);
1259 }
1260 else 1041 else
1261 update_object (last, UP_OBJ_REMOVE); 1042 update_object (last, UP_OBJ_REMOVE);
1262 1043
1263 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1044 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1264 update_all_los (op->map, op->x, op->y); 1045 update_all_los (map, x, y);
1265 } 1046 }
1266} 1047}
1267 1048
1268/* 1049/*
1269 * merge_ob(op,top): 1050 * merge_ob(op,top):
… …
1277merge_ob (object *op, object *top) 1058merge_ob (object *op, object *top)
1278{ 1059{
1279 if (!op->nrof) 1060 if (!op->nrof)
1280 return 0; 1061 return 0;
1281 1062
1282 if (top == NULL) 1063 if (top)
1283 for (top = op; top != NULL && top->above != NULL; top = top->above); 1064 for (top = op; top && top->above; top = top->above)
1065 ;
1284 1066
1285 for (; top != NULL; top = top->below) 1067 for (; top; top = top->below)
1286 { 1068 {
1287 if (top == op) 1069 if (top == op)
1288 continue; 1070 continue;
1289 if (CAN_MERGE (op, top)) 1071
1072 if (object::can_merge (op, top))
1290 { 1073 {
1291 top->nrof += op->nrof; 1074 top->nrof += op->nrof;
1292 1075
1293/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1076/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1294 op->weight = 0; /* Don't want any adjustements now */ 1077 op->weight = 0; /* Don't want any adjustements now */
1295 remove_ob (op); 1078 op->destroy ();
1296 free_object (op);
1297 return top; 1079 return top;
1298 } 1080 }
1299 } 1081 }
1300 1082
1301 return NULL; 1083 return 0;
1302} 1084}
1303 1085
1304/* 1086/*
1305 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1087 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1306 * job preparing multi-part monsters 1088 * job preparing multi-part monsters.
1307 */ 1089 */
1308object * 1090object *
1309insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1091insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1310{ 1092{
1311 object *tmp;
1312
1313 if (op->head)
1314 op = op->head;
1315
1316 for (tmp = op; tmp; tmp = tmp->more) 1093 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1317 { 1094 {
1318 tmp->x = x + tmp->arch->clone.x; 1095 tmp->x = x + tmp->arch->clone.x;
1319 tmp->y = y + tmp->arch->clone.y; 1096 tmp->y = y + tmp->arch->clone.y;
1320 } 1097 }
1321 1098
… …
1340 * Return value: 1117 * Return value:
1341 * new object if 'op' was merged with other object 1118 * new object if 'op' was merged with other object
1342 * NULL if 'op' was destroyed 1119 * NULL if 'op' was destroyed
1343 * just 'op' otherwise 1120 * just 'op' otherwise
1344 */ 1121 */
1345
1346object * 1122object *
1347insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1123insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1348{ 1124{
1349 object *tmp, *top, *floor = NULL; 1125 object *tmp, *top, *floor = NULL;
1350 sint16 x, y;
1351 1126
1352 if (QUERY_FLAG (op, FLAG_FREED)) 1127 if (QUERY_FLAG (op, FLAG_FREED))
1353 { 1128 {
1354 LOG (llevError, "Trying to insert freed object!\n"); 1129 LOG (llevError, "Trying to insert freed object!\n");
1355 return NULL; 1130 return NULL;
1356 } 1131 }
1357 1132
1358 if (m == NULL) 1133 if (!QUERY_FLAG (op, FLAG_REMOVED))
1134 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1135
1136 op->remove ();
1137
1138 if (!m)
1359 { 1139 {
1360 dump_object (op); 1140 char *dump = dump_object (op);
1361 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1141 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1142 free (dump);
1362 return op; 1143 return op;
1363 } 1144 }
1364 1145
1365 if (out_of_map (m, op->x, op->y)) 1146 if (out_of_map (m, op->x, op->y))
1366 { 1147 {
1367 dump_object (op); 1148 char *dump = dump_object (op);
1368 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1149 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1369#ifdef MANY_CORES 1150#ifdef MANY_CORES
1370 /* Better to catch this here, as otherwise the next use of this object 1151 /* Better to catch this here, as otherwise the next use of this object
1371 * is likely to cause a crash. Better to find out where it is getting 1152 * is likely to cause a crash. Better to find out where it is getting
1372 * improperly inserted. 1153 * improperly inserted.
1373 */ 1154 */
1374 abort (); 1155 abort ();
1375#endif 1156#endif
1157 free (dump);
1376 return op; 1158 return op;
1377 } 1159 }
1378 1160
1379 if (!QUERY_FLAG (op, FLAG_REMOVED))
1380 {
1381 dump_object (op);
1382 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1383 return op;
1384 }
1385
1386 if (op->more != NULL)
1387 {
1388 /* The part may be on a different map. */
1389
1390 object *more = op->more; 1161 if (object *more = op->more)
1391 1162 {
1392 /* We really need the caller to normalize coordinates - if
1393 * we set the map, that doesn't work if the location is within
1394 * a map and this is straddling an edge. So only if coordinate
1395 * is clear wrong do we normalize it.
1396 */
1397 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1398 more->map = get_map_from_coord (m, &more->x, &more->y);
1399 else if (!more->map)
1400 {
1401 /* For backwards compatibility - when not dealing with tiled maps,
1402 * more->map should always point to the parent.
1403 */
1404 more->map = m;
1405 }
1406
1407 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1163 if (!insert_ob_in_map (more, m, originator, flag))
1408 { 1164 {
1409 if (!op->head) 1165 if (!op->head)
1410 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1166 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1411 1167
1412 return NULL; 1168 return 0;
1413 } 1169 }
1414 } 1170 }
1415 1171
1416 CLEAR_FLAG (op, FLAG_REMOVED); 1172 CLEAR_FLAG (op, FLAG_REMOVED);
1417 1173
1418 /* Ideally, the caller figures this out. However, it complicates a lot 1174 /* Ideally, the caller figures this out. However, it complicates a lot
1419 * of areas of callers (eg, anything that uses find_free_spot would now 1175 * of areas of callers (eg, anything that uses find_free_spot would now
1420 * need extra work 1176 * need extra work
1421 */ 1177 */
1422 op->map = get_map_from_coord (m, &op->x, &op->y); 1178 if (!xy_normalise (m, op->x, op->y))
1423 x = op->x; 1179 return 0;
1424 y = op->y; 1180
1181 op->map = m;
1182 mapspace &ms = op->ms ();
1425 1183
1426 /* this has to be done after we translate the coordinates. 1184 /* this has to be done after we translate the coordinates.
1427 */ 1185 */
1428 if (op->nrof && !(flag & INS_NO_MERGE)) 1186 if (op->nrof && !(flag & INS_NO_MERGE))
1429 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1187 for (tmp = ms.bot; tmp; tmp = tmp->above)
1430 if (CAN_MERGE (op, tmp)) 1188 if (object::can_merge (op, tmp))
1431 { 1189 {
1432 op->nrof += tmp->nrof; 1190 op->nrof += tmp->nrof;
1433 remove_ob (tmp); 1191 tmp->destroy ();
1434 free_object (tmp);
1435 } 1192 }
1436 1193
1437 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1194 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1438 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1195 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1439 1196
… …
1452 op->below = originator->below; 1209 op->below = originator->below;
1453 1210
1454 if (op->below) 1211 if (op->below)
1455 op->below->above = op; 1212 op->below->above = op;
1456 else 1213 else
1457 SET_MAP_OB (op->map, op->x, op->y, op); 1214 ms.bot = op;
1458 1215
1459 /* since *below* originator, no need to update top */ 1216 /* since *below* originator, no need to update top */
1460 originator->below = op; 1217 originator->below = op;
1461 } 1218 }
1462 else 1219 else
1463 { 1220 {
1221 top = ms.bot;
1222
1464 /* If there are other objects, then */ 1223 /* If there are other objects, then */
1465 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1224 if ((!(flag & INS_MAP_LOAD)) && top)
1466 { 1225 {
1467 object *last = NULL; 1226 object *last = 0;
1468 1227
1469 /* 1228 /*
1470 * If there are multiple objects on this space, we do some trickier handling. 1229 * If there are multiple objects on this space, we do some trickier handling.
1471 * We've already dealt with merging if appropriate. 1230 * We've already dealt with merging if appropriate.
1472 * Generally, we want to put the new object on top. But if 1231 * Generally, we want to put the new object on top. But if
… …
1476 * once we get to them. This reduces the need to traverse over all of 1235 * once we get to them. This reduces the need to traverse over all of
1477 * them when adding another one - this saves quite a bit of cpu time 1236 * them when adding another one - this saves quite a bit of cpu time
1478 * when lots of spells are cast in one area. Currently, it is presumed 1237 * when lots of spells are cast in one area. Currently, it is presumed
1479 * that flying non pickable objects are spell objects. 1238 * that flying non pickable objects are spell objects.
1480 */ 1239 */
1481 1240 for (top = ms.bot; top; top = top->above)
1482 while (top != NULL)
1483 { 1241 {
1484 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1242 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1485 floor = top; 1243 floor = top;
1486 1244
1487 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1245 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1490 top = top->below; 1248 top = top->below;
1491 break; 1249 break;
1492 } 1250 }
1493 1251
1494 last = top; 1252 last = top;
1495 top = top->above;
1496 } 1253 }
1497 1254
1498 /* Don't want top to be NULL, so set it to the last valid object */ 1255 /* Don't want top to be NULL, so set it to the last valid object */
1499 top = last; 1256 top = last;
1500 1257
… …
1507 * Unless those objects are exits, type 66 1264 * Unless those objects are exits, type 66
1508 * If INS_ON_TOP is used, don't do this processing 1265 * If INS_ON_TOP is used, don't do this processing
1509 * Need to find the object that in fact blocks view, otherwise 1266 * Need to find the object that in fact blocks view, otherwise
1510 * stacking is a bit odd. 1267 * stacking is a bit odd.
1511 */ 1268 */
1512 if (!(flag & INS_ON_TOP) && 1269 if (!(flag & INS_ON_TOP)
1513 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1270 && ms.flags () & P_BLOCKSVIEW
1271 && (op->face && !op->face->visibility))
1514 { 1272 {
1515 for (last = top; last != floor; last = last->below) 1273 for (last = top; last != floor; last = last->below)
1516 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1274 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1517 break; 1275 break;
1276
1518 /* Check to see if we found the object that blocks view, 1277 /* Check to see if we found the object that blocks view,
1519 * and make sure we have a below pointer for it so that 1278 * and make sure we have a below pointer for it so that
1520 * we can get inserted below this one, which requires we 1279 * we can get inserted below this one, which requires we
1521 * set top to the object below us. 1280 * set top to the object below us.
1522 */ 1281 */
… …
1524 top = last->below; 1283 top = last->below;
1525 } 1284 }
1526 } /* If objects on this space */ 1285 } /* If objects on this space */
1527 1286
1528 if (flag & INS_MAP_LOAD) 1287 if (flag & INS_MAP_LOAD)
1529 top = GET_MAP_TOP (op->map, op->x, op->y); 1288 top = ms.top;
1530 1289
1531 if (flag & INS_ABOVE_FLOOR_ONLY) 1290 if (flag & INS_ABOVE_FLOOR_ONLY)
1532 top = floor; 1291 top = floor;
1533 1292
1534 /* Top is the object that our object (op) is going to get inserted above. 1293 /* Top is the object that our object (op) is going to get inserted above.
1535 */ 1294 */
1536 1295
1537 /* First object on this space */ 1296 /* First object on this space */
1538 if (!top) 1297 if (!top)
1539 { 1298 {
1540 op->above = GET_MAP_OB (op->map, op->x, op->y); 1299 op->above = ms.bot;
1541 1300
1542 if (op->above) 1301 if (op->above)
1543 op->above->below = op; 1302 op->above->below = op;
1544 1303
1545 op->below = NULL; 1304 op->below = 0;
1546 SET_MAP_OB (op->map, op->x, op->y, op); 1305 ms.bot = op;
1547 } 1306 }
1548 else 1307 else
1549 { /* get inserted into the stack above top */ 1308 { /* get inserted into the stack above top */
1550 op->above = top->above; 1309 op->above = top->above;
1551 1310
… …
1554 1313
1555 op->below = top; 1314 op->below = top;
1556 top->above = op; 1315 top->above = op;
1557 } 1316 }
1558 1317
1559 if (op->above == NULL) 1318 if (!op->above)
1560 SET_MAP_TOP (op->map, op->x, op->y, op); 1319 ms.top = op;
1561 } /* else not INS_BELOW_ORIGINATOR */ 1320 } /* else not INS_BELOW_ORIGINATOR */
1562 1321
1563 if (op->type == PLAYER) 1322 if (op->type == PLAYER)
1323 {
1564 op->contr->do_los = 1; 1324 op->contr->do_los = 1;
1325 ++op->map->players;
1326 op->map->touch ();
1327 }
1328
1329 op->map->dirty = true;
1565 1330
1566 /* If we have a floor, we know the player, if any, will be above 1331 /* If we have a floor, we know the player, if any, will be above
1567 * it, so save a few ticks and start from there. 1332 * it, so save a few ticks and start from there.
1568 */ 1333 */
1569 if (!(flag & INS_MAP_LOAD)) 1334 if (!(flag & INS_MAP_LOAD))
1570 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1335 if (object *pl = ms.player ())
1571 if (tmp->type == PLAYER) 1336 if (pl->contr->ns)
1572 tmp->contr->socket.update_look = 1; 1337 pl->contr->ns->floorbox_update ();
1573 1338
1574 /* If this object glows, it may affect lighting conditions that are 1339 /* If this object glows, it may affect lighting conditions that are
1575 * visible to others on this map. But update_all_los is really 1340 * visible to others on this map. But update_all_los is really
1576 * an inefficient way to do this, as it means los for all players 1341 * an inefficient way to do this, as it means los for all players
1577 * on the map will get recalculated. The players could very well 1342 * on the map will get recalculated. The players could very well
1578 * be far away from this change and not affected in any way - 1343 * be far away from this change and not affected in any way -
1579 * this should get redone to only look for players within range, 1344 * this should get redone to only look for players within range,
1580 * or just updating the P_NEED_UPDATE for spaces within this area 1345 * or just updating the P_UPTODATE for spaces within this area
1581 * of effect may be sufficient. 1346 * of effect may be sufficient.
1582 */ 1347 */
1583 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1348 if (op->map->darkness && (op->glow_radius != 0))
1584 update_all_los (op->map, op->x, op->y); 1349 update_all_los (op->map, op->x, op->y);
1585 1350
1586 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1351 /* updates flags (blocked, alive, no magic, etc) for this map space */
1587 update_object (op, UP_OBJ_INSERT); 1352 update_object (op, UP_OBJ_INSERT);
1588 1353
1354 INVOKE_OBJECT (INSERT, op);
1355
1589 /* Don't know if moving this to the end will break anything. However, 1356 /* Don't know if moving this to the end will break anything. However,
1590 * we want to have update_look set above before calling this. 1357 * we want to have floorbox_update called before calling this.
1591 * 1358 *
1592 * check_move_on() must be after this because code called from 1359 * check_move_on() must be after this because code called from
1593 * check_move_on() depends on correct map flags (so functions like 1360 * check_move_on() depends on correct map flags (so functions like
1594 * blocked() and wall() work properly), and these flags are updated by 1361 * blocked() and wall() work properly), and these flags are updated by
1595 * update_object(). 1362 * update_object().
… …
1597 1364
1598 /* if this is not the head or flag has been passed, don't check walk on status */ 1365 /* if this is not the head or flag has been passed, don't check walk on status */
1599 if (!(flag & INS_NO_WALK_ON) && !op->head) 1366 if (!(flag & INS_NO_WALK_ON) && !op->head)
1600 { 1367 {
1601 if (check_move_on (op, originator)) 1368 if (check_move_on (op, originator))
1602 return NULL; 1369 return 0;
1603 1370
1604 /* If we are a multi part object, lets work our way through the check 1371 /* If we are a multi part object, lets work our way through the check
1605 * walk on's. 1372 * walk on's.
1606 */ 1373 */
1607 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1374 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1608 if (check_move_on (tmp, originator)) 1375 if (check_move_on (tmp, originator))
1609 return NULL; 1376 return 0;
1610 } 1377 }
1611 1378
1612 return op; 1379 return op;
1613} 1380}
1614 1381
1615/* this function inserts an object in the map, but if it 1382/* this function inserts an object in the map, but if it
1616 * finds an object of its own type, it'll remove that one first. 1383 * finds an object of its own type, it'll remove that one first.
1617 * op is the object to insert it under: supplies x and the map. 1384 * op is the object to insert it under: supplies x and the map.
1618 */ 1385 */
1619void 1386void
1620replace_insert_ob_in_map (const char *arch_string, object *op) 1387replace_insert_ob_in_map (const char *arch_string, object *op)
1621{ 1388{
1622 object * 1389 object *tmp, *tmp1;
1623 tmp;
1624 object *
1625 tmp1;
1626 1390
1627 /* first search for itself and remove any old instances */ 1391 /* first search for itself and remove any old instances */
1628 1392
1629 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1393 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1630 {
1631 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1394 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1632 { 1395 tmp->destroy ();
1633 remove_ob (tmp);
1634 free_object (tmp);
1635 }
1636 }
1637 1396
1638 tmp1 = arch_to_object (find_archetype (arch_string)); 1397 tmp1 = arch_to_object (archetype::find (arch_string));
1639 1398
1640 tmp1->x = op->x; 1399 tmp1->x = op->x;
1641 tmp1->y = op->y; 1400 tmp1->y = op->y;
1642 insert_ob_in_map (tmp1, op->map, op, 0); 1401 insert_ob_in_map (tmp1, op->map, op, 0);
1402}
1403
1404object *
1405object::insert_at (object *where, object *originator, int flags)
1406{
1407 where->map->insert (this, where->x, where->y, originator, flags);
1643} 1408}
1644 1409
1645/* 1410/*
1646 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1411 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1647 * is returned contains nr objects, and the remaining parts contains 1412 * is returned contains nr objects, and the remaining parts contains
1648 * the rest (or is removed and freed if that number is 0). 1413 * the rest (or is removed and freed if that number is 0).
1649 * On failure, NULL is returned, and the reason put into the 1414 * On failure, NULL is returned, and the reason put into the
1650 * global static errmsg array. 1415 * global static errmsg array.
1651 */ 1416 */
1652
1653object * 1417object *
1654get_split_ob (object *orig_ob, uint32 nr) 1418get_split_ob (object *orig_ob, uint32 nr)
1655{ 1419{
1656 object * 1420 object *newob;
1657 newob;
1658 int
1659 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1421 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1660 1422
1661 if (orig_ob->nrof < nr) 1423 if (orig_ob->nrof < nr)
1662 { 1424 {
1663 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1425 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1664 return NULL; 1426 return NULL;
1665 } 1427 }
1666 1428
1667 newob = object_create_clone (orig_ob); 1429 newob = object_create_clone (orig_ob);
1668 1430
1669 if ((orig_ob->nrof -= nr) < 1) 1431 if ((orig_ob->nrof -= nr) < 1)
1670 { 1432 orig_ob->destroy (1);
1671 if (!is_removed)
1672 remove_ob (orig_ob);
1673 free_object2 (orig_ob, 1);
1674 }
1675 else if (!is_removed) 1433 else if (!is_removed)
1676 { 1434 {
1677 if (orig_ob->env != NULL) 1435 if (orig_ob->env != NULL)
1678 sub_weight (orig_ob->env, orig_ob->weight * nr); 1436 sub_weight (orig_ob->env, orig_ob->weight * nr);
1679 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1437 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1699 1457
1700object * 1458object *
1701decrease_ob_nr (object *op, uint32 i) 1459decrease_ob_nr (object *op, uint32 i)
1702{ 1460{
1703 object *tmp; 1461 object *tmp;
1704 player *pl;
1705 1462
1706 if (i == 0) /* objects with op->nrof require this check */ 1463 if (i == 0) /* objects with op->nrof require this check */
1707 return op; 1464 return op;
1708 1465
1709 if (i > op->nrof) 1466 if (i > op->nrof)
1710 i = op->nrof; 1467 i = op->nrof;
1711 1468
1712 if (QUERY_FLAG (op, FLAG_REMOVED)) 1469 if (QUERY_FLAG (op, FLAG_REMOVED))
1713 op->nrof -= i; 1470 op->nrof -= i;
1714 else if (op->env != NULL) 1471 else if (op->env)
1715 { 1472 {
1716 /* is this object in the players inventory, or sub container 1473 /* is this object in the players inventory, or sub container
1717 * therein? 1474 * therein?
1718 */ 1475 */
1719 tmp = is_player_inv (op->env); 1476 tmp = op->in_player ();
1720 /* nope. Is this a container the player has opened? 1477 /* nope. Is this a container the player has opened?
1721 * If so, set tmp to that player. 1478 * If so, set tmp to that player.
1722 * IMO, searching through all the players will mostly 1479 * IMO, searching through all the players will mostly
1723 * likely be quicker than following op->env to the map, 1480 * likely be quicker than following op->env to the map,
1724 * and then searching the map for a player. 1481 * and then searching the map for a player.
1725 */ 1482 */
1726 if (!tmp) 1483 if (!tmp)
1727 { 1484 for_all_players (pl)
1728 for (pl = first_player; pl; pl = pl->next)
1729 if (pl->ob->container == op->env) 1485 if (pl->ob->container == op->env)
1486 {
1487 tmp = pl->ob;
1730 break; 1488 break;
1731 if (pl)
1732 tmp = pl->ob;
1733 else
1734 tmp = NULL;
1735 } 1489 }
1736 1490
1737 if (i < op->nrof) 1491 if (i < op->nrof)
1738 { 1492 {
1739 sub_weight (op->env, op->weight * i); 1493 sub_weight (op->env, op->weight * i);
1740 op->nrof -= i; 1494 op->nrof -= i;
1741 if (tmp) 1495 if (tmp)
1742 {
1743 esrv_send_item (tmp, op); 1496 esrv_send_item (tmp, op);
1744 }
1745 } 1497 }
1746 else 1498 else
1747 { 1499 {
1748 remove_ob (op); 1500 op->remove ();
1749 op->nrof = 0; 1501 op->nrof = 0;
1750 if (tmp) 1502 if (tmp)
1751 {
1752 esrv_del_item (tmp->contr, op->count); 1503 esrv_del_item (tmp->contr, op->count);
1753 }
1754 } 1504 }
1755 } 1505 }
1756 else 1506 else
1757 { 1507 {
1758 object *above = op->above; 1508 object *above = op->above;
1759 1509
1760 if (i < op->nrof) 1510 if (i < op->nrof)
1761 op->nrof -= i; 1511 op->nrof -= i;
1762 else 1512 else
1763 { 1513 {
1764 remove_ob (op); 1514 op->remove ();
1765 op->nrof = 0; 1515 op->nrof = 0;
1766 } 1516 }
1767 1517
1768 /* Since we just removed op, op->above is null */ 1518 /* Since we just removed op, op->above is null */
1769 for (tmp = above; tmp != NULL; tmp = tmp->above) 1519 for (tmp = above; tmp; tmp = tmp->above)
1770 if (tmp->type == PLAYER) 1520 if (tmp->type == PLAYER)
1771 { 1521 {
1772 if (op->nrof) 1522 if (op->nrof)
1773 esrv_send_item (tmp, op); 1523 esrv_send_item (tmp, op);
1774 else 1524 else
… …
1778 1528
1779 if (op->nrof) 1529 if (op->nrof)
1780 return op; 1530 return op;
1781 else 1531 else
1782 { 1532 {
1783 free_object (op); 1533 op->destroy ();
1784 return NULL; 1534 return 0;
1785 } 1535 }
1786} 1536}
1787 1537
1788/* 1538/*
1789 * add_weight(object, weight) adds the specified weight to an object, 1539 * add_weight(object, weight) adds the specified weight to an object,
… …
1801 op->carrying += weight; 1551 op->carrying += weight;
1802 op = op->env; 1552 op = op->env;
1803 } 1553 }
1804} 1554}
1805 1555
1556object *
1557insert_ob_in_ob (object *op, object *where)
1558{
1559 if (!where)
1560 {
1561 char *dump = dump_object (op);
1562 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1563 free (dump);
1564 return op;
1565 }
1566
1567 if (where->head)
1568 {
1569 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1570 where = where->head;
1571 }
1572
1573 return where->insert (op);
1574}
1575
1806/* 1576/*
1807 * insert_ob_in_ob(op,environment): 1577 * env->insert (op)
1808 * This function inserts the object op in the linked list 1578 * This function inserts the object op in the linked list
1809 * inside the object environment. 1579 * inside the object environment.
1810 * 1580 *
1811 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1812 * the inventory at the last position or next to other objects of the same
1813 * type.
1814 * Frank: Now sorted by type, archetype and magic!
1815 *
1816 * The function returns now pointer to inserted item, and return value can 1581 * The function returns now pointer to inserted item, and return value can
1817 * be != op, if items are merged. -Tero 1582 * be != op, if items are merged. -Tero
1818 */ 1583 */
1819 1584
1820object * 1585object *
1821insert_ob_in_ob (object *op, object *where) 1586object::insert (object *op)
1822{ 1587{
1823 object * 1588 object *tmp, *otmp;
1824 tmp, *
1825 otmp;
1826 1589
1827 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1590 if (!QUERY_FLAG (op, FLAG_REMOVED))
1828 { 1591 op->remove ();
1829 dump_object (op);
1830 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1831 return op;
1832 }
1833
1834 if (where == NULL)
1835 {
1836 dump_object (op);
1837 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1838 return op;
1839 }
1840
1841 if (where->head)
1842 {
1843 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1844 where = where->head;
1845 }
1846 1592
1847 if (op->more) 1593 if (op->more)
1848 { 1594 {
1849 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1595 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1850 return op; 1596 return op;
… …
1852 1598
1853 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1599 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1854 CLEAR_FLAG (op, FLAG_REMOVED); 1600 CLEAR_FLAG (op, FLAG_REMOVED);
1855 if (op->nrof) 1601 if (op->nrof)
1856 { 1602 {
1857 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1603 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1858 if (CAN_MERGE (tmp, op)) 1604 if (object::can_merge (tmp, op))
1859 { 1605 {
1860 /* return the original object and remove inserted object 1606 /* return the original object and remove inserted object
1861 (client needs the original object) */ 1607 (client needs the original object) */
1862 tmp->nrof += op->nrof; 1608 tmp->nrof += op->nrof;
1863 /* Weight handling gets pretty funky. Since we are adding to 1609 /* Weight handling gets pretty funky. Since we are adding to
1864 * tmp->nrof, we need to increase the weight. 1610 * tmp->nrof, we need to increase the weight.
1865 */ 1611 */
1866 add_weight (where, op->weight * op->nrof); 1612 add_weight (this, op->weight * op->nrof);
1867 SET_FLAG (op, FLAG_REMOVED); 1613 SET_FLAG (op, FLAG_REMOVED);
1868 free_object (op); /* free the inserted object */ 1614 op->destroy (); /* free the inserted object */
1869 op = tmp; 1615 op = tmp;
1870 remove_ob (op); /* and fix old object's links */ 1616 op->remove (); /* and fix old object's links */
1871 CLEAR_FLAG (op, FLAG_REMOVED); 1617 CLEAR_FLAG (op, FLAG_REMOVED);
1872 break; 1618 break;
1873 } 1619 }
1874 1620
1875 /* I assume combined objects have no inventory 1621 /* I assume combined objects have no inventory
1876 * We add the weight - this object could have just been removed 1622 * We add the weight - this object could have just been removed
1877 * (if it was possible to merge). calling remove_ob will subtract 1623 * (if it was possible to merge). calling remove_ob will subtract
1878 * the weight, so we need to add it in again, since we actually do 1624 * the weight, so we need to add it in again, since we actually do
1879 * the linking below 1625 * the linking below
1880 */ 1626 */
1881 add_weight (where, op->weight * op->nrof); 1627 add_weight (this, op->weight * op->nrof);
1882 } 1628 }
1883 else 1629 else
1884 add_weight (where, (op->weight + op->carrying)); 1630 add_weight (this, (op->weight + op->carrying));
1885 1631
1886 otmp = is_player_inv (where); 1632 otmp = this->in_player ();
1887 if (otmp && otmp->contr != NULL) 1633 if (otmp && otmp->contr)
1888 {
1889 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1634 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1890 fix_player (otmp); 1635 otmp->update_stats ();
1891 }
1892 1636
1893 op->map = NULL; 1637 op->map = 0;
1894 op->env = where; 1638 op->env = this;
1895 op->above = NULL; 1639 op->above = 0;
1896 op->below = NULL; 1640 op->below = 0;
1897 op->x = 0, op->y = 0; 1641 op->x = 0, op->y = 0;
1898 1642
1899 /* reset the light list and los of the players on the map */ 1643 /* reset the light list and los of the players on the map */
1900 if ((op->glow_radius != 0) && where->map) 1644 if ((op->glow_radius != 0) && map)
1901 { 1645 {
1902#ifdef DEBUG_LIGHTS 1646#ifdef DEBUG_LIGHTS
1903 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1647 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1904#endif /* DEBUG_LIGHTS */ 1648#endif /* DEBUG_LIGHTS */
1905 if (MAP_DARKNESS (where->map)) 1649 if (map->darkness)
1906 update_all_los (where->map, where->x, where->y); 1650 update_all_los (map, x, y);
1907 } 1651 }
1908 1652
1909 /* Client has no idea of ordering so lets not bother ordering it here. 1653 /* Client has no idea of ordering so lets not bother ordering it here.
1910 * It sure simplifies this function... 1654 * It sure simplifies this function...
1911 */ 1655 */
1912 if (where->inv == NULL) 1656 if (!inv)
1913 where->inv = op; 1657 inv = op;
1914 else 1658 else
1915 { 1659 {
1916 op->below = where->inv; 1660 op->below = inv;
1917 op->below->above = op; 1661 op->below->above = op;
1918 where->inv = op; 1662 inv = op;
1919 } 1663 }
1664
1665 INVOKE_OBJECT (INSERT, this);
1666
1920 return op; 1667 return op;
1921} 1668}
1922 1669
1923/* 1670/*
1924 * Checks if any objects has a move_type that matches objects 1671 * Checks if any objects has a move_type that matches objects
… …
1938 * 1685 *
1939 * MSW 2001-07-08: Check all objects on space, not just those below 1686 * MSW 2001-07-08: Check all objects on space, not just those below
1940 * object being inserted. insert_ob_in_map may not put new objects 1687 * object being inserted. insert_ob_in_map may not put new objects
1941 * on top. 1688 * on top.
1942 */ 1689 */
1943
1944int 1690int
1945check_move_on (object *op, object *originator) 1691check_move_on (object *op, object *originator)
1946{ 1692{
1947 object * 1693 object *tmp;
1948 tmp; 1694 maptile *m = op->map;
1949 tag_t
1950 tag;
1951 mapstruct *
1952 m = op->map;
1953 int
1954 x = op->x, y = op->y; 1695 int x = op->x, y = op->y;
1955 1696
1956 MoveType 1697 MoveType move_on, move_slow, move_block;
1957 move_on,
1958 move_slow,
1959 move_block;
1960 1698
1961 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1699 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1962 return 0; 1700 return 0;
1963
1964 tag = op->count;
1965 1701
1966 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1702 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1967 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1703 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1968 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1704 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1969 1705
… …
1985 1721
1986 /* The objects have to be checked from top to bottom. 1722 /* The objects have to be checked from top to bottom.
1987 * Hence, we first go to the top: 1723 * Hence, we first go to the top:
1988 */ 1724 */
1989 1725
1990 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1726 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1991 { 1727 {
1992 /* Trim the search when we find the first other spell effect 1728 /* Trim the search when we find the first other spell effect
1993 * this helps performance so that if a space has 50 spell objects, 1729 * this helps performance so that if a space has 50 spell objects,
1994 * we don't need to check all of them. 1730 * we don't need to check all of them.
1995 */ 1731 */
… …
2030 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1766 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2031 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1767 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2032 { 1768 {
2033 move_apply (tmp, op, originator); 1769 move_apply (tmp, op, originator);
2034 1770
2035 if (was_destroyed (op, tag)) 1771 if (op->destroyed ())
2036 return 1; 1772 return 1;
2037 1773
2038 /* what the person/creature stepped onto has moved the object 1774 /* what the person/creature stepped onto has moved the object
2039 * someplace new. Don't process any further - if we did, 1775 * someplace new. Don't process any further - if we did,
2040 * have a feeling strange problems would result. 1776 * have a feeling strange problems would result.
… …
2050/* 1786/*
2051 * present_arch(arch, map, x, y) searches for any objects with 1787 * present_arch(arch, map, x, y) searches for any objects with
2052 * a matching archetype at the given map and coordinates. 1788 * a matching archetype at the given map and coordinates.
2053 * The first matching object is returned, or NULL if none. 1789 * The first matching object is returned, or NULL if none.
2054 */ 1790 */
2055
2056object * 1791object *
2057present_arch (const archetype *at, mapstruct *m, int x, int y) 1792present_arch (const archetype *at, maptile *m, int x, int y)
2058{ 1793{
2059 object *
2060 tmp;
2061
2062 if (m == NULL || out_of_map (m, x, y)) 1794 if (!m || out_of_map (m, x, y))
2063 { 1795 {
2064 LOG (llevError, "Present_arch called outside map.\n"); 1796 LOG (llevError, "Present_arch called outside map.\n");
2065 return NULL; 1797 return NULL;
2066 } 1798 }
2067 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1799
1800 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2068 if (tmp->arch == at) 1801 if (tmp->arch == at)
2069 return tmp; 1802 return tmp;
1803
2070 return NULL; 1804 return NULL;
2071} 1805}
2072 1806
2073/* 1807/*
2074 * present(type, map, x, y) searches for any objects with 1808 * present(type, map, x, y) searches for any objects with
2075 * a matching type variable at the given map and coordinates. 1809 * a matching type variable at the given map and coordinates.
2076 * The first matching object is returned, or NULL if none. 1810 * The first matching object is returned, or NULL if none.
2077 */ 1811 */
2078
2079object * 1812object *
2080present (unsigned char type, mapstruct *m, int x, int y) 1813present (unsigned char type, maptile *m, int x, int y)
2081{ 1814{
2082 object *
2083 tmp;
2084
2085 if (out_of_map (m, x, y)) 1815 if (out_of_map (m, x, y))
2086 { 1816 {
2087 LOG (llevError, "Present called outside map.\n"); 1817 LOG (llevError, "Present called outside map.\n");
2088 return NULL; 1818 return NULL;
2089 } 1819 }
2090 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1820
1821 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2091 if (tmp->type == type) 1822 if (tmp->type == type)
2092 return tmp; 1823 return tmp;
1824
2093 return NULL; 1825 return NULL;
2094} 1826}
2095 1827
2096/* 1828/*
2097 * present_in_ob(type, object) searches for any objects with 1829 * present_in_ob(type, object) searches for any objects with
2098 * a matching type variable in the inventory of the given object. 1830 * a matching type variable in the inventory of the given object.
2099 * The first matching object is returned, or NULL if none. 1831 * The first matching object is returned, or NULL if none.
2100 */ 1832 */
2101
2102object * 1833object *
2103present_in_ob (unsigned char type, const object *op) 1834present_in_ob (unsigned char type, const object *op)
2104{ 1835{
2105 object *
2106 tmp;
2107
2108 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1836 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2109 if (tmp->type == type) 1837 if (tmp->type == type)
2110 return tmp; 1838 return tmp;
1839
2111 return NULL; 1840 return NULL;
2112} 1841}
2113 1842
2114/* 1843/*
2115 * present_in_ob (type, str, object) searches for any objects with 1844 * present_in_ob (type, str, object) searches for any objects with
… …
2123 * str is the string to match against. Note that we match against 1852 * str is the string to match against. Note that we match against
2124 * the object name, not the archetype name. this is so that the 1853 * the object name, not the archetype name. this is so that the
2125 * spell code can use one object type (force), but change it's name 1854 * spell code can use one object type (force), but change it's name
2126 * to be unique. 1855 * to be unique.
2127 */ 1856 */
2128
2129object * 1857object *
2130present_in_ob_by_name (int type, const char *str, const object *op) 1858present_in_ob_by_name (int type, const char *str, const object *op)
2131{ 1859{
2132 object *
2133 tmp;
2134
2135 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2136 {
2137 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1861 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2138 return tmp; 1862 return tmp;
2139 } 1863
2140 return NULL; 1864 return 0;
2141} 1865}
2142 1866
2143/* 1867/*
2144 * present_arch_in_ob(archetype, object) searches for any objects with 1868 * present_arch_in_ob(archetype, object) searches for any objects with
2145 * a matching archetype in the inventory of the given object. 1869 * a matching archetype in the inventory of the given object.
2146 * The first matching object is returned, or NULL if none. 1870 * The first matching object is returned, or NULL if none.
2147 */ 1871 */
2148
2149object * 1872object *
2150present_arch_in_ob (const archetype *at, const object *op) 1873present_arch_in_ob (const archetype *at, const object *op)
2151{ 1874{
2152 object *
2153 tmp;
2154
2155 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1875 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2156 if (tmp->arch == at) 1876 if (tmp->arch == at)
2157 return tmp; 1877 return tmp;
1878
2158 return NULL; 1879 return NULL;
2159} 1880}
2160 1881
2161/* 1882/*
2162 * activate recursively a flag on an object inventory 1883 * activate recursively a flag on an object inventory
2163 */ 1884 */
2164void 1885void
2165flag_inv (object *op, int flag) 1886flag_inv (object *op, int flag)
2166{ 1887{
2167 object *
2168 tmp;
2169
2170 if (op->inv) 1888 if (op->inv)
2171 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1889 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2172 { 1890 {
2173 SET_FLAG (tmp, flag); 1891 SET_FLAG (tmp, flag);
2174 flag_inv (tmp, flag); 1892 flag_inv (tmp, flag);
2175 } 1893 }
2176} /* 1894}
1895
1896/*
2177 * desactivate recursively a flag on an object inventory 1897 * deactivate recursively a flag on an object inventory
2178 */ 1898 */
2179void 1899void
2180unflag_inv (object *op, int flag) 1900unflag_inv (object *op, int flag)
2181{ 1901{
2182 object *
2183 tmp;
2184
2185 if (op->inv) 1902 if (op->inv)
2186 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1903 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2187 { 1904 {
2188 CLEAR_FLAG (tmp, flag); 1905 CLEAR_FLAG (tmp, flag);
2189 unflag_inv (tmp, flag); 1906 unflag_inv (tmp, flag);
2190 } 1907 }
2191} 1908}
… …
2194 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1911 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2195 * all it's inventory (recursively). 1912 * all it's inventory (recursively).
2196 * If checksums are used, a player will get set_cheat called for 1913 * If checksums are used, a player will get set_cheat called for
2197 * him/her-self and all object carried by a call to this function. 1914 * him/her-self and all object carried by a call to this function.
2198 */ 1915 */
2199
2200void 1916void
2201set_cheat (object *op) 1917set_cheat (object *op)
2202{ 1918{
2203 SET_FLAG (op, FLAG_WAS_WIZ); 1919 SET_FLAG (op, FLAG_WAS_WIZ);
2204 flag_inv (op, FLAG_WAS_WIZ); 1920 flag_inv (op, FLAG_WAS_WIZ);
… …
2223 * because arch_blocked (now ob_blocked) needs to know the movement type 1939 * because arch_blocked (now ob_blocked) needs to know the movement type
2224 * to know if the space in question will block the object. We can't use 1940 * to know if the space in question will block the object. We can't use
2225 * the archetype because that isn't correct if the monster has been 1941 * the archetype because that isn't correct if the monster has been
2226 * customized, changed states, etc. 1942 * customized, changed states, etc.
2227 */ 1943 */
2228
2229int 1944int
2230find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1945find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2231{ 1946{
2232 int
2233 i,
2234 index = 0, flag; 1947 int index = 0, flag;
2235 static int
2236 altern[SIZEOFFREE]; 1948 int altern[SIZEOFFREE];
2237 1949
2238 for (i = start; i < stop; i++) 1950 for (int i = start; i < stop; i++)
2239 { 1951 {
2240 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1952 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2241 if (!flag) 1953 if (!flag)
2242 altern[index++] = i; 1954 altern [index++] = i;
2243 1955
2244 /* Basically, if we find a wall on a space, we cut down the search size. 1956 /* Basically, if we find a wall on a space, we cut down the search size.
2245 * In this way, we won't return spaces that are on another side of a wall. 1957 * In this way, we won't return spaces that are on another side of a wall.
2246 * This mostly work, but it cuts down the search size in all directions - 1958 * This mostly work, but it cuts down the search size in all directions -
2247 * if the space being examined only has a wall to the north and empty 1959 * if the space being examined only has a wall to the north and empty
2248 * spaces in all the other directions, this will reduce the search space 1960 * spaces in all the other directions, this will reduce the search space
2249 * to only the spaces immediately surrounding the target area, and 1961 * to only the spaces immediately surrounding the target area, and
2250 * won't look 2 spaces south of the target space. 1962 * won't look 2 spaces south of the target space.
2251 */ 1963 */
2252 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1964 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2253 stop = maxfree[i]; 1965 stop = maxfree[i];
2254 } 1966 }
1967
2255 if (!index) 1968 if (!index)
2256 return -1; 1969 return -1;
1970
2257 return altern[RANDOM () % index]; 1971 return altern[RANDOM () % index];
2258} 1972}
2259 1973
2260/* 1974/*
2261 * find_first_free_spot(archetype, mapstruct, x, y) works like 1975 * find_first_free_spot(archetype, maptile, x, y) works like
2262 * find_free_spot(), but it will search max number of squares. 1976 * find_free_spot(), but it will search max number of squares.
2263 * But it will return the first available spot, not a random choice. 1977 * But it will return the first available spot, not a random choice.
2264 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1978 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2265 */ 1979 */
2266
2267int 1980int
2268find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 1981find_first_free_spot (const object *ob, maptile *m, int x, int y)
2269{ 1982{
2270 int
2271 i;
2272
2273 for (i = 0; i < SIZEOFFREE; i++) 1983 for (int i = 0; i < SIZEOFFREE; i++)
2274 {
2275 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1984 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2276 return i; 1985 return i;
2277 } 1986
2278 return -1; 1987 return -1;
2279} 1988}
2280 1989
2281/* 1990/*
2282 * The function permute(arr, begin, end) randomly reorders the array 1991 * The function permute(arr, begin, end) randomly reorders the array
2283 * arr[begin..end-1]. 1992 * arr[begin..end-1].
1993 * now uses a fisher-yates shuffle, old permute was broken
2284 */ 1994 */
2285static void 1995static void
2286permute (int *arr, int begin, int end) 1996permute (int *arr, int begin, int end)
2287{ 1997{
2288 int 1998 arr += begin;
2289 i,
2290 j,
2291 tmp,
2292 len;
2293
2294 len = end - begin; 1999 end -= begin;
2295 for (i = begin; i < end; i++)
2296 {
2297 j = begin + RANDOM () % len;
2298 2000
2299 tmp = arr[i]; 2001 while (--end)
2300 arr[i] = arr[j]; 2002 swap (arr [end], arr [RANDOM () % (end + 1)]);
2301 arr[j] = tmp;
2302 }
2303} 2003}
2304 2004
2305/* new function to make monster searching more efficient, and effective! 2005/* new function to make monster searching more efficient, and effective!
2306 * This basically returns a randomized array (in the passed pointer) of 2006 * This basically returns a randomized array (in the passed pointer) of
2307 * the spaces to find monsters. In this way, it won't always look for 2007 * the spaces to find monsters. In this way, it won't always look for
… …
2310 * the 3x3 area will be searched, just not in a predictable order. 2010 * the 3x3 area will be searched, just not in a predictable order.
2311 */ 2011 */
2312void 2012void
2313get_search_arr (int *search_arr) 2013get_search_arr (int *search_arr)
2314{ 2014{
2315 int 2015 int i;
2316 i;
2317 2016
2318 for (i = 0; i < SIZEOFFREE; i++) 2017 for (i = 0; i < SIZEOFFREE; i++)
2319 {
2320 search_arr[i] = i; 2018 search_arr[i] = i;
2321 }
2322 2019
2323 permute (search_arr, 1, SIZEOFFREE1 + 1); 2020 permute (search_arr, 1, SIZEOFFREE1 + 1);
2324 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2021 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2325 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2022 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2326} 2023}
… …
2335 * Perhaps incorrectly, but I'm making the assumption that exclude 2032 * Perhaps incorrectly, but I'm making the assumption that exclude
2336 * is actually want is going to try and move there. We need this info 2033 * is actually want is going to try and move there. We need this info
2337 * because we have to know what movement the thing looking to move 2034 * because we have to know what movement the thing looking to move
2338 * there is capable of. 2035 * there is capable of.
2339 */ 2036 */
2340
2341int 2037int
2342find_dir (mapstruct *m, int x, int y, object *exclude) 2038find_dir (maptile *m, int x, int y, object *exclude)
2343{ 2039{
2344 int
2345 i,
2346 max = SIZEOFFREE, mflags; 2040 int i, max = SIZEOFFREE, mflags;
2347 2041
2348 sint16 nx, ny; 2042 sint16 nx, ny;
2349 object * 2043 object *tmp;
2350 tmp; 2044 maptile *mp;
2351 mapstruct *
2352 mp;
2353 2045
2354 MoveType blocked, move_type; 2046 MoveType blocked, move_type;
2355 2047
2356 if (exclude && exclude->head) 2048 if (exclude && exclude->head)
2357 { 2049 {
… …
2369 mp = m; 2061 mp = m;
2370 nx = x + freearr_x[i]; 2062 nx = x + freearr_x[i];
2371 ny = y + freearr_y[i]; 2063 ny = y + freearr_y[i];
2372 2064
2373 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2065 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2066
2374 if (mflags & P_OUT_OF_MAP) 2067 if (mflags & P_OUT_OF_MAP)
2375 {
2376 max = maxfree[i]; 2068 max = maxfree[i];
2377 }
2378 else 2069 else
2379 { 2070 {
2380 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2071 mapspace &ms = mp->at (nx, ny);
2072
2073 blocked = ms.move_block;
2381 2074
2382 if ((move_type & blocked) == move_type) 2075 if ((move_type & blocked) == move_type)
2383 {
2384 max = maxfree[i]; 2076 max = maxfree[i];
2385 }
2386 else if (mflags & P_IS_ALIVE) 2077 else if (mflags & P_IS_ALIVE)
2387 { 2078 {
2388 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2079 for (tmp = ms.bot; tmp; tmp = tmp->above)
2389 { 2080 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2390 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2081 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2391 {
2392 break; 2082 break;
2393 } 2083
2394 }
2395 if (tmp) 2084 if (tmp)
2396 {
2397 return freedir[i]; 2085 return freedir[i];
2398 }
2399 } 2086 }
2400 } 2087 }
2401 } 2088 }
2089
2402 return 0; 2090 return 0;
2403} 2091}
2404 2092
2405/* 2093/*
2406 * distance(object 1, object 2) will return the square of the 2094 * distance(object 1, object 2) will return the square of the
2407 * distance between the two given objects. 2095 * distance between the two given objects.
2408 */ 2096 */
2409
2410int 2097int
2411distance (const object *ob1, const object *ob2) 2098distance (const object *ob1, const object *ob2)
2412{ 2099{
2413 int
2414 i;
2415
2416 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2100 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2417 return i;
2418} 2101}
2419 2102
2420/* 2103/*
2421 * find_dir_2(delta-x,delta-y) will return a direction in which 2104 * find_dir_2(delta-x,delta-y) will return a direction in which
2422 * an object which has subtracted the x and y coordinates of another 2105 * an object which has subtracted the x and y coordinates of another
2423 * object, needs to travel toward it. 2106 * object, needs to travel toward it.
2424 */ 2107 */
2425
2426int 2108int
2427find_dir_2 (int x, int y) 2109find_dir_2 (int x, int y)
2428{ 2110{
2429 int 2111 int q;
2430 q;
2431 2112
2432 if (y) 2113 if (y)
2433 q = x * 100 / y; 2114 q = x * 100 / y;
2434 else if (x) 2115 else if (x)
2435 q = -300 * x; 2116 q = -300 * x;
… …
2460 2141
2461 return 3; 2142 return 3;
2462} 2143}
2463 2144
2464/* 2145/*
2465 * absdir(int): Returns a number between 1 and 8, which represent
2466 * the "absolute" direction of a number (it actually takes care of
2467 * "overflow" in previous calculations of a direction).
2468 */
2469
2470int
2471absdir (int d)
2472{
2473 while (d < 1)
2474 d += 8;
2475 while (d > 8)
2476 d -= 8;
2477 return d;
2478}
2479
2480/*
2481 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2146 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2482 * between two directions (which are expected to be absolute (see absdir()) 2147 * between two directions (which are expected to be absolute (see absdir())
2483 */ 2148 */
2484
2485int 2149int
2486dirdiff (int dir1, int dir2) 2150dirdiff (int dir1, int dir2)
2487{ 2151{
2488 int 2152 int d;
2489 d;
2490 2153
2491 d = abs (dir1 - dir2); 2154 d = abs (dir1 - dir2);
2492 if (d > 4) 2155 if (d > 4)
2493 d = 8 - d; 2156 d = 8 - d;
2157
2494 return d; 2158 return d;
2495} 2159}
2496 2160
2497/* peterm: 2161/* peterm:
2498 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2162 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2501 * This basically means that if direction is 15, then it could either go 2165 * This basically means that if direction is 15, then it could either go
2502 * direction 4, 14, or 16 to get back to where we are. 2166 * direction 4, 14, or 16 to get back to where we are.
2503 * Moved from spell_util.c to object.c with the other related direction 2167 * Moved from spell_util.c to object.c with the other related direction
2504 * functions. 2168 * functions.
2505 */ 2169 */
2506
2507int
2508 reduction_dir[SIZEOFFREE][3] = { 2170int reduction_dir[SIZEOFFREE][3] = {
2509 {0, 0, 0}, /* 0 */ 2171 {0, 0, 0}, /* 0 */
2510 {0, 0, 0}, /* 1 */ 2172 {0, 0, 0}, /* 1 */
2511 {0, 0, 0}, /* 2 */ 2173 {0, 0, 0}, /* 2 */
2512 {0, 0, 0}, /* 3 */ 2174 {0, 0, 0}, /* 3 */
2513 {0, 0, 0}, /* 4 */ 2175 {0, 0, 0}, /* 4 */
… …
2561 * find a path to that monster that we found. If not, 2223 * find a path to that monster that we found. If not,
2562 * we don't bother going toward it. Returns 1 if we 2224 * we don't bother going toward it. Returns 1 if we
2563 * can see a direct way to get it 2225 * can see a direct way to get it
2564 * Modified to be map tile aware -.MSW 2226 * Modified to be map tile aware -.MSW
2565 */ 2227 */
2566
2567
2568int 2228int
2569can_see_monsterP (mapstruct *m, int x, int y, int dir) 2229can_see_monsterP (maptile *m, int x, int y, int dir)
2570{ 2230{
2571 sint16 dx, dy; 2231 sint16 dx, dy;
2572 int
2573 mflags; 2232 int mflags;
2574 2233
2575 if (dir < 0) 2234 if (dir < 0)
2576 return 0; /* exit condition: invalid direction */ 2235 return 0; /* exit condition: invalid direction */
2577 2236
2578 dx = x + freearr_x[dir]; 2237 dx = x + freearr_x[dir];
… …
2591 return 0; 2250 return 0;
2592 2251
2593 /* yes, can see. */ 2252 /* yes, can see. */
2594 if (dir < 9) 2253 if (dir < 9)
2595 return 1; 2254 return 1;
2255
2596 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2256 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2597 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2257 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2258 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2598} 2259}
2599
2600
2601 2260
2602/* 2261/*
2603 * can_pick(picker, item): finds out if an object is possible to be 2262 * can_pick(picker, item): finds out if an object is possible to be
2604 * picked up by the picker. Returnes 1 if it can be 2263 * picked up by the picker. Returnes 1 if it can be
2605 * picked up, otherwise 0. 2264 * picked up, otherwise 0.
… …
2616 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2275 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2617 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2276 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2618 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2277 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2619} 2278}
2620 2279
2621
2622/* 2280/*
2623 * create clone from object to another 2281 * create clone from object to another
2624 */ 2282 */
2625object * 2283object *
2626object_create_clone (object *asrc) 2284object_create_clone (object *asrc)
2627{ 2285{
2628 object *
2629 dst = NULL, *tmp, *src, *part, *prev, *item; 2286 object *dst = 0, *tmp, *src, *part, *prev, *item;
2630 2287
2631 if (!asrc) 2288 if (!asrc)
2632 return NULL; 2289 return 0;
2290
2633 src = asrc; 2291 src = asrc;
2634 if (src->head) 2292 if (src->head)
2635 src = src->head; 2293 src = src->head;
2636 2294
2637 prev = NULL; 2295 prev = 0;
2638 for (part = src; part; part = part->more) 2296 for (part = src; part; part = part->more)
2639 { 2297 {
2640 tmp = get_object (); 2298 tmp = part->clone ();
2641 copy_object (part, tmp);
2642 tmp->x -= src->x; 2299 tmp->x -= src->x;
2643 tmp->y -= src->y; 2300 tmp->y -= src->y;
2301
2644 if (!part->head) 2302 if (!part->head)
2645 { 2303 {
2646 dst = tmp; 2304 dst = tmp;
2647 tmp->head = NULL; 2305 tmp->head = 0;
2648 } 2306 }
2649 else 2307 else
2650 {
2651 tmp->head = dst; 2308 tmp->head = dst;
2652 } 2309
2653 tmp->more = NULL; 2310 tmp->more = 0;
2311
2654 if (prev) 2312 if (prev)
2655 prev->more = tmp; 2313 prev->more = tmp;
2314
2656 prev = tmp; 2315 prev = tmp;
2657 } 2316 }
2658 2317
2659 /*** copy inventory ***/
2660 for (item = src->inv; item; item = item->below) 2318 for (item = src->inv; item; item = item->below)
2661 {
2662 (void) insert_ob_in_ob (object_create_clone (item), dst); 2319 insert_ob_in_ob (object_create_clone (item), dst);
2663 }
2664 2320
2665 return dst; 2321 return dst;
2666} 2322}
2667 2323
2668/* return true if the object was destroyed, 0 otherwise */
2669int
2670was_destroyed (const object *op, tag_t old_tag)
2671{
2672 /* checking for FLAG_FREED isn't necessary, but makes this function more
2673 * robust */
2674 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2675}
2676
2677/* GROS - Creates an object using a string representing its content. */ 2324/* GROS - Creates an object using a string representing its content. */
2678
2679/* Basically, we save the content of the string to a temp file, then call */ 2325/* Basically, we save the content of the string to a temp file, then call */
2680
2681/* load_object on it. I admit it is a highly inefficient way to make things, */ 2326/* load_object on it. I admit it is a highly inefficient way to make things, */
2682
2683/* but it was simple to make and allows reusing the load_object function. */ 2327/* but it was simple to make and allows reusing the load_object function. */
2684
2685/* Remember not to use load_object_str in a time-critical situation. */ 2328/* Remember not to use load_object_str in a time-critical situation. */
2686
2687/* Also remember that multiparts objects are not supported for now. */ 2329/* Also remember that multiparts objects are not supported for now. */
2688
2689object * 2330object *
2690load_object_str (const char *obstr) 2331load_object_str (const char *obstr)
2691{ 2332{
2692 object * 2333 object *op;
2693 op;
2694 char
2695 filename[MAX_BUF]; 2334 char filename[MAX_BUF];
2696 2335
2697 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2336 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2698 2337
2699 FILE *
2700 tempfile = fopen (filename, "w"); 2338 FILE *tempfile = fopen (filename, "w");
2701 2339
2702 if (tempfile == NULL) 2340 if (tempfile == NULL)
2703 { 2341 {
2704 LOG (llevError, "Error - Unable to access load object temp file\n"); 2342 LOG (llevError, "Error - Unable to access load object temp file\n");
2705 return NULL; 2343 return NULL;
2706 } 2344 }
2707 2345
2708 fprintf (tempfile, obstr); 2346 fprintf (tempfile, obstr);
2709 fclose (tempfile); 2347 fclose (tempfile);
2710 2348
2711 op = get_object (); 2349 op = object::create ();
2712 2350
2713 object_thawer thawer (filename); 2351 object_thawer thawer (filename);
2714 2352
2715 if (thawer) 2353 if (thawer)
2716 load_object (thawer, op, 0); 2354 load_object (thawer, op, 0);
… …
2726 * returns NULL if no match. 2364 * returns NULL if no match.
2727 */ 2365 */
2728object * 2366object *
2729find_obj_by_type_subtype (const object *who, int type, int subtype) 2367find_obj_by_type_subtype (const object *who, int type, int subtype)
2730{ 2368{
2731 object *
2732 tmp;
2733
2734 for (tmp = who->inv; tmp; tmp = tmp->below) 2369 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2735 if (tmp->type == type && tmp->subtype == subtype) 2370 if (tmp->type == type && tmp->subtype == subtype)
2736 return tmp; 2371 return tmp;
2737 2372
2738 return NULL; 2373 return 0;
2739} 2374}
2740 2375
2741/* If ob has a field named key, return the link from the list, 2376/* If ob has a field named key, return the link from the list,
2742 * otherwise return NULL. 2377 * otherwise return NULL.
2743 * 2378 *
… …
2745 * do the desired thing. 2380 * do the desired thing.
2746 */ 2381 */
2747key_value * 2382key_value *
2748get_ob_key_link (const object *ob, const char *key) 2383get_ob_key_link (const object *ob, const char *key)
2749{ 2384{
2750 key_value *
2751 link;
2752
2753 for (link = ob->key_values; link != NULL; link = link->next) 2385 for (key_value *link = ob->key_values; link; link = link->next)
2754 {
2755 if (link->key == key) 2386 if (link->key == key)
2756 {
2757 return link; 2387 return link;
2758 }
2759 }
2760 2388
2761 return NULL; 2389 return 0;
2762} 2390}
2763 2391
2764/* 2392/*
2765 * Returns the value of op has an extra_field for key, or NULL. 2393 * Returns the value of op has an extra_field for key, or NULL.
2766 * 2394 *
… …
2806 * Returns TRUE on success. 2434 * Returns TRUE on success.
2807 */ 2435 */
2808int 2436int
2809set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2437set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2810{ 2438{
2811 key_value *
2812 field = NULL, *last = NULL; 2439 key_value *field = NULL, *last = NULL;
2813 2440
2814 for (field = op->key_values; field != NULL; field = field->next) 2441 for (field = op->key_values; field != NULL; field = field->next)
2815 { 2442 {
2816 if (field->key != canonical_key) 2443 if (field->key != canonical_key)
2817 { 2444 {
… …
2845 /* IF we get here, key doesn't exist */ 2472 /* IF we get here, key doesn't exist */
2846 2473
2847 /* No field, we'll have to add it. */ 2474 /* No field, we'll have to add it. */
2848 2475
2849 if (!add_key) 2476 if (!add_key)
2850 {
2851 return FALSE; 2477 return FALSE;
2852 } 2478
2853 /* There isn't any good reason to store a null 2479 /* There isn't any good reason to store a null
2854 * value in the key/value list. If the archetype has 2480 * value in the key/value list. If the archetype has
2855 * this key, then we should also have it, so shouldn't 2481 * this key, then we should also have it, so shouldn't
2856 * be here. If user wants to store empty strings, 2482 * be here. If user wants to store empty strings,
2857 * should pass in "" 2483 * should pass in ""
… …
2906 } 2532 }
2907 else 2533 else
2908 item = item->env; 2534 item = item->env;
2909} 2535}
2910 2536
2537
2538const char *
2539object::flag_desc (char *desc, int len) const
2540{
2541 char *p = desc;
2542 bool first = true;
2543
2544 *p = 0;
2545
2546 for (int i = 0; i < NUM_FLAGS; i++)
2547 {
2548 if (len <= 10) // magic constant!
2549 {
2550 snprintf (p, len, ",...");
2551 break;
2552 }
2553
2554 if (flag [i])
2555 {
2556 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2557 len -= cnt;
2558 p += cnt;
2559 first = false;
2560 }
2561 }
2562
2563 return desc;
2564}
2565
2911// return a suitable string describing an objetc in enough detail to find it 2566// return a suitable string describing an object in enough detail to find it
2912const char * 2567const char *
2913object::debug_desc (char *info) const 2568object::debug_desc (char *info) const
2914{ 2569{
2570 char flagdesc[512];
2915 char info2[256 * 3]; 2571 char info2[256 * 4];
2916 char *p = info; 2572 char *p = info;
2917 2573
2918 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2574 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2919 count, 2575 count, uuid.seq,
2920 &name, 2576 &name,
2921 title ? " " : "", 2577 title ? "\",title:\"" : "",
2922 title ? (const char *)title : ""); 2578 title ? (const char *)title : "",
2579 flag_desc (flagdesc, 512), type);
2923 2580
2924 if (env) 2581 if (env)
2925 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2582 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2926 2583
2927 if (map) 2584 if (map)
2928 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2585 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2929 2586
2930 return info; 2587 return info;
2931} 2588}
2932 2589
2933const char * 2590const char *
2934object::debug_desc () const 2591object::debug_desc () const
2935{ 2592{
2936 static char info[256 * 3]; 2593 static char info[256 * 4];
2937 return debug_desc (info); 2594 return debug_desc (info);
2938} 2595}
2939 2596
2597const char *
2598object::debug_desc2 () const
2599{
2600 static char info[256 * 4];
2601 return debug_desc (info);
2602}
2603

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines