ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.56 by root, Sun Dec 3 02:04:57 2006 UTC vs.
Revision 1.104 by root, Tue Jan 2 21:13:21 2007 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
104 _exit (1); 106 _exit (1);
105 } 107 }
106 108
107 uuid.seq = uid; 109 uuid.seq = uid;
108 write_uuid (); 110 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 112 fclose (fp);
111} 113}
112 114
113UUID 115UUID
114gen_uuid () 116gen_uuid ()
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193
194bool object::can_merge (object *ob1, object *ob2) 195bool object::can_merge_slow (object *ob1, object *ob2)
195{ 196{
196 /* A couple quicksanity checks */ 197 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 198 if (ob1 == ob2
199 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value
202 || ob1->name != ob2->name)
198 return 0; 203 return 0;
199 204
200 if (ob1->speed != ob2->speed) 205 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 206 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 207 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 208 * used to store nrof).
206 */ 209 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 210 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 220 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 221
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 224
222 225 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 226 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 227 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 228 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 229 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 230 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 233 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 234 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 235 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 236 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 237 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 238 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 239 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 240 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 241 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 242 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 243 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 244 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 245 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 246 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 247 || ob1->move_off != ob2->move_off
248 || ob1->move_slow != ob2->move_slow
249 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 250 return 0;
254 251
255 /* This is really a spellbook check - really, we should 252 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 253 * check all objects in the inventory.
257 */ 254 */
260 /* if one object has inventory but the other doesn't, not equiv */ 257 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 258 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 259 return 0;
263 260
264 /* Now check to see if the two inventory objects could merge */ 261 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 262 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 263 return 0;
267 264
268 /* inventory ok - still need to check rest of this object to see 265 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 266 * if it is valid.
270 */ 267 */
279 276
280 /* Note sure why the following is the case - either the object has to 277 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 278 * be animated or have a very low speed. Is this an attempted monster
282 * check? 279 * check?
283 */ 280 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 281 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 282 return 0;
286 283
287 switch (ob1->type) 284 switch (ob1->type)
288 { 285 {
289 case SCROLL: 286 case SCROLL:
354 op = op->env; 351 op = op->env;
355 return op; 352 return op;
356} 353}
357 354
358/* 355/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 356 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 357 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 358 * The result of the dump is stored in the static global errmsg array.
377 */ 359 */
378 360
381{ 363{
382 if (!op) 364 if (!op)
383 return strdup ("[NULLOBJ]"); 365 return strdup ("[NULLOBJ]");
384 366
385 object_freezer freezer; 367 object_freezer freezer;
386 save_object (freezer, op, 3); 368 save_object (freezer, op, 1);
387 return freezer.as_string (); 369 return freezer.as_string ();
388} 370}
389 371
390/* 372/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 373 * get_nearest_part(multi-object, object 2) returns the part of the
484 } 466 }
485 467
486 op->key_values = 0; 468 op->key_values = 0;
487} 469}
488 470
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 471/*
541 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 477 * will point at garbage.
547 */ 478 */
548void 479void
549copy_object (object *op2, object *op) 480object::copy_to (object *dst)
550{ 481{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 484
554 op2->clone (op); 485 *(object_copy *)dst = *this;
555 486
556 if (is_freed) 487 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
558 if (is_removed) 490 if (is_removed)
559 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
560 492
561 if (op2->speed < 0) 493 if (speed < 0)
562 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
563 495
564 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
565 if (op2->key_values) 497 if (key_values)
566 { 498 {
567 key_value *tail = 0; 499 key_value *tail = 0;
568 key_value *i; 500 key_value *i;
569 501
570 op->key_values = 0; 502 dst->key_values = 0;
571 503
572 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
573 { 505 {
574 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
575 507
576 new_link->next = 0; 508 new_link->next = 0;
577 new_link->key = i->key; 509 new_link->key = i->key;
578 new_link->value = i->value; 510 new_link->value = i->value;
579 511
580 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
581 if (!op->key_values) 513 if (!dst->key_values)
582 { 514 {
583 op->key_values = new_link; 515 dst->key_values = new_link;
584 tail = new_link; 516 tail = new_link;
585 } 517 }
586 else 518 else
587 { 519 {
588 tail->next = new_link; 520 tail->next = new_link;
589 tail = new_link; 521 tail = new_link;
590 } 522 }
591 } 523 }
592 } 524 }
593 525
594 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
595} 535}
596 536
597/* 537/*
598 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
599 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
600 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
601 */ 541 */
602
603void 542void
604update_turn_face (object *op) 543update_turn_face (object *op)
605{ 544{
606 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
607 return; 546 return;
547
608 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
609 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
610} 550}
611 551
612/* 552/*
613 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
614 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
615 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
616 */ 556 */
617void 557void
618update_ob_speed (object *op) 558object::set_speed (float speed)
619{ 559{
620 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
621
622 /* No reason putting the archetypes objects on the speed list,
623 * since they never really need to be updated.
624 */
625
626 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
627 { 561 {
628 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
629#ifdef MANY_CORES
630 abort ();
631#else
632 op->speed = 0; 563 speed = 0;
633#endif
634 }
635
636 if (arch_init)
637 return;
638
639 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
640 { 564 }
641 /* If already on active list, don't do anything */
642 if (op->active_next || op->active_prev || op == active_objects)
643 return;
644 565
645 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
646 * of the list. */
647 op->active_next = active_objects;
648 567
649 if (op->active_next != NULL) 568 if (has_active_speed ())
650 op->active_next->active_prev = op; 569 activate ();
651
652 active_objects = op;
653 }
654 else 570 else
655 { 571 deactivate ();
656 /* If not on the active list, nothing needs to be done */
657 if (!op->active_next && !op->active_prev && op != active_objects)
658 return;
659
660 if (op->active_prev == NULL)
661 {
662 active_objects = op->active_next;
663
664 if (op->active_next != NULL)
665 op->active_next->active_prev = NULL;
666 }
667 else
668 {
669 op->active_prev->active_next = op->active_next;
670
671 if (op->active_next)
672 op->active_next->active_prev = op->active_prev;
673 }
674
675 op->active_next = NULL;
676 op->active_prev = NULL;
677 }
678} 572}
679 573
680/* This function removes object 'op' from the list of active
681 * objects.
682 * This should only be used for style maps or other such
683 * reference maps where you don't want an object that isn't
684 * in play chewing up cpu time getting processed.
685 * The reverse of this is to call update_ob_speed, which
686 * will do the right thing based on the speed of the object.
687 */
688void
689remove_from_active_list (object *op)
690{
691 /* If not on the active list, nothing needs to be done */
692 if (!op->active_next && !op->active_prev && op != active_objects)
693 return;
694
695 if (op->active_prev == NULL)
696 {
697 active_objects = op->active_next;
698 if (op->active_next != NULL)
699 op->active_next->active_prev = NULL;
700 }
701 else
702 {
703 op->active_prev->active_next = op->active_next;
704 if (op->active_next)
705 op->active_next->active_prev = op->active_prev;
706 }
707 op->active_next = NULL;
708 op->active_prev = NULL;
709}
710
711/* 574/*
712 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
713 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
714 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
715 * invisible object, etc...) 578 * invisible object, etc...)
716 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
717 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
718 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
719 * 582 *
720 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
721 * For example, if the only thing that has changed is the face (due to
722 * an animation), we don't need to call update_position until that actually
723 * comes into view of a player. OTOH, many other things, like addition/removal
724 * of walls or living creatures may need us to update the flags now.
725 * current action are: 584 * current action are:
726 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
727 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
728 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
729 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
730 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
731 */ 590 */
732
733void 591void
734update_object (object *op, int action) 592update_object (object *op, int action)
735{ 593{
736 int update_now = 0, flags;
737 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
738 595
739 if (op == NULL) 596 if (op == NULL)
740 { 597 {
741 /* this should never happen */ 598 /* this should never happen */
742 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
743 return; 600 return;
744 } 601 }
745 602
746 if (op->env != NULL) 603 if (op->env)
747 { 604 {
748 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
749 * to do in this case. 606 * to do in this case.
750 */ 607 */
751 return; 608 return;
756 */ 613 */
757 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
758 return; 615 return;
759 616
760 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
761 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
762 { 619 {
763 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
764#ifdef MANY_CORES 621#ifdef MANY_CORES
765 abort (); 622 abort ();
766#endif 623#endif
767 return; 624 return;
768 } 625 }
769 626
770 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
771 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
772 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
773 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
774 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
775 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
776 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
777 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
778 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
779 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
780 update_now = 1;
781
782 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
783 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
784 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
785 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
789 update_now = 1;
790
791 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
792 update_now = 1;
793
794 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
795 update_now = 1;
796
797 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
798 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
799
800 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
801 * to have move_allow right now. 644 * to have move_allow right now.
802 */ 645 */
803 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
804 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
805 648 m.flags_ = 0;
806 if ((move_slow | op->move_slow) != move_slow)
807 update_now = 1;
808 } 649 }
809 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
810 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
811 * that is being removed. 652 * that is being removed.
812 */ 653 */
813 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
814 update_now = 1; 655 m.flags_ = 0;
815 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
816 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
817 else 658 else
818 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
819 660
820 if (update_now)
821 {
822 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
823 update_position (op->map, op->x, op->y);
824 }
825
826 if (op->more != NULL) 661 if (op->more)
827 update_object (op->more, action); 662 update_object (op->more, action);
828} 663}
829 664
830object::vector object::mortals;
831object::vector object::objects; // not yet used
832object *object::first; 665object *object::first;
833
834void object::free_mortals ()
835{
836 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
837 if ((*i)->refcnt)
838 ++i; // further delay freeing
839 else
840 {
841 delete *i;
842 mortals.erase (i);
843 }
844
845 static int lastmortals = 0;//D
846
847 if (mortals.size() != lastmortals && lastmortals > 100)//D
848 {
849 lastmortals = mortals.size ();//D
850 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
851 }
852}
853 666
854object::object () 667object::object ()
855{ 668{
856 SET_FLAG (this, FLAG_REMOVED); 669 SET_FLAG (this, FLAG_REMOVED);
857 670
889 702
890 prev = 0; 703 prev = 0;
891 next = 0; 704 next = 0;
892} 705}
893 706
707bool
708object::active () const
709{
710 return active_next || active_prev || this == active_objects;
711}
712
713void
714object::activate ()
715{
716 /* If already on active list, don't do anything */
717 if (active ())
718 return;
719
720 if (has_active_speed ())
721 {
722 /* process_events() expects us to insert the object at the beginning
723 * of the list. */
724 active_next = active_objects;
725
726 if (active_next)
727 active_next->active_prev = this;
728
729 active_objects = this;
730 }
731}
732
733void
734object::activate_recursive ()
735{
736 activate ();
737
738 for (object *op = inv; op; op = op->below)
739 op->activate_recursive ();
740}
741
742/* This function removes object 'op' from the list of active
743 * objects.
744 * This should only be used for style maps or other such
745 * reference maps where you don't want an object that isn't
746 * in play chewing up cpu time getting processed.
747 * The reverse of this is to call update_ob_speed, which
748 * will do the right thing based on the speed of the object.
749 */
750void
751object::deactivate ()
752{
753 /* If not on the active list, nothing needs to be done */
754 if (!active ())
755 return;
756
757 if (active_prev == 0)
758 {
759 active_objects = active_next;
760 if (active_next)
761 active_next->active_prev = 0;
762 }
763 else
764 {
765 active_prev->active_next = active_next;
766 if (active_next)
767 active_next->active_prev = active_prev;
768 }
769
770 active_next = 0;
771 active_prev = 0;
772}
773
774void
775object::deactivate_recursive ()
776{
777 for (object *op = inv; op; op = op->below)
778 op->deactivate_recursive ();
779
780 deactivate ();
781}
782
783/*
784 * Remove and free all objects in the inventory of the given object.
785 * object.c ?
786 */
787void
788object::destroy_inv (bool drop_to_ground)
789{
790 // need to check first, because the checks below might segfault
791 // as we might be on an invalid mapspace and crossfire code
792 // is too buggy to ensure that the inventory is empty.
793 // corollary: if you create arrows etc. with stuff in tis inventory,
794 // cf will crash below with off-map x and y
795 if (!inv)
796 return;
797
798 /* Only if the space blocks everything do we not process -
799 * if some form of movement is allowed, let objects
800 * drop on that space.
801 */
802 if (!drop_to_ground
803 || !map
804 || map->in_memory != MAP_IN_MEMORY
805 || ms ().move_block == MOVE_ALL)
806 {
807 while (inv)
808 {
809 inv->destroy_inv (drop_to_ground);
810 inv->destroy ();
811 }
812 }
813 else
814 { /* Put objects in inventory onto this space */
815 while (inv)
816 {
817 object *op = inv;
818
819 if (op->flag [FLAG_STARTEQUIP]
820 || op->flag [FLAG_NO_DROP]
821 || op->type == RUNE
822 || op->type == TRAP
823 || op->flag [FLAG_IS_A_TEMPLATE])
824 op->destroy ();
825 else
826 map->insert (op, x, y);
827 }
828 }
829}
830
894object *object::create () 831object *object::create ()
895{ 832{
896 object *op = new object; 833 object *op = new object;
897 op->link (); 834 op->link ();
898 return op; 835 return op;
899} 836}
900 837
901/* 838void
902 * free_object() frees everything allocated by an object, removes 839object::do_destroy ()
903 * it from the list of used objects, and puts it on the list of
904 * free objects. The IS_FREED() flag is set in the object.
905 * The object must have been removed by remove_ob() first for
906 * this function to succeed.
907 *
908 * If destroy_inventory is set, free inventory as well. Else drop items in
909 * inventory to the ground.
910 */
911void object::destroy (bool destroy_inventory)
912{ 840{
913 if (QUERY_FLAG (this, FLAG_FREED)) 841 if (flag [FLAG_IS_LINKED])
842 remove_button_link (this);
843
844 if (flag [FLAG_FRIENDLY])
845 remove_friendly_object (this);
846
847 if (!flag [FLAG_REMOVED])
848 remove ();
849
850 if (flag [FLAG_FREED])
914 return; 851 return;
915 852
916 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 853 set_speed (0);
917 remove_friendly_object (this);
918 854
919 if (!QUERY_FLAG (this, FLAG_REMOVED)) 855 flag [FLAG_FREED] = 1;
920 remove_ob (this);
921 856
922 SET_FLAG (this, FLAG_FREED); 857 attachable::do_destroy ();
858
859 destroy_inv (true);
860 unlink ();
923 861
924 // hack to ensure that freed objects still have a valid map 862 // hack to ensure that freed objects still have a valid map
925 { 863 {
926 static maptile *freed_map; // freed objects are moved here to avoid crashes 864 static maptile *freed_map; // freed objects are moved here to avoid crashes
927 865
931 869
932 freed_map->name = "/internal/freed_objects_map"; 870 freed_map->name = "/internal/freed_objects_map";
933 freed_map->width = 3; 871 freed_map->width = 3;
934 freed_map->height = 3; 872 freed_map->height = 3;
935 873
936 freed_map->allocate (); 874 freed_map->alloc ();
875 freed_map->in_memory = MAP_IN_MEMORY;
937 } 876 }
938 877
939 map = freed_map; 878 map = freed_map;
940 x = 1; 879 x = 1;
941 y = 1; 880 y = 1;
942 } 881 }
943 882
883 head = 0;
884
944 if (more) 885 if (more)
945 { 886 {
946 more->destroy (destroy_inventory); 887 more->destroy ();
947 more = 0; 888 more = 0;
948 }
949
950 if (inv)
951 {
952 /* Only if the space blocks everything do we not process -
953 * if some form of movement is allowed, let objects
954 * drop on that space.
955 */
956 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
957 {
958 object *op = inv;
959
960 while (op)
961 {
962 object *tmp = op->below;
963 op->destroy (destroy_inventory);
964 op = tmp;
965 }
966 }
967 else
968 { /* Put objects in inventory onto this space */
969 object *op = inv;
970
971 while (op)
972 {
973 object *tmp = op->below;
974
975 remove_ob (op);
976
977 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
978 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
979 free_object (op);
980 else
981 {
982 op->x = x;
983 op->y = y;
984 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
985 }
986
987 op = tmp;
988 }
989 }
990 } 889 }
991 890
992 // clear those pointers that likely might have circular references to us 891 // clear those pointers that likely might have circular references to us
993 owner = 0; 892 owner = 0;
994 enemy = 0; 893 enemy = 0;
995 attacked_by = 0; 894 attacked_by = 0;
996 895
997 // only relevant for players(?), but make sure of it anyways 896 // only relevant for players(?), but make sure of it anyways
998 contr = 0; 897 contr = 0;
898}
999 899
1000 /* Remove object from the active list */ 900void
1001 speed = 0; 901object::destroy (bool destroy_inventory)
1002 update_ob_speed (this); 902{
903 if (destroyed ())
904 return;
1003 905
1004 unlink (); 906 if (destroy_inventory)
907 destroy_inv (false);
1005 908
1006 mortals.push_back (this); 909 attachable::destroy ();
1007} 910}
1008 911
1009/* 912/*
1010 * sub_weight() recursively (outwards) subtracts a number from the 913 * sub_weight() recursively (outwards) subtracts a number from the
1011 * weight of an object (and what is carried by it's environment(s)). 914 * weight of an object (and what is carried by it's environment(s)).
1012 */ 915 */
1013
1014void 916void
1015sub_weight (object *op, signed long weight) 917sub_weight (object *op, signed long weight)
1016{ 918{
1017 while (op != NULL) 919 while (op != NULL)
1018 { 920 {
1022 op->carrying -= weight; 924 op->carrying -= weight;
1023 op = op->env; 925 op = op->env;
1024 } 926 }
1025} 927}
1026 928
1027/* remove_ob(op): 929/* op->remove ():
1028 * This function removes the object op from the linked list of objects 930 * This function removes the object op from the linked list of objects
1029 * which it is currently tied to. When this function is done, the 931 * which it is currently tied to. When this function is done, the
1030 * object will have no environment. If the object previously had an 932 * object will have no environment. If the object previously had an
1031 * environment, the x and y coordinates will be updated to 933 * environment, the x and y coordinates will be updated to
1032 * the previous environment. 934 * the previous environment.
1033 * Beware: This function is called from the editor as well! 935 * Beware: This function is called from the editor as well!
1034 */ 936 */
1035
1036void 937void
1037remove_ob (object *op) 938object::remove ()
1038{ 939{
1039 object *tmp, *last = 0; 940 object *tmp, *last = 0;
1040 object *otmp; 941 object *otmp;
1041 942
1042 int check_walk_off;
1043 maptile *m;
1044
1045 sint16 x, y;
1046
1047 if (QUERY_FLAG (op, FLAG_REMOVED)) 943 if (QUERY_FLAG (this, FLAG_REMOVED))
1048 return; 944 return;
1049 945
1050 SET_FLAG (op, FLAG_REMOVED); 946 SET_FLAG (this, FLAG_REMOVED);
947 INVOKE_OBJECT (REMOVE, this);
1051 948
1052 if (op->more != NULL) 949 if (more)
1053 remove_ob (op->more); 950 more->remove ();
1054 951
1055 /* 952 /*
1056 * In this case, the object to be removed is in someones 953 * In this case, the object to be removed is in someones
1057 * inventory. 954 * inventory.
1058 */ 955 */
1059 if (op->env != NULL) 956 if (env)
1060 { 957 {
1061 if (op->nrof) 958 if (nrof)
1062 sub_weight (op->env, op->weight * op->nrof); 959 sub_weight (env, weight * nrof);
1063 else 960 else
1064 sub_weight (op->env, op->weight + op->carrying); 961 sub_weight (env, weight + carrying);
1065 962
1066 /* NO_FIX_PLAYER is set when a great many changes are being 963 /* NO_FIX_PLAYER is set when a great many changes are being
1067 * made to players inventory. If set, avoiding the call 964 * made to players inventory. If set, avoiding the call
1068 * to save cpu time. 965 * to save cpu time.
1069 */ 966 */
1070 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 967 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1071 fix_player (otmp); 968 otmp->update_stats ();
1072 969
1073 if (op->above != NULL) 970 if (above)
1074 op->above->below = op->below; 971 above->below = below;
1075 else 972 else
1076 op->env->inv = op->below; 973 env->inv = below;
1077 974
1078 if (op->below != NULL) 975 if (below)
1079 op->below->above = op->above; 976 below->above = above;
1080 977
1081 /* we set up values so that it could be inserted into 978 /* we set up values so that it could be inserted into
1082 * the map, but we don't actually do that - it is up 979 * the map, but we don't actually do that - it is up
1083 * to the caller to decide what we want to do. 980 * to the caller to decide what we want to do.
1084 */ 981 */
1085 op->x = op->env->x, op->y = op->env->y; 982 x = env->x, y = env->y;
1086 op->map = op->env->map; 983 map = env->map;
1087 op->above = NULL, op->below = NULL; 984 above = 0, below = 0;
1088 op->env = NULL; 985 env = 0;
1089 } 986 }
1090 else if (op->map) 987 else if (map)
1091 { 988 {
1092 x = op->x; 989 if (type == PLAYER)
1093 y = op->y;
1094 m = get_map_from_coord (op->map, &x, &y);
1095
1096 if (!m)
1097 {
1098 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1099 op->map->path, op->x, op->y);
1100 /* in old days, we used to set x and y to 0 and continue.
1101 * it seems if we get into this case, something is probablye
1102 * screwed up and should be fixed.
1103 */
1104 abort ();
1105 } 990 {
1106 991 --map->players;
1107 if (op->map != m) 992 map->touch ();
1108 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1109 op->map->path, m->path, op->x, op->y, x, y);
1110
1111 /* Re did the following section of code - it looks like it had
1112 * lots of logic for things we no longer care about
1113 */ 993 }
994
995 map->dirty = true;
1114 996
1115 /* link the object above us */ 997 /* link the object above us */
1116 if (op->above) 998 if (above)
1117 op->above->below = op->below; 999 above->below = below;
1118 else 1000 else
1119 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1001 map->at (x, y).top = below; /* we were top, set new top */
1120 1002
1121 /* Relink the object below us, if there is one */ 1003 /* Relink the object below us, if there is one */
1122 if (op->below) 1004 if (below)
1123 op->below->above = op->above; 1005 below->above = above;
1124 else 1006 else
1125 { 1007 {
1126 /* Nothing below, which means we need to relink map object for this space 1008 /* Nothing below, which means we need to relink map object for this space
1127 * use translated coordinates in case some oddness with map tiling is 1009 * use translated coordinates in case some oddness with map tiling is
1128 * evident 1010 * evident
1129 */ 1011 */
1130 if (GET_MAP_OB (m, x, y) != op) 1012 if (GET_MAP_OB (map, x, y) != this)
1131 { 1013 {
1132 char *dump = dump_object (op); 1014 char *dump = dump_object (this);
1133 LOG (llevError, 1015 LOG (llevError,
1134 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1016 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1135 free (dump); 1017 free (dump);
1136 dump = dump_object (GET_MAP_OB (m, x, y)); 1018 dump = dump_object (GET_MAP_OB (map, x, y));
1137 LOG (llevError, "%s\n", dump); 1019 LOG (llevError, "%s\n", dump);
1138 free (dump); 1020 free (dump);
1139 } 1021 }
1140 1022
1141 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1023 map->at (x, y).bot = above; /* goes on above it. */
1142 } 1024 }
1143 1025
1144 op->above = 0; 1026 above = 0;
1145 op->below = 0; 1027 below = 0;
1146 1028
1147 if (op->map->in_memory == MAP_SAVING) 1029 if (map->in_memory == MAP_SAVING)
1148 return; 1030 return;
1149 1031
1150 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1032 int check_walk_off = !flag [FLAG_NO_APPLY];
1151 1033
1152 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1034 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1153 { 1035 {
1154 /* No point updating the players look faces if he is the object 1036 /* No point updating the players look faces if he is the object
1155 * being removed. 1037 * being removed.
1156 */ 1038 */
1157 1039
1158 if (tmp->type == PLAYER && tmp != op) 1040 if (tmp->type == PLAYER && tmp != this)
1159 { 1041 {
1160 /* If a container that the player is currently using somehow gets 1042 /* If a container that the player is currently using somehow gets
1161 * removed (most likely destroyed), update the player view 1043 * removed (most likely destroyed), update the player view
1162 * appropriately. 1044 * appropriately.
1163 */ 1045 */
1164 if (tmp->container == op) 1046 if (tmp->container == this)
1165 { 1047 {
1166 CLEAR_FLAG (op, FLAG_APPLIED); 1048 flag [FLAG_APPLIED] = 0;
1167 tmp->container = NULL; 1049 tmp->container = 0;
1168 } 1050 }
1169 1051
1170 tmp->contr->socket.update_look = 1; 1052 if (tmp->contr->ns)
1053 tmp->contr->ns->floorbox_update ();
1171 } 1054 }
1172 1055
1173 /* See if player moving off should effect something */ 1056 /* See if object moving off should effect something */
1174 if (check_walk_off 1057 if (check_walk_off
1175 && ((op->move_type & tmp->move_off) 1058 && ((move_type & tmp->move_off)
1176 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1059 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1177 { 1060 {
1178 move_apply (tmp, op, NULL); 1061 move_apply (tmp, this, 0);
1179 1062
1180 if (op->destroyed ()) 1063 if (destroyed ())
1181 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1064 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1182 } 1065 }
1183 1066
1184 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1067 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1185 1068 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1186 if (tmp->above == tmp) 1069 if (tmp->above == tmp)
1187 tmp->above = NULL; 1070 tmp->above = 0;
1188 1071
1189 last = tmp; 1072 last = tmp;
1190 } 1073 }
1191 1074
1192 /* last == NULL of there are no objects on this space */ 1075 /* last == NULL if there are no objects on this space */
1076 //TODO: this makes little sense, why only update the topmost object?
1193 if (last == NULL) 1077 if (!last)
1194 { 1078 map->at (x, y).flags_ = 0;
1195 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1196 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1197 * those out anyways, and if there are any flags set right now, they won't
1198 * be correct anyways.
1199 */
1200 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1201 update_position (op->map, op->x, op->y);
1202 }
1203 else 1079 else
1204 update_object (last, UP_OBJ_REMOVE); 1080 update_object (last, UP_OBJ_REMOVE);
1205 1081
1206 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1082 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1207 update_all_los (op->map, op->x, op->y); 1083 update_all_los (map, x, y);
1208 } 1084 }
1209} 1085}
1210 1086
1211/* 1087/*
1212 * merge_ob(op,top): 1088 * merge_ob(op,top):
1220merge_ob (object *op, object *top) 1096merge_ob (object *op, object *top)
1221{ 1097{
1222 if (!op->nrof) 1098 if (!op->nrof)
1223 return 0; 1099 return 0;
1224 1100
1225 if (top == NULL) 1101 if (top)
1226 for (top = op; top != NULL && top->above != NULL; top = top->above); 1102 for (top = op; top && top->above; top = top->above)
1103 ;
1227 1104
1228 for (; top != NULL; top = top->below) 1105 for (; top; top = top->below)
1229 { 1106 {
1230 if (top == op) 1107 if (top == op)
1231 continue; 1108 continue;
1232 if (CAN_MERGE (op, top)) 1109
1110 if (object::can_merge (op, top))
1233 { 1111 {
1234 top->nrof += op->nrof; 1112 top->nrof += op->nrof;
1235 1113
1236/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1114/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1237 op->weight = 0; /* Don't want any adjustements now */ 1115 op->weight = 0; /* Don't want any adjustements now */
1238 remove_ob (op); 1116 op->destroy ();
1239 free_object (op);
1240 return top; 1117 return top;
1241 } 1118 }
1242 } 1119 }
1243 1120
1244 return 0; 1121 return 0;
1249 * job preparing multi-part monsters 1126 * job preparing multi-part monsters
1250 */ 1127 */
1251object * 1128object *
1252insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1129insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1253{ 1130{
1254 object *tmp;
1255
1256 if (op->head)
1257 op = op->head;
1258
1259 for (tmp = op; tmp; tmp = tmp->more) 1131 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1260 { 1132 {
1261 tmp->x = x + tmp->arch->clone.x; 1133 tmp->x = x + tmp->arch->clone.x;
1262 tmp->y = y + tmp->arch->clone.y; 1134 tmp->y = y + tmp->arch->clone.y;
1263 } 1135 }
1264 1136
1283 * Return value: 1155 * Return value:
1284 * new object if 'op' was merged with other object 1156 * new object if 'op' was merged with other object
1285 * NULL if 'op' was destroyed 1157 * NULL if 'op' was destroyed
1286 * just 'op' otherwise 1158 * just 'op' otherwise
1287 */ 1159 */
1288
1289object * 1160object *
1290insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1161insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1291{ 1162{
1292 object *tmp, *top, *floor = NULL; 1163 object *tmp, *top, *floor = NULL;
1293 sint16 x, y; 1164 sint16 x, y;
1296 { 1167 {
1297 LOG (llevError, "Trying to insert freed object!\n"); 1168 LOG (llevError, "Trying to insert freed object!\n");
1298 return NULL; 1169 return NULL;
1299 } 1170 }
1300 1171
1301 if (m == NULL) 1172 if (!m)
1302 { 1173 {
1303 char *dump = dump_object (op); 1174 char *dump = dump_object (op);
1304 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1175 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1305 free (dump); 1176 free (dump);
1306 return op; 1177 return op;
1327 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1198 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1328 free (dump); 1199 free (dump);
1329 return op; 1200 return op;
1330 } 1201 }
1331 1202
1332 if (op->more != NULL) 1203 if (op->more)
1333 { 1204 {
1334 /* The part may be on a different map. */ 1205 /* The part may be on a different map. */
1335 1206
1336 object *more = op->more; 1207 object *more = op->more;
1337 1208
1353 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1224 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1354 { 1225 {
1355 if (!op->head) 1226 if (!op->head)
1356 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1227 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1357 1228
1358 return NULL; 1229 return 0;
1359 } 1230 }
1360 } 1231 }
1361 1232
1362 CLEAR_FLAG (op, FLAG_REMOVED); 1233 CLEAR_FLAG (op, FLAG_REMOVED);
1363 1234
1370 y = op->y; 1241 y = op->y;
1371 1242
1372 /* this has to be done after we translate the coordinates. 1243 /* this has to be done after we translate the coordinates.
1373 */ 1244 */
1374 if (op->nrof && !(flag & INS_NO_MERGE)) 1245 if (op->nrof && !(flag & INS_NO_MERGE))
1375 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1246 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1376 if (CAN_MERGE (op, tmp)) 1247 if (object::can_merge (op, tmp))
1377 { 1248 {
1378 op->nrof += tmp->nrof; 1249 op->nrof += tmp->nrof;
1379 remove_ob (tmp); 1250 tmp->destroy ();
1380 free_object (tmp);
1381 } 1251 }
1382 1252
1383 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1253 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1384 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1254 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1385 1255
1398 op->below = originator->below; 1268 op->below = originator->below;
1399 1269
1400 if (op->below) 1270 if (op->below)
1401 op->below->above = op; 1271 op->below->above = op;
1402 else 1272 else
1403 SET_MAP_OB (op->map, op->x, op->y, op); 1273 op->ms ().bot = op;
1404 1274
1405 /* since *below* originator, no need to update top */ 1275 /* since *below* originator, no need to update top */
1406 originator->below = op; 1276 originator->below = op;
1407 } 1277 }
1408 else 1278 else
1409 { 1279 {
1410 /* If there are other objects, then */ 1280 /* If there are other objects, then */
1411 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1281 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1412 { 1282 {
1413 object *last = NULL; 1283 object *last = 0;
1414 1284
1415 /* 1285 /*
1416 * If there are multiple objects on this space, we do some trickier handling. 1286 * If there are multiple objects on this space, we do some trickier handling.
1417 * We've already dealt with merging if appropriate. 1287 * We've already dealt with merging if appropriate.
1418 * Generally, we want to put the new object on top. But if 1288 * Generally, we want to put the new object on top. But if
1422 * once we get to them. This reduces the need to traverse over all of 1292 * once we get to them. This reduces the need to traverse over all of
1423 * them when adding another one - this saves quite a bit of cpu time 1293 * them when adding another one - this saves quite a bit of cpu time
1424 * when lots of spells are cast in one area. Currently, it is presumed 1294 * when lots of spells are cast in one area. Currently, it is presumed
1425 * that flying non pickable objects are spell objects. 1295 * that flying non pickable objects are spell objects.
1426 */ 1296 */
1427
1428 while (top != NULL) 1297 while (top)
1429 { 1298 {
1430 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1299 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1431 floor = top; 1300 floor = top;
1432 1301
1433 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1302 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1454 * If INS_ON_TOP is used, don't do this processing 1323 * If INS_ON_TOP is used, don't do this processing
1455 * Need to find the object that in fact blocks view, otherwise 1324 * Need to find the object that in fact blocks view, otherwise
1456 * stacking is a bit odd. 1325 * stacking is a bit odd.
1457 */ 1326 */
1458 if (!(flag & INS_ON_TOP) && 1327 if (!(flag & INS_ON_TOP) &&
1459 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1328 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1460 { 1329 {
1461 for (last = top; last != floor; last = last->below) 1330 for (last = top; last != floor; last = last->below)
1462 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1331 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1463 break; 1332 break;
1464 /* Check to see if we found the object that blocks view, 1333 /* Check to see if we found the object that blocks view,
1486 op->above = GET_MAP_OB (op->map, op->x, op->y); 1355 op->above = GET_MAP_OB (op->map, op->x, op->y);
1487 1356
1488 if (op->above) 1357 if (op->above)
1489 op->above->below = op; 1358 op->above->below = op;
1490 1359
1491 op->below = NULL; 1360 op->below = 0;
1492 SET_MAP_OB (op->map, op->x, op->y, op); 1361 op->ms ().bot = op;
1493 } 1362 }
1494 else 1363 else
1495 { /* get inserted into the stack above top */ 1364 { /* get inserted into the stack above top */
1496 op->above = top->above; 1365 op->above = top->above;
1497 1366
1500 1369
1501 op->below = top; 1370 op->below = top;
1502 top->above = op; 1371 top->above = op;
1503 } 1372 }
1504 1373
1505 if (op->above == NULL) 1374 if (!op->above)
1506 SET_MAP_TOP (op->map, op->x, op->y, op); 1375 op->ms ().top = op;
1507 } /* else not INS_BELOW_ORIGINATOR */ 1376 } /* else not INS_BELOW_ORIGINATOR */
1508 1377
1509 if (op->type == PLAYER) 1378 if (op->type == PLAYER)
1379 {
1510 op->contr->do_los = 1; 1380 op->contr->do_los = 1;
1381 ++op->map->players;
1382 op->map->touch ();
1383 }
1384
1385 op->map->dirty = true;
1511 1386
1512 /* If we have a floor, we know the player, if any, will be above 1387 /* If we have a floor, we know the player, if any, will be above
1513 * it, so save a few ticks and start from there. 1388 * it, so save a few ticks and start from there.
1514 */ 1389 */
1515 if (!(flag & INS_MAP_LOAD)) 1390 if (!(flag & INS_MAP_LOAD))
1516 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1391 if (object *pl = op->ms ().player ())
1517 if (tmp->type == PLAYER) 1392 if (pl->contr->ns)
1518 tmp->contr->socket.update_look = 1; 1393 pl->contr->ns->floorbox_update ();
1519 1394
1520 /* If this object glows, it may affect lighting conditions that are 1395 /* If this object glows, it may affect lighting conditions that are
1521 * visible to others on this map. But update_all_los is really 1396 * visible to others on this map. But update_all_los is really
1522 * an inefficient way to do this, as it means los for all players 1397 * an inefficient way to do this, as it means los for all players
1523 * on the map will get recalculated. The players could very well 1398 * on the map will get recalculated. The players could very well
1524 * be far away from this change and not affected in any way - 1399 * be far away from this change and not affected in any way -
1525 * this should get redone to only look for players within range, 1400 * this should get redone to only look for players within range,
1526 * or just updating the P_NEED_UPDATE for spaces within this area 1401 * or just updating the P_UPTODATE for spaces within this area
1527 * of effect may be sufficient. 1402 * of effect may be sufficient.
1528 */ 1403 */
1529 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1404 if (op->map->darkness && (op->glow_radius != 0))
1530 update_all_los (op->map, op->x, op->y); 1405 update_all_los (op->map, op->x, op->y);
1531 1406
1532 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1407 /* updates flags (blocked, alive, no magic, etc) for this map space */
1533 update_object (op, UP_OBJ_INSERT); 1408 update_object (op, UP_OBJ_INSERT);
1534 1409
1410 INVOKE_OBJECT (INSERT, op);
1411
1535 /* Don't know if moving this to the end will break anything. However, 1412 /* Don't know if moving this to the end will break anything. However,
1536 * we want to have update_look set above before calling this. 1413 * we want to have floorbox_update called before calling this.
1537 * 1414 *
1538 * check_move_on() must be after this because code called from 1415 * check_move_on() must be after this because code called from
1539 * check_move_on() depends on correct map flags (so functions like 1416 * check_move_on() depends on correct map flags (so functions like
1540 * blocked() and wall() work properly), and these flags are updated by 1417 * blocked() and wall() work properly), and these flags are updated by
1541 * update_object(). 1418 * update_object().
1543 1420
1544 /* if this is not the head or flag has been passed, don't check walk on status */ 1421 /* if this is not the head or flag has been passed, don't check walk on status */
1545 if (!(flag & INS_NO_WALK_ON) && !op->head) 1422 if (!(flag & INS_NO_WALK_ON) && !op->head)
1546 { 1423 {
1547 if (check_move_on (op, originator)) 1424 if (check_move_on (op, originator))
1548 return NULL; 1425 return 0;
1549 1426
1550 /* If we are a multi part object, lets work our way through the check 1427 /* If we are a multi part object, lets work our way through the check
1551 * walk on's. 1428 * walk on's.
1552 */ 1429 */
1553 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1430 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1554 if (check_move_on (tmp, originator)) 1431 if (check_move_on (tmp, originator))
1555 return NULL; 1432 return 0;
1556 } 1433 }
1557 1434
1558 return op; 1435 return op;
1559} 1436}
1560 1437
1561/* this function inserts an object in the map, but if it 1438/* this function inserts an object in the map, but if it
1562 * finds an object of its own type, it'll remove that one first. 1439 * finds an object of its own type, it'll remove that one first.
1563 * op is the object to insert it under: supplies x and the map. 1440 * op is the object to insert it under: supplies x and the map.
1564 */ 1441 */
1565void 1442void
1566replace_insert_ob_in_map (const char *arch_string, object *op) 1443replace_insert_ob_in_map (const char *arch_string, object *op)
1567{ 1444{
1568 object * 1445 object *tmp, *tmp1;
1569 tmp;
1570 object *
1571 tmp1;
1572 1446
1573 /* first search for itself and remove any old instances */ 1447 /* first search for itself and remove any old instances */
1574 1448
1575 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1449 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1576 {
1577 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1450 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1578 { 1451 tmp->destroy ();
1579 remove_ob (tmp);
1580 free_object (tmp);
1581 }
1582 }
1583 1452
1584 tmp1 = arch_to_object (archetype::find (arch_string)); 1453 tmp1 = arch_to_object (archetype::find (arch_string));
1585 1454
1586 tmp1->x = op->x; 1455 tmp1->x = op->x;
1587 tmp1->y = op->y; 1456 tmp1->y = op->y;
1588 insert_ob_in_map (tmp1, op->map, op, 0); 1457 insert_ob_in_map (tmp1, op->map, op, 0);
1458}
1459
1460object *
1461object::insert_at (object *where, object *originator, int flags)
1462{
1463 where->map->insert (this, where->x, where->y, originator, flags);
1589} 1464}
1590 1465
1591/* 1466/*
1592 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1467 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1593 * is returned contains nr objects, and the remaining parts contains 1468 * is returned contains nr objects, and the remaining parts contains
1594 * the rest (or is removed and freed if that number is 0). 1469 * the rest (or is removed and freed if that number is 0).
1595 * On failure, NULL is returned, and the reason put into the 1470 * On failure, NULL is returned, and the reason put into the
1596 * global static errmsg array. 1471 * global static errmsg array.
1597 */ 1472 */
1598
1599object * 1473object *
1600get_split_ob (object *orig_ob, uint32 nr) 1474get_split_ob (object *orig_ob, uint32 nr)
1601{ 1475{
1602 object * 1476 object *newob;
1603 newob;
1604 int
1605 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1477 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1606 1478
1607 if (orig_ob->nrof < nr) 1479 if (orig_ob->nrof < nr)
1608 { 1480 {
1609 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1481 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1610 return NULL; 1482 return NULL;
1611 } 1483 }
1612 1484
1613 newob = object_create_clone (orig_ob); 1485 newob = object_create_clone (orig_ob);
1614 1486
1615 if ((orig_ob->nrof -= nr) < 1) 1487 if ((orig_ob->nrof -= nr) < 1)
1616 { 1488 orig_ob->destroy (1);
1617 if (!is_removed)
1618 remove_ob (orig_ob);
1619 free_object2 (orig_ob, 1);
1620 }
1621 else if (!is_removed) 1489 else if (!is_removed)
1622 { 1490 {
1623 if (orig_ob->env != NULL) 1491 if (orig_ob->env != NULL)
1624 sub_weight (orig_ob->env, orig_ob->weight * nr); 1492 sub_weight (orig_ob->env, orig_ob->weight * nr);
1625 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1493 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1645 1513
1646object * 1514object *
1647decrease_ob_nr (object *op, uint32 i) 1515decrease_ob_nr (object *op, uint32 i)
1648{ 1516{
1649 object *tmp; 1517 object *tmp;
1650 player *pl;
1651 1518
1652 if (i == 0) /* objects with op->nrof require this check */ 1519 if (i == 0) /* objects with op->nrof require this check */
1653 return op; 1520 return op;
1654 1521
1655 if (i > op->nrof) 1522 if (i > op->nrof)
1656 i = op->nrof; 1523 i = op->nrof;
1657 1524
1658 if (QUERY_FLAG (op, FLAG_REMOVED)) 1525 if (QUERY_FLAG (op, FLAG_REMOVED))
1659 op->nrof -= i; 1526 op->nrof -= i;
1660 else if (op->env != NULL) 1527 else if (op->env)
1661 { 1528 {
1662 /* is this object in the players inventory, or sub container 1529 /* is this object in the players inventory, or sub container
1663 * therein? 1530 * therein?
1664 */ 1531 */
1665 tmp = is_player_inv (op->env); 1532 tmp = op->in_player ();
1666 /* nope. Is this a container the player has opened? 1533 /* nope. Is this a container the player has opened?
1667 * If so, set tmp to that player. 1534 * If so, set tmp to that player.
1668 * IMO, searching through all the players will mostly 1535 * IMO, searching through all the players will mostly
1669 * likely be quicker than following op->env to the map, 1536 * likely be quicker than following op->env to the map,
1670 * and then searching the map for a player. 1537 * and then searching the map for a player.
1671 */ 1538 */
1672 if (!tmp) 1539 if (!tmp)
1673 { 1540 for_all_players (pl)
1674 for (pl = first_player; pl; pl = pl->next)
1675 if (pl->ob->container == op->env) 1541 if (pl->ob->container == op->env)
1542 {
1543 tmp = pl->ob;
1676 break; 1544 break;
1677 if (pl)
1678 tmp = pl->ob;
1679 else
1680 tmp = NULL;
1681 } 1545 }
1682 1546
1683 if (i < op->nrof) 1547 if (i < op->nrof)
1684 { 1548 {
1685 sub_weight (op->env, op->weight * i); 1549 sub_weight (op->env, op->weight * i);
1686 op->nrof -= i; 1550 op->nrof -= i;
1687 if (tmp) 1551 if (tmp)
1688 {
1689 esrv_send_item (tmp, op); 1552 esrv_send_item (tmp, op);
1690 }
1691 } 1553 }
1692 else 1554 else
1693 { 1555 {
1694 remove_ob (op); 1556 op->remove ();
1695 op->nrof = 0; 1557 op->nrof = 0;
1696 if (tmp) 1558 if (tmp)
1697 {
1698 esrv_del_item (tmp->contr, op->count); 1559 esrv_del_item (tmp->contr, op->count);
1699 }
1700 } 1560 }
1701 } 1561 }
1702 else 1562 else
1703 { 1563 {
1704 object *above = op->above; 1564 object *above = op->above;
1705 1565
1706 if (i < op->nrof) 1566 if (i < op->nrof)
1707 op->nrof -= i; 1567 op->nrof -= i;
1708 else 1568 else
1709 { 1569 {
1710 remove_ob (op); 1570 op->remove ();
1711 op->nrof = 0; 1571 op->nrof = 0;
1712 } 1572 }
1713 1573
1714 /* Since we just removed op, op->above is null */ 1574 /* Since we just removed op, op->above is null */
1715 for (tmp = above; tmp != NULL; tmp = tmp->above) 1575 for (tmp = above; tmp; tmp = tmp->above)
1716 if (tmp->type == PLAYER) 1576 if (tmp->type == PLAYER)
1717 { 1577 {
1718 if (op->nrof) 1578 if (op->nrof)
1719 esrv_send_item (tmp, op); 1579 esrv_send_item (tmp, op);
1720 else 1580 else
1724 1584
1725 if (op->nrof) 1585 if (op->nrof)
1726 return op; 1586 return op;
1727 else 1587 else
1728 { 1588 {
1729 free_object (op); 1589 op->destroy ();
1730 return NULL; 1590 return 0;
1731 } 1591 }
1732} 1592}
1733 1593
1734/* 1594/*
1735 * add_weight(object, weight) adds the specified weight to an object, 1595 * add_weight(object, weight) adds the specified weight to an object,
1747 op->carrying += weight; 1607 op->carrying += weight;
1748 op = op->env; 1608 op = op->env;
1749 } 1609 }
1750} 1610}
1751 1611
1752/*
1753 * insert_ob_in_ob(op,environment):
1754 * This function inserts the object op in the linked list
1755 * inside the object environment.
1756 *
1757 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1758 * the inventory at the last position or next to other objects of the same
1759 * type.
1760 * Frank: Now sorted by type, archetype and magic!
1761 *
1762 * The function returns now pointer to inserted item, and return value can
1763 * be != op, if items are merged. -Tero
1764 */
1765
1766object * 1612object *
1767insert_ob_in_ob (object *op, object *where) 1613insert_ob_in_ob (object *op, object *where)
1768{ 1614{
1769 object * 1615 if (!where)
1770 tmp, *
1771 otmp;
1772
1773 if (!QUERY_FLAG (op, FLAG_REMOVED))
1774 {
1775 char *dump = dump_object (op);
1776 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", dump);
1777 free (dump);
1778 return op;
1779 }
1780
1781 if (where == NULL)
1782 { 1616 {
1783 char *dump = dump_object (op); 1617 char *dump = dump_object (op);
1784 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); 1618 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1785 free (dump); 1619 free (dump);
1786 return op; 1620 return op;
1787 } 1621 }
1788 1622
1789 if (where->head) 1623 if (where->head)
1790 { 1624 {
1791 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n"); 1625 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1792 where = where->head; 1626 where = where->head;
1793 } 1627 }
1628
1629 return where->insert (op);
1630}
1631
1632/*
1633 * env->insert (op)
1634 * This function inserts the object op in the linked list
1635 * inside the object environment.
1636 *
1637 * The function returns now pointer to inserted item, and return value can
1638 * be != op, if items are merged. -Tero
1639 */
1640
1641object *
1642object::insert (object *op)
1643{
1644 object *tmp, *otmp;
1645
1646 if (!QUERY_FLAG (op, FLAG_REMOVED))
1647 op->remove ();
1794 1648
1795 if (op->more) 1649 if (op->more)
1796 { 1650 {
1797 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1651 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1798 return op; 1652 return op;
1800 1654
1801 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1655 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1802 CLEAR_FLAG (op, FLAG_REMOVED); 1656 CLEAR_FLAG (op, FLAG_REMOVED);
1803 if (op->nrof) 1657 if (op->nrof)
1804 { 1658 {
1805 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1659 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1806 if (CAN_MERGE (tmp, op)) 1660 if (object::can_merge (tmp, op))
1807 { 1661 {
1808 /* return the original object and remove inserted object 1662 /* return the original object and remove inserted object
1809 (client needs the original object) */ 1663 (client needs the original object) */
1810 tmp->nrof += op->nrof; 1664 tmp->nrof += op->nrof;
1811 /* Weight handling gets pretty funky. Since we are adding to 1665 /* Weight handling gets pretty funky. Since we are adding to
1812 * tmp->nrof, we need to increase the weight. 1666 * tmp->nrof, we need to increase the weight.
1813 */ 1667 */
1814 add_weight (where, op->weight * op->nrof); 1668 add_weight (this, op->weight * op->nrof);
1815 SET_FLAG (op, FLAG_REMOVED); 1669 SET_FLAG (op, FLAG_REMOVED);
1816 free_object (op); /* free the inserted object */ 1670 op->destroy (); /* free the inserted object */
1817 op = tmp; 1671 op = tmp;
1818 remove_ob (op); /* and fix old object's links */ 1672 op->remove (); /* and fix old object's links */
1819 CLEAR_FLAG (op, FLAG_REMOVED); 1673 CLEAR_FLAG (op, FLAG_REMOVED);
1820 break; 1674 break;
1821 } 1675 }
1822 1676
1823 /* I assume combined objects have no inventory 1677 /* I assume combined objects have no inventory
1824 * We add the weight - this object could have just been removed 1678 * We add the weight - this object could have just been removed
1825 * (if it was possible to merge). calling remove_ob will subtract 1679 * (if it was possible to merge). calling remove_ob will subtract
1826 * the weight, so we need to add it in again, since we actually do 1680 * the weight, so we need to add it in again, since we actually do
1827 * the linking below 1681 * the linking below
1828 */ 1682 */
1829 add_weight (where, op->weight * op->nrof); 1683 add_weight (this, op->weight * op->nrof);
1830 } 1684 }
1831 else 1685 else
1832 add_weight (where, (op->weight + op->carrying)); 1686 add_weight (this, (op->weight + op->carrying));
1833 1687
1834 otmp = is_player_inv (where); 1688 otmp = this->in_player ();
1835 if (otmp && otmp->contr != NULL) 1689 if (otmp && otmp->contr)
1836 {
1837 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1690 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1838 fix_player (otmp); 1691 otmp->update_stats ();
1839 }
1840 1692
1841 op->map = NULL; 1693 op->map = 0;
1842 op->env = where; 1694 op->env = this;
1843 op->above = NULL; 1695 op->above = 0;
1844 op->below = NULL; 1696 op->below = 0;
1845 op->x = 0, op->y = 0; 1697 op->x = 0, op->y = 0;
1846 1698
1847 /* reset the light list and los of the players on the map */ 1699 /* reset the light list and los of the players on the map */
1848 if ((op->glow_radius != 0) && where->map) 1700 if ((op->glow_radius != 0) && map)
1849 { 1701 {
1850#ifdef DEBUG_LIGHTS 1702#ifdef DEBUG_LIGHTS
1851 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1703 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1852#endif /* DEBUG_LIGHTS */ 1704#endif /* DEBUG_LIGHTS */
1853 if (MAP_DARKNESS (where->map)) 1705 if (map->darkness)
1854 update_all_los (where->map, where->x, where->y); 1706 update_all_los (map, x, y);
1855 } 1707 }
1856 1708
1857 /* Client has no idea of ordering so lets not bother ordering it here. 1709 /* Client has no idea of ordering so lets not bother ordering it here.
1858 * It sure simplifies this function... 1710 * It sure simplifies this function...
1859 */ 1711 */
1860 if (where->inv == NULL) 1712 if (!inv)
1861 where->inv = op; 1713 inv = op;
1862 else 1714 else
1863 { 1715 {
1864 op->below = where->inv; 1716 op->below = inv;
1865 op->below->above = op; 1717 op->below->above = op;
1866 where->inv = op; 1718 inv = op;
1867 } 1719 }
1720
1721 INVOKE_OBJECT (INSERT, this);
1722
1868 return op; 1723 return op;
1869} 1724}
1870 1725
1871/* 1726/*
1872 * Checks if any objects has a move_type that matches objects 1727 * Checks if any objects has a move_type that matches objects
1886 * 1741 *
1887 * MSW 2001-07-08: Check all objects on space, not just those below 1742 * MSW 2001-07-08: Check all objects on space, not just those below
1888 * object being inserted. insert_ob_in_map may not put new objects 1743 * object being inserted. insert_ob_in_map may not put new objects
1889 * on top. 1744 * on top.
1890 */ 1745 */
1891
1892int 1746int
1893check_move_on (object *op, object *originator) 1747check_move_on (object *op, object *originator)
1894{ 1748{
1895 object *tmp; 1749 object *tmp;
1896 maptile *m = op->map; 1750 maptile *m = op->map;
1923 1777
1924 /* The objects have to be checked from top to bottom. 1778 /* The objects have to be checked from top to bottom.
1925 * Hence, we first go to the top: 1779 * Hence, we first go to the top:
1926 */ 1780 */
1927 1781
1928 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1782 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1929 { 1783 {
1930 /* Trim the search when we find the first other spell effect 1784 /* Trim the search when we find the first other spell effect
1931 * this helps performance so that if a space has 50 spell objects, 1785 * this helps performance so that if a space has 50 spell objects,
1932 * we don't need to check all of them. 1786 * we don't need to check all of them.
1933 */ 1787 */
1988/* 1842/*
1989 * present_arch(arch, map, x, y) searches for any objects with 1843 * present_arch(arch, map, x, y) searches for any objects with
1990 * a matching archetype at the given map and coordinates. 1844 * a matching archetype at the given map and coordinates.
1991 * The first matching object is returned, or NULL if none. 1845 * The first matching object is returned, or NULL if none.
1992 */ 1846 */
1993
1994object * 1847object *
1995present_arch (const archetype *at, maptile *m, int x, int y) 1848present_arch (const archetype *at, maptile *m, int x, int y)
1996{ 1849{
1997 object *
1998 tmp;
1999
2000 if (m == NULL || out_of_map (m, x, y)) 1850 if (!m || out_of_map (m, x, y))
2001 { 1851 {
2002 LOG (llevError, "Present_arch called outside map.\n"); 1852 LOG (llevError, "Present_arch called outside map.\n");
2003 return NULL; 1853 return NULL;
2004 } 1854 }
2005 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1855
1856 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2006 if (tmp->arch == at) 1857 if (tmp->arch == at)
2007 return tmp; 1858 return tmp;
1859
2008 return NULL; 1860 return NULL;
2009} 1861}
2010 1862
2011/* 1863/*
2012 * present(type, map, x, y) searches for any objects with 1864 * present(type, map, x, y) searches for any objects with
2013 * a matching type variable at the given map and coordinates. 1865 * a matching type variable at the given map and coordinates.
2014 * The first matching object is returned, or NULL if none. 1866 * The first matching object is returned, or NULL if none.
2015 */ 1867 */
2016
2017object * 1868object *
2018present (unsigned char type, maptile *m, int x, int y) 1869present (unsigned char type, maptile *m, int x, int y)
2019{ 1870{
2020 object *
2021 tmp;
2022
2023 if (out_of_map (m, x, y)) 1871 if (out_of_map (m, x, y))
2024 { 1872 {
2025 LOG (llevError, "Present called outside map.\n"); 1873 LOG (llevError, "Present called outside map.\n");
2026 return NULL; 1874 return NULL;
2027 } 1875 }
2028 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1876
1877 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2029 if (tmp->type == type) 1878 if (tmp->type == type)
2030 return tmp; 1879 return tmp;
1880
2031 return NULL; 1881 return NULL;
2032} 1882}
2033 1883
2034/* 1884/*
2035 * present_in_ob(type, object) searches for any objects with 1885 * present_in_ob(type, object) searches for any objects with
2036 * a matching type variable in the inventory of the given object. 1886 * a matching type variable in the inventory of the given object.
2037 * The first matching object is returned, or NULL if none. 1887 * The first matching object is returned, or NULL if none.
2038 */ 1888 */
2039
2040object * 1889object *
2041present_in_ob (unsigned char type, const object *op) 1890present_in_ob (unsigned char type, const object *op)
2042{ 1891{
2043 object *
2044 tmp;
2045
2046 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1892 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2047 if (tmp->type == type) 1893 if (tmp->type == type)
2048 return tmp; 1894 return tmp;
1895
2049 return NULL; 1896 return NULL;
2050} 1897}
2051 1898
2052/* 1899/*
2053 * present_in_ob (type, str, object) searches for any objects with 1900 * present_in_ob (type, str, object) searches for any objects with
2061 * str is the string to match against. Note that we match against 1908 * str is the string to match against. Note that we match against
2062 * the object name, not the archetype name. this is so that the 1909 * the object name, not the archetype name. this is so that the
2063 * spell code can use one object type (force), but change it's name 1910 * spell code can use one object type (force), but change it's name
2064 * to be unique. 1911 * to be unique.
2065 */ 1912 */
2066
2067object * 1913object *
2068present_in_ob_by_name (int type, const char *str, const object *op) 1914present_in_ob_by_name (int type, const char *str, const object *op)
2069{ 1915{
2070 object *
2071 tmp;
2072
2073 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1916 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2074 {
2075 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1917 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2076 return tmp; 1918 return tmp;
2077 } 1919
2078 return NULL; 1920 return 0;
2079} 1921}
2080 1922
2081/* 1923/*
2082 * present_arch_in_ob(archetype, object) searches for any objects with 1924 * present_arch_in_ob(archetype, object) searches for any objects with
2083 * a matching archetype in the inventory of the given object. 1925 * a matching archetype in the inventory of the given object.
2084 * The first matching object is returned, or NULL if none. 1926 * The first matching object is returned, or NULL if none.
2085 */ 1927 */
2086
2087object * 1928object *
2088present_arch_in_ob (const archetype *at, const object *op) 1929present_arch_in_ob (const archetype *at, const object *op)
2089{ 1930{
2090 object *
2091 tmp;
2092
2093 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1931 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2094 if (tmp->arch == at) 1932 if (tmp->arch == at)
2095 return tmp; 1933 return tmp;
1934
2096 return NULL; 1935 return NULL;
2097} 1936}
2098 1937
2099/* 1938/*
2100 * activate recursively a flag on an object inventory 1939 * activate recursively a flag on an object inventory
2101 */ 1940 */
2102void 1941void
2103flag_inv (object *op, int flag) 1942flag_inv (object *op, int flag)
2104{ 1943{
2105 object *
2106 tmp;
2107
2108 if (op->inv) 1944 if (op->inv)
2109 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1945 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2110 { 1946 {
2111 SET_FLAG (tmp, flag); 1947 SET_FLAG (tmp, flag);
2112 flag_inv (tmp, flag); 1948 flag_inv (tmp, flag);
2113 } 1949 }
2114} /* 1950}
1951
1952/*
2115 * desactivate recursively a flag on an object inventory 1953 * deactivate recursively a flag on an object inventory
2116 */ 1954 */
2117void 1955void
2118unflag_inv (object *op, int flag) 1956unflag_inv (object *op, int flag)
2119{ 1957{
2120 object *
2121 tmp;
2122
2123 if (op->inv) 1958 if (op->inv)
2124 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1959 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2125 { 1960 {
2126 CLEAR_FLAG (tmp, flag); 1961 CLEAR_FLAG (tmp, flag);
2127 unflag_inv (tmp, flag); 1962 unflag_inv (tmp, flag);
2128 } 1963 }
2129} 1964}
2132 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1967 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2133 * all it's inventory (recursively). 1968 * all it's inventory (recursively).
2134 * If checksums are used, a player will get set_cheat called for 1969 * If checksums are used, a player will get set_cheat called for
2135 * him/her-self and all object carried by a call to this function. 1970 * him/her-self and all object carried by a call to this function.
2136 */ 1971 */
2137
2138void 1972void
2139set_cheat (object *op) 1973set_cheat (object *op)
2140{ 1974{
2141 SET_FLAG (op, FLAG_WAS_WIZ); 1975 SET_FLAG (op, FLAG_WAS_WIZ);
2142 flag_inv (op, FLAG_WAS_WIZ); 1976 flag_inv (op, FLAG_WAS_WIZ);
2161 * because arch_blocked (now ob_blocked) needs to know the movement type 1995 * because arch_blocked (now ob_blocked) needs to know the movement type
2162 * to know if the space in question will block the object. We can't use 1996 * to know if the space in question will block the object. We can't use
2163 * the archetype because that isn't correct if the monster has been 1997 * the archetype because that isn't correct if the monster has been
2164 * customized, changed states, etc. 1998 * customized, changed states, etc.
2165 */ 1999 */
2166
2167int 2000int
2168find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2001find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2169{ 2002{
2170 int
2171 i,
2172 index = 0, flag; 2003 int index = 0, flag;
2173 static int
2174 altern[SIZEOFFREE]; 2004 int altern[SIZEOFFREE];
2175 2005
2176 for (i = start; i < stop; i++) 2006 for (int i = start; i < stop; i++)
2177 { 2007 {
2178 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2008 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2179 if (!flag) 2009 if (!flag)
2180 altern[index++] = i; 2010 altern [index++] = i;
2181 2011
2182 /* Basically, if we find a wall on a space, we cut down the search size. 2012 /* Basically, if we find a wall on a space, we cut down the search size.
2183 * In this way, we won't return spaces that are on another side of a wall. 2013 * In this way, we won't return spaces that are on another side of a wall.
2184 * This mostly work, but it cuts down the search size in all directions - 2014 * This mostly work, but it cuts down the search size in all directions -
2185 * if the space being examined only has a wall to the north and empty 2015 * if the space being examined only has a wall to the north and empty
2186 * spaces in all the other directions, this will reduce the search space 2016 * spaces in all the other directions, this will reduce the search space
2187 * to only the spaces immediately surrounding the target area, and 2017 * to only the spaces immediately surrounding the target area, and
2188 * won't look 2 spaces south of the target space. 2018 * won't look 2 spaces south of the target space.
2189 */ 2019 */
2190 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2020 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2191 stop = maxfree[i]; 2021 stop = maxfree[i];
2192 } 2022 }
2023
2193 if (!index) 2024 if (!index)
2194 return -1; 2025 return -1;
2026
2195 return altern[RANDOM () % index]; 2027 return altern[RANDOM () % index];
2196} 2028}
2197 2029
2198/* 2030/*
2199 * find_first_free_spot(archetype, maptile, x, y) works like 2031 * find_first_free_spot(archetype, maptile, x, y) works like
2200 * find_free_spot(), but it will search max number of squares. 2032 * find_free_spot(), but it will search max number of squares.
2201 * But it will return the first available spot, not a random choice. 2033 * But it will return the first available spot, not a random choice.
2202 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2034 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2203 */ 2035 */
2204
2205int 2036int
2206find_first_free_spot (const object *ob, maptile *m, int x, int y) 2037find_first_free_spot (const object *ob, maptile *m, int x, int y)
2207{ 2038{
2208 int
2209 i;
2210
2211 for (i = 0; i < SIZEOFFREE; i++) 2039 for (int i = 0; i < SIZEOFFREE; i++)
2212 {
2213 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2040 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2214 return i; 2041 return i;
2215 } 2042
2216 return -1; 2043 return -1;
2217} 2044}
2218 2045
2219/* 2046/*
2220 * The function permute(arr, begin, end) randomly reorders the array 2047 * The function permute(arr, begin, end) randomly reorders the array
2221 * arr[begin..end-1]. 2048 * arr[begin..end-1].
2049 * now uses a fisher-yates shuffle, old permute was broken
2222 */ 2050 */
2223static void 2051static void
2224permute (int *arr, int begin, int end) 2052permute (int *arr, int begin, int end)
2225{ 2053{
2226 int 2054 arr += begin;
2227 i,
2228 j,
2229 tmp,
2230 len;
2231
2232 len = end - begin; 2055 end -= begin;
2233 for (i = begin; i < end; i++)
2234 {
2235 j = begin + RANDOM () % len;
2236 2056
2237 tmp = arr[i]; 2057 while (--end)
2238 arr[i] = arr[j]; 2058 swap (arr [end], arr [RANDOM () % (end + 1)]);
2239 arr[j] = tmp;
2240 }
2241} 2059}
2242 2060
2243/* new function to make monster searching more efficient, and effective! 2061/* new function to make monster searching more efficient, and effective!
2244 * This basically returns a randomized array (in the passed pointer) of 2062 * This basically returns a randomized array (in the passed pointer) of
2245 * the spaces to find monsters. In this way, it won't always look for 2063 * the spaces to find monsters. In this way, it won't always look for
2248 * the 3x3 area will be searched, just not in a predictable order. 2066 * the 3x3 area will be searched, just not in a predictable order.
2249 */ 2067 */
2250void 2068void
2251get_search_arr (int *search_arr) 2069get_search_arr (int *search_arr)
2252{ 2070{
2253 int 2071 int i;
2254 i;
2255 2072
2256 for (i = 0; i < SIZEOFFREE; i++) 2073 for (i = 0; i < SIZEOFFREE; i++)
2257 {
2258 search_arr[i] = i; 2074 search_arr[i] = i;
2259 }
2260 2075
2261 permute (search_arr, 1, SIZEOFFREE1 + 1); 2076 permute (search_arr, 1, SIZEOFFREE1 + 1);
2262 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2077 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2263 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2078 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2264} 2079}
2273 * Perhaps incorrectly, but I'm making the assumption that exclude 2088 * Perhaps incorrectly, but I'm making the assumption that exclude
2274 * is actually want is going to try and move there. We need this info 2089 * is actually want is going to try and move there. We need this info
2275 * because we have to know what movement the thing looking to move 2090 * because we have to know what movement the thing looking to move
2276 * there is capable of. 2091 * there is capable of.
2277 */ 2092 */
2278
2279int 2093int
2280find_dir (maptile *m, int x, int y, object *exclude) 2094find_dir (maptile *m, int x, int y, object *exclude)
2281{ 2095{
2282 int
2283 i,
2284 max = SIZEOFFREE, mflags; 2096 int i, max = SIZEOFFREE, mflags;
2285 2097
2286 sint16 nx, ny; 2098 sint16 nx, ny;
2287 object * 2099 object *tmp;
2288 tmp;
2289 maptile * 2100 maptile *mp;
2290 mp;
2291 2101
2292 MoveType blocked, move_type; 2102 MoveType blocked, move_type;
2293 2103
2294 if (exclude && exclude->head) 2104 if (exclude && exclude->head)
2295 { 2105 {
2307 mp = m; 2117 mp = m;
2308 nx = x + freearr_x[i]; 2118 nx = x + freearr_x[i];
2309 ny = y + freearr_y[i]; 2119 ny = y + freearr_y[i];
2310 2120
2311 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2121 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2122
2312 if (mflags & P_OUT_OF_MAP) 2123 if (mflags & P_OUT_OF_MAP)
2313 {
2314 max = maxfree[i]; 2124 max = maxfree[i];
2315 }
2316 else 2125 else
2317 { 2126 {
2318 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2127 mapspace &ms = mp->at (nx, ny);
2128
2129 blocked = ms.move_block;
2319 2130
2320 if ((move_type & blocked) == move_type) 2131 if ((move_type & blocked) == move_type)
2321 {
2322 max = maxfree[i]; 2132 max = maxfree[i];
2323 }
2324 else if (mflags & P_IS_ALIVE) 2133 else if (mflags & P_IS_ALIVE)
2325 { 2134 {
2326 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2135 for (tmp = ms.bot; tmp; tmp = tmp->above)
2327 { 2136 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2328 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2137 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2329 {
2330 break; 2138 break;
2331 } 2139
2332 }
2333 if (tmp) 2140 if (tmp)
2334 {
2335 return freedir[i]; 2141 return freedir[i];
2336 }
2337 } 2142 }
2338 } 2143 }
2339 } 2144 }
2145
2340 return 0; 2146 return 0;
2341} 2147}
2342 2148
2343/* 2149/*
2344 * distance(object 1, object 2) will return the square of the 2150 * distance(object 1, object 2) will return the square of the
2345 * distance between the two given objects. 2151 * distance between the two given objects.
2346 */ 2152 */
2347
2348int 2153int
2349distance (const object *ob1, const object *ob2) 2154distance (const object *ob1, const object *ob2)
2350{ 2155{
2351 int
2352 i;
2353
2354 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2156 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2355 return i;
2356} 2157}
2357 2158
2358/* 2159/*
2359 * find_dir_2(delta-x,delta-y) will return a direction in which 2160 * find_dir_2(delta-x,delta-y) will return a direction in which
2360 * an object which has subtracted the x and y coordinates of another 2161 * an object which has subtracted the x and y coordinates of another
2361 * object, needs to travel toward it. 2162 * object, needs to travel toward it.
2362 */ 2163 */
2363
2364int 2164int
2365find_dir_2 (int x, int y) 2165find_dir_2 (int x, int y)
2366{ 2166{
2367 int 2167 int q;
2368 q;
2369 2168
2370 if (y) 2169 if (y)
2371 q = x * 100 / y; 2170 q = x * 100 / y;
2372 else if (x) 2171 else if (x)
2373 q = -300 * x; 2172 q = -300 * x;
2408int 2207int
2409absdir (int d) 2208absdir (int d)
2410{ 2209{
2411 while (d < 1) 2210 while (d < 1)
2412 d += 8; 2211 d += 8;
2212
2413 while (d > 8) 2213 while (d > 8)
2414 d -= 8; 2214 d -= 8;
2215
2415 return d; 2216 return d;
2416} 2217}
2417 2218
2418/* 2219/*
2419 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2220 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2421 */ 2222 */
2422 2223
2423int 2224int
2424dirdiff (int dir1, int dir2) 2225dirdiff (int dir1, int dir2)
2425{ 2226{
2426 int 2227 int d;
2427 d;
2428 2228
2429 d = abs (dir1 - dir2); 2229 d = abs (dir1 - dir2);
2430 if (d > 4) 2230 if (d > 4)
2431 d = 8 - d; 2231 d = 8 - d;
2232
2432 return d; 2233 return d;
2433} 2234}
2434 2235
2435/* peterm: 2236/* peterm:
2436 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2237 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2439 * This basically means that if direction is 15, then it could either go 2240 * This basically means that if direction is 15, then it could either go
2440 * direction 4, 14, or 16 to get back to where we are. 2241 * direction 4, 14, or 16 to get back to where we are.
2441 * Moved from spell_util.c to object.c with the other related direction 2242 * Moved from spell_util.c to object.c with the other related direction
2442 * functions. 2243 * functions.
2443 */ 2244 */
2444
2445int
2446 reduction_dir[SIZEOFFREE][3] = { 2245int reduction_dir[SIZEOFFREE][3] = {
2447 {0, 0, 0}, /* 0 */ 2246 {0, 0, 0}, /* 0 */
2448 {0, 0, 0}, /* 1 */ 2247 {0, 0, 0}, /* 1 */
2449 {0, 0, 0}, /* 2 */ 2248 {0, 0, 0}, /* 2 */
2450 {0, 0, 0}, /* 3 */ 2249 {0, 0, 0}, /* 3 */
2451 {0, 0, 0}, /* 4 */ 2250 {0, 0, 0}, /* 4 */
2499 * find a path to that monster that we found. If not, 2298 * find a path to that monster that we found. If not,
2500 * we don't bother going toward it. Returns 1 if we 2299 * we don't bother going toward it. Returns 1 if we
2501 * can see a direct way to get it 2300 * can see a direct way to get it
2502 * Modified to be map tile aware -.MSW 2301 * Modified to be map tile aware -.MSW
2503 */ 2302 */
2504
2505
2506int 2303int
2507can_see_monsterP (maptile *m, int x, int y, int dir) 2304can_see_monsterP (maptile *m, int x, int y, int dir)
2508{ 2305{
2509 sint16 dx, dy; 2306 sint16 dx, dy;
2510 int
2511 mflags; 2307 int mflags;
2512 2308
2513 if (dir < 0) 2309 if (dir < 0)
2514 return 0; /* exit condition: invalid direction */ 2310 return 0; /* exit condition: invalid direction */
2515 2311
2516 dx = x + freearr_x[dir]; 2312 dx = x + freearr_x[dir];
2529 return 0; 2325 return 0;
2530 2326
2531 /* yes, can see. */ 2327 /* yes, can see. */
2532 if (dir < 9) 2328 if (dir < 9)
2533 return 1; 2329 return 1;
2330
2534 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2331 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2535 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2332 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2333 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2536} 2334}
2537
2538
2539 2335
2540/* 2336/*
2541 * can_pick(picker, item): finds out if an object is possible to be 2337 * can_pick(picker, item): finds out if an object is possible to be
2542 * picked up by the picker. Returnes 1 if it can be 2338 * picked up by the picker. Returnes 1 if it can be
2543 * picked up, otherwise 0. 2339 * picked up, otherwise 0.
2554 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2350 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2555 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2351 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2556 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2352 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2557} 2353}
2558 2354
2559
2560/* 2355/*
2561 * create clone from object to another 2356 * create clone from object to another
2562 */ 2357 */
2563object * 2358object *
2564object_create_clone (object *asrc) 2359object_create_clone (object *asrc)
2565{ 2360{
2566 object *
2567 dst = NULL, *tmp, *src, *part, *prev, *item; 2361 object *dst = 0, *tmp, *src, *part, *prev, *item;
2568 2362
2569 if (!asrc) 2363 if (!asrc)
2570 return NULL; 2364 return 0;
2365
2571 src = asrc; 2366 src = asrc;
2572 if (src->head) 2367 if (src->head)
2573 src = src->head; 2368 src = src->head;
2574 2369
2575 prev = NULL; 2370 prev = 0;
2576 for (part = src; part; part = part->more) 2371 for (part = src; part; part = part->more)
2577 { 2372 {
2578 tmp = get_object (); 2373 tmp = part->clone ();
2579 copy_object (part, tmp);
2580 tmp->x -= src->x; 2374 tmp->x -= src->x;
2581 tmp->y -= src->y; 2375 tmp->y -= src->y;
2376
2582 if (!part->head) 2377 if (!part->head)
2583 { 2378 {
2584 dst = tmp; 2379 dst = tmp;
2585 tmp->head = NULL; 2380 tmp->head = 0;
2586 } 2381 }
2587 else 2382 else
2588 {
2589 tmp->head = dst; 2383 tmp->head = dst;
2590 } 2384
2591 tmp->more = NULL; 2385 tmp->more = 0;
2386
2592 if (prev) 2387 if (prev)
2593 prev->more = tmp; 2388 prev->more = tmp;
2389
2594 prev = tmp; 2390 prev = tmp;
2595 } 2391 }
2596 2392
2597 for (item = src->inv; item; item = item->below) 2393 for (item = src->inv; item; item = item->below)
2598 insert_ob_in_ob (object_create_clone (item), dst); 2394 insert_ob_in_ob (object_create_clone (item), dst);
2604/* Basically, we save the content of the string to a temp file, then call */ 2400/* Basically, we save the content of the string to a temp file, then call */
2605/* load_object on it. I admit it is a highly inefficient way to make things, */ 2401/* load_object on it. I admit it is a highly inefficient way to make things, */
2606/* but it was simple to make and allows reusing the load_object function. */ 2402/* but it was simple to make and allows reusing the load_object function. */
2607/* Remember not to use load_object_str in a time-critical situation. */ 2403/* Remember not to use load_object_str in a time-critical situation. */
2608/* Also remember that multiparts objects are not supported for now. */ 2404/* Also remember that multiparts objects are not supported for now. */
2609
2610object * 2405object *
2611load_object_str (const char *obstr) 2406load_object_str (const char *obstr)
2612{ 2407{
2613 object *op; 2408 object *op;
2614 char filename[MAX_BUF]; 2409 char filename[MAX_BUF];
2624 } 2419 }
2625 2420
2626 fprintf (tempfile, obstr); 2421 fprintf (tempfile, obstr);
2627 fclose (tempfile); 2422 fclose (tempfile);
2628 2423
2629 op = get_object (); 2424 op = object::create ();
2630 2425
2631 object_thawer thawer (filename); 2426 object_thawer thawer (filename);
2632 2427
2633 if (thawer) 2428 if (thawer)
2634 load_object (thawer, op, 0); 2429 load_object (thawer, op, 0);
2644 * returns NULL if no match. 2439 * returns NULL if no match.
2645 */ 2440 */
2646object * 2441object *
2647find_obj_by_type_subtype (const object *who, int type, int subtype) 2442find_obj_by_type_subtype (const object *who, int type, int subtype)
2648{ 2443{
2649 object *tmp;
2650
2651 for (tmp = who->inv; tmp; tmp = tmp->below) 2444 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2652 if (tmp->type == type && tmp->subtype == subtype) 2445 if (tmp->type == type && tmp->subtype == subtype)
2653 return tmp; 2446 return tmp;
2654 2447
2655 return NULL; 2448 return 0;
2656} 2449}
2657 2450
2658/* If ob has a field named key, return the link from the list, 2451/* If ob has a field named key, return the link from the list,
2659 * otherwise return NULL. 2452 * otherwise return NULL.
2660 * 2453 *
2662 * do the desired thing. 2455 * do the desired thing.
2663 */ 2456 */
2664key_value * 2457key_value *
2665get_ob_key_link (const object *ob, const char *key) 2458get_ob_key_link (const object *ob, const char *key)
2666{ 2459{
2667 key_value *link;
2668
2669 for (link = ob->key_values; link != NULL; link = link->next) 2460 for (key_value *link = ob->key_values; link; link = link->next)
2670 if (link->key == key) 2461 if (link->key == key)
2671 return link; 2462 return link;
2672 2463
2673 return NULL; 2464 return 0;
2674} 2465}
2675 2466
2676/* 2467/*
2677 * Returns the value of op has an extra_field for key, or NULL. 2468 * Returns the value of op has an extra_field for key, or NULL.
2678 * 2469 *
2718 * Returns TRUE on success. 2509 * Returns TRUE on success.
2719 */ 2510 */
2720int 2511int
2721set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2512set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2722{ 2513{
2723 key_value *
2724 field = NULL, *last = NULL; 2514 key_value *field = NULL, *last = NULL;
2725 2515
2726 for (field = op->key_values; field != NULL; field = field->next) 2516 for (field = op->key_values; field != NULL; field = field->next)
2727 { 2517 {
2728 if (field->key != canonical_key) 2518 if (field->key != canonical_key)
2729 { 2519 {
2757 /* IF we get here, key doesn't exist */ 2547 /* IF we get here, key doesn't exist */
2758 2548
2759 /* No field, we'll have to add it. */ 2549 /* No field, we'll have to add it. */
2760 2550
2761 if (!add_key) 2551 if (!add_key)
2762 {
2763 return FALSE; 2552 return FALSE;
2764 } 2553
2765 /* There isn't any good reason to store a null 2554 /* There isn't any good reason to store a null
2766 * value in the key/value list. If the archetype has 2555 * value in the key/value list. If the archetype has
2767 * this key, then we should also have it, so shouldn't 2556 * this key, then we should also have it, so shouldn't
2768 * be here. If user wants to store empty strings, 2557 * be here. If user wants to store empty strings,
2769 * should pass in "" 2558 * should pass in ""
2818 } 2607 }
2819 else 2608 else
2820 item = item->env; 2609 item = item->env;
2821} 2610}
2822 2611
2612
2613const char *
2614object::flag_desc (char *desc, int len) const
2615{
2616 char *p = desc;
2617 bool first = true;
2618
2619 *p = 0;
2620
2621 for (int i = 0; i < NUM_FLAGS; i++)
2622 {
2623 if (len <= 10) // magic constant!
2624 {
2625 snprintf (p, len, ",...");
2626 break;
2627 }
2628
2629 if (flag [i])
2630 {
2631 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2632 len -= cnt;
2633 p += cnt;
2634 first = false;
2635 }
2636 }
2637
2638 return desc;
2639}
2640
2823// return a suitable string describing an objetc in enough detail to find it 2641// return a suitable string describing an object in enough detail to find it
2824const char * 2642const char *
2825object::debug_desc (char *info) const 2643object::debug_desc (char *info) const
2826{ 2644{
2645 char flagdesc[512];
2827 char info2[256 * 3]; 2646 char info2[256 * 4];
2828 char *p = info; 2647 char *p = info;
2829 2648
2830 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2649 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2831 count, 2650 count, uuid.seq,
2832 &name, 2651 &name,
2833 title ? " " : "", 2652 title ? "\",title:" : "",
2834 title ? (const char *)title : ""); 2653 title ? (const char *)title : "",
2654 flag_desc (flagdesc, 512), type);
2835 2655
2836 if (env) 2656 if (env)
2837 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2657 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2838 2658
2839 if (map) 2659 if (map)
2840 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2660 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2841 2661
2842 return info; 2662 return info;
2843} 2663}
2844 2664
2845const char * 2665const char *
2846object::debug_desc () const 2666object::debug_desc () const
2847{ 2667{
2848 static char info[256 * 3]; 2668 static char info[256 * 4];
2849 return debug_desc (info); 2669 return debug_desc (info);
2850} 2670}
2851 2671

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines