[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.48 by root, Thu Sep 14 23:13:48 2006 UTC vs.
Revision 1.59 by root, Wed Dec 6 13:59:00 2006 UTC

  * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
  *      Some error messages.
  * The result of the dump is stored in the static global errmsg array.
  */
-void
+char *
-dump_object2 (object *op)
-{
-  errmsg[0] = 0;
-  return;
-  //TODO//D#d#
-#if 0
-  char *cp;
-/*  object *tmp;*/
-  if (op->arch != NULL)
-    {
-      strcat (errmsg, "arch ");
-      strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
-      strcat (errmsg, "\n");
-      if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
-        strcat (errmsg, cp);
-# if 0
-      /* Don't dump player diffs - they are too long, mostly meaningless, and
-       * will overflow the buffer.
-       * Changed so that we don't dump inventory either.  This may
-       * also overflow the buffer.
-       */
-      if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
-        strcat (errmsg, cp);
-      for (tmp = op->inv; tmp; tmp = tmp->below)
-        dump_object2 (tmp);
-# endif
-      strcat (errmsg, "end\n");
-    }
-  else
-    {
-      strcat (errmsg, "Object ");
-      if (op->name == NULL)
-        strcat (errmsg, "(null)");
-      else
-        strcat (errmsg, op->name);
-      strcat (errmsg, "\n");
-# if 0
-      if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
-        strcat (errmsg, cp);
-      for (tmp = op->inv; tmp; tmp = tmp->below)
-        dump_object2 (tmp);
-# endif
-      strcat (errmsg, "end\n");
-    }
-#endif
-}
-/*
- * Dumps an object.  Returns output in the static global errmsg array.
- */
-void
 dump_object (object *op)
 {
-  if (op == NULL)
+  if (!op)
-    {
+    return strdup ("[NULLOBJ]");
-      strcpy (errmsg, "[NULL pointer]");
-      return;
-    }
-  errmsg[0] = '\0';
-  dump_object2 (op);
-}
-void
+  object_freezer freezer;
-dump_all_objects (void)
+  save_object (freezer, op, 3);
-{
+  return freezer.as_string ();
-  object *op;
-  for (op = object::first; op != NULL; op = op->next)
-    {
-      dump_object (op);
-      fprintf (logfile, "Object %s\n", errmsg);
-    }
 }
 /*
  * get_nearest_part(multi-object, object 2) returns the part of the
  * multi-object 1 which is closest to the second object.
  */
 object *
 find_object (tag_t i)
 {
-  object *op;
-  for (op = object::first; op != NULL; op = op->next)
+  for (object *op = object::first; op; op = op->next)
     if (op->count == i)
-      break;
+      return op;
-  return op;
+  return 0;
 }
 /*
  * Returns the first object which has a name equal to the argument.
  * Used only by the patch command, but not all that useful.
   op2->clone (op);
   if (is_freed)
     SET_FLAG (op, FLAG_FREED);
   if (is_removed)
     SET_FLAG (op, FLAG_REMOVED);
   if (op2->speed < 0)
     op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
         update_now = 1;
       if ((move_slow | op->move_slow) != move_slow)
         update_now = 1;
     }
   /* if the object is being removed, we can't make intelligent
    * decisions, because remove_ob can't really pass the object
    * that is being removed.
    */
   else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
     else
       {
         delete *i;
         mortals.erase (i);
       }
-  static int lastmortals = 0;//D
-  if (mortals.size() != lastmortals)//D
-    {
-      lastmortals = mortals.size ();//D
-      LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
-    }
 }
 object::object ()
 {
   SET_FLAG (this, FLAG_REMOVED);
  * it from the list of used objects, and puts it on the list of
  * free objects.  The IS_FREED() flag is set in the object.
  * The object must have been removed by remove_ob() first for
  * this function to succeed.
  *
- * If free_inventory is set, free inventory as well. Else drop items in
+ * If destroy_inventory is set, free inventory as well. Else drop items in
  * inventory to the ground.
  */
-void object::free (bool free_inventory)
+void object::destroy (bool destroy_inventory)
 {
   if (QUERY_FLAG (this, FLAG_FREED))
     return;
   if (QUERY_FLAG (this, FLAG_FRIENDLY))
   SET_FLAG (this, FLAG_FREED);
   if (more)
     {
-      more->free (free_inventory);
+      more->destroy (destroy_inventory);
       more = 0;
     }
   if (inv)
     {
       /* Only if the space blocks everything do we not process -
        * if some form of movement is allowed, let objects
        * drop on that space.
        */
-      if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
+      if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
         {
           object *op = inv;
           while (op)
             {
               object *tmp = op->below;
-              op->free (free_inventory);
+              op->destroy (destroy_inventory);
               op = tmp;
             }
         }
       else
         {                       /* Put objects in inventory onto this space */
               op = tmp;
             }
         }
     }
+  // hack to ensure that freed objects still have a valid map
+  {
+    static maptile *freed_map; // freed objects are moved here to avoid crashes
+    if (!freed_map)
+      {
+        freed_map = new maptile;
+        freed_map->name   = "/internal/freed_objects_map";
+        freed_map->width  = 3;
+        freed_map->height = 3;
+        freed_map->allocate ();
+      }
+    map = freed_map;
+    x = 1;
+    y = 1;
+  }
   // clear those pointers that likely might have circular references to us
   owner       = 0;
   enemy       = 0;
   attacked_by = 0;
+  // only relevant for players(?), but make sure of it anyways
+  contr       = 0;
   /* Remove object from the active list */
   speed = 0;
   update_ob_speed (this);
   unlink ();
 /*
  * sub_weight() recursively (outwards) subtracts a number from the
  * weight of an object (and what is carried by it's environment(s)).
  */
 void
 sub_weight (object *op, signed long weight)
 {
   while (op != NULL)
     {
  *   object will have no environment.  If the object previously had an
  *   environment, the x and y coordinates will be updated to
  *   the previous environment.
  *   Beware: This function is called from the editor as well!
  */
 void
-remove_ob (object *op)
+object::remove ()
 {
   object *tmp, *last = 0;
   object *otmp;
   int check_walk_off;
-  mapstruct *m;
-  sint16 x, y;
-  if (QUERY_FLAG (op, FLAG_REMOVED))
+  if (QUERY_FLAG (this, FLAG_REMOVED))
     return;
-  SET_FLAG (op, FLAG_REMOVED);
+  SET_FLAG (this, FLAG_REMOVED);
-  if (op->more != NULL)
+  if (more)
-    remove_ob (op->more);
+    more->remove ();
   /*
    * In this case, the object to be removed is in someones
    * inventory.
    */
-  if (op->env != NULL)
+  if (env)
     {
-      if (op->nrof)
+      if (nrof)
-        sub_weight (op->env, op->weight * op->nrof);
+        sub_weight (env, weight * nrof);
       else
-        sub_weight (op->env, op->weight + op->carrying);
+        sub_weight (env, weight + carrying);
       /* NO_FIX_PLAYER is set when a great many changes are being
        * made to players inventory.  If set, avoiding the call
        * to save cpu time.
        */
-      if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
+      if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
         fix_player (otmp);
-      if (op->above != NULL)
+      if (above != NULL)
-        op->above->below = op->below;
+        above->below = below;
       else
-        op->env->inv = op->below;
+        env->inv = below;
-      if (op->below != NULL)
+      if (below != NULL)
-        op->below->above = op->above;
+        below->above = above;
       /* we set up values so that it could be inserted into
        * the map, but we don't actually do that - it is up
        * to the caller to decide what we want to do.
        */
-      op->x = op->env->x, op->y = op->env->y;
+      x = env->x, y = env->y;
-      op->map = op->env->map;
+      map = env->map;
-      op->above = NULL, op->below = NULL;
+      above = 0, below = 0;
-      op->env = NULL;
+      env = 0;
     }
-  else if (op->map)
+  else if (map)
     {
-      x = op->x;
-      y = op->y;
-      m = get_map_from_coord (op->map, &x, &y);
-      if (!m)
-        {
-          LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
-               op->map->path, op->x, op->y);
-          /* in old days, we used to set x and y to 0 and continue.
-           * it seems if we get into this case, something is probablye
-           * screwed up and should be fixed.
-           */
-          abort ();
-        }
-      if (op->map != m)
-        LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
-             op->map->path, m->path, op->x, op->y, x, y);
       /* Re did the following section of code - it looks like it had
        * lots of logic for things we no longer care about
        */
       /* link the object above us */
-      if (op->above)
+      if (above)
-        op->above->below = op->below;
+        above->below = below;
       else
-        SET_MAP_TOP (m, x, y, op->below);       /* we were top, set new top */
+        SET_MAP_TOP (map, x, y, below);       /* we were top, set new top */
       /* Relink the object below us, if there is one */
-      if (op->below)
+      if (below)
-        op->below->above = op->above;
+        below->above = above;
       else
         {
           /* Nothing below, which means we need to relink map object for this space
            * use translated coordinates in case some oddness with map tiling is
            * evident
            */
-          if (GET_MAP_OB (m, x, y) != op)
+          if (GET_MAP_OB (map, x, y) != this)
             {
-              dump_object (op);
+              char *dump = dump_object (this);
               LOG (llevError,
-                   "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg);
+                   "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
+              free (dump);
-              dump_object (GET_MAP_OB (m, x, y));
+              dump = dump_object (GET_MAP_OB (map, x, y));
-              LOG (llevError, "%s\n", errmsg);
+              LOG (llevError, "%s\n", dump);
+              free (dump);
             }
-          SET_MAP_OB (m, x, y, op->above);      /* goes on above it. */
+          SET_MAP_OB (map, x, y, above);      /* goes on above it. */
         }
-      op->above = 0;
+      above = 0;
-      op->below = 0;
+      below = 0;
-      if (op->map->in_memory == MAP_SAVING)
+      if (map->in_memory == MAP_SAVING)
         return;
-      check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
+      check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);
-      for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
+      for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
         {
           /* No point updating the players look faces if he is the object
            * being removed.
            */
-          if (tmp->type == PLAYER && tmp != op)
+          if (tmp->type == PLAYER && tmp != this)
             {
               /* If a container that the player is currently using somehow gets
                * removed (most likely destroyed), update the player view
                * appropriately.
                */
-              if (tmp->container == op)
+              if (tmp->container == this)
                 {
-                  CLEAR_FLAG (op, FLAG_APPLIED);
+                  CLEAR_FLAG (this, FLAG_APPLIED);
-                  tmp->container = NULL;
+                  tmp->container = 0;
                 }
               tmp->contr->socket.update_look = 1;
             }
           /* See if player moving off should effect something */
-          if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
+          if (check_walk_off
+              && ((move_type & tmp->move_off)
+                  && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
             {
-              move_apply (tmp, op, NULL);
+              move_apply (tmp, this, 0);
-              if (op->destroyed ());
+              if (destroyed ())
-                LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);
+                LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
             }
           /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
           if (tmp->above == tmp)
-            tmp->above = NULL;
+            tmp->above = 0;
           last = tmp;
         }
       /* last == NULL of there are no objects on this space */
-      if (last == NULL)
+      if (!last)
         {
           /* set P_NEED_UPDATE, otherwise update_position will complain.  In theory,
            * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
            * those out anyways, and if there are any flags set right now, they won't
            * be correct anyways.
            */
-          SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
+          SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
-          update_position (op->map, op->x, op->y);
+          update_position (map, x, y);
         }
       else
         update_object (last, UP_OBJ_REMOVE);
-      if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0))
+      if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)
-        update_all_los (op->map, op->x, op->y);
+        update_all_los (map, x, y);
     }
 }
 /*
  * merge_ob(op,top):
 /*
  * same as insert_ob_in_map except it handle separate coordinates and do a clean
  * job preparing multi-part monsters
  */
 object *
-insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y)
+insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
 {
   object *tmp;
   if (op->head)
     op = op->head;
  *   NULL if 'op' was destroyed
  *   just 'op' otherwise
  */
 object *
-insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag)
+insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
 {
   object *tmp, *top, *floor = NULL;
   sint16 x, y;
   if (QUERY_FLAG (op, FLAG_FREED))
       return NULL;
     }
   if (m == NULL)
     {
-      dump_object (op);
+      char *dump = dump_object (op);
-      LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg);
+      LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
+      free (dump);
       return op;
     }
   if (out_of_map (m, op->x, op->y))
     {
-      dump_object (op);
+      char *dump = dump_object (op);
-      LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg);
+      LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
 #ifdef MANY_CORES
       /* Better to catch this here, as otherwise the next use of this object
        * is likely to cause a crash.  Better to find out where it is getting
        * improperly inserted.
        */
       abort ();
 #endif
+      free (dump);
       return op;
     }
   if (!QUERY_FLAG (op, FLAG_REMOVED))
     {
-      dump_object (op);
+      char *dump = dump_object (op);
-      LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
+      LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
+      free (dump);
       return op;
     }
   if (op->more != NULL)
     {
       op->carrying += weight;
       op = op->env;
     }
 }
+object *
+insert_ob_in_ob (object *op, object *where)
+{
+  if (!where)
+    {
+      char *dump = dump_object (op);
+      LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
+      free (dump);
+      return op;
+    }
+  if (where->head)
+    {
+      LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
+      where = where->head;
+    }
+  return where->insert (op);
+}
 /*
- * insert_ob_in_ob(op,environment):
+ * env->insert (op)
  *   This function inserts the object op in the linked list
  *   inside the object environment.
  *
- * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
- * the inventory at the last position or next to other objects of the same
- * type.
- * Frank: Now sorted by type, archetype and magic!
- *
  * The function returns now pointer to inserted item, and return value can
  * be != op, if items are merged. -Tero
  */
 object *
-insert_ob_in_ob (object *op, object *where)
+object::insert (object *op)
 {
-  object *
+  object *tmp, *otmp;
-  tmp, *
-    otmp;
   if (!QUERY_FLAG (op, FLAG_REMOVED))
-    {
+    op->remove ();
-      dump_object (op);
-      LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
-      return op;
-    }
-  if (where == NULL)
-    {
-      dump_object (op);
-      LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
-      return op;
-    }
-  if (where->head)
-    {
-      LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
-      where = where->head;
-    }
   if (op->more)
     {
       LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
       return op;
   CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
   CLEAR_FLAG (op, FLAG_REMOVED);
   if (op->nrof)
     {
-      for (tmp = where->inv; tmp != NULL; tmp = tmp->below)
+      for (tmp = inv; tmp != NULL; tmp = tmp->below)
         if (CAN_MERGE (tmp, op))
           {
             /* return the original object and remove inserted object
                (client needs the original object) */
             tmp->nrof += op->nrof;
             /* Weight handling gets pretty funky.  Since we are adding to
              * tmp->nrof, we need to increase the weight.
              */
-            add_weight (where, op->weight * op->nrof);
+            add_weight (this, op->weight * op->nrof);
             SET_FLAG (op, FLAG_REMOVED);
-            free_object (op);   /* free the inserted object */
+            op->destroy ();   /* free the inserted object */
             op = tmp;
-            remove_ob (op);     /* and fix old object's links */
+            op->remove ();     /* and fix old object's links */
             CLEAR_FLAG (op, FLAG_REMOVED);
             break;
           }
       /* I assume combined objects have no inventory
        * We add the weight - this object could have just been removed
        * (if it was possible to merge).  calling remove_ob will subtract
        * the weight, so we need to add it in again, since we actually do
        * the linking below
        */
-      add_weight (where, op->weight * op->nrof);
+      add_weight (this, op->weight * op->nrof);
     }
   else
-    add_weight (where, (op->weight + op->carrying));
+    add_weight (this, (op->weight + op->carrying));
-  otmp = is_player_inv (where);
+  otmp = is_player_inv (this);
-  if (otmp && otmp->contr != NULL)
+  if (otmp && otmp->contr)
-    {
-      if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
+    if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
-        fix_player (otmp);
+      fix_player (otmp);
-    }
   op->map = NULL;
-  op->env = where;
+  op->env = this;
   op->above = NULL;
   op->below = NULL;
   op->x = 0, op->y = 0;
   /* reset the light list and los of the players on the map */
-  if ((op->glow_radius != 0) && where->map)
+  if ((op->glow_radius != 0) && map)
     {
 #ifdef DEBUG_LIGHTS
       LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
 #endif /* DEBUG_LIGHTS */
-      if (MAP_DARKNESS (where->map))
+      if (MAP_DARKNESS (map))
-        update_all_los (where->map, where->x, where->y);
+        update_all_los (map, x, y);
     }
   /* Client has no idea of ordering so lets not bother ordering it here.
    * It sure simplifies this function...
    */
-  if (where->inv == NULL)
+  if (!inv)
-    where->inv = op;
+    inv = op;
   else
     {
-      op->below = where->inv;
+      op->below = inv;
       op->below->above = op;
-      where->inv = op;
+      inv = op;
     }
   return op;
 }
 /*
  * Checks if any objects has a move_type that matches objects
 int
 check_move_on (object *op, object *originator)
 {
   object *tmp;
-  mapstruct *m = op->map;
+  maptile *m = op->map;
   int x = op->x, y = op->y;
   MoveType move_on, move_slow, move_block;
   if (QUERY_FLAG (op, FLAG_NO_APPLY))
  * a matching archetype at the given map and coordinates.
  * The first matching object is returned, or NULL if none.
  */
 object *
-present_arch (const archetype *at, mapstruct *m, int x, int y)
+present_arch (const archetype *at, maptile *m, int x, int y)
 {
   object *
     tmp;
   if (m == NULL || out_of_map (m, x, y))
  * a matching type variable at the given map and coordinates.
  * The first matching object is returned, or NULL if none.
  */
 object *
-present (unsigned char type, mapstruct *m, int x, int y)
+present (unsigned char type, maptile *m, int x, int y)
 {
   object *
     tmp;
   if (out_of_map (m, x, y))
  * the archetype because that isn't correct if the monster has been
  * customized, changed states, etc.
  */
 int
-find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop)
+find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
 {
   int
     i,
     index = 0, flag;
   static int
     return -1;
   return altern[RANDOM () % index];
 }
 /*
- * find_first_free_spot(archetype, mapstruct, x, y) works like
+ * find_first_free_spot(archetype, maptile, x, y) works like
  * find_free_spot(), but it will search max number of squares.
  * But it will return the first available spot, not a random choice.
  * Changed 0.93.2: Have it return -1 if there is no free spot available.
  */
 int
-find_first_free_spot (const object *ob, mapstruct *m, int x, int y)
+find_first_free_spot (const object *ob, maptile *m, int x, int y)
 {
   int
     i;
   for (i = 0; i < SIZEOFFREE; i++)
  * because we have to know what movement the thing looking to move
  * there is capable of.
  */
 int
-find_dir (mapstruct *m, int x, int y, object *exclude)
+find_dir (maptile *m, int x, int y, object *exclude)
 {
   int
     i,
     max = SIZEOFFREE, mflags;
   sint16 nx, ny;
   object *
     tmp;
-  mapstruct *
+  maptile *
     mp;
   MoveType blocked, move_type;
   if (exclude && exclude->head)
  * Modified to be map tile aware -.MSW
  */
 int
-can_see_monsterP (mapstruct *m, int x, int y, int dir)
+can_see_monsterP (maptile *m, int x, int y, int dir)
 {
   sint16 dx, dy;
   int
     mflags;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.48 by root, Thu Sep 14 23:13:48 2006 UTC vs. Revision 1.59 by root, Wed Dec 6 13:59:00 2006 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.48 by root, Thu Sep 14 23:13:48 2006 UTC vs.
Revision 1.59 by root, Wed Dec 6 13:59:00 2006 UTC