ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.63 by root, Tue Dec 12 20:53:02 2006 UTC vs.
Revision 1.101 by root, Mon Jan 1 17:30:33 2007 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193
194bool object::can_merge (object *ob1, object *ob2) 195bool object::can_merge_slow (object *ob1, object *ob2)
195{ 196{
196 /* A couple quicksanity checks */ 197 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 198 if (ob1 == ob2
199 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value
202 || ob1->name != ob2->name)
198 return 0; 203 return 0;
199 204
200 if (ob1->speed != ob2->speed) 205 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 206 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 207 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 208 * used to store nrof).
206 */ 209 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 210 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 220 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 221
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 224
222 225 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 226 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 227 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 228 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 229 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 230 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 233 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 234 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 235 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 236 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 237 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 238 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 239 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 240 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 241 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 242 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 243 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 244 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 245 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 246 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 247 || ob1->move_off != ob2->move_off
248 || ob1->move_slow != ob2->move_slow
249 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 250 return 0;
254 251
255 /* This is really a spellbook check - really, we should 252 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 253 * check all objects in the inventory.
257 */ 254 */
260 /* if one object has inventory but the other doesn't, not equiv */ 257 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 258 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 259 return 0;
263 260
264 /* Now check to see if the two inventory objects could merge */ 261 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 262 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 263 return 0;
267 264
268 /* inventory ok - still need to check rest of this object to see 265 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 266 * if it is valid.
270 */ 267 */
279 276
280 /* Note sure why the following is the case - either the object has to 277 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 278 * be animated or have a very low speed. Is this an attempted monster
282 * check? 279 * check?
283 */ 280 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 281 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 282 return 0;
286 283
287 switch (ob1->type) 284 switch (ob1->type)
288 { 285 {
289 case SCROLL: 286 case SCROLL:
354 op = op->env; 351 op = op->env;
355 return op; 352 return op;
356} 353}
357 354
358/* 355/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 356 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 357 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 358 * The result of the dump is stored in the static global errmsg array.
377 */ 359 */
378 360
381{ 363{
382 if (!op) 364 if (!op)
383 return strdup ("[NULLOBJ]"); 365 return strdup ("[NULLOBJ]");
384 366
385 object_freezer freezer; 367 object_freezer freezer;
386 save_object (freezer, op, 3); 368 save_object (freezer, op, 1);
387 return freezer.as_string (); 369 return freezer.as_string ();
388} 370}
389 371
390/* 372/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 373 * get_nearest_part(multi-object, object 2) returns the part of the
484 } 466 }
485 467
486 op->key_values = 0; 468 op->key_values = 0;
487} 469}
488 470
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 471/*
541 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 477 * will point at garbage.
547 */ 478 */
548void 479void
549copy_object (object *op2, object *op) 480object::copy_to (object *dst)
550{ 481{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 484
554 op2->clone (op); 485 *(object_copy *)dst = *this;
555 486
556 if (is_freed) 487 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
558 489
559 if (is_removed) 490 if (is_removed)
560 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
561 492
562 if (op2->speed < 0) 493 if (speed < 0)
563 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
564 495
565 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
566 if (op2->key_values) 497 if (key_values)
567 { 498 {
568 key_value *tail = 0; 499 key_value *tail = 0;
569 key_value *i; 500 key_value *i;
570 501
571 op->key_values = 0; 502 dst->key_values = 0;
572 503
573 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
574 { 505 {
575 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
576 507
577 new_link->next = 0; 508 new_link->next = 0;
578 new_link->key = i->key; 509 new_link->key = i->key;
579 new_link->value = i->value; 510 new_link->value = i->value;
580 511
581 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
582 if (!op->key_values) 513 if (!dst->key_values)
583 { 514 {
584 op->key_values = new_link; 515 dst->key_values = new_link;
585 tail = new_link; 516 tail = new_link;
586 } 517 }
587 else 518 else
588 { 519 {
589 tail->next = new_link; 520 tail->next = new_link;
590 tail = new_link; 521 tail = new_link;
591 } 522 }
592 } 523 }
593 } 524 }
594 525
595 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
596} 535}
597 536
598/* 537/*
599 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
600 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
601 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
602 */ 541 */
603
604void 542void
605update_turn_face (object *op) 543update_turn_face (object *op)
606{ 544{
607 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
608 return; 546 return;
547
609 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
610 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
611} 550}
612 551
613/* 552/*
614 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
615 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
616 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
617 */ 556 */
618void 557void
619update_ob_speed (object *op) 558object::set_speed (float speed)
620{ 559{
621 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
622
623 /* No reason putting the archetypes objects on the speed list,
624 * since they never really need to be updated.
625 */
626
627 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
628 { 561 {
629 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
630#ifdef MANY_CORES
631 abort ();
632#else
633 op->speed = 0; 563 speed = 0;
634#endif
635 }
636
637 if (arch_init)
638 return;
639
640 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
641 { 564 }
642 /* If already on active list, don't do anything */
643 if (op->active_next || op->active_prev || op == active_objects)
644 return;
645 565
646 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
647 * of the list. */
648 op->active_next = active_objects;
649 567
650 if (op->active_next != NULL) 568 if (has_active_speed ())
651 op->active_next->active_prev = op; 569 activate ();
652
653 active_objects = op;
654 }
655 else 570 else
656 { 571 deactivate ();
657 /* If not on the active list, nothing needs to be done */
658 if (!op->active_next && !op->active_prev && op != active_objects)
659 return;
660
661 if (op->active_prev == NULL)
662 {
663 active_objects = op->active_next;
664
665 if (op->active_next != NULL)
666 op->active_next->active_prev = NULL;
667 }
668 else
669 {
670 op->active_prev->active_next = op->active_next;
671
672 if (op->active_next)
673 op->active_next->active_prev = op->active_prev;
674 }
675
676 op->active_next = NULL;
677 op->active_prev = NULL;
678 }
679} 572}
680 573
681/* This function removes object 'op' from the list of active
682 * objects.
683 * This should only be used for style maps or other such
684 * reference maps where you don't want an object that isn't
685 * in play chewing up cpu time getting processed.
686 * The reverse of this is to call update_ob_speed, which
687 * will do the right thing based on the speed of the object.
688 */
689void
690remove_from_active_list (object *op)
691{
692 /* If not on the active list, nothing needs to be done */
693 if (!op->active_next && !op->active_prev && op != active_objects)
694 return;
695
696 if (op->active_prev == NULL)
697 {
698 active_objects = op->active_next;
699 if (op->active_next != NULL)
700 op->active_next->active_prev = NULL;
701 }
702 else
703 {
704 op->active_prev->active_next = op->active_next;
705 if (op->active_next)
706 op->active_next->active_prev = op->active_prev;
707 }
708 op->active_next = NULL;
709 op->active_prev = NULL;
710}
711
712/* 574/*
713 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
714 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
715 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
716 * invisible object, etc...) 578 * invisible object, etc...)
717 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
718 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
719 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
720 * 582 *
721 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
722 * For example, if the only thing that has changed is the face (due to
723 * an animation), we don't need to call update_position until that actually
724 * comes into view of a player. OTOH, many other things, like addition/removal
725 * of walls or living creatures may need us to update the flags now.
726 * current action are: 584 * current action are:
727 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
728 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
729 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
730 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
731 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
732 */ 590 */
733
734void 591void
735update_object (object *op, int action) 592update_object (object *op, int action)
736{ 593{
737 int update_now = 0, flags;
738 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
739 595
740 if (op == NULL) 596 if (op == NULL)
741 { 597 {
742 /* this should never happen */ 598 /* this should never happen */
743 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
744 return; 600 return;
745 } 601 }
746 602
747 if (op->env != NULL) 603 if (op->env)
748 { 604 {
749 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
750 * to do in this case. 606 * to do in this case.
751 */ 607 */
752 return; 608 return;
757 */ 613 */
758 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
759 return; 615 return;
760 616
761 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
762 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
763 { 619 {
764 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
765#ifdef MANY_CORES 621#ifdef MANY_CORES
766 abort (); 622 abort ();
767#endif 623#endif
768 return; 624 return;
769 } 625 }
770 626
771 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
772 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
773 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
774 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
775 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
776 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
777 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
778 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
779 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
780 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
781 update_now = 1;
782
783 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
784 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
785 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
786 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
787 update_now = 1;
788
789 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
790 update_now = 1;
791
792 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
793 update_now = 1;
794
795 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
796 update_now = 1;
797
798 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
799 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
800
801 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
802 * to have move_allow right now. 644 * to have move_allow right now.
803 */ 645 */
804 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
805 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
806 648 m.flags_ = 0;
807 if ((move_slow | op->move_slow) != move_slow)
808 update_now = 1;
809 } 649 }
810
811 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
812 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
813 * that is being removed. 652 * that is being removed.
814 */ 653 */
815 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
816 update_now = 1; 655 m.flags_ = 0;
817 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
818 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
819 else 658 else
820 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
821 660
822 if (update_now)
823 {
824 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
825 update_position (op->map, op->x, op->y);
826 }
827
828 if (op->more != NULL) 661 if (op->more)
829 update_object (op->more, action); 662 update_object (op->more, action);
830} 663}
831 664
832object::vector object::mortals;
833object::vector object::objects; // not yet used
834object *object::first; 665object *object::first;
835
836void object::free_mortals ()
837{
838 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
839 if ((*i)->refcnt)
840 ++i; // further delay freeing
841 else
842 {
843 delete *i;
844 mortals.erase (i);
845 }
846}
847 666
848object::object () 667object::object ()
849{ 668{
850 SET_FLAG (this, FLAG_REMOVED); 669 SET_FLAG (this, FLAG_REMOVED);
851 670
883 702
884 prev = 0; 703 prev = 0;
885 next = 0; 704 next = 0;
886} 705}
887 706
707bool
708object::active () const
709{
710 return active_next || active_prev || this == active_objects;
711}
712
713void
714object::activate ()
715{
716 /* If already on active list, don't do anything */
717 if (active ())
718 return;
719
720 if (has_active_speed ())
721 {
722 /* process_events() expects us to insert the object at the beginning
723 * of the list. */
724 active_next = active_objects;
725
726 if (active_next)
727 active_next->active_prev = this;
728
729 active_objects = this;
730 }
731}
732
733void
734object::activate_recursive ()
735{
736 activate ();
737
738 for (object *op = inv; op; op = op->above)
739 op->activate_recursive ();
740}
741
742/* This function removes object 'op' from the list of active
743 * objects.
744 * This should only be used for style maps or other such
745 * reference maps where you don't want an object that isn't
746 * in play chewing up cpu time getting processed.
747 * The reverse of this is to call update_ob_speed, which
748 * will do the right thing based on the speed of the object.
749 */
750void
751object::deactivate ()
752{
753 /* If not on the active list, nothing needs to be done */
754 if (!active ())
755 return;
756
757 if (active_prev == 0)
758 {
759 active_objects = active_next;
760 if (active_next)
761 active_next->active_prev = 0;
762 }
763 else
764 {
765 active_prev->active_next = active_next;
766 if (active_next)
767 active_next->active_prev = active_prev;
768 }
769
770 active_next = 0;
771 active_prev = 0;
772}
773
774void
775object::deactivate_recursive ()
776{
777 for (object *op = inv; op; op = op->above)
778 op->deactivate_recursive ();
779
780 deactivate ();
781}
782
783/*
784 * Remove and free all objects in the inventory of the given object.
785 * object.c ?
786 */
787void
788object::destroy_inv (bool drop_to_ground)
789{
790 // need to check first, because the checks below might segfault
791 // as we might be on an invalid mapspace and crossfire code
792 // is too buggy to ensure that the inventory is empty.
793 // corollary: if you create arrows etc. with stuff in tis inventory,
794 // cf will crash below with off-map x and y
795 if (!inv)
796 return;
797
798 /* Only if the space blocks everything do we not process -
799 * if some form of movement is allowed, let objects
800 * drop on that space.
801 */
802 if (!drop_to_ground
803 || !map
804 || map->in_memory != MAP_IN_MEMORY
805 || ms ().move_block == MOVE_ALL)
806 {
807 while (inv)
808 {
809 inv->destroy_inv (drop_to_ground);
810 inv->destroy ();
811 }
812 }
813 else
814 { /* Put objects in inventory onto this space */
815 while (inv)
816 {
817 object *op = inv;
818
819 if (op->flag [FLAG_STARTEQUIP]
820 || op->flag [FLAG_NO_DROP]
821 || op->type == RUNE
822 || op->type == TRAP
823 || op->flag [FLAG_IS_A_TEMPLATE])
824 op->destroy ();
825 else
826 map->insert (op, x, y);
827 }
828 }
829}
830
888object *object::create () 831object *object::create ()
889{ 832{
890 object *op = new object; 833 object *op = new object;
891 op->link (); 834 op->link ();
892 return op; 835 return op;
893} 836}
894 837
895/* 838void
896 * free_object() frees everything allocated by an object, removes 839object::do_destroy ()
897 * it from the list of used objects, and puts it on the list of
898 * free objects. The IS_FREED() flag is set in the object.
899 * The object must have been removed by remove_ob() first for
900 * this function to succeed.
901 *
902 * If destroy_inventory is set, free inventory as well. Else drop items in
903 * inventory to the ground.
904 */
905void object::destroy (bool destroy_inventory)
906{ 840{
907 if (QUERY_FLAG (this, FLAG_FREED)) 841 if (flag [FLAG_IS_LINKED])
842 remove_button_link (this);
843
844 if (flag [FLAG_FRIENDLY])
845 remove_friendly_object (this);
846
847 if (!flag [FLAG_REMOVED])
848 remove ();
849
850 if (flag [FLAG_FREED])
908 return; 851 return;
909 852
910 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 853 set_speed (0);
911 remove_friendly_object (this);
912 854
913 if (!QUERY_FLAG (this, FLAG_REMOVED)) 855 flag [FLAG_FREED] = 1;
914 remove ();
915 856
916 SET_FLAG (this, FLAG_FREED); 857 attachable::do_destroy ();
917 858
918 if (more) 859 destroy_inv (true);
919 { 860 unlink ();
920 more->destroy (destroy_inventory);
921 more = 0;
922 }
923
924 if (inv)
925 {
926 /* Only if the space blocks everything do we not process -
927 * if some form of movement is allowed, let objects
928 * drop on that space.
929 */
930 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
931 {
932 object *op = inv;
933
934 while (op)
935 {
936 object *tmp = op->below;
937 op->destroy (destroy_inventory);
938 op = tmp;
939 }
940 }
941 else
942 { /* Put objects in inventory onto this space */
943 object *op = inv;
944
945 while (op)
946 {
947 object *tmp = op->below;
948
949 op->remove ();
950
951 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
952 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
953 op->destroy (0);
954 else
955 {
956 op->x = x;
957 op->y = y;
958 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
959 }
960
961 op = tmp;
962 }
963 }
964 }
965 861
966 // hack to ensure that freed objects still have a valid map 862 // hack to ensure that freed objects still have a valid map
967 { 863 {
968 static maptile *freed_map; // freed objects are moved here to avoid crashes 864 static maptile *freed_map; // freed objects are moved here to avoid crashes
969 865
973 869
974 freed_map->name = "/internal/freed_objects_map"; 870 freed_map->name = "/internal/freed_objects_map";
975 freed_map->width = 3; 871 freed_map->width = 3;
976 freed_map->height = 3; 872 freed_map->height = 3;
977 873
978 freed_map->allocate (); 874 freed_map->alloc ();
979 } 875 }
980 876
981 map = freed_map; 877 map = freed_map;
982 x = 1; 878 x = 1;
983 y = 1; 879 y = 1;
984 } 880 }
985 881
882 head = 0;
883
884 if (more)
885 {
886 more->destroy ();
887 more = 0;
888 }
889
986 // clear those pointers that likely might have circular references to us 890 // clear those pointers that likely might have circular references to us
987 owner = 0; 891 owner = 0;
988 enemy = 0; 892 enemy = 0;
989 attacked_by = 0; 893 attacked_by = 0;
990 894
991 // only relevant for players(?), but make sure of it anyways 895 // only relevant for players(?), but make sure of it anyways
992 contr = 0; 896 contr = 0;
897}
993 898
994 /* Remove object from the active list */ 899void
995 speed = 0; 900object::destroy (bool destroy_inventory)
996 update_ob_speed (this); 901{
902 if (destroyed ())
903 return;
997 904
998 unlink (); 905 if (destroy_inventory)
906 destroy_inv (false);
999 907
1000 mortals.push_back (this); 908 attachable::destroy ();
1001} 909}
1002 910
1003/* 911/*
1004 * sub_weight() recursively (outwards) subtracts a number from the 912 * sub_weight() recursively (outwards) subtracts a number from the
1005 * weight of an object (and what is carried by it's environment(s)). 913 * weight of an object (and what is carried by it's environment(s)).
1029object::remove () 937object::remove ()
1030{ 938{
1031 object *tmp, *last = 0; 939 object *tmp, *last = 0;
1032 object *otmp; 940 object *otmp;
1033 941
1034 int check_walk_off;
1035
1036 if (QUERY_FLAG (this, FLAG_REMOVED)) 942 if (QUERY_FLAG (this, FLAG_REMOVED))
1037 return; 943 return;
1038 944
1039 SET_FLAG (this, FLAG_REMOVED); 945 SET_FLAG (this, FLAG_REMOVED);
946 INVOKE_OBJECT (REMOVE, this);
1040 947
1041 if (more) 948 if (more)
1042 more->remove (); 949 more->remove ();
1043 950
1044 /* 951 /*
1054 961
1055 /* NO_FIX_PLAYER is set when a great many changes are being 962 /* NO_FIX_PLAYER is set when a great many changes are being
1056 * made to players inventory. If set, avoiding the call 963 * made to players inventory. If set, avoiding the call
1057 * to save cpu time. 964 * to save cpu time.
1058 */ 965 */
1059 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 966 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1060 fix_player (otmp); 967 otmp->update_stats ();
1061 968
1062 if (above != NULL) 969 if (above)
1063 above->below = below; 970 above->below = below;
1064 else 971 else
1065 env->inv = below; 972 env->inv = below;
1066 973
1067 if (below != NULL) 974 if (below)
1068 below->above = above; 975 below->above = above;
1069 976
1070 /* we set up values so that it could be inserted into 977 /* we set up values so that it could be inserted into
1071 * the map, but we don't actually do that - it is up 978 * the map, but we don't actually do that - it is up
1072 * to the caller to decide what we want to do. 979 * to the caller to decide what we want to do.
1076 above = 0, below = 0; 983 above = 0, below = 0;
1077 env = 0; 984 env = 0;
1078 } 985 }
1079 else if (map) 986 else if (map)
1080 { 987 {
1081 /* Re did the following section of code - it looks like it had 988 if (type == PLAYER)
1082 * lots of logic for things we no longer care about
1083 */ 989 {
990 --map->players;
991 map->touch ();
992 }
993
994 map->dirty = true;
1084 995
1085 /* link the object above us */ 996 /* link the object above us */
1086 if (above) 997 if (above)
1087 above->below = below; 998 above->below = below;
1088 else 999 else
1089 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 1000 map->at (x, y).top = below; /* we were top, set new top */
1090 1001
1091 /* Relink the object below us, if there is one */ 1002 /* Relink the object below us, if there is one */
1092 if (below) 1003 if (below)
1093 below->above = above; 1004 below->above = above;
1094 else 1005 else
1106 dump = dump_object (GET_MAP_OB (map, x, y)); 1017 dump = dump_object (GET_MAP_OB (map, x, y));
1107 LOG (llevError, "%s\n", dump); 1018 LOG (llevError, "%s\n", dump);
1108 free (dump); 1019 free (dump);
1109 } 1020 }
1110 1021
1111 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1022 map->at (x, y).bot = above; /* goes on above it. */
1112 } 1023 }
1113 1024
1114 above = 0; 1025 above = 0;
1115 below = 0; 1026 below = 0;
1116 1027
1117 if (map->in_memory == MAP_SAVING) 1028 if (map->in_memory == MAP_SAVING)
1118 return; 1029 return;
1119 1030
1120 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1031 int check_walk_off = !flag [FLAG_NO_APPLY];
1121 1032
1122 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1033 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1123 { 1034 {
1124 /* No point updating the players look faces if he is the object 1035 /* No point updating the players look faces if he is the object
1125 * being removed. 1036 * being removed.
1126 */ 1037 */
1127 1038
1131 * removed (most likely destroyed), update the player view 1042 * removed (most likely destroyed), update the player view
1132 * appropriately. 1043 * appropriately.
1133 */ 1044 */
1134 if (tmp->container == this) 1045 if (tmp->container == this)
1135 { 1046 {
1136 CLEAR_FLAG (this, FLAG_APPLIED); 1047 flag [FLAG_APPLIED] = 0;
1137 tmp->container = 0; 1048 tmp->container = 0;
1138 } 1049 }
1139 1050
1140 tmp->contr->socket.update_look = 1; 1051 if (tmp->contr->ns)
1052 tmp->contr->ns->floorbox_update ();
1141 } 1053 }
1142 1054
1143 /* See if player moving off should effect something */ 1055 /* See if object moving off should effect something */
1144 if (check_walk_off 1056 if (check_walk_off
1145 && ((move_type & tmp->move_off) 1057 && ((move_type & tmp->move_off)
1146 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1058 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1147 { 1059 {
1148 move_apply (tmp, this, 0); 1060 move_apply (tmp, this, 0);
1150 if (destroyed ()) 1062 if (destroyed ())
1151 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1063 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1152 } 1064 }
1153 1065
1154 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1066 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1155 1067 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1156 if (tmp->above == tmp) 1068 if (tmp->above == tmp)
1157 tmp->above = 0; 1069 tmp->above = 0;
1158 1070
1159 last = tmp; 1071 last = tmp;
1160 } 1072 }
1161 1073
1162 /* last == NULL of there are no objects on this space */ 1074 /* last == NULL if there are no objects on this space */
1075 //TODO: this makes little sense, why only update the topmost object?
1163 if (!last) 1076 if (!last)
1164 { 1077 map->at (x, y).flags_ = 0;
1165 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1166 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1167 * those out anyways, and if there are any flags set right now, they won't
1168 * be correct anyways.
1169 */
1170 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1171 update_position (map, x, y);
1172 }
1173 else 1078 else
1174 update_object (last, UP_OBJ_REMOVE); 1079 update_object (last, UP_OBJ_REMOVE);
1175 1080
1176 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1081 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1177 update_all_los (map, x, y); 1082 update_all_los (map, x, y);
1178 } 1083 }
1179} 1084}
1180 1085
1181/* 1086/*
1190merge_ob (object *op, object *top) 1095merge_ob (object *op, object *top)
1191{ 1096{
1192 if (!op->nrof) 1097 if (!op->nrof)
1193 return 0; 1098 return 0;
1194 1099
1195 if (top == NULL) 1100 if (top)
1196 for (top = op; top != NULL && top->above != NULL; top = top->above); 1101 for (top = op; top && top->above; top = top->above)
1102 ;
1197 1103
1198 for (; top != NULL; top = top->below) 1104 for (; top; top = top->below)
1199 { 1105 {
1200 if (top == op) 1106 if (top == op)
1201 continue; 1107 continue;
1202 if (CAN_MERGE (op, top)) 1108
1109 if (object::can_merge (op, top))
1203 { 1110 {
1204 top->nrof += op->nrof; 1111 top->nrof += op->nrof;
1205 1112
1206/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1113/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1207 op->weight = 0; /* Don't want any adjustements now */ 1114 op->weight = 0; /* Don't want any adjustements now */
1208 op->remove ();
1209 op->destroy (0); 1115 op->destroy ();
1210 return top; 1116 return top;
1211 } 1117 }
1212 } 1118 }
1213 1119
1214 return 0; 1120 return 0;
1219 * job preparing multi-part monsters 1125 * job preparing multi-part monsters
1220 */ 1126 */
1221object * 1127object *
1222insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1128insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1223{ 1129{
1224 object *tmp;
1225
1226 if (op->head)
1227 op = op->head;
1228
1229 for (tmp = op; tmp; tmp = tmp->more) 1130 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1230 { 1131 {
1231 tmp->x = x + tmp->arch->clone.x; 1132 tmp->x = x + tmp->arch->clone.x;
1232 tmp->y = y + tmp->arch->clone.y; 1133 tmp->y = y + tmp->arch->clone.y;
1233 } 1134 }
1234 1135
1253 * Return value: 1154 * Return value:
1254 * new object if 'op' was merged with other object 1155 * new object if 'op' was merged with other object
1255 * NULL if 'op' was destroyed 1156 * NULL if 'op' was destroyed
1256 * just 'op' otherwise 1157 * just 'op' otherwise
1257 */ 1158 */
1258
1259object * 1159object *
1260insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1160insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1261{ 1161{
1262 object *tmp, *top, *floor = NULL; 1162 object *tmp, *top, *floor = NULL;
1263 sint16 x, y; 1163 sint16 x, y;
1266 { 1166 {
1267 LOG (llevError, "Trying to insert freed object!\n"); 1167 LOG (llevError, "Trying to insert freed object!\n");
1268 return NULL; 1168 return NULL;
1269 } 1169 }
1270 1170
1271 if (m == NULL) 1171 if (!m)
1272 { 1172 {
1273 char *dump = dump_object (op); 1173 char *dump = dump_object (op);
1274 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1174 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1275 free (dump); 1175 free (dump);
1276 return op; 1176 return op;
1297 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1197 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1298 free (dump); 1198 free (dump);
1299 return op; 1199 return op;
1300 } 1200 }
1301 1201
1302 if (op->more != NULL) 1202 if (op->more)
1303 { 1203 {
1304 /* The part may be on a different map. */ 1204 /* The part may be on a different map. */
1305 1205
1306 object *more = op->more; 1206 object *more = op->more;
1307 1207
1323 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1223 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1324 { 1224 {
1325 if (!op->head) 1225 if (!op->head)
1326 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1226 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1327 1227
1328 return NULL; 1228 return 0;
1329 } 1229 }
1330 } 1230 }
1331 1231
1332 CLEAR_FLAG (op, FLAG_REMOVED); 1232 CLEAR_FLAG (op, FLAG_REMOVED);
1333 1233
1340 y = op->y; 1240 y = op->y;
1341 1241
1342 /* this has to be done after we translate the coordinates. 1242 /* this has to be done after we translate the coordinates.
1343 */ 1243 */
1344 if (op->nrof && !(flag & INS_NO_MERGE)) 1244 if (op->nrof && !(flag & INS_NO_MERGE))
1345 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1245 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1346 if (CAN_MERGE (op, tmp)) 1246 if (object::can_merge (op, tmp))
1347 { 1247 {
1348 op->nrof += tmp->nrof; 1248 op->nrof += tmp->nrof;
1349 tmp->remove ();
1350 tmp->destroy (0); 1249 tmp->destroy ();
1351 } 1250 }
1352 1251
1353 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1252 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1354 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1253 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1355 1254
1368 op->below = originator->below; 1267 op->below = originator->below;
1369 1268
1370 if (op->below) 1269 if (op->below)
1371 op->below->above = op; 1270 op->below->above = op;
1372 else 1271 else
1373 SET_MAP_OB (op->map, op->x, op->y, op); 1272 op->ms ().bot = op;
1374 1273
1375 /* since *below* originator, no need to update top */ 1274 /* since *below* originator, no need to update top */
1376 originator->below = op; 1275 originator->below = op;
1377 } 1276 }
1378 else 1277 else
1379 { 1278 {
1380 /* If there are other objects, then */ 1279 /* If there are other objects, then */
1381 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1280 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1382 { 1281 {
1383 object *last = NULL; 1282 object *last = 0;
1384 1283
1385 /* 1284 /*
1386 * If there are multiple objects on this space, we do some trickier handling. 1285 * If there are multiple objects on this space, we do some trickier handling.
1387 * We've already dealt with merging if appropriate. 1286 * We've already dealt with merging if appropriate.
1388 * Generally, we want to put the new object on top. But if 1287 * Generally, we want to put the new object on top. But if
1392 * once we get to them. This reduces the need to traverse over all of 1291 * once we get to them. This reduces the need to traverse over all of
1393 * them when adding another one - this saves quite a bit of cpu time 1292 * them when adding another one - this saves quite a bit of cpu time
1394 * when lots of spells are cast in one area. Currently, it is presumed 1293 * when lots of spells are cast in one area. Currently, it is presumed
1395 * that flying non pickable objects are spell objects. 1294 * that flying non pickable objects are spell objects.
1396 */ 1295 */
1397
1398 while (top != NULL) 1296 while (top)
1399 { 1297 {
1400 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1298 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1401 floor = top; 1299 floor = top;
1402 1300
1403 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1301 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1424 * If INS_ON_TOP is used, don't do this processing 1322 * If INS_ON_TOP is used, don't do this processing
1425 * Need to find the object that in fact blocks view, otherwise 1323 * Need to find the object that in fact blocks view, otherwise
1426 * stacking is a bit odd. 1324 * stacking is a bit odd.
1427 */ 1325 */
1428 if (!(flag & INS_ON_TOP) && 1326 if (!(flag & INS_ON_TOP) &&
1429 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1327 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1430 { 1328 {
1431 for (last = top; last != floor; last = last->below) 1329 for (last = top; last != floor; last = last->below)
1432 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1330 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1433 break; 1331 break;
1434 /* Check to see if we found the object that blocks view, 1332 /* Check to see if we found the object that blocks view,
1456 op->above = GET_MAP_OB (op->map, op->x, op->y); 1354 op->above = GET_MAP_OB (op->map, op->x, op->y);
1457 1355
1458 if (op->above) 1356 if (op->above)
1459 op->above->below = op; 1357 op->above->below = op;
1460 1358
1461 op->below = NULL; 1359 op->below = 0;
1462 SET_MAP_OB (op->map, op->x, op->y, op); 1360 op->ms ().bot = op;
1463 } 1361 }
1464 else 1362 else
1465 { /* get inserted into the stack above top */ 1363 { /* get inserted into the stack above top */
1466 op->above = top->above; 1364 op->above = top->above;
1467 1365
1470 1368
1471 op->below = top; 1369 op->below = top;
1472 top->above = op; 1370 top->above = op;
1473 } 1371 }
1474 1372
1475 if (op->above == NULL) 1373 if (!op->above)
1476 SET_MAP_TOP (op->map, op->x, op->y, op); 1374 op->ms ().top = op;
1477 } /* else not INS_BELOW_ORIGINATOR */ 1375 } /* else not INS_BELOW_ORIGINATOR */
1478 1376
1479 if (op->type == PLAYER) 1377 if (op->type == PLAYER)
1378 {
1480 op->contr->do_los = 1; 1379 op->contr->do_los = 1;
1380 ++op->map->players;
1381 op->map->touch ();
1382 }
1383
1384 op->map->dirty = true;
1481 1385
1482 /* If we have a floor, we know the player, if any, will be above 1386 /* If we have a floor, we know the player, if any, will be above
1483 * it, so save a few ticks and start from there. 1387 * it, so save a few ticks and start from there.
1484 */ 1388 */
1485 if (!(flag & INS_MAP_LOAD)) 1389 if (!(flag & INS_MAP_LOAD))
1486 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1390 if (object *pl = op->ms ().player ())
1487 if (tmp->type == PLAYER) 1391 if (pl->contr->ns)
1488 tmp->contr->socket.update_look = 1; 1392 pl->contr->ns->floorbox_update ();
1489 1393
1490 /* If this object glows, it may affect lighting conditions that are 1394 /* If this object glows, it may affect lighting conditions that are
1491 * visible to others on this map. But update_all_los is really 1395 * visible to others on this map. But update_all_los is really
1492 * an inefficient way to do this, as it means los for all players 1396 * an inefficient way to do this, as it means los for all players
1493 * on the map will get recalculated. The players could very well 1397 * on the map will get recalculated. The players could very well
1494 * be far away from this change and not affected in any way - 1398 * be far away from this change and not affected in any way -
1495 * this should get redone to only look for players within range, 1399 * this should get redone to only look for players within range,
1496 * or just updating the P_NEED_UPDATE for spaces within this area 1400 * or just updating the P_UPTODATE for spaces within this area
1497 * of effect may be sufficient. 1401 * of effect may be sufficient.
1498 */ 1402 */
1499 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1403 if (op->map->darkness && (op->glow_radius != 0))
1500 update_all_los (op->map, op->x, op->y); 1404 update_all_los (op->map, op->x, op->y);
1501 1405
1502 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1406 /* updates flags (blocked, alive, no magic, etc) for this map space */
1503 update_object (op, UP_OBJ_INSERT); 1407 update_object (op, UP_OBJ_INSERT);
1504 1408
1409 INVOKE_OBJECT (INSERT, op);
1410
1505 /* Don't know if moving this to the end will break anything. However, 1411 /* Don't know if moving this to the end will break anything. However,
1506 * we want to have update_look set above before calling this. 1412 * we want to have floorbox_update called before calling this.
1507 * 1413 *
1508 * check_move_on() must be after this because code called from 1414 * check_move_on() must be after this because code called from
1509 * check_move_on() depends on correct map flags (so functions like 1415 * check_move_on() depends on correct map flags (so functions like
1510 * blocked() and wall() work properly), and these flags are updated by 1416 * blocked() and wall() work properly), and these flags are updated by
1511 * update_object(). 1417 * update_object().
1513 1419
1514 /* if this is not the head or flag has been passed, don't check walk on status */ 1420 /* if this is not the head or flag has been passed, don't check walk on status */
1515 if (!(flag & INS_NO_WALK_ON) && !op->head) 1421 if (!(flag & INS_NO_WALK_ON) && !op->head)
1516 { 1422 {
1517 if (check_move_on (op, originator)) 1423 if (check_move_on (op, originator))
1518 return NULL; 1424 return 0;
1519 1425
1520 /* If we are a multi part object, lets work our way through the check 1426 /* If we are a multi part object, lets work our way through the check
1521 * walk on's. 1427 * walk on's.
1522 */ 1428 */
1523 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1429 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1524 if (check_move_on (tmp, originator)) 1430 if (check_move_on (tmp, originator))
1525 return NULL; 1431 return 0;
1526 } 1432 }
1527 1433
1528 return op; 1434 return op;
1529} 1435}
1530 1436
1531/* this function inserts an object in the map, but if it 1437/* this function inserts an object in the map, but if it
1532 * finds an object of its own type, it'll remove that one first. 1438 * finds an object of its own type, it'll remove that one first.
1533 * op is the object to insert it under: supplies x and the map. 1439 * op is the object to insert it under: supplies x and the map.
1534 */ 1440 */
1535void 1441void
1536replace_insert_ob_in_map (const char *arch_string, object *op) 1442replace_insert_ob_in_map (const char *arch_string, object *op)
1537{ 1443{
1538 object * 1444 object *tmp, *tmp1;
1539 tmp;
1540 object *
1541 tmp1;
1542 1445
1543 /* first search for itself and remove any old instances */ 1446 /* first search for itself and remove any old instances */
1544 1447
1545 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1448 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1546 {
1547 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1449 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1548 {
1549 tmp->remove ();
1550 tmp->destroy (0); 1450 tmp->destroy ();
1551 }
1552 }
1553 1451
1554 tmp1 = arch_to_object (archetype::find (arch_string)); 1452 tmp1 = arch_to_object (archetype::find (arch_string));
1555 1453
1556 tmp1->x = op->x; 1454 tmp1->x = op->x;
1557 tmp1->y = op->y; 1455 tmp1->y = op->y;
1558 insert_ob_in_map (tmp1, op->map, op, 0); 1456 insert_ob_in_map (tmp1, op->map, op, 0);
1457}
1458
1459object *
1460object::insert_at (object *where, object *originator, int flags)
1461{
1462 where->map->insert (this, where->x, where->y, originator, flags);
1559} 1463}
1560 1464
1561/* 1465/*
1562 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1466 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1563 * is returned contains nr objects, and the remaining parts contains 1467 * is returned contains nr objects, and the remaining parts contains
1564 * the rest (or is removed and freed if that number is 0). 1468 * the rest (or is removed and freed if that number is 0).
1565 * On failure, NULL is returned, and the reason put into the 1469 * On failure, NULL is returned, and the reason put into the
1566 * global static errmsg array. 1470 * global static errmsg array.
1567 */ 1471 */
1568
1569object * 1472object *
1570get_split_ob (object *orig_ob, uint32 nr) 1473get_split_ob (object *orig_ob, uint32 nr)
1571{ 1474{
1572 object * 1475 object *newob;
1573 newob;
1574 int
1575 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1476 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1576 1477
1577 if (orig_ob->nrof < nr) 1478 if (orig_ob->nrof < nr)
1578 { 1479 {
1579 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1480 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1580 return NULL; 1481 return NULL;
1611 1512
1612object * 1513object *
1613decrease_ob_nr (object *op, uint32 i) 1514decrease_ob_nr (object *op, uint32 i)
1614{ 1515{
1615 object *tmp; 1516 object *tmp;
1616 player *pl;
1617 1517
1618 if (i == 0) /* objects with op->nrof require this check */ 1518 if (i == 0) /* objects with op->nrof require this check */
1619 return op; 1519 return op;
1620 1520
1621 if (i > op->nrof) 1521 if (i > op->nrof)
1622 i = op->nrof; 1522 i = op->nrof;
1623 1523
1624 if (QUERY_FLAG (op, FLAG_REMOVED)) 1524 if (QUERY_FLAG (op, FLAG_REMOVED))
1625 op->nrof -= i; 1525 op->nrof -= i;
1626 else if (op->env != NULL) 1526 else if (op->env)
1627 { 1527 {
1628 /* is this object in the players inventory, or sub container 1528 /* is this object in the players inventory, or sub container
1629 * therein? 1529 * therein?
1630 */ 1530 */
1631 tmp = is_player_inv (op->env); 1531 tmp = op->in_player ();
1632 /* nope. Is this a container the player has opened? 1532 /* nope. Is this a container the player has opened?
1633 * If so, set tmp to that player. 1533 * If so, set tmp to that player.
1634 * IMO, searching through all the players will mostly 1534 * IMO, searching through all the players will mostly
1635 * likely be quicker than following op->env to the map, 1535 * likely be quicker than following op->env to the map,
1636 * and then searching the map for a player. 1536 * and then searching the map for a player.
1637 */ 1537 */
1638 if (!tmp) 1538 if (!tmp)
1639 { 1539 for_all_players (pl)
1640 for (pl = first_player; pl; pl = pl->next)
1641 if (pl->ob->container == op->env) 1540 if (pl->ob->container == op->env)
1541 {
1542 tmp = pl->ob;
1642 break; 1543 break;
1643 if (pl)
1644 tmp = pl->ob;
1645 else
1646 tmp = NULL;
1647 } 1544 }
1648 1545
1649 if (i < op->nrof) 1546 if (i < op->nrof)
1650 { 1547 {
1651 sub_weight (op->env, op->weight * i); 1548 sub_weight (op->env, op->weight * i);
1652 op->nrof -= i; 1549 op->nrof -= i;
1653 if (tmp) 1550 if (tmp)
1654 {
1655 esrv_send_item (tmp, op); 1551 esrv_send_item (tmp, op);
1656 }
1657 } 1552 }
1658 else 1553 else
1659 { 1554 {
1660 op->remove (); 1555 op->remove ();
1661 op->nrof = 0; 1556 op->nrof = 0;
1662 if (tmp) 1557 if (tmp)
1663 {
1664 esrv_del_item (tmp->contr, op->count); 1558 esrv_del_item (tmp->contr, op->count);
1665 }
1666 } 1559 }
1667 } 1560 }
1668 else 1561 else
1669 { 1562 {
1670 object *above = op->above; 1563 object *above = op->above;
1676 op->remove (); 1569 op->remove ();
1677 op->nrof = 0; 1570 op->nrof = 0;
1678 } 1571 }
1679 1572
1680 /* Since we just removed op, op->above is null */ 1573 /* Since we just removed op, op->above is null */
1681 for (tmp = above; tmp != NULL; tmp = tmp->above) 1574 for (tmp = above; tmp; tmp = tmp->above)
1682 if (tmp->type == PLAYER) 1575 if (tmp->type == PLAYER)
1683 { 1576 {
1684 if (op->nrof) 1577 if (op->nrof)
1685 esrv_send_item (tmp, op); 1578 esrv_send_item (tmp, op);
1686 else 1579 else
1690 1583
1691 if (op->nrof) 1584 if (op->nrof)
1692 return op; 1585 return op;
1693 else 1586 else
1694 { 1587 {
1695 op->destroy (0); 1588 op->destroy ();
1696 return NULL; 1589 return 0;
1697 } 1590 }
1698} 1591}
1699 1592
1700/* 1593/*
1701 * add_weight(object, weight) adds the specified weight to an object, 1594 * add_weight(object, weight) adds the specified weight to an object,
1761 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1654 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1762 CLEAR_FLAG (op, FLAG_REMOVED); 1655 CLEAR_FLAG (op, FLAG_REMOVED);
1763 if (op->nrof) 1656 if (op->nrof)
1764 { 1657 {
1765 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1658 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1766 if (CAN_MERGE (tmp, op)) 1659 if (object::can_merge (tmp, op))
1767 { 1660 {
1768 /* return the original object and remove inserted object 1661 /* return the original object and remove inserted object
1769 (client needs the original object) */ 1662 (client needs the original object) */
1770 tmp->nrof += op->nrof; 1663 tmp->nrof += op->nrof;
1771 /* Weight handling gets pretty funky. Since we are adding to 1664 /* Weight handling gets pretty funky. Since we are adding to
1789 add_weight (this, op->weight * op->nrof); 1682 add_weight (this, op->weight * op->nrof);
1790 } 1683 }
1791 else 1684 else
1792 add_weight (this, (op->weight + op->carrying)); 1685 add_weight (this, (op->weight + op->carrying));
1793 1686
1794 otmp = is_player_inv (this); 1687 otmp = this->in_player ();
1795 if (otmp && otmp->contr) 1688 if (otmp && otmp->contr)
1796 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1689 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1797 fix_player (otmp); 1690 otmp->update_stats ();
1798 1691
1799 op->map = NULL; 1692 op->map = 0;
1800 op->env = this; 1693 op->env = this;
1801 op->above = NULL; 1694 op->above = 0;
1802 op->below = NULL; 1695 op->below = 0;
1803 op->x = 0, op->y = 0; 1696 op->x = 0, op->y = 0;
1804 1697
1805 /* reset the light list and los of the players on the map */ 1698 /* reset the light list and los of the players on the map */
1806 if ((op->glow_radius != 0) && map) 1699 if ((op->glow_radius != 0) && map)
1807 { 1700 {
1808#ifdef DEBUG_LIGHTS 1701#ifdef DEBUG_LIGHTS
1809 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1702 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1810#endif /* DEBUG_LIGHTS */ 1703#endif /* DEBUG_LIGHTS */
1811 if (MAP_DARKNESS (map)) 1704 if (map->darkness)
1812 update_all_los (map, x, y); 1705 update_all_los (map, x, y);
1813 } 1706 }
1814 1707
1815 /* Client has no idea of ordering so lets not bother ordering it here. 1708 /* Client has no idea of ordering so lets not bother ordering it here.
1816 * It sure simplifies this function... 1709 * It sure simplifies this function...
1821 { 1714 {
1822 op->below = inv; 1715 op->below = inv;
1823 op->below->above = op; 1716 op->below->above = op;
1824 inv = op; 1717 inv = op;
1825 } 1718 }
1719
1720 INVOKE_OBJECT (INSERT, this);
1826 1721
1827 return op; 1722 return op;
1828} 1723}
1829 1724
1830/* 1725/*
1845 * 1740 *
1846 * MSW 2001-07-08: Check all objects on space, not just those below 1741 * MSW 2001-07-08: Check all objects on space, not just those below
1847 * object being inserted. insert_ob_in_map may not put new objects 1742 * object being inserted. insert_ob_in_map may not put new objects
1848 * on top. 1743 * on top.
1849 */ 1744 */
1850
1851int 1745int
1852check_move_on (object *op, object *originator) 1746check_move_on (object *op, object *originator)
1853{ 1747{
1854 object *tmp; 1748 object *tmp;
1855 maptile *m = op->map; 1749 maptile *m = op->map;
1882 1776
1883 /* The objects have to be checked from top to bottom. 1777 /* The objects have to be checked from top to bottom.
1884 * Hence, we first go to the top: 1778 * Hence, we first go to the top:
1885 */ 1779 */
1886 1780
1887 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1781 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1888 { 1782 {
1889 /* Trim the search when we find the first other spell effect 1783 /* Trim the search when we find the first other spell effect
1890 * this helps performance so that if a space has 50 spell objects, 1784 * this helps performance so that if a space has 50 spell objects,
1891 * we don't need to check all of them. 1785 * we don't need to check all of them.
1892 */ 1786 */
1947/* 1841/*
1948 * present_arch(arch, map, x, y) searches for any objects with 1842 * present_arch(arch, map, x, y) searches for any objects with
1949 * a matching archetype at the given map and coordinates. 1843 * a matching archetype at the given map and coordinates.
1950 * The first matching object is returned, or NULL if none. 1844 * The first matching object is returned, or NULL if none.
1951 */ 1845 */
1952
1953object * 1846object *
1954present_arch (const archetype *at, maptile *m, int x, int y) 1847present_arch (const archetype *at, maptile *m, int x, int y)
1955{ 1848{
1956 object *
1957 tmp;
1958
1959 if (m == NULL || out_of_map (m, x, y)) 1849 if (m == NULL || out_of_map (m, x, y))
1960 { 1850 {
1961 LOG (llevError, "Present_arch called outside map.\n"); 1851 LOG (llevError, "Present_arch called outside map.\n");
1962 return NULL; 1852 return NULL;
1963 } 1853 }
1854
1964 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1855 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1965 if (tmp->arch == at) 1856 if (tmp->arch == at)
1966 return tmp; 1857 return tmp;
1858
1967 return NULL; 1859 return NULL;
1968} 1860}
1969 1861
1970/* 1862/*
1971 * present(type, map, x, y) searches for any objects with 1863 * present(type, map, x, y) searches for any objects with
1972 * a matching type variable at the given map and coordinates. 1864 * a matching type variable at the given map and coordinates.
1973 * The first matching object is returned, or NULL if none. 1865 * The first matching object is returned, or NULL if none.
1974 */ 1866 */
1975
1976object * 1867object *
1977present (unsigned char type, maptile *m, int x, int y) 1868present (unsigned char type, maptile *m, int x, int y)
1978{ 1869{
1979 object *
1980 tmp;
1981
1982 if (out_of_map (m, x, y)) 1870 if (out_of_map (m, x, y))
1983 { 1871 {
1984 LOG (llevError, "Present called outside map.\n"); 1872 LOG (llevError, "Present called outside map.\n");
1985 return NULL; 1873 return NULL;
1986 } 1874 }
1875
1987 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1876 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1988 if (tmp->type == type) 1877 if (tmp->type == type)
1989 return tmp; 1878 return tmp;
1879
1990 return NULL; 1880 return NULL;
1991} 1881}
1992 1882
1993/* 1883/*
1994 * present_in_ob(type, object) searches for any objects with 1884 * present_in_ob(type, object) searches for any objects with
1995 * a matching type variable in the inventory of the given object. 1885 * a matching type variable in the inventory of the given object.
1996 * The first matching object is returned, or NULL if none. 1886 * The first matching object is returned, or NULL if none.
1997 */ 1887 */
1998
1999object * 1888object *
2000present_in_ob (unsigned char type, const object *op) 1889present_in_ob (unsigned char type, const object *op)
2001{ 1890{
2002 object *
2003 tmp;
2004
2005 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2006 if (tmp->type == type) 1892 if (tmp->type == type)
2007 return tmp; 1893 return tmp;
1894
2008 return NULL; 1895 return NULL;
2009} 1896}
2010 1897
2011/* 1898/*
2012 * present_in_ob (type, str, object) searches for any objects with 1899 * present_in_ob (type, str, object) searches for any objects with
2020 * str is the string to match against. Note that we match against 1907 * str is the string to match against. Note that we match against
2021 * the object name, not the archetype name. this is so that the 1908 * the object name, not the archetype name. this is so that the
2022 * spell code can use one object type (force), but change it's name 1909 * spell code can use one object type (force), but change it's name
2023 * to be unique. 1910 * to be unique.
2024 */ 1911 */
2025
2026object * 1912object *
2027present_in_ob_by_name (int type, const char *str, const object *op) 1913present_in_ob_by_name (int type, const char *str, const object *op)
2028{ 1914{
2029 object *
2030 tmp;
2031
2032 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1915 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2033 {
2034 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1916 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2035 return tmp; 1917 return tmp;
2036 } 1918
2037 return NULL; 1919 return 0;
2038} 1920}
2039 1921
2040/* 1922/*
2041 * present_arch_in_ob(archetype, object) searches for any objects with 1923 * present_arch_in_ob(archetype, object) searches for any objects with
2042 * a matching archetype in the inventory of the given object. 1924 * a matching archetype in the inventory of the given object.
2043 * The first matching object is returned, or NULL if none. 1925 * The first matching object is returned, or NULL if none.
2044 */ 1926 */
2045
2046object * 1927object *
2047present_arch_in_ob (const archetype *at, const object *op) 1928present_arch_in_ob (const archetype *at, const object *op)
2048{ 1929{
2049 object *
2050 tmp;
2051
2052 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1930 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2053 if (tmp->arch == at) 1931 if (tmp->arch == at)
2054 return tmp; 1932 return tmp;
1933
2055 return NULL; 1934 return NULL;
2056} 1935}
2057 1936
2058/* 1937/*
2059 * activate recursively a flag on an object inventory 1938 * activate recursively a flag on an object inventory
2060 */ 1939 */
2061void 1940void
2062flag_inv (object *op, int flag) 1941flag_inv (object *op, int flag)
2063{ 1942{
2064 object *
2065 tmp;
2066
2067 if (op->inv) 1943 if (op->inv)
2068 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1944 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2069 { 1945 {
2070 SET_FLAG (tmp, flag); 1946 SET_FLAG (tmp, flag);
2071 flag_inv (tmp, flag); 1947 flag_inv (tmp, flag);
2072 } 1948 }
2073} /* 1949}
1950
1951/*
2074 * desactivate recursively a flag on an object inventory 1952 * deactivate recursively a flag on an object inventory
2075 */ 1953 */
2076void 1954void
2077unflag_inv (object *op, int flag) 1955unflag_inv (object *op, int flag)
2078{ 1956{
2079 object *
2080 tmp;
2081
2082 if (op->inv) 1957 if (op->inv)
2083 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1958 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2084 { 1959 {
2085 CLEAR_FLAG (tmp, flag); 1960 CLEAR_FLAG (tmp, flag);
2086 unflag_inv (tmp, flag); 1961 unflag_inv (tmp, flag);
2087 } 1962 }
2088} 1963}
2091 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1966 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2092 * all it's inventory (recursively). 1967 * all it's inventory (recursively).
2093 * If checksums are used, a player will get set_cheat called for 1968 * If checksums are used, a player will get set_cheat called for
2094 * him/her-self and all object carried by a call to this function. 1969 * him/her-self and all object carried by a call to this function.
2095 */ 1970 */
2096
2097void 1971void
2098set_cheat (object *op) 1972set_cheat (object *op)
2099{ 1973{
2100 SET_FLAG (op, FLAG_WAS_WIZ); 1974 SET_FLAG (op, FLAG_WAS_WIZ);
2101 flag_inv (op, FLAG_WAS_WIZ); 1975 flag_inv (op, FLAG_WAS_WIZ);
2120 * because arch_blocked (now ob_blocked) needs to know the movement type 1994 * because arch_blocked (now ob_blocked) needs to know the movement type
2121 * to know if the space in question will block the object. We can't use 1995 * to know if the space in question will block the object. We can't use
2122 * the archetype because that isn't correct if the monster has been 1996 * the archetype because that isn't correct if the monster has been
2123 * customized, changed states, etc. 1997 * customized, changed states, etc.
2124 */ 1998 */
2125
2126int 1999int
2127find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2000find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2128{ 2001{
2129 int
2130 i,
2131 index = 0, flag; 2002 int index = 0, flag;
2132 static int
2133 altern[SIZEOFFREE]; 2003 int altern[SIZEOFFREE];
2134 2004
2135 for (i = start; i < stop; i++) 2005 for (int i = start; i < stop; i++)
2136 { 2006 {
2137 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2007 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2138 if (!flag) 2008 if (!flag)
2139 altern[index++] = i; 2009 altern [index++] = i;
2140 2010
2141 /* Basically, if we find a wall on a space, we cut down the search size. 2011 /* Basically, if we find a wall on a space, we cut down the search size.
2142 * In this way, we won't return spaces that are on another side of a wall. 2012 * In this way, we won't return spaces that are on another side of a wall.
2143 * This mostly work, but it cuts down the search size in all directions - 2013 * This mostly work, but it cuts down the search size in all directions -
2144 * if the space being examined only has a wall to the north and empty 2014 * if the space being examined only has a wall to the north and empty
2145 * spaces in all the other directions, this will reduce the search space 2015 * spaces in all the other directions, this will reduce the search space
2146 * to only the spaces immediately surrounding the target area, and 2016 * to only the spaces immediately surrounding the target area, and
2147 * won't look 2 spaces south of the target space. 2017 * won't look 2 spaces south of the target space.
2148 */ 2018 */
2149 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2019 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2150 stop = maxfree[i]; 2020 stop = maxfree[i];
2151 } 2021 }
2022
2152 if (!index) 2023 if (!index)
2153 return -1; 2024 return -1;
2025
2154 return altern[RANDOM () % index]; 2026 return altern[RANDOM () % index];
2155} 2027}
2156 2028
2157/* 2029/*
2158 * find_first_free_spot(archetype, maptile, x, y) works like 2030 * find_first_free_spot(archetype, maptile, x, y) works like
2159 * find_free_spot(), but it will search max number of squares. 2031 * find_free_spot(), but it will search max number of squares.
2160 * But it will return the first available spot, not a random choice. 2032 * But it will return the first available spot, not a random choice.
2161 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2033 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2162 */ 2034 */
2163
2164int 2035int
2165find_first_free_spot (const object *ob, maptile *m, int x, int y) 2036find_first_free_spot (const object *ob, maptile *m, int x, int y)
2166{ 2037{
2167 int
2168 i;
2169
2170 for (i = 0; i < SIZEOFFREE; i++) 2038 for (int i = 0; i < SIZEOFFREE; i++)
2171 {
2172 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2039 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2173 return i; 2040 return i;
2174 } 2041
2175 return -1; 2042 return -1;
2176} 2043}
2177 2044
2178/* 2045/*
2179 * The function permute(arr, begin, end) randomly reorders the array 2046 * The function permute(arr, begin, end) randomly reorders the array
2180 * arr[begin..end-1]. 2047 * arr[begin..end-1].
2048 * now uses a fisher-yates shuffle, old permute was broken
2181 */ 2049 */
2182static void 2050static void
2183permute (int *arr, int begin, int end) 2051permute (int *arr, int begin, int end)
2184{ 2052{
2185 int 2053 arr += begin;
2186 i,
2187 j,
2188 tmp,
2189 len;
2190
2191 len = end - begin; 2054 end -= begin;
2192 for (i = begin; i < end; i++)
2193 {
2194 j = begin + RANDOM () % len;
2195 2055
2196 tmp = arr[i]; 2056 while (--end)
2197 arr[i] = arr[j]; 2057 swap (arr [end], arr [RANDOM () % (end + 1)]);
2198 arr[j] = tmp;
2199 }
2200} 2058}
2201 2059
2202/* new function to make monster searching more efficient, and effective! 2060/* new function to make monster searching more efficient, and effective!
2203 * This basically returns a randomized array (in the passed pointer) of 2061 * This basically returns a randomized array (in the passed pointer) of
2204 * the spaces to find monsters. In this way, it won't always look for 2062 * the spaces to find monsters. In this way, it won't always look for
2207 * the 3x3 area will be searched, just not in a predictable order. 2065 * the 3x3 area will be searched, just not in a predictable order.
2208 */ 2066 */
2209void 2067void
2210get_search_arr (int *search_arr) 2068get_search_arr (int *search_arr)
2211{ 2069{
2212 int 2070 int i;
2213 i;
2214 2071
2215 for (i = 0; i < SIZEOFFREE; i++) 2072 for (i = 0; i < SIZEOFFREE; i++)
2216 {
2217 search_arr[i] = i; 2073 search_arr[i] = i;
2218 }
2219 2074
2220 permute (search_arr, 1, SIZEOFFREE1 + 1); 2075 permute (search_arr, 1, SIZEOFFREE1 + 1);
2221 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2076 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2222 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2077 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2223} 2078}
2232 * Perhaps incorrectly, but I'm making the assumption that exclude 2087 * Perhaps incorrectly, but I'm making the assumption that exclude
2233 * is actually want is going to try and move there. We need this info 2088 * is actually want is going to try and move there. We need this info
2234 * because we have to know what movement the thing looking to move 2089 * because we have to know what movement the thing looking to move
2235 * there is capable of. 2090 * there is capable of.
2236 */ 2091 */
2237
2238int 2092int
2239find_dir (maptile *m, int x, int y, object *exclude) 2093find_dir (maptile *m, int x, int y, object *exclude)
2240{ 2094{
2241 int
2242 i,
2243 max = SIZEOFFREE, mflags; 2095 int i, max = SIZEOFFREE, mflags;
2244 2096
2245 sint16 nx, ny; 2097 sint16 nx, ny;
2246 object * 2098 object *tmp;
2247 tmp;
2248 maptile * 2099 maptile *mp;
2249 mp;
2250 2100
2251 MoveType blocked, move_type; 2101 MoveType blocked, move_type;
2252 2102
2253 if (exclude && exclude->head) 2103 if (exclude && exclude->head)
2254 { 2104 {
2266 mp = m; 2116 mp = m;
2267 nx = x + freearr_x[i]; 2117 nx = x + freearr_x[i];
2268 ny = y + freearr_y[i]; 2118 ny = y + freearr_y[i];
2269 2119
2270 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2120 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2121
2271 if (mflags & P_OUT_OF_MAP) 2122 if (mflags & P_OUT_OF_MAP)
2272 {
2273 max = maxfree[i]; 2123 max = maxfree[i];
2274 }
2275 else 2124 else
2276 { 2125 {
2277 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2126 mapspace &ms = mp->at (nx, ny);
2127
2128 blocked = ms.move_block;
2278 2129
2279 if ((move_type & blocked) == move_type) 2130 if ((move_type & blocked) == move_type)
2280 {
2281 max = maxfree[i]; 2131 max = maxfree[i];
2282 }
2283 else if (mflags & P_IS_ALIVE) 2132 else if (mflags & P_IS_ALIVE)
2284 { 2133 {
2285 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2134 for (tmp = ms.bot; tmp; tmp = tmp->above)
2286 { 2135 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2287 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2136 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2288 {
2289 break; 2137 break;
2290 } 2138
2291 }
2292 if (tmp) 2139 if (tmp)
2293 {
2294 return freedir[i]; 2140 return freedir[i];
2295 }
2296 } 2141 }
2297 } 2142 }
2298 } 2143 }
2144
2299 return 0; 2145 return 0;
2300} 2146}
2301 2147
2302/* 2148/*
2303 * distance(object 1, object 2) will return the square of the 2149 * distance(object 1, object 2) will return the square of the
2304 * distance between the two given objects. 2150 * distance between the two given objects.
2305 */ 2151 */
2306
2307int 2152int
2308distance (const object *ob1, const object *ob2) 2153distance (const object *ob1, const object *ob2)
2309{ 2154{
2310 int
2311 i;
2312
2313 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2155 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2314 return i;
2315} 2156}
2316 2157
2317/* 2158/*
2318 * find_dir_2(delta-x,delta-y) will return a direction in which 2159 * find_dir_2(delta-x,delta-y) will return a direction in which
2319 * an object which has subtracted the x and y coordinates of another 2160 * an object which has subtracted the x and y coordinates of another
2320 * object, needs to travel toward it. 2161 * object, needs to travel toward it.
2321 */ 2162 */
2322
2323int 2163int
2324find_dir_2 (int x, int y) 2164find_dir_2 (int x, int y)
2325{ 2165{
2326 int 2166 int q;
2327 q;
2328 2167
2329 if (y) 2168 if (y)
2330 q = x * 100 / y; 2169 q = x * 100 / y;
2331 else if (x) 2170 else if (x)
2332 q = -300 * x; 2171 q = -300 * x;
2367int 2206int
2368absdir (int d) 2207absdir (int d)
2369{ 2208{
2370 while (d < 1) 2209 while (d < 1)
2371 d += 8; 2210 d += 8;
2211
2372 while (d > 8) 2212 while (d > 8)
2373 d -= 8; 2213 d -= 8;
2214
2374 return d; 2215 return d;
2375} 2216}
2376 2217
2377/* 2218/*
2378 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2219 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2380 */ 2221 */
2381 2222
2382int 2223int
2383dirdiff (int dir1, int dir2) 2224dirdiff (int dir1, int dir2)
2384{ 2225{
2385 int 2226 int d;
2386 d;
2387 2227
2388 d = abs (dir1 - dir2); 2228 d = abs (dir1 - dir2);
2389 if (d > 4) 2229 if (d > 4)
2390 d = 8 - d; 2230 d = 8 - d;
2231
2391 return d; 2232 return d;
2392} 2233}
2393 2234
2394/* peterm: 2235/* peterm:
2395 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2236 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2398 * This basically means that if direction is 15, then it could either go 2239 * This basically means that if direction is 15, then it could either go
2399 * direction 4, 14, or 16 to get back to where we are. 2240 * direction 4, 14, or 16 to get back to where we are.
2400 * Moved from spell_util.c to object.c with the other related direction 2241 * Moved from spell_util.c to object.c with the other related direction
2401 * functions. 2242 * functions.
2402 */ 2243 */
2403
2404int
2405 reduction_dir[SIZEOFFREE][3] = { 2244int reduction_dir[SIZEOFFREE][3] = {
2406 {0, 0, 0}, /* 0 */ 2245 {0, 0, 0}, /* 0 */
2407 {0, 0, 0}, /* 1 */ 2246 {0, 0, 0}, /* 1 */
2408 {0, 0, 0}, /* 2 */ 2247 {0, 0, 0}, /* 2 */
2409 {0, 0, 0}, /* 3 */ 2248 {0, 0, 0}, /* 3 */
2410 {0, 0, 0}, /* 4 */ 2249 {0, 0, 0}, /* 4 */
2458 * find a path to that monster that we found. If not, 2297 * find a path to that monster that we found. If not,
2459 * we don't bother going toward it. Returns 1 if we 2298 * we don't bother going toward it. Returns 1 if we
2460 * can see a direct way to get it 2299 * can see a direct way to get it
2461 * Modified to be map tile aware -.MSW 2300 * Modified to be map tile aware -.MSW
2462 */ 2301 */
2463
2464
2465int 2302int
2466can_see_monsterP (maptile *m, int x, int y, int dir) 2303can_see_monsterP (maptile *m, int x, int y, int dir)
2467{ 2304{
2468 sint16 dx, dy; 2305 sint16 dx, dy;
2469 int
2470 mflags; 2306 int mflags;
2471 2307
2472 if (dir < 0) 2308 if (dir < 0)
2473 return 0; /* exit condition: invalid direction */ 2309 return 0; /* exit condition: invalid direction */
2474 2310
2475 dx = x + freearr_x[dir]; 2311 dx = x + freearr_x[dir];
2488 return 0; 2324 return 0;
2489 2325
2490 /* yes, can see. */ 2326 /* yes, can see. */
2491 if (dir < 9) 2327 if (dir < 9)
2492 return 1; 2328 return 1;
2329
2493 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2330 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2494 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2331 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2332 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2495} 2333}
2496
2497
2498 2334
2499/* 2335/*
2500 * can_pick(picker, item): finds out if an object is possible to be 2336 * can_pick(picker, item): finds out if an object is possible to be
2501 * picked up by the picker. Returnes 1 if it can be 2337 * picked up by the picker. Returnes 1 if it can be
2502 * picked up, otherwise 0. 2338 * picked up, otherwise 0.
2513 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2349 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2514 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2350 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2515 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2351 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2516} 2352}
2517 2353
2518
2519/* 2354/*
2520 * create clone from object to another 2355 * create clone from object to another
2521 */ 2356 */
2522object * 2357object *
2523object_create_clone (object *asrc) 2358object_create_clone (object *asrc)
2532 src = src->head; 2367 src = src->head;
2533 2368
2534 prev = 0; 2369 prev = 0;
2535 for (part = src; part; part = part->more) 2370 for (part = src; part; part = part->more)
2536 { 2371 {
2537 tmp = get_object (); 2372 tmp = part->clone ();
2538 copy_object (part, tmp);
2539 tmp->x -= src->x; 2373 tmp->x -= src->x;
2540 tmp->y -= src->y; 2374 tmp->y -= src->y;
2541 2375
2542 if (!part->head) 2376 if (!part->head)
2543 { 2377 {
2544 dst = tmp; 2378 dst = tmp;
2545 tmp->head = 0; 2379 tmp->head = 0;
2546 } 2380 }
2547 else 2381 else
2548 {
2549 tmp->head = dst; 2382 tmp->head = dst;
2550 }
2551 2383
2552 tmp->more = 0; 2384 tmp->more = 0;
2553 2385
2554 if (prev) 2386 if (prev)
2555 prev->more = tmp; 2387 prev->more = tmp;
2567/* Basically, we save the content of the string to a temp file, then call */ 2399/* Basically, we save the content of the string to a temp file, then call */
2568/* load_object on it. I admit it is a highly inefficient way to make things, */ 2400/* load_object on it. I admit it is a highly inefficient way to make things, */
2569/* but it was simple to make and allows reusing the load_object function. */ 2401/* but it was simple to make and allows reusing the load_object function. */
2570/* Remember not to use load_object_str in a time-critical situation. */ 2402/* Remember not to use load_object_str in a time-critical situation. */
2571/* Also remember that multiparts objects are not supported for now. */ 2403/* Also remember that multiparts objects are not supported for now. */
2572
2573object * 2404object *
2574load_object_str (const char *obstr) 2405load_object_str (const char *obstr)
2575{ 2406{
2576 object *op; 2407 object *op;
2577 char filename[MAX_BUF]; 2408 char filename[MAX_BUF];
2587 } 2418 }
2588 2419
2589 fprintf (tempfile, obstr); 2420 fprintf (tempfile, obstr);
2590 fclose (tempfile); 2421 fclose (tempfile);
2591 2422
2592 op = get_object (); 2423 op = object::create ();
2593 2424
2594 object_thawer thawer (filename); 2425 object_thawer thawer (filename);
2595 2426
2596 if (thawer) 2427 if (thawer)
2597 load_object (thawer, op, 0); 2428 load_object (thawer, op, 0);
2607 * returns NULL if no match. 2438 * returns NULL if no match.
2608 */ 2439 */
2609object * 2440object *
2610find_obj_by_type_subtype (const object *who, int type, int subtype) 2441find_obj_by_type_subtype (const object *who, int type, int subtype)
2611{ 2442{
2612 object *tmp;
2613
2614 for (tmp = who->inv; tmp; tmp = tmp->below) 2443 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2615 if (tmp->type == type && tmp->subtype == subtype) 2444 if (tmp->type == type && tmp->subtype == subtype)
2616 return tmp; 2445 return tmp;
2617 2446
2618 return NULL; 2447 return 0;
2619} 2448}
2620 2449
2621/* If ob has a field named key, return the link from the list, 2450/* If ob has a field named key, return the link from the list,
2622 * otherwise return NULL. 2451 * otherwise return NULL.
2623 * 2452 *
2625 * do the desired thing. 2454 * do the desired thing.
2626 */ 2455 */
2627key_value * 2456key_value *
2628get_ob_key_link (const object *ob, const char *key) 2457get_ob_key_link (const object *ob, const char *key)
2629{ 2458{
2630 key_value *link;
2631
2632 for (link = ob->key_values; link != NULL; link = link->next) 2459 for (key_value *link = ob->key_values; link; link = link->next)
2633 if (link->key == key) 2460 if (link->key == key)
2634 return link; 2461 return link;
2635 2462
2636 return NULL; 2463 return 0;
2637} 2464}
2638 2465
2639/* 2466/*
2640 * Returns the value of op has an extra_field for key, or NULL. 2467 * Returns the value of op has an extra_field for key, or NULL.
2641 * 2468 *
2681 * Returns TRUE on success. 2508 * Returns TRUE on success.
2682 */ 2509 */
2683int 2510int
2684set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2511set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2685{ 2512{
2686 key_value *
2687 field = NULL, *last = NULL; 2513 key_value *field = NULL, *last = NULL;
2688 2514
2689 for (field = op->key_values; field != NULL; field = field->next) 2515 for (field = op->key_values; field != NULL; field = field->next)
2690 { 2516 {
2691 if (field->key != canonical_key) 2517 if (field->key != canonical_key)
2692 { 2518 {
2720 /* IF we get here, key doesn't exist */ 2546 /* IF we get here, key doesn't exist */
2721 2547
2722 /* No field, we'll have to add it. */ 2548 /* No field, we'll have to add it. */
2723 2549
2724 if (!add_key) 2550 if (!add_key)
2725 {
2726 return FALSE; 2551 return FALSE;
2727 } 2552
2728 /* There isn't any good reason to store a null 2553 /* There isn't any good reason to store a null
2729 * value in the key/value list. If the archetype has 2554 * value in the key/value list. If the archetype has
2730 * this key, then we should also have it, so shouldn't 2555 * this key, then we should also have it, so shouldn't
2731 * be here. If user wants to store empty strings, 2556 * be here. If user wants to store empty strings,
2732 * should pass in "" 2557 * should pass in ""
2781 } 2606 }
2782 else 2607 else
2783 item = item->env; 2608 item = item->env;
2784} 2609}
2785 2610
2611
2612const char *
2613object::flag_desc (char *desc, int len) const
2614{
2615 char *p = desc;
2616 bool first = true;
2617
2618 *p = 0;
2619
2620 for (int i = 0; i < NUM_FLAGS; i++)
2621 {
2622 if (len <= 10) // magic constant!
2623 {
2624 snprintf (p, len, ",...");
2625 break;
2626 }
2627
2628 if (flag [i])
2629 {
2630 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2631 len -= cnt;
2632 p += cnt;
2633 first = false;
2634 }
2635 }
2636
2637 return desc;
2638}
2639
2786// return a suitable string describing an objetc in enough detail to find it 2640// return a suitable string describing an object in enough detail to find it
2787const char * 2641const char *
2788object::debug_desc (char *info) const 2642object::debug_desc (char *info) const
2789{ 2643{
2644 char flagdesc[512];
2790 char info2[256 * 3]; 2645 char info2[256 * 4];
2791 char *p = info; 2646 char *p = info;
2792 2647
2793 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2648 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2794 count, 2649 count, uuid.seq,
2795 &name, 2650 &name,
2796 title ? " " : "", 2651 title ? "\",title:" : "",
2797 title ? (const char *)title : ""); 2652 title ? (const char *)title : "",
2653 flag_desc (flagdesc, 512), type);
2798 2654
2799 if (env) 2655 if (env)
2800 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2656 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2801 2657
2802 if (map) 2658 if (map)
2803 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2659 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2804 2660
2805 return info; 2661 return info;
2806} 2662}
2807 2663
2808const char * 2664const char *

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines