ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.74 by root, Wed Dec 20 09:14:21 2006 UTC vs.
Revision 1.106 by root, Wed Jan 3 20:08:04 2007 UTC

141 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
143 */ 143 */
144 144
145 /* For each field in wants, */ 145 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 147 {
148 key_value *has_field; 148 key_value *has_field;
149 149
150 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
190 * Check nrof variable *before* calling can_merge() 190 * Check nrof variable *before* calling can_merge()
191 * 191 *
192 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
193 * check weight 193 * check weight
194 */ 194 */
195
196bool object::can_merge_slow (object *ob1, object *ob2) 195bool object::can_merge_slow (object *ob1, object *ob2)
197{ 196{
198 /* A couple quicksanity checks */ 197 /* A couple quicksanity checks */
199 if (ob1 == ob2 198 if (ob1 == ob2
200 || ob1->type != ob2->type 199 || ob1->type != ob2->type
221 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 220 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222 221
223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225 224
226 if ((ob1->flags ^ ob2->flags).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 225 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
227 || ob1->arch != ob2->arch 226 || ob1->arch != ob2->arch
228 || ob1->name != ob2->name 227 || ob1->name != ob2->name
229 || ob1->title != ob2->title 228 || ob1->title != ob2->title
230 || ob1->msg != ob2->msg 229 || ob1->msg != ob2->msg
231 || ob1->weight != ob2->weight 230 || ob1->weight != ob2->weight
277 276
278 /* Note sure why the following is the case - either the object has to 277 /* Note sure why the following is the case - either the object has to
279 * be animated or have a very low speed. Is this an attempted monster 278 * be animated or have a very low speed. Is this an attempted monster
280 * check? 279 * check?
281 */ 280 */
282 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 281 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
283 return 0; 282 return 0;
284 283
285 switch (ob1->type) 284 switch (ob1->type)
286 { 285 {
287 case SCROLL: 286 case SCROLL:
364{ 363{
365 if (!op) 364 if (!op)
366 return strdup ("[NULLOBJ]"); 365 return strdup ("[NULLOBJ]");
367 366
368 object_freezer freezer; 367 object_freezer freezer;
369 save_object (freezer, op, 3); 368 save_object (freezer, op, 1);
370 return freezer.as_string (); 369 return freezer.as_string ();
371} 370}
372 371
373/* 372/*
374 * get_nearest_part(multi-object, object 2) returns the part of the 373 * get_nearest_part(multi-object, object 2) returns the part of the
467 } 466 }
468 467
469 op->key_values = 0; 468 op->key_values = 0;
470} 469}
471 470
472void object::clear ()
473{
474 attachable_base::clear ();
475
476 free_key_values (this);
477
478 owner = 0;
479 name = 0;
480 name_pl = 0;
481 title = 0;
482 race = 0;
483 slaying = 0;
484 skill = 0;
485 msg = 0;
486 lore = 0;
487 custom_name = 0;
488 materialname = 0;
489 contr = 0;
490 below = 0;
491 above = 0;
492 inv = 0;
493 container = 0;
494 env = 0;
495 more = 0;
496 head = 0;
497 map = 0;
498 active_next = 0;
499 active_prev = 0;
500
501 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
502
503 SET_FLAG (this, FLAG_REMOVED);
504
505 /* What is not cleared is next, prev, and count */
506
507 expmul = 1.0;
508 face = blank_face;
509
510 if (settings.casting_time)
511 casting_time = -1;
512}
513
514/* 471/*
515 * copy_to first frees everything allocated by the dst object, 472 * copy_to first frees everything allocated by the dst object,
516 * and then copies the contents of itself into the second 473 * and then copies the contents of itself into the second
517 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
518 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
524{ 481{
525 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
526 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
527 484
528 *(object_copy *)dst = *this; 485 *(object_copy *)dst = *this;
529 *(object_pod *)dst = *this;
530
531 if (self || cb)
532 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
533 486
534 if (is_freed) 487 if (is_freed)
535 SET_FLAG (dst, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
536 489
537 if (is_removed) 490 if (is_removed)
568 tail = new_link; 521 tail = new_link;
569 } 522 }
570 } 523 }
571 } 524 }
572 525
573 update_ob_speed (dst); 526 dst->set_speed (dst->speed);
574} 527}
575 528
576object * 529object *
577object::clone () 530object::clone ()
578{ 531{
584/* 537/*
585 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
586 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
587 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
588 */ 541 */
589
590void 542void
591update_turn_face (object *op) 543update_turn_face (object *op)
592{ 544{
593 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
594 return; 546 return;
547
595 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
596 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
597} 550}
598 551
599/* 552/*
600 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
601 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
602 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
603 */ 556 */
604void 557void
605update_ob_speed (object *op) 558object::set_speed (float speed)
606{ 559{
607 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
608
609 /* No reason putting the archetypes objects on the speed list,
610 * since they never really need to be updated.
611 */
612
613 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
614 { 561 {
615 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
616#ifdef MANY_CORES
617 abort ();
618#else
619 op->speed = 0; 563 speed = 0;
620#endif
621 }
622
623 if (arch_init)
624 return;
625
626 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
627 { 564 }
628 /* If already on active list, don't do anything */
629 if (op->active_next || op->active_prev || op == active_objects)
630 return;
631 565
632 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
633 * of the list. */
634 op->active_next = active_objects;
635 567
636 if (op->active_next != NULL) 568 if (has_active_speed ())
637 op->active_next->active_prev = op; 569 activate ();
638
639 active_objects = op;
640 }
641 else 570 else
642 { 571 deactivate ();
643 /* If not on the active list, nothing needs to be done */
644 if (!op->active_next && !op->active_prev && op != active_objects)
645 return;
646
647 if (op->active_prev == NULL)
648 {
649 active_objects = op->active_next;
650
651 if (op->active_next != NULL)
652 op->active_next->active_prev = NULL;
653 }
654 else
655 {
656 op->active_prev->active_next = op->active_next;
657
658 if (op->active_next)
659 op->active_next->active_prev = op->active_prev;
660 }
661
662 op->active_next = NULL;
663 op->active_prev = NULL;
664 }
665} 572}
666 573
667/* This function removes object 'op' from the list of active
668 * objects.
669 * This should only be used for style maps or other such
670 * reference maps where you don't want an object that isn't
671 * in play chewing up cpu time getting processed.
672 * The reverse of this is to call update_ob_speed, which
673 * will do the right thing based on the speed of the object.
674 */
675void
676remove_from_active_list (object *op)
677{
678 /* If not on the active list, nothing needs to be done */
679 if (!op->active_next && !op->active_prev && op != active_objects)
680 return;
681
682 if (op->active_prev == NULL)
683 {
684 active_objects = op->active_next;
685 if (op->active_next != NULL)
686 op->active_next->active_prev = NULL;
687 }
688 else
689 {
690 op->active_prev->active_next = op->active_next;
691 if (op->active_next)
692 op->active_next->active_prev = op->active_prev;
693 }
694 op->active_next = NULL;
695 op->active_prev = NULL;
696}
697
698/* 574/*
699 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
700 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
701 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
702 * invisible object, etc...) 578 * invisible object, etc...)
703 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
704 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
705 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
706 * 582 *
707 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
708 * For example, if the only thing that has changed is the face (due to
709 * an animation), we don't need to call update_position until that actually
710 * comes into view of a player. OTOH, many other things, like addition/removal
711 * of walls or living creatures may need us to update the flags now.
712 * current action are: 584 * current action are:
713 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
714 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
715 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
716 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
717 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
718 */ 590 */
719
720void 591void
721update_object (object *op, int action) 592update_object (object *op, int action)
722{ 593{
723 int update_now = 0, flags;
724 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
725 595
726 if (op == NULL) 596 if (op == NULL)
727 { 597 {
728 /* this should never happen */ 598 /* this should never happen */
729 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
730 return; 600 return;
731 } 601 }
732 602
733 if (op->env != NULL) 603 if (op->env)
734 { 604 {
735 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
736 * to do in this case. 606 * to do in this case.
737 */ 607 */
738 return; 608 return;
743 */ 613 */
744 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
745 return; 615 return;
746 616
747 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
748 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
749 { 619 {
750 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
751#ifdef MANY_CORES 621#ifdef MANY_CORES
752 abort (); 622 abort ();
753#endif 623#endif
754 return; 624 return;
755 } 625 }
756 626
757 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
758 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
759 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
760 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
761 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
762 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
763 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
764 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
765 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
766 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
767 update_now = 1;
768
769 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
770 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
771 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
772 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
773 update_now = 1;
774
775 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
776 update_now = 1;
777
778 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
779 update_now = 1;
780
781 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
782 update_now = 1;
783
784 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
785 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
786
787 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
788 * to have move_allow right now. 644 * to have move_allow right now.
789 */ 645 */
790 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
791 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
792 648 m.flags_ = 0;
793 if ((move_slow | op->move_slow) != move_slow)
794 update_now = 1;
795 } 649 }
796
797 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
798 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
799 * that is being removed. 652 * that is being removed.
800 */ 653 */
801 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
802 update_now = 1; 655 m.flags_ = 0;
803 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
804 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
805 else 658 else
806 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
807 660
808 if (update_now)
809 {
810 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
811 update_position (op->map, op->x, op->y);
812 }
813
814 if (op->more != NULL) 661 if (op->more)
815 update_object (op->more, action); 662 update_object (op->more, action);
816} 663}
817 664
818object::vector object::mortals;
819object::vector object::objects; // not yet used
820object *object::first; 665object *object::first;
821
822void object::free_mortals ()
823{
824 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
825 if ((*i)->refcnt)
826 ++i; // further delay freeing
827 else
828 {
829 delete *i;
830 mortals.erase (i);
831 }
832}
833 666
834object::object () 667object::object ()
835{ 668{
836 SET_FLAG (this, FLAG_REMOVED); 669 SET_FLAG (this, FLAG_REMOVED);
837 670
869 702
870 prev = 0; 703 prev = 0;
871 next = 0; 704 next = 0;
872} 705}
873 706
707bool
708object::active () const
709{
710 return active_next || active_prev || this == active_objects;
711}
712
713void
714object::activate ()
715{
716 /* If already on active list, don't do anything */
717 if (active ())
718 return;
719
720 if (has_active_speed ())
721 {
722 /* process_events() expects us to insert the object at the beginning
723 * of the list. */
724 active_next = active_objects;
725
726 if (active_next)
727 active_next->active_prev = this;
728
729 active_objects = this;
730 }
731}
732
733void
734object::activate_recursive ()
735{
736 activate ();
737
738 for (object *op = inv; op; op = op->below)
739 op->activate_recursive ();
740}
741
742/* This function removes object 'op' from the list of active
743 * objects.
744 * This should only be used for style maps or other such
745 * reference maps where you don't want an object that isn't
746 * in play chewing up cpu time getting processed.
747 * The reverse of this is to call update_ob_speed, which
748 * will do the right thing based on the speed of the object.
749 */
750void
751object::deactivate ()
752{
753 /* If not on the active list, nothing needs to be done */
754 if (!active ())
755 return;
756
757 if (active_prev == 0)
758 {
759 active_objects = active_next;
760 if (active_next)
761 active_next->active_prev = 0;
762 }
763 else
764 {
765 active_prev->active_next = active_next;
766 if (active_next)
767 active_next->active_prev = active_prev;
768 }
769
770 active_next = 0;
771 active_prev = 0;
772}
773
774void
775object::deactivate_recursive ()
776{
777 for (object *op = inv; op; op = op->below)
778 op->deactivate_recursive ();
779
780 deactivate ();
781}
782
783void
784object::set_flag_inv (int flag, int value)
785{
786 for (object *op = inv; op; op = op->below)
787 {
788 op->flag [flag] = value;
789 op->set_flag_inv (flag, value);
790 }
791}
792
793/*
794 * Remove and free all objects in the inventory of the given object.
795 * object.c ?
796 */
797void
798object::destroy_inv (bool drop_to_ground)
799{
800 // need to check first, because the checks below might segfault
801 // as we might be on an invalid mapspace and crossfire code
802 // is too buggy to ensure that the inventory is empty.
803 // corollary: if you create arrows etc. with stuff in tis inventory,
804 // cf will crash below with off-map x and y
805 if (!inv)
806 return;
807
808 /* Only if the space blocks everything do we not process -
809 * if some form of movement is allowed, let objects
810 * drop on that space.
811 */
812 if (!drop_to_ground
813 || !map
814 || map->in_memory != MAP_IN_MEMORY
815 || ms ().move_block == MOVE_ALL)
816 {
817 while (inv)
818 {
819 inv->destroy_inv (drop_to_ground);
820 inv->destroy ();
821 }
822 }
823 else
824 { /* Put objects in inventory onto this space */
825 while (inv)
826 {
827 object *op = inv;
828
829 if (op->flag [FLAG_STARTEQUIP]
830 || op->flag [FLAG_NO_DROP]
831 || op->type == RUNE
832 || op->type == TRAP
833 || op->flag [FLAG_IS_A_TEMPLATE])
834 op->destroy ();
835 else
836 map->insert (op, x, y);
837 }
838 }
839}
840
874object *object::create () 841object *object::create ()
875{ 842{
876 object *op = new object; 843 object *op = new object;
877 op->link (); 844 op->link ();
878 return op; 845 return op;
879} 846}
880 847
881/* 848void
882 * free_object() frees everything allocated by an object, removes 849object::do_destroy ()
883 * it from the list of used objects, and puts it on the list of
884 * free objects. The IS_FREED() flag is set in the object.
885 * The object must have been removed by remove_ob() first for
886 * this function to succeed.
887 *
888 * If destroy_inventory is set, free inventory as well. Else drop items in
889 * inventory to the ground.
890 */
891void object::destroy (bool destroy_inventory)
892{ 850{
893 if (QUERY_FLAG (this, FLAG_FREED)) 851 if (flag [FLAG_IS_LINKED])
852 remove_button_link (this);
853
854 if (flag [FLAG_FRIENDLY])
855 remove_friendly_object (this);
856
857 if (!flag [FLAG_REMOVED])
858 remove ();
859
860 if (flag [FLAG_FREED])
894 return; 861 return;
895 862
896 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 863 set_speed (0);
897 remove_friendly_object (this);
898 864
899 if (!QUERY_FLAG (this, FLAG_REMOVED)) 865 flag [FLAG_FREED] = 1;
900 remove ();
901 866
902 SET_FLAG (this, FLAG_FREED); 867 attachable::do_destroy ();
903 868
904 if (more) 869 destroy_inv (true);
905 { 870 unlink ();
906 more->destroy (destroy_inventory);
907 more = 0;
908 }
909
910 if (inv)
911 {
912 /* Only if the space blocks everything do we not process -
913 * if some form of movement is allowed, let objects
914 * drop on that space.
915 */
916 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
917 {
918 object *op = inv;
919
920 while (op)
921 {
922 object *tmp = op->below;
923 op->destroy (destroy_inventory);
924 op = tmp;
925 }
926 }
927 else
928 { /* Put objects in inventory onto this space */
929 object *op = inv;
930
931 while (op)
932 {
933 object *tmp = op->below;
934
935 op->remove ();
936
937 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
938 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
939 op->destroy ();
940 else
941 {
942 op->x = x;
943 op->y = y;
944 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
945 }
946
947 op = tmp;
948 }
949 }
950 }
951 871
952 // hack to ensure that freed objects still have a valid map 872 // hack to ensure that freed objects still have a valid map
953 { 873 {
954 static maptile *freed_map; // freed objects are moved here to avoid crashes 874 static maptile *freed_map; // freed objects are moved here to avoid crashes
955 875
959 879
960 freed_map->name = "/internal/freed_objects_map"; 880 freed_map->name = "/internal/freed_objects_map";
961 freed_map->width = 3; 881 freed_map->width = 3;
962 freed_map->height = 3; 882 freed_map->height = 3;
963 883
964 freed_map->allocate (); 884 freed_map->alloc ();
885 freed_map->in_memory = MAP_IN_MEMORY;
965 } 886 }
966 887
967 map = freed_map; 888 map = freed_map;
968 x = 1; 889 x = 1;
969 y = 1; 890 y = 1;
970 } 891 }
971 892
893 head = 0;
894
895 if (more)
896 {
897 more->destroy ();
898 more = 0;
899 }
900
972 // clear those pointers that likely might have circular references to us 901 // clear those pointers that likely might have circular references to us
973 owner = 0; 902 owner = 0;
974 enemy = 0; 903 enemy = 0;
975 attacked_by = 0; 904 attacked_by = 0;
976 905
977 // only relevant for players(?), but make sure of it anyways 906 // only relevant for players(?), but make sure of it anyways
978 contr = 0; 907 contr = 0;
908}
979 909
980 /* Remove object from the active list */ 910void
981 speed = 0; 911object::destroy (bool destroy_inventory)
982 update_ob_speed (this); 912{
913 if (destroyed ())
914 return;
983 915
984 unlink (); 916 if (destroy_inventory)
917 destroy_inv (false);
985 918
986 mortals.push_back (this); 919 attachable::destroy ();
987} 920}
988 921
989/* 922/*
990 * sub_weight() recursively (outwards) subtracts a number from the 923 * sub_weight() recursively (outwards) subtracts a number from the
991 * weight of an object (and what is carried by it's environment(s)). 924 * weight of an object (and what is carried by it's environment(s)).
1015object::remove () 948object::remove ()
1016{ 949{
1017 object *tmp, *last = 0; 950 object *tmp, *last = 0;
1018 object *otmp; 951 object *otmp;
1019 952
1020 int check_walk_off;
1021
1022 if (QUERY_FLAG (this, FLAG_REMOVED)) 953 if (QUERY_FLAG (this, FLAG_REMOVED))
1023 return; 954 return;
1024 955
1025 SET_FLAG (this, FLAG_REMOVED); 956 SET_FLAG (this, FLAG_REMOVED);
957 INVOKE_OBJECT (REMOVE, this);
1026 958
1027 if (more) 959 if (more)
1028 more->remove (); 960 more->remove ();
1029 961
1030 /* 962 /*
1041 /* NO_FIX_PLAYER is set when a great many changes are being 973 /* NO_FIX_PLAYER is set when a great many changes are being
1042 * made to players inventory. If set, avoiding the call 974 * made to players inventory. If set, avoiding the call
1043 * to save cpu time. 975 * to save cpu time.
1044 */ 976 */
1045 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 977 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1046 fix_player (otmp); 978 otmp->update_stats ();
1047 979
1048 if (above != NULL) 980 if (above)
1049 above->below = below; 981 above->below = below;
1050 else 982 else
1051 env->inv = below; 983 env->inv = below;
1052 984
1053 if (below != NULL) 985 if (below)
1054 below->above = above; 986 below->above = above;
1055 987
1056 /* we set up values so that it could be inserted into 988 /* we set up values so that it could be inserted into
1057 * the map, but we don't actually do that - it is up 989 * the map, but we don't actually do that - it is up
1058 * to the caller to decide what we want to do. 990 * to the caller to decide what we want to do.
1062 above = 0, below = 0; 994 above = 0, below = 0;
1063 env = 0; 995 env = 0;
1064 } 996 }
1065 else if (map) 997 else if (map)
1066 { 998 {
1067 /* Re did the following section of code - it looks like it had 999 if (type == PLAYER)
1068 * lots of logic for things we no longer care about
1069 */ 1000 {
1001 --map->players;
1002 map->touch ();
1003 }
1004
1005 map->dirty = true;
1070 1006
1071 /* link the object above us */ 1007 /* link the object above us */
1072 if (above) 1008 if (above)
1073 above->below = below; 1009 above->below = below;
1074 else 1010 else
1075 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 1011 map->at (x, y).top = below; /* we were top, set new top */
1076 1012
1077 /* Relink the object below us, if there is one */ 1013 /* Relink the object below us, if there is one */
1078 if (below) 1014 if (below)
1079 below->above = above; 1015 below->above = above;
1080 else 1016 else
1092 dump = dump_object (GET_MAP_OB (map, x, y)); 1028 dump = dump_object (GET_MAP_OB (map, x, y));
1093 LOG (llevError, "%s\n", dump); 1029 LOG (llevError, "%s\n", dump);
1094 free (dump); 1030 free (dump);
1095 } 1031 }
1096 1032
1097 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1033 map->at (x, y).bot = above; /* goes on above it. */
1098 } 1034 }
1099 1035
1100 above = 0; 1036 above = 0;
1101 below = 0; 1037 below = 0;
1102 1038
1103 if (map->in_memory == MAP_SAVING) 1039 if (map->in_memory == MAP_SAVING)
1104 return; 1040 return;
1105 1041
1106 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1042 int check_walk_off = !flag [FLAG_NO_APPLY];
1107 1043
1108 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1044 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1109 { 1045 {
1110 /* No point updating the players look faces if he is the object 1046 /* No point updating the players look faces if he is the object
1111 * being removed. 1047 * being removed.
1112 */ 1048 */
1113 1049
1117 * removed (most likely destroyed), update the player view 1053 * removed (most likely destroyed), update the player view
1118 * appropriately. 1054 * appropriately.
1119 */ 1055 */
1120 if (tmp->container == this) 1056 if (tmp->container == this)
1121 { 1057 {
1122 CLEAR_FLAG (this, FLAG_APPLIED); 1058 flag [FLAG_APPLIED] = 0;
1123 tmp->container = 0; 1059 tmp->container = 0;
1124 } 1060 }
1125 1061
1062 if (tmp->contr->ns)
1126 tmp->contr->socket->floorbox_update (); 1063 tmp->contr->ns->floorbox_update ();
1127 } 1064 }
1128 1065
1129 /* See if player moving off should effect something */ 1066 /* See if object moving off should effect something */
1130 if (check_walk_off 1067 if (check_walk_off
1131 && ((move_type & tmp->move_off) 1068 && ((move_type & tmp->move_off)
1132 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1069 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1133 { 1070 {
1134 move_apply (tmp, this, 0); 1071 move_apply (tmp, this, 0);
1136 if (destroyed ()) 1073 if (destroyed ())
1137 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1074 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1138 } 1075 }
1139 1076
1140 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1077 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1141 1078 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1142 if (tmp->above == tmp) 1079 if (tmp->above == tmp)
1143 tmp->above = 0; 1080 tmp->above = 0;
1144 1081
1145 last = tmp; 1082 last = tmp;
1146 } 1083 }
1147 1084
1148 /* last == NULL of there are no objects on this space */ 1085 /* last == NULL if there are no objects on this space */
1086 //TODO: this makes little sense, why only update the topmost object?
1149 if (!last) 1087 if (!last)
1150 { 1088 map->at (x, y).flags_ = 0;
1151 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1152 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1153 * those out anyways, and if there are any flags set right now, they won't
1154 * be correct anyways.
1155 */
1156 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1157 update_position (map, x, y);
1158 }
1159 else 1089 else
1160 update_object (last, UP_OBJ_REMOVE); 1090 update_object (last, UP_OBJ_REMOVE);
1161 1091
1162 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1092 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1163 update_all_los (map, x, y); 1093 update_all_los (map, x, y);
1164 } 1094 }
1165} 1095}
1166 1096
1167/* 1097/*
1176merge_ob (object *op, object *top) 1106merge_ob (object *op, object *top)
1177{ 1107{
1178 if (!op->nrof) 1108 if (!op->nrof)
1179 return 0; 1109 return 0;
1180 1110
1181 if (top == NULL) 1111 if (top)
1182 for (top = op; top != NULL && top->above != NULL; top = top->above); 1112 for (top = op; top && top->above; top = top->above)
1113 ;
1183 1114
1184 for (; top != NULL; top = top->below) 1115 for (; top; top = top->below)
1185 { 1116 {
1186 if (top == op) 1117 if (top == op)
1187 continue; 1118 continue;
1188 1119
1189 if (object::can_merge (op, top)) 1120 if (object::can_merge (op, top))
1205 * job preparing multi-part monsters 1136 * job preparing multi-part monsters
1206 */ 1137 */
1207object * 1138object *
1208insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1139insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1209{ 1140{
1210 object *tmp;
1211
1212 if (op->head)
1213 op = op->head;
1214
1215 for (tmp = op; tmp; tmp = tmp->more) 1141 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1216 { 1142 {
1217 tmp->x = x + tmp->arch->clone.x; 1143 tmp->x = x + tmp->arch->clone.x;
1218 tmp->y = y + tmp->arch->clone.y; 1144 tmp->y = y + tmp->arch->clone.y;
1219 } 1145 }
1220 1146
1239 * Return value: 1165 * Return value:
1240 * new object if 'op' was merged with other object 1166 * new object if 'op' was merged with other object
1241 * NULL if 'op' was destroyed 1167 * NULL if 'op' was destroyed
1242 * just 'op' otherwise 1168 * just 'op' otherwise
1243 */ 1169 */
1244
1245object * 1170object *
1246insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1171insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1247{ 1172{
1248 object *tmp, *top, *floor = NULL; 1173 object *tmp, *top, *floor = NULL;
1249 sint16 x, y; 1174 sint16 x, y;
1252 { 1177 {
1253 LOG (llevError, "Trying to insert freed object!\n"); 1178 LOG (llevError, "Trying to insert freed object!\n");
1254 return NULL; 1179 return NULL;
1255 } 1180 }
1256 1181
1257 if (m == NULL) 1182 if (!m)
1258 { 1183 {
1259 char *dump = dump_object (op); 1184 char *dump = dump_object (op);
1260 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1185 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1261 free (dump); 1186 free (dump);
1262 return op; 1187 return op;
1283 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1208 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1284 free (dump); 1209 free (dump);
1285 return op; 1210 return op;
1286 } 1211 }
1287 1212
1288 if (op->more != NULL) 1213 if (op->more)
1289 { 1214 {
1290 /* The part may be on a different map. */ 1215 /* The part may be on a different map. */
1291 1216
1292 object *more = op->more; 1217 object *more = op->more;
1293 1218
1294 /* We really need the caller to normalize coordinates - if 1219 /* We really need the caller to normalise coordinates - if
1295 * we set the map, that doesn't work if the location is within 1220 * we set the map, that doesn't work if the location is within
1296 * a map and this is straddling an edge. So only if coordinate 1221 * a map and this is straddling an edge. So only if coordinate
1297 * is clear wrong do we normalize it. 1222 * is clear wrong do we normalise it.
1298 */ 1223 */
1299 if (OUT_OF_REAL_MAP (more->map, more->x, more->y)) 1224 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1300 more->map = get_map_from_coord (m, &more->x, &more->y); 1225 more->map = get_map_from_coord (m, &more->x, &more->y);
1301 else if (!more->map) 1226 else if (!more->map)
1302 { 1227 {
1309 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1234 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1310 { 1235 {
1311 if (!op->head) 1236 if (!op->head)
1312 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1237 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1313 1238
1314 return NULL; 1239 return 0;
1315 } 1240 }
1316 } 1241 }
1317 1242
1318 CLEAR_FLAG (op, FLAG_REMOVED); 1243 CLEAR_FLAG (op, FLAG_REMOVED);
1319 1244
1326 y = op->y; 1251 y = op->y;
1327 1252
1328 /* this has to be done after we translate the coordinates. 1253 /* this has to be done after we translate the coordinates.
1329 */ 1254 */
1330 if (op->nrof && !(flag & INS_NO_MERGE)) 1255 if (op->nrof && !(flag & INS_NO_MERGE))
1331 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1256 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1332 if (object::can_merge (op, tmp)) 1257 if (object::can_merge (op, tmp))
1333 { 1258 {
1334 op->nrof += tmp->nrof; 1259 op->nrof += tmp->nrof;
1335 tmp->destroy (); 1260 tmp->destroy ();
1336 } 1261 }
1353 op->below = originator->below; 1278 op->below = originator->below;
1354 1279
1355 if (op->below) 1280 if (op->below)
1356 op->below->above = op; 1281 op->below->above = op;
1357 else 1282 else
1358 SET_MAP_OB (op->map, op->x, op->y, op); 1283 op->ms ().bot = op;
1359 1284
1360 /* since *below* originator, no need to update top */ 1285 /* since *below* originator, no need to update top */
1361 originator->below = op; 1286 originator->below = op;
1362 } 1287 }
1363 else 1288 else
1364 { 1289 {
1365 /* If there are other objects, then */ 1290 /* If there are other objects, then */
1366 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1291 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1367 { 1292 {
1368 object *last = NULL; 1293 object *last = 0;
1369 1294
1370 /* 1295 /*
1371 * If there are multiple objects on this space, we do some trickier handling. 1296 * If there are multiple objects on this space, we do some trickier handling.
1372 * We've already dealt with merging if appropriate. 1297 * We've already dealt with merging if appropriate.
1373 * Generally, we want to put the new object on top. But if 1298 * Generally, we want to put the new object on top. But if
1377 * once we get to them. This reduces the need to traverse over all of 1302 * once we get to them. This reduces the need to traverse over all of
1378 * them when adding another one - this saves quite a bit of cpu time 1303 * them when adding another one - this saves quite a bit of cpu time
1379 * when lots of spells are cast in one area. Currently, it is presumed 1304 * when lots of spells are cast in one area. Currently, it is presumed
1380 * that flying non pickable objects are spell objects. 1305 * that flying non pickable objects are spell objects.
1381 */ 1306 */
1382
1383 while (top != NULL) 1307 while (top)
1384 { 1308 {
1385 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1309 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1386 floor = top; 1310 floor = top;
1387 1311
1388 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1312 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1409 * If INS_ON_TOP is used, don't do this processing 1333 * If INS_ON_TOP is used, don't do this processing
1410 * Need to find the object that in fact blocks view, otherwise 1334 * Need to find the object that in fact blocks view, otherwise
1411 * stacking is a bit odd. 1335 * stacking is a bit odd.
1412 */ 1336 */
1413 if (!(flag & INS_ON_TOP) && 1337 if (!(flag & INS_ON_TOP) &&
1414 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1338 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1415 { 1339 {
1416 for (last = top; last != floor; last = last->below) 1340 for (last = top; last != floor; last = last->below)
1417 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1341 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1418 break; 1342 break;
1419 /* Check to see if we found the object that blocks view, 1343 /* Check to see if we found the object that blocks view,
1441 op->above = GET_MAP_OB (op->map, op->x, op->y); 1365 op->above = GET_MAP_OB (op->map, op->x, op->y);
1442 1366
1443 if (op->above) 1367 if (op->above)
1444 op->above->below = op; 1368 op->above->below = op;
1445 1369
1446 op->below = NULL; 1370 op->below = 0;
1447 SET_MAP_OB (op->map, op->x, op->y, op); 1371 op->ms ().bot = op;
1448 } 1372 }
1449 else 1373 else
1450 { /* get inserted into the stack above top */ 1374 { /* get inserted into the stack above top */
1451 op->above = top->above; 1375 op->above = top->above;
1452 1376
1455 1379
1456 op->below = top; 1380 op->below = top;
1457 top->above = op; 1381 top->above = op;
1458 } 1382 }
1459 1383
1460 if (op->above == NULL) 1384 if (!op->above)
1461 SET_MAP_TOP (op->map, op->x, op->y, op); 1385 op->ms ().top = op;
1462 } /* else not INS_BELOW_ORIGINATOR */ 1386 } /* else not INS_BELOW_ORIGINATOR */
1463 1387
1464 if (op->type == PLAYER) 1388 if (op->type == PLAYER)
1389 {
1465 op->contr->do_los = 1; 1390 op->contr->do_los = 1;
1391 ++op->map->players;
1392 op->map->touch ();
1393 }
1394
1395 op->map->dirty = true;
1466 1396
1467 /* If we have a floor, we know the player, if any, will be above 1397 /* If we have a floor, we know the player, if any, will be above
1468 * it, so save a few ticks and start from there. 1398 * it, so save a few ticks and start from there.
1469 */ 1399 */
1470 if (!(flag & INS_MAP_LOAD)) 1400 if (!(flag & INS_MAP_LOAD))
1471 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1401 if (object *pl = op->ms ().player ())
1472 if (tmp->type == PLAYER) 1402 if (pl->contr->ns)
1473 tmp->contr->socket->floorbox_update (); 1403 pl->contr->ns->floorbox_update ();
1474 1404
1475 /* If this object glows, it may affect lighting conditions that are 1405 /* If this object glows, it may affect lighting conditions that are
1476 * visible to others on this map. But update_all_los is really 1406 * visible to others on this map. But update_all_los is really
1477 * an inefficient way to do this, as it means los for all players 1407 * an inefficient way to do this, as it means los for all players
1478 * on the map will get recalculated. The players could very well 1408 * on the map will get recalculated. The players could very well
1479 * be far away from this change and not affected in any way - 1409 * be far away from this change and not affected in any way -
1480 * this should get redone to only look for players within range, 1410 * this should get redone to only look for players within range,
1481 * or just updating the P_NEED_UPDATE for spaces within this area 1411 * or just updating the P_UPTODATE for spaces within this area
1482 * of effect may be sufficient. 1412 * of effect may be sufficient.
1483 */ 1413 */
1484 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1414 if (op->map->darkness && (op->glow_radius != 0))
1485 update_all_los (op->map, op->x, op->y); 1415 update_all_los (op->map, op->x, op->y);
1486 1416
1487 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1417 /* updates flags (blocked, alive, no magic, etc) for this map space */
1488 update_object (op, UP_OBJ_INSERT); 1418 update_object (op, UP_OBJ_INSERT);
1419
1420 INVOKE_OBJECT (INSERT, op);
1489 1421
1490 /* Don't know if moving this to the end will break anything. However, 1422 /* Don't know if moving this to the end will break anything. However,
1491 * we want to have floorbox_update called before calling this. 1423 * we want to have floorbox_update called before calling this.
1492 * 1424 *
1493 * check_move_on() must be after this because code called from 1425 * check_move_on() must be after this because code called from
1498 1430
1499 /* if this is not the head or flag has been passed, don't check walk on status */ 1431 /* if this is not the head or flag has been passed, don't check walk on status */
1500 if (!(flag & INS_NO_WALK_ON) && !op->head) 1432 if (!(flag & INS_NO_WALK_ON) && !op->head)
1501 { 1433 {
1502 if (check_move_on (op, originator)) 1434 if (check_move_on (op, originator))
1503 return NULL; 1435 return 0;
1504 1436
1505 /* If we are a multi part object, lets work our way through the check 1437 /* If we are a multi part object, lets work our way through the check
1506 * walk on's. 1438 * walk on's.
1507 */ 1439 */
1508 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1440 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1509 if (check_move_on (tmp, originator)) 1441 if (check_move_on (tmp, originator))
1510 return NULL; 1442 return 0;
1511 } 1443 }
1512 1444
1513 return op; 1445 return op;
1514} 1446}
1515 1447
1516/* this function inserts an object in the map, but if it 1448/* this function inserts an object in the map, but if it
1517 * finds an object of its own type, it'll remove that one first. 1449 * finds an object of its own type, it'll remove that one first.
1518 * op is the object to insert it under: supplies x and the map. 1450 * op is the object to insert it under: supplies x and the map.
1519 */ 1451 */
1520void 1452void
1521replace_insert_ob_in_map (const char *arch_string, object *op) 1453replace_insert_ob_in_map (const char *arch_string, object *op)
1522{ 1454{
1523 object * 1455 object *tmp, *tmp1;
1524 tmp;
1525 object *
1526 tmp1;
1527 1456
1528 /* first search for itself and remove any old instances */ 1457 /* first search for itself and remove any old instances */
1529 1458
1530 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1459 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1531 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1460 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1532 tmp->destroy (); 1461 tmp->destroy ();
1533 1462
1534 tmp1 = arch_to_object (archetype::find (arch_string)); 1463 tmp1 = arch_to_object (archetype::find (arch_string));
1535 1464
1536 tmp1->x = op->x; 1465 tmp1->x = op->x;
1537 tmp1->y = op->y; 1466 tmp1->y = op->y;
1538 insert_ob_in_map (tmp1, op->map, op, 0); 1467 insert_ob_in_map (tmp1, op->map, op, 0);
1468}
1469
1470object *
1471object::insert_at (object *where, object *originator, int flags)
1472{
1473 where->map->insert (this, where->x, where->y, originator, flags);
1539} 1474}
1540 1475
1541/* 1476/*
1542 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1477 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1543 * is returned contains nr objects, and the remaining parts contains 1478 * is returned contains nr objects, and the remaining parts contains
1544 * the rest (or is removed and freed if that number is 0). 1479 * the rest (or is removed and freed if that number is 0).
1545 * On failure, NULL is returned, and the reason put into the 1480 * On failure, NULL is returned, and the reason put into the
1546 * global static errmsg array. 1481 * global static errmsg array.
1547 */ 1482 */
1548
1549object * 1483object *
1550get_split_ob (object *orig_ob, uint32 nr) 1484get_split_ob (object *orig_ob, uint32 nr)
1551{ 1485{
1552 object *newob; 1486 object *newob;
1553 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1487 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1589 1523
1590object * 1524object *
1591decrease_ob_nr (object *op, uint32 i) 1525decrease_ob_nr (object *op, uint32 i)
1592{ 1526{
1593 object *tmp; 1527 object *tmp;
1594 player *pl;
1595 1528
1596 if (i == 0) /* objects with op->nrof require this check */ 1529 if (i == 0) /* objects with op->nrof require this check */
1597 return op; 1530 return op;
1598 1531
1599 if (i > op->nrof) 1532 if (i > op->nrof)
1612 * IMO, searching through all the players will mostly 1545 * IMO, searching through all the players will mostly
1613 * likely be quicker than following op->env to the map, 1546 * likely be quicker than following op->env to the map,
1614 * and then searching the map for a player. 1547 * and then searching the map for a player.
1615 */ 1548 */
1616 if (!tmp) 1549 if (!tmp)
1617 { 1550 for_all_players (pl)
1618 for (pl = first_player; pl; pl = pl->next)
1619 if (pl->ob->container == op->env) 1551 if (pl->ob->container == op->env)
1620 { 1552 {
1621 tmp = pl->ob; 1553 tmp = pl->ob;
1622 break; 1554 break;
1623 } 1555 }
1624 }
1625 1556
1626 if (i < op->nrof) 1557 if (i < op->nrof)
1627 { 1558 {
1628 sub_weight (op->env, op->weight * i); 1559 sub_weight (op->env, op->weight * i);
1629 op->nrof -= i; 1560 op->nrof -= i;
1765 add_weight (this, (op->weight + op->carrying)); 1696 add_weight (this, (op->weight + op->carrying));
1766 1697
1767 otmp = this->in_player (); 1698 otmp = this->in_player ();
1768 if (otmp && otmp->contr) 1699 if (otmp && otmp->contr)
1769 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1700 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1770 fix_player (otmp); 1701 otmp->update_stats ();
1771 1702
1772 op->map = 0; 1703 op->map = 0;
1773 op->env = this; 1704 op->env = this;
1774 op->above = 0; 1705 op->above = 0;
1775 op->below = 0; 1706 op->below = 0;
1779 if ((op->glow_radius != 0) && map) 1710 if ((op->glow_radius != 0) && map)
1780 { 1711 {
1781#ifdef DEBUG_LIGHTS 1712#ifdef DEBUG_LIGHTS
1782 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1713 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1783#endif /* DEBUG_LIGHTS */ 1714#endif /* DEBUG_LIGHTS */
1784 if (MAP_DARKNESS (map)) 1715 if (map->darkness)
1785 update_all_los (map, x, y); 1716 update_all_los (map, x, y);
1786 } 1717 }
1787 1718
1788 /* Client has no idea of ordering so lets not bother ordering it here. 1719 /* Client has no idea of ordering so lets not bother ordering it here.
1789 * It sure simplifies this function... 1720 * It sure simplifies this function...
1794 { 1725 {
1795 op->below = inv; 1726 op->below = inv;
1796 op->below->above = op; 1727 op->below->above = op;
1797 inv = op; 1728 inv = op;
1798 } 1729 }
1730
1731 INVOKE_OBJECT (INSERT, this);
1799 1732
1800 return op; 1733 return op;
1801} 1734}
1802 1735
1803/* 1736/*
1818 * 1751 *
1819 * MSW 2001-07-08: Check all objects on space, not just those below 1752 * MSW 2001-07-08: Check all objects on space, not just those below
1820 * object being inserted. insert_ob_in_map may not put new objects 1753 * object being inserted. insert_ob_in_map may not put new objects
1821 * on top. 1754 * on top.
1822 */ 1755 */
1823
1824int 1756int
1825check_move_on (object *op, object *originator) 1757check_move_on (object *op, object *originator)
1826{ 1758{
1827 object *tmp; 1759 object *tmp;
1828 maptile *m = op->map; 1760 maptile *m = op->map;
1855 1787
1856 /* The objects have to be checked from top to bottom. 1788 /* The objects have to be checked from top to bottom.
1857 * Hence, we first go to the top: 1789 * Hence, we first go to the top:
1858 */ 1790 */
1859 1791
1860 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1792 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1861 { 1793 {
1862 /* Trim the search when we find the first other spell effect 1794 /* Trim the search when we find the first other spell effect
1863 * this helps performance so that if a space has 50 spell objects, 1795 * this helps performance so that if a space has 50 spell objects,
1864 * we don't need to check all of them. 1796 * we don't need to check all of them.
1865 */ 1797 */
1920/* 1852/*
1921 * present_arch(arch, map, x, y) searches for any objects with 1853 * present_arch(arch, map, x, y) searches for any objects with
1922 * a matching archetype at the given map and coordinates. 1854 * a matching archetype at the given map and coordinates.
1923 * The first matching object is returned, or NULL if none. 1855 * The first matching object is returned, or NULL if none.
1924 */ 1856 */
1925
1926object * 1857object *
1927present_arch (const archetype *at, maptile *m, int x, int y) 1858present_arch (const archetype *at, maptile *m, int x, int y)
1928{ 1859{
1929 object *
1930 tmp;
1931
1932 if (m == NULL || out_of_map (m, x, y)) 1860 if (!m || out_of_map (m, x, y))
1933 { 1861 {
1934 LOG (llevError, "Present_arch called outside map.\n"); 1862 LOG (llevError, "Present_arch called outside map.\n");
1935 return NULL; 1863 return NULL;
1936 } 1864 }
1937 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1865
1866 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1938 if (tmp->arch == at) 1867 if (tmp->arch == at)
1939 return tmp; 1868 return tmp;
1869
1940 return NULL; 1870 return NULL;
1941} 1871}
1942 1872
1943/* 1873/*
1944 * present(type, map, x, y) searches for any objects with 1874 * present(type, map, x, y) searches for any objects with
1945 * a matching type variable at the given map and coordinates. 1875 * a matching type variable at the given map and coordinates.
1946 * The first matching object is returned, or NULL if none. 1876 * The first matching object is returned, or NULL if none.
1947 */ 1877 */
1948
1949object * 1878object *
1950present (unsigned char type, maptile *m, int x, int y) 1879present (unsigned char type, maptile *m, int x, int y)
1951{ 1880{
1952 object *
1953 tmp;
1954
1955 if (out_of_map (m, x, y)) 1881 if (out_of_map (m, x, y))
1956 { 1882 {
1957 LOG (llevError, "Present called outside map.\n"); 1883 LOG (llevError, "Present called outside map.\n");
1958 return NULL; 1884 return NULL;
1959 } 1885 }
1960 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1886
1887 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1961 if (tmp->type == type) 1888 if (tmp->type == type)
1962 return tmp; 1889 return tmp;
1890
1963 return NULL; 1891 return NULL;
1964} 1892}
1965 1893
1966/* 1894/*
1967 * present_in_ob(type, object) searches for any objects with 1895 * present_in_ob(type, object) searches for any objects with
1968 * a matching type variable in the inventory of the given object. 1896 * a matching type variable in the inventory of the given object.
1969 * The first matching object is returned, or NULL if none. 1897 * The first matching object is returned, or NULL if none.
1970 */ 1898 */
1971
1972object * 1899object *
1973present_in_ob (unsigned char type, const object *op) 1900present_in_ob (unsigned char type, const object *op)
1974{ 1901{
1975 object *
1976 tmp;
1977
1978 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1902 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1979 if (tmp->type == type) 1903 if (tmp->type == type)
1980 return tmp; 1904 return tmp;
1905
1981 return NULL; 1906 return NULL;
1982} 1907}
1983 1908
1984/* 1909/*
1985 * present_in_ob (type, str, object) searches for any objects with 1910 * present_in_ob (type, str, object) searches for any objects with
1993 * str is the string to match against. Note that we match against 1918 * str is the string to match against. Note that we match against
1994 * the object name, not the archetype name. this is so that the 1919 * the object name, not the archetype name. this is so that the
1995 * spell code can use one object type (force), but change it's name 1920 * spell code can use one object type (force), but change it's name
1996 * to be unique. 1921 * to be unique.
1997 */ 1922 */
1998
1999object * 1923object *
2000present_in_ob_by_name (int type, const char *str, const object *op) 1924present_in_ob_by_name (int type, const char *str, const object *op)
2001{ 1925{
2002 object *
2003 tmp;
2004
2005 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1926 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2006 {
2007 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1927 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2008 return tmp; 1928 return tmp;
2009 } 1929
2010 return NULL; 1930 return 0;
2011} 1931}
2012 1932
2013/* 1933/*
2014 * present_arch_in_ob(archetype, object) searches for any objects with 1934 * present_arch_in_ob(archetype, object) searches for any objects with
2015 * a matching archetype in the inventory of the given object. 1935 * a matching archetype in the inventory of the given object.
2016 * The first matching object is returned, or NULL if none. 1936 * The first matching object is returned, or NULL if none.
2017 */ 1937 */
2018
2019object * 1938object *
2020present_arch_in_ob (const archetype *at, const object *op) 1939present_arch_in_ob (const archetype *at, const object *op)
2021{ 1940{
2022 object *
2023 tmp;
2024
2025 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1941 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2026 if (tmp->arch == at) 1942 if (tmp->arch == at)
2027 return tmp; 1943 return tmp;
1944
2028 return NULL; 1945 return NULL;
2029} 1946}
2030 1947
2031/* 1948/*
2032 * activate recursively a flag on an object inventory 1949 * activate recursively a flag on an object inventory
2033 */ 1950 */
2034void 1951void
2035flag_inv (object *op, int flag) 1952flag_inv (object *op, int flag)
2036{ 1953{
2037 object *
2038 tmp;
2039
2040 if (op->inv) 1954 if (op->inv)
2041 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1955 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2042 { 1956 {
2043 SET_FLAG (tmp, flag); 1957 SET_FLAG (tmp, flag);
2044 flag_inv (tmp, flag); 1958 flag_inv (tmp, flag);
2045 } 1959 }
2046} /* 1960}
1961
1962/*
2047 * desactivate recursively a flag on an object inventory 1963 * deactivate recursively a flag on an object inventory
2048 */ 1964 */
2049void 1965void
2050unflag_inv (object *op, int flag) 1966unflag_inv (object *op, int flag)
2051{ 1967{
2052 object *
2053 tmp;
2054
2055 if (op->inv) 1968 if (op->inv)
2056 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1969 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2057 { 1970 {
2058 CLEAR_FLAG (tmp, flag); 1971 CLEAR_FLAG (tmp, flag);
2059 unflag_inv (tmp, flag); 1972 unflag_inv (tmp, flag);
2060 } 1973 }
2061} 1974}
2064 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1977 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2065 * all it's inventory (recursively). 1978 * all it's inventory (recursively).
2066 * If checksums are used, a player will get set_cheat called for 1979 * If checksums are used, a player will get set_cheat called for
2067 * him/her-self and all object carried by a call to this function. 1980 * him/her-self and all object carried by a call to this function.
2068 */ 1981 */
2069
2070void 1982void
2071set_cheat (object *op) 1983set_cheat (object *op)
2072{ 1984{
2073 SET_FLAG (op, FLAG_WAS_WIZ); 1985 SET_FLAG (op, FLAG_WAS_WIZ);
2074 flag_inv (op, FLAG_WAS_WIZ); 1986 flag_inv (op, FLAG_WAS_WIZ);
2093 * because arch_blocked (now ob_blocked) needs to know the movement type 2005 * because arch_blocked (now ob_blocked) needs to know the movement type
2094 * to know if the space in question will block the object. We can't use 2006 * to know if the space in question will block the object. We can't use
2095 * the archetype because that isn't correct if the monster has been 2007 * the archetype because that isn't correct if the monster has been
2096 * customized, changed states, etc. 2008 * customized, changed states, etc.
2097 */ 2009 */
2098
2099int 2010int
2100find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2011find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2101{ 2012{
2102 int
2103 i,
2104 index = 0, flag; 2013 int index = 0, flag;
2105 static int
2106 altern[SIZEOFFREE]; 2014 int altern[SIZEOFFREE];
2107 2015
2108 for (i = start; i < stop; i++) 2016 for (int i = start; i < stop; i++)
2109 { 2017 {
2110 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2018 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2111 if (!flag) 2019 if (!flag)
2112 altern[index++] = i; 2020 altern [index++] = i;
2113 2021
2114 /* Basically, if we find a wall on a space, we cut down the search size. 2022 /* Basically, if we find a wall on a space, we cut down the search size.
2115 * In this way, we won't return spaces that are on another side of a wall. 2023 * In this way, we won't return spaces that are on another side of a wall.
2116 * This mostly work, but it cuts down the search size in all directions - 2024 * This mostly work, but it cuts down the search size in all directions -
2117 * if the space being examined only has a wall to the north and empty 2025 * if the space being examined only has a wall to the north and empty
2133 * find_first_free_spot(archetype, maptile, x, y) works like 2041 * find_first_free_spot(archetype, maptile, x, y) works like
2134 * find_free_spot(), but it will search max number of squares. 2042 * find_free_spot(), but it will search max number of squares.
2135 * But it will return the first available spot, not a random choice. 2043 * But it will return the first available spot, not a random choice.
2136 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2044 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2137 */ 2045 */
2138
2139int 2046int
2140find_first_free_spot (const object *ob, maptile *m, int x, int y) 2047find_first_free_spot (const object *ob, maptile *m, int x, int y)
2141{ 2048{
2142 int
2143 i;
2144
2145 for (i = 0; i < SIZEOFFREE; i++) 2049 for (int i = 0; i < SIZEOFFREE; i++)
2146 {
2147 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2050 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2148 return i; 2051 return i;
2149 } 2052
2150 return -1; 2053 return -1;
2151} 2054}
2152 2055
2153/* 2056/*
2154 * The function permute(arr, begin, end) randomly reorders the array 2057 * The function permute(arr, begin, end) randomly reorders the array
2155 * arr[begin..end-1]. 2058 * arr[begin..end-1].
2059 * now uses a fisher-yates shuffle, old permute was broken
2156 */ 2060 */
2157static void 2061static void
2158permute (int *arr, int begin, int end) 2062permute (int *arr, int begin, int end)
2159{ 2063{
2160 int 2064 arr += begin;
2161 i,
2162 j,
2163 tmp,
2164 len;
2165
2166 len = end - begin; 2065 end -= begin;
2167 for (i = begin; i < end; i++)
2168 {
2169 j = begin + RANDOM () % len;
2170 2066
2171 tmp = arr[i]; 2067 while (--end)
2172 arr[i] = arr[j]; 2068 swap (arr [end], arr [RANDOM () % (end + 1)]);
2173 arr[j] = tmp;
2174 }
2175} 2069}
2176 2070
2177/* new function to make monster searching more efficient, and effective! 2071/* new function to make monster searching more efficient, and effective!
2178 * This basically returns a randomized array (in the passed pointer) of 2072 * This basically returns a randomized array (in the passed pointer) of
2179 * the spaces to find monsters. In this way, it won't always look for 2073 * the spaces to find monsters. In this way, it won't always look for
2182 * the 3x3 area will be searched, just not in a predictable order. 2076 * the 3x3 area will be searched, just not in a predictable order.
2183 */ 2077 */
2184void 2078void
2185get_search_arr (int *search_arr) 2079get_search_arr (int *search_arr)
2186{ 2080{
2187 int 2081 int i;
2188 i;
2189 2082
2190 for (i = 0; i < SIZEOFFREE; i++) 2083 for (i = 0; i < SIZEOFFREE; i++)
2191 {
2192 search_arr[i] = i; 2084 search_arr[i] = i;
2193 }
2194 2085
2195 permute (search_arr, 1, SIZEOFFREE1 + 1); 2086 permute (search_arr, 1, SIZEOFFREE1 + 1);
2196 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2087 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2197 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2088 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2198} 2089}
2207 * Perhaps incorrectly, but I'm making the assumption that exclude 2098 * Perhaps incorrectly, but I'm making the assumption that exclude
2208 * is actually want is going to try and move there. We need this info 2099 * is actually want is going to try and move there. We need this info
2209 * because we have to know what movement the thing looking to move 2100 * because we have to know what movement the thing looking to move
2210 * there is capable of. 2101 * there is capable of.
2211 */ 2102 */
2212
2213int 2103int
2214find_dir (maptile *m, int x, int y, object *exclude) 2104find_dir (maptile *m, int x, int y, object *exclude)
2215{ 2105{
2216 int
2217 i,
2218 max = SIZEOFFREE, mflags; 2106 int i, max = SIZEOFFREE, mflags;
2219 2107
2220 sint16 nx, ny; 2108 sint16 nx, ny;
2221 object * 2109 object *tmp;
2222 tmp;
2223 maptile * 2110 maptile *mp;
2224 mp;
2225 2111
2226 MoveType blocked, move_type; 2112 MoveType blocked, move_type;
2227 2113
2228 if (exclude && exclude->head) 2114 if (exclude && exclude->head)
2229 { 2115 {
2241 mp = m; 2127 mp = m;
2242 nx = x + freearr_x[i]; 2128 nx = x + freearr_x[i];
2243 ny = y + freearr_y[i]; 2129 ny = y + freearr_y[i];
2244 2130
2245 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2131 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2132
2246 if (mflags & P_OUT_OF_MAP) 2133 if (mflags & P_OUT_OF_MAP)
2247 {
2248 max = maxfree[i]; 2134 max = maxfree[i];
2249 }
2250 else 2135 else
2251 { 2136 {
2252 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2137 mapspace &ms = mp->at (nx, ny);
2138
2139 blocked = ms.move_block;
2253 2140
2254 if ((move_type & blocked) == move_type) 2141 if ((move_type & blocked) == move_type)
2255 {
2256 max = maxfree[i]; 2142 max = maxfree[i];
2257 }
2258 else if (mflags & P_IS_ALIVE) 2143 else if (mflags & P_IS_ALIVE)
2259 { 2144 {
2260 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2145 for (tmp = ms.bot; tmp; tmp = tmp->above)
2261 { 2146 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2262 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2147 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2263 {
2264 break; 2148 break;
2265 } 2149
2266 }
2267 if (tmp) 2150 if (tmp)
2268 {
2269 return freedir[i]; 2151 return freedir[i];
2270 }
2271 } 2152 }
2272 } 2153 }
2273 } 2154 }
2155
2274 return 0; 2156 return 0;
2275} 2157}
2276 2158
2277/* 2159/*
2278 * distance(object 1, object 2) will return the square of the 2160 * distance(object 1, object 2) will return the square of the
2279 * distance between the two given objects. 2161 * distance between the two given objects.
2280 */ 2162 */
2281
2282int 2163int
2283distance (const object *ob1, const object *ob2) 2164distance (const object *ob1, const object *ob2)
2284{ 2165{
2285 int
2286 i;
2287
2288 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2166 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2289 return i;
2290} 2167}
2291 2168
2292/* 2169/*
2293 * find_dir_2(delta-x,delta-y) will return a direction in which 2170 * find_dir_2(delta-x,delta-y) will return a direction in which
2294 * an object which has subtracted the x and y coordinates of another 2171 * an object which has subtracted the x and y coordinates of another
2295 * object, needs to travel toward it. 2172 * object, needs to travel toward it.
2296 */ 2173 */
2297
2298int 2174int
2299find_dir_2 (int x, int y) 2175find_dir_2 (int x, int y)
2300{ 2176{
2301 int 2177 int q;
2302 q;
2303 2178
2304 if (y) 2179 if (y)
2305 q = x * 100 / y; 2180 q = x * 100 / y;
2306 else if (x) 2181 else if (x)
2307 q = -300 * x; 2182 q = -300 * x;
2342int 2217int
2343absdir (int d) 2218absdir (int d)
2344{ 2219{
2345 while (d < 1) 2220 while (d < 1)
2346 d += 8; 2221 d += 8;
2222
2347 while (d > 8) 2223 while (d > 8)
2348 d -= 8; 2224 d -= 8;
2225
2349 return d; 2226 return d;
2350} 2227}
2351 2228
2352/* 2229/*
2353 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2230 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2355 */ 2232 */
2356 2233
2357int 2234int
2358dirdiff (int dir1, int dir2) 2235dirdiff (int dir1, int dir2)
2359{ 2236{
2360 int 2237 int d;
2361 d;
2362 2238
2363 d = abs (dir1 - dir2); 2239 d = abs (dir1 - dir2);
2364 if (d > 4) 2240 if (d > 4)
2365 d = 8 - d; 2241 d = 8 - d;
2242
2366 return d; 2243 return d;
2367} 2244}
2368 2245
2369/* peterm: 2246/* peterm:
2370 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2247 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2373 * This basically means that if direction is 15, then it could either go 2250 * This basically means that if direction is 15, then it could either go
2374 * direction 4, 14, or 16 to get back to where we are. 2251 * direction 4, 14, or 16 to get back to where we are.
2375 * Moved from spell_util.c to object.c with the other related direction 2252 * Moved from spell_util.c to object.c with the other related direction
2376 * functions. 2253 * functions.
2377 */ 2254 */
2378
2379int
2380 reduction_dir[SIZEOFFREE][3] = { 2255int reduction_dir[SIZEOFFREE][3] = {
2381 {0, 0, 0}, /* 0 */ 2256 {0, 0, 0}, /* 0 */
2382 {0, 0, 0}, /* 1 */ 2257 {0, 0, 0}, /* 1 */
2383 {0, 0, 0}, /* 2 */ 2258 {0, 0, 0}, /* 2 */
2384 {0, 0, 0}, /* 3 */ 2259 {0, 0, 0}, /* 3 */
2385 {0, 0, 0}, /* 4 */ 2260 {0, 0, 0}, /* 4 */
2433 * find a path to that monster that we found. If not, 2308 * find a path to that monster that we found. If not,
2434 * we don't bother going toward it. Returns 1 if we 2309 * we don't bother going toward it. Returns 1 if we
2435 * can see a direct way to get it 2310 * can see a direct way to get it
2436 * Modified to be map tile aware -.MSW 2311 * Modified to be map tile aware -.MSW
2437 */ 2312 */
2438
2439
2440int 2313int
2441can_see_monsterP (maptile *m, int x, int y, int dir) 2314can_see_monsterP (maptile *m, int x, int y, int dir)
2442{ 2315{
2443 sint16 dx, dy; 2316 sint16 dx, dy;
2444 int
2445 mflags; 2317 int mflags;
2446 2318
2447 if (dir < 0) 2319 if (dir < 0)
2448 return 0; /* exit condition: invalid direction */ 2320 return 0; /* exit condition: invalid direction */
2449 2321
2450 dx = x + freearr_x[dir]; 2322 dx = x + freearr_x[dir];
2463 return 0; 2335 return 0;
2464 2336
2465 /* yes, can see. */ 2337 /* yes, can see. */
2466 if (dir < 9) 2338 if (dir < 9)
2467 return 1; 2339 return 1;
2340
2468 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2341 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2469 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2342 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2343 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2470} 2344}
2471
2472
2473 2345
2474/* 2346/*
2475 * can_pick(picker, item): finds out if an object is possible to be 2347 * can_pick(picker, item): finds out if an object is possible to be
2476 * picked up by the picker. Returnes 1 if it can be 2348 * picked up by the picker. Returnes 1 if it can be
2477 * picked up, otherwise 0. 2349 * picked up, otherwise 0.
2488 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2360 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2489 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2361 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2490 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2362 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2491} 2363}
2492 2364
2493
2494/* 2365/*
2495 * create clone from object to another 2366 * create clone from object to another
2496 */ 2367 */
2497object * 2368object *
2498object_create_clone (object *asrc) 2369object_create_clone (object *asrc)
2517 { 2388 {
2518 dst = tmp; 2389 dst = tmp;
2519 tmp->head = 0; 2390 tmp->head = 0;
2520 } 2391 }
2521 else 2392 else
2522 {
2523 tmp->head = dst; 2393 tmp->head = dst;
2524 }
2525 2394
2526 tmp->more = 0; 2395 tmp->more = 0;
2527 2396
2528 if (prev) 2397 if (prev)
2529 prev->more = tmp; 2398 prev->more = tmp;
2541/* Basically, we save the content of the string to a temp file, then call */ 2410/* Basically, we save the content of the string to a temp file, then call */
2542/* load_object on it. I admit it is a highly inefficient way to make things, */ 2411/* load_object on it. I admit it is a highly inefficient way to make things, */
2543/* but it was simple to make and allows reusing the load_object function. */ 2412/* but it was simple to make and allows reusing the load_object function. */
2544/* Remember not to use load_object_str in a time-critical situation. */ 2413/* Remember not to use load_object_str in a time-critical situation. */
2545/* Also remember that multiparts objects are not supported for now. */ 2414/* Also remember that multiparts objects are not supported for now. */
2546
2547object * 2415object *
2548load_object_str (const char *obstr) 2416load_object_str (const char *obstr)
2549{ 2417{
2550 object *op; 2418 object *op;
2551 char filename[MAX_BUF]; 2419 char filename[MAX_BUF];
2581 * returns NULL if no match. 2449 * returns NULL if no match.
2582 */ 2450 */
2583object * 2451object *
2584find_obj_by_type_subtype (const object *who, int type, int subtype) 2452find_obj_by_type_subtype (const object *who, int type, int subtype)
2585{ 2453{
2586 object *tmp;
2587
2588 for (tmp = who->inv; tmp; tmp = tmp->below) 2454 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2589 if (tmp->type == type && tmp->subtype == subtype) 2455 if (tmp->type == type && tmp->subtype == subtype)
2590 return tmp; 2456 return tmp;
2591 2457
2592 return NULL; 2458 return 0;
2593} 2459}
2594 2460
2595/* If ob has a field named key, return the link from the list, 2461/* If ob has a field named key, return the link from the list,
2596 * otherwise return NULL. 2462 * otherwise return NULL.
2597 * 2463 *
2599 * do the desired thing. 2465 * do the desired thing.
2600 */ 2466 */
2601key_value * 2467key_value *
2602get_ob_key_link (const object *ob, const char *key) 2468get_ob_key_link (const object *ob, const char *key)
2603{ 2469{
2604 key_value *link;
2605
2606 for (link = ob->key_values; link != NULL; link = link->next) 2470 for (key_value *link = ob->key_values; link; link = link->next)
2607 if (link->key == key) 2471 if (link->key == key)
2608 return link; 2472 return link;
2609 2473
2610 return NULL; 2474 return 0;
2611} 2475}
2612 2476
2613/* 2477/*
2614 * Returns the value of op has an extra_field for key, or NULL. 2478 * Returns the value of op has an extra_field for key, or NULL.
2615 * 2479 *
2655 * Returns TRUE on success. 2519 * Returns TRUE on success.
2656 */ 2520 */
2657int 2521int
2658set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2522set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2659{ 2523{
2660 key_value *
2661 field = NULL, *last = NULL; 2524 key_value *field = NULL, *last = NULL;
2662 2525
2663 for (field = op->key_values; field != NULL; field = field->next) 2526 for (field = op->key_values; field != NULL; field = field->next)
2664 { 2527 {
2665 if (field->key != canonical_key) 2528 if (field->key != canonical_key)
2666 { 2529 {
2694 /* IF we get here, key doesn't exist */ 2557 /* IF we get here, key doesn't exist */
2695 2558
2696 /* No field, we'll have to add it. */ 2559 /* No field, we'll have to add it. */
2697 2560
2698 if (!add_key) 2561 if (!add_key)
2699 {
2700 return FALSE; 2562 return FALSE;
2701 } 2563
2702 /* There isn't any good reason to store a null 2564 /* There isn't any good reason to store a null
2703 * value in the key/value list. If the archetype has 2565 * value in the key/value list. If the archetype has
2704 * this key, then we should also have it, so shouldn't 2566 * this key, then we should also have it, so shouldn't
2705 * be here. If user wants to store empty strings, 2567 * be here. If user wants to store empty strings,
2706 * should pass in "" 2568 * should pass in ""
2755 } 2617 }
2756 else 2618 else
2757 item = item->env; 2619 item = item->env;
2758} 2620}
2759 2621
2622
2623const char *
2624object::flag_desc (char *desc, int len) const
2625{
2626 char *p = desc;
2627 bool first = true;
2628
2629 *p = 0;
2630
2631 for (int i = 0; i < NUM_FLAGS; i++)
2632 {
2633 if (len <= 10) // magic constant!
2634 {
2635 snprintf (p, len, ",...");
2636 break;
2637 }
2638
2639 if (flag [i])
2640 {
2641 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2642 len -= cnt;
2643 p += cnt;
2644 first = false;
2645 }
2646 }
2647
2648 return desc;
2649}
2650
2760// return a suitable string describing an objetc in enough detail to find it 2651// return a suitable string describing an object in enough detail to find it
2761const char * 2652const char *
2762object::debug_desc (char *info) const 2653object::debug_desc (char *info) const
2763{ 2654{
2655 char flagdesc[512];
2764 char info2[256 * 3]; 2656 char info2[256 * 4];
2765 char *p = info; 2657 char *p = info;
2766 2658
2767 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2659 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2768 count, 2660 count, uuid.seq,
2769 &name, 2661 &name,
2770 title ? " " : "", 2662 title ? "\",title:" : "",
2771 title ? (const char *)title : ""); 2663 title ? (const char *)title : "",
2664 flag_desc (flagdesc, 512), type);
2772 2665
2773 if (env) 2666 if (env)
2774 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2667 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2775 2668
2776 if (map) 2669 if (map)
2777 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2670 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2778 2671
2779 return info; 2672 return info;
2780} 2673}
2781 2674
2782const char * 2675const char *
2783object::debug_desc () const 2676object::debug_desc () const
2784{ 2677{
2785 static char info[256 * 3]; 2678 static char info[256 * 4];
2786 return debug_desc (info); 2679 return debug_desc (info);
2787} 2680}
2788 2681

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines