ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.78 by root, Fri Dec 22 16:34:00 2006 UTC vs.
Revision 1.119 by root, Fri Jan 19 18:06:51 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
36 37
37int nrofallocobjects = 0; 38int nrofallocobjects = 0;
38static UUID uuid; 39static UUID uuid;
39const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
40 41
41object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
42 44
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 47};
46short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
141 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
143 */ 145 */
144 146
145 /* For each field in wants, */ 147 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 149 {
148 key_value *has_field; 150 key_value *has_field;
149 151
150 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
190 * Check nrof variable *before* calling can_merge() 192 * Check nrof variable *before* calling can_merge()
191 * 193 *
192 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
193 * check weight 195 * check weight
194 */ 196 */
195
196bool object::can_merge_slow (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
197{ 198{
198 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
199 if (ob1 == ob2 200 if (ob1 == ob2
200 || ob1->type != ob2->type 201 || ob1->type != ob2->type
221 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222 223
223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225 226
226 if ((ob1->flags ^ ob2->flags).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
227 || ob1->arch != ob2->arch 228 || ob1->arch != ob2->arch
228 || ob1->name != ob2->name 229 || ob1->name != ob2->name
229 || ob1->title != ob2->title 230 || ob1->title != ob2->title
230 || ob1->msg != ob2->msg 231 || ob1->msg != ob2->msg
231 || ob1->weight != ob2->weight 232 || ob1->weight != ob2->weight
277 278
278 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
279 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
280 * check? 281 * check?
281 */ 282 */
282 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
283 return 0; 284 return 0;
284 285
285 switch (ob1->type) 286 switch (ob1->type)
286 { 287 {
287 case SCROLL: 288 case SCROLL:
364{ 365{
365 if (!op) 366 if (!op)
366 return strdup ("[NULLOBJ]"); 367 return strdup ("[NULLOBJ]");
367 368
368 object_freezer freezer; 369 object_freezer freezer;
369 save_object (freezer, op, 3); 370 save_object (freezer, op, 1);
370 return freezer.as_string (); 371 return freezer.as_string ();
371} 372}
372 373
373/* 374/*
374 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
391} 392}
392 393
393/* 394/*
394 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
395 */ 396 */
396
397object * 397object *
398find_object (tag_t i) 398find_object (tag_t i)
399{ 399{
400 for (object *op = object::first; op; op = op->next) 400 for_all_objects (op)
401 if (op->count == i) 401 if (op->count == i)
402 return op; 402 return op;
403 403
404 return 0; 404 return 0;
405} 405}
406 406
407/* 407/*
408 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
409 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
410 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
411 */ 411 */
412
413object * 412object *
414find_object_name (const char *str) 413find_object_name (const char *str)
415{ 414{
416 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
417 object *op; 416 object *op;
418 417
419 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
420 if (op->name == str_) 419 if (op->name == str_)
421 break; 420 break;
422 421
423 return op; 422 return op;
424} 423}
482{ 481{
483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
485 484
486 *(object_copy *)dst = *this; 485 *(object_copy *)dst = *this;
487 *(object_pod *)dst = *this;
488
489 if (self || cb)
490 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
491 486
492 if (is_freed) 487 if (is_freed)
493 SET_FLAG (dst, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
494 489
495 if (is_removed) 490 if (is_removed)
496 SET_FLAG (dst, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
497 492
498 if (speed < 0) 493 if (speed < 0)
499 dst->speed_left = speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
500 495
501 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
502 if (key_values) 497 if (key_values)
503 { 498 {
504 key_value *tail = 0; 499 key_value *tail = 0;
526 tail = new_link; 521 tail = new_link;
527 } 522 }
528 } 523 }
529 } 524 }
530 525
531 update_ob_speed (dst); 526 dst->set_speed (dst->speed);
532} 527}
533 528
534object * 529object *
535object::clone () 530object::clone ()
536{ 531{
542/* 537/*
543 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
544 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
545 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
546 */ 541 */
547
548void 542void
549update_turn_face (object *op) 543update_turn_face (object *op)
550{ 544{
551 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
552 return; 546 return;
547
553 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
554 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
555} 550}
556 551
557/* 552/*
558 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
559 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
560 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
561 */ 556 */
562void 557void
563update_ob_speed (object *op) 558object::set_speed (float speed)
564{ 559{
565 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
566
567 /* No reason putting the archetypes objects on the speed list,
568 * since they never really need to be updated.
569 */
570
571 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
572 { 561 {
573 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
574#ifdef MANY_CORES
575 abort ();
576#else
577 op->speed = 0; 563 speed = 0;
578#endif
579 }
580
581 if (arch_init)
582 return;
583
584 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
585 { 564 }
586 /* If already on active list, don't do anything */
587 if (op->active_next || op->active_prev || op == active_objects)
588 return;
589 565
590 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
591 * of the list. */
592 op->active_next = active_objects;
593 567
594 if (op->active_next != NULL) 568 if (has_active_speed ())
595 op->active_next->active_prev = op; 569 activate ();
596
597 active_objects = op;
598 }
599 else 570 else
600 { 571 deactivate ();
601 /* If not on the active list, nothing needs to be done */
602 if (!op->active_next && !op->active_prev && op != active_objects)
603 return;
604
605 if (op->active_prev == NULL)
606 {
607 active_objects = op->active_next;
608
609 if (op->active_next != NULL)
610 op->active_next->active_prev = NULL;
611 }
612 else
613 {
614 op->active_prev->active_next = op->active_next;
615
616 if (op->active_next)
617 op->active_next->active_prev = op->active_prev;
618 }
619
620 op->active_next = NULL;
621 op->active_prev = NULL;
622 }
623}
624
625/* This function removes object 'op' from the list of active
626 * objects.
627 * This should only be used for style maps or other such
628 * reference maps where you don't want an object that isn't
629 * in play chewing up cpu time getting processed.
630 * The reverse of this is to call update_ob_speed, which
631 * will do the right thing based on the speed of the object.
632 */
633void
634remove_from_active_list (object *op)
635{
636 /* If not on the active list, nothing needs to be done */
637 if (!op->active_next && !op->active_prev && op != active_objects)
638 return;
639
640 if (op->active_prev == NULL)
641 {
642 active_objects = op->active_next;
643 if (op->active_next != NULL)
644 op->active_next->active_prev = NULL;
645 }
646 else
647 {
648 op->active_prev->active_next = op->active_next;
649 if (op->active_next)
650 op->active_next->active_prev = op->active_prev;
651 }
652 op->active_next = NULL;
653 op->active_prev = NULL;
654} 572}
655 573
656/* 574/*
657 * update_object() updates the the map. 575 * update_object() updates the the map.
658 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
695 */ 613 */
696 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
697 return; 615 return;
698 616
699 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
700 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
701 { 619 {
702 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
703#ifdef MANY_CORES 621#ifdef MANY_CORES
704 abort (); 622 abort ();
705#endif 623#endif
706 return; 624 return;
707 } 625 }
708 626
709 mapspace &m = op->ms (); 627 mapspace &m = op->ms ();
710 628
711 if (m.flags_ & P_NEED_UPDATE) 629 if (!(m.flags_ & P_UPTODATE))
712 /* nop */; 630 /* nop */;
713 else if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
714 { 632 {
715 // this is likely overkill, TODO: revisit (schmorp) 633 // this is likely overkill, TODO: revisit (schmorp)
716 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
725 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
726 * to have move_allow right now. 644 * to have move_allow right now.
727 */ 645 */
728 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
729 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
730 m.flags_ = P_NEED_UPDATE; 648 m.flags_ = 0;
731 } 649 }
732 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
733 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
734 * that is being removed. 652 * that is being removed.
735 */ 653 */
736 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
737 m.flags_ = P_NEED_UPDATE; 655 m.flags_ = 0;
738 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
739 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
740 else 658 else
741 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
742 660
743 if (op->more) 661 if (op->more)
744 update_object (op->more, action); 662 update_object (op->more, action);
745} 663}
746 664
747object::vector object::mortals;
748object::vector object::objects; // not yet used
749object *object::first;
750
751void object::free_mortals ()
752{
753 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
754 if ((*i)->refcnt)
755 ++i; // further delay freeing
756 else
757 {
758 delete *i;
759 mortals.erase (i);
760 }
761}
762
763object::object () 665object::object ()
764{ 666{
765 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
766 668
767 expmul = 1.0; 669 expmul = 1.0;
768 face = blank_face; 670 face = blank_face;
769} 671}
770 672
771object::~object () 673object::~object ()
772{ 674{
675 if (index)
676 unlink ();
677
773 free_key_values (this); 678 free_key_values (this);
774} 679}
775 680
681static int object_count;
682
776void object::link () 683void object::link ()
777{ 684{
778 count = ++ob_count; 685 assert (!index);//D
779 uuid = gen_uuid (); 686 uuid = gen_uuid ();
687 count = ++object_count;
780 688
781 prev = 0; 689 refcnt_inc ();
782 next = object::first; 690 objects.insert (this);
783
784 if (object::first)
785 object::first->prev = this;
786
787 object::first = this;
788} 691}
789 692
790void object::unlink () 693void object::unlink ()
791{ 694{
792 if (this == object::first) 695 assert (index);//D
793 object::first = next; 696 objects.erase (this);
697 refcnt_dec ();
698}
794 699
795 /* Remove this object from the list of used objects */ 700void
796 if (prev) prev->next = next; 701object::activate ()
797 if (next) next->prev = prev; 702{
703 /* If already on active list, don't do anything */
704 if (active)
705 return;
798 706
799 prev = 0; 707 if (has_active_speed ())
800 next = 0; 708 actives.insert (this);
709}
710
711void
712object::activate_recursive ()
713{
714 activate ();
715
716 for (object *op = inv; op; op = op->below)
717 op->activate_recursive ();
718}
719
720/* This function removes object 'op' from the list of active
721 * objects.
722 * This should only be used for style maps or other such
723 * reference maps where you don't want an object that isn't
724 * in play chewing up cpu time getting processed.
725 * The reverse of this is to call update_ob_speed, which
726 * will do the right thing based on the speed of the object.
727 */
728void
729object::deactivate ()
730{
731 /* If not on the active list, nothing needs to be done */
732 if (!active)
733 return;
734
735 actives.erase (this);
736}
737
738void
739object::deactivate_recursive ()
740{
741 for (object *op = inv; op; op = op->below)
742 op->deactivate_recursive ();
743
744 deactivate ();
745}
746
747void
748object::set_flag_inv (int flag, int value)
749{
750 for (object *op = inv; op; op = op->below)
751 {
752 op->flag [flag] = value;
753 op->set_flag_inv (flag, value);
754 }
755}
756
757/*
758 * Remove and free all objects in the inventory of the given object.
759 * object.c ?
760 */
761void
762object::destroy_inv (bool drop_to_ground)
763{
764 // need to check first, because the checks below might segfault
765 // as we might be on an invalid mapspace and crossfire code
766 // is too buggy to ensure that the inventory is empty.
767 // corollary: if you create arrows etc. with stuff in tis inventory,
768 // cf will crash below with off-map x and y
769 if (!inv)
770 return;
771
772 /* Only if the space blocks everything do we not process -
773 * if some form of movement is allowed, let objects
774 * drop on that space.
775 */
776 if (!drop_to_ground
777 || !map
778 || map->in_memory != MAP_IN_MEMORY
779 || ms ().move_block == MOVE_ALL)
780 {
781 while (inv)
782 {
783 inv->destroy_inv (drop_to_ground);
784 inv->destroy ();
785 }
786 }
787 else
788 { /* Put objects in inventory onto this space */
789 while (inv)
790 {
791 object *op = inv;
792
793 if (op->flag [FLAG_STARTEQUIP]
794 || op->flag [FLAG_NO_DROP]
795 || op->type == RUNE
796 || op->type == TRAP
797 || op->flag [FLAG_IS_A_TEMPLATE]
798 || op->flag [FLAG_DESTROY_ON_DEATH])
799 op->destroy ();
800 else
801 map->insert (op, x, y);
802 }
803 }
801} 804}
802 805
803object *object::create () 806object *object::create ()
804{ 807{
805 object *op = new object; 808 object *op = new object;
806 op->link (); 809 op->link ();
807 return op; 810 return op;
808} 811}
809 812
810/* 813void
811 * free_object() frees everything allocated by an object, removes 814object::do_destroy ()
812 * it from the list of used objects, and puts it on the list of
813 * free objects. The IS_FREED() flag is set in the object.
814 * The object must have been removed by remove_ob() first for
815 * this function to succeed.
816 *
817 * If destroy_inventory is set, free inventory as well. Else drop items in
818 * inventory to the ground.
819 */
820void object::destroy (bool destroy_inventory)
821{ 815{
822 if (QUERY_FLAG (this, FLAG_FREED)) 816 attachable::do_destroy ();
823 return;
824 817
825 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 818 if (flag [FLAG_IS_LINKED])
819 remove_button_link (this);
820
821 if (flag [FLAG_FRIENDLY])
826 remove_friendly_object (this); 822 remove_friendly_object (this);
827 823
828 if (!QUERY_FLAG (this, FLAG_REMOVED)) 824 if (!flag [FLAG_REMOVED])
829 remove (); 825 remove ();
830 826
831 SET_FLAG (this, FLAG_FREED); 827 destroy_inv (true);
832 828
833 if (more) 829 deactivate ();
834 { 830 unlink ();
835 more->destroy (destroy_inventory);
836 more = 0;
837 }
838 831
839 if (inv) 832 flag [FLAG_FREED] = 1;
840 {
841 /* Only if the space blocks everything do we not process -
842 * if some form of movement is allowed, let objects
843 * drop on that space.
844 */
845 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
846 {
847 object *op = inv;
848
849 while (op)
850 {
851 object *tmp = op->below;
852 op->destroy (destroy_inventory);
853 op = tmp;
854 }
855 }
856 else
857 { /* Put objects in inventory onto this space */
858 object *op = inv;
859
860 while (op)
861 {
862 object *tmp = op->below;
863
864 op->remove ();
865
866 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
867 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
868 op->destroy ();
869 else
870 {
871 op->x = x;
872 op->y = y;
873 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
874 }
875
876 op = tmp;
877 }
878 }
879 }
880 833
881 // hack to ensure that freed objects still have a valid map 834 // hack to ensure that freed objects still have a valid map
882 { 835 {
883 static maptile *freed_map; // freed objects are moved here to avoid crashes 836 static maptile *freed_map; // freed objects are moved here to avoid crashes
884 837
888 841
889 freed_map->name = "/internal/freed_objects_map"; 842 freed_map->name = "/internal/freed_objects_map";
890 freed_map->width = 3; 843 freed_map->width = 3;
891 freed_map->height = 3; 844 freed_map->height = 3;
892 845
893 freed_map->allocate (); 846 freed_map->alloc ();
847 freed_map->in_memory = MAP_IN_MEMORY;
894 } 848 }
895 849
896 map = freed_map; 850 map = freed_map;
897 x = 1; 851 x = 1;
898 y = 1; 852 y = 1;
899 } 853 }
900 854
855 head = 0;
856
857 if (more)
858 {
859 more->destroy ();
860 more = 0;
861 }
862
901 // clear those pointers that likely might have circular references to us 863 // clear those pointers that likely might have circular references to us
902 owner = 0; 864 owner = 0;
903 enemy = 0; 865 enemy = 0;
904 attacked_by = 0; 866 attacked_by = 0;
867}
905 868
906 // only relevant for players(?), but make sure of it anyways 869void
907 contr = 0; 870object::destroy (bool destroy_inventory)
871{
872 if (destroyed ())
873 return;
908 874
909 /* Remove object from the active list */ 875 if (destroy_inventory)
910 speed = 0; 876 destroy_inv (false);
911 update_ob_speed (this);
912 877
913 unlink (); 878 attachable::destroy ();
914
915 mortals.push_back (this);
916} 879}
917 880
918/* 881/*
919 * sub_weight() recursively (outwards) subtracts a number from the 882 * sub_weight() recursively (outwards) subtracts a number from the
920 * weight of an object (and what is carried by it's environment(s)). 883 * weight of an object (and what is carried by it's environment(s)).
939 * environment, the x and y coordinates will be updated to 902 * environment, the x and y coordinates will be updated to
940 * the previous environment. 903 * the previous environment.
941 * Beware: This function is called from the editor as well! 904 * Beware: This function is called from the editor as well!
942 */ 905 */
943void 906void
944object::remove () 907object::remove_slow ()
945{ 908{
946 object *tmp, *last = 0; 909 object *tmp, *last = 0;
947 object *otmp; 910 object *otmp;
948 911
949 int check_walk_off;
950
951 if (QUERY_FLAG (this, FLAG_REMOVED)) 912 if (QUERY_FLAG (this, FLAG_REMOVED))
952 return; 913 return;
953 914
954 SET_FLAG (this, FLAG_REMOVED); 915 SET_FLAG (this, FLAG_REMOVED);
916 INVOKE_OBJECT (REMOVE, this);
955 917
956 if (more) 918 if (more)
957 more->remove (); 919 more->remove ();
958 920
959 /* 921 /*
972 * to save cpu time. 934 * to save cpu time.
973 */ 935 */
974 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 936 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
975 otmp->update_stats (); 937 otmp->update_stats ();
976 938
977 if (above != NULL) 939 if (above)
978 above->below = below; 940 above->below = below;
979 else 941 else
980 env->inv = below; 942 env->inv = below;
981 943
982 if (below != NULL) 944 if (below)
983 below->above = above; 945 below->above = above;
984 946
985 /* we set up values so that it could be inserted into 947 /* we set up values so that it could be inserted into
986 * the map, but we don't actually do that - it is up 948 * the map, but we don't actually do that - it is up
987 * to the caller to decide what we want to do. 949 * to the caller to decide what we want to do.
991 above = 0, below = 0; 953 above = 0, below = 0;
992 env = 0; 954 env = 0;
993 } 955 }
994 else if (map) 956 else if (map)
995 { 957 {
996 /* Re did the following section of code - it looks like it had 958 if (type == PLAYER)
997 * lots of logic for things we no longer care about
998 */ 959 {
960 --map->players;
961 map->touch ();
962 }
963
964 map->dirty = true;
965 mapspace &ms = this->ms ();
999 966
1000 /* link the object above us */ 967 /* link the object above us */
1001 if (above) 968 if (above)
1002 above->below = below; 969 above->below = below;
1003 else 970 else
1004 map->at (x, y).top = below; /* we were top, set new top */ 971 ms.top = below; /* we were top, set new top */
1005 972
1006 /* Relink the object below us, if there is one */ 973 /* Relink the object below us, if there is one */
1007 if (below) 974 if (below)
1008 below->above = above; 975 below->above = above;
1009 else 976 else
1011 /* Nothing below, which means we need to relink map object for this space 978 /* Nothing below, which means we need to relink map object for this space
1012 * use translated coordinates in case some oddness with map tiling is 979 * use translated coordinates in case some oddness with map tiling is
1013 * evident 980 * evident
1014 */ 981 */
1015 if (GET_MAP_OB (map, x, y) != this) 982 if (GET_MAP_OB (map, x, y) != this)
1016 {
1017 char *dump = dump_object (this);
1018 LOG (llevError,
1019 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 983 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1020 free (dump);
1021 dump = dump_object (GET_MAP_OB (map, x, y));
1022 LOG (llevError, "%s\n", dump);
1023 free (dump);
1024 }
1025 984
1026 map->at (x, y).bottom = above; /* goes on above it. */ 985 ms.bot = above; /* goes on above it. */
1027 } 986 }
1028 987
1029 above = 0; 988 above = 0;
1030 below = 0; 989 below = 0;
1031 990
1032 if (map->in_memory == MAP_SAVING) 991 if (map->in_memory == MAP_SAVING)
1033 return; 992 return;
1034 993
1035 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 994 int check_walk_off = !flag [FLAG_NO_APPLY];
1036 995
1037 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 996 for (tmp = ms.bot; tmp; tmp = tmp->above)
1038 { 997 {
1039 /* No point updating the players look faces if he is the object 998 /* No point updating the players look faces if he is the object
1040 * being removed. 999 * being removed.
1041 */ 1000 */
1042 1001
1046 * removed (most likely destroyed), update the player view 1005 * removed (most likely destroyed), update the player view
1047 * appropriately. 1006 * appropriately.
1048 */ 1007 */
1049 if (tmp->container == this) 1008 if (tmp->container == this)
1050 { 1009 {
1051 CLEAR_FLAG (this, FLAG_APPLIED); 1010 flag [FLAG_APPLIED] = 0;
1052 tmp->container = 0; 1011 tmp->container = 0;
1053 } 1012 }
1054 1013
1014 if (tmp->contr->ns)
1055 tmp->contr->ns->floorbox_update (); 1015 tmp->contr->ns->floorbox_update ();
1056 } 1016 }
1057 1017
1058 /* See if player moving off should effect something */ 1018 /* See if object moving off should effect something */
1059 if (check_walk_off 1019 if (check_walk_off
1060 && ((move_type & tmp->move_off) 1020 && ((move_type & tmp->move_off)
1061 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1021 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1062 { 1022 {
1063 move_apply (tmp, this, 0); 1023 move_apply (tmp, this, 0);
1065 if (destroyed ()) 1025 if (destroyed ())
1066 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1026 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1067 } 1027 }
1068 1028
1069 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1029 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1070 1030 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1071 if (tmp->above == tmp) 1031 if (tmp->above == tmp)
1072 tmp->above = 0; 1032 tmp->above = 0;
1073 1033
1074 last = tmp; 1034 last = tmp;
1075 } 1035 }
1076 1036
1077 /* last == NULL of there are no objects on this space */ 1037 /* last == NULL if there are no objects on this space */
1038 //TODO: this makes little sense, why only update the topmost object?
1078 if (!last) 1039 if (!last)
1079 map->at (x, y).flags_ = P_NEED_UPDATE; 1040 map->at (x, y).flags_ = 0;
1080 else 1041 else
1081 update_object (last, UP_OBJ_REMOVE); 1042 update_object (last, UP_OBJ_REMOVE);
1082 1043
1083 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1044 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1084 update_all_los (map, x, y); 1045 update_all_los (map, x, y);
1085 } 1046 }
1086} 1047}
1087 1048
1088/* 1049/*
1097merge_ob (object *op, object *top) 1058merge_ob (object *op, object *top)
1098{ 1059{
1099 if (!op->nrof) 1060 if (!op->nrof)
1100 return 0; 1061 return 0;
1101 1062
1102 if (top == NULL) 1063 if (top)
1103 for (top = op; top != NULL && top->above != NULL; top = top->above); 1064 for (top = op; top && top->above; top = top->above)
1065 ;
1104 1066
1105 for (; top != NULL; top = top->below) 1067 for (; top; top = top->below)
1106 { 1068 {
1107 if (top == op) 1069 if (top == op)
1108 continue; 1070 continue;
1109 1071
1110 if (object::can_merge (op, top)) 1072 if (object::can_merge (op, top))
1120 1082
1121 return 0; 1083 return 0;
1122} 1084}
1123 1085
1124/* 1086/*
1125 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1087 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1126 * job preparing multi-part monsters 1088 * job preparing multi-part monsters.
1127 */ 1089 */
1128object * 1090object *
1129insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1091insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1130{ 1092{
1131 object *tmp;
1132
1133 if (op->head)
1134 op = op->head;
1135
1136 for (tmp = op; tmp; tmp = tmp->more) 1093 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1137 { 1094 {
1138 tmp->x = x + tmp->arch->clone.x; 1095 tmp->x = x + tmp->arch->clone.x;
1139 tmp->y = y + tmp->arch->clone.y; 1096 tmp->y = y + tmp->arch->clone.y;
1140 } 1097 }
1141 1098
1160 * Return value: 1117 * Return value:
1161 * new object if 'op' was merged with other object 1118 * new object if 'op' was merged with other object
1162 * NULL if 'op' was destroyed 1119 * NULL if 'op' was destroyed
1163 * just 'op' otherwise 1120 * just 'op' otherwise
1164 */ 1121 */
1165
1166object * 1122object *
1167insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1123insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1168{ 1124{
1169 object *tmp, *top, *floor = NULL; 1125 object *tmp, *top, *floor = NULL;
1170 sint16 x, y;
1171 1126
1172 if (QUERY_FLAG (op, FLAG_FREED)) 1127 if (QUERY_FLAG (op, FLAG_FREED))
1173 { 1128 {
1174 LOG (llevError, "Trying to insert freed object!\n"); 1129 LOG (llevError, "Trying to insert freed object!\n");
1175 return NULL; 1130 return NULL;
1176 } 1131 }
1177 1132
1178 if (m == NULL) 1133 if (!QUERY_FLAG (op, FLAG_REMOVED))
1134 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1135
1136 op->remove ();
1137
1138 if (!m)
1179 { 1139 {
1180 char *dump = dump_object (op); 1140 char *dump = dump_object (op);
1181 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1141 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1182 free (dump); 1142 free (dump);
1183 return op; 1143 return op;
1196#endif 1156#endif
1197 free (dump); 1157 free (dump);
1198 return op; 1158 return op;
1199 } 1159 }
1200 1160
1201 if (!QUERY_FLAG (op, FLAG_REMOVED))
1202 {
1203 char *dump = dump_object (op);
1204 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1205 free (dump);
1206 return op;
1207 }
1208
1209 if (op->more != NULL)
1210 {
1211 /* The part may be on a different map. */
1212
1213 object *more = op->more; 1161 if (object *more = op->more)
1214 1162 {
1215 /* We really need the caller to normalize coordinates - if
1216 * we set the map, that doesn't work if the location is within
1217 * a map and this is straddling an edge. So only if coordinate
1218 * is clear wrong do we normalize it.
1219 */
1220 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1221 more->map = get_map_from_coord (m, &more->x, &more->y);
1222 else if (!more->map)
1223 {
1224 /* For backwards compatibility - when not dealing with tiled maps,
1225 * more->map should always point to the parent.
1226 */
1227 more->map = m;
1228 }
1229
1230 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1163 if (!insert_ob_in_map (more, m, originator, flag))
1231 { 1164 {
1232 if (!op->head) 1165 if (!op->head)
1233 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1166 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1234 1167
1235 return NULL; 1168 return 0;
1236 } 1169 }
1237 } 1170 }
1238 1171
1239 CLEAR_FLAG (op, FLAG_REMOVED); 1172 CLEAR_FLAG (op, FLAG_REMOVED);
1240 1173
1241 /* Ideally, the caller figures this out. However, it complicates a lot 1174 /* Ideally, the caller figures this out. However, it complicates a lot
1242 * of areas of callers (eg, anything that uses find_free_spot would now 1175 * of areas of callers (eg, anything that uses find_free_spot would now
1243 * need extra work 1176 * need extra work
1244 */ 1177 */
1245 op->map = get_map_from_coord (m, &op->x, &op->y); 1178 if (!xy_normalise (m, op->x, op->y))
1246 x = op->x; 1179 return 0;
1247 y = op->y; 1180
1181 op->map = m;
1182 mapspace &ms = op->ms ();
1248 1183
1249 /* this has to be done after we translate the coordinates. 1184 /* this has to be done after we translate the coordinates.
1250 */ 1185 */
1251 if (op->nrof && !(flag & INS_NO_MERGE)) 1186 if (op->nrof && !(flag & INS_NO_MERGE))
1252 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1187 for (tmp = ms.bot; tmp; tmp = tmp->above)
1253 if (object::can_merge (op, tmp)) 1188 if (object::can_merge (op, tmp))
1254 { 1189 {
1255 op->nrof += tmp->nrof; 1190 op->nrof += tmp->nrof;
1256 tmp->destroy (); 1191 tmp->destroy ();
1257 } 1192 }
1274 op->below = originator->below; 1209 op->below = originator->below;
1275 1210
1276 if (op->below) 1211 if (op->below)
1277 op->below->above = op; 1212 op->below->above = op;
1278 else 1213 else
1279 op->ms ().bottom = op; 1214 ms.bot = op;
1280 1215
1281 /* since *below* originator, no need to update top */ 1216 /* since *below* originator, no need to update top */
1282 originator->below = op; 1217 originator->below = op;
1283 } 1218 }
1284 else 1219 else
1285 { 1220 {
1221 top = ms.bot;
1222
1286 /* If there are other objects, then */ 1223 /* If there are other objects, then */
1287 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1224 if ((!(flag & INS_MAP_LOAD)) && top)
1288 { 1225 {
1289 object *last = NULL; 1226 object *last = 0;
1290 1227
1291 /* 1228 /*
1292 * If there are multiple objects on this space, we do some trickier handling. 1229 * If there are multiple objects on this space, we do some trickier handling.
1293 * We've already dealt with merging if appropriate. 1230 * We've already dealt with merging if appropriate.
1294 * Generally, we want to put the new object on top. But if 1231 * Generally, we want to put the new object on top. But if
1298 * once we get to them. This reduces the need to traverse over all of 1235 * once we get to them. This reduces the need to traverse over all of
1299 * them when adding another one - this saves quite a bit of cpu time 1236 * them when adding another one - this saves quite a bit of cpu time
1300 * when lots of spells are cast in one area. Currently, it is presumed 1237 * when lots of spells are cast in one area. Currently, it is presumed
1301 * that flying non pickable objects are spell objects. 1238 * that flying non pickable objects are spell objects.
1302 */ 1239 */
1303 1240 for (top = ms.bot; top; top = top->above)
1304 while (top != NULL)
1305 { 1241 {
1306 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1242 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1307 floor = top; 1243 floor = top;
1308 1244
1309 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1245 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1312 top = top->below; 1248 top = top->below;
1313 break; 1249 break;
1314 } 1250 }
1315 1251
1316 last = top; 1252 last = top;
1317 top = top->above;
1318 } 1253 }
1319 1254
1320 /* Don't want top to be NULL, so set it to the last valid object */ 1255 /* Don't want top to be NULL, so set it to the last valid object */
1321 top = last; 1256 top = last;
1322 1257
1329 * Unless those objects are exits, type 66 1264 * Unless those objects are exits, type 66
1330 * If INS_ON_TOP is used, don't do this processing 1265 * If INS_ON_TOP is used, don't do this processing
1331 * Need to find the object that in fact blocks view, otherwise 1266 * Need to find the object that in fact blocks view, otherwise
1332 * stacking is a bit odd. 1267 * stacking is a bit odd.
1333 */ 1268 */
1334 if (!(flag & INS_ON_TOP) && 1269 if (!(flag & INS_ON_TOP)
1335 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1270 && ms.flags () & P_BLOCKSVIEW
1271 && (op->face && !op->face->visibility))
1336 { 1272 {
1337 for (last = top; last != floor; last = last->below) 1273 for (last = top; last != floor; last = last->below)
1338 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1274 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1339 break; 1275 break;
1276
1340 /* Check to see if we found the object that blocks view, 1277 /* Check to see if we found the object that blocks view,
1341 * and make sure we have a below pointer for it so that 1278 * and make sure we have a below pointer for it so that
1342 * we can get inserted below this one, which requires we 1279 * we can get inserted below this one, which requires we
1343 * set top to the object below us. 1280 * set top to the object below us.
1344 */ 1281 */
1346 top = last->below; 1283 top = last->below;
1347 } 1284 }
1348 } /* If objects on this space */ 1285 } /* If objects on this space */
1349 1286
1350 if (flag & INS_MAP_LOAD) 1287 if (flag & INS_MAP_LOAD)
1351 top = GET_MAP_TOP (op->map, op->x, op->y); 1288 top = ms.top;
1352 1289
1353 if (flag & INS_ABOVE_FLOOR_ONLY) 1290 if (flag & INS_ABOVE_FLOOR_ONLY)
1354 top = floor; 1291 top = floor;
1355 1292
1356 /* Top is the object that our object (op) is going to get inserted above. 1293 /* Top is the object that our object (op) is going to get inserted above.
1357 */ 1294 */
1358 1295
1359 /* First object on this space */ 1296 /* First object on this space */
1360 if (!top) 1297 if (!top)
1361 { 1298 {
1362 op->above = GET_MAP_OB (op->map, op->x, op->y); 1299 op->above = ms.bot;
1363 1300
1364 if (op->above) 1301 if (op->above)
1365 op->above->below = op; 1302 op->above->below = op;
1366 1303
1367 op->below = NULL; 1304 op->below = 0;
1368 op->ms ().bottom = op; 1305 ms.bot = op;
1369 } 1306 }
1370 else 1307 else
1371 { /* get inserted into the stack above top */ 1308 { /* get inserted into the stack above top */
1372 op->above = top->above; 1309 op->above = top->above;
1373 1310
1376 1313
1377 op->below = top; 1314 op->below = top;
1378 top->above = op; 1315 top->above = op;
1379 } 1316 }
1380 1317
1381 if (op->above == NULL) 1318 if (!op->above)
1382 op->ms ().top = op; 1319 ms.top = op;
1383 } /* else not INS_BELOW_ORIGINATOR */ 1320 } /* else not INS_BELOW_ORIGINATOR */
1384 1321
1385 if (op->type == PLAYER) 1322 if (op->type == PLAYER)
1323 {
1386 op->contr->do_los = 1; 1324 op->contr->do_los = 1;
1325 ++op->map->players;
1326 op->map->touch ();
1327 }
1328
1329 op->map->dirty = true;
1387 1330
1388 /* If we have a floor, we know the player, if any, will be above 1331 /* If we have a floor, we know the player, if any, will be above
1389 * it, so save a few ticks and start from there. 1332 * it, so save a few ticks and start from there.
1390 */ 1333 */
1391 if (!(flag & INS_MAP_LOAD)) 1334 if (!(flag & INS_MAP_LOAD))
1392 if (object *pl = op->ms ().player ()) 1335 if (object *pl = ms.player ())
1336 if (pl->contr->ns)
1393 pl->contr->ns->floorbox_update (); 1337 pl->contr->ns->floorbox_update ();
1394 1338
1395 /* If this object glows, it may affect lighting conditions that are 1339 /* If this object glows, it may affect lighting conditions that are
1396 * visible to others on this map. But update_all_los is really 1340 * visible to others on this map. But update_all_los is really
1397 * an inefficient way to do this, as it means los for all players 1341 * an inefficient way to do this, as it means los for all players
1398 * on the map will get recalculated. The players could very well 1342 * on the map will get recalculated. The players could very well
1399 * be far away from this change and not affected in any way - 1343 * be far away from this change and not affected in any way -
1400 * this should get redone to only look for players within range, 1344 * this should get redone to only look for players within range,
1401 * or just updating the P_NEED_UPDATE for spaces within this area 1345 * or just updating the P_UPTODATE for spaces within this area
1402 * of effect may be sufficient. 1346 * of effect may be sufficient.
1403 */ 1347 */
1404 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1348 if (op->map->darkness && (op->glow_radius != 0))
1405 update_all_los (op->map, op->x, op->y); 1349 update_all_los (op->map, op->x, op->y);
1406 1350
1407 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1351 /* updates flags (blocked, alive, no magic, etc) for this map space */
1408 update_object (op, UP_OBJ_INSERT); 1352 update_object (op, UP_OBJ_INSERT);
1353
1354 INVOKE_OBJECT (INSERT, op);
1409 1355
1410 /* Don't know if moving this to the end will break anything. However, 1356 /* Don't know if moving this to the end will break anything. However,
1411 * we want to have floorbox_update called before calling this. 1357 * we want to have floorbox_update called before calling this.
1412 * 1358 *
1413 * check_move_on() must be after this because code called from 1359 * check_move_on() must be after this because code called from
1418 1364
1419 /* if this is not the head or flag has been passed, don't check walk on status */ 1365 /* if this is not the head or flag has been passed, don't check walk on status */
1420 if (!(flag & INS_NO_WALK_ON) && !op->head) 1366 if (!(flag & INS_NO_WALK_ON) && !op->head)
1421 { 1367 {
1422 if (check_move_on (op, originator)) 1368 if (check_move_on (op, originator))
1423 return NULL; 1369 return 0;
1424 1370
1425 /* If we are a multi part object, lets work our way through the check 1371 /* If we are a multi part object, lets work our way through the check
1426 * walk on's. 1372 * walk on's.
1427 */ 1373 */
1428 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1374 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1429 if (check_move_on (tmp, originator)) 1375 if (check_move_on (tmp, originator))
1430 return NULL; 1376 return 0;
1431 } 1377 }
1432 1378
1433 return op; 1379 return op;
1434} 1380}
1435 1381
1442{ 1388{
1443 object *tmp, *tmp1; 1389 object *tmp, *tmp1;
1444 1390
1445 /* first search for itself and remove any old instances */ 1391 /* first search for itself and remove any old instances */
1446 1392
1447 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1393 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1448 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1394 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1449 tmp->destroy (); 1395 tmp->destroy ();
1450 1396
1451 tmp1 = arch_to_object (archetype::find (arch_string)); 1397 tmp1 = arch_to_object (archetype::find (arch_string));
1452 1398
1453 tmp1->x = op->x; 1399 tmp1->x = op->x;
1454 tmp1->y = op->y; 1400 tmp1->y = op->y;
1455 insert_ob_in_map (tmp1, op->map, op, 0); 1401 insert_ob_in_map (tmp1, op->map, op, 0);
1402}
1403
1404object *
1405object::insert_at (object *where, object *originator, int flags)
1406{
1407 where->map->insert (this, where->x, where->y, originator, flags);
1456} 1408}
1457 1409
1458/* 1410/*
1459 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1411 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1460 * is returned contains nr objects, and the remaining parts contains 1412 * is returned contains nr objects, and the remaining parts contains
1461 * the rest (or is removed and freed if that number is 0). 1413 * the rest (or is removed and freed if that number is 0).
1462 * On failure, NULL is returned, and the reason put into the 1414 * On failure, NULL is returned, and the reason put into the
1463 * global static errmsg array. 1415 * global static errmsg array.
1464 */ 1416 */
1465
1466object * 1417object *
1467get_split_ob (object *orig_ob, uint32 nr) 1418get_split_ob (object *orig_ob, uint32 nr)
1468{ 1419{
1469 object *newob; 1420 object *newob;
1470 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1421 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1506 1457
1507object * 1458object *
1508decrease_ob_nr (object *op, uint32 i) 1459decrease_ob_nr (object *op, uint32 i)
1509{ 1460{
1510 object *tmp; 1461 object *tmp;
1511 player *pl;
1512 1462
1513 if (i == 0) /* objects with op->nrof require this check */ 1463 if (i == 0) /* objects with op->nrof require this check */
1514 return op; 1464 return op;
1515 1465
1516 if (i > op->nrof) 1466 if (i > op->nrof)
1529 * IMO, searching through all the players will mostly 1479 * IMO, searching through all the players will mostly
1530 * likely be quicker than following op->env to the map, 1480 * likely be quicker than following op->env to the map,
1531 * and then searching the map for a player. 1481 * and then searching the map for a player.
1532 */ 1482 */
1533 if (!tmp) 1483 if (!tmp)
1534 { 1484 for_all_players (pl)
1535 for (pl = first_player; pl; pl = pl->next)
1536 if (pl->ob->container == op->env) 1485 if (pl->ob->container == op->env)
1537 { 1486 {
1538 tmp = pl->ob; 1487 tmp = pl->ob;
1539 break; 1488 break;
1540 } 1489 }
1541 }
1542 1490
1543 if (i < op->nrof) 1491 if (i < op->nrof)
1544 { 1492 {
1545 sub_weight (op->env, op->weight * i); 1493 sub_weight (op->env, op->weight * i);
1546 op->nrof -= i; 1494 op->nrof -= i;
1696 if ((op->glow_radius != 0) && map) 1644 if ((op->glow_radius != 0) && map)
1697 { 1645 {
1698#ifdef DEBUG_LIGHTS 1646#ifdef DEBUG_LIGHTS
1699 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1647 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1700#endif /* DEBUG_LIGHTS */ 1648#endif /* DEBUG_LIGHTS */
1701 if (MAP_DARKNESS (map)) 1649 if (map->darkness)
1702 update_all_los (map, x, y); 1650 update_all_los (map, x, y);
1703 } 1651 }
1704 1652
1705 /* Client has no idea of ordering so lets not bother ordering it here. 1653 /* Client has no idea of ordering so lets not bother ordering it here.
1706 * It sure simplifies this function... 1654 * It sure simplifies this function...
1711 { 1659 {
1712 op->below = inv; 1660 op->below = inv;
1713 op->below->above = op; 1661 op->below->above = op;
1714 inv = op; 1662 inv = op;
1715 } 1663 }
1664
1665 INVOKE_OBJECT (INSERT, this);
1716 1666
1717 return op; 1667 return op;
1718} 1668}
1719 1669
1720/* 1670/*
1735 * 1685 *
1736 * MSW 2001-07-08: Check all objects on space, not just those below 1686 * MSW 2001-07-08: Check all objects on space, not just those below
1737 * object being inserted. insert_ob_in_map may not put new objects 1687 * object being inserted. insert_ob_in_map may not put new objects
1738 * on top. 1688 * on top.
1739 */ 1689 */
1740
1741int 1690int
1742check_move_on (object *op, object *originator) 1691check_move_on (object *op, object *originator)
1743{ 1692{
1744 object *tmp; 1693 object *tmp;
1745 maptile *m = op->map; 1694 maptile *m = op->map;
1772 1721
1773 /* The objects have to be checked from top to bottom. 1722 /* The objects have to be checked from top to bottom.
1774 * Hence, we first go to the top: 1723 * Hence, we first go to the top:
1775 */ 1724 */
1776 1725
1777 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1726 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1778 { 1727 {
1779 /* Trim the search when we find the first other spell effect 1728 /* Trim the search when we find the first other spell effect
1780 * this helps performance so that if a space has 50 spell objects, 1729 * this helps performance so that if a space has 50 spell objects,
1781 * we don't need to check all of them. 1730 * we don't need to check all of them.
1782 */ 1731 */
1837/* 1786/*
1838 * present_arch(arch, map, x, y) searches for any objects with 1787 * present_arch(arch, map, x, y) searches for any objects with
1839 * a matching archetype at the given map and coordinates. 1788 * a matching archetype at the given map and coordinates.
1840 * The first matching object is returned, or NULL if none. 1789 * The first matching object is returned, or NULL if none.
1841 */ 1790 */
1842
1843object * 1791object *
1844present_arch (const archetype *at, maptile *m, int x, int y) 1792present_arch (const archetype *at, maptile *m, int x, int y)
1845{ 1793{
1846 object *
1847 tmp;
1848
1849 if (m == NULL || out_of_map (m, x, y)) 1794 if (!m || out_of_map (m, x, y))
1850 { 1795 {
1851 LOG (llevError, "Present_arch called outside map.\n"); 1796 LOG (llevError, "Present_arch called outside map.\n");
1852 return NULL; 1797 return NULL;
1853 } 1798 }
1854 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1799
1800 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1855 if (tmp->arch == at) 1801 if (tmp->arch == at)
1856 return tmp; 1802 return tmp;
1803
1857 return NULL; 1804 return NULL;
1858} 1805}
1859 1806
1860/* 1807/*
1861 * present(type, map, x, y) searches for any objects with 1808 * present(type, map, x, y) searches for any objects with
1862 * a matching type variable at the given map and coordinates. 1809 * a matching type variable at the given map and coordinates.
1863 * The first matching object is returned, or NULL if none. 1810 * The first matching object is returned, or NULL if none.
1864 */ 1811 */
1865
1866object * 1812object *
1867present (unsigned char type, maptile *m, int x, int y) 1813present (unsigned char type, maptile *m, int x, int y)
1868{ 1814{
1869 object *
1870 tmp;
1871
1872 if (out_of_map (m, x, y)) 1815 if (out_of_map (m, x, y))
1873 { 1816 {
1874 LOG (llevError, "Present called outside map.\n"); 1817 LOG (llevError, "Present called outside map.\n");
1875 return NULL; 1818 return NULL;
1876 } 1819 }
1877 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1820
1821 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1878 if (tmp->type == type) 1822 if (tmp->type == type)
1879 return tmp; 1823 return tmp;
1824
1880 return NULL; 1825 return NULL;
1881} 1826}
1882 1827
1883/* 1828/*
1884 * present_in_ob(type, object) searches for any objects with 1829 * present_in_ob(type, object) searches for any objects with
1885 * a matching type variable in the inventory of the given object. 1830 * a matching type variable in the inventory of the given object.
1886 * The first matching object is returned, or NULL if none. 1831 * The first matching object is returned, or NULL if none.
1887 */ 1832 */
1888
1889object * 1833object *
1890present_in_ob (unsigned char type, const object *op) 1834present_in_ob (unsigned char type, const object *op)
1891{ 1835{
1892 object *
1893 tmp;
1894
1895 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1836 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1896 if (tmp->type == type) 1837 if (tmp->type == type)
1897 return tmp; 1838 return tmp;
1839
1898 return NULL; 1840 return NULL;
1899} 1841}
1900 1842
1901/* 1843/*
1902 * present_in_ob (type, str, object) searches for any objects with 1844 * present_in_ob (type, str, object) searches for any objects with
1910 * str is the string to match against. Note that we match against 1852 * str is the string to match against. Note that we match against
1911 * the object name, not the archetype name. this is so that the 1853 * the object name, not the archetype name. this is so that the
1912 * spell code can use one object type (force), but change it's name 1854 * spell code can use one object type (force), but change it's name
1913 * to be unique. 1855 * to be unique.
1914 */ 1856 */
1915
1916object * 1857object *
1917present_in_ob_by_name (int type, const char *str, const object *op) 1858present_in_ob_by_name (int type, const char *str, const object *op)
1918{ 1859{
1919 object *
1920 tmp;
1921
1922 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1923 {
1924 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1861 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
1925 return tmp; 1862 return tmp;
1926 } 1863
1927 return NULL; 1864 return 0;
1928} 1865}
1929 1866
1930/* 1867/*
1931 * present_arch_in_ob(archetype, object) searches for any objects with 1868 * present_arch_in_ob(archetype, object) searches for any objects with
1932 * a matching archetype in the inventory of the given object. 1869 * a matching archetype in the inventory of the given object.
1933 * The first matching object is returned, or NULL if none. 1870 * The first matching object is returned, or NULL if none.
1934 */ 1871 */
1935
1936object * 1872object *
1937present_arch_in_ob (const archetype *at, const object *op) 1873present_arch_in_ob (const archetype *at, const object *op)
1938{ 1874{
1939 object *
1940 tmp;
1941
1942 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1875 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1943 if (tmp->arch == at) 1876 if (tmp->arch == at)
1944 return tmp; 1877 return tmp;
1878
1945 return NULL; 1879 return NULL;
1946} 1880}
1947 1881
1948/* 1882/*
1949 * activate recursively a flag on an object inventory 1883 * activate recursively a flag on an object inventory
1950 */ 1884 */
1951void 1885void
1952flag_inv (object *op, int flag) 1886flag_inv (object *op, int flag)
1953{ 1887{
1954 object *
1955 tmp;
1956
1957 if (op->inv) 1888 if (op->inv)
1958 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1889 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1959 { 1890 {
1960 SET_FLAG (tmp, flag); 1891 SET_FLAG (tmp, flag);
1961 flag_inv (tmp, flag); 1892 flag_inv (tmp, flag);
1962 } 1893 }
1963} /* 1894}
1895
1896/*
1964 * desactivate recursively a flag on an object inventory 1897 * deactivate recursively a flag on an object inventory
1965 */ 1898 */
1966void 1899void
1967unflag_inv (object *op, int flag) 1900unflag_inv (object *op, int flag)
1968{ 1901{
1969 object *
1970 tmp;
1971
1972 if (op->inv) 1902 if (op->inv)
1973 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1903 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1974 { 1904 {
1975 CLEAR_FLAG (tmp, flag); 1905 CLEAR_FLAG (tmp, flag);
1976 unflag_inv (tmp, flag); 1906 unflag_inv (tmp, flag);
1977 } 1907 }
1978} 1908}
1981 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1911 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
1982 * all it's inventory (recursively). 1912 * all it's inventory (recursively).
1983 * If checksums are used, a player will get set_cheat called for 1913 * If checksums are used, a player will get set_cheat called for
1984 * him/her-self and all object carried by a call to this function. 1914 * him/her-self and all object carried by a call to this function.
1985 */ 1915 */
1986
1987void 1916void
1988set_cheat (object *op) 1917set_cheat (object *op)
1989{ 1918{
1990 SET_FLAG (op, FLAG_WAS_WIZ); 1919 SET_FLAG (op, FLAG_WAS_WIZ);
1991 flag_inv (op, FLAG_WAS_WIZ); 1920 flag_inv (op, FLAG_WAS_WIZ);
2010 * because arch_blocked (now ob_blocked) needs to know the movement type 1939 * because arch_blocked (now ob_blocked) needs to know the movement type
2011 * to know if the space in question will block the object. We can't use 1940 * to know if the space in question will block the object. We can't use
2012 * the archetype because that isn't correct if the monster has been 1941 * the archetype because that isn't correct if the monster has been
2013 * customized, changed states, etc. 1942 * customized, changed states, etc.
2014 */ 1943 */
2015
2016int 1944int
2017find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1945find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2018{ 1946{
2019 int
2020 i,
2021 index = 0, flag; 1947 int index = 0, flag;
2022 static int
2023 altern[SIZEOFFREE]; 1948 int altern[SIZEOFFREE];
2024 1949
2025 for (i = start; i < stop; i++) 1950 for (int i = start; i < stop; i++)
2026 { 1951 {
2027 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1952 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2028 if (!flag) 1953 if (!flag)
2029 altern[index++] = i; 1954 altern [index++] = i;
2030 1955
2031 /* Basically, if we find a wall on a space, we cut down the search size. 1956 /* Basically, if we find a wall on a space, we cut down the search size.
2032 * In this way, we won't return spaces that are on another side of a wall. 1957 * In this way, we won't return spaces that are on another side of a wall.
2033 * This mostly work, but it cuts down the search size in all directions - 1958 * This mostly work, but it cuts down the search size in all directions -
2034 * if the space being examined only has a wall to the north and empty 1959 * if the space being examined only has a wall to the north and empty
2050 * find_first_free_spot(archetype, maptile, x, y) works like 1975 * find_first_free_spot(archetype, maptile, x, y) works like
2051 * find_free_spot(), but it will search max number of squares. 1976 * find_free_spot(), but it will search max number of squares.
2052 * But it will return the first available spot, not a random choice. 1977 * But it will return the first available spot, not a random choice.
2053 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1978 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2054 */ 1979 */
2055
2056int 1980int
2057find_first_free_spot (const object *ob, maptile *m, int x, int y) 1981find_first_free_spot (const object *ob, maptile *m, int x, int y)
2058{ 1982{
2059 int
2060 i;
2061
2062 for (i = 0; i < SIZEOFFREE; i++) 1983 for (int i = 0; i < SIZEOFFREE; i++)
2063 {
2064 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1984 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2065 return i; 1985 return i;
2066 } 1986
2067 return -1; 1987 return -1;
2068} 1988}
2069 1989
2070/* 1990/*
2071 * The function permute(arr, begin, end) randomly reorders the array 1991 * The function permute(arr, begin, end) randomly reorders the array
2072 * arr[begin..end-1]. 1992 * arr[begin..end-1].
1993 * now uses a fisher-yates shuffle, old permute was broken
2073 */ 1994 */
2074static void 1995static void
2075permute (int *arr, int begin, int end) 1996permute (int *arr, int begin, int end)
2076{ 1997{
2077 int 1998 arr += begin;
2078 i,
2079 j,
2080 tmp,
2081 len;
2082
2083 len = end - begin; 1999 end -= begin;
2084 for (i = begin; i < end; i++)
2085 {
2086 j = begin + RANDOM () % len;
2087 2000
2088 tmp = arr[i]; 2001 while (--end)
2089 arr[i] = arr[j]; 2002 swap (arr [end], arr [RANDOM () % (end + 1)]);
2090 arr[j] = tmp;
2091 }
2092} 2003}
2093 2004
2094/* new function to make monster searching more efficient, and effective! 2005/* new function to make monster searching more efficient, and effective!
2095 * This basically returns a randomized array (in the passed pointer) of 2006 * This basically returns a randomized array (in the passed pointer) of
2096 * the spaces to find monsters. In this way, it won't always look for 2007 * the spaces to find monsters. In this way, it won't always look for
2099 * the 3x3 area will be searched, just not in a predictable order. 2010 * the 3x3 area will be searched, just not in a predictable order.
2100 */ 2011 */
2101void 2012void
2102get_search_arr (int *search_arr) 2013get_search_arr (int *search_arr)
2103{ 2014{
2104 int 2015 int i;
2105 i;
2106 2016
2107 for (i = 0; i < SIZEOFFREE; i++) 2017 for (i = 0; i < SIZEOFFREE; i++)
2108 {
2109 search_arr[i] = i; 2018 search_arr[i] = i;
2110 }
2111 2019
2112 permute (search_arr, 1, SIZEOFFREE1 + 1); 2020 permute (search_arr, 1, SIZEOFFREE1 + 1);
2113 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2021 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2114 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2022 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2115} 2023}
2124 * Perhaps incorrectly, but I'm making the assumption that exclude 2032 * Perhaps incorrectly, but I'm making the assumption that exclude
2125 * is actually want is going to try and move there. We need this info 2033 * is actually want is going to try and move there. We need this info
2126 * because we have to know what movement the thing looking to move 2034 * because we have to know what movement the thing looking to move
2127 * there is capable of. 2035 * there is capable of.
2128 */ 2036 */
2129
2130int 2037int
2131find_dir (maptile *m, int x, int y, object *exclude) 2038find_dir (maptile *m, int x, int y, object *exclude)
2132{ 2039{
2133 int
2134 i,
2135 max = SIZEOFFREE, mflags; 2040 int i, max = SIZEOFFREE, mflags;
2136 2041
2137 sint16 nx, ny; 2042 sint16 nx, ny;
2138 object * 2043 object *tmp;
2139 tmp;
2140 maptile * 2044 maptile *mp;
2141 mp;
2142 2045
2143 MoveType blocked, move_type; 2046 MoveType blocked, move_type;
2144 2047
2145 if (exclude && exclude->head) 2048 if (exclude && exclude->head)
2146 { 2049 {
2163 2066
2164 if (mflags & P_OUT_OF_MAP) 2067 if (mflags & P_OUT_OF_MAP)
2165 max = maxfree[i]; 2068 max = maxfree[i];
2166 else 2069 else
2167 { 2070 {
2168 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2071 mapspace &ms = mp->at (nx, ny);
2072
2073 blocked = ms.move_block;
2169 2074
2170 if ((move_type & blocked) == move_type) 2075 if ((move_type & blocked) == move_type)
2171 max = maxfree[i]; 2076 max = maxfree[i];
2172 else if (mflags & P_IS_ALIVE) 2077 else if (mflags & P_IS_ALIVE)
2173 { 2078 {
2174 for (tmp = GET_MAP_OB (mp, nx, ny); tmp; tmp = tmp->above) 2079 for (tmp = ms.bot; tmp; tmp = tmp->above)
2175 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2080 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2081 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2176 break; 2082 break;
2177 2083
2178 if (tmp) 2084 if (tmp)
2179 return freedir[i]; 2085 return freedir[i];
2180 } 2086 }
2186 2092
2187/* 2093/*
2188 * distance(object 1, object 2) will return the square of the 2094 * distance(object 1, object 2) will return the square of the
2189 * distance between the two given objects. 2095 * distance between the two given objects.
2190 */ 2096 */
2191
2192int 2097int
2193distance (const object *ob1, const object *ob2) 2098distance (const object *ob1, const object *ob2)
2194{ 2099{
2195 int i;
2196
2197 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2100 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2198 return i;
2199} 2101}
2200 2102
2201/* 2103/*
2202 * find_dir_2(delta-x,delta-y) will return a direction in which 2104 * find_dir_2(delta-x,delta-y) will return a direction in which
2203 * an object which has subtracted the x and y coordinates of another 2105 * an object which has subtracted the x and y coordinates of another
2204 * object, needs to travel toward it. 2106 * object, needs to travel toward it.
2205 */ 2107 */
2206
2207int 2108int
2208find_dir_2 (int x, int y) 2109find_dir_2 (int x, int y)
2209{ 2110{
2210 int q; 2111 int q;
2211 2112
2240 2141
2241 return 3; 2142 return 3;
2242} 2143}
2243 2144
2244/* 2145/*
2245 * absdir(int): Returns a number between 1 and 8, which represent
2246 * the "absolute" direction of a number (it actually takes care of
2247 * "overflow" in previous calculations of a direction).
2248 */
2249
2250int
2251absdir (int d)
2252{
2253 while (d < 1)
2254 d += 8;
2255 while (d > 8)
2256 d -= 8;
2257 return d;
2258}
2259
2260/*
2261 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2146 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2262 * between two directions (which are expected to be absolute (see absdir()) 2147 * between two directions (which are expected to be absolute (see absdir())
2263 */ 2148 */
2264
2265int 2149int
2266dirdiff (int dir1, int dir2) 2150dirdiff (int dir1, int dir2)
2267{ 2151{
2268 int 2152 int d;
2269 d;
2270 2153
2271 d = abs (dir1 - dir2); 2154 d = abs (dir1 - dir2);
2272 if (d > 4) 2155 if (d > 4)
2273 d = 8 - d; 2156 d = 8 - d;
2157
2274 return d; 2158 return d;
2275} 2159}
2276 2160
2277/* peterm: 2161/* peterm:
2278 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2162 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2281 * This basically means that if direction is 15, then it could either go 2165 * This basically means that if direction is 15, then it could either go
2282 * direction 4, 14, or 16 to get back to where we are. 2166 * direction 4, 14, or 16 to get back to where we are.
2283 * Moved from spell_util.c to object.c with the other related direction 2167 * Moved from spell_util.c to object.c with the other related direction
2284 * functions. 2168 * functions.
2285 */ 2169 */
2286
2287int
2288 reduction_dir[SIZEOFFREE][3] = { 2170int reduction_dir[SIZEOFFREE][3] = {
2289 {0, 0, 0}, /* 0 */ 2171 {0, 0, 0}, /* 0 */
2290 {0, 0, 0}, /* 1 */ 2172 {0, 0, 0}, /* 1 */
2291 {0, 0, 0}, /* 2 */ 2173 {0, 0, 0}, /* 2 */
2292 {0, 0, 0}, /* 3 */ 2174 {0, 0, 0}, /* 3 */
2293 {0, 0, 0}, /* 4 */ 2175 {0, 0, 0}, /* 4 */
2443/* Basically, we save the content of the string to a temp file, then call */ 2325/* Basically, we save the content of the string to a temp file, then call */
2444/* load_object on it. I admit it is a highly inefficient way to make things, */ 2326/* load_object on it. I admit it is a highly inefficient way to make things, */
2445/* but it was simple to make and allows reusing the load_object function. */ 2327/* but it was simple to make and allows reusing the load_object function. */
2446/* Remember not to use load_object_str in a time-critical situation. */ 2328/* Remember not to use load_object_str in a time-critical situation. */
2447/* Also remember that multiparts objects are not supported for now. */ 2329/* Also remember that multiparts objects are not supported for now. */
2448
2449object * 2330object *
2450load_object_str (const char *obstr) 2331load_object_str (const char *obstr)
2451{ 2332{
2452 object *op; 2333 object *op;
2453 char filename[MAX_BUF]; 2334 char filename[MAX_BUF];
2483 * returns NULL if no match. 2364 * returns NULL if no match.
2484 */ 2365 */
2485object * 2366object *
2486find_obj_by_type_subtype (const object *who, int type, int subtype) 2367find_obj_by_type_subtype (const object *who, int type, int subtype)
2487{ 2368{
2488 object *tmp;
2489
2490 for (tmp = who->inv; tmp; tmp = tmp->below) 2369 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2491 if (tmp->type == type && tmp->subtype == subtype) 2370 if (tmp->type == type && tmp->subtype == subtype)
2492 return tmp; 2371 return tmp;
2493 2372
2494 return NULL; 2373 return 0;
2495} 2374}
2496 2375
2497/* If ob has a field named key, return the link from the list, 2376/* If ob has a field named key, return the link from the list,
2498 * otherwise return NULL. 2377 * otherwise return NULL.
2499 * 2378 *
2501 * do the desired thing. 2380 * do the desired thing.
2502 */ 2381 */
2503key_value * 2382key_value *
2504get_ob_key_link (const object *ob, const char *key) 2383get_ob_key_link (const object *ob, const char *key)
2505{ 2384{
2506 key_value *link;
2507
2508 for (link = ob->key_values; link != NULL; link = link->next) 2385 for (key_value *link = ob->key_values; link; link = link->next)
2509 if (link->key == key) 2386 if (link->key == key)
2510 return link; 2387 return link;
2511 2388
2512 return NULL; 2389 return 0;
2513} 2390}
2514 2391
2515/* 2392/*
2516 * Returns the value of op has an extra_field for key, or NULL. 2393 * Returns the value of op has an extra_field for key, or NULL.
2517 * 2394 *
2557 * Returns TRUE on success. 2434 * Returns TRUE on success.
2558 */ 2435 */
2559int 2436int
2560set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2437set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2561{ 2438{
2562 key_value *
2563 field = NULL, *last = NULL; 2439 key_value *field = NULL, *last = NULL;
2564 2440
2565 for (field = op->key_values; field != NULL; field = field->next) 2441 for (field = op->key_values; field != NULL; field = field->next)
2566 { 2442 {
2567 if (field->key != canonical_key) 2443 if (field->key != canonical_key)
2568 { 2444 {
2596 /* IF we get here, key doesn't exist */ 2472 /* IF we get here, key doesn't exist */
2597 2473
2598 /* No field, we'll have to add it. */ 2474 /* No field, we'll have to add it. */
2599 2475
2600 if (!add_key) 2476 if (!add_key)
2601 {
2602 return FALSE; 2477 return FALSE;
2603 } 2478
2604 /* There isn't any good reason to store a null 2479 /* There isn't any good reason to store a null
2605 * value in the key/value list. If the archetype has 2480 * value in the key/value list. If the archetype has
2606 * this key, then we should also have it, so shouldn't 2481 * this key, then we should also have it, so shouldn't
2607 * be here. If user wants to store empty strings, 2482 * be here. If user wants to store empty strings,
2608 * should pass in "" 2483 * should pass in ""
2657 } 2532 }
2658 else 2533 else
2659 item = item->env; 2534 item = item->env;
2660} 2535}
2661 2536
2537
2538const char *
2539object::flag_desc (char *desc, int len) const
2540{
2541 char *p = desc;
2542 bool first = true;
2543
2544 *p = 0;
2545
2546 for (int i = 0; i < NUM_FLAGS; i++)
2547 {
2548 if (len <= 10) // magic constant!
2549 {
2550 snprintf (p, len, ",...");
2551 break;
2552 }
2553
2554 if (flag [i])
2555 {
2556 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2557 len -= cnt;
2558 p += cnt;
2559 first = false;
2560 }
2561 }
2562
2563 return desc;
2564}
2565
2662// return a suitable string describing an objetc in enough detail to find it 2566// return a suitable string describing an object in enough detail to find it
2663const char * 2567const char *
2664object::debug_desc (char *info) const 2568object::debug_desc (char *info) const
2665{ 2569{
2570 char flagdesc[512];
2666 char info2[256 * 3]; 2571 char info2[256 * 4];
2667 char *p = info; 2572 char *p = info;
2668 2573
2669 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2574 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2670 count, 2575 count, uuid.seq,
2671 &name, 2576 &name,
2672 title ? " " : "", 2577 title ? "\",title:\"" : "",
2673 title ? (const char *)title : ""); 2578 title ? (const char *)title : "",
2579 flag_desc (flagdesc, 512), type);
2674 2580
2675 if (env) 2581 if (env)
2676 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2582 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2677 2583
2678 if (map) 2584 if (map)
2679 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2585 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2680 2586
2681 return info; 2587 return info;
2682} 2588}
2683 2589
2684const char * 2590const char *
2685object::debug_desc () const 2591object::debug_desc () const
2686{ 2592{
2687 static char info[256 * 3]; 2593 static char info[256 * 4];
2688 return debug_desc (info); 2594 return debug_desc (info);
2689} 2595}
2690 2596
2597const char *
2598object::debug_desc2 () const
2599{
2600 static char info[256 * 4];
2601 return debug_desc (info);
2602}
2603

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines