ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.82 by root, Mon Dec 25 11:25:49 2006 UTC vs.
Revision 1.145 by root, Mon May 7 03:05:58 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
36 37
37int nrofallocobjects = 0; 38int nrofallocobjects = 0;
38static UUID uuid; 39static UUID uuid;
39const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
40 41
41object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
42 44
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 47};
46short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
141 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
143 */ 145 */
144 146
145 /* For each field in wants, */ 147 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 149 {
148 key_value *has_field; 150 key_value *has_field;
149 151
150 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
190 * Check nrof variable *before* calling can_merge() 192 * Check nrof variable *before* calling can_merge()
191 * 193 *
192 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
193 * check weight 195 * check weight
194 */ 196 */
195
196bool object::can_merge_slow (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
197{ 198{
198 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
199 if (ob1 == ob2 200 if (ob1 == ob2
200 || ob1->type != ob2->type 201 || ob1->type != ob2->type
277 278
278 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
279 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
280 * check? 281 * check?
281 */ 282 */
282 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
283 return 0; 284 return 0;
284 285
285 switch (ob1->type) 286 switch (ob1->type)
286 { 287 {
287 case SCROLL: 288 case SCROLL:
323sum_weight (object *op) 324sum_weight (object *op)
324{ 325{
325 long sum; 326 long sum;
326 object *inv; 327 object *inv;
327 328
328 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 329 for (sum = 0, inv = op->inv; inv; inv = inv->below)
329 { 330 {
330 if (inv->inv) 331 if (inv->inv)
331 sum_weight (inv); 332 sum_weight (inv);
333
332 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 334 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
333 } 335 }
334 336
335 if (op->type == CONTAINER && op->stats.Str) 337 if (op->type == CONTAINER && op->stats.Str)
336 sum = (sum * (100 - op->stats.Str)) / 100; 338 sum = (sum * (100 - op->stats.Str)) / 100;
356/* 358/*
357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 359 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
358 * Some error messages. 360 * Some error messages.
359 * The result of the dump is stored in the static global errmsg array. 361 * The result of the dump is stored in the static global errmsg array.
360 */ 362 */
361
362char * 363char *
363dump_object (object *op) 364dump_object (object *op)
364{ 365{
365 if (!op) 366 if (!op)
366 return strdup ("[NULLOBJ]"); 367 return strdup ("[NULLOBJ]");
367 368
368 object_freezer freezer; 369 object_freezer freezer;
369 save_object (freezer, op, 3); 370 op->write (freezer);
370 return freezer.as_string (); 371 return freezer.as_string ();
371} 372}
372 373
373/* 374/*
374 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
391} 392}
392 393
393/* 394/*
394 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
395 */ 396 */
396
397object * 397object *
398find_object (tag_t i) 398find_object (tag_t i)
399{ 399{
400 for (object *op = object::first; op; op = op->next) 400 for_all_objects (op)
401 if (op->count == i) 401 if (op->count == i)
402 return op; 402 return op;
403 403
404 return 0; 404 return 0;
405} 405}
406 406
407/* 407/*
408 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
409 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
410 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
411 */ 411 */
412
413object * 412object *
414find_object_name (const char *str) 413find_object_name (const char *str)
415{ 414{
416 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
417 object *op; 416 object *op;
418 417
419 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
420 if (op->name == str_) 419 if (op->name == str_)
421 break; 420 break;
422 421
423 return op; 422 return op;
424} 423}
450 owner = owner->owner; 449 owner = owner->owner;
451 450
452 this->owner = owner; 451 this->owner = owner;
453} 452}
454 453
454void
455object::set_weapon (object *ob)
456{
457 if (current_weapon == ob)
458 return;
459
460 current_weapon = ob;
461 new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
462 update_stats ();
463}
464
455/* Zero the key_values on op, decrementing the shared-string 465/* Zero the key_values on op, decrementing the shared-string
456 * refcounts and freeing the links. 466 * refcounts and freeing the links.
457 */ 467 */
458static void 468static void
459free_key_values (object *op) 469free_key_values (object *op)
460{ 470{
461 for (key_value *i = op->key_values; i != 0;) 471 for (key_value *i = op->key_values; i; )
462 { 472 {
463 key_value *next = i->next; 473 key_value *next = i->next;
464 delete i; 474 delete i;
465 475
466 i = next; 476 i = next;
467 } 477 }
468 478
469 op->key_values = 0; 479 op->key_values = 0;
470} 480}
471 481
472/* 482object &
473 * copy_to first frees everything allocated by the dst object, 483object::operator =(const object &src)
474 * and then copies the contents of itself into the second
475 * object, allocating what needs to be allocated. Basically, any
476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
477 * if the first object is freed, the pointers in the new object
478 * will point at garbage.
479 */
480void
481object::copy_to (object *dst)
482{ 484{
483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 485 bool is_freed = flag [FLAG_FREED];
484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 486 bool is_removed = flag [FLAG_REMOVED];
485 487
486 *(object_copy *)dst = *this; 488 *(object_copy *)this = src;
487 489
488 if (is_freed) 490 flag [FLAG_FREED] = is_freed;
489 SET_FLAG (dst, FLAG_FREED); 491 flag [FLAG_REMOVED] = is_removed;
490
491 if (is_removed)
492 SET_FLAG (dst, FLAG_REMOVED);
493
494 if (speed < 0)
495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
496 492
497 /* Copy over key_values, if any. */ 493 /* Copy over key_values, if any. */
498 if (key_values) 494 if (src.key_values)
499 { 495 {
500 key_value *tail = 0; 496 key_value *tail = 0;
501 key_value *i;
502
503 dst->key_values = 0; 497 key_values = 0;
504 498
505 for (i = key_values; i; i = i->next) 499 for (key_value *i = src.key_values; i; i = i->next)
506 { 500 {
507 key_value *new_link = new key_value; 501 key_value *new_link = new key_value;
508 502
509 new_link->next = 0; 503 new_link->next = 0;
510 new_link->key = i->key; 504 new_link->key = i->key;
511 new_link->value = i->value; 505 new_link->value = i->value;
512 506
513 /* Try and be clever here, too. */ 507 /* Try and be clever here, too. */
514 if (!dst->key_values) 508 if (!key_values)
515 { 509 {
516 dst->key_values = new_link; 510 key_values = new_link;
517 tail = new_link; 511 tail = new_link;
518 } 512 }
519 else 513 else
520 { 514 {
521 tail->next = new_link; 515 tail->next = new_link;
522 tail = new_link; 516 tail = new_link;
523 } 517 }
524 } 518 }
525 } 519 }
520}
526 521
527 update_ob_speed (dst); 522/*
523 * copy_to first frees everything allocated by the dst object,
524 * and then copies the contents of itself into the second
525 * object, allocating what needs to be allocated. Basically, any
526 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
527 * if the first object is freed, the pointers in the new object
528 * will point at garbage.
529 */
530void
531object::copy_to (object *dst)
532{
533 *dst = *this;
534
535 if (speed < 0)
536 dst->speed_left = speed_left - rndm ();
537
538 dst->set_speed (dst->speed);
539}
540
541void
542object::instantiate ()
543{
544 if (!uuid.seq) // HACK
545 uuid = gen_uuid ();
546
547 speed_left = -0.1f;
548 /* copy the body_info to the body_used - this is only really
549 * need for monsters, but doesn't hurt to do it for everything.
550 * by doing so, when a monster is created, it has good starting
551 * values for the body_used info, so when items are created
552 * for it, they can be properly equipped.
553 */
554 for (int i = NUM_BODY_LOCATIONS; i--; )
555 slot[i].used = slot[i].info;
556
557 attachable::instantiate ();
528} 558}
529 559
530object * 560object *
531object::clone () 561object::clone ()
532{ 562{
538/* 568/*
539 * If an object with the IS_TURNABLE() flag needs to be turned due 569 * If an object with the IS_TURNABLE() flag needs to be turned due
540 * to the closest player being on the other side, this function can 570 * to the closest player being on the other side, this function can
541 * be called to update the face variable, _and_ how it looks on the map. 571 * be called to update the face variable, _and_ how it looks on the map.
542 */ 572 */
543
544void 573void
545update_turn_face (object *op) 574update_turn_face (object *op)
546{ 575{
547 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 576 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
548 return; 577 return;
578
549 SET_ANIMATION (op, op->direction); 579 SET_ANIMATION (op, op->direction);
550 update_object (op, UP_OBJ_FACE); 580 update_object (op, UP_OBJ_FACE);
551} 581}
552 582
553/* 583/*
554 * Updates the speed of an object. If the speed changes from 0 to another 584 * Updates the speed of an object. If the speed changes from 0 to another
555 * value, or vice versa, then add/remove the object from the active list. 585 * value, or vice versa, then add/remove the object from the active list.
556 * This function needs to be called whenever the speed of an object changes. 586 * This function needs to be called whenever the speed of an object changes.
557 */ 587 */
558void 588void
559update_ob_speed (object *op) 589object::set_speed (float speed)
560{ 590{
561 extern int arch_init; 591 if (flag [FLAG_FREED] && speed)
562
563 /* No reason putting the archetypes objects on the speed list,
564 * since they never really need to be updated.
565 */
566
567 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
568 { 592 {
569 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 593 LOG (llevError, "Object %s is freed but has speed.\n", &name);
570#ifdef MANY_CORES
571 abort ();
572#else
573 op->speed = 0; 594 speed = 0;
574#endif
575 }
576
577 if (arch_init)
578 return;
579
580 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
581 { 595 }
582 /* If already on active list, don't do anything */
583 if (op->active_next || op->active_prev || op == active_objects)
584 return;
585 596
586 /* process_events() expects us to insert the object at the beginning 597 this->speed = speed;
587 * of the list. */
588 op->active_next = active_objects;
589 598
590 if (op->active_next != NULL) 599 if (has_active_speed ())
591 op->active_next->active_prev = op; 600 activate ();
592
593 active_objects = op;
594 }
595 else 601 else
596 { 602 deactivate ();
597 /* If not on the active list, nothing needs to be done */
598 if (!op->active_next && !op->active_prev && op != active_objects)
599 return;
600
601 if (op->active_prev == NULL)
602 {
603 active_objects = op->active_next;
604
605 if (op->active_next != NULL)
606 op->active_next->active_prev = NULL;
607 }
608 else
609 {
610 op->active_prev->active_next = op->active_next;
611
612 if (op->active_next)
613 op->active_next->active_prev = op->active_prev;
614 }
615
616 op->active_next = NULL;
617 op->active_prev = NULL;
618 }
619}
620
621/* This function removes object 'op' from the list of active
622 * objects.
623 * This should only be used for style maps or other such
624 * reference maps where you don't want an object that isn't
625 * in play chewing up cpu time getting processed.
626 * The reverse of this is to call update_ob_speed, which
627 * will do the right thing based on the speed of the object.
628 */
629void
630remove_from_active_list (object *op)
631{
632 /* If not on the active list, nothing needs to be done */
633 if (!op->active_next && !op->active_prev && op != active_objects)
634 return;
635
636 if (op->active_prev == NULL)
637 {
638 active_objects = op->active_next;
639 if (op->active_next != NULL)
640 op->active_next->active_prev = NULL;
641 }
642 else
643 {
644 op->active_prev->active_next = op->active_next;
645 if (op->active_next)
646 op->active_next->active_prev = op->active_prev;
647 }
648 op->active_next = NULL;
649 op->active_prev = NULL;
650} 603}
651 604
652/* 605/*
653 * update_object() updates the the map. 606 * update_object() updates the the map.
654 * It takes into account invisible objects (and represent squares covered 607 * It takes into account invisible objects (and represent squares covered
667 * UP_OBJ_FACE: only the objects face has changed. 620 * UP_OBJ_FACE: only the objects face has changed.
668 */ 621 */
669void 622void
670update_object (object *op, int action) 623update_object (object *op, int action)
671{ 624{
672 MoveType move_on, move_off, move_block, move_slow;
673
674 if (op == NULL) 625 if (op == NULL)
675 { 626 {
676 /* this should never happen */ 627 /* this should never happen */
677 LOG (llevDebug, "update_object() called for NULL object.\n"); 628 LOG (llevDebug, "update_object() called for NULL object.\n");
678 return; 629 return;
691 */ 642 */
692 if (!op->map || op->map->in_memory == MAP_SAVING) 643 if (!op->map || op->map->in_memory == MAP_SAVING)
693 return; 644 return;
694 645
695 /* make sure the object is within map boundaries */ 646 /* make sure the object is within map boundaries */
696 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 647 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
697 { 648 {
698 LOG (llevError, "update_object() called for object out of map!\n"); 649 LOG (llevError, "update_object() called for object out of map!\n");
699#ifdef MANY_CORES 650#ifdef MANY_CORES
700 abort (); 651 abort ();
701#endif 652#endif
702 return; 653 return;
703 } 654 }
704 655
705 mapspace &m = op->ms (); 656 mapspace &m = op->ms ();
706 657
707 if (m.flags_ & P_NEED_UPDATE) 658 if (!(m.flags_ & P_UPTODATE))
708 /* nop */; 659 /* nop */;
709 else if (action == UP_OBJ_INSERT) 660 else if (action == UP_OBJ_INSERT)
710 { 661 {
711 // this is likely overkill, TODO: revisit (schmorp) 662 // this is likely overkill, TODO: revisit (schmorp)
712 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 663 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
721 /* This isn't perfect, but I don't expect a lot of objects to 672 /* This isn't perfect, but I don't expect a lot of objects to
722 * to have move_allow right now. 673 * to have move_allow right now.
723 */ 674 */
724 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 675 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
725 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 676 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
726 m.flags_ = P_NEED_UPDATE; 677 m.flags_ = 0;
727 } 678 }
728 /* if the object is being removed, we can't make intelligent 679 /* if the object is being removed, we can't make intelligent
729 * decisions, because remove_ob can't really pass the object 680 * decisions, because remove_ob can't really pass the object
730 * that is being removed. 681 * that is being removed.
731 */ 682 */
732 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 683 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
733 m.flags_ = P_NEED_UPDATE; 684 m.flags_ = 0;
734 else if (action == UP_OBJ_FACE) 685 else if (action == UP_OBJ_FACE)
735 /* Nothing to do for that case */ ; 686 /* Nothing to do for that case */ ;
736 else 687 else
737 LOG (llevError, "update_object called with invalid action: %d\n", action); 688 LOG (llevError, "update_object called with invalid action: %d\n", action);
738 689
739 if (op->more) 690 if (op->more)
740 update_object (op->more, action); 691 update_object (op->more, action);
741} 692}
742 693
743object::vector object::objects; // not yet used
744object *object::first;
745
746object::object () 694object::object ()
747{ 695{
748 SET_FLAG (this, FLAG_REMOVED); 696 SET_FLAG (this, FLAG_REMOVED);
749 697
750 expmul = 1.0; 698 expmul = 1.0;
751 face = blank_face; 699 face = blank_face;
752} 700}
753 701
754object::~object () 702object::~object ()
755{ 703{
704 unlink ();
705
756 free_key_values (this); 706 free_key_values (this);
757} 707}
758 708
709static int object_count;
710
759void object::link () 711void object::link ()
760{ 712{
761 count = ++ob_count; 713 assert (!index);//D
762 uuid = gen_uuid (); 714 uuid = gen_uuid ();
715 count = ++object_count;
763 716
764 prev = 0; 717 refcnt_inc ();
765 next = object::first; 718 objects.insert (this);
766
767 if (object::first)
768 object::first->prev = this;
769
770 object::first = this;
771} 719}
772 720
773void object::unlink () 721void object::unlink ()
774{ 722{
775 if (this == object::first) 723 if (!index)
776 object::first = next; 724 return;
777 725
778 /* Remove this object from the list of used objects */ 726 objects.erase (this);
779 if (prev) prev->next = next; 727 refcnt_dec ();
780 if (next) next->prev = prev; 728}
781 729
782 prev = 0; 730void
783 next = 0; 731object::activate ()
732{
733 /* If already on active list, don't do anything */
734 if (active)
735 return;
736
737 if (has_active_speed ())
738 actives.insert (this);
739}
740
741void
742object::activate_recursive ()
743{
744 activate ();
745
746 for (object *op = inv; op; op = op->below)
747 op->activate_recursive ();
748}
749
750/* This function removes object 'op' from the list of active
751 * objects.
752 * This should only be used for style maps or other such
753 * reference maps where you don't want an object that isn't
754 * in play chewing up cpu time getting processed.
755 * The reverse of this is to call update_ob_speed, which
756 * will do the right thing based on the speed of the object.
757 */
758void
759object::deactivate ()
760{
761 /* If not on the active list, nothing needs to be done */
762 if (!active)
763 return;
764
765 actives.erase (this);
766}
767
768void
769object::deactivate_recursive ()
770{
771 for (object *op = inv; op; op = op->below)
772 op->deactivate_recursive ();
773
774 deactivate ();
775}
776
777void
778object::set_flag_inv (int flag, int value)
779{
780 for (object *op = inv; op; op = op->below)
781 {
782 op->flag [flag] = value;
783 op->set_flag_inv (flag, value);
784 }
785}
786
787/*
788 * Remove and free all objects in the inventory of the given object.
789 * object.c ?
790 */
791void
792object::destroy_inv (bool drop_to_ground)
793{
794 // need to check first, because the checks below might segfault
795 // as we might be on an invalid mapspace and crossfire code
796 // is too buggy to ensure that the inventory is empty.
797 // corollary: if you create arrows etc. with stuff in tis inventory,
798 // cf will crash below with off-map x and y
799 if (!inv)
800 return;
801
802 /* Only if the space blocks everything do we not process -
803 * if some form of movement is allowed, let objects
804 * drop on that space.
805 */
806 if (!drop_to_ground
807 || !map
808 || map->in_memory != MAP_IN_MEMORY
809 || map->nodrop
810 || ms ().move_block == MOVE_ALL)
811 {
812 while (inv)
813 {
814 inv->destroy_inv (drop_to_ground);
815 inv->destroy ();
816 }
817 }
818 else
819 { /* Put objects in inventory onto this space */
820 while (inv)
821 {
822 object *op = inv;
823
824 if (op->flag [FLAG_STARTEQUIP]
825 || op->flag [FLAG_NO_DROP]
826 || op->type == RUNE
827 || op->type == TRAP
828 || op->flag [FLAG_IS_A_TEMPLATE]
829 || op->flag [FLAG_DESTROY_ON_DEATH])
830 op->destroy ();
831 else
832 map->insert (op, x, y);
833 }
834 }
784} 835}
785 836
786object *object::create () 837object *object::create ()
787{ 838{
788 object *op = new object; 839 object *op = new object;
789 op->link (); 840 op->link ();
790 return op; 841 return op;
791} 842}
792 843
793/*
794 * free_object() frees everything allocated by an object, removes
795 * it from the list of used objects, and puts it on the list of
796 * free objects. The IS_FREED() flag is set in the object.
797 * The object must have been removed by remove_ob() first for
798 * this function to succeed.
799 *
800 * If destroy_inventory is set, free inventory as well. Else drop items in
801 * inventory to the ground.
802 */
803void 844void
804object::do_destroy () 845object::do_destroy ()
805{ 846{
806 attachable::do_destroy (); 847 attachable::do_destroy ();
807 848
812 remove_friendly_object (this); 853 remove_friendly_object (this);
813 854
814 if (!flag [FLAG_REMOVED]) 855 if (!flag [FLAG_REMOVED])
815 remove (); 856 remove ();
816 857
817 if (flag [FLAG_FREED]) 858 destroy_inv (true);
818 return; 859
860 deactivate ();
861 unlink ();
819 862
820 flag [FLAG_FREED] = 1; 863 flag [FLAG_FREED] = 1;
821 864
822 // hack to ensure that freed objects still have a valid map 865 // hack to ensure that freed objects still have a valid map
823 { 866 {
829 872
830 freed_map->name = "/internal/freed_objects_map"; 873 freed_map->name = "/internal/freed_objects_map";
831 freed_map->width = 3; 874 freed_map->width = 3;
832 freed_map->height = 3; 875 freed_map->height = 3;
833 876
834 freed_map->allocate (); 877 freed_map->alloc ();
878 freed_map->in_memory = MAP_IN_MEMORY;
835 } 879 }
836 880
837 map = freed_map; 881 map = freed_map;
838 x = 1; 882 x = 1;
839 y = 1; 883 y = 1;
840 } 884 }
841 885
842 more = 0;
843 head = 0; 886 head = 0;
844 inv = 0; 887
888 if (more)
889 {
890 more->destroy ();
891 more = 0;
892 }
845 893
846 // clear those pointers that likely might have circular references to us 894 // clear those pointers that likely might have circular references to us
847 owner = 0; 895 owner = 0;
848 enemy = 0; 896 enemy = 0;
849 attacked_by = 0; 897 attacked_by = 0;
850
851 // only relevant for players(?), but make sure of it anyways
852 contr = 0;
853
854 /* Remove object from the active list */
855 speed = 0;
856 update_ob_speed (this);
857
858 unlink ();
859}
860
861/*
862 * Remove and free all objects in the inventory of the given object.
863 * object.c ?
864 */
865void
866object::destroy_inv (bool drop_to_ground)
867{
868 if (!inv)
869 return;
870
871 /* Only if the space blocks everything do we not process -
872 * if some form of movement is allowed, let objects
873 * drop on that space.
874 */
875 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
876 {
877 while (inv)
878 {
879 inv->destroy_inv (drop_to_ground);
880 inv->destroy ();
881 }
882 }
883 else
884 { /* Put objects in inventory onto this space */
885 while (inv)
886 {
887 object *op = inv;
888
889 if (op->flag [FLAG_STARTEQUIP]
890 || op->flag [FLAG_NO_DROP]
891 || op->type == RUNE
892 || op->type == TRAP
893 || op->flag [FLAG_IS_A_TEMPLATE])
894 op->destroy ();
895 else
896 {
897 op->remove ();
898 op->x = x;
899 op->y = y;
900 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
901 }
902 }
903 }
904} 898}
905 899
906void 900void
907object::destroy (bool destroy_inventory) 901object::destroy (bool destroy_inventory)
908{ 902{
909 if (destroyed ()) 903 if (destroyed ())
910 return; 904 return;
911 905
912 if (more)
913 {
914 //TODO: non-head objects must not have inventory
915 more->destroy (destroy_inventory);
916 more = 0;
917 }
918
919 if (destroy_inventory) 906 if (destroy_inventory)
920 destroy_inv (true); 907 destroy_inv (false);
921 908
922 attachable::destroy (); 909 attachable::destroy ();
923} 910}
924 911
925/* 912/*
943 * This function removes the object op from the linked list of objects 930 * This function removes the object op from the linked list of objects
944 * which it is currently tied to. When this function is done, the 931 * which it is currently tied to. When this function is done, the
945 * object will have no environment. If the object previously had an 932 * object will have no environment. If the object previously had an
946 * environment, the x and y coordinates will be updated to 933 * environment, the x and y coordinates will be updated to
947 * the previous environment. 934 * the previous environment.
948 * Beware: This function is called from the editor as well!
949 */ 935 */
950void 936void
951object::remove () 937object::do_remove ()
952{ 938{
953 object *tmp, *last = 0; 939 object *tmp, *last = 0;
954 object *otmp; 940 object *otmp;
955 941
956 if (QUERY_FLAG (this, FLAG_REMOVED)) 942 if (QUERY_FLAG (this, FLAG_REMOVED))
978 * to save cpu time. 964 * to save cpu time.
979 */ 965 */
980 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 966 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
981 otmp->update_stats (); 967 otmp->update_stats ();
982 968
983 if (above != NULL) 969 if (above)
984 above->below = below; 970 above->below = below;
985 else 971 else
986 env->inv = below; 972 env->inv = below;
987 973
988 if (below != NULL) 974 if (below)
989 below->above = above; 975 below->above = above;
990 976
991 /* we set up values so that it could be inserted into 977 /* we set up values so that it could be inserted into
992 * the map, but we don't actually do that - it is up 978 * the map, but we don't actually do that - it is up
993 * to the caller to decide what we want to do. 979 * to the caller to decide what we want to do.
997 above = 0, below = 0; 983 above = 0, below = 0;
998 env = 0; 984 env = 0;
999 } 985 }
1000 else if (map) 986 else if (map)
1001 { 987 {
1002 /* Re did the following section of code - it looks like it had 988 if (type == PLAYER)
1003 * lots of logic for things we no longer care about
1004 */ 989 {
990 // leaving a spot always closes any open container on the ground
991 if (container && !container->env)
992 // this causes spurious floorbox updates, but it ensures
993 // that the CLOSE event is being sent.
994 close_container ();
995
996 --map->players;
997 map->touch ();
998 }
999
1000 map->dirty = true;
1001 mapspace &ms = this->ms ();
1005 1002
1006 /* link the object above us */ 1003 /* link the object above us */
1007 if (above) 1004 if (above)
1008 above->below = below; 1005 above->below = below;
1009 else 1006 else
1010 map->at (x, y).top = below; /* we were top, set new top */ 1007 ms.top = below; /* we were top, set new top */
1011 1008
1012 /* Relink the object below us, if there is one */ 1009 /* Relink the object below us, if there is one */
1013 if (below) 1010 if (below)
1014 below->above = above; 1011 below->above = above;
1015 else 1012 else
1017 /* Nothing below, which means we need to relink map object for this space 1014 /* Nothing below, which means we need to relink map object for this space
1018 * use translated coordinates in case some oddness with map tiling is 1015 * use translated coordinates in case some oddness with map tiling is
1019 * evident 1016 * evident
1020 */ 1017 */
1021 if (GET_MAP_OB (map, x, y) != this) 1018 if (GET_MAP_OB (map, x, y) != this)
1022 {
1023 char *dump = dump_object (this);
1024 LOG (llevError,
1025 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1019 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1026 free (dump);
1027 dump = dump_object (GET_MAP_OB (map, x, y));
1028 LOG (llevError, "%s\n", dump);
1029 free (dump);
1030 }
1031 1020
1032 map->at (x, y).bottom = above; /* goes on above it. */ 1021 ms.bot = above; /* goes on above it. */
1033 } 1022 }
1034 1023
1035 above = 0; 1024 above = 0;
1036 below = 0; 1025 below = 0;
1037 1026
1038 if (map->in_memory == MAP_SAVING) 1027 if (map->in_memory == MAP_SAVING)
1039 return; 1028 return;
1040 1029
1041 int check_walk_off = !flag [FLAG_NO_APPLY]; 1030 int check_walk_off = !flag [FLAG_NO_APPLY];
1042 1031
1043 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1032 for (tmp = ms.bot; tmp; tmp = tmp->above)
1044 { 1033 {
1045 /* No point updating the players look faces if he is the object 1034 /* No point updating the players look faces if he is the object
1046 * being removed. 1035 * being removed.
1047 */ 1036 */
1048 1037
1060 1049
1061 if (tmp->contr->ns) 1050 if (tmp->contr->ns)
1062 tmp->contr->ns->floorbox_update (); 1051 tmp->contr->ns->floorbox_update ();
1063 } 1052 }
1064 1053
1065 /* See if player moving off should effect something */ 1054 /* See if object moving off should effect something */
1066 if (check_walk_off 1055 if (check_walk_off
1067 && ((move_type & tmp->move_off) 1056 && ((move_type & tmp->move_off)
1068 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1057 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1069 { 1058 {
1070 move_apply (tmp, this, 0); 1059 move_apply (tmp, this, 0);
1072 if (destroyed ()) 1061 if (destroyed ())
1073 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1062 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1074 } 1063 }
1075 1064
1076 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1065 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1077 1066 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1078 if (tmp->above == tmp) 1067 if (tmp->above == tmp)
1079 tmp->above = 0; 1068 tmp->above = 0;
1080 1069
1081 last = tmp; 1070 last = tmp;
1082 } 1071 }
1083 1072
1084 /* last == NULL of there are no objects on this space */ 1073 /* last == NULL if there are no objects on this space */
1074 //TODO: this makes little sense, why only update the topmost object?
1085 if (!last) 1075 if (!last)
1086 map->at (x, y).flags_ = P_NEED_UPDATE; 1076 map->at (x, y).flags_ = 0;
1087 else 1077 else
1088 update_object (last, UP_OBJ_REMOVE); 1078 update_object (last, UP_OBJ_REMOVE);
1089 1079
1090 if (flag [FLAG_BLOCKSVIEW] || glow_radius) 1080 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1091 update_all_los (map, x, y); 1081 update_all_los (map, x, y);
1127 } 1117 }
1128 1118
1129 return 0; 1119 return 0;
1130} 1120}
1131 1121
1122void
1123object::expand_tail ()
1124{
1125 if (more)
1126 return;
1127
1128 object *prev = this;
1129
1130 for (archetype *at = arch->more; at; at = at->more)
1131 {
1132 object *op = arch_to_object (at);
1133
1134 op->name = name;
1135 op->name_pl = name_pl;
1136 op->title = title;
1137
1138 op->head = this;
1139 prev->more = op;
1140
1141 prev = op;
1142 }
1143}
1144
1132/* 1145/*
1133 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1146 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1134 * job preparing multi-part monsters 1147 * job preparing multi-part monsters.
1135 */ 1148 */
1136object * 1149object *
1137insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1150insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1138{ 1151{
1139 object *tmp;
1140
1141 if (op->head)
1142 op = op->head;
1143
1144 for (tmp = op; tmp; tmp = tmp->more) 1152 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1145 { 1153 {
1146 tmp->x = x + tmp->arch->clone.x; 1154 tmp->x = x + tmp->arch->clone.x;
1147 tmp->y = y + tmp->arch->clone.y; 1155 tmp->y = y + tmp->arch->clone.y;
1148 } 1156 }
1149 1157
1171 * just 'op' otherwise 1179 * just 'op' otherwise
1172 */ 1180 */
1173object * 1181object *
1174insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1182insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1175{ 1183{
1184 assert (!op->flag [FLAG_FREED]);
1185
1176 object *tmp, *top, *floor = NULL; 1186 object *tmp, *top, *floor = NULL;
1177 sint16 x, y;
1178 1187
1179 if (QUERY_FLAG (op, FLAG_FREED)) 1188 op->remove ();
1180 {
1181 LOG (llevError, "Trying to insert freed object!\n");
1182 return NULL;
1183 }
1184 1189
1185 if (m == NULL) 1190#if 0
1186 { 1191 if (!m->active != !op->active)
1187 char *dump = dump_object (op); 1192 if (m->active)
1188 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1193 op->activate_recursive ();
1189 free (dump); 1194 else
1190 return op; 1195 op->deactivate_recursive ();
1191 } 1196#endif
1192 1197
1193 if (out_of_map (m, op->x, op->y)) 1198 if (out_of_map (m, op->x, op->y))
1194 { 1199 {
1195 char *dump = dump_object (op);
1196 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump); 1200 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1197#ifdef MANY_CORES 1201#ifdef MANY_CORES
1198 /* Better to catch this here, as otherwise the next use of this object 1202 /* Better to catch this here, as otherwise the next use of this object
1199 * is likely to cause a crash. Better to find out where it is getting 1203 * is likely to cause a crash. Better to find out where it is getting
1200 * improperly inserted. 1204 * improperly inserted.
1201 */ 1205 */
1202 abort (); 1206 abort ();
1203#endif 1207#endif
1204 free (dump);
1205 return op; 1208 return op;
1206 } 1209 }
1207 1210
1208 if (!QUERY_FLAG (op, FLAG_REMOVED))
1209 {
1210 char *dump = dump_object (op);
1211 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1212 free (dump);
1213 return op;
1214 }
1215
1216 if (op->more)
1217 {
1218 /* The part may be on a different map. */
1219
1220 object *more = op->more; 1211 if (object *more = op->more)
1221 1212 {
1222 /* We really need the caller to normalize coordinates - if
1223 * we set the map, that doesn't work if the location is within
1224 * a map and this is straddling an edge. So only if coordinate
1225 * is clear wrong do we normalize it.
1226 */
1227 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1228 more->map = get_map_from_coord (m, &more->x, &more->y);
1229 else if (!more->map)
1230 {
1231 /* For backwards compatibility - when not dealing with tiled maps,
1232 * more->map should always point to the parent.
1233 */
1234 more->map = m;
1235 }
1236
1237 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1213 if (!insert_ob_in_map (more, m, originator, flag))
1238 { 1214 {
1239 if (!op->head) 1215 if (!op->head)
1240 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1216 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1241 1217
1242 return 0; 1218 return 0;
1247 1223
1248 /* Ideally, the caller figures this out. However, it complicates a lot 1224 /* Ideally, the caller figures this out. However, it complicates a lot
1249 * of areas of callers (eg, anything that uses find_free_spot would now 1225 * of areas of callers (eg, anything that uses find_free_spot would now
1250 * need extra work 1226 * need extra work
1251 */ 1227 */
1252 op->map = get_map_from_coord (m, &op->x, &op->y); 1228 if (!xy_normalise (m, op->x, op->y))
1253 x = op->x; 1229 return 0;
1254 y = op->y; 1230
1231 op->map = m;
1232 mapspace &ms = op->ms ();
1255 1233
1256 /* this has to be done after we translate the coordinates. 1234 /* this has to be done after we translate the coordinates.
1257 */ 1235 */
1258 if (op->nrof && !(flag & INS_NO_MERGE)) 1236 if (op->nrof && !(flag & INS_NO_MERGE))
1259 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1237 for (tmp = ms.bot; tmp; tmp = tmp->above)
1260 if (object::can_merge (op, tmp)) 1238 if (object::can_merge (op, tmp))
1261 { 1239 {
1262 op->nrof += tmp->nrof; 1240 op->nrof += tmp->nrof;
1263 tmp->destroy (); 1241 tmp->destroy ();
1264 } 1242 }
1281 op->below = originator->below; 1259 op->below = originator->below;
1282 1260
1283 if (op->below) 1261 if (op->below)
1284 op->below->above = op; 1262 op->below->above = op;
1285 else 1263 else
1286 op->ms ().bottom = op; 1264 ms.bot = op;
1287 1265
1288 /* since *below* originator, no need to update top */ 1266 /* since *below* originator, no need to update top */
1289 originator->below = op; 1267 originator->below = op;
1290 } 1268 }
1291 else 1269 else
1292 { 1270 {
1271 top = ms.bot;
1272
1293 /* If there are other objects, then */ 1273 /* If there are other objects, then */
1294 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1274 if ((!(flag & INS_MAP_LOAD)) && top)
1295 { 1275 {
1296 object *last = NULL; 1276 object *last = 0;
1297 1277
1298 /* 1278 /*
1299 * If there are multiple objects on this space, we do some trickier handling. 1279 * If there are multiple objects on this space, we do some trickier handling.
1300 * We've already dealt with merging if appropriate. 1280 * We've already dealt with merging if appropriate.
1301 * Generally, we want to put the new object on top. But if 1281 * Generally, we want to put the new object on top. But if
1305 * once we get to them. This reduces the need to traverse over all of 1285 * once we get to them. This reduces the need to traverse over all of
1306 * them when adding another one - this saves quite a bit of cpu time 1286 * them when adding another one - this saves quite a bit of cpu time
1307 * when lots of spells are cast in one area. Currently, it is presumed 1287 * when lots of spells are cast in one area. Currently, it is presumed
1308 * that flying non pickable objects are spell objects. 1288 * that flying non pickable objects are spell objects.
1309 */ 1289 */
1310 1290 for (top = ms.bot; top; top = top->above)
1311 while (top != NULL)
1312 { 1291 {
1313 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1292 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1314 floor = top; 1293 floor = top;
1315 1294
1316 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1295 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1319 top = top->below; 1298 top = top->below;
1320 break; 1299 break;
1321 } 1300 }
1322 1301
1323 last = top; 1302 last = top;
1324 top = top->above;
1325 } 1303 }
1326 1304
1327 /* Don't want top to be NULL, so set it to the last valid object */ 1305 /* Don't want top to be NULL, so set it to the last valid object */
1328 top = last; 1306 top = last;
1329 1307
1331 * looks like instead of lots of conditions here. 1309 * looks like instead of lots of conditions here.
1332 * makes things faster, and effectively the same result. 1310 * makes things faster, and effectively the same result.
1333 */ 1311 */
1334 1312
1335 /* Have object 'fall below' other objects that block view. 1313 /* Have object 'fall below' other objects that block view.
1336 * Unless those objects are exits, type 66 1314 * Unless those objects are exits.
1337 * If INS_ON_TOP is used, don't do this processing 1315 * If INS_ON_TOP is used, don't do this processing
1338 * Need to find the object that in fact blocks view, otherwise 1316 * Need to find the object that in fact blocks view, otherwise
1339 * stacking is a bit odd. 1317 * stacking is a bit odd.
1340 */ 1318 */
1341 if (!(flag & INS_ON_TOP) && 1319 if (!(flag & INS_ON_TOP)
1342 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1320 && ms.flags () & P_BLOCKSVIEW
1321 && (op->face && !faces [op->face].visibility))
1343 { 1322 {
1344 for (last = top; last != floor; last = last->below) 1323 for (last = top; last != floor; last = last->below)
1345 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1324 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1346 break; 1325 break;
1326
1347 /* Check to see if we found the object that blocks view, 1327 /* Check to see if we found the object that blocks view,
1348 * and make sure we have a below pointer for it so that 1328 * and make sure we have a below pointer for it so that
1349 * we can get inserted below this one, which requires we 1329 * we can get inserted below this one, which requires we
1350 * set top to the object below us. 1330 * set top to the object below us.
1351 */ 1331 */
1353 top = last->below; 1333 top = last->below;
1354 } 1334 }
1355 } /* If objects on this space */ 1335 } /* If objects on this space */
1356 1336
1357 if (flag & INS_MAP_LOAD) 1337 if (flag & INS_MAP_LOAD)
1358 top = GET_MAP_TOP (op->map, op->x, op->y); 1338 top = ms.top;
1359 1339
1360 if (flag & INS_ABOVE_FLOOR_ONLY) 1340 if (flag & INS_ABOVE_FLOOR_ONLY)
1361 top = floor; 1341 top = floor;
1362 1342
1363 /* Top is the object that our object (op) is going to get inserted above. 1343 /* Top is the object that our object (op) is going to get inserted above.
1364 */ 1344 */
1365 1345
1366 /* First object on this space */ 1346 /* First object on this space */
1367 if (!top) 1347 if (!top)
1368 { 1348 {
1369 op->above = GET_MAP_OB (op->map, op->x, op->y); 1349 op->above = ms.bot;
1370 1350
1371 if (op->above) 1351 if (op->above)
1372 op->above->below = op; 1352 op->above->below = op;
1373 1353
1374 op->below = NULL; 1354 op->below = 0;
1375 op->ms ().bottom = op; 1355 ms.bot = op;
1376 } 1356 }
1377 else 1357 else
1378 { /* get inserted into the stack above top */ 1358 { /* get inserted into the stack above top */
1379 op->above = top->above; 1359 op->above = top->above;
1380 1360
1383 1363
1384 op->below = top; 1364 op->below = top;
1385 top->above = op; 1365 top->above = op;
1386 } 1366 }
1387 1367
1388 if (op->above == NULL) 1368 if (!op->above)
1389 op->ms ().top = op; 1369 ms.top = op;
1390 } /* else not INS_BELOW_ORIGINATOR */ 1370 } /* else not INS_BELOW_ORIGINATOR */
1391 1371
1392 if (op->type == PLAYER) 1372 if (op->type == PLAYER)
1373 {
1393 op->contr->do_los = 1; 1374 op->contr->do_los = 1;
1375 ++op->map->players;
1376 op->map->touch ();
1377 }
1378
1379 op->map->dirty = true;
1394 1380
1395 /* If we have a floor, we know the player, if any, will be above 1381 /* If we have a floor, we know the player, if any, will be above
1396 * it, so save a few ticks and start from there. 1382 * it, so save a few ticks and start from there.
1397 */ 1383 */
1398 if (!(flag & INS_MAP_LOAD)) 1384 if (!(flag & INS_MAP_LOAD))
1399 if (object *pl = op->ms ().player ()) 1385 if (object *pl = ms.player ())
1400 if (pl->contr->ns) 1386 if (pl->contr->ns)
1401 pl->contr->ns->floorbox_update (); 1387 pl->contr->ns->floorbox_update ();
1402 1388
1403 /* If this object glows, it may affect lighting conditions that are 1389 /* If this object glows, it may affect lighting conditions that are
1404 * visible to others on this map. But update_all_los is really 1390 * visible to others on this map. But update_all_los is really
1405 * an inefficient way to do this, as it means los for all players 1391 * an inefficient way to do this, as it means los for all players
1406 * on the map will get recalculated. The players could very well 1392 * on the map will get recalculated. The players could very well
1407 * be far away from this change and not affected in any way - 1393 * be far away from this change and not affected in any way -
1408 * this should get redone to only look for players within range, 1394 * this should get redone to only look for players within range,
1409 * or just updating the P_NEED_UPDATE for spaces within this area 1395 * or just updating the P_UPTODATE for spaces within this area
1410 * of effect may be sufficient. 1396 * of effect may be sufficient.
1411 */ 1397 */
1412 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1398 if (op->map->darkness && (op->glow_radius != 0))
1413 update_all_los (op->map, op->x, op->y); 1399 update_all_los (op->map, op->x, op->y);
1414 1400
1415 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1401 /* updates flags (blocked, alive, no magic, etc) for this map space */
1416 update_object (op, UP_OBJ_INSERT); 1402 update_object (op, UP_OBJ_INSERT);
1417 1403
1452{ 1438{
1453 object *tmp, *tmp1; 1439 object *tmp, *tmp1;
1454 1440
1455 /* first search for itself and remove any old instances */ 1441 /* first search for itself and remove any old instances */
1456 1442
1457 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1443 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1458 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1444 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1459 tmp->destroy (); 1445 tmp->destroy ();
1460 1446
1461 tmp1 = arch_to_object (archetype::find (arch_string)); 1447 tmp1 = arch_to_object (archetype::find (arch_string));
1462 1448
1463 tmp1->x = op->x; 1449 tmp1->x = op->x;
1464 tmp1->y = op->y; 1450 tmp1->y = op->y;
1465 insert_ob_in_map (tmp1, op->map, op, 0); 1451 insert_ob_in_map (tmp1, op->map, op, 0);
1452}
1453
1454object *
1455object::insert_at (object *where, object *originator, int flags)
1456{
1457 return where->map->insert (this, where->x, where->y, originator, flags);
1466} 1458}
1467 1459
1468/* 1460/*
1469 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1461 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1470 * is returned contains nr objects, and the remaining parts contains 1462 * is returned contains nr objects, and the remaining parts contains
1471 * the rest (or is removed and freed if that number is 0). 1463 * the rest (or is removed and freed if that number is 0).
1472 * On failure, NULL is returned, and the reason put into the 1464 * On failure, NULL is returned, and the reason put into the
1473 * global static errmsg array. 1465 * global static errmsg array.
1474 */ 1466 */
1475
1476object * 1467object *
1477get_split_ob (object *orig_ob, uint32 nr) 1468get_split_ob (object *orig_ob, uint32 nr)
1478{ 1469{
1479 object *newob; 1470 object *newob;
1480 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1471 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1511 * the amount of an object. If the amount reaches 0, the object 1502 * the amount of an object. If the amount reaches 0, the object
1512 * is subsequently removed and freed. 1503 * is subsequently removed and freed.
1513 * 1504 *
1514 * Return value: 'op' if something is left, NULL if the amount reached 0 1505 * Return value: 'op' if something is left, NULL if the amount reached 0
1515 */ 1506 */
1516
1517object * 1507object *
1518decrease_ob_nr (object *op, uint32 i) 1508decrease_ob_nr (object *op, uint32 i)
1519{ 1509{
1520 object *tmp; 1510 object *tmp;
1521 1511
1596 1586
1597/* 1587/*
1598 * add_weight(object, weight) adds the specified weight to an object, 1588 * add_weight(object, weight) adds the specified weight to an object,
1599 * and also updates how much the environment(s) is/are carrying. 1589 * and also updates how much the environment(s) is/are carrying.
1600 */ 1590 */
1601
1602void 1591void
1603add_weight (object *op, signed long weight) 1592add_weight (object *op, signed long weight)
1604{ 1593{
1605 while (op != NULL) 1594 while (op != NULL)
1606 { 1595 {
1638 * inside the object environment. 1627 * inside the object environment.
1639 * 1628 *
1640 * The function returns now pointer to inserted item, and return value can 1629 * The function returns now pointer to inserted item, and return value can
1641 * be != op, if items are merged. -Tero 1630 * be != op, if items are merged. -Tero
1642 */ 1631 */
1643
1644object * 1632object *
1645object::insert (object *op) 1633object::insert (object *op)
1646{ 1634{
1647 object *tmp, *otmp; 1635 object *tmp, *otmp;
1648 1636
1703 if ((op->glow_radius != 0) && map) 1691 if ((op->glow_radius != 0) && map)
1704 { 1692 {
1705#ifdef DEBUG_LIGHTS 1693#ifdef DEBUG_LIGHTS
1706 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1694 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1707#endif /* DEBUG_LIGHTS */ 1695#endif /* DEBUG_LIGHTS */
1708 if (MAP_DARKNESS (map)) 1696 if (map->darkness)
1709 update_all_los (map, x, y); 1697 update_all_los (map, x, y);
1710 } 1698 }
1711 1699
1712 /* Client has no idea of ordering so lets not bother ordering it here. 1700 /* Client has no idea of ordering so lets not bother ordering it here.
1713 * It sure simplifies this function... 1701 * It sure simplifies this function...
1744 * 1732 *
1745 * MSW 2001-07-08: Check all objects on space, not just those below 1733 * MSW 2001-07-08: Check all objects on space, not just those below
1746 * object being inserted. insert_ob_in_map may not put new objects 1734 * object being inserted. insert_ob_in_map may not put new objects
1747 * on top. 1735 * on top.
1748 */ 1736 */
1749
1750int 1737int
1751check_move_on (object *op, object *originator) 1738check_move_on (object *op, object *originator)
1752{ 1739{
1753 object *tmp; 1740 object *tmp;
1754 maptile *m = op->map; 1741 maptile *m = op->map;
1781 1768
1782 /* The objects have to be checked from top to bottom. 1769 /* The objects have to be checked from top to bottom.
1783 * Hence, we first go to the top: 1770 * Hence, we first go to the top:
1784 */ 1771 */
1785 1772
1786 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1773 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1787 { 1774 {
1788 /* Trim the search when we find the first other spell effect 1775 /* Trim the search when we find the first other spell effect
1789 * this helps performance so that if a space has 50 spell objects, 1776 * this helps performance so that if a space has 50 spell objects,
1790 * we don't need to check all of them. 1777 * we don't need to check all of them.
1791 */ 1778 */
1809 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1796 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1810 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1797 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1811 { 1798 {
1812 1799
1813 float 1800 float
1814 diff = tmp->move_slow_penalty * FABS (op->speed); 1801 diff = tmp->move_slow_penalty * fabs (op->speed);
1815 1802
1816 if (op->type == PLAYER) 1803 if (op->type == PLAYER)
1817 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1804 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1818 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1805 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1819 diff /= 4.0; 1806 diff /= 4.0;
1846/* 1833/*
1847 * present_arch(arch, map, x, y) searches for any objects with 1834 * present_arch(arch, map, x, y) searches for any objects with
1848 * a matching archetype at the given map and coordinates. 1835 * a matching archetype at the given map and coordinates.
1849 * The first matching object is returned, or NULL if none. 1836 * The first matching object is returned, or NULL if none.
1850 */ 1837 */
1851
1852object * 1838object *
1853present_arch (const archetype *at, maptile *m, int x, int y) 1839present_arch (const archetype *at, maptile *m, int x, int y)
1854{ 1840{
1855 object *
1856 tmp;
1857
1858 if (m == NULL || out_of_map (m, x, y)) 1841 if (!m || out_of_map (m, x, y))
1859 { 1842 {
1860 LOG (llevError, "Present_arch called outside map.\n"); 1843 LOG (llevError, "Present_arch called outside map.\n");
1861 return NULL; 1844 return NULL;
1862 } 1845 }
1863 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1846
1847 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1864 if (tmp->arch == at) 1848 if (tmp->arch == at)
1865 return tmp; 1849 return tmp;
1850
1866 return NULL; 1851 return NULL;
1867} 1852}
1868 1853
1869/* 1854/*
1870 * present(type, map, x, y) searches for any objects with 1855 * present(type, map, x, y) searches for any objects with
1871 * a matching type variable at the given map and coordinates. 1856 * a matching type variable at the given map and coordinates.
1872 * The first matching object is returned, or NULL if none. 1857 * The first matching object is returned, or NULL if none.
1873 */ 1858 */
1874
1875object * 1859object *
1876present (unsigned char type, maptile *m, int x, int y) 1860present (unsigned char type, maptile *m, int x, int y)
1877{ 1861{
1878 object *
1879 tmp;
1880
1881 if (out_of_map (m, x, y)) 1862 if (out_of_map (m, x, y))
1882 { 1863 {
1883 LOG (llevError, "Present called outside map.\n"); 1864 LOG (llevError, "Present called outside map.\n");
1884 return NULL; 1865 return NULL;
1885 } 1866 }
1886 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1867
1868 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1887 if (tmp->type == type) 1869 if (tmp->type == type)
1888 return tmp; 1870 return tmp;
1871
1889 return NULL; 1872 return NULL;
1890} 1873}
1891 1874
1892/* 1875/*
1893 * present_in_ob(type, object) searches for any objects with 1876 * present_in_ob(type, object) searches for any objects with
1894 * a matching type variable in the inventory of the given object. 1877 * a matching type variable in the inventory of the given object.
1895 * The first matching object is returned, or NULL if none. 1878 * The first matching object is returned, or NULL if none.
1896 */ 1879 */
1897
1898object * 1880object *
1899present_in_ob (unsigned char type, const object *op) 1881present_in_ob (unsigned char type, const object *op)
1900{ 1882{
1901 object *
1902 tmp;
1903
1904 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1883 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1905 if (tmp->type == type) 1884 if (tmp->type == type)
1906 return tmp; 1885 return tmp;
1886
1907 return NULL; 1887 return NULL;
1908} 1888}
1909 1889
1910/* 1890/*
1911 * present_in_ob (type, str, object) searches for any objects with 1891 * present_in_ob (type, str, object) searches for any objects with
1922 * to be unique. 1902 * to be unique.
1923 */ 1903 */
1924object * 1904object *
1925present_in_ob_by_name (int type, const char *str, const object *op) 1905present_in_ob_by_name (int type, const char *str, const object *op)
1926{ 1906{
1927 object *tmp;
1928
1929 for (tmp = op->inv; tmp; tmp = tmp->below) 1907 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1930 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1908 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
1931 return tmp; 1909 return tmp;
1932 1910
1933 return 0; 1911 return 0;
1934} 1912}
2035 } 2013 }
2036 2014
2037 if (!index) 2015 if (!index)
2038 return -1; 2016 return -1;
2039 2017
2040 return altern[RANDOM () % index]; 2018 return altern [rndm (index)];
2041} 2019}
2042 2020
2043/* 2021/*
2044 * find_first_free_spot(archetype, maptile, x, y) works like 2022 * find_first_free_spot(archetype, maptile, x, y) works like
2045 * find_free_spot(), but it will search max number of squares. 2023 * find_free_spot(), but it will search max number of squares.
2066{ 2044{
2067 arr += begin; 2045 arr += begin;
2068 end -= begin; 2046 end -= begin;
2069 2047
2070 while (--end) 2048 while (--end)
2071 swap (arr [end], arr [RANDOM () % (end + 1)]); 2049 swap (arr [end], arr [rndm (end + 1)]);
2072} 2050}
2073 2051
2074/* new function to make monster searching more efficient, and effective! 2052/* new function to make monster searching more efficient, and effective!
2075 * This basically returns a randomized array (in the passed pointer) of 2053 * This basically returns a randomized array (in the passed pointer) of
2076 * the spaces to find monsters. In this way, it won't always look for 2054 * the spaces to find monsters. In this way, it won't always look for
2143 2121
2144 if ((move_type & blocked) == move_type) 2122 if ((move_type & blocked) == move_type)
2145 max = maxfree[i]; 2123 max = maxfree[i];
2146 else if (mflags & P_IS_ALIVE) 2124 else if (mflags & P_IS_ALIVE)
2147 { 2125 {
2148 for (tmp = ms.bottom; tmp; tmp = tmp->above) 2126 for (tmp = ms.bot; tmp; tmp = tmp->above)
2149 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2127 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2150 && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2128 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2151 break; 2129 break;
2152 2130
2153 if (tmp) 2131 if (tmp)
2210 2188
2211 return 3; 2189 return 3;
2212} 2190}
2213 2191
2214/* 2192/*
2215 * absdir(int): Returns a number between 1 and 8, which represent
2216 * the "absolute" direction of a number (it actually takes care of
2217 * "overflow" in previous calculations of a direction).
2218 */
2219
2220int
2221absdir (int d)
2222{
2223 while (d < 1)
2224 d += 8;
2225
2226 while (d > 8)
2227 d -= 8;
2228
2229 return d;
2230}
2231
2232/*
2233 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2193 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2234 * between two directions (which are expected to be absolute (see absdir()) 2194 * between two directions (which are expected to be absolute (see absdir())
2235 */ 2195 */
2236
2237int 2196int
2238dirdiff (int dir1, int dir2) 2197dirdiff (int dir1, int dir2)
2239{ 2198{
2240 int d; 2199 int d;
2241 2200
2407 insert_ob_in_ob (object_create_clone (item), dst); 2366 insert_ob_in_ob (object_create_clone (item), dst);
2408 2367
2409 return dst; 2368 return dst;
2410} 2369}
2411 2370
2412/* GROS - Creates an object using a string representing its content. */
2413/* Basically, we save the content of the string to a temp file, then call */
2414/* load_object on it. I admit it is a highly inefficient way to make things, */
2415/* but it was simple to make and allows reusing the load_object function. */
2416/* Remember not to use load_object_str in a time-critical situation. */
2417/* Also remember that multiparts objects are not supported for now. */
2418object *
2419load_object_str (const char *obstr)
2420{
2421 object *op;
2422 char filename[MAX_BUF];
2423
2424 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2425
2426 FILE *tempfile = fopen (filename, "w");
2427
2428 if (tempfile == NULL)
2429 {
2430 LOG (llevError, "Error - Unable to access load object temp file\n");
2431 return NULL;
2432 }
2433
2434 fprintf (tempfile, obstr);
2435 fclose (tempfile);
2436
2437 op = object::create ();
2438
2439 object_thawer thawer (filename);
2440
2441 if (thawer)
2442 load_object (thawer, op, 0);
2443
2444 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2445 CLEAR_FLAG (op, FLAG_REMOVED);
2446
2447 return op;
2448}
2449
2450/* This returns the first object in who's inventory that 2371/* This returns the first object in who's inventory that
2451 * has the same type and subtype match. 2372 * has the same type and subtype match.
2452 * returns NULL if no match. 2373 * returns NULL if no match.
2453 */ 2374 */
2454object * 2375object *
2507 if (link->key == canonical_key) 2428 if (link->key == canonical_key)
2508 return link->value; 2429 return link->value;
2509 2430
2510 return 0; 2431 return 0;
2511} 2432}
2512
2513 2433
2514/* 2434/*
2515 * Updates the canonical_key in op to value. 2435 * Updates the canonical_key in op to value.
2516 * 2436 *
2517 * canonical_key is a shared string (value doesn't have to be). 2437 * canonical_key is a shared string (value doesn't have to be).
2620 } 2540 }
2621 else 2541 else
2622 item = item->env; 2542 item = item->env;
2623} 2543}
2624 2544
2545
2546const char *
2547object::flag_desc (char *desc, int len) const
2548{
2549 char *p = desc;
2550 bool first = true;
2551
2552 *p = 0;
2553
2554 for (int i = 0; i < NUM_FLAGS; i++)
2555 {
2556 if (len <= 10) // magic constant!
2557 {
2558 snprintf (p, len, ",...");
2559 break;
2560 }
2561
2562 if (flag [i])
2563 {
2564 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2565 len -= cnt;
2566 p += cnt;
2567 first = false;
2568 }
2569 }
2570
2571 return desc;
2572}
2573
2625// return a suitable string describing an objetc in enough detail to find it 2574// return a suitable string describing an object in enough detail to find it
2626const char * 2575const char *
2627object::debug_desc (char *info) const 2576object::debug_desc (char *info) const
2628{ 2577{
2578 char flagdesc[512];
2629 char info2[256 * 3]; 2579 char info2[256 * 4];
2630 char *p = info; 2580 char *p = info;
2631 2581
2632 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2582 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2633 count, 2583 count, uuid.seq,
2634 &name, 2584 &name,
2635 title ? " " : "", 2585 title ? "\",title:\"" : "",
2636 title ? (const char *)title : ""); 2586 title ? (const char *)title : "",
2587 flag_desc (flagdesc, 512), type);
2637 2588
2638 if (env) 2589 if (env)
2639 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2590 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2640 2591
2641 if (map) 2592 if (map)
2642 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2593 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2643 2594
2644 return info; 2595 return info;
2645} 2596}
2646 2597
2647const char * 2598const char *
2648object::debug_desc () const 2599object::debug_desc () const
2649{ 2600{
2650 static char info[256 * 3]; 2601 static char info[3][256 * 4];
2602 static int info_idx;
2603
2651 return debug_desc (info); 2604 return debug_desc (info [++info_idx % 3]);
2652} 2605}
2653 2606
2607struct region *
2608object::region () const
2609{
2610 return map ? map->region (x, y)
2611 : region::default_region ();
2612}
2613
2614const materialtype_t *
2615object::dominant_material () const
2616{
2617 if (materialtype_t *mat = name_to_material (materialname))
2618 return mat;
2619
2620 // omfg this is slow, this has to be temporary :)
2621 shstr unknown ("unknown");
2622
2623 return name_to_material (unknown);
2624}
2625
2626void
2627object::open_container (object *new_container)
2628{
2629 if (container == new_container)
2630 return;
2631
2632 if (object *old_container = container)
2633 {
2634 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2635 return;
2636
2637#if 0
2638 // remove the "Close old_container" object.
2639 if (object *closer = old_container->inv)
2640 if (closer->type == CLOSE_CON)
2641 closer->destroy ();
2642#endif
2643
2644 old_container->flag [FLAG_APPLIED] = 0;
2645 container = 0;
2646
2647 esrv_update_item (UPD_FLAGS, this, old_container);
2648 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2649 }
2650
2651 if (new_container)
2652 {
2653 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2654 return;
2655
2656 // TODO: this does not seem to serve any purpose anymore?
2657#if 0
2658 // insert the "Close Container" object.
2659 if (archetype *closer = new_container->other_arch)
2660 {
2661 object *closer = arch_to_object (new_container->other_arch);
2662 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2663 new_container->insert (closer);
2664 }
2665#endif
2666
2667 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2668
2669 new_container->flag [FLAG_APPLIED] = 1;
2670 container = new_container;
2671
2672 esrv_update_item (UPD_FLAGS, this, new_container);
2673 esrv_send_inventory (this, new_container);
2674 }
2675}
2676
2677

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines