ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.52 by root, Wed Sep 27 00:36:08 2006 UTC vs.
Revision 1.84 by root, Mon Dec 25 14:54:44 2006 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
104 _exit (1); 106 _exit (1);
105 } 107 }
106 108
107 uuid.seq = uid; 109 uuid.seq = uid;
108 write_uuid (); 110 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 112 fclose (fp);
111} 113}
112 114
113UUID 115UUID
114gen_uuid () 116gen_uuid ()
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193 195
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
354 op = op->env; 352 op = op->env;
355 return op; 353 return op;
356} 354}
357 355
358/* 356/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 358 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
377 */ 360 */
378 361
379void 362char *
380dump_object2 (object *op)
381{
382 errmsg[0] = 0;
383 return;
384 //TODO//D#d#
385#if 0
386 char *cp;
387
388/* object *tmp;*/
389
390 if (op->arch != NULL)
391 {
392 strcat (errmsg, "arch ");
393 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394 strcat (errmsg, "\n");
395 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396 strcat (errmsg, cp);
397# if 0
398 /* Don't dump player diffs - they are too long, mostly meaningless, and
399 * will overflow the buffer.
400 * Changed so that we don't dump inventory either. This may
401 * also overflow the buffer.
402 */
403 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404 strcat (errmsg, cp);
405 for (tmp = op->inv; tmp; tmp = tmp->below)
406 dump_object2 (tmp);
407# endif
408 strcat (errmsg, "end\n");
409 }
410 else
411 {
412 strcat (errmsg, "Object ");
413 if (op->name == NULL)
414 strcat (errmsg, "(null)");
415 else
416 strcat (errmsg, op->name);
417 strcat (errmsg, "\n");
418# if 0
419 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420 strcat (errmsg, cp);
421 for (tmp = op->inv; tmp; tmp = tmp->below)
422 dump_object2 (tmp);
423# endif
424 strcat (errmsg, "end\n");
425 }
426#endif
427}
428
429/*
430 * Dumps an object. Returns output in the static global errmsg array.
431 */
432
433void
434dump_object (object *op) 363dump_object (object *op)
435{ 364{
436 if (op == NULL) 365 if (!op)
437 { 366 return strdup ("[NULLOBJ]");
438 strcpy (errmsg, "[NULL pointer]");
439 return;
440 }
441 errmsg[0] = '\0';
442 dump_object2 (op);
443}
444 367
445void 368 object_freezer freezer;
446dump_all_objects (void) 369 save_object (freezer, op, 3);
447{ 370 return freezer.as_string ();
448 object *op;
449
450 for (op = object::first; op != NULL; op = op->next)
451 {
452 dump_object (op);
453 fprintf (logfile, "Object %s\n", errmsg);
454 }
455} 371}
456 372
457/* 373/*
458 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
459 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
479 */ 395 */
480 396
481object * 397object *
482find_object (tag_t i) 398find_object (tag_t i)
483{ 399{
484 object *op;
485
486 for (op = object::first; op != NULL; op = op->next) 400 for (object *op = object::first; op; op = op->next)
487 if (op->count == i) 401 if (op->count == i)
488 break; 402 return op;
489 403
490 return op; 404 return 0;
491} 405}
492 406
493/* 407/*
494 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
495 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
553 } 467 }
554 468
555 op->key_values = 0; 469 op->key_values = 0;
556} 470}
557 471
558void object::clear ()
559{
560 attachable_base::clear ();
561
562 free_key_values (this);
563
564 owner = 0;
565 name = 0;
566 name_pl = 0;
567 title = 0;
568 race = 0;
569 slaying = 0;
570 skill = 0;
571 msg = 0;
572 lore = 0;
573 custom_name = 0;
574 materialname = 0;
575 contr = 0;
576 below = 0;
577 above = 0;
578 inv = 0;
579 container = 0;
580 env = 0;
581 more = 0;
582 head = 0;
583 map = 0;
584 active_next = 0;
585 active_prev = 0;
586
587 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
588
589 SET_FLAG (this, FLAG_REMOVED);
590
591 /* What is not cleared is next, prev, and count */
592
593 expmul = 1.0;
594 face = blank_face;
595
596 if (settings.casting_time)
597 casting_time = -1;
598}
599
600void object::clone (object *destination)
601{
602 *(object_copy *)destination = *this;
603 *(object_pod *)destination = *this;
604
605 if (self || cb)
606 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
607}
608
609/* 472/*
610 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
611 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
612 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
613 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
614 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
615 * will point at garbage. 478 * will point at garbage.
616 */ 479 */
617void 480void
618copy_object (object *op2, object *op) 481object::copy_to (object *dst)
619{ 482{
620 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
621 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
622 485
623 op2->clone (op); 486 *(object_copy *)dst = *this;
624 487
625 if (is_freed) 488 if (is_freed)
626 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
490
627 if (is_removed) 491 if (is_removed)
628 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
629 493
630 if (op2->speed < 0) 494 if (speed < 0)
631 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
632 496
633 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
634 if (op2->key_values) 498 if (key_values)
635 { 499 {
636 key_value *tail = 0; 500 key_value *tail = 0;
637 key_value *i; 501 key_value *i;
638 502
639 op->key_values = 0; 503 dst->key_values = 0;
640 504
641 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
642 { 506 {
643 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
644 508
645 new_link->next = 0; 509 new_link->next = 0;
646 new_link->key = i->key; 510 new_link->key = i->key;
647 new_link->value = i->value; 511 new_link->value = i->value;
648 512
649 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
650 if (!op->key_values) 514 if (!dst->key_values)
651 { 515 {
652 op->key_values = new_link; 516 dst->key_values = new_link;
653 tail = new_link; 517 tail = new_link;
654 } 518 }
655 else 519 else
656 { 520 {
657 tail->next = new_link; 521 tail->next = new_link;
658 tail = new_link; 522 tail = new_link;
659 } 523 }
660 } 524 }
661 } 525 }
662 526
663 update_ob_speed (op); 527 update_ob_speed (dst);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
664} 536}
665 537
666/* 538/*
667 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
668 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
776 op->active_next = NULL; 648 op->active_next = NULL;
777 op->active_prev = NULL; 649 op->active_prev = NULL;
778} 650}
779 651
780/* 652/*
781 * update_object() updates the array which represents the map. 653 * update_object() updates the the map.
782 * It takes into account invisible objects (and represent squares covered 654 * It takes into account invisible objects (and represent squares covered
783 * by invisible objects by whatever is below them (unless it's another 655 * by invisible objects by whatever is below them (unless it's another
784 * invisible object, etc...) 656 * invisible object, etc...)
785 * If the object being updated is beneath a player, the look-window 657 * If the object being updated is beneath a player, the look-window
786 * of that player is updated (this might be a suboptimal way of 658 * of that player is updated (this might be a suboptimal way of
787 * updating that window, though, since update_object() is called _often_) 659 * updating that window, though, since update_object() is called _often_)
788 * 660 *
789 * action is a hint of what the caller believes need to be done. 661 * action is a hint of what the caller believes need to be done.
790 * For example, if the only thing that has changed is the face (due to
791 * an animation), we don't need to call update_position until that actually
792 * comes into view of a player. OTOH, many other things, like addition/removal
793 * of walls or living creatures may need us to update the flags now.
794 * current action are: 662 * current action are:
795 * UP_OBJ_INSERT: op was inserted 663 * UP_OBJ_INSERT: op was inserted
796 * UP_OBJ_REMOVE: op was removed 664 * UP_OBJ_REMOVE: op was removed
797 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 665 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
798 * as that is easier than trying to look at what may have changed. 666 * as that is easier than trying to look at what may have changed.
799 * UP_OBJ_FACE: only the objects face has changed. 667 * UP_OBJ_FACE: only the objects face has changed.
800 */ 668 */
801
802void 669void
803update_object (object *op, int action) 670update_object (object *op, int action)
804{ 671{
805 int update_now = 0, flags;
806 MoveType move_on, move_off, move_block, move_slow; 672 MoveType move_on, move_off, move_block, move_slow;
807 673
808 if (op == NULL) 674 if (op == NULL)
809 { 675 {
810 /* this should never happen */ 676 /* this should never happen */
811 LOG (llevDebug, "update_object() called for NULL object.\n"); 677 LOG (llevDebug, "update_object() called for NULL object.\n");
812 return; 678 return;
813 } 679 }
814 680
815 if (op->env != NULL) 681 if (op->env)
816 { 682 {
817 /* Animation is currently handled by client, so nothing 683 /* Animation is currently handled by client, so nothing
818 * to do in this case. 684 * to do in this case.
819 */ 685 */
820 return; 686 return;
825 */ 691 */
826 if (!op->map || op->map->in_memory == MAP_SAVING) 692 if (!op->map || op->map->in_memory == MAP_SAVING)
827 return; 693 return;
828 694
829 /* make sure the object is within map boundaries */ 695 /* make sure the object is within map boundaries */
830 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 696 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
831 { 697 {
832 LOG (llevError, "update_object() called for object out of map!\n"); 698 LOG (llevError, "update_object() called for object out of map!\n");
833#ifdef MANY_CORES 699#ifdef MANY_CORES
834 abort (); 700 abort ();
835#endif 701#endif
836 return; 702 return;
837 } 703 }
838 704
839 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 705 mapspace &m = op->ms ();
840 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
841 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
842 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
843 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
844 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
845 706
707 if (m.flags_ & P_NEED_UPDATE)
708 /* nop */;
846 if (action == UP_OBJ_INSERT) 709 else if (action == UP_OBJ_INSERT)
847 { 710 {
711 // this is likely overkill, TODO: revisit (schmorp)
848 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 712 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
849 update_now = 1;
850
851 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 713 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
852 update_now = 1; 714 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
853 715 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
716 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
854 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 717 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
858 update_now = 1;
859
860 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
861 update_now = 1;
862
863 if ((move_on | op->move_on) != move_on) 718 || (m.move_on | op->move_on ) != m.move_on
864 update_now = 1;
865
866 if ((move_off | op->move_off) != move_off) 719 || (m.move_off | op->move_off ) != m.move_off
867 update_now = 1; 720 || (m.move_slow | op->move_slow) != m.move_slow
868
869 /* This isn't perfect, but I don't expect a lot of objects to 721 /* This isn't perfect, but I don't expect a lot of objects to
870 * to have move_allow right now. 722 * to have move_allow right now.
871 */ 723 */
872 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 724 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
873 update_now = 1; 725 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
874 726 m.flags_ = P_NEED_UPDATE;
875 if ((move_slow | op->move_slow) != move_slow)
876 update_now = 1;
877 } 727 }
878 /* if the object is being removed, we can't make intelligent 728 /* if the object is being removed, we can't make intelligent
879 * decisions, because remove_ob can't really pass the object 729 * decisions, because remove_ob can't really pass the object
880 * that is being removed. 730 * that is being removed.
881 */ 731 */
882 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 732 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
883 update_now = 1; 733 m.flags_ = P_NEED_UPDATE;
884 else if (action == UP_OBJ_FACE) 734 else if (action == UP_OBJ_FACE)
885 /* Nothing to do for that case */ ; 735 /* Nothing to do for that case */ ;
886 else 736 else
887 LOG (llevError, "update_object called with invalid action: %d\n", action); 737 LOG (llevError, "update_object called with invalid action: %d\n", action);
888 738
889 if (update_now)
890 {
891 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
892 update_position (op->map, op->x, op->y);
893 }
894
895 if (op->more != NULL) 739 if (op->more)
896 update_object (op->more, action); 740 update_object (op->more, action);
897} 741}
898 742
899object::vector object::mortals;
900object::vector object::objects; // not yet used 743object::vector object::objects; // not yet used
901object *object::first; 744object *object::first;
902
903void object::free_mortals ()
904{
905 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
906 if ((*i)->refcnt)
907 ++i; // further delay freeing
908 else
909 {
910 delete *i;
911 mortals.erase (i);
912 }
913
914 static int lastmortals = 0;//D
915
916 if (mortals.size() != lastmortals && lastmortals > 100)//D
917 {
918 lastmortals = mortals.size ();//D
919 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
920 }
921}
922 745
923object::object () 746object::object ()
924{ 747{
925 SET_FLAG (this, FLAG_REMOVED); 748 SET_FLAG (this, FLAG_REMOVED);
926 749
975 * this function to succeed. 798 * this function to succeed.
976 * 799 *
977 * If destroy_inventory is set, free inventory as well. Else drop items in 800 * If destroy_inventory is set, free inventory as well. Else drop items in
978 * inventory to the ground. 801 * inventory to the ground.
979 */ 802 */
980void object::destroy (bool destroy_inventory) 803void
804object::do_destroy ()
981{ 805{
982 if (QUERY_FLAG (this, FLAG_FREED)) 806 attachable::do_destroy ();
807
808 if (flag [FLAG_IS_LINKED])
809 remove_button_link (this);
810
811 if (flag [FLAG_FRIENDLY])
812 remove_friendly_object (this);
813
814 if (!flag [FLAG_REMOVED])
815 remove ();
816
817 if (flag [FLAG_FREED])
983 return; 818 return;
984 819
985 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 820 flag [FLAG_FREED] = 1;
986 remove_friendly_object (this);
987 821
988 if (!QUERY_FLAG (this, FLAG_REMOVED)) 822 // hack to ensure that freed objects still have a valid map
989 remove_ob (this);
990
991 SET_FLAG (this, FLAG_FREED);
992
993 if (more)
994 { 823 {
995 more->destroy (destroy_inventory); 824 static maptile *freed_map; // freed objects are moved here to avoid crashes
996 more = 0;
997 }
998 825
999 if (inv) 826 if (!freed_map)
1000 {
1001 /* Only if the space blocks everything do we not process -
1002 * if some form of movement is allowed, let objects
1003 * drop on that space.
1004 */
1005 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1006 { 827 {
1007 object *op = inv; 828 freed_map = new maptile;
1008 829
1009 while (op) 830 freed_map->name = "/internal/freed_objects_map";
1010 { 831 freed_map->width = 3;
1011 object *tmp = op->below; 832 freed_map->height = 3;
1012 op->destroy (destroy_inventory); 833
1013 op = tmp; 834 freed_map->allocate ();
1014 }
1015 } 835 }
1016 else
1017 { /* Put objects in inventory onto this space */
1018 object *op = inv;
1019 836
1020 while (op) 837 map = freed_map;
1021 { 838 x = 1;
1022 object *tmp = op->below; 839 y = 1;
1023
1024 remove_ob (op);
1025
1026 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1027 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1028 free_object (op);
1029 else
1030 {
1031 op->x = x;
1032 op->y = y;
1033 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1034 }
1035
1036 op = tmp;
1037 }
1038 }
1039 } 840 }
841
842 more = 0;
843 head = 0;
844 inv = 0;
1040 845
1041 // clear those pointers that likely might have circular references to us 846 // clear those pointers that likely might have circular references to us
1042 owner = 0; 847 owner = 0;
1043 enemy = 0; 848 enemy = 0;
1044 attacked_by = 0; 849 attacked_by = 0;
1049 /* Remove object from the active list */ 854 /* Remove object from the active list */
1050 speed = 0; 855 speed = 0;
1051 update_ob_speed (this); 856 update_ob_speed (this);
1052 857
1053 unlink (); 858 unlink ();
859}
1054 860
1055 mortals.push_back (this); 861/*
862 * Remove and free all objects in the inventory of the given object.
863 * object.c ?
864 */
865void
866object::destroy_inv (bool drop_to_ground)
867{
868 if (!inv)
869 return;
870
871 /* Only if the space blocks everything do we not process -
872 * if some form of movement is allowed, let objects
873 * drop on that space.
874 */
875 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
876 {
877 while (inv)
878 {
879 inv->destroy_inv (drop_to_ground);
880 inv->destroy ();
881 }
882 }
883 else
884 { /* Put objects in inventory onto this space */
885 while (inv)
886 {
887 object *op = inv;
888
889 if (op->flag [FLAG_STARTEQUIP]
890 || op->flag [FLAG_NO_DROP]
891 || op->type == RUNE
892 || op->type == TRAP
893 || op->flag [FLAG_IS_A_TEMPLATE])
894 op->destroy ();
895 else
896 {
897 op->remove ();
898 op->x = x;
899 op->y = y;
900 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
901 }
902 }
903 }
904}
905
906void
907object::destroy (bool destroy_inventory)
908{
909 if (destroyed ())
910 return;
911
912 if (more)
913 {
914 //TODO: non-head objects must not have inventory
915 more->destroy (destroy_inventory);
916 more = 0;
917 }
918
919 if (destroy_inventory)
920 destroy_inv (true);
921
922 attachable::destroy ();
1056} 923}
1057 924
1058/* 925/*
1059 * sub_weight() recursively (outwards) subtracts a number from the 926 * sub_weight() recursively (outwards) subtracts a number from the
1060 * weight of an object (and what is carried by it's environment(s)). 927 * weight of an object (and what is carried by it's environment(s)).
1061 */ 928 */
1062
1063void 929void
1064sub_weight (object *op, signed long weight) 930sub_weight (object *op, signed long weight)
1065{ 931{
1066 while (op != NULL) 932 while (op != NULL)
1067 { 933 {
1071 op->carrying -= weight; 937 op->carrying -= weight;
1072 op = op->env; 938 op = op->env;
1073 } 939 }
1074} 940}
1075 941
1076/* remove_ob(op): 942/* op->remove ():
1077 * This function removes the object op from the linked list of objects 943 * This function removes the object op from the linked list of objects
1078 * which it is currently tied to. When this function is done, the 944 * which it is currently tied to. When this function is done, the
1079 * object will have no environment. If the object previously had an 945 * object will have no environment. If the object previously had an
1080 * environment, the x and y coordinates will be updated to 946 * environment, the x and y coordinates will be updated to
1081 * the previous environment. 947 * the previous environment.
1082 * Beware: This function is called from the editor as well! 948 * Beware: This function is called from the editor as well!
1083 */ 949 */
1084
1085void 950void
1086remove_ob (object *op) 951object::remove ()
1087{ 952{
1088 object *tmp, *last = 0; 953 object *tmp, *last = 0;
1089 object *otmp; 954 object *otmp;
1090 955
1091 int check_walk_off;
1092 maptile *m;
1093
1094 sint16 x, y;
1095
1096 if (QUERY_FLAG (op, FLAG_REMOVED)) 956 if (QUERY_FLAG (this, FLAG_REMOVED))
1097 return; 957 return;
1098 958
1099 SET_FLAG (op, FLAG_REMOVED); 959 SET_FLAG (this, FLAG_REMOVED);
960 INVOKE_OBJECT (REMOVE, this);
1100 961
1101 if (op->more != NULL) 962 if (more)
1102 remove_ob (op->more); 963 more->remove ();
1103 964
1104 /* 965 /*
1105 * In this case, the object to be removed is in someones 966 * In this case, the object to be removed is in someones
1106 * inventory. 967 * inventory.
1107 */ 968 */
1108 if (op->env != NULL) 969 if (env)
1109 { 970 {
1110 if (op->nrof) 971 if (nrof)
1111 sub_weight (op->env, op->weight * op->nrof); 972 sub_weight (env, weight * nrof);
1112 else 973 else
1113 sub_weight (op->env, op->weight + op->carrying); 974 sub_weight (env, weight + carrying);
1114 975
1115 /* NO_FIX_PLAYER is set when a great many changes are being 976 /* NO_FIX_PLAYER is set when a great many changes are being
1116 * made to players inventory. If set, avoiding the call 977 * made to players inventory. If set, avoiding the call
1117 * to save cpu time. 978 * to save cpu time.
1118 */ 979 */
1119 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 980 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1120 fix_player (otmp); 981 otmp->update_stats ();
1121 982
1122 if (op->above != NULL) 983 if (above != NULL)
1123 op->above->below = op->below; 984 above->below = below;
1124 else 985 else
1125 op->env->inv = op->below; 986 env->inv = below;
1126 987
1127 if (op->below != NULL) 988 if (below != NULL)
1128 op->below->above = op->above; 989 below->above = above;
1129 990
1130 /* we set up values so that it could be inserted into 991 /* we set up values so that it could be inserted into
1131 * the map, but we don't actually do that - it is up 992 * the map, but we don't actually do that - it is up
1132 * to the caller to decide what we want to do. 993 * to the caller to decide what we want to do.
1133 */ 994 */
1134 op->x = op->env->x, op->y = op->env->y; 995 x = env->x, y = env->y;
1135 op->map = op->env->map; 996 map = env->map;
1136 op->above = NULL, op->below = NULL; 997 above = 0, below = 0;
1137 op->env = NULL; 998 env = 0;
1138 } 999 }
1139 else if (op->map) 1000 else if (map)
1140 { 1001 {
1141 x = op->x;
1142 y = op->y;
1143 m = get_map_from_coord (op->map, &x, &y);
1144
1145 if (!m)
1146 {
1147 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1148 op->map->path, op->x, op->y);
1149 /* in old days, we used to set x and y to 0 and continue.
1150 * it seems if we get into this case, something is probablye
1151 * screwed up and should be fixed.
1152 */
1153 abort ();
1154 }
1155
1156 if (op->map != m)
1157 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1158 op->map->path, m->path, op->x, op->y, x, y);
1159
1160 /* Re did the following section of code - it looks like it had 1002 /* Re did the following section of code - it looks like it had
1161 * lots of logic for things we no longer care about 1003 * lots of logic for things we no longer care about
1162 */ 1004 */
1163 1005
1164 /* link the object above us */ 1006 /* link the object above us */
1165 if (op->above) 1007 if (above)
1166 op->above->below = op->below; 1008 above->below = below;
1167 else 1009 else
1168 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1010 map->at (x, y).top = below; /* we were top, set new top */
1169 1011
1170 /* Relink the object below us, if there is one */ 1012 /* Relink the object below us, if there is one */
1171 if (op->below) 1013 if (below)
1172 op->below->above = op->above; 1014 below->above = above;
1173 else 1015 else
1174 { 1016 {
1175 /* Nothing below, which means we need to relink map object for this space 1017 /* Nothing below, which means we need to relink map object for this space
1176 * use translated coordinates in case some oddness with map tiling is 1018 * use translated coordinates in case some oddness with map tiling is
1177 * evident 1019 * evident
1178 */ 1020 */
1179 if (GET_MAP_OB (m, x, y) != op) 1021 if (GET_MAP_OB (map, x, y) != this)
1180 { 1022 {
1181 dump_object (op); 1023 char *dump = dump_object (this);
1182 LOG (llevError, 1024 LOG (llevError,
1183 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1025 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1026 free (dump);
1184 dump_object (GET_MAP_OB (m, x, y)); 1027 dump = dump_object (GET_MAP_OB (map, x, y));
1185 LOG (llevError, "%s\n", errmsg); 1028 LOG (llevError, "%s\n", dump);
1029 free (dump);
1186 } 1030 }
1187 1031
1188 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1032 map->at (x, y).bot = above; /* goes on above it. */
1189 } 1033 }
1190 1034
1191 op->above = 0; 1035 above = 0;
1192 op->below = 0; 1036 below = 0;
1193 1037
1194 if (op->map->in_memory == MAP_SAVING) 1038 if (map->in_memory == MAP_SAVING)
1195 return; 1039 return;
1196 1040
1197 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1041 int check_walk_off = !flag [FLAG_NO_APPLY];
1198 1042
1199 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1043 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1200 { 1044 {
1201 /* No point updating the players look faces if he is the object 1045 /* No point updating the players look faces if he is the object
1202 * being removed. 1046 * being removed.
1203 */ 1047 */
1204 1048
1205 if (tmp->type == PLAYER && tmp != op) 1049 if (tmp->type == PLAYER && tmp != this)
1206 { 1050 {
1207 /* If a container that the player is currently using somehow gets 1051 /* If a container that the player is currently using somehow gets
1208 * removed (most likely destroyed), update the player view 1052 * removed (most likely destroyed), update the player view
1209 * appropriately. 1053 * appropriately.
1210 */ 1054 */
1211 if (tmp->container == op) 1055 if (tmp->container == this)
1212 { 1056 {
1213 CLEAR_FLAG (op, FLAG_APPLIED); 1057 flag [FLAG_APPLIED] = 0;
1214 tmp->container = NULL; 1058 tmp->container = 0;
1215 } 1059 }
1216 1060
1217 tmp->contr->socket.update_look = 1; 1061 if (tmp->contr->ns)
1062 tmp->contr->ns->floorbox_update ();
1218 } 1063 }
1219 1064
1220 /* See if player moving off should effect something */ 1065 /* See if player moving off should effect something */
1221 if (check_walk_off 1066 if (check_walk_off
1222 && ((op->move_type & tmp->move_off) 1067 && ((move_type & tmp->move_off)
1223 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1068 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1224 { 1069 {
1225 move_apply (tmp, op, NULL); 1070 move_apply (tmp, this, 0);
1226 1071
1227 if (op->destroyed ()) 1072 if (destroyed ())
1228 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1073 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1229 } 1074 }
1230 1075
1231 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1076 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1232 1077
1233 if (tmp->above == tmp) 1078 if (tmp->above == tmp)
1234 tmp->above = NULL; 1079 tmp->above = 0;
1235 1080
1236 last = tmp; 1081 last = tmp;
1237 } 1082 }
1238 1083
1239 /* last == NULL of there are no objects on this space */ 1084 /* last == NULL of there are no objects on this space */
1240 if (last == NULL) 1085 if (!last)
1241 { 1086 map->at (x, y).flags_ = P_NEED_UPDATE;
1242 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1243 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1244 * those out anyways, and if there are any flags set right now, they won't
1245 * be correct anyways.
1246 */
1247 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1248 update_position (op->map, op->x, op->y);
1249 }
1250 else 1087 else
1251 update_object (last, UP_OBJ_REMOVE); 1088 update_object (last, UP_OBJ_REMOVE);
1252 1089
1253 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1090 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1254 update_all_los (op->map, op->x, op->y); 1091 update_all_los (map, x, y);
1255 } 1092 }
1256} 1093}
1257 1094
1258/* 1095/*
1259 * merge_ob(op,top): 1096 * merge_ob(op,top):
1267merge_ob (object *op, object *top) 1104merge_ob (object *op, object *top)
1268{ 1105{
1269 if (!op->nrof) 1106 if (!op->nrof)
1270 return 0; 1107 return 0;
1271 1108
1272 if (top == NULL) 1109 if (top)
1273 for (top = op; top != NULL && top->above != NULL; top = top->above); 1110 for (top = op; top && top->above; top = top->above)
1111 ;
1274 1112
1275 for (; top != NULL; top = top->below) 1113 for (; top; top = top->below)
1276 { 1114 {
1277 if (top == op) 1115 if (top == op)
1278 continue; 1116 continue;
1279 if (CAN_MERGE (op, top)) 1117
1118 if (object::can_merge (op, top))
1280 { 1119 {
1281 top->nrof += op->nrof; 1120 top->nrof += op->nrof;
1282 1121
1283/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1122/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1284 op->weight = 0; /* Don't want any adjustements now */ 1123 op->weight = 0; /* Don't want any adjustements now */
1285 remove_ob (op); 1124 op->destroy ();
1286 free_object (op);
1287 return top; 1125 return top;
1288 } 1126 }
1289 } 1127 }
1290 1128
1291 return 0; 1129 return 0;
1330 * Return value: 1168 * Return value:
1331 * new object if 'op' was merged with other object 1169 * new object if 'op' was merged with other object
1332 * NULL if 'op' was destroyed 1170 * NULL if 'op' was destroyed
1333 * just 'op' otherwise 1171 * just 'op' otherwise
1334 */ 1172 */
1335
1336object * 1173object *
1337insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1174insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1338{ 1175{
1339 object *tmp, *top, *floor = NULL; 1176 object *tmp, *top, *floor = NULL;
1340 sint16 x, y; 1177 sint16 x, y;
1345 return NULL; 1182 return NULL;
1346 } 1183 }
1347 1184
1348 if (m == NULL) 1185 if (m == NULL)
1349 { 1186 {
1350 dump_object (op); 1187 char *dump = dump_object (op);
1351 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1188 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1189 free (dump);
1352 return op; 1190 return op;
1353 } 1191 }
1354 1192
1355 if (out_of_map (m, op->x, op->y)) 1193 if (out_of_map (m, op->x, op->y))
1356 { 1194 {
1357 dump_object (op); 1195 char *dump = dump_object (op);
1358 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1196 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1359#ifdef MANY_CORES 1197#ifdef MANY_CORES
1360 /* Better to catch this here, as otherwise the next use of this object 1198 /* Better to catch this here, as otherwise the next use of this object
1361 * is likely to cause a crash. Better to find out where it is getting 1199 * is likely to cause a crash. Better to find out where it is getting
1362 * improperly inserted. 1200 * improperly inserted.
1363 */ 1201 */
1364 abort (); 1202 abort ();
1365#endif 1203#endif
1204 free (dump);
1366 return op; 1205 return op;
1367 } 1206 }
1368 1207
1369 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1208 if (!QUERY_FLAG (op, FLAG_REMOVED))
1370 { 1209 {
1371 dump_object (op); 1210 char *dump = dump_object (op);
1372 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1211 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1212 free (dump);
1373 return op; 1213 return op;
1374 } 1214 }
1375 1215
1376 if (op->more != NULL) 1216 if (op->more)
1377 { 1217 {
1378 /* The part may be on a different map. */ 1218 /* The part may be on a different map. */
1379 1219
1380 object *more = op->more; 1220 object *more = op->more;
1381 1221
1397 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1237 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1398 { 1238 {
1399 if (!op->head) 1239 if (!op->head)
1400 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1240 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1401 1241
1402 return NULL; 1242 return 0;
1403 } 1243 }
1404 } 1244 }
1405 1245
1406 CLEAR_FLAG (op, FLAG_REMOVED); 1246 CLEAR_FLAG (op, FLAG_REMOVED);
1407 1247
1415 1255
1416 /* this has to be done after we translate the coordinates. 1256 /* this has to be done after we translate the coordinates.
1417 */ 1257 */
1418 if (op->nrof && !(flag & INS_NO_MERGE)) 1258 if (op->nrof && !(flag & INS_NO_MERGE))
1419 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1259 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1420 if (CAN_MERGE (op, tmp)) 1260 if (object::can_merge (op, tmp))
1421 { 1261 {
1422 op->nrof += tmp->nrof; 1262 op->nrof += tmp->nrof;
1423 remove_ob (tmp); 1263 tmp->destroy ();
1424 free_object (tmp);
1425 } 1264 }
1426 1265
1427 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1266 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1428 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1267 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1429 1268
1442 op->below = originator->below; 1281 op->below = originator->below;
1443 1282
1444 if (op->below) 1283 if (op->below)
1445 op->below->above = op; 1284 op->below->above = op;
1446 else 1285 else
1447 SET_MAP_OB (op->map, op->x, op->y, op); 1286 op->ms ().bot = op;
1448 1287
1449 /* since *below* originator, no need to update top */ 1288 /* since *below* originator, no need to update top */
1450 originator->below = op; 1289 originator->below = op;
1451 } 1290 }
1452 else 1291 else
1498 * If INS_ON_TOP is used, don't do this processing 1337 * If INS_ON_TOP is used, don't do this processing
1499 * Need to find the object that in fact blocks view, otherwise 1338 * Need to find the object that in fact blocks view, otherwise
1500 * stacking is a bit odd. 1339 * stacking is a bit odd.
1501 */ 1340 */
1502 if (!(flag & INS_ON_TOP) && 1341 if (!(flag & INS_ON_TOP) &&
1503 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1342 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1504 { 1343 {
1505 for (last = top; last != floor; last = last->below) 1344 for (last = top; last != floor; last = last->below)
1506 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1345 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1507 break; 1346 break;
1508 /* Check to see if we found the object that blocks view, 1347 /* Check to see if we found the object that blocks view,
1531 1370
1532 if (op->above) 1371 if (op->above)
1533 op->above->below = op; 1372 op->above->below = op;
1534 1373
1535 op->below = NULL; 1374 op->below = NULL;
1536 SET_MAP_OB (op->map, op->x, op->y, op); 1375 op->ms ().bot = op;
1537 } 1376 }
1538 else 1377 else
1539 { /* get inserted into the stack above top */ 1378 { /* get inserted into the stack above top */
1540 op->above = top->above; 1379 op->above = top->above;
1541 1380
1545 op->below = top; 1384 op->below = top;
1546 top->above = op; 1385 top->above = op;
1547 } 1386 }
1548 1387
1549 if (op->above == NULL) 1388 if (op->above == NULL)
1550 SET_MAP_TOP (op->map, op->x, op->y, op); 1389 op->ms ().top = op;
1551 } /* else not INS_BELOW_ORIGINATOR */ 1390 } /* else not INS_BELOW_ORIGINATOR */
1552 1391
1553 if (op->type == PLAYER) 1392 if (op->type == PLAYER)
1554 op->contr->do_los = 1; 1393 op->contr->do_los = 1;
1555 1394
1556 /* If we have a floor, we know the player, if any, will be above 1395 /* If we have a floor, we know the player, if any, will be above
1557 * it, so save a few ticks and start from there. 1396 * it, so save a few ticks and start from there.
1558 */ 1397 */
1559 if (!(flag & INS_MAP_LOAD)) 1398 if (!(flag & INS_MAP_LOAD))
1560 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1399 if (object *pl = op->ms ().player ())
1561 if (tmp->type == PLAYER) 1400 if (pl->contr->ns)
1562 tmp->contr->socket.update_look = 1; 1401 pl->contr->ns->floorbox_update ();
1563 1402
1564 /* If this object glows, it may affect lighting conditions that are 1403 /* If this object glows, it may affect lighting conditions that are
1565 * visible to others on this map. But update_all_los is really 1404 * visible to others on this map. But update_all_los is really
1566 * an inefficient way to do this, as it means los for all players 1405 * an inefficient way to do this, as it means los for all players
1567 * on the map will get recalculated. The players could very well 1406 * on the map will get recalculated. The players could very well
1568 * be far away from this change and not affected in any way - 1407 * be far away from this change and not affected in any way -
1569 * this should get redone to only look for players within range, 1408 * this should get redone to only look for players within range,
1570 * or just updating the P_NEED_UPDATE for spaces within this area 1409 * or just updating the P_NEED_UPDATE for spaces within this area
1571 * of effect may be sufficient. 1410 * of effect may be sufficient.
1572 */ 1411 */
1573 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1412 if (op->map->darkness && (op->glow_radius != 0))
1574 update_all_los (op->map, op->x, op->y); 1413 update_all_los (op->map, op->x, op->y);
1575 1414
1576 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1415 /* updates flags (blocked, alive, no magic, etc) for this map space */
1577 update_object (op, UP_OBJ_INSERT); 1416 update_object (op, UP_OBJ_INSERT);
1578 1417
1418 INVOKE_OBJECT (INSERT, op);
1419
1579 /* Don't know if moving this to the end will break anything. However, 1420 /* Don't know if moving this to the end will break anything. However,
1580 * we want to have update_look set above before calling this. 1421 * we want to have floorbox_update called before calling this.
1581 * 1422 *
1582 * check_move_on() must be after this because code called from 1423 * check_move_on() must be after this because code called from
1583 * check_move_on() depends on correct map flags (so functions like 1424 * check_move_on() depends on correct map flags (so functions like
1584 * blocked() and wall() work properly), and these flags are updated by 1425 * blocked() and wall() work properly), and these flags are updated by
1585 * update_object(). 1426 * update_object().
1587 1428
1588 /* if this is not the head or flag has been passed, don't check walk on status */ 1429 /* if this is not the head or flag has been passed, don't check walk on status */
1589 if (!(flag & INS_NO_WALK_ON) && !op->head) 1430 if (!(flag & INS_NO_WALK_ON) && !op->head)
1590 { 1431 {
1591 if (check_move_on (op, originator)) 1432 if (check_move_on (op, originator))
1592 return NULL; 1433 return 0;
1593 1434
1594 /* If we are a multi part object, lets work our way through the check 1435 /* If we are a multi part object, lets work our way through the check
1595 * walk on's. 1436 * walk on's.
1596 */ 1437 */
1597 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1438 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1598 if (check_move_on (tmp, originator)) 1439 if (check_move_on (tmp, originator))
1599 return NULL; 1440 return 0;
1600 } 1441 }
1601 1442
1602 return op; 1443 return op;
1603} 1444}
1604 1445
1605/* this function inserts an object in the map, but if it 1446/* this function inserts an object in the map, but if it
1606 * finds an object of its own type, it'll remove that one first. 1447 * finds an object of its own type, it'll remove that one first.
1607 * op is the object to insert it under: supplies x and the map. 1448 * op is the object to insert it under: supplies x and the map.
1608 */ 1449 */
1609void 1450void
1610replace_insert_ob_in_map (const char *arch_string, object *op) 1451replace_insert_ob_in_map (const char *arch_string, object *op)
1611{ 1452{
1612 object * 1453 object *tmp, *tmp1;
1613 tmp;
1614 object *
1615 tmp1;
1616 1454
1617 /* first search for itself and remove any old instances */ 1455 /* first search for itself and remove any old instances */
1618 1456
1619 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1457 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1620 {
1621 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1458 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1622 { 1459 tmp->destroy ();
1623 remove_ob (tmp);
1624 free_object (tmp);
1625 }
1626 }
1627 1460
1628 tmp1 = arch_to_object (archetype::find (arch_string)); 1461 tmp1 = arch_to_object (archetype::find (arch_string));
1629 1462
1630 tmp1->x = op->x; 1463 tmp1->x = op->x;
1631 tmp1->y = op->y; 1464 tmp1->y = op->y;
1641 */ 1474 */
1642 1475
1643object * 1476object *
1644get_split_ob (object *orig_ob, uint32 nr) 1477get_split_ob (object *orig_ob, uint32 nr)
1645{ 1478{
1646 object * 1479 object *newob;
1647 newob;
1648 int
1649 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1480 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1650 1481
1651 if (orig_ob->nrof < nr) 1482 if (orig_ob->nrof < nr)
1652 { 1483 {
1653 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1484 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1654 return NULL; 1485 return NULL;
1655 } 1486 }
1656 1487
1657 newob = object_create_clone (orig_ob); 1488 newob = object_create_clone (orig_ob);
1658 1489
1659 if ((orig_ob->nrof -= nr) < 1) 1490 if ((orig_ob->nrof -= nr) < 1)
1660 { 1491 orig_ob->destroy (1);
1661 if (!is_removed)
1662 remove_ob (orig_ob);
1663 free_object2 (orig_ob, 1);
1664 }
1665 else if (!is_removed) 1492 else if (!is_removed)
1666 { 1493 {
1667 if (orig_ob->env != NULL) 1494 if (orig_ob->env != NULL)
1668 sub_weight (orig_ob->env, orig_ob->weight * nr); 1495 sub_weight (orig_ob->env, orig_ob->weight * nr);
1669 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1496 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1689 1516
1690object * 1517object *
1691decrease_ob_nr (object *op, uint32 i) 1518decrease_ob_nr (object *op, uint32 i)
1692{ 1519{
1693 object *tmp; 1520 object *tmp;
1694 player *pl;
1695 1521
1696 if (i == 0) /* objects with op->nrof require this check */ 1522 if (i == 0) /* objects with op->nrof require this check */
1697 return op; 1523 return op;
1698 1524
1699 if (i > op->nrof) 1525 if (i > op->nrof)
1700 i = op->nrof; 1526 i = op->nrof;
1701 1527
1702 if (QUERY_FLAG (op, FLAG_REMOVED)) 1528 if (QUERY_FLAG (op, FLAG_REMOVED))
1703 op->nrof -= i; 1529 op->nrof -= i;
1704 else if (op->env != NULL) 1530 else if (op->env)
1705 { 1531 {
1706 /* is this object in the players inventory, or sub container 1532 /* is this object in the players inventory, or sub container
1707 * therein? 1533 * therein?
1708 */ 1534 */
1709 tmp = is_player_inv (op->env); 1535 tmp = op->in_player ();
1710 /* nope. Is this a container the player has opened? 1536 /* nope. Is this a container the player has opened?
1711 * If so, set tmp to that player. 1537 * If so, set tmp to that player.
1712 * IMO, searching through all the players will mostly 1538 * IMO, searching through all the players will mostly
1713 * likely be quicker than following op->env to the map, 1539 * likely be quicker than following op->env to the map,
1714 * and then searching the map for a player. 1540 * and then searching the map for a player.
1715 */ 1541 */
1716 if (!tmp) 1542 if (!tmp)
1717 { 1543 for_all_players (pl)
1718 for (pl = first_player; pl; pl = pl->next)
1719 if (pl->ob->container == op->env) 1544 if (pl->ob->container == op->env)
1545 {
1546 tmp = pl->ob;
1720 break; 1547 break;
1721 if (pl)
1722 tmp = pl->ob;
1723 else
1724 tmp = NULL;
1725 } 1548 }
1726 1549
1727 if (i < op->nrof) 1550 if (i < op->nrof)
1728 { 1551 {
1729 sub_weight (op->env, op->weight * i); 1552 sub_weight (op->env, op->weight * i);
1730 op->nrof -= i; 1553 op->nrof -= i;
1731 if (tmp) 1554 if (tmp)
1732 {
1733 esrv_send_item (tmp, op); 1555 esrv_send_item (tmp, op);
1734 }
1735 } 1556 }
1736 else 1557 else
1737 { 1558 {
1738 remove_ob (op); 1559 op->remove ();
1739 op->nrof = 0; 1560 op->nrof = 0;
1740 if (tmp) 1561 if (tmp)
1741 {
1742 esrv_del_item (tmp->contr, op->count); 1562 esrv_del_item (tmp->contr, op->count);
1743 }
1744 } 1563 }
1745 } 1564 }
1746 else 1565 else
1747 { 1566 {
1748 object *above = op->above; 1567 object *above = op->above;
1749 1568
1750 if (i < op->nrof) 1569 if (i < op->nrof)
1751 op->nrof -= i; 1570 op->nrof -= i;
1752 else 1571 else
1753 { 1572 {
1754 remove_ob (op); 1573 op->remove ();
1755 op->nrof = 0; 1574 op->nrof = 0;
1756 } 1575 }
1757 1576
1758 /* Since we just removed op, op->above is null */ 1577 /* Since we just removed op, op->above is null */
1759 for (tmp = above; tmp != NULL; tmp = tmp->above) 1578 for (tmp = above; tmp; tmp = tmp->above)
1760 if (tmp->type == PLAYER) 1579 if (tmp->type == PLAYER)
1761 { 1580 {
1762 if (op->nrof) 1581 if (op->nrof)
1763 esrv_send_item (tmp, op); 1582 esrv_send_item (tmp, op);
1764 else 1583 else
1768 1587
1769 if (op->nrof) 1588 if (op->nrof)
1770 return op; 1589 return op;
1771 else 1590 else
1772 { 1591 {
1773 free_object (op); 1592 op->destroy ();
1774 return NULL; 1593 return 0;
1775 } 1594 }
1776} 1595}
1777 1596
1778/* 1597/*
1779 * add_weight(object, weight) adds the specified weight to an object, 1598 * add_weight(object, weight) adds the specified weight to an object,
1791 op->carrying += weight; 1610 op->carrying += weight;
1792 op = op->env; 1611 op = op->env;
1793 } 1612 }
1794} 1613}
1795 1614
1615object *
1616insert_ob_in_ob (object *op, object *where)
1617{
1618 if (!where)
1619 {
1620 char *dump = dump_object (op);
1621 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1622 free (dump);
1623 return op;
1624 }
1625
1626 if (where->head)
1627 {
1628 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1629 where = where->head;
1630 }
1631
1632 return where->insert (op);
1633}
1634
1796/* 1635/*
1797 * insert_ob_in_ob(op,environment): 1636 * env->insert (op)
1798 * This function inserts the object op in the linked list 1637 * This function inserts the object op in the linked list
1799 * inside the object environment. 1638 * inside the object environment.
1800 * 1639 *
1801 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1802 * the inventory at the last position or next to other objects of the same
1803 * type.
1804 * Frank: Now sorted by type, archetype and magic!
1805 *
1806 * The function returns now pointer to inserted item, and return value can 1640 * The function returns now pointer to inserted item, and return value can
1807 * be != op, if items are merged. -Tero 1641 * be != op, if items are merged. -Tero
1808 */ 1642 */
1809 1643
1810object * 1644object *
1811insert_ob_in_ob (object *op, object *where) 1645object::insert (object *op)
1812{ 1646{
1813 object * 1647 object *tmp, *otmp;
1814 tmp, *
1815 otmp;
1816 1648
1817 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1649 if (!QUERY_FLAG (op, FLAG_REMOVED))
1818 { 1650 op->remove ();
1819 dump_object (op);
1820 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1821 return op;
1822 }
1823
1824 if (where == NULL)
1825 {
1826 dump_object (op);
1827 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1828 return op;
1829 }
1830
1831 if (where->head)
1832 {
1833 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1834 where = where->head;
1835 }
1836 1651
1837 if (op->more) 1652 if (op->more)
1838 { 1653 {
1839 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1654 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1840 return op; 1655 return op;
1842 1657
1843 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1658 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1844 CLEAR_FLAG (op, FLAG_REMOVED); 1659 CLEAR_FLAG (op, FLAG_REMOVED);
1845 if (op->nrof) 1660 if (op->nrof)
1846 { 1661 {
1847 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1662 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1848 if (CAN_MERGE (tmp, op)) 1663 if (object::can_merge (tmp, op))
1849 { 1664 {
1850 /* return the original object and remove inserted object 1665 /* return the original object and remove inserted object
1851 (client needs the original object) */ 1666 (client needs the original object) */
1852 tmp->nrof += op->nrof; 1667 tmp->nrof += op->nrof;
1853 /* Weight handling gets pretty funky. Since we are adding to 1668 /* Weight handling gets pretty funky. Since we are adding to
1854 * tmp->nrof, we need to increase the weight. 1669 * tmp->nrof, we need to increase the weight.
1855 */ 1670 */
1856 add_weight (where, op->weight * op->nrof); 1671 add_weight (this, op->weight * op->nrof);
1857 SET_FLAG (op, FLAG_REMOVED); 1672 SET_FLAG (op, FLAG_REMOVED);
1858 free_object (op); /* free the inserted object */ 1673 op->destroy (); /* free the inserted object */
1859 op = tmp; 1674 op = tmp;
1860 remove_ob (op); /* and fix old object's links */ 1675 op->remove (); /* and fix old object's links */
1861 CLEAR_FLAG (op, FLAG_REMOVED); 1676 CLEAR_FLAG (op, FLAG_REMOVED);
1862 break; 1677 break;
1863 } 1678 }
1864 1679
1865 /* I assume combined objects have no inventory 1680 /* I assume combined objects have no inventory
1866 * We add the weight - this object could have just been removed 1681 * We add the weight - this object could have just been removed
1867 * (if it was possible to merge). calling remove_ob will subtract 1682 * (if it was possible to merge). calling remove_ob will subtract
1868 * the weight, so we need to add it in again, since we actually do 1683 * the weight, so we need to add it in again, since we actually do
1869 * the linking below 1684 * the linking below
1870 */ 1685 */
1871 add_weight (where, op->weight * op->nrof); 1686 add_weight (this, op->weight * op->nrof);
1872 } 1687 }
1873 else 1688 else
1874 add_weight (where, (op->weight + op->carrying)); 1689 add_weight (this, (op->weight + op->carrying));
1875 1690
1876 otmp = is_player_inv (where); 1691 otmp = this->in_player ();
1877 if (otmp && otmp->contr != NULL) 1692 if (otmp && otmp->contr)
1878 {
1879 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1693 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1880 fix_player (otmp); 1694 otmp->update_stats ();
1881 }
1882 1695
1883 op->map = NULL; 1696 op->map = 0;
1884 op->env = where; 1697 op->env = this;
1885 op->above = NULL; 1698 op->above = 0;
1886 op->below = NULL; 1699 op->below = 0;
1887 op->x = 0, op->y = 0; 1700 op->x = 0, op->y = 0;
1888 1701
1889 /* reset the light list and los of the players on the map */ 1702 /* reset the light list and los of the players on the map */
1890 if ((op->glow_radius != 0) && where->map) 1703 if ((op->glow_radius != 0) && map)
1891 { 1704 {
1892#ifdef DEBUG_LIGHTS 1705#ifdef DEBUG_LIGHTS
1893 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1706 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1894#endif /* DEBUG_LIGHTS */ 1707#endif /* DEBUG_LIGHTS */
1895 if (MAP_DARKNESS (where->map)) 1708 if (map->darkness)
1896 update_all_los (where->map, where->x, where->y); 1709 update_all_los (map, x, y);
1897 } 1710 }
1898 1711
1899 /* Client has no idea of ordering so lets not bother ordering it here. 1712 /* Client has no idea of ordering so lets not bother ordering it here.
1900 * It sure simplifies this function... 1713 * It sure simplifies this function...
1901 */ 1714 */
1902 if (where->inv == NULL) 1715 if (!inv)
1903 where->inv = op; 1716 inv = op;
1904 else 1717 else
1905 { 1718 {
1906 op->below = where->inv; 1719 op->below = inv;
1907 op->below->above = op; 1720 op->below->above = op;
1908 where->inv = op; 1721 inv = op;
1909 } 1722 }
1723
1724 INVOKE_OBJECT (INSERT, this);
1725
1910 return op; 1726 return op;
1911} 1727}
1912 1728
1913/* 1729/*
1914 * Checks if any objects has a move_type that matches objects 1730 * Checks if any objects has a move_type that matches objects
1965 1781
1966 /* The objects have to be checked from top to bottom. 1782 /* The objects have to be checked from top to bottom.
1967 * Hence, we first go to the top: 1783 * Hence, we first go to the top:
1968 */ 1784 */
1969 1785
1970 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1786 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1971 { 1787 {
1972 /* Trim the search when we find the first other spell effect 1788 /* Trim the search when we find the first other spell effect
1973 * this helps performance so that if a space has 50 spell objects, 1789 * this helps performance so that if a space has 50 spell objects,
1974 * we don't need to check all of them. 1790 * we don't need to check all of them.
1975 */ 1791 */
2030/* 1846/*
2031 * present_arch(arch, map, x, y) searches for any objects with 1847 * present_arch(arch, map, x, y) searches for any objects with
2032 * a matching archetype at the given map and coordinates. 1848 * a matching archetype at the given map and coordinates.
2033 * The first matching object is returned, or NULL if none. 1849 * The first matching object is returned, or NULL if none.
2034 */ 1850 */
2035
2036object * 1851object *
2037present_arch (const archetype *at, maptile *m, int x, int y) 1852present_arch (const archetype *at, maptile *m, int x, int y)
2038{ 1853{
2039 object *
2040 tmp;
2041
2042 if (m == NULL || out_of_map (m, x, y)) 1854 if (m == NULL || out_of_map (m, x, y))
2043 { 1855 {
2044 LOG (llevError, "Present_arch called outside map.\n"); 1856 LOG (llevError, "Present_arch called outside map.\n");
2045 return NULL; 1857 return NULL;
2046 } 1858 }
1859
2047 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1860 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2048 if (tmp->arch == at) 1861 if (tmp->arch == at)
2049 return tmp; 1862 return tmp;
1863
2050 return NULL; 1864 return NULL;
2051} 1865}
2052 1866
2053/* 1867/*
2054 * present(type, map, x, y) searches for any objects with 1868 * present(type, map, x, y) searches for any objects with
2055 * a matching type variable at the given map and coordinates. 1869 * a matching type variable at the given map and coordinates.
2056 * The first matching object is returned, or NULL if none. 1870 * The first matching object is returned, or NULL if none.
2057 */ 1871 */
2058
2059object * 1872object *
2060present (unsigned char type, maptile *m, int x, int y) 1873present (unsigned char type, maptile *m, int x, int y)
2061{ 1874{
2062 object *
2063 tmp;
2064
2065 if (out_of_map (m, x, y)) 1875 if (out_of_map (m, x, y))
2066 { 1876 {
2067 LOG (llevError, "Present called outside map.\n"); 1877 LOG (llevError, "Present called outside map.\n");
2068 return NULL; 1878 return NULL;
2069 } 1879 }
1880
2070 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1881 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2071 if (tmp->type == type) 1882 if (tmp->type == type)
2072 return tmp; 1883 return tmp;
1884
2073 return NULL; 1885 return NULL;
2074} 1886}
2075 1887
2076/* 1888/*
2077 * present_in_ob(type, object) searches for any objects with 1889 * present_in_ob(type, object) searches for any objects with
2078 * a matching type variable in the inventory of the given object. 1890 * a matching type variable in the inventory of the given object.
2079 * The first matching object is returned, or NULL if none. 1891 * The first matching object is returned, or NULL if none.
2080 */ 1892 */
2081
2082object * 1893object *
2083present_in_ob (unsigned char type, const object *op) 1894present_in_ob (unsigned char type, const object *op)
2084{ 1895{
2085 object *
2086 tmp;
2087
2088 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1896 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2089 if (tmp->type == type) 1897 if (tmp->type == type)
2090 return tmp; 1898 return tmp;
1899
2091 return NULL; 1900 return NULL;
2092} 1901}
2093 1902
2094/* 1903/*
2095 * present_in_ob (type, str, object) searches for any objects with 1904 * present_in_ob (type, str, object) searches for any objects with
2103 * str is the string to match against. Note that we match against 1912 * str is the string to match against. Note that we match against
2104 * the object name, not the archetype name. this is so that the 1913 * the object name, not the archetype name. this is so that the
2105 * spell code can use one object type (force), but change it's name 1914 * spell code can use one object type (force), but change it's name
2106 * to be unique. 1915 * to be unique.
2107 */ 1916 */
2108
2109object * 1917object *
2110present_in_ob_by_name (int type, const char *str, const object *op) 1918present_in_ob_by_name (int type, const char *str, const object *op)
2111{ 1919{
2112 object *
2113 tmp;
2114
2115 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1920 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2116 {
2117 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1921 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2118 return tmp; 1922 return tmp;
2119 } 1923
2120 return NULL; 1924 return 0;
2121} 1925}
2122 1926
2123/* 1927/*
2124 * present_arch_in_ob(archetype, object) searches for any objects with 1928 * present_arch_in_ob(archetype, object) searches for any objects with
2125 * a matching archetype in the inventory of the given object. 1929 * a matching archetype in the inventory of the given object.
2126 * The first matching object is returned, or NULL if none. 1930 * The first matching object is returned, or NULL if none.
2127 */ 1931 */
2128
2129object * 1932object *
2130present_arch_in_ob (const archetype *at, const object *op) 1933present_arch_in_ob (const archetype *at, const object *op)
2131{ 1934{
2132 object *
2133 tmp;
2134
2135 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1935 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2136 if (tmp->arch == at) 1936 if (tmp->arch == at)
2137 return tmp; 1937 return tmp;
1938
2138 return NULL; 1939 return NULL;
2139} 1940}
2140 1941
2141/* 1942/*
2142 * activate recursively a flag on an object inventory 1943 * activate recursively a flag on an object inventory
2143 */ 1944 */
2144void 1945void
2145flag_inv (object *op, int flag) 1946flag_inv (object *op, int flag)
2146{ 1947{
2147 object *
2148 tmp;
2149
2150 if (op->inv) 1948 if (op->inv)
2151 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1949 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2152 { 1950 {
2153 SET_FLAG (tmp, flag); 1951 SET_FLAG (tmp, flag);
2154 flag_inv (tmp, flag); 1952 flag_inv (tmp, flag);
2155 } 1953 }
2156} /* 1954}
1955
1956/*
2157 * desactivate recursively a flag on an object inventory 1957 * deactivate recursively a flag on an object inventory
2158 */ 1958 */
2159void 1959void
2160unflag_inv (object *op, int flag) 1960unflag_inv (object *op, int flag)
2161{ 1961{
2162 object *
2163 tmp;
2164
2165 if (op->inv) 1962 if (op->inv)
2166 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1963 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2167 { 1964 {
2168 CLEAR_FLAG (tmp, flag); 1965 CLEAR_FLAG (tmp, flag);
2169 unflag_inv (tmp, flag); 1966 unflag_inv (tmp, flag);
2170 } 1967 }
2171} 1968}
2174 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1971 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2175 * all it's inventory (recursively). 1972 * all it's inventory (recursively).
2176 * If checksums are used, a player will get set_cheat called for 1973 * If checksums are used, a player will get set_cheat called for
2177 * him/her-self and all object carried by a call to this function. 1974 * him/her-self and all object carried by a call to this function.
2178 */ 1975 */
2179
2180void 1976void
2181set_cheat (object *op) 1977set_cheat (object *op)
2182{ 1978{
2183 SET_FLAG (op, FLAG_WAS_WIZ); 1979 SET_FLAG (op, FLAG_WAS_WIZ);
2184 flag_inv (op, FLAG_WAS_WIZ); 1980 flag_inv (op, FLAG_WAS_WIZ);
2203 * because arch_blocked (now ob_blocked) needs to know the movement type 1999 * because arch_blocked (now ob_blocked) needs to know the movement type
2204 * to know if the space in question will block the object. We can't use 2000 * to know if the space in question will block the object. We can't use
2205 * the archetype because that isn't correct if the monster has been 2001 * the archetype because that isn't correct if the monster has been
2206 * customized, changed states, etc. 2002 * customized, changed states, etc.
2207 */ 2003 */
2208
2209int 2004int
2210find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2005find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2211{ 2006{
2212 int
2213 i,
2214 index = 0, flag; 2007 int index = 0, flag;
2215 static int
2216 altern[SIZEOFFREE]; 2008 int altern[SIZEOFFREE];
2217 2009
2218 for (i = start; i < stop; i++) 2010 for (int i = start; i < stop; i++)
2219 { 2011 {
2220 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2012 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2221 if (!flag) 2013 if (!flag)
2222 altern[index++] = i; 2014 altern [index++] = i;
2223 2015
2224 /* Basically, if we find a wall on a space, we cut down the search size. 2016 /* Basically, if we find a wall on a space, we cut down the search size.
2225 * In this way, we won't return spaces that are on another side of a wall. 2017 * In this way, we won't return spaces that are on another side of a wall.
2226 * This mostly work, but it cuts down the search size in all directions - 2018 * This mostly work, but it cuts down the search size in all directions -
2227 * if the space being examined only has a wall to the north and empty 2019 * if the space being examined only has a wall to the north and empty
2228 * spaces in all the other directions, this will reduce the search space 2020 * spaces in all the other directions, this will reduce the search space
2229 * to only the spaces immediately surrounding the target area, and 2021 * to only the spaces immediately surrounding the target area, and
2230 * won't look 2 spaces south of the target space. 2022 * won't look 2 spaces south of the target space.
2231 */ 2023 */
2232 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2024 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2233 stop = maxfree[i]; 2025 stop = maxfree[i];
2234 } 2026 }
2027
2235 if (!index) 2028 if (!index)
2236 return -1; 2029 return -1;
2030
2237 return altern[RANDOM () % index]; 2031 return altern[RANDOM () % index];
2238} 2032}
2239 2033
2240/* 2034/*
2241 * find_first_free_spot(archetype, maptile, x, y) works like 2035 * find_first_free_spot(archetype, maptile, x, y) works like
2242 * find_free_spot(), but it will search max number of squares. 2036 * find_free_spot(), but it will search max number of squares.
2243 * But it will return the first available spot, not a random choice. 2037 * But it will return the first available spot, not a random choice.
2244 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2038 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2245 */ 2039 */
2246
2247int 2040int
2248find_first_free_spot (const object *ob, maptile *m, int x, int y) 2041find_first_free_spot (const object *ob, maptile *m, int x, int y)
2249{ 2042{
2250 int
2251 i;
2252
2253 for (i = 0; i < SIZEOFFREE; i++) 2043 for (int i = 0; i < SIZEOFFREE; i++)
2254 {
2255 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2044 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2256 return i; 2045 return i;
2257 } 2046
2258 return -1; 2047 return -1;
2259} 2048}
2260 2049
2261/* 2050/*
2262 * The function permute(arr, begin, end) randomly reorders the array 2051 * The function permute(arr, begin, end) randomly reorders the array
2263 * arr[begin..end-1]. 2052 * arr[begin..end-1].
2053 * now uses a fisher-yates shuffle, old permute was broken
2264 */ 2054 */
2265static void 2055static void
2266permute (int *arr, int begin, int end) 2056permute (int *arr, int begin, int end)
2267{ 2057{
2268 int 2058 arr += begin;
2269 i,
2270 j,
2271 tmp,
2272 len;
2273
2274 len = end - begin; 2059 end -= begin;
2275 for (i = begin; i < end; i++)
2276 {
2277 j = begin + RANDOM () % len;
2278 2060
2279 tmp = arr[i]; 2061 while (--end)
2280 arr[i] = arr[j]; 2062 swap (arr [end], arr [RANDOM () % (end + 1)]);
2281 arr[j] = tmp;
2282 }
2283} 2063}
2284 2064
2285/* new function to make monster searching more efficient, and effective! 2065/* new function to make monster searching more efficient, and effective!
2286 * This basically returns a randomized array (in the passed pointer) of 2066 * This basically returns a randomized array (in the passed pointer) of
2287 * the spaces to find monsters. In this way, it won't always look for 2067 * the spaces to find monsters. In this way, it won't always look for
2290 * the 3x3 area will be searched, just not in a predictable order. 2070 * the 3x3 area will be searched, just not in a predictable order.
2291 */ 2071 */
2292void 2072void
2293get_search_arr (int *search_arr) 2073get_search_arr (int *search_arr)
2294{ 2074{
2295 int 2075 int i;
2296 i;
2297 2076
2298 for (i = 0; i < SIZEOFFREE; i++) 2077 for (i = 0; i < SIZEOFFREE; i++)
2299 {
2300 search_arr[i] = i; 2078 search_arr[i] = i;
2301 }
2302 2079
2303 permute (search_arr, 1, SIZEOFFREE1 + 1); 2080 permute (search_arr, 1, SIZEOFFREE1 + 1);
2304 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2081 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2305 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2082 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2306} 2083}
2315 * Perhaps incorrectly, but I'm making the assumption that exclude 2092 * Perhaps incorrectly, but I'm making the assumption that exclude
2316 * is actually want is going to try and move there. We need this info 2093 * is actually want is going to try and move there. We need this info
2317 * because we have to know what movement the thing looking to move 2094 * because we have to know what movement the thing looking to move
2318 * there is capable of. 2095 * there is capable of.
2319 */ 2096 */
2320
2321int 2097int
2322find_dir (maptile *m, int x, int y, object *exclude) 2098find_dir (maptile *m, int x, int y, object *exclude)
2323{ 2099{
2324 int
2325 i,
2326 max = SIZEOFFREE, mflags; 2100 int i, max = SIZEOFFREE, mflags;
2327 2101
2328 sint16 nx, ny; 2102 sint16 nx, ny;
2329 object * 2103 object *tmp;
2330 tmp;
2331 maptile * 2104 maptile *mp;
2332 mp;
2333 2105
2334 MoveType blocked, move_type; 2106 MoveType blocked, move_type;
2335 2107
2336 if (exclude && exclude->head) 2108 if (exclude && exclude->head)
2337 { 2109 {
2349 mp = m; 2121 mp = m;
2350 nx = x + freearr_x[i]; 2122 nx = x + freearr_x[i];
2351 ny = y + freearr_y[i]; 2123 ny = y + freearr_y[i];
2352 2124
2353 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2125 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2126
2354 if (mflags & P_OUT_OF_MAP) 2127 if (mflags & P_OUT_OF_MAP)
2355 {
2356 max = maxfree[i]; 2128 max = maxfree[i];
2357 }
2358 else 2129 else
2359 { 2130 {
2360 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2131 mapspace &ms = mp->at (nx, ny);
2132
2133 blocked = ms.move_block;
2361 2134
2362 if ((move_type & blocked) == move_type) 2135 if ((move_type & blocked) == move_type)
2363 {
2364 max = maxfree[i]; 2136 max = maxfree[i];
2365 }
2366 else if (mflags & P_IS_ALIVE) 2137 else if (mflags & P_IS_ALIVE)
2367 { 2138 {
2368 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2139 for (tmp = ms.bot; tmp; tmp = tmp->above)
2369 { 2140 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2370 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2141 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2371 {
2372 break; 2142 break;
2373 } 2143
2374 }
2375 if (tmp) 2144 if (tmp)
2376 {
2377 return freedir[i]; 2145 return freedir[i];
2378 }
2379 } 2146 }
2380 } 2147 }
2381 } 2148 }
2149
2382 return 0; 2150 return 0;
2383} 2151}
2384 2152
2385/* 2153/*
2386 * distance(object 1, object 2) will return the square of the 2154 * distance(object 1, object 2) will return the square of the
2387 * distance between the two given objects. 2155 * distance between the two given objects.
2388 */ 2156 */
2389
2390int 2157int
2391distance (const object *ob1, const object *ob2) 2158distance (const object *ob1, const object *ob2)
2392{ 2159{
2393 int
2394 i;
2395
2396 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2160 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2397 return i;
2398} 2161}
2399 2162
2400/* 2163/*
2401 * find_dir_2(delta-x,delta-y) will return a direction in which 2164 * find_dir_2(delta-x,delta-y) will return a direction in which
2402 * an object which has subtracted the x and y coordinates of another 2165 * an object which has subtracted the x and y coordinates of another
2403 * object, needs to travel toward it. 2166 * object, needs to travel toward it.
2404 */ 2167 */
2405
2406int 2168int
2407find_dir_2 (int x, int y) 2169find_dir_2 (int x, int y)
2408{ 2170{
2409 int 2171 int q;
2410 q;
2411 2172
2412 if (y) 2173 if (y)
2413 q = x * 100 / y; 2174 q = x * 100 / y;
2414 else if (x) 2175 else if (x)
2415 q = -300 * x; 2176 q = -300 * x;
2450int 2211int
2451absdir (int d) 2212absdir (int d)
2452{ 2213{
2453 while (d < 1) 2214 while (d < 1)
2454 d += 8; 2215 d += 8;
2216
2455 while (d > 8) 2217 while (d > 8)
2456 d -= 8; 2218 d -= 8;
2219
2457 return d; 2220 return d;
2458} 2221}
2459 2222
2460/* 2223/*
2461 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2224 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2463 */ 2226 */
2464 2227
2465int 2228int
2466dirdiff (int dir1, int dir2) 2229dirdiff (int dir1, int dir2)
2467{ 2230{
2468 int 2231 int d;
2469 d;
2470 2232
2471 d = abs (dir1 - dir2); 2233 d = abs (dir1 - dir2);
2472 if (d > 4) 2234 if (d > 4)
2473 d = 8 - d; 2235 d = 8 - d;
2236
2474 return d; 2237 return d;
2475} 2238}
2476 2239
2477/* peterm: 2240/* peterm:
2478 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2241 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2481 * This basically means that if direction is 15, then it could either go 2244 * This basically means that if direction is 15, then it could either go
2482 * direction 4, 14, or 16 to get back to where we are. 2245 * direction 4, 14, or 16 to get back to where we are.
2483 * Moved from spell_util.c to object.c with the other related direction 2246 * Moved from spell_util.c to object.c with the other related direction
2484 * functions. 2247 * functions.
2485 */ 2248 */
2486
2487int
2488 reduction_dir[SIZEOFFREE][3] = { 2249int reduction_dir[SIZEOFFREE][3] = {
2489 {0, 0, 0}, /* 0 */ 2250 {0, 0, 0}, /* 0 */
2490 {0, 0, 0}, /* 1 */ 2251 {0, 0, 0}, /* 1 */
2491 {0, 0, 0}, /* 2 */ 2252 {0, 0, 0}, /* 2 */
2492 {0, 0, 0}, /* 3 */ 2253 {0, 0, 0}, /* 3 */
2493 {0, 0, 0}, /* 4 */ 2254 {0, 0, 0}, /* 4 */
2541 * find a path to that monster that we found. If not, 2302 * find a path to that monster that we found. If not,
2542 * we don't bother going toward it. Returns 1 if we 2303 * we don't bother going toward it. Returns 1 if we
2543 * can see a direct way to get it 2304 * can see a direct way to get it
2544 * Modified to be map tile aware -.MSW 2305 * Modified to be map tile aware -.MSW
2545 */ 2306 */
2546
2547
2548int 2307int
2549can_see_monsterP (maptile *m, int x, int y, int dir) 2308can_see_monsterP (maptile *m, int x, int y, int dir)
2550{ 2309{
2551 sint16 dx, dy; 2310 sint16 dx, dy;
2552 int
2553 mflags; 2311 int mflags;
2554 2312
2555 if (dir < 0) 2313 if (dir < 0)
2556 return 0; /* exit condition: invalid direction */ 2314 return 0; /* exit condition: invalid direction */
2557 2315
2558 dx = x + freearr_x[dir]; 2316 dx = x + freearr_x[dir];
2571 return 0; 2329 return 0;
2572 2330
2573 /* yes, can see. */ 2331 /* yes, can see. */
2574 if (dir < 9) 2332 if (dir < 9)
2575 return 1; 2333 return 1;
2334
2576 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2335 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2577 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2336 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2337 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2578} 2338}
2579
2580
2581 2339
2582/* 2340/*
2583 * can_pick(picker, item): finds out if an object is possible to be 2341 * can_pick(picker, item): finds out if an object is possible to be
2584 * picked up by the picker. Returnes 1 if it can be 2342 * picked up by the picker. Returnes 1 if it can be
2585 * picked up, otherwise 0. 2343 * picked up, otherwise 0.
2596 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2354 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2597 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2355 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2598 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2356 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2599} 2357}
2600 2358
2601
2602/* 2359/*
2603 * create clone from object to another 2360 * create clone from object to another
2604 */ 2361 */
2605object * 2362object *
2606object_create_clone (object *asrc) 2363object_create_clone (object *asrc)
2607{ 2364{
2608 object *
2609 dst = NULL, *tmp, *src, *part, *prev, *item; 2365 object *dst = 0, *tmp, *src, *part, *prev, *item;
2610 2366
2611 if (!asrc) 2367 if (!asrc)
2612 return NULL; 2368 return 0;
2369
2613 src = asrc; 2370 src = asrc;
2614 if (src->head) 2371 if (src->head)
2615 src = src->head; 2372 src = src->head;
2616 2373
2617 prev = NULL; 2374 prev = 0;
2618 for (part = src; part; part = part->more) 2375 for (part = src; part; part = part->more)
2619 { 2376 {
2620 tmp = get_object (); 2377 tmp = part->clone ();
2621 copy_object (part, tmp);
2622 tmp->x -= src->x; 2378 tmp->x -= src->x;
2623 tmp->y -= src->y; 2379 tmp->y -= src->y;
2380
2624 if (!part->head) 2381 if (!part->head)
2625 { 2382 {
2626 dst = tmp; 2383 dst = tmp;
2627 tmp->head = NULL; 2384 tmp->head = 0;
2628 } 2385 }
2629 else 2386 else
2630 {
2631 tmp->head = dst; 2387 tmp->head = dst;
2632 } 2388
2633 tmp->more = NULL; 2389 tmp->more = 0;
2390
2634 if (prev) 2391 if (prev)
2635 prev->more = tmp; 2392 prev->more = tmp;
2393
2636 prev = tmp; 2394 prev = tmp;
2637 } 2395 }
2638 2396
2639 for (item = src->inv; item; item = item->below) 2397 for (item = src->inv; item; item = item->below)
2640 insert_ob_in_ob (object_create_clone (item), dst); 2398 insert_ob_in_ob (object_create_clone (item), dst);
2646/* Basically, we save the content of the string to a temp file, then call */ 2404/* Basically, we save the content of the string to a temp file, then call */
2647/* load_object on it. I admit it is a highly inefficient way to make things, */ 2405/* load_object on it. I admit it is a highly inefficient way to make things, */
2648/* but it was simple to make and allows reusing the load_object function. */ 2406/* but it was simple to make and allows reusing the load_object function. */
2649/* Remember not to use load_object_str in a time-critical situation. */ 2407/* Remember not to use load_object_str in a time-critical situation. */
2650/* Also remember that multiparts objects are not supported for now. */ 2408/* Also remember that multiparts objects are not supported for now. */
2651
2652object * 2409object *
2653load_object_str (const char *obstr) 2410load_object_str (const char *obstr)
2654{ 2411{
2655 object *op; 2412 object *op;
2656 char filename[MAX_BUF]; 2413 char filename[MAX_BUF];
2666 } 2423 }
2667 2424
2668 fprintf (tempfile, obstr); 2425 fprintf (tempfile, obstr);
2669 fclose (tempfile); 2426 fclose (tempfile);
2670 2427
2671 op = get_object (); 2428 op = object::create ();
2672 2429
2673 object_thawer thawer (filename); 2430 object_thawer thawer (filename);
2674 2431
2675 if (thawer) 2432 if (thawer)
2676 load_object (thawer, op, 0); 2433 load_object (thawer, op, 0);
2686 * returns NULL if no match. 2443 * returns NULL if no match.
2687 */ 2444 */
2688object * 2445object *
2689find_obj_by_type_subtype (const object *who, int type, int subtype) 2446find_obj_by_type_subtype (const object *who, int type, int subtype)
2690{ 2447{
2691 object *tmp;
2692
2693 for (tmp = who->inv; tmp; tmp = tmp->below) 2448 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2694 if (tmp->type == type && tmp->subtype == subtype) 2449 if (tmp->type == type && tmp->subtype == subtype)
2695 return tmp; 2450 return tmp;
2696 2451
2697 return NULL; 2452 return 0;
2698} 2453}
2699 2454
2700/* If ob has a field named key, return the link from the list, 2455/* If ob has a field named key, return the link from the list,
2701 * otherwise return NULL. 2456 * otherwise return NULL.
2702 * 2457 *
2704 * do the desired thing. 2459 * do the desired thing.
2705 */ 2460 */
2706key_value * 2461key_value *
2707get_ob_key_link (const object *ob, const char *key) 2462get_ob_key_link (const object *ob, const char *key)
2708{ 2463{
2709 key_value *link;
2710
2711 for (link = ob->key_values; link != NULL; link = link->next) 2464 for (key_value *link = ob->key_values; link; link = link->next)
2712 if (link->key == key) 2465 if (link->key == key)
2713 return link; 2466 return link;
2714 2467
2715 return NULL; 2468 return 0;
2716} 2469}
2717 2470
2718/* 2471/*
2719 * Returns the value of op has an extra_field for key, or NULL. 2472 * Returns the value of op has an extra_field for key, or NULL.
2720 * 2473 *
2760 * Returns TRUE on success. 2513 * Returns TRUE on success.
2761 */ 2514 */
2762int 2515int
2763set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2516set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2764{ 2517{
2765 key_value *
2766 field = NULL, *last = NULL; 2518 key_value *field = NULL, *last = NULL;
2767 2519
2768 for (field = op->key_values; field != NULL; field = field->next) 2520 for (field = op->key_values; field != NULL; field = field->next)
2769 { 2521 {
2770 if (field->key != canonical_key) 2522 if (field->key != canonical_key)
2771 { 2523 {
2799 /* IF we get here, key doesn't exist */ 2551 /* IF we get here, key doesn't exist */
2800 2552
2801 /* No field, we'll have to add it. */ 2553 /* No field, we'll have to add it. */
2802 2554
2803 if (!add_key) 2555 if (!add_key)
2804 {
2805 return FALSE; 2556 return FALSE;
2806 } 2557
2807 /* There isn't any good reason to store a null 2558 /* There isn't any good reason to store a null
2808 * value in the key/value list. If the archetype has 2559 * value in the key/value list. If the archetype has
2809 * this key, then we should also have it, so shouldn't 2560 * this key, then we should also have it, so shouldn't
2810 * be here. If user wants to store empty strings, 2561 * be here. If user wants to store empty strings,
2811 * should pass in "" 2562 * should pass in ""

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines