ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.50 by root, Sat Sep 16 22:40:22 2006 UTC vs.
Revision 1.87 by root, Tue Dec 26 08:54:59 2006 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
104 _exit (1); 106 _exit (1);
105 } 107 }
106 108
107 uuid.seq = uid; 109 uuid.seq = uid;
108 write_uuid (); 110 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 112 fclose (fp);
111} 113}
112 114
113UUID 115UUID
114gen_uuid () 116gen_uuid ()
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193 195
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
354 op = op->env; 352 op = op->env;
355 return op; 353 return op;
356} 354}
357 355
358/* 356/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 358 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
377 */ 360 */
378 361
379void 362char *
380dump_object2 (object *op)
381{
382 errmsg[0] = 0;
383 return;
384 //TODO//D#d#
385#if 0
386 char *cp;
387
388/* object *tmp;*/
389
390 if (op->arch != NULL)
391 {
392 strcat (errmsg, "arch ");
393 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394 strcat (errmsg, "\n");
395 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396 strcat (errmsg, cp);
397# if 0
398 /* Don't dump player diffs - they are too long, mostly meaningless, and
399 * will overflow the buffer.
400 * Changed so that we don't dump inventory either. This may
401 * also overflow the buffer.
402 */
403 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404 strcat (errmsg, cp);
405 for (tmp = op->inv; tmp; tmp = tmp->below)
406 dump_object2 (tmp);
407# endif
408 strcat (errmsg, "end\n");
409 }
410 else
411 {
412 strcat (errmsg, "Object ");
413 if (op->name == NULL)
414 strcat (errmsg, "(null)");
415 else
416 strcat (errmsg, op->name);
417 strcat (errmsg, "\n");
418# if 0
419 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420 strcat (errmsg, cp);
421 for (tmp = op->inv; tmp; tmp = tmp->below)
422 dump_object2 (tmp);
423# endif
424 strcat (errmsg, "end\n");
425 }
426#endif
427}
428
429/*
430 * Dumps an object. Returns output in the static global errmsg array.
431 */
432
433void
434dump_object (object *op) 363dump_object (object *op)
435{ 364{
436 if (op == NULL) 365 if (!op)
437 { 366 return strdup ("[NULLOBJ]");
438 strcpy (errmsg, "[NULL pointer]");
439 return;
440 }
441 errmsg[0] = '\0';
442 dump_object2 (op);
443}
444 367
445void 368 object_freezer freezer;
446dump_all_objects (void) 369 save_object (freezer, op, 1);
447{ 370 return freezer.as_string ();
448 object *op;
449
450 for (op = object::first; op != NULL; op = op->next)
451 {
452 dump_object (op);
453 fprintf (logfile, "Object %s\n", errmsg);
454 }
455} 371}
456 372
457/* 373/*
458 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
459 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
479 */ 395 */
480 396
481object * 397object *
482find_object (tag_t i) 398find_object (tag_t i)
483{ 399{
484 object *op;
485
486 for (op = object::first; op != NULL; op = op->next) 400 for (object *op = object::first; op; op = op->next)
487 if (op->count == i) 401 if (op->count == i)
488 break; 402 return op;
489 403
490 return op; 404 return 0;
491} 405}
492 406
493/* 407/*
494 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
495 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
553 } 467 }
554 468
555 op->key_values = 0; 469 op->key_values = 0;
556} 470}
557 471
558void object::clear ()
559{
560 attachable_base::clear ();
561
562 free_key_values (this);
563
564 owner = 0;
565 name = 0;
566 name_pl = 0;
567 title = 0;
568 race = 0;
569 slaying = 0;
570 skill = 0;
571 msg = 0;
572 lore = 0;
573 custom_name = 0;
574 materialname = 0;
575 contr = 0;
576 below = 0;
577 above = 0;
578 inv = 0;
579 container = 0;
580 env = 0;
581 more = 0;
582 head = 0;
583 map = 0;
584 active_next = 0;
585 active_prev = 0;
586
587 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
588
589 SET_FLAG (this, FLAG_REMOVED);
590
591 /* What is not cleared is next, prev, and count */
592
593 expmul = 1.0;
594 face = blank_face;
595
596 if (settings.casting_time)
597 casting_time = -1;
598}
599
600void object::clone (object *destination)
601{
602 *(object_copy *)destination = *this;
603 *(object_pod *)destination = *this;
604
605 if (self || cb)
606 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
607}
608
609/* 472/*
610 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
611 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
612 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
613 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
614 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
615 * will point at garbage. 478 * will point at garbage.
616 */ 479 */
617void 480void
618copy_object (object *op2, object *op) 481object::copy_to (object *dst)
619{ 482{
620 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
621 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
622 485
623 op2->clone (op); 486 *(object_copy *)dst = *this;
624 487
625 if (is_freed) 488 if (is_freed)
626 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
490
627 if (is_removed) 491 if (is_removed)
628 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
629 493
630 if (op2->speed < 0) 494 if (speed < 0)
631 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
632 496
633 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
634 if (op2->key_values) 498 if (key_values)
635 { 499 {
636 key_value *tail = 0; 500 key_value *tail = 0;
637 key_value *i; 501 key_value *i;
638 502
639 op->key_values = 0; 503 dst->key_values = 0;
640 504
641 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
642 { 506 {
643 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
644 508
645 new_link->next = 0; 509 new_link->next = 0;
646 new_link->key = i->key; 510 new_link->key = i->key;
647 new_link->value = i->value; 511 new_link->value = i->value;
648 512
649 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
650 if (!op->key_values) 514 if (!dst->key_values)
651 { 515 {
652 op->key_values = new_link; 516 dst->key_values = new_link;
653 tail = new_link; 517 tail = new_link;
654 } 518 }
655 else 519 else
656 { 520 {
657 tail->next = new_link; 521 tail->next = new_link;
658 tail = new_link; 522 tail = new_link;
659 } 523 }
660 } 524 }
661 } 525 }
662 526
663 update_ob_speed (op); 527 dst->set_speed (dst->speed);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
664} 536}
665 537
666/* 538/*
667 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
668 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
682 * Updates the speed of an object. If the speed changes from 0 to another 554 * Updates the speed of an object. If the speed changes from 0 to another
683 * value, or vice versa, then add/remove the object from the active list. 555 * value, or vice versa, then add/remove the object from the active list.
684 * This function needs to be called whenever the speed of an object changes. 556 * This function needs to be called whenever the speed of an object changes.
685 */ 557 */
686void 558void
687update_ob_speed (object *op) 559object::set_speed (float speed)
688{ 560{
689 extern int arch_init; 561 extern int arch_init;
690 562
691 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
692 * since they never really need to be updated. 564 * since they never really need to be updated.
693 */ 565 */
694 566 if (flag [FLAG_FREED] && speed)
695 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
696 { 567 {
697 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &name);
698#ifdef MANY_CORES
699 abort ();
700#else
701 op->speed = 0; 569 speed = 0;
702#endif
703 } 570 }
571
572 this->speed = speed;
704 573
705 if (arch_init) 574 if (arch_init)
706 return; 575 return;
707 576
708 if (FABS (op->speed) > MIN_ACTIVE_SPEED) 577 if (FABS (speed) > MIN_ACTIVE_SPEED)
709 { 578 {
710 /* If already on active list, don't do anything */ 579 /* If already on active list, don't do anything */
711 if (op->active_next || op->active_prev || op == active_objects) 580 if (active_next || active_prev || this == active_objects)
712 return; 581 return;
713 582
714 /* process_events() expects us to insert the object at the beginning 583 /* process_events() expects us to insert the object at the beginning
715 * of the list. */ 584 * of the list. */
716 op->active_next = active_objects; 585 active_next = active_objects;
717 586
718 if (op->active_next != NULL) 587 if (active_next)
719 op->active_next->active_prev = op; 588 active_next->active_prev = this;
720 589
721 active_objects = op; 590 active_objects = this;
722 } 591 }
723 else 592 else
724 { 593 {
725 /* If not on the active list, nothing needs to be done */ 594 /* If not on the active list, nothing needs to be done */
726 if (!op->active_next && !op->active_prev && op != active_objects) 595 if (!active_next && !active_prev && this != active_objects)
727 return; 596 return;
728 597
729 if (op->active_prev == NULL) 598 if (!active_prev)
730 { 599 {
731 active_objects = op->active_next; 600 active_objects = active_next;
732 601
733 if (op->active_next != NULL) 602 if (active_next)
734 op->active_next->active_prev = NULL; 603 active_next->active_prev = 0;
735 } 604 }
736 else 605 else
737 { 606 {
738 op->active_prev->active_next = op->active_next; 607 active_prev->active_next = active_next;
739 608
740 if (op->active_next) 609 if (active_next)
741 op->active_next->active_prev = op->active_prev; 610 active_next->active_prev = active_prev;
742 } 611 }
743 612
744 op->active_next = NULL; 613 active_next = 0;
745 op->active_prev = NULL; 614 active_prev = 0;
746 } 615 }
747} 616}
748 617
749/* This function removes object 'op' from the list of active 618/* This function removes object 'op' from the list of active
750 * objects. 619 * objects.
776 op->active_next = NULL; 645 op->active_next = NULL;
777 op->active_prev = NULL; 646 op->active_prev = NULL;
778} 647}
779 648
780/* 649/*
781 * update_object() updates the array which represents the map. 650 * update_object() updates the the map.
782 * It takes into account invisible objects (and represent squares covered 651 * It takes into account invisible objects (and represent squares covered
783 * by invisible objects by whatever is below them (unless it's another 652 * by invisible objects by whatever is below them (unless it's another
784 * invisible object, etc...) 653 * invisible object, etc...)
785 * If the object being updated is beneath a player, the look-window 654 * If the object being updated is beneath a player, the look-window
786 * of that player is updated (this might be a suboptimal way of 655 * of that player is updated (this might be a suboptimal way of
787 * updating that window, though, since update_object() is called _often_) 656 * updating that window, though, since update_object() is called _often_)
788 * 657 *
789 * action is a hint of what the caller believes need to be done. 658 * action is a hint of what the caller believes need to be done.
790 * For example, if the only thing that has changed is the face (due to
791 * an animation), we don't need to call update_position until that actually
792 * comes into view of a player. OTOH, many other things, like addition/removal
793 * of walls or living creatures may need us to update the flags now.
794 * current action are: 659 * current action are:
795 * UP_OBJ_INSERT: op was inserted 660 * UP_OBJ_INSERT: op was inserted
796 * UP_OBJ_REMOVE: op was removed 661 * UP_OBJ_REMOVE: op was removed
797 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 662 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
798 * as that is easier than trying to look at what may have changed. 663 * as that is easier than trying to look at what may have changed.
799 * UP_OBJ_FACE: only the objects face has changed. 664 * UP_OBJ_FACE: only the objects face has changed.
800 */ 665 */
801
802void 666void
803update_object (object *op, int action) 667update_object (object *op, int action)
804{ 668{
805 int update_now = 0, flags;
806 MoveType move_on, move_off, move_block, move_slow; 669 MoveType move_on, move_off, move_block, move_slow;
807 670
808 if (op == NULL) 671 if (op == NULL)
809 { 672 {
810 /* this should never happen */ 673 /* this should never happen */
811 LOG (llevDebug, "update_object() called for NULL object.\n"); 674 LOG (llevDebug, "update_object() called for NULL object.\n");
812 return; 675 return;
813 } 676 }
814 677
815 if (op->env != NULL) 678 if (op->env)
816 { 679 {
817 /* Animation is currently handled by client, so nothing 680 /* Animation is currently handled by client, so nothing
818 * to do in this case. 681 * to do in this case.
819 */ 682 */
820 return; 683 return;
825 */ 688 */
826 if (!op->map || op->map->in_memory == MAP_SAVING) 689 if (!op->map || op->map->in_memory == MAP_SAVING)
827 return; 690 return;
828 691
829 /* make sure the object is within map boundaries */ 692 /* make sure the object is within map boundaries */
830 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 693 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
831 { 694 {
832 LOG (llevError, "update_object() called for object out of map!\n"); 695 LOG (llevError, "update_object() called for object out of map!\n");
833#ifdef MANY_CORES 696#ifdef MANY_CORES
834 abort (); 697 abort ();
835#endif 698#endif
836 return; 699 return;
837 } 700 }
838 701
839 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 702 mapspace &m = op->ms ();
840 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
841 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
842 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
843 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
844 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
845 703
704 if (m.flags_ & P_NEED_UPDATE)
705 /* nop */;
846 if (action == UP_OBJ_INSERT) 706 else if (action == UP_OBJ_INSERT)
847 { 707 {
708 // this is likely overkill, TODO: revisit (schmorp)
848 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 709 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
849 update_now = 1;
850
851 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 710 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
852 update_now = 1; 711 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
853 712 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
713 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
854 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 714 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
858 update_now = 1;
859
860 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
861 update_now = 1;
862
863 if ((move_on | op->move_on) != move_on) 715 || (m.move_on | op->move_on ) != m.move_on
864 update_now = 1;
865
866 if ((move_off | op->move_off) != move_off) 716 || (m.move_off | op->move_off ) != m.move_off
867 update_now = 1; 717 || (m.move_slow | op->move_slow) != m.move_slow
868
869 /* This isn't perfect, but I don't expect a lot of objects to 718 /* This isn't perfect, but I don't expect a lot of objects to
870 * to have move_allow right now. 719 * to have move_allow right now.
871 */ 720 */
872 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 721 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
873 update_now = 1; 722 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
874 723 m.flags_ = P_NEED_UPDATE;
875 if ((move_slow | op->move_slow) != move_slow)
876 update_now = 1;
877 } 724 }
878 /* if the object is being removed, we can't make intelligent 725 /* if the object is being removed, we can't make intelligent
879 * decisions, because remove_ob can't really pass the object 726 * decisions, because remove_ob can't really pass the object
880 * that is being removed. 727 * that is being removed.
881 */ 728 */
882 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 729 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
883 update_now = 1; 730 m.flags_ = P_NEED_UPDATE;
884 else if (action == UP_OBJ_FACE) 731 else if (action == UP_OBJ_FACE)
885 /* Nothing to do for that case */ ; 732 /* Nothing to do for that case */ ;
886 else 733 else
887 LOG (llevError, "update_object called with invalid action: %d\n", action); 734 LOG (llevError, "update_object called with invalid action: %d\n", action);
888 735
889 if (update_now)
890 {
891 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
892 update_position (op->map, op->x, op->y);
893 }
894
895 if (op->more != NULL) 736 if (op->more)
896 update_object (op->more, action); 737 update_object (op->more, action);
897} 738}
898 739
899object::vector object::mortals;
900object::vector object::objects; // not yet used 740object::vector object::objects; // not yet used
901object *object::first; 741object *object::first;
902
903void object::free_mortals ()
904{
905 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
906 if ((*i)->refcnt)
907 ++i; // further delay freeing
908 else
909 {
910 delete *i;
911 mortals.erase (i);
912 }
913
914 static int lastmortals = 0;//D
915
916 if (mortals.size() != lastmortals)//D
917 {
918 lastmortals = mortals.size ();//D
919 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
920 }
921}
922 742
923object::object () 743object::object ()
924{ 744{
925 SET_FLAG (this, FLAG_REMOVED); 745 SET_FLAG (this, FLAG_REMOVED);
926 746
965 object *op = new object; 785 object *op = new object;
966 op->link (); 786 op->link ();
967 return op; 787 return op;
968} 788}
969 789
970/* 790void
971 * free_object() frees everything allocated by an object, removes 791object::do_destroy ()
972 * it from the list of used objects, and puts it on the list of
973 * free objects. The IS_FREED() flag is set in the object.
974 * The object must have been removed by remove_ob() first for
975 * this function to succeed.
976 *
977 * If free_inventory is set, free inventory as well. Else drop items in
978 * inventory to the ground.
979 */
980void object::free (bool free_inventory)
981{ 792{
982 if (QUERY_FLAG (this, FLAG_FREED)) 793 attachable::do_destroy ();
794
795 if (flag [FLAG_IS_LINKED])
796 remove_button_link (this);
797
798 if (flag [FLAG_FRIENDLY])
799 remove_friendly_object (this);
800
801 if (!flag [FLAG_REMOVED])
802 remove ();
803
804 if (flag [FLAG_FREED])
983 return; 805 return;
984 806
985 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 807 flag [FLAG_FREED] = 1;
986 remove_friendly_object (this);
987 808
988 if (!QUERY_FLAG (this, FLAG_REMOVED)) 809 // hack to ensure that freed objects still have a valid map
989 remove_ob (this);
990
991 SET_FLAG (this, FLAG_FREED);
992
993 if (more)
994 { 810 {
995 more->free (free_inventory); 811 static maptile *freed_map; // freed objects are moved here to avoid crashes
996 more = 0;
997 }
998 812
999 if (inv) 813 if (!freed_map)
1000 {
1001 /* Only if the space blocks everything do we not process -
1002 * if some form of movement is allowed, let objects
1003 * drop on that space.
1004 */
1005 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1006 { 814 {
1007 object *op = inv; 815 freed_map = new maptile;
1008 816
1009 while (op) 817 freed_map->name = "/internal/freed_objects_map";
1010 { 818 freed_map->width = 3;
1011 object *tmp = op->below; 819 freed_map->height = 3;
1012 op->free (free_inventory); 820
1013 op = tmp; 821 freed_map->allocate ();
1014 }
1015 } 822 }
1016 else
1017 { /* Put objects in inventory onto this space */
1018 object *op = inv;
1019 823
1020 while (op) 824 map = freed_map;
1021 { 825 x = 1;
1022 object *tmp = op->below; 826 y = 1;
1023
1024 remove_ob (op);
1025
1026 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1027 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1028 free_object (op);
1029 else
1030 {
1031 op->x = x;
1032 op->y = y;
1033 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1034 }
1035
1036 op = tmp;
1037 }
1038 }
1039 } 827 }
828
829 more = 0;
830 head = 0;
831 inv = 0;
1040 832
1041 // clear those pointers that likely might have circular references to us 833 // clear those pointers that likely might have circular references to us
1042 owner = 0; 834 owner = 0;
1043 enemy = 0; 835 enemy = 0;
1044 attacked_by = 0; 836 attacked_by = 0;
1045 837
838 // only relevant for players(?), but make sure of it anyways
839 contr = 0;
840
1046 /* Remove object from the active list */ 841 /* Remove object from the active list */
1047 speed = 0; 842 set_speed (0);
1048 update_ob_speed (this);
1049 843
1050 unlink (); 844 unlink ();
845}
1051 846
1052 mortals.push_back (this); 847/*
848 * Remove and free all objects in the inventory of the given object.
849 * object.c ?
850 */
851void
852object::destroy_inv (bool drop_to_ground)
853{
854 if (!inv)
855 return;
856
857 /* Only if the space blocks everything do we not process -
858 * if some form of movement is allowed, let objects
859 * drop on that space.
860 */
861 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
862 {
863 while (inv)
864 {
865 inv->destroy_inv (drop_to_ground);
866 inv->destroy ();
867 }
868 }
869 else
870 { /* Put objects in inventory onto this space */
871 while (inv)
872 {
873 object *op = inv;
874
875 if (op->flag [FLAG_STARTEQUIP]
876 || op->flag [FLAG_NO_DROP]
877 || op->type == RUNE
878 || op->type == TRAP
879 || op->flag [FLAG_IS_A_TEMPLATE])
880 op->destroy ();
881 else
882 {
883 op->remove ();
884 op->x = x;
885 op->y = y;
886 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
887 }
888 }
889 }
890}
891
892void
893object::destroy (bool destroy_inventory)
894{
895 if (destroyed ())
896 return;
897
898 if (more)
899 {
900 //TODO: non-head objects must not have inventory
901 more->destroy (destroy_inventory);
902 more = 0;
903 }
904
905 if (destroy_inventory)
906 destroy_inv (true);
907
908 attachable::destroy ();
1053} 909}
1054 910
1055/* 911/*
1056 * sub_weight() recursively (outwards) subtracts a number from the 912 * sub_weight() recursively (outwards) subtracts a number from the
1057 * weight of an object (and what is carried by it's environment(s)). 913 * weight of an object (and what is carried by it's environment(s)).
1058 */ 914 */
1059
1060void 915void
1061sub_weight (object *op, signed long weight) 916sub_weight (object *op, signed long weight)
1062{ 917{
1063 while (op != NULL) 918 while (op != NULL)
1064 { 919 {
1068 op->carrying -= weight; 923 op->carrying -= weight;
1069 op = op->env; 924 op = op->env;
1070 } 925 }
1071} 926}
1072 927
1073/* remove_ob(op): 928/* op->remove ():
1074 * This function removes the object op from the linked list of objects 929 * This function removes the object op from the linked list of objects
1075 * which it is currently tied to. When this function is done, the 930 * which it is currently tied to. When this function is done, the
1076 * object will have no environment. If the object previously had an 931 * object will have no environment. If the object previously had an
1077 * environment, the x and y coordinates will be updated to 932 * environment, the x and y coordinates will be updated to
1078 * the previous environment. 933 * the previous environment.
1079 * Beware: This function is called from the editor as well! 934 * Beware: This function is called from the editor as well!
1080 */ 935 */
1081
1082void 936void
1083remove_ob (object *op) 937object::remove ()
1084{ 938{
1085 object *tmp, *last = 0; 939 object *tmp, *last = 0;
1086 object *otmp; 940 object *otmp;
1087 941
1088 int check_walk_off;
1089 maptile *m;
1090
1091 sint16 x, y;
1092
1093 if (QUERY_FLAG (op, FLAG_REMOVED)) 942 if (QUERY_FLAG (this, FLAG_REMOVED))
1094 return; 943 return;
1095 944
1096 SET_FLAG (op, FLAG_REMOVED); 945 SET_FLAG (this, FLAG_REMOVED);
946 INVOKE_OBJECT (REMOVE, this);
1097 947
1098 if (op->more != NULL) 948 if (more)
1099 remove_ob (op->more); 949 more->remove ();
1100 950
1101 /* 951 /*
1102 * In this case, the object to be removed is in someones 952 * In this case, the object to be removed is in someones
1103 * inventory. 953 * inventory.
1104 */ 954 */
1105 if (op->env != NULL) 955 if (env)
1106 { 956 {
1107 if (op->nrof) 957 if (nrof)
1108 sub_weight (op->env, op->weight * op->nrof); 958 sub_weight (env, weight * nrof);
1109 else 959 else
1110 sub_weight (op->env, op->weight + op->carrying); 960 sub_weight (env, weight + carrying);
1111 961
1112 /* NO_FIX_PLAYER is set when a great many changes are being 962 /* NO_FIX_PLAYER is set when a great many changes are being
1113 * made to players inventory. If set, avoiding the call 963 * made to players inventory. If set, avoiding the call
1114 * to save cpu time. 964 * to save cpu time.
1115 */ 965 */
1116 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 966 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1117 fix_player (otmp); 967 otmp->update_stats ();
1118 968
1119 if (op->above != NULL) 969 if (above != NULL)
1120 op->above->below = op->below; 970 above->below = below;
1121 else 971 else
1122 op->env->inv = op->below; 972 env->inv = below;
1123 973
1124 if (op->below != NULL) 974 if (below != NULL)
1125 op->below->above = op->above; 975 below->above = above;
1126 976
1127 /* we set up values so that it could be inserted into 977 /* we set up values so that it could be inserted into
1128 * the map, but we don't actually do that - it is up 978 * the map, but we don't actually do that - it is up
1129 * to the caller to decide what we want to do. 979 * to the caller to decide what we want to do.
1130 */ 980 */
1131 op->x = op->env->x, op->y = op->env->y; 981 x = env->x, y = env->y;
1132 op->map = op->env->map; 982 map = env->map;
1133 op->above = NULL, op->below = NULL; 983 above = 0, below = 0;
1134 op->env = NULL; 984 env = 0;
1135 } 985 }
1136 else if (op->map) 986 else if (map)
1137 { 987 {
1138 x = op->x;
1139 y = op->y;
1140 m = get_map_from_coord (op->map, &x, &y);
1141
1142 if (!m)
1143 {
1144 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1145 op->map->path, op->x, op->y);
1146 /* in old days, we used to set x and y to 0 and continue.
1147 * it seems if we get into this case, something is probablye
1148 * screwed up and should be fixed.
1149 */
1150 abort ();
1151 }
1152
1153 if (op->map != m)
1154 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1155 op->map->path, m->path, op->x, op->y, x, y);
1156
1157 /* Re did the following section of code - it looks like it had 988 /* Re did the following section of code - it looks like it had
1158 * lots of logic for things we no longer care about 989 * lots of logic for things we no longer care about
1159 */ 990 */
1160 991
1161 /* link the object above us */ 992 /* link the object above us */
1162 if (op->above) 993 if (above)
1163 op->above->below = op->below; 994 above->below = below;
1164 else 995 else
1165 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 996 map->at (x, y).top = below; /* we were top, set new top */
1166 997
1167 /* Relink the object below us, if there is one */ 998 /* Relink the object below us, if there is one */
1168 if (op->below) 999 if (below)
1169 op->below->above = op->above; 1000 below->above = above;
1170 else 1001 else
1171 { 1002 {
1172 /* Nothing below, which means we need to relink map object for this space 1003 /* Nothing below, which means we need to relink map object for this space
1173 * use translated coordinates in case some oddness with map tiling is 1004 * use translated coordinates in case some oddness with map tiling is
1174 * evident 1005 * evident
1175 */ 1006 */
1176 if (GET_MAP_OB (m, x, y) != op) 1007 if (GET_MAP_OB (map, x, y) != this)
1177 { 1008 {
1178 dump_object (op); 1009 char *dump = dump_object (this);
1179 LOG (llevError, 1010 LOG (llevError,
1180 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1011 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1012 free (dump);
1181 dump_object (GET_MAP_OB (m, x, y)); 1013 dump = dump_object (GET_MAP_OB (map, x, y));
1182 LOG (llevError, "%s\n", errmsg); 1014 LOG (llevError, "%s\n", dump);
1015 free (dump);
1183 } 1016 }
1184 1017
1185 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1018 map->at (x, y).bot = above; /* goes on above it. */
1186 } 1019 }
1187 1020
1188 op->above = 0; 1021 above = 0;
1189 op->below = 0; 1022 below = 0;
1190 1023
1191 if (op->map->in_memory == MAP_SAVING) 1024 if (map->in_memory == MAP_SAVING)
1192 return; 1025 return;
1193 1026
1194 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1027 int check_walk_off = !flag [FLAG_NO_APPLY];
1195 1028
1196 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1029 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1197 { 1030 {
1198 /* No point updating the players look faces if he is the object 1031 /* No point updating the players look faces if he is the object
1199 * being removed. 1032 * being removed.
1200 */ 1033 */
1201 1034
1202 if (tmp->type == PLAYER && tmp != op) 1035 if (tmp->type == PLAYER && tmp != this)
1203 { 1036 {
1204 /* If a container that the player is currently using somehow gets 1037 /* If a container that the player is currently using somehow gets
1205 * removed (most likely destroyed), update the player view 1038 * removed (most likely destroyed), update the player view
1206 * appropriately. 1039 * appropriately.
1207 */ 1040 */
1208 if (tmp->container == op) 1041 if (tmp->container == this)
1209 { 1042 {
1210 CLEAR_FLAG (op, FLAG_APPLIED); 1043 flag [FLAG_APPLIED] = 0;
1211 tmp->container = NULL; 1044 tmp->container = 0;
1212 } 1045 }
1213 1046
1214 tmp->contr->socket.update_look = 1; 1047 if (tmp->contr->ns)
1048 tmp->contr->ns->floorbox_update ();
1215 } 1049 }
1216 1050
1217 /* See if player moving off should effect something */ 1051 /* See if player moving off should effect something */
1218 if (check_walk_off 1052 if (check_walk_off
1219 && ((op->move_type & tmp->move_off) 1053 && ((move_type & tmp->move_off)
1220 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1054 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1221 { 1055 {
1222 move_apply (tmp, op, NULL); 1056 move_apply (tmp, this, 0);
1223 1057
1224 if (op->destroyed ()) 1058 if (destroyed ())
1225 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1059 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1226 } 1060 }
1227 1061
1228 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1062 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1229 1063
1230 if (tmp->above == tmp) 1064 if (tmp->above == tmp)
1231 tmp->above = NULL; 1065 tmp->above = 0;
1232 1066
1233 last = tmp; 1067 last = tmp;
1234 } 1068 }
1235 1069
1236 /* last == NULL of there are no objects on this space */ 1070 /* last == NULL of there are no objects on this space */
1237 if (last == NULL) 1071 if (!last)
1238 { 1072 map->at (x, y).flags_ = P_NEED_UPDATE;
1239 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1240 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1241 * those out anyways, and if there are any flags set right now, they won't
1242 * be correct anyways.
1243 */
1244 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1245 update_position (op->map, op->x, op->y);
1246 }
1247 else 1073 else
1248 update_object (last, UP_OBJ_REMOVE); 1074 update_object (last, UP_OBJ_REMOVE);
1249 1075
1250 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1076 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1251 update_all_los (op->map, op->x, op->y); 1077 update_all_los (map, x, y);
1252 } 1078 }
1253} 1079}
1254 1080
1255/* 1081/*
1256 * merge_ob(op,top): 1082 * merge_ob(op,top):
1264merge_ob (object *op, object *top) 1090merge_ob (object *op, object *top)
1265{ 1091{
1266 if (!op->nrof) 1092 if (!op->nrof)
1267 return 0; 1093 return 0;
1268 1094
1269 if (top == NULL) 1095 if (top)
1270 for (top = op; top != NULL && top->above != NULL; top = top->above); 1096 for (top = op; top && top->above; top = top->above)
1097 ;
1271 1098
1272 for (; top != NULL; top = top->below) 1099 for (; top; top = top->below)
1273 { 1100 {
1274 if (top == op) 1101 if (top == op)
1275 continue; 1102 continue;
1276 if (CAN_MERGE (op, top)) 1103
1104 if (object::can_merge (op, top))
1277 { 1105 {
1278 top->nrof += op->nrof; 1106 top->nrof += op->nrof;
1279 1107
1280/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1108/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1281 op->weight = 0; /* Don't want any adjustements now */ 1109 op->weight = 0; /* Don't want any adjustements now */
1282 remove_ob (op); 1110 op->destroy ();
1283 free_object (op);
1284 return top; 1111 return top;
1285 } 1112 }
1286 } 1113 }
1287 1114
1288 return 0; 1115 return 0;
1327 * Return value: 1154 * Return value:
1328 * new object if 'op' was merged with other object 1155 * new object if 'op' was merged with other object
1329 * NULL if 'op' was destroyed 1156 * NULL if 'op' was destroyed
1330 * just 'op' otherwise 1157 * just 'op' otherwise
1331 */ 1158 */
1332
1333object * 1159object *
1334insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1160insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1335{ 1161{
1336 object *tmp, *top, *floor = NULL; 1162 object *tmp, *top, *floor = NULL;
1337 sint16 x, y; 1163 sint16 x, y;
1342 return NULL; 1168 return NULL;
1343 } 1169 }
1344 1170
1345 if (m == NULL) 1171 if (m == NULL)
1346 { 1172 {
1347 dump_object (op); 1173 char *dump = dump_object (op);
1348 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1174 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1175 free (dump);
1349 return op; 1176 return op;
1350 } 1177 }
1351 1178
1352 if (out_of_map (m, op->x, op->y)) 1179 if (out_of_map (m, op->x, op->y))
1353 { 1180 {
1354 dump_object (op); 1181 char *dump = dump_object (op);
1355 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1182 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1356#ifdef MANY_CORES 1183#ifdef MANY_CORES
1357 /* Better to catch this here, as otherwise the next use of this object 1184 /* Better to catch this here, as otherwise the next use of this object
1358 * is likely to cause a crash. Better to find out where it is getting 1185 * is likely to cause a crash. Better to find out where it is getting
1359 * improperly inserted. 1186 * improperly inserted.
1360 */ 1187 */
1361 abort (); 1188 abort ();
1362#endif 1189#endif
1190 free (dump);
1363 return op; 1191 return op;
1364 } 1192 }
1365 1193
1366 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1194 if (!QUERY_FLAG (op, FLAG_REMOVED))
1367 { 1195 {
1368 dump_object (op); 1196 char *dump = dump_object (op);
1369 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1197 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1198 free (dump);
1370 return op; 1199 return op;
1371 } 1200 }
1372 1201
1373 if (op->more != NULL) 1202 if (op->more)
1374 { 1203 {
1375 /* The part may be on a different map. */ 1204 /* The part may be on a different map. */
1376 1205
1377 object *more = op->more; 1206 object *more = op->more;
1378 1207
1394 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1223 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1395 { 1224 {
1396 if (!op->head) 1225 if (!op->head)
1397 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1226 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1398 1227
1399 return NULL; 1228 return 0;
1400 } 1229 }
1401 } 1230 }
1402 1231
1403 CLEAR_FLAG (op, FLAG_REMOVED); 1232 CLEAR_FLAG (op, FLAG_REMOVED);
1404 1233
1412 1241
1413 /* this has to be done after we translate the coordinates. 1242 /* this has to be done after we translate the coordinates.
1414 */ 1243 */
1415 if (op->nrof && !(flag & INS_NO_MERGE)) 1244 if (op->nrof && !(flag & INS_NO_MERGE))
1416 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1245 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1417 if (CAN_MERGE (op, tmp)) 1246 if (object::can_merge (op, tmp))
1418 { 1247 {
1419 op->nrof += tmp->nrof; 1248 op->nrof += tmp->nrof;
1420 remove_ob (tmp); 1249 tmp->destroy ();
1421 free_object (tmp);
1422 } 1250 }
1423 1251
1424 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1252 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1425 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1253 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1426 1254
1439 op->below = originator->below; 1267 op->below = originator->below;
1440 1268
1441 if (op->below) 1269 if (op->below)
1442 op->below->above = op; 1270 op->below->above = op;
1443 else 1271 else
1444 SET_MAP_OB (op->map, op->x, op->y, op); 1272 op->ms ().bot = op;
1445 1273
1446 /* since *below* originator, no need to update top */ 1274 /* since *below* originator, no need to update top */
1447 originator->below = op; 1275 originator->below = op;
1448 } 1276 }
1449 else 1277 else
1495 * If INS_ON_TOP is used, don't do this processing 1323 * If INS_ON_TOP is used, don't do this processing
1496 * Need to find the object that in fact blocks view, otherwise 1324 * Need to find the object that in fact blocks view, otherwise
1497 * stacking is a bit odd. 1325 * stacking is a bit odd.
1498 */ 1326 */
1499 if (!(flag & INS_ON_TOP) && 1327 if (!(flag & INS_ON_TOP) &&
1500 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1328 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1501 { 1329 {
1502 for (last = top; last != floor; last = last->below) 1330 for (last = top; last != floor; last = last->below)
1503 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1331 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1504 break; 1332 break;
1505 /* Check to see if we found the object that blocks view, 1333 /* Check to see if we found the object that blocks view,
1528 1356
1529 if (op->above) 1357 if (op->above)
1530 op->above->below = op; 1358 op->above->below = op;
1531 1359
1532 op->below = NULL; 1360 op->below = NULL;
1533 SET_MAP_OB (op->map, op->x, op->y, op); 1361 op->ms ().bot = op;
1534 } 1362 }
1535 else 1363 else
1536 { /* get inserted into the stack above top */ 1364 { /* get inserted into the stack above top */
1537 op->above = top->above; 1365 op->above = top->above;
1538 1366
1542 op->below = top; 1370 op->below = top;
1543 top->above = op; 1371 top->above = op;
1544 } 1372 }
1545 1373
1546 if (op->above == NULL) 1374 if (op->above == NULL)
1547 SET_MAP_TOP (op->map, op->x, op->y, op); 1375 op->ms ().top = op;
1548 } /* else not INS_BELOW_ORIGINATOR */ 1376 } /* else not INS_BELOW_ORIGINATOR */
1549 1377
1550 if (op->type == PLAYER) 1378 if (op->type == PLAYER)
1551 op->contr->do_los = 1; 1379 op->contr->do_los = 1;
1552 1380
1553 /* If we have a floor, we know the player, if any, will be above 1381 /* If we have a floor, we know the player, if any, will be above
1554 * it, so save a few ticks and start from there. 1382 * it, so save a few ticks and start from there.
1555 */ 1383 */
1556 if (!(flag & INS_MAP_LOAD)) 1384 if (!(flag & INS_MAP_LOAD))
1557 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1385 if (object *pl = op->ms ().player ())
1558 if (tmp->type == PLAYER) 1386 if (pl->contr->ns)
1559 tmp->contr->socket.update_look = 1; 1387 pl->contr->ns->floorbox_update ();
1560 1388
1561 /* If this object glows, it may affect lighting conditions that are 1389 /* If this object glows, it may affect lighting conditions that are
1562 * visible to others on this map. But update_all_los is really 1390 * visible to others on this map. But update_all_los is really
1563 * an inefficient way to do this, as it means los for all players 1391 * an inefficient way to do this, as it means los for all players
1564 * on the map will get recalculated. The players could very well 1392 * on the map will get recalculated. The players could very well
1565 * be far away from this change and not affected in any way - 1393 * be far away from this change and not affected in any way -
1566 * this should get redone to only look for players within range, 1394 * this should get redone to only look for players within range,
1567 * or just updating the P_NEED_UPDATE for spaces within this area 1395 * or just updating the P_NEED_UPDATE for spaces within this area
1568 * of effect may be sufficient. 1396 * of effect may be sufficient.
1569 */ 1397 */
1570 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1398 if (op->map->darkness && (op->glow_radius != 0))
1571 update_all_los (op->map, op->x, op->y); 1399 update_all_los (op->map, op->x, op->y);
1572 1400
1573 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1401 /* updates flags (blocked, alive, no magic, etc) for this map space */
1574 update_object (op, UP_OBJ_INSERT); 1402 update_object (op, UP_OBJ_INSERT);
1575 1403
1404 INVOKE_OBJECT (INSERT, op);
1405
1576 /* Don't know if moving this to the end will break anything. However, 1406 /* Don't know if moving this to the end will break anything. However,
1577 * we want to have update_look set above before calling this. 1407 * we want to have floorbox_update called before calling this.
1578 * 1408 *
1579 * check_move_on() must be after this because code called from 1409 * check_move_on() must be after this because code called from
1580 * check_move_on() depends on correct map flags (so functions like 1410 * check_move_on() depends on correct map flags (so functions like
1581 * blocked() and wall() work properly), and these flags are updated by 1411 * blocked() and wall() work properly), and these flags are updated by
1582 * update_object(). 1412 * update_object().
1584 1414
1585 /* if this is not the head or flag has been passed, don't check walk on status */ 1415 /* if this is not the head or flag has been passed, don't check walk on status */
1586 if (!(flag & INS_NO_WALK_ON) && !op->head) 1416 if (!(flag & INS_NO_WALK_ON) && !op->head)
1587 { 1417 {
1588 if (check_move_on (op, originator)) 1418 if (check_move_on (op, originator))
1589 return NULL; 1419 return 0;
1590 1420
1591 /* If we are a multi part object, lets work our way through the check 1421 /* If we are a multi part object, lets work our way through the check
1592 * walk on's. 1422 * walk on's.
1593 */ 1423 */
1594 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1424 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1595 if (check_move_on (tmp, originator)) 1425 if (check_move_on (tmp, originator))
1596 return NULL; 1426 return 0;
1597 } 1427 }
1598 1428
1599 return op; 1429 return op;
1600} 1430}
1601 1431
1602/* this function inserts an object in the map, but if it 1432/* this function inserts an object in the map, but if it
1603 * finds an object of its own type, it'll remove that one first. 1433 * finds an object of its own type, it'll remove that one first.
1604 * op is the object to insert it under: supplies x and the map. 1434 * op is the object to insert it under: supplies x and the map.
1605 */ 1435 */
1606void 1436void
1607replace_insert_ob_in_map (const char *arch_string, object *op) 1437replace_insert_ob_in_map (const char *arch_string, object *op)
1608{ 1438{
1609 object * 1439 object *tmp, *tmp1;
1610 tmp;
1611 object *
1612 tmp1;
1613 1440
1614 /* first search for itself and remove any old instances */ 1441 /* first search for itself and remove any old instances */
1615 1442
1616 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1443 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1617 {
1618 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1444 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1619 { 1445 tmp->destroy ();
1620 remove_ob (tmp);
1621 free_object (tmp);
1622 }
1623 }
1624 1446
1625 tmp1 = arch_to_object (archetype::find (arch_string)); 1447 tmp1 = arch_to_object (archetype::find (arch_string));
1626 1448
1627 tmp1->x = op->x; 1449 tmp1->x = op->x;
1628 tmp1->y = op->y; 1450 tmp1->y = op->y;
1638 */ 1460 */
1639 1461
1640object * 1462object *
1641get_split_ob (object *orig_ob, uint32 nr) 1463get_split_ob (object *orig_ob, uint32 nr)
1642{ 1464{
1643 object * 1465 object *newob;
1644 newob;
1645 int
1646 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1466 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1647 1467
1648 if (orig_ob->nrof < nr) 1468 if (orig_ob->nrof < nr)
1649 { 1469 {
1650 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1470 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1651 return NULL; 1471 return NULL;
1652 } 1472 }
1653 1473
1654 newob = object_create_clone (orig_ob); 1474 newob = object_create_clone (orig_ob);
1655 1475
1656 if ((orig_ob->nrof -= nr) < 1) 1476 if ((orig_ob->nrof -= nr) < 1)
1657 { 1477 orig_ob->destroy (1);
1658 if (!is_removed)
1659 remove_ob (orig_ob);
1660 free_object2 (orig_ob, 1);
1661 }
1662 else if (!is_removed) 1478 else if (!is_removed)
1663 { 1479 {
1664 if (orig_ob->env != NULL) 1480 if (orig_ob->env != NULL)
1665 sub_weight (orig_ob->env, orig_ob->weight * nr); 1481 sub_weight (orig_ob->env, orig_ob->weight * nr);
1666 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1482 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1686 1502
1687object * 1503object *
1688decrease_ob_nr (object *op, uint32 i) 1504decrease_ob_nr (object *op, uint32 i)
1689{ 1505{
1690 object *tmp; 1506 object *tmp;
1691 player *pl;
1692 1507
1693 if (i == 0) /* objects with op->nrof require this check */ 1508 if (i == 0) /* objects with op->nrof require this check */
1694 return op; 1509 return op;
1695 1510
1696 if (i > op->nrof) 1511 if (i > op->nrof)
1697 i = op->nrof; 1512 i = op->nrof;
1698 1513
1699 if (QUERY_FLAG (op, FLAG_REMOVED)) 1514 if (QUERY_FLAG (op, FLAG_REMOVED))
1700 op->nrof -= i; 1515 op->nrof -= i;
1701 else if (op->env != NULL) 1516 else if (op->env)
1702 { 1517 {
1703 /* is this object in the players inventory, or sub container 1518 /* is this object in the players inventory, or sub container
1704 * therein? 1519 * therein?
1705 */ 1520 */
1706 tmp = is_player_inv (op->env); 1521 tmp = op->in_player ();
1707 /* nope. Is this a container the player has opened? 1522 /* nope. Is this a container the player has opened?
1708 * If so, set tmp to that player. 1523 * If so, set tmp to that player.
1709 * IMO, searching through all the players will mostly 1524 * IMO, searching through all the players will mostly
1710 * likely be quicker than following op->env to the map, 1525 * likely be quicker than following op->env to the map,
1711 * and then searching the map for a player. 1526 * and then searching the map for a player.
1712 */ 1527 */
1713 if (!tmp) 1528 if (!tmp)
1714 { 1529 for_all_players (pl)
1715 for (pl = first_player; pl; pl = pl->next)
1716 if (pl->ob->container == op->env) 1530 if (pl->ob->container == op->env)
1531 {
1532 tmp = pl->ob;
1717 break; 1533 break;
1718 if (pl)
1719 tmp = pl->ob;
1720 else
1721 tmp = NULL;
1722 } 1534 }
1723 1535
1724 if (i < op->nrof) 1536 if (i < op->nrof)
1725 { 1537 {
1726 sub_weight (op->env, op->weight * i); 1538 sub_weight (op->env, op->weight * i);
1727 op->nrof -= i; 1539 op->nrof -= i;
1728 if (tmp) 1540 if (tmp)
1729 {
1730 esrv_send_item (tmp, op); 1541 esrv_send_item (tmp, op);
1731 }
1732 } 1542 }
1733 else 1543 else
1734 { 1544 {
1735 remove_ob (op); 1545 op->remove ();
1736 op->nrof = 0; 1546 op->nrof = 0;
1737 if (tmp) 1547 if (tmp)
1738 {
1739 esrv_del_item (tmp->contr, op->count); 1548 esrv_del_item (tmp->contr, op->count);
1740 }
1741 } 1549 }
1742 } 1550 }
1743 else 1551 else
1744 { 1552 {
1745 object *above = op->above; 1553 object *above = op->above;
1746 1554
1747 if (i < op->nrof) 1555 if (i < op->nrof)
1748 op->nrof -= i; 1556 op->nrof -= i;
1749 else 1557 else
1750 { 1558 {
1751 remove_ob (op); 1559 op->remove ();
1752 op->nrof = 0; 1560 op->nrof = 0;
1753 } 1561 }
1754 1562
1755 /* Since we just removed op, op->above is null */ 1563 /* Since we just removed op, op->above is null */
1756 for (tmp = above; tmp != NULL; tmp = tmp->above) 1564 for (tmp = above; tmp; tmp = tmp->above)
1757 if (tmp->type == PLAYER) 1565 if (tmp->type == PLAYER)
1758 { 1566 {
1759 if (op->nrof) 1567 if (op->nrof)
1760 esrv_send_item (tmp, op); 1568 esrv_send_item (tmp, op);
1761 else 1569 else
1765 1573
1766 if (op->nrof) 1574 if (op->nrof)
1767 return op; 1575 return op;
1768 else 1576 else
1769 { 1577 {
1770 free_object (op); 1578 op->destroy ();
1771 return NULL; 1579 return 0;
1772 } 1580 }
1773} 1581}
1774 1582
1775/* 1583/*
1776 * add_weight(object, weight) adds the specified weight to an object, 1584 * add_weight(object, weight) adds the specified weight to an object,
1788 op->carrying += weight; 1596 op->carrying += weight;
1789 op = op->env; 1597 op = op->env;
1790 } 1598 }
1791} 1599}
1792 1600
1601object *
1602insert_ob_in_ob (object *op, object *where)
1603{
1604 if (!where)
1605 {
1606 char *dump = dump_object (op);
1607 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1608 free (dump);
1609 return op;
1610 }
1611
1612 if (where->head)
1613 {
1614 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1615 where = where->head;
1616 }
1617
1618 return where->insert (op);
1619}
1620
1793/* 1621/*
1794 * insert_ob_in_ob(op,environment): 1622 * env->insert (op)
1795 * This function inserts the object op in the linked list 1623 * This function inserts the object op in the linked list
1796 * inside the object environment. 1624 * inside the object environment.
1797 * 1625 *
1798 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1799 * the inventory at the last position or next to other objects of the same
1800 * type.
1801 * Frank: Now sorted by type, archetype and magic!
1802 *
1803 * The function returns now pointer to inserted item, and return value can 1626 * The function returns now pointer to inserted item, and return value can
1804 * be != op, if items are merged. -Tero 1627 * be != op, if items are merged. -Tero
1805 */ 1628 */
1806 1629
1807object * 1630object *
1808insert_ob_in_ob (object *op, object *where) 1631object::insert (object *op)
1809{ 1632{
1810 object * 1633 object *tmp, *otmp;
1811 tmp, *
1812 otmp;
1813 1634
1814 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1635 if (!QUERY_FLAG (op, FLAG_REMOVED))
1815 { 1636 op->remove ();
1816 dump_object (op);
1817 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1818 return op;
1819 }
1820
1821 if (where == NULL)
1822 {
1823 dump_object (op);
1824 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1825 return op;
1826 }
1827
1828 if (where->head)
1829 {
1830 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1831 where = where->head;
1832 }
1833 1637
1834 if (op->more) 1638 if (op->more)
1835 { 1639 {
1836 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1640 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1837 return op; 1641 return op;
1839 1643
1840 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1644 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1841 CLEAR_FLAG (op, FLAG_REMOVED); 1645 CLEAR_FLAG (op, FLAG_REMOVED);
1842 if (op->nrof) 1646 if (op->nrof)
1843 { 1647 {
1844 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1648 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1845 if (CAN_MERGE (tmp, op)) 1649 if (object::can_merge (tmp, op))
1846 { 1650 {
1847 /* return the original object and remove inserted object 1651 /* return the original object and remove inserted object
1848 (client needs the original object) */ 1652 (client needs the original object) */
1849 tmp->nrof += op->nrof; 1653 tmp->nrof += op->nrof;
1850 /* Weight handling gets pretty funky. Since we are adding to 1654 /* Weight handling gets pretty funky. Since we are adding to
1851 * tmp->nrof, we need to increase the weight. 1655 * tmp->nrof, we need to increase the weight.
1852 */ 1656 */
1853 add_weight (where, op->weight * op->nrof); 1657 add_weight (this, op->weight * op->nrof);
1854 SET_FLAG (op, FLAG_REMOVED); 1658 SET_FLAG (op, FLAG_REMOVED);
1855 free_object (op); /* free the inserted object */ 1659 op->destroy (); /* free the inserted object */
1856 op = tmp; 1660 op = tmp;
1857 remove_ob (op); /* and fix old object's links */ 1661 op->remove (); /* and fix old object's links */
1858 CLEAR_FLAG (op, FLAG_REMOVED); 1662 CLEAR_FLAG (op, FLAG_REMOVED);
1859 break; 1663 break;
1860 } 1664 }
1861 1665
1862 /* I assume combined objects have no inventory 1666 /* I assume combined objects have no inventory
1863 * We add the weight - this object could have just been removed 1667 * We add the weight - this object could have just been removed
1864 * (if it was possible to merge). calling remove_ob will subtract 1668 * (if it was possible to merge). calling remove_ob will subtract
1865 * the weight, so we need to add it in again, since we actually do 1669 * the weight, so we need to add it in again, since we actually do
1866 * the linking below 1670 * the linking below
1867 */ 1671 */
1868 add_weight (where, op->weight * op->nrof); 1672 add_weight (this, op->weight * op->nrof);
1869 } 1673 }
1870 else 1674 else
1871 add_weight (where, (op->weight + op->carrying)); 1675 add_weight (this, (op->weight + op->carrying));
1872 1676
1873 otmp = is_player_inv (where); 1677 otmp = this->in_player ();
1874 if (otmp && otmp->contr != NULL) 1678 if (otmp && otmp->contr)
1875 {
1876 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1679 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1877 fix_player (otmp); 1680 otmp->update_stats ();
1878 }
1879 1681
1880 op->map = NULL; 1682 op->map = 0;
1881 op->env = where; 1683 op->env = this;
1882 op->above = NULL; 1684 op->above = 0;
1883 op->below = NULL; 1685 op->below = 0;
1884 op->x = 0, op->y = 0; 1686 op->x = 0, op->y = 0;
1885 1687
1886 /* reset the light list and los of the players on the map */ 1688 /* reset the light list and los of the players on the map */
1887 if ((op->glow_radius != 0) && where->map) 1689 if ((op->glow_radius != 0) && map)
1888 { 1690 {
1889#ifdef DEBUG_LIGHTS 1691#ifdef DEBUG_LIGHTS
1890 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1692 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1891#endif /* DEBUG_LIGHTS */ 1693#endif /* DEBUG_LIGHTS */
1892 if (MAP_DARKNESS (where->map)) 1694 if (map->darkness)
1893 update_all_los (where->map, where->x, where->y); 1695 update_all_los (map, x, y);
1894 } 1696 }
1895 1697
1896 /* Client has no idea of ordering so lets not bother ordering it here. 1698 /* Client has no idea of ordering so lets not bother ordering it here.
1897 * It sure simplifies this function... 1699 * It sure simplifies this function...
1898 */ 1700 */
1899 if (where->inv == NULL) 1701 if (!inv)
1900 where->inv = op; 1702 inv = op;
1901 else 1703 else
1902 { 1704 {
1903 op->below = where->inv; 1705 op->below = inv;
1904 op->below->above = op; 1706 op->below->above = op;
1905 where->inv = op; 1707 inv = op;
1906 } 1708 }
1709
1710 INVOKE_OBJECT (INSERT, this);
1711
1907 return op; 1712 return op;
1908} 1713}
1909 1714
1910/* 1715/*
1911 * Checks if any objects has a move_type that matches objects 1716 * Checks if any objects has a move_type that matches objects
1962 1767
1963 /* The objects have to be checked from top to bottom. 1768 /* The objects have to be checked from top to bottom.
1964 * Hence, we first go to the top: 1769 * Hence, we first go to the top:
1965 */ 1770 */
1966 1771
1967 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1772 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1968 { 1773 {
1969 /* Trim the search when we find the first other spell effect 1774 /* Trim the search when we find the first other spell effect
1970 * this helps performance so that if a space has 50 spell objects, 1775 * this helps performance so that if a space has 50 spell objects,
1971 * we don't need to check all of them. 1776 * we don't need to check all of them.
1972 */ 1777 */
2027/* 1832/*
2028 * present_arch(arch, map, x, y) searches for any objects with 1833 * present_arch(arch, map, x, y) searches for any objects with
2029 * a matching archetype at the given map and coordinates. 1834 * a matching archetype at the given map and coordinates.
2030 * The first matching object is returned, or NULL if none. 1835 * The first matching object is returned, or NULL if none.
2031 */ 1836 */
2032
2033object * 1837object *
2034present_arch (const archetype *at, maptile *m, int x, int y) 1838present_arch (const archetype *at, maptile *m, int x, int y)
2035{ 1839{
2036 object *
2037 tmp;
2038
2039 if (m == NULL || out_of_map (m, x, y)) 1840 if (m == NULL || out_of_map (m, x, y))
2040 { 1841 {
2041 LOG (llevError, "Present_arch called outside map.\n"); 1842 LOG (llevError, "Present_arch called outside map.\n");
2042 return NULL; 1843 return NULL;
2043 } 1844 }
1845
2044 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1846 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2045 if (tmp->arch == at) 1847 if (tmp->arch == at)
2046 return tmp; 1848 return tmp;
1849
2047 return NULL; 1850 return NULL;
2048} 1851}
2049 1852
2050/* 1853/*
2051 * present(type, map, x, y) searches for any objects with 1854 * present(type, map, x, y) searches for any objects with
2052 * a matching type variable at the given map and coordinates. 1855 * a matching type variable at the given map and coordinates.
2053 * The first matching object is returned, or NULL if none. 1856 * The first matching object is returned, or NULL if none.
2054 */ 1857 */
2055
2056object * 1858object *
2057present (unsigned char type, maptile *m, int x, int y) 1859present (unsigned char type, maptile *m, int x, int y)
2058{ 1860{
2059 object *
2060 tmp;
2061
2062 if (out_of_map (m, x, y)) 1861 if (out_of_map (m, x, y))
2063 { 1862 {
2064 LOG (llevError, "Present called outside map.\n"); 1863 LOG (llevError, "Present called outside map.\n");
2065 return NULL; 1864 return NULL;
2066 } 1865 }
1866
2067 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1867 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2068 if (tmp->type == type) 1868 if (tmp->type == type)
2069 return tmp; 1869 return tmp;
1870
2070 return NULL; 1871 return NULL;
2071} 1872}
2072 1873
2073/* 1874/*
2074 * present_in_ob(type, object) searches for any objects with 1875 * present_in_ob(type, object) searches for any objects with
2075 * a matching type variable in the inventory of the given object. 1876 * a matching type variable in the inventory of the given object.
2076 * The first matching object is returned, or NULL if none. 1877 * The first matching object is returned, or NULL if none.
2077 */ 1878 */
2078
2079object * 1879object *
2080present_in_ob (unsigned char type, const object *op) 1880present_in_ob (unsigned char type, const object *op)
2081{ 1881{
2082 object *
2083 tmp;
2084
2085 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1882 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2086 if (tmp->type == type) 1883 if (tmp->type == type)
2087 return tmp; 1884 return tmp;
1885
2088 return NULL; 1886 return NULL;
2089} 1887}
2090 1888
2091/* 1889/*
2092 * present_in_ob (type, str, object) searches for any objects with 1890 * present_in_ob (type, str, object) searches for any objects with
2100 * str is the string to match against. Note that we match against 1898 * str is the string to match against. Note that we match against
2101 * the object name, not the archetype name. this is so that the 1899 * the object name, not the archetype name. this is so that the
2102 * spell code can use one object type (force), but change it's name 1900 * spell code can use one object type (force), but change it's name
2103 * to be unique. 1901 * to be unique.
2104 */ 1902 */
2105
2106object * 1903object *
2107present_in_ob_by_name (int type, const char *str, const object *op) 1904present_in_ob_by_name (int type, const char *str, const object *op)
2108{ 1905{
2109 object *
2110 tmp;
2111
2112 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1906 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2113 {
2114 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1907 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2115 return tmp; 1908 return tmp;
2116 } 1909
2117 return NULL; 1910 return 0;
2118} 1911}
2119 1912
2120/* 1913/*
2121 * present_arch_in_ob(archetype, object) searches for any objects with 1914 * present_arch_in_ob(archetype, object) searches for any objects with
2122 * a matching archetype in the inventory of the given object. 1915 * a matching archetype in the inventory of the given object.
2123 * The first matching object is returned, or NULL if none. 1916 * The first matching object is returned, or NULL if none.
2124 */ 1917 */
2125
2126object * 1918object *
2127present_arch_in_ob (const archetype *at, const object *op) 1919present_arch_in_ob (const archetype *at, const object *op)
2128{ 1920{
2129 object *
2130 tmp;
2131
2132 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1921 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2133 if (tmp->arch == at) 1922 if (tmp->arch == at)
2134 return tmp; 1923 return tmp;
1924
2135 return NULL; 1925 return NULL;
2136} 1926}
2137 1927
2138/* 1928/*
2139 * activate recursively a flag on an object inventory 1929 * activate recursively a flag on an object inventory
2140 */ 1930 */
2141void 1931void
2142flag_inv (object *op, int flag) 1932flag_inv (object *op, int flag)
2143{ 1933{
2144 object *
2145 tmp;
2146
2147 if (op->inv) 1934 if (op->inv)
2148 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1935 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2149 { 1936 {
2150 SET_FLAG (tmp, flag); 1937 SET_FLAG (tmp, flag);
2151 flag_inv (tmp, flag); 1938 flag_inv (tmp, flag);
2152 } 1939 }
2153} /* 1940}
1941
1942/*
2154 * desactivate recursively a flag on an object inventory 1943 * deactivate recursively a flag on an object inventory
2155 */ 1944 */
2156void 1945void
2157unflag_inv (object *op, int flag) 1946unflag_inv (object *op, int flag)
2158{ 1947{
2159 object *
2160 tmp;
2161
2162 if (op->inv) 1948 if (op->inv)
2163 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1949 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2164 { 1950 {
2165 CLEAR_FLAG (tmp, flag); 1951 CLEAR_FLAG (tmp, flag);
2166 unflag_inv (tmp, flag); 1952 unflag_inv (tmp, flag);
2167 } 1953 }
2168} 1954}
2171 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1957 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2172 * all it's inventory (recursively). 1958 * all it's inventory (recursively).
2173 * If checksums are used, a player will get set_cheat called for 1959 * If checksums are used, a player will get set_cheat called for
2174 * him/her-self and all object carried by a call to this function. 1960 * him/her-self and all object carried by a call to this function.
2175 */ 1961 */
2176
2177void 1962void
2178set_cheat (object *op) 1963set_cheat (object *op)
2179{ 1964{
2180 SET_FLAG (op, FLAG_WAS_WIZ); 1965 SET_FLAG (op, FLAG_WAS_WIZ);
2181 flag_inv (op, FLAG_WAS_WIZ); 1966 flag_inv (op, FLAG_WAS_WIZ);
2200 * because arch_blocked (now ob_blocked) needs to know the movement type 1985 * because arch_blocked (now ob_blocked) needs to know the movement type
2201 * to know if the space in question will block the object. We can't use 1986 * to know if the space in question will block the object. We can't use
2202 * the archetype because that isn't correct if the monster has been 1987 * the archetype because that isn't correct if the monster has been
2203 * customized, changed states, etc. 1988 * customized, changed states, etc.
2204 */ 1989 */
2205
2206int 1990int
2207find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1991find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2208{ 1992{
2209 int
2210 i,
2211 index = 0, flag; 1993 int index = 0, flag;
2212 static int
2213 altern[SIZEOFFREE]; 1994 int altern[SIZEOFFREE];
2214 1995
2215 for (i = start; i < stop; i++) 1996 for (int i = start; i < stop; i++)
2216 { 1997 {
2217 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1998 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2218 if (!flag) 1999 if (!flag)
2219 altern[index++] = i; 2000 altern [index++] = i;
2220 2001
2221 /* Basically, if we find a wall on a space, we cut down the search size. 2002 /* Basically, if we find a wall on a space, we cut down the search size.
2222 * In this way, we won't return spaces that are on another side of a wall. 2003 * In this way, we won't return spaces that are on another side of a wall.
2223 * This mostly work, but it cuts down the search size in all directions - 2004 * This mostly work, but it cuts down the search size in all directions -
2224 * if the space being examined only has a wall to the north and empty 2005 * if the space being examined only has a wall to the north and empty
2225 * spaces in all the other directions, this will reduce the search space 2006 * spaces in all the other directions, this will reduce the search space
2226 * to only the spaces immediately surrounding the target area, and 2007 * to only the spaces immediately surrounding the target area, and
2227 * won't look 2 spaces south of the target space. 2008 * won't look 2 spaces south of the target space.
2228 */ 2009 */
2229 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2010 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2230 stop = maxfree[i]; 2011 stop = maxfree[i];
2231 } 2012 }
2013
2232 if (!index) 2014 if (!index)
2233 return -1; 2015 return -1;
2016
2234 return altern[RANDOM () % index]; 2017 return altern[RANDOM () % index];
2235} 2018}
2236 2019
2237/* 2020/*
2238 * find_first_free_spot(archetype, maptile, x, y) works like 2021 * find_first_free_spot(archetype, maptile, x, y) works like
2239 * find_free_spot(), but it will search max number of squares. 2022 * find_free_spot(), but it will search max number of squares.
2240 * But it will return the first available spot, not a random choice. 2023 * But it will return the first available spot, not a random choice.
2241 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2024 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2242 */ 2025 */
2243
2244int 2026int
2245find_first_free_spot (const object *ob, maptile *m, int x, int y) 2027find_first_free_spot (const object *ob, maptile *m, int x, int y)
2246{ 2028{
2247 int
2248 i;
2249
2250 for (i = 0; i < SIZEOFFREE; i++) 2029 for (int i = 0; i < SIZEOFFREE; i++)
2251 {
2252 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2030 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2253 return i; 2031 return i;
2254 } 2032
2255 return -1; 2033 return -1;
2256} 2034}
2257 2035
2258/* 2036/*
2259 * The function permute(arr, begin, end) randomly reorders the array 2037 * The function permute(arr, begin, end) randomly reorders the array
2260 * arr[begin..end-1]. 2038 * arr[begin..end-1].
2039 * now uses a fisher-yates shuffle, old permute was broken
2261 */ 2040 */
2262static void 2041static void
2263permute (int *arr, int begin, int end) 2042permute (int *arr, int begin, int end)
2264{ 2043{
2265 int 2044 arr += begin;
2266 i,
2267 j,
2268 tmp,
2269 len;
2270
2271 len = end - begin; 2045 end -= begin;
2272 for (i = begin; i < end; i++)
2273 {
2274 j = begin + RANDOM () % len;
2275 2046
2276 tmp = arr[i]; 2047 while (--end)
2277 arr[i] = arr[j]; 2048 swap (arr [end], arr [RANDOM () % (end + 1)]);
2278 arr[j] = tmp;
2279 }
2280} 2049}
2281 2050
2282/* new function to make monster searching more efficient, and effective! 2051/* new function to make monster searching more efficient, and effective!
2283 * This basically returns a randomized array (in the passed pointer) of 2052 * This basically returns a randomized array (in the passed pointer) of
2284 * the spaces to find monsters. In this way, it won't always look for 2053 * the spaces to find monsters. In this way, it won't always look for
2287 * the 3x3 area will be searched, just not in a predictable order. 2056 * the 3x3 area will be searched, just not in a predictable order.
2288 */ 2057 */
2289void 2058void
2290get_search_arr (int *search_arr) 2059get_search_arr (int *search_arr)
2291{ 2060{
2292 int 2061 int i;
2293 i;
2294 2062
2295 for (i = 0; i < SIZEOFFREE; i++) 2063 for (i = 0; i < SIZEOFFREE; i++)
2296 {
2297 search_arr[i] = i; 2064 search_arr[i] = i;
2298 }
2299 2065
2300 permute (search_arr, 1, SIZEOFFREE1 + 1); 2066 permute (search_arr, 1, SIZEOFFREE1 + 1);
2301 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2067 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2302 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2068 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2303} 2069}
2312 * Perhaps incorrectly, but I'm making the assumption that exclude 2078 * Perhaps incorrectly, but I'm making the assumption that exclude
2313 * is actually want is going to try and move there. We need this info 2079 * is actually want is going to try and move there. We need this info
2314 * because we have to know what movement the thing looking to move 2080 * because we have to know what movement the thing looking to move
2315 * there is capable of. 2081 * there is capable of.
2316 */ 2082 */
2317
2318int 2083int
2319find_dir (maptile *m, int x, int y, object *exclude) 2084find_dir (maptile *m, int x, int y, object *exclude)
2320{ 2085{
2321 int
2322 i,
2323 max = SIZEOFFREE, mflags; 2086 int i, max = SIZEOFFREE, mflags;
2324 2087
2325 sint16 nx, ny; 2088 sint16 nx, ny;
2326 object * 2089 object *tmp;
2327 tmp;
2328 maptile * 2090 maptile *mp;
2329 mp;
2330 2091
2331 MoveType blocked, move_type; 2092 MoveType blocked, move_type;
2332 2093
2333 if (exclude && exclude->head) 2094 if (exclude && exclude->head)
2334 { 2095 {
2346 mp = m; 2107 mp = m;
2347 nx = x + freearr_x[i]; 2108 nx = x + freearr_x[i];
2348 ny = y + freearr_y[i]; 2109 ny = y + freearr_y[i];
2349 2110
2350 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2111 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2112
2351 if (mflags & P_OUT_OF_MAP) 2113 if (mflags & P_OUT_OF_MAP)
2352 {
2353 max = maxfree[i]; 2114 max = maxfree[i];
2354 }
2355 else 2115 else
2356 { 2116 {
2357 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2117 mapspace &ms = mp->at (nx, ny);
2118
2119 blocked = ms.move_block;
2358 2120
2359 if ((move_type & blocked) == move_type) 2121 if ((move_type & blocked) == move_type)
2360 {
2361 max = maxfree[i]; 2122 max = maxfree[i];
2362 }
2363 else if (mflags & P_IS_ALIVE) 2123 else if (mflags & P_IS_ALIVE)
2364 { 2124 {
2365 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2125 for (tmp = ms.bot; tmp; tmp = tmp->above)
2366 { 2126 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2367 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2127 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2368 {
2369 break; 2128 break;
2370 } 2129
2371 }
2372 if (tmp) 2130 if (tmp)
2373 {
2374 return freedir[i]; 2131 return freedir[i];
2375 }
2376 } 2132 }
2377 } 2133 }
2378 } 2134 }
2135
2379 return 0; 2136 return 0;
2380} 2137}
2381 2138
2382/* 2139/*
2383 * distance(object 1, object 2) will return the square of the 2140 * distance(object 1, object 2) will return the square of the
2384 * distance between the two given objects. 2141 * distance between the two given objects.
2385 */ 2142 */
2386
2387int 2143int
2388distance (const object *ob1, const object *ob2) 2144distance (const object *ob1, const object *ob2)
2389{ 2145{
2390 int
2391 i;
2392
2393 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2146 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2394 return i;
2395} 2147}
2396 2148
2397/* 2149/*
2398 * find_dir_2(delta-x,delta-y) will return a direction in which 2150 * find_dir_2(delta-x,delta-y) will return a direction in which
2399 * an object which has subtracted the x and y coordinates of another 2151 * an object which has subtracted the x and y coordinates of another
2400 * object, needs to travel toward it. 2152 * object, needs to travel toward it.
2401 */ 2153 */
2402
2403int 2154int
2404find_dir_2 (int x, int y) 2155find_dir_2 (int x, int y)
2405{ 2156{
2406 int 2157 int q;
2407 q;
2408 2158
2409 if (y) 2159 if (y)
2410 q = x * 100 / y; 2160 q = x * 100 / y;
2411 else if (x) 2161 else if (x)
2412 q = -300 * x; 2162 q = -300 * x;
2447int 2197int
2448absdir (int d) 2198absdir (int d)
2449{ 2199{
2450 while (d < 1) 2200 while (d < 1)
2451 d += 8; 2201 d += 8;
2202
2452 while (d > 8) 2203 while (d > 8)
2453 d -= 8; 2204 d -= 8;
2205
2454 return d; 2206 return d;
2455} 2207}
2456 2208
2457/* 2209/*
2458 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2210 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2460 */ 2212 */
2461 2213
2462int 2214int
2463dirdiff (int dir1, int dir2) 2215dirdiff (int dir1, int dir2)
2464{ 2216{
2465 int 2217 int d;
2466 d;
2467 2218
2468 d = abs (dir1 - dir2); 2219 d = abs (dir1 - dir2);
2469 if (d > 4) 2220 if (d > 4)
2470 d = 8 - d; 2221 d = 8 - d;
2222
2471 return d; 2223 return d;
2472} 2224}
2473 2225
2474/* peterm: 2226/* peterm:
2475 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2227 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2478 * This basically means that if direction is 15, then it could either go 2230 * This basically means that if direction is 15, then it could either go
2479 * direction 4, 14, or 16 to get back to where we are. 2231 * direction 4, 14, or 16 to get back to where we are.
2480 * Moved from spell_util.c to object.c with the other related direction 2232 * Moved from spell_util.c to object.c with the other related direction
2481 * functions. 2233 * functions.
2482 */ 2234 */
2483
2484int
2485 reduction_dir[SIZEOFFREE][3] = { 2235int reduction_dir[SIZEOFFREE][3] = {
2486 {0, 0, 0}, /* 0 */ 2236 {0, 0, 0}, /* 0 */
2487 {0, 0, 0}, /* 1 */ 2237 {0, 0, 0}, /* 1 */
2488 {0, 0, 0}, /* 2 */ 2238 {0, 0, 0}, /* 2 */
2489 {0, 0, 0}, /* 3 */ 2239 {0, 0, 0}, /* 3 */
2490 {0, 0, 0}, /* 4 */ 2240 {0, 0, 0}, /* 4 */
2538 * find a path to that monster that we found. If not, 2288 * find a path to that monster that we found. If not,
2539 * we don't bother going toward it. Returns 1 if we 2289 * we don't bother going toward it. Returns 1 if we
2540 * can see a direct way to get it 2290 * can see a direct way to get it
2541 * Modified to be map tile aware -.MSW 2291 * Modified to be map tile aware -.MSW
2542 */ 2292 */
2543
2544
2545int 2293int
2546can_see_monsterP (maptile *m, int x, int y, int dir) 2294can_see_monsterP (maptile *m, int x, int y, int dir)
2547{ 2295{
2548 sint16 dx, dy; 2296 sint16 dx, dy;
2549 int
2550 mflags; 2297 int mflags;
2551 2298
2552 if (dir < 0) 2299 if (dir < 0)
2553 return 0; /* exit condition: invalid direction */ 2300 return 0; /* exit condition: invalid direction */
2554 2301
2555 dx = x + freearr_x[dir]; 2302 dx = x + freearr_x[dir];
2568 return 0; 2315 return 0;
2569 2316
2570 /* yes, can see. */ 2317 /* yes, can see. */
2571 if (dir < 9) 2318 if (dir < 9)
2572 return 1; 2319 return 1;
2320
2573 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2321 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2574 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2322 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2323 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2575} 2324}
2576
2577
2578 2325
2579/* 2326/*
2580 * can_pick(picker, item): finds out if an object is possible to be 2327 * can_pick(picker, item): finds out if an object is possible to be
2581 * picked up by the picker. Returnes 1 if it can be 2328 * picked up by the picker. Returnes 1 if it can be
2582 * picked up, otherwise 0. 2329 * picked up, otherwise 0.
2593 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2340 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2594 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2341 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2595 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2342 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2596} 2343}
2597 2344
2598
2599/* 2345/*
2600 * create clone from object to another 2346 * create clone from object to another
2601 */ 2347 */
2602object * 2348object *
2603object_create_clone (object *asrc) 2349object_create_clone (object *asrc)
2604{ 2350{
2605 object *
2606 dst = NULL, *tmp, *src, *part, *prev, *item; 2351 object *dst = 0, *tmp, *src, *part, *prev, *item;
2607 2352
2608 if (!asrc) 2353 if (!asrc)
2609 return NULL; 2354 return 0;
2355
2610 src = asrc; 2356 src = asrc;
2611 if (src->head) 2357 if (src->head)
2612 src = src->head; 2358 src = src->head;
2613 2359
2614 prev = NULL; 2360 prev = 0;
2615 for (part = src; part; part = part->more) 2361 for (part = src; part; part = part->more)
2616 { 2362 {
2617 tmp = get_object (); 2363 tmp = part->clone ();
2618 copy_object (part, tmp);
2619 tmp->x -= src->x; 2364 tmp->x -= src->x;
2620 tmp->y -= src->y; 2365 tmp->y -= src->y;
2366
2621 if (!part->head) 2367 if (!part->head)
2622 { 2368 {
2623 dst = tmp; 2369 dst = tmp;
2624 tmp->head = NULL; 2370 tmp->head = 0;
2625 } 2371 }
2626 else 2372 else
2627 {
2628 tmp->head = dst; 2373 tmp->head = dst;
2629 } 2374
2630 tmp->more = NULL; 2375 tmp->more = 0;
2376
2631 if (prev) 2377 if (prev)
2632 prev->more = tmp; 2378 prev->more = tmp;
2379
2633 prev = tmp; 2380 prev = tmp;
2634 } 2381 }
2635 2382
2636 for (item = src->inv; item; item = item->below) 2383 for (item = src->inv; item; item = item->below)
2637 insert_ob_in_ob (object_create_clone (item), dst); 2384 insert_ob_in_ob (object_create_clone (item), dst);
2643/* Basically, we save the content of the string to a temp file, then call */ 2390/* Basically, we save the content of the string to a temp file, then call */
2644/* load_object on it. I admit it is a highly inefficient way to make things, */ 2391/* load_object on it. I admit it is a highly inefficient way to make things, */
2645/* but it was simple to make and allows reusing the load_object function. */ 2392/* but it was simple to make and allows reusing the load_object function. */
2646/* Remember not to use load_object_str in a time-critical situation. */ 2393/* Remember not to use load_object_str in a time-critical situation. */
2647/* Also remember that multiparts objects are not supported for now. */ 2394/* Also remember that multiparts objects are not supported for now. */
2648
2649object * 2395object *
2650load_object_str (const char *obstr) 2396load_object_str (const char *obstr)
2651{ 2397{
2652 object *op; 2398 object *op;
2653 char filename[MAX_BUF]; 2399 char filename[MAX_BUF];
2663 } 2409 }
2664 2410
2665 fprintf (tempfile, obstr); 2411 fprintf (tempfile, obstr);
2666 fclose (tempfile); 2412 fclose (tempfile);
2667 2413
2668 op = get_object (); 2414 op = object::create ();
2669 2415
2670 object_thawer thawer (filename); 2416 object_thawer thawer (filename);
2671 2417
2672 if (thawer) 2418 if (thawer)
2673 load_object (thawer, op, 0); 2419 load_object (thawer, op, 0);
2683 * returns NULL if no match. 2429 * returns NULL if no match.
2684 */ 2430 */
2685object * 2431object *
2686find_obj_by_type_subtype (const object *who, int type, int subtype) 2432find_obj_by_type_subtype (const object *who, int type, int subtype)
2687{ 2433{
2688 object *tmp;
2689
2690 for (tmp = who->inv; tmp; tmp = tmp->below) 2434 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2691 if (tmp->type == type && tmp->subtype == subtype) 2435 if (tmp->type == type && tmp->subtype == subtype)
2692 return tmp; 2436 return tmp;
2693 2437
2694 return NULL; 2438 return 0;
2695} 2439}
2696 2440
2697/* If ob has a field named key, return the link from the list, 2441/* If ob has a field named key, return the link from the list,
2698 * otherwise return NULL. 2442 * otherwise return NULL.
2699 * 2443 *
2701 * do the desired thing. 2445 * do the desired thing.
2702 */ 2446 */
2703key_value * 2447key_value *
2704get_ob_key_link (const object *ob, const char *key) 2448get_ob_key_link (const object *ob, const char *key)
2705{ 2449{
2706 key_value *link;
2707
2708 for (link = ob->key_values; link != NULL; link = link->next) 2450 for (key_value *link = ob->key_values; link; link = link->next)
2709 if (link->key == key) 2451 if (link->key == key)
2710 return link; 2452 return link;
2711 2453
2712 return NULL; 2454 return 0;
2713} 2455}
2714 2456
2715/* 2457/*
2716 * Returns the value of op has an extra_field for key, or NULL. 2458 * Returns the value of op has an extra_field for key, or NULL.
2717 * 2459 *
2757 * Returns TRUE on success. 2499 * Returns TRUE on success.
2758 */ 2500 */
2759int 2501int
2760set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2502set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2761{ 2503{
2762 key_value *
2763 field = NULL, *last = NULL; 2504 key_value *field = NULL, *last = NULL;
2764 2505
2765 for (field = op->key_values; field != NULL; field = field->next) 2506 for (field = op->key_values; field != NULL; field = field->next)
2766 { 2507 {
2767 if (field->key != canonical_key) 2508 if (field->key != canonical_key)
2768 { 2509 {
2796 /* IF we get here, key doesn't exist */ 2537 /* IF we get here, key doesn't exist */
2797 2538
2798 /* No field, we'll have to add it. */ 2539 /* No field, we'll have to add it. */
2799 2540
2800 if (!add_key) 2541 if (!add_key)
2801 {
2802 return FALSE; 2542 return FALSE;
2803 } 2543
2804 /* There isn't any good reason to store a null 2544 /* There isn't any good reason to store a null
2805 * value in the key/value list. If the archetype has 2545 * value in the key/value list. If the archetype has
2806 * this key, then we should also have it, so shouldn't 2546 * this key, then we should also have it, so shouldn't
2807 * be here. If user wants to store empty strings, 2547 * be here. If user wants to store empty strings,
2808 * should pass in "" 2548 * should pass in ""

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines