ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.61 by root, Mon Dec 11 21:32:16 2006 UTC vs.
Revision 1.91 by elmex, Tue Dec 26 10:51:52 2006 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193 195
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
354 op = op->env; 352 op = op->env;
355 return op; 353 return op;
356} 354}
357 355
358/* 356/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 358 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
377 */ 360 */
378 361
381{ 364{
382 if (!op) 365 if (!op)
383 return strdup ("[NULLOBJ]"); 366 return strdup ("[NULLOBJ]");
384 367
385 object_freezer freezer; 368 object_freezer freezer;
386 save_object (freezer, op, 3); 369 save_object (freezer, op, 1);
387 return freezer.as_string (); 370 return freezer.as_string ();
388} 371}
389 372
390/* 373/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
484 } 467 }
485 468
486 op->key_values = 0; 469 op->key_values = 0;
487} 470}
488 471
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 472/*
541 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 478 * will point at garbage.
547 */ 479 */
548void 480void
549copy_object (object *op2, object *op) 481object::copy_to (object *dst)
550{ 482{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 485
554 op2->clone (op); 486 *(object_copy *)dst = *this;
555 487
556 if (is_freed) 488 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
558 490
559 if (is_removed) 491 if (is_removed)
560 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
561 493
562 if (op2->speed < 0) 494 if (speed < 0)
563 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
564 496
565 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
566 if (op2->key_values) 498 if (key_values)
567 { 499 {
568 key_value *tail = 0; 500 key_value *tail = 0;
569 key_value *i; 501 key_value *i;
570 502
571 op->key_values = 0; 503 dst->key_values = 0;
572 504
573 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
574 { 506 {
575 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
576 508
577 new_link->next = 0; 509 new_link->next = 0;
578 new_link->key = i->key; 510 new_link->key = i->key;
579 new_link->value = i->value; 511 new_link->value = i->value;
580 512
581 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
582 if (!op->key_values) 514 if (!dst->key_values)
583 { 515 {
584 op->key_values = new_link; 516 dst->key_values = new_link;
585 tail = new_link; 517 tail = new_link;
586 } 518 }
587 else 519 else
588 { 520 {
589 tail->next = new_link; 521 tail->next = new_link;
590 tail = new_link; 522 tail = new_link;
591 } 523 }
592 } 524 }
593 } 525 }
594 526
595 update_ob_speed (op); 527 dst->set_speed (dst->speed);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
596} 536}
597 537
598/* 538/*
599 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
600 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
614 * Updates the speed of an object. If the speed changes from 0 to another 554 * Updates the speed of an object. If the speed changes from 0 to another
615 * value, or vice versa, then add/remove the object from the active list. 555 * value, or vice versa, then add/remove the object from the active list.
616 * This function needs to be called whenever the speed of an object changes. 556 * This function needs to be called whenever the speed of an object changes.
617 */ 557 */
618void 558void
619update_ob_speed (object *op) 559object::set_speed (float speed)
620{ 560{
621 extern int arch_init; 561 extern int arch_init;
622 562
623 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
624 * since they never really need to be updated. 564 * since they never really need to be updated.
625 */ 565 */
626 566 if (flag [FLAG_FREED] && speed)
627 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
628 { 567 {
629 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &name);
630#ifdef MANY_CORES
631 abort ();
632#else
633 op->speed = 0; 569 speed = 0;
634#endif
635 } 570 }
571
572 this->speed = speed;
636 573
637 if (arch_init) 574 if (arch_init)
638 return; 575 return;
639 576
640 if (FABS (op->speed) > MIN_ACTIVE_SPEED) 577 if (FABS (speed) > MIN_ACTIVE_SPEED)
641 { 578 {
642 /* If already on active list, don't do anything */ 579 /* If already on active list, don't do anything */
643 if (op->active_next || op->active_prev || op == active_objects) 580 if (active_next || active_prev || this == active_objects)
644 return; 581 return;
645 582
646 /* process_events() expects us to insert the object at the beginning 583 /* process_events() expects us to insert the object at the beginning
647 * of the list. */ 584 * of the list. */
648 op->active_next = active_objects; 585 active_next = active_objects;
649 586
650 if (op->active_next != NULL) 587 if (active_next)
651 op->active_next->active_prev = op; 588 active_next->active_prev = this;
652 589
653 active_objects = op; 590 active_objects = this;
654 } 591 }
655 else 592 else
656 { 593 {
657 /* If not on the active list, nothing needs to be done */ 594 /* If not on the active list, nothing needs to be done */
658 if (!op->active_next && !op->active_prev && op != active_objects) 595 if (!active_next && !active_prev && this != active_objects)
659 return; 596 return;
660 597
661 if (op->active_prev == NULL) 598 if (!active_prev)
662 { 599 {
663 active_objects = op->active_next; 600 active_objects = active_next;
664 601
665 if (op->active_next != NULL) 602 if (active_next)
666 op->active_next->active_prev = NULL; 603 active_next->active_prev = 0;
667 } 604 }
668 else 605 else
669 { 606 {
670 op->active_prev->active_next = op->active_next; 607 active_prev->active_next = active_next;
671 608
672 if (op->active_next) 609 if (active_next)
673 op->active_next->active_prev = op->active_prev; 610 active_next->active_prev = active_prev;
674 } 611 }
675 612
676 op->active_next = NULL; 613 active_next = 0;
677 op->active_prev = NULL; 614 active_prev = 0;
678 } 615 }
679} 616}
680 617
681/* This function removes object 'op' from the list of active 618/* This function removes object 'op' from the list of active
682 * objects. 619 * objects.
708 op->active_next = NULL; 645 op->active_next = NULL;
709 op->active_prev = NULL; 646 op->active_prev = NULL;
710} 647}
711 648
712/* 649/*
713 * update_object() updates the array which represents the map. 650 * update_object() updates the the map.
714 * It takes into account invisible objects (and represent squares covered 651 * It takes into account invisible objects (and represent squares covered
715 * by invisible objects by whatever is below them (unless it's another 652 * by invisible objects by whatever is below them (unless it's another
716 * invisible object, etc...) 653 * invisible object, etc...)
717 * If the object being updated is beneath a player, the look-window 654 * If the object being updated is beneath a player, the look-window
718 * of that player is updated (this might be a suboptimal way of 655 * of that player is updated (this might be a suboptimal way of
719 * updating that window, though, since update_object() is called _often_) 656 * updating that window, though, since update_object() is called _often_)
720 * 657 *
721 * action is a hint of what the caller believes need to be done. 658 * action is a hint of what the caller believes need to be done.
722 * For example, if the only thing that has changed is the face (due to
723 * an animation), we don't need to call update_position until that actually
724 * comes into view of a player. OTOH, many other things, like addition/removal
725 * of walls or living creatures may need us to update the flags now.
726 * current action are: 659 * current action are:
727 * UP_OBJ_INSERT: op was inserted 660 * UP_OBJ_INSERT: op was inserted
728 * UP_OBJ_REMOVE: op was removed 661 * UP_OBJ_REMOVE: op was removed
729 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 662 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
730 * as that is easier than trying to look at what may have changed. 663 * as that is easier than trying to look at what may have changed.
731 * UP_OBJ_FACE: only the objects face has changed. 664 * UP_OBJ_FACE: only the objects face has changed.
732 */ 665 */
733
734void 666void
735update_object (object *op, int action) 667update_object (object *op, int action)
736{ 668{
737 int update_now = 0, flags;
738 MoveType move_on, move_off, move_block, move_slow; 669 MoveType move_on, move_off, move_block, move_slow;
739 670
740 if (op == NULL) 671 if (op == NULL)
741 { 672 {
742 /* this should never happen */ 673 /* this should never happen */
743 LOG (llevDebug, "update_object() called for NULL object.\n"); 674 LOG (llevDebug, "update_object() called for NULL object.\n");
744 return; 675 return;
745 } 676 }
746 677
747 if (op->env != NULL) 678 if (op->env)
748 { 679 {
749 /* Animation is currently handled by client, so nothing 680 /* Animation is currently handled by client, so nothing
750 * to do in this case. 681 * to do in this case.
751 */ 682 */
752 return; 683 return;
757 */ 688 */
758 if (!op->map || op->map->in_memory == MAP_SAVING) 689 if (!op->map || op->map->in_memory == MAP_SAVING)
759 return; 690 return;
760 691
761 /* make sure the object is within map boundaries */ 692 /* make sure the object is within map boundaries */
762 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 693 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
763 { 694 {
764 LOG (llevError, "update_object() called for object out of map!\n"); 695 LOG (llevError, "update_object() called for object out of map!\n");
765#ifdef MANY_CORES 696#ifdef MANY_CORES
766 abort (); 697 abort ();
767#endif 698#endif
768 return; 699 return;
769 } 700 }
770 701
771 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 702 mapspace &m = op->ms ();
772 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
773 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
774 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
775 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
776 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
777 703
704 if (m.flags_ & P_NEED_UPDATE)
705 /* nop */;
778 if (action == UP_OBJ_INSERT) 706 else if (action == UP_OBJ_INSERT)
779 { 707 {
708 // this is likely overkill, TODO: revisit (schmorp)
780 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 709 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
781 update_now = 1;
782
783 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 710 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
784 update_now = 1; 711 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
785 712 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
713 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
786 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 714 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
787 update_now = 1;
788
789 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
790 update_now = 1;
791
792 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
793 update_now = 1;
794
795 if ((move_on | op->move_on) != move_on) 715 || (m.move_on | op->move_on ) != m.move_on
796 update_now = 1;
797
798 if ((move_off | op->move_off) != move_off) 716 || (m.move_off | op->move_off ) != m.move_off
799 update_now = 1; 717 || (m.move_slow | op->move_slow) != m.move_slow
800
801 /* This isn't perfect, but I don't expect a lot of objects to 718 /* This isn't perfect, but I don't expect a lot of objects to
802 * to have move_allow right now. 719 * to have move_allow right now.
803 */ 720 */
804 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 721 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
805 update_now = 1; 722 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
806 723 m.flags_ = P_NEED_UPDATE;
807 if ((move_slow | op->move_slow) != move_slow)
808 update_now = 1;
809 } 724 }
810
811 /* if the object is being removed, we can't make intelligent 725 /* if the object is being removed, we can't make intelligent
812 * decisions, because remove_ob can't really pass the object 726 * decisions, because remove_ob can't really pass the object
813 * that is being removed. 727 * that is being removed.
814 */ 728 */
815 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 729 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
816 update_now = 1; 730 m.flags_ = P_NEED_UPDATE;
817 else if (action == UP_OBJ_FACE) 731 else if (action == UP_OBJ_FACE)
818 /* Nothing to do for that case */ ; 732 /* Nothing to do for that case */ ;
819 else 733 else
820 LOG (llevError, "update_object called with invalid action: %d\n", action); 734 LOG (llevError, "update_object called with invalid action: %d\n", action);
821 735
822 if (update_now)
823 {
824 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
825 update_position (op->map, op->x, op->y);
826 }
827
828 if (op->more != NULL) 736 if (op->more)
829 update_object (op->more, action); 737 update_object (op->more, action);
830} 738}
831 739
832object::vector object::mortals;
833object::vector object::objects; // not yet used 740object::vector object::objects; // not yet used
834object *object::first; 741object *object::first;
835
836void object::free_mortals ()
837{
838 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
839 if ((*i)->refcnt)
840 ++i; // further delay freeing
841 else
842 {
843 delete *i;
844 mortals.erase (i);
845 }
846}
847 742
848object::object () 743object::object ()
849{ 744{
850 SET_FLAG (this, FLAG_REMOVED); 745 SET_FLAG (this, FLAG_REMOVED);
851 746
883 778
884 prev = 0; 779 prev = 0;
885 next = 0; 780 next = 0;
886} 781}
887 782
783/*
784 * Remove and free all objects in the inventory of the given object.
785 * object.c ?
786 */
787void
788object::destroy_inv (bool drop_to_ground)
789{
790 /* Only if the space blocks everything do we not process -
791 * if some form of movement is allowed, let objects
792 * drop on that space.
793 */
794 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
795 {
796 while (inv)
797 inv->destroy ();
798 }
799 else
800 { /* Put objects in inventory onto this space */
801 while (inv)
802 {
803 object *op = inv;
804
805 if (op->flag [FLAG_STARTEQUIP]
806 || op->flag [FLAG_NO_DROP]
807 || op->type == RUNE
808 || op->type == TRAP
809 || op->flag [FLAG_IS_A_TEMPLATE])
810 op->destroy ();
811 else
812 {
813 op->remove ();
814 op->x = x;
815 op->y = y;
816 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
817 }
818 }
819 }
820}
821
888object *object::create () 822object *object::create ()
889{ 823{
890 object *op = new object; 824 object *op = new object;
891 op->link (); 825 op->link ();
892 return op; 826 return op;
893} 827}
894 828
895/* 829void
896 * free_object() frees everything allocated by an object, removes 830object::do_destroy ()
897 * it from the list of used objects, and puts it on the list of
898 * free objects. The IS_FREED() flag is set in the object.
899 * The object must have been removed by remove_ob() first for
900 * this function to succeed.
901 *
902 * If destroy_inventory is set, free inventory as well. Else drop items in
903 * inventory to the ground.
904 */
905void object::destroy (bool destroy_inventory)
906{ 831{
907 if (QUERY_FLAG (this, FLAG_FREED)) 832 if (flag [FLAG_IS_LINKED])
833 remove_button_link (this);
834
835 if (flag [FLAG_FRIENDLY])
836 remove_friendly_object (this);
837
838 if (!flag [FLAG_REMOVED])
839 remove ();
840
841 if (flag [FLAG_FREED])
908 return; 842 return;
909 843
910 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 844 flag [FLAG_FREED] = 1;
911 remove_friendly_object (this);
912 845
913 if (!QUERY_FLAG (this, FLAG_REMOVED)) 846 attachable::do_destroy ();
914 remove_ob (this);
915 847
916 SET_FLAG (this, FLAG_FREED); 848 destroy_inv (true);
917 849 set_speed (0);
918 if (more) 850 unlink ();
919 {
920 more->destroy (destroy_inventory);
921 more = 0;
922 }
923
924 if (inv)
925 {
926 /* Only if the space blocks everything do we not process -
927 * if some form of movement is allowed, let objects
928 * drop on that space.
929 */
930 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
931 {
932 object *op = inv;
933
934 while (op)
935 {
936 object *tmp = op->below;
937 op->destroy (destroy_inventory);
938 op = tmp;
939 }
940 }
941 else
942 { /* Put objects in inventory onto this space */
943 object *op = inv;
944
945 while (op)
946 {
947 object *tmp = op->below;
948
949 remove_ob (op);
950
951 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
952 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
953 free_object (op);
954 else
955 {
956 op->x = x;
957 op->y = y;
958 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
959 }
960
961 op = tmp;
962 }
963 }
964 }
965 851
966 // hack to ensure that freed objects still have a valid map 852 // hack to ensure that freed objects still have a valid map
967 { 853 {
968 static maptile *freed_map; // freed objects are moved here to avoid crashes 854 static maptile *freed_map; // freed objects are moved here to avoid crashes
969 855
981 map = freed_map; 867 map = freed_map;
982 x = 1; 868 x = 1;
983 y = 1; 869 y = 1;
984 } 870 }
985 871
872 head = 0;
873
874 if (more)
875 {
876 more->destroy ();
877 more = 0;
878 }
879
986 // clear those pointers that likely might have circular references to us 880 // clear those pointers that likely might have circular references to us
987 owner = 0; 881 owner = 0;
988 enemy = 0; 882 enemy = 0;
989 attacked_by = 0; 883 attacked_by = 0;
990 884
991 // only relevant for players(?), but make sure of it anyways 885 // only relevant for players(?), but make sure of it anyways
992 contr = 0; 886 contr = 0;
887}
993 888
994 /* Remove object from the active list */ 889void
995 speed = 0; 890object::destroy (bool destroy_inventory)
996 update_ob_speed (this); 891{
892 if (destroyed ())
893 return;
997 894
998 unlink (); 895 if (destroy_inventory)
896 destroy_inv (false);
999 897
1000 mortals.push_back (this); 898 attachable::destroy ();
1001} 899}
1002 900
1003/* 901/*
1004 * sub_weight() recursively (outwards) subtracts a number from the 902 * sub_weight() recursively (outwards) subtracts a number from the
1005 * weight of an object (and what is carried by it's environment(s)). 903 * weight of an object (and what is carried by it's environment(s)).
1015 op->carrying -= weight; 913 op->carrying -= weight;
1016 op = op->env; 914 op = op->env;
1017 } 915 }
1018} 916}
1019 917
1020/* remove_ob(op): 918/* op->remove ():
1021 * This function removes the object op from the linked list of objects 919 * This function removes the object op from the linked list of objects
1022 * which it is currently tied to. When this function is done, the 920 * which it is currently tied to. When this function is done, the
1023 * object will have no environment. If the object previously had an 921 * object will have no environment. If the object previously had an
1024 * environment, the x and y coordinates will be updated to 922 * environment, the x and y coordinates will be updated to
1025 * the previous environment. 923 * the previous environment.
1029object::remove () 927object::remove ()
1030{ 928{
1031 object *tmp, *last = 0; 929 object *tmp, *last = 0;
1032 object *otmp; 930 object *otmp;
1033 931
1034 int check_walk_off;
1035
1036 if (QUERY_FLAG (this, FLAG_REMOVED)) 932 if (QUERY_FLAG (this, FLAG_REMOVED))
1037 return; 933 return;
1038 934
1039 SET_FLAG (this, FLAG_REMOVED); 935 SET_FLAG (this, FLAG_REMOVED);
936 INVOKE_OBJECT (REMOVE, this);
1040 937
1041 if (more) 938 if (more)
1042 more->remove (); 939 more->remove ();
1043 940
1044 /* 941 /*
1054 951
1055 /* NO_FIX_PLAYER is set when a great many changes are being 952 /* NO_FIX_PLAYER is set when a great many changes are being
1056 * made to players inventory. If set, avoiding the call 953 * made to players inventory. If set, avoiding the call
1057 * to save cpu time. 954 * to save cpu time.
1058 */ 955 */
1059 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 956 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1060 fix_player (otmp); 957 otmp->update_stats ();
1061 958
1062 if (above != NULL) 959 if (above != NULL)
1063 above->below = below; 960 above->below = below;
1064 else 961 else
1065 env->inv = below; 962 env->inv = below;
1084 981
1085 /* link the object above us */ 982 /* link the object above us */
1086 if (above) 983 if (above)
1087 above->below = below; 984 above->below = below;
1088 else 985 else
1089 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 986 map->at (x, y).top = below; /* we were top, set new top */
1090 987
1091 /* Relink the object below us, if there is one */ 988 /* Relink the object below us, if there is one */
1092 if (below) 989 if (below)
1093 below->above = above; 990 below->above = above;
1094 else 991 else
1106 dump = dump_object (GET_MAP_OB (map, x, y)); 1003 dump = dump_object (GET_MAP_OB (map, x, y));
1107 LOG (llevError, "%s\n", dump); 1004 LOG (llevError, "%s\n", dump);
1108 free (dump); 1005 free (dump);
1109 } 1006 }
1110 1007
1111 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1008 map->at (x, y).bot = above; /* goes on above it. */
1112 } 1009 }
1113 1010
1114 above = 0; 1011 above = 0;
1115 below = 0; 1012 below = 0;
1116 1013
1117 if (map->in_memory == MAP_SAVING) 1014 if (map->in_memory == MAP_SAVING)
1118 return; 1015 return;
1119 1016
1120 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1017 int check_walk_off = !flag [FLAG_NO_APPLY];
1121 1018
1122 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1019 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1123 { 1020 {
1124 /* No point updating the players look faces if he is the object 1021 /* No point updating the players look faces if he is the object
1125 * being removed. 1022 * being removed.
1126 */ 1023 */
1127 1024
1131 * removed (most likely destroyed), update the player view 1028 * removed (most likely destroyed), update the player view
1132 * appropriately. 1029 * appropriately.
1133 */ 1030 */
1134 if (tmp->container == this) 1031 if (tmp->container == this)
1135 { 1032 {
1136 CLEAR_FLAG (this, FLAG_APPLIED); 1033 flag [FLAG_APPLIED] = 0;
1137 tmp->container = 0; 1034 tmp->container = 0;
1138 } 1035 }
1139 1036
1140 tmp->contr->socket.update_look = 1; 1037 if (tmp->contr->ns)
1038 tmp->contr->ns->floorbox_update ();
1141 } 1039 }
1142 1040
1143 /* See if player moving off should effect something */ 1041 /* See if player moving off should effect something */
1144 if (check_walk_off 1042 if (check_walk_off
1145 && ((move_type & tmp->move_off) 1043 && ((move_type & tmp->move_off)
1159 last = tmp; 1057 last = tmp;
1160 } 1058 }
1161 1059
1162 /* last == NULL of there are no objects on this space */ 1060 /* last == NULL of there are no objects on this space */
1163 if (!last) 1061 if (!last)
1164 { 1062 map->at (x, y).flags_ = P_NEED_UPDATE;
1165 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1166 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1167 * those out anyways, and if there are any flags set right now, they won't
1168 * be correct anyways.
1169 */
1170 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1171 update_position (map, x, y);
1172 }
1173 else 1063 else
1174 update_object (last, UP_OBJ_REMOVE); 1064 update_object (last, UP_OBJ_REMOVE);
1175 1065
1176 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1066 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1177 update_all_los (map, x, y); 1067 update_all_los (map, x, y);
1178 } 1068 }
1179} 1069}
1180 1070
1181/* 1071/*
1190merge_ob (object *op, object *top) 1080merge_ob (object *op, object *top)
1191{ 1081{
1192 if (!op->nrof) 1082 if (!op->nrof)
1193 return 0; 1083 return 0;
1194 1084
1195 if (top == NULL) 1085 if (top)
1196 for (top = op; top != NULL && top->above != NULL; top = top->above); 1086 for (top = op; top && top->above; top = top->above)
1087 ;
1197 1088
1198 for (; top != NULL; top = top->below) 1089 for (; top; top = top->below)
1199 { 1090 {
1200 if (top == op) 1091 if (top == op)
1201 continue; 1092 continue;
1202 if (CAN_MERGE (op, top)) 1093
1094 if (object::can_merge (op, top))
1203 { 1095 {
1204 top->nrof += op->nrof; 1096 top->nrof += op->nrof;
1205 1097
1206/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1098/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1207 op->weight = 0; /* Don't want any adjustements now */ 1099 op->weight = 0; /* Don't want any adjustements now */
1208 remove_ob (op); 1100 op->destroy ();
1209 free_object (op);
1210 return top; 1101 return top;
1211 } 1102 }
1212 } 1103 }
1213 1104
1214 return 0; 1105 return 0;
1253 * Return value: 1144 * Return value:
1254 * new object if 'op' was merged with other object 1145 * new object if 'op' was merged with other object
1255 * NULL if 'op' was destroyed 1146 * NULL if 'op' was destroyed
1256 * just 'op' otherwise 1147 * just 'op' otherwise
1257 */ 1148 */
1258
1259object * 1149object *
1260insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1150insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1261{ 1151{
1262 object *tmp, *top, *floor = NULL; 1152 object *tmp, *top, *floor = NULL;
1263 sint16 x, y; 1153 sint16 x, y;
1297 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1187 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1298 free (dump); 1188 free (dump);
1299 return op; 1189 return op;
1300 } 1190 }
1301 1191
1302 if (op->more != NULL) 1192 if (op->more)
1303 { 1193 {
1304 /* The part may be on a different map. */ 1194 /* The part may be on a different map. */
1305 1195
1306 object *more = op->more; 1196 object *more = op->more;
1307 1197
1323 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1213 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1324 { 1214 {
1325 if (!op->head) 1215 if (!op->head)
1326 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1216 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1327 1217
1328 return NULL; 1218 return 0;
1329 } 1219 }
1330 } 1220 }
1331 1221
1332 CLEAR_FLAG (op, FLAG_REMOVED); 1222 CLEAR_FLAG (op, FLAG_REMOVED);
1333 1223
1341 1231
1342 /* this has to be done after we translate the coordinates. 1232 /* this has to be done after we translate the coordinates.
1343 */ 1233 */
1344 if (op->nrof && !(flag & INS_NO_MERGE)) 1234 if (op->nrof && !(flag & INS_NO_MERGE))
1345 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1235 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1346 if (CAN_MERGE (op, tmp)) 1236 if (object::can_merge (op, tmp))
1347 { 1237 {
1348 op->nrof += tmp->nrof; 1238 op->nrof += tmp->nrof;
1349 remove_ob (tmp); 1239 tmp->destroy ();
1350 free_object (tmp);
1351 } 1240 }
1352 1241
1353 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1242 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1354 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1243 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1355 1244
1368 op->below = originator->below; 1257 op->below = originator->below;
1369 1258
1370 if (op->below) 1259 if (op->below)
1371 op->below->above = op; 1260 op->below->above = op;
1372 else 1261 else
1373 SET_MAP_OB (op->map, op->x, op->y, op); 1262 op->ms ().bot = op;
1374 1263
1375 /* since *below* originator, no need to update top */ 1264 /* since *below* originator, no need to update top */
1376 originator->below = op; 1265 originator->below = op;
1377 } 1266 }
1378 else 1267 else
1424 * If INS_ON_TOP is used, don't do this processing 1313 * If INS_ON_TOP is used, don't do this processing
1425 * Need to find the object that in fact blocks view, otherwise 1314 * Need to find the object that in fact blocks view, otherwise
1426 * stacking is a bit odd. 1315 * stacking is a bit odd.
1427 */ 1316 */
1428 if (!(flag & INS_ON_TOP) && 1317 if (!(flag & INS_ON_TOP) &&
1429 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1318 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1430 { 1319 {
1431 for (last = top; last != floor; last = last->below) 1320 for (last = top; last != floor; last = last->below)
1432 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1321 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1433 break; 1322 break;
1434 /* Check to see if we found the object that blocks view, 1323 /* Check to see if we found the object that blocks view,
1457 1346
1458 if (op->above) 1347 if (op->above)
1459 op->above->below = op; 1348 op->above->below = op;
1460 1349
1461 op->below = NULL; 1350 op->below = NULL;
1462 SET_MAP_OB (op->map, op->x, op->y, op); 1351 op->ms ().bot = op;
1463 } 1352 }
1464 else 1353 else
1465 { /* get inserted into the stack above top */ 1354 { /* get inserted into the stack above top */
1466 op->above = top->above; 1355 op->above = top->above;
1467 1356
1471 op->below = top; 1360 op->below = top;
1472 top->above = op; 1361 top->above = op;
1473 } 1362 }
1474 1363
1475 if (op->above == NULL) 1364 if (op->above == NULL)
1476 SET_MAP_TOP (op->map, op->x, op->y, op); 1365 op->ms ().top = op;
1477 } /* else not INS_BELOW_ORIGINATOR */ 1366 } /* else not INS_BELOW_ORIGINATOR */
1478 1367
1479 if (op->type == PLAYER) 1368 if (op->type == PLAYER)
1480 op->contr->do_los = 1; 1369 op->contr->do_los = 1;
1481 1370
1482 /* If we have a floor, we know the player, if any, will be above 1371 /* If we have a floor, we know the player, if any, will be above
1483 * it, so save a few ticks and start from there. 1372 * it, so save a few ticks and start from there.
1484 */ 1373 */
1485 if (!(flag & INS_MAP_LOAD)) 1374 if (!(flag & INS_MAP_LOAD))
1486 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1375 if (object *pl = op->ms ().player ())
1487 if (tmp->type == PLAYER) 1376 if (pl->contr->ns)
1488 tmp->contr->socket.update_look = 1; 1377 pl->contr->ns->floorbox_update ();
1489 1378
1490 /* If this object glows, it may affect lighting conditions that are 1379 /* If this object glows, it may affect lighting conditions that are
1491 * visible to others on this map. But update_all_los is really 1380 * visible to others on this map. But update_all_los is really
1492 * an inefficient way to do this, as it means los for all players 1381 * an inefficient way to do this, as it means los for all players
1493 * on the map will get recalculated. The players could very well 1382 * on the map will get recalculated. The players could very well
1494 * be far away from this change and not affected in any way - 1383 * be far away from this change and not affected in any way -
1495 * this should get redone to only look for players within range, 1384 * this should get redone to only look for players within range,
1496 * or just updating the P_NEED_UPDATE for spaces within this area 1385 * or just updating the P_NEED_UPDATE for spaces within this area
1497 * of effect may be sufficient. 1386 * of effect may be sufficient.
1498 */ 1387 */
1499 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1388 if (op->map->darkness && (op->glow_radius != 0))
1500 update_all_los (op->map, op->x, op->y); 1389 update_all_los (op->map, op->x, op->y);
1501 1390
1502 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1391 /* updates flags (blocked, alive, no magic, etc) for this map space */
1503 update_object (op, UP_OBJ_INSERT); 1392 update_object (op, UP_OBJ_INSERT);
1504 1393
1394 INVOKE_OBJECT (INSERT, op);
1395
1505 /* Don't know if moving this to the end will break anything. However, 1396 /* Don't know if moving this to the end will break anything. However,
1506 * we want to have update_look set above before calling this. 1397 * we want to have floorbox_update called before calling this.
1507 * 1398 *
1508 * check_move_on() must be after this because code called from 1399 * check_move_on() must be after this because code called from
1509 * check_move_on() depends on correct map flags (so functions like 1400 * check_move_on() depends on correct map flags (so functions like
1510 * blocked() and wall() work properly), and these flags are updated by 1401 * blocked() and wall() work properly), and these flags are updated by
1511 * update_object(). 1402 * update_object().
1513 1404
1514 /* if this is not the head or flag has been passed, don't check walk on status */ 1405 /* if this is not the head or flag has been passed, don't check walk on status */
1515 if (!(flag & INS_NO_WALK_ON) && !op->head) 1406 if (!(flag & INS_NO_WALK_ON) && !op->head)
1516 { 1407 {
1517 if (check_move_on (op, originator)) 1408 if (check_move_on (op, originator))
1518 return NULL; 1409 return 0;
1519 1410
1520 /* If we are a multi part object, lets work our way through the check 1411 /* If we are a multi part object, lets work our way through the check
1521 * walk on's. 1412 * walk on's.
1522 */ 1413 */
1523 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1414 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1524 if (check_move_on (tmp, originator)) 1415 if (check_move_on (tmp, originator))
1525 return NULL; 1416 return 0;
1526 } 1417 }
1527 1418
1528 return op; 1419 return op;
1529} 1420}
1530 1421
1531/* this function inserts an object in the map, but if it 1422/* this function inserts an object in the map, but if it
1532 * finds an object of its own type, it'll remove that one first. 1423 * finds an object of its own type, it'll remove that one first.
1533 * op is the object to insert it under: supplies x and the map. 1424 * op is the object to insert it under: supplies x and the map.
1534 */ 1425 */
1535void 1426void
1536replace_insert_ob_in_map (const char *arch_string, object *op) 1427replace_insert_ob_in_map (const char *arch_string, object *op)
1537{ 1428{
1538 object * 1429 object *tmp, *tmp1;
1539 tmp;
1540 object *
1541 tmp1;
1542 1430
1543 /* first search for itself and remove any old instances */ 1431 /* first search for itself and remove any old instances */
1544 1432
1545 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1433 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1546 {
1547 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1434 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1548 { 1435 tmp->destroy ();
1549 remove_ob (tmp);
1550 free_object (tmp);
1551 }
1552 }
1553 1436
1554 tmp1 = arch_to_object (archetype::find (arch_string)); 1437 tmp1 = arch_to_object (archetype::find (arch_string));
1555 1438
1556 tmp1->x = op->x; 1439 tmp1->x = op->x;
1557 tmp1->y = op->y; 1440 tmp1->y = op->y;
1567 */ 1450 */
1568 1451
1569object * 1452object *
1570get_split_ob (object *orig_ob, uint32 nr) 1453get_split_ob (object *orig_ob, uint32 nr)
1571{ 1454{
1572 object * 1455 object *newob;
1573 newob;
1574 int
1575 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1456 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1576 1457
1577 if (orig_ob->nrof < nr) 1458 if (orig_ob->nrof < nr)
1578 { 1459 {
1579 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1460 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1580 return NULL; 1461 return NULL;
1581 } 1462 }
1582 1463
1583 newob = object_create_clone (orig_ob); 1464 newob = object_create_clone (orig_ob);
1584 1465
1585 if ((orig_ob->nrof -= nr) < 1) 1466 if ((orig_ob->nrof -= nr) < 1)
1586 { 1467 orig_ob->destroy (1);
1587 if (!is_removed)
1588 remove_ob (orig_ob);
1589 free_object2 (orig_ob, 1);
1590 }
1591 else if (!is_removed) 1468 else if (!is_removed)
1592 { 1469 {
1593 if (orig_ob->env != NULL) 1470 if (orig_ob->env != NULL)
1594 sub_weight (orig_ob->env, orig_ob->weight * nr); 1471 sub_weight (orig_ob->env, orig_ob->weight * nr);
1595 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1472 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1615 1492
1616object * 1493object *
1617decrease_ob_nr (object *op, uint32 i) 1494decrease_ob_nr (object *op, uint32 i)
1618{ 1495{
1619 object *tmp; 1496 object *tmp;
1620 player *pl;
1621 1497
1622 if (i == 0) /* objects with op->nrof require this check */ 1498 if (i == 0) /* objects with op->nrof require this check */
1623 return op; 1499 return op;
1624 1500
1625 if (i > op->nrof) 1501 if (i > op->nrof)
1626 i = op->nrof; 1502 i = op->nrof;
1627 1503
1628 if (QUERY_FLAG (op, FLAG_REMOVED)) 1504 if (QUERY_FLAG (op, FLAG_REMOVED))
1629 op->nrof -= i; 1505 op->nrof -= i;
1630 else if (op->env != NULL) 1506 else if (op->env)
1631 { 1507 {
1632 /* is this object in the players inventory, or sub container 1508 /* is this object in the players inventory, or sub container
1633 * therein? 1509 * therein?
1634 */ 1510 */
1635 tmp = is_player_inv (op->env); 1511 tmp = op->in_player ();
1636 /* nope. Is this a container the player has opened? 1512 /* nope. Is this a container the player has opened?
1637 * If so, set tmp to that player. 1513 * If so, set tmp to that player.
1638 * IMO, searching through all the players will mostly 1514 * IMO, searching through all the players will mostly
1639 * likely be quicker than following op->env to the map, 1515 * likely be quicker than following op->env to the map,
1640 * and then searching the map for a player. 1516 * and then searching the map for a player.
1641 */ 1517 */
1642 if (!tmp) 1518 if (!tmp)
1643 { 1519 for_all_players (pl)
1644 for (pl = first_player; pl; pl = pl->next)
1645 if (pl->ob->container == op->env) 1520 if (pl->ob->container == op->env)
1521 {
1522 tmp = pl->ob;
1646 break; 1523 break;
1647 if (pl)
1648 tmp = pl->ob;
1649 else
1650 tmp = NULL;
1651 } 1524 }
1652 1525
1653 if (i < op->nrof) 1526 if (i < op->nrof)
1654 { 1527 {
1655 sub_weight (op->env, op->weight * i); 1528 sub_weight (op->env, op->weight * i);
1656 op->nrof -= i; 1529 op->nrof -= i;
1657 if (tmp) 1530 if (tmp)
1658 {
1659 esrv_send_item (tmp, op); 1531 esrv_send_item (tmp, op);
1660 }
1661 } 1532 }
1662 else 1533 else
1663 { 1534 {
1664 remove_ob (op); 1535 op->remove ();
1665 op->nrof = 0; 1536 op->nrof = 0;
1666 if (tmp) 1537 if (tmp)
1667 {
1668 esrv_del_item (tmp->contr, op->count); 1538 esrv_del_item (tmp->contr, op->count);
1669 }
1670 } 1539 }
1671 } 1540 }
1672 else 1541 else
1673 { 1542 {
1674 object *above = op->above; 1543 object *above = op->above;
1675 1544
1676 if (i < op->nrof) 1545 if (i < op->nrof)
1677 op->nrof -= i; 1546 op->nrof -= i;
1678 else 1547 else
1679 { 1548 {
1680 remove_ob (op); 1549 op->remove ();
1681 op->nrof = 0; 1550 op->nrof = 0;
1682 } 1551 }
1683 1552
1684 /* Since we just removed op, op->above is null */ 1553 /* Since we just removed op, op->above is null */
1685 for (tmp = above; tmp != NULL; tmp = tmp->above) 1554 for (tmp = above; tmp; tmp = tmp->above)
1686 if (tmp->type == PLAYER) 1555 if (tmp->type == PLAYER)
1687 { 1556 {
1688 if (op->nrof) 1557 if (op->nrof)
1689 esrv_send_item (tmp, op); 1558 esrv_send_item (tmp, op);
1690 else 1559 else
1694 1563
1695 if (op->nrof) 1564 if (op->nrof)
1696 return op; 1565 return op;
1697 else 1566 else
1698 { 1567 {
1699 free_object (op); 1568 op->destroy ();
1700 return NULL; 1569 return 0;
1701 } 1570 }
1702} 1571}
1703 1572
1704/* 1573/*
1705 * add_weight(object, weight) adds the specified weight to an object, 1574 * add_weight(object, weight) adds the specified weight to an object,
1765 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1634 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1766 CLEAR_FLAG (op, FLAG_REMOVED); 1635 CLEAR_FLAG (op, FLAG_REMOVED);
1767 if (op->nrof) 1636 if (op->nrof)
1768 { 1637 {
1769 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1638 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1770 if (CAN_MERGE (tmp, op)) 1639 if (object::can_merge (tmp, op))
1771 { 1640 {
1772 /* return the original object and remove inserted object 1641 /* return the original object and remove inserted object
1773 (client needs the original object) */ 1642 (client needs the original object) */
1774 tmp->nrof += op->nrof; 1643 tmp->nrof += op->nrof;
1775 /* Weight handling gets pretty funky. Since we are adding to 1644 /* Weight handling gets pretty funky. Since we are adding to
1793 add_weight (this, op->weight * op->nrof); 1662 add_weight (this, op->weight * op->nrof);
1794 } 1663 }
1795 else 1664 else
1796 add_weight (this, (op->weight + op->carrying)); 1665 add_weight (this, (op->weight + op->carrying));
1797 1666
1798 otmp = is_player_inv (this); 1667 otmp = this->in_player ();
1799 if (otmp && otmp->contr) 1668 if (otmp && otmp->contr)
1800 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1669 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1801 fix_player (otmp); 1670 otmp->update_stats ();
1802 1671
1803 op->map = NULL; 1672 op->map = 0;
1804 op->env = this; 1673 op->env = this;
1805 op->above = NULL; 1674 op->above = 0;
1806 op->below = NULL; 1675 op->below = 0;
1807 op->x = 0, op->y = 0; 1676 op->x = 0, op->y = 0;
1808 1677
1809 /* reset the light list and los of the players on the map */ 1678 /* reset the light list and los of the players on the map */
1810 if ((op->glow_radius != 0) && map) 1679 if ((op->glow_radius != 0) && map)
1811 { 1680 {
1812#ifdef DEBUG_LIGHTS 1681#ifdef DEBUG_LIGHTS
1813 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1682 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1814#endif /* DEBUG_LIGHTS */ 1683#endif /* DEBUG_LIGHTS */
1815 if (MAP_DARKNESS (map)) 1684 if (map->darkness)
1816 update_all_los (map, x, y); 1685 update_all_los (map, x, y);
1817 } 1686 }
1818 1687
1819 /* Client has no idea of ordering so lets not bother ordering it here. 1688 /* Client has no idea of ordering so lets not bother ordering it here.
1820 * It sure simplifies this function... 1689 * It sure simplifies this function...
1825 { 1694 {
1826 op->below = inv; 1695 op->below = inv;
1827 op->below->above = op; 1696 op->below->above = op;
1828 inv = op; 1697 inv = op;
1829 } 1698 }
1699
1700 INVOKE_OBJECT (INSERT, this);
1830 1701
1831 return op; 1702 return op;
1832} 1703}
1833 1704
1834/* 1705/*
1886 1757
1887 /* The objects have to be checked from top to bottom. 1758 /* The objects have to be checked from top to bottom.
1888 * Hence, we first go to the top: 1759 * Hence, we first go to the top:
1889 */ 1760 */
1890 1761
1891 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1762 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1892 { 1763 {
1893 /* Trim the search when we find the first other spell effect 1764 /* Trim the search when we find the first other spell effect
1894 * this helps performance so that if a space has 50 spell objects, 1765 * this helps performance so that if a space has 50 spell objects,
1895 * we don't need to check all of them. 1766 * we don't need to check all of them.
1896 */ 1767 */
1951/* 1822/*
1952 * present_arch(arch, map, x, y) searches for any objects with 1823 * present_arch(arch, map, x, y) searches for any objects with
1953 * a matching archetype at the given map and coordinates. 1824 * a matching archetype at the given map and coordinates.
1954 * The first matching object is returned, or NULL if none. 1825 * The first matching object is returned, or NULL if none.
1955 */ 1826 */
1956
1957object * 1827object *
1958present_arch (const archetype *at, maptile *m, int x, int y) 1828present_arch (const archetype *at, maptile *m, int x, int y)
1959{ 1829{
1960 object *
1961 tmp;
1962
1963 if (m == NULL || out_of_map (m, x, y)) 1830 if (m == NULL || out_of_map (m, x, y))
1964 { 1831 {
1965 LOG (llevError, "Present_arch called outside map.\n"); 1832 LOG (llevError, "Present_arch called outside map.\n");
1966 return NULL; 1833 return NULL;
1967 } 1834 }
1835
1968 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1836 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1969 if (tmp->arch == at) 1837 if (tmp->arch == at)
1970 return tmp; 1838 return tmp;
1839
1971 return NULL; 1840 return NULL;
1972} 1841}
1973 1842
1974/* 1843/*
1975 * present(type, map, x, y) searches for any objects with 1844 * present(type, map, x, y) searches for any objects with
1976 * a matching type variable at the given map and coordinates. 1845 * a matching type variable at the given map and coordinates.
1977 * The first matching object is returned, or NULL if none. 1846 * The first matching object is returned, or NULL if none.
1978 */ 1847 */
1979
1980object * 1848object *
1981present (unsigned char type, maptile *m, int x, int y) 1849present (unsigned char type, maptile *m, int x, int y)
1982{ 1850{
1983 object *
1984 tmp;
1985
1986 if (out_of_map (m, x, y)) 1851 if (out_of_map (m, x, y))
1987 { 1852 {
1988 LOG (llevError, "Present called outside map.\n"); 1853 LOG (llevError, "Present called outside map.\n");
1989 return NULL; 1854 return NULL;
1990 } 1855 }
1856
1991 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1857 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1992 if (tmp->type == type) 1858 if (tmp->type == type)
1993 return tmp; 1859 return tmp;
1860
1994 return NULL; 1861 return NULL;
1995} 1862}
1996 1863
1997/* 1864/*
1998 * present_in_ob(type, object) searches for any objects with 1865 * present_in_ob(type, object) searches for any objects with
1999 * a matching type variable in the inventory of the given object. 1866 * a matching type variable in the inventory of the given object.
2000 * The first matching object is returned, or NULL if none. 1867 * The first matching object is returned, or NULL if none.
2001 */ 1868 */
2002
2003object * 1869object *
2004present_in_ob (unsigned char type, const object *op) 1870present_in_ob (unsigned char type, const object *op)
2005{ 1871{
2006 object *
2007 tmp;
2008
2009 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1872 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2010 if (tmp->type == type) 1873 if (tmp->type == type)
2011 return tmp; 1874 return tmp;
1875
2012 return NULL; 1876 return NULL;
2013} 1877}
2014 1878
2015/* 1879/*
2016 * present_in_ob (type, str, object) searches for any objects with 1880 * present_in_ob (type, str, object) searches for any objects with
2024 * str is the string to match against. Note that we match against 1888 * str is the string to match against. Note that we match against
2025 * the object name, not the archetype name. this is so that the 1889 * the object name, not the archetype name. this is so that the
2026 * spell code can use one object type (force), but change it's name 1890 * spell code can use one object type (force), but change it's name
2027 * to be unique. 1891 * to be unique.
2028 */ 1892 */
2029
2030object * 1893object *
2031present_in_ob_by_name (int type, const char *str, const object *op) 1894present_in_ob_by_name (int type, const char *str, const object *op)
2032{ 1895{
2033 object *
2034 tmp;
2035
2036 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1896 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2037 {
2038 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1897 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2039 return tmp; 1898 return tmp;
2040 } 1899
2041 return NULL; 1900 return 0;
2042} 1901}
2043 1902
2044/* 1903/*
2045 * present_arch_in_ob(archetype, object) searches for any objects with 1904 * present_arch_in_ob(archetype, object) searches for any objects with
2046 * a matching archetype in the inventory of the given object. 1905 * a matching archetype in the inventory of the given object.
2047 * The first matching object is returned, or NULL if none. 1906 * The first matching object is returned, or NULL if none.
2048 */ 1907 */
2049
2050object * 1908object *
2051present_arch_in_ob (const archetype *at, const object *op) 1909present_arch_in_ob (const archetype *at, const object *op)
2052{ 1910{
2053 object *
2054 tmp;
2055
2056 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1911 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2057 if (tmp->arch == at) 1912 if (tmp->arch == at)
2058 return tmp; 1913 return tmp;
1914
2059 return NULL; 1915 return NULL;
2060} 1916}
2061 1917
2062/* 1918/*
2063 * activate recursively a flag on an object inventory 1919 * activate recursively a flag on an object inventory
2064 */ 1920 */
2065void 1921void
2066flag_inv (object *op, int flag) 1922flag_inv (object *op, int flag)
2067{ 1923{
2068 object *
2069 tmp;
2070
2071 if (op->inv) 1924 if (op->inv)
2072 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1925 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2073 { 1926 {
2074 SET_FLAG (tmp, flag); 1927 SET_FLAG (tmp, flag);
2075 flag_inv (tmp, flag); 1928 flag_inv (tmp, flag);
2076 } 1929 }
2077} /* 1930}
1931
1932/*
2078 * desactivate recursively a flag on an object inventory 1933 * deactivate recursively a flag on an object inventory
2079 */ 1934 */
2080void 1935void
2081unflag_inv (object *op, int flag) 1936unflag_inv (object *op, int flag)
2082{ 1937{
2083 object *
2084 tmp;
2085
2086 if (op->inv) 1938 if (op->inv)
2087 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1939 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2088 { 1940 {
2089 CLEAR_FLAG (tmp, flag); 1941 CLEAR_FLAG (tmp, flag);
2090 unflag_inv (tmp, flag); 1942 unflag_inv (tmp, flag);
2091 } 1943 }
2092} 1944}
2095 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1947 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2096 * all it's inventory (recursively). 1948 * all it's inventory (recursively).
2097 * If checksums are used, a player will get set_cheat called for 1949 * If checksums are used, a player will get set_cheat called for
2098 * him/her-self and all object carried by a call to this function. 1950 * him/her-self and all object carried by a call to this function.
2099 */ 1951 */
2100
2101void 1952void
2102set_cheat (object *op) 1953set_cheat (object *op)
2103{ 1954{
2104 SET_FLAG (op, FLAG_WAS_WIZ); 1955 SET_FLAG (op, FLAG_WAS_WIZ);
2105 flag_inv (op, FLAG_WAS_WIZ); 1956 flag_inv (op, FLAG_WAS_WIZ);
2124 * because arch_blocked (now ob_blocked) needs to know the movement type 1975 * because arch_blocked (now ob_blocked) needs to know the movement type
2125 * to know if the space in question will block the object. We can't use 1976 * to know if the space in question will block the object. We can't use
2126 * the archetype because that isn't correct if the monster has been 1977 * the archetype because that isn't correct if the monster has been
2127 * customized, changed states, etc. 1978 * customized, changed states, etc.
2128 */ 1979 */
2129
2130int 1980int
2131find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1981find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2132{ 1982{
2133 int
2134 i,
2135 index = 0, flag; 1983 int index = 0, flag;
2136 static int
2137 altern[SIZEOFFREE]; 1984 int altern[SIZEOFFREE];
2138 1985
2139 for (i = start; i < stop; i++) 1986 for (int i = start; i < stop; i++)
2140 { 1987 {
2141 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1988 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2142 if (!flag) 1989 if (!flag)
2143 altern[index++] = i; 1990 altern [index++] = i;
2144 1991
2145 /* Basically, if we find a wall on a space, we cut down the search size. 1992 /* Basically, if we find a wall on a space, we cut down the search size.
2146 * In this way, we won't return spaces that are on another side of a wall. 1993 * In this way, we won't return spaces that are on another side of a wall.
2147 * This mostly work, but it cuts down the search size in all directions - 1994 * This mostly work, but it cuts down the search size in all directions -
2148 * if the space being examined only has a wall to the north and empty 1995 * if the space being examined only has a wall to the north and empty
2149 * spaces in all the other directions, this will reduce the search space 1996 * spaces in all the other directions, this will reduce the search space
2150 * to only the spaces immediately surrounding the target area, and 1997 * to only the spaces immediately surrounding the target area, and
2151 * won't look 2 spaces south of the target space. 1998 * won't look 2 spaces south of the target space.
2152 */ 1999 */
2153 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2000 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2154 stop = maxfree[i]; 2001 stop = maxfree[i];
2155 } 2002 }
2003
2156 if (!index) 2004 if (!index)
2157 return -1; 2005 return -1;
2006
2158 return altern[RANDOM () % index]; 2007 return altern[RANDOM () % index];
2159} 2008}
2160 2009
2161/* 2010/*
2162 * find_first_free_spot(archetype, maptile, x, y) works like 2011 * find_first_free_spot(archetype, maptile, x, y) works like
2163 * find_free_spot(), but it will search max number of squares. 2012 * find_free_spot(), but it will search max number of squares.
2164 * But it will return the first available spot, not a random choice. 2013 * But it will return the first available spot, not a random choice.
2165 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2014 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2166 */ 2015 */
2167
2168int 2016int
2169find_first_free_spot (const object *ob, maptile *m, int x, int y) 2017find_first_free_spot (const object *ob, maptile *m, int x, int y)
2170{ 2018{
2171 int
2172 i;
2173
2174 for (i = 0; i < SIZEOFFREE; i++) 2019 for (int i = 0; i < SIZEOFFREE; i++)
2175 {
2176 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2020 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2177 return i; 2021 return i;
2178 } 2022
2179 return -1; 2023 return -1;
2180} 2024}
2181 2025
2182/* 2026/*
2183 * The function permute(arr, begin, end) randomly reorders the array 2027 * The function permute(arr, begin, end) randomly reorders the array
2184 * arr[begin..end-1]. 2028 * arr[begin..end-1].
2029 * now uses a fisher-yates shuffle, old permute was broken
2185 */ 2030 */
2186static void 2031static void
2187permute (int *arr, int begin, int end) 2032permute (int *arr, int begin, int end)
2188{ 2033{
2189 int 2034 arr += begin;
2190 i,
2191 j,
2192 tmp,
2193 len;
2194
2195 len = end - begin; 2035 end -= begin;
2196 for (i = begin; i < end; i++)
2197 {
2198 j = begin + RANDOM () % len;
2199 2036
2200 tmp = arr[i]; 2037 while (--end)
2201 arr[i] = arr[j]; 2038 swap (arr [end], arr [RANDOM () % (end + 1)]);
2202 arr[j] = tmp;
2203 }
2204} 2039}
2205 2040
2206/* new function to make monster searching more efficient, and effective! 2041/* new function to make monster searching more efficient, and effective!
2207 * This basically returns a randomized array (in the passed pointer) of 2042 * This basically returns a randomized array (in the passed pointer) of
2208 * the spaces to find monsters. In this way, it won't always look for 2043 * the spaces to find monsters. In this way, it won't always look for
2211 * the 3x3 area will be searched, just not in a predictable order. 2046 * the 3x3 area will be searched, just not in a predictable order.
2212 */ 2047 */
2213void 2048void
2214get_search_arr (int *search_arr) 2049get_search_arr (int *search_arr)
2215{ 2050{
2216 int 2051 int i;
2217 i;
2218 2052
2219 for (i = 0; i < SIZEOFFREE; i++) 2053 for (i = 0; i < SIZEOFFREE; i++)
2220 {
2221 search_arr[i] = i; 2054 search_arr[i] = i;
2222 }
2223 2055
2224 permute (search_arr, 1, SIZEOFFREE1 + 1); 2056 permute (search_arr, 1, SIZEOFFREE1 + 1);
2225 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2057 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2226 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2058 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2227} 2059}
2236 * Perhaps incorrectly, but I'm making the assumption that exclude 2068 * Perhaps incorrectly, but I'm making the assumption that exclude
2237 * is actually want is going to try and move there. We need this info 2069 * is actually want is going to try and move there. We need this info
2238 * because we have to know what movement the thing looking to move 2070 * because we have to know what movement the thing looking to move
2239 * there is capable of. 2071 * there is capable of.
2240 */ 2072 */
2241
2242int 2073int
2243find_dir (maptile *m, int x, int y, object *exclude) 2074find_dir (maptile *m, int x, int y, object *exclude)
2244{ 2075{
2245 int
2246 i,
2247 max = SIZEOFFREE, mflags; 2076 int i, max = SIZEOFFREE, mflags;
2248 2077
2249 sint16 nx, ny; 2078 sint16 nx, ny;
2250 object * 2079 object *tmp;
2251 tmp;
2252 maptile * 2080 maptile *mp;
2253 mp;
2254 2081
2255 MoveType blocked, move_type; 2082 MoveType blocked, move_type;
2256 2083
2257 if (exclude && exclude->head) 2084 if (exclude && exclude->head)
2258 { 2085 {
2270 mp = m; 2097 mp = m;
2271 nx = x + freearr_x[i]; 2098 nx = x + freearr_x[i];
2272 ny = y + freearr_y[i]; 2099 ny = y + freearr_y[i];
2273 2100
2274 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2101 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2102
2275 if (mflags & P_OUT_OF_MAP) 2103 if (mflags & P_OUT_OF_MAP)
2276 {
2277 max = maxfree[i]; 2104 max = maxfree[i];
2278 }
2279 else 2105 else
2280 { 2106 {
2281 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2107 mapspace &ms = mp->at (nx, ny);
2108
2109 blocked = ms.move_block;
2282 2110
2283 if ((move_type & blocked) == move_type) 2111 if ((move_type & blocked) == move_type)
2284 {
2285 max = maxfree[i]; 2112 max = maxfree[i];
2286 }
2287 else if (mflags & P_IS_ALIVE) 2113 else if (mflags & P_IS_ALIVE)
2288 { 2114 {
2289 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2115 for (tmp = ms.bot; tmp; tmp = tmp->above)
2290 { 2116 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2291 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2117 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2292 {
2293 break; 2118 break;
2294 } 2119
2295 }
2296 if (tmp) 2120 if (tmp)
2297 {
2298 return freedir[i]; 2121 return freedir[i];
2299 }
2300 } 2122 }
2301 } 2123 }
2302 } 2124 }
2125
2303 return 0; 2126 return 0;
2304} 2127}
2305 2128
2306/* 2129/*
2307 * distance(object 1, object 2) will return the square of the 2130 * distance(object 1, object 2) will return the square of the
2308 * distance between the two given objects. 2131 * distance between the two given objects.
2309 */ 2132 */
2310
2311int 2133int
2312distance (const object *ob1, const object *ob2) 2134distance (const object *ob1, const object *ob2)
2313{ 2135{
2314 int
2315 i;
2316
2317 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2136 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2318 return i;
2319} 2137}
2320 2138
2321/* 2139/*
2322 * find_dir_2(delta-x,delta-y) will return a direction in which 2140 * find_dir_2(delta-x,delta-y) will return a direction in which
2323 * an object which has subtracted the x and y coordinates of another 2141 * an object which has subtracted the x and y coordinates of another
2324 * object, needs to travel toward it. 2142 * object, needs to travel toward it.
2325 */ 2143 */
2326
2327int 2144int
2328find_dir_2 (int x, int y) 2145find_dir_2 (int x, int y)
2329{ 2146{
2330 int 2147 int q;
2331 q;
2332 2148
2333 if (y) 2149 if (y)
2334 q = x * 100 / y; 2150 q = x * 100 / y;
2335 else if (x) 2151 else if (x)
2336 q = -300 * x; 2152 q = -300 * x;
2371int 2187int
2372absdir (int d) 2188absdir (int d)
2373{ 2189{
2374 while (d < 1) 2190 while (d < 1)
2375 d += 8; 2191 d += 8;
2192
2376 while (d > 8) 2193 while (d > 8)
2377 d -= 8; 2194 d -= 8;
2195
2378 return d; 2196 return d;
2379} 2197}
2380 2198
2381/* 2199/*
2382 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2200 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2384 */ 2202 */
2385 2203
2386int 2204int
2387dirdiff (int dir1, int dir2) 2205dirdiff (int dir1, int dir2)
2388{ 2206{
2389 int 2207 int d;
2390 d;
2391 2208
2392 d = abs (dir1 - dir2); 2209 d = abs (dir1 - dir2);
2393 if (d > 4) 2210 if (d > 4)
2394 d = 8 - d; 2211 d = 8 - d;
2212
2395 return d; 2213 return d;
2396} 2214}
2397 2215
2398/* peterm: 2216/* peterm:
2399 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2217 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2402 * This basically means that if direction is 15, then it could either go 2220 * This basically means that if direction is 15, then it could either go
2403 * direction 4, 14, or 16 to get back to where we are. 2221 * direction 4, 14, or 16 to get back to where we are.
2404 * Moved from spell_util.c to object.c with the other related direction 2222 * Moved from spell_util.c to object.c with the other related direction
2405 * functions. 2223 * functions.
2406 */ 2224 */
2407
2408int
2409 reduction_dir[SIZEOFFREE][3] = { 2225int reduction_dir[SIZEOFFREE][3] = {
2410 {0, 0, 0}, /* 0 */ 2226 {0, 0, 0}, /* 0 */
2411 {0, 0, 0}, /* 1 */ 2227 {0, 0, 0}, /* 1 */
2412 {0, 0, 0}, /* 2 */ 2228 {0, 0, 0}, /* 2 */
2413 {0, 0, 0}, /* 3 */ 2229 {0, 0, 0}, /* 3 */
2414 {0, 0, 0}, /* 4 */ 2230 {0, 0, 0}, /* 4 */
2462 * find a path to that monster that we found. If not, 2278 * find a path to that monster that we found. If not,
2463 * we don't bother going toward it. Returns 1 if we 2279 * we don't bother going toward it. Returns 1 if we
2464 * can see a direct way to get it 2280 * can see a direct way to get it
2465 * Modified to be map tile aware -.MSW 2281 * Modified to be map tile aware -.MSW
2466 */ 2282 */
2467
2468
2469int 2283int
2470can_see_monsterP (maptile *m, int x, int y, int dir) 2284can_see_monsterP (maptile *m, int x, int y, int dir)
2471{ 2285{
2472 sint16 dx, dy; 2286 sint16 dx, dy;
2473 int
2474 mflags; 2287 int mflags;
2475 2288
2476 if (dir < 0) 2289 if (dir < 0)
2477 return 0; /* exit condition: invalid direction */ 2290 return 0; /* exit condition: invalid direction */
2478 2291
2479 dx = x + freearr_x[dir]; 2292 dx = x + freearr_x[dir];
2492 return 0; 2305 return 0;
2493 2306
2494 /* yes, can see. */ 2307 /* yes, can see. */
2495 if (dir < 9) 2308 if (dir < 9)
2496 return 1; 2309 return 1;
2310
2497 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2311 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2498 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2312 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2313 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2499} 2314}
2500
2501
2502 2315
2503/* 2316/*
2504 * can_pick(picker, item): finds out if an object is possible to be 2317 * can_pick(picker, item): finds out if an object is possible to be
2505 * picked up by the picker. Returnes 1 if it can be 2318 * picked up by the picker. Returnes 1 if it can be
2506 * picked up, otherwise 0. 2319 * picked up, otherwise 0.
2517 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2330 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2518 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2331 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2519 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2332 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2520} 2333}
2521 2334
2522
2523/* 2335/*
2524 * create clone from object to another 2336 * create clone from object to another
2525 */ 2337 */
2526object * 2338object *
2527object_create_clone (object *asrc) 2339object_create_clone (object *asrc)
2528{ 2340{
2529 object *
2530 dst = NULL, *tmp, *src, *part, *prev, *item; 2341 object *dst = 0, *tmp, *src, *part, *prev, *item;
2531 2342
2532 if (!asrc) 2343 if (!asrc)
2533 return NULL; 2344 return 0;
2345
2534 src = asrc; 2346 src = asrc;
2535 if (src->head) 2347 if (src->head)
2536 src = src->head; 2348 src = src->head;
2537 2349
2538 prev = NULL; 2350 prev = 0;
2539 for (part = src; part; part = part->more) 2351 for (part = src; part; part = part->more)
2540 { 2352 {
2541 tmp = get_object (); 2353 tmp = part->clone ();
2542 copy_object (part, tmp);
2543 tmp->x -= src->x; 2354 tmp->x -= src->x;
2544 tmp->y -= src->y; 2355 tmp->y -= src->y;
2356
2545 if (!part->head) 2357 if (!part->head)
2546 { 2358 {
2547 dst = tmp; 2359 dst = tmp;
2548 tmp->head = NULL; 2360 tmp->head = 0;
2549 } 2361 }
2550 else 2362 else
2551 {
2552 tmp->head = dst; 2363 tmp->head = dst;
2553 } 2364
2554 tmp->more = NULL; 2365 tmp->more = 0;
2366
2555 if (prev) 2367 if (prev)
2556 prev->more = tmp; 2368 prev->more = tmp;
2369
2557 prev = tmp; 2370 prev = tmp;
2558 } 2371 }
2559 2372
2560 for (item = src->inv; item; item = item->below) 2373 for (item = src->inv; item; item = item->below)
2561 insert_ob_in_ob (object_create_clone (item), dst); 2374 insert_ob_in_ob (object_create_clone (item), dst);
2567/* Basically, we save the content of the string to a temp file, then call */ 2380/* Basically, we save the content of the string to a temp file, then call */
2568/* load_object on it. I admit it is a highly inefficient way to make things, */ 2381/* load_object on it. I admit it is a highly inefficient way to make things, */
2569/* but it was simple to make and allows reusing the load_object function. */ 2382/* but it was simple to make and allows reusing the load_object function. */
2570/* Remember not to use load_object_str in a time-critical situation. */ 2383/* Remember not to use load_object_str in a time-critical situation. */
2571/* Also remember that multiparts objects are not supported for now. */ 2384/* Also remember that multiparts objects are not supported for now. */
2572
2573object * 2385object *
2574load_object_str (const char *obstr) 2386load_object_str (const char *obstr)
2575{ 2387{
2576 object *op; 2388 object *op;
2577 char filename[MAX_BUF]; 2389 char filename[MAX_BUF];
2587 } 2399 }
2588 2400
2589 fprintf (tempfile, obstr); 2401 fprintf (tempfile, obstr);
2590 fclose (tempfile); 2402 fclose (tempfile);
2591 2403
2592 op = get_object (); 2404 op = object::create ();
2593 2405
2594 object_thawer thawer (filename); 2406 object_thawer thawer (filename);
2595 2407
2596 if (thawer) 2408 if (thawer)
2597 load_object (thawer, op, 0); 2409 load_object (thawer, op, 0);
2607 * returns NULL if no match. 2419 * returns NULL if no match.
2608 */ 2420 */
2609object * 2421object *
2610find_obj_by_type_subtype (const object *who, int type, int subtype) 2422find_obj_by_type_subtype (const object *who, int type, int subtype)
2611{ 2423{
2612 object *tmp;
2613
2614 for (tmp = who->inv; tmp; tmp = tmp->below) 2424 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2615 if (tmp->type == type && tmp->subtype == subtype) 2425 if (tmp->type == type && tmp->subtype == subtype)
2616 return tmp; 2426 return tmp;
2617 2427
2618 return NULL; 2428 return 0;
2619} 2429}
2620 2430
2621/* If ob has a field named key, return the link from the list, 2431/* If ob has a field named key, return the link from the list,
2622 * otherwise return NULL. 2432 * otherwise return NULL.
2623 * 2433 *
2625 * do the desired thing. 2435 * do the desired thing.
2626 */ 2436 */
2627key_value * 2437key_value *
2628get_ob_key_link (const object *ob, const char *key) 2438get_ob_key_link (const object *ob, const char *key)
2629{ 2439{
2630 key_value *link;
2631
2632 for (link = ob->key_values; link != NULL; link = link->next) 2440 for (key_value *link = ob->key_values; link; link = link->next)
2633 if (link->key == key) 2441 if (link->key == key)
2634 return link; 2442 return link;
2635 2443
2636 return NULL; 2444 return 0;
2637} 2445}
2638 2446
2639/* 2447/*
2640 * Returns the value of op has an extra_field for key, or NULL. 2448 * Returns the value of op has an extra_field for key, or NULL.
2641 * 2449 *
2681 * Returns TRUE on success. 2489 * Returns TRUE on success.
2682 */ 2490 */
2683int 2491int
2684set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2492set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2685{ 2493{
2686 key_value *
2687 field = NULL, *last = NULL; 2494 key_value *field = NULL, *last = NULL;
2688 2495
2689 for (field = op->key_values; field != NULL; field = field->next) 2496 for (field = op->key_values; field != NULL; field = field->next)
2690 { 2497 {
2691 if (field->key != canonical_key) 2498 if (field->key != canonical_key)
2692 { 2499 {
2720 /* IF we get here, key doesn't exist */ 2527 /* IF we get here, key doesn't exist */
2721 2528
2722 /* No field, we'll have to add it. */ 2529 /* No field, we'll have to add it. */
2723 2530
2724 if (!add_key) 2531 if (!add_key)
2725 {
2726 return FALSE; 2532 return FALSE;
2727 } 2533
2728 /* There isn't any good reason to store a null 2534 /* There isn't any good reason to store a null
2729 * value in the key/value list. If the archetype has 2535 * value in the key/value list. If the archetype has
2730 * this key, then we should also have it, so shouldn't 2536 * this key, then we should also have it, so shouldn't
2731 * be here. If user wants to store empty strings, 2537 * be here. If user wants to store empty strings,
2732 * should pass in "" 2538 * should pass in ""

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines