[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.86 by root, Tue Dec 26 08:17:58 2006 UTC vs.
Revision 1.91 by elmex, Tue Dec 26 10:51:52 2006 UTC

               tail = new_link;
             }
         }
     }
-  update_ob_speed (dst);
+  dst->set_speed (dst->speed);
 }
 object *
 object::clone ()
 {
  * Updates the speed of an object.  If the speed changes from 0 to another
  * value, or vice versa, then add/remove the object from the active list.
  * This function needs to be called whenever the speed of an object changes.
  */
 void
-update_ob_speed (object *op)
+object::set_speed (float speed)
 {
   extern int arch_init;
   /* No reason putting the archetypes objects on the speed list,
    * since they never really need to be updated.
    */
-  if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
+  if (flag [FLAG_FREED] && speed)
     {
-      LOG (llevError, "Object %s is freed but has speed.\n", &op->name);
+      LOG (llevError, "Object %s is freed but has speed.\n", &name);
-      op->speed = 0;
+      speed = 0;
     }
+  this->speed = speed;
   if (arch_init)
     return;
-  if (FABS (op->speed) > MIN_ACTIVE_SPEED)
+  if (FABS (speed) > MIN_ACTIVE_SPEED)
     {
       /* If already on active list, don't do anything */
-      if (op->active_next || op->active_prev || op == active_objects)
+      if (active_next || active_prev || this == active_objects)
         return;
       /* process_events() expects us to insert the object at the beginning
        * of the list. */
-      op->active_next = active_objects;
+      active_next = active_objects;
-      if (op->active_next != NULL)
+      if (active_next)
-        op->active_next->active_prev = op;
+        active_next->active_prev = this;
-      active_objects = op;
+      active_objects = this;
     }
   else
     {
       /* If not on the active list, nothing needs to be done */
-      if (!op->active_next && !op->active_prev && op != active_objects)
+      if (!active_next && !active_prev && this != active_objects)
         return;
-      if (op->active_prev == NULL)
+      if (!active_prev)
         {
-          active_objects = op->active_next;
+          active_objects = active_next;
-          if (op->active_next != NULL)
+          if (active_next)
-            op->active_next->active_prev = NULL;
+            active_next->active_prev = 0;
         }
       else
         {
-          op->active_prev->active_next = op->active_next;
+          active_prev->active_next = active_next;
-          if (op->active_next)
+          if (active_next)
-            op->active_next->active_prev = op->active_prev;
+            active_next->active_prev = active_prev;
         }
-      op->active_next = NULL;
+      active_next = 0;
-      op->active_prev = NULL;
+      active_prev = 0;
     }
 }
 /* This function removes object 'op' from the list of active
  * objects.
   prev = 0;
   next = 0;
 }
-object *object::create ()
-{
-  object *op = new object;
-  op->link ();
-  return op;
-}
-/*
- * free_object() frees everything allocated by an object, removes
- * it from the list of used objects, and puts it on the list of
- * free objects.  The IS_FREED() flag is set in the object.
- * The object must have been removed by remove_ob() first for
- * this function to succeed.
- *
- * If destroy_inventory is set, free inventory as well. Else drop items in
- * inventory to the ground.
- */
-void
-object::do_destroy ()
-{
-  attachable::do_destroy ();
-  if (flag [FLAG_IS_LINKED])
-    remove_button_link (this);
-  if (flag [FLAG_FRIENDLY])
-    remove_friendly_object (this);
-  if (!flag [FLAG_REMOVED])
-    remove ();
-  if (flag [FLAG_FREED])
-    return;
-  flag [FLAG_FREED] = 1;
-  // hack to ensure that freed objects still have a valid map
-  {
-    static maptile *freed_map; // freed objects are moved here to avoid crashes
-    if (!freed_map)
-      {
-        freed_map = new maptile;
-        freed_map->name   = "/internal/freed_objects_map";
-        freed_map->width  = 3;
-        freed_map->height = 3;
-        freed_map->allocate ();
-      }
-    map = freed_map;
-    x = 1;
-    y = 1;
-  }
-  more = 0;
-  head = 0;
-  inv  = 0;
-  // clear those pointers that likely might have circular references to us
-  owner       = 0;
-  enemy       = 0;
-  attacked_by = 0;
-  // only relevant for players(?), but make sure of it anyways
-  contr       = 0;
-  /* Remove object from the active list */
-  speed = 0;
-  update_ob_speed (this);
-  unlink ();
-}
 /*
  * Remove and free all objects in the inventory of the given object.
  * object.c ?
  */
 void
 object::destroy_inv (bool drop_to_ground)
 {
-  if (!inv)
-    return;
   /* Only if the space blocks everything do we not process -
    * if some form of movement is allowed, let objects
    * drop on that space.
    */
   if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
     {
       while (inv)
-        {
-          inv->destroy_inv (drop_to_ground);
-          inv->destroy ();
+        inv->destroy ();
-        }
     }
   else
     {                       /* Put objects in inventory onto this space */
       while (inv)
         {
             }
         }
     }
 }
+object *object::create ()
+{
+  object *op = new object;
+  op->link ();
+  return op;
+}
+void
+object::do_destroy ()
+{
+  if (flag [FLAG_IS_LINKED])
+    remove_button_link (this);
+  if (flag [FLAG_FRIENDLY])
+    remove_friendly_object (this);
+  if (!flag [FLAG_REMOVED])
+    remove ();
+  if (flag [FLAG_FREED])
+    return;
+  flag [FLAG_FREED] = 1;
+  attachable::do_destroy ();
+  destroy_inv (true);
+  set_speed (0);
+  unlink ();
+  // hack to ensure that freed objects still have a valid map
+  {
+    static maptile *freed_map; // freed objects are moved here to avoid crashes
+    if (!freed_map)
+      {
+        freed_map = new maptile;
+        freed_map->name   = "/internal/freed_objects_map";
+        freed_map->width  = 3;
+        freed_map->height = 3;
+        freed_map->allocate ();
+      }
+    map = freed_map;
+    x = 1;
+    y = 1;
+  }
+  head = 0;
+  if (more)
+    {
+      more->destroy ();
+      more = 0;
+    }
+  // clear those pointers that likely might have circular references to us
+  owner       = 0;
+  enemy       = 0;
+  attacked_by = 0;
+  // only relevant for players(?), but make sure of it anyways
+  contr       = 0;
+}
 void
 object::destroy (bool destroy_inventory)
 {
   if (destroyed ())
     return;
-  if (more)
-    {
-      //TODO: non-head objects must not have inventory
-      more->destroy (destroy_inventory);
-      more = 0;
-    }
   if (destroy_inventory)
-    destroy_inv (true);
+    destroy_inv (false);
   attachable::destroy ();
 }
 /*
       if (map->in_memory == MAP_SAVING)
         return;
       int check_walk_off = !flag [FLAG_NO_APPLY];
-      for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
+      for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
         {
           /* No point updating the players look faces if he is the object
            * being removed.
            */

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.86 by root, Tue Dec 26 08:17:58 2006 UTC vs. Revision 1.91 by elmex, Tue Dec 26 10:51:52 2006 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.86 by root, Tue Dec 26 08:17:58 2006 UTC vs.
Revision 1.91 by elmex, Tue Dec 26 10:51:52 2006 UTC