ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.27 by root, Mon Sep 11 12:08:45 2006 UTC vs.
Revision 1.93 by root, Tue Dec 26 20:04:09 2006 UTC

1
2/*
3 * static char *rcsid_object_c =
4 * "$Id: object.C,v 1.27 2006/09/11 12:08:45 root Exp $";
5 */
6
7/* 1/*
8 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
9 3
10 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
… …
22 16
23 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26 20
27 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
28*/ 22*/
29 23
30/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
31 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
32 variable. */ 26 variable. */
33#include <global.h> 27#include <global.h>
34#ifndef WIN32 /* ---win32 exclude headers */
35# include <stdio.h> 28#include <stdio.h>
36# include <sys/types.h> 29#include <sys/types.h>
37# include <sys/uio.h> 30#include <sys/uio.h>
38#endif /* win32 */
39#include <object.h> 31#include <object.h>
40#include <funcpoint.h> 32#include <funcpoint.h>
41#include <skills.h>
42#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
36
43int nrofallocobjects = 0; 37int nrofallocobjects = 0;
38static UUID uuid;
39const uint64 UUID_SKIP = 1<<19;
44 40
45object *objects; /* Pointer to the list of used objects */
46object *active_objects; /* List of active objects that need to be processed */ 41object *active_objects; /* List of active objects that need to be processed */
47 42
48short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
49 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
50}; 45};
… …
57int freedir[SIZEOFFREE] = { 52int freedir[SIZEOFFREE] = {
58 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 53 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
59 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 54 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
60}; 55};
61 56
57static void
58write_uuid (void)
59{
60 char filename1[MAX_BUF], filename2[MAX_BUF];
61
62 sprintf (filename1, "%s/uuid", settings.localdir);
63 sprintf (filename2, "%s/uuid~", settings.localdir);
64
65 FILE *fp;
66
67 if (!(fp = fopen (filename2, "w")))
68 {
69 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
70 return;
71 }
72
73 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
74 fclose (fp);
75 rename (filename2, filename1);
76}
77
78static void
79read_uuid (void)
80{
81 char filename[MAX_BUF];
82
83 sprintf (filename, "%s/uuid", settings.localdir);
84
85 FILE *fp;
86
87 if (!(fp = fopen (filename, "r")))
88 {
89 if (errno == ENOENT)
90 {
91 LOG (llevInfo, "RESET uid to 1\n");
92 uuid.seq = 0;
93 write_uuid ();
94 return;
95 }
96
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1);
99 }
100
101 int version;
102 unsigned long long uid;
103 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)
104 {
105 LOG (llevError, "FATAL: error reading uid from %s!\n", filename);
106 _exit (1);
107 }
108
109 uuid.seq = uid;
110 write_uuid ();
111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp);
113}
114
115UUID
116gen_uuid ()
117{
118 UUID uid;
119
120 uid.seq = ++uuid.seq;
121
122 if (!(uuid.seq & (UUID_SKIP - 1)))
123 write_uuid ();
124
125 return uid;
126}
127
128void
129init_uuid ()
130{
131 read_uuid ();
132}
133
62/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 134/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
63static int 135static int
64compare_ob_value_lists_one (const object *wants, const object *has) 136compare_ob_value_lists_one (const object *wants, const object *has)
65{ 137{
66 key_value *wants_field; 138 key_value *wants_field;
… …
69 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
70 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
71 */ 143 */
72 144
73 /* For each field in wants, */ 145 /* For each field in wants, */
74 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
75 { 147 {
76 key_value *has_field; 148 key_value *has_field;
77 149
78 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
79 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
… …
113 * 185 *
114 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
115 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
116 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
117 * 189 *
118 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
119 * 191 *
120 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
121 * check weight 193 * check weight
122 */ 194 */
123 195
124bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
125{ 197{
126 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
127 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
128 return 0; 204 return 0;
129 205
130 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
131 return 0;
132
133 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
134 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
135 * used to store nrof). 209 * used to store nrof).
136 */ 210 */
137 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
147 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
148 222
149 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
150 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
151 225
152 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
153 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
154 * being locked in inventory should prevent merging.
155 * 0x4 in flags3 is CLIENT_SENT
156 */
157 if ((ob1->arch != ob2->arch) ||
158 (ob1->flags[0] != ob2->flags[0]) ||
159 (ob1->flags[1] != ob2->flags[1]) ||
160 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
161 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
162 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
163 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
164 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
165 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
166 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
167 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
168 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
169 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
170 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
171 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
172 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
173 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
174 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
175 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
176 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
177 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
178 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
179 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
180 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
181 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
182 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
183 return 0; 251 return 0;
184 252
185 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
186 * check all objects in the inventory. 254 * check all objects in the inventory.
187 */ 255 */
… …
190 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
191 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
192 return 0; 260 return 0;
193 261
194 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
195 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
196 return 0; 264 return 0;
197 265
198 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
199 * if it is valid. 267 * if it is valid.
200 */ 268 */
… …
214 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 282 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED)
215 return 0; 283 return 0;
216 284
217 switch (ob1->type) 285 switch (ob1->type)
218 { 286 {
219 case SCROLL: 287 case SCROLL:
220 if (ob1->level != ob2->level) 288 if (ob1->level != ob2->level)
221 return 0; 289 return 0;
222 break; 290 break;
223 } 291 }
224 292
225 if (ob1->key_values != NULL || ob2->key_values != NULL) 293 if (ob1->key_values != NULL || ob2->key_values != NULL)
226 { 294 {
227 /* At least one of these has key_values. */ 295 /* At least one of these has key_values. */
… …
249/* 317/*
250 * sum_weight() is a recursive function which calculates the weight 318 * sum_weight() is a recursive function which calculates the weight
251 * an object is carrying. It goes through in figures out how much 319 * an object is carrying. It goes through in figures out how much
252 * containers are carrying, and sums it up. 320 * containers are carrying, and sums it up.
253 */ 321 */
254signed long 322long
255sum_weight (object *op) 323sum_weight (object *op)
256{ 324{
257 signed long sum; 325 long sum;
258 object *inv; 326 object *inv;
259 327
260 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 328 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below)
261 { 329 {
262 if (inv->inv) 330 if (inv->inv)
263 sum_weight (inv); 331 sum_weight (inv);
264 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 332 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
265 } 333 }
334
266 if (op->type == CONTAINER && op->stats.Str) 335 if (op->type == CONTAINER && op->stats.Str)
267 sum = (sum * (100 - op->stats.Str)) / 100; 336 sum = (sum * (100 - op->stats.Str)) / 100;
337
268 if (op->carrying != sum) 338 if (op->carrying != sum)
269 op->carrying = sum; 339 op->carrying = sum;
340
270 return sum; 341 return sum;
271} 342}
272 343
273/** 344/**
274 * Return the outermost environment object for a given object. 345 * Return the outermost environment object for a given object.
… …
281 op = op->env; 352 op = op->env;
282 return op; 353 return op;
283} 354}
284 355
285/* 356/*
286 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
287 * a better check. We basically keeping traversing up until we can't
288 * or find a player.
289 */
290
291object *
292is_player_inv (object *op)
293{
294 for (; op != NULL && op->type != PLAYER; op = op->env)
295 if (op->env == op)
296 op->env = NULL;
297 return op;
298}
299
300/*
301 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
302 * Some error messages. 358 * Some error messages.
303 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
304 */ 360 */
305 361
306void 362char *
307dump_object2 (object *op)
308{
309 errmsg[0] = 0;
310 return;
311 //TODO//D#d#
312#if 0
313 char *cp;
314
315/* object *tmp;*/
316
317 if (op->arch != NULL)
318 {
319 strcat (errmsg, "arch ");
320 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
321 strcat (errmsg, "\n");
322 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
323 strcat (errmsg, cp);
324# if 0
325 /* Don't dump player diffs - they are too long, mostly meaningless, and
326 * will overflow the buffer.
327 * Changed so that we don't dump inventory either. This may
328 * also overflow the buffer.
329 */
330 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
331 strcat (errmsg, cp);
332 for (tmp = op->inv; tmp; tmp = tmp->below)
333 dump_object2 (tmp);
334# endif
335 strcat (errmsg, "end\n");
336 }
337 else
338 {
339 strcat (errmsg, "Object ");
340 if (op->name == NULL)
341 strcat (errmsg, "(null)");
342 else
343 strcat (errmsg, op->name);
344 strcat (errmsg, "\n");
345# if 0
346 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
347 strcat (errmsg, cp);
348 for (tmp = op->inv; tmp; tmp = tmp->below)
349 dump_object2 (tmp);
350# endif
351 strcat (errmsg, "end\n");
352 }
353#endif
354}
355
356/*
357 * Dumps an object. Returns output in the static global errmsg array.
358 */
359
360void
361dump_object (object *op) 363dump_object (object *op)
362{ 364{
363 if (op == NULL) 365 if (!op)
364 { 366 return strdup ("[NULLOBJ]");
365 strcpy (errmsg, "[NULL pointer]");
366 return;
367 }
368 errmsg[0] = '\0';
369 dump_object2 (op);
370}
371 367
372void 368 object_freezer freezer;
373dump_all_objects (void) 369 save_object (freezer, op, 1);
374{ 370 return freezer.as_string ();
375 object *op;
376
377 for (op = objects; op != NULL; op = op->next)
378 {
379 dump_object (op);
380 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
381 }
382} 371}
383 372
384/* 373/*
385 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
386 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
… …
406 */ 395 */
407 396
408object * 397object *
409find_object (tag_t i) 398find_object (tag_t i)
410{ 399{
411 object *op; 400 for (object *op = object::first; op; op = op->next)
412
413 for (op = objects; op != NULL; op = op->next)
414 if (op->count == i) 401 if (op->count == i)
415 break; 402 return op;
403
416 return op; 404 return 0;
417} 405}
418 406
419/* 407/*
420 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
421 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
… …
423 */ 411 */
424 412
425object * 413object *
426find_object_name (const char *str) 414find_object_name (const char *str)
427{ 415{
428 const char *name = shstr::find (str); 416 shstr_cmp str_ (str);
429 object *op; 417 object *op;
430 418
431 for (op = objects; op != NULL; op = op->next) 419 for (op = object::first; op != NULL; op = op->next)
432 if (&op->name == name) 420 if (op->name == str_)
433 break; 421 break;
434 422
435 return op; 423 return op;
436} 424}
437 425
… …
440{ 428{
441 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 429 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
442} 430}
443 431
444/* 432/*
445 * Returns the object which this object marks as being the owner.
446 * A id-scheme is used to avoid pointing to objects which have been
447 * freed and are now reused. If this is detected, the owner is
448 * set to NULL, and NULL is returned.
449 * Changed 2004-02-12 - if the player is setting at the play again
450 * prompt, he is removed, and we don't want to treat him as an owner of
451 * anything, so check removed flag. I don't expect that this should break
452 * anything - once an object is removed, it is basically dead anyways.
453 */
454
455object *
456get_owner (object *op)
457{
458 if (op->owner == NULL)
459 return NULL;
460
461 if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount)
462 return op->owner;
463
464 op->owner = NULL;
465 op->ownercount = 0;
466 return NULL;
467}
468
469void
470clear_owner (object *op)
471{
472 if (!op)
473 return;
474
475 if (op->owner && op->ownercount == op->owner->count)
476 op->owner->refcount--;
477
478 op->owner = NULL;
479 op->ownercount = 0;
480}
481
482/*
483 * Sets the owner and sets the skill and exp pointers to owner's current 433 * Sets the owner and sets the skill and exp pointers to owner's current
484 * skill and experience objects. 434 * skill and experience objects.
485 */ 435 */
486void 436void
487set_owner (object *op, object *owner) 437object::set_owner (object *owner)
488{ 438{
489 if (owner == NULL || op == NULL) 439 if (!owner)
490 return; 440 return;
491 441
492 /* next line added to allow objects which own objects */ 442 /* next line added to allow objects which own objects */
493 /* Add a check for ownercounts in here, as I got into an endless loop 443 /* Add a check for ownercounts in here, as I got into an endless loop
494 * with the fireball owning a poison cloud which then owned the 444 * with the fireball owning a poison cloud which then owned the
495 * fireball. I believe that was caused by one of the objects getting 445 * fireball. I believe that was caused by one of the objects getting
496 * freed and then another object replacing it. Since the ownercounts 446 * freed and then another object replacing it. Since the ownercounts
497 * didn't match, this check is valid and I believe that cause is valid. 447 * didn't match, this check is valid and I believe that cause is valid.
498 */ 448 */
499 while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count) 449 while (owner->owner)
500 owner = owner->owner; 450 owner = owner->owner;
501 451
502 /* IF the owner still has an owner, we did not resolve to a final owner.
503 * so lets not add to that.
504 */
505 if (owner->owner)
506 return;
507
508 op->owner = owner; 452 this->owner = owner;
509
510 op->ownercount = owner->count;
511 owner->refcount++;
512}
513
514/* Set the owner to clone's current owner and set the skill and experience
515 * objects to clone's objects (typically those objects that where the owner's
516 * current skill and experience objects at the time when clone's owner was
517 * set - not the owner's current skill and experience objects).
518 *
519 * Use this function if player created an object (e.g. fire bullet, swarm
520 * spell), and this object creates further objects whose kills should be
521 * accounted for the player's original skill, even if player has changed
522 * skills meanwhile.
523 */
524void
525copy_owner (object *op, object *clone)
526{
527 object *owner = get_owner (clone);
528
529 if (owner == NULL)
530 {
531 /* players don't have owners - they own themselves. Update
532 * as appropriate.
533 */
534 if (clone->type == PLAYER)
535 owner = clone;
536 else
537 return;
538 }
539
540 set_owner (op, owner);
541} 453}
542 454
543/* Zero the key_values on op, decrementing the shared-string 455/* Zero the key_values on op, decrementing the shared-string
544 * refcounts and freeing the links. 456 * refcounts and freeing the links.
545 */ 457 */
… …
555 } 467 }
556 468
557 op->key_values = 0; 469 op->key_values = 0;
558} 470}
559 471
560void object::clear ()
561{
562 attachable_base::clear ();
563
564 free_key_values (this);
565
566 clear_owner (this);
567
568 name = 0;
569 name_pl = 0;
570 title = 0;
571 race = 0;
572 slaying = 0;
573 skill = 0;
574 msg = 0;
575 lore = 0;
576 custom_name = 0;
577 materialname = 0;
578
579 memset (static_cast < object_pod * >(this), 0, sizeof (object_pod));
580
581 SET_FLAG (this, FLAG_REMOVED);
582}
583
584void object::clone (object *destination)
585{
586 *(object_copy *) destination = *this;
587 *(object_pod *) destination = *this;
588
589 if (self || cb)
590 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
591}
592
593/* 472/*
594 * clear_object() frees everything allocated by an object, and also
595 * clears all variables and flags to default settings.
596 */
597
598void
599clear_object (object *op)
600{
601 op->clear ();
602
603 op->contr = NULL;
604 op->below = NULL;
605 op->above = NULL;
606 op->inv = NULL;
607 op->container = NULL;
608 op->env = NULL;
609 op->more = NULL;
610 op->head = NULL;
611 op->map = NULL;
612 op->refcount = 0;
613 op->active_next = NULL;
614 op->active_prev = NULL;
615 /* What is not cleared is next, prev, and count */
616
617 op->expmul = 1.0;
618 op->face = blank_face;
619 op->attacked_by_count = -1;
620
621 if (settings.casting_time)
622 op->casting_time = -1;
623}
624
625/*
626 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
627 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
628 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
629 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
630 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
631 * will point at garbage. 478 * will point at garbage.
632 */ 479 */
633
634void 480void
635copy_object (object *op2, object *op) 481object::copy_to (object *dst)
636{ 482{
637 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
638 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
639 485
640 op2->clone (op); 486 *(object_copy *)dst = *this;
641 487
642 if (is_freed) 488 if (is_freed)
643 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
490
644 if (is_removed) 491 if (is_removed)
645 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
646 493
647 if (op2->speed < 0) 494 if (speed < 0)
648 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
649 496
650 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
651 if (op2->key_values) 498 if (key_values)
652 { 499 {
653 key_value *tail = 0; 500 key_value *tail = 0;
654 key_value *i; 501 key_value *i;
655 502
656 op->key_values = 0; 503 dst->key_values = 0;
657 504
658 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
659 { 506 {
660 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
661 508
662 new_link->next = 0; 509 new_link->next = 0;
663 new_link->key = i->key; 510 new_link->key = i->key;
664 new_link->value = i->value; 511 new_link->value = i->value;
665 512
666 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
667 if (!op->key_values) 514 if (!dst->key_values)
668 { 515 {
669 op->key_values = new_link; 516 dst->key_values = new_link;
670 tail = new_link; 517 tail = new_link;
671 } 518 }
672 else 519 else
673 { 520 {
674 tail->next = new_link; 521 tail->next = new_link;
675 tail = new_link; 522 tail = new_link;
676 } 523 }
677 } 524 }
678 } 525 }
679 526
680 update_ob_speed (op); 527 dst->set_speed (dst->speed);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
681} 536}
682 537
683/* 538/*
684 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
685 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
… …
698/* 553/*
699 * Updates the speed of an object. If the speed changes from 0 to another 554 * Updates the speed of an object. If the speed changes from 0 to another
700 * value, or vice versa, then add/remove the object from the active list. 555 * value, or vice versa, then add/remove the object from the active list.
701 * This function needs to be called whenever the speed of an object changes. 556 * This function needs to be called whenever the speed of an object changes.
702 */ 557 */
703
704void 558void
705update_ob_speed (object *op) 559object::set_speed (float speed)
706{ 560{
707 extern int arch_init; 561 extern int arch_init;
708 562
709 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
710 * since they never really need to be updated. 564 * since they never really need to be updated.
711 */ 565 */
712 566 if (flag [FLAG_FREED] && speed)
713 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
714 { 567 {
715 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &name);
716#ifdef MANY_CORES
717 abort ();
718#else
719 op->speed = 0; 569 speed = 0;
720#endif
721 } 570 }
571
572 this->speed = speed;
573
722 if (arch_init) 574 if (arch_init)
723 {
724 return; 575 return;
725 } 576
726 if (FABS (op->speed) > MIN_ACTIVE_SPEED) 577 if (FABS (speed) > MIN_ACTIVE_SPEED)
727 { 578 {
728 /* If already on active list, don't do anything */ 579 /* If already on active list, don't do anything */
729 if (op->active_next || op->active_prev || op == active_objects) 580 if (active_next || active_prev || this == active_objects)
730 return; 581 return;
731 582
732 /* process_events() expects us to insert the object at the beginning 583 /* process_events() expects us to insert the object at the beginning
733 * of the list. */ 584 * of the list. */
734 op->active_next = active_objects; 585 active_next = active_objects;
586
735 if (op->active_next != NULL) 587 if (active_next)
736 op->active_next->active_prev = op; 588 active_next->active_prev = this;
589
737 active_objects = op; 590 active_objects = this;
738 } 591 }
739 else 592 else
740 { 593 {
741 /* If not on the active list, nothing needs to be done */ 594 /* If not on the active list, nothing needs to be done */
742 if (!op->active_next && !op->active_prev && op != active_objects) 595 if (!active_next && !active_prev && this != active_objects)
743 return; 596 return;
744 597
745 if (op->active_prev == NULL) 598 if (!active_prev)
746 { 599 {
747 active_objects = op->active_next; 600 active_objects = active_next;
601
748 if (op->active_next != NULL) 602 if (active_next)
749 op->active_next->active_prev = NULL; 603 active_next->active_prev = 0;
750 } 604 }
751 else 605 else
752 { 606 {
753 op->active_prev->active_next = op->active_next; 607 active_prev->active_next = active_next;
608
754 if (op->active_next) 609 if (active_next)
755 op->active_next->active_prev = op->active_prev; 610 active_next->active_prev = active_prev;
756 } 611 }
612
757 op->active_next = NULL; 613 active_next = 0;
758 op->active_prev = NULL; 614 active_prev = 0;
759 } 615 }
760} 616}
761 617
762/* This function removes object 'op' from the list of active 618/* This function removes object 'op' from the list of active
763 * objects. 619 * objects.
… …
789 op->active_next = NULL; 645 op->active_next = NULL;
790 op->active_prev = NULL; 646 op->active_prev = NULL;
791} 647}
792 648
793/* 649/*
794 * update_object() updates the array which represents the map. 650 * update_object() updates the the map.
795 * It takes into account invisible objects (and represent squares covered 651 * It takes into account invisible objects (and represent squares covered
796 * by invisible objects by whatever is below them (unless it's another 652 * by invisible objects by whatever is below them (unless it's another
797 * invisible object, etc...) 653 * invisible object, etc...)
798 * If the object being updated is beneath a player, the look-window 654 * If the object being updated is beneath a player, the look-window
799 * of that player is updated (this might be a suboptimal way of 655 * of that player is updated (this might be a suboptimal way of
800 * updating that window, though, since update_object() is called _often_) 656 * updating that window, though, since update_object() is called _often_)
801 * 657 *
802 * action is a hint of what the caller believes need to be done. 658 * action is a hint of what the caller believes need to be done.
803 * For example, if the only thing that has changed is the face (due to
804 * an animation), we don't need to call update_position until that actually
805 * comes into view of a player. OTOH, many other things, like addition/removal
806 * of walls or living creatures may need us to update the flags now.
807 * current action are: 659 * current action are:
808 * UP_OBJ_INSERT: op was inserted 660 * UP_OBJ_INSERT: op was inserted
809 * UP_OBJ_REMOVE: op was removed 661 * UP_OBJ_REMOVE: op was removed
810 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 662 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
811 * as that is easier than trying to look at what may have changed. 663 * as that is easier than trying to look at what may have changed.
812 * UP_OBJ_FACE: only the objects face has changed. 664 * UP_OBJ_FACE: only the objects face has changed.
813 */ 665 */
814
815void 666void
816update_object (object *op, int action) 667update_object (object *op, int action)
817{ 668{
818 int update_now = 0, flags;
819 MoveType move_on, move_off, move_block, move_slow; 669 MoveType move_on, move_off, move_block, move_slow;
820 670
821 if (op == NULL) 671 if (op == NULL)
822 { 672 {
823 /* this should never happen */ 673 /* this should never happen */
824 LOG (llevDebug, "update_object() called for NULL object.\n"); 674 LOG (llevDebug, "update_object() called for NULL object.\n");
825 return; 675 return;
826 } 676 }
827 677
828 if (op->env != NULL) 678 if (op->env)
829 { 679 {
830 /* Animation is currently handled by client, so nothing 680 /* Animation is currently handled by client, so nothing
831 * to do in this case. 681 * to do in this case.
832 */ 682 */
833 return; 683 return;
… …
838 */ 688 */
839 if (!op->map || op->map->in_memory == MAP_SAVING) 689 if (!op->map || op->map->in_memory == MAP_SAVING)
840 return; 690 return;
841 691
842 /* make sure the object is within map boundaries */ 692 /* make sure the object is within map boundaries */
843 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 693 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
844 { 694 {
845 LOG (llevError, "update_object() called for object out of map!\n"); 695 LOG (llevError, "update_object() called for object out of map!\n");
846#ifdef MANY_CORES 696#ifdef MANY_CORES
847 abort (); 697 abort ();
848#endif 698#endif
849 return; 699 return;
850 } 700 }
851 701
852 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 702 mapspace &m = op->ms ();
853 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
854 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
855 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
856 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
857 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
858 703
704 if (m.flags_ & P_NEED_UPDATE)
705 /* nop */;
859 if (action == UP_OBJ_INSERT) 706 else if (action == UP_OBJ_INSERT)
860 { 707 {
708 // this is likely overkill, TODO: revisit (schmorp)
861 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 709 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
862 update_now = 1;
863
864 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 710 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
865 update_now = 1; 711 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
866 712 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
713 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
867 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 714 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
868 update_now = 1;
869
870 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
871 update_now = 1;
872
873 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
874 update_now = 1;
875
876 if ((move_on | op->move_on) != move_on) 715 || (m.move_on | op->move_on ) != m.move_on
877 update_now = 1;
878
879 if ((move_off | op->move_off) != move_off) 716 || (m.move_off | op->move_off ) != m.move_off
880 update_now = 1; 717 || (m.move_slow | op->move_slow) != m.move_slow
881
882 /* This isn't perfect, but I don't expect a lot of objects to 718 /* This isn't perfect, but I don't expect a lot of objects to
883 * to have move_allow right now. 719 * to have move_allow right now.
884 */ 720 */
885 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 721 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
886 update_now = 1; 722 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
887 723 m.flags_ = P_NEED_UPDATE;
888 if ((move_slow | op->move_slow) != move_slow)
889 update_now = 1;
890 } 724 }
891 /* if the object is being removed, we can't make intelligent 725 /* if the object is being removed, we can't make intelligent
892 * decisions, because remove_ob can't really pass the object 726 * decisions, because remove_ob can't really pass the object
893 * that is being removed. 727 * that is being removed.
894 */ 728 */
895 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 729 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
896 update_now = 1; 730 m.flags_ = P_NEED_UPDATE;
897 else if (action == UP_OBJ_FACE) 731 else if (action == UP_OBJ_FACE)
898 /* Nothing to do for that case */; 732 /* Nothing to do for that case */ ;
899 else 733 else
900 LOG (llevError, "update_object called with invalid action: %d\n", action); 734 LOG (llevError, "update_object called with invalid action: %d\n", action);
901 735
902 if (update_now)
903 {
904 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
905 update_position (op->map, op->x, op->y);
906 }
907
908 if (op->more != NULL) 736 if (op->more)
909 update_object (op->more, action); 737 update_object (op->more, action);
910} 738}
911 739
912static unordered_vector<object *> mortals; 740object::vector object::objects; // not yet used
913static std::vector<object *> freed; 741object *object::first;
914
915void object::free_mortals ()
916{
917 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end (); )
918 if (!(*i)->refcount)
919 {
920 freed.push_back (*i);
921 mortals.erase (i);
922 }
923 else
924 ++i;
925}
926 742
927object::object () 743object::object ()
928{ 744{
929 SET_FLAG (this, FLAG_REMOVED); 745 SET_FLAG (this, FLAG_REMOVED);
930 746
931 expmul = 1.0; 747 expmul = 1.0;
932 face = blank_face; 748 face = blank_face;
933 attacked_by_count = -1;
934} 749}
935 750
936object::~object () 751object::~object ()
937{ 752{
938 free_key_values (this); 753 free_key_values (this);
939} 754}
940 755
941void object::link () 756void object::link ()
942{ 757{
943 count = ++ob_count; 758 count = ++ob_count;
759 uuid = gen_uuid ();
944 760
945 prev = 0; 761 prev = 0;
946 next = objects; 762 next = object::first;
947 763
948 if (objects) 764 if (object::first)
949 objects->prev = this; 765 object::first->prev = this;
950 766
951 objects = this; 767 object::first = this;
952} 768}
953 769
954void object::unlink () 770void object::unlink ()
955{ 771{
956 count = 0; 772 if (this == object::first)
773 object::first = next;
957 774
958 /* Remove this object from the list of used objects */ 775 /* Remove this object from the list of used objects */
959 if (prev)
960 {
961 prev->next = next; 776 if (prev) prev->next = next;
777 if (next) next->prev = prev;
778
962 prev = 0; 779 prev = 0;
963 }
964
965 if (next)
966 {
967 next->prev = prev;
968 next = 0; 780 next = 0;
781}
782
783/*
784 * Remove and free all objects in the inventory of the given object.
785 * object.c ?
786 */
787void
788object::destroy_inv (bool drop_to_ground)
789{
790 /* Only if the space blocks everything do we not process -
791 * if some form of movement is allowed, let objects
792 * drop on that space.
793 */
794 if (!drop_to_ground
795 || !map
796 || map->in_memory != MAP_IN_MEMORY
797 || map->at (x, y).move_block == MOVE_ALL)
969 } 798 {
799 while (inv)
800 {
801 inv->destroy_inv (drop_to_ground);
802 inv->destroy ();
803 }
804 }
805 else
806 { /* Put objects in inventory onto this space */
807 while (inv)
808 {
809 object *op = inv;
970 810
971 if (this == objects) 811 if (op->flag [FLAG_STARTEQUIP]
972 objects = next; 812 || op->flag [FLAG_NO_DROP]
813 || op->type == RUNE
814 || op->type == TRAP
815 || op->flag [FLAG_IS_A_TEMPLATE])
816 op->destroy ();
817 else
818 map->insert (op, x, y);
819 }
820 }
973} 821}
974 822
975object *object::create () 823object *object::create ()
976{ 824{
977 object *op;
978
979 if (freed.empty ())
980 op = new object; 825 object *op = new object;
981 else
982 {
983 // highly annoying, but the only way to get it stable right now
984 op = freed.back (); freed.pop_back ();
985 op->~object ();
986 new ((void *)op) object;
987 }
988
989 op->link (); 826 op->link ();
990 return op; 827 return op;
991} 828}
992 829
993/* 830void
994 * free_object() frees everything allocated by an object, removes 831object::do_destroy ()
995 * it from the list of used objects, and puts it on the list of
996 * free objects. The IS_FREED() flag is set in the object.
997 * The object must have been removed by remove_ob() first for
998 * this function to succeed.
999 *
1000 * If free_inventory is set, free inventory as well. Else drop items in
1001 * inventory to the ground.
1002 */
1003void object::free (bool free_inventory)
1004{ 832{
1005 if (!QUERY_FLAG (this, FLAG_REMOVED)) 833 if (flag [FLAG_IS_LINKED])
1006 { 834 remove_button_link (this);
1007 LOG (llevDebug, "Free object called with non removed object\n");
1008 dump_object (this);
1009#ifdef MANY_CORES
1010 abort ();
1011#endif
1012 }
1013 835
1014 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 836 if (flag [FLAG_FRIENDLY])
1015 {
1016 LOG (llevMonster, "Warning: tried to free friendly object.\n");
1017 remove_friendly_object (this); 837 remove_friendly_object (this);
1018 }
1019 838
1020 if (QUERY_FLAG (this, FLAG_FREED)) 839 if (!flag [FLAG_REMOVED])
1021 { 840 remove ();
1022 dump_object (this); 841
1023 LOG (llevError, "Trying to free freed object.\n%s\n", errmsg); 842 if (flag [FLAG_FREED])
1024 return; 843 return;
844
845 set_speed (0);
846
847 flag [FLAG_FREED] = 1;
848
849 attachable::do_destroy ();
850
851 destroy_inv (true);
852 unlink ();
853
854 // hack to ensure that freed objects still have a valid map
855 {
856 static maptile *freed_map; // freed objects are moved here to avoid crashes
857
858 if (!freed_map)
859 {
860 freed_map = new maptile;
861
862 freed_map->name = "/internal/freed_objects_map";
863 freed_map->width = 3;
864 freed_map->height = 3;
865
866 freed_map->allocate ();
1025 } 867 }
868
869 map = freed_map;
870 x = 1;
871 y = 1;
872 }
873
874 head = 0;
1026 875
1027 if (more) 876 if (more)
1028 { 877 {
1029 more->free (free_inventory); 878 more->destroy ();
1030 more = 0; 879 more = 0;
1031 } 880 }
1032 881
1033 if (inv) 882 // clear those pointers that likely might have circular references to us
1034 { 883 owner = 0;
1035 /* Only if the space blocks everything do we not process - 884 enemy = 0;
1036 * if some form of movement is allowed, let objects 885 attacked_by = 0;
1037 * drop on that space.
1038 */
1039 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL))
1040 {
1041 object *
1042 op = inv;
1043 886
1044 while (op) 887 // only relevant for players(?), but make sure of it anyways
1045 { 888 contr = 0;
1046 object * 889}
1047 tmp = op->below;
1048 890
1049 remove_ob (op); 891void
1050 op->free (free_inventory); 892object::destroy (bool destroy_inventory)
1051 op = tmp; 893{
1052 } 894 if (destroyed ())
1053 } 895 return;
1054 else
1055 { /* Put objects in inventory onto this space */
1056 object *
1057 op = inv;
1058 896
1059 while (op) 897 if (destroy_inventory)
1060 { 898 destroy_inv (false);
1061 object *
1062 tmp = op->below;
1063 899
1064 remove_ob (op); 900 attachable::destroy ();
1065
1066 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1067 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1068 free_object (op);
1069 else
1070 {
1071 op->x = x;
1072 op->y = y;
1073 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1074 }
1075
1076 op = tmp;
1077 }
1078 }
1079 }
1080
1081 clear_owner (this);
1082
1083 /* Remove object from the active list */
1084 speed = 0;
1085 update_ob_speed (this);
1086
1087 unlink ();
1088
1089 SET_FLAG (this, FLAG_FREED);
1090
1091 mortals.push_back (this);
1092} 901}
1093 902
1094/* 903/*
1095 * sub_weight() recursively (outwards) subtracts a number from the 904 * sub_weight() recursively (outwards) subtracts a number from the
1096 * weight of an object (and what is carried by it's environment(s)). 905 * weight of an object (and what is carried by it's environment(s)).
1097 */ 906 */
1098
1099void 907void
1100sub_weight (object *op, signed long weight) 908sub_weight (object *op, signed long weight)
1101{ 909{
1102 while (op != NULL) 910 while (op != NULL)
1103 { 911 {
1104 if (op->type == CONTAINER) 912 if (op->type == CONTAINER)
1105 {
1106 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 913 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1107 } 914
1108 op->carrying -= weight; 915 op->carrying -= weight;
1109 op = op->env; 916 op = op->env;
1110 } 917 }
1111} 918}
1112 919
1113/* remove_ob(op): 920/* op->remove ():
1114 * This function removes the object op from the linked list of objects 921 * This function removes the object op from the linked list of objects
1115 * which it is currently tied to. When this function is done, the 922 * which it is currently tied to. When this function is done, the
1116 * object will have no environment. If the object previously had an 923 * object will have no environment. If the object previously had an
1117 * environment, the x and y coordinates will be updated to 924 * environment, the x and y coordinates will be updated to
1118 * the previous environment. 925 * the previous environment.
1119 * Beware: This function is called from the editor as well! 926 * Beware: This function is called from the editor as well!
1120 */ 927 */
1121
1122void 928void
1123remove_ob (object *op) 929object::remove ()
1124{ 930{
1125 object *tmp, *last = NULL; 931 object *tmp, *last = 0;
1126 object *otmp; 932 object *otmp;
1127 933
1128 tag_t tag;
1129 int check_walk_off;
1130 mapstruct *m;
1131
1132 sint16 x, y;
1133
1134 if (QUERY_FLAG (op, FLAG_REMOVED)) 934 if (QUERY_FLAG (this, FLAG_REMOVED))
1135 { 935 return;
1136 dump_object (op);
1137 LOG (llevError, "Trying to remove removed object.\n%s\n", errmsg);
1138 936
1139 /* Changed it to always dump core in this case. As has been learned
1140 * in the past, trying to recover from errors almost always
1141 * make things worse, and this is a real error here - something
1142 * that should not happen.
1143 * Yes, if this was a mission critical app, trying to do something
1144 * to recover may make sense, but that is because failure of the app
1145 * may have other disastrous problems. Cf runs out of a script
1146 * so is easily enough restarted without any real problems.
1147 * MSW 2001-07-01
1148 */
1149 abort ();
1150 }
1151
1152 if (op->more != NULL)
1153 remove_ob (op->more);
1154
1155 SET_FLAG (op, FLAG_REMOVED); 937 SET_FLAG (this, FLAG_REMOVED);
938 INVOKE_OBJECT (REMOVE, this);
939
940 if (more)
941 more->remove ();
1156 942
1157 /* 943 /*
1158 * In this case, the object to be removed is in someones 944 * In this case, the object to be removed is in someones
1159 * inventory. 945 * inventory.
1160 */ 946 */
1161 if (op->env != NULL) 947 if (env)
1162 { 948 {
1163 if (op->nrof) 949 if (nrof)
1164 sub_weight (op->env, op->weight * op->nrof); 950 sub_weight (env, weight * nrof);
1165 else 951 else
1166 sub_weight (op->env, op->weight + op->carrying); 952 sub_weight (env, weight + carrying);
1167 953
1168 /* NO_FIX_PLAYER is set when a great many changes are being 954 /* NO_FIX_PLAYER is set when a great many changes are being
1169 * made to players inventory. If set, avoiding the call 955 * made to players inventory. If set, avoiding the call
1170 * to save cpu time. 956 * to save cpu time.
1171 */ 957 */
1172 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 958 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1173 fix_player (otmp); 959 otmp->update_stats ();
1174 960
1175 if (op->above != NULL) 961 if (above != NULL)
1176 op->above->below = op->below; 962 above->below = below;
1177 else 963 else
1178 op->env->inv = op->below; 964 env->inv = below;
1179 965
1180 if (op->below != NULL) 966 if (below != NULL)
1181 op->below->above = op->above; 967 below->above = above;
1182 968
1183 /* we set up values so that it could be inserted into 969 /* we set up values so that it could be inserted into
1184 * the map, but we don't actually do that - it is up 970 * the map, but we don't actually do that - it is up
1185 * to the caller to decide what we want to do. 971 * to the caller to decide what we want to do.
1186 */ 972 */
1187 op->x = op->env->x, op->y = op->env->y; 973 x = env->x, y = env->y;
1188 op->map = op->env->map; 974 map = env->map;
1189 op->above = NULL, op->below = NULL; 975 above = 0, below = 0;
1190 op->env = NULL; 976 env = 0;
1191 return;
1192 }
1193
1194 /* If we get here, we are removing it from a map */
1195 if (op->map == NULL)
1196 return;
1197
1198 x = op->x;
1199 y = op->y;
1200 m = get_map_from_coord (op->map, &x, &y);
1201
1202 if (!m)
1203 { 977 }
1204 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 978 else if (map)
1205 op->map->path, op->x, op->y); 979 {
1206 /* in old days, we used to set x and y to 0 and continue. 980 /* Re did the following section of code - it looks like it had
1207 * it seems if we get into this case, something is probablye 981 * lots of logic for things we no longer care about
1208 * screwed up and should be fixed.
1209 */ 982 */
1210 abort ();
1211 }
1212 if (op->map != m)
1213 {
1214 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1215 op->map->path, m->path, op->x, op->y, x, y);
1216 }
1217 983
1218 /* Re did the following section of code - it looks like it had
1219 * lots of logic for things we no longer care about
1220 */
1221
1222 /* link the object above us */ 984 /* link the object above us */
1223 if (op->above) 985 if (above)
1224 op->above->below = op->below; 986 above->below = below;
1225 else 987 else
1226 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 988 map->at (x, y).top = below; /* we were top, set new top */
1227 989
1228 /* Relink the object below us, if there is one */ 990 /* Relink the object below us, if there is one */
1229 if (op->below) 991 if (below)
1230 op->below->above = op->above; 992 below->above = above;
1231 else 993 else
1232 {
1233 /* Nothing below, which means we need to relink map object for this space
1234 * use translated coordinates in case some oddness with map tiling is
1235 * evident
1236 */
1237 if (GET_MAP_OB (m, x, y) != op)
1238 { 994 {
1239 dump_object (op); 995 /* Nothing below, which means we need to relink map object for this space
996 * use translated coordinates in case some oddness with map tiling is
997 * evident
998 */
999 if (GET_MAP_OB (map, x, y) != this)
1000 {
1001 char *dump = dump_object (this);
1002 LOG (llevError,
1240 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", 1003 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1241 errmsg); 1004 free (dump);
1242 dump_object (GET_MAP_OB (m, x, y)); 1005 dump = dump_object (GET_MAP_OB (map, x, y));
1243 LOG (llevError, "%s\n", errmsg); 1006 LOG (llevError, "%s\n", dump);
1007 free (dump);
1008 }
1009
1010 map->at (x, y).bot = above; /* goes on above it. */
1244 } 1011 }
1245 1012
1246 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1013 above = 0;
1247 } 1014 below = 0;
1248 1015
1249 op->above = NULL;
1250 op->below = NULL;
1251
1252 if (op->map->in_memory == MAP_SAVING) 1016 if (map->in_memory == MAP_SAVING)
1253 return; 1017 return;
1254 1018
1255 tag = op->count; 1019 int check_walk_off = !flag [FLAG_NO_APPLY];
1256 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1257 1020
1258 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1021 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1259 {
1260 /* No point updating the players look faces if he is the object
1261 * being removed.
1262 */
1263
1264 if (tmp->type == PLAYER && tmp != op)
1265 { 1022 {
1266 /* If a container that the player is currently using somehow gets 1023 /* No point updating the players look faces if he is the object
1267 * removed (most likely destroyed), update the player view 1024 * being removed.
1268 * appropriately.
1269 */ 1025 */
1270 if (tmp->container == op) 1026
1027 if (tmp->type == PLAYER && tmp != this)
1271 { 1028 {
1272 CLEAR_FLAG (op, FLAG_APPLIED); 1029 /* If a container that the player is currently using somehow gets
1030 * removed (most likely destroyed), update the player view
1031 * appropriately.
1032 */
1033 if (tmp->container == this)
1034 {
1035 flag [FLAG_APPLIED] = 0;
1273 tmp->container = NULL; 1036 tmp->container = 0;
1037 }
1038
1039 if (tmp->contr->ns)
1040 tmp->contr->ns->floorbox_update ();
1274 } 1041 }
1275 1042
1276 tmp->contr->socket.update_look = 1; 1043 /* See if player moving off should effect something */
1044 if (check_walk_off
1045 && ((move_type & tmp->move_off)
1046 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1047 {
1048 move_apply (tmp, this, 0);
1049
1050 if (destroyed ())
1051 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1052 }
1053
1054 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1055
1056 if (tmp->above == tmp)
1057 tmp->above = 0;
1058
1059 last = tmp;
1277 } 1060 }
1278 /* See if player moving off should effect something */
1279 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1280 {
1281 move_apply (tmp, op, NULL);
1282 1061
1283 if (was_destroyed (op, tag))
1284 {
1285 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);
1286 }
1287 }
1288
1289 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1290
1291 if (tmp->above == tmp)
1292 tmp->above = NULL;
1293
1294 last = tmp;
1295 }
1296
1297 /* last == NULL of there are no objects on this space */ 1062 /* last == NULL of there are no objects on this space */
1298 if (last == NULL) 1063 if (!last)
1299 { 1064 map->at (x, y).flags_ = P_NEED_UPDATE;
1300 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1301 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1302 * those out anyways, and if there are any flags set right now, they won't
1303 * be correct anyways.
1304 */
1305 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1306 update_position (op->map, op->x, op->y);
1307 }
1308 else 1065 else
1309 update_object (last, UP_OBJ_REMOVE); 1066 update_object (last, UP_OBJ_REMOVE);
1310 1067
1311 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1068 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1312 update_all_los (op->map, op->x, op->y); 1069 update_all_los (map, x, y);
1070 }
1313} 1071}
1314 1072
1315/* 1073/*
1316 * merge_ob(op,top): 1074 * merge_ob(op,top):
1317 * 1075 *
1318 * This function goes through all objects below and including top, and 1076 * This function goes through all objects below and including top, and
1319 * merges op to the first matching object. 1077 * merges op to the first matching object.
1320 * If top is NULL, it is calculated. 1078 * If top is NULL, it is calculated.
1321 * Returns pointer to object if it succeded in the merge, otherwise NULL 1079 * Returns pointer to object if it succeded in the merge, otherwise NULL
1322 */ 1080 */
1323
1324object * 1081object *
1325merge_ob (object *op, object *top) 1082merge_ob (object *op, object *top)
1326{ 1083{
1327 if (!op->nrof) 1084 if (!op->nrof)
1328 return 0; 1085 return 0;
1329 if (top == NULL) 1086
1087 if (top)
1330 for (top = op; top != NULL && top->above != NULL; top = top->above); 1088 for (top = op; top && top->above; top = top->above)
1089 ;
1090
1331 for (; top != NULL; top = top->below) 1091 for (; top; top = top->below)
1332 { 1092 {
1333 if (top == op) 1093 if (top == op)
1334 continue; 1094 continue;
1335 if (CAN_MERGE (op, top)) 1095
1096 if (object::can_merge (op, top))
1336 { 1097 {
1337 top->nrof += op->nrof; 1098 top->nrof += op->nrof;
1338 1099
1339/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1100/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1340 op->weight = 0; /* Don't want any adjustements now */ 1101 op->weight = 0; /* Don't want any adjustements now */
1341 remove_ob (op); 1102 op->destroy ();
1342 free_object (op);
1343 return top; 1103 return top;
1344 } 1104 }
1345 } 1105 }
1106
1346 return NULL; 1107 return 0;
1347} 1108}
1348 1109
1349/* 1110/*
1350 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1111 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1351 * job preparing multi-part monsters 1112 * job preparing multi-part monsters
1352 */ 1113 */
1353object * 1114object *
1354insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1115insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1355{ 1116{
1356 object *
1357 tmp;
1358
1359 if (op->head)
1360 op = op->head;
1361 for (tmp = op; tmp; tmp = tmp->more) 1117 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1362 { 1118 {
1363 tmp->x = x + tmp->arch->clone.x; 1119 tmp->x = x + tmp->arch->clone.x;
1364 tmp->y = y + tmp->arch->clone.y; 1120 tmp->y = y + tmp->arch->clone.y;
1365 } 1121 }
1122
1366 return insert_ob_in_map (op, m, originator, flag); 1123 return insert_ob_in_map (op, m, originator, flag);
1367} 1124}
1368 1125
1369/* 1126/*
1370 * insert_ob_in_map (op, map, originator, flag): 1127 * insert_ob_in_map (op, map, originator, flag):
… …
1384 * Return value: 1141 * Return value:
1385 * new object if 'op' was merged with other object 1142 * new object if 'op' was merged with other object
1386 * NULL if 'op' was destroyed 1143 * NULL if 'op' was destroyed
1387 * just 'op' otherwise 1144 * just 'op' otherwise
1388 */ 1145 */
1389
1390object * 1146object *
1391insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1147insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1392{ 1148{
1393 object *tmp, *top, *floor = NULL; 1149 object *tmp, *top, *floor = NULL;
1394 sint16 x, y; 1150 sint16 x, y;
1395 1151
1396 if (QUERY_FLAG (op, FLAG_FREED)) 1152 if (QUERY_FLAG (op, FLAG_FREED))
… …
1399 return NULL; 1155 return NULL;
1400 } 1156 }
1401 1157
1402 if (m == NULL) 1158 if (m == NULL)
1403 { 1159 {
1404 dump_object (op); 1160 char *dump = dump_object (op);
1405 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1161 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1162 free (dump);
1406 return op; 1163 return op;
1407 } 1164 }
1408 1165
1409 if (out_of_map (m, op->x, op->y)) 1166 if (out_of_map (m, op->x, op->y))
1410 { 1167 {
1411 dump_object (op); 1168 char *dump = dump_object (op);
1412 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1169 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1413#ifdef MANY_CORES 1170#ifdef MANY_CORES
1414 /* Better to catch this here, as otherwise the next use of this object 1171 /* Better to catch this here, as otherwise the next use of this object
1415 * is likely to cause a crash. Better to find out where it is getting 1172 * is likely to cause a crash. Better to find out where it is getting
1416 * improperly inserted. 1173 * improperly inserted.
1417 */ 1174 */
1418 abort (); 1175 abort ();
1419#endif 1176#endif
1177 free (dump);
1420 return op; 1178 return op;
1421 } 1179 }
1422 1180
1423 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1181 if (!QUERY_FLAG (op, FLAG_REMOVED))
1424 { 1182 {
1425 dump_object (op); 1183 char *dump = dump_object (op);
1426 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1184 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1185 free (dump);
1427 return op; 1186 return op;
1428 } 1187 }
1429 1188
1430 if (op->more != NULL) 1189 if (op->more)
1431 { 1190 {
1432 /* The part may be on a different map. */ 1191 /* The part may be on a different map. */
1433 1192
1434 object *more = op->more; 1193 object *more = op->more;
1435 1194
… …
1451 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1210 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1452 { 1211 {
1453 if (!op->head) 1212 if (!op->head)
1454 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1213 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1455 1214
1456 return NULL; 1215 return 0;
1457 } 1216 }
1458 } 1217 }
1459 1218
1460 CLEAR_FLAG (op, FLAG_REMOVED); 1219 CLEAR_FLAG (op, FLAG_REMOVED);
1461 1220
… …
1469 1228
1470 /* this has to be done after we translate the coordinates. 1229 /* this has to be done after we translate the coordinates.
1471 */ 1230 */
1472 if (op->nrof && !(flag & INS_NO_MERGE)) 1231 if (op->nrof && !(flag & INS_NO_MERGE))
1473 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1232 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1474 if (CAN_MERGE (op, tmp)) 1233 if (object::can_merge (op, tmp))
1475 { 1234 {
1476 op->nrof += tmp->nrof; 1235 op->nrof += tmp->nrof;
1477 remove_ob (tmp); 1236 tmp->destroy ();
1478 free_object (tmp);
1479 } 1237 }
1480 1238
1481 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1239 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1482 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1240 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1483 1241
… …
1496 op->below = originator->below; 1254 op->below = originator->below;
1497 1255
1498 if (op->below) 1256 if (op->below)
1499 op->below->above = op; 1257 op->below->above = op;
1500 else 1258 else
1501 SET_MAP_OB (op->map, op->x, op->y, op); 1259 op->ms ().bot = op;
1502 1260
1503 /* since *below* originator, no need to update top */ 1261 /* since *below* originator, no need to update top */
1504 originator->below = op; 1262 originator->below = op;
1505 } 1263 }
1506 else 1264 else
… …
1552 * If INS_ON_TOP is used, don't do this processing 1310 * If INS_ON_TOP is used, don't do this processing
1553 * Need to find the object that in fact blocks view, otherwise 1311 * Need to find the object that in fact blocks view, otherwise
1554 * stacking is a bit odd. 1312 * stacking is a bit odd.
1555 */ 1313 */
1556 if (!(flag & INS_ON_TOP) && 1314 if (!(flag & INS_ON_TOP) &&
1557 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1315 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1558 { 1316 {
1559 for (last = top; last != floor; last = last->below) 1317 for (last = top; last != floor; last = last->below)
1560 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1318 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1561 break; 1319 break;
1562 /* Check to see if we found the object that blocks view, 1320 /* Check to see if we found the object that blocks view,
… …
1585 1343
1586 if (op->above) 1344 if (op->above)
1587 op->above->below = op; 1345 op->above->below = op;
1588 1346
1589 op->below = NULL; 1347 op->below = NULL;
1590 SET_MAP_OB (op->map, op->x, op->y, op); 1348 op->ms ().bot = op;
1591 } 1349 }
1592 else 1350 else
1593 { /* get inserted into the stack above top */ 1351 { /* get inserted into the stack above top */
1594 op->above = top->above; 1352 op->above = top->above;
1595 1353
… …
1599 op->below = top; 1357 op->below = top;
1600 top->above = op; 1358 top->above = op;
1601 } 1359 }
1602 1360
1603 if (op->above == NULL) 1361 if (op->above == NULL)
1604 SET_MAP_TOP (op->map, op->x, op->y, op); 1362 op->ms ().top = op;
1605 } /* else not INS_BELOW_ORIGINATOR */ 1363 } /* else not INS_BELOW_ORIGINATOR */
1606 1364
1607 if (op->type == PLAYER) 1365 if (op->type == PLAYER)
1608 op->contr->do_los = 1; 1366 op->contr->do_los = 1;
1609 1367
1610 /* If we have a floor, we know the player, if any, will be above 1368 /* If we have a floor, we know the player, if any, will be above
1611 * it, so save a few ticks and start from there. 1369 * it, so save a few ticks and start from there.
1612 */ 1370 */
1613 if (!(flag & INS_MAP_LOAD)) 1371 if (!(flag & INS_MAP_LOAD))
1614 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1372 if (object *pl = op->ms ().player ())
1615 if (tmp->type == PLAYER) 1373 if (pl->contr->ns)
1616 tmp->contr->socket.update_look = 1; 1374 pl->contr->ns->floorbox_update ();
1617 1375
1618 /* If this object glows, it may affect lighting conditions that are 1376 /* If this object glows, it may affect lighting conditions that are
1619 * visible to others on this map. But update_all_los is really 1377 * visible to others on this map. But update_all_los is really
1620 * an inefficient way to do this, as it means los for all players 1378 * an inefficient way to do this, as it means los for all players
1621 * on the map will get recalculated. The players could very well 1379 * on the map will get recalculated. The players could very well
1622 * be far away from this change and not affected in any way - 1380 * be far away from this change and not affected in any way -
1623 * this should get redone to only look for players within range, 1381 * this should get redone to only look for players within range,
1624 * or just updating the P_NEED_UPDATE for spaces within this area 1382 * or just updating the P_NEED_UPDATE for spaces within this area
1625 * of effect may be sufficient. 1383 * of effect may be sufficient.
1626 */ 1384 */
1627 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1385 if (op->map->darkness && (op->glow_radius != 0))
1628 update_all_los (op->map, op->x, op->y); 1386 update_all_los (op->map, op->x, op->y);
1629 1387
1630 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1388 /* updates flags (blocked, alive, no magic, etc) for this map space */
1631 update_object (op, UP_OBJ_INSERT); 1389 update_object (op, UP_OBJ_INSERT);
1632 1390
1391 INVOKE_OBJECT (INSERT, op);
1392
1633 /* Don't know if moving this to the end will break anything. However, 1393 /* Don't know if moving this to the end will break anything. However,
1634 * we want to have update_look set above before calling this. 1394 * we want to have floorbox_update called before calling this.
1635 * 1395 *
1636 * check_move_on() must be after this because code called from 1396 * check_move_on() must be after this because code called from
1637 * check_move_on() depends on correct map flags (so functions like 1397 * check_move_on() depends on correct map flags (so functions like
1638 * blocked() and wall() work properly), and these flags are updated by 1398 * blocked() and wall() work properly), and these flags are updated by
1639 * update_object(). 1399 * update_object().
… …
1641 1401
1642 /* if this is not the head or flag has been passed, don't check walk on status */ 1402 /* if this is not the head or flag has been passed, don't check walk on status */
1643 if (!(flag & INS_NO_WALK_ON) && !op->head) 1403 if (!(flag & INS_NO_WALK_ON) && !op->head)
1644 { 1404 {
1645 if (check_move_on (op, originator)) 1405 if (check_move_on (op, originator))
1646 return NULL; 1406 return 0;
1647 1407
1648 /* If we are a multi part object, lets work our way through the check 1408 /* If we are a multi part object, lets work our way through the check
1649 * walk on's. 1409 * walk on's.
1650 */ 1410 */
1651 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1411 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1652 if (check_move_on (tmp, originator)) 1412 if (check_move_on (tmp, originator))
1653 return NULL; 1413 return 0;
1654 } 1414 }
1655 1415
1656 return op; 1416 return op;
1657} 1417}
1658 1418
1659/* this function inserts an object in the map, but if it 1419/* this function inserts an object in the map, but if it
1660 * finds an object of its own type, it'll remove that one first. 1420 * finds an object of its own type, it'll remove that one first.
1661 * op is the object to insert it under: supplies x and the map. 1421 * op is the object to insert it under: supplies x and the map.
1662 */ 1422 */
1663void 1423void
1664replace_insert_ob_in_map (const char *arch_string, object *op) 1424replace_insert_ob_in_map (const char *arch_string, object *op)
1665{ 1425{
1666 object *tmp;
1667 object *tmp1; 1426 object *tmp, *tmp1;
1668 1427
1669 /* first search for itself and remove any old instances */ 1428 /* first search for itself and remove any old instances */
1670 1429
1671 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1430 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1672 {
1673 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1431 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1674 { 1432 tmp->destroy ();
1675 remove_ob (tmp);
1676 free_object (tmp);
1677 }
1678 }
1679 1433
1680 tmp1 = arch_to_object (find_archetype (arch_string)); 1434 tmp1 = arch_to_object (archetype::find (arch_string));
1681 1435
1682 tmp1->x = op->x; 1436 tmp1->x = op->x;
1683 tmp1->y = op->y; 1437 tmp1->y = op->y;
1684 insert_ob_in_map (tmp1, op->map, op, 0); 1438 insert_ob_in_map (tmp1, op->map, op, 0);
1439}
1440
1441object *
1442object::insert_at (object *where, object *originator, int flags)
1443{
1444 where->map->insert (this, where->x, where->y, originator, flags);
1685} 1445}
1686 1446
1687/* 1447/*
1688 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1448 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1689 * is returned contains nr objects, and the remaining parts contains 1449 * is returned contains nr objects, and the remaining parts contains
1690 * the rest (or is removed and freed if that number is 0). 1450 * the rest (or is removed and freed if that number is 0).
1691 * On failure, NULL is returned, and the reason put into the 1451 * On failure, NULL is returned, and the reason put into the
1692 * global static errmsg array. 1452 * global static errmsg array.
1693 */ 1453 */
1694
1695object * 1454object *
1696get_split_ob (object *orig_ob, uint32 nr) 1455get_split_ob (object *orig_ob, uint32 nr)
1697{ 1456{
1698 object * 1457 object *newob;
1699 newob;
1700 int
1701 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1458 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1702 1459
1703 if (orig_ob->nrof < nr) 1460 if (orig_ob->nrof < nr)
1704 { 1461 {
1705 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1462 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1706 return NULL; 1463 return NULL;
1707 } 1464 }
1465
1708 newob = object_create_clone (orig_ob); 1466 newob = object_create_clone (orig_ob);
1467
1709 if ((orig_ob->nrof -= nr) < 1) 1468 if ((orig_ob->nrof -= nr) < 1)
1710 { 1469 orig_ob->destroy (1);
1711 if (!is_removed)
1712 remove_ob (orig_ob);
1713 free_object2 (orig_ob, 1);
1714 }
1715 else if (!is_removed) 1470 else if (!is_removed)
1716 { 1471 {
1717 if (orig_ob->env != NULL) 1472 if (orig_ob->env != NULL)
1718 sub_weight (orig_ob->env, orig_ob->weight * nr); 1473 sub_weight (orig_ob->env, orig_ob->weight * nr);
1719 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1474 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1721 strcpy (errmsg, "Tried to split object whose map is not in memory."); 1476 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1722 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n"); 1477 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1723 return NULL; 1478 return NULL;
1724 } 1479 }
1725 } 1480 }
1481
1726 newob->nrof = nr; 1482 newob->nrof = nr;
1727 1483
1728 return newob; 1484 return newob;
1729} 1485}
1730 1486
… …
1737 */ 1493 */
1738 1494
1739object * 1495object *
1740decrease_ob_nr (object *op, uint32 i) 1496decrease_ob_nr (object *op, uint32 i)
1741{ 1497{
1742 object * 1498 object *tmp;
1743 tmp;
1744 player *
1745 pl;
1746 1499
1747 if (i == 0) /* objects with op->nrof require this check */ 1500 if (i == 0) /* objects with op->nrof require this check */
1748 return op; 1501 return op;
1749 1502
1750 if (i > op->nrof) 1503 if (i > op->nrof)
1751 i = op->nrof; 1504 i = op->nrof;
1752 1505
1753 if (QUERY_FLAG (op, FLAG_REMOVED)) 1506 if (QUERY_FLAG (op, FLAG_REMOVED))
1754 {
1755 op->nrof -= i; 1507 op->nrof -= i;
1756 }
1757 else if (op->env != NULL) 1508 else if (op->env)
1758 { 1509 {
1759 /* is this object in the players inventory, or sub container 1510 /* is this object in the players inventory, or sub container
1760 * therein? 1511 * therein?
1761 */ 1512 */
1762 tmp = is_player_inv (op->env); 1513 tmp = op->in_player ();
1763 /* nope. Is this a container the player has opened? 1514 /* nope. Is this a container the player has opened?
1764 * If so, set tmp to that player. 1515 * If so, set tmp to that player.
1765 * IMO, searching through all the players will mostly 1516 * IMO, searching through all the players will mostly
1766 * likely be quicker than following op->env to the map, 1517 * likely be quicker than following op->env to the map,
1767 * and then searching the map for a player. 1518 * and then searching the map for a player.
1768 */ 1519 */
1769 if (!tmp) 1520 if (!tmp)
1770 { 1521 for_all_players (pl)
1771 for (pl = first_player; pl; pl = pl->next)
1772 if (pl->ob->container == op->env) 1522 if (pl->ob->container == op->env)
1523 {
1524 tmp = pl->ob;
1773 break; 1525 break;
1774 if (pl)
1775 tmp = pl->ob;
1776 else
1777 tmp = NULL;
1778 } 1526 }
1779 1527
1780 if (i < op->nrof) 1528 if (i < op->nrof)
1781 { 1529 {
1782 sub_weight (op->env, op->weight * i); 1530 sub_weight (op->env, op->weight * i);
1783 op->nrof -= i; 1531 op->nrof -= i;
1784 if (tmp) 1532 if (tmp)
1785 {
1786 esrv_send_item (tmp, op); 1533 esrv_send_item (tmp, op);
1787 }
1788 } 1534 }
1789 else 1535 else
1790 { 1536 {
1791 remove_ob (op); 1537 op->remove ();
1792 op->nrof = 0; 1538 op->nrof = 0;
1793 if (tmp) 1539 if (tmp)
1794 {
1795 esrv_del_item (tmp->contr, op->count); 1540 esrv_del_item (tmp->contr, op->count);
1796 }
1797 } 1541 }
1798 } 1542 }
1799 else 1543 else
1800 { 1544 {
1801 object *
1802 above = op->above; 1545 object *above = op->above;
1803 1546
1804 if (i < op->nrof) 1547 if (i < op->nrof)
1805 {
1806 op->nrof -= i; 1548 op->nrof -= i;
1807 }
1808 else 1549 else
1809 { 1550 {
1810 remove_ob (op); 1551 op->remove ();
1811 op->nrof = 0; 1552 op->nrof = 0;
1812 } 1553 }
1554
1813 /* Since we just removed op, op->above is null */ 1555 /* Since we just removed op, op->above is null */
1814 for (tmp = above; tmp != NULL; tmp = tmp->above) 1556 for (tmp = above; tmp; tmp = tmp->above)
1815 if (tmp->type == PLAYER) 1557 if (tmp->type == PLAYER)
1816 { 1558 {
1817 if (op->nrof) 1559 if (op->nrof)
1818 esrv_send_item (tmp, op); 1560 esrv_send_item (tmp, op);
1819 else 1561 else
1820 esrv_del_item (tmp->contr, op->count); 1562 esrv_del_item (tmp->contr, op->count);
1821 } 1563 }
1822 } 1564 }
1823 1565
1824 if (op->nrof) 1566 if (op->nrof)
1825 {
1826 return op; 1567 return op;
1827 }
1828 else 1568 else
1829 { 1569 {
1830 free_object (op); 1570 op->destroy ();
1831 return NULL; 1571 return 0;
1832 } 1572 }
1833} 1573}
1834 1574
1835/* 1575/*
1836 * add_weight(object, weight) adds the specified weight to an object, 1576 * add_weight(object, weight) adds the specified weight to an object,
… …
1841add_weight (object *op, signed long weight) 1581add_weight (object *op, signed long weight)
1842{ 1582{
1843 while (op != NULL) 1583 while (op != NULL)
1844 { 1584 {
1845 if (op->type == CONTAINER) 1585 if (op->type == CONTAINER)
1846 {
1847 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 1586 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1848 } 1587
1849 op->carrying += weight; 1588 op->carrying += weight;
1850 op = op->env; 1589 op = op->env;
1851 } 1590 }
1852} 1591}
1853 1592
1593object *
1594insert_ob_in_ob (object *op, object *where)
1595{
1596 if (!where)
1597 {
1598 char *dump = dump_object (op);
1599 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1600 free (dump);
1601 return op;
1602 }
1603
1604 if (where->head)
1605 {
1606 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1607 where = where->head;
1608 }
1609
1610 return where->insert (op);
1611}
1612
1854/* 1613/*
1855 * insert_ob_in_ob(op,environment): 1614 * env->insert (op)
1856 * This function inserts the object op in the linked list 1615 * This function inserts the object op in the linked list
1857 * inside the object environment. 1616 * inside the object environment.
1858 * 1617 *
1859 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1860 * the inventory at the last position or next to other objects of the same
1861 * type.
1862 * Frank: Now sorted by type, archetype and magic!
1863 *
1864 * The function returns now pointer to inserted item, and return value can 1618 * The function returns now pointer to inserted item, and return value can
1865 * be != op, if items are merged. -Tero 1619 * be != op, if items are merged. -Tero
1866 */ 1620 */
1867 1621
1868object * 1622object *
1869insert_ob_in_ob (object *op, object *where) 1623object::insert (object *op)
1870{ 1624{
1871 object * 1625 object *tmp, *otmp;
1872 tmp, *
1873 otmp;
1874 1626
1875 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1627 if (!QUERY_FLAG (op, FLAG_REMOVED))
1876 { 1628 op->remove ();
1877 dump_object (op); 1629
1878 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1879 return op;
1880 }
1881 if (where == NULL)
1882 {
1883 dump_object (op);
1884 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1885 return op;
1886 }
1887 if (where->head)
1888 {
1889 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1890 where = where->head;
1891 }
1892 if (op->more) 1630 if (op->more)
1893 { 1631 {
1894 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1632 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1895 return op; 1633 return op;
1896 } 1634 }
1635
1897 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1636 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1898 CLEAR_FLAG (op, FLAG_REMOVED); 1637 CLEAR_FLAG (op, FLAG_REMOVED);
1899 if (op->nrof) 1638 if (op->nrof)
1900 { 1639 {
1901 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1640 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1902 if (CAN_MERGE (tmp, op)) 1641 if (object::can_merge (tmp, op))
1903 { 1642 {
1904 /* return the original object and remove inserted object 1643 /* return the original object and remove inserted object
1905 (client needs the original object) */ 1644 (client needs the original object) */
1906 tmp->nrof += op->nrof; 1645 tmp->nrof += op->nrof;
1907 /* Weight handling gets pretty funky. Since we are adding to 1646 /* Weight handling gets pretty funky. Since we are adding to
1908 * tmp->nrof, we need to increase the weight. 1647 * tmp->nrof, we need to increase the weight.
1909 */ 1648 */
1910 add_weight (where, op->weight * op->nrof); 1649 add_weight (this, op->weight * op->nrof);
1911 SET_FLAG (op, FLAG_REMOVED); 1650 SET_FLAG (op, FLAG_REMOVED);
1912 free_object (op); /* free the inserted object */ 1651 op->destroy (); /* free the inserted object */
1913 op = tmp; 1652 op = tmp;
1914 remove_ob (op); /* and fix old object's links */ 1653 op->remove (); /* and fix old object's links */
1915 CLEAR_FLAG (op, FLAG_REMOVED); 1654 CLEAR_FLAG (op, FLAG_REMOVED);
1916 break; 1655 break;
1917 } 1656 }
1918 1657
1919 /* I assume combined objects have no inventory 1658 /* I assume combined objects have no inventory
1920 * We add the weight - this object could have just been removed 1659 * We add the weight - this object could have just been removed
1921 * (if it was possible to merge). calling remove_ob will subtract 1660 * (if it was possible to merge). calling remove_ob will subtract
1922 * the weight, so we need to add it in again, since we actually do 1661 * the weight, so we need to add it in again, since we actually do
1923 * the linking below 1662 * the linking below
1924 */ 1663 */
1925 add_weight (where, op->weight * op->nrof); 1664 add_weight (this, op->weight * op->nrof);
1926 } 1665 }
1927 else 1666 else
1928 add_weight (where, (op->weight + op->carrying)); 1667 add_weight (this, (op->weight + op->carrying));
1929 1668
1930 otmp = is_player_inv (where); 1669 otmp = this->in_player ();
1931 if (otmp && otmp->contr != NULL) 1670 if (otmp && otmp->contr)
1932 {
1933 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1671 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1934 fix_player (otmp); 1672 otmp->update_stats ();
1935 }
1936 1673
1937 op->map = NULL; 1674 op->map = 0;
1938 op->env = where; 1675 op->env = this;
1939 op->above = NULL; 1676 op->above = 0;
1940 op->below = NULL; 1677 op->below = 0;
1941 op->x = 0, op->y = 0; 1678 op->x = 0, op->y = 0;
1942 1679
1943 /* reset the light list and los of the players on the map */ 1680 /* reset the light list and los of the players on the map */
1944 if ((op->glow_radius != 0) && where->map) 1681 if ((op->glow_radius != 0) && map)
1945 { 1682 {
1946#ifdef DEBUG_LIGHTS 1683#ifdef DEBUG_LIGHTS
1947 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1684 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1948#endif /* DEBUG_LIGHTS */ 1685#endif /* DEBUG_LIGHTS */
1949 if (MAP_DARKNESS (where->map)) 1686 if (map->darkness)
1950 update_all_los (where->map, where->x, where->y); 1687 update_all_los (map, x, y);
1951 } 1688 }
1952 1689
1953 /* Client has no idea of ordering so lets not bother ordering it here. 1690 /* Client has no idea of ordering so lets not bother ordering it here.
1954 * It sure simplifies this function... 1691 * It sure simplifies this function...
1955 */ 1692 */
1956 if (where->inv == NULL) 1693 if (!inv)
1957 where->inv = op; 1694 inv = op;
1958 else 1695 else
1959 { 1696 {
1960 op->below = where->inv; 1697 op->below = inv;
1961 op->below->above = op; 1698 op->below->above = op;
1962 where->inv = op; 1699 inv = op;
1963 } 1700 }
1701
1702 INVOKE_OBJECT (INSERT, this);
1703
1964 return op; 1704 return op;
1965} 1705}
1966 1706
1967/* 1707/*
1968 * Checks if any objects has a move_type that matches objects 1708 * Checks if any objects has a move_type that matches objects
… …
1982 * 1722 *
1983 * MSW 2001-07-08: Check all objects on space, not just those below 1723 * MSW 2001-07-08: Check all objects on space, not just those below
1984 * object being inserted. insert_ob_in_map may not put new objects 1724 * object being inserted. insert_ob_in_map may not put new objects
1985 * on top. 1725 * on top.
1986 */ 1726 */
1987
1988int 1727int
1989check_move_on (object *op, object *originator) 1728check_move_on (object *op, object *originator)
1990{ 1729{
1991 object *tmp; 1730 object *tmp;
1992 tag_t tag;
1993 mapstruct *m = op->map; 1731 maptile *m = op->map;
1994 int x = op->x, y = op->y; 1732 int x = op->x, y = op->y;
1995 1733
1996 MoveType move_on, move_slow, move_block; 1734 MoveType move_on, move_slow, move_block;
1997 1735
1998 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1736 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1999 return 0; 1737 return 0;
2000
2001 tag = op->count;
2002 1738
2003 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1739 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
2004 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1740 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
2005 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1741 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
2006 1742
… …
2022 1758
2023 /* The objects have to be checked from top to bottom. 1759 /* The objects have to be checked from top to bottom.
2024 * Hence, we first go to the top: 1760 * Hence, we first go to the top:
2025 */ 1761 */
2026 1762
2027 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1763 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
2028 { 1764 {
2029 /* Trim the search when we find the first other spell effect 1765 /* Trim the search when we find the first other spell effect
2030 * this helps performance so that if a space has 50 spell objects, 1766 * this helps performance so that if a space has 50 spell objects,
2031 * we don't need to check all of them. 1767 * we don't need to check all of them.
2032 */ 1768 */
… …
2049 { 1785 {
2050 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1786 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2051 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1787 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2052 { 1788 {
2053 1789
1790 float
2054 float diff = tmp->move_slow_penalty * FABS (op->speed); 1791 diff = tmp->move_slow_penalty * FABS (op->speed);
2055 1792
2056 if (op->type == PLAYER) 1793 if (op->type == PLAYER)
2057 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1794 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2058 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1795 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2059 diff /= 4.0; 1796 diff /= 4.0;
… …
2066 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1803 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2067 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1804 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2068 { 1805 {
2069 move_apply (tmp, op, originator); 1806 move_apply (tmp, op, originator);
2070 1807
2071 if (was_destroyed (op, tag)) 1808 if (op->destroyed ())
2072 return 1; 1809 return 1;
2073 1810
2074 /* what the person/creature stepped onto has moved the object 1811 /* what the person/creature stepped onto has moved the object
2075 * someplace new. Don't process any further - if we did, 1812 * someplace new. Don't process any further - if we did,
2076 * have a feeling strange problems would result. 1813 * have a feeling strange problems would result.
… …
2086/* 1823/*
2087 * present_arch(arch, map, x, y) searches for any objects with 1824 * present_arch(arch, map, x, y) searches for any objects with
2088 * a matching archetype at the given map and coordinates. 1825 * a matching archetype at the given map and coordinates.
2089 * The first matching object is returned, or NULL if none. 1826 * The first matching object is returned, or NULL if none.
2090 */ 1827 */
2091
2092object * 1828object *
2093present_arch (const archetype *at, mapstruct *m, int x, int y) 1829present_arch (const archetype *at, maptile *m, int x, int y)
2094{ 1830{
2095 object *
2096 tmp;
2097
2098 if (m == NULL || out_of_map (m, x, y)) 1831 if (m == NULL || out_of_map (m, x, y))
2099 { 1832 {
2100 LOG (llevError, "Present_arch called outside map.\n"); 1833 LOG (llevError, "Present_arch called outside map.\n");
2101 return NULL; 1834 return NULL;
2102 } 1835 }
1836
2103 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1837 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2104 if (tmp->arch == at) 1838 if (tmp->arch == at)
2105 return tmp; 1839 return tmp;
1840
2106 return NULL; 1841 return NULL;
2107} 1842}
2108 1843
2109/* 1844/*
2110 * present(type, map, x, y) searches for any objects with 1845 * present(type, map, x, y) searches for any objects with
2111 * a matching type variable at the given map and coordinates. 1846 * a matching type variable at the given map and coordinates.
2112 * The first matching object is returned, or NULL if none. 1847 * The first matching object is returned, or NULL if none.
2113 */ 1848 */
2114
2115object * 1849object *
2116present (unsigned char type, mapstruct *m, int x, int y) 1850present (unsigned char type, maptile *m, int x, int y)
2117{ 1851{
2118 object *
2119 tmp;
2120
2121 if (out_of_map (m, x, y)) 1852 if (out_of_map (m, x, y))
2122 { 1853 {
2123 LOG (llevError, "Present called outside map.\n"); 1854 LOG (llevError, "Present called outside map.\n");
2124 return NULL; 1855 return NULL;
2125 } 1856 }
1857
2126 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1858 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2127 if (tmp->type == type) 1859 if (tmp->type == type)
2128 return tmp; 1860 return tmp;
1861
2129 return NULL; 1862 return NULL;
2130} 1863}
2131 1864
2132/* 1865/*
2133 * present_in_ob(type, object) searches for any objects with 1866 * present_in_ob(type, object) searches for any objects with
2134 * a matching type variable in the inventory of the given object. 1867 * a matching type variable in the inventory of the given object.
2135 * The first matching object is returned, or NULL if none. 1868 * The first matching object is returned, or NULL if none.
2136 */ 1869 */
2137
2138object * 1870object *
2139present_in_ob (unsigned char type, const object *op) 1871present_in_ob (unsigned char type, const object *op)
2140{ 1872{
2141 object *
2142 tmp;
2143
2144 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1873 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2145 if (tmp->type == type) 1874 if (tmp->type == type)
2146 return tmp; 1875 return tmp;
1876
2147 return NULL; 1877 return NULL;
2148} 1878}
2149 1879
2150/* 1880/*
2151 * present_in_ob (type, str, object) searches for any objects with 1881 * present_in_ob (type, str, object) searches for any objects with
… …
2159 * str is the string to match against. Note that we match against 1889 * str is the string to match against. Note that we match against
2160 * the object name, not the archetype name. this is so that the 1890 * the object name, not the archetype name. this is so that the
2161 * spell code can use one object type (force), but change it's name 1891 * spell code can use one object type (force), but change it's name
2162 * to be unique. 1892 * to be unique.
2163 */ 1893 */
2164
2165object * 1894object *
2166present_in_ob_by_name (int type, const char *str, const object *op) 1895present_in_ob_by_name (int type, const char *str, const object *op)
2167{ 1896{
2168 object *
2169 tmp;
2170
2171 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1897 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2172 {
2173 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1898 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2174 return tmp; 1899 return tmp;
2175 } 1900
2176 return NULL; 1901 return 0;
2177} 1902}
2178 1903
2179/* 1904/*
2180 * present_arch_in_ob(archetype, object) searches for any objects with 1905 * present_arch_in_ob(archetype, object) searches for any objects with
2181 * a matching archetype in the inventory of the given object. 1906 * a matching archetype in the inventory of the given object.
2182 * The first matching object is returned, or NULL if none. 1907 * The first matching object is returned, or NULL if none.
2183 */ 1908 */
2184
2185object * 1909object *
2186present_arch_in_ob (const archetype *at, const object *op) 1910present_arch_in_ob (const archetype *at, const object *op)
2187{ 1911{
2188 object *
2189 tmp;
2190
2191 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1912 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2192 if (tmp->arch == at) 1913 if (tmp->arch == at)
2193 return tmp; 1914 return tmp;
1915
2194 return NULL; 1916 return NULL;
2195} 1917}
2196 1918
2197/* 1919/*
2198 * activate recursively a flag on an object inventory 1920 * activate recursively a flag on an object inventory
2199 */ 1921 */
2200void 1922void
2201flag_inv (object *op, int flag) 1923flag_inv (object *op, int flag)
2202{ 1924{
2203 object *
2204 tmp;
2205
2206 if (op->inv) 1925 if (op->inv)
2207 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1926 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2208 { 1927 {
2209 SET_FLAG (tmp, flag); 1928 SET_FLAG (tmp, flag);
2210 flag_inv (tmp, flag); 1929 flag_inv (tmp, flag);
2211 } 1930 }
2212} /* 1931}
1932
1933/*
2213 * desactivate recursively a flag on an object inventory 1934 * deactivate recursively a flag on an object inventory
2214 */ 1935 */
2215void 1936void
2216unflag_inv (object *op, int flag) 1937unflag_inv (object *op, int flag)
2217{ 1938{
2218 object *
2219 tmp;
2220
2221 if (op->inv) 1939 if (op->inv)
2222 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1940 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2223 { 1941 {
2224 CLEAR_FLAG (tmp, flag); 1942 CLEAR_FLAG (tmp, flag);
2225 unflag_inv (tmp, flag); 1943 unflag_inv (tmp, flag);
2226 } 1944 }
2227} 1945}
… …
2230 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1948 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2231 * all it's inventory (recursively). 1949 * all it's inventory (recursively).
2232 * If checksums are used, a player will get set_cheat called for 1950 * If checksums are used, a player will get set_cheat called for
2233 * him/her-self and all object carried by a call to this function. 1951 * him/her-self and all object carried by a call to this function.
2234 */ 1952 */
2235
2236void 1953void
2237set_cheat (object *op) 1954set_cheat (object *op)
2238{ 1955{
2239 SET_FLAG (op, FLAG_WAS_WIZ); 1956 SET_FLAG (op, FLAG_WAS_WIZ);
2240 flag_inv (op, FLAG_WAS_WIZ); 1957 flag_inv (op, FLAG_WAS_WIZ);
… …
2259 * because arch_blocked (now ob_blocked) needs to know the movement type 1976 * because arch_blocked (now ob_blocked) needs to know the movement type
2260 * to know if the space in question will block the object. We can't use 1977 * to know if the space in question will block the object. We can't use
2261 * the archetype because that isn't correct if the monster has been 1978 * the archetype because that isn't correct if the monster has been
2262 * customized, changed states, etc. 1979 * customized, changed states, etc.
2263 */ 1980 */
2264
2265int 1981int
2266find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1982find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2267{ 1983{
2268 int
2269 i,
2270 index = 0, flag; 1984 int index = 0, flag;
2271 static int
2272 altern[SIZEOFFREE]; 1985 int altern[SIZEOFFREE];
2273 1986
2274 for (i = start; i < stop; i++) 1987 for (int i = start; i < stop; i++)
2275 { 1988 {
2276 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1989 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2277 if (!flag) 1990 if (!flag)
2278 altern[index++] = i; 1991 altern [index++] = i;
2279 1992
2280 /* Basically, if we find a wall on a space, we cut down the search size. 1993 /* Basically, if we find a wall on a space, we cut down the search size.
2281 * In this way, we won't return spaces that are on another side of a wall. 1994 * In this way, we won't return spaces that are on another side of a wall.
2282 * This mostly work, but it cuts down the search size in all directions - 1995 * This mostly work, but it cuts down the search size in all directions -
2283 * if the space being examined only has a wall to the north and empty 1996 * if the space being examined only has a wall to the north and empty
2284 * spaces in all the other directions, this will reduce the search space 1997 * spaces in all the other directions, this will reduce the search space
2285 * to only the spaces immediately surrounding the target area, and 1998 * to only the spaces immediately surrounding the target area, and
2286 * won't look 2 spaces south of the target space. 1999 * won't look 2 spaces south of the target space.
2287 */ 2000 */
2288 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2001 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2289 stop = maxfree[i]; 2002 stop = maxfree[i];
2290 } 2003 }
2004
2291 if (!index) 2005 if (!index)
2292 return -1; 2006 return -1;
2007
2293 return altern[RANDOM () % index]; 2008 return altern[RANDOM () % index];
2294} 2009}
2295 2010
2296/* 2011/*
2297 * find_first_free_spot(archetype, mapstruct, x, y) works like 2012 * find_first_free_spot(archetype, maptile, x, y) works like
2298 * find_free_spot(), but it will search max number of squares. 2013 * find_free_spot(), but it will search max number of squares.
2299 * But it will return the first available spot, not a random choice. 2014 * But it will return the first available spot, not a random choice.
2300 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2015 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2301 */ 2016 */
2302
2303int 2017int
2304find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2018find_first_free_spot (const object *ob, maptile *m, int x, int y)
2305{ 2019{
2306 int
2307 i;
2308
2309 for (i = 0; i < SIZEOFFREE; i++) 2020 for (int i = 0; i < SIZEOFFREE; i++)
2310 {
2311 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2021 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2312 return i; 2022 return i;
2313 } 2023
2314 return -1; 2024 return -1;
2315} 2025}
2316 2026
2317/* 2027/*
2318 * The function permute(arr, begin, end) randomly reorders the array 2028 * The function permute(arr, begin, end) randomly reorders the array
2319 * arr[begin..end-1]. 2029 * arr[begin..end-1].
2030 * now uses a fisher-yates shuffle, old permute was broken
2320 */ 2031 */
2321static void 2032static void
2322permute (int *arr, int begin, int end) 2033permute (int *arr, int begin, int end)
2323{ 2034{
2324 int 2035 arr += begin;
2325 i,
2326 j,
2327 tmp,
2328 len;
2329
2330 len = end - begin; 2036 end -= begin;
2331 for (i = begin; i < end; i++)
2332 {
2333 j = begin + RANDOM () % len;
2334 2037
2335 tmp = arr[i]; 2038 while (--end)
2336 arr[i] = arr[j]; 2039 swap (arr [end], arr [RANDOM () % (end + 1)]);
2337 arr[j] = tmp;
2338 }
2339} 2040}
2340 2041
2341/* new function to make monster searching more efficient, and effective! 2042/* new function to make monster searching more efficient, and effective!
2342 * This basically returns a randomized array (in the passed pointer) of 2043 * This basically returns a randomized array (in the passed pointer) of
2343 * the spaces to find monsters. In this way, it won't always look for 2044 * the spaces to find monsters. In this way, it won't always look for
… …
2346 * the 3x3 area will be searched, just not in a predictable order. 2047 * the 3x3 area will be searched, just not in a predictable order.
2347 */ 2048 */
2348void 2049void
2349get_search_arr (int *search_arr) 2050get_search_arr (int *search_arr)
2350{ 2051{
2351 int 2052 int i;
2352 i;
2353 2053
2354 for (i = 0; i < SIZEOFFREE; i++) 2054 for (i = 0; i < SIZEOFFREE; i++)
2355 {
2356 search_arr[i] = i; 2055 search_arr[i] = i;
2357 }
2358 2056
2359 permute (search_arr, 1, SIZEOFFREE1 + 1); 2057 permute (search_arr, 1, SIZEOFFREE1 + 1);
2360 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2058 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2361 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2059 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2362} 2060}
… …
2371 * Perhaps incorrectly, but I'm making the assumption that exclude 2069 * Perhaps incorrectly, but I'm making the assumption that exclude
2372 * is actually want is going to try and move there. We need this info 2070 * is actually want is going to try and move there. We need this info
2373 * because we have to know what movement the thing looking to move 2071 * because we have to know what movement the thing looking to move
2374 * there is capable of. 2072 * there is capable of.
2375 */ 2073 */
2376
2377int 2074int
2378find_dir (mapstruct *m, int x, int y, object *exclude) 2075find_dir (maptile *m, int x, int y, object *exclude)
2379{ 2076{
2380 int
2381 i,
2382 max = SIZEOFFREE, mflags; 2077 int i, max = SIZEOFFREE, mflags;
2383 sint16 2078
2384 nx, 2079 sint16 nx, ny;
2385 ny;
2386 object * 2080 object *tmp;
2387 tmp; 2081 maptile *mp;
2388 mapstruct * 2082
2389 mp; 2083 MoveType blocked, move_type;
2390 MoveType
2391 blocked,
2392 move_type;
2393 2084
2394 if (exclude && exclude->head) 2085 if (exclude && exclude->head)
2395 { 2086 {
2396 exclude = exclude->head; 2087 exclude = exclude->head;
2397 move_type = exclude->move_type; 2088 move_type = exclude->move_type;
… …
2407 mp = m; 2098 mp = m;
2408 nx = x + freearr_x[i]; 2099 nx = x + freearr_x[i];
2409 ny = y + freearr_y[i]; 2100 ny = y + freearr_y[i];
2410 2101
2411 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2102 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2103
2412 if (mflags & P_OUT_OF_MAP) 2104 if (mflags & P_OUT_OF_MAP)
2413 {
2414 max = maxfree[i]; 2105 max = maxfree[i];
2415 }
2416 else 2106 else
2417 { 2107 {
2418 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2108 mapspace &ms = mp->at (nx, ny);
2109
2110 blocked = ms.move_block;
2419 2111
2420 if ((move_type & blocked) == move_type) 2112 if ((move_type & blocked) == move_type)
2421 {
2422 max = maxfree[i]; 2113 max = maxfree[i];
2423 }
2424 else if (mflags & P_IS_ALIVE) 2114 else if (mflags & P_IS_ALIVE)
2425 { 2115 {
2426 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2116 for (tmp = ms.bot; tmp; tmp = tmp->above)
2427 { 2117 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2428 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2118 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2429 {
2430 break; 2119 break;
2431 } 2120
2432 }
2433 if (tmp) 2121 if (tmp)
2434 {
2435 return freedir[i]; 2122 return freedir[i];
2436 }
2437 } 2123 }
2438 } 2124 }
2439 } 2125 }
2126
2440 return 0; 2127 return 0;
2441} 2128}
2442 2129
2443/* 2130/*
2444 * distance(object 1, object 2) will return the square of the 2131 * distance(object 1, object 2) will return the square of the
2445 * distance between the two given objects. 2132 * distance between the two given objects.
2446 */ 2133 */
2447
2448int 2134int
2449distance (const object *ob1, const object *ob2) 2135distance (const object *ob1, const object *ob2)
2450{ 2136{
2451 int
2452 i;
2453
2454 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2137 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2455 return i;
2456} 2138}
2457 2139
2458/* 2140/*
2459 * find_dir_2(delta-x,delta-y) will return a direction in which 2141 * find_dir_2(delta-x,delta-y) will return a direction in which
2460 * an object which has subtracted the x and y coordinates of another 2142 * an object which has subtracted the x and y coordinates of another
2461 * object, needs to travel toward it. 2143 * object, needs to travel toward it.
2462 */ 2144 */
2463
2464int 2145int
2465find_dir_2 (int x, int y) 2146find_dir_2 (int x, int y)
2466{ 2147{
2467 int 2148 int q;
2468 q;
2469 2149
2470 if (y) 2150 if (y)
2471 q = x * 100 / y; 2151 q = x * 100 / y;
2472 else if (x) 2152 else if (x)
2473 q = -300 * x; 2153 q = -300 * x;
… …
2508int 2188int
2509absdir (int d) 2189absdir (int d)
2510{ 2190{
2511 while (d < 1) 2191 while (d < 1)
2512 d += 8; 2192 d += 8;
2193
2513 while (d > 8) 2194 while (d > 8)
2514 d -= 8; 2195 d -= 8;
2196
2515 return d; 2197 return d;
2516} 2198}
2517 2199
2518/* 2200/*
2519 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2201 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
… …
2521 */ 2203 */
2522 2204
2523int 2205int
2524dirdiff (int dir1, int dir2) 2206dirdiff (int dir1, int dir2)
2525{ 2207{
2526 int 2208 int d;
2527 d;
2528 2209
2529 d = abs (dir1 - dir2); 2210 d = abs (dir1 - dir2);
2530 if (d > 4) 2211 if (d > 4)
2531 d = 8 - d; 2212 d = 8 - d;
2213
2532 return d; 2214 return d;
2533} 2215}
2534 2216
2535/* peterm: 2217/* peterm:
2536 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2218 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2539 * This basically means that if direction is 15, then it could either go 2221 * This basically means that if direction is 15, then it could either go
2540 * direction 4, 14, or 16 to get back to where we are. 2222 * direction 4, 14, or 16 to get back to where we are.
2541 * Moved from spell_util.c to object.c with the other related direction 2223 * Moved from spell_util.c to object.c with the other related direction
2542 * functions. 2224 * functions.
2543 */ 2225 */
2544
2545int
2546 reduction_dir[SIZEOFFREE][3] = { 2226int reduction_dir[SIZEOFFREE][3] = {
2547 {0, 0, 0}, /* 0 */ 2227 {0, 0, 0}, /* 0 */
2548 {0, 0, 0}, /* 1 */ 2228 {0, 0, 0}, /* 1 */
2549 {0, 0, 0}, /* 2 */ 2229 {0, 0, 0}, /* 2 */
2550 {0, 0, 0}, /* 3 */ 2230 {0, 0, 0}, /* 3 */
2551 {0, 0, 0}, /* 4 */ 2231 {0, 0, 0}, /* 4 */
… …
2599 * find a path to that monster that we found. If not, 2279 * find a path to that monster that we found. If not,
2600 * we don't bother going toward it. Returns 1 if we 2280 * we don't bother going toward it. Returns 1 if we
2601 * can see a direct way to get it 2281 * can see a direct way to get it
2602 * Modified to be map tile aware -.MSW 2282 * Modified to be map tile aware -.MSW
2603 */ 2283 */
2604
2605
2606int 2284int
2607can_see_monsterP (mapstruct *m, int x, int y, int dir) 2285can_see_monsterP (maptile *m, int x, int y, int dir)
2608{ 2286{
2609 sint16 2287 sint16 dx, dy;
2610 dx,
2611 dy;
2612 int
2613 mflags; 2288 int mflags;
2614 2289
2615 if (dir < 0) 2290 if (dir < 0)
2616 return 0; /* exit condition: invalid direction */ 2291 return 0; /* exit condition: invalid direction */
2617 2292
2618 dx = x + freearr_x[dir]; 2293 dx = x + freearr_x[dir];
… …
2631 return 0; 2306 return 0;
2632 2307
2633 /* yes, can see. */ 2308 /* yes, can see. */
2634 if (dir < 9) 2309 if (dir < 9)
2635 return 1; 2310 return 1;
2311
2636 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2312 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2637 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2313 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2314 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2638} 2315}
2639
2640
2641 2316
2642/* 2317/*
2643 * can_pick(picker, item): finds out if an object is possible to be 2318 * can_pick(picker, item): finds out if an object is possible to be
2644 * picked up by the picker. Returnes 1 if it can be 2319 * picked up by the picker. Returnes 1 if it can be
2645 * picked up, otherwise 0. 2320 * picked up, otherwise 0.
… …
2656 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2331 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2657 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2332 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2658 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2333 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2659} 2334}
2660 2335
2661
2662/* 2336/*
2663 * create clone from object to another 2337 * create clone from object to another
2664 */ 2338 */
2665object * 2339object *
2666object_create_clone (object *asrc) 2340object_create_clone (object *asrc)
2667{ 2341{
2668 object *
2669 dst = NULL, *tmp, *src, *part, *prev, *item; 2342 object *dst = 0, *tmp, *src, *part, *prev, *item;
2670 2343
2671 if (!asrc) 2344 if (!asrc)
2672 return NULL; 2345 return 0;
2346
2673 src = asrc; 2347 src = asrc;
2674 if (src->head) 2348 if (src->head)
2675 src = src->head; 2349 src = src->head;
2676 2350
2677 prev = NULL; 2351 prev = 0;
2678 for (part = src; part; part = part->more) 2352 for (part = src; part; part = part->more)
2679 { 2353 {
2680 tmp = get_object (); 2354 tmp = part->clone ();
2681 copy_object (part, tmp);
2682 tmp->x -= src->x; 2355 tmp->x -= src->x;
2683 tmp->y -= src->y; 2356 tmp->y -= src->y;
2357
2684 if (!part->head) 2358 if (!part->head)
2685 { 2359 {
2686 dst = tmp; 2360 dst = tmp;
2687 tmp->head = NULL; 2361 tmp->head = 0;
2688 } 2362 }
2689 else 2363 else
2690 {
2691 tmp->head = dst; 2364 tmp->head = dst;
2692 } 2365
2693 tmp->more = NULL; 2366 tmp->more = 0;
2367
2694 if (prev) 2368 if (prev)
2695 prev->more = tmp; 2369 prev->more = tmp;
2370
2696 prev = tmp; 2371 prev = tmp;
2697 } 2372 }
2698 2373
2699 /*** copy inventory ***/
2700 for (item = src->inv; item; item = item->below) 2374 for (item = src->inv; item; item = item->below)
2701 {
2702 (void) insert_ob_in_ob (object_create_clone (item), dst); 2375 insert_ob_in_ob (object_create_clone (item), dst);
2703 }
2704 2376
2705 return dst; 2377 return dst;
2706} 2378}
2707 2379
2708/* return true if the object was destroyed, 0 otherwise */
2709int
2710was_destroyed (const object *op, tag_t old_tag)
2711{
2712 /* checking for FLAG_FREED isn't necessary, but makes this function more
2713 * robust */
2714 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2715}
2716
2717/* GROS - Creates an object using a string representing its content. */ 2380/* GROS - Creates an object using a string representing its content. */
2718
2719/* Basically, we save the content of the string to a temp file, then call */ 2381/* Basically, we save the content of the string to a temp file, then call */
2720
2721/* load_object on it. I admit it is a highly inefficient way to make things, */ 2382/* load_object on it. I admit it is a highly inefficient way to make things, */
2722
2723/* but it was simple to make and allows reusing the load_object function. */ 2383/* but it was simple to make and allows reusing the load_object function. */
2724
2725/* Remember not to use load_object_str in a time-critical situation. */ 2384/* Remember not to use load_object_str in a time-critical situation. */
2726
2727/* Also remember that multiparts objects are not supported for now. */ 2385/* Also remember that multiparts objects are not supported for now. */
2728
2729object * 2386object *
2730load_object_str (const char *obstr) 2387load_object_str (const char *obstr)
2731{ 2388{
2732 object * 2389 object *op;
2733 op;
2734 char
2735 filename[MAX_BUF]; 2390 char filename[MAX_BUF];
2736 2391
2737 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2392 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2738 2393
2739 FILE *
2740 tempfile = fopen (filename, "w"); 2394 FILE *tempfile = fopen (filename, "w");
2741 2395
2742 if (tempfile == NULL) 2396 if (tempfile == NULL)
2743 { 2397 {
2744 LOG (llevError, "Error - Unable to access load object temp file\n"); 2398 LOG (llevError, "Error - Unable to access load object temp file\n");
2745 return NULL; 2399 return NULL;
2746 }; 2400 }
2401
2747 fprintf (tempfile, obstr); 2402 fprintf (tempfile, obstr);
2748 fclose (tempfile); 2403 fclose (tempfile);
2749 2404
2750 op = get_object (); 2405 op = object::create ();
2751 2406
2752 object_thawer 2407 object_thawer thawer (filename);
2753 thawer (filename);
2754 2408
2755 if (thawer) 2409 if (thawer)
2756 load_object (thawer, op, 0); 2410 load_object (thawer, op, 0);
2757 2411
2758 LOG (llevDebug, " load str completed, object=%s\n", &op->name); 2412 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
… …
2766 * returns NULL if no match. 2420 * returns NULL if no match.
2767 */ 2421 */
2768object * 2422object *
2769find_obj_by_type_subtype (const object *who, int type, int subtype) 2423find_obj_by_type_subtype (const object *who, int type, int subtype)
2770{ 2424{
2771 object *
2772 tmp;
2773
2774 for (tmp = who->inv; tmp; tmp = tmp->below) 2425 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2775 if (tmp->type == type && tmp->subtype == subtype) 2426 if (tmp->type == type && tmp->subtype == subtype)
2776 return tmp; 2427 return tmp;
2777 2428
2778 return NULL; 2429 return 0;
2779} 2430}
2780 2431
2781/* If ob has a field named key, return the link from the list, 2432/* If ob has a field named key, return the link from the list,
2782 * otherwise return NULL. 2433 * otherwise return NULL.
2783 * 2434 *
… …
2785 * do the desired thing. 2436 * do the desired thing.
2786 */ 2437 */
2787key_value * 2438key_value *
2788get_ob_key_link (const object *ob, const char *key) 2439get_ob_key_link (const object *ob, const char *key)
2789{ 2440{
2790 key_value *
2791 link;
2792
2793 for (link = ob->key_values; link != NULL; link = link->next) 2441 for (key_value *link = ob->key_values; link; link = link->next)
2794 {
2795 if (link->key == key) 2442 if (link->key == key)
2796 {
2797 return link; 2443 return link;
2798 }
2799 }
2800 2444
2801 return NULL; 2445 return 0;
2802} 2446}
2803 2447
2804/* 2448/*
2805 * Returns the value of op has an extra_field for key, or NULL. 2449 * Returns the value of op has an extra_field for key, or NULL.
2806 * 2450 *
… …
2809 * The returned string is shared. 2453 * The returned string is shared.
2810 */ 2454 */
2811const char * 2455const char *
2812get_ob_key_value (const object *op, const char *const key) 2456get_ob_key_value (const object *op, const char *const key)
2813{ 2457{
2814 key_value * 2458 key_value *link;
2815 link; 2459 shstr_cmp canonical_key (key);
2816 const char *
2817 canonical_key;
2818 2460
2819 canonical_key = shstr::find (key);
2820
2821 if (canonical_key == NULL) 2461 if (!canonical_key)
2822 { 2462 {
2823 /* 1. There being a field named key on any object 2463 /* 1. There being a field named key on any object
2824 * implies there'd be a shared string to find. 2464 * implies there'd be a shared string to find.
2825 * 2. Since there isn't, no object has this field. 2465 * 2. Since there isn't, no object has this field.
2826 * 3. Therefore, *this* object doesn't have this field. 2466 * 3. Therefore, *this* object doesn't have this field.
2827 */ 2467 */
2828 return NULL; 2468 return 0;
2829 } 2469 }
2830 2470
2831 /* This is copied from get_ob_key_link() above - 2471 /* This is copied from get_ob_key_link() above -
2832 * only 4 lines, and saves the function call overhead. 2472 * only 4 lines, and saves the function call overhead.
2833 */ 2473 */
2834 for (link = op->key_values; link != NULL; link = link->next) 2474 for (link = op->key_values; link; link = link->next)
2835 {
2836 if (link->key == canonical_key) 2475 if (link->key == canonical_key)
2837 {
2838 return link->value; 2476 return link->value;
2839 } 2477
2840 }
2841 return NULL; 2478 return 0;
2842} 2479}
2843 2480
2844 2481
2845/* 2482/*
2846 * Updates the canonical_key in op to value. 2483 * Updates the canonical_key in op to value.
… …
2853 * Returns TRUE on success. 2490 * Returns TRUE on success.
2854 */ 2491 */
2855int 2492int
2856set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2493set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2857{ 2494{
2858 key_value *
2859 field = NULL, *last = NULL; 2495 key_value *field = NULL, *last = NULL;
2860 2496
2861 for (field = op->key_values; field != NULL; field = field->next) 2497 for (field = op->key_values; field != NULL; field = field->next)
2862 { 2498 {
2863 if (field->key != canonical_key) 2499 if (field->key != canonical_key)
2864 { 2500 {
… …
2882 if (last) 2518 if (last)
2883 last->next = field->next; 2519 last->next = field->next;
2884 else 2520 else
2885 op->key_values = field->next; 2521 op->key_values = field->next;
2886 2522
2887 delete
2888 field; 2523 delete field;
2889 } 2524 }
2890 } 2525 }
2891 return TRUE; 2526 return TRUE;
2892 } 2527 }
2893 /* IF we get here, key doesn't exist */ 2528 /* IF we get here, key doesn't exist */
2894 2529
2895 /* No field, we'll have to add it. */ 2530 /* No field, we'll have to add it. */
2896 2531
2897 if (!add_key) 2532 if (!add_key)
2898 {
2899 return FALSE; 2533 return FALSE;
2900 } 2534
2901 /* There isn't any good reason to store a null 2535 /* There isn't any good reason to store a null
2902 * value in the key/value list. If the archetype has 2536 * value in the key/value list. If the archetype has
2903 * this key, then we should also have it, so shouldn't 2537 * this key, then we should also have it, so shouldn't
2904 * be here. If user wants to store empty strings, 2538 * be here. If user wants to store empty strings,
2905 * should pass in "" 2539 * should pass in ""
… …
2928 * Returns TRUE on success. 2562 * Returns TRUE on success.
2929 */ 2563 */
2930int 2564int
2931set_ob_key_value (object *op, const char *key, const char *value, int add_key) 2565set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2932{ 2566{
2933 shstr
2934 key_ (key); 2567 shstr key_ (key);
2935 2568
2936 return set_ob_key_value_s (op, key_, value, add_key); 2569 return set_ob_key_value_s (op, key_, value, add_key);
2937} 2570}
2571
2572object::depth_iterator::depth_iterator (object *container)
2573: iterator_base (container)
2574{
2575 while (item->inv)
2576 item = item->inv;
2577}
2578
2579void
2580object::depth_iterator::next ()
2581{
2582 if (item->below)
2583 {
2584 item = item->below;
2585
2586 while (item->inv)
2587 item = item->inv;
2588 }
2589 else
2590 item = item->env;
2591}
2592
2593// return a suitable string describing an objetc in enough detail to find it
2594const char *
2595object::debug_desc (char *info) const
2596{
2597 char info2[256 * 3];
2598 char *p = info;
2599
2600 p += snprintf (p, 256, "%d=\"%s%s%s\"",
2601 count,
2602 &name,
2603 title ? " " : "",
2604 title ? (const char *)title : "");
2605
2606 if (env)
2607 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2608
2609 if (map)
2610 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y);
2611
2612 return info;
2613}
2614
2615const char *
2616object::debug_desc () const
2617{
2618 static char info[256 * 3];
2619 return debug_desc (info);
2620}
2621

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines