--- deliantra/server/common/shstr.C 2006/09/03 09:00:05 1.5 +++ deliantra/server/common/shstr.C 2006/09/07 07:52:58 1.12 @@ -5,51 +5,35 @@ #include #include +#include + #include #include "shstr.h" +#include "util.h" -// NOTE: even with lots of stuff loaded, we do not usually have >>20000 strings. -// maybe refcounting is just overhead? +typedef std::tr1::unordered_set HT; -struct hash -{ - std::size_t operator ()(const char *s) const - { - unsigned long hash = 0; - unsigned int i = 0; - - /* use the one-at-a-time hash function, which supposedly is - * better than the djb2-like one used by perl5.005, but - * certainly is better then the bug used here before. - * see http://burtleburtle.net/bob/hash/doobs.html - */ - while (*s) - { - hash += *s++; - hash += hash << 10; - hash ^= hash >> 6; - } - - hash += hash << 3; - hash ^= hash >> 11; - hash += hash << 15; - - return hash; - } -}; +static HT ht; -struct equal +static const char *makevec (const char *s) { - bool operator ()(const char *a, const char *b) const - { - return !strcmp (a, b); - } -}; + int len = strlen (s); -typedef std::tr1::unordered_set HT; + const char *v = (const char *)(2 + (int *)g_slice_alloc (sizeof (int) * 2 + len + 1)); -static HT ht; + shstr::length (v) = len; + shstr::refcnt (v) = 1; + + memcpy ((char *)v, s, len + 1); + + return v; +} + +const char *shstr::null = makevec (""); + +// what weird misoptimisation is this again? +const shstr undead_name ("undead"); const char * shstr::find (const char *s) @@ -68,7 +52,7 @@ shstr::intern (const char *s) { if (!s) - return s; + return null; if (const char *found = find (s)) { @@ -76,18 +60,9 @@ return found; } - int len = strlen (s); - - const char *v = (const char *)(2 + (int *)malloc (sizeof (int) * 2 + len + 1)); - - length (v) = len; - refcnt (v) = 1; - - memcpy ((char *)v, s, len + 1); - - ht.insert (v); - - return v; + s = makevec (s); + ht.insert (s); + return s; } // periodically test refcounts == 0 for a few strings @@ -103,22 +78,25 @@ i = ht.begin (); // go through all strings roughly once every 4 minutes - for (int n = ht.size () / 256 + 16; --n; ) + int n = ht.size () / 256 + 16; + + for (;;) { if (i == ht.end ()) { curpos = 0; return; } - - if (!refcnt (*i)) + else if (!--n) + break; + else if (!refcnt (*i)) { HT::iterator o = i++; const char *s = *o; ht.erase (o); //printf ("GC %4d %3d %d >%s<%d\n", (int)ht.size (), n, shstr::refcnt (s), s, shstr::length (s)); - free (-2 + (int *)s); + g_slice_free1 (sizeof (int) * 2 + length (s) + 1, -2 + (int *)s); } else ++i;